⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 5, 2009:

11:58 PM Changeset in webkit [49155] by jorlow@chromium.org
  • 3 edits
    2 copies
    1 add in trunk/LayoutTests

2009-10-05 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Convert DOM Storage's "complex-values" test into the new format.
​https://bugs.webkit.org/show_bug.cgi?id=30097

Convert DOM Storage's "complex-values" test into the new format and add it for
session storage. This also increases the coverage of these tests a bit.

  • storage/domstorage/localstorage/complex-values-expected.txt:
  • storage/domstorage/localstorage/complex-values.html:
  • storage/domstorage/script-tests/complex-values.js: Added. (handleStorageEvent): (testKeyValue): (runTest):
  • storage/domstorage/sessionstorage/complex-values-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/complex-values-expected.txt.
  • storage/domstorage/sessionstorage/complex-values.html: Copied from LayoutTests/storage/domstorage/localstorage/complex-values.html.
11:56 PM Changeset in webkit [49154] by jorlow@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

2009-10-05 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Convert DOM Storage's "complex-keys" test into the new format
​https://bugs.webkit.org/show_bug.cgi?id=30089

Convert DOM Storage's "complex-keys" test into the new format and add it for
session storage. This test should be a bit more thorough than the old
version as well.

  • storage/domstorage/localstorage/complex-keys-expected.txt:
  • storage/domstorage/localstorage/complex-keys.html:
  • storage/domstorage/script-tests/complex-keys.js: Added. (runTest):
  • storage/domstorage/sessionstorage/complex-keys-expected.txt: Added.
  • storage/domstorage/sessionstorage/complex-keys.html: Added.
10:58 PM Changeset in webkit [49153] by krit@webkit.org
  • 4 edits
    4 adds in trunk

2009-10-05 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filters do not support source images besides "sourceGraphic"
​https://bugs.webkit.org/show_bug.cgi?id=6022

Add support for SourceAlpha to SVG filters.

Test: svg/filters/sourceAlpha.svg

  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::calculateEffectRect): (WebCore::SourceAlpha::apply):
  • platform/graphics/filters/SourceAlpha.h:

Test for SVG's SourceAlpha support for Filters.

  • platform/mac/svg/filters/sourceAlpha-expected.checksum: Added.
  • platform/mac/svg/filters/sourceAlpha-expected.png: Added.
  • platform/mac/svg/filters/sourceAlpha-expected.txt: Added.
  • svg/filters/sourceAlpha.svg: Added.
10:39 PM WebKit Team edited by jam@chromium.org
(diff)
10:13 PM Changeset in webkit [49152] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Rubber-stamped by Mark Rowe.

Moved a WebPluginHalterClient out of the WebCore namesapce.

  • WebCoreSupport/WebPluginHalterClient.h:
10:07 PM Changeset in webkit [49151] by kevino@webkit.org
  • 4 edits in trunk

wx libjpeg link fix and JSC build fix.

9:58 PM Changeset in webkit [49150] by Simon Fraser
  • 21 edits
    4 adds in trunk/LayoutTests

2009-10-05 Simon Fraser <Simon Fraser>

Updated results for media tests after controller change to add the fullscreen button.

  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.checksum: Added.
  • platform/mac/media/controls-after-reload-expected.png: Added.
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.checksum:
  • platform/mac/media/controls-styling-expected.png:
  • platform/mac/media/controls-styling-expected.txt:
  • platform/mac/media/video-aspect-ratio-expected.checksum:
  • platform/mac/media/video-aspect-ratio-expected.png:
  • platform/mac/media/video-empty-source-expected.checksum:
  • platform/mac/media/video-empty-source-expected.png:
  • platform/mac/media/video-empty-source-expected.txt:
  • platform/mac/media/video-no-audio-expected.checksum:
  • platform/mac/media/video-no-audio-expected.png:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-transformed-expected.checksum:
  • platform/mac/media/video-transformed-expected.png:
  • platform/mac/media/video-zoom-controls-expected.checksum: Added.
  • platform/mac/media/video-zoom-controls-expected.png: Added.
  • platform/mac/media/video-zoom-controls-expected.txt:
  • platform/mac/media/video-zoom-expected.checksum:
  • platform/mac/media/video-zoom-expected.png:
9:58 PM Changeset in webkit [49149] by kdecker@apple.com
  • 8 edits
    2 adds in trunk/WebKit

Reviewed by Dan Bernstein.

Added new PluginHalter client, delegate and few more WebPreferences keys.

  • WebView/WebPreferenceKeysPrivate.h: Added two new keys.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Initialize newly added key. (-[WebPreferences pluginAllowedRunTime]): Added. (-[WebPreferences setPluginAllowedRunTime:]): Added.
  • WebView/WebPreferencesPrivate.h: Added above two methods.
  • WebView/WebUIDelegatePrivate.h: Added shouldHaltPlugin delegate.
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Setup a new WebPluginHalterClient. (-[WebView _preferencesChangedNotification:]): Update WebCore settings accordingly.
  • WebCoreSupport/WebPluginHalterClient.h: Added.
  • WebCoreSupport/WebPluginHalterClient.mm: Added. (WebPluginHalterClient::WebPluginHalterClient): (WebPluginHalterClient::shouldHaltPlugin): Added, invoke the delegate.
9:55 PM Changeset in webkit [49148] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-10-05 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Adam Barth.

Fix reliablity bot crash in DateExtension.
​https://bugs.webkit.org/show_bug.cgi?id=30033

There were a few problems using the weak persistent pointers because no one else had a
handle to them. The new approach stores them as a hidden value on the Date constructor.

  • bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep): (WebCore::DateExtension::GetNativeFunction): (WebCore::DateExtension::Setup): (WebCore::DateExtension::OnSleepDetected):
  • bindings/v8/DateExtension.h:
  • bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::sleepFunction):
  • bindings/v8/V8HiddenPropertyName.h:
9:40 PM Changeset in webkit [49147] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <Simon Fraser>

More build fixes for Tiger.

  • WebView/WebVideoFullscreenController.mm:
9:17 PM Changeset in webkit [49146] by Simon Fraser
  • 3 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <Simon Fraser>

More build fixes for Tiger.

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenWindow animationDidEnd:]):
  • WebView/WebWindowAnimation.m:
9:17 PM Changeset in webkit [49145] by Stephanie Lewis
  • 2 edits in trunk/WebCore

Crash when trying to load a null stylesheet for a site specific hack.
​https://bugs.webkit.org/show_bug.cgi?id=30105

Reviewed by Dan Bernstein.

Created a testcase and tested in browser. DRT doesn't test
site specific hacks.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

9:12 PM Changeset in webkit [49144] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-05 James Robinson <​jamesr@google.com>

Reviewed by Darin Adler.

Fix forward declaration (struct vs class mismatch)

​https://bugs.webkit.org/show_bug.cgi?id=30094

  • loader/RedirectScheduler.h:
8:58 PM Changeset in webkit [49143] by Simon Fraser
  • 3 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <Simon Fraser>

More build fixes for Tiger.

  • WebView/WebVideoFullscreenController.mm:
  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): (-[WebVideoFullscreenHUDWindowController fadeWindowIn]): (-[WebVideoFullscreenHUDWindowController fadeWindowOut]): (-[WebVideoFullscreenHUDWindowController closeWindow]):
6:53 PM Changeset in webkit [49142] by jparent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, last Chromium build fix corresponding to revision 49113.
Add include for BeforeLoadEvent to DOMObjectsInclude.h.

Patch by Julie Parent <​jparent@chromium.org> on 2009-10-05

  • bindings/v8/DOMObjectsInclude.h:
6:47 PM Changeset in webkit [49141] by eric@webkit.org
  • 2 edits in trunk/WebKit

2009-10-05 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Dimitri Glazkov.

One of the dependencies' SVN url was missing a @ before the revision number.

​https://bugs.webkit.org/show_bug.cgi?id=30101

  • chromium/DEPS:
6:21 PM Changeset in webkit [49140] by Simon Fraser
  • 3 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <Simon Fraser>

Build fixes for Tiger.

  • WebView/WebVideoFullscreenHUDWindowController.h:
  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): (-[WebVideoFullscreenHUDWindowController dealloc]): (-[WebVideoFullscreenHUDWindowController closeWindow]): (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
6:05 PM Changeset in webkit [49139] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-10-05 Simon Fraser <Simon Fraser>

Build fix. If you call Node::hasTagName(), you also have to include Element.h.

  • WebCoreSupport/WebChromeClient.mm:
5:43 PM Changeset in webkit [49138] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-10-05 Simon Fraser <Simon Fraser>

Fix Windows build.

  • html/HTMLMediaElement.cpp:
5:40 PM Changeset in webkit [49137] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-10-05 Simon Fraser <Simon Fraser>

Fix the build: MediaControllerThemeQT was renamed to MediaControllerThemeQuickTime.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
5:24 PM Changeset in webkit [49136] by Simon Fraser
  • 31 edits
    7 adds in trunk

2009-10-05 Pierre d'Herbemont <​pdherbemont@webkit.org>

Reviewed by Simon Fraser

Support fullscreen in MediaPlayer (Mac)
​https://bugs.webkit.org/show_bug.cgi?id=26742

Add a fullscreen button to the <video> controller if the media engine,
and the theme have support for fullscreen, and can show appropriate controls.
Clicking the button calls through the ChromeClient to the WebVideoFullscreenController
in WebKit to do a nice animation to fullscreen, with a custom controller.

5:21 PM Changeset in webkit [49135] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Export a few more methods from Settings.h


Rubberstamped by Jon Honeycutt.


  • WebCore.base.exp:
5:03 PM Changeset in webkit [49134] by dimich@chromium.org
  • 2 edits in trunk/WebCore

1-char fix for obviously reverse condition.
​https://bugs.webkit.org/show_bug.cgi?id=30100
No test since the only difference is a timing of GC.

Reviewed by Darin Adler.

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::clear): Revert condition. Almost a typo.

5:00 PM Changeset in webkit [49133] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

WebKit side of <rdar://problem/7179166>

Reviewed by Kevin Decker.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:

Add an m_pluginIsWaitingForDraw member variable.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Initialize m_pluginIsWaitingForDraw.

(WebKit::NetscapePluginInstanceProxy::invalidateRect):
Set m_pluginIsWaitingForDraw to true.

(WebKit::NetscapePluginInstanceProxy::didDraw):
If m_pluginIsWaitingForDraw is true, call _WKPHPluginInstanceDidDraw.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView drawRect:]):
Call didDraw.

  • Plugins/Hosted/WebKitPluginHost.defs:

Add PHPluginInstanceDidDraw.

4:57 PM Changeset in webkit [49132] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-09-30 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Update platform-specific #ifdefs in GraphicsContext3D.h for the
Chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=29936

  • platform/graphics/GraphicsContext3D.h: Changed #if PLATFORM(SKIA) to #if PLATFORM(CHROMIUM).
4:37 PM Changeset in webkit [49131] by mitz@apple.com
  • 3 edits
    4 adds in trunk

REGRESSION (r47440): Inserting text in the middle of content in a scrolled textfield results in painting bugs
<rdar://problem/7269108>
​https://bugs.webkit.org/show_bug.cgi?id=29982

Reviewed by Darin Adler.

WebCore:

Test: fast/repaint/line-in-scrolled-clipped-block.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): Use the unclipped overflow rect
(including layout overflow) for the repaint rect calculation.

LayoutTests:

  • fast/repaint/line-in-scrolled-clipped-block.html: Added.
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.checksum: Added.
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.
4:34 PM Changeset in webkit [49130] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-10-05 Drew Wilson <​atwilson@google.com>

Reviewed by David Levin.

Chromium wants to turn off SharedWorkers at runtime
​https://bugs.webkit.org/show_bug.cgi?id=29757

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::sharedWorker): Now returns jsUndefined if isAvailable() returns false, to allow SharedWorkers to be disabled at runtime.
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerRepository::isAvailable): Made SharedWorkers available by default.
  • workers/SharedWorkerRepository.h: Added definition for SharedWorkerRepository::isAvailable().
4:26 PM Changeset in webkit [49129] by eric@webkit.org
  • 4 edits
    4 adds in trunk

2009-10-05 Hironori Bono <​hbono@chromium.org>

Reviewed by Eric Seidel.

A super quick fix for Bug 28710.

​https://bugs.webkit.org/show_bug.cgi?id=28710

This change just resets the style sent to addStyleMarkup() to avoid an assertion error
and creates an empty style when computedStyleAtPosition is 0 to avoid a crash.
(This change is nothing but a better-than-crash change.)

  • editing/selection/select-crash-001-expected.txt: Added.
  • editing/selection/select-crash-001.html: Added.
  • editing/selection/select-crash-002-expected.txt: Added.
  • editing/selection/select-crash-002.html: Added.

2009-10-05 Hironori Bono <​hbono@chromium.org>

Reviewed by Eric Seidel.

A super quick fix for Bug 28710.

​https://bugs.webkit.org/show_bug.cgi?id=28710

This change just resets the style sent to addStyleMarkup() to avoid an assertion error
and creates an empty style when computedStyleAtPosition is 0 to avoid a crash.
(This change is nothing but a better-than-crash change.)

Tests: editing/selection/select-crash-001.html

editing/selection/select-crash-002.html

  • editing/ApplyStyleCommand.cpp: (WebCore::editingStyleAtPosition): Resets the style sent to addStyleMarkup() if it is not valid.
  • editing/markup.cpp: (WebCore::createMarkup): Creates an empty style if computedStyleAtPosition is 0.
4:18 PM Changeset in webkit [49128] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-05 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Remove precompiled header from JavaScriptCore compilation to
prevent qmake warning during autonomous compilation.
​https://bugs.webkit.org/show_bug.cgi?id=30069

4:10 PM Changeset in webkit [49127] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-05 Julie Parent <​jparent@chromium.org>

Reviewed by Darin Adler.

Make LayoutTests/editing/selection/hit-test-anonymous.html resistant to
GDI/CG differences, by increasing the font size so the slight
difference in fonts doesn't result in a different character clicked.
​https://bugs.webkit.org/show_bug.cgi?id=29985

  • editing/selection/hit-test-anonymous.html:
4:10 PM Changeset in webkit [49126] by weinig@apple.com
  • 2 edits in trunk/WebCore

Silence duplicate errors logged for missing getComputedStyle
implementations. Improves the error message as well.

Reviewed by Mark Rowe.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::logUnimplementedPropertyID):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

4:03 PM Changeset in webkit [49125] by jparent@chromium.org
  • 3 edits in trunk/WebCore

Unreviewed, Chromium build fix #3. Add V8BeforeLoadEvent.[cc|h] to derived sources.

Patch by Julie Parent <​jparent@chromium.org> on 2009-10-05

  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
4:03 PM Changeset in webkit [49124] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-05 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

Add screenshot option to menubar

​https://bugs.webkit.org/show_bug.cgi?id=30067

  • QtLauncher/main.cpp: (MainWindow::screenshot): (MainWindow::setupUI):
3:49 PM Changeset in webkit [49123] by cmarrin@apple.com
  • 1 edit in trunk/WebKitSite/blog-files/webgl/WebGL+CSS.html

Another change to one of the WebGL blog post demos

3:45 PM Changeset in webkit [49122] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-10-05 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

Setting the env QTLAUNCHER_USE_ARGB_VISUALS makes Qt use WA_TranslucentWindow.

​https://bugs.webkit.org/show_bug.cgi?id=30068

  • QtLauncher/main.cpp: (MainWindow::MainWindow):
3:44 PM Changeset in webkit [49121] by cmarrin@apple.com
  • 7 edits in trunk/WebKitSite/blog-files/webgl

Fixed some tests for WebGL blog post

3:41 PM Changeset in webkit [49120] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Try and fix the GTK build.

  • GNUmakefile.am:
3:37 PM Changeset in webkit [49119] by cmarrin@apple.com
  • 17 adds in trunk/WebKitSite/blog-files/webgl

Added files for WebGL blog post

3:37 PM Changeset in webkit [49118] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-05 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] EventSender::keyDown() cannot send function-key events.
​https://bugs.webkit.org/show_bug.cgi?id=30044

This affects the fast/events/keydown-function-keys.html layout test.

  • DumpRenderTree/qt/jsobjects.cpp: (EventSender::keyDown):
3:31 PM Changeset in webkit [49117] by jparent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, Chromium build fix #2. Add new BEFORELOADEVENT to V8ClassIndex.

Patch by Julie Parent <​jparent@chromium.org> on 2009-10-05

  • bindings/v8/V8Index.h:
3:07 PM Changeset in webkit [49116] by jparent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, Chromium build fix. Missing "," after entry for BeforeLoadEvent.idl.

Patch by Julie Parent <​jparent@chromium.org> on 2009-10-05

  • WebCore.gypi:
3:04 PM Changeset in webkit [49115] by hyatt@apple.com
  • 4 edits in trunk/LayoutTests

Update layout tests to account for the new beforeload event object.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
2:28 PM Changeset in webkit [49114] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.pro

Fix Qt bustage.

2:16 PM Changeset in webkit [49113] by hyatt@apple.com
  • 8 edits
    2 adds in trunk/WebCore

Add a beforeload event that will be fired before subresources load. (It isn't fired yet.) The event
has one field, the URL that is going to be requested. Setting preventDefault will stop the load
from occurring.

Reviewed by Sam Weinig.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/BeforeLoadEvent.h: Added.

(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::initBeforeLoadEvent):
(WebCore::BeforeLoadEvent::url):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):

  • dom/BeforeLoadEvent.idl: Added.
  • dom/EventNames.h:
  • page/DOMWindow.idl:
2:07 PM Changeset in webkit [49112] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-05 Priit Laes <​plaes@plaes.org>

Reviewed by Gustavo Noronha.

Add Gentoo-specific paths for searching browser plugins.
​https://bugs.webkit.org/show_bug.cgi?id=30088

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::defaultPluginDirectories):
1:46 PM Changeset in webkit [49111] by cmarrin@apple.com
  • 7 edits in trunk

Add functionality to pause/throttle CSS transitions/animations in a WebView
​https://bugs.webkit.org/show_bug.cgi?id=29942

1:44 PM Changeset in webkit [49110] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-10-05
Remove test that I forgot in earlier commit.

  • platform/qt/Skipped:
1:23 PM Changeset in webkit [49109] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-10-05 Vadim Zeitlin <​vadim@wxwidgets.org>

Added --wx-compiler-prefix waf option to allow building wxWebKit with
wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".

  • wx/build/settings.py:
  • wx/build/wxpresets.py:
1:06 PM Changeset in webkit [49108] by kdecker@apple.com
  • 3 edits in trunk/WebCore

Rubberstamped by Anders Carlsson.


  • WebCore.base.exp: Update export of HaltablePlugin/PluginHalterClient.
  • WebCore.xcodeproj/project.pbxproj: Likewise.
12:07 PM Changeset in webkit [49107] by eric@webkit.org
  • 8 edits
    15 deletes in trunk

2009-10-05 Eric Seidel <​eric@webkit.org>

No review, rolling out r49104.
​http://trac.webkit.org/changeset/49104

  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-number.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-range.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
  • fast/forms/input-minmax-expected.txt: Removed.
  • fast/forms/input-minmax.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
  • fast/forms/script-tests/input-minmax.js: Removed.

2009-10-05 Eric Seidel <​eric@webkit.org>

No review, rolling out r49104.
​http://trac.webkit.org/changeset/49104

  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/ValidityState.cpp:
  • html/ValidityState.h: (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow):
  • rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::valueFromElement):
11:57 AM Changeset in webkit [49106] by kdecker@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by Sam Weinig.

<rdar://problem/7273363> Plug-ins should use PluginHalter


  • Plugins/WebBaseNetscapePluginView.h: Add WebHaltablePlugin forward declare and _haltable ivar.
  • Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::WebHaltablePlugin): Added. (WebHaltablePlugin::halt): New method that stops a plug-in. (WebHaltablePlugin::restart): New method that starts a plug-in. (WebHaltablePlugin::node): Added. Provides the DOMNode corresponding to the plug-in in WebBaseNetscapePluginView. (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): Initialize new _haltable ivar. (-[WebBaseNetscapePluginView start]): Call the page's didStartPlugin() upon starting a plug-in. (-[WebBaseNetscapePluginView stop]): Call the page's didStopPlugin() upon stopping a plug-in.
11:23 AM Changeset in webkit [49105] by eric@webkit.org
  • 7 edits
    7 adds in trunk

2009-10-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Tests to check if validation-related CSS selectors are applied immediately.
​https://bugs.webkit.org/show_bug.cgi?id=28868

  • fast/forms/input-live-pseudo-selectors-expected.txt: Added.
  • fast/forms/input-live-pseudo-selectors.html: Added.
  • fast/forms/resources/input-live-pseudo-selectors.js: Added.
  • fast/forms/resources/live-pseudo-selectors.css: Added.
  • fast/forms/resources/textarea-live-pseudo-selectors.js: Added.
  • fast/forms/textarea-live-pseudo-selectors-expected.txt: Added.
  • fast/forms/textarea-live-pseudo-selectors.html: Added.

2009-10-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Update style immediately when validation-related values are updated.
​https://bugs.webkit.org/show_bug.cgi?id=28868

In order to apply :valid, :invalid, :optional or :required lively,

  • call setNeedsStyleRecalc() when properties which can change willValidate state are updated, and

(Parent form element, name, disabled, readonly)

  • call updateValidity() when properties which can change validity state are updated. (value, pattern, required)

Tests: fast/forms/input-live-pseudo-selectors.html

fast/forms/textarea-live-pseudo-selectors.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::required): (WebCore::HTMLFormControlElement::updateValidity):
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
11:14 AM Changeset in webkit [49104] by eric@webkit.org
  • 8 edits
    15 adds in trunk

2009-10-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Implement min/max attributes, ValidityState.rangeUnderflow and
ValidityState.rangeOverflow for <input type=number> and <input type=range>
​https://bugs.webkit.org/show_bug.cgi?id=29069

  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-number.html: Added.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-range.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Added.
  • fast/forms/input-minmax-expected.txt: Added.
  • fast/forms/input-minmax.html: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Added.
  • fast/forms/script-tests/input-minmax.js: Added.

2009-10-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Implement min/max attributes, ValidityState.rangeUnderflow and
ValidityState.rangeOverflow for <input type=number> and <input type=range>
​https://bugs.webkit.org/show_bug.cgi?id=29069

Tests: fast/forms/ValidityState-rangeOverflow-number.html

fast/forms/ValidityState-rangeOverflow-range.html
fast/forms/ValidityState-rangeUnderflow-number.html
fast/forms/ValidityState-rangeUnderflow-range.html
fast/forms/input-minmax.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): (WebCore::HTMLInputElement::rangeOverflow): (WebCore::HTMLInputElement::rangeMinimum): (WebCore::HTMLInputElement::rangeMaximum):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/ValidityState.cpp: (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow):
  • html/ValidityState.h:
  • rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::valueFromElement):
11:05 AM Changeset in webkit [49103] by eric@webkit.org
  • 13 edits
    2 adds in trunk

2009-10-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Tests for -webkit-appearance:list-button
​https://bugs.webkit.org/show_bug.cgi?id=27794

  • platform/mac/fast/forms/input-list-button-size-expected.txt: Added.
  • platform/mac/fast/forms/input-list-button-size.html: Added.

2009-10-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Introduces

  • new CSS pseudo selector: "-webkit-input-list-button"
  • new CSS apperance type: "list-button"
  • new ControlPart value: "ListButtonPart"

for the UI of the list attribute of the input element, and adds
implementation to draw ListButtonPart on Mac.
The code is guarded by ENABLE(DATALIST).

​https://bugs.webkit.org/show_bug.cgi?id=27794

Test: platform/mac/fast/forms/input-list-button-size.html

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • css/CSSValueKeywords.in:
  • css/html.css:
  • html/HTMLInputElement.cpp:
  • platform/ThemeTypes.h: (WebCore::):
  • platform/mac/ThemeMac.mm: (WebCore::listButtonSizes): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeMac::controlSize): (WebCore::ThemeMac::minimumControlSize): (WebCore::ThemeMac::controlBorder): (WebCore::ThemeMac::paint):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect):
  • rendering/style/RenderStyleConstants.h: (WebCore::):
11:00 AM Changeset in webkit [49102] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-10-05
Add documentation to the ErrorPageExtension.

  • Api/qwebpage.cpp:
10:39 AM Changeset in webkit [49101] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-10-05 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Fixes <​https://bugs.webkit.org/show_bug.cgi?id=30065>
nodeTitleInfo should be placed in ElementsTreeOutline.


Move nodeTitleInfo into ElementsTreeOutline.js from utilities.js.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
  • inspector/front-end/utilities.js:
10:36 AM Changeset in webkit [49100] by yael.aharon@nokia.com
  • 6 edits in trunk

[Qt] Inform the application when a new request is created
​https://bugs.webkit.org/show_bug.cgi?id=29975

Patch by Yael Aharon <​yael.aharon@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

WebCore:

Emit a signal each time a request is created, with the request and the frame
that created it.

WebKit/qt:

Add a signal to QWebPage, to inform the application when a request is created.

10:30 AM Changeset in webkit [49099] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-05 Ben Murdoch <​benm@google.com>

Reviewed by Darin Adler.

Add an ASSERT in updateGuidVersionMap.
​https://bugs.webkit.org/show_bug.cgi?id=30077

  • storage/Database.cpp: (WebCore::updateGuidVersionMap): ASSERT that the guidMutex() is locked.
10:15 AM Changeset in webkit [49098] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-10-05 Nate Chapin <Nate Chapin>

Reviewed by Eric Seidel.

Allow V8 to throw an exception in _NPN_SetException without worrying about context
if we don't have enough information to find the correct context.

​https://bugs.webkit.org/show_bug.cgi?id=30026

Part of the fix for Chromium's failure of LayouTests/plugins/netscape-throw-exception.html.

  • bindings/v8/NPV8Object.cpp: (_NPN_SetException): Don't suppress the exception if we can't find the relevant context.
9:03 AM Changeset in webkit [49097] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-10-01 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Place "Close" button in docked mode on the same side as the window "Close" button in detached mode.

​https://bugs.webkit.org/show_bug.cgi?id=29961

  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
8:11 AM Changeset in webkit [49096] by kenneth@webkit.org
  • 3 edits in trunk/WebKit/qt

ErrorPageExtension: Add a pointer to the QWebFrame that had
an error.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-10-05
Reviewed by Simon Hausmann.

  • Api/qwebpage.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::callErrorPageExtension):

8:01 AM Changeset in webkit [49095] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Do not empty the offline web appcache when clearing
memory caches. That one is not in memory, but stored
in sqlite.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2009-10-05
Reviewed by Tor Arne Vestbø.

  • Api/qwebsettings.cpp:

(QWebSettings::clearMemoryCaches):

7:36 AM Changeset in webkit [49094] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Re-enable fast/table/008.html

7:08 AM Changeset in webkit [49093] by kenneth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[Qt] Add expected files for passing fast/table tests.

Patch by Andras Becsi <​becsi.andras@stud.u-szeged.hu> on 2009-10-05
Reviewed by Ariya Hidayat.

  • platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt: Added.
  • platform/qt/fast/table/fixed-table-with-small-percent-width-expected.txt: Added.
7:03 AM Changeset in webkit [49092] by Simon Hausmann
  • 6 edits in trunk

WebCore: [Qt] Added pure virtual QWebPageClient::pluginParent()

Patch by J-P Nurmi <​jpnurmi@gmail.com> on 2009-10-05
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=29710

  • platform/qt/QWebPageClient.h:

WebKit/qt: Added QGraphicsWidget-plugins support to FrameLoaderClientQt.

Patch by J-P Nurmi <​jpnurmi@gmail.com> on 2009-10-05
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=29710

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::pluginParent):

  • Api/qwebview.cpp:

(QWebViewPrivate::pluginParent):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::):
(WebCore::FrameLoaderClientQt::createPlugin):

7:03 AM Changeset in webkit [49091] by pfeldman@chromium.org
  • 19 edits
    2 adds in trunk

2009-10-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add testing harness for Web Inspector.

​https://bugs.webkit.org/show_bug.cgi?id=30010

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

WebKit/win:

  • Interfaces/IWebInspectorPrivate.idl: Added.
  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebInspector.cpp: (WebInspector::evaluateInFrontend):
  • WebInspector.h:
  • WebView.cpp: (WebView::inspectorPrivate):
  • WebView.h:

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp: (showWebInspectorCallback): (closeWebInspectorCallback): (evaluateInWebInspectorCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
6:25 AM Changeset in webkit [49090] by zoltan@webkit.org
  • 2 edits in trunk

2009-10-05 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Disable TCmalloc for Windows port at the present, because MinGW
hasn't got built-in pthread library.

  • WebKit.pri:
3:57 AM Changeset in webkit [49089] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-10-05 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Tor Arne Vestbø.

[Qt] windowsKeyCodeForKeyEvent() returns a wrong value for the F10 key.
​https://bugs.webkit.org/show_bug.cgi?id=30042

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
3:48 AM Changeset in webkit [49088] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

Pass arguments to system() as a string instead of array

Reviewed by Ariya Hidayat.

When passed as an array entries with a space fail to translate
to two arguments to the child process, so instead of manually
splitting all the entries in @buildArgs we pass the whole thing
as a string instead.

  • Scripts/webkitdirs.pm:
2:31 AM Changeset in webkit [49087] by vestbo@webkit.org
  • 4 edits
    1 copy
    1 delete in trunk/WebCore

Move mediaControls extras for the Qt port into WebCore/css like other ports

​https://bugs.webkit.org/show_bug.cgi?id=30013

Reviewed by Eric Carlson.

2:17 AM Changeset in webkit [49086] by ukai@chromium.org
  • 2 edits in trunk/WebCore

2009-10-05 Fumitoshi Ukai <​ukai@chromium.org>

Unreviewed build fix for ENABLE(WEB_SOCKETS) and v8.

V8ObjectEventListener.h has been removed at r48978

  • bindings/v8/custom/V8WebSocketCustom.cpp:
2:06 AM Changeset in webkit [49085] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector console stops working while JS in IFRAME is paused.

​https://bugs.webkit.org/show_bug.cgi?id=29958

  • inspector/front-end/InjectedScript.js: (InjectedScript._evaluateOn): (InjectedScript.addInspectedNode): (InjectedScript._ensureCommandLineAPIInstalled):
1:56 AM Changeset in webkit [49084] by pfeldman@chromium.org
  • 13 edits in trunk/WebCore

2009-10-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce inspected object groups for console
and watch evaluation results so that they could be released
explicitly.

​https://bugs.webkit.org/show_bug.cgi?id=29891

  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::wrapObject):
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::wrapObject): (WebCore::InspectorBackend::releaseWrapperObjectGroup):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::wrapObject): (WebCore::InspectorController::unwrapObject): (WebCore::InspectorController::releaseWrapperObjectGroup):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addMessageToConsole):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed):
  • inspector/front-end/InjectedScript.js: (InjectedScript.evaluate): (InjectedScript._evaluateAndWrap): (InjectedScript.evaluateInCallFrame):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSection.prototype.update):
1:42 AM Changeset in webkit [49083] by vestbo@webkit.org
  • 4 edits
    1 move in trunk/WebCore

Rename WebCore/css/mediaControlsQT.css and MediaControllerThemeQT

​https://bugs.webkit.org/show_bug.cgi?id=30013

Reviewed by Eric Carlson.

The QT suffix has been expanded to QuickTime, to not cause confusion
and name-crashes with similar files in the Qt port.

Oct 4, 2009:

10:27 PM Changeset in webkit [49082] by bweinstein@apple.com
  • 7 edits
    1 add in trunk/WebCore

2009-10-04 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Timothy Hatcher.


Fixes <​https://bugs.webkit.org/show_bug.cgi?id=30064>
Syntax Highlighting CSS shouldn't be duplicated.

Refactor syntax highlighting CSS into a new file, add it to the
projects, and have SourceFrame.js and inspector.html include the
new CSS file.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspectorSyntaxHighlight.css: Added.
  • inspector/front-end/WebKit.qrc:
9:16 PM Changeset in webkit [49081] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

2009-10-04 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Timothy Hatcher.


Fixes <​https://bugs.webkit.org/show_bug.cgi?id=30062>
Inspector should syntax highlight JS/CSS in elements view.

Add syntax highlighting of CSS and JavaScript tags to the elements panel.
Copied CSS rules from SourceFrame.js to inspector.css, and have the text nodes
in utilities.js call the CSS or JS Syntax highlighters if their parent is a script
or style tag.

  • inspector/front-end/inspector.css:
  • inspector/front-end/utilities.js:
7:52 PM Changeset in webkit [49080] by ukai@chromium.org
  • 4 edits in trunk

2009-10-04 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Eric Seidel

Enable Web Sockets in chromium build.
​https://bugs.webkit.org/show_bug.cgi?id=29917

  • WebCore.gyp/WebCore.gyp:

2009-10-04 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Eric Seidel

Enable Web Sockets in chromium build.
​https://bugs.webkit.org/show_bug.cgi?id=29917

  • chromium/features.gypi:
4:43 PM Changeset in webkit [49079] by kdecker@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Cameron Zwarich.

  • WebView/WebPreferenceKeysPrivate.h: Added new key.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Leave plug-in halting disabled by default. (-[WebPreferences pluginHalterEnabled]): Added. (-[WebPreferences setPluginHalterEnabled:]): Ditto.
  • WebView/WebPreferencesPrivate.h: Added above new methods.
2:12 PM Changeset in webkit [49078] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-10-04 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by David Levin.

check-webkit-style misses whitespace errors for operators:

<<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&,
.

​https://bugs.webkit.org/show_bug.cgi?id=30021

  • Scripts/modules/cpp_style.py: Added the operators mentioned above to the same list as == and !=.
1:01 PM Changeset in webkit [49077] by xan@webkit.org
  • 5 edits
    4 adds in trunk

WebCore:

2009-10-01 Xan Lopez <​xlopez@igalia.com>

Reviewed by NOBODY (OOPS!).

[GTK] performs a POST when refreshing a view that was obtained with a GET
​https://bugs.webkit.org/show_bug.cgi?id=29761

Update the HTTP method in the request stored by willSendRequest
after a redirect, since it could have changed.

Test: http/tests/navigation/postredirect-reload.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):

LayoutTests:

2009-10-01 Xan Lopez <​xlopez@igalia.com>

Reviewed by NOBODY (OOPS!).

[GTK] performs a POST when refreshing a view that was obtained with a GET
​https://bugs.webkit.org/show_bug.cgi?id=29761

New test that checks that a reload after a redirect to a page with
a GET method from one with a POST method will use GET and not
POST.

  • http/tests/navigation/postredirect-reload-expected.txt: Added.
  • http/tests/navigation/postredirect-reload.html: Added.
  • http/tests/navigation/resources/postresult.pl:
  • http/tests/navigation/resources/reloadresult.pl: Added.
  • http/tests/navigation/resources/redirect-reload.html: Added.
  • http/tests/navigation/resources/success200.html:
  • http/tests/navigation/resources/testcode.js: (submitFormWithPostRedirectReload): (runRedirectReloadTest):
11:14 AM Changeset in webkit [49076] by xan@webkit.org
  • 6 edits
    3 deletes in trunk

Revert previous patch, as the newly added test breaks other tests.

10:17 AM Changeset in webkit [49075] by xan@webkit.org
  • 6 edits
    3 adds in trunk

WebCore:

2009-10-04 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] performs a POST when refreshing a view that was obtained with a GET
​https://bugs.webkit.org/show_bug.cgi?id=29761

Update the HTTP method in the request stored by willSendRequest
after a redirect, since it could have changed.

Test: http/tests/navigation/postredirect-reload.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):

LayoutTests:

2009-10-04 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] performs a POST when refreshing a view that was obtained with a GET
​https://bugs.webkit.org/show_bug.cgi?id=29761

New test that checks that a reload after a redirect to a page with
a GET method from one with a POST method will use GET and not
POST.

  • http/tests/navigation/postredirect-reload-expected.txt: Added.
  • http/tests/navigation/postredirect-reload.html: Added.
  • http/tests/navigation/resources/postresult.pl:
  • http/tests/navigation/resources/reloadresult.pl: Added.
  • http/tests/navigation/resources/success200.html:
  • http/tests/navigation/resources/testcode.js: (submitFormWithPostRedirectReload): (runRedirectReloadTest):
10:12 AM Changeset in webkit [49074] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-10-04 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Fixed Function leak in V8LazyEventListener.
(Should fix the remaning leak in
​https://bugs.webkit.org/show_bug.cgi?id=29093).
V8LazyEventListeners used to create FunctionTemplates for each
wrapped listener which in turn created Functions that were cached
forever in V8 Context. Now there is at most one such Function per
Context.
​https://bugs.webkit.org/show_bug.cgi?id=30060

Added new hidden property name to store toString result:

  • bindings/v8/V8HiddenPropertyName.cpp:
  • bindings/v8/V8HiddenPropertyName.h:

Switched to static FunctionTemplate:

  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListenerToString): (WebCore::V8LazyEventListener::prepareListenerObject):
Note: See TracTimeline for information about the timeline view.