Context Navigation

← Previous Period
Next Period →

Timeline

Oct 7, 2009:

11:57 PM Changeset in webkit [49292] by dbates@webkit.org

2 edits in trunk/WebCore

2009-10-07 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30188

Fixes an issue where performing a non DHTML drag-and-drop operation
does not work as expected. For instance, dragging some selected text
to an external application, such as TextEdit.

This issue was a regression that arose from patching bug #30107.

This change is covered by the manual test:
drag-out-of-background-window.html

page/DragController.cpp: (WebCore::DragController::startDrag): When performing a non-DHTML drag operation then default to drag operations DragOperationGeneric and DragOperationCopy according to similar functionality removed when fixing bug #30107, see: http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebHTMLView.mm?rev=48526#L3430

11:29 PM Changeset in webkit [49291] by xan@webkit.org

2 edits in trunk/WebCore

2009-10-07 Xan Lopez <xlopez@igalia.com>

Fix more breakage in the GTK+ build.

GNUmakefile.am:

11:17 PM Changeset in webkit [49290] by abarth@webkit.org

8 edits
4 adds
2 deletes in trunk/WebCore

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move PolicyChecker to it's own file
https://bugs.webkit.org/show_bug.cgi?id=30193

This is just moving code around and re-naming things.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
loader/FrameLoader.cpp:
loader/FrameLoader.h:
loader/PolicyCallback.cpp: Added. (WebCore::PolicyCallback::PolicyCallback): (WebCore::PolicyCallback::~PolicyCallback): (WebCore::PolicyCallback::clear): (WebCore::PolicyCallback::set): (WebCore::PolicyCallback::call): (WebCore::PolicyCallback::clearRequest): (WebCore::PolicyCallback::cancel):
loader/PolicyCallback.h: Added. (WebCore::PolicyCallback::request):
loader/PolicyCheck.cpp: Removed.
loader/PolicyCheck.h: Removed.

11:13 PM Changeset in webkit [49289] by eric@webkit.org

7 edits in trunk/WebCore

2009-10-07 Joel Stanley <joel@jms.id.au>

Reviewed by Mark Rowe.

Include <limits> for std::numeric_limits. Required by gcc-4.4
https://bugs.webkit.org/show_bug.cgi?id=30197

html/canvas/CanvasByteArray.h:
html/canvas/CanvasIntArray.h:
html/canvas/CanvasShortArray.h:
html/canvas/CanvasUnsignedByteArray.h:
html/canvas/CanvasUnsignedIntArray.h:
html/canvas/CanvasUnsignedShortArray.h:

11:09 PM Changeset in webkit [49288] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-10-07 Xan Lopez <xlopez@igalia.com>

Fix the GTK+ build.

webkit/webkitwebpolicydecision.cpp: (webkit_web_policy_decision_use): (webkit_web_policy_decision_ignore): (webkit_web_policy_decision_download):

10:30 PM Changeset in webkit [49287] by weinig@apple.com

2 edits in trunk/WebKitSite

Fix for https://bugs.webkit.org/show_bug.cgi?id=30196
Change style guidelines for indentation in header files

Reviewed by Dan Bernstein.

coding/coding-style.html: Don't indent in a namespace in a header file.

9:55 PM QtWebKitPerformanceUtilities edited by zecke@selfish.org

Update pahs. (diff)

9:44 PM Changeset in webkit [49286] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <Simon Fraser>

Re-land 49269-49271 since reverting them did not fix the tests.

WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):

9:09 PM Changeset in webkit [49285] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <Simon Fraser>

Revert 49269-49271 to see if it fixes test failures on SnowLeopard that do not
reproduce locally.

WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):

8:17 PM Changeset in webkit [49284] by abarth@webkit.org

18 edits in trunk

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::callPolicyFunction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSubmitForm): (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): (WebFrame::receivedPolicyDecision): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchWillSubmitForm): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::receivedPolicyDecison):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

Move the policy callback to the policy object.

WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::dispatchWillSubmitForm): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNavigationAction):

2009-10-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155

This patch separates PolicyChecker from FrameLoader. Loader policy is
in change of managing the FrameLoaderClient callbacks. Ideally, it
shouldn't know anything about FrameLoader, but I couldn't quite remove
all knowledge (although we might be able to do more later). In a
future patch, I'll move PolicyChecker into a separate file.

loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::PolicyChecker::handleUnimplementablePolicy): (WebCore::PolicyChecker::cannotShowMIMEType): (WebCore::PolicyChecker::PolicyChecker): (WebCore::PolicyChecker::checkNavigationPolicy): (WebCore::PolicyChecker::checkContentPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::stopAllLoaders): (WebCore::PolicyChecker::cancelCheck): (WebCore::PolicyChecker::stopCheck): (WebCore::PolicyChecker::continueAfterContentPolicy): (WebCore::PolicyChecker::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::loadPostRequest): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::PolicyChecker::checkNewWindowPolicy): (WebCore::PolicyChecker::continueAfterNewWindowPolicy): (WebCore::PolicyChecker::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
loader/FrameLoader.h: (WebCore::PolicyChecker::loadType): (WebCore::PolicyChecker::setLoadType): (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy): (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy): (WebCore::FrameLoader::policy):
loader/FrameLoaderClient.h:
loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse):
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

7:28 PM Changeset in webkit [49283] by aa@chromium.org

1 edit
1 move
1 add in trunk/LayoutTests/http/tests/security/isolatedWorld

Not reviewed. Fix layout test missing results.

7:04 PM Changeset in webkit [49282] by sfalken@apple.com

2 edits in trunk/WebKitSite

Add new Windows build prerequisite: Visual Studio 2005 Service Pack 1 ATL Security Update

Reviewed by Mark Rowe.

building/tools.html:

6:52 PM Changeset in webkit [49281] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Windows build fix: removed no longer exported symbol.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

6:46 PM Changeset in webkit [49280] by ggaren@apple.com

24 edits
2 copies in trunk

JavaScriptCore: Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
thread, permanently slowing down JavaScript

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
Reviewed by Oliver Hunt.

Removed the optional lock from Heap::protect, Heap::unprotect, and friends,
since WebCore no longer uses it.

JavaScriptCore.exp:
runtime/Collector.cpp:

(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markProtectedObjects):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::protectedObjectCount):
(JSC::Heap::protectedObjectTypeCounts):

runtime/Collector.h:

WebCore: Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
thread, permanently slowing down JavaScript

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
Reviewed by Oliver Hunt.

Changed callback objects to use a standard helper object. The helper
object ASSERTs that it is deleted on the main thread, so no lock is
required when unprotecting its members. It also centralizes some previously
duplicated code.

Callback objects that might be deleted on a secondary thread use
callOnMainThread to delete their helper objects on the main thread.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCallbackData.cpp: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp.

(WebCore::JSCallbackData::deleteData):
(WebCore::JSCallbackData::invokeCallback):

bindings/js/JSCallbackData.h: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp.

(WebCore::JSCallbackData::JSCallbackData):
(WebCore::JSCallbackData::~JSCallbackData):
(WebCore::JSCallbackData::callback):

bindings/js/JSCustomPositionCallback.cpp:

(WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
(WebCore::JSCustomPositionCallback::handleEvent):

bindings/js/JSCustomPositionCallback.h:
bindings/js/JSCustomPositionErrorCallback.cpp:

(WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
(WebCore::JSCustomPositionErrorCallback::handleEvent):

bindings/js/JSCustomPositionErrorCallback.h:
bindings/js/JSCustomSQLStatementCallback.cpp:

(WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::~JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::handleEvent):

bindings/js/JSCustomSQLStatementCallback.h:
bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::~JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):

bindings/js/JSCustomSQLStatementErrorCallback.h:
bindings/js/JSCustomSQLTransactionCallback.cpp:

(WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::handleEvent):

bindings/js/JSCustomSQLTransactionCallback.h:
bindings/js/JSCustomSQLTransactionErrorCallback.cpp:

(WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::~JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):

bindings/js/JSCustomSQLTransactionErrorCallback.h:
bindings/js/JSCustomVoidCallback.cpp:

(WebCore::JSCustomVoidCallback::JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::~JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::handleEvent):

bindings/js/JSCustomVoidCallback.h:
storage/Database.cpp:

(WebCore::Database::Database):

5:41 PM Changeset in webkit [49279] by jorlow@chromium.org

3 edits in trunk/WebCore

2009-10-07 Jens Alfke <snej@chromium.org>

Reviewed by Dave Levin.

Fix StringImpl::m_buffer
https://bugs.webkit.org/show_bug.cgi?id=30189

Fix my previous StringImpl patch to avoid using an indefinite-length array member,
since MSVC doesn't like it. Instead, go back to offsetting by sizeof(StringImpl).

platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::createUninitialized):
platform/text/StringImpl.h: (WebCore::StringImpl::bufferIsInternal):

5:07 PM Changeset in webkit [49278] by aa@chromium.org

12 edits
3 adds in trunk

Update isolated worlds under v8 to support world reuse.
https://bugs.webkit.org/show_bug.cgi?id=30145

Patch by Aaron Boodman <aa@chromium.org> on 2009-10-07
Reviewed by Adam Barth.

WebCore:

bindings/v8/ScriptController.cpp:

Replace evaluateInNewIsolatedWorld() withe evaluateInIsolatedWorld(id).
(WebCore::ScriptController::evaluateInIsolatedWorld):

bindings/v8/ScriptController.h: Ditto.
bindings/v8/V8Proxy.cpp: Ditto.

(WebCore::V8Proxy::~V8Proxy): Dittio.
(WebCore::V8Proxy::evaluateInIsolatedWorld): Ditto.

bindings/v8/V8Proxy.h: Ditto.
bindings/v8/V8IsolatedWorld.cpp:

Add support for controlling lifetime of a world, rather than relying on GC.
(WebCore::V8IsolatedWorld::contextWeakReferenceCallback): Ditto.
(WebCore::V8IsolatedWorld::V8IsolatedWorld): Ditto.
(WebCore::V8IsolatedWorld::destroy): Ditto.

bindings/v8/V8IsolatedWorld.h: Ditto.

LayoutTests:

http/tests/security/isolatedWorld/iframe.html: Added.
http/tests/security/isolatedWorld/world-reuse-expected.txt: Added.
http/tests/security/isolatedWorld/world-reuse.html: Added.

5:05 PM Changeset in webkit [49277] by beidson@apple.com

8 edits
2 adds in trunk

Send title changes to the global history delegate.
<rdar://problem/7285293> and https://webkit.org/b/29904

Reviewed by Darin Adler.

WebKit/mac:

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::setTitle):

WebView/WebDelegateImplementationCaching.h:
WebView/WebHistoryDelegate.h:
WebView/WebView.mm:

(-[WebView _cacheHistoryDelegateImplementations]):

WebKitTools:

DumpRenderTree/mac/HistoryDelegate.mm:

(-[HistoryDelegate webView:updateHistoryTitle:forURL:]):

LayoutTests:

http/tests/globalhistory/history-delegate-basic-title-expected.txt: Added.
http/tests/globalhistory/history-delegate-basic-title.html: Added.

4:55 PM Changeset in webkit [49276] by bweinstein@apple.com

1 edit in trunk/WebCore/platform/text/StringImpl.cpp

Well that was wrong, undo-ing previous build fix.

4:50 PM Changeset in webkit [49275] by bweinstein@apple.com

1 edit in trunk/WebCore/platform/text/StringImpl.cpp

Hopefully the rest of the Windows build fix.

4:33 PM Changeset in webkit [49274] by jorlow@chromium.org

2 edits in trunk/WebCore

Build fix for http://trac.webkit.org/changeset/49272 on Windows

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-07

platform/text/StringImpl.h:

4:20 PM Changeset in webkit [49273] by Darin Adler

4 edits in trunk/WebKit/mac

Make the setMetadataURL function foolproof by having it remove user info
https://bugs.webkit.org/show_bug.cgi?id=30178
rdar://problem/6544670

Patch by Darin Adler <Darin Adler> on 2009-10-07
Reviewed by John Sullivan.

Misc/WebNSFileManagerExtras.m:

(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
Call _web_URLByRemovingUserInfo on the passed in URL string after converting
it to a URL, and then convert it back to a string.

Misc/WebNSURLExtras.h: Added _web_URLByRemovingUserInfo.
Misc/WebNSURLExtras.mm: Removed unused WebKitURLComponents struct.

(-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Renamed to be
clearer on what this does.
(-[NSURL _webkit_URLByRemovingFragment]): Changed to call new name.
(-[NSURL _webkit_URLByRemovingResourceSpecifier]): Ditto.
(-[NSURL _web_URLByRemovingComponentAndSubsequentCharacter:]): Added.
(-[NSURL _web_URLByRemovingUserInfo]): Added.

3:41 PM Changeset in webkit [49272] by eric@webkit.org

3 edits in trunk/WebCore

2009-10-07 Jens Alfke <snej@chromium.org>

Reviewed by Darin Adler.

Optimization of StringImpl:

Remove unnecessary m_bufferIsInternal member (saves 4 bytes). Instead, check whether m_data points to just past the end of the object's members.
copy() and createWithTerminatingNullCharacter() create the string in a single malloc block instead of 2 (saves ~20 bytes and considerable CPU cycles, increases locality).
Move m_length next to m_hash to save 4 bytes of padding in 64-bit builds.

https://bugs.webkit.org/show_bug.cgi?id=29500

platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Re-ordered members. (WebCore::StringImpl::~StringImpl): Change to is-buffer-internal check. (WebCore::StringImpl::createUninitialized): Use new m_buffer member instead of sizeof()

to ensure chars are copied to correct location.

(WebCore::StringImpl::createWithTerminatingNullCharacter): Make sure copy is created

in a single malloc block.

(WebCore::StringImpl::threadsafeCopy): Make sure copy is created in a single malloc block.
(WebCore::StringImpl::crossThreadString): Make sure copy is created in a single malloc block.
(WebCore::StringImpl::sharedBuffer): Change to is-buffer-internal check.

platform/text/StringImpl.h: (WebCore::StringImpl::startsWith): Just fixed a confusing param name. (WebCore::StringImpl::bufferIsInternal): Changed member var into accessor method. (WebCore::StringImpl::m_data): Repositioned for optimal member packing in 64-bit. (WebCore::StringImpl::m_buffer): Added to provide an explicit location for where internal buffer goes.

3:41 PM Changeset in webkit [49271] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <Simon Fraser>

Make Dan Bernstein happy.

WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):

3:38 PM Changeset in webkit [49270] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Avoid Obj-C message dispatch when possible by storing accessed objects
in local variables.

WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):

3:29 PM Changeset in webkit [49269] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-10-07 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Animation stalls for a few seconds partway through
https://bugs.webkit.org/show_bug.cgi?id=30182

Make sure that we only call -disableScreenUpdatesUntilFlush when a window
update is actually going to happen, otherwise screen updates are disabled
for too long.

WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):

3:26 PM Changeset in webkit [49268] by dbates@webkit.org

3 edits
1 add in trunk

2009-10-07 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30102
And
<rdar://problem/5015957>

Fixes an issue (in the Windows build) where the cursor does not change to the
not-allowed cursor when the drag-and-drop operation is not allowed.

The allowed effects in WebDragClient::startDrag are hard-coded to be
DROPEFFECT_COPY | DROPEFFECT_LINK | DROPEFFECT_MOVE. Instead, the list of
allowed drop effects should be determined by the allowed operations of the
drag source.

We cannot test this using DRT because DRT looks at the programmatic drop
cursor and until bug #24731 is fixed this value is hard-coded to DragOperationCopy.
That is, there is a discrepancy in the Windows build between the Windows API-based
drop effect and the WebKit drop effect. Because DRT cannot read the screen buffer
to determine the cursor, a manual test is needed.

WebCoreSupport/WebDragClient.cpp: (draggingSourceOperationMaskToDragCursors): Added method. (WebDragClient::startDrag):

2009-10-07 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30102
And
<rdar://problem/5015957>

Manual test to confirm that the not-allowed cursor is shown for an
invalid drag-and-drop operation.

We cannot test this using DRT because of a discrepancy between the Windows
API-based drop effect and the WebKit drop effect. See bug #24731 for more
details.

manual-tests/drag-cursor-notallowed.html: Added.

3:22 PM Changeset in webkit [49267] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-10-07 Adam Barth <abarth@webkit.org>

Unreviewed. Remove some folks from committers.py who were listed on
the WebKit Team wiki page but who weren't actually listed as commit+.
At some point, we should coorelate this list with the committers
mailing list.

Scripts/modules/committers.py:

3:16 PM Changeset in webkit [49266] by mrowe@apple.com

2 edits in trunk/WebCore

Fix the build.

3:10 PM Changeset in webkit [49265] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-10-07 Adam Barth <abarth@webkit.org>

Unreviewed. Import a bunch of committers from the WebKit Team page on
the wiki into committers.py.

Scripts/modules/committers.py:

2:56 PM Changeset in webkit [49264] by eric@webkit.org

1 edit
2 adds in trunk/LayoutTests

2009-10-07 Evan Martin <evan@chromium.org>

Reviewed by Adam Roben.

Windows-specific baselines for some new tests.

platform/win/fast/css/large-number-round-trip-expected.txt: Added.
platform/win/fast/css/opacity-float-expected.txt: Copied from LayoutTests/fast/css/opacity-float-expected.txt.

2:55 PM Changeset in webkit [49263] by bweinstein@apple.com

18 edits in trunk/WebCore

2009-10-07 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Fixes <http://webkit.org/b/30104>.
Inspector should show cookies of sub-resources on the page.

This function implements showing cookies for all sub-resources of a page.
When the page is loaded, it populates the Storage Panel with a list of all
domains that were loaded as part of the full page load (iframes, ads, etc).
When the user selects one of the domains, the inspector calls back into the
controller, and the controller combines all of the cookies from that domain
into a list, and sends that list is sent back to the controller to render.

A domain now needs to be passed into CookieItemsView, and CookieSidebarTreeElement.

As a result of a previous patch, we now have detailed cookie information for
both Windows on CFNetwork and Mac. Additionally, this patch provides deleteCookie
support on Windows.

bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set):
bindings/js/ScriptObject.h:
inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getCookies): (WebCore::InspectorBackend::deleteCookie):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::buildArrayForCookies): (WebCore::InspectorController::buildObjectForCookie): (WebCore::InspectorController::deleteCookie):
inspector/InspectorController.h:
inspector/InspectorDOMAgent.cpp:
inspector/InspectorDOMAgent.h:
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addCookieDomainForDocument):
inspector/InspectorFrontend.h:
inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
inspector/front-end/DOMAgent.js: (WebInspector.Cookies.getCookiesAsync):
inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addCookieDomain): (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect):
inspector/front-end/inspector.js: (WebInspector.addCookieDomain):
platform/Cookie.h: (WebCore::CookieHash::hash): (WebCore::CookieHash::equal): (WTF::):
platform/network/win/CookieJarCFNetWin.cpp: (WebCore::deleteCookie):

2:50 PM Changeset in webkit [49262] by bweinstein@apple.com

3 edits in trunk/WebCore

2009-10-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add ScriptObject::set(const char*, unsigned).

https://bugs.webkit.org/show_bug.cgi?id=30104

bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set):
bindings/v8/ScriptObject.h:

2:49 PM LayoutAndRendering edited by alex@milowski.com

(diff)

2:47 PM Changeset in webkit [49261] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-10-07 Adam Barth <abarth@webkit.org>

Unreviewed. Added Aaron Boodman to committers.py.

Scripts/modules/committers.py:

2:46 PM LayoutAndRendering edited by alex@milowski.com

(diff)

2:46 PM LayoutAndRendering created by alex@milowski.com

2:41 PM WikiStart edited by alex@milowski.com

added link to new layout and rendering page (diff)

1:51 PM Changeset in webkit [49260] by bfulgham@webkit.org

2 edits in trunk/WebCore

Unreviewed build fix for Windows (Cairo).

Provide implementation of new BitmapImage::create that was
added in @r49060.

platform/graphics/win/ImageCairoWin.cpp:

1:25 PM Changeset in webkit [49259] by eric@webkit.org

9 edits
2 adds in trunk/WebCore

2009-10-07 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Refactor RenderThemeChromiumMac and RenderThemeChromiumSkia to render media controls using GraphicsContext.

Design was based on existing RenderMediaControls.cpp used by RenderThemeSafari/Win.

https://bugs.webkit.org/show_bug.cgi?id=29987

Covered by existing layout tests as no new functionality was introduced.

WebCore.gypi: Added RenderMediaControlsChromium.cpp/h.
css/mediaControlsChromium.css: Tweaked media slider position and border style.
rendering/MediaControlElements.cpp: (WebCore::toParentMediaElement): Taken from RenderMediaControls. (WebCore::MediaControlElement::rendererIsNeeded): Don't call shouldRenderMediaControlPart() if element has no appearance. (WebCore::MediaControlInputElement::rendererIsNeeded): Ditto.
rendering/RenderMediaControls.cpp: Moved parentMediaElement() to MediaControlElements.
rendering/RenderMediaControlsChromium.cpp: Added. (WebCore::platformResource): Helper to load and cache media control image resources. (WebCore::mediaSliderThumbImage): Implementation refactored from RenderThemeChromiumMac/Skia. (WebCore::mediaVolumeSliderThumbImage): Ditto. (WebCore::paintMediaButton): Ditto. (WebCore::paintMediaMuteButton): Ditto. (WebCore::paintMediaPlayButton): Ditto. (WebCore::paintMediaSlider): Ditto. (WebCore::paintMediaSliderThumb): Ditto. (WebCore::paintMediaVolumeSlider): Ditto. (WebCore::paintMediaVolumeSliderThumb): Ditto. (WebCore::paintMediaTimelineContainer): Ditto. (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Ditto. (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Same (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
rendering/RenderMediaControlsChromium.h: Added.
rendering/RenderThemeChromiumMac.h:
rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): Implementation delegated to RenderMediaControlsChromium. (WebCore::RenderThemeChromiumMac::shouldRenderMediaControlPart): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground): Ditto.
rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintMediaControlsBackground): Implementation delegated to RenderMediaControlsChromium. (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): Ditto. (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): Ditto. (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Ditto.

1:03 PM Changeset in webkit [49258] by hyatt@apple.com

3 edits
2 adds in trunk

Make plugins work with beforeload.

Reviewed by Adam Roben.

Added fast/dom/beforeload/flash-before-load.html

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::updateWidget):

12:10 PM Changeset in webkit [49257] by cmarrin@apple.com

6 edits in trunk/WebKitSite/blog-files/webgl/resources

resized thumbnails

11:32 AM Changeset in webkit [49256] by sfalken@apple.com

2 edits in trunk/WebKit/win

https://bugs.webkit.org/show_bug.cgi?id=30176
<rdar://problem/7281553> Extra information in UA causes problems with gmail

Reviewed by Darin Adler.

WebKit.vcproj/WebKit.rc: Restore PRODUCTVERSION to build number only. Remove extra space.

11:20 AM Changeset in webkit [49255] by cmarrin@apple.com

6 adds in trunk/WebKitSite/blog-files/webgl/resources

added thumbnail images for demos

11:10 AM Changeset in webkit [49254] by eric@webkit.org

1 edit
2 adds in trunk/LayoutTests

2009-10-07 Evan Martin <evan@chromium.org>

Reviewed by Simon Fraser.

Add a currently-failing test exhibiting the problem in
https://bugs.webkit.org/show_bug.cgi?id=20674:

When converting very large or small numbers back to strings, exponential
notation is used, so a value like 90010000px is returned from
getComputedStyle() as 9.001e+07px.

9.001e+07px does not parse, so such a value cannot be round-tripped.

This is a particular problem with tranformation matrices, which can often
contain very large or small numbers.

(Test written by Simon Fraser; I've just made it a committable patch.)

fast/css/large-number-round-trip-expected.txt: Added.
fast/css/large-number-round-trip.html: Added.

10:47 AM Changeset in webkit [49253] by eric@webkit.org

8 edits
3 adds in trunk

2009-10-07 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

Layout test for verifying that LC_NUMERIC setting doesn't affect
the way CSS properties are stringified.
https://bugs.webkit.org/show_bug.cgi?id=18994

fast/css/opacity-float-expected.txt: Added.
fast/css/opacity-float.html: Added.

2009-10-07 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

Add API to LayoutTestController for re/setting the system locale.
https://bugs.webkit.org/show_bug.cgi?id=18994

DumpRenderTree/LayoutTestController.cpp: (setLocaleCallback): (LayoutTestController::staticFunctions): (LayoutTestController::setLocale):
DumpRenderTree/LayoutTestController.h:

10:25 AM Changeset in webkit [49252] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-07 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Protect JS listener object from GC while clearing a property on it.
See http://crbug.com/23780.
https://bugs.webkit.org/show_bug.cgi?id=30137

bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):

10:09 AM Changeset in webkit [49251] by zoltan@webkit.org

2 edits in trunk/WebCore

2009-10-07 Zoltan Horvath <zoltan@webkit.org>

Rubber-stamped by Eric Seidel.

Allow custom memory allocation control for WebCore's CachedResourceClient class
https://bugs.webkit.org/show_bug.cgi?id=30165

Inherits CachedResourceClient class from FastAllocBase because (its
child class) CSSFontFaceSource has been instantiated by 'new' in WebCore/css/CSSFontFaceSource.h:46.

loader/CachedResourceClient.h:

10:04 AM Changeset in webkit [49250] by zoltan@webkit.org

2 edits in trunk/WebCore

2009-10-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for WebCore's IdentifierRep
https://bugs.webkit.org/show_bug.cgi?id=30159

Inherits IdentifierRep class from FastAllocBase because it has been
instantiated by 'new' in WebCore/bridge/IdentifierRep.cpp:61.

bridge/IdentifierRep.h:

10:00 AM Changeset in webkit [49249] by zoltan@webkit.org

2 edits in trunk/JavaScriptCore

2009-10-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's IdentifierArena
https://bugs.webkit.org/show_bug.cgi?id=30158

Inherits IdentifierArena class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/parser/ParserArena.cpp:36.

parser/ParserArena.h:

9:59 AM Changeset in webkit [49248] by eric@webkit.org

5 edits in trunk/WebCore

2009-10-07 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Fetch pointers to C++ DOM window immediately from holder
object (do not search prototype chain for proper JS wrapper).
https://bugs.webkit.org/show_bug.cgi?id=29031

bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createNewContext): (WebCore::V8Proxy::installDOMWindow):
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_ACCESS_CHECK):

9:49 AM Changeset in webkit [49247] by Adam Roben

4 edits in trunk/JavaScriptCore

Export DateInstance::info in a way that works on Windows

Fixes <http://webkit.org/b/30171>
fast/dom/Window/window-postmessage-clone.html fails on Windows

Reviewed by Anders Carlsson.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

Removed the export of DateInstance::info from here.

runtime/DateInstance.h: Use JS_EXPORTDATA to export

DateInstance::info, which is the required way of exporting data on
Windows.

9:23 AM Changeset in webkit [49246] by hamaji@chromium.org

2 edits in trunk/WebKitTools

2009-10-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Jan Alonzo.

[Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
https://bugs.webkit.org/show_bug.cgi?id=29689

Build fix by adding -lfontconfig for DumpRenderTree.

GNUmakefile.am:

8:22 AM Changeset in webkit [49245] by tonikitoo@webkit.org

4 edits in trunk/WebKit/qt

2009-10-07 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Get rid of useless loadFailed signal in QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=30166

Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_doLoadFinished):
Api/qgraphicswebview.h:
QGVLauncher/main.cpp: (MainWindow::init): (MainWindow::loadFinished):

8:11 AM Changeset in webkit [49244] by Adam Roben

2 edits in trunk/WebCore

Fix typo in PluginView::load that was causing cross-origin loads to be allowed

This typo was introduced in the build fix in r49213.

Fixes <http://webkit.org/b/30168> REGRESSION (r49213):
http/tests/plugins/local-geturl-from-remote.html is failing on Windows

Reviewed by Sam Weinig.

plugins/PluginView.cpp:

(WebCore::PluginView::load): Removed a comma operator that was making
a condition always evaluate to true.

7:53 AM Changeset in webkit [49243] by zoltan@webkit.org

2 edits in trunk/WebKitTools

2009-10-07 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.

Scripts/run-webkit-tests:

7:06 AM Changeset in webkit [49242] by kenneth@webkit.org

2 edits in trunk/WebCore

Do not create valid QColor's for invalid WebCore::Color's.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-07
Reviewed by Simon Hausmann.

platform/graphics/qt/ColorQt.cpp:

(WebCore::Color::operator QColor):

5:44 AM Changeset in webkit [49241] by xan@webkit.org

2 edits in trunk/WebKitTools

2009-10-07 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

"delete" in EventSender is the backspace key, not the delete one.

DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):

4:46 AM Changeset in webkit [49240] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-10-07 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

Add a simple rotation effect to QGVLauncher

https://bugs.webkit.org/show_bug.cgi?id=30162

QGVLauncher/main.cpp: (MainView::animatedFlip): (MainWindow::animatedFlip): (MainWindow::buildUI):

3:58 AM Changeset in webkit [49239] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-07 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

[Qt] Symbian SBSv2 .data segment adress fix
https://bugs.webkit.org/show_bug.cgi?id=30157

RO-section in qtwebkit.dll exceeds allocated space in SBSv2. Move RW-section
base address to start from 0x800000 instead of the toolchain default 0x400000

WebCore.pro:

3:45 AM Changeset in webkit [49238] by Simon Hausmann

2 edits in trunk/JavaScriptCore

When enabling or disabling the JIT through .qmake.cache, make sure
to also toggle ENABLE_YARR_JIT.

Patch by Jørgen Lind <jorgen.lind@nokia.com> on 2009-10-07
Reviewed by Simon Hausmann.

JavaScriptCore.pri:

3:44 AM Changeset in webkit [49237] by Simon Hausmann

2 edits in trunk/WebKit/qt

Doc: Document HTML and status as properties.

Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-10-07
Reviewed by Simon Hausmann.

Api/qgraphicswebview.cpp:

3:42 AM Changeset in webkit [49236] by Simon Hausmann

3 edits in trunk/WebKit/qt

Fix qdoc warning about disabled renderHints property
on Symbian.

Patch by Martin Smith <msmith@trolltech.com> on 2009-10-07
Reviewed by Simon Hausmann.

Api/qwebview.cpp:
Api/qwebview.h:

3:36 AM Changeset in webkit [49235] by xan@webkit.org

2 edits in trunk/WebKitTools

2009-10-07 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

getChildrenWithRange expects as last parameter the end index, not
the length of the range. Correct this and clarify the variable
names to reflect how the code works.

DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::getChildrenWithRange): (AccessibilityUIElement::getChildAtIndex):

2:32 AM Changeset in webkit [49234] by pfeldman@chromium.org

18 edits in trunk/WebCore

2009-10-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Migrate database inspection to the injected script-based schema.

https://bugs.webkit.org/show_bug.cgi?id=29788

bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::databaseForId):
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::databaseForId): (WebCore::InspectorBackend::selectDatabase): (WebCore::InspectorBackend::getDatabaseTableNames): (WebCore::InspectorBackend::reportDidDispatchOnInjectedScript):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::selectDatabase): (WebCore::InspectorController::databaseForId): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::selectDOMStorage): (WebCore::InspectorController::getDOMStorageResourceForId):
inspector/InspectorController.h:
inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind):
inspector/InspectorDatabaseResource.h: (WebCore::InspectorDatabaseResource::database): (WebCore::InspectorDatabaseResource::id):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::didGetDatabaseTableNames): (WebCore::InspectorFrontend::addDOMStorage):
inspector/InspectorFrontend.h:
inspector/front-end/Database.js: (WebInspector.Database): (WebInspector.Database.prototype.get id): (WebInspector.Database.prototype.set name): (WebInspector.Database.prototype.set version): (WebInspector.Database.prototype.set domain): (WebInspector.Database.prototype.getTableNames): (WebInspector.Database.prototype.executeSql):
inspector/front-end/InjectedScript.js: (InjectedScript.dispatch): (InjectedScript.executeSql): (InjectedScript.executeSql.errorCallback): (InjectedScript.executeSql.queryTransaction):
inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.selectDatabase): (WebInspector.StoragePanel.prototype.dataGridForResult):
inspector/front-end/inspector.js: (WebInspector.addDatabase):

1:23 AM Changeset in webkit [49233] by eric@webkit.org

2 edits in trunk/WebKit/gtk

2009-10-07 Martin Robinson <martin.james.robinson@gmail.com>

[GTK] Segfault while testing fast/events/keydown-keypress-preventDefault.html
https://bugs.webkit.org/show_bug.cgi?id=30121

Clear previous preedit or pending composition before storing new ones.
This can happen when a WebView receives a native keydown event without
a matching keyup event or when preventDefault() is called on DOM keydown
events.

WebCoreSupport/EditorClientGtk.cpp: (WebKit::setPendingComposition): (WebKit::setPendingPreedit): (WebKit::clearPendingIMData): (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged):

12:42 AM Changeset in webkit [49232] by pfeldman@chromium.org

4 edits in trunk/WebKit

2009-10-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: default to an attached inspector window on Windows (as on Mac).

https://bugs.webkit.org/show_bug.cgi?id=30134

WebKit/mac:

WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]):

WebKit/win:

WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::showWindowWithoutNotifications):

12:40 AM Changeset in webkit [49231] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-07 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins: Disable content propagation for QGraphicsView items

We cannot support content propagation for items in QGraphicsView because
the contents of the backing store might be transformed. So turn it off
if we are not painting on QWidget.

Note that this check will not work for a QWebView in a
QGraphicsProxyWidget, but I guess it's fine. Alternative is to do an
even uglier cast: static_cast painter's paintDevice() to QWidget and
check if it is the viewport() of QGraphicsView.

https://bugs.webkit.org/show_bug.cgi?id=30149

plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):

12:38 AM Changeset in webkit [49230] by xan@webkit.org

2 edits in trunk/LayoutTests

2009-10-07 Xan Lopez <xlopez@igalia.com>

Skip two new tests for which we are missing results.

platform/gtk/Skipped:

12:17 AM Changeset in webkit [49229] by oliver@apple.com

3 edits in trunk/LayoutTests

Tidy up postMessage testcase

Reviewed by Gavin Barraclough.

12:15 AM Changeset in webkit [49228] by Simon Hausmann

2 edits in trunk/WebCore

Fix the Qt build by adding the missing files to the build.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-07

WebCore.pro:

12:10 AM Changeset in webkit [49227] by kov@webkit.org

3 edits in trunk/WebCore

2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Fix incorrect convertion of double into int while assigning it to
a float.

platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):

12:10 AM Changeset in webkit [49226] by kov@webkit.org

3 edits in trunk/WebCore

2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Fix rounding error issues in height calculation in 64 bits.

Already covered by existing tests.

platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):

Oct 6, 2009:

11:20 PM Changeset in webkit [49225] by hamaji@chromium.org

4 edits
8 adds in trunk

2009-10-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Dual lines in css2.1 layout tests do not match:
https://bugs.webkit.org/show_bug.cgi?id=23262

Now we can put a counter node as the next sibling of a reset node.
Re-layout the counter content when the count is updated.

Tests: fast/css/counters/t1204-increment-00-c-o.html

fast/css/counters/t1204-increment-01-c-o.html

rendering/CounterNode.cpp: (WebCore::CounterNode::recount):
rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter):

2009-10-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Dual lines in css2.1 layout tests do not match:
https://bugs.webkit.org/show_bug.cgi?id=23262

Now we can put a counter node as the next sibling of a reset node.
Re-layout the counter content when the count is updated.

fast/css/counters/t1204-increment-00-c-o.html: Added.
fast/css/counters/t1204-increment-01-c-o.html: Added.
platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.checksum: Added.
platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.png: Added.
platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.checksum: Added.
platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.png: Added.
platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.

10:44 PM Changeset in webkit [49224] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-10-06 Priit Laes <plaes@plaes.org>

Reviewed by Gavin Barraclough.

Linking fails with "relocation R_X86_64_PC32 against symbol
`cti_vm_throw'"
https://bugs.webkit.org/show_bug.cgi?id=28422

jit/JITStubs.cpp: Mark cti_vm_throw symbol as PLT-indirect symbol, so it doesn't end up in text segment causing relocation errors on amd64 architecture. Introduced new define SYMBOL_STRING_RELOCATION for such symbols.

10:15 PM Changeset in webkit [49223] by xan@webkit.org

2 edits in trunk/WebCore

2009-10-06 Xan Lopez <xlopez@igalia.com>

Try to fix the GTK+ build.

GNUmakefile.am:

8:56 PM Changeset in webkit [49222] by eric@webkit.org

3 edits in trunk/WebCore

2009-10-06 Adam Barth <abarth@webkit.org>

Reviewed by Adam Barth.

Removed unused member variable from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30146

loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader):
loader/FrameLoader.h:

8:45 PM Changeset in webkit [49221] by levin@chromium.org

2 edits in trunk/WebCore

A few small/trivial tweaks to the last build fix.

Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by NOBODY (build fix).

bindings/scripts/CodeGeneratorV8.pm:

8:16 PM Changeset in webkit [49220] by oliver@apple.com

3 edits in trunk/JavaScriptCore

Windows linking fix

8:07 PM Changeset in webkit [49219] by levin@chromium.org

8 edits
1 copy in trunk/WebCore

[Chromium] Need to adjust MessagePort, etc. code for the post clone work done.
https://bugs.webkit.org/show_bug.cgi?id=30147

Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by Dimitri Glazkov.

No change in functionality so no new tests.

WebCore.gypi:
bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/SerializedScriptValue.h: Added. A very simple implementation of SerializedScriptValue that only works for strings.
bindings/v8/custom/V8DOMWindowCustom.cpp: