Timeline
Oct 10, 2009:
- 8:47 PM Changeset in webkit [49423] by
-
- 3 edits3 adds in trunk
Support for String.trim(), String.trimLeft() and String.trimRight() methods
https://bugs.webkit.org/show_bug.cgi?id=26590
Reviewed by Maciej Stachowiak.
Implement trim, trimLeft, and trimRight
- 3:10 PM Changeset in webkit [49422] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r49414): Rebaseline needed for Windows / Gtk Linux
https://bugs.webkit.org/show_bug.cgi?id=30279
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-10
Reviewed by Eric Seidel.
- platform/gtk/editing/style/5228141-expected.txt: Same rebaseline done for Mac in r49414
- platform/win/editing/execCommand/toggle-compound-styles-expected.txt: two i tags are merged properly
- 2:46 PM Changeset in webkit [49421] by
-
- 2 edits in trunk/WebCore
Fix paths in xcode.
- 2:16 PM Changeset in webkit [49420] by
-
- 10 edits2 copies8 adds in trunk
Implement getActiveAttrib and getActiveUniform
https://bugs.webkit.org/show_bug.cgi?id=30276
Reviewed by Eric Carlson.
Implements the getActiveAttrib and getActiveUniform APIs.
Rather simple patch, adds CanvasActiveInfo definition and implementation
and adds forwarding to the GraphicsContext3D.
Test: fast/canvas/webgl/getActiveTest.html
- 12:21 PM Changeset in webkit [49419] by
-
- 2 edits in trunk/WebCore
2009-10-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Adding new attributes in Element Panel is
counterintuitive.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement.prototype.set hovered): (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):
- 9:19 AM Changeset in webkit [49418] by
-
- 4 edits in trunk/WebCore
2009-10-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
Build fix if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=30275
In addition to fixing the build break with guards
remove notImplemented() from PluginViewNone.cpp and
make them just just be empty functions.
- plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/PluginViewNone.cpp: (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::getValue): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::invalidateRect): (WebCore::PluginView::invalidateRegion): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::updatePluginWidget):
- 8:56 AM Changeset in webkit [49417] by
-
- 2 edits in trunk/WebCore
2009-10-10 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
Add HistoryController.cpp to the build.
- WebCore.pro:
- 6:53 AM Changeset in webkit [49416] by
-
- 2 edits in trunk/WebCore
2009-10-09 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
[Chromium] KURLGoogle's protocolIs barfs on input containing hyphens
https://bugs.webkit.org/show_bug.cgi?id=30262
This is not testable from WebKit since WebKit never uses the member
function form of protocolIs with input that can be controlled from a
web page. It always passes string literals lacking hyphens.
- platform/KURLGoogle.cpp: (WebCore::lowerCaseEqualsASCII): Only assert if toASCIILower would transform the input character.
- 3:04 AM BuildingQtOnWindows edited by
- (diff)
- 2:11 AM Changeset in webkit [49415] by
-
- 8 edits2 adds in trunk/WebCore
2009-10-10 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Move HistoryController to its own file
https://bugs.webkit.org/show_bug.cgi?id=30272
Purely mechanical.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/HistoryController.cpp: Added.
- loader/HistoryController.h: Added.
Oct 9, 2009:
- 8:36 PM Changeset in webkit [49414] by
-
- 10 edits3 adds in trunk
ApplyStyleCommand removes presentational tags even when not necessary
https://bugs.webkit.org/show_bug.cgi?id=28091
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-09
Reviewed by Eric Seidel.
WebCore:
This patch updates implicitlyStyledElementShouldBeRemovedWhenApplyingStyle to return true
(triggering removal of tag) only if the style implicitly added by the element is not present in
the new style to apply. It also changes surroundNodeRangeWithElement so that it merges the
surrounding element when possible. applyTextDecorationStyle is modified so that it does not add
style span when the style attribute is empty.
Test: editing/execCommand/toggle-style-3.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::shouldRemoveTextDecorationTag): Returns true if specified text
decoration is not present in the style to apply
(WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): No longer
returns true if the tag is used in new style
(WebCore::ApplyStyleCommand::applyTextDecorationStyle): Does not add style-span when redundant
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Merges the newly created element
with the surrounding identical elements
- editing/ApplyStyleCommand.h:
LayoutTests:
This patch adds test to make sure to preserve presentational tag
(u, s, strike, i, em, sup, sub, b, & strong) when the corresponding style is present in
the final computed style. i.e. avoid removing tag and re-applying the style later
- editing/execCommand/19653-2-expected.txt: Two b elements are merged.
- editing/execCommand/createLink-expected.txt: Two anchor elements are merged.
- editing/execCommand/script-tests/toggle-style-3.js: Added.
(testSingleToggle):
- editing/execCommand/strikethroughSelection-expected.txt: Redundant style spans are no longer added.
- editing/execCommand/toggle-style-3-expected.txt: Added.
- editing/execCommand/toggle-style-3.html: Added.
- editing/execCommand/unlink-expected.txt: Two anchor elements are merged.
- platform/mac/editing/style/5228141-expected.txt: Two b elements are merged.
- platform/mac/editing/style/style-boundary-001-expected.txt: Two b elements are merged.
- 7:27 PM Changeset in webkit [49413] by
-
- 10 edits in trunk
2009-10-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246
Update API call.
- WebView.cpp: (WebView::loadBackForwardListFromOtherView):
2009-10-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246
Update API call.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::restoreViewState):
- WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]):
2009-10-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246
HistoryController is in charge of managing the current / previous /
provisional HistoryItems. The split isn't perfect, but it's a place to
start. I'll move HistoryController into its own file in another patch.
- WebCore.base.exp:
- loader/FrameLoader.cpp: (WebCore::HistoryController::HistoryController): (WebCore::HistoryController::~HistoryController): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::closeURL): (WebCore::FrameLoader::begin): (WebCore::HistoryController::restoreDocumentState): (WebCore::HistoryController::setCurrentItem): (WebCore::HistoryController::setProvisionalItem): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::scrollToAnchor): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::didFirstLayout): (WebCore::HistoryController::updateForFrameLoadCompleted): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::HistoryController::addHistoryItemForFragmentScroll): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::HistoryController::createHistoryItem): (WebCore::FrameLoader::checkDidPerformFirstNavigation): (WebCore::HistoryController::addBackForwardItemClippedAtTarget): (WebCore::HistoryController::createHistoryItemTree): (WebCore::HistoryController::saveScrollPositionAndViewStateToItem): (WebCore::HistoryController::restoreScrollPositionAndViewState): (WebCore::HistoryController::invalidateCurrentItemCachedPage): (WebCore::HistoryController::saveDocumentState): (WebCore::FrameLoader::loadItem): (WebCore::HistoryController::urlsMatchItem): (WebCore::HistoryController::goToItem): (WebCore::HistoryController::recursiveGoToItem): (WebCore::HistoryController::childFramesMatchItem): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForClientRedirect): (WebCore::HistoryController::updateForBackForwardNavigation): (WebCore::HistoryController::updateForReload): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::updateForCommit): (WebCore::HistoryController::updateForAnchorScroll): (WebCore::HistoryController::saveDocumentAndScrollState): (WebCore::HistoryController::setCurrentItemTitle): (WebCore::FrameLoader::didChangeTitle):
- loader/FrameLoader.h: (WebCore::HistoryController::current): (WebCore::HistoryController::provisional): (WebCore::FrameLoader::policyChecker): (WebCore::FrameLoader::history): (WebCore::FrameLoader::creatingInitialEmptyDocument):
- page/Page.cpp: (WebCore::Page::goToItem):
- 5:53 PM Changeset in webkit [49412] by
-
- 2 edits in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore
Try to fix Windows build by adding needed exports.
- 5:46 PM Changeset in webkit [49411] by
-
- 5 edits in trunk
WebKit/mac: <rdar://problem/7290671> Crash after navigating away from a page with subframe containing plug-in
Reviewed by Brady Eidson.
At the time that -stop is called on a WebBaseNetscapePluginView that is contained within a subframe
the WebFrame's data source has been zeroed out. This was causing -[WebBaseNetscapePluginView webFrame]
to return nil during -stop, preventing the plug-in view from unregistering itself from the PluginHalter.
We fix this by having -webFrame retrieve the frame directly rather than retrieving it from the data source.
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView dataSource]): Get the data source from the WebFrame.
(-[WebBaseNetscapePluginView webFrame]): Get the Frame directly from the element's document rather
than taking a windy route through the WebDataSource.
WebKitTools: Enable plug-in halting in DumpRenderTree.
We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:shouldHaltPlugin:]):
- 5:38 PM Changeset in webkit [49410] by
-
- 2 edits in trunk/WebCore
Unreviewed - fixing an obvious typo in my previous check-in.
https://bugs.webkit.org/show_bug.cgi?id=30260
<rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work
Fixes existing tests (which I thought I had run the previous time).
- platform/network/CredentialStorage.cpp: (WebCore::originsWithCredentials): Return the set by reference.
- 5:30 PM Changeset in webkit [49409] by
-
- 10 edits in trunk/JavaScriptCore
Eliminated some legacy bytecode weirdness.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-09
Reviewed by Oliver Hunt.
Use vPC[x] subscripting instead of ++vPC to access instruction operands.
This is simpler, and often more efficient.
To support this, and to remove use of hard-coded offsets in bytecode and
JIT code generation and dumping, calculate jump offsets from the beginning
of an instruction, rather than the middle or end.
Also, use OPCODE_LENGTH instead of hard-coded constants for the sizes of
opcodes.
SunSpider reports no change in JIT mode, and a 1.01x speedup in Interpreter
mode.
- bytecode/CodeBlock.cpp:
(JSC::printConditionalJump):
(JSC::CodeBlock::dump):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJump):
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
(JSC::BytecodeGenerator::emitJumpScopes):
(JSC::BytecodeGenerator::emitNextPropertyName):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::emitJumpSubroutine):
(JSC::prepareJumpTableForImmediateSwitch):
(JSC::prepareJumpTableForCharacterSwitch):
(JSC::prepareJumpTableForStringSwitch):
(JSC::BytecodeGenerator::endSwitch):
- bytecompiler/Label.h:
(JSC::Label::setLocation):
(JSC::Label::bind):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveBase):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):
- interpreter/Interpreter.h:
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitBinaryDoubleOp):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_loop):
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emitSlow_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):
(JSC::JIT::emit_op_loop_if_true):
(JSC::JIT::emitSlow_op_loop_if_true):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_jmp_scopes):
- 4:28 PM Changeset in webkit [49408] by
-
- 3 edits in trunk/WebCore
[v8] Need change to V8WorkerContextEventListener::reportError signature to match the base class.
https://bugs.webkit.org/show_bug.cgi?id=30264
Patch by David Levin <levin@chromium.org> on 2009-10-09
Reviewed by Eric Seidel.
The base class method changed in r48884.
Test: fast/worker/worker-script-error.html
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::reportError):
- bindings/v8/V8WorkerContextEventListener.h:
- 3:45 PM Changeset in webkit [49407] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix bad ChangeLog entry merge in r49019 by the commit queue script.
- 3:29 PM Changeset in webkit [49406] by
-
- 6 edits10 adds in trunk
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=30260
<rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work
Tests: http/tests/xmlhttprequest/logout.html
http/tests/xmlhttprequest/re-login-async.html
http/tests/xmlhttprequest/re-login.html
Fix several issues with existing credential handling code.
- platform/network/CredentialStorage.cpp: (WebCore::pathToDefaultProtectionSpaceMap): Changed the data structure to a simpler one. (WebCore::originsWithCredentials): The reason for two-stage lookup above was that we didn't want to iterate paths for origins that never had credentials associated with them. Changed to use a separate HashSet for this. (WebCore::pathToDefaultProtectionSpaceMap): The concept of default per-path credentials didn't match the spec very well. UAs are supposed to deduce protection space from an URL, and then use whichever credentials are known for this protection space. So, OriginToDefaultBasicCredentialMap is now PathToDefaultProtectionSpaceMap. (WebCore::protectionSpaceMapKeyFromURL): Factored out a helper that extracts a directory URL from a given URL. These directory URLs are what we use as keys in PathToDefaultProtectionSpaceMap. (WebCore::CredentialStorage::set): Updated for above changes. (WebCore::findDefaultProtectionSpaceForURL): Factored out code iterating path length to find a prefix in OriginToDefaultBasicCredentialMap. (WebCore::CredentialStorage::set): Another version of set() can update credentials for a URL default protection space. It does nothing if the given URL doesn't correspond to a known protection space. (WebCore::CredentialStorage::get): Renamed from getDefaultAuthenticationCredential.
- platform/network/CredentialStorage.h: Made the distinction between methods that use a known protection space and those that deduce one from URL more clear.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Update credentials before starting the request for real. This makes the following pattern work: var req = new XMLHttpRequest("GET", "logout.html", "logout", "logout"); wrong credentials req.send(""); req.abort(); Abort() is used here to avoid having UA present an auth dialog after getting a 401 response. Note that one cannot log in using the same method, because there isn't a known protection space for the URL yet in that case, so the added code has no effect. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Use a correct persistence for calling receivedCredential(). This fixes logging in using an async XHR (withut abort(), of course), and matches sync case. (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Renamed getDefaultAuthenticationCredential() to get().
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): (WebCore::WebCoreSynchronousLoader::load): Same changes as in Mac code.
- 3:01 PM Changeset in webkit [49405] by
-
- 14 edits4 adds in trunk
2009-10-09 Enrica Casucci <enrica@apple.com>
Reviewed by Adele Peterson.
Undoing a indent removes text instead of it's formatting.
<rdar://problem/7169206>
https://bugs.webkit.org/show_bug.cgi?id=28722
Added test case for https://bugs.webkit.org/show_bug.cgi?id=23995
- editing/execCommand/19653-1-expected.txt: Re-baselined.
- editing/execCommand/indent-div-inside-list-expected.txt: Re-baselined.
- editing/execCommand/indent-nested-blockquotes-expected.txt: Re-baselined.
- editing/execCommand/indent-nested-div-expected.txt: Re-baselined.
- editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Re-baselined.
- editing/execCommand/indent-with-style-expected.txt: Added.
- editing/execCommand/indent-with-style.html: Added.
- editing/undo/undo-indent-expected.txt: Added.
- editing/undo/undo-indent.html: Added.
- platform/mac/editing/execCommand/4641880-2-expected.txt: Re-baselined.
- platform/mac/editing/execCommand/4916541-expected.txt: Re-baselined.
- platform/mac/editing/execCommand/5138441-expected.txt: Re-baselined.
- platform/mac/editing/execCommand/5481523-expected.txt: Re-baselined.
- platform/mac/editing/execCommand/indent-selection-expected.txt: Re-baselined.
2009-10-09 Enrica Casucci <enrica@apple.com>
Reviewed by Adele Peterson.
Undoing a indent removes text instead of it's formatting.
<rdar://problem/7169206>
https://bugs.webkit.org/show_bug.cgi?id=28722
Restored the behavior prior to http://trac.webkit.org/changeset/46143. This change implemented the
indent command making simple DOM operation, without using moveParagraph which cause undo to be broken.
Added editing/undo/undo-indent.html test.
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Restored. (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Merged changes. (WebCore::IndentOutdentCommand::indentIntoBlockquote): Restored. (WebCore::IndentOutdentCommand::indentRegion): Restored and added call to updateLayout to ensure TextIterator could correctly calculate the position starting from the index.
- editing/IndentOutdentCommand.h: Restored.
- 2:24 PM Changeset in webkit [49404] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-10-09 Rimas Kudelis <rq@akl.lt>
Rubber-stamped by Gustavo Noronha
https://bugs.webkit.org/show_bug.cgi?id=30054
Localization of WebKit GTK into Lithuanian
- lt.po: Added.
- 2:24 PM Changeset in webkit [49403] by
-
- 2 edits in trunk/WebCore
2009-10-09 Jens Alfke <snej@chromium.org>
Reviewed by Darin Adler.
Optimization: Many StringImpl transformations are no-ops and should just return 'this'
https://bugs.webkit.org/show_bug.cgi?id=30186
Optimized StringImpl methods lower(), stripWhiteSpace() and simplifyWhiteSpace() to
detect no-ops and return this instead of creating a new instance.
Empirical testing shows that the majority of calls to these methods are no-ops, making
this worthwhile even if (in the case of lower()) the non-no-op case is slightly slowed.
Upper() is very rarely a no-op, so it wasn't worthwhile to optimize it.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): Just add a comment explaining why this wasn't optimized (WebCore::StringImpl::stripWhiteSpace): (WebCore::StringImpl::simplifyWhiteSpace):
- 1:51 PM Changeset in webkit [49402] by
-
- 6 edits4 adds in trunk
2009-10-09 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
SVG Filter feGaussianBlur implementation is missing
https://bugs.webkit.org/show_bug.cgi?id=28141
This is the implementation of GaussianBlur filter for SVG.
There is already a test for feGaussianBlur
Test: svg/W3C-SVG-1.1/filters-gauss-01-b-w3c.svg
Test: svg/filters/feGaussianBlur.svg
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
- platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::isAlphaImage): (WebCore::FilterEffect::setIsAlphaImage):
- platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
- svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::boxBlur): (WebCore::FEGaussianBlur::apply):
Test for feGaussianBlur implementation
- platform/mac/svg/filters/feGaussianBlur-expected.checksum: Added.
- platform/mac/svg/filters/feGaussianBlur-expected.png: Added.
- platform/mac/svg/filters/feGaussianBlur-expected.txt: Added.
- svg/filters/feGaussianBlur.svg: Added.
- 12:37 PM Changeset in webkit [49401] by
-
- 4 edits in trunk/WebCore
2009-10-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] QoS support in the video sink
https://bugs.webkit.org/show_bug.cgi?id=29959
Removed the async buffer queue from the sink. Synchronize the
render method of the sink using a g_timeout_add() combined with a
gcond triggered when the buffer has been rendered.
Also fixed the video sink reference handling in the player, now
that the idle is not there anymore to mess up things.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_init): (webkit_video_sink_timeout_func): (webkit_video_sink_render): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (webkit_video_sink_stop): (webkit_video_sink_class_init):
- 12:13 PM Changeset in webkit [49400] by
-
- 19 edits6 adds in trunk
2009-10-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
feMorphology filter is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5863
Adds SVGFEMorphologyElement, for the SVG filter. It also fixes a bug
with the attribute "operator". It was only accessible via "_operator"
on JavaScript.
Test: svg/dom/operatorAttribute.xhtml
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.SVG.Filters.exp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm: (WebCore::createElementClassMap):
- bindings/objc/DOMSVG.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- page/DOMWindow.idl:
- svg/SVGAllInOne.cpp:
- svg/SVGFECompositeElement.idl:
- svg/SVGFEMorphologyElement.cpp: Added. (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::~SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::setRadius): (WebCore::SVGFEMorphologyElement::parseMappedAttribute): (WebCore::SVGFEMorphologyElement::build):
- svg/SVGFEMorphologyElement.h: Added.
- svg/SVGFEMorphologyElement.idl: Added.
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::operator<<):
- svg/graphics/filters/SVGFEMorphology.h: (WebCore::):
- svg/svgtags.in:
Reviewed by Nikolas Zimmermann.
Attribute "operator" schould only be accessible by "operator", not by "_operator"
- svg/dom/operatorAttribute-expected.txt: Added.
- svg/dom/operatorAttribute.html: Added.
- svg/dom/script-tests/operatorAttribute.js: Added.
- 12:12 PM Changeset in webkit [49399] by
-
- 2 edits in trunk/WebCore
2009-10-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Dimitri Glazkov.
Fix Chromium breakage.
- inspector/front-end/inspector.js: (WebInspector.addCookieDomain): check that Storage panel is present before calling its methods.
- 11:14 AM Changeset in webkit [49398] by
-
- 9 edits in trunk/JavaScriptCore
Migrated some code that didn't belong out of Structure.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-09
Reviewed by Sam Weinig.
SunSpider says maybe 1.03x faster.
- runtime/JSCell.h: Nixed Structure::markAggregate, and made marking of
a Structure's prototype the direct responsility of the object using it.
(Giving Structure a mark function was misleading because it implied that
all live structures get marked during GC, when they don't.)
- runtime/JSGlobalObject.cpp:
(JSC::markIfNeeded):
(JSC::JSGlobalObject::markChildren): Added code to mark prototypes stored
on the global object. Maybe this wasn't necessary, but now we don't have
to wonder.
- runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::getEnumerableNamesFromClassInfoTable):
- runtime/JSObject.h:
(JSC::JSObject::markChildrenDirect):
- runtime/PropertyNameArray.h:
- runtime/Structure.cpp:
- runtime/Structure.h:
(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache): Moved property name gathering code
from Structure to JSObject because having a Structure iterate its JSObject
was a layering violation. A JSObject is implemented using a Structure; not
the other way around.
- 10:31 AM Changeset in webkit [49397] by
-
- 7 edits in trunk
2009-10-09 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
Sets Qt::WA_InputMethodEnabled and Qt::ImhHiddenText for password fields in EditorClientQt
setInputMethodState. This change is needed so widgets such as the s60 software
input panel can receive input method events for password fields.
It's up to the Qt platform to determine which widget will receive input method
events when these flags are set.
Also added implementation for setInputMethodEnabled and setInputMethodHint
to QGraphicsWebViewPrivate and QWebViewPrivate. This change removes the direct
dependency on QWebView and uses QWebPageClient.
Added autotest to tst_qwebpage.cpp
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::setInputMethodEnabled): (QGraphicsWebViewPrivate::setInputMethodHint):
- Api/qwebview.cpp: (QWebViewPrivate::setInputMethodEnabled): (QWebViewPrivate::setInputMethodHint):
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
2009-10-09 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Added pure virtual methods setInputMethodEnabled and setInputMethodHint to QWebPageClient
- platform/qt/QWebPageClient.h:
- 10:26 AM Changeset in webkit [49396] by
-
- 1 edit3 moves in trunk/LayoutTests
Requested by Mark Rowe.
Patch by Darin Adler <Darin Adler> on 2009-10-09
Moved DOM test that was in fast/js to fast/dom where it belongs.
- fast/dom/Document/invalid-domain-change-throws-exception-expected.txt:
Copied from fast/js/invalid-domain-change-throws-exception-expected.txt.
- fast/dom/Document/invalid-domain-change-throws-exception.html:
Copied from fast/js/invalid-domain-change-throws-exception.html.
Regenerated with the make-script-test-wrappers.
- fast/dom/Document/script-tests/invalid-domain-change-throws-exception.js:
Copied from fast/js/resources/invalid-domain-change-throws-exception.js.
- fast/js/invalid-domain-change-throws-exception-expected.txt: Removed.
- fast/js/invalid-domain-change-throws-exception.html: Removed.
- fast/js/resources/invalid-domain-change-throws-exception.js: Removed.
- 10:20 AM Changeset in webkit [49395] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog patch reviewer to be accurate.
- 10:03 AM Changeset in webkit [49394] by
-
- 11 edits2 adds in trunk
Implement beforeload for images. ImageLoadEventSender has been refactored into a more generic
ImageEventSender that can be used by both load and beforeload events. If the document has any
beforeload listeners, then the installation of images onto the renderer becomes asynchronous
and will be held up until the beforeload event can fire at a later date.
Reviewed by Adam Roben.
Both beforeload and load events now fire at the end of the tokenizer write() methods, so that
in the typical parsing case we don't have to put off the beforeload/load events until after
a layout or paint might already have happened. This lets beforeload/load not cause extra
layouts and repaints.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::dispatchBeforeLoadEvent):
- dom/Document.cpp:
(WebCore::Document::implicitClose):
(WebCore::Document::addListenerTypeIfNeeded):
- dom/Document.h:
(WebCore::Document::):
- dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::write):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::attach):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attach):
- html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::write):
- loader/ImageLoader.cpp:
(WebCore::ImageBeforeLoadEventSender::ImageBeforeLoadEventSender):
(WebCore::ImageLoadEventSender::ImageLoadEventSender):
(WebCore::beforeLoadEventSender):
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::setLoadingImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingEvents):
(WebCore::ImageEventSender::ImageEventSender):
(WebCore::ImageEventSender::dispatchEventSoon):
(WebCore::ImageEventSender::cancelEvent):
(WebCore::ImageEventSender::dispatchPendingEvents):
(WebCore::ImageEventSender::timerFired):
- loader/ImageLoader.h:
(WebCore::ImageLoader::haveFiredBeforeLoadEvent):
- wml/WMLImageElement.cpp:
(WebCore::WMLImageElement::attach):
- 9:36 AM Changeset in webkit [49393] by
-
- 2 edits in trunk/WebCore
2009-10-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
Web Inspector: Wrap Database into ScriptObject in v8 bindings.
No tests due to no Script* test infrastructure.
- bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
- 9:35 AM Changeset in webkit [49392] by
-
- 3 edits in trunk/WebKit/mac
Add SPI to specifically enable visited link tracking.
Reviewed by Dan Bernstein.
- History/WebHistory.mm:
(+[WebHistory _setVisitedLinkTrackingEnabled:]):
- History/WebHistoryPrivate.h:
- 7:58 AM Changeset in webkit [49391] by
-
- 2 edits in trunk/WebCore
2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
[Qt] Windowless Plugins : Fix crash when using QWebPage without QWebView.
'client' is 0 when we have no view.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):
- 7:51 AM Changeset in webkit [49390] by
-
- 3 edits in trunk/LayoutTests/platform/mac
Set the svn:mime-type property of recently-added PNG files to image/png.
- 5:47 AM Changeset in webkit [49389] by
-
- 2 edits in trunk/WebCore
2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
[Qt] Plugins : Add missing setCurrentPlugin(0)
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent):
- 5:32 AM Changeset in webkit [49388] by
-
- 2 edits in trunk/WebCore
2009-10-09 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] beforeload event does not fire on script elements in XML
https://bugs.webkit.org/show_bug.cgi?id=30235
r49194 was lacking a change to XMLTokenizerQt.cpp, equivalent to the one
made in XMLTokenizerLibxml2.cpp.
- dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
- 5:12 AM Changeset in webkit [49387] by
-
- 2 edits in trunk/WebCore
2009-10-09 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore's CSSParserValueList
https://bugs.webkit.org/show_bug.cgi?id=30249
Inherits CSSParserValueList class from FastAllocBase because it has
been instantiated by 'new' in WebCore/css/CSSGrammar.y:1271.
- css/CSSParserValues.h:
- 4:32 AM Changeset in webkit [49386] by
-
- 2 edits in trunk/WebCore
2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
[Qt] Windowless Plugins : Create Pixmap only when size changes.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
- 2:36 AM Changeset in webkit [49385] by
-
- 25 edits in trunk
Remove the WebKitPluginHalterEnabledPreferenceKey in favor of checking
for the existence of a PluginHalterDelegate.
This fixes a leak of WebPluginHalterClients:
https://bugs.webkit.org/show_bug.cgi?id=30119.
WebCore:
Reviewed by Dan Bernstein.
- WebCore.base.exp:
Removed the export of WebCore::Settings::setPluginHalterEnabled().
- loader/EmptyClients.h:
(WebCore::EmptyPluginHalterClient::enabled):
- page/Page.cpp:
(WebCore::Page::Page):
Remove initialization of m_pluginHalterClient, which was removed. If a
non-null PluginHalterClient was passed, create the PluginHalter, and
set its allowed run time.
- page/Page.h:
Removed pluginHalterEnabledStateChanged() and m_pluginHalterClient.
- page/PluginHalter.cpp:
(WebCore::PluginHalter::didStartPlugin):
Check whether the PluginHalterClient is enabled.
(WebCore::PluginHalter::didStopPlugin):
Ditto.
- page/PluginHalter.h:
Made m_client an OwnPtr.
- page/PluginHalterClient.h:
Added a function to return the enabled state.
- page/Settings.cpp:
(WebCore::Settings::Settings):
Remove initialization of removed member.
- page/Settings.h:
Removed settings for the enabled state of the PluginHalter; we now use
the existence of a WebPluginHalterDelegate to determine whether the
PluginHalter is enabled.
WebKit/mac:
- WebCoreSupport/WebPluginHalterClient.h:
Add declaration for new function.
- WebCoreSupport/WebPluginHalterClient.mm:
(WebPluginHalterClient::enabled):
Check whether the UIDelegate responds to shouldHaltPlugin.
- WebView/WebPreferenceKeysPrivate.h:
Remove the "enabled" preference key.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Remove the initialization of the pref.
- WebView/WebPreferencesPrivate.h:
Remove the getter/setter for this pref.
- WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
Remove propagation of the pref.
WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
Remove the getter and setter.
- WebCoreSupport/WebPluginHalterClient.cpp:
(WebPluginHalterClient::enabled):
Return true if the delegate exists.
- WebCoreSupport/WebPluginHalterClient.h:
Declare implementation of enabled().
- WebPreferenceKeysPrivate.h:
Removed the pref key.
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
Removed initialization of the pref.
- WebPreferences.h:
Removed declaration of the getter/setter.
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Don't propagate the pref.
- 1:59 AM Changeset in webkit [49384] by
-
- 2 edits in trunk/JavaScriptCore
Attempt to fix the GTK release build.
- GNUmakefile.am: Include Grammar.cpp in release builds now that
AllInOneFile.cpp is gone.
- 12:50 AM Changeset in webkit [49383] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-09 Gabor Loki <loki@inf.u-szeged.hu>
Rubber-stamped by Eric Seidel.
Add ARM JIT support for Gtk port (disabled by default)
https://bugs.webkit.org/show_bug.cgi?id=30228
- GNUmakefile.am:
