⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 12, 2009:

11:11 PM Changeset in webkit [49492] by eric@webkit.org
  • 6 edits in trunk

2009-10-12 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Missing default value for the default text encoding.
​https://bugs.webkit.org/show_bug.cgi?id=30311

QtWebKit has provided a default, hardcoded value for default charset but since
the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
value has had no effect.

Added a regression test and unskipped fast/dom/Document/document-charset.html,
which is passing now.

  • platform/qt/Skipped:

2009-10-12 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Missing default value for the default text encoding.
​https://bugs.webkit.org/show_bug.cgi?id=30311

QtWebKit has provided a default, hardcoded value for default charset but since
the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
value has had no effect.

Added a regression test and unskipped fast/dom/Document/document-charset.html,
which is passing now.

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::defaultTextEncoding):
10:38 PM Changeset in webkit [49491] by cam@webkit.org
  • 2 edits in trunk/WebKitSite

Change <a name> to id="" to fix styling problems
​https://bugs.webkit.org/show_bug.cgi?id=30283

Reviewed by Eric Seidel.

This prevents the headings from being styled like links.

  • coding/contributing.html:
9:59 PM Changeset in webkit [49490] by eric@webkit.org
  • 7 edits in trunk

2009-10-12 Xiaomei Ji <​xji@chromium.org>

Reviewed by Sam Weinig.

Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
scrolled page.
​https://bugs.webkit.org/show_bug.cgi?id=30034

  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
  • fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
  • fast/dom/elementFromPoint-relative-to-viewport.html:

2009-10-12 Xiaomei Ji <​xji@chromium.org>

Reviewed by Sam Weinig.

Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
scrolled page.
​https://bugs.webkit.org/show_bug.cgi?id=30034

  • dom/Document.cpp: (WebCore::Document::elementFromPoint): calculate the correct point relative to document when the page is zoomed and scrolled. (WebCore::Document::caretRangeFromPoint): calculate the correct point relative to document when the page is zoomed and scrolled.
9:22 PM Changeset in webkit [49489] by ukai@chromium.org
  • 5 edits in trunk/LayoutTests

2009-10-12 Fumitoshi Ukai <​ukai@chromium.org>

Unreviewed. Fix 4 layout test failures by webkit r49488

WebKit r49488 enables window.WebSocket back.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
6:44 PM Changeset in webkit [49488] by ukai@chromium.org
  • 9 edits
    6 adds in trunk

WebCore: JavaScript bindings of WebSocket addEventListener/removeEventListener
​https://bugs.webkit.org/show_bug.cgi?id=29841

Patch by Fumitoshi Ukai <​ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).

Test: fast/websockets/websocket-event-target.html

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • websockets/WebSocket.idl:

WebKitTools: Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
​https://bugs.webkit.org/show_bug.cgi?id=29841

Patch by Fumitoshi Ukai <​ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests: Add a test to verify WebSocket's EventTarget methods.
​https://bugs.webkit.org/show_bug.cgi?id=29841

Patch by Fumitoshi Ukai <​ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).

  • fast/websockets/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/canvas/script-tests/TEMPLATE.html.
  • fast/websockets/script-tests/websocket-event-target.js: Added.

(openListener):
(messageListener):
(closeListener):

  • fast/websockets/websocket-event-target-expected.txt: Added.
  • fast/websockets/websocket-event-target.html: Added.
5:47 PM Changeset in webkit [49487] by weinig@apple.com
  • 5 edits
    13 deletes in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=29078
<rdar://problem/7288221>

Reviewed by Darin Adler.

WebCore:

Add a mechanism to blacklist certain codecs. Initially, just blacklist UTF-7 as HTML5 encourages.

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::pruneBlacklistedCodecs):
(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):

LayoutTests:

Test the lack of UTF-7 support. Remove old UTF-7 tests.

  • fast/encoding/char-decoding-expected.txt:
  • fast/encoding/char-decoding.html:
  • http/tests/misc/submit-get-in-utf7-expected.txt: Removed.
  • http/tests/misc/submit-get-in-utf7.html: Removed.
  • http/tests/misc/submit-post-in-utf7-expected.txt: Removed.
  • http/tests/misc/submit-post-in-utf7.html: Removed.
  • http/tests/misc/url-in-utf7-expected.txt: Removed.
  • http/tests/misc/url-in-utf7.html: Removed.
  • http/tests/security/xssAuditor/http-equiv-utf-7-encoded-expected.txt: Removed.
  • http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html: Removed.
  • http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Removed.
  • http/tests/security/xssAuditor/script-tag-utf-7-encoded-expected.txt: Removed.
  • http/tests/security/xssAuditor/script-tag-utf-7-encoded.html: Removed.
  • http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Removed.
  • http/tests/security/xssAuditor/script-tag-utf-7.html: Removed.
5:37 PM Changeset in webkit [49486] by hyatt@apple.com
  • 9 edits
    2 adds in trunk

Add support for the beforeload event to frames. Complete support of the beforeload event by making sure
its wrapper gets properly constructed (so that the URL field of the event can be accessed). Add support
for the Objective-C wrapper class as well.

Reviewed by Darin Adler.

Added fast/dom/beforeload/frame-before-load.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/objc/DOMEvents.mm:

(kitClass):

  • dom/BeforeLoadEvent.h:

(WebCore::BeforeLoadEvent::isBeforeLoadEvent):

  • dom/Event.cpp:

(WebCore::Event::isBeforeLoadEvent):

  • dom/Event.h:
  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseMappedAttribute):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadWithDocumentLoader):

5:27 PM Changeset in webkit [49485] by eric@webkit.org
  • 5 edits in trunk

2009-10-12 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium Port - Windows
​https://bugs.webkit.org/show_bug.cgi?id=29969

  • chromium/DEPS: Added gtest dep required by windows and incremented some of the deps revisions.

2009-10-12 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium Port - Windows
​https://bugs.webkit.org/show_bug.cgi?id=29969

  • Scripts/pdevenv: removed msvc's /useenv for chromium builds
  • Scripts/webkitdirs.pm:
5:15 PM BuildingQtOnLinux edited by sch@eecs.berkeley.edu
added error relating to phonon (diff)
4:49 PM Changeset in webkit [49484] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore: Fix <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()

Reviewed by Simon Fraser.

Test: fast/dynamic/position-absolute-to-fixed-crash.html

The crash was caused by stale positioned objects lists following an
object transitioning from being absolutely position to being fixed
positioned.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange): In case of a transition between
absolute and fixed position, mark the parent as having a child needing
layout, so that this object will get inserted into its new container's
positioned objects list.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange): Changed a condition to cover
this transition, so that this object gets removed from its current
container's positioned objects list.

LayoutTests: Test for <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()

Reviewed by Simon Fraser.

  • fast/dynamic/position-absolute-to-fixed-crash-expected.txt: Added.
  • fast/dynamic/position-absolute-to-fixed-crash.html: Added.
4:20 PM Changeset in webkit [49483] by eric@webkit.org
  • 5 edits in trunk

2009-10-12 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Hausmann.

Add a palette() method that is needed by our RenderTheme.

  • platform/qt/QWebPageClient.h:

2009-10-12 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Hausmann.

Implement the new palette() methods on the page clients

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::palette):
  • Api/qwebview.cpp: (QWebViewPrivate::palette):
4:16 PM Changeset in webkit [49482] by mrowe@apple.com
  • 1 edit in branches/safari-4-branch/WebCore/dom/Element.cpp

Fix release builds.

4:05 PM Changeset in webkit [49481] by eric@webkit.org
  • 9 edits
    4 adds in trunk

2009-10-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Three old test results give back the absolute position instead of the realtive position.
The new test will check the correct behavior of gradients in userSpaceOnUse mode and
values in percentage.

  • platform/mac/svg/custom/gradient-attr-update-expected.txt:
  • platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Added.
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Added.
  • platform/mac/svg/custom/text-gradient-no-content-expected.txt:
  • svg/custom/gradient-userSpaceOnUse-with-percentage.svg: Added.

2009-10-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Gradients can't handle percentage values in userSpaceOnUse mode
​https://bugs.webkit.org/show_bug.cgi?id=30286

Fixed *GradientAttributes to take SVGLength instead of double. This casues
the problem, that we can't calculate the correct size of a gradient on
userSpaceOnUse mode with percentage values.

Test: svg/custom/gradient-userSpaceOnUse-with-percentage.svg

  • svg/LinearGradientAttributes.h: (WebCore::LinearGradientAttributes::LinearGradientAttributes): (WebCore::LinearGradientAttributes::x1): (WebCore::LinearGradientAttributes::y1): (WebCore::LinearGradientAttributes::x2): (WebCore::LinearGradientAttributes::y2): (WebCore::LinearGradientAttributes::setX1): (WebCore::LinearGradientAttributes::setY1): (WebCore::LinearGradientAttributes::setX2): (WebCore::LinearGradientAttributes::setY2):
  • svg/RadialGradientAttributes.h: (WebCore::RadialGradientAttributes::RadialGradientAttributes): (WebCore::RadialGradientAttributes::cx): (WebCore::RadialGradientAttributes::cy): (WebCore::RadialGradientAttributes::r): (WebCore::RadialGradientAttributes::fx): (WebCore::RadialGradientAttributes::fy): (WebCore::RadialGradientAttributes::setCx): (WebCore::RadialGradientAttributes::setCy): (WebCore::RadialGradientAttributes::setR): (WebCore::RadialGradientAttributes::setFx): (WebCore::RadialGradientAttributes::setFy):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient): (WebCore::SVGLinearGradientElement::collectGradientProperties):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient): (WebCore::SVGRadialGradientElement::collectGradientProperties):
3:39 PM Changeset in webkit [49480] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch/WebCore

Merge r49218.

3:33 PM Changeset in webkit [49479] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Fixes <​http://webkit.org/b/30315>.
Web Inspector: DOM Content and Load lines in Resources are unclear what they mean.

Reviewed by Timothy Hatcher.

Add tooltip text to the Load event and DOM Content event lines through
a new layer that allows these lines to be on top of the view.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
(WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition):

  • inspector/front-end/inspector.css:
3:32 PM Changeset in webkit [49478] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch/WebKit

Merge r48946.

3:32 PM Changeset in webkit [49477] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r47883.

3:25 PM Changeset in webkit [49476] by Csaba Osztrogonác
  • 6 edits in trunk/WebKitTools

jsc scripts cleanup and Qt/GTK fix
​https://bugs.webkit.org/show_bug.cgi?id=30288

Patch by Csaba Osztrogonac <Csaba Osztrogonác> on 2009-10-12
Reviewed by Darin Adler.

Duplicated jscPath() moved to webkitdirs.pm.
New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
Configuration added (release/debug) to path for Qt-port on Windows.

  • Scripts/run-javascriptcore-tests:
  • Scripts/run-jsc:
  • Scripts/run-sunspider:
  • Scripts/sunspider-compare-results:
  • Scripts/webkitdirs.pm:
3:25 PM Changeset in webkit [49475] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48787.

3:25 PM Changeset in webkit [49474] by mrowe@apple.com
  • 6 edits in branches/safari-4-branch

Merge r48775.

2:30 PM Changeset in webkit [49473] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-10-12 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r49429, because it broke layout tests.
​http://trac.webkit.org/changeset/49429

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
2:15 PM Changeset in webkit [49472] by krit@webkit.org
  • 3 edits
    4 adds in trunk

2009-10-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

SVG - crash on feMerge when input not available
​https://bugs.webkit.org/show_bug.cgi?id=30297

Make a early return in SVGFEMergeElement if the needed
filter effect doesn't exist.

Test: svg/filters/feMerge-wrong-input.svg

  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):

2009-10-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Eirc Seidel.

feMergeNod has a reference to an effect that doesn't exist. This test will
check if SVGFEMergeElement handles this correctly and stops the filter process.

  • svg/filters/feMerge-wrong-input-expected.checksum: Added.
  • svg/filters/feMerge-wrong-input-expected.png: Added.
  • svg/filters/feMerge-wrong-input-expected.txt: Added.
  • svg/filters/feMerge-wrong-input.svg: Added.
2:07 PM Changeset in webkit [49471] by mrowe@apple.com
  • 3 edits
    18 adds in branches/safari-4-branch

Merge r48572.

2:07 PM Changeset in webkit [49470] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-4-branch

Merge r47801.

2:07 PM Changeset in webkit [49469] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-4-branch/WebCore

Merge r47771.

2:00 PM Changeset in webkit [49468] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48848.

2:00 PM Changeset in webkit [49467] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48547.

2:00 PM Changeset in webkit [49466] by mrowe@apple.com
  • 5 edits
    4 adds in branches/safari-4-branch

Merge r48546.

2:00 PM Changeset in webkit [49465] by mrowe@apple.com
  • 3 edits
    8 adds in branches/safari-4-branch

Merge r47900.

2:00 PM Changeset in webkit [49464] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r48743.

1:49 PM Changeset in webkit [49463] by mrowe@apple.com
  • 10 edits
    4 adds in branches/safari-4-branch

Merge r46136.

1:49 PM Changeset in webkit [49462] by mrowe@apple.com
  • 5 edits in branches/safari-4-branch/WebCore

Merge r47509.

1:42 PM Changeset in webkit [49461] by Csaba Osztrogonác
  • 1 edit in trunk/WebKitTools/Scripts/modules/committers.py

2009-10-12 Csaba Osztrogonac <Csaba Osztrogonác>

Unreviewed. Added myself to committers.py.

  • Scripts/modules/committers.py:
1:42 PM Changeset in webkit [49460] by mrowe@apple.com
  • 6 edits
    24 adds in branches/safari-4-branch

Merge r48647.

1:42 PM Changeset in webkit [49459] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46521.

1:38 PM Changeset in webkit [49458] by mrowe@apple.com
  • 6 edits in branches/safari-4-branch

Merge r47551.

1:38 PM Changeset in webkit [49457] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebKit/mac

Merge r47300.

1:34 PM Changeset in webkit [49456] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48957.

1:34 PM Changeset in webkit [49455] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48956.

1:34 PM Changeset in webkit [49454] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r48953.

1:33 PM Changeset in webkit [49453] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-4-branch

Merge r46548.

1:19 PM Changeset in webkit [49452] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48369.

1:19 PM Changeset in webkit [49451] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebKit/mac

Merge r47657.

1:19 PM Changeset in webkit [49450] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46058.

1:19 PM Changeset in webkit [49449] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r45945.

1:19 PM Changeset in webkit [49448] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48725.

1:03 PM WebKit Team edited by Csaba Osztrogonác
(diff)
1:00 PM Changeset in webkit [49447] by cmarrin@apple.com
  • 19 edits
    3 adds in trunk

Added automatic flush before compositing
​https://bugs.webkit.org/show_bug.cgi?id=30236

This causes image to always render correctly. In writing a testcase
I needed to implement readPixels. This exposed a bug in reading back
values from a CanvasArray subclass, so I fixed that as well. Now when
you wrap a CanvasArray in a JSValue it actually wraps the specific
subclass. To do this I need to add virtual methods to each CanvasArray
subclass to determine the type and a custom toJS method for CanvasArray
to create the proper wrapper.

Test: fast/canvas/webgl/triangle.html

12:38 PM Changeset in webkit [49446] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Update Fedora httpd.conf settings to closely match the generic httpd.conf
​https://bugs.webkit.org/show_bug.cgi?id=30302

Closely match the default httpd.conf for layout tests.

  • http/conf/fedora-httpd.conf:
11:09 AM Changeset in webkit [49445] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-12 Sebastian Dröge <​sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=30307

Fix 0 sentinel for g_object_set() function call.

  • platform/graphics/gtk/DataSourceGStreamer.cpp: (webkit_data_src_uri_set_uri): 0 is passed as 32 bit value on x86-64 in vararg functions, but g_object_set() expects a 64 bit 0. This will cause crashes.
11:05 AM Changeset in webkit [49444] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Remove unnecessary self-include.

  • webkit/webkitsecurityorigin.h:
9:29 AM Changeset in webkit [49443] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-10-12 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Video keeps playing after going fullscreen, then closing window
​https://bugs.webkit.org/show_bug.cgi?id=30164

Clear the QTMovie on the QTMovieView when coming out of fullscreen,
to fix issue where the underlying movie keeps playing.

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidExitFullscreen]):
8:52 AM Changeset in webkit [49442] by eric@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

2009-10-12 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Tor Arne Vestbø.

[Qt] Add expected files for new passing fast tests.

  • platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
  • platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
  • platform/qt/fast/css/text-rendering-expected.txt: Added.
  • platform/qt/fast/forms/basic-buttons-expected.txt: Added.
  • platform/qt/fast/forms/basic-inputs-expected.txt: Added.
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt: Added.
  • platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.
8:26 AM Changeset in webkit [49441] by krit@webkit.org
  • 7 edits
    3 adds in trunk

2009-10-12 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop in="" from <feFlood>
​https://bugs.webkit.org/show_bug.cgi?id=29001

This makes <feFlood in="bogus"> have an effect, too.

​http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute

Test: svg/dom/feFlood-no-in1.html

  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFloodElement.idl:
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::FEFlood): (WebCore::FEFlood::create):
  • svg/graphics/filters/SVGFEFlood.h:

LayoutTest:

Drop in="" from <feFlood>
​https://bugs.webkit.org/show_bug.cgi?id=29001

This makes <feFlood in="bogus"> have an effect, too.

​http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute

  • svg/dom/feFlood-no-in1-expected.txt: Added.
  • svg/dom/feFlood-no-in1.html: Added.
  • svg/dom/script-tests/feFlood-no-in1.js: Added.
8:05 AM Changeset in webkit [49440] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-10-12 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

QWebPage's createViewlessPlugin autotest crash fix.

It is possible that plugins that are QWidgets or QGraphicsWidgets
are created before a view has been assigned to a QWebPage. The
plug-ins won't be fully functional, as by design, they should
visualise something, but they won't crash and will stay in memory.

An autotest that covers this use-case, is included.

​https://bugs.webkit.org/show_bug.cgi?id=30118

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
  • tests/qwebpage/tst_qwebpage.cpp: (PluginTrackedPageWidget::PluginTrackedPageWidget): (PluginTrackedPageGraphicsWidget::PluginTrackedPageGraphicsWidget): (PluginTrackedPageGraphicsWidget::createPlugin): (tst_QWebPage::destroyPlugin): (tst_QWebPage::createViewlessPlugin):
7:34 AM Changeset in webkit [49439] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-12 Sebastian Dröge <​sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=29998

Scale video to completely fill the target surface while
keeping the aspect ratio. This fixes displaying of the
YouTube HTML5 sample website.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Scale video to completely fill the target surface, keep the aspect ratio and center it.
7:18 AM Changeset in webkit [49438] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-10-12 Sebastian Dröge <​sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=29997

Fixes double memcpy of all rendered video frames.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::duration):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (marshal_VOIDMINIOBJECT): (webkit_video_sink_class_init): (webkit_video_sink_new):
  • platform/graphics/gtk/VideoSinkGStreamer.h: Directly pass the buffers up to the MediaPlayerPrivate::paint() method instead of rendering them first to an intermediate cairo surface. This should increase performance and peak memory usage.
7:15 AM Changeset in webkit [49437] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-10-12 Christian Dywan <​christian@twotoasts.de>

Reviewed by Gustavo Noronha.

[GTK] Crash when right-clicking misspelled word
​https://bugs.webkit.org/show_bug.cgi?id=29772

Make sure the dictionary exist before adding it to the list of
dictionaries.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::checkSpellingOfString):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_set_property):
4:56 AM Changeset in webkit [49436] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-10-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Rubberstamped by Eric Seidel.

[Gtk] Fix icu CFLAG for Darwin
​https://bugs.webkit.org/show_bug.cgi?id=29517

Don't escape the srcdir variable. Also use $host instead of the
os_foo variables.

  • autotools/webkit.m4:
4:55 AM Changeset in webkit [49435] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-10-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] Use the SQLite3 headers from WebKitLibraries if sqlite3 is undetected
​https://bugs.webkit.org/show_bug.cgi?id=29518

  • configure.ac:
3:14 AM QtBackLog edited by zecke@selfish.org
Add new items and pointers to them (diff)

Oct 11, 2009:

11:50 PM Changeset in webkit [49434] by dbates@webkit.org
  • 5 edits
    6 adds in trunk

2009-10-11 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=30242


Fixes an issue where JavaScript URLs that are URL-encoded twice can
bypass the XSSAuditor.


JavaScript URLs that are completed by method Document::completeURL have added
URL-encoded characters such that a direct comparison with the URL-decoded
outgoing HTTP parameters is not sufficient. Instead, the URL-decoded outgoing
HTTP parameters must be URL-decoded before comparison.

Tests: http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html

http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL): Modified to pass XSSAuditor the URL-decoded source code for the JavaScript URL.
  • page/XSSAuditor.cpp: (WebCore::isIllegalURICharacter): Minor syntactical change to the comment. (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): Added parameter decodeURLEscapeSequencesTwice. (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::decodeURL): Ditto. (WebCore::XSSAuditor::findInRequest): Ditto.
  • page/XSSAuditor.h: (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): Ditto.

2009-10-11 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=30242


Tests that JavaScript URLs that are twice URL encoded do not bypass the XSSAuditor.

  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html: Added.
9:17 PM Changeset in webkit [49433] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebKit/mac: <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and video chat
doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=30295

Reviewed by Darin Adler.

Test: plugins/setProperty.html

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::setFieldValue): Fixed a typo. The function
should return early if m_instanceProxy is null.

LayoutTests: Test for <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and
video chat doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=30295

Reviewed by Darin Adler.

  • plugins/setProperty-expected.txt: Added.
  • plugins/setProperty.html: Added.
8:30 PM Changeset in webkit [49432] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-10-11 Dominic Cooney <​dominicc@google.com>

Reviewed by Adam Barth.

Fixes a build break in the V8 bindings caused by revision 49420.
​https://bugs.webkit.org/show_bug.cgi?id=30294

Revision 49420 introduces an IDL-defined CanvasActiveInfo
type. This causes a build break in the V8 bindings where
CanvasGraphicsContext3D naively refers to CanvasActiveInfo as a
non-ref type.

  • WebCore.gypi: Include CanvasActiveInfo.idl in build.
  • bindings/scripts/CodeGeneratorV8.pm: CanvasActiveInfo is a ref ptr type.
  • bindings/v8/DOMObjectsInclude.h: Include generated CanvasActiveInfo files.
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
8:15 PM Changeset in webkit [49431] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-11 Collin Jackson <​collinj@webkit.org>

Reviewed by Adam Barth.

Log mixed content warnings to console

​https://bugs.webkit.org/show_bug.cgi?id=30290

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent):
7:53 PM Changeset in webkit [49430] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-11 Adam Barth <​abarth@webkit.org>

Unreviewed. Add Collin to committers.py.

  • Scripts/modules/committers.py:
7:36 PM QtBackLog edited by zecke@selfish.org
(diff)
3:48 PM Changeset in webkit [49429] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-11 Søren Gjesse <​sgjesse@chromium.org>

Reviewed by Adam Barth.

[V8] Add a context scope in JS listener destructor. The destructor code uses the cotext. See ​http://crbug.com/24200.
​https://bugs.webkit.org/show_bug.cgi?id=30250

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
3:34 PM Changeset in webkit [49428] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-11 Lyon Chen <​lyon.chen@torchmobile.com>

Reviewed by Alexey Proskuryakov.

Correct the position of #endif sentence inside WebCore::Document::finishedParsing().

​https://bugs.webkit.org/show_bug.cgi?id=30244

This change requires no test case as it fix a compiling error.

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
3:17 PM Changeset in webkit [49427] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-11 Dominic Cooney <​dominicc@google.com>

Reviewed by Adam Barth.

Sets a 500K stack limit for JavaScript workers in Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=29797

Runaway recursion in JavaScript workers crashes the Chromium
worker process on OS X. This is because V8's default stack limit
is 512K on ia32 or 1M on x64, but the worker process runs workers
on a thread with the OS X default stack size--512K. Because there
are already some C++ frames on the stack when V8 establishes its
512K default stack limit, and V8 doesn't precisely enforce the
stack limit, runaway recursion in V8 workers overflows the OS
stack and segfaults, killing the worker process. This is described
in Chromium bug 21653 <​http://crbug.com/21653>.

This patch sets the V8 stack limit for worker JavaScript in
Chromium to a more conservative 500K on all platforms. This allows
some "headroom" for the C++ stack in use when the limit is set up,
and some "legroom" for the V8 helper functions which in practice
briefly flout the V8 stack limit.

Test: LayoutTests/fast/workers/use-machine-stack.html

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
  • bindings/v8/WorkerContextExecutionProxy.h:
2:30 PM Changeset in webkit [49426] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Re-enable the JIT.

1:01 PM Changeset in webkit [49425] by kevino@webkit.org
  • 4 edits in trunk

wx build fixes, adding bindings to include/source dirs and fixing wxMac 2.9 compilation.

2:46 AM Changeset in webkit [49424] by cam@webkit.org
  • 10 edits
    3 adds in trunk

Allow [Reflect] on SVG elements.
​https://bugs.webkit.org/show_bug.cgi?id=28936

Reviewed by Sam Weinig.

Update the JS binding generators to reference SVGNames instead of
HTMLNames, if [Reflect]ing an attribute on an SVG element. Make
SVGElement::id use [Reflect].

Also make [Reflect] on an attribute with a setter exception work in ObjC
bindings.

WebCore:

Test: svg/dom/id-reflect.html

  • bindings/scripts/CodeGenerator.pm: Add a function to determine the

appropriate C++ namespace for attribute name constants.

  • bindings/scripts/CodeGeneratorObjC.pm: Generate ExceptionCode handling

code for [Reflect] on an attribute with a setter exception.

  • bindings/scripts/CodeGeneratorCOM.pm: Generate "SVGNames" instead of

"HTMLNames" when appropriate.

  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/SVGElement.cpp: Remove getter and setter methods for id.
  • svg/SVGElement.h: Ditto.
  • svg/SVGElement.idl: Add [Reflect] to id.

LayoutTests:

  • svg/dom/script-tests/id-reflect.js: Added.
  • svg/dom/id-reflect-expected.txt: Added.
  • svg/dom/id-reflect.html: Added.
Note: See TracTimeline for information about the timeline view.