Context Navigation

← Previous Period
Next Period →

Timeline

Oct 17, 2009:

11:27 PM Changeset in webkit [49748] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-10-17 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Fix inefficient string concatenation.

LayoutTests/fast/css/large-list-of-rules-crash.html contains code that
concatenate strings in an inefficient way. Concatenation of strings should be
done with Array.join method. This patch fixes this issue, and also fixes typos
in the test.

fast/css/large-list-of-rules-crash.html concatenates strings in an inefficient way
https://bugs.webkit.org/show_bug.cgi?id=30436

fast/css/large-list-of-rules-crash.html:

6:46 PM QtBackLog edited by zecke@selfish.org

(diff)

6:41 PM QtBackLog edited by zecke@selfish.org

(diff)

6:22 PM QtBackLog edited by zecke@selfish.org

(diff)

6:15 PM QtBackLog edited by zecke@selfish.org

(diff)

4:07 PM Changeset in webkit [49747] by mrowe@apple.com

4 edits in trunk

Versioning.

4:06 PM Changeset in webkit [49746] by mrowe@apple.com

1 copy in tags/Safari-532.2

New tag.

3:52 PM Changeset in webkit [49745] by Nikolas Zimmermann

13 edits
2 adds in trunk/WebCore

2009-10-17 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by George Staikos.

Cleanup SVGElement code, preparing for animVal support
https://bugs.webkit.org/show_bug.cgi?id=30466

Add new SynchronizablePropertyController and move the code for SVG property <-> XML attribute synchronization
from SVGElement. This is a further preparation for animVal support, where SynchronizablePropertyController will
be used to control the start/end state of an animated property.

We're currently tracking animated properties that need synchronization, generalize this concept and use
it to track their creation (bound to certain SVG*Element classes) as well as a flag determing the need
of synchronization (no SVG DOM object wrappers, no synchronization needed).

No change in functionality, thus no tests.

GNUmakefile.am: Add 'SynchronizablePropertyController.cpp/h' to build
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
svg/SVGAllInOne.cpp: Ditto.
svg/SVGAnimatedProperty.h: Add registerProperty() function (WebCore::::SVGAnimatedProperty): Call registerProperty() function (WebCore::::registerProperty): Add new registerProperty() function, announcing new properties to SynchronizablePropertyController.
svg/SVGAnimatedTemplate.h: Use propertyController() method, to access the new functions moved from SVGElement. (WebCore::lookupOrCreateWrapper):
svg/SVGElement.cpp: Adapt to code moving to SynchronizablePropertyController. (WebCore::SVGElement::updateAnimatedSVGAttribute):
svg/SVGElement.h: Move handling SVG property synchronization to SynchronizablePropertyController. (WebCore::SVGElement::propertyController): Expose reference to SynchronizablePropertyController object.
svg/SVGViewSpec.cpp: Reorder initialization order of contextElement, leading to possible crashes. (WebCore::SVGViewSpec::SVGViewSpec): (WebCore::SVGViewSpec::viewTarget):
svg/SVGViewSpec.h: Ditto. (WebCore::SVGViewSpec::contextElement):
svg/SynchronizablePropertyController.cpp: Added. (WebCore::SynchronizablePropertyController::SynchronizablePropertyController): (WebCore::SynchronizablePropertyController::registerProperty): (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization): (WebCore::SynchronizablePropertyController::synchronizeProperty): (WebCore::SynchronizablePropertyController::synchronizeAllProperties): (WebCore::SynchronizablePropertyController::startAnimation): (WebCore::SynchronizablePropertyController::stopAnimation):
svg/SynchronizablePropertyController.h: Added. (WebCore::SynchronizableProperty::SynchronizableProperty): (WebCore::SynchronizableProperty::isHashTableDeletedValue): (WebCore::SynchronizableProperty::operator==): (WebCore::SynchronizablePropertyHash::hash): (WebCore::SynchronizablePropertyHash::equal): (WebCore::SynchronizablePropertyHashTraits::constructDeletedValue): (WebCore::SynchronizablePropertyHashTraits::isDeletedValue):

3:38 PM Changeset in webkit [49744] by ap@apple.com

2 edits in trunk/BugsSite

Reviewed by Eric Carlson.

https://bugs.webkit.org/show_bug.cgi?id=30470
Make marking a bug as duplicate easier

js/field.js: (setResolutionToDuplicate): Focus the edit field, too.

1:00 PM Changeset in webkit [49743] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-17 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25413
[GTK] Please expose the level of headings

Exposes the heading level as an attribute of the AtkObject.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (addAttributeToSet): (webkit_accessible_get_attributes): (webkit_accessible_class_init):

8:54 AM Changeset in webkit [49742] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-17 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards
https://bugs.webkit.org/show_bug.cgi?id=30472

Put ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged
in EventHandler.cpp. MSVC fails to compile when DRAG_SUPPORT not enabled.

page/EventHandler.cpp:

8:49 AM Changeset in webkit [49741] by kevino@webkit.org

3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Optionally allow the user to zoom text using the mouse wheel.

https://bugs.webkit.org/show_bug.cgi?id=30444

8:45 AM Changeset in webkit [49740] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-17 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Seidel.

[chromium] Video controls not zoomed / transformed correctly
https://bugs.webkit.org/show_bug.cgi?id=30461

Draw the images in the controls scaled.

No new tests. With this change Chromium will pass the following tests:
LayoutTests/media/video-controls-zoomed.html
LayoutTests/media/video-controls-transformed.html

rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaButton): Pass along the target rect directly. (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize): Adjust the thumb slide applied with the scale factor.

12:53 AM Changeset in webkit [49739] by Laszlo Gombos

2 edits in trunk/WebCore

2009-10-17 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Gtk] Build fix for WebKitGtk after r49723.

Add bindings/js/JSExceptionBase.* to the build.

GNUmakefile.am:

12:46 AM Changeset in webkit [49738] by Laszlo Gombos

2 edits in trunk/WebCore

2009-10-17 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix for QtWebKit after r49723.

Add bindings/js/JSExceptionBase.cpp to the build.

WebCore.pro:

12:32 AM Changeset in webkit [49737] by pfeldman@chromium.org

3 edits in trunk/LayoutTests

2009-10-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: reduce inspector console test size - it times out.

inspector/console-tests-expected.txt:
inspector/console-tests.html:

Oct 16, 2009:

11:59 PM Changeset in webkit [49736] by ap@apple.com

2 edits in trunk/BugsSite

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=30470
Make marking a bug as duplicate easier

js/field.js: (setResolutionToDuplicate): Show edit field right away, don't make the user click again.

11:50 PM WebKit Team edited by dbates@webkit.org

Added Drag and Drop to my section. (diff)

11:29 PM Changeset in webkit [49735] by sfalken@apple.com

12 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=30456
Fixes for new Debug_All Windows build configuration.

Reviewed by Dan Bernstein.

WebCore:

platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::findCFNetworkModule): Ask for the correct library instead of guessing.

platform/win/ScrollbarThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.
rendering/RenderMediaControls.cpp: Use new DEBUG_ALL preprocessor define for library naming.
rendering/RenderThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.

WebKit/win:

WebKitClassFactory.cpp: Use new DEBUG_ALL preprocessor define for library naming.

WebKitLibraries:

win/tools/vsprops/debug_all.vsprops:

Define DEBUG_ALL in Debug_All configuration.
Continue to define USE_DEBUG_SAFARI_THEME for open source SafariTheme header usage.

WebKitTools:

DumpRenderTree/win/DumpRenderTree.cpp:

(sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.

DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.

10:52 PM Changeset in webkit [49734] by ggaren@apple.com

98 edits
1 add in trunk

Rolled back in r49717 with the build maybe working now?

10:15 PM Changeset in webkit [49733] by kdecker@apple.com

5 edits in trunk/WebKit/mac

Reviewed by Jon Honeycutt.

<rdar://problem/7304575>

Plugins/WebBaseNetscapePluginView.h: Added new boolean ivar and -hasBeenHalted instance method.
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView halt]):Update _hasBeenHalted. (-[WebBaseNetscapePluginView hasBeenHalted]): Added.
WebView/WebView.mm: (+[WebView _hasPluginForNodeBeenHalted:]): Checks to see if a plug-in node's been halted.
WebView/WebViewPrivate.h: Added -_hasPluginForNodeBeenHalted method.

9:38 PM Changeset in webkit [49732] by jhoneycutt@apple.com

8 edits in trunk

Add SPI to determine whether a plug-in has ever been halted.

Part of <rdar://problem/7312158>.

Reviewed by Dan Bernstein.

WebCore:

plugins/PluginView.cpp:

(WebCore::PluginView::PluginView):
Initialize m_hasBeenHalted.

plugins/PluginView.h:

(WebCore::PluginView::hasBeenHalted):
Return m_hasBeenHalted.

plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::halt):
Set m_hasBeenHalted.

WebKit/win:

Interfaces/IWebViewPrivate.idl:

Add hasPluginForNodeBeenHalted().

WebView.cpp:

(pluginViewForNode):
Code factored out of isNodeHaltedPlugin().
(WebView::isNodeHaltedPlugin):
Remove STDMETHODCALLTYPE, as it has no use at the definition. Use
pluginViewForNode().
(WebView::restartHaltedPluginForNode):
Ditto.
(WebView::hasPluginForNodeBeenHalted):
Get the PluginView for the given node. Return the result of
PluginView::hasBeenHalted().

WebView.h:

Declare hasPluginForNodeBeenHalted().

9:23 PM Changeset in webkit [49731] by Simon Fraser

2 edits in trunk/LayoutTests

2009-10-16 Simon Fraser <Simon Fraser>

Skip this test:

compositing/animation/animated-composited-inside-hidden.html

because the fix for https://bugs.webkit.org/show_bug.cgi?id=26770 was backed out.

platform/mac/Skipped:

8:54 PM Changeset in webkit [49730] by tonikitoo@webkit.org

2 edits in trunk/WebKit/qt

[Qt] QGLauncher leaks WebPage object
https://bugs.webkit.org/show_bug.cgi?id=30465

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.

Make 'SharedScene' to own 'WebPage' reference and delete it at its destructor.

Api/qwebpage.cpp:

(QWebPage::view):

Api/qwebpage_p.h:
QGVLauncher/main.cpp:

(SharedScene::SharedScene):
(SharedScene::~SharedScene):

8:51 PM Changeset in webkit [49729] by tonikitoo@webkit.org

3 edits in trunk/WebKit/qt

[Qt] "dangling" pointer to qwebpage's view object can leads QGLauncher to crash
https://bugs.webkit.org/show_bug.cgi?id=30459

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.

Remove all setView(ev->widget()) calls in QWebPage and QGWV event handling methods,
since QWebPageClient would do the trick.

Api/qgraphicswebview.cpp:

(QGraphicsWebView::hoverMoveEvent):

Api/qwebpage.cpp:

(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragLeaveEvent):
(QWebPagePrivate::dragMoveEvent):

8:35 PM Changeset in webkit [49728] by bweinstein@apple.com

4 edits in trunk/LayoutTests

Updated expected results of tests that give CONSOLE messages for
new verbose output.

fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt:
fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
platform/mac/fast/dynamic/015-expected.txt:

8:10 PM Changeset in webkit [49727] by abarth@webkit.org

3 edits
12 adds in trunk

2009-10-16 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

@charset rule after the first byte causes the rest of css to be ignored
https://bugs.webkit.org/show_bug.cgi?id=18265

Apparently we're supposed to tolerate whitespace before the charset
rule so folks can write code like this:

<style>
@charset "utf-8"
...
</style>

I'm told this is one of the top compatability problems in China.
Tests: fast/css/comment-before-charset-external.html

fast/css/comment-before-charset.html
fast/css/many-spaces-before-charset.html
fast/css/space-before-charset-external.html
fast/css/space-before-charset.html

css/CSSGrammar.y:

2009-10-16 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

@charset rule after the first byte causes the rest of css to be ignored
https://bugs.webkit.org/show_bug.cgi?id=18265

Test that we allow whitespace and comments before the charset rule.
These test results all match Firefox.

fast/css/comment-before-charset-expected.txt: Added.
fast/css/comment-before-charset-external-expected.txt: Added.
fast/css/comment-before-charset-external.html: Added.
fast/css/comment-before-charset.html: Added.
fast/css/many-spaces-before-charset-expected.txt: Added.
fast/css/many-spaces-before-charset.html: Added.
fast/css/resources/comment-before-charset.css: Added.
fast/css/resources/space-before-charset.css: Added.
fast/css/space-before-charset-expected.txt: Added.
fast/css/space-before-charset-external-expected.txt: Added.
fast/css/space-before-charset-external.html: Added.
fast/css/space-before-charset.html: Added.

7:31 PM Changeset in webkit [49726] by mrowe@apple.com

29 edits in trunk

Roll out r49717 as it broke the build.

6:23 PM Changeset in webkit [49725] by bweinstein@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Remove inspector tests from Windows Skipped list, because they pass locally
and the front-end changes are picked up by the bots.

platform/win/Skipped:

6:20 PM Changeset in webkit [49724] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: apparently we shouldn't export those symbols?

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16

JavaScriptCore.exp:

6:18 PM Changeset in webkit [49723] by bweinstein@apple.com

10 edits
8 adds in trunk

WebCore: Fixes part of <http://webkit.org/b/30412>.
Web Inspector should get human readable DOM Exceptions.

Reviewed by Darin Adler.

Add a description field to ExceptionBase, and call it through
reportException which allows the user/developer to get a more detailed
and coherent error explanation through the Web Inspector.

This only applies to exceptions that come from a script on the page when
it is run. DOM Exceptions that come from the code run in the console, or DOM
exceptions that are caught and logged will come in a future patch.

Tests: inspector/uncaught-dom1-exception.html

inspector/uncaught-dom3-exception.html
inspector/uncaught-dom8-exception.html

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

bindings/js/JSExceptionBase.cpp: Added.

(WebCore::toExceptionBase):

bindings/js/JSExceptionBase.h: Added.
dom/ExceptionBase.cpp:

(WebCore::ExceptionBase::ExceptionBase):

dom/ExceptionBase.h:

(WebCore::ExceptionBase::description):

dom/ExceptionCode.cpp:

(WebCore::):
(WebCore::getExceptionCodeDescription):

dom/ExceptionCode.h:

LayoutTests: Fixes part of <http://webkit.org/b/30412>.
Web Inspector should get human readable DOM Exceptions.

Reviewed by Darin Adler.

Adds tests for output of uncaught exceptions to the Web Inspector
Console. Tests DOM exceptions 1, 3, and 8 (INDEX_SIZE_ERR, NOT_FOUND_ERR, and
HIERARCHY_REQUEST_ERR).

inspector/uncaught-dom1-exception-expected.txt: Added.
inspector/uncaught-dom1-exception.html: Added.
inspector/uncaught-dom3-exception-expected.txt: Added.
inspector/uncaught-dom3-exception.html: Added.
inspector/uncaught-dom8-exception-expected.txt: Added.
inspector/uncaught-dom8-exception.html: Added.

6:09 PM Changeset in webkit [49722] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: export some symbols.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16

JavaScriptCore.exp:

6:06 PM Changeset in webkit [49721] by oliver@apple.com

30 edits in trunk/JavaScriptCore

structure typeinfo flags should be inherited.
https://bugs.webkit.org/show_bug.cgi?id=30468

Reviewed by Gavin Barraclough.

Add StructureFlag constant to the various JSC classes and use
it for the TypeInfo construction. This allows us to simply
accumulate flags by basing each classes StructureInfo on its parents.

5:45 PM Changeset in webkit [49720] by ggaren@apple.com

2 edits in trunk/WebCore

Build fix: forgot to check in this #include.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16

bridge/runtime_root.h:

5:40 PM Changeset in webkit [49719] by Darin Adler

2 edits in trunk/WebKitSite

coding/RefPtr.html: Minor revision, updating a link and tweaking

wording a bit in few places.

5:32 PM Changeset in webkit [49718] by mrowe@apple.com

1 copy in tags/Safari-6531.21.3

New tag.

5:28 PM Changeset in webkit [49717] by ggaren@apple.com

27 edits in trunk/JavaScriptCore

Fast for-in enumeration: Cache JSPropertyNameIterator; cache JSStrings
in JSPropertyNameIterator; inline more code.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
Reviewed by Oliver Hunt.

1.024x as fast on SunSpider (fasta: 1.43x as fast).

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

bytecode/Opcode.h:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetPropertyNames):
(JSC::BytecodeGenerator::emitNextPropertyName):

bytecompiler/BytecodeGenerator.h: Added a few extra operands to

op_get_pnames and op_next_pname so that we can track iteration state
in the register file instead of in the JSPropertyNameIterator. (To be
cacheable, the JSPropertyNameIterator must be stateless.)

interpreter/Interpreter.cpp:

(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".

(JSC::Interpreter::privateExecute): Updated for in-RegisterFile
iteration state tracking.

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

jit/JIT.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_get_pnames): Updated for in-RegisterFile
iteration state tracking.

(JSC::JIT::emit_op_next_pname): Inlined code generation for op_next_pname.

jit/JITStubs.cpp:

(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".

(JSC::DEFINE_STUB_FUNCTION):

jit/JITStubs.h:

(JSC::): Added has_property and to_object stubs. Removed op_next_pname
stub, since has_property is all we need anymore.

parser/Nodes.cpp:

(JSC::ForInNode::emitBytecode): Updated for in-RegisterFile
iteration state tracking.

runtime/JSCell.h:
runtime/JSObject.cpp:

(JSC::JSObject::getPropertyNames): Don't do caching at this layer
anymore, since we don't create a JSPropertyNameIterator at this layer.

runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::create): Do do caching at this layer.
(JSC::JSPropertyNameIterator::get): Updated for in-RegisterFile
iteration state tracking.
(JSC::JSPropertyNameIterator::markChildren): Mark our JSStrings.

runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::size):
(JSC::JSPropertyNameIterator::setCachedStructure):
(JSC::JSPropertyNameIterator::cachedStructure):
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
(JSC::JSPropertyNameIterator::cachedPrototypeChain):
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::Structure::setEnumerationCache): Don't store iteration state in
a JSPropertyNameIterator. Do cache a JSPropertyNameIterator in a
Structure.

runtime/JSValue.h:

(JSC::asCell):

runtime/MarkStack.h: Make those mischievous #include gods happy.

runtime/ObjectConstructor.cpp:

runtime/Operations.h:

(JSC::normalizePrototypeChain): Renamed countPrototypeChainEntriesAndCheckForProxies
to normalizePrototypeChain, since it changes dictionary prototypes to
non-dictionary objects.

runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

runtime/PropertyNameArray.h:

(JSC::PropertyNameArrayData::PropertyNameArrayData):
(JSC::PropertyNameArray::data):
(JSC::PropertyNameArray::size):
(JSC::PropertyNameArray::begin):
(JSC::PropertyNameArray::end): Simplified some code here to help with
current and future refactoring.

runtime/Protect.h:
runtime/Structure.cpp:

(JSC::Structure::~Structure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition): No need to clear
the enumeration cache with adding / removing properties without
transition. It is an error to add / remove properties without transition
once an object has been observed, and we can ASSERT to catch that.

runtime/Structure.h:

(JSC::Structure::enumerationCache): Changed the enumeration cache to
hold a JSPropertyNameIterator.

runtime/StructureChain.cpp:
runtime/StructureChain.h:

(JSC::StructureChain::head): Removed StructureChain::isCacheable because
it was wrong-headed in two ways: (1) It gave up when a prototype was a
dictionary, but instead we want un-dictionary heavily accessed
prototypes; (2) It folded a test for hasDefaultGetPropertyNames() into
a generic test for "cacheable-ness", but hasDefaultGetPropertyNames()
is only releavant to for-in caching.

5:27 PM Changeset in webkit [49716] by mrowe@apple.com

5 edits in branches/safari-4-branch/WebCore

Merge r48971.

5:27 PM Changeset in webkit [49715] by mrowe@apple.com

8 edits in branches/safari-4-branch

Merge r48683.

5:27 PM Changeset in webkit [49714] by mrowe@apple.com

4 edits in branches/safari-4-branch

Versioning.

5:20 PM Changeset in webkit [49713] by Simon Fraser

3 edits
5 adds in trunk

2009-10-16 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Transform layer gets stuck with the wrong transform after an animation ends
<rdar://problem/7311662>

Work around a CoreAnimation bug which causes an animated transform layer to
end up with a stale transform.

Test: compositing/animation/state-at-end-event-transform-layer.html

platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::bug7311367Workaround): (WebCore::GraphicsLayerCA::removeAnimationFromLayer):

5:20 PM Changeset in webkit [49712] by kevino@webkit.org

2 edits in trunk/WebKit/wx

wxMSW non-precomp headers build fix.

5:17 PM Changeset in webkit [49711] by Simon Fraser

4 edits
20 adds in trunk

2009-10-16 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

After running a transition with an end event listener, can't change the transform
https://bugs.webkit.org/show_bug.cgi?id=30454

Fix an issue where, if a document had any listener for webkitTransitionEnd or webkitAnimationEnd,
the animations would not get cleaned up correctly, which broke subsequent changes of transform.

Now, we always clean up the animations right after queuing up the end events.

Tests: animations/state-at-end-event.html

transitions/move-after-transition.html

page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::onAnimationEnd):
page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::onAnimationEnd):

5:11 PM Changeset in webkit [49710] by kdecker@apple.com

3 edits in trunk/WebKit/mac

Reviewed by Anders Carlson.

Small code cleanup

Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::halt): Just call -[WebBaseNetscapePluginView halt]. (WebHaltablePlugin::restart): Just call -[WebBaseNetscapePluginView resumeFromHalt] (-[WebBaseNetscapePluginView halt]): (-[WebBaseNetscapePluginView resumeFromHalt]):
WebView/WebView.mm: (_pluginViewForNode): Added a check if a render is a widget. This prevents a later assertion.

5:08 PM Changeset in webkit [49709] by Joseph Pecoraro

2 edits in trunk/WebCore

2009-10-15 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Handle the Enter Key in the Elements Tree Hierarchy
https://bugs.webkit.org/show_bug.cgi?id=30428

TextNode => Edit Text Node
Has Attributes => Edit First Attribute
No Attributes => Start Editing New Attribute

inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): handle the "Enter" key (WebInspector.ElementsTreeElement.prototype.set hovered): only add new attribute button on nodes with attributes (WebInspector.ElementsTreeElement.prototype._addNewAttribute): prevent moving backwards where there are no attributes (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): renamed to be clearer (WebInspector.ElementsTreeElement.prototype._startEditing): transition to the appropriate edit state for a tree element

5:04 PM Changeset in webkit [49708] by eric@webkit.org

4 edits in trunk/WebKitTools

2009-10-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue status bot should list which buildbot is blocking the queue
https://bugs.webkit.org/show_bug.cgi?id=30452

Add new methods and testing.

Scripts/bugzilla-tool:
Scripts/modules/buildbot.py:
Scripts/modules/buildbot_unittest.py:

4:57 PM Changeset in webkit [49707] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-10-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

run-webkit-tests fails when CWD is not inside a WebKit checkout
https://bugs.webkit.org/show_bug.cgi?id=30451

Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
Scripts/modules/scm_unittest.py:
- Remove use of original_path (we don't need to restore the CWD).
- Don't use '.' to find the webkit checkout, use file instead.

4:44 PM Changeset in webkit [49706] by eric@webkit.org

7 edits in trunk/WebCore

2009-10-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix header indent style for FrameLoader and friends
https://bugs.webkit.org/show_bug.cgi?id=30430

loader/FrameLoader.h: (WebCore::FrameLoader::frame): (WebCore::FrameLoader::policyChecker): (WebCore::FrameLoader::history): (WebCore::FrameLoader::notifier): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::policyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::client): (WebCore::FrameLoader::url): (WebCore::FrameLoader::isLoadingFromCachedPage): (WebCore::FrameLoader::committingFirstRealLoad): (WebCore::FrameLoader::committedFirstRealDocumentLoad): (WebCore::FrameLoader::creatingInitialEmptyDocument):
loader/HistoryController.h: (WebCore::HistoryController::currentItem): (WebCore::HistoryController::provisionalItem):
loader/PolicyCallback.h: (WebCore::PolicyCallback::request):
loader/PolicyChecker.h: (WebCore::PolicyChecker::loadType): (WebCore::PolicyChecker::setLoadType): (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy): (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy):
loader/RedirectScheduler.h:
loader/ResourceLoadNotifier.h:

3:31 PM Changeset in webkit [49705] by sfalken@apple.com

32 edits
1 add in trunk

Add a Debug_All configuration to build entire stack as debug.
Change Debug_Internal to:

stop using _debug suffix for all WebKit/Safari binaries
not use _debug as a DLL naming suffix
use non-debug C runtime lib.

Reviewed by Adam Roben.

JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore.make: Debug build in makefile should build Debug_All.
JavaScriptCore.vcproj/JavaScriptCore.sln: Add Debug_All configuration.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add Debug_All configuration.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".
JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Add Debug_All configuration.
JavaScriptCore.vcproj/WTF/WTF.vcproj: Add Debug_All configuration.
JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_All configuration.
JavaScriptCore.vcproj/testapi/testapi.vcproj: Add Debug_All configuration.

WebCore:

WebCore.vcproj/QTMovieWin.vcproj: Add Debug_All configuration.
WebCore.vcproj/WebCore.make: Debug build in makefile should build Debug_All.
WebCore.vcproj/WebCore.sln: Add Debug_All configuration.
WebCore.vcproj/WebCore.submit.sln: Add Debug_All configuration.
WebCore.vcproj/WebCore.vcproj: Add Debug_All configuration.
WebCore.vcproj/WebCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".

WebKit/win:

WebKit.vcproj/InterfacesGenerated.vcproj: Renamed single configuration from "Release" to "all".
WebKit.vcproj/WebKit.make: Debug build in makefile should build Debug_All.
WebKit.vcproj/WebKit.sln: Add Debug_All configuration.
WebKit.vcproj/WebKit.submit.sln: Add Debug_All configuration.
WebKit.vcproj/WebKit.vcproj:

Remove extraneous OutputDirectory/IntermediateDirectory in Debug_Cairo.
Add Debug_All configuration.

WebKit.vcproj/WebKitGUID.vcproj: Add Debug_All configuration.

WebKitLibraries:

win/tools/vsprops/debug_all.vsprops: Added.

Use debug C runtime library in debug_all.
Specify USE_DEBUG_SAFARI_THEME to get "_debug" suffix for debug_all.

win/tools/vsprops/debug_internal.vsprops:

Don't specify debug C runtime library in debug_internal.
Don't specify _debug suffix for standard debug_internal builds.

WebKitTools:

DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:

Add missing debug.vsprops inherited property sheet.
Add Debug_All configuration.

FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
WinLauncher/WinLauncher.vcproj:

Removed extraneous definitions inherited from vsprops.
Add Debug_All configuration.

3:28 PM Changeset in webkit [49704] by kov@webkit.org

2 edits in trunk/LayoutTests

Unreviewed. Rolling out r49661 since it makes tests fail on GTK+ and Mac with Xiph plugin

3:07 PM Changeset in webkit [49703] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-10-16 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r49693, because it broke Chromium build.
http://trac.webkit.org/changeset/49693

WebCore.gyp/WebCore.gyp:
WebCore.gypi:

3:03 PM Changeset in webkit [49702] by eric@webkit.org

5 edits
4 adds in trunk

2009-10-16 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Updated media resource selection algorithm to reflect latest HTML 5 specification.

https://bugs.webkit.org/show_bug.cgi?id=30407

media/video-play-pause-exception-expected.txt:
media/video-play-pause-exception.html:
media/video-src-empty-expected.txt: Added.
media/video-src-empty.html: Added.
media/video-src-none-expected.txt: Added.
media/video-src-none.html: Added.

2009-10-16 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Updated media resource selection algorithm to reflect latest HTML 5 specification.

Noticable changes:

Elements with no source should have their network state set to NETWORK_EMPTY as opposed to NETWORK_NO_SOURCE
Empty string ("") is now considered a valid URL resolving to the current page and will be loaded

Tests: media/video-src-empty.html

media/video-src-none.html

https://bugs.webkit.org/show_bug.cgi?id=30407

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): Updated code and comments to match spec.

2:33 PM Changeset in webkit [49701] by dbates@webkit.org

1 edit
2 adds in trunk/LayoutTests

2009-10-16 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30266

Tests that the JavaScript array event.dataTransfer.types can be accessed
within an ondrop handler without causing a crash.

Although this issue has been resolved as of nightly r49550 we should add a
test case so that we can prevent a regression of this issue.

fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Added.
fast/events/drag-and-drop-dataTransfer-types-nocrash.html: Added.

2:30 PM Changeset in webkit [49700] by eric@webkit.org

3 edits
3 adds in trunk

2009-10-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Insecure plug-ins don't trigger mixed content
https://bugs.webkit.org/show_bug.cgi?id=30431

http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt: Added.
http/tests/security/mixedContent/insecure-plugin-in-iframe.html: Added.
http/tests/security/mixedContent/resources/frame-with-insecure-plugin.html: Added.

2009-10-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Insecure plug-ins don't trigger mixed content
https://bugs.webkit.org/show_bug.cgi?id=30431

Added the missing check.

Test: http/tests/security/mixedContent/insecure-plugin-in-iframe.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin):

2:26 PM Changeset in webkit [49699] by jhoneycutt@apple.com

4 edits in trunk/WebKit/win

Add SPI to restart a halted plug-in.

Part of <rdar://problem/7273354> Halted plug-ins should restart on
mouseover

https://bugs.webkit.org/show_bug.cgi?id=30151

Reviewed by Kevin Decker.

Interfaces/IWebViewPrivate.idl:

Add restartHaltedPluginForNode().

WebView.cpp:

(WebView::restartHaltedPluginForNode):
From the IDOMNode, query for the DOMNode. From the DOMNode, get the
WebCore::Node. Get the node's renderer, and check whether it is a
RenderWidget. If so, get its Widget, and check whether it's a
PluginView. If so, call PluginView::restart().

WebView.h:

Declare restartHaltedPluginForNode().

2:21 PM Changeset in webkit [49698] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-16 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Set autobuffer to true and schedule load in V8 audio element constructor.

https://bugs.webkit.org/show_bug.cgi?id=30448

Covered by existing tests.

bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Set autobuffer to true and schedule load.

2:06 PM Changeset in webkit [49697] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-16 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Seidel.

Remove FIXME in RenderMediaControlsChromium as bug was fixed upstream.

https://bugs.webkit.org/show_bug.cgi?id=30422

Covered by existing media layout tests.

rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaSlider): Removed round() and FIXME.

2:01 PM BuildingOnWindows edited by dbates@webkit.org

Added note about error PRJ0002 - i.e. cannot find mspdb80.dll (diff)

1:57 PM Changeset in webkit [49696] by kdecker@apple.com

3 edits in trunk/WebKit/mac

Reviewed by Anders Carlson.

Last part of:
<rdar://problem/7273354>

WebView/WebView.mm: (_pluginViewForNode): Added with code extracted from _isNodeHaltedPlugin (+[WebView _isNodeHaltedPlugin:]): Made this a class method. (+[WebView _restartHaltedPluginForNode:]): Added. Restarts a plug-in
WebView/WebViewPrivate.h: Added +_restartHaltedPluginForNode to header.

1:56 PM Changeset in webkit [49695] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-16 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Seidel.

Fix Chromium media controls to render a disabled play button when the element is unintialized.

https://bugs.webkit.org/show_bug.cgi?id=30410

Covered by existing layout tests.

rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaPlayButton): Include check for NETWORK_EMPTY to render disabled play button.

1:39 PM Changeset in webkit [49694] by oliver@apple.com

40 edits in trunk

Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372

Reviewed by Gavin Barraclough.

Last part -- replace HasDefaultGetPropertyNames with OverridesGetPropertyNames
flag.

1:37 PM Changeset in webkit [49693] by eric@webkit.org

3 edits in trunk/WebCore

2009-10-16 Steven Knight <sgk@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=30447
Handle long link lines by building .idl-generated bindings in a
separate webcore_bindings library target. Avoid Visual Studio
dependency issues by building additional generated .cpp and .h files
in a separate webcore_bindings_sources target.

Chrome should still build and test successfully.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:

1:28 PM Changeset in webkit [49692] by Simon Fraser

2 edits in trunk/WebCore

2009-10-16 Simon Fraser <Simon Fraser>

Reviewed by Eric Carlson.

Transform transitions that used to be accelerated are no longer so
https://bugs.webkit.org/show_bug.cgi?id=30453

The change in r49633, to not run accelerated animations/transitions on layers that
are not attached, broke accelerated transitions/animations in many cases where they start
as soon as the page loads. This change reverts the code that tests for the GraphicsLayer being
attached.

No test, because it's not possible from a test to know whether a transition is accelerated or not.

rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::startTransition):

1:21 PM Changeset in webkit [49691] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-10-16 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

LayoutTests/fast/loader/local-JavaScript-from-local.html times out in case of error.
https://bugs.webkit.org/show_bug.cgi?id=30434

fast/loader/local-JavaScript-from-local.html:

11:46 AM Changeset in webkit [49690] by levin@chromium.org

3 edits in trunk/WebKitTools

check-webkit-style is wrong about indent checking in namespaces
in header files and a few other things
https://bugs.webkit.org/show_bug.cgi?id=30362

Patch by Carol Szabo <carol.szabo@nokia.com> on 2009-10-16
Reviewed by David Levin.

The few other things include:
+ check-webkit-style does not require spaces around the equal sign

inside 'if' statements and around binary operators that take
numeric literals.

+ check-webkit-style reports false errors for the / operator

when part of a filename in the #include directive.

Scripts/modules/cpp_style.py:

Improved indentation checking and space checking around
binary operators. While the checks are still not perfect,
they are clearly better than before.

Scripts/modules/cpp_style_unittest.py:

Added test cases for the newly supported checks and modified old
test cases to match the new guidelines

11:33 AM Changeset in webkit [49689] by kdecker@apple.com

5 edits in trunk/WebKit/mac

Reviewed by Anders.

<rdar://problem/7273354>

Plugins/WebBaseNetscapePluginView.h: Added _isHalted ivar and three new methods: -halt, -resumeFromHalt, and -isHalted
Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::halt): Call -halt instead of -stop. (WebHaltablePlugin::restart):Call -resumeFromHalt instead of -start. (-[WebBaseNetscapePluginView halt]): Added. Stop the plug-in, update _isHalted. (-[WebBaseNetscapePluginView resumeFromHalt]): Added. Start the plug-in, update _isHalted. (-[WebBaseNetscapePluginView isHalted]): Added.
WebView/WebView.mm: (-[WebView _isNodeHaltedPlugin:]): Added. Queries a DOMNode to determine if it's a halted plug-in.
WebView/WebViewPrivate.h: Added _isNodeHaltedPlugin.

11:23 AM Changeset in webkit [49688] by kevino@webkit.org

6 edits in trunk

wxMSW build fix, we can't use the simple hash there because the PlatformModuleVersion
structure differs.

10:46 AM Changeset in webkit [49687] by abarth@webkit.org

1 edit
1 add in trunk/WebCore

2009-10-16 Adam Barth <abarth@webkit.org>

Unreviewed build fix. Add back MIMETypeRegistryChromium with the right
casing.

platform/chromium/MIMETypeRegistryChromium.cpp: Added. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::getMIMETypeForPath): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType): (WebCore::MIMETypeRegistry::isJavaAppletMIMEType): (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): (WebCore::dummyHashSet): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding): (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):

10:41 AM Changeset in webkit [49686] by abarth@webkit.org

2 edits
1 delete in trunk/WebCore

2009-10-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

MimeTypeRegistryChromium is mis-casen
https://bugs.webkit.org/show_bug.cgi?id=30441

Change the case of MimeTypeRegistryChromium to match other platforms.

WebCore.gypi:
platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
platform/chromium/MimeTypeRegistryChromium.cpp: Removed.

10:35 AM Changeset in webkit [49685] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Change EmptyPluginHalterClient in SVGImage to be non-static, to
match changes made http://trac.webkit.org/changeset/49385.
https://bugs.webkit.org/show_bug.cgi?id=30403

Run the following layout test sequence:

LayoutTests/svg/W3C-SVG-1.1/struct-image-01-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-03-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-04-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-05-b.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-06-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-08-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-09-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-10-t.svg
LayoutTests/svg/carto.net/scrollbar.svg
LayoutTests/svg/carto.net/selectionlist.svg

selectionlist.svg should not crash.

svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Made EmptyPluginHalterClient non-static.

10:27 AM Changeset in webkit [49684] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-16 Victor Wang <victorw@chromium.org>

Reviewed by David Levin.

Add beforeload event support to V8DOMWrapper

https://bugs.webkit.org/show_bug.cgi?id=30413

LayoutTests/fast/dom/beforeload/frame-before-load.html

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):

9:41 AM Changeset in webkit [49683] by abarth@webkit.org

1 edit in trunk/WebCore/ChangeLog

2009-10-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

MimeTypeRegistryChromium is mis-casen
https://bugs.webkit.org/show_bug.cgi?id=30441

Change the case of MimeTypeRegistryChromium to match other platforms.

WebCore.gypi:
platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
platform/chromium/MimeTypeRegistryChromium.cpp: Removed.

9:20 AM Changeset in webkit [49682] by abarth@webkit.org

2 edits in trunk/WebCore

2009-10-16 Adam Barth <abarth@webkit.org>

Reviewed by Mark Rowe.

Chrome doesn't set Content-Type for file upload when the file extension
is not recognized
https://bugs.webkit.org/show_bug.cgi?id=30433

Apparently, getMIMETypeForPath is supposed to return
application/octet-stream when it doesn't have a better MIME type.

platform/chromium/MimeTypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForPath):

8:58 AM Changeset in webkit [49681] by vestbo@webkit.org

4 edits in trunk

Pull out r49676 as it caused build breakges on Symbian

8:53 AM Changeset in webkit [49680] by vestbo@webkit.org

1 edit
5 adds in trunk/LayoutTests

[Qt] Add empty skipped lists for the platform-specific results

Reviewed by Ariya Hidayat.

platform/qt-linux/Skipped:
platform/qt-mac/Skipped:
platform/qt-win/Skipped:

8:45 AM Changeset in webkit [49679] by Laszlo Gombos

3 edits
1 add in trunk/JavaScriptCore

2009-10-16 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Implement ExecutableAllocator for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29946

Tested with YARR JIT enabled for Symbian;
This patch does not (yet) enable YARR JIT by default.

JavaScriptCore.pri:
jit/ExecutableAllocator.h:
jit/ExecutableAllocatorSymbian.cpp: Added. (JSC::ExecutableAllocator::intializePageSize): (JSC::ExecutablePool::systemAlloc): (JSC::ExecutablePool::systemRelease):

7:35 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com

(diff)

6:26 AM Changeset in webkit [49678] by vestbo@webkit.org

2 edits in trunk/LayoutTests

[Qt] Update outdated platform dependent expected file.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-16
Reviewed by Tor Arne Vestbø.

platform/qt/editing/execCommand/toggle-compound-styles-expected.txt:

6:26 AM Changeset in webkit [49677] by vestbo@webkit.org

1 edit in trunk/WebCore/ChangeLog

Crash fix when loading NPAPI plugins on Qt/Mac

Reviewed by Ariya Hidayat.

There's no guarantee that the plist will be valid even if we
ask the plugin to create it. Crash obverved with iGetter.

plugins/mac/PluginPackageMac.cpp:

6:18 AM Changeset in webkit [49676] by eric@webkit.org

4 edits in trunk

2009-10-16 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Need a way to inform the application when a Netscape plugin is created or deleted
https://bugs.webkit.org/show_bug.cgi?id=30179

Inform the application when a plugin is created or destroyed, but only if the
application registered for these notifications.

plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):

2009-10-16 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Need a way to inform the application when a Netscape plugin is created or deleted
https://bugs.webkit.org/show_bug.cgi?id=30179

Added "c" style static methods for the application to hook up for
receiving notifications when a plugin is created or destroyed.

Api/qwebpage.cpp:

5:47 AM Changeset in webkit [49675] by eric@webkit.org

3 edits
2 adds in trunk

2009-10-16 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Added test case for testing navigator.language.
https://bugs.webkit.org/show_bug.cgi?id=29653

Different browsers may not return the exact same result.
Some examples here:
Safari 4 WinXP: "en-US"
Safari 4 Mac: "en-us"
Firefox 3 Mac/WinXP: "en-US"
Opera 9.64: "en"
Epiphany 2 GTK: "en"
Chrome 3 WinXP: "en-US"