Context Navigation

← Previous Period
Next Period →

Timeline

Oct 18, 2009:

11:59 PM Changeset in webkit [49767] by eric@webkit.org

3 edits
10 adds in trunk

2009-10-18 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Barth.

Fixes issue where doubleclicking a word could select following adjacent newlines.
https://bugs.webkit.org/show_bug.cgi?id=30234

platform/mac/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
platform/mac/editing/selection/script-tests/TEMPLATE.html: Added.
platform/mac/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):
platform/win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
platform/win/editing/selection/script-tests/TEMPLATE.html: Added.
platform/win/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):

2009-10-18 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Barth.

Fixes issue where doubleclicking a word could select following adjacent newlines.
https://bugs.webkit.org/show_bug.cgi?id=30234

Tests: platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html

platform/mac/editing/selection/script-tests/TEMPLATE.html
platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html
platform/win/editing/selection/script-tests/TEMPLATE.html

editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace):

11:51 PM Changeset in webkit [49766] by eric@webkit.org

7 edits in trunk

2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

Rename fixedContentsSize property to preferredContentsSize as
agreed upon with Siman Hausmann and Matthias Ettrich.

Api/qwebpage.cpp: (QWebPage::preferredContentsSize): (QWebPage::setPreferredContentsSize):
Api/qwebpage.h:
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

Use the setPreferredContentsSize method instead
of setFixedContentsSize, as the method has been renamed.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setFixedContentsSize):

11:50 PM QtBackLog edited by zecke@selfish.org

(diff)

11:46 PM QtBackLog edited by zecke@selfish.org

Move QtWebKit problems into a table. (diff)

11:43 PM Changeset in webkit [49765] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-10-18 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Use _stricmp and _strnicmp instead of deprecated stricmp and strnicmp.
https://bugs.webkit.org/show_bug.cgi?id=30474

stricmp and strnicmp are deprecated beginning in Visual
C++ 2005. Use _stricmp and _strnicmp instead in StringExtras.h.

wtf/StringExtras.h: (strncasecmp): (strcasecmp):

11:42 PM QtBackLog edited by zecke@selfish.org

Change Qt items into a table (diff)

11:34 PM QtBackLog edited by zecke@selfish.org

Add completed items to the bottom (diff)

8:53 PM Changeset in webkit [49764] by kevino@webkit.org

2 edits in trunk/WebCore

CURL build fix, use proper header name.

7:38 PM Changeset in webkit [49763] by mrowe@apple.com

2 edits in trunk/WebKit/mac

<rdar://problem/7309062> Crashes in WebCore::DocumentLoader::isStopping below WebKit::NetscapePluginInstanceProxy::loadRequest.

Reviewed by Dan Bernstein.

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::loadRequest): Null-check the DocumentLoader before deferencing it.

7:09 PM Changeset in webkit [49762] by pfeldman@chromium.org

9 edits in trunk

2009-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Properties on Arrays and NodeLists are not logged correctly.

https://bugs.webkit.org/show_bug.cgi?id=30485

WebCore:

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._printArray):

LayoutTests:

inspector/console-format-expected.txt:
inspector/console-format.html:

6:20 PM Changeset in webkit [49761] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-10-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: touching WebCore so that it
initiated inspector frontend deployment on Windows.

Web Inspector: frontend files are not deployed in Windows
incremental build.

inspector/InspectorDOMAgent.cpp:

5:20 PM Changeset in webkit [49760] by pfeldman@chromium.org

6 edits
6 adds in trunk/LayoutTests

2009-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make console tests more granular.

https://bugs.webkit.org/show_bug.cgi?id=30496

inspector/console-dir-expected.txt: Added.
inspector/console-dir.html: Added.
inspector/console-dirxml-expected.txt: Added.
inspector/console-dirxml.html: Added.
inspector/console-format-expected.txt: Added.
inspector/console-format.html: Added.
inspector/console-tests-expected.txt:
inspector/console-tests.html:
platform/gtk/Skipped:
platform/qt/Skipped:

4:48 PM Changeset in webkit [49759] by mrowe@apple.com

4 edits in branches/safari-4-branch

Versioning.

4:17 PM Changeset in webkit [49758] by pfeldman@chromium.org

4 edits in trunk

2009-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Title of dir(["test", "test2"]) should be Array

https://bugs.webkit.org/show_bug.cgi?id=30486

Test: inspector/console-tests.html

inspector/front-end/InjectedScript.js:

2:15 PM Changeset in webkit [49757] by krit@webkit.org

9 edits in trunk

2009-10-18 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

REGRESSION: SVG Mask doesn't work for maskContentUnits="objectBoundingBox"
https://bugs.webkit.org/show_bug.cgi?id=30480

Patch for SVGMaskElement landed in r49598 should correct the location of
the mask image graphics context. It only corrects the location for userSpaceOnUse
mode in maskContentUnits but breaks objectBoundingBoxMode.
The maskDestRect shouldn't be moved. It is not responsible for the correct context
postioin but for the correct position of the mask image.
This patch calculates the context postion independently from the maskDestRect.
It also uses lineareRGB color space for masking on CG now. This is the default
color space for masking operations.
We already have tests for both maskContentUnits modes.

*svg/W3C-SVG-1.1/masking-intro-01-f.svg
*svg/custom/mask-with-default-value.svg

Some tests needed new pixel tests because of the new color space.

svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):

The color space of masking operations in SVG changed to linearSVG.
This needs an update of some masking pixel tests.

platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
platform/mac/svg/batik/masking/maskRegions-expected.checksum:
platform/mac/svg/batik/masking/maskRegions-expected.png:
platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
platform/mac/svg/custom/grayscale-gradient-mask-expected.png:

12:55 PM Changeset in webkit [49756] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-18 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Use v8::Integer::NewFromUnsigned when converting unsigneds into V8's numbers.
That is notably faster for small numbers (most common case).
https://bugs.webkit.org/show_bug.cgi?id=30493

bindings/scripts/CodeGeneratorV8.pm:

12:29 PM Changeset in webkit [49755] by jmalonzo@webkit.org

5 edits
5 adds in trunk

2009-10-18 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK] Add MathML to the build system
https://bugs.webkit.org/show_bug.cgi?id=30487

Add --enable-mathml to configure.

configure.ac:

Add MathML sources if MathML support is enabled.

GNUmakefile.am:

Include layout test baseline for Gtk.

platform/gtk/mathml/presentation/sub-expected.txt: Added.
platform/gtk/mathml/presentation/sup-expected.txt: Added.
platform/gtk/mathml/presentation/tables-expected.txt: Added.

11:21 AM Changeset in webkit [49754] by kevino@webkit.org

2 edits in trunk/WebCore

Non-PCH build fix. Added missing header.

10:17 AM Changeset in webkit [49753] by Simon Fraser

7 edits
4 adds in trunk

2009-10-18 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Compositing layers not correctly updated after partial layout
https://bugs.webkit.org/show_bug.cgi?id=30425

When a partial layout happened, for example as the result of a postion-change-only
layout, then some compositing layer positions were not correctly updated. To fix
this, updateLayerPositions() now carries along a flag that is set at the rootmost
layer being updated, and used to determine when we hit the first compositing layer
in this update. RenderLayerBacking::updateAfterLayout() makes use of this information
to do a full geometry update on that layer, which is thus the rootmost compositing
layer that is being updated.

Test: compositing/geometry/partial-layout-update.html

page/FrameView.cpp: (WebCore::FrameView::layout):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset):
rendering/RenderLayer.h: (WebCore::RenderLayer::):
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
rendering/RenderLayerBacking.h:

10:02 AM Changeset in webkit [49752] by kevino@webkit.org

6 edits in trunk

Reviewed by Kevin Ollivier.

Add the ability to specify a proxy for wxWebKit.

https://bugs.webkit.org/show_bug.cgi?id=30446

9:23 AM Changeset in webkit [49751] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-18 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez

https://bugs.webkit.org/show_bug.cgi?id=25901
Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag

Replaces the use of ATK_ROLE_PANEL with the expected accessible roles.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):

9:08 AM Changeset in webkit [49750] by kevino@webkit.org

4 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add basic database support to wx API

https://bugs.webkit.org/show_bug.cgi?id=30445

9:00 AM Changeset in webkit [49749] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

2009-10-18 Eric Carlson <eric.carlson@apple.com>

Skip media/video-empty-source.html until <rdar://problem/6563117> has been fixed.

platform/mac/Skipped:

7:50 AM QtBackLog edited by zecke@selfish.org

(diff)

2:35 AM QtWebKitPlugins edited by Girish Ramakrishnan

(diff)

Oct 17, 2009:

11:27 PM Changeset in webkit [49748] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-10-17 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Fix inefficient string concatenation.

LayoutTests/fast/css/large-list-of-rules-crash.html contains code that
concatenate strings in an inefficient way. Concatenation of strings should be
done with Array.join method. This patch fixes this issue, and also fixes typos
in the test.

fast/css/large-list-of-rules-crash.html concatenates strings in an inefficient way
https://bugs.webkit.org/show_bug.cgi?id=30436

fast/css/large-list-of-rules-crash.html:

6:46 PM QtBackLog edited by zecke@selfish.org

(diff)

6:41 PM QtBackLog edited by zecke@selfish.org

(diff)

6:22 PM QtBackLog edited by zecke@selfish.org

(diff)

6:15 PM QtBackLog edited by zecke@selfish.org

(diff)

4:07 PM Changeset in webkit [49747] by mrowe@apple.com

4 edits in trunk

Versioning.

4:06 PM Changeset in webkit [49746] by mrowe@apple.com

1 copy in tags/Safari-532.2

New tag.

3:52 PM Changeset in webkit [49745] by Nikolas Zimmermann

13 edits
2 adds in trunk/WebCore

2009-10-17 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by George Staikos.

Cleanup SVGElement code, preparing for animVal support
https://bugs.webkit.org/show_bug.cgi?id=30466

Add new SynchronizablePropertyController and move the code for SVG property <-> XML attribute synchronization
from SVGElement. This is a further preparation for animVal support, where SynchronizablePropertyController will
be used to control the start/end state of an animated property.

We're currently tracking animated properties that need synchronization, generalize this concept and use
it to track their creation (bound to certain SVG*Element classes) as well as a flag determing the need
of synchronization (no SVG DOM object wrappers, no synchronization needed).

No change in functionality, thus no tests.

GNUmakefile.am: Add 'SynchronizablePropertyController.cpp/h' to build
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
svg/SVGAllInOne.cpp: Ditto.
svg/SVGAnimatedProperty.h: Add registerProperty() function (WebCore::::SVGAnimatedProperty): Call registerProperty() function (WebCore::::registerProperty): Add new registerProperty() function, announcing new properties to SynchronizablePropertyController.
svg/SVGAnimatedTemplate.h: Use propertyController() method, to access the new functions moved from SVGElement. (WebCore::lookupOrCreateWrapper):
svg/SVGElement.cpp: Adapt to code moving to SynchronizablePropertyController. (WebCore::SVGElement::updateAnimatedSVGAttribute):
svg/SVGElement.h: Move handling SVG property synchronization to SynchronizablePropertyController. (WebCore::SVGElement::propertyController): Expose reference to SynchronizablePropertyController object.
svg/SVGViewSpec.cpp: Reorder initialization order of contextElement, leading to possible crashes. (WebCore::SVGViewSpec::SVGViewSpec): (WebCore::SVGViewSpec::viewTarget):
svg/SVGViewSpec.h: Ditto. (WebCore::SVGViewSpec::contextElement):
svg/SynchronizablePropertyController.cpp: Added. (WebCore::SynchronizablePropertyController::SynchronizablePropertyController): (WebCore::SynchronizablePropertyController::registerProperty): (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization): (WebCore::SynchronizablePropertyController::synchronizeProperty): (WebCore::SynchronizablePropertyController::synchronizeAllProperties): (WebCore::SynchronizablePropertyController::startAnimation): (WebCore::SynchronizablePropertyController::stopAnimation):
svg/SynchronizablePropertyController.h: Added. (WebCore::SynchronizableProperty::SynchronizableProperty): (WebCore::SynchronizableProperty::isHashTableDeletedValue): (WebCore::SynchronizableProperty::operator==): (WebCore::SynchronizablePropertyHash::hash): (WebCore::SynchronizablePropertyHash::equal): (WebCore::SynchronizablePropertyHashTraits::constructDeletedValue): (WebCore::SynchronizablePropertyHashTraits::isDeletedValue):

3:38 PM Changeset in webkit [49744] by ap@apple.com

2 edits in trunk/BugsSite

Reviewed by Eric Carlson.

https://bugs.webkit.org/show_bug.cgi?id=30470
Make marking a bug as duplicate easier

js/field.js: (setResolutionToDuplicate): Focus the edit field, too.

1:00 PM Changeset in webkit [49743] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-17 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25413
[GTK] Please expose the level of headings

Exposes the heading level as an attribute of the AtkObject.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (addAttributeToSet): (webkit_accessible_get_attributes): (webkit_accessible_class_init):

8:54 AM Changeset in webkit [49742] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-17 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards
https://bugs.webkit.org/show_bug.cgi?id=30472

Put ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged
in EventHandler.cpp. MSVC fails to compile when DRAG_SUPPORT not enabled.

page/EventHandler.cpp:

8:49 AM Changeset in webkit [49741] by kevino@webkit.org

3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Optionally allow the user to zoom text using the mouse wheel.

https://bugs.webkit.org/show_bug.cgi?id=30444

8:45 AM Changeset in webkit [49740] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-17 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Seidel.

[chromium] Video controls not zoomed / transformed correctly
https://bugs.webkit.org/show_bug.cgi?id=30461

Draw the images in the controls scaled.

No new tests. With this change Chromium will pass the following tests:
LayoutTests/media/video-controls-zoomed.html
LayoutTests/media/video-controls-transformed.html

rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaButton): Pass along the target rect directly. (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize): Adjust the thumb slide applied with the scale factor.

12:53 AM Changeset in webkit [49739] by Laszlo Gombos