Timeline
Oct 19, 2009:
- 11:56 PM Changeset in webkit [49841] by
-
- 2 edits in trunk/WebCore
REGRESSION: Dromaeo DOM test is 14% slower
https://bugs.webkit.org/show_bug.cgi?id=30273
Reviewed by Sam Weinig.
Whoops, make prototype bindings actually use the StructureFlags.
- 10:01 PM Changeset in webkit [49840] by
-
- 4 edits2 copies in trunk/WebCore
2009-10-19 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Better implementation of WebCore::ScriptString for the V8 bindings.
WebCore::ScriptString is used for XMLHttpRequest's responseText attribute which is
shared with JavaScript. Thus, simply using a WebCore::String and copying the value
is pretty inefficient, especially since responseText is built up with a sequence of
operator+= calls. JSC builds use a JSC::UString to share the buffer when possible,
this patch adopts a similar approach for V8.
No new tests, behavior is unchanged and covered by LayoutTests/http/tests/xmlhttprequest
- WebCore.gypi:
- bindings/v8/ScriptString.h: (WebCore::ScriptString::ScriptString): (WebCore::ScriptString::operator String): (WebCore::ScriptString::isNull): (WebCore::ScriptString::size): (WebCore::ScriptString::operator=): (WebCore::ScriptString::operator+=): (WebCore::ScriptString::v8StringOrNull):
- bindings/v8/ScriptStringImpl.cpp: Added. (WebCore::ScriptStringImpl::ScriptStringImpl): (WebCore::ScriptStringImpl::~ScriptStringImpl): (WebCore::ScriptStringImpl::toString): (WebCore::ScriptStringImpl::isNull): (WebCore::ScriptStringImpl::size): (WebCore::ScriptStringImpl::append):
- bindings/v8/ScriptStringImpl.h: Added. (WebCore::ScriptStringImpl::ScriptStringImpl): (WebCore::ScriptStringImpl::v8StringHandle):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::ACCESSOR_GETTER):
- 9:46 PM Changeset in webkit [49839] by
-
- 3 edits1 delete in trunk/WebCore
2009-10-19 Adam Barth <abarth@webkit.org>
No review, rolling out r49837.
http://trac.webkit.org/changeset/49837
- page/Settings.cpp: (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::setFantasyFontFamily):
- page/Settings.h: (WebCore::Settings::standardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::fantasyFontFamily):
- platform/text/UScriptCode.h: Removed.
- 9:39 PM Changeset in webkit [49838] by
-
- 2 edits in trunk/WebCore
2009-10-19 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Check COMPILER(MSVC) instead of PLATFORM(WIN_OS) to avoid the use of vasprintf.
https://bugs.webkit.org/show_bug.cgi?id=30473
vasprintf is missing in MSVC. Use COMPILER(MSVC) guards instead of
PLALTFORM(WIN_OS) guards.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
- 9:37 PM Changeset in webkit [49837] by
-
- 3 edits1 add in trunk/WebCore
2009-10-19 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel.
Make generic font family getters/setters accept an additional
argument (script code). It has a default value so that if an embedder
does not have/want a per-script font family setting, call-sites
don't have to be changed.
This is to prepare for fixing bug 10874 (font selection is not
language-dependent) and bug 18085.
There should be no change in layout and no new layout test
is added.
- WebCore.base.exp:
- page/Settings.cpp:
- page/Settings.h:
- platform/text/UScriptCode.h: Added. This is for ports that do not use ICU. the part of ICU's common/unicode/uscript.h that defines script code enum was copied. To keep enums compatible with those in ICU, we don't generate the list out of Scripts.txt of the Unicode Data base or CLDR's data.
- 9:28 PM Changeset in webkit [49836] by
-
- 2 edits in trunk/WebCore
2009-10-19 Evan Stade <estade@chromium.org>
Reviewed by Darin Adler.
Clarify usage of SuddenTermination API. No code change.
- platform/SuddenTermination.h:
- 9:05 PM Changeset in webkit [49835] by
-
- 10 edits in trunk/WebCore
REGRESSION: Dromaeo DOM test is 14% slower
https://bugs.webkit.org/show_bug.cgi?id=30273
Reviewed by Gavin Barraclough.
Make DOM bindings automatically inherit correct structure
flags rather than being needlessly conservative. This is
done by making the bindings generator use the same model
for TypeInfo flags that we now use in JSC.
This gains us about 1% of this regression back.
- 9:01 PM Changeset in webkit [49834] by
-
- 2 edits in trunk/WebKit
2009-10-19 John Gregg <johnnyg@google.com>
Reviewed by Dimitri Glazkov.
set ENABLE_NOTIFICATIONS=1 for Chromium
https://bugs.webkit.org/show_bug.cgi?id=29949
- chromium/features.gypi:
- 8:19 PM Changeset in webkit [49833] by
-
- 3 edits2 adds in trunk
2009-10-19 Robin Qiu <robin.qiu@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
Add a layout test for nested SVG <use> element which has a child.
https://bugs.webkit.org/show_bug.cgi?id=26117
- svg/custom/use-on-use-with-child-expected.txt: Added.
- svg/custom/use-on-use-with-child.svg: Added.
2009-10-19 Robin Qiu <robin.qiu@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
Fixed a bug on nested SVG <use> elements.
https://bugs.webkit.org/show_bug.cgi?id=26117
When a <use> element refer to another <use> element which has
child/children, the instance tree built for this <use> element
is incorrect (more nodes than expected).
Test: svg/dom/use-on-use-with-child.svg
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree):
- 7:59 PM Changeset in webkit [49832] by
-
- 2 edits in trunk/WebCore
Small changes to fully invalidate and update the JavaScriptCallFrame.
Patch by Oliver Hunt <oliver@apple.com> on 2009-10-19
<rdar://problem/7020755> JSDebugger crashes after reloading from a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=27146
Reviewed by Timothy Hatcher.
- inspector/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::invalidate):
(WebCore::JavaScriptCallFrame::update):
- 7:51 PM Changeset in webkit [49831] by
-
- 3 edits in trunk/LayoutTests
2009-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Fix fallout from last change.
https://bugs.webkit.org/show_bug.cgi?id=30550
Update init-events to match reality. I only ran the domstorage layout tests
and thus missed one in fast/events/. This addresses fallout from
https://bugs.webkit.org/show_bug.cgi?id=30536
- fast/events/init-events-expected.txt:
- fast/events/script-tests/init-events.js:
- 6:32 PM Changeset in webkit [49830] by
-
- 17 edits in trunk
2009-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dmitri Titov.
Remove "source" from storage events
https://bugs.webkit.org/show_bug.cgi?id=30536
Remove "source" from storage events per
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html
This was removed because it makes it introduces synchronous access that can
cross the event loop boundry (since a storage event can fire from one process
and be handled in another).
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent):
- storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent): (WebCore::StorageEvent::initStorageEvent):
- storage/StorageEvent.h: (WebCore::StorageEvent::uri):
- storage/StorageEvent.idl:
- storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):
2009-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dmitri Titov.
Remove "source" from storage events
https://bugs.webkit.org/show_bug.cgi?id=30536
Remove "source" from storage events per
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html
- storage/domstorage/localstorage/iframe-events-expected.txt:
- storage/domstorage/localstorage/iframe-events.html:
- storage/domstorage/localstorage/resources/iframe-events-second.html:
- storage/domstorage/localstorage/simple-events-expected.txt:
- storage/domstorage/localstorage/simple-events.html:
- storage/domstorage/sessionstorage/iframe-events-expected.txt:
- storage/domstorage/sessionstorage/iframe-events.html:
- storage/domstorage/sessionstorage/resources/iframe-events-second.html:
- storage/domstorage/sessionstorage/simple-events-expected.txt:
- storage/domstorage/sessionstorage/simple-events.html:
- 6:29 PM Changeset in webkit [49829] by
-
- 5 edits in trunk/WebCore
2009-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove ResourceLoadNotifier::activeDocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=30533
Removing this method from ResourceLoadNotifier better decouples the
notifier from FrameLoader.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::requestFromDelegate):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveResponse):
- loader/ResourceLoadNotifier.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest):
- 6:28 PM Changeset in webkit [49828] by
-
- 5 edits in trunk/WebCore
2009-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move sendRemainingDelegateMessages to ResourceLoadNotifier
https://bugs.webkit.org/show_bug.cgi?id=30531
This method is about notifying folks and doesn't interact with the rest
of FrameLoader.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
- loader/FrameLoader.h:
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
- loader/ResourceLoadNotifier.h:
- 6:19 PM Changeset in webkit [49827] by
-
- 7 edits2 adds in trunk
2009-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Bypass popup blocker using click event
https://bugs.webkit.org/show_bug.cgi?id=21501
Test that a fake event can't get around the popup blocker.
- http/tests/security/popup-blocked-from-fake-event-expected.txt: Added.
- http/tests/security/popup-blocked-from-fake-event.html: Added.
2009-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Bypass popup blocker using click event
https://bugs.webkit.org/show_bug.cgi?id=21501
Keep track of which events were generated by JavaScript and use that
inforation when figuring out if we're processing a user gesture.
Test: http/tests/security/popup-blocked-from-fake-event.html
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGestureEvent):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
- dom/Document.cpp: (WebCore::Document::createEvent):
- dom/Event.cpp: (WebCore::Event::Event):
- dom/Event.h: (WebCore::Event::createdByDOM): (WebCore::Event::setCreatedByDOM):
- 6:09 PM Changeset in webkit [49826] by
-
- 2 edits in trunk/WebCore
Fixing a typo.
Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-19
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30543
- platform/sql/SQLiteDatabase.h:
- 6:05 PM Changeset in webkit [49825] by
-
- 1 edit in trunk/WebKitTools/Scripts/modules/committers.py
Adding myself to committers.py.
- 5:41 PM Changeset in webkit [49824] by
-
- 1 edit1 add in trunk/WebCore
Manual Test for crash caused by JS accessing DOMWindow which is disconnected from the Frame.
https://bugs.webkit.org/show_bug.cgi?id=30544
Reviewed by Darin Adler.
- manual-tests/crash-on-accessing-domwindow-without-frame.html: Added.
- 5:38 PM Changeset in webkit [49823] by
-
- 3 edits in trunk/WebCore
2009-10-19 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Flash at end of opacity/transform transition sometimes
https://bugs.webkit.org/show_bug.cgi?id=30501
When a transition finishes, there window of time between when the animation is
removed, and the final style set on the GraphicsLayer. This caused the layer to revert
to its old appearance for one or two frames. To avoid this, we set the final
transform or opacity at the start of the transition; we know that the animation
will override the final value for as long as its running.
No test because this is a very transient effect that can't be captured
in a test.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::updateLayerOpacity): (WebCore::RenderLayerBacking::updateLayerTransform): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::startTransition):
- rendering/RenderLayerBacking.h:
- 5:12 PM Changeset in webkit [49822] by
-
- 1 edit in trunk/WebKitSite/blog-files/webgl/resources/blogpost.css
Added one more style rule
- 5:03 PM Changeset in webkit [49821] by
-
- 1 add in trunk/WebKitSite/blog-files/webgl/resources/blogpost.css
Moved WebGL blog CSS to a separate file
- 3:59 PM Changeset in webkit [49820] by
-
- 3 edits in trunk/JavaScriptCore
Tightened up some put_by_id_transition code generation.
https://bugs.webkit.org/show_bug.cgi?id=30539
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-19
Reviewed by Oliver Hunt.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::testPrototype):
(JSC::JIT::privateCompilePutByIdTransition): No need to do object type
checks or read Structures and prototypes from objects: they're all known
constants at compile time.
- 3:44 PM Changeset in webkit [49819] by
-
- 3 edits in trunk/LayoutTests
2009-10-19 Jason Yan <tailofthesun@gmail.com>
Reviewed by Eric Seidel.
Fixed issue with LayoutTests/fast/cookies/local-file-can-set-cookies.html
which can fail when the system under test has local file cookies set already.
https://bugs.webkit.org/show_bug.cgi?id=30281
- fast/cookies/local-file-can-set-cookies-expected.txt: Modified. Updated expected results.
- fast/cookies/local-file-can-set-cookies.html: Modified. Check for existing cookie and set non-persistent cookie.
- 3:36 PM Changeset in webkit [49818] by
-
- 3 edits in trunk/LayoutTests
2009-10-19 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Language tag should include both language and country sub-tags,
case insensitive.
https://bugs.webkit.org/show_bug.cgi?id=30440
- fast/js/navigator-language-expected.txt:
- fast/js/navigator-language.html:
- 3:28 PM Changeset in webkit [49817] by
-
- 2 edits in trunk/WebKitLibraries
2009-10-19 Marshall Culpepper <mculpepper@appcelerator.com>
Reviewed by Eric Seidel.
added cairo include and lib directories to debug_wincairo.vsprops
https://bugs.webkit.org/show_bug.cgi?id=29831
- win/tools/vsprops/debug_wincairo.vsprops:
- 3:10 PM Changeset in webkit [49816] by
-
- 2 edits in trunk/WebKitSite
2009-10-19 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Replace boolean operator indentation example with an if statement.
- coding/coding-style.html: Replace boolean indenting example to use "if"
- 3:00 PM Changeset in webkit [49815] by
-
- 2 edits in trunk/WebCore
2009-10-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add more stop characters into console completions.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions):
- 3:00 PM Changeset in webkit [49814] by
-
- 2 edits in trunk/WebKit/win
Fix crashes/assertions when calling WebLocalizedString from multiple threads concurrently
Fixes <http://webkit.org/b/30534> WebLocalizedString asserts if called
from multiple threads concurrently
Reviewed by John Sullivan.
- WebLocalizableStrings.cpp:
(mainBundleLocStringsMutex):
(frameworkLocStringsMutex):
Added these new getters.
(findCachedString):
(cacheString):
Lock the relevant mutex before accessing each string map. Otherwise
bad things could happen if two threads end up here at the same time.
- 3:00 PM Changeset in webkit [49813] by
-
- 2 edits in trunk/WebKit/win
Get rid of a few static initializers/exit-time destructors in WebLocalizableStrings
Reviewed by Dan Bernstein.
- WebLocalizableStrings.cpp:
(mainBundleLocStrings):
(frameworkLocStrings):
Added these functions instead of file-scope variables.
(findCachedString):
(cacheString):
Updated to use the new functions.
- 2:41 PM Changeset in webkit [49812] by
-
- 4 edits in trunk/WebKit
2009-10-19 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
Update call to FrameLoader::loadFrameRequest() in qt and
FrameLoader::urlSelected() in win.
- 2:39 PM Changeset in webkit [49811] by
-
- 2 edits in trunk/LayoutTests
2009-10-19 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Added the test case for bug #30266 to the Windows skip list because
event.dataTransfer.types does not behave correctly. See bug #30527.
- platform/win/Skipped: Added test case to Windows skipped list.
- 2:31 PM Changeset in webkit [49810] by
-
- 2 edits in trunk/WebCore
2009-10-19 Marshall Culpepper <mculpepper@appcelerator.com>
Reviewed by Adam Roben.
implemented ClipboardWin::files()
https://bugs.webkit.org/show_bug.cgi?id=29666
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::files):
- 2:15 PM Changeset in webkit [49809] by
-
- 13 edits11 adds in trunk
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Alexey Proskuryakov.
Add support for link relations in HTMLAnchorElement and implement rel="noreferrer".
- 2:08 PM Changeset in webkit [49808] by
-
- 2 edits in trunk/WebKit/mac
Documentation fix for -[NSObject(WebResourceLoadDelegate) webView:resource:willSendRequest:redirectResponse:fromDataSource:]
Reviewed by Dan Bernstein.
- WebView/WebResourceLoadDelegate.h: Prepended "webView:" to the
@method declaration of
-webView:resource:willSendRequest:redirectResponse:fromDataSource:
which was absent before r3953 and was missed during the great
documentation clean up of r4269.
- 2:01 PM Changeset in webkit [49807] by
-
- 2 edits in trunk/WebKit/mac
Fix build.
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
- 1:30 PM Changeset in webkit [49806] by
-
- 8 edits in trunk/WebKit/mac
Split assertions of conjunctions into separate statements or remove
redundant assertions.
Reviewed by Anders Carlsson.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::deadNameNotificationCallback):
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView setAttributeKeys:andValues:]):
(-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView halt]):
(-[WebBaseNetscapePluginView resumeFromHalt]):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::checkGrammarOfString):
(WebEditorClient::checkTextOfParagraph):
- WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _reflectSelection]):
- 1:25 PM Changeset in webkit [49805] by
-
- 2 edits in trunk/LayoutTests
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Geoffrey Garen.
Add plugins/netscape-invoke-failures.html to Snow Leopard skipped list.
- platform/mac-snowleopard/Skipped: Add plugins/netscape-invoke-failures.html.
- 1:25 PM Changeset in webkit [49804] by
-
- 3 edits in trunk/WebCore
Refactor out some of the code in paint() into paintPanScrollIcon()
and paintScrollbars() in preparation of some Qt API changes.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-19
Reviewed by David Hyatt.
- platform/ScrollView.cpp:
(WebCore::ScrollView::paint):
- platform/ScrollView.h:
- 1:18 PM Changeset in webkit [49803] by
-
- 4 edits in trunk/WebCore
[v8] typeof(HTMLMediaElement) should return undefined if media
engine is not available
https://bugs.webkit.org/show_bug.cgi?id=30343
Patch by Alpha Lam <hclam@chromium.org> on 2009-10-19
Reviewed by Dimitri Glazkov (Dimitri Glazkov).
Check for availability of the media engine to disable
HTMLMediaElement, HTMLAudioElement, HTMLVideoElement, MediaError
in runtime.
Try runs and review in Chromium:
http://codereview.chromium.org/276011
Test: manual-tests/chromium/media-player-not-available.html
The above test can work work in Chromium. Testing procedures:
- Remove all media support libraries in Chromium (e.g. ffmpeg libraries)
- Open Chromium with above test page
- Verify the test results according to the test page
- bindings/v8/custom/V8CustomBinding.h:
Declare enabler methods.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
Report enabled only if media player is available.
- manual-tests/chromium/media-player-not-available.html: Added.
Manual test, following instruction in this test for procedures.
- page/DOMWindow.idl:
Mark HTMLMediaElement, HTMLAudioElement, HTMLVideElement, MediaError
as enabled at runtime.
- 12:59 PM Changeset in webkit [49802] by
-
- 9 edits1 add in trunk/JavaScriptCore
Added a private API for getting a global context from a context, for
clients who want to preserve a context for a later callback.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-19
Reviewed by Sam Weinig.
- API/APICast.h:
(toGlobalRef): Added an ASSERT, since this function is used more often
than before.
- API/JSContextRef.cpp:
- API/JSContextRefPrivate.h: Added. The new API.
- API/tests/testapi.c:
(print_callAsFunction):
(main): Test the new API.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj: Build and export the new API.
- 12:38 PM Changeset in webkit [49801] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-19 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Alexey Proskuryakov.
[Gtk] ApplicationCacheStorage error while compiling WebKit/gtk/webkit/webkitapplicationcache.cpp
https://bugs.webkit.org/show_bug.cgi?id=30358
Guard calls to cacheStorage() with ENABLE(OFFLINE_WEB_APPLICATIONS).
- webkit/webkitapplicationcache.cpp:
- 12:24 PM Changeset in webkit [49800] by
-
- 2 edits in trunk/WebCore
Make the local static panScrollIcon into a Image* instead
of a RefPtr<Image>.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-19
Reviewed by Adam Roben.
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- 12:19 PM Changeset in webkit [49799] by
-
- 2 edits in trunk/WebCore
Forcefully set antialiasing for Chromium media controls.
Patch by Andrew Scherkus <scherkus@chromium.org> on 2009-10-19
Reviewed by NOBODY (OOPS!).
https://bugs.webkit.org/show_bug.cgi?id=30521
Before it was nondeterministiacally being enabled based on the previous state of GraphicsContext.
Covered by existing layout tests.
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaSlider): Added setShouldAntialias(true).
- 12:11 PM Changeset in webkit [49798] by
-
- 11 edits in trunk/WebCore
2009-10-19 Jens Alfke <jens@mooseyard.com>
Reviewed by Darin Adler.
Optimize string upper/lowercasing
https://bugs.webkit.org/show_bug.cgi?id=30261
- Added AtomicString::upper() and lower()
- Further optimized StringImpl::lower()
- Removed StringImpl::isLower()
- Added QualifiedName::localNameUpper(), which is cached, thereby saving thousands of upper() calls and string allocations.
- dom/Element.cpp: (WebCore::Element::setAttribute): Call AtomicString::lower()
- dom/QualifiedName.cpp: (WebCore::QualifiedName::localNameUpper): New method
- dom/QualifiedName.h: Added localNameUpper() method
- dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Call AtomicString::lower()
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::createElement): Call AtomicString::lower()
- html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): Call localNameUpper()
- platform/text/AtomicString.cpp: (WebCore::AtomicString::lower): New method (WebCore::AtomicString::upper): New method
- platform/text/AtomicString.h: Added lower() and upper()
- platform/text/StringImpl.cpp: Removed isLower() (WebCore::StringImpl::lower): Further optimization of initial loop
- platform/text/StringImpl.h: Removed isLower()
- 11:59 AM Changeset in webkit [49797] by
-
- 19 edits1 delete in trunk/LayoutTests
2009-10-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Update test results and Skipped list after changes in r49791.
Some test results were accidentally committed in r49192. At that time
results were incorrect, but testing still succeeded because of
unimplemented features. After r49791 tests, though generating semantically
equal output to Mac's render trees, started to fail and need to have
generated results updated. This patch does just that.
- platform/gtk/Skipped: Skip a test that does not generate semantically equal render trees.
- platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
- platform/gtk/editing/pasteboard/4076267-2-expected.txt:
- platform/gtk/editing/pasteboard/4076267-3-expected.txt:
- platform/gtk/editing/pasteboard/4076267-expected.txt:
- platform/gtk/editing/pasteboard/paste-table-001-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-015-expected.txt:
- platform/gtk/editing/pasteboard/paste-xml-expected.txt:
- platform/gtk/editing/pasteboard/select-element-1-expected.txt: Removed.
- 11:50 AM Changeset in webkit [49796] by
-
- 6 edits2 adds in trunk
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Test that the proper exception is thrown into JS when a plugin
invoke call returns false.
- plugins/netscape-invoke-failure-expected.txt: Added.
- plugins/netscape-invoke-failure.html: Added.
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
If a call to a plugin's invokeMethod, invokeDefault or construct
returns false, throw an exception into JS.
Test: plugins/netscape-invoke-failure.html
- bindings/v8/V8NPObject.cpp: Check return values of invokeMethod, invokeDefault and construct. (npObjectInvokeImpl):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::invokeMethod): Check return value (JSC::Bindings::CInstance::invokeDefaultMethod): Check return value (JSC::Bindings::CInstance::invokeConstruct): Check return value
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Add testFail() to test plugin so we can test our handling of a
plugin invoke call returning false.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail(). (pluginInvoke): (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
- 11:47 AM Changeset in webkit [49795] by
-
- 2 edits in trunk/JavaScriptCore
Tightened up some instanceof code generation.
https://bugs.webkit.org/show_bug.cgi?id=30488
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-17
Reviewed by Oliver Hunt.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof): No need to do object type checks -
cell type checks and ImplementsDefaultHasIntance checks implicitly
supersede object type checks.
- 11:38 AM Changeset in webkit [49794] by
-
- 3 edits4 adds in trunk
WebCore: Fix for chromium/skia canvas arc start/end positions, when the arc is
360 degrees.
https://bugs.webkit.org/show_bug.cgi?id=30449
Reviewed by Adam Barth.
Covered by new test:
LayoutTests/fast/canvas/arc360.html
- platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::addArc):
LayoutTests: New test for 360 degree arc endpoints, and expected results.
http://bugs.webkit.org/show_bug.cgi?id=30449
Reviewed by Adam Barth.
- fast/canvas/arc360.html: Added.
- platform/mac/fast/canvas/arc360-expected.checksum: Added.
- platform/mac/fast/canvas/arc360-expected.png: Added.
- platform/mac/fast/canvas/arc360-expected.txt: Added.
- 11:14 AM Changeset in webkit [49793] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Add tests that have never passed on Windows to the Skipped list, and reopen
bugs.
- platform/win/Skipped:
- 10:35 AM Changeset in webkit [49792] by
-
- 2 edits in trunk/WebCore
2009-10-19 Kent Tamura <tkent@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix uninitialized variable reference in Element::removeAttribute().
https://bugs.webkit.org/show_bug.cgi?id=30502
- dom/Element.cpp: (WebCore::Element::removeAttribute):
- 10:25 AM Changeset in webkit [49791] by
-
- 7 edits in trunk
2009-10-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Enable tests that pass when DOM pasting is allowed.
- platform/gtk/Skipped:
2009-10-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Add a settings to allow DOM pastes to be performed.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
2009-10-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Enable DOM pasting when running layout tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 10:13 AM Changeset in webkit [49790] by
-
- 11 edits in trunk
2009-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=30463
Remove HTML5 media element 'loadend' event
- dom/EventNames.h:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute): Remove 'loadend'. (WebCore::HTMLMediaElement::loadInternal): Ditto. (WebCore::HTMLMediaElement::noneSupported): Ditto. (WebCore::HTMLMediaElement::mediaEngineError): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::userCancelledLoad): Ditto.
2009-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=30463
Remove HTML5 media element 'loadend' event
- media/event-attributes-expected.txt:
- media/event-attributes.html: Switch from 'loadend' to 'canplaythrough'.
- media/media-load-event-expected.txt:
- media/media-load-event.html: Ditto.
- media/progress-event-at-least-one-expected.txt:
- media/progress-event-at-least-one.html: Ditto.
- 9:26 AM Changeset in webkit [49789] by
-
- 3 edits in trunk/WebCore
2009-10-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Adam Barth.
[Qt] Remove deletion of outgoing FormData object when reply is finished.
The buffers will be destroyed a bit later, when the QNetworkReply is deleted.
Bug: https://bugs.webkit.org/show_bug.cgi?id=29551
- platform/network/qt/QNetworkReplyHandler.cpp:
- platform/network/qt/QNetworkReplyHandler.h:
- 9:18 AM Changeset in webkit [49788] by
-
- 2 edits in trunk/WebCore
2009-10-19 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Fix hard-to-reproduce crash in HTMLTokenizer by avoiding a rare
fastRealloc edge case.
https://bugs.webkit.org/show_bug.cgi?id=29313
No test, the crash shows up occasionally in crash dumps, we weren't able
to reproduce it locally.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::enlargeScriptBuffer): Added an early exit to
avoid calling fastRealloc with the size of 0.
- 9:08 AM Changeset in webkit [49787] by
-
- 2 edits in trunk/WebCore
2009-10-19 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Use fillRect() instead of drawRect() to fix Chromium media controls rendering.
Chromium Mac layout tests will need to be rebaselined. Existing layout tests for Linux/Win still pass.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaSlider): Use fillRect() instead of drawRect().
- 9:00 AM Changeset in webkit [49786] by
-
- 2 edits in trunk/WebCore
2009-10-19 Dmitry Titov <dimich@chromium.org>
Reviewed by Adam Barth.
Crash in DOMWindow::clearTimeout etc when DOMWindow is not connected to a frame.
https://bugs.webkit.org/show_bug.cgi?id=29832
Need to make sure the script caches are reset when frame gets disconnected from still-alive DOMWindow.
This will prevent JS from calling DOMWindow methods that can not be completed w/o the frame.
I am not sure it's possible to test this since the only file that repros the problem need ~10 seconds to cause crash.
- page/Frame.cpp: (WebCore::Frame::~Frame): Right after frame disconnects from DOMWindow, clear WindowShell.
- 8:53 AM Changeset in webkit [49785] by
-
- 5 edits1 add in trunk/WebKit/qt
2009-10-19 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Ariya Hidayat.
Add QWebElement::render API which allows rendering of single
element.
- Api/qwebelement.cpp: (QWebElement::render):
- Api/qwebelement.h:
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::render):
- tests/qwebelement/qwebelement.qrc:
- tests/qwebelement/image.png: Added.
- 8:16 AM Changeset in webkit [49784] by
-
- 2 edits in trunk/WebKit/qt
QWebPage: Doc: setNetworkAccessManager should only be called once.
Patch by Markus Goetz <Markus.Goetz@nokia.com> on 2009-10-19
Reviewed by Ariya Hidayat.
- 8:02 AM Changeset in webkit [49783] by
-
- 2 edits in trunk/WebCore
2009-10-19 Csaba Osztrogonác <Csaba Osztrogonác>
Unreviewed build warning fix.
[Qt] Apply changes to WebCore.pro introduced in r49778
- WebCore.pro: Removed svg/graphics/filters/SVGFEGaussianBlur.h from HEADERS
- 8:01 AM Changeset in webkit [49782] by
-
- 2 edits in trunk/WebKit/qt
Wrong ifdef combination in QGraphicsWebView's event method.
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-19
Reviewed by Tor Arne.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::event):
- 7:42 AM Changeset in webkit [49781] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip failing tests for now and add test-specific information about the cause to the Skipped list.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-19
Reviewed by Tor Arne Vestbø.
- platform/qt/Skipped:
- 7:16 AM Changeset in webkit [49780] by
-
- 2 edits in trunk/WebKit/gtk
Make WebKitHitTestResult actually appear in the index
- 7:00 AM Changeset in webkit [49779] by
-
- 1 edit1 add in trunk/LayoutTests
[Qt] Add platform expected file for canvas test.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-19
Reviewed by Tor Arne Vestbø.
- platform/qt/fast/canvas/canvas-empty-image-pattern-expected.txt: Added.
- 5:57 AM Changeset in webkit [49778] by
-
- 7 edits2 moves in trunk/WebCore
2009-10-19 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
Move feGaussianBlur from WebCore/svg to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=30495
This patch moves SVGFRGaussianBlur from svg/graphics/filters
to platform/graphics/filters/FEGaussianBlur. This is needed
for shadow support on Qt and Cairo.
No change in functionality, therfore no new test case needed.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/FEGaussianBlur.cpp: Added.
- platform/graphics/filters/FEGaussianBlur.h: Added.
- svg/SVGFEGaussianBlurElement.h:
- svg/graphics/filters/SVGFEGaussianBlur.cpp: Removed.
- svg/graphics/filters/SVGFEGaussianBlur.h: Removed.
- 5:49 AM Changeset in webkit [49777] by
-
- 1 edit in trunk/WebCore/ChangeLog
Unreviewed.
Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-19
Added reviewer name to r49574.
- 5:48 AM Changeset in webkit [49776] by
-
- 3 edits in trunk/LayoutTests
2009-10-19 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
[Qt] Update outdated metrics for these passing tests.
- platform/qt/css1/font_properties/font-expected.txt:
- platform/qt/fast/xsl/document-function-expected.txt:
- 4:58 AM Changeset in webkit [49775] by
-
- 2 edits in trunk/WebCore
2009-10-19 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30489
[Gtk] The document frame/html container claims to be parentless
Work around for the parentless claim made by the accessible associated
with the embedded WebView. When we identify this condition, get the
widget's parent, and then get the AtkObject from that. Admittedly an ugly
hack, but we'll need it for Yelp and other Gtk+/GNOME applications which
plan to switch over to WebKit.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent):
- 4:51 AM Changeset in webkit [49774] by
-
- 2 edits in trunk/WebCore
2009-10-19 Benjamin Otte <otte@gnome.org>
Reviewed by Jan Alonzo.
Handle duration queries properly
https://bugs.webkit.org/show_bug.cgi?id=29999
Previously duration queries failed to handle unknown duration
and didn't treat the returned duration as an unsigned.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):
- 4:50 AM Changeset in webkit [49773] by
-
- 2 edits in trunk/WebKit/gtk/po
2009-10-19 Daniel Macks <dmacks@netspace.org>
Reviewed by Adam Barth.
Inconsistent handling of gettext domain can cause compile failure
https://bugs.webkit.org/show_bug.cgi?id=30292
- GNUmakefile.am: Use DOMAIN variable instead of hard-coded value
- 4:28 AM Changeset in webkit [49772] by
-
- 2 edits in trunk/WebCore
2009-10-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Fix build on Windows.
- plugins/win/PluginViewWin.cpp: (windowHandleForPageClient):
- 4:17 AM Changeset in webkit [49771] by
-
- 5 edits2 adds in trunk
Windowed Plugins: Don't crash when client is 0.
Client is 0 when we use QWebPage without a QWebView or QGraphicsWebView.
In addition, setFrameRect()/updatePluginWidget() is called even if the
plugin was not succesfully loaded. updatePluginWidget() updates the
window rect which is, in theory, useful to draw something that indicates
that we didn't load successfully.
So, a status check is added to setNPWindowIfNeeded.
- 3:44 AM Changeset in webkit [49770] by
-
- 7 edits in trunk
2009-10-19 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Holger Freyther.
[Qt] Windowed Plugins: Fix crash when QWebPage is deleted after QWebView.
Fixes various sources of crashes:
- The PluginContainer is a child of QWebView. When the view gets deleted, the PluginView is not notified about the deletion of PluginContainer.
- QWebView destructor does not set client to 0.
- Sometimes pending paint events are sent after the plugin has died, so add a check in PluginView::setNPWindowIfNeeded.
- plugins/qt/PluginContainerQt.cpp: (PluginContainerQt::~PluginContainerQt):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
2009-10-19 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Holger Freyther.
[Qt] Windowed Plugins: Fix crash when QWebPage is deleted after QWebView.
Fixes various sources of crashes:
- The PluginContainer is a child of QWebView. When the view gets deleted, the PluginView is not notified about the deletion of PluginContainer.
- QWebView destructor does not set client to 0.
- Sometimes pending paint events are sent after the plugin has died, so add a check in PluginView::setNPWindowIfNeeded.
- Api/qwebview.cpp: (QWebView::~QWebView):
- tests/qwebview/qwebview.pro:
- tests/qwebview/tst_qwebview.cpp: (tst_QWebView::reusePage_data): (tst_QWebView::reusePage):
- 12:17 AM Changeset in webkit [49769] by
-
- 7 edits in trunk
2009-10-19 Jakob Truelsen <antialize@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=29042
Allow one to customize the minimal and maximal shrink factors used when printing.
- page/PrintContext.cpp: (WebCore::PrintContext::begin):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setPrintingMinimumShrinkFactor): (WebCore::Settings::setPrintingMaximumShrinkFactor):
- page/Settings.h: (WebCore::Settings::printingMinimumShrinkFactor): (WebCore::Settings::printingMaximumShrinkFactor):
2009-10-19 Jakob Truelsen <antialize@gmail.com>
Reviewed by Adam Barth.
Allow one to costumize the minimal and maximal shrink factors,
Added methods setPrintingMinimumShrinkFactor, printingMinimumShrinkFactor,
setPrintingMaximumShrinkFactor, printingMaximumShrinkFactor to QWebSettings.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings): (QWebSettings::setPrintingMinimumShrinkFactor): (QWebSettings::printingMinimumShrinkFactor): (QWebSettings::setPrintingMaximumShrinkFactor): (QWebSettings::printingMaximumShrinkFactor):
- Api/qwebsettings.h:
- 12:04 AM Changeset in webkit [49768] by
-
- 1 edit in trunk/WebKit/qt/ChangeLog
Fix ChangeLog spelling.
Oct 18, 2009:
- 11:59 PM Changeset in webkit [49767] by
-
- 3 edits10 adds in trunk
2009-10-18 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Fixes issue where doubleclicking a word could select following adjacent newlines.
https://bugs.webkit.org/show_bug.cgi?id=30234
- platform/mac/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
- platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
- platform/mac/editing/selection/script-tests/TEMPLATE.html: Added.
- platform/mac/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):
- platform/win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
- platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
- platform/win/editing/selection/script-tests/TEMPLATE.html: Added.
- platform/win/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):
2009-10-18 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Fixes issue where doubleclicking a word could select following adjacent newlines.
https://bugs.webkit.org/show_bug.cgi?id=30234
Tests: platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html
platform/mac/editing/selection/script-tests/TEMPLATE.html
platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html
platform/win/editing/selection/script-tests/TEMPLATE.html
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace):
- 11:51 PM Changeset in webkit [49766] by
-
- 7 edits in trunk
2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Rename fixedContentsSize property to preferredContentsSize as
agreed upon with Siman Hausmann and Matthias Ettrich.
- Api/qwebpage.cpp: (QWebPage::preferredContentsSize): (QWebPage::setPreferredContentsSize):
- Api/qwebpage.h:
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Use the setPreferredContentsSize method instead
of setFixedContentsSize, as the method has been renamed.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setFixedContentsSize):
- 11:50 PM QtBackLog edited by
- (diff)
- 11:46 PM QtBackLog edited by
- Move QtWebKit problems into a table. (diff)
- 11:43 PM Changeset in webkit [49765] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-18 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Use _stricmp and _strnicmp instead of deprecated stricmp and strnicmp.
https://bugs.webkit.org/show_bug.cgi?id=30474
stricmp and strnicmp are deprecated beginning in Visual
C++ 2005. Use _stricmp and _strnicmp instead in StringExtras.h.
- wtf/StringExtras.h: (strncasecmp): (strcasecmp):
- 11:42 PM QtBackLog edited by
- Change Qt items into a table (diff)
- 11:34 PM QtBackLog edited by
- Add completed items to the bottom (diff)
- 8:53 PM Changeset in webkit [49764] by
-
- 2 edits in trunk/WebCore
CURL build fix, use proper header name.
- 7:38 PM Changeset in webkit [49763] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/7309062> Crashes in WebCore::DocumentLoader::isStopping below WebKit::NetscapePluginInstanceProxy::loadRequest.
Reviewed by Dan Bernstein.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::loadRequest): Null-check the DocumentLoader before deferencing it.
- 7:09 PM Changeset in webkit [49762] by
-
- 9 edits in trunk
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Properties on Arrays and NodeLists are not logged correctly.
WebCore:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._printArray):
LayoutTests:
- inspector/console-format-expected.txt:
- inspector/console-format.html:
- 6:20 PM Changeset in webkit [49761] by
-
- 2 edits in trunk/WebCore
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: touching WebCore so that it
initiated inspector frontend deployment on Windows.
Web Inspector: frontend files are not deployed in Windows
incremental build.
- inspector/InspectorDOMAgent.cpp:
- 5:20 PM Changeset in webkit [49760] by
-
- 6 edits6 adds in trunk/LayoutTests
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make console tests more granular.
- inspector/console-dir-expected.txt: Added.
- inspector/console-dir.html: Added.
- inspector/console-dirxml-expected.txt: Added.
- inspector/console-dirxml.html: Added.
- inspector/console-format-expected.txt: Added.
- inspector/console-format.html: Added.
- inspector/console-tests-expected.txt:
- inspector/console-tests.html:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 4:48 PM Changeset in webkit [49759] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:17 PM Changeset in webkit [49758] by
-
- 4 edits in trunk
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Title of dir(["test", "test2"]) should be Array
Test: inspector/console-tests.html
- inspector/front-end/InjectedScript.js:
- 2:15 PM Changeset in webkit [49757] by
-
- 9 edits in trunk
2009-10-18 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
REGRESSION: SVG Mask doesn't work for maskContentUnits="objectBoundingBox"
https://bugs.webkit.org/show_bug.cgi?id=30480
Patch for SVGMaskElement landed in r49598 should correct the location of
the mask image graphics context. It only corrects the location for userSpaceOnUse
mode in maskContentUnits but breaks objectBoundingBoxMode.
The maskDestRect shouldn't be moved. It is not responsible for the correct context
postioin but for the correct position of the mask image.
This patch calculates the context postion independently from the maskDestRect.
It also uses lineareRGB color space for masking on CG now. This is the default
color space for masking operations.
We already have tests for both maskContentUnits modes.
*svg/W3C-SVG-1.1/masking-intro-01-f.svg
*svg/custom/mask-with-default-value.svg
Some tests needed new pixel tests because of the new color space.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
The color space of masking operations in SVG changed to linearSVG.
This needs an update of some masking pixel tests.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/mac/svg/batik/masking/maskRegions-expected.checksum:
- platform/mac/svg/batik/masking/maskRegions-expected.png:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
- 12:55 PM Changeset in webkit [49756] by
-
- 2 edits in trunk/WebCore
2009-10-18 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Use v8::Integer::NewFromUnsigned when converting unsigneds into V8's numbers.
That is notably faster for small numbers (most common case).
https://bugs.webkit.org/show_bug.cgi?id=30493
- bindings/scripts/CodeGeneratorV8.pm:
- 12:29 PM Changeset in webkit [49755] by
-
- 5 edits5 adds in trunk
2009-10-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[GTK] Add MathML to the build system
https://bugs.webkit.org/show_bug.cgi?id=30487
Add --enable-mathml to configure.
- configure.ac:
Add MathML sources if MathML support is enabled.
- GNUmakefile.am:
Include layout test baseline for Gtk.
- platform/gtk/mathml/presentation/sub-expected.txt: Added.
- platform/gtk/mathml/presentation/sup-expected.txt: Added.
- platform/gtk/mathml/presentation/tables-expected.txt: Added.
- 11:21 AM Changeset in webkit [49754] by
-
- 2 edits in trunk/WebCore
Non-PCH build fix. Added missing header.
- 10:17 AM Changeset in webkit [49753] by
-
- 7 edits4 adds in trunk
2009-10-18 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Compositing layers not correctly updated after partial layout
https://bugs.webkit.org/show_bug.cgi?id=30425
When a partial layout happened, for example as the result of a postion-change-only
layout, then some compositing layer positions were not correctly updated. To fix
this, updateLayerPositions() now carries along a flag that is set at the rootmost
layer being updated, and used to determine when we hit the first compositing layer
in this update. RenderLayerBacking::updateAfterLayout() makes use of this information
to do a full geometry update on that layer, which is thus the rootmost compositing
layer that is being updated.
Test: compositing/geometry/partial-layout-update.html
- page/FrameView.cpp: (WebCore::FrameView::layout):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset):
- rendering/RenderLayer.h: (WebCore::RenderLayer::):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
- rendering/RenderLayerBacking.h:
- 10:02 AM Changeset in webkit [49752] by
-
- 6 edits in trunk
Reviewed by Kevin Ollivier.
Add the ability to specify a proxy for wxWebKit.
https://bugs.webkit.org/show_bug.cgi?id=30446
- 9:23 AM Changeset in webkit [49751] by
-
- 2 edits in trunk/WebCore
2009-10-18 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez
https://bugs.webkit.org/show_bug.cgi?id=25901
Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag
Replaces the use of ATK_ROLE_PANEL with the expected accessible roles.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
- 9:08 AM Changeset in webkit [49750] by
-
- 4 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Add basic database support to wx API
https://bugs.webkit.org/show_bug.cgi?id=30445
- 9:00 AM Changeset in webkit [49749] by
-
- 2 edits in trunk/LayoutTests
2009-10-18 Eric Carlson <eric.carlson@apple.com>
Skip media/video-empty-source.html until <rdar://problem/6563117> has been fixed.
- platform/mac/Skipped:
- 7:50 AM QtBackLog edited by
- (diff)
- 2:35 AM QtWebKitPlugins edited by
- (diff)
