Timeline
Oct 23, 2009:
- 11:55 PM QtBackLog edited by
- (diff)
- 11:55 PM QtBackLog edited by
- (diff)
- 11:41 PM QtBackLog edited by
- (diff)
- 9:42 PM QtWebKitPerformanceUtilities edited by
- (diff)
- 9:12 PM Changeset in webkit [50025] by
-
- 4 edits in trunk/WebCore
<rdar://problem/7294131> Assertion failure in AuthenticationMac at
mac(const Credential&) after authenticating to MobileMe Gallery movie
Reviewed by Alexey Proskuryakov.
- platform/network/Credential.cpp:
(WebCore::Credential::Credential): Initialize m_persistence.
(WebCore::Credential::isEmpty): Made this method const.
- platform/network/Credential.h:
- platform/network/mac/AuthenticationMac.mm:
(WebCore::mac): Return nil if the Credential is empty.
- 8:16 PM Changeset in webkit [50024] by
-
- 2 edits in trunk/WebKit/mac
Fix engineering builds in the mysterious future.
- Configurations/DebugRelease.xcconfig:
- 8:06 PM Changeset in webkit [50023] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 8:05 PM Changeset in webkit [50022] by
-
- 1 copy in tags/Safari-6531.21.5
New tag.
- 8:05 PM Changeset in webkit [50021] by
-
- 3 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30617>.
Web Inspector: Resources Scope Bar Should Allow Combinations.
Reviewed by Timothy Hatcher.
Refactor the filtering in ResourcePanel to make it match ConsoleView,
and add a divider between All, and the other choices of Resource types.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):
- inspector/front-end/inspector.css:
- 8:03 PM Changeset in webkit [50020] by
-
- 2 edits in branches/safari-4-branch/WebKit/win
Merge r50019.
- 8:01 PM Changeset in webkit [50019] by
-
- 2 edits in trunk/WebKit/win
Build fix. Include config.h before including other files.
- AccessibleImage.cpp:
- 7:06 PM Changeset in webkit [50018] by
-
- 3 edits3 adds in trunk
2009-10-23 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Added test for bug 27239 (ignore Refresh for view source mode).
https://bugs.webkit.org/show_bug.cgi?id=27239
- http/tests/security/view-source-no-refresh.html: Added
- http/tests/security/view-source-no-refresh-expected.txt: Added
- http/tests/security/resources/view-source-no-refresh.php: Added
2009-10-23 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Ignore the Refresh header if we're in view source mode.
Test: http/tests/security/view-source-no-refresh.html
- loader/FrameLoader.cpp: ignore Refresh in view-source mode.
- 6:10 PM Changeset in webkit [50017] by
-
- 5 edits in trunk/WebCore
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=30734
Remove XMLTokenizer::m_currentNodeIsReferenced
No change in behavior, no tests.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::setCurrentNode):
- dom/XMLTokenizer.h: Don't store a boolean for the current node being the document - we can always check for that.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::XMLTokenizer):
- dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::XMLTokenizer): A fragment passed to XMLTokenizer is never null - in fact, the first thing we do is dereference it unconditionally, and then begin checking it for null, as if it could help.
- 6:09 PM Changeset in webkit [50016] by
-
- 3 edits in trunk/WebCore
No review since this is a build fix.
Build fix for the Mac. (Build is only broken when SVG filters are
enabled.)
Labelled these function static.
- platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::identity):
(WebCore::table):
(WebCore::discrete):
(WebCore::linear):
(WebCore::gamma):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::boxBlur):
- 5:40 PM Changeset in webkit [50015] by
-
- 9 edits2 adds in trunk/WebCore
2009-10-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement a Timeline panel.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/Images/timelineIcon.png: Added.
- inspector/front-end/TimelineAgent.js: (WebInspector.addItemToTimeline): (WebInspector.timelineProfilerWasStarted): (WebInspector.timelineProfilerWasStopped):
- inspector/front-end/TimelinePanel.js: Added. (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype.handleKeyEvent): (WebInspector.TimelinePanel.prototype.timelineWasStarted): (WebInspector.TimelinePanel.prototype.timelineWasStopped): (WebInspector.TimelinePanel.prototype.addItemToTimeline): (WebInspector.TimelinePanel.prototype._innerAddItemToTimeline): (WebInspector.TimelinePanel.prototype._toggleTimelineButton): (WebInspector.TimelinePanel.prototype.setMainViewWidth): (WebInspector.TimelinePanel.prototype.getItemTypeName): (WebInspector.TimelineRecordTreeElement): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._createPanels):
- 5:26 PM Changeset in webkit [50014] by
-
- 2 edits in trunk/WebCore
2009-10-23 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Clash Between Search's onkeyup and incremental search events
https://bugs.webkit.org/show_bug.cgi?id=30731
- inspector/front-end/inspector.js: (WebInspector.performSearch): prevent incremental search event from clobbering a forced search
- 5:24 PM Changeset in webkit [50013] by
-
- 11 edits2 adds in trunk/WebCore
2009-10-23 Kelly Norton <knorton@google.com>
Reviewed by Pavel Feldman.
Removes the need for C++ Timeline types in InspectorTimelineAgent in favor
of ScriptObjects.
https://bugs.webkit.org/show_bug.cgi?id=30707
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/DOMDispatchTimelineItem.cpp: Removed.
- inspector/DOMDispatchTimelineItem.h: Removed.
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentTimelineItem):
- inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::TimelineItemEntry::TimelineItemEntry):
- inspector/TimelineItem.cpp: Removed.
- inspector/TimelineItem.h: Removed.
- inspector/TimelineItemFactory.cpp: Added. (WebCore::TimelineItemFactory::createGenericTimelineItem): (WebCore::TimelineItemFactory::createDOMDispatchTimelineItem):
- inspector/TimelineItemFactory.h: Added. (WebCore::): (WebCore::TimelineItemFactory::TimelineItemFactory):
- 5:13 PM Changeset in webkit [50012] by
-
- 10 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=30729
Provide private API to request the global context for a specific world.
Used to initialize parameters on the global object.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-23
Reviewed by Geoff Garen.
WebCore:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::globalObject):
- bindings/js/ScriptController.h:
WebKit/mac:
- WebView/WebFramePrivate.h:
- WebView/WebFrame.mm:
(-[WebFrame contextForWorldID:]):
WebKit/win:
- WebFrame.cpp:
(WebFrame::contextForWorldID):
- WebFrame.h:
- 4:44 PM Changeset in webkit [50011] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:44 PM Changeset in webkit [50010] by
-
- 1 copy in tags/Safari-6531.21.4
New tag.
- 4:40 PM Changeset in webkit [50009] by
-
- 4 edits4 adds in branches/safari-4-branch
Merge r50004.
- 4:40 PM Changeset in webkit [50008] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r47534.
- 4:35 PM Changeset in webkit [50007] by
-
- 2 edits in trunk/WebKit/win
Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it.
<http://webkit.org/b/30732> and <rdar://7332018>.
Reviewed by John Sullivan.
Turns off pan-scrolling on a WebView when it is about to lose focus.
- WebView.cpp:
(WebViewWndProc):
- 3:40 PM Changeset in webkit [50006] by
-
- 9 edits in trunk/WebCore
2009-10-23 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Fixes style problems in Android-specific files.
https://bugs.webkit.org/show_bug.cgi?id=30717
Style changes only, no new tests possible.
- page/android/EventHandlerAndroid.cpp: Modified. (WebCore::EventHandler::passMouseDownEventToWidget): Fixes whitespace in method signature. (WebCore::EventHandler::passSubframeEventToSubframe): Fixes whitespace in method signature. (WebCore::EventHandler::passWheelEventToWidget): Fixes whitespace in method signature. (WebCore::EventHandler::passMouseMoveEventToSubframe): Fixes whitespace in method signature.
- platform/android/ClipboardAndroid.h: Modified. Fixes header include order and indenting.
- platform/android/CursorAndroid.cpp: Modified. (WebCore::grabCursor): Fixes function braces. (WebCore::grabbingCursor): Fixes function braces.
- platform/android/FileChooserAndroid.cpp: Modified. (WebCore::FileChooser::basenameForWidth): Fixes braces on while statement, and updates String::copy to String::threadsafeCopy.
- platform/android/FileSystemAndroid.cpp: Modified. Fixes header include order. (WebCore::unloadModule): Fixes zero test. (WebCore::writeToFile): Fixes if statement structure.
- platform/android/KeyEventAndroid.cpp: Modified. (WebCore::windowsKeyCodeForKeyEvent): Fixes switch statement indenting. (WebCore::keyIdentifierForAndroidKeyCode): Fixes switch statement indenting.
- platform/android/ScreenAndroid.cpp: Modified. Fixes header include order and switch statement indenting.
- platform/android/TemporaryLinkStubs.cpp: Modified. Fixes header include order.
- 3:25 PM Changeset in webkit [50005] by
-
- 4 edits1 add in trunk/LayoutTests
2009-10-23 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Modified the tests results according to the last changes due
to the fixes of the bug (r49985):
https://bugs.webkit.org/show_bug.cgi?id=29697.
- platform/gtk/editing/execCommand/4916541-expected.txt:
- platform/gtk/editing/execCommand/5138441-expected.txt:
- platform/gtk/editing/execCommand/5481523-expected.txt:
- platform/gtk/editing/execCommand/indent-paragraphs-expected.txt: Added.
- 3:16 PM Changeset in webkit [50004] by
-
- 4 edits4 adds in trunk
MSAA: Name for image elements should use alt attribute text
https://bugs.webkit.org/show_bug.cgi?id=30727
<rdar://problem/7328291>
Reviewed by Alice Liu.
WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::createInstance):
If the AccessibilityObject is an image, return an AccessibleImage.
- AccessibleImage.cpp: Added.
(AccessibleImage::AccessibleImage):
Call the base constructor.
(AccessibleImage::name):
If the object is not an AccessibilityRenderObject, return the base's
name(). Look first for an ARIA "labeled-by" attribute, then look for an
alternate text attribute. Fall back to the base's name().
- AccessibleImage.h: Added.
(AccessibleImage::~AccessibleImage):
- WebKit.vcproj/WebKit.vcproj:
Add AccessibleImage to the project.
LayoutTests:
- platform/win/accessibility/img-alt-attribute-expected.txt: Added.
- platform/win/accessibility/img-alt-attribute.html: Added.
- 2:49 PM Changeset in webkit [50003] by
-
- 2 edits in trunk/WebKitTools
2009-10-23 Eric Seidel <eric@webkit.org>
No review, only adding Alice to the list of reviewers.
- Scripts/modules/committers.py:
- 2:45 PM Changeset in webkit [50002] by
-
- 2 edits in trunk/WebCore
Another shot at a fixed build.
- DerivedSources.cpp:
- 2:33 PM Changeset in webkit [50001] by
-
- 2 edits in trunk/WebCore
Another shot at a fixed build.
- html/HTMLOptionsCollection.idl:
- 2:25 PM Changeset in webkit [50000] by
-
- 1 edit in trunk/WebCore/ChangeLog
50,000!
- ChangeLog: Point out revision 50,000.
- 2:25 PM Changeset in webkit [49999] by
-
- 2 edits in trunk/WebKit/win
Try and fix the windows build.
- Interfaces/WebKit.idl:
- 2:12 PM Changeset in webkit [49998] by
-
- 26 edits8 adds3 deletes in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30695
Drop .tags() support from HTMLCollection
Reviewed by Anders Carlsson.
- Make .tags() only work for HTMLAllCollections in JS. .tags() is still available for all HTMLCollection like objects in Objective-C since that is API.
- Auto-generate HTMLAllCollection.
Test: fast/dom/HTMLDocument/document-all.html
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLAllCollection.cpp: Removed.
- bindings/js/JSHTMLAllCollection.h: Removed.
- bindings/js/JSHTMLAllCollectionCustom.cpp: Added.
(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::getCallData):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
- bindings/js/JSHTMLDocumentCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.cpp:
(WebCore::Document::all):
- dom/Document.h:
- dom/HTMLAllCollection.idl: Removed.
- html/HTMLAllCollection.cpp: Added.
(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::~HTMLAllCollection):
- html/HTMLAllCollection.h: Added.
- html/HTMLAllCollection.idl: Added.
- html/HTMLCollection.h:
- html/HTMLCollection.idl:
- html/HTMLDocument.idl:
- page/DOMWindow.idl:
LayoutTests: Update and add test for https://bugs.webkit.org/show_bug.cgi?id=30695
Drop .tags() support from HTMLCollection
Reviewed by Anders Carlsson.
- fast/dom/HTMLDocument/document-all-expected.txt: Added.
- fast/dom/HTMLDocument/document-all.html: Added.
- fast/dom/HTMLDocument/script-tests: Added.
- fast/dom/HTMLDocument/script-tests/document-all.js: Added.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/dom/script-tests/domListEnumeration.js:
- fast/dom/undetectable-document-all-expected.txt:
- fast/js/global-constructors-expected.txt:
- 1:47 PM Changeset in webkit [49997] by
-
- 4 edits in trunk/WebCore
2009-10-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: pull basic sidebar implementation into the Panel.
- inspector/front-end/Panel.js: (WebInspector.Panel): (WebInspector.Panel.prototype.jumpToPreviousSearchResult): (WebInspector.Panel.prototype.handleKeyEvent): (WebInspector.Panel.prototype._createSidebar): (WebInspector.Panel.prototype._startSidebarDragging): (WebInspector.Panel.prototype._sidebarDragging): (WebInspector.Panel.prototype._endSidebarDragging): (WebInspector.Panel.prototype._updateSidebarWidth): (WebInspector.Panel.prototype.setCenterViewWidth):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.setCenterViewWidth):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.setCenterViewWidth):
- 1:43 PM Changeset in webkit [49996] by
-
- 2 edits in trunk/WebCore
2009-10-23 Jens Alfke <snej@chromium.org>
Reviewed by Dimitri Glazkov.
Slight optimizations to object returning and exception handling in generated V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30599
- bindings/scripts/CodeGeneratorV8.pm: Generate better code
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertToV8Object): Added overload that takes a Ref<>
- bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Remove unnecessary template param to prevent compile error
- 1:35 PM Changeset in webkit [49995] by
-
- 8 edits1 add in trunk
2009-10-23 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Carlson.
Volume slider always starts at half volume
https://bugs.webkit.org/show_bug.cgi?id=28322
- media/video-volume-slider.html: Added. Pixel test for the volume slider of the media control. This test assumes volume slider is implemented and usable. It moves the mouse over the right bottom corner of a video element to trigger the volume slider. If volume slider is not implemented at all, you'll only see a video element with the first frame.
- platform/gtk/Skipped: The above test requires a volume slider so it's skipped.
- platform/mac/Skipped: ditto.
- platform/win/Skipped: ditto.
2009-10-23 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Carlson.
Volume slider always starts at half volume
https://bugs.webkit.org/show_bug.cgi?id=28322
Sets the value attribute of volume slider to the volume attribute
of the media element. Also update the value attribute of the
input element for the volume slider when the volume attribute
of the media element is updated.
Test: media/video-volume-slider.html
- rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::update): Set the value attribute of the input element for the volume slider using the current volume of the media element.
- rendering/MediaControlElements.h: Add method definition of update().
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider): Creates a volume slider with value attribute equals to the current volume attribute of the media element.
- 1:26 PM Changeset in webkit [49994] by
-
- 2 edits in trunk/WebCore
2009-10-23 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
Chrome Linux: fix caret positioning in LTR complex languages
The caret is positioned off by one in languages like Thai.
A group of us spent a while trying various approaches to write a test
for this; however, since it is only that the blinking cursor is
displayed incorrectly, we concluded it can not be tested.
(Patch by Hironori Bono.)
- platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::selectionRectForComplexText):
- 1:13 PM Changeset in webkit [49993] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-10-23 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Add a layout test to assert that media element implementors do not
advance currentTime after being paused.
- media/video-pause-immediately-expected.txt: Added.
- media/video-pause-immediately.html: Added.
- 1:09 PM Changeset in webkit [49992] by
-
- 10 edits in trunk/WebCore
2009-10-23 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
Fix Chromium build after IsoldatedWorld change (r49963).
https://bugs.webkit.org/show_bug.cgi?id=30719
- bindings/ScriptControllerBase.cpp:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInIsolatedWorld):
- bindings/v8/ScriptController.cpp: (WebCore::mainThreadNormalWorld):
- bindings/v8/ScriptController.h: (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell):
- dom/Document.cpp: (WebCore::Document::createWrapperCache):
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
- xml/XMLHttpRequest.cpp:
- xml/XMLHttpRequest.h:
- 1:05 PM Changeset in webkit [49991] by
-
- 3 edits in trunk/LayoutTests
2009-10-23 Victor Wang <victorw@chromium.org>
Reviewed by Eric Seidel.
Update the expected pixel result for test svg-as-background-6.html
The old result is incorrect because of the wrong SVG masking offset calculation.
Patch http://trac.webkit.org/changeset/49598 fixed the issue.
The pixel result of this layout test needs to be updated.
- platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
- platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
- 12:48 PM Changeset in webkit [49990] by
-
- 7 edits2 adds in trunk
2009-10-23 Xiaomei Ji <xji@chromium.org>
Reviewed by Sam Weinig.
Fix caretRangeFromPoint()/elementFromPoint() returns wrong result
for a zoomed and scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30689.
The real cause is the wrong calculation of event.clientX/Y when
page is zoomed and scolled.
After Sam fixed the event.clientX/Y in r49551, the hit test point
should be recalculated (revert r49490).
- fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll-expected.txt: Added.
- fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html: Added.
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
- fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
- fast/dom/elementFromPoint-relative-to-viewport.html:
2009-10-23 Xiaomei Ji <xji@chromium.org>
Reviewed by Sam Weinig.
Fix caretRangeFromPoint()/elementFromPoint() returns wrong result
for a zoomed and scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30689.
The real cause is the wrong calculation of event.clientX/Y when
page is zoomed and scolled.
After Sam fixed the event.clientX/Y in r49551, the hit test point
should be recalculated (revert r49490).
Test: fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html
- dom/Document.cpp: (WebCore::Document::elementFromPoint): calculate the correct point relative to document when page is zoomed and scrolled. (WebCore::Document::caretRangeFromPoint): calculate the correct point relative to document when page is zoomed and scrolled.
- 12:38 PM Changeset in webkit [49989] by
-
- 5 edits2 adds in trunk/WebCore
Adding a class that allows us to enable/disable features at
runtime. Adding a flag to enable database support.
Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-22
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=30653
- WebCore.gypi:
- bindings/v8/RuntimeEnabledFeatures.cpp: Added.
- bindings/v8/RuntimeEnabledFeatures.h: Added.
(WebCore::RuntimeEnabledFeatures::setDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::databaseEnabled):
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
- page/DOMWindow.idl:
- 12:30 PM Changeset in webkit [49988] by
-
- 2 edits in trunk/WebCore
2009-10-23 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
Inspector injects _inspectorCommandLineAPI into global object when opened
https://bugs.webkit.org/show_bug.cgi?id=30675
- inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions): (InjectedScript._evaluateOn): (InjectedScript.addInspectedNode): (InjectedScript._ensureCommandLineAPIInstalled): Moved _inspectorCommandLineAPI from window to console.
- 12:23 PM Changeset in webkit [49987] by
-
- 2 edits in trunk/WebCore
2009-10-23 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Tor Arne Vestbø.
[Qt] don't undef NULL in Symbian emulator
npapi.h way of defining mwerks compiler,intel
and win32 are all true for Symbian emulator.
Changed the definions so that NULL won't be undefined
when compiling for Symbian emulator nor target HW.
- bridge/npapi.h:
- 12:14 PM Changeset in webkit [49986] by
-
- 2 edits in trunk/WebCore
2009-10-23 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Correct linking of sqlite3 for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30569
".lib" will try to include library as static library
causing the library to be searched from wrong directory and if found
will be statically linked instead of the inteded dynamic linking.
- WebCore.pro:
- 12:00 PM Changeset in webkit [49985] by
-
- 21 edits2 adds in trunk
REGRESSION: Copy is copying incorrect background-color
<rdar://problem/7248529>
https://bugs.webkit.org/show_bug.cgi?id=29697
Patch by Enrica Casucci <enrica@apple.com> on 2009-10-23
Reviewed by Adele Peterson.
WebCore:
Test: editing/execCommand/indent-paragraphs.html
This change removes the BackgroundColor from the list
of inheritable CSS properties and changes significantly
the way we perform indentation.
The new implementation of IndentOutdentCommand uses a new method
defined in CompositeEditCommand called moveParagraphWithClones.
This is an improved version of the original moveParagraph that
is aimed at preserving the original markup of the paragraph being
moved.
- editing/ApplyStyleCommand.cpp:
(WebCore::): removed CSSPropertyBackgroundColor from editingStyleProperties.
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::CompositeEditCommand): Removed trailing blanks.
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Removed trailing blanks.
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added.
(WebCore::CompositeEditCommand::cleanupAfterDeletion): Added.
(WebCore::CompositeEditCommand::moveParagraphWithClones): Added.
(WebCore::CompositeEditCommand::moveParagraphs): Modified to use cleanupAfterDeletion.
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Removed trailing blanks.
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Removed trailing blanks.
(WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Removed trailing blanks.
- editing/CompositeEditCommand.h: Added three new methods.
- editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::tryIndentingAsListItem): Changed to use moveParagraphWithClones.
(WebCore::IndentOutdentCommand::indentIntoBlockquote): Changed to use moveParagraphWithClones.
(WebCore::IndentOutdentCommand::indentRegion): Removed comment.
- editing/IndentOutdentCommand.h: Removed prepareBlockquoteLevelForInsertion method.
LayoutTests:
All the following tests have been re-baselined because
the indent command now preserves the original markup.
A new test (indent-paragraph.html) has been added to test
several indent combinations not covered by the existing tests.
- editing/execCommand/19087-expected.txt:
- editing/execCommand/19653-1-expected.txt:
- editing/execCommand/indent-div-inside-list-expected.txt:
- editing/execCommand/indent-nested-blockquotes-expected.txt:
- editing/execCommand/indent-nested-div-expected.txt:
- editing/execCommand/indent-paragraphs.html: Added.
- editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt:
- editing/execCommand/indent-with-style-expected.txt:
- editing/inserting/5994480-2-expected.txt:
- platform/mac/editing/execCommand/4641880-2-expected.txt:
- platform/mac/editing/execCommand/4916541-expected.txt:
- platform/mac/editing/execCommand/5138441-expected.txt:
- platform/mac/editing/execCommand/5481523-expected.txt:
- platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Added.
- platform/mac/editing/execCommand/indent-selection-expected.txt:
- platform/mac/editing/pasteboard/select-element-1-expected.txt:
- 11:57 AM Changeset in webkit [49984] by
-
- 2 edits in trunk/WebKitTools
2009-10-23 Eric Seidel <eric@webkit.org>
Reviewed by Eric Carlson.
fast/media/mq-transform-02.html failed on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=30700
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Update QuickTime version check.
- 10:34 AM Changeset in webkit [49983] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
Isolated worlds tests now pass, removing then from the Skipped
list.
- platform/win/Skipped:
- 9:45 AM Changeset in webkit [49982] by
-
- 2 edits in trunk/WebKitTools
wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
character measurement APIs that are private on Tiger.
- 9:42 AM Changeset in webkit [49981] by
-
- 3 edits in trunk/WebKit/wx
wx build fix. Update the globalObject calls after changes.
- 9:34 AM Changeset in webkit [49980] by
-
- 1 edit in trunk/WebKitSite/blog-files/webgl/resources/blogpost.css
Changed anchor style to take a class name
- 8:53 AM Changeset in webkit [49979] by
-
- 2 edits in trunk/WebKit/mac
2009-10-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by John Sullivan.
<rdar://problem/7322847>
Pressing space bar key in full screen mode should pause movie but doesn't
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController keyDown:]): New, toggle playback on space key. (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Play button action is now called togglePlaying. (-[WebVideoFullscreenHUDWindowController togglePlaying:]): Rename from playingChanged.
- 7:30 AM Changeset in webkit [49978] by
-
- 1 edit in trunk/WebKit/qt/Api/qwebframe.cpp
Qt build fix
- 7:07 AM Changeset in webkit [49977] by
-
- 2 edits in trunk/JavaScriptCore
Fixes a leak in createThreadInternal on Android.
https://bugs.webkit.org/show_bug.cgi?id=30698
Patch by Steve Block <steveblock@google.com> on 2009-10-23
Reviewed by Dmitry Titov.
- wtf/ThreadingPthreads.cpp: Modified.
(WTF::createThreadInternal): Avoid leaking a ThreadData object on failure.
- 5:45 AM Changeset in webkit [49976] by
-
- 3 edits in trunk/WebCore
Adds missing UnusedParam.h includes, required when INSPECTOR is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=30677
Patch by Steve Block <steveblock@google.com> on 2009-10-23
Reviewed by Eric Seidel.
Build fix, no new tests required.
- page/Console.cpp: Modified. Added UnusedParam.h include.
- workers/WorkerContext.cpp: Modified. Added UnusedParam.h include.
- 5:02 AM Changeset in webkit [49975] by
-
- 2 edits in trunk/WebCore
[Qt] Plugins : Use window's winId() instead of the widget's.
2009-10-23 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Holger Freyther.
[Qt] Plugins : Use window's winId() instead of the widget's.
As per, https://developer.mozilla.org/en/NPN_GetValue
NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the
plug-in is displayed; returns Window".
The issue was found because NPNVNetscapeWindow winId() ends up creating
a native window resulting in flicker.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::getValue):
- 5:02 AM Changeset in webkit [49974] by
-
- 2 edits in trunk/WebCore
[Qt] Windowless Plugins : Don't use m_clipRect when painting.
2009-10-23 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Holger Freyther.
[Qt] Windowless Plugins : Don't use m_clipRect when painting.
Though it works, it is not correct to use m_clipRect for painting
in Windowless mode. Instead, the rect paramater that is passed
as a part of PluginView::paint() must be used. This change will
also result in some speedup since previously we used to paint all
the visible parts of a windowless plugin (even if those parts were
not dirty).
Also, fix invalidateRect() to compute the correct width and height.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint): (WebCore::PluginView::invalidateRect):
- 5:02 AM Changeset in webkit [49973] by
-
- 4 edits1 add in trunk/WebCore
Plugins : Use test.swf in the plugins manual tests.
They previously referenced youtube videos which among other things are
cumbersome to use without internet connection. The old youtube link is
just commented out so that testing with youtube can be done with
little effort.
- 4:47 AM Changeset in webkit [49972] by
-
- 3 edits in trunk/LayoutTests
2009-10-23 Xan Lopez <xlopez@igalia.com>
Use the correct Skipped file ...
- platform/gtk/Skipped:
- platform/mac/Skipped:
- 4:43 AM Changeset in webkit [49971] by
-
- 2 edits in trunk/LayoutTests
2009-10-23 Xan Lopez <xlopez@igalia.com>
Skip new tests missing expected results.
- platform/mac/Skipped:
- 1:14 AM Changeset in webkit [49970] by
-
- 2 edits1 add in trunk/WebCore
Fix the Windows Release build by moving Accessibility files
into all-in-one file and excluding them from the build.
Reviewed by Jon Honeycutt.
- WebCore.vcproj/WebCore.vcproj:
- accessibility/AccessibilityAllInOne.cpp: Added.
Oct 22, 2009:
- 11:22 PM Changeset in webkit [49969] by
-
- 16 edits in trunk
Update configurations to support the mysterious future.
Rubber-stamped by Brady Eidson.
- 10:27 PM Changeset in webkit [49968] by
-
- 2 edits in trunk/WebKitTools
Build fix following bug #30696.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
- 10:16 PM Changeset in webkit [49967] by
-
- 23 edits2 deletes in trunk/WebKitSite
Update to WordPress 2.8.5.
- blog:
- 10:06 PM Changeset in webkit [49966] by
-
- 3 edits in trunk/WebKit/qt
Build fix following bug #30696.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (speculative build fix - qt is currently already broken!)
- Api/qwebelement.cpp:
(setupScriptContext):
- Api/qwebframe.cpp:
(QWebFrame::evaluateJavaScript):
- 9:57 PM Changeset in webkit [49965] by
-
- 2 edits in trunk/WebKit/mac
Build fix following bug #30696.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::evaluate):
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::getProperty):
(WebKit::NetscapePluginInstanceProxy::setProperty):
(WebKit::NetscapePluginInstanceProxy::removeProperty):
(WebKit::NetscapePluginInstanceProxy::hasProperty):
(WebKit::NetscapePluginInstanceProxy::hasMethod):
(WebKit::NetscapePluginInstanceProxy::enumerate):
- 9:48 PM Changeset in webkit [49964] by
-
- 3 edits in trunk/WebKit/gtk
Build fix following bug #30696.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::windowObjectCleared):
- webkit/webkitwebframe.cpp:
(webkit_web_frame_get_global_context):
- 9:33 PM Changeset in webkit [49963] by
-
- 101 edits in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=30696
Add support for IsolatedWorlds to JSC bindings.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-16
Reviewed by Sam Weinig & Geoff Garen.
An IsolatedWorld is basically a parallel, separate copy of the window shells and DOM wrapper objects for
a given document. To support isolation this patch:
- Adds support to the ScriptController to track multiple window shells, one per world.
- Adds support to Document to support multiple separate wrapper-maps, one per world.
- Replaces the single global DOM wrapper map (on the WebCoreJSClientData) with separate maps, stored on the (new) IsolatedWorld objects.
In addition to supporting separate copies of these objects, two other features are supported:
- It is necessary to track the current world on entry into JSC, so that within callbacks out to WebCore we can determine which world (and as such, set of DOM bindings) we should be operating on.
- EventListeners & Callbacks are run in the world they were registered in. This requires the handler to retain a reference to the world.
No new tests. (Enabled existing isolated world layout tests.)
- WebCore.base.exp:
- bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMBinding.cpp:
(WebCore::removeWrappers):
(WebCore::DOMObjectWrapperMap::get):
(WebCore::DOMObjectWrapperMap::set):
(WebCore::DOMObjectWrapperMap::remove):
(WebCore::DOMObjectWrapperMap::take):
(WebCore::IsolatedWorld::IsolatedWorld):
(WebCore::IsolatedWorld::~IsolatedWorld):
(WebCore::EnterIsolatedWorld::EnterIsolatedWorld):
(WebCore::EnterIsolatedWorld::~EnterIsolatedWorld):
(WebCore::JSGlobalDataWorldIterator::JSGlobalDataWorldIterator):
(WebCore::JSGlobalDataWorldIterator::operator bool):
(WebCore::JSGlobalDataWorldIterator::operator*):
(WebCore::JSGlobalDataWorldIterator::operator->):
(WebCore::JSGlobalDataWorldIterator::operator++):
(WebCore::getCurrentWorld):
(WebCore::getNormalWorld):
(WebCore::commonNormalWorld):
(WebCore::commonCurrentWorld):
(WebCore::DOMObjectHashTableMap::mapFor):
(WebCore::DOMObjectWrapperMap::mapFor):
(WebCore::forgetDOMObject):
(WebCore::getCachedDOMNodeWrapper):
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
(WebCore::forgetAllDOMNodesForDocument):
(WebCore::forgetWorldOfDOMNodesForDocument):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markActiveObjectsForContext):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::allowsAccessFromFrame):
(WebCore::printErrorMessageForFrame):
(WebCore::JSC_DebuggerCallFrame_evaluateInWorld):
(WebCore::JSC_callInWorld):
(WebCore::JSC_constructInWorld):
(WebCore::JSC_evaluateInWorld):
- bindings/js/JSDOMBinding.h:
(WebCore::IsolatedWorld::rememberDocument):
(WebCore::IsolatedWorld::forgetDocument):
(WebCore::IsolatedWorld::rememberScriptController):
(WebCore::IsolatedWorld::forgetScriptController):
(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::currentWorld):
(WebCore::WebCoreJSClientData::normalWorld):
(WebCore::WebCoreJSClientData::rememberWorld):
(WebCore::WebCoreJSClientData::forgetWorld):
(WebCore::debuggerWorld):
(WebCore::pluginWorld):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
(WebCore::toJSDOMGlobalObject):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::printErrorMessage):
(WebCore::JSDOMWindowBase::commonJSGlobalData):
(WebCore::toJS):
(WebCore::toJSDOMWindow):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::createWindow):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):
(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::setInterval):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::toJS):
(WebCore::toJSDOMWindowShell):
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::create):
- bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
- bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
- bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::nameGetter):
- bindings/js/JSInspectorBackendCustom.cpp:
(WebCore::JSInspectorBackend::databaseForId):
(WebCore::JSInspectorBackend::inspectedWindow):
(WebCore::JSInspectorBackend::nodeForId):
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::parseCode):
- bindings/js/JSLazyEventListener.h:
(WebCore::JSLazyEventListener::create):
- bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::markChildren):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::markChildren):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::markChildren):
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
- bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):
- bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::markChildren):
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::setInterval):
- bindings/js/JSXMLHttpRequestConstructor.cpp:
(WebCore::constructXMLHttpRequest):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::markChildren):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::executeFunctionInContext):
(WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h:
(WebCore::ScheduledAction::ScheduledAction):
- bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::jsObjectForPluginElement):
- bindings/js/ScriptController.h:
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::globalObject):
(WebCore::ScriptController::forgetWorld):
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject):
- bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
- bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
- bindings/js/ScriptObjectQuarantine.cpp:
(WebCore::getQuarantinedScriptObject):
- bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):
- bindings/js/ScriptState.h:
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::evaluate):
- bindings/objc/DOMInternal.mm:
(-[WebScriptObject _initializeScriptDOMNodeImp]):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
- dom/Document.cpp:
(WebCore::Document::createWrapperCache):
- dom/Document.h:
(WebCore::Document::wrapperCacheMap):
(WebCore::Document::getWrapperCache):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
- inspector/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchWindowObjectAvailable):
- platform/network/mac/AuthenticationMac.mm:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::dropProtection):
- xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::create):
WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=30696
Update to incorporate support for IsolatedWorlds in JSC bindings.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-16
Reviewed by Sam Weinig & Geoff Garen.
- WebView/WebFrame.mm:
(-[WebFrame _attachScriptDebugger]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame globalContext]):
- WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]):
- WebView/WebView.mm:
(-[WebView aeDescByEvaluatingJavaScriptFromString:]):
WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=30696
Update to incorporate support for IsolatedWorlds in JSC bindings.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by Sam Weinig & Geoff Garen.
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp:
(WebFrame::globalContext):
(WebFrame::windowObjectCleared):
(WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld):
- WebFrame.h:
WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=30696
Enable isolated-worlds tests on mac.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by Sam Weinig & Geoff Garen.
Add private interface for DRT to invoke execution in a given world.
- DumpRenderTree/LayoutTestController.cpp:
(evaluateScriptInIsolatedWorldCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::evaluateScriptInIsolatedWorld):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=30696
Enable isolated-worlds tests on mac.
- Update the results to switch from windows to unix line-endings.
- Update all-window-prototypes.html to allow for properties on the global object with null prototypes (just skip over them).
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-19
Reviewed by Sam Weinig & Geoff Garen.
- http/tests/security/isolatedWorld/all-window-properties-expected.txt:
- http/tests/security/isolatedWorld/all-window-prototypes-expected.txt:
- http/tests/security/isolatedWorld/all-window-prototypes.html:
- http/tests/security/isolatedWorld/body-properties-expected.txt:
- http/tests/security/isolatedWorld/body-prototype-expected.txt:
- http/tests/security/isolatedWorld/document-properties-expected.txt:
- http/tests/security/isolatedWorld/document-prototype-expected.txt:
- http/tests/security/isolatedWorld/global-variables-expected.txt:
- http/tests/security/isolatedWorld/image-properties-expected.txt:
- http/tests/security/isolatedWorld/image-prototype-expected.txt:
- http/tests/security/isolatedWorld/location-properties-expected.txt:
- http/tests/security/isolatedWorld/location-prototype-expected.txt:
- http/tests/security/isolatedWorld/number-prototype-expected.txt:
- http/tests/security/isolatedWorld/object-prototype-expected.txt:
- http/tests/security/isolatedWorld/storage-properties-expected.txt:
- http/tests/security/isolatedWorld/storage-prototype-expected.txt:
- http/tests/security/isolatedWorld/string-prototype-expected.txt:
- http/tests/security/isolatedWorld/window-properties-expected.txt:
- platform/mac/Skipped:
- 9:12 PM Changeset in webkit [49962] by
-
- 2 edits in trunk/WebCore
2009-10-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: EventListenersSidebarPane TODO No Longer Needed
https://bugs.webkit.org/show_bug.cgi?id=30705
- inspector/front-end/EventListenersSidebarPane.js:
- 5:22 PM Changeset in webkit [49961] by
-
- 3 edits in trunk/LayoutTests
Updating expected results - unreviewed.
Updated expected computed style results on Windows after r49959.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 5:00 PM Changeset in webkit [49960] by
-
- 3 edits in trunk/WebCore
Reviewed by Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=30506
<rdar://problem/7319845> Resources that the server sent as 304 not modified are not shown
in the inspectors resource pane
I don't know how to make a test for this.
The issue here was that preloaded resources weren't added to DocLoader document resource set,
but Web Inspector asked DocLoader to fetch data from CachedResource. Even when (if) document
parser eventually requested the same resource for real and it got added to resource set, it
was too late - the Inspector wasn't updated.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
- inspector/InspectorResource.h: Fix the issue by trying to fetch corresponding CachedResource harder - also look in global cache. This seems safe, and easier than updating the Inspector on transitions between resource states (revalidate vs. revalidate done and preload vs. non-preload).
- 4:34 PM Changeset in webkit [49959] by
-
- 17 edits36 adds in trunk
WebCore: Fix for <rdar://problem/6942706> ER: Add a CSS property that allows
shadows to work for SVG content
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=30479
Reviewed by Dan Bernstein.
This patch adds a new SVG-specific CSS property called -webkit-
shadow that has the same syntax as -webkit-box-shadow
Add CSSPropertyWebkitShadow to the list of SVG CSS properties, and
make valueForShadow a member function rather than a static function
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSComputedStyleDeclaration.h:
Call valueForShadow for CSSPropertyWebkitShadow
- css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
Do standard CSS stuff for CSSPropertyWebkitShadow
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- css/SVGCSSPropertyNames.in:
- css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
Set the appropriate shadow on the paint context if we have one.
This seems to be all we have to do to have an SVG-shaped shadow.
- rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
Add shadow to SVGRenderStyle. I added a new macro that I don't like
just because that's the way things are done here right now.
- rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::SVGRenderStyle):
(WebCore::SVGRenderStyle::operator==):
- rendering/style/SVGRenderStyle.h:
- rendering/style/SVGRenderStyleDefs.cpp:
(StyleShadowSVGData::StyleShadowSVGData):
(StyleShadowSVGData::operator==):
- rendering/style/SVGRenderStyleDefs.h:
(WebCore::StyleShadowSVGData::create):
(WebCore::StyleShadowSVGData::copy):
(WebCore::StyleShadowSVGData::operator!=):
LayoutTests: Tests for <rdar://problem/6942706> ER: Add a CSS property that
allows shadows to work for SVG content
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=30479
Reviewed by Dan Bernstein.
New results that include -webkit-shadow:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
New tests and their results.
- platform/mac/svg/css/arrow-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/arrow-with-shadow-expected.png: Added.
- platform/mac/svg/css/arrow-with-shadow-expected.txt: Added.
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.png: Added.
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
- platform/mac/svg/css/clippath-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/clippath-with-shadow-expected.png: Added.
- platform/mac/svg/css/clippath-with-shadow-expected.txt: Added.
- platform/mac/svg/css/group-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/group-with-shadow-expected.png: Added.
- platform/mac/svg/css/group-with-shadow-expected.txt: Added.
- platform/mac/svg/css/mask-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/mask-with-shadow-expected.png: Added.
- platform/mac/svg/css/mask-with-shadow-expected.txt: Added.
- platform/mac/svg/css/path-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/path-with-shadow-expected.png: Added.
- platform/mac/svg/css/path-with-shadow-expected.txt: Added.
- platform/mac/svg/css/stars-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/stars-with-shadow-expected.png: Added.
- platform/mac/svg/css/stars-with-shadow-expected.txt: Added.
- platform/mac/svg/filters/shadow-on-filter-expected.checksum: Added.
- platform/mac/svg/filters/shadow-on-filter-expected.png: Added.
- platform/mac/svg/filters/shadow-on-filter-expected.txt: Added.
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.checksum: Added.
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
- svg/css/arrow-with-shadow.svg: Added.
- svg/css/circle-in-mask-with-shadow.svg: Added.
- svg/css/clippath-with-shadow.svg: Added.
- svg/css/getComputedStyle-basic-expected.txt:
- svg/css/group-with-shadow.svg: Added.
- svg/css/mask-with-shadow.svg: Added.
- svg/css/path-with-shadow.svg: Added.
- svg/css/stars-with-shadow.html: Added.
- svg/filters/shadow-on-filter.svg: Added.
- svg/filters/shadow-on-rect-with-filter.svg: Added.
- 4:07 PM Changeset in webkit [49958] by
-
- 4 edits in trunk/WebCore
2009-10-22 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25530
[Gtk] Implement LABEL_FOR/LABELLED_BY relationship pair for labels
Implements atk_object_ref_relation_set and LABEL_FOR/LABELLED_BY.
Also causes the accessible name for labeled controls to be based on
the label as expected, rather than based on the contents.
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityRenderObject.cpp: (correspondingLabelForControlElement):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkRelationSetFromCoreObject): (webkit_accessible_ref_relation_set): (webkit_accessible_class_init): (webkit_accessible_get_name):
- 2:32 PM Changeset in webkit [49957] by
-
- 4 edits2 adds in trunk
2009-10-22 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Added expected result for clicked-link-is-visited.html.
Removed test case from qt/Skipped as it works now.
- platform/qt/Skipped:
- platform/qt/fast/history: Added.
- platform/qt/fast/history/clicked-link-is-visited-expected.txt: Added.
2009-10-22 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Enable track visited links in QWebPage
https://bugs.webkit.org/show_bug.cgi?id=30574
Test: fast/history/clicked-link-is-visited.html
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
- 2:08 PM Changeset in webkit [49956] by
-
- 2 edits in trunk/WebCore
2009-10-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: windowFocused and windowBlured Fail to Clear/Mark Inspector as "inactive"
https://bugs.webkit.org/show_bug.cgi?id=30663
Correctly handle focusing/blurring on inner <iframe>'s such as Source Frames.
- inspector/front-end/inspector.js: (WebInspector.windowFocused): fix for inner iframes (WebInspector.windowBlurred): fix for inner iframes (WebInspector.addMainEventListeners): change useCapture to false
- 1:33 PM Changeset in webkit [49955] by
-
- 4 edits in trunk/JavaScriptCore
Fixed ASSERT when opening Safari's Caches window while the Web Inspector
is open.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-22
Reviewed by Alexey Proskuryakov.
- runtime/Collector.cpp:
(JSC::typeName): Added two new types to the type name list in the Collector.
These types have been around for a while, but nobody remembered to consider them here.
- runtime/JSCell.h:
(JSC::JSCell::isPropertyNameIterator):
- runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::isPropertyNameIterator): Give the Collector
a way to tell if a cell is a JSPropertyNameIterator.
- 1:19 PM Changeset in webkit [49954] by
-
- 3 edits in trunk/WebCore
2009-10-22 Jaime Yap <jaimeyap@google.com>
Reviewed by Timothy Hatcher.
Makes a page reload optional when activating resource monitoring in
InspectorController. It leaves the default behavior as performing the reload.
Reload is an optional param so callsites do not have to change.
No new tests added.
- inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking):
- inspector/InspectorController.h:
- 1:10 PM Changeset in webkit [49953] by
-
- 2 edits in trunk/WebKit/qt
2009-10-22 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Eric Seidel.
[Qt] Add Print Shortcut to QtLauncher
- QtLauncher/main.cpp: (MainWindow::setupUI):
- 1:06 PM Changeset in webkit [49952] by
-
- 2 edits1 delete in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=30686
Remove debug-specific def file.
Only Debug_All target uses JavaScriptCore_debug.dll naming, and since
that target is only used internally, maintaining two files just to
suppress a single link warning isn't worthwhile.
Reviewed by Jon Honeycutt.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Removed.
- 12:56 PM Changeset in webkit [49951] by
-
- 2 edits in trunk/WebCore
2009-10-22 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Fix memory leak in QNetworkReplyHandler::abort().
In QNetworkReplyHandler::release(), m_reply should no longer point to its parent
after being released.
https://bugs.webkit.org/show_bug.cgi?id=30167
No layout test available as a non-functional fix.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::abort): (WebCore::QNetworkReplyHandler::release):
- 12:15 PM Changeset in webkit [49950] by
-
- 4 edits in trunk/WebCore
2009-10-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fix DOMAgent leak.
- inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
- 11:35 AM Changeset in webkit [49949] by
-
- 19 edits in trunk/WebCore
2009-10-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Rework event listeners to not hold references to frame or V8 context.
Covered by existing layout tests: fast/events/attribute-listener*
- bindings/scripts/CodeGeneratorV8.pm: Added passing ScriptExecutionContext*
to event listener handling code.
- bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep): Changed to use currentContext().
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Reworked to match JSC logic. (WebCore::getEventListenerHandlerBody): Added ScriptExecutionContext* param.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): Removed Frame* param
and usage.
(WebCore::V8AbstractEventListener::handleEvent): Chaged to use ScriptExecutionContext*.
(WebCore::V8AbstractEventListener::invokeEventHandler): Ditto.
- bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::getListenerObject): Ditto. (WebCore::V8AbstractEventListener::prepareListenerObject): Ditto.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Added ScriptExecutionContext* param. (WebCore::V8DOMWrapper::getEventListener): Ditto.
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Ditto.
- bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper): Removed ContextType* template param,
because it's no longer needed.
- bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::sharedContext): Renamed from shared_context.
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): Removed Frame* param and usage. (WebCore::V8LazyEventListener::callListenerFunction): Added ScriptExecutionContext* param. (WebCore::V8LazyEventListener::prepareListenerObject): Ditto.
- bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create): Reordered params to match JSC impl.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): Adjusted formatting to match WebKit style. (WebCore::V8Proxy::evaluateInNewContext): Changed to use m_context directly. (WebCore::V8Proxy::setInjectedScriptContextDebugId): Ditto. (WebCore::V8Proxy::createWrapperFromCacheSlowCase): Ditto. (WebCore::V8Proxy::isContextInitialized): Ditto. (WebCore::V8Proxy::updateDocumentWrapperCache): Ditto. (WebCore::V8Proxy::clearDocumentWrapperCache): Ditto. (WebCore::V8Proxy::disposeContextHandles): Added explicit disposing of m_context. (WebCore::V8Proxy::clearForClose): Changed to use m_context directly. (WebCore::V8Proxy::clearForNavigation): Ditto. (WebCore::V8Proxy::setSecurityToken): Ditto. (WebCore::V8Proxy::updateDocument): Ditto. (WebCore::V8Proxy::initContextIfNeeded): Ditto. (WebCore::V8Proxy::context): Changed to use v8::Local. (WebCore::V8Proxy::mainWorldContext): Changed to use m_context directly. (WebCore::V8Proxy::setContextDebugId): Ditto. (WebCore::toV8Context):
- bindings/v8/V8Proxy.h: Removed shared_context decl, changed to use straight
v8::Persistent for m_context.
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::workerProxy): Added. (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): Removed
WorkerContextExecutionProxy* param.
(WebCore::V8WorkerContextEventListener::handleEvent): Started using ScriptExecutionContext*.
(WebCore::V8WorkerContextEventListener::reportError): Ditto.
(WebCore::V8WorkerContextEventListener::callListenerFunction): Ditto.
(WebCore::V8WorkerContextEventListener::getReceiverObject): Ditto.
- bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create): Removed
WorkerContextExecutionProxy* param.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener): Removed ContextType*
template param.
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener): Removed Frame* param. (WebCore::V8EventListener::getListenerFunction): Started using ScriptExecutionContext*. (WebCore::V8EventListener::callListenerFunction): Ditto.
- bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create): Removed Frame* param.
- 11:10 AM Changeset in webkit [49948] by
-
- 4 edits in trunk/WebKit/mac
2009-10-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein & Simon Fraser.
<rdar://problem/7297717>
https://bugs.webkit.org/show_bug.cgi?id=30323
Play/pause button in full-screen video controller does not reflect current state
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController setMediaElement:WebCore::]): Register for QTMovieRateDidChangeNotification (-[WebVideoFullscreenController rateChanged:]): Call HUD controller when rate changes.
- WebView/WebVideoFullscreenHUDWindowController.h:
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Call updateRate so play button reflects playback state. (-[WebVideoFullscreenHUDWindowController updateRate]): New, set play button state according to movie state. (-[WebVideoFullscreenHUDWindowController playingChanged:]): Only call [self playing] once.
- 10:49 AM Changeset in webkit [49947] by
-
- 5 edits in trunk/WebCore
2009-10-14 Gaurav Shah <gauravsh@google.com>
Reviewed by Darin Fisher.
Replaces temporary link stub for <keygen> tag handler for the Chromium
browser with a call via the Chromium Bridge.
- platform/SSLKeyGenerator.h:
- platform/chromium/ChromiumBridge.h:
- platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
- platform/chromium/TemporaryLinkStubs.cpp: (WebCore::KURL::fileSystemPath): (WebCore::SharedBuffer::createWithContentsOfFile):
- 10:48 AM Changeset in webkit [49946] by
-
- 3 edits in trunk/WebCore
Fixes Chromium Mac pasteboard handling to flow through the same code paths as other platforms.
Patch by Avi Drissman <avi@chromium.org> on 2009-10-22
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=30591
- platform/chromium/ChromiumBridge.h:
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage):
- 10:33 AM Changeset in webkit [49945] by
-
- 6 edits in trunk/WebCore
2009-10-20 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Make accelerated compositing debug indicators work in release builds
https://bugs.webkit.org/show_bug.cgi?id=30588
Allow some debug indicators, that show which page elements go into compositing layers,
to work in release builds, when the runtime prefs are set.
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): (WebCore::GraphicsLayer::setZPosition):
- platform/graphics/GraphicsLayer.h:
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::clearBorderColor): (WebCore::GraphicsLayer::showRepaintCounter): (WebCore::GraphicsLayerCA::GraphicsLayerCA): (WebCore::GraphicsLayerCA::updateMasksToBounds): (WebCore::GraphicsLayerCA::updateLayerDrawsContent): (WebCore::GraphicsLayerCA::setDebugBorder): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): (WebCore::GraphicsLayerCA::setupContentsLayer):
- platform/graphics/mac/WebLayer.mm:
- 10:30 AM Changeset in webkit [49944] by
-
- 2 edits in trunk/LayoutTests
2009-10-22 Xan Lopez <xlopez@igalia.com>
Skip failing tests that seems to be somewhat tied to the Mac
platform. See https://bugs.webkit.org/show_bug.cgi?id=30680
- platform/gtk/Skipped:
- 9:42 AM Changeset in webkit [49943] by
-
- 2 edits in trunk/WebKit/qt
Code standarlization for QGVLauncher.
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-22
RubberStamped by Tor Arne Vestbø.
1) Made member initilization lists in constructors
to be per line.
2) Made applyProxy method inline as all other methods in
WebPage class.
- QGVLauncher/main.cpp:
(WebPage::WebPage):
(WebPage::applyProxy):
(MainView::MainView):
(MainWindow::MainWindow):
(MainWindow::init):
- 9:34 AM Changeset in webkit [49942] by
-
- 2 edits in trunk/WebKit/qt
Add a Y-Axis rotation to QGVLauncher.
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-22
Reviewed by Tor Arne Vestbø.
It uses the QStateMachine API from Qt 4.6.
- QGVLauncher/main.cpp:
(WebView::WebView):
(WebView::setYRotation):
(WebView::yRotation):
(MainView::flip):
(MainView::animatedYFlip):
(SharedScene::SharedScene):
(SharedScene::webView):
(MainWindow::init):
(MainWindow::animatedYFlip):
(MainWindow::buildUI):
- 8:53 AM Changeset in webkit [49941] by
-
- 2 edits in trunk/LayoutTests
2009-10-22 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Fix video-played.js to use an error timeout based on time rather than function call count.
- media/video-played.js: (nowInSecs): Returns the current time in seconds. (playForMillisecs.callPauseIfTimeIsReached): Change from call counts to using elapsed time. (playForMillisecs): Ditto.
- 8:45 AM Changeset in webkit [49940] by
-
- 3 edits in trunk/WebCore
2009-10-22 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Pavel Feldman.
Inspector should support monitorEvents/un monitorEvents() in the command line
https://bugs.webkit.org/show_bug.cgi?id=19879
- inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): Ignores event listeners generated by monitorEvent
- inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI._logEvent, _allEventTypes, _normalizeEventTypes, monitorEvent, unmonitorEvent.
- 8:28 AM Changeset in webkit [49939] by
-
- 2 edits in trunk/WebCore
2009-10-21 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: windowFocused and windowBlurred Fail to Clear/Mark Inspector as "inactive"
https://bugs.webkit.org/show_bug.cgi?id=30663
- inspector/front-end/inspector.js: (WebInspector.windowFocused): (WebInspector.windowBlurred):
- 8:23 AM Changeset in webkit [49938] by
-
- 2 edits in trunk/WebCore
2009-10-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Error - requestContentType [undefined] is not an object
https://bugs.webkit.org/show_bug.cgi?id=30666
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshFormData):
- 4:52 AM Changeset in webkit [49937] by
-
- 2 edits in trunk/WebCore
2009-10-22 Maxime Simon <Maxime Simon>
Reviewed by Holger Freyther.
[Haiku] Correction of the accented letter width (they were 2 characters long).
https://bugs.webkit.org/show_bug.cgi?id=30629
- platform/graphics/haiku/SimpleFontDataHaiku.cpp: (WebCore::SimpleFontData::platformWidthForGlyph):
- 3:49 AM Changeset in webkit [49936] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-22 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
m_webView should be private attribute of the EditorClientGtk.
https://bugs.webkit.org/show_bug.cgi?id=30664
- WebKit/gtk/WebCoreSupport/EditorClientGtk.h:
- 3:39 AM Changeset in webkit [49935] by
-
- 2 edits in trunk/LayoutTests
2009-10-22 Xan Lopez <xlopez@igalia.com>
libsoup can reconstruct URIs with empty querys now, so unskip
another bunch of tests.
- platform/gtk/Skipped:
- 3:24 AM Changeset in webkit [49934] by
-
- 2 edits in trunk/LayoutTests
2009-10-22 Xan Lopez <xlopez@igalia.com>
Unskip a couple of working tests.
- platform/gtk/Skipped:
- 12:15 AM Changeset in webkit [49933] by
-
- 6 edits in trunk
<rdar://problem/7270320> Screenshots of off-screen plug-ins are blank
<rdar://problem/7270314> After halting a transparent PluginView on
Windows, the transparency is applied twice
Reviewed by Dan Bernstein.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Export WTF::deleteOwnedPtr(HDC).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Ditto.
WebCore:
Replace use of Frame::nodeImage() with a function that takes a snapshot
of a PluginView.
Reviewed by Dan Bernstein.
- plugins/PluginView.h:
Made paintWindowedPluginIntoContext() non-const, as it now calls
paintIntoTransformedContext(). Declare paintIntoTransformedContext()
and snapshot() for Windows platforms.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintIntoTransformedContext):
Paints into the passed HDC without applying any coordinate translations.
Code moved from paintWindowedPluginIntoContext() and paint(). Removed
the memset() of windowpos in lieu of assignment.
(WebCore::PluginView::paintWindowedPluginIntoContext):
Code moved to paintIntoTransformedContext().
(WebCore::PluginView::paint):
Ditto.
(WebCore::PluginView::snapshot):
Create a context, and if the plug-in is windowless, translate it so the
plug-in will draw at the correct location. Create a bitmap, and select
it into the context. Paint the plug-in, and create a BitmapImage from
the bitmap.
(WebCore::PluginView::halt):
Use snapshot().
- 12:11 AM Changeset in webkit [49932] by
-
- 2 edits in trunk/WebCore
2009-10-22 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix calculation of length in WebSocketChannel.cpp
https://bugs.webkit.org/show_bug.cgi?id=30656
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):