⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 24, 2009:

9:56 PM Changeset in webkit [50039] by timothy@apple.com
  • 5 edits in trunk/WebCore

WebInspector: Fixed issue with IME inside console
​https://bugs.webkit.org/show_bug.cgi?id=30660

Patch by Keishi Hattori <​casey.hattori@gmail.com> on 2009-10-24
Reviewed by Timothy Hatcher.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._promptKeyDown):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._promptKeyDown):

  • inspector/front-end/inspector.js:

(WebInspector.loaded):
(WebInspector.searchKeyDown): Moved performSearch here from WebInspector.searchKeyUp.
(WebInspector.startEditing.element.handleKeyEvent):
(WebInspector.startEditing):

  • inspector/front-end/utilities.js:

(isEnterKey): Added. Check if in IME.

9:13 PM Changeset in webkit [50038] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Fixes <​https://bugs.webkit.org/show_bug.cgi?id=30752>.
Web Inspector: Multiple Selection on Scope Bars by default Conflicts with other behavior on OSX.

Reviewed by Timothy Hatcher.

Have the scope bars select one scope by default, but if the multiple selection key
is pressed, allow for multiple selection.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype._updateFilter):
(WebInspector.ConsoleView.prototype.filter):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):

7:44 PM Changeset in webkit [50037] by weinig@apple.com
  • 18 edits
    1 add in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLCollectionFunctions.h: Added.

(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.

  • bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h

for toJS on document.all.

  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:

LayoutTests: Update tests for ​https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • fast/dom/wrapper-classes-expected.txt:
4:08 PM Changeset in webkit [50036] by timothy@apple.com
  • 4 edits in trunk/WebCore

Make the scope bars in the Web Inspector match other scope bars in Mac OS X.
Also cleans up the CSS to use classes instead of ID selectors.

​https://bugs.webkit.org/show_bug.cgi?id=28186

Reviewed by Dan Bernstein.

  • inspector/front-end/ResourcesPanel.js: Add the scope-bar class.
  • inspector/front-end/inspector.css: Lots of changes to make it look right.
  • inspector/front-end/inspector.html: Add the scope-bar class.
4:08 PM Changeset in webkit [50035] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix selecting Resources in the Web Inspector's Resources panel.

​https://bugs.webkit.org/show_bug.cgi?id=30743

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.isCategoryVisible): Added.
(WebInspector.ResourceSidebarTreeElement.prototype.get selectable): Call
isCategoryVisible on the ResourcesPanel.

4:08 PM Changeset in webkit [50034] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix the Scope Bar in the Web Inspector's Resource panel, so that selecting
All will deselect the other filters.

​https://bugs.webkit.org/show_bug.cgi?id=30744

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.createFilterElement): Better syntax.
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter): Use a normal for loop,
and the child variable instead of target in the loop. Other clean up.

4:08 PM Changeset in webkit [50033] by timothy@apple.com
  • 6 edits in trunk/WebCore

Make resizing the Web Inspector's Elements panel sidebar work again.
Also makes Resources panel use the sidebar code in Panel.

​https://bugs.webkit.org/show_bug.cgi?id=30742

Reviewed by Pavel Feldman.

  • inspector/front-end/Panel.js:

(WebInspector.Panel): Don't create the sidebar with an argument.
(WebInspector.Panel.prototype.show): Call updateSidebarWidth.
(WebInspector.Panel.prototype.handleKeyEvent): Call handleSidebarKeyEvent.
(WebInspector.Panel.prototype.handleSidebarKeyEvent): Added.
(WebInspector.Panel.prototype.createSidebar): Renamed from _createSidebar.
(WebInspector.Panel.prototype._sidebarDragging): Call updateSidebarWidth.
(WebInspector.Panel.prototype.updateSidebarWidth): Renamed from _updateSidebarWidth.
(WebInspector.Panel.prototype.setSidebarWidth): Added. Called by updateSidebarWidth.
(WebInspector.Panel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel): Call createSidebar.
(WebInspector.ProfilesPanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.show): Remove call to _updateSidebarWidth.
(WebInspector.ResourcesPanel.prototype.showResource): Call updateSidebarWidth
(WebInspector.ResourcesPanel.prototype.closeVisibleResource): Ditto.
(WebInspector.ResourcesPanel.prototype.setSidebarWidth): Added.
(WebInspector.ResourcesPanel.prototype.updateMainViewWidth): Added.

  • inspector/front-end/StoragePanel.js:

(WebInspector.StoragePanel): Call createSidebar.
(WebInspector.StoragePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel): Call createSidebar.
(WebInspector.TimelinePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

4:08 PM Changeset in webkit [50032] by timothy@apple.com
  • 3 edits in trunk/WebCore

Call updateSelection() in a few places so hovering in the Web Inspector's
Elements panel always has the correct row selection height.

​https://bugs.webkit.org/show_bug.cgi?id=30735

Reviewed by Pavel Feldman.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
(WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.

  • inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.
4:02 PM Changeset in webkit [50031] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-24 Timothy Hatcher <​timothy@apple.com>

Remove the re-root tree feature from the Web Inspector's
Elements panel. This feature wasn't super useful and gets
in the way of double-click to edit.

​https://bugs.webkit.org/show_bug.cgi?id=30736

Reviewed by Pavel Feldman.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.ondblclick):
3:40 PM Changeset in webkit [50030] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-24 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

Implements ReturnsNew hint for V8 bindings generation code.
​https://bugs.webkit.org/show_bug.cgi?id=30745

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
3:16 PM Changeset in webkit [50029] by mitz@apple.com
  • 3 edits
    1 copy
    4 adds in trunk

Missing images at 350.org due to wrong URLs
​https://bugs.webkit.org/show_bug.cgi?id=30748

Reviewed by Sam Weinig.

WebCore:

Test: fast/dom/HTMLImageElement/parse-src.html

  • dom/Element.cpp:

(WebCore::Element::getURLAttribute): Pass the attribute value through deprecateParseURL().
This matches what the Objective-C bindings do, as well as what HTMLImageLoader::sourceURI()
and SVGImageLoader::sourceURI() do.

LayoutTests:

  • fast/dom/HTMLImageElement/parse-src-expected.txt: Added.
  • fast/dom/HTMLImageElement/parse-src.html: Added.
  • fast/dom/HTMLImageElement/script-tests: Added.
  • fast/dom/HTMLImageElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Document/script-tests/TEMPLATE.html.
  • fast/dom/HTMLImageElement/script-tests/parse-src.js: Added.
1:55 PM Changeset in webkit [50028] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2009-10-24 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix for QtWebKit after r50013.

  • WebCore.pro:
9:12 AM Changeset in webkit [50027] by Dimitri Glazkov
  • 5 edits
    1 add in trunk/WebCore

2009-10-24 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[V8] Fix up to accommodate for HTMLAllCollection changes in
​http://trac.webkit.org/changeset/49998.

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
8:28 AM Changeset in webkit [50026] by eric@webkit.org
  • 17 edits in trunk

2009-10-24 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=30476

Set the stack size to 80 Kb and heap size to the 128kB - 32MB range
to all executables linking against WebKit library.

  • WebKit.pri:

2009-10-24 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=30476

Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
to jsc.exe.

  • jsc.pro:

2009-10-24 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=30476

Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
to all QtWebkit executables.

  • QGVLauncher/QGVLauncher.pro:
  • QtLauncher/QtLauncher.pro:
  • tests/benchmarks/loading/tst_loading.pro:
  • tests/benchmarks/painting/tst_painting.pro:
  • tests/qgraphicswebview/qgraphicswebview.pro:
  • tests/qwebelement/qwebelement.pro:
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebhistory/qwebhistory.pro:
  • tests/qwebhistoryinterface/qwebhistoryinterface.pro:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebplugindatabase/qwebplugindatabase.pro:
  • tests/qwebview/qwebview.pro:
5:56 AM QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
5:48 AM QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
5:23 AM QtBackLog edited by zecke@selfish.org
(diff)
5:21 AM QtBackLog edited by zecke@selfish.org
(diff)

Oct 23, 2009:

11:55 PM QtBackLog edited by zecke@selfish.org
(diff)
11:55 PM QtBackLog edited by zecke@selfish.org
(diff)
11:41 PM QtBackLog edited by zecke@selfish.org
(diff)
9:42 PM QtWebKitPerformanceUtilities edited by zecke@selfish.org
(diff)
9:12 PM Changeset in webkit [50025] by mitz@apple.com
  • 4 edits in trunk/WebCore

<rdar://problem/7294131> Assertion failure in AuthenticationMac at
mac(const Credential&) after authenticating to MobileMe Gallery movie

Reviewed by Alexey Proskuryakov.

  • platform/network/Credential.cpp:

(WebCore::Credential::Credential): Initialize m_persistence.
(WebCore::Credential::isEmpty): Made this method const.

  • platform/network/Credential.h:
  • platform/network/mac/AuthenticationMac.mm:

(WebCore::mac): Return nil if the Credential is empty.

8:16 PM Changeset in webkit [50024] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix engineering builds in the mysterious future.

  • Configurations/DebugRelease.xcconfig:
8:06 PM Changeset in webkit [50023] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

8:05 PM Changeset in webkit [50022] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.21.5

New tag.

8:05 PM Changeset in webkit [50021] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Fixes <​https://bugs.webkit.org/show_bug.cgi?id=30617>.
Web Inspector: Resources Scope Bar Should Allow Combinations.

Reviewed by Timothy Hatcher.

Refactor the filtering in ResourcePanel to make it match ConsoleView,
and add a divider between All, and the other choices of Resource types.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):

  • inspector/front-end/inspector.css:
8:03 PM Changeset in webkit [50020] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebKit/win

Merge r50019.

8:01 PM Changeset in webkit [50019] by mrowe@apple.com
  • 2 edits in trunk/WebKit/win

Build fix. Include config.h before including other files.

  • AccessibleImage.cpp:
7:06 PM Changeset in webkit [50018] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-10-23 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Added test for bug 27239 (ignore Refresh for view source mode).
​https://bugs.webkit.org/show_bug.cgi?id=27239

  • http/tests/security/view-source-no-refresh.html: Added
  • http/tests/security/view-source-no-refresh-expected.txt: Added
  • http/tests/security/resources/view-source-no-refresh.php: Added

2009-10-23 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Ignore the Refresh header if we're in view source mode.

​https://bugs.webkit.org/show_bug.cgi?id=27239

Test: http/tests/security/view-source-no-refresh.html

  • loader/FrameLoader.cpp: ignore Refresh in view-source mode.
6:10 PM Changeset in webkit [50017] by ap@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=30734
Remove XMLTokenizer::m_currentNodeIsReferenced

No change in behavior, no tests.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::setCurrentNode):
  • dom/XMLTokenizer.h: Don't store a boolean for the current node being the document - we can always check for that.
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::XMLTokenizer):
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::XMLTokenizer): A fragment passed to XMLTokenizer is never null - in fact, the first thing we do is dereference it unconditionally, and then begin checking it for null, as if it could help.
6:09 PM Changeset in webkit [50016] by Beth Dakin
  • 3 edits in trunk/WebCore

No review since this is a build fix.

Build fix for the Mac. (Build is only broken when SVG filters are
enabled.)

Labelled these function static.

  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::identity):
(WebCore::table):
(WebCore::discrete):
(WebCore::linear):
(WebCore::gamma):

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::boxBlur):

5:40 PM Changeset in webkit [50015] by pfeldman@chromium.org
  • 9 edits
    2 adds in trunk/WebCore

2009-10-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement a Timeline panel.

​https://bugs.webkit.org/show_bug.cgi?id=30725

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Images/timelineIcon.png: Added.
  • inspector/front-end/TimelineAgent.js: (WebInspector.addItemToTimeline): (WebInspector.timelineProfilerWasStarted): (WebInspector.timelineProfilerWasStopped):
  • inspector/front-end/TimelinePanel.js: Added. (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype.handleKeyEvent): (WebInspector.TimelinePanel.prototype.timelineWasStarted): (WebInspector.TimelinePanel.prototype.timelineWasStopped): (WebInspector.TimelinePanel.prototype.addItemToTimeline): (WebInspector.TimelinePanel.prototype._innerAddItemToTimeline): (WebInspector.TimelinePanel.prototype._toggleTimelineButton): (WebInspector.TimelinePanel.prototype.setMainViewWidth): (WebInspector.TimelinePanel.prototype.getItemTypeName): (WebInspector.TimelineRecordTreeElement): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
5:26 PM Changeset in webkit [50014] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2009-10-23 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Clash Between Search's onkeyup and incremental search events
​https://bugs.webkit.org/show_bug.cgi?id=30731

  • inspector/front-end/inspector.js: (WebInspector.performSearch): prevent incremental search event from clobbering a forced search
5:24 PM Changeset in webkit [50013] by pfeldman@chromium.org
  • 11 edits
    2 adds in trunk/WebCore

2009-10-23 Kelly Norton <​knorton@google.com>

Reviewed by Pavel Feldman.

Removes the need for C++ Timeline types in InspectorTimelineAgent in favor
of ScriptObjects.
​https://bugs.webkit.org/show_bug.cgi?id=30707

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/DOMDispatchTimelineItem.cpp: Removed.
  • inspector/DOMDispatchTimelineItem.h: Removed.
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentTimelineItem):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::TimelineItemEntry::TimelineItemEntry):
  • inspector/TimelineItem.cpp: Removed.
  • inspector/TimelineItem.h: Removed.
  • inspector/TimelineItemFactory.cpp: Added. (WebCore::TimelineItemFactory::createGenericTimelineItem): (WebCore::TimelineItemFactory::createDOMDispatchTimelineItem):
  • inspector/TimelineItemFactory.h: Added. (WebCore::): (WebCore::TimelineItemFactory::TimelineItemFactory):
5:13 PM Changeset in webkit [50012] by barraclough@apple.com
  • 10 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=30729
Provide private API to request the global context for a specific world.
Used to initialize parameters on the global object.

Patch by Gavin Barraclough <​barraclough@apple.com> on 2009-10-23
Reviewed by Geoff Garen.

WebCore:

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::globalObject):

  • bindings/js/ScriptController.h:

WebKit/mac:

  • WebView/WebFramePrivate.h:
  • WebView/WebFrame.mm:

(-[WebFrame contextForWorldID:]):

WebKit/win:

  • WebFrame.cpp:

(WebFrame::contextForWorldID):

  • WebFrame.h:
4:44 PM Changeset in webkit [50011] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

4:44 PM Changeset in webkit [50010] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.21.4

New tag.

4:40 PM Changeset in webkit [50009] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-4-branch

Merge r50004.

4:40 PM Changeset in webkit [50008] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r47534.

4:35 PM Changeset in webkit [50007] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it.
<​http://webkit.org/b/30732> and <rdar://7332018>.

Reviewed by John Sullivan.

Turns off pan-scrolling on a WebView when it is about to lose focus.

  • WebView.cpp:

(WebViewWndProc):

3:40 PM Changeset in webkit [50006] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-10-23 Steve Block <​steveblock@google.com>

Reviewed by Eric Seidel.

Fixes style problems in Android-specific files.
​https://bugs.webkit.org/show_bug.cgi?id=30717

Style changes only, no new tests possible.

  • page/android/EventHandlerAndroid.cpp: Modified. (WebCore::EventHandler::passMouseDownEventToWidget): Fixes whitespace in method signature. (WebCore::EventHandler::passSubframeEventToSubframe): Fixes whitespace in method signature. (WebCore::EventHandler::passWheelEventToWidget): Fixes whitespace in method signature. (WebCore::EventHandler::passMouseMoveEventToSubframe): Fixes whitespace in method signature.
  • platform/android/ClipboardAndroid.h: Modified. Fixes header include order and indenting.
  • platform/android/CursorAndroid.cpp: Modified. (WebCore::grabCursor): Fixes function braces. (WebCore::grabbingCursor): Fixes function braces.
  • platform/android/FileChooserAndroid.cpp: Modified. (WebCore::FileChooser::basenameForWidth): Fixes braces on while statement, and updates String::copy to String::threadsafeCopy.
  • platform/android/FileSystemAndroid.cpp: Modified. Fixes header include order. (WebCore::unloadModule): Fixes zero test. (WebCore::writeToFile): Fixes if statement structure.
  • platform/android/KeyEventAndroid.cpp: Modified. (WebCore::windowsKeyCodeForKeyEvent): Fixes switch statement indenting. (WebCore::keyIdentifierForAndroidKeyCode): Fixes switch statement indenting.
  • platform/android/ScreenAndroid.cpp: Modified. Fixes header include order and switch statement indenting.
  • platform/android/TemporaryLinkStubs.cpp: Modified. Fixes header include order.
3:25 PM Changeset in webkit [50005] by eric@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2009-10-23 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Modified the tests results according to the last changes due
to the fixes of the bug (r49985):
​https://bugs.webkit.org/show_bug.cgi?id=29697.

  • platform/gtk/editing/execCommand/4916541-expected.txt:
  • platform/gtk/editing/execCommand/5138441-expected.txt:
  • platform/gtk/editing/execCommand/5481523-expected.txt:
  • platform/gtk/editing/execCommand/indent-paragraphs-expected.txt: Added.
3:16 PM Changeset in webkit [50004] by jhoneycutt@apple.com
  • 4 edits
    4 adds in trunk

MSAA: Name for image elements should use alt attribute text

​https://bugs.webkit.org/show_bug.cgi?id=30727
<rdar://problem/7328291>

Reviewed by Alice Liu.

WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::createInstance):
If the AccessibilityObject is an image, return an AccessibleImage.

  • AccessibleImage.cpp: Added.

(AccessibleImage::AccessibleImage):
Call the base constructor.
(AccessibleImage::name):
If the object is not an AccessibilityRenderObject, return the base's
name(). Look first for an ARIA "labeled-by" attribute, then look for an
alternate text attribute. Fall back to the base's name().

  • AccessibleImage.h: Added.

(AccessibleImage::~AccessibleImage):

  • WebKit.vcproj/WebKit.vcproj:

Add AccessibleImage to the project.

LayoutTests:

  • platform/win/accessibility/img-alt-attribute-expected.txt: Added.
  • platform/win/accessibility/img-alt-attribute.html: Added.
2:49 PM Changeset in webkit [50003] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-23 Eric Seidel <​eric@webkit.org>

No review, only adding Alice to the list of reviewers.

  • Scripts/modules/committers.py:
2:45 PM Changeset in webkit [50002] by weinig@apple.com
  • 2 edits in trunk/WebCore

Another shot at a fixed build.

  • DerivedSources.cpp:
2:33 PM Changeset in webkit [50001] by weinig@apple.com
  • 2 edits in trunk/WebCore

Another shot at a fixed build.

  • html/HTMLOptionsCollection.idl:
2:25 PM Changeset in webkit [50000] by beidson@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

50,000!

  • ChangeLog: Point out revision 50,000.
2:25 PM Changeset in webkit [49999] by weinig@apple.com
  • 2 edits in trunk/WebKit/win

Try and fix the windows build.

  • Interfaces/WebKit.idl:
2:12 PM Changeset in webkit [49998] by weinig@apple.com
  • 26 edits
    8 adds
    3 deletes in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=30695
Drop .tags() support from HTMLCollection

Reviewed by Anders Carlsson.

  • Make .tags() only work for HTMLAllCollections in JS. .tags() is still available for all HTMLCollection like objects in Objective-C since that is API.
  • Auto-generate HTMLAllCollection.

Test: fast/dom/HTMLDocument/document-all.html

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAllCollection.cpp: Removed.
  • bindings/js/JSHTMLAllCollection.h: Removed.
  • bindings/js/JSHTMLAllCollectionCustom.cpp: Added.

(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::getCallData):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.cpp:

(WebCore::Document::all):

  • dom/Document.h:
  • dom/HTMLAllCollection.idl: Removed.
  • html/HTMLAllCollection.cpp: Added.

(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::~HTMLAllCollection):

  • html/HTMLAllCollection.h: Added.
  • html/HTMLAllCollection.idl: Added.
  • html/HTMLCollection.h:
  • html/HTMLCollection.idl:
  • html/HTMLDocument.idl:
  • page/DOMWindow.idl:

LayoutTests: Update and add test for ​https://bugs.webkit.org/show_bug.cgi?id=30695
Drop .tags() support from HTMLCollection

Reviewed by Anders Carlsson.

  • fast/dom/HTMLDocument/document-all-expected.txt: Added.
  • fast/dom/HTMLDocument/document-all.html: Added.
  • fast/dom/HTMLDocument/script-tests: Added.
  • fast/dom/HTMLDocument/script-tests/document-all.js: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/script-tests/domListEnumeration.js:
  • fast/dom/undetectable-document-all-expected.txt:
  • fast/js/global-constructors-expected.txt:
1:47 PM Changeset in webkit [49997] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-10-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: pull basic sidebar implementation into the Panel.

​https://bugs.webkit.org/show_bug.cgi?id=30720

1:43 PM Changeset in webkit [49996] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-23 Jens Alfke <​snej@chromium.org>

Reviewed by Dimitri Glazkov.

Slight optimizations to object returning and exception handling in generated V8 bindings.
​https://bugs.webkit.org/show_bug.cgi?id=30599

  • bindings/scripts/CodeGeneratorV8.pm: Generate better code
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertToV8Object): Added overload that takes a Ref<>
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Remove unnecessary template param to prevent compile error
1:35 PM Changeset in webkit [49995] by eric@webkit.org
  • 8 edits
    1 add in trunk

2009-10-23 Alpha Lam <​hclam@chromium.org>

Reviewed by Eric Carlson.

Volume slider always starts at half volume
​https://bugs.webkit.org/show_bug.cgi?id=28322

  • media/video-volume-slider.html: Added. Pixel test for the volume slider of the media control. This test assumes volume slider is implemented and usable. It moves the mouse over the right bottom corner of a video element to trigger the volume slider. If volume slider is not implemented at all, you'll only see a video element with the first frame.
  • platform/gtk/Skipped: The above test requires a volume slider so it's skipped.
  • platform/mac/Skipped: ditto.
  • platform/win/Skipped: ditto.

2009-10-23 Alpha Lam <​hclam@chromium.org>

Reviewed by Eric Carlson.

Volume slider always starts at half volume
​https://bugs.webkit.org/show_bug.cgi?id=28322

Sets the value attribute of volume slider to the volume attribute
of the media element. Also update the value attribute of the
input element for the volume slider when the volume attribute
of the media element is updated.

Test: media/video-volume-slider.html

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::update): Set the value attribute of the input element for the volume slider using the current volume of the media element.
  • rendering/MediaControlElements.h: Add method definition of update().
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider): Creates a volume slider with value attribute equals to the current volume attribute of the media element.
1:26 PM Changeset in webkit [49994] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-23 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

Chrome Linux: fix caret positioning in LTR complex languages
The caret is positioned off by one in languages like Thai.

​https://bugs.webkit.org/show_bug.cgi?id=28284

A group of us spent a while trying various approaches to write a test
for this; however, since it is only that the blinking cursor is
displayed incorrectly, we concluded it can not be tested.

(Patch by Hironori Bono.)

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::selectionRectForComplexText):
1:13 PM Changeset in webkit [49993] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-10-23 Andrew Scherkus <​scherkus@chromium.org>

Reviewed by Eric Carlson.

Add a layout test to assert that media element implementors do not
advance currentTime after being paused.

​https://bugs.webkit.org/show_bug.cgi?id=30699

  • media/video-pause-immediately-expected.txt: Added.
  • media/video-pause-immediately.html: Added.
1:09 PM Changeset in webkit [49992] by tony@chromium.org
  • 10 edits in trunk/WebCore

2009-10-23 Tony Chang <​tony@chromium.org>

Reviewed by David Levin.

Fix Chromium build after IsoldatedWorld change (r49963).
​https://bugs.webkit.org/show_bug.cgi?id=30719

  • bindings/ScriptControllerBase.cpp:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInIsolatedWorld):
  • bindings/v8/ScriptController.cpp: (WebCore::mainThreadNormalWorld):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell):
  • dom/Document.cpp: (WebCore::Document::createWrapperCache):
  • dom/ScriptExecutionContext.cpp:
  • dom/ScriptExecutionContext.h:
  • xml/XMLHttpRequest.cpp:
  • xml/XMLHttpRequest.h:
1:05 PM Changeset in webkit [49991] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-10-23 Victor Wang <​victorw@chromium.org>

Reviewed by Eric Seidel.

Update the expected pixel result for test svg-as-background-6.html

The old result is incorrect because of the wrong SVG masking offset calculation.
Patch ​http://trac.webkit.org/changeset/49598 fixed the issue.
The pixel result of this layout test needs to be updated.

​https://bugs.webkit.org/show_bug.cgi?id=30692

  • platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
12:48 PM Changeset in webkit [49990] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2009-10-23 Xiaomei Ji <​xji@chromium.org>

Reviewed by Sam Weinig.

Fix caretRangeFromPoint()/elementFromPoint() returns wrong result
for a zoomed and scrolled page.
​https://bugs.webkit.org/show_bug.cgi?id=30689.

The real cause is the wrong calculation of event.clientX/Y when
page is zoomed and scolled.
After Sam fixed the event.clientX/Y in r49551, the hit test point
should be recalculated (revert r49490).

  • fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll-expected.txt: Added.
  • fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html: Added.
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
  • fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
  • fast/dom/elementFromPoint-relative-to-viewport.html:

2009-10-23 Xiaomei Ji <​xji@chromium.org>

Reviewed by Sam Weinig.

Fix caretRangeFromPoint()/elementFromPoint() returns wrong result
for a zoomed and scrolled page.
​https://bugs.webkit.org/show_bug.cgi?id=30689.

The real cause is the wrong calculation of event.clientX/Y when
page is zoomed and scolled.
After Sam fixed the event.clientX/Y in r49551, the hit test point
should be recalculated (revert r49490).

Test: fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html

  • dom/Document.cpp: (WebCore::Document::elementFromPoint): calculate the correct point relative to document when page is zoomed and scrolled. (WebCore::Document::caretRangeFromPoint): calculate the correct point relative to document when page is zoomed and scrolled.
12:38 PM Changeset in webkit [49989] by dumi@chromium.org
  • 5 edits
    2 adds in trunk/WebCore

Adding a class that allows us to enable/disable features at
runtime. Adding a flag to enable database support.

Patch by Dumitru Daniliuc <​dumi@chromium.org> on 2009-10-22
Reviewed by Dmitry Titov.

​https://bugs.webkit.org/show_bug.cgi?id=30653

  • WebCore.gypi:
  • bindings/v8/RuntimeEnabledFeatures.cpp: Added.
  • bindings/v8/RuntimeEnabledFeatures.h: Added.

(WebCore::RuntimeEnabledFeatures::setDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::databaseEnabled):
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::ACCESSOR_RUNTIME_ENABLER):

  • page/DOMWindow.idl:
12:30 PM Changeset in webkit [49988] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-23 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Inspector injects _inspectorCommandLineAPI into global object when opened
​https://bugs.webkit.org/show_bug.cgi?id=30675

  • inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions): (InjectedScript._evaluateOn): (InjectedScript.addInspectedNode): (InjectedScript._ensureCommandLineAPIInstalled): Moved _inspectorCommandLineAPI from window to console.
12:23 PM Changeset in webkit [49987] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-23 Janne Koskinen <​janne.p.koskinen@digia.com>

Reviewed by Tor Arne Vestbø.

[Qt] don't undef NULL in Symbian emulator

npapi.h way of defining mwerks compiler,intel
and win32 are all true for Symbian emulator.
Changed the definions so that NULL won't be undefined
when compiling for Symbian emulator nor target HW.

  • bridge/npapi.h:
12:14 PM Changeset in webkit [49986] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-23 Janne Koskinen <​janne.p.koskinen@digia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Correct linking of sqlite3 for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=30569

".lib" will try to include library as static library
causing the library to be searched from wrong directory and if found
will be statically linked instead of the inteded dynamic linking.

  • WebCore.pro:
12:00 PM Changeset in webkit [49985] by adele@apple.com
  • 21 edits
    2 adds in trunk

REGRESSION: Copy is copying incorrect background-color
<rdar://problem/7248529>
​https://bugs.webkit.org/show_bug.cgi?id=29697

Patch by Enrica Casucci <​enrica@apple.com> on 2009-10-23
Reviewed by Adele Peterson.

WebCore:

Test: editing/execCommand/indent-paragraphs.html

This change removes the BackgroundColor from the list
of inheritable CSS properties and changes significantly
the way we perform indentation.
The new implementation of IndentOutdentCommand uses a new method
defined in CompositeEditCommand called moveParagraphWithClones.
This is an improved version of the original moveParagraph that
is aimed at preserving the original markup of the paragraph being
moved.

  • editing/ApplyStyleCommand.cpp:

(WebCore::): removed CSSPropertyBackgroundColor from editingStyleProperties.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::CompositeEditCommand): Removed trailing blanks.
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Removed trailing blanks.
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added.
(WebCore::CompositeEditCommand::cleanupAfterDeletion): Added.
(WebCore::CompositeEditCommand::moveParagraphWithClones): Added.
(WebCore::CompositeEditCommand::moveParagraphs): Modified to use cleanupAfterDeletion.
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Removed trailing blanks.
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Removed trailing blanks.
(WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Removed trailing blanks.

  • editing/CompositeEditCommand.h: Added three new methods.
  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::tryIndentingAsListItem): Changed to use moveParagraphWithClones.
(WebCore::IndentOutdentCommand::indentIntoBlockquote): Changed to use moveParagraphWithClones.
(WebCore::IndentOutdentCommand::indentRegion): Removed comment.

  • editing/IndentOutdentCommand.h: Removed prepareBlockquoteLevelForInsertion method.

LayoutTests:

All the following tests have been re-baselined because
the indent command now preserves the original markup.
A new test (indent-paragraph.html) has been added to test
several indent combinations not covered by the existing tests.

  • editing/execCommand/19087-expected.txt:
  • editing/execCommand/19653-1-expected.txt:
  • editing/execCommand/indent-div-inside-list-expected.txt:
  • editing/execCommand/indent-nested-blockquotes-expected.txt:
  • editing/execCommand/indent-nested-div-expected.txt:
  • editing/execCommand/indent-paragraphs.html: Added.
  • editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt:
  • editing/execCommand/indent-with-style-expected.txt:
  • editing/inserting/5994480-2-expected.txt:
  • platform/mac/editing/execCommand/4641880-2-expected.txt:
  • platform/mac/editing/execCommand/4916541-expected.txt:
  • platform/mac/editing/execCommand/5138441-expected.txt:
  • platform/mac/editing/execCommand/5481523-expected.txt:
  • platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Added.
  • platform/mac/editing/execCommand/indent-selection-expected.txt:
  • platform/mac/editing/pasteboard/select-element-1-expected.txt:
11:57 AM Changeset in webkit [49984] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-23 Eric Seidel <​eric@webkit.org>

Reviewed by Eric Carlson.

fast/media/mq-transform-02.html failed on Leopard Commit Bot
​https://bugs.webkit.org/show_bug.cgi?id=30700

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Update QuickTime version check.
10:34 AM Changeset in webkit [49983] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

Isolated worlds tests now pass, removing then from the Skipped
list.

  • platform/win/Skipped:
9:45 AM Changeset in webkit [49982] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
character measurement APIs that are private on Tiger.

9:42 AM Changeset in webkit [49981] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

wx build fix. Update the globalObject calls after changes.

9:34 AM Changeset in webkit [49980] by cmarrin@apple.com
  • 1 edit in trunk/WebKitSite/blog-files/webgl/resources/blogpost.css

Changed anchor style to take a class name

8:53 AM Changeset in webkit [49979] by eric.carlson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-10-22 Eric Carlson <​eric.carlson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/7322847>
Pressing space bar key in full screen mode should pause movie but doesn't

  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController keyDown:]): New, toggle playback on space key. (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Play button action is now called togglePlaying. (-[WebVideoFullscreenHUDWindowController togglePlaying:]): Rename from playingChanged.
7:30 AM Changeset in webkit [49978] by vestbo@webkit.org
  • 1 edit in trunk/WebKit/qt/Api/qwebframe.cpp

Qt build fix

7:07 AM Changeset in webkit [49977] by benm@google.com
  • 2 edits in trunk/JavaScriptCore

Fixes a leak in createThreadInternal on Android.
​https://bugs.webkit.org/show_bug.cgi?id=30698

Patch by Steve Block <​steveblock@google.com> on 2009-10-23
Reviewed by Dmitry Titov.

  • wtf/ThreadingPthreads.cpp: Modified.

(WTF::createThreadInternal): Avoid leaking a ThreadData object on failure.

5:45 AM Changeset in webkit [49976] by benm@google.com
  • 3 edits in trunk/WebCore

Adds missing UnusedParam.h includes, required when INSPECTOR is not enabled.
​https://bugs.webkit.org/show_bug.cgi?id=30677

Patch by Steve Block <​steveblock@google.com> on 2009-10-23
Reviewed by Eric Seidel.

Build fix, no new tests required.

  • page/Console.cpp: Modified. Added UnusedParam.h include.
  • workers/WorkerContext.cpp: Modified. Added UnusedParam.h include.
5:02 AM Changeset in webkit [49975] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Plugins : Use window's winId() instead of the widget's.

2009-10-23 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Holger Freyther.

[Qt] Plugins : Use window's winId() instead of the widget's.

As per, ​https://developer.mozilla.org/en/NPN_GetValue
NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the
plug-in is displayed; returns Window".

The issue was found because NPNVNetscapeWindow winId() ends up creating
a native window resulting in flicker.

​https://bugs.webkit.org/show_bug.cgi?id=30706

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::getValue):
5:02 AM Changeset in webkit [49974] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Windowless Plugins : Don't use m_clipRect when painting.

2009-10-23 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Holger Freyther.

[Qt] Windowless Plugins : Don't use m_clipRect when painting.

Though it works, it is not correct to use m_clipRect for painting
in Windowless mode. Instead, the rect paramater that is passed
as a part of PluginView::paint() must be used. This change will
also result in some speedup since previously we used to paint all
the visible parts of a windowless plugin (even if those parts were
not dirty).

Also, fix invalidateRect() to compute the correct width and height.

​https://bugs.webkit.org/show_bug.cgi?id=30711

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint): (WebCore::PluginView::invalidateRect):
5:02 AM Changeset in webkit [49973] by zecke@webkit.org
  • 4 edits
    1 add in trunk/WebCore

Plugins : Use test.swf in the plugins manual tests.

They previously referenced youtube videos which among other things are
cumbersome to use without internet connection. The old youtube link is
just commented out so that testing with youtube can be done with
little effort.

4:47 AM Changeset in webkit [49972] by xan@webkit.org
  • 3 edits in trunk/LayoutTests

2009-10-23 Xan Lopez <​xlopez@igalia.com>

Use the correct Skipped file ...

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
4:43 AM Changeset in webkit [49971] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-23 Xan Lopez <​xlopez@igalia.com>

Skip new tests missing expected results.

  • platform/mac/Skipped:
1:14 AM Changeset in webkit [49970] by bweinstein@apple.com
  • 2 edits
    1 add in trunk/WebCore

Fix the Windows Release build by moving Accessibility files
into all-in-one file and excluding them from the build.

Reviewed by Jon Honeycutt.

  • WebCore.vcproj/WebCore.vcproj:
  • accessibility/AccessibilityAllInOne.cpp: Added.
Note: See TracTimeline for information about the timeline view.