⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 25, 2009:

9:33 PM Changeset in webkit [50049] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-25 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

Reuse already fetched proxy.
​https://bugs.webkit.org/show_bug.cgi?id=30747

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
9:14 PM QtBackLog edited by zecke@selfish.org
(diff)
9:07 PM QtBackLog edited by zecke@selfish.org
(diff)
9:03 PM QtBackLog edited by zecke@selfish.org
Mention the bug report and commits of this work (diff)
5:45 PM Changeset in webkit [50048] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-25 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Rebaseline test after 49998.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
3:39 PM Changeset in webkit [50047] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2009-10-25 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix.

Build fix for WIN_OS if Netscape plugin support is turned off
​https://bugs.webkit.org/show_bug.cgi?id=30753

  • plugins/PluginDatabase.cpp:
1:15 PM Changeset in webkit [50046] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2009-10-25 Hironori Bono <​hbono@chromium.org>

Reviewed by Darin Adler.

A quick fix for Bug 29103.
Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
and the option string before calling String::startsWith().
​https://bugs.webkit.org/show_bug.cgi?id=29103

  • fast/forms/listbox-typeahead-cyrillic-expected.txt: Added.
  • fast/forms/listbox-typeahead-cyrillic.html: Added.
  • fast/forms/listbox-typeahead-greek-expected.txt: Added.
  • fast/forms/listbox-typeahead-greek.html: Added.

2009-10-25 Hironori Bono <​hbono@chromium.org>

Reviewed by Darin Adler.

A quick fix for Bug 29103.
Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
and the option string before calling String::startsWith().
​https://bugs.webkit.org/show_bug.cgi?id=29103

Tests: fast/forms/listbox-typeahead-cyrillic.html

fast/forms/listbox-typeahead-greek.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::typeAheadFind):
10:28 AM Changeset in webkit [50045] by mitz@apple.com
  • 3 edits in trunk/WebKit/win

Add contextForWorldID to the IWebFramePrivate interface.

Reviewed by John Sullivan.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.h:
8:06 AM Web Inspector edited by casey.hattori@gmail.com
(diff)
6:56 AM Web Inspector edited by casey.hattori@gmail.com
(diff)
6:54 AM Web Inspector edited by casey.hattori@gmail.com
(diff)
1:54 AM Changeset in webkit [50044] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-25 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Expanding a node in the Console should not show the element in Elements panel
​https://bugs.webkit.org/show_bug.cgi?id=30749

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onmousedown): Check if inside disclosure triangle.
1:22 AM Changeset in webkit [50043] by weinig@apple.com
  • 2 edits in trunk/WebKit/win

Another try at fixing windows.

  • DOMCreateInstance.cpp:
12:52 AM Changeset in webkit [50042] by weinig@apple.com
  • 2 edits in trunk/WebKit/win

Touch WebKit.idl in an effort to try and regenerate the COM bindings.

  • Interfaces/WebKit.idl:
12:52 AM Changeset in webkit [50041] by weinig@apple.com
  • 18 edits
    1 add in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLCollectionFunctions.h: Added.

(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.

  • bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h

for toJS on document.all.

  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:

LayoutTests: Update tests for ​https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • fast/dom/wrapper-classes-expected.txt:
12:08 AM Changeset in webkit [50040] by bweinstein@apple.com
  • 18 edits
    1 delete in trunk

Roll out r50037 as it broke the Windows build.

Oct 24, 2009:

9:56 PM Changeset in webkit [50039] by timothy@apple.com
  • 5 edits in trunk/WebCore

WebInspector: Fixed issue with IME inside console
​https://bugs.webkit.org/show_bug.cgi?id=30660

Patch by Keishi Hattori <​casey.hattori@gmail.com> on 2009-10-24
Reviewed by Timothy Hatcher.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._promptKeyDown):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._promptKeyDown):

  • inspector/front-end/inspector.js:

(WebInspector.loaded):
(WebInspector.searchKeyDown): Moved performSearch here from WebInspector.searchKeyUp.
(WebInspector.startEditing.element.handleKeyEvent):
(WebInspector.startEditing):

  • inspector/front-end/utilities.js:

(isEnterKey): Added. Check if in IME.

9:13 PM Changeset in webkit [50038] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Fixes <​https://bugs.webkit.org/show_bug.cgi?id=30752>.
Web Inspector: Multiple Selection on Scope Bars by default Conflicts with other behavior on OSX.

Reviewed by Timothy Hatcher.

Have the scope bars select one scope by default, but if the multiple selection key
is pressed, allow for multiple selection.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype._updateFilter):
(WebInspector.ConsoleView.prototype.filter):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):

7:44 PM Changeset in webkit [50037] by weinig@apple.com
  • 18 edits
    1 add in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h

  • bindings/js/JSHTMLCollectionFunctions.h: Added.

(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.

  • bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h

for toJS on document.all.

  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:

LayoutTests: Update tests for ​https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

  • fast/dom/wrapper-classes-expected.txt:
4:08 PM Changeset in webkit [50036] by timothy@apple.com
  • 4 edits in trunk/WebCore

Make the scope bars in the Web Inspector match other scope bars in Mac OS X.
Also cleans up the CSS to use classes instead of ID selectors.

​https://bugs.webkit.org/show_bug.cgi?id=28186

Reviewed by Dan Bernstein.

  • inspector/front-end/ResourcesPanel.js: Add the scope-bar class.
  • inspector/front-end/inspector.css: Lots of changes to make it look right.
  • inspector/front-end/inspector.html: Add the scope-bar class.
4:08 PM Changeset in webkit [50035] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix selecting Resources in the Web Inspector's Resources panel.

​https://bugs.webkit.org/show_bug.cgi?id=30743

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.isCategoryVisible): Added.
(WebInspector.ResourceSidebarTreeElement.prototype.get selectable): Call
isCategoryVisible on the ResourcesPanel.

4:08 PM Changeset in webkit [50034] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix the Scope Bar in the Web Inspector's Resource panel, so that selecting
All will deselect the other filters.

​https://bugs.webkit.org/show_bug.cgi?id=30744

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.createFilterElement): Better syntax.
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter): Use a normal for loop,
and the child variable instead of target in the loop. Other clean up.

4:08 PM Changeset in webkit [50033] by timothy@apple.com
  • 6 edits in trunk/WebCore

Make resizing the Web Inspector's Elements panel sidebar work again.
Also makes Resources panel use the sidebar code in Panel.

​https://bugs.webkit.org/show_bug.cgi?id=30742

Reviewed by Pavel Feldman.

  • inspector/front-end/Panel.js:

(WebInspector.Panel): Don't create the sidebar with an argument.
(WebInspector.Panel.prototype.show): Call updateSidebarWidth.
(WebInspector.Panel.prototype.handleKeyEvent): Call handleSidebarKeyEvent.
(WebInspector.Panel.prototype.handleSidebarKeyEvent): Added.
(WebInspector.Panel.prototype.createSidebar): Renamed from _createSidebar.
(WebInspector.Panel.prototype._sidebarDragging): Call updateSidebarWidth.
(WebInspector.Panel.prototype.updateSidebarWidth): Renamed from _updateSidebarWidth.
(WebInspector.Panel.prototype.setSidebarWidth): Added. Called by updateSidebarWidth.
(WebInspector.Panel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel): Call createSidebar.
(WebInspector.ProfilesPanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.show): Remove call to _updateSidebarWidth.
(WebInspector.ResourcesPanel.prototype.showResource): Call updateSidebarWidth
(WebInspector.ResourcesPanel.prototype.closeVisibleResource): Ditto.
(WebInspector.ResourcesPanel.prototype.setSidebarWidth): Added.
(WebInspector.ResourcesPanel.prototype.updateMainViewWidth): Added.

  • inspector/front-end/StoragePanel.js:

(WebInspector.StoragePanel): Call createSidebar.
(WebInspector.StoragePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel): Call createSidebar.
(WebInspector.TimelinePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.

4:08 PM Changeset in webkit [50032] by timothy@apple.com
  • 3 edits in trunk/WebCore

Call updateSelection() in a few places so hovering in the Web Inspector's
Elements panel always has the correct row selection height.

​https://bugs.webkit.org/show_bug.cgi?id=30735

Reviewed by Pavel Feldman.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
(WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.

  • inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.
4:02 PM Changeset in webkit [50031] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-24 Timothy Hatcher <​timothy@apple.com>

Remove the re-root tree feature from the Web Inspector's
Elements panel. This feature wasn't super useful and gets
in the way of double-click to edit.

​https://bugs.webkit.org/show_bug.cgi?id=30736

Reviewed by Pavel Feldman.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.ondblclick):
3:40 PM Changeset in webkit [50030] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-24 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

Implements ReturnsNew hint for V8 bindings generation code.
​https://bugs.webkit.org/show_bug.cgi?id=30745

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
3:16 PM Changeset in webkit [50029] by mitz@apple.com
  • 3 edits
    1 copy
    4 adds in trunk

Missing images at 350.org due to wrong URLs
​https://bugs.webkit.org/show_bug.cgi?id=30748

Reviewed by Sam Weinig.

WebCore:

Test: fast/dom/HTMLImageElement/parse-src.html

  • dom/Element.cpp:

(WebCore::Element::getURLAttribute): Pass the attribute value through deprecateParseURL().
This matches what the Objective-C bindings do, as well as what HTMLImageLoader::sourceURI()
and SVGImageLoader::sourceURI() do.

LayoutTests:

  • fast/dom/HTMLImageElement/parse-src-expected.txt: Added.
  • fast/dom/HTMLImageElement/parse-src.html: Added.
  • fast/dom/HTMLImageElement/script-tests: Added.
  • fast/dom/HTMLImageElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Document/script-tests/TEMPLATE.html.
  • fast/dom/HTMLImageElement/script-tests/parse-src.js: Added.
1:55 PM Changeset in webkit [50028] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2009-10-24 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix for QtWebKit after r50013.

  • WebCore.pro:
9:12 AM Changeset in webkit [50027] by Dimitri Glazkov
  • 5 edits
    1 add in trunk/WebCore

2009-10-24 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[V8] Fix up to accommodate for HTMLAllCollection changes in
​http://trac.webkit.org/changeset/49998.

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
8:28 AM Changeset in webkit [50026] by eric@webkit.org
  • 17 edits in trunk

2009-10-24 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=30476

Set the stack size to 80 Kb and heap size to the 128kB - 32MB range
to all executables linking against WebKit library.

  • WebKit.pri:

2009-10-24 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=30476

Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
to jsc.exe.

  • jsc.pro:

2009-10-24 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=30476

Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
to all QtWebkit executables.

  • QGVLauncher/QGVLauncher.pro:
  • QtLauncher/QtLauncher.pro:
  • tests/benchmarks/loading/tst_loading.pro:
  • tests/benchmarks/painting/tst_painting.pro:
  • tests/qgraphicswebview/qgraphicswebview.pro:
  • tests/qwebelement/qwebelement.pro:
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebhistory/qwebhistory.pro:
  • tests/qwebhistoryinterface/qwebhistoryinterface.pro:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebplugindatabase/qwebplugindatabase.pro:
  • tests/qwebview/qwebview.pro:
5:56 AM QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
5:48 AM QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
(diff)
5:23 AM QtBackLog edited by zecke@selfish.org
(diff)
5:21 AM QtBackLog edited by zecke@selfish.org
(diff)
Note: See TracTimeline for information about the timeline view.