Context Navigation

svg/SynchronizablePropertyController.cpp: (WebCore::SynchronizableProperties::addProperty): (WebCore::SynchronizableProperties::synchronize): (WebCore::SynchronizableProperties::startAnimation): (WebCore::SynchronizableProperties::stopAnimation): (WebCore::SynchronizablePropertyController::registerProperty): (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization): (WebCore::SynchronizablePropertyController::synchronizeProperty): (WebCore::SynchronizablePropertyController::synchronizeAllProperties): (WebCore::SynchronizablePropertyController::startAnimation): (WebCore::SynchronizablePropertyController::stopAnimation):
svg/SynchronizablePropertyController.h: (WebCore::SynchronizableProperties::SynchronizableProperties): (WebCore::SynchronizableProperties::setNeedsSynchronization):

8:24 PM Changeset in webkit [50125] by eric@webkit.org

11 edits
2 moves in trunk/WebCore

2009-10-26 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Renames TimelineItem to TimelineRecord and updates all call sites.
https://bugs.webkit.org/show_bug.cgi?id=30785

GNUmakefile.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addRecordToTimeline):
inspector/InspectorFrontend.h:
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willFireTimer): (WebCore::InspectorTimelineAgent::didFireTimer): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::RecordEntry::RecordEntry):
inspector/TimelineItemFactory.cpp: Removed.
inspector/TimelineItemFactory.h: Removed.
inspector/TimelineRecordFactory.cpp: Added. (WebCore::TimelineRecordFactory::createGenericRecord): (WebCore::TimelineRecordFactory::createDOMDispatchRecord): (WebCore::TimelineRecordFactory::createGenericTimerRecord): (WebCore::TimelineRecordFactory::createTimerInstallRecord):
inspector/TimelineRecordFactory.h: Added. (WebCore::TimelineRecordFactory::TimelineRecordFactory):
inspector/front-end/TimelineAgent.js: (WebInspector.addRecordToTimeline):
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype.getRecordTypeName): (WebInspector.TimelineRecordTreeElement.prototype.onattach):

7:56 PM Changeset in webkit [50124] by zecke@webkit.org

1 edit in trunk/WebCore/plugins/qt/PluginViewQt.cpp

Unreviewed spelling fix in the PluginViewQt.cpp

This error was pointed out in the bug report and it was agreed to
do the spelling fix when landing the patch. Fix it now.

7:50 PM Changeset in webkit [50123] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-26 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Antti Koivisto.

[Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled

When printing, QPrinter's preview mode uses a QPicture to capture the output. The
QPicture holds a reference to the X Pixmap. As a result, the print preview would
update itself when the X Pixmap changes. To prevent the print preview from updating
whenever m_drawable is updated (i.e when the view updates), we create a copy.

We require that a QPixmap::copy() result in a QPixmap backed by a XPixmap
regardless of the graphicssystem. This is taken care of by
commit d310f7c710ecb331a9689861f0551eabd38e946e in Qt (4.6)

The beauty of this patch is that the newly created X Pixmap is managed by Qt and
it will free the Pixmap whenever the user closes the print preview dialog and
handles the case of displaying multiple preview dialogs nicely.

All credit to Samuel Rødal for suggesting usage of QPixmap::copy().

https://bugs.webkit.org/show_bug.cgi?id=30714

plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):

7:42 PM Changeset in webkit [50122] by eric@webkit.org

3 edits in trunk/WebCore

2009-10-26 Benjamin Otte <otte@gnome.org>

Reviewed by Gustavo Noronha.

Don't store properties in the MediaPlayerPrivate class

Access them via the MediaPlayer class instead.
https://bugs.webkit.org/show_bug.cgi?id=30462

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

7:27 PM Changeset in webkit [50121] by bweinstein@apple.com

2 edits in trunk/WebCore

Fixes <http://webkit.org/b/30801>.
Web Inspector: Control + ]/[ on Windows doesn't change Panels.

Reviewed by Timothy Hatcher.

In my testing, Windows uses "U+00DB" and "U+00DD" to represent
[ and ], so we should honor those as well.

inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

7:10 PM Changeset in webkit [50120] by Laszlo Gombos

9 edits in trunk

2009-10-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Make .rc files compile on Windows without depending on MFC headers
https://bugs.webkit.org/show_bug.cgi?id=30750

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Use winresrc.h because it exists even when MFC is not installed, and is all that's needed here.

WebCore.vcproj/QTMovieWin.rc: Ditto.

WebKit.vcproj/WebKit.rc: Ditto.

DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use windows.h instead of afxres.h because it exists even when MFC is not installed, and is all that's needed here.

FindSafari/FindSafari.rc: Ditto

6:56 PM Changeset in webkit [50119] by bweinstein@apple.com

3 edits in trunk/LayoutTests

Unreviewed - Updating getComputedStyle results for Windows.

Updating getComputedStyle results for Windows.

platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

6:09 PM Changeset in webkit [50118] by bfulgham@webkit.org

4 edits in trunk/WebCore

Build corrections for ENABLE_FILTERS in Windows.
https://bugs.webkit.org/show_bug.cgi?id=30797

Reviewed by Darin Adler.

Build correction for ENABLE_FILTERS feature. No new tests needed.

platform/graphics/filters/FEColorMatrix.cpp: Use MathExtras.h and its piDouble constant.
platform/graphics/filters/FEGaussianBlur.cpp: Use MathExtras.h and its piDouble constant. Remove unnecessary call to floor used in the division of an unsigned, converting to int.
platform/graphics/win/SimpleFontDataCairoWin.cpp: Correct include style for MathExtras.h.

6:04 PM WikiStart edited by timothy@apple.com

Remove some other old pages. (diff)

6:01 PM WikiStart edited by timothy@apple.com

Remove some old pages for Developer Tools. (diff)

5:53 PM Changeset in webkit [50117] by mitz@apple.com

2 edits in trunk/WebKitSite

Updated BSD License

Reviewed by Adele Peterson.

coding/bsd-license.html: Updated to the latest version.

5:19 PM Changeset in webkit [50116] by beidson@apple.com

3 edits
4 adds in trunk

<rdar://problem/7289467> and http://webkit.org/b/30798 - REGRESSION (r48687): www.myuhc.com doesn't load.

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/grandparent-completion-starts-redirect.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::completed): Notify all descendants that the load completed, not just direct children.

LayoutTests:

fast/loader/grandparent-completion-starts-redirect-expected.txt: Added.
fast/loader/grandparent-completion-starts-redirect.html: Added.
fast/loader/resources/meta-redirect-to-notify-done.html: Added.
fast/loader/resources/parent-of-redirect.html: Added.

4:56 PM Changeset in webkit [50115] by mitz@apple.com

4 edits in trunk

WebCore: Re-add CSSPropertyWebkitBackgroundSize in one more place

Reviewed by Beth Dakin.

Fixes transitions/multiple-background-size-transitions.html, transitions/background-transitions.html

page/animation/AnimationBase.cpp:

(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):

LayoutTests: Use -webkit-background-size as the transition property in this test now
that it is distinct from background-size.

Reviewed by Sam Weinig.

transitions/multiple-background-size-transitions.html:

4:56 PM Changeset in webkit [50114] by mrowe@apple.com

2 edits in trunk/WebKitLibraries

Clean up the regex madness in auto-version.sh to make it obvious what the script is doing.

Reviewed by Adam Roben.

Also teaches auto-version.sh to handle RC_PROJECTSOURCEVERSION that has more than three digits
in the major component of the version number.

win/tools/scripts/auto-version.sh:

4:44 PM Changeset in webkit [50113] by jorlow@chromium.org

6 edits in trunk/WebCore

2009-10-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Tidy up the DOM Storage runtime flag stuff
https://bugs.webkit.org/show_bug.cgi?id=30794

Clean up the DOM Storage runtime flag stuff to match the new way of doing
things. No behavioral changes.

bindings/v8/RuntimeEnabledFeatures.cpp:
bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::databaseEnabled): (WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled): (WebCore::RuntimeEnabledFeatures::localStorageEnabled): (WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled): (WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
storage/Storage.cpp:
storage/Storage.h:

4:27 PM Changeset in webkit [50112] by mitz@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Beth Dakin.

Update expedted results after r50108.

svg/css/getComputedStyle-basic-expected.txt:

4:20 PM Changeset in webkit [50111] by beidson@apple.com

3 edits
2 adds in trunk

<rdar://problem/7308952> and http://webkit.org/b/30424 - REGRESSION (r48687): Pages on ucas.com appear blank.

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/history-forward-in-head.html

loader/RedirectScheduler.cpp:

(WebCore::RedirectScheduler::scheduleHistoryNavigation): Restore the moved canGoBackOrForward() check.

This restores the side effect of an invalid history navigation canceling previous scheduled redirects
and also fixes the bug of scheduling an invalid history navigation canceling parsing of the current document.

(WebCore::RedirectScheduler::timerFired): Removed the canGoBackOrForward() check as it is now made before

the redirect is scheduled.

LayoutTests:

fast/loader/history-forward-in-head-expected.txt: Added.
fast/loader/history-forward-in-head.html: Added.

4:11 PM Changeset in webkit [50110] by ap@apple.com

6 edits
4 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30049
<rdar://problem/7286002> Manipulating DOM from a script while parsing XHTML can cause a crash

Tests: fast/parser/remove-current-node-parent-x-2.xhtml

fast/parser/remove-current-node-parent-x.xhtml

dom/XMLTokenizer.h: Store the whole stack of parent nodes - element.parentNode() is unreliable after DOM manipulation.

dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode): Push the new node onto stack. (WebCore::XMLTokenizer::popCurrentNode): This is now called instead of setCurrentNode when exiting a node. (WebCore::XMLTokenizer::clearCurrentNodeStack): We're aborting; or just done parsing. This replaces setCurrentNode(0). (WebCore::XMLTokenizer::enterText): Call pushCurrentNode(). (WebCore::XMLTokenizer::exitText): Call popCurrentNode(), removing a long-standing FIXME (not sure if it was ever practical though - how can a parent become null while adding text?)

dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::~XMLTokenizer): Call clearCurrentNodeStack(). (WebCore::XMLTokenizer::startElementNs): Call pushCurrentNode(). (WebCore::XMLTokenizer::endElementNs): Call popCurrentNode() to safely get to a parent. Also added a check fo script element still being in document - Firefox parses those that aren't, but doesn't execute them.

dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::parseStartElement): (WebCore::XMLTokenizer::parseEndElement): Match libxml2 version changes.

3:49 PM Changeset in webkit [50109] by eric@webkit.org

8 edits in trunk/JavaScriptCore

2009-10-26 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

The thunkReturnAddress is on JITStackFrame on ARM JIT as well
https://bugs.webkit.org/show_bug.cgi?id=30782

Move the thunkReturnAddress from top of the stack into the JITStackFrame
structure. This is a requirement for JSValue32_64 support on ARM.

assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::ret): Return with link register (JSC::MacroAssemblerARM::prepareCall): Store the return address in link register
jit/JIT.h: Remove unused ctiReturnRegister
jit/JITInlineMethods.h: Same as ARMv7 (JSC::JIT::restoreArgumentReference): Ditto. (JSC::JIT::restoreArgumentReferenceForTrampoline): Ditto.
jit/JITOpcodes.cpp: Remove ctiReturnRegister related instruction
jit/JITStubs.cpp: Store thunkReturnAddress on JITStackFrame. Use small trampoline functions which handle return addresses for each CTI_STUB_FUNCTION.
jit/JITStubs.h: Store thunkReturnAddress on JITStackFrame (JSC::JITStackFrame::returnAddressSlot): Return with the address of thunkReturnAddress
yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): Remove the unnecessary instruction

3:41 PM Changeset in webkit [50108] by mitz@apple.com

13 edits in trunk

background-size: X treated as background-size: X X, not background-size: X auto
https://bugs.webkit.org/show_bug.cgi?id=28440

Reviewed by Beth Dakin.

WebCore:

Updated fast/backgrounds/size/resources/parsing-background-size-values.js
and fast/backgrounds/size/resources/parsing-inherit.js

Reinstated -webkit-background-size and kept its behavior of filling in
the second value with the first one; and changed background-size to have
the behavior of filling in the second value with 'auto'.

css/CSSComputedStyleDeclaration.cpp:

(computedProperties): Re-added CSSPropertyWebkitBackgroundSize.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto.
(WebCore::CSSParser::parseFillSize): Adapted for the new parsing rule.
(WebCore::CSSParser::parseFillProperty): Re-added
CSSPropertyWebkitBackgroundSize.
(WebCore::cssPropertyID): Removed mapping of -webkit-background-size to
background-size.

css/CSSParser.h:
css/CSSPropertyNames.in: Re-added -webkit-background-size.
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Re-added
CSSPropertyWebkitBackgroundSize.

LayoutTests:

fast/backgrounds/size/parsing-background-size-values-expected.txt:
fast/backgrounds/size/parsing-inherit-expected.txt:
fast/backgrounds/size/resources/parsing-background-size-values.js:

(test):

fast/backgrounds/size/resources/parsing-inherit.js:
platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

3:41 PM Changeset in webkit [50107] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-10-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool post-diff should know how to mark commit-queue=?
https://bugs.webkit.org/show_bug.cgi?id=29202

Scripts/bugzilla-tool:
- Add --commit-queue option to post-diff, post-commits and create-bug.
Scripts/modules/bugzilla.py:
- Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
- Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.

3:37 PM Changeset in webkit [50106] by weinig@apple.com

5 edits
1 add in trunk/WebKit

Move some WebView event handling code into its own file, WebViewEventHandling.mm

Reviewed by Anders Carlsson.

WebKit:

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

WebView/WebView.mm:

(-[WebView _close]):
(-[WebView _selectedOrMainFrame]):

WebView/WebViewEventHandling.mm: Added.

(-[WebView _closingEventHandling]):
(-[WebView _setMouseDownEvent:]):
(-[WebView mouseDown:]):
(-[WebView mouseUp:]):
(+[WebView _updateMouseoverWithEvent:]):
(-[WebView _updateMouseoverWithFakeEvent]):
(_updateMouseoverWithEvent:fakeEvent::if):
(-[WebView _stopAutoscrollTimer]):
(-[WebView _setToolTip:]):

WebView/WebViewInternal.h:

3:34 PM Changeset in webkit [50105] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool commit-queue does not notice modifications to committers.py
https://bugs.webkit.org/show_bug.cgi?id=30084

Scripts/bugzilla-tool:
- Make commit-queue re-exec itself instead of using while(1).
- Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
- Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).

3:32 PM Changeset in webkit [50104] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue will get stuck on patches if land-patches terminates unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=30634

Scripts/bugzilla-tool:
- Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
- Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.

3:22 PM Changeset in webkit [50103] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Use "%lli" to format "long long" on WIN_OS to fix HTML5 WebDB crash
https://bugs.webkit.org/show_bug.cgi?id=30777

No new tests as the crash can be reproduced by existing storage
LayoutTests (by hitting an assert in debug mode Webkit on WIN_OS).

platform/text/String.cpp: (WebCore::String::number): Qt's QString::vsprintf does not understand the "%I64u" format string. Always use the "%lli" format string for Qt port.

3:10 PM Changeset in webkit [50102] by eric@webkit.org

7 edits in trunk/WebKitTools

2009-10-26 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.

https://bugs.webkit.org/show_bug.cgi?id=30763

pywebsocket/mod_pywebsocket/init.py:
pywebsocket/mod_pywebsocket/dispatch.py:
pywebsocket/mod_pywebsocket/headerparserhandler.py:
pywebsocket/mod_pywebsocket/standalone.py:
pywebsocket/setup.py:
pywebsocket/test/test_dispatch.py:

3:04 PM Changeset in webkit [50101] by tony@chromium.org

6 edits in trunk/WebCore

2009-10-26 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Roll back r50073 because r50041-50043 were reverted. r50073 was
a chromium side fix for r50041.
https://bugs.webkit.org/show_bug.cgi?id=30789

bindings/v8/V8Collection.h:
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

3:02 PM Changeset in webkit [50100] by ggaren@apple.com

5 edits
3 adds in trunk

WebCore: Fixed https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes the one added just after it not to fire

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-26
Reviewed by Dimitri Glazkov.

and related bugs.

If the event listener being removed is prior to the current firing event
iterator, we need to decrement the current firing event iterator in
addition to the endpoint. (Otherwise, shrinking the event listener vector
by one implicity moves the current firing event iterator forward by one.
It's like relativity, only without the planets.)

Also took the opportunity to change some pointers to references, since
they can't be null.

dom/EventTarget.cpp:

(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::removeAllEventListeners): Update iterator in addition
to end, if need be.
(WebCore::EventTarget::fireEventListeners): Updated for interface changes.
Added a comment to explain a behavior that was implicit enough to be
confusing.

dom/EventTarget.h:

(WebCore::FiringEventIterator::FiringEventIterator):
(WebCore::EventTarget::isFiringEventListeners): Updated for interface changes.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes one added after it to not fire

Patch by Dimitri Glazkov <Dimitri Glazkov> on 2009-10-26
Reviewed by Geoffrey Garen.

fast/events/event-listener-list-mutation-expected.txt: Added.
fast/events/event-listener-list-mutation.html: Added.
fast/events/script-tests/event-listener-list-mutation.js: Added.

(TestMutation.listeners):
(TestMutation.mutateList):

2:52 PM Changeset in webkit [50099] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Unreviewed documentation fix from David Boddie (Qt Doc Team)

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Removes the check around the RenderHints property documentation
that was clearly added to synchronize the source and header files
when the #if !defined(Q_OS_SYMBIAN) guards was added to the
property.

The documentation has also been updated to ensure that Symbian
users know that there is no actual RenderHints property on their
platform.

Api/qwebview.cpp:

2:50 PM Changeset in webkit [50098] by bweinstein@apple.com

2 edits in trunk/WebCore

Fixes <http://webkit.org/b/30792>.
Web Inspector: When changing resource scope, resource graph can get in weird state.

Reviewed by Timothy Hatcher.

If the user was scrolled down while looking at All resources, and then just
selects Fonts, or something that doesn't have many resources, then the graph
will stay scrolled down, even when there is no content there.

When the filter is updated, scroll to the top of the graph view, so this won't
happen.

inspector/front-end/AbstractTimelinePanel.js:

(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

2:46 PM Changeset in webkit [50097] by weinig@apple.com

2 edits in trunk/WebCore

Fix mac clean build.

html/HTMLOptionsCollection.idl:

2:42 PM Changeset in webkit [50096] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Unreviewed documentation fix from David Boddie (Qt Doc Team)

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Ensure that qdoc will always see the RenderHints property.

The property was only defined in the header file if the Q_OS_SYMBIAN
symbol was not defined, resulting in the property not showing up
in the Qt documentation just because one platform doesn't support it.

A follow up commit will improve the documentation for the property
and note that it is not supported on the Symbiam platform.

Api/qwebview.h:

2:35 PM Changeset in webkit [50095] by pfeldman@chromium.org

9 edits
1 add in trunk/WebCore

2009-10-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Extract AbstractTimelinePanel that will be a base
class for ResourcesPanel and TimelinePanel.

https://bugs.webkit.org/show_bug.cgi?id=30776

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/AbstractTimelinePanel.js: Added. (WebInspector.AbstractTimelinePanel): (WebInspector.AbstractTimelinePanel.prototype.get categories): (WebInspector.AbstractTimelinePanel.prototype.showCategory): (WebInspector.AbstractTimelinePanel.prototype.hideCategory): (WebInspector.AbstractTimelinePanel.prototype.createTimelinePanels): (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel.createFilterElement): (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel): (WebInspector.AbstractTimelinePanel.prototype.filter): (WebInspector.AbstractTimelinePanel.prototype._updateFilter): (WebInspector.AbstractTimelinePanel.prototype._createGraph): (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.AbstractTimelinePanel.prototype._updateSummaryGraph): (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition): (WebInspector.AbstractTimelinePanel.prototype.get needsRefresh): (WebInspector.AbstractTimelinePanel.prototype.set needsRefresh): (WebInspector.AbstractTimelinePanel.prototype.refreshIfNeeded): (WebInspector.AbstractTimelinePanel.prototype.show): (WebInspector.AbstractTimelinePanel.prototype.resize): (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.computeSummaryValues): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels): (WebInspector.TimelineCalculator.prototype.get boundarySpan): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype._value): (WebInspector.TimelineCalculator.prototype.formatValue):
inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.ResourcesPanel.prototype.get statusBarItems): (WebInspector.ResourcesPanel.prototype.get categories): (WebInspector.ResourcesPanel.prototype.showCategory): (WebInspector.ResourcesPanel.prototype.hideCategory): (WebInspector.ResourcesPanel.prototype.isCategoryVisible): (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourcesPanel.prototype.createPanelEnabler): (WebInspector.ResourcesPanel.prototype.createStatusbarButtons): (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.resize): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded): (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): (WebInspector.ResourceTimeCalculator): (WebInspector.ResourceTransferSizeCalculator): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
inspector/front-end/SummaryBar.js: (WebInspector.SummaryBar.prototype.update):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:
inspector/front-end/inspector.js: (WebInspector.loaded):

2:09 PM Changeset in webkit [50094] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-26 Avi Drissman <avi@google.com>

Reviewed by Darin Adler.

Use Helvetica in the Inspector as intended.
https://bugs.webkit.org/show_bug.cgi?id=30787

inspector/front-end/inspector.css:

2:05 PM Changeset in webkit [50093] by xan@webkit.org

2 edits in trunk/LayoutTests

2009-10-26 Xan Lopez <xlopez@igalia.com>

Skip test fast/loader/opaque-base-url.html with a reference to the
bug tracking it, https://bugs.webkit.org/show_bug.cgi?id=30724

platform/gtk/Skipped:

2:02 PM Changeset in webkit [50092] by eric@webkit.org

5 edits in trunk

2009-10-26 Nate Chapin <Nate Chapin>

Reviewed by Alexey Proskuryakov.

Update no-referrer-reset for https://bugs.webkit.org/show_bug.cgi?id=30781.

http/tests/navigation/no-referrer-reset-expected.txt: Expect window.opener to still be set.
http/tests/navigation/no-referrer-reset.html: Update text to reflect what the test actually does.

2009-10-26 Nate Chapin <Nate Chapin>

Reviewed by Alexey Proskuryakov.

Don't set window.opener to 0 for the current FrameLoader if a noreferrer link was clicked, only suppress opener in a new frame.
https://bugs.webkit.org/show_bug.cgi?id=30781

loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): Don't suppress opener in the current frame for noreferrer navigations.

1:53 PM Changeset in webkit [50091] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-26 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Levin.

REGRESSION: 2 failures in run-webkit-unittests
https://bugs.webkit.org/show_bug.cgi?id=30645

Scripts/modules/cpp_style_unittest.py: Fixed a few test scenarios which apparently lost some spaces from text literals.

1:48 PM Changeset in webkit [50090] by rniwa@webkit.org

3 edits
3 adds in trunk

Data loss occurs when unbolding nested bold tags.
https://bugs.webkit.org/show_bug.cgi?id=30083

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-26
Reviewed by Eric Seidel.

WebCore:

Fixes the loop in swapInNodePreservingAttributesAndChildren by saving nextSibling() of child
to a temporary valuable. It was originally calling nextSibling() after appending the child
to new parent, in which case, nextSibling is always 0.

Test: editing/style/unbolding-nested-b.html

editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

LayoutTests:

Adds a test to make sure WebKit can remove nested b, i, & s tags properly
without loosing the content of inner elements.

editing/style/remove-nested-inline-styles-expected.txt: Added.
editing/style/remove-nested-inline-styles.html: Added.
editing/style/script-tests/remove-nested-inline-styles.js: Added.

(removeStyleAndExpect):

1:16 PM Changeset in webkit [50089] by kov@webkit.org

2 edits in trunk

Reviewed by Jan Alonzo.

Alternative solution to regression introduced in r48672.

1:11 PM Changeset in webkit [50088] by jorlow@chromium.org

4 edits
3 adds in trunk

2009-10-21 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Storage events should use Document::url() rather than documentURI()
https://bugs.webkit.org/show_bug.cgi?id=30535

Storage events should use Document::url() rather than Document::documentURI()
per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html

Test: storage/domstorage/documentURI.html

storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):

2009-10-26 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.

fast/dom/wrapper-classes-expected.txt:

1:04 PM Changeset in webkit [50087] by weinig@apple.com

19 edits
1 delete in trunk

Rubber-stamped by Darin Adler.

Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.

WebCore:

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
(WebCore::toJS):

bindings/js/JSHTMLCollectionFunctions.h: Removed.
bindings/js/JSHTMLDocumentCustom.cpp:
bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::length):
(WebCore::JSHTMLOptionsCollection::indexSetter):

bindings/objc/DOMHTML.mm:

(kitClass):

bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):

bindings/scripts/CodeGeneratorJS.pm:
html/HTMLCollection.idl:
html/HTMLOptionsCollection.idl:

WebKit/win:

DOMCreateInstance.cpp:

LayoutTests:

fast/dom/wrapper-classes-expected.txt:

12:46 PM Changeset in webkit [50086] by kevino@webkit.org

2 edits in trunk/WebKitTools

wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.

12:34 PM Changeset in webkit [50085] by bfulgham@webkit.org

3 edits in trunk/WebCore

Build fix for ENABLE_FILTERS under Windows.
https://bugs.webkit.org/show_bug.cgi?id=30762

Reviewed by Adam Roben.

Build correction for ENABLE_FILTERS feature. No new tests needed.

WebCore.vcproj/WebCore.vcproj: Make the following changes: (1) Create a new 'filters' sub-folder of the platform/graphics

folder to properly show the sources held in this directory.

(2) Move the files that are currently shown in svn/graphics/filters

to platform/graphics/filters (where they actually live on disk).

(3) Add the missing SVGFilter, SVGFilterBuilder, and SVGFETile to

the project so they are built.

(4) Remove SVGFEFloodElement.cpp from the build, since it is already

being compiled by SVGAllInOne.cpp. Its presence as a separate
entity is causing a linker warning for duplicate symbols.

(5) Add ImageBuffer.cpp to the build to support color space

calculations for non-CG builds.

WebCore.vcproj/WebCoreCommon.vsprops: Add the platform/graphics/filters path to the search paths in the project.

12:30 PM Changeset in webkit [50084] by eric@webkit.org

5 edits in trunk/WebCore

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

console.assert should prefix messages with "Assertion failed: "
https://bugs.webkit.org/show_bug.cgi?id=19135

English.lproj/localizedStrings.js:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType. (WebInspector.ConsoleMessage.prototype.toString):
page/Console.cpp: (WebCore::Console::assertCondition): Use AssertMessageType.
page/Console.h: (WebCore::MessageType): Added AssertMessageType.

12:19 PM Changeset in webkit [50083] by eric@webkit.org

3 edits
2 adds in trunk

2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Eric Seidel.

Prevent crash when optgroup element is empty.

https://bugs.webkit.org/show_bug.cgi?id=30365

fast/forms/select-empty-optgroup-expected.txt: Added.
fast/forms/select-empty-optgroup.html: Added.

2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Eric Seidel.

Prevent crash when optgroup element is empty by adding a NULL check.

https://bugs.webkit.org/show_bug.cgi?id=30365

Test: fast/forms/select-empty-optgroup.html

dom/SelectElement.cpp: (WebCore::SelectElement::appendFormData):

12:11 PM Changeset in webkit [50082] by tony@chromium.org

3 edits in trunk/WebCore

2009-10-21 Steven Knight <sgk@chromium.org>

Reviewed by David Levin.

Refactor gyp for separate webcore_bindings{,_sources} targets.

https://bugs.webkit.org/show_bug.cgi?id=30447

Handle long link lines by building .idl-generated bindings in a
separate webcore_bindings library target. Avoid Visual Studio
dependency issues by building additional generated .cpp and .h files
in a separate webcore_bindings_sources target.

Chrome should still build and test successfully.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:

12:10 PM Changeset in webkit [50081] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.1.16

Tagging 1.1.16.

11:57 AM Changeset in webkit [50080] by Csaba Osztrogonác

9 edits in trunk/WebKitTools

Unification of using null device in perl scripts.
https://bugs.webkit.org/show_bug.cgi?id=30572

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-26
Reviewed by Darin Adler.

Scripts/VCSUtils.pm:
Scripts/bisect-builds:
Scripts/resolve-ChangeLogs:
Scripts/run-iexploder-tests:
Scripts/run-jsc:
Scripts/run-mangleme-tests:
Scripts/run-webkit-tests:
Scripts/webkitdirs.pm:

Using File::Spec->devnull() instead of hard coded /dev/null.

11:40 AM Changeset in webkit [50079] by eric@webkit.org

3 edits
1 add in trunk/WebCore

2009-10-26 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

Make the number of connections for chromium controlled by
chromium rather than by ResourceRequestBase.
https://bugs.webkit.org/show_bug.cgi?id=30661

platform/network/ResourceRequestBase.cpp:
platform/network/chromium/ResourceRequest.cpp:

11:38 AM Changeset in webkit [50078] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-26 Eric Seidel <eric@webkit.org>

Reviewed by Holger Freyther.

Reviewers are missing from committers.py
https://bugs.webkit.org/show_bug.cgi?id=30733

Scripts/modules/committers.py:

11:38 AM Web Inspector edited by casey.hattori@gmail.com

(diff)

11:33 AM Changeset in webkit [50077] by eric@webkit.org

2 edits in trunk/BugsSite

2009-10-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

PrettyPatch should show images even when they have the wrong mime type
https://bugs.webkit.org/show_bug.cgi?id=29506

PrettyPatch/PrettyPatch.rb:

10:55 AM HackingGtk edited by kov@webkit.org

(diff)

10:54 AM Changeset in webkit [50076] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed typo fix.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-26

platform/qt/Skipped: shared-workers-close.html replaced with shared-worker-close.html

10:45 AM Changeset in webkit [50075] by kov@webkit.org

2 edits in trunk/WebCore

Unreviewed. make distcheck build fixes.

10:44 AM Changeset in webkit [50074] by kov@webkit.org

2 edits in trunk

Unreviewed. Fix make dist regression introduced by r48672.

10:35 AM Changeset in webkit [50073] by eric@webkit.org

6 edits in trunk/WebCore

2009-10-26 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Unbreak Chromium build: that requires adding custom implementations
for HTMLOptionsCollection's item and namedItem. Keep v8 binding
close to JSC bindings as well.
https://bugs.webkit.org/show_bug.cgi?id=30780

bindings/v8/V8Collection.h: (WebCore::getNamedItemsFromCollection): (WebCore::getItemFromCollection):
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

10:26 AM Changeset in webkit [50072] by ap@apple.com

3 edits
3 adds in trunk

Reviewed by Adam Barth and Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30723
<rdar://problem/6189415> Input names added to multipart/form-data headers need to be escaped.

Test: http/tests/security/escape-form-data-field-names.html

platform/network/FormDataBuilder.cpp: (WebCore::appendQuotedString): (WebCore::FormDataBuilder::beginMultiPartHeader): (WebCore::FormDataBuilder::addFilenameToMultiPartHeader): Percent-escape line breaks and quotation marks.

10:10 AM Changeset in webkit [50071] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Skip two flakey tests because of sporadic timeouts.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

platform/qt/Skipped:

10:06 AM Changeset in webkit [50070] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Skipping two other tests because of missing features on our platform.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

platform/qt/Skipped:

10:00 AM Changeset in webkit [50069] by Csaba Osztrogonác

1 edit
1 add in trunk/LayoutTests

[Qt] Add platform-dependent expected file for test added in r49875.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

platform/qt/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Added.

9:46 AM Changeset in webkit [50068] by eric@webkit.org

8 edits in trunk/WebCore

2009-10-26 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Adds DOMTimer support to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=30467

inspector/InspectorTimelineAgent.cpp: Added timer support and fixed some method names. (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): Added. (WebCore::InspectorTimelineAgent::didRemoveTimer): Added. (WebCore::InspectorTimelineAgent::willFireTimer): Added. (WebCore::InspectorTimelineAgent::didFireTimer): Added. (WebCore::InspectorTimelineAgent::addItemToTimeline): Added. (WebCore::InspectorTimelineAgent::didCompleteCurrentTimelineItem): Renamed.
inspector/InspectorTimelineAgent.h: (WebCore::):
inspector/TimelineItemFactory.cpp: Add methods for timer-related ScriptObjects. (WebCore::TimelineItemFactory::createGenericTimerTimelineItem): (WebCore::TimelineItemFactory::createTimerInstallTimelineItem):
inspector/TimelineItemFactory.h:
page/DOMTimer.cpp: Added instrumentation points. (WebCore::DOMTimer::install): (WebCore::DOMTimer::removeById): (WebCore::DOMTimer::fired):

9:31 AM Changeset in webkit [50067] by Simon Fraser

6 edits in trunk

2009-10-26 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

<rdar://problem/6988966> Hardware layers do not show up in page snapshots

WebView/WebHTMLViewPrivate.h:
WebView/WebHTMLView.mm: (-[WebHTMLView _compositingLayersHostingView]): Add a private method that returns the NSView used to host compositing layers.

platform/graphics/mac/Canvas3DLayer.h:
platform/graphics/mac/Canvas3DLayer.mm: (-[Canvas3DLayer copyImageSnapshotWithColorSpace:]): Add a method that gets called when snapshotting Canvas3DLayers for page snapshots, that allows the layer to return a CGImageRef of its contents.

9:22 AM Changeset in webkit [50066] by Csaba Osztrogonác

7 edits in trunk/LayoutTests

[Qt] Update outdated expected files which expected wrong color values.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:

9:17 AM Changeset in webkit [50065] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Pass "console" as object group when evaluating selection.

https://bugs.webkit.org/show_bug.cgi?id=30738

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):

9:10 AM Changeset in webkit [50064] by eric@webkit.org

10 edits in trunk

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix for Console not showing repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324

inspector/console-tests-expected.txt:

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix for Console not showing repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324

inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::updateRepeatCountInConsole): Added.
inspector/ConsoleMessage.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): Calls updateRepeatCountInConsole if it is a repeating message.
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): Renamed WebCore::InspectorFrontend::addMessageToConsole (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): Added. Called when repeatCount is incremented.
inspector/InspectorFrontend.h:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): Removed calls to msg.isEqual. (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): Added. (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): Added. Updates the error/warning count. (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): Use ConsoleMessage._updateRepeatCount (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
inspector/front-end/inspector.js: (WebInspector.addConsoleMessage): Renamed WebInspector.addMessageToConsole. (WebInspector.updateConsoleMessageRepeatCount): Added.

8:27 AM Changeset in webkit [50063] by eric.carlson@apple.com

63 edits in trunk/LayoutTests

2009-10-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464

Part 1, change layout tests to not use the event.

media/audio-constructor-autobuffer-expected.txt:
media/audio-constructor-autobuffer.html:
media/audio-constructor-expected.txt:
media/audio-constructor-src-expected.txt:
media/audio-constructor-src.html:
media/audio-constructor.html:
media/audio-controls-rendering.html:
media/audio-data-url-expected.txt:
media/audio-data-url.html:
media/audio-mpeg-supported-expected.txt:
media/audio-mpeg-supported.html:
media/media-load-event-expected.txt:
media/media-load-event.html:
media/progress-event-expected.txt:
media/progress-event-total-expected.txt:
media/progress-event-total.html:
media/progress-event.html:
media/remove-from-document-expected.txt:
media/remove-from-document-no-load-expected.txt:
media/remove-from-document-no-load.html:
media/remove-from-document.html:
media/restore-from-page-cache-expected.txt:
media/restore-from-page-cache.html:
media/video-append-source-expected.txt:
media/video-append-source.html:
media/video-buffered-expected.txt:
media/video-buffered.html:
media/video-canvas-source-expected.txt:
media/video-canvas-source.html:
media/video-controls-expected.txt:
media/video-controls-transformed-expected.txt:
media/video-controls-transformed.html:
media/video-controls-zoomed-expected.txt:
media/video-controls-zoomed.html:
media/video-controls.html:
media/video-currentTime-expected.txt:
media/video-currentTime-set-expected.txt:
media/video-currentTime-set.html:
media/video-currentTime-set2-expected.txt:
media/video-currentTime-set2.html:
media/video-currentTime.html:
media/video-dom-src-expected.txt:
media/video-dom-src.html:
media/video-error-abort-expected.txt:
media/video-error-abort.html:
media/video-error-does-not-exist.html:
media/video-muted-expected.txt:
media/video-muted.html:
media/video-no-autoplay-expected.txt:
media/video-no-autoplay.html:
media/video-seek-past-end-paused-expected.txt:
media/video-seek-past-end-paused.html:
media/video-seek-past-end-playing-expected.txt:
media/video-seek-past-end-playing.html:
media/video-seekable-expected.txt:
media/video-seekable.html:
media/video-seeking-expected.txt:
media/video-seeking.html:
media/video-src-change-expected.txt:
media/video-src-change.html:
media/video-volume-expected.txt:
media/video-volume.html:

7:49 AM Changeset in webkit [50062] by Chris Fleizach

3 edits
2 adds in trunk

crash with AX on when an image map contains an anchor tag
https://bugs.webkit.org/show_bug.cgi?id=30739

Reviewed by Darin Adler.

WebCore:

Tests: accessibility/crashing-a-tag-in-map.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addChildren):

LayoutTests:

accessibility/crashing-a-tag-in-map-expected.txt: Added.
accessibility/crashing-a-tag-in-map.html: Added.

6:51 AM Changeset in webkit [50061] by kov@webkit.org

3 edits in trunk/WebKit/gtk

2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Update documentation control files for 1.1.16.

docs/webkitgtk-docs.sgml:
docs/webkitgtk-sections.txt:

6:49 AM Changeset in webkit [50060] by kov@webkit.org

3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30759
[GTK] Should use WebKitNetworkResponse, and expose it

WebKitDownload now uses our WebKitNetworkResponse instead of using
ResourceResponse directly. By exposing the response, like we do
with the request, we give our users the ability to look at the
response headers, status code, and so on, through the SoupMessage
object.

6:25 AM Changeset in webkit [50059] by xan@webkit.org

4 edits in trunk

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.1.16 release.

configure.ac:

WebKit/gtk:

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.1.16 release.

NEWS:

6:06 AM Changeset in webkit [50058] by eric@webkit.org

8 edits in trunk/WebKit/qt

2009-10-26 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Reintroduce QWebElementCollection

Revert the patch that has replaced QWebElementCollection
with QList<QWebElement>. Update the tests accordingly.

Remove the constness of the return type of QWebElement operator[].

https://bugs.webkit.org/show_bug.cgi?id=30767

Api/qwebelement.cpp: (QWebElement::findAll): (QWebElementCollectionPrivate::QWebElementCollectionPrivate): (QWebElementCollectionPrivate::create): (QWebElementCollection::QWebElementCollection): (QWebElementCollection::operator=): (QWebElementCollection::~QWebElementCollection): (QWebElementCollection::operator+): (QWebElementCollection::append): (QWebElementCollection::count): (QWebElementCollection::at): (QWebElementCollection::toList):
Api/qwebelement.h: (const_iterator::begin): (const_iterator::end): (const_iterator::operator[]):
Api/qwebframe.cpp: (QWebFrame::findAllElements):
Api/qwebframe.h:
QtLauncher/main.cpp: (MainWindow::selectElements):
tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::simpleCollection): (tst_QWebElement::iteration): (tst_QWebElement::emptyCollection): (tst_QWebElement::appendCollection): (tst_QWebElement::nullSelect): (tst_QWebElement::hasSetFocus): (tst_QWebElement::render):
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

5:44 AM Changeset in webkit [50057] by benm@google.com

5 edits in trunk/WebCore

Adds feature ENABLE guards to V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30697

Patch by Steve Block <steveblock@google.com> on 2009-10-26
Reviewed by Eric Seidel.

This adds guards for the following features to the V8 bindings,
to allow builds with V8 to succeed when these features are not enabled.

DATABASE
WORKERS
SHARED_WORKERS
SVG
XPATH
XSLT
INSPECTOR

This is a build fix only, no new tests required.

bindings/v8/DOMObjectsInclude.h: Modified.
bindings/v8/DerivedSourcesAllInOne.cpp: Modified.
bindings/v8/V8Index.cpp: Modified.
bindings/v8/V8Index.h: Modified.

5:32 AM Changeset in webkit [50056] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Rubber-stamped by Tor Arne Vestbø.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-26
http/tests/cookies/simple-cookies-max-age.html moved to flakey tests group.
http/tests/xmlhttprequest/workers/close.html added to flakey tests group.

platform/qt/Skipped:

4:58 AM Changeset in webkit [50055] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed trivial fix for r49854.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-26

platform/qt/Skipped: Missing html extension added.

4:42 AM Changeset in webkit [50054] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25679
[Gtk] Improve accessibility of focusable lists

Fixes the issues with the Atk states exposed for ListBoxOption

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject):

4:35 AM Changeset in webkit [50053] by eric@webkit.org

9 edits in trunk/WebCore

2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=27085
[Gtk] Incorrect rendering of list

Adds a way for platforms to indicate that a particular object
should not be ignored.

accessibility/AccessibilityObject.h:
accessibility/chromium/AccessibilityObjectChromium.cpp:
accessibility/gtk/AccessibilityObjectAtk.cpp:
accessibility/mac/AccessibilityObjectMac.mm:
accessibility/qt/AccessibilityObjectQt.cpp:
accessibility/win/AccessibilityObjectWin.cpp:
accessibility/wx/AccessibilityObjectWx.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):

3:46 AM Changeset in webkit [50052] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2009-10-26 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Adds ability to disable ReadWriteLock on platforms (eg Android) that use pthreads but do not support pthread_rwlock.
https://bugs.webkit.org/show_bug.cgi?id=30713

wtf/Platform.h: Modified. Defines HAVE_PTHREAD_RWLOCK for all platforms currently using pthreads.
wtf/Threading.h: Modified. Use pthread_rwlock_t only when HAVE_PTHREAD_RWLOCK is defined.
wtf/ThreadingPthreads.cpp: Modified. Build ReadWriteLock methods only when HAVE_PTHREAD_RWLOCK is defined.

3:29 AM Changeset in webkit [50051] by eric@webkit.org

3 edits
1 add in trunk/WebCore

2009-10-26 Kinuko Yasuda <kinuko@google.com>

Reviewed by Jan Alonzo.

Bug 30619: [Linux] Menu key doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30619

Test: manual-tests/keyboard-menukey-event.html
No new layout tests: testing this will require changes in the test
controller in a platform-specific way.

platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for GDK_Menu to return VKEY_APPS instead of VKEY_MENU.
platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for GDK_Menu to return V_APPS instead of VK_MENU.

3:07 AM Changeset in webkit [50050] by jmalonzo@webkit.org

2 edits in trunk/LayoutTests

2009-10-26 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] Reenable mod_rewrite in Fedora's httpd.conf
https://bugs.webkit.org/show_bug.cgi?id=30741

http/conf/fedora-httpd.conf:

1:52 AM QtBackLog edited by zecke@selfish.org

(diff)

1:45 AM QtBackLog edited by zecke@selfish.org

(diff)

Oct 25, 2009:

9:33 PM Changeset in webkit [50049] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-25 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Reuse already fetched proxy.
https://bugs.webkit.org/show_bug.cgi?id=30747

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNewNodeToV8Object):

9:14 PM QtBackLog edited by zecke@selfish.org

(diff)

9:07 PM QtBackLog edited by zecke@selfish.org

(diff)

9:03 PM QtBackLog edited by zecke@selfish.org

Mention the bug report and commits of this work (diff)

5:45 PM Changeset in webkit [50048] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-10-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Rebaseline test after 49998.

platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

3:39 PM Changeset in webkit [50047] by Laszlo Gombos

2 edits in trunk/WebCore

2009-10-25 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix.

Build fix for WIN_OS if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=30753

plugins/PluginDatabase.cpp:

1:15 PM Changeset in webkit [50046] by eric@webkit.org

3 edits
4 adds in trunk

2009-10-25 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

A quick fix for Bug 29103.
Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
and the option string before calling String::startsWith().
https://bugs.webkit.org/show_bug.cgi?id=29103

fast/forms/listbox-typeahead-cyrillic-expected.txt: Added.
fast/forms/listbox-typeahead-cyrillic.html: Added.
fast/forms/listbox-typeahead-greek-expected.txt: Added.
fast/forms/listbox-typeahead-greek.html: Added.

2009-10-25 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

A quick fix for Bug 29103.
Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
and the option string before calling String::startsWith().
https://bugs.webkit.org/show_bug.cgi?id=29103

Tests: fast/forms/listbox-typeahead-cyrillic.html

fast/forms/listbox-typeahead-greek.html

dom/SelectElement.cpp: (WebCore::SelectElement::typeAheadFind):

10:28 AM Changeset in webkit [50045] by mitz@apple.com

3 edits in trunk/WebKit/win

Add contextForWorldID to the IWebFramePrivate interface.

Reviewed by John Sullivan.

Interfaces/IWebFramePrivate.idl:
WebFrame.h:

8:06 AM Web Inspector edited by casey.hattori@gmail.com

(diff)

6:56 AM Web Inspector edited by casey.hattori@gmail.com

(diff)

6:54 AM Web Inspector edited by casey.hattori@gmail.com

(diff)

1:54 AM Changeset in webkit [50044] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-25 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Expanding a node in the Console should not show the element in Elements panel
https://bugs.webkit.org/show_bug.cgi?id=30749

inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onmousedown): Check if inside disclosure triangle.

1:22 AM Changeset in webkit [50043] by weinig@apple.com

2 edits in trunk/WebKit/win

Another try at fixing windows.

DOMCreateInstance.cpp:

12:52 AM Changeset in webkit [50042] by weinig@apple.com

2 edits in trunk/WebKit/win

Touch WebKit.idl in an effort to try and regenerate the COM bindings.

Interfaces/WebKit.idl:

12:52 AM Changeset in webkit [50041] by weinig@apple.com

18 edits
1 add in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Added JSHTMLCollectionFunctions.h

bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):

bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h

bindings/js/JSHTMLCollectionFunctions.h: Added.

(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.

bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h

for toJS on document.all.

bindings/objc/DOMHTML.mm:
bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.

bindings/scripts/CodeGeneratorJS.pm:
html/HTMLAllCollection.idl:
html/HTMLCollection.idl:
html/HTMLOptionsCollection.idl:

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

fast/dom/wrapper-classes-expected.txt:

12:08 AM Changeset in webkit [50040] by bweinstein@apple.com

18 edits
1 delete in trunk

Roll out r50037 as it broke the Windows build.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed