Timeline
Oct 31, 2009:
- 4:22 PM Changeset in webkit [50383] by
-
- 2 edits in trunk/WebCore
Build fix
- 4:10 PM Changeset in webkit [50382] by
-
- 2 edits in trunk/WebCore
Remove obsolete null checks from CanvasRenderingContext3DMac
https://bugs.webkit.org/show_bug.cgi?id=30983
Reviewed by Darin Adler
- 3:19 PM Changeset in webkit [50381] by
-
- 6 edits6 adds in trunk
WebGL allows objects to be used with the wrong context
https://bugs.webkit.org/show_bug.cgi?id=30981
Reviewed by Jon Honeycutt.
Simply add null checks and a few context guards to ensure we don't
deref null or attempt to use an object from a different context.
Tests: fast/canvas/webgl/incorrect-context-object-behaviour.html
fast/canvas/webgl/null-object-behaviour.html
- 2:54 PM BuildingOnWindows edited by
- (diff)
Oct 30, 2009:
- 8:48 PM Changeset in webkit [50380] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 8:48 PM Changeset in webkit [50379] by
-
- 1 copy in tags/Safari-6531.21.8
New tag.
- 8:47 PM Changeset in webkit [50378] by
-
- 2 edits in branches/safari-4-branch/WebCore
Fix the build.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):
- 7:11 PM Changeset in webkit [50377] by
-
- 2 edits in trunk/JavaScriptCore
Fixed failing layout test: restore a special case I accidentally deleted.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-30
Reviewed by Oliver Hunt.
- runtime/DatePrototype.cpp:
(JSC::setNewValueFromDateArgs): In the case of applying a change to a date
that is NaN, reset the date to 0 *and* then apply the change; don't just
reset the date to 0.
- 5:51 PM Changeset in webkit [50376] by
-
- 2 edits in trunk/WebKitTools
Fix an issue that Adam noticed in DRT.
Reviewed by Darin Adler.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::role):
Get the length of the role text, and create a buffer dynamically.
- 5:26 PM Changeset in webkit [50375] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:25 PM Changeset in webkit [50374] by
-
- 1 copy in tags/Safari-6531.21.7
New tag.
- 5:23 PM Changeset in webkit [50373] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r50356.
- 5:23 PM Changeset in webkit [50372] by
-
- 6 edits2 adds in branches/safari-4-branch
Merge r50355.
- 5:23 PM Changeset in webkit [50371] by
-
- 7 edits in branches/safari-4-branch
Merge r50354.
- 5:23 PM Changeset in webkit [50370] by
-
- 8 edits in branches/safari-4-branch
Merge r50353.
- 4:18 PM Changeset in webkit [50369] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's MediaQueryResult
https://bugs.webkit.org/show_bug.cgi?id=30857
Reviewed by Darin Adler.
Inherits MediaQueryResult class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:5984 and
it is no need to be copyable.
- css/CSSStyleSelector.h:
- 4:16 PM Changeset in webkit [50368] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's MediaQueryEvaluator
https://bugs.webkit.org/show_bug.cgi?id=30854
Reviewed by Darin Adler.
Inherits MediaQueryEvaluator class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and
it is no need to be copyable.
- css/MediaQueryEvaluator.h:
- 4:10 PM Changeset in webkit [50367] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's MediaQueryEvaluator
https://bugs.webkit.org/show_bug.cgi?id=30854
Reviewed by Darin Adler.
Inherits MediaQueryEvaluator class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and
it is no need to be copyable.
- css/MediaQueryEvaluator.h:
- 4:08 PM Changeset in webkit [50366] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's CSSRuleSet
https://bugs.webkit.org/show_bug.cgi?id=30852
Reviewed by Darin Adler.
Inherits CSSRuleSet class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:455 and
it is no need to be copyable.
- css/CSSStyleSelector.cpp:
- 4:06 PM Changeset in webkit [50365] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's CSSRuleData
https://bugs.webkit.org/show_bug.cgi?id=30851
Reviewed by Darin Adler.
Inherits CSSRuleData class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.h:320 and
it is no need to be copyable.
- css/CSSStyleSelector.h:
- 4:02 PM Changeset in webkit [50364] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's CSSRuleDataList
https://bugs.webkit.org/show_bug.cgi?id=30850
Reviewed by Darin Adler.
Inherits CSSRuleDataList class from Noncopyable because it has been
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:2715 and
it is no need to be copyable.
- css/CSSStyleSelector.h:
- 3:59 PM Changeset in webkit [50363] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's CSSNamespace
https://bugs.webkit.org/show_bug.cgi?id=30849
Reviewed by Darin Adler.
Inherits CSSNamespace struct from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSheet.cpp:141 and
it is no need to be copyable.
- css/CSSNamespace.h:
- 3:41 PM Changeset in webkit [50362] by
-
- 2 edits in trunk/WebKitTools
2009-10-30 Eric Seidel <eric@webkit.org>
No review, rolling out r50105.
http://trac.webkit.org/changeset/50105
This commit was causing:
https://bugs.webkit.org/show_bug.cgi?id=30869
We'll re-implement the feature a different way.
- Scripts/bugzilla-tool:
- 3:35 PM Changeset in webkit [50361] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: update for object-to-pointer change.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-30
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
- 3:26 PM Changeset in webkit [50360] by
-
- 5 edits in trunk/WebCore
Refactor DatabaseTask in preparation for removing threadsafe refcounting from it.
Move the synchronizer object out of the DatabaseTask so there is no need to keep
the pointer to Databasetask around after passing it to MessageQueue.
Also pass the references to return parameters to the task so it can update them.
https://bugs.webkit.org/show_bug.cgi?id=30941
Reviewed by David Levin.
No new tests, since this is just moving the code around, no change in functionality.
- storage/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::openAndVerifyVersion): Use new DatabaseTaskSynchronizer to wait for task completion.
(WebCore::Database::markAsDeletedAndClose): Ditto.
(WebCore::Database::tableNames): Ditto.
(WebCore::Database::stop): Use the boolean flag rather then 'killed' flag built into MessageQueue.
(WebCore::Database::scheduleTransaction): Transaction queue is a Deque now, change the way to fetch the transaction.
- storage/Database.h: Change the SQLTransaction queue to be a Deque rather then a MessageQueue.
- storage/DatabaseTask.cpp:
(WebCore::DatabaseTaskSynchronizer::DatabaseTaskSynchronizer):
(WebCore::DatabaseTaskSynchronizer::waitForTaskCompletion):
(WebCore::DatabaseTaskSynchronizer::taskCompleted):
(WebCore::DatabaseTask::DatabaseTask): Ctor takes DatabaseTaskSynchronizer which can be 0.
(WebCore::DatabaseTask::performTask): Signal completion. m_synchronizer should still be around since main thread is waiting on it.
(WebCore::DatabaseOpenTask::DatabaseOpenTask): Pass synchronizer and return parameters via constructor.
(WebCore::DatabaseCloseTask::DatabaseCloseTask): Ditto.
(WebCore::DatabaseTransactionTask::DatabaseTransactionTask): Ditto.
(WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): Ditto.
- storage/DatabaseTask.h:
(WebCore::DatabaseOpenTask::create):
(WebCore::DatabaseCloseTask::create):
(WebCore::DatabaseTransactionTask::create):
(WebCore::DatabaseTableNamesTask::create):
- 3:23 PM Changeset in webkit [50359] by
-
- 4 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=30942
Use pointers instead of copies to pass GregorianDateTime objects around.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-29
Reviewed by Darin Adler.
SunSpider reports a shocking 4.5% speedup on date-format-xparb, and 1.3%
speedup on date-format-tofte.
- runtime/DateInstance.cpp:
(JSC::DateInstance::gregorianDateTime):
- runtime/DateInstance.h:
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Renamed getGregorianDateTime to gregorianDateTime,
since it no longer has an out parameter. Uses 0 to indicate invalid dates.
- 3:09 PM Changeset in webkit [50358] by
-
- 3 edits2 adds in trunk
REGRESSION: In Mail, Undo does not restore some characters I have deleted at the end of a line
https://bugs.webkit.org/show_bug.cgi?id=30955
<rdar://problem/7067033>
Patch by Enrica Casucci <enrica@apple.com> on 2009-10-30
Reviewed by Darin Adler.
WebCore:
When the command is deleteWordBackward or deleteWordForward
we should not add to the open typing command, but
create a new one.
Test: editing/undo/undo-deleteWord.html
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Always start a new command if the granularity is
not CharacterGranularity.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Always start a new command if the granularity is
not CharacterGranularity.
LayoutTests:
- editing/undo/undo-deleteWord-expected.txt: Added.
- editing/undo/undo-deleteWord.html: Added.
- 3:03 PM Changeset in webkit [50357] by
-
- 3 edits in trunk/WebCore
2009-10-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Make MediaPlayer constructor private
https://bugs.webkit.org/show_bug.cgi?id=30965
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::finishParsingChildren): Use MediaPlayer::create.
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::create): New.
- 2:38 PM Changeset in webkit [50356] by
-
- 3 edits2 adds in trunk
Test for MSAA: Accessibility of headings is not correct
https://bugs.webkit.org/show_bug.cgi?id=30937
Reviewed by Adam Roben.
WebKitTools:
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::role):
Allow the role returned to be a BSTR.
(AccessibilityUIElement::description):
Fix a copy/paste error.
LayoutTests:
- platform/win/accessibility/heading-elements-expected.txt: Added.
- platform/win/accessibility/heading-elements.html: Added.
- 2:38 PM Changeset in webkit [50355] by
-
- 7 edits2 adds in trunk
Test for MSAA: Accessibility of links is wrong
https://bugs.webkit.org/show_bug.cgi?id=30928
Reviewed by Darin Adler.
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(getAccessibilityValueCallback):
Return the accessibility value.
(AccessibilityUIElement::getJSClass):
Added "accessibilityValue" value.
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::accessibilityValue):
Stubbed.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::accessibilityValue):
Stubbed.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::accessibilityValue):
Get the object's value, and return it as a JS string.
LayoutTests:
- platform/win/accessibility/linked-elements-expected.txt: Added.
- platform/win/accessibility/linked-elements.html: Added.
- 2:38 PM Changeset in webkit [50354] by
-
- 7 edits in trunk
MSAA: Accessibility of headings is not correct
https://bugs.webkit.org/show_bug.cgi?id=30937
Reviewed by Alice Liu.
WebCore:
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::stringRoleForMSAA):
(WebCore::AccessibilityObject::descriptionForMSAA):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::shouldReturnTagNameAsRoleForMSAA):
If the element's tag name is one of h1, h2, h3, h4, h5, h6, return
true.
(WebCore::AccessibilityRenderObject::stringRoleForMSAA):
If the element should return its tag name as the role, return the tag
name.
(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):
If the object is a heading, return the string "L" followed by the
heading level.
(WebCore::AccessibilityRenderObject::descriptionForMSAA):
If the object has a positional description, return it. Otherwise, get
the accessibility description, and prefix it with "Description" so that
MSAA clients know that it's not a positional description.
- accessibility/AccessibilityRenderObject.h:
WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::get_accDescription):
Call the object's descriptionForMSAA(). Moved the comment to the
WebCore file.
(AccessibleBase::get_accRole):
If the object has a string role, return that. Otherwise, return the
integer role.
- AccessibleBase.h:
Removed description(), as this was moved to WebCore.
- 2:37 PM Changeset in webkit [50353] by
-
- 8 edits in trunk
MSAA: Accessibility of links is wrong
https://bugs.webkit.org/show_bug.cgi?id=30928
Reviewed by Darin Adler.
WebCore:
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::stringValueForMSAA):
Return the URL.
(WebCore::AccessibilityImageMapLink::nameForMSAA):
Return the alt text.
- accessibility/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::isLinked):
Return true.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isLinked):
(WebCore::AccessibilityObject::stringValueForMSAA):
(WebCore::AccessibilityObject::nameForMSAA):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::isLinkable):
Return true if the element is considered "linkable" with respect to
accessibility.
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
If the element is linkable, check whether it has a parent anchor
element. If so, return the anchor element's href.
(WebCore::AccessibilityRenderObject::isLinked):
Return true if the element is linkable and if it's parent anchor tag's
href is non-empty.
(WebCore::AccessibilityRenderObject::nameForMSAA):
For text nodes, return the text.
- accessibility/AccessibilityRenderObject.h:
WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::get_accState):
Check whether the element is linked, instead of whether the node is an
anchor, so the child "linkable" elements of anchor elements will also
be "linked".
(AccessibleBase::name):
Return the name for MSAA.
(AccessibleBase::value):
Return the string value for MSAA.
- 2:20 PM Changeset in webkit [50352] by
-
- 1 edit in trunk/WebKit/win/WebKitPrefix.cpp
Touch WebKitPrefix to force rebuild of WebKit.
- 1:59 PM Changeset in webkit [50351] by
-
- 24 edits in trunk
Notify the chrome when the focused node has changed.
https://bugs.webkit.org/show_bug.cgi?id=30832
Patch by Evan Stade <estade@chromium.org> on 2009-10-30
Reviewed by David Levin.
WebCore:
This is similar to AX code that is already in place, except that this also informs the
chrome when there stops being a focused node. This is needed for a browser to show the
anchor for links that have keyboard focus.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- loader/EmptyClients.h:
(WebCore::EmptyChromeClient::focusedNodeChanged):
- page/Chrome.cpp:
(WebCore::Chrome::focusedNodeChanged):
- page/Chrome.h:
- page/ChromeClient.h:
WebKit/gtk:
Added stub implementation for new ChromeClient function.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::focusedNodeChanged):
- WebCoreSupport/ChromeClientGtk.h:
WebKit/haiku:
Added stub implementation for new ChromeClient function.
- WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientHaiku::focusedNodeChanged):
- WebCoreSupport/ChromeClientHaiku.h:
WebKit/mac:
Added stub implementation for new ChromeClient function.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::focusedNodeChanged):
WebKit/qt:
Added stub implementation for new ChromeClient function.
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::focusedNodeChanged):
- WebCoreSupport/ChromeClientQt.h:
WebKit/win:
Added stub implementation for new ChromeClient function.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::focusedNodeChanged):
- WebCoreSupport/WebChromeClient.h:
WebKit/wx:
Added stub implementation for new ChromeClient function.
- WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::focusedNodeChanged):
- WebKitSupport/ChromeClientWx.h:
- 1:20 PM Changeset in webkit [50350] by
-
- 3 edits2 adds in trunk
2009-10-30 Ben Murdoch <benm@google.com>
Reviewed by David Kilzer.
openDatabase() with empty version sets db version up incorrectly
https://bugs.webkit.org/show_bug.cgi?id=28417
- storage/open-database-set-empty-version-expected.txt: Added.
- storage/open-database-set-empty-version.html: Added.
2009-10-30 Ben Murdoch <benm@google.com>
Reviewed by David Kilzer.
openDatabase() with empty version sets db version up incorrectly
https://bugs.webkit.org/show_bug.cgi?id=28417
Test: storage/open-database-set-empty-version.html
- storage/Database.cpp: (WebCore::Database::performOpenAndVerify): Raise an exception if the current database version does not match the expected version when the current version is the empty string.
- 12:52 PM Changeset in webkit [50349] by
-
- 2 edits in trunk/WebKitTools
Fix typo in command name used by wx build system.
- 12:37 PM Changeset in webkit [50348] by
-
- 8 edits in trunk/WebCore
2009-10-30 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Need to turn off notifications properly at runtime
https://bugs.webkit.org/show_bug.cgi?id=30409
Moving the notificationsEnabled bit from NotificationCenter
to the new V8 RuntimeEnabledFeatures object.
Just moving a bit around, so no new tests.
- bindings/v8/RuntimeEnabledFeatures.cpp:
- bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setNotificationsEnabled): (WebCore::RuntimeEnabledFeatures::notificationsEnabled):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
- notifications/NotificationCenter.cpp:
- notifications/NotificationCenter.h:
- 11:31 AM Changeset in webkit [50347] by
-
- 14 edits in trunk/WebCore
[V8] More cleanup after r49949: remove ListenerGuard.
ListenerGuard is no longer needed since EventListeners do not depend on frame or v8 context.
https://bugs.webkit.org/show_bug.cgi?id=30943
Reviewed by Dimitri Glazkov.
Covered by fast/events/add-event-without-document.html which will now pass in Chromium.
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::handleEvent):
- bindings/v8/V8AbstractEventListener.h:
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getEventListener):
- bindings/v8/V8EventListenerList.h:
(WebCore::V8EventListenerList::findOrCreateWrapper):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::V8LazyEventListener):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::V8Proxy):
(WebCore::V8Proxy::disconnectFrame):
(WebCore::V8Proxy::clearForNavigation):
- bindings/v8/V8Proxy.h:
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
(WebCore::V8WorkerContextEventListener::handleEvent):
(WebCore::V8WorkerContextEventListener::reportError):
- bindings/v8/V8WorkerContextEventListener.h:
(WebCore::V8WorkerContextEventListener::create):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::dispose):
(WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/custom/V8CustomEventListener.cpp:
(WebCore::V8EventListener::V8EventListener):
- bindings/v8/custom/V8CustomEventListener.h:
(WebCore::V8EventListener::create):
- 11:19 AM Changeset in webkit [50346] by
-
- 2 edits in trunk/WebKitTools
2009-10-30 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Patch v1 is a dumb default name for patches
https://bugs.webkit.org/show_bug.cgi?id=30952
Let's use "Patch" instead.
- Scripts/bugzilla-tool:
- 10:57 AM Changeset in webkit [50345] by
-
- 3 edits2 adds in trunk
2009-10-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
counterValueForElementById should return space-separated string for multiple counters
https://bugs.webkit.org/show_bug.cgi?id=30939
Test: fast/css/counters/counterValueForElementById.html
- rendering/RenderTreeAsText.cpp: (WebCore::writeCounterValuesFromChildren): (WebCore::counterValueForElement):
2009-10-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
counterValueForElementById should return space-separated string for multiple counters
https://bugs.webkit.org/show_bug.cgi?id=30939
- fast/css/counters/counterValueForElementById-expected.txt: Added.
- fast/css/counters/counterValueForElementById.html: Added.
- 10:50 AM Changeset in webkit [50344] by
-
- 4 edits in trunk/WebKit/qt
2009-10-30 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Remove the QWebInspector::windowTitleChanged signal,
QEvent::WindowTitleChange can be used to achieve the same.
https://bugs.webkit.org/show_bug.cgi?id=30927
- Api/qwebinspector.cpp:
- Api/qwebinspector.h:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::updateWindowTitle):
- 10:43 AM Changeset in webkit [50343] by
-
- 2 edits in trunk/WebCore
2009-10-30 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint): Add some comments to explain what is happening here.
- 10:35 AM Changeset in webkit [50342] by
-
- 2 edits in trunk/WebCore
2009-10-30 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Fix Web Inspector crash on the errors/warnings counter click
RenderObject::createVisiblePosition(const Position& position)
understands "null Positions", so we can construct such a Position manually.
- rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
- 10:27 AM Changeset in webkit [50341] by
-
- 2 edits in trunk/WebCore
2009-10-30 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Fix Web Inspector crash on the errors/warnings counter click
RenderObject::createVisiblePosition(const Position& position)
understands "null Positions", so we can construct such a Position manually.
- rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
- 10:26 AM Changeset in webkit [50340] by
-
- 3 edits in trunk/LayoutTests
2009-10-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Mark Rowe.
fast/css/counters/t1204* are not asynchronous anymore
https://bugs.webkit.org/show_bug.cgi?id=30940
- fast/css/counters/t1204-increment-00-c-o.html:
- fast/css/counters/t1204-increment-01-c-o.html:
- 10:19 AM Changeset in webkit [50339] by
-
- 2 edits in trunk/WebCore
2009-10-30 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25534
[GTK] Objects of ROLE_TABLE should implement the accessible table interface
Second part of the implementation of AtkTable.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (cellAtIndex): (webkit_accessible_table_get_column_at_index): (webkit_accessible_table_get_row_at_index): (webkit_accessible_table_get_caption): (atk_table_interface_init):
- 9:40 AM Changeset in webkit [50338] by
-
- 1 edit in trunk/WebCore/WebCorePrefix.cpp
Touch WebCorePrefix to try and force a clean build.
- 9:18 AM Changeset in webkit [50337] by
-
- 3 edits in trunk/WebCore
2009-10-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add TimelinePanel into the panels enum.
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):
- inspector/front-end/inspector.js: (WebInspector.showTimelinePanel):
- 8:48 AM Changeset in webkit [50336] by
-
- 2 edits in trunk/WebKitTools
Unreviewed trivial buildfix.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-30
[Qt] Buildfix for r50333.
- DumpRenderTree/qt/DumpRenderTree.pro:
- 8:00 AM Changeset in webkit [50335] by
-
- 7 edits in trunk/LayoutTests
Unreviewed layout test fixes.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
The existing excepted results were wrong, due to the visited links not
being reset between tests.
This was fixed in r50329, so updating the results.
- platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
- platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
- 7:13 AM Changeset in webkit [50334] by
-
- 1 edit9 adds in trunk/LayoutTests
[Qt] Add expected files for new svg tests we pass.
Compared to the Mac expected png files.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-30
Reviewed by Holger Hans Peter Freyther.
- platform/qt/svg/css/arrow-with-shadow-expected.txt: Added.
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
- platform/qt/svg/css/clippath-with-shadow-expected.txt: Added.
- platform/qt/svg/css/mask-with-shadow-expected.txt: Added.
- platform/qt/svg/css/path-with-shadow-expected.txt: Added.
- platform/qt/svg/css/stars-with-shadow-expected.txt: Added.
- platform/qt/svg/filters/shadow-on-filter-expected.txt: Added.
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
- 7:02 AM Changeset in webkit [50333] by
-
- 2 edits2 deletes in trunk/WebKitTools
[Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=30953
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-30
Reviewed by Holger Freyther.
DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
makes qt DRT to share this implementation (as gtk and mac ports do).
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/WorkQueue.cpp: Removed.
- DumpRenderTree/qt/WorkQueue.h: Removed.
- 6:51 AM Changeset in webkit [50332] by
-
- 2 edits in trunk/WebKitTools
Unreviewed potential buildbot fix.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
Second try: Reset page history before running each test.
Apparently the QWebHistory::clear() keeps the current page
in history which is not what we want, so we not additionally
sets the history capacity to 0 (forces removing everything)
and then sets it back to its original value.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 6:38 AM Changeset in webkit [50331] by
-
- 1 edit2 adds in trunk/LayoutTests
changelog date
- 6:29 AM Changeset in webkit [50330] by
-
- 2 edits in trunk/WebCore
If the owner widget of the page has a palette set, we
should use that one. This was only working when the
owner was a QWebView. This patch fixes that.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
Reviewed by Holger Hans Peter Freyther.
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::applyTheme):
- 6:07 AM Changeset in webkit [50329] by
-
- 2 edits in trunk/WebKitTools
Unreviewed potential buildbot fix.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
Reset page history before running each test.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 5:12 AM QtWebKitPerformanceToolBackLog: edited by
- (diff)
- 3:50 AM Changeset in webkit [50328] by
-
- 2 edits in trunk/WebCore
2009-10-30 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Wire CookieJarChromium to the cookies
backend. This is a final step of a 3-steps raw cookies
access implementation in Chromium.
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
- 3:32 AM Changeset in webkit [50327] by
-
- 7 edits in trunk/WebCore
2009-10-30 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Fix Chromium crash in console.log in "deeply recursive" function
Check that result of 'frameSourceName' is not null handle
before casting it to String.
Allow V8Proxy::sourceName/sourceLineNumber() to report
that they have failed due to JavaScript stack overflow.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::sourceLineNumber): (WebCore::V8Proxy::sourceName):
- bindings/v8/V8Proxy.h:
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- 2:27 AM Changeset in webkit [50326] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's MediaQueryExp
https://bugs.webkit.org/show_bug.cgi?id=30855
Reviewed by Darin Adler.
Inherits MediaQueryExp class from FastAllocBase because it is
instantiated by 'new' in WebCore/css/CSSParser.cpp:4874.
- css/MediaQueryExp.h:
- 1:55 AM Changeset in webkit [50325] by
-
- 1 edit1 add in trunk
2009-10-30 Adam Barth <abarth@webkit.org>
Reviewed by Mark Rowe.
Teach git to ignore some files
https://bugs.webkit.org/show_bug.cgi?id=30951
Ignore WebKitBuild because we never want to version that directory.
Also, ignore the xcode project files so git clean doesn't blow away
your project settings. Finally, ignore the compiled python files in
WebKitTools/Script modules because they clutter up git status.
- .gitignore: Added.
- 1:53 AM Changeset in webkit [50324] by
-
- 2 edits in trunk/JavaScriptCore
Allow custom memory allocation control for JavaScriptCore's ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=30853
Reviewed by Darin Adler.
Inherits ListHashSet class from FastAllocBase because it is
instantiated by 'new' in WebCore/rendering/RenderBlock.cpp:1813.
- wtf/ListHashSet.h:
- 1:13 AM Changeset in webkit [50323] by
-
- 5 edits in trunk
Regression: crash enumerating properties of an object with getters or setters
https://bugs.webkit.org/show_bug.cgi?id=30948
Reviewed by Gavin Barraclough
Add a guard to prevent us trying to cache property enumeration on
objects with getters or setters.
- 12:55 AM Changeset in webkit [50322] by
-
- 17 edits in trunk
Commit patch 1 of ruby implementation, reviewed by Eric Seidel. (see issue 28420)
- 12:24 AM Changeset in webkit [50321] by
-
- 2 edits in trunk/WebCore
Removed test for an impossible condition (a glyph in a right-to-left run not having
the RTL flag 0x800)
Reviewed by Adele Peterson.
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation):
- 12:13 AM Changeset in webkit [50320] by
-
- 2 edits in trunk/JavaScriptCore
REGRESSION (r50218-r50262): E*TRADE accounts page is missing content
https://bugs.webkit.org/show_bug.cgi?id=30947
<rdar://problem/7348833>
Reviewed by Maciej Stachowiak
The logic for flagging that a structure has non-enumerable properties
was in addPropertyWithoutTransition, rather than in the core Structure::put
method. Despite this I was unable to produce a testcase that caused
the failure that etrade was experiencing, but the new assertion in
getEnumerablePropertyNames triggers on numerous layout tests without
the fix, so in effecti all for..in enumeration in any test ends up
doing the required consistency check.
