Context Navigation

dom/Node.cpp: (WebCore::eventHasListeners): (WebCore::Node::dispatchGenericEvent):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):

7:14 PM Changeset in webkit [50399] by mitz@apple.com

2 edits in trunk/WebKit/mac

Made the full-screen video HUD respond to the up and down arrow keys by
increasing and decreasing the volume by 1/10 of the range or, when
combined with the Option key, all the way up or down.

Reviewed by Mark Rowe.

Made the volume buttons in the full-screen video HUD match the behavior
of their equivalents in the QuickTime Player HUD by turning the volume
all the way up or down.

Made the volume slider update immediately when the keyboard or volume
buttons are used to change the volume, rather than at the nearest 1/4
second interval.

Made the elapsed and remaining time displays update immediately when the
play head is dragged across the timeline, rather than at 1/4 second
intervals.

WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController keyDown:]): Handle the up and
down arrow keys.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
actions of the volume up and volume down buttons.
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]): Call
-updateTime.
(-[WebVideoFullscreenHUDWindowController setVolumeToZero:]): Added this
action for the volume down button.
(-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]): Added
this action for the volume up button.
(-[WebVideoFullscreenHUDWindowController decrementVolume]): No longer
and action method.
(-[WebVideoFullscreenHUDWindowController incrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController setVolume:]): Call
-updateVolume.

6:50 PM Changeset in webkit [50398] by rolandsteiner@chromium.org

2 edits in trunk/WebCore

No review (build fix).

Add missing files for Ruby implementation to WebCore.vcproj
(Fix build break after 50397)
https://bugs.webkit.org/show_bug.cgi?id=31001

No new tests. (No functional change)

WebCore.vcproj/WebCore.vcproj:

5:52 PM Changeset in webkit [50397] by rolandsteiner@chromium.org

12 edits
8 adds in trunk

Bug 28420 - Implement HTML5 <ruby> rendering
(https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Dave Hyatt.

First rudimentary implementation of HTML5 ruby rendering support.

WebCore:

Following the HTML 5 spec, the box object model for a <ruby> element allows several runs of ruby
bases with their respective ruby texts looks as follows:

1 RenderRuby object, corresponding to the whole <ruby> HTML element

1+ RenderRubyRun (anonymous)

0 or 1 RenderRubyText - shuffled to the front in order to re-use existing block layouting

0-n inline object(s)

0 or 1 RenderRubyBase - contains the inline objects that make up the ruby base

1-n inline object(s)

Note: <rp> elements are defined as having 'display:none' and thus normally are not assigned a renderer.

New layout tests will be committed in a follow-up patch under fast/ruby.

Makefiles, etc.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:

CSS

css/html.css: Added <ruby> and <rt>

Existing render files:

rendering/RenderBlock.cpp: make moveChild a member function moveChildTo

(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::removeChild):

rendering/RenderBlock.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject): instantiate ruby renderers based on element name

rendering/RenderObject.h: add query methods for ruby renderers

(WebCore::RenderObject::isRuby):
(WebCore::RenderObject::isRubyBase):
(WebCore::RenderObject::isRubyRun):
(WebCore::RenderObject::isRubyText):

New ruby renderers:

rendering/RenderRuby.cpp: Added.

(WebCore::lastRubyRun):
(WebCore::findRubyRunParent):
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore::RenderRubyAsInline::~RenderRubyAsInline):
(WebCore::RenderRubyAsInline::isChildAllowed):
(WebCore::RenderRubyAsInline::addChild):
(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::~RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::isChildAllowed):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::removeChild):

rendering/RenderRuby.h: Added.

(WebCore::RenderRubyAsInline::renderName):
(WebCore::RenderRubyAsInline::isRuby):
(WebCore::RenderRubyAsBlock::renderName):
(WebCore::RenderRubyAsBlock::isRuby):

rendering/RenderRubyBase.cpp: Added.

(WebCore::RenderRubyBase::RenderRubyBase):
(WebCore::RenderRubyBase::~RenderRubyBase):
(WebCore::RenderRubyBase::isChildAllowed):
(WebCore::RenderRubyBase::splitToLeft):
(WebCore::RenderRubyBase::mergeWithRight):

rendering/RenderRubyBase.h: Added.

(WebCore::RenderRubyBase::renderName):
(WebCore::RenderRubyBase::isRubyBase):

rendering/RenderRubyRun.cpp: Added.

(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::~RenderRubyRun):
(WebCore::RenderRubyRun::hasRubyText):
(WebCore::RenderRubyRun::hasRubyBase):
(WebCore::RenderRubyRun::isEmpty):
(WebCore::RenderRubyRun::rubyText):
(WebCore::RenderRubyRun::rubyBase):
(WebCore::RenderRubyRun::rubyBaseSafe):
(WebCore::RenderRubyRun::firstLineBlock):
(WebCore::RenderRubyRun::updateFirstLetter):
(WebCore::RenderRubyRun::isChildAllowed):
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):
(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):

rendering/RenderRubyRun.h: Added.

(WebCore::RenderRubyRun::renderName):
(WebCore::RenderRubyRun::isRubyRun):

rendering/RenderRubyText.cpp: Added.

(WebCore::RenderRubyText::RenderRubyText):
(WebCore::RenderRubyText::~RenderRubyText):
(WebCore::RenderRubyText::isChildAllowed):

rendering/RenderRubyText.h: Added.

(WebCore::RenderRubyText::renderName):
(WebCore::RenderRubyText::isRubyText):

LayoutTests:

Further layout tests will be committed in a follow-up patch under fast/ruby.

fast/ruby/parse-rp-expected.txt: result changed due to <rt> being rendered as block within <ruby>

5:00 PM Changeset in webkit [50396] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=30992
Node.isDefaultNamespace doesn't convert empty strings to null

Test: fast/dom/Node/default-namespace-empty-argument.html

dom/Node.cpp: (WebCore::Node::isDefaultNamespace): Per DOM 3 Core, treat empty input as null.

1:38 PM Changeset in webkit [50395] by eric@webkit.org

4 edits in trunk

2009-11-01 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Don't add '/' to the URL path if the it does not include '/' after the protocol component
https://bugs.webkit.org/show_bug.cgi?id=30971

Updating the expected result to reflect the change.

fast/loader/url-parse-1-expected.txt:

2009-11-01 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Don't add '/' to the URL path if the it does not include '/' after the protocol component
https://bugs.webkit.org/show_bug.cgi?id=30971

Match IE8 behaviour, that does not add '/' if there is none after the protocol component.

platform/KURL.cpp: (WebCore::KURL::parse):

1:30 PM Changeset in webkit [50394] by oliver@apple.com

4 edits in trunk/WebCore

Fix layering violations in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=30986

Reviewed by Darin Adler.

Remove uses of HTMLImageElement and HTMLCanvasElement

1:22 PM Changeset in webkit [50393] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-01 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=30964
[Gtk] Implemment AtkDocument

Implements what has been implemented in AT-SPI.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (GetAtkInterfaceTypeFromWAIType): (getInterfaceMaskFromObject): (atk_document_interface_init): (webkit_accessible_document_get_document_attribute_value): (webkit_accessible_document_get_document_attributes): (webkit_accessible_document_get_locale):

12:49 PM Changeset in webkit [50392] by eric@webkit.org

9 edits in trunk

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

WebKit.pri: Turn on warnings for the GCC compiler

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

No new tests as there is no functional change.

platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::RGBA32Buffer): Reorder initialization list to fix compiler warnings.

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Reorder initialization list to fix compiler warnings.
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Ditto.

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

DumpRenderTree/qt/main.cpp: (crashHandler): Mark function NO_RETURN

12:41 PM Changeset in webkit [50391] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

[Regression] monitorEvent doesn't work

inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled):

12:33 PM Changeset in webkit [50390] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix Web Inspector: Bug with Message Bubble in Syntax Highlighter
https://bugs.webkit.org/show_bug.cgi?id=30990

inspector/front-end/SourceFrame.js:

12:04 PM Changeset in webkit [50389] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=30982
createHTMLDocument doesn't escape ampersand and less-than in title

Test: fast/dom/DOMImplementation/createHTMLDocument-title.html

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument): Set document title after creating the document, avoiding parser intricacies.

8:18 AM Changeset in webkit [50388] by eric@webkit.org

4 edits
2 adds in trunk/LayoutTests

2009-11-01 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

Bug 30902: Need a layout test for Bug 28284
This change just adds a simple test that calls TextInputController.firstRectForCharacterRange()
before and after inserting a Thai character and compare their results.
https://bugs.webkit.org/show_bug.cgi?id=30902

fast/text/international/thai-cursor-position-expected.txt: Added.
fast/text/international/thai-cursor-position.html: Added.
platform/gtk/Skipped: Skip this test because TextInputController is not implemented.
platform/qt/Skipped: ditto.
platform/win/Skipped: ditto.

8:11 AM Changeset in webkit [50387] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Double clicking on a breakpoints should not select text
https://bugs.webkit.org/show_bug.cgi?id=30950

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._documentMouseDown):

8:03 AM Changeset in webkit [50386] by eric@webkit.org

3 edits
2 adds in trunk

2009-11-01 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().

[Crash (debug)] Combination of list-item and :after causes assertion failure
https://bugs.webkit.org/show_bug.cgi?id=30944

fast/css/list-item-pseudo-nocrash-expected.txt: Added.
fast/css/list-item-pseudo-nocrash.html: Added.

2009-11-01 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().

[Crash (debug)] Combination of list-item and :after causes assertion failure
https://bugs.webkit.org/show_bug.cgi?id=30944

Test: fast/css/list-item-pseudo-nocrash.html

rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):

7:54 AM Changeset in webkit [50385] by eric@webkit.org

4 edits in trunk

2009-11-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html

platform/gtk/Skipped: Unskip fixed test.

2009-11-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html

Correctly set network/ready state depending on GStreamer errors
received on the bus.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback):

7:25 AM Changeset in webkit [50384] by jberlin@webkit.org

2 edits in trunk/WebKitTools

2009-11-01 Jessie Berlin <jberlin@webkit.org>

Adding myself to the committers list.

Scripts/modules/committers.py:

Oct 31, 2009:

4:22 PM Changeset in webkit [50383] by oliver@apple.com

2 edits in trunk/WebCore

Build fix

4:10 PM Changeset in webkit [50382] by oliver@apple.com

2 edits in trunk/WebCore

Remove obsolete null checks from CanvasRenderingContext3DMac
https://bugs.webkit.org/show_bug.cgi?id=30983

Reviewed by Darin Adler

3:19 PM Changeset in webkit [50381] by oliver@apple.com

6 edits
6 adds in trunk

WebGL allows objects to be used with the wrong context
https://bugs.webkit.org/show_bug.cgi?id=30981

Reviewed by Jon Honeycutt.

Simply add null checks and a few context guards to ensure we don't
deref null or attempt to use an object from a different context.

Tests: fast/canvas/webgl/incorrect-context-object-behaviour.html

fast/canvas/webgl/null-object-behaviour.html

2:54 PM BuildingOnWindows edited by jberlin@webkit.org

(diff)

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed