⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 5, 2009:

11:28 PM Changeset in webkit [50593] by Csaba Osztrogonác
  • 3 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=31159
Fix branchDouble behaviour on ARM THUMB2 JIT.

Patch by Zoltan Herczeg <​zherczeg@inf.u-szeged.hu> on 2009-11-05
Reviewed by Gavin Barraclough.

The x86 branchDouble behaviour is reworked, and all JIT
ports should follow the x86 port. See bug 31104 and 31151

This patch contains a fix for the traditional ARM port

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::):
(JSC::ARMAssembler::fmrs_r):
(JSC::ARMAssembler::ftosid_r):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):

11:26 PM Changeset in webkit [50592] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-05 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Eric Seidel.

Fix ASSERT(currentStyle = renderStyle()).
​https://bugs.webkit.org/show_bug.cgi?id=31152

  • dom/Element.cpp: (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
10:52 PM Maintenance and architecture list edited by chris.jerdonek@gmail.com
Changeset 50583 removed the "this is part of the KDE project" code … (diff)
10:52 PM Changeset in webkit [50591] by ggaren@apple.com
  • 19 edits in trunk

Rolled out r50590 because it doesn't build on Windows.

10:26 PM Changeset in webkit [50590] by ggaren@apple.com
  • 19 edits in trunk

JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=31197
Implemented a timezone cache not based on Mac OS X's notify_check API.

Patch by Geoffrey Garen <​ggaren@apple.com> on 2009-11-05
Reviewed by Oliver Hunt.

If the VM calculates the local timezone offset from UTC, it caches the
result until the end of the current VM invocation. (We don't want to cache
forever, because the user's timezone may change over time.)

This removes notify_* overhead on Mac, and, more significantly, removes
OS time and date call overhead on non-Mac platforms.

~8% speedup on Date microbenchmark on Mac. SunSpider reports maybe a tiny
speedup on Mac. (Speedup on non-Mac platforms should be even more noticeable.)

  • interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • runtime/JSGlobalObject.h:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Made the
DynamicGlobalObjectScope constructor responsible for checking whether a
dynamicGlobalObject has already been set. This eliminated some duplicate
client code, and allowed me to avoid adding even more duplicate client
code. Made DynamicGlobalObjectScope responsible for resetting the
local timezone cache upon first entry to the VM.

  • runtime/DateConstructor.cpp:

(JSC::constructDate):
(JSC::callDate):
(JSC::dateParse):
(JSC::dateUTC):

  • runtime/DateConversion.cpp:

(JSC::parseDate):

  • runtime/DateConversion.h:
  • runtime/DateInstance.cpp:

(JSC::DateInstance::gregorianDateTime):

  • runtime/DateInstance.h:
  • runtime/DateInstanceCache.h:
  • runtime/DatePrototype.cpp:

(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:
  • wtf/DateMath.cpp:

(WTF::getCurrentUTCTime):
(WTF::getCurrentUTCTimeWithMicroseconds):
(WTF::getLocalTime):
(JSC::getUTCOffset): Use the new cache. Also, see below.
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::initializeDates):
(JSC::parseDateFromNullTerminatedCharacters): Simplified the way this function
accounts for the local timezone offset, to accomodate our new caching API,
and a (possibly misguided) caller in WebCore. Also, see below.

  • wtf/DateMath.h:

(JSC::GregorianDateTime::GregorianDateTime): Moved most of the code in
DateMath.* into the JSC namespace. The code needed to move so it could
naturally interact with ExecState and JSGlobalData to support caching.
Logically, it seemed right to move it, too, since this code is not really
as low-level as the WTF namespace might imply -- it implements a set of
date parsing and conversion quirks that are finely tuned to the JavaScript
language. Also removed the Mac OS X notify_* infrastructure.

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=31197
Implemented a timezone cache not based on Mac OS X's notify_check API.

Patch by Geoffrey Garen <​ggaren@apple.com> on 2009-11-05
Updated for JavaScriptCore internal API change.

  • platform/network/HTTPParsers.cpp:

(WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
(This function probably shouldn't be using a JavaScript date parser
to begin with, but oh well.)

10:25 PM Changeset in webkit [50589] by dbates@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2009-11-05 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31193

Removed obsolete test case which was included in the patch for bug #30107.
This test case is already covered by the test case fast/events/drag-and-drop.html,
which was included in the patch for bug #24731.

  • fast/events/drag-and-drop-none-expected.txt: Removed.
  • fast/events/drag-and-drop-none.html: Removed.
  • platform/win/Skipped: Removed entry for drag-and-drop-none.html.
10:19 PM Changeset in webkit [50588] by hclam@chromium.org
  • 4 edits in trunk/WebCore

Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.

Patch by Alpha Lam <​hclam@chromium.org> on 2009-11-05

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::gcEpilogue):

  • bindings/v8/V8GCController.h:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluate):
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):

10:05 PM Changeset in webkit [50587] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

2009-11-05 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Cross-domain access to stylesheet text should not be allowed
​https://bugs.webkit.org/show_bug.cgi?id=20527

Test that a script cannot read cross-origin cssRules.

  • http/tests/security/cannot-read-cssrules-expected.txt: Added.
  • http/tests/security/cannot-read-cssrules-redirect-expected.txt: Added.
  • http/tests/security/cannot-read-cssrules-redirect.html: Added.
  • http/tests/security/cannot-read-cssrules.html: Added.

2009-11-05 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Cross-domain access to stylesheet text should not be allowed
​https://bugs.webkit.org/show_bug.cgi?id=20527

Check whether whether the current document can read the cssRules from
the style sheet. Firefox throws a security error here, but we return
null instead because that's what we usually do in these cases.

Test: http/tests/security/cannot-read-cssrules-redirect.html

http/tests/security/cannot-read-cssrules.html

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):
7:27 PM Changeset in webkit [50586] by jparent@chromium.org
  • 1 edit in trunk/WebCore/WebCore.gyp

Rubber stamped by Mark Rowe.

Adds some GYP generated files to svn:ignore
​https://bugs.webkit.org/show_bug.cgi?id=31194

*.vcproj
*.rules
*.mk
*.scons
SConstruct

6:46 PM Changeset in webkit [50585] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-05 Steve Block <​steveblock@google.com>

Reviewed by Eric Seidel.

If the Geolocation service fails to start, invoke the error callback asynchronously.
​https://bugs.webkit.org/show_bug.cgi?id=28276

All Geolocation callbacks must be invoked asynchronously.
See ​http://www.w3.org/TR/geolocation-API/#geolocation_interface

No new tests possible with current LayoutTestController.

  • page/Geolocation.cpp: (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier. (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier. (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
4:05 PM Changeset in webkit [50584] by alice.liu@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Adding a resource that seems to be missing. Without it, several tests in
fast/dom/beforeload aren't really testing if the default event handling is
prevented, but instead are only testing if the beforeload event fires.

Rubber-stamped by Gavin Barraclough.

  • fast/dom/beforeload/resources/fail.js: Added.
3:53 PM Changeset in webkit [50583] by eric@webkit.org
  • 253 edits in trunk

2009-11-05 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Removed the "this is part of the KDE project" comments from
all *.h, *.cpp, *.idl, and *.pm files.

​https://bugs.webkit.org/show_bug.cgi?id=31167

The maintenance and architecture page in the project wiki lists
this as a task.

This change includes no changes or additions to test cases
since the change affects only comments.

  • wtf/wince/FastMallocWince.h:

2009-11-05 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Removed the "this is part of the KDE project" comments from
all *.h, *.cpp, *.idl, and *.pm files.

​https://bugs.webkit.org/show_bug.cgi?id=31167

The maintenance and architecture page in the project wiki lists
this as a task.

This change includes no changes or additions to test cases
since the change affects only comments.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/IDLParser.pm:
  • bindings/scripts/IDLStructure.pm:
  • css/CSSInheritedValue.cpp:
  • css/CSSInitialValue.cpp:
  • css/CSSMediaRule.cpp:
  • css/CSSNamespace.h:
  • css/CSSProperty.cpp:
  • css/CSSProperty.h:
  • css/CSSRuleList.cpp:
  • css/CSSRuleList.h:
  • css/CSSSelector.h:
  • css/CSSValueList.cpp:
  • css/FontValue.cpp:
  • css/MediaFeatureNames.cpp:
  • css/MediaFeatureNames.h:
  • css/Pair.h:
  • css/SVGCSSStyleSelector.cpp:
  • css/ShadowValue.cpp:
  • css/StyleSheet.cpp:
  • css/StyleSheetList.cpp:
  • css/maketokenizer:
  • dom/BeforeUnloadEvent.cpp:
  • dom/BeforeUnloadEvent.h:
  • dom/CSSMappedAttributeDeclaration.cpp:
  • dom/EventNames.cpp:
  • dom/EventTarget.cpp:
  • dom/MappedAttributeEntry.h:
  • dom/MouseRelatedEvent.h:
  • dom/RangeException.h:
  • dom/StyleElement.h:
  • dom/Tokenizer.h:
  • html/HTMLHeadElement.h:
  • html/HTMLHeadingElement.cpp:
  • html/HTMLHeadingElement.h:
  • html/HTMLHtmlElement.h:
  • html/HTMLImageLoader.h:
  • html/HTMLMetaElement.h:
  • html/HTMLModElement.cpp:
  • html/HTMLModElement.h:
  • html/HTMLOptionsCollection.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPreElement.cpp:
  • html/HTMLPreElement.h:
  • html/HTMLTableCellElement.cpp:
  • html/HTMLTableCellElement.h:
  • html/HTMLTableColElement.cpp:
  • html/HTMLTableColElement.h:
  • html/HTMLTablePartElement.cpp:
  • html/HTMLTablePartElement.h:
  • html/HTMLTitleElement.h:
  • page/MouseEventWithHitTestResults.h:
  • platform/StaticConstructors.h:
  • platform/text/AtomicStringImpl.h:
  • platform/text/qt/TextBreakIteratorQt.cpp:
  • rendering/AutoTableLayout.h:
  • rendering/CounterNode.cpp:
  • rendering/EllipsisBox.cpp:
  • rendering/EllipsisBox.h:
  • rendering/FixedTableLayout.cpp:
  • rendering/FixedTableLayout.h:
  • rendering/HitTestRequest.h:
  • rendering/HitTestResult.h:
  • rendering/InlineRunBox.h:
  • rendering/PointerEventsHitRules.cpp:
  • rendering/PointerEventsHitRules.h:
  • rendering/RenderBR.cpp:
  • rendering/RenderBR.h:
  • rendering/RenderButton.cpp:
  • rendering/RenderButton.h:
  • rendering/RenderFieldset.cpp:
  • rendering/RenderFrameSet.cpp:
  • rendering/RenderListItem.cpp:
  • rendering/RenderTableRow.cpp:
  • rendering/RenderView.h:
  • rendering/RootInlineBox.h:
  • rendering/SVGInlineTextBox.cpp:
  • rendering/SVGInlineTextBox.h:
  • rendering/TableLayout.h:
  • rendering/break_lines.h:
  • rendering/style/SVGRenderStyle.cpp:
  • rendering/style/SVGRenderStyle.h:
  • rendering/style/SVGRenderStyleDefs.cpp:
  • rendering/style/SVGRenderStyleDefs.h:
  • svg/GradientAttributes.h:
  • svg/LinearGradientAttributes.h:
  • svg/PatternAttributes.h:
  • svg/RadialGradientAttributes.h:
  • svg/SVGAElement.cpp:
  • svg/SVGAngle.idl:
  • svg/SVGAnimateColorElement.cpp:
  • svg/SVGAnimateColorElement.h:
  • svg/SVGAnimateElement.cpp:
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimatedPathData.cpp:
  • svg/SVGAnimatedPathData.h:
  • svg/SVGAnimatedPoints.cpp:
  • svg/SVGAnimatedPoints.h:
  • svg/SVGAnimationElement.cpp:
  • svg/SVGCircleElement.cpp:
  • svg/SVGClipPathElement.cpp:
  • svg/SVGColor.cpp:
  • svg/SVGColor.idl:
  • svg/SVGComponentTransferFunctionElement.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGCursorElement.cpp:
  • svg/SVGDefsElement.cpp:
  • svg/SVGDescElement.cpp:
  • svg/SVGDescElement.h:
  • svg/SVGDocument.idl:
  • svg/SVGElement.idl:
  • svg/SVGElementInstanceList.cpp:
  • svg/SVGElementInstanceList.h:
  • svg/SVGEllipseElement.cpp:
  • svg/SVGExternalResourcesRequired.cpp:
  • svg/SVGFEBlendElement.cpp:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp:
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEFloodElement.cpp:
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFuncAElement.cpp:
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncBElement.cpp:
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncGElement.cpp:
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncRElement.cpp:
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEGaussianBlurElement.cpp:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp:
  • svg/SVGFEMergeElement.cpp:
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeNodeElement.cpp:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFETileElement.cpp:
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp:
  • svg/SVGGElement.cpp:
  • svg/SVGGradientElement.cpp:
  • svg/SVGHKernElement.idl:
  • svg/SVGLangSpace.cpp:
  • svg/SVGLangSpace.h:
  • svg/SVGLength.cpp:
  • svg/SVGLength.h:
  • svg/SVGLength.idl:
  • svg/SVGLengthList.cpp:
  • svg/SVGLengthList.h:
  • svg/SVGLineElement.cpp:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGList.h:
  • svg/SVGListTraits.h:
  • svg/SVGLocatable.h:
  • svg/SVGMaskElement.cpp:
  • svg/SVGMatrix.idl:
  • svg/SVGMetadataElement.cpp:
  • svg/SVGMetadataElement.h:
  • svg/SVGMetadataElement.idl:
  • svg/SVGNumber.idl:
  • svg/SVGNumberList.cpp:
  • svg/SVGNumberList.h:
  • svg/SVGPaint.cpp:
  • svg/SVGPathElement.cpp:
  • svg/SVGPathSeg.h:
  • svg/SVGPathSegArc.cpp:
  • svg/SVGPathSegArc.h:
  • svg/SVGPathSegClosePath.cpp:
  • svg/SVGPathSegClosePath.h:
  • svg/SVGPathSegCurvetoCubic.cpp:
  • svg/SVGPathSegCurvetoCubic.h:
  • svg/SVGPathSegCurvetoCubicSmooth.cpp:
  • svg/SVGPathSegCurvetoCubicSmooth.h:
  • svg/SVGPathSegCurvetoQuadratic.cpp:
  • svg/SVGPathSegCurvetoQuadratic.h:
  • svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
  • svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • svg/SVGPathSegLineto.cpp:
  • svg/SVGPathSegLineto.h:
  • svg/SVGPathSegLinetoHorizontal.cpp:
  • svg/SVGPathSegLinetoHorizontal.h:
  • svg/SVGPathSegLinetoVertical.cpp:
  • svg/SVGPathSegLinetoVertical.h:
  • svg/SVGPathSegMoveto.cpp:
  • svg/SVGPathSegMoveto.h:
  • svg/SVGPatternElement.cpp:
  • svg/SVGPoint.idl:
  • svg/SVGPointList.cpp:
  • svg/SVGPointList.h:
  • svg/SVGPolyElement.cpp:
  • svg/SVGPolygonElement.cpp:
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.cpp:
  • svg/SVGPolylineElement.h:
  • svg/SVGPreserveAspectRatio.cpp:
  • svg/SVGPreserveAspectRatio.h:
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRect.idl:
  • svg/SVGRectElement.cpp:
  • svg/SVGRenderingIntent.h:
  • svg/SVGSVGElement.idl:
  • svg/SVGScriptElement.cpp:
  • svg/SVGSetElement.cpp:
  • svg/SVGSetElement.h:
  • svg/SVGStopElement.cpp:
  • svg/SVGStringList.cpp:
  • svg/SVGStringList.h:
  • svg/SVGStylable.cpp:
  • svg/SVGStylable.h:
  • svg/SVGStyleElement.cpp:
  • svg/SVGStyleElement.h:
  • svg/SVGStyledElement.h:
  • svg/SVGStyledLocatableElement.cpp:
  • svg/SVGStyledLocatableElement.h:
  • svg/SVGStyledTransformableElement.cpp:
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGSwitchElement.cpp:
  • svg/SVGSymbolElement.cpp:
  • svg/SVGTRefElement.cpp:
  • svg/SVGTSpanElement.cpp:
  • svg/SVGTSpanElement.h:
  • svg/SVGTests.h:
  • svg/SVGTextElement.cpp:
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.cpp:
  • svg/SVGTextPositioningElement.cpp:
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTitleElement.cpp:
  • svg/SVGTitleElement.h:
  • svg/SVGTransform.cpp:
  • svg/SVGTransform.h:
  • svg/SVGTransform.idl:
  • svg/SVGTransformList.cpp:
  • svg/SVGTransformList.h:
  • svg/SVGTransformable.h:
  • svg/SVGURIReference.h:
  • svg/SVGUnitTypes.h:
  • svg/SVGUseElement.cpp:
  • svg/SVGViewElement.cpp:
  • svg/SVGZoomAndPan.cpp:
  • svg/SVGZoomAndPan.h:
  • svg/SVGZoomEvent.cpp:
3:28 PM Changeset in webkit [50582] by pfeldman@chromium.org
  • 17 edits
    3 moves
    5 adds
    2 deletes in trunk/LayoutTests

2009-11-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: beautify layout tests.

​https://bugs.webkit.org/show_bug.cgi?id=31189

  • inspector/console-dir-expected.txt:
  • inspector/console-dir.html:
  • inspector/console-dirxml-expected.txt:
  • inspector/console-dirxml.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-collections.html:
  • inspector/console-format-expected.txt:
  • inspector/console-format.html:
  • inspector/console-tests-expected.txt:
  • inspector/console-tests.html:
  • inspector/console-tests.js: Added. (dumpConsoleMessages.callback): (dumpConsoleMessages): (dumpConsoleMessagesWithClasses.callback): (dumpConsoleMessagesWithClasses): (frontendScript_dumpConsoleMessages):
  • inspector/css-syntax-highlight.html: Removed.
  • inspector/elements-panel-structure-expected.txt:
  • inspector/elements-panel-structure.html:
  • inspector/elements-tests.js: Added. (frontendScript_expandDOMSubtree.processChildren): (frontendScript_expandDOMSubtree):
  • inspector/evaluate-in-frontend.html:
  • inspector/evaluate-in-frontend.js: Removed.
  • inspector/inspector-test.js: Added. (): (evaluateInWebInspector): (notifyDone): (output): (window.didEvaluateForTestInFrontend):
  • inspector/javascript-syntax-highlight.html: Removed.
  • inspector/styles-iframe.html:
  • inspector/syntax-highlight-css-expected.txt: Renamed from LayoutTests/inspector/css-syntax-highlight-expected.txt.
  • inspector/syntax-highlight-css.html: Added.
  • inspector/syntax-highlight-javascript-expected.txt: Renamed from LayoutTests/inspector/javascript-syntax-highlight-expected.txt.
  • inspector/syntax-highlight-javascript.html: Added.
  • inspector/syntax-highlight.js: Added. (doit.callback): (doit): (frontendScript_dumpSyntaxHighlight):
  • inspector/timeline-trivial.html:
  • platform/qt/Skipped:
3:25 PM Changeset in webkit [50581] by jorlow@chromium.org
  • 5 edits in trunk/WebCore

2009-11-05 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

REGRESSION Clean up security origin usage in DOM Storage.
​https://bugs.webkit.org/show_bug.cgi?id=31188

Clean up security origin usage in DOM Storage. This fixes a bug in my
refactoring here: ​https://bugs.webkit.org/show_bug.cgi?id=31149

Instead of having StorageAreaSync's constructor (which is called in the
constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
database identifier, simply have StorageAreaImpl pass the identifier into
StorageAreaSync.

No test because there's no change in externally observable behavior.

  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::StorageAreaImpl):
  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::create): (WebCore::StorageAreaSync::StorageAreaSync):
  • storage/StorageAreaSync.h:
3:08 PM Changeset in webkit [50580] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-05 Scott Violet <​sky@google.com>

Reviewed by Dimitri Glazkov.

Need notification of scrolling frame
​https://bugs.webkit.org/show_bug.cgi?id=31145

Adds FrameLoaderClient::didChangeScrollOffset that is called when
the frame scrolls. This will be used to know when history state
needs to be updated.

  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::didChangeScrollOffset):
  • page/FrameView.cpp: (WebCore::FrameView::valueChanged):
2:46 PM Changeset in webkit [50579] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-11-05 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Adele Peterson.

The number of selected lines in textarea after a shift-PageDown
may differ. The test case is modified so that it will not depend
on the exact number of lines selected. This should resolve regression
on platforms like Qt and GTK.
​https://bugs.webkit.org/show_bug.cgi?id=31122

  • editing/selection/shrink-selection-after-shift-pagedown.html:
2:17 PM Changeset in webkit [50578] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-11-05 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

[V8] Update bindings to use new API for external arrays
​https://bugs.webkit.org/show_bug.cgi?id=31181

No new tests; covered by existing WebGL tests.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray): (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object):
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/custom/V8CanvasArrayCustom.h: (WebCore::constructCanvasArray):
1:59 PM Changeset in webkit [50577] by hclam@chromium.org
  • 3 edits in trunk/WebCore

Not reviewed, Chromium build fix.

Patch by Alpha Lam <​hclam@chromium.org> on 2009-11-05
50561 introduces a custom method for SVGMatrix, we need to implement
this in V8.

  • bindings/v8/custom/V8CustomBinding.h:

Adding definition for V8SVGMatrixMultiply.

  • bindings/v8/custom/V8SVGMatrixCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):
Implement V8SVGMatrixMultiply according to the same method in JSC.

1:09 PM Changeset in webkit [50576] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2009-11-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: empty line in expectations build fix.

  • fast/events/event-listener-map-rehash-crash-expected.txt:
12:42 PM Changeset in webkit [50575] by jorlow@chromium.org
  • 4 edits in trunk/WebCore

Revert 50569 since it broke QT. Build fix and just a revert, so no review.

Patch by Jeremy Orlow <​jorlow@chromium.org> on 2009-11-05

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::sessionStorage):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageEnabled):

  • page/Settings.h:

(WebCore::Settings::sessionStorageEnabled):

12:13 PM Changeset in webkit [50574] by pfeldman@chromium.org
  • 16 edits
    4 adds in trunk

2009-11-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

REGRESSION: Web Inspector doesn't show CSS rules properly for iframes

​https://bugs.webkit.org/show_bug.cgi?id=30884

Test: inspector/styles-iframe.html

  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
  • inspector/front-end/InjectedScript.js: (InjectedScript.getStyles): (InjectedScript.getComputedStyle): (InjectedScript.addStyleSelector):
  • inspector/front-end/TestController.js: (WebInspector.TestController.prototype.notifyDone): (WebInspector.TestController.prototype.runAfterPendingDispatches): (WebInspector.evaluateForTestInFrontend.invokeMethod): (WebInspector.evaluateForTestInFrontend):
12:09 PM Changeset in webkit [50573] by Dimitri Glazkov
  • 6 edits
    2 adds in trunk

WebCore:

2009-11-05 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Geoffrey Garen and Dimitri Glazkov.

Rehashing of EventListenerMap leads to loss of EvenListenerList.
​https://bugs.webkit.org/show_bug.cgi?id=31027

Tested by new fast/events/event-listener-map-rehash-crash.html.

EventListenerMap modified to store pointers to listener vectors:

  • dom/EventTarget.cpp: (WebCore::EventTargetData::~EventTargetData): (WebCore::EventTarget::addEventListener): (WebCore::EventTarget::removeEventListener): (WebCore::EventTarget::fireEventListeners): (WebCore::EventTarget::getEventListeners): (WebCore::EventTarget::removeAllEventListeners):
  • dom/EventTarget.h:

Usages updated after interface changes:

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::transferEventListenersToShadowTree):

LayoutTests:

2009-11-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Geoffrey Garen.

Rehashing of EventListenerMap leads to loss of EvenListenerList.
​https://bugs.webkit.org/show_bug.cgi?id=31027

  • fast/events/event-listener-map-rehash-crash.html: Added.
12:05 PM Changeset in webkit [50572] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Add ruby tests and failing accessibility test to Windows Skipped list,
we should be able to re-add ruby tests, but not sure the correct course
of action yet.

  • platform/win/Skipped:
11:57 AM Changeset in webkit [50571] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-05 Dan Kegel <​dank@chromium.org>

Reviewed by Dmitri Titov.

Add missing initialization for m_createdByParser.
​https://bugs.webkit.org/show_bug.cgi?id=31089

Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction):
11:33 AM Changeset in webkit [50570] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-04 Eric Seidel <​eric@webkit.org>

No review, just add a line which got left out of the patch uploaded for commit.

commit-queue is crashing when trying to reject patches after unknown failures
​https://bugs.webkit.org/show_bug.cgi?id=31091

  • Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
11:27 AM Changeset in webkit [50569] by jorlow@chromium.org
  • 4 edits in trunk/WebCore

2009-11-04 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Adam Barth.

DOM Storage runtime flag changes
​https://bugs.webkit.org/show_bug.cgi?id=30602

Part 2/2.

Revert my changes to Settings and instead implement DOM Storage enabling via
the methods agreed upon in ​https://bugs.webkit.org/show_bug.cgi?id=30240

This stuff was (intentionally) never exposed to web pages or DRT, so there's no
LayoutTest visible changes and thus no tests.

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage):
  • page/DOMWindow.idl:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:
  • storage/Storage.cpp: (WebCore::Storage::setLocalStorageAvailable): (WebCore::Storage::localStorageAvailable): (WebCore::Storage::setSessionStorageAvailable): (WebCore::Storage::sessionStorageAvailable):
  • storage/Storage.h:
10:33 AM Changeset in webkit [50568] by jianli@chromium.org
  • 3 edits in trunk/WebCore

Bug 31108 - [V8] REGRESSION: Pause on exception is broken
​https://bugs.webkit.org/show_bug.cgi?id=31108

Reviewed by Pavel Feldman.

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):

  • bindings/v8/V8Utilities.cpp:

(WebCore::reportException):

10:14 AM Changeset in webkit [50567] by Adam Roben
  • 10 edits in trunk/WebKit/win

Make CFDictionaryPropertyBag::createInstance return a COMPtr

I also cleaned up CFDictionaryPropertyBag's class declaration a little
while I was at it.

Part of <​http://webkit.org/b/25294> <rdar://problem/6803127> All
WebKit/win classes should return COMPtrs from their static constructor
members

Reviewed by Steve Falkenburg.

  • CFDictionaryPropertyBag.cpp:

(CFDictionaryPropertyBag::CFDictionaryPropertyBag): Changed to
initialize m_refCount to 0. m_refCount gets increased to 1 by
createInstance.
(CFDictionaryPropertyBag::createInstance): Changed to return a COMPtr.

  • CFDictionaryPropertyBag.h:
    • Updated copyright years
    • Fixed header guard to match current style
    • Replaced #include of CoreFoundation.h with forward-declaration of CFMutableDictionaryRef
    • Added #include of COMPtr.h
    • Fixed opening brace placement in class declaration
    • Made createInstance return a COMPtr
    • Made constructor/destructor private
    • Made QueryInterface and IPropertyBag functions private
    • Removed unnecessary parameter names and MIDL comments
  • WebCache.cpp:

(WebCache::statistics): Updated for change to
CFDictionaryPropertyBag::createInstance. Now uses releaseRef to place
the IPropertyBag pointers into the s array.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidFailToStartPlugin):

  • WebDatabaseManager.cpp:

(WebDatabaseManager::dispatchDidModifyDatabase):

  • WebFrame.cpp:

(WebFrame::createJavaAppletWidget):
Updated for change to CFDictionaryPropertyBag::createInstance.

  • WebHistory.cpp: Removed releaseUserInfo, which is no longer needed.

That function was also doing an unnecessary call to setDictionary(0).
(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
Changed to return COMPtr.

(WebHistory::loadFromURL): Updated for change to
CFDictionaryPropertyBag::createInstance.

(WebHistory::removeAllItems): Updated for change to
CFDictionaryPropertyBag::createInstance, which fixed a leak! We had
forgotten to call releaseUserInfo here.

(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):

  • WebIconDatabase.cpp:

(postDidAddIconNotification):
Updated for change to CFDictionaryPropertyBag::createInstance.

  • WebKitClassFactory.cpp:

(releaseRefFromCreateInstance): Added this overloaded function
template to abstract away the difference between createInstance
functions that return a ref'd pointer and createInstance functions
that return a COMPtr.
(WebKitClassFactory::CreateInstance): Changed to use
releaseRefFromCreateInstance.

9:59 AM Changeset in webkit [50566] by jianli@chromium.org
  • 4 edits
    2 adds in trunk

WebCore: We should not bubble up events if we drag something to an iframe that
has an invalid source.
​https://bugs.webkit.org/show_bug.cgi?id=30469

Reviewed by Dmitri Titov.

Test: http/tests/misc/bubble-drag-events.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleDragAndDropForTarget):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):

  • page/EventHandler.h:

(WebCore::EventHandler::):

LayoutTests: Tests the drag event bubbling on different targets:

  • iframe with invalid source
  • iframe with valid source
  • non-iframe droppable element

​https://bugs.webkit.org/show_bug.cgi?id=30469

Reviewed by Dmitri Titov.

  • http/tests/misc/bubble-drag-events-expected.txt: Added.
  • http/tests/misc/bubble-drag-events.html: Added.
8:42 AM Changeset in webkit [50565] by Adam Roben
  • 2 edits in trunk/WebKitTools

Remove bogus else clause in bugzilla-tool

Fixes <​http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
create-bug raises exception after entering bug description

Reviewed by David Kilzer.

  • Scripts/bugzilla-tool:

(CreateBug): else clauses are only hit if no exception is raised, so
it makes no sense to try to re-raise the exception in an else clause.
The exception will automatically be re-raised if it doesn't match any
of the except clauses, so we don't have to do anything special here at
all to get the desired behavior.

7:58 AM Changeset in webkit [50564] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: speed up Timelines Clear by a factor of thousands.

​https://bugs.webkit.org/show_bug.cgi?id=31160

  • inspector/front-end/utilities.js: (Element.prototype.removeChildren):
7:48 AM Changeset in webkit [50563] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-11-05 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Tor Arne Vestbø.

Add support for Shift-PageUp and Shift-PageDown key events.
​https://bugs.webkit.org/show_bug.cgi?id=31166

Test: LayoutTests/editing/selection/shrink-selection-after-shift-pagedown.html

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
7:36 AM Changeset in webkit [50562] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-11-05 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

If high memory usage is detected, hint to V8 that it might be due
to external objects retained by V8 objects.
​https://bugs.webkit.org/show_bug.cgi?id=31051

  • bindings/v8/V8GCController.cpp: (WebCore::GetMemoryUsageInMB): (WebCore::V8GCController::gcEpilogue): (WebCore::V8GCController::checkMemoryUsage):
  • bindings/v8/V8GCController.h:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction):
7:28 AM Changeset in webkit [50561] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2009-11-05 Jeff Schiller <​codedread@gmail.com>

Reviewed by Simon Fraser.

Added test to ensure proper order of matrix multiplication with SVGMatrix.
​https://bugs.webkit.org/show_bug.cgi?id=16062

  • svg/dom/SVGMatrix-interface-expected.txt: Added.
  • svg/dom/SVGMatrix-interface.xhtml: Added.

2009-11-05 Jeff Schiller <​codedread@gmail.com>

Reviewed by Simon Fraser.

Correct order of matrix multiplication for SVGMatrix.
​https://bugs.webkit.org/show_bug.cgi?id=16062

Test: svg/dom/SVGMatrix-interface.xhtml

  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply):
  • svg/SVGMatrix.idl:
2:06 AM Changeset in webkit [50560] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-11-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Make resource-related records in timeline
actually take some time.

​https://bugs.webkit.org/show_bug.cgi?id=31139

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset):
1:51 AM Changeset in webkit [50559] by eric@webkit.org
  • 2 edits in trunk

2009-11-05 Priit Laes <​plaes@plaes.org>

Reviewed by Jan Alonzo.

[Gtk] Build failure with --enable-introspection
​https://bugs.webkit.org/show_bug.cgi?id=31102

Add search and include paths for JSCore-1.0.gir required by
gobject-introspection tools.

  • GNUmakefile.am:
1:31 AM Changeset in webkit [50558] by jorlow@chromium.org
  • 6 edits in trunk/WebCore

2009-11-04 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Simplify LocalStorageThread
​https://bugs.webkit.org/show_bug.cgi?id=30935

This is a re-submit of 50519. LocalStorageTask should have never been ref
counted. I've removed that and switched a PassRefPtr over to a PassOwnPtr.

On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
of the method names a bit more clear. Assert proper thread usage. Join rather
than detaching the thread and doing an ad-hoc form of join. Avoid touching
variables on the background thread when simple to do so. Also create a generic
scheduleTask function rather than one for each task.

No behavior should have changed.

  • storage/LocalStorageTask.h:
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::create): (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::~LocalStorageThread): (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::threadEntryPointCallback): (WebCore::LocalStorageThread::threadEntryPoint): (WebCore::LocalStorageThread::scheduleTask): (WebCore::LocalStorageThread::terminate): (WebCore::LocalStorageThread::performTerminate):
  • storage/LocalStorageThread.h:
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::~StorageSyncManager): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
  • storage/StorageSyncManager.h:
12:58 AM Changeset in webkit [50557] by jorlow@chromium.org
  • 5 edits in trunk/WebCore

2009-11-04 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Calling databaseIdentifier on LocalStorage's background thread is not safe.
​https://bugs.webkit.org/show_bug.cgi?id=31149

Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
is not safe. databaseIdentifier does a bunch of string concatenation which
ref-counts StringImpls in some cases. This was caught by valgrind thread
sanitizer: ​http://code.google.com/p/chromium/issues/detail?id=25645

There's no way to test for such racyness, unfortunately.

  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::performImport):
  • storage/StorageAreaSync.h:
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::fullDatabaseFilename):
  • storage/StorageSyncManager.h:
12:40 AM Changeset in webkit [50556] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Last Qt 4.5 build fix (*sigh*)

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-05

  • tests/qwebpage/tst_qwebpage.cpp:

(inputMethodHints): inputMethodHints() is only used for
Qt 4.6, so guard the whole function.

12:36 AM Changeset in webkit [50555] by jorlow@chromium.org
  • 4 edits in trunk/WebCore

2009-11-03 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Clean up StorageAreaSync
​https://bugs.webkit.org/show_bug.cgi?id=31100

Major fixes: Break the ref count cycle for StorageArea on the main
thread, not the background thread since the latter is not safe.
Length() needs to block on the import completing.

Small fixes: setItem needs to handle the copy on write case even if it
has an exception. setItem and removeItem should just bail from the
the function if the value hasn't changed rather than wrapping the end
in an if block. Clear should only send an event if it wasn't already
cleared. StorageAreaSync should assert that the final sync was
scheduled.

  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::length): Forgot to block on the import. (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::setItem): Handle the copy on write case even when there's an exception. (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear):
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::~StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::performImport): (WebCore::StorageAreaSync::markImported): (WebCore::StorageAreaSync::blockUntilImportComplete):
  • storage/StorageAreaSync.h:
12:34 AM Web Inspector edited by rik@webkit.org
Adding latest blog post (diff)
12:30 AM Changeset in webkit [50554] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Another prospective build fix against Qt 4.5 (build bot)

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-05
Don't compile & run the QGraphicsWebView portion of the
input methods auto test with Qt 4.5.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::inputMethods_data):
(inputMethodHints):
(inputMethodEnabled):
(tst_QWebPage::inputMethods):

12:28 AM Changeset in webkit [50553] by zoltan@webkit.org
  • 3 edits in trunk/JavaScriptCore

Use ARMv7 specific encoding for immediate constants on ARMv7 target
​https://bugs.webkit.org/show_bug.cgi?id=31060

Patch by Gabor Loki <​loki@inf.u-szeged.hu> on 2009-11-05
Reviewed by Gavin Barraclough.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::getOp2): Use INVALID_IMM
(JSC::ARMAssembler::getImm): Use encodeComplexImm for complex immediate
(JSC::ARMAssembler::moveImm): Ditto.
(JSC::ARMAssembler::encodeComplexImm): Encode a constant by one or two
instructions or a PC relative load.

  • assembler/ARMAssembler.h: Use INVALID_IMM if a constant cannot be

encoded as an immediate constant.
(JSC::ARMAssembler::):
(JSC::ARMAssembler::movw_r): 16-bit immediate load
(JSC::ARMAssembler::movt_r): High halfword 16-bit immediate load
(JSC::ARMAssembler::getImm16Op2): Encode immediate constant for
movw_r and mowt_r

12:23 AM Changeset in webkit [50552] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Prospective build fix against Qt 4.5 (build bot)

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-05

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::setInputMethodEnabled): Guard the
use of Qt 4.6 specific API with #ifdefs.

12:12 AM Changeset in webkit [50551] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

[Qt] Fix enabling of input method support on QGraphicsWebView.
​https://bugs.webkit.org/show_bug.cgi?id=30605

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-01
Reviewed by Kenneth Christiansen.

Instead of setting the unsupported widget attribute on the
QGraphicsWidget in setInputMethodEnabled() set the
ItemAcceptsInputMethod GraphicsItem flag directly.

Changed the existing input method auto test to run once
on a QWebView and once on a QGraphicsWebView.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::setInputMethodEnabled):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::inputMethods_data):
(inputMethodHints):
(inputMethodEnabled):
(tst_QWebPage::inputMethods):

12:11 AM Changeset in webkit [50550] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Added QGraphicsWebView::modified property, for consistency
with QWebView.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Kenneth Christiansen.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::isModified):

  • Api/qgraphicswebview.h:
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::qgraphicswebview):

12:11 AM Changeset in webkit [50549] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Removed status and progress properties of QGraphicsWebView.
Added loadProgress and statusBarMessage signals instead,
after API review.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Kenneth Christiansen.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
(QGraphicsWebView::setPage):

  • Api/qgraphicswebview.h:
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::qgraphicswebview):

Nov 4, 2009:

11:53 PM Changeset in webkit [50548] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CachedResource
​https://bugs.webkit.org/show_bug.cgi?id=31114

Reviewed by Eric Seidel.

Inherits CachedResource class from Noncopyable because its (its child
class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75
and it is no need to be copyable.

  • loader/CachedResource.h:
11:07 PM Changeset in webkit [50547] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-11-04 Eric Seidel <​eric@webkit.org>

Reviewed by David Kilzer.

svn-apply's fixChangeLogPatch function seems broken
​https://bugs.webkit.org/show_bug.cgi?id=30683

Update fixChangeLogPatch to be able to handle patches which
don't start at line 1.
Add unit tests for svn-apply to scm_unittest.py.

  • Scripts/VCSUtils.pm:
  • Scripts/modules/scm_unittest.py:
10:52 PM Changeset in webkit [50546] by eric@webkit.org
  • 4 edits in trunk

2009-11-04 Mark Mentovai <​mark@chromium.org>

Reviewed by Mark Rowe.

Provide TARGETING_TIGER and TARGETING_LEOPARD as analogues to
BUILDING_ON_TIGER and BUILDING_ON_LEOPARD. The TARGETING_ macros
consider the deployment target; the BUILDING_ON_ macros consider the
headers being built against.

  • wtf/Platform.h:

2009-11-04 Mark Mentovai <​mark@chromium.org>

Reviewed by Mark Rowe.

Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
which is true when targeting 10.6 or later.

HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
is present in the CGInterpolationQuality enum, and must be handled
by a switch that has cases for each enumerated value.

USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
on 10.6 or later, and that CoreGraphics will understand when
InterpolationMedium is mapped to kCGInterpolationMedium at runtime.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
10:39 PM Changeset in webkit [50545] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Dan Kegel <​dank@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
​https://bugs.webkit.org/show_bug.cgi?id=31138

Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind

  • page/Page.cpp: (WebCore::Page::userStyleSheetLocationChanged):
10:27 PM Changeset in webkit [50544] by timothy@apple.com
  • 3 edits in trunk/WebCore

Update the Web Inspector Timeline panel to better match the mock-up.

​https://bugs.webkit.org/show_bug.cgi?id=31150

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._getRecordDetails):
(WebInspector.TimelinePanel.prototype._dragWindow):
(WebInspector.TimelinePanel.prototype._resizeWindowLeft):
(WebInspector.TimelinePanel.prototype._resizeWindowRight):
(WebInspector.TimelineCategoryTreeElement.prototype.onattach):
(WebInspector.TimelineRecordTreeElement.prototype.onattach):
(WebInspector.TimelineRecordTreeElement.prototype.refresh):
(WebInspector.TimelineCategoryGraph):

  • inspector/front-end/inspector.css:
9:33 PM Changeset in webkit [50543] by justin.garcia@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed typos.

9:25 PM Changeset in webkit [50542] by justin.garcia@apple.com
  • 6 edits
    6 adds in trunk

WebCore:

2009-11-02 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=25439
Deleting when in front of a block image removes character from previous paragraph

Added editing/deleting/25439-{1,2,3}.html

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot be made inline with other content. Instead of merging, just move the caret to just before the selection we deleted.
  • editing/htmlediting.cpp: (WebCore::firstInSpecialElement): Added a FIXME. This function begins iterating up from pos.node(), which doesn't necessarily contain pos (suppose pos was [img, 0]). (WebCore::lastInSpecialElement): Ditto. (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp. Added a check for non-inline images.
  • editing/htmlediting.h:
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Use moved/renamed function. Removed FIXME. The problem causing 5027702 is now squarely in first/lastInSpecialElement (WebCore::endOfParagraph): Ditto.

LayoutTests:

2009-11-03 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=25439
Deleting when in front of a block image removes character from previous paragraph

  • editing/deleting/delete-before-block-image-1-expected.txt: Added.
  • editing/deleting/delete-before-block-image-1.html: Added.
  • editing/deleting/delete-before-block-image-2-expected.txt: Added.
  • editing/deleting/delete-before-block-image-2.html: Added.
  • editing/deleting/delete-before-block-table-expected.txt: Added.
  • editing/deleting/delete-before-block-table.html: Added.
9:02 PM Changeset in webkit [50541] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=31151
Fix branchDouble behaviour on ARM THUMB2 JIT.

Patch by Gavin Barraclough <​barraclough@apple.com> on 2009-11-04
Reviewed by Oliver Hunt.

The ARMv7 JIT is currently using ARMv7Assembler::ConditionEQ to branch
for DoubleEqualOrUnordered, however this is incorrect – ConditionEQ won't
branch on unordered operands. Similarly, DoubleLessThanOrUnordered &
DoubleLessThanOrEqualOrUnordered use ARMv7Assembler::ConditionLO &
ARMv7Assembler::ConditionLS, whereas they should be using
ARMv7Assembler::ConditionLT & ARMv7Assembler::ConditionLE.

Fix these, and fill out the missing DoubleConditions.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::):
(JSC::MacroAssemblerARMv7::branchDouble):

7:29 PM Changeset in webkit [50540] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Rubber Stamped by Oliver Hunt.

Patch by Gavin Barraclough <​barraclough@apple.com> on 2009-11-04
Enable native call optimizations on ARMv7. (Existing ARM_TRADITIONAL
implementation was generic, worked perfectly, just needed turning on).

  • jit/JITOpcodes.cpp:
  • wtf/Platform.h:
7:04 PM Changeset in webkit [50539] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Rubber Stamped by Mark Rowe, Oliver Hunt, and Sam Weinig.

Patch by Gavin Barraclough <​barraclough@apple.com> on 2009-11-04
Add a missing assert to the ARMv7 JIT.

  • assembler/ARMv7Assembler.h:

(JSC::ARMThumbImmediate::ARMThumbImmediate):

6:22 PM Changeset in webkit [50538] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove bogus op_ prefix on dumped version of three opcodes.

Rubber-stamped by Oliver Hunt.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

6:22 PM Changeset in webkit [50537] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix dumping of constants in bytecode so that they aren't printed as large positive register numbers.

Reviewed by Sam Weinig.

We do this by having the registerName function return information about the constant if the register
number corresponds to a constant. This requires that registerName, and several functions that call it,
be converted to member functions of CodeBlock so that the constant value can be retrieved. The
ExecState also needs to be threaded down through these functions so that it can be passed on to
constantName when needed.

  • bytecode/CodeBlock.cpp:

(JSC::constantName):
(JSC::CodeBlock::registerName):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::dump):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::isConstantRegisterIndex):

5:42 PM Changeset in webkit [50536] by enrica@apple.com
  • 4 edits
    2 adds in trunk

WebCore: Hang in Mail on attempting to change indent level.
<rdar://problem/7131805>
​https://bugs.webkit.org/show_bug.cgi?id=31127

Reviewed by Adele Peterson.

The hang was caused by an infinite loop inside outdentRegion.
The code did not account for the fact that, when a list item
cointains multiple paragraphs, outdent moves all paragraphs at
once, invalidating some of the position we keep track of in the loop.
Some code refactoring has also been done to minimize duplicate code.

Test: editing/execCommand/outdent-multiparagraph-list.html

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
outdentRegion to doApply.
(WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
(WebCore::IndentOutdentCommand::doApply): Some code refactoring.

  • editing/IndentOutdentCommand.h: Added VisiblePosition parameters to

indentRegion and outdentRegion.

LayoutTests: Hang in Mail on attempting to change indent level
<rdar://problem/7131805>
​https://bugs.webkit.org/show_bug.cgi?id=31127

Reviewed by Adele Peterson.

Added test to cover all the different code paths.

  • editing/execCommand/outdent-multiparagraph-list-expected.txt: Added.
  • editing/execCommand/outdent-multiparagraph-list.html: Added.
4:50 PM Changeset in webkit [50535] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Alpha Lam <​hclam@chromium.org>

Reviewed by Eric Carlson.

Volume slider doesn't have a thumb
​https://bugs.webkit.org/show_bug.cgi?id=31135

Fixed an incorrect if statement that prevents volume slider
being updated.

The statement checks if the slider value equals to the current
volume value of the media control to avoid updating the volume
slider. Updating the volume slider control shouldn't be within
this condition because we explicitly set them to be equals
during creation of the controls and also when mouse events are
received on the volume control.

No new tests because existing code breaks:
LayoutTests/media/video-volume-slider.html

It should now start passing on Chromium.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::update): Update the volume slider regardless of the current volume value of the media control.
4:35 PM Changeset in webkit [50534] by levin@chromium.org
  • 6 edits in trunk/WebCore

Need to properly disable applicationCache at runtime
​https://bugs.webkit.org/show_bug.cgi?id=30417

Patch by Jenn Braithwaite <​jennb@chromium.org> on 2009-11-04
Reviewed by David Levin.

Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.

No new exposed functionality, so no new tests.

  • bindings/v8/RuntimeEnabledFeatures.cpp:
  • bindings/v8/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::ACCESSOR_RUNTIME_ENABLER):

  • page/DOMWindow.idl:
4:12 PM Changeset in webkit [50533] by ap@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-11-04 Pavel Heimlich <​tropikhajma@gmail.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=30647
Solaris build failure due to strnstr.

  • wtf/StringExtras.h: Enable strnstr on Solaris, too.
3:59 PM Changeset in webkit [50532] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

2009-11-04 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=30266


Changed data format type from "text" to "text/plain" to pass Chrome tests.

  • fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt:
  • fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
3:59 PM Changeset in webkit [50531] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=31104
Refactor x86-specific behaviour out of the JIT.

Patch by Gavin Barraclough <​barraclough@apple.com> on 2009-11-04
Reviewed by Oliver Hunt.

  • Add explicit double branch conditions for ordered and unordered comparisons (presently the brehaviour is a mix).
  • Refactor double to int conversion out into the MacroAssembler.
  • Remove broken double to int conversion for !JSVALUE32_64 builds - this code was broken and slowing us down, fixing it showed it not to be an improvement.
  • Remove exclusion of double to int conversion from (1 % X) cases in JSVALUE32_64 builds - if this was of benefit this is no longer the case; simplify.
  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::):
(JSC::MacroAssemblerX86Common::convertInt32ToDouble):
(JSC::MacroAssemblerX86Common::branchDouble):
(JSC::MacroAssemblerX86Common::branchConvertDoubleToInt32):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_jfalse):

3:48 PM Changeset in webkit [50530] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=31143
Assertion failure in CredentialStorage::set() when proxy credentials are being set

No test, cannot test proxy behavior.

  • platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Account for the possibility of null url. Release mode changes are likely inconsequential - e.g. we used to add ":" to origin set, which is weird, but safe.
2:21 PM Changeset in webkit [50529] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Patrick Mueller <​Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Web Inspector: Leftover Breakpoints in the Sidebar Pane
​https://bugs.webkit.org/show_bug.cgi?id=30659

No new tests.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.addScript):
1:44 PM Changeset in webkit [50528] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-11-04 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Timothy Hatcher.

WebInspector: Use a different method to identify the webkit port in
InspectorBackent::platform().
This corrects the inspector expected behavior with Qt on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=31116

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::platform): (WebCore::InspectorBackend::port):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/front-end/InspectorControllerStub.js: (.WebInspector.InspectorControllerStub.prototype.port):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.toolbarDragStart):
1:00 PM Changeset in webkit [50527] by eric@webkit.org
  • 7 edits in trunk

2009-11-04 Benjamin Otte <​otte@gnome.org>

Reviewed by Gustavo Noronha.

Update Cairo requirement to 1.6.

​https://bugs.webkit.org/show_bug.cgi?id=19266

  • configure.ac:

2009-11-04 Benjamin Otte <​otte@gnome.org>

Reviewed by Gustavo Noronha.

Update Cairo requirement to 1.6.

Also remove all conditional code and workarounds for older versions of
Cairo.
In particular, gain image quality by removing the use of
CAIRO_FILTER_NEAREST when rendering images and use the default
bilinear filter instead.
​https://bugs.webkit.org/show_bug.cgi?id=19266

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipOut):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): (WebCore::BitmapImage::drawPattern):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::isEmpty): (WebCore::Path::boundingRect):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozWidget):
12:46 PM Changeset in webkit [50526] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Restore removed string conversion after cleanup.

12:22 PM Changeset in webkit [50525] by eric@webkit.org
  • 15 edits
    2 adds in trunk

2009-11-04 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Need to implement ARIA role="combobox"
​https://bugs.webkit.org/show_bug.cgi?id=31096

  • accessibility/aria-combobox.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/accessibility/aria-combobox-expected.txt: Added.
  • platform/win/Skipped:

2009-11-04 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Need to implement ARIA role="combobox"
​https://bugs.webkit.org/show_bug.cgi?id=31096

Test: accessibility/aria-combobox.html

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::isComboBox): (WebCore::AccessibilityObject::isExpanded): (WebCore::AccessibilityObject::expandObject): (WebCore::AccessibilityObject::increment): (WebCore::AccessibilityObject::decrement):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::expandObject): (WebCore::AccessibilityRenderObject::isExpanded): (WebCore::createARIARoleMap):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
  • html/HTMLAttributeNames.in:

2009-11-04 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Need to implement ARIA role="combobox"
​https://bugs.webkit.org/show_bug.cgi?id=31096

  • DumpRenderTree/AccessibilityUIElement.cpp: (showMenuCallback): (getIsExpandedCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu):
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu):
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isSelected): (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu):
12:12 PM Changeset in webkit [50524] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-11-04 Kelly Norton <​knorton@google.com>

Reviewed by Pavel Feldman.

Fixes naming inconsistencies in TimelineRecordFactory.
​https://bugs.webkit.org/show_bug.cgi?id=31132

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createXHRReadyStateChangeRecord): (WebCore::TimelineRecordFactory::createXHRLoadRecord): (WebCore::TimelineRecordFactory::createEvaluateScriptRecord): (WebCore::TimelineRecordFactory::createMarkTimelineRecord): (WebCore::TimelineRecordFactory::createResourceSendRequestRecord): (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord): (WebCore::TimelineRecordFactory::createResourceFinishRecord): (WebCore::TimelineRecordFactory::createPaintRecord):
  • inspector/TimelineRecordFactory.h:
12:04 PM Changeset in webkit [50523] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-11-04 Eric Z. Ayers <​zundel@google.com>

Reviewed by Pavel Feldman.

Followon to bug 31080, which protects Timeline
instrumentation in the case where InspectorTimelineAgent
is enabled or disabled during an event dispatch.

​https://bugs.webkit.org/show_bug.cgi?id=31121

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate):
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::inspectorTimelineAgent): (WebCore::DOMWindow::dispatchEvent):
  • page/DOMWindow.h:
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
11:55 AM Changeset in webkit [50522] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Fix an assert on shutdown when wxWebView has captured the mouse,
and make sure wxWebView's right click handling is only active when
the WebCore popup menu is used.

​https://bugs.webkit.org/show_bug.cgi?id=31131

11:35 AM Changeset in webkit [50521] by jorlow@chromium.org
  • 5 edits in trunk/WebCore

Revert 50519 while I work out what went wrong.

Patch by Jeremy Orlow <​jorlow@chromium.org> on 2009-11-04

  • storage/LocalStorageThread.cpp:

(WebCore::LocalStorageThread::create):
(WebCore::LocalStorageThread::LocalStorageThread):
(WebCore::LocalStorageThread::start):
(WebCore::LocalStorageThread::localStorageThreadStart):
(WebCore::LocalStorageThread::localStorageThread):
(WebCore::LocalStorageThread::scheduleImport):
(WebCore::LocalStorageThread::scheduleSync):
(WebCore::LocalStorageThread::terminate):
(WebCore::LocalStorageThread::performTerminate):

  • storage/LocalStorageThread.h:
  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::StorageSyncManager):
(WebCore::StorageSyncManager::~StorageSyncManager):
(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):

  • storage/StorageSyncManager.h:
11:32 AM Changeset in webkit [50520] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-11-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add basic support for resource events and marks.
Couple of drive-by fixes. Enabling the panel!

​https://bugs.webkit.org/show_bug.cgi?id=31130

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClicked): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
11:11 AM Changeset in webkit [50519] by jorlow@chromium.org
  • 5 edits in trunk/WebCore

2009-11-03 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Simplify LocalStorageThread
​https://bugs.webkit.org/show_bug.cgi?id=30935

On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
of the method names a bit more clear. Assert proper thread usage. Join rather
than detaching the thread and doing an ad-hoc form of join. Avoid touching
variables on the background thread when simple to do so. Also create a generic
scheduleTask function rather than one for each task.

No behavior should have changed.

  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::create): (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::~LocalStorageThread): (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::threadEntryPointCallback): (WebCore::LocalStorageThread::threadEntryPoint): (WebCore::LocalStorageThread::scheduleTask): (WebCore::LocalStorageThread::terminate): (WebCore::LocalStorageThread::performTerminate):
  • storage/LocalStorageThread.h:
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::~StorageSyncManager): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
  • storage/StorageSyncManager.h:
10:28 AM Changeset in webkit [50518] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue is crashing when trying to reject patches after unknown failures
​https://bugs.webkit.org/show_bug.cgi?id=31091

  • Scripts/bugzilla-tool:
    • patchid was a copy/paste mistake. This code has no 'patch' variable so we have to find out what the current patch is by asking bugzilla again.
    • Discovered that this code was also leaking file descriptors, so fixed that.
10:21 AM Changeset in webkit [50517] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-11-04 Mark Mentovai <​mark@chromium.org>

Reviewed by Eric Seidel.

Remove BUILDING_ON_LEOPARD from JavaScriptCore.gyp. This is supposed
to be set as needed only in wtf/Platform.h.

10:13 AM Changeset in webkit [50516] by eric@webkit.org
  • 4 edits in trunk

2009-11-04 Vadim Zeitlin <​vadim@wxwidgets.org>

Reviewed by Eric Seidel.

[wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.

  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash):

2009-11-04 Vadim Zeitlin <​vadim@wxwidgets.org>

Reviewed by Eric Seidel.

[wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.

  • WebFrame.cpp: (wxWebFrame::SetPageSource): (wxWebFrame::LoadURL):
9:17 AM Changeset in webkit [50515] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-11-04 Kelly Norton <​knorton@google.com>

Reviewed by Pavel Feldman.

Adds lightweight network resources to InspectorTimelineAgent.
​https://bugs.webkit.org/show_bug.cgi?id=31065

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createResourceSendRequestTimelineRecord): (WebCore::TimelineRecordFactory::createResourceReceiveResponseTimelineRecord): (WebCore::TimelineRecordFactory::createResourceFinishTimelineRecord):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
9:08 AM Changeset in webkit [50514] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] ASSERT failure when receiving 401 HTTP Authentication response.
​https://bugs.webkit.org/show_bug.cgi?id=31077

Allow sending the response body under the same conditions that we
allow it to finish without reporting an error.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
8:58 AM Changeset in webkit [50513] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make run-webkit-tests work for the Debug_Internal Windows configuration

In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
suffix.

Fixes <​http://webkit.org/b/31123>.

Reviewed by Sam Weinig.

  • Scripts/run-webkit-tests: Don't add the _debug suffix in

Debug_Internal, either.

8:13 AM Changeset in webkit [50512] by Adam Roben
  • 2 edits in trunk/WebCore

Sort WebCore.base.exp

Rubber-stamped by Dan Bernstein.

  • WebCore.base.exp: Sorted.
4:12 AM Changeset in webkit [50511] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Put test into skiplist added in r50489 because
layoutTestController.showWebInspector() is unimplemented now.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-04

  • platform/qt/Skipped: inspector/timeline-trivial.html added.
3:27 AM Changeset in webkit [50510] by Csaba Osztrogonác
  • 6 edits
    1 add
    3 deletes in trunk

Unreviewed rollout.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-04
Revert r50496 because it broke all layout tests on QtBuildBot.

WebCore:

  • WebCore.pro:
  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::fontCache):
(WebCore::FontCache::FontCache):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
(WebCore::FontPlatformDataCacheKey::):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::FontPlatformDataCacheKey::hash):
(WebCore::FontPlatformDataCacheKey::computeHash):
(WebCore::FontPlatformDataCacheKey::hashTableDeletedSize):
(WebCore::FontPlatformDataCacheKeyHash::hash):
(WebCore::FontPlatformDataCacheKeyHash::equal):
(WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
(WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue):
(WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::addClient):
(WebCore::FontCache::removeClient):
(WebCore::FontCache::invalidate):

  • platform/graphics/qt/FontFallbackListQt.cpp: Added.

(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):
(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::determinePitch):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::fontDataForCharacters):
(WebCore::FontFallbackList::setPlatformFont):

  • platform/graphics/qt/FontPlatformData.h:

(WebCore::FontPlatformData::pixelSize):

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):

LayoutTests:

  • svg/text/resources: Removed.
  • svg/text/resources/text-font-invalid.svg: Removed.
  • svg/text/text-font-invalid-expected.txt: Removed.
  • svg/text/text-font-invalid.html: Removed.
2:35 AM Changeset in webkit [50509] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=31044
[Gtk] assertion when webkit_accessible_get_index_in_parent attempts to get parent of the web view

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkParentOfWebView): (webkit_accessible_get_index_in_parent): (webkit_accessible_get_parent):
2:28 AM Changeset in webkit [50508] by eric@webkit.org
  • 5 edits
    2 adds in trunk/WebCore

2009-11-04 Dominik Röttsches <​dominik.roettsches@access-company.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=15914
[GTK] Implement Unicode functionality using GLib

Initial version of this patch by Jürg Billeter and Naiem Shaik.
Patch 2/4 - Moving TextCodecs to GLib

Added probing for a hard-coded lists of text encodings.
The basis of this list is taken from the encodings supported by iconv,
then extended by e.g. tis-620, windows-1251, euc-kr, windows-1253 and
a number of Chinese ones.

Probing is necessary with the current design of text codecs
as iconv/GLib do not support enumerating available encodings.

  • GNUmakefile.am:
  • platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): (WebCore::ThreadGlobalData::~ThreadGlobalData):
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
  • platform/text/gtk/TextCodecGtk.cpp: Added. (WebCore::): (WebCore::newTextCodecGtk): (WebCore::TextCodecGtk::isEncodingAvailable): (WebCore::TextCodecGtk::registerEncodingNames): (WebCore::TextCodecGtk::registerCodecs): (WebCore::TextCodecGtk::registerBaseEncodingNames): (WebCore::TextCodecGtk::registerBaseCodecs): (WebCore::TextCodecGtk::registerExtendedEncodingNames): (WebCore::TextCodecGtk::registerExtendedCodecs): (WebCore::TextCodecGtk::TextCodecGtk): (WebCore::TextCodecGtk::~TextCodecGtk): (WebCore::TextCodecGtk::releaseIConv): (WebCore::TextCodecGtk::createIConvDecoder): (WebCore::TextCodecGtk::createIConvEncoder): (WebCore::TextCodecGtk::decode): (WebCore::TextCodecGtk::encode):
  • platform/text/gtk/TextCodecGtk.h: Added.
2:19 AM Changeset in webkit [50507] by eric@webkit.org
  • 9 edits in trunk

2009-11-04 Martin Robinson <​martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Unify redudant methods which will always return the same value.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection):
  • platform/gtk/PasteboardHelper.h:

2009-11-04 Martin Robinson <​martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Move handling of target list to PasteboardHelperGtk.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::PasteboardHelperGtk): (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk): (WebKit::PasteboardHelperGtk::fullTargetList):
  • WebCoreSupport/PasteboardHelperGtk.h:
  • webkit/webkitprivate.cpp: (WebKit::pasteboardHelperInstance): (webkit_init):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_init): (webkit_web_view_get_copy_target_list): (webkit_web_view_get_paste_target_list):
1:31 AM Changeset in webkit [50506] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=31035
[GTK] some accessibility tests hitting assertion in debug builds

Removes the assertions in webkit_accessible_ref_child; adds sanity checks.
Any app or AT can attempt to ref a child at a bogus index.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_ref_child):
1:15 AM Changeset in webkit [50505] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-11-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

committers.py needs a way to store non-bugzilla email addresses
​https://bugs.webkit.org/show_bug.cgi?id=31037

Make Committer and Reviewer constructors take a single email or a list of emails.
Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
Expose reviewers(), used by validate-committer-lists on bug 30970.

  • Scripts/modules/committers.py:
  • Scripts/modules/committers_unittest.py: Added tests for the new code.
12:58 AM Changeset in webkit [50504] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Benjamin Otte <​otte@gnome.org>

Reviewed by Jan Alonzo.

[gtk] Use gst_element_class_set_details_simple()

Cosmetic change, just code simplification

  • platform/graphics/gtk/VideoSinkGStreamer.cpp:
12:50 AM Changeset in webkit [50503] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-11-04 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

[Qt] REGRESSION: Allow applications to use their own QWidget bypassing QWebView.
​https://bugs.webkit.org/show_bug.cgi?id=30979

Decouple QWebViewPrivate from QWebPageClient, and automatically create
QWebPageWidgetClient whenever the view is QWidget based.

  • Api/qwebpage.cpp: (QWebPageWidgetClient::QWebPageWidgetClient): (QWebPageWidgetClient::scroll): (QWebPageWidgetClient::update): (QWebPageWidgetClient::setInputMethodEnabled): (QWebPageWidgetClient::setInputMethodHint): (QWebPageWidgetClient::cursor): (QWebPageWidgetClient::updateCursor): (QWebPageWidgetClient::palette): (QWebPageWidgetClient::screenNumber): (QWebPageWidgetClient::ownerWidget): (QWebPageWidgetClient::pluginParent): (QWebPage::setView):
  • Api/qwebview.cpp: (QWebView::~QWebView): (QWebView::setPage): (QWebView::event):
12:42 AM Changeset in webkit [50502] by eric@webkit.org
  • 6 edits in trunk/WebCore

2009-11-04 Kelly Norton <​knorton@google.com>

Reviewed by Timothy Hatcher.

Adds paint rectangle information to TimelineAgent's didPaint callback.
​https://bugs.webkit.org/show_bug.cgi?id=31087

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willPaint):
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createPaintTimelineRecord):
  • inspector/TimelineRecordFactory.h:
  • page/FrameView.cpp: (WebCore::FrameView::paintContents):
12:33 AM Changeset in webkit [50501] by eric@webkit.org
  • 12 edits in trunk

2009-11-04 Jaime Yap <​jaimeyap@google.com>

Reviewed by Timothy Hatcher.

This patch adds API to the console object for annotating the
inspector timeline. This allows developers to mark logical
checkpoints in their apps and have them overlaid in the event
record tree.

tests updated: LayoutTests/fast/dom/Window/window-properties.html
​https://bugs.webkit.org/show_bug.cgi?id=31082

  • inspector/InspectorController.cpp: (WebCore::InspectorController::markTimeline):
  • inspector/InspectorController.h:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didMarkTimeline):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • page/Console.cpp: (WebCore::Console::markTimeline):
  • page/Console.h:
  • page/Console.idl:
Note: See TracTimeline for information about the timeline view.