⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 14, 2009:

12:55 PM Changeset in webkit [50998] by adele@apple.com
  • 11 edits
    5 adds in trunk

WebCore: Fix for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp

Reviewed by Dan Bernstein.

Test: fast/overflow/line-clamp.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):

Use the line count value if available. Otherwise, convert the percentage to the line count, as we did before. Also,
if there is anchor as the last child box, still allow adding the ellipsis.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
(WebCore::RenderLayer::scrollRectToVisible): ditto.

  • WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
  • rendering/style/LineClampValue.h: Added.

(WebCore::LineClampValue::LineClampValue):
(WebCore::LineClampValue::value):
(WebCore::LineClampValue::isPercentage):
(WebCore::LineClampValue::isNone):
(WebCore::LineClampValue::operator==):
(WebCore::LineClampValue::operator!=):

  • rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.
  • rendering/style/RenderStyle.h: Use LineClampValue.

(WebCore::InheritedFlags::lineClamp):
(WebCore::InheritedFlags::setLineClamp):
(WebCore::InheritedFlags::initialLineClamp):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests: Test for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp

Reviewed by Dan Bernstein.

  • fast/overflow/line-clamp.html: Added.
  • platform/mac/fast/overflow/line-clamp-expected.checksum: Added.
  • platform/mac/fast/overflow/line-clamp-expected.png: Added.
  • platform/mac/fast/overflow/line-clamp-expected.txt: Added.
12:24 PM QtBackLog edited by zecke@selfish.org
Mention individual commits (diff)
9:53 AM Changeset in webkit [50997] by eric.carlson@apple.com
  • 8 edits in trunk

2009-11-14 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/7287487>
Do not use QuickTime version to detect media controller theme

  • WebCore.base.exp: Export wkMediaControllerThemeAvailable
  • platform/mac/WebCoreSystemInterface.h: Ditto.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.

2009-11-14 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/7287487>
Do not use QuickTime version to detect media controller theme

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize wkMediaControllerThemeAvailable.
7:21 AM Changeset in webkit [50996] by tkent@chromium.org
  • 4 edits
    3 adds in trunk

2009-11-14 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Add tests for reading/writing .type property of HTMLInputElement.
​https://bugs.webkit.org/show_bug.cgi?id=29004

  • fast/forms/input-type-change3-expected.txt: Added.
  • fast/forms/input-type-change3.html: Added.
  • fast/forms/script-tests/input-type-change3.js: Added.

2009-11-14 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

  • Recognizes date/datetime/datetime-local/month/time/week types of INPUT element. They have no dedicated UI and no type validation for now.
  • Clean up setInputType() and formControlType() of HTMLInputElement. ​https://bugs.webkit.org/show_bug.cgi?id=29004

Test: fast/forms/input-type-change3.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): (WebCore::HTMLInputElement::patternMismatch): (WebCore::HTMLInputElement::tooLong): (WebCore::createTypeMap): Initializer for a static local variable. (WebCore::HTMLInputElement::setInputType): (WebCore::createFormControlTypes): Initializer for a static local variable. (WebCore::HTMLInputElement::formControlType): (WebCore::HTMLInputElement::saveFormControlState): (WebCore::HTMLInputElement::restoreFormControlState): (WebCore::HTMLInputElement::accessKeyAction): (WebCore::HTMLInputElement::rendererIsNeeded): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::isTextField): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::isRequiredFormControl): (WebCore::HTMLInputElement::dataList):
  • html/HTMLInputElement.h: Add new values to InputType enum, and define numberOfTypes.
6:08 AM Changeset in webkit [50995] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip new test that needs new DRT infrastructure, with bug filled.

Nov 13, 2009:

10:24 PM Changeset in webkit [50994] by Chris Fleizach
  • 5 edits
    2 adds in trunk

WAI-ARIA: checkbox does not determine its label from text content
​https://bugs.webkit.org/show_bug.cgi?id=31456

Reviewed by Darin Adler.

WebCore:

Test: accessibility/aria-checkbox-text.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::title):

LayoutTests:

  • accessibility/aria-checkbox-text.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/accessibility/aria-checkbox-text-expected.txt: Added.
  • platform/win/Skipped:
8:54 PM Changeset in webkit [50993] by Dimitri Glazkov
  • 7 edits in trunk

WebCore:

2009-11-13 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Fix build to catch up with ​http://trac.webkit.org/changeset/50973.
This is just enough changes to unbreak the port.

  • bindings/v8/ScriptController.cpp: (WebCore::mainThreadNormalWorld):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::initContextIfNeeded):
  • loader/FrameLoaderClient.h:

WebKit/chromium:

2009-11-13 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Rename windowObjectCleared to dispatchDidClearWindowObjectInWorld
to catch up ​http://trac.webkit.org/changeset/50973.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld):
  • src/FrameLoaderClientImpl.h:
7:34 PM Changeset in webkit [50992] by aa@chromium.org
  • 2 edits in trunk/WebCore

2009-11-13 Aaron Boodman <​aa@chromium.org>

Unreviewed fix for Chromium build.

  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchDidClearWindowObjectInWorld): Provide an empty implementation of this method because I don't know what it is supposed to do on Chromium.
7:11 PM Changeset in webkit [50991] by aa@chromium.org
  • 2 edits in trunk/WebCore

2009-11-13 Aaron Boodman <​aa@chromium.org>

Unreviewed fix for Chromium build.

  • loader/FrameLoader.h: Make dispatchDidClearWindowObjectsInAllWorlds() public, as Chromium's V8Proxy calls it.
6:58 PM Changeset in webkit [50990] by aa@chromium.org
  • 2 edits in trunk/WebCore

2009-11-13 Aaron Boodman <​aa@chromium.org>

Unreviewed fix to Chromium build.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::getAllWorlds):
6:45 PM Changeset in webkit [50989] by aa@chromium.org
  • 2 edits in trunk/WebCore

2009-11-13 Aaron Boodman <​aa@chromium.org>

Unreviewed fix for Chromium build.

  • platform/text/TextBoundaries.cpp: Use longer path to refer to Unicode.h.
6:29 PM Changeset in webkit [50988] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2009-11-13 Adam Barth <​abarth@webkit.org>

Unreviewed partial build fix for Chromium. Should fix failure #4.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::getAllWorlds):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::initContextIfNeeded):
6:18 PM Changeset in webkit [50987] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-11-13 Adam Barth <​abarth@webkit.org>

Unreviewed partial build fix for Chromium.

  • bindings/v8/ScriptController.h: (WebCore::ScriptController::getAllWorlds):
5:47 PM Changeset in webkit [50986] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Disable websocket tests on Tiger, as they time out.

Filed <​https://bugs.webkit.org/show_bug.cgi?id=31501> to investigate this issue.

  • platform/mac-tiger/Skipped:
5:40 PM Changeset in webkit [50985] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-11-13 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium WebKit Port to compile as dynamic lib

​https://bugs.webkit.org/show_bug.cgi?id=31478

  • WebKit.gyp:
5:33 PM Changeset in webkit [50984] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix after r50923 change to externalRepresentation.

5:22 PM Changeset in webkit [50983] by aa@chromium.org
  • 4 edits in trunk/WebKit/chromium

woo

5:07 PM Changeset in webkit [50982] by zoltan@webkit.org
  • 3 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=31050

Patch by Zoltan Herczeg <​zherczeg@inf.u-szeged.hu> on 2009-11-13
Reviewed by Gavin Barraclough.

Adding optimization support for mode JSVALUE32_64
on ARM systems.

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):

4:44 PM Changeset in webkit [50981] by zoltan@webkit.org
  • 8 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=31050

Patch by Zoltan Herczeg <​zherczeg@inf.u-szeged.hu> on 2009-11-14
Reviewed by Gavin Barraclough.

Adding JSVALUE32_64 support for ARM (but not turning it
on by default). All optimizations must be disabled, since
this patch is only the first of a series of patches.

During the work, a lot of x86 specific code revealed and
made platform independent.
See revisions: 50531 50541 50593 50594 50595

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::):
(JSC::ARMAssembler::fdivd_r):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::neg32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::branchOr32):
(JSC::MacroAssemblerARM::set8):
(JSC::MacroAssemblerARM::setTest8):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::zeroDouble):

  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITStubs.cpp:
  • wtf/StdLibExtras.h:
4:39 PM Changeset in webkit [50980] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-13 Eric Seidel <​eric@webkit.org>

No review, build fix only.

Fix Windows and Chromium builds after ​http://trac.webkit.org/changeset/50977.

Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
​https://bugs.webkit.org/show_bug.cgi?id=31468

  • WebCore.gypi: Rename TextBoundariesICU -> TextBoundaries
  • WebCore.vcproj/WebCore.vcproj: Rename TextBoundariesICU -> TextBoundaries
4:27 PM Changeset in webkit [50979] by jorlow@chromium.org
  • 5 edits in trunk

2009-11-12 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dmitry Titov.

LocalStorage quota should include key sizes in its count
​https://bugs.webkit.org/show_bug.cgi?id=31451

  • storage/StorageMap.cpp: (WebCore::StorageMap::setItem):

Count keys in the quota when adding a new item.

(WebCore::StorageMap::removeItem):

Remove the key's length from the quota if we're removing the item.

(WebCore::StorageMap::importItem):

Assume that we're adding things for the first time.
Count keys in the quota.

2009-11-12 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dmitry Titov.

Now that we're tracking key size in the quota, we can't fit as much in.
​https://bugs.webkit.org/show_bug.cgi?id=31451

  • storage/domstorage/quota-expected.txt:
  • storage/domstorage/script-tests/quota.js: (testQuota):
4:25 PM Changeset in webkit [50978] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2009-11-13 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Darin Adler.

Added to the WebKit Coding Style Guidelines not to use
"using namespace" statements in header files.

  • coding/coding-style.html:
4:09 PM Changeset in webkit [50977] by eric@webkit.org
  • 8 edits
    1 move in trunk

2009-11-13 Dominik Röttsches <​dominik.roettsches@access-company.com>

Reviewed by Eric Seidel.

Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
​https://bugs.webkit.org/show_bug.cgi?id=31468

Adding isAlphanumeric abstraction, required
by TextBoundaries.cpp.

  • wtf/unicode/glib/UnicodeGLib.h: (WTF::Unicode::isAlphanumeric):
  • wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::isAlphanumeric):

2009-11-13 Dominik Röttsches <​dominik.roettsches@access-company.com>

Reviewed by Eric Seidel.

Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
​https://bugs.webkit.org/show_bug.cgi?id=31468

Moving TextBoundariesICU.cpp to TextBoundaries.cpp
by removing the direct ICU dependency and replacing it
with WTF functions and WebCore's own TextBreakIterator
abstractions.

  • GNUmakefile.am:
  • platform/graphics/gtk/SimpleFontDataGtk.cpp:
  • platform/text/TextBoundaries.cpp: Added. (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):
  • platform/text/TextBoundariesICU.cpp: Removed.
  • platform/text/TextBreakIterator.h:
  • platform/text/TextBreakIteratorICU.cpp: (WebCore::textBreakLast): (WebCore::textBreakPrevious):
4:07 PM Changeset in webkit [50976] by hamaji@chromium.org
  • 4 edits in trunk

2009-11-13 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

WebCore::externalRepresentation should update layout before getting render object
​https://bugs.webkit.org/show_bug.cgi?id=31459

Before this change, the render tree output for this test was wrong.
Note that #FF0000 (red) becomes #008000 (green) now.

  • platform/mac/svg/custom/gradient-stop-style-change-expected.txt:

2009-11-13 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

WebCore::externalRepresentation should update layout before getting render object
​https://bugs.webkit.org/show_bug.cgi?id=31459

  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation):
4:06 PM Changeset in webkit [50975] by andersca@apple.com
  • 5 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.

Reviewed by Dan Bernstein.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
3:56 PM Changeset in webkit [50974] by Adam Roben
  • 2 edits in trunk/WebKit/win

Build fix

  • Interfaces/WebKit.idl: Touch this to force interfaces to rebuild.
3:49 PM Changeset in webkit [50973] by Adam Roben
  • 45 edits
    2 adds in trunk

Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared

Fixes <​http://webkit.org/b/31124>.

Reviewed by Dave Hyatt.

WebCore:

Tell FrameLoaderClient when window objects in isolated worlds are
cleared

Test: http/tests/security/isolatedWorld/didClearWindowObject.html

  • bindings/js/JSDOMBinding.h:

(WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
worlds in m_worldSet to the passed-in Vector.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::getAllWorlds): Added. Calls through to
WebCoreJSClientData.
(WebCore::ScriptController::initScript): Changed to call
FrameLoader::dispatchDidClearWindowObjectInWorld.

  • bindings/js/ScriptController.h: Added getAllWorlds.
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
Updated for FrameLoaderClient change.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::begin):
Changed to call dispatchDidClearWindowObjectsInAllWorlds.

(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
Added. Retrieves all the worlds, then calls through to
dispatchDidClearWindowObjectInWorld for each one.
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
dispatchWindowObjectAvailable. Calls up to the client, then, if the
world is the mainThreadNormalWorld(), tells the Inspector about it,
too.

  • loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with

dispatchDidClearWindowObjectInWorld. Added
dispatchDidClearWindowObjectsInAllWorlds.

  • loader/FrameLoaderClient.h: Replaced windowObjectCleared with

dispatchDidClearWindowObjectForWorld.

WebKit:

Add WebFrameLoadDelegatePrivat.h to WebKit.xcodeproj

  • WebKit.xcodeproj/project.pbxproj: Added

WebFrameLoadDelegatePrivate.h, which already existed.

WebKit/gtk:

Update for changes to FrameLoaderClient

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().

WebKit/haiku:

Update for changes to FrameLoaderClient

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::dispatchDidClearWindowObjectInWorld):

  • WebCoreSupport/FrameLoaderClientHaiku.h:

Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().

WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
Replaced windowObjectCleared with this function. If the delegate
implements it, call
-webView:didClearWindowObjectForFrame:inScriptWorld:. Otherwise, if
the passed-in world is the mainThreadNormalWorld(), call
-webView:didClearWindowObject:forFrame:.

  • WebView/WebDelegateImplementationCaching.h: Added a new entry in the

frame load delegate implementation cache for the new delegate method.

  • WebView/WebFrameLoadDelegatePrivate.h:
  • WebView/WebScriptWorld.mm:

(allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in
existence.
(-[WebScriptWorld initWithWorld:]): Add ourselves to allWorlds().
(-[WebScriptWorld dealloc]): Remove ourselves from allWorlds().
(+[WebScriptWorld findOrCreateWorld:]): Returns the existing
WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't
already exist.

  • WebView/WebScriptWorldInternal.h: Declared +findOrCreateWorld:.
  • WebView/WebView.mm:

(-[WebView _cacheFrameLoadDelegateImplementations]): Cache the
implementation of the new frame load delegate method.

WebKit/qt:

Update for changes to FrameLoaderClient

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):

  • WebCoreSupport/FrameLoaderClientQt.h:

Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().

WebKit/win:

  • Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added

didClearWindowObjectForFrameInScriptWorld.

  • WebFrame.cpp:

(WebFrame::dispatchDidClearWindowObjectInWorld):

  • WebFrame.h:

Replaced windowObjectCleared with this function. If the delegate
implements IWebFrameLoadDelegatePrivate2, call
didClearWindowObjectForFrameInScriptWorld. Otherwise, if the passed-in
world is the mainThreadNormalWorld(), call
didClearWindowObjectForFrame.

  • WebScriptWorld.cpp:

(allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in
existence.
(WebScriptWorld::WebScriptWorld): Add ourselves to allWorlds().
(WebScriptWorld::~WebScriptWorld): Remove ourselves from allWorlds().
(WebScriptWorld::standardWorld): Added this non-COM getter for the
standard world, which the COM getter now calls through to.
(WebScriptWorld::findOrCreateWorld): Added. Returns the existing
WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't
already exist.

  • WebScriptWorld.h: Added new standardWorld overload, made one

overload of createInstance private, and added findOrCreateWorld.

WebKit/wx:

Update for changes to FrameLoaderClient

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::dispatchDidClearWindowObjectInWorld):

  • WebKitSupport/FrameLoaderClientWx.h:

Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().

WebKitTools:

Add support for
http/tests/security/isolatedWorld/didClearWindowObject.html

  • DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
Added. Moved code here from -webView:didClearWindowObject:forFrame:.
(-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
Added. Sets a worldID property on the global object whose value is
the ID of this world.
(-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
Respond to this new delegate callback by calling through to one of the
above new methods.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(worldMap): Added. Returns a HashMap containing all the worlds we've
created.
(worldIDForWorld): Added. Returns the ID for this world, or 0 if we
haven't kept track of this world.
(LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
instead of declaring our own.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
  • DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::didClearWindowObject): Moved code from hear to
didClearWindowObjectForFrameInStandardWorld.
(FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
Respond to this new delegate callback by calling through to one of the
below new methods.
(FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
Added. Sets a worldID property on the gobal object whose value is
the ID of this world.
(FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
Added. Moved code here from didClearWindowObject.

  • DumpRenderTree/win/FrameLoadDelegate.h: Added the

didClearWindowObjectForFrame* functions.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(worldMap): Added. Returns a HashMap containing all the worlds we've
created.
(worldIDForWorld): Added. Returns the ID of this world, or 0 if we
haven't kept track of this world.
(LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
instead of declaring our own.

LayoutTests:

Test that delegates can modify global objects in isolated worlds

  • http/tests/security/isolatedWorld/didClearWindowObject-expected.txt: Added.
  • http/tests/security/isolatedWorld/didClearWindowObject.html: Added.

Tests that the global object in the normal world does not have a
worldID property, and that the global object in isolated worlds has
a worldID property whose value is equal to the world's ID.

3:46 PM Changeset in webkit [50972] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-11-13 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix SVG context assignment for pod types.
​https://bugs.webkit.org/show_bug.cgi?id=31497

I broke this in r50958.

Tested by svg/custom/viewport-update2.svg.

  • bindings/scripts/CodeGeneratorV8.pm:
3:38 PM Changeset in webkit [50971] by dimich@chromium.org
  • 12 edits in trunk/WebCore

Bring the platform/android files inline with Android 2.0
​https://bugs.webkit.org/show_bug.cgi?id=31423

Patch by Andrei Popescu <​andreip@google.com> on 2009-11-13
Reviewed by Dmitry Titov.

No new tests required: these are all Android-specific files.

  • platform/android/ClipboardAndroid.cpp:

(WebCore::ClipboardAndroid::files):

  • platform/android/ClipboardAndroid.h:
  • platform/android/FileChooserAndroid.cpp:

(WebCore::FileChooser::basenameForWidth):
(WebCore::fileButtonChooseFileLabel):

  • platform/android/KeyEventAndroid.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/android/LocalizedStringsAndroid.cpp:

(WebCore::contextMenuItemTagOpenLinkInNewWindow):
(WebCore::contextMenuItemTagDownloadLinkToDisk):
(WebCore::contextMenuItemTagCopyLinkToClipboard):
(WebCore::contextMenuItemTagOpenImageInNewWindow):
(WebCore::contextMenuItemTagDownloadImageToDisk):
(WebCore::contextMenuItemTagCopyImageToClipboard):
(WebCore::contextMenuItemTagOpenFrameInNewWindow):
(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagReload):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagNoGuessesFound):
(WebCore::contextMenuItemTagIgnoreSpelling):
(WebCore::contextMenuItemTagLearnSpelling):
(WebCore::contextMenuItemTagSearchWeb):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::contextMenuItemTagOpenLink):
(WebCore::contextMenuItemTagIgnoreGrammar):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckSpelling):
(WebCore::contextMenuItemTagCheckSpellingWhileTyping):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagFontMenu):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):
(WebCore::contextMenuItemTagOutline):
(WebCore::contextMenuItemTagWritingDirectionMenu):
(WebCore::contextMenuItemTagTextDirectionMenu):
(WebCore::contextMenuItemTagDefaultDirection):
(WebCore::contextMenuItemTagLeftToRight):
(WebCore::contextMenuItemTagRightToLeft):
(WebCore::mediaElementLoadingStateText):
(WebCore::mediaElementLiveBroadcastStateText):
(WebCore::searchableIndexIntroduction):
(WebCore::resetButtonDefaultLabel):
(WebCore::submitButtonDefaultLabel):
(WebCore::inputElementAltText):

  • platform/android/RenderThemeAndroid.cpp:

(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeAndroid::baselinePosition):
(WebCore::RenderThemeAndroid::paintButton):
(WebCore::adjustMenuListStyleCommon):
(WebCore::RenderThemeAndroid::paintCombo):

  • platform/android/ScreenAndroid.cpp:
  • platform/android/ScrollViewAndroid.cpp:

(WebCore::ScrollView::platformOffscreenContentRectangle):

  • platform/android/TemporaryLinkStubs.cpp:

(JSC::Bindings::dispatchJNICall):

  • platform/android/WidgetAndroid.cpp:

(WebCore::Widget::setFrameRect):

3:33 PM UsingGitWithWebKit edited by eric@webkit.org
(diff)
3:21 PM Changeset in webkit [50970] by eric@webkit.org
  • 4 edits in trunk

2009-11-13 Norbert Leser <norbert.leser&nokia.com>

Reviewed by Eric Seidel.

Added macros for USERINCLUDE paths within symbian blocks
to guarantee inclusion of respective header files from local path
first (to avoid clashes with same names of header files in system include path).

2009-11-13 Norbert Leser <norbert.leser&nokia.com>

Reviewed by Eric Seidel.

Added macros for USERINCLUDE paths within symbian blocks
to guarantee inclusion of respective header files from local path
first (to avoid clashes with same names of header files in system include path).

  • WebCore.pro:
3:20 PM Changeset in webkit [50969] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Remove the unnecessary call to dumpDatabaseCallbacks().

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31495

  • storage/hash-change-with-xhr.html:
1:51 PM Changeset in webkit [50968] by dimich@chromium.org
  • 23 edits
    5 adds in trunk

Implement composition events introduced in DOM Level 3.
This change adds a new IDL which defines the composition events, adds a class which
implements the composition events, and sends the composition events according to
the specification.
​https://bugs.webkit.org/show_bug.cgi?id=26310

Patch by Hironori Bono <​hbono@chromium.org> on 2009-11-13
Reviewed by Oliver Hunt.

WebCore:

Test: fast/events/ime-composition-events-001.html

  • DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
  • GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
  • WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.

  • bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
  • bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.

(WebCore::V8DOMWrapper::convertEventToV8Object):

  • bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
  • bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
  • dom/CompositionEvent.cpp: Implements the CompositionEvent class.

(WebCore::CompositionEvent::CompositionEvent):
(WebCore::CompositionEvent::~CompositionEvent):
(WebCore::CompositionEvent::initCompositionEvent):
(WebCore::CompositionEvent::isCompositionEvent):

  • dom/CompositionEvent.h: Declares the CompositionEvent class.

(WebCore::CompositionEvent::create):
(WebCore::CompositionEvent::data):

  • dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
  • dom/Event.cpp:

(WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.

  • dom/Event.h:
  • dom/EventNames.h: Added composition{start,update,end} to eventNames.
  • editing/Editor.cpp:

(WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
(WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.

LayoutTests:

  • fast/events/ime-composition-events-001-expected.txt: Added.
  • fast/events/ime-composition-events-001.html: Added.
  • platform/gtk/Skipped: Skip this test because TextInputController is not implemented.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.
1:26 PM Changeset in webkit [50967] by snej@chromium.org
  • 2 edits in trunk/WebCore

Fix a link error in unofficial GCC 4.4 builds on Linux.
​https://bugs.webkit.org/show_bug.cgi?id=31477

Reviewed by Dimitri Glazkov.

  • bindings/v8/V8Binding.cpp: Add explicit instantiations of v8StringToWebCoreString template.
12:55 PM Changeset in webkit [50966] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-13 Eric Seidel <​eric@webkit.org>

No review, build fix only.

Fix Debug build after ​http://trac.webkit.org/changeset/50960.

The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
​https://bugs.webkit.org/show_bug.cgi?id=31213

  • rendering/CounterNode.cpp: (WebCore::showTreeAndMark):
  • rendering/RenderCounter.cpp: (WebCore::destroyCounterNodeChildren):
12:50 PM Changeset in webkit [50965] by kenneth@webkit.org
  • 3 edits
    1 add in trunk

WebKitTools: Make the Qt Linux only --valgrind feature, suppress errors
defined in the SuppressedValgrindErrors file.

Reviewed by Simon Hausmann.

  • Scripts/run-webkit-tests:

LayoutTests: Add a file for suppressing invalid valgrind errors (Qt / Linux only)

Reviewed by Simon Hausmann.

  • platform/qt/SuppressedValgrindErrors: Added.
12:42 PM Changeset in webkit [50964] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

JSValueProtect and JSValueUnprotect don't protect API wrapper values
​https://bugs.webkit.org/show_bug.cgi?id=31485

Reviewed by Geoff Garen.

Make JSValueProtect/Unprotect use a new 'toJS' function, 'toJSForGC' that
does not attempt to to strip out API wrapper objects.

12:35 PM Changeset in webkit [50963] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-11-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Gustavo Noronha.

[CAIRO] shadow support for Canvas and SVG
​https://bugs.webkit.org/show_bug.cgi?id=30960

We currently fill a path with solid color instead of filling
a clipping path. This causes problems on some composite operators,
since Cairo modifies the area outside the path.
This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html

Thanks to Benjamin Otte for tracking the bug down.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill):
12:29 PM Changeset in webkit [50962] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-11-13 İsmail Dönmez <​ismail@namtrac.org>

Reviewed by Antti Koivisto.

Fix typo, ce_time.cpp should be ce_time.c

12:25 PM Changeset in webkit [50961] by dumi@chromium.org
  • 11 edits
    1 add in trunk

Adding Chromium's DatabaseTracker implementation.

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=31440

WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • storage/DatabaseTracker.h:
  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):

  • storage/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::updateDatabaseSize):

  • storage/chromium/QuotaTracker.h:

WebKit/chromium:

  • WebKit.gyp:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::exceededDatabaseQuota):

  • src/DatabaseObserver.cpp: Added.

(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):

  • src/WebDatabase.cpp:

(WebKit::WebDatabase::name):
(WebKit::WebDatabase::displayName):
(WebKit::WebDatabase::estimatedSize):
(WebKit::WebDatabase::securityOrigin):
(WebKit::WebDatabase::updateDatabaseSize):

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::toString):
(WebKit::WebSecurityOrigin::databaseIdentifier):

12:21 PM Changeset in webkit [50960] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-11-13 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Darin Adler.

The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
​https://bugs.webkit.org/show_bug.cgi?id=31213
Added tree navigation methods that permit full implementation of CSS2.1
counter feature without using recursion proportional to the counter
tree depth.
No new tests because I did not find any bug that is fixed by this
commit yet, this just reduces the size of the patch for 11031 and
helps respond to some concerns regarding that patch.

  • rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode):

(WebCore::CounterNode::nextInPreOrderAfterChildren):
(WebCore::CounterNode::nextInPreOrder):
Added to support non-recursive tree traversal necessary for
efficient full implementation of CSS2.1 counters.

(WebCore::CounterNode::lastDescendant):
(WebCore::CounterNode::previousInPreOrder):
Moved this methods such that they occupy a place similar to that of
identically named methods on the render tree. This allows for their
broader use needed in full implementation of CSS2.1 counters.

(WebCore::CounterNode::resetRenderer):
(WebCore::CounterNode::resetRenderers):
(WebCore::CounterNode::recount):
(WebCore::CounterNode::insertAfter):
(WebCore::CounterNode::removeChild):
Changed such that insertion/removal of a counter, triggers not only
recalculation of PrefixWidths, but also reassesment of values in
counter nodes. This is the basis full implementation of CSS2.1
counters. It does not change current behavior by much because of
changes needed to the recalculation algorithm, but those are comming
in the patch for 11031.
(WebCore::showTreeAndMark):

  • rendering/CounterNode.h:
  • rendering/RenderCounter.cpp: (WebCore::counter): Only changed argument type to prepare for implementation of Darin Adler's recommendation for the patch to 11031.

(WebCore::RenderCounter::invalidate):
(WebCore::destroyCounterNodeChildren):
(WebCore::RenderCounter::destroyCounterNodes):

  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::invalidateCountersInContainer): (WebCore::RenderObjectChildList::invalidateCounters):
  • rendering/RenderObjectChildList.h: Added the ability to restrict invalidation to counters with a given identifier. Also invalidated counters that are on the child container itself which were missed by the previous algorithm, but were a valid case.
12:04 PM Changeset in webkit [50959] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Set the locale to C and not to the current one in use on the system.

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

11:56 AM Changeset in webkit [50958] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-13 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Protect SVG animated properties from destruction in bindings.
​https://bugs.webkit.org/show_bug.cgi?id=31474

See ​http://crbug.com/26719.

Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
under Valgrind.

Made sure we keep a reference to SVG properties while setting a
context:

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::withSVGContext):
11:30 AM Changeset in webkit [50957] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Disable websocket tests on Windows, as the server cannot start on buildbot.

Filed <​https://bugs.webkit.org/show_bug.cgi?id=31479> to investigate this issue.

  • platform/win/Skipped:
11:21 AM Changeset in webkit [50956] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

[CAIRO] shadow support for Canvas and SVG.
​https://bugs.webkit.org/show_bug.cgi?id=30960

Reviewed by Alexey Proskuryakov.

Incorporate Benjamin Otte's recommendations to avoid
a buffer overrun, and small performance improvement.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::copyContextProperties): Correctly size output

storage for cairo_get_dash to avoid buffer overrun.

(WebCore::drawPathShadow): Prefer cairo_fill_extents

to slower cairo_stroke_extents when not drawing shadows.

11:19 AM Changeset in webkit [50955] by ap@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Restoring parst of ChangeLog that were somehow deleted with my latest commit.

11:14 AM Changeset in webkit [50954] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Do not register Chromium's HTML5 DB VFS as the default
VFS. Otherwise, other sqlite DB users in the same process will
stop working.

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=31462

  • platform/sql/chromium/SQLiteFileSystemChromium.cpp:

(WebCore::SQLiteFileSystem::openDatabase):

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:

(WebCore::SQLiteFileSystem::registerSQLiteVFS):

  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:

(WebCore::SQLiteFileSystem::registerSQLiteVFS):

10:51 AM Changeset in webkit [50953] by ap@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags, avoiding a sign mismatch warning.
10:47 AM Changeset in webkit [50952] by ap@apple.com
  • 2 edits in trunk/WebCore

Release build fix.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::readStreamCallback): (WebCore::SocketStreamHandle::writeStreamCallback): Use ASSERT_UNUSED for unused stream parameter.
10:14 AM Changeset in webkit [50951] by ap@apple.com
  • 7 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31441
Implement SocketStreamHandleCFNet

Existing WebSocket tests now pass on Mac. No proxy support yet.

  • platform/network/SocketStreamHandleClient.h:
  • platform/network/cf/SocketStreamHandle.h: (WebCore::SocketStreamHandle::shouldUseSSL): (WebCore::SocketStreamHandle::refAuthenticationClient): (WebCore::SocketStreamHandle::derefAuthenticationClient): (WebCore::SocketStreamHandle::):
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::chooseProxy): (WebCore::SocketStreamHandle::createStreams): (WebCore::SocketStreamHandle::copyCFStreamDescription): (WebCore::SocketStreamHandle::readStreamCallback): (WebCore::SocketStreamHandle::writeStreamCallback): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose): (WebCore::SocketStreamHandle::receivedCredential): (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): (WebCore::SocketStreamHandle::receivedCancellation):
10:07 AM Changeset in webkit [50950] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Fix worker-timeout.html layout test that fails in Chromium harness.
​https://bugs.webkit.org/show_bug.cgi?id=31452

Reviewed by Darin Adler.

  • fast/workers/worker-timeout.html:

Stop logging timer messages at the same time as calling NotifyDone() because
in test harness Chromium uses for workers it does not capture the output immediately.

9:51 AM Changeset in webkit [50949] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

Build correction. No review.

The WinCairo build requires ENABLE_FILTERS to work properly.

  • win/tools/vsprops/WinCairo.vsprops:
9:50 AM Changeset in webkit [50948] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-11-13 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling Chromium dependencies to match Chromium revision 31834.

​https://bugs.webkit.org/show_bug.cgi?id=31445

  • DEPS:
9:26 AM Changeset in webkit [50947] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: preload status bar button glyphs
in order to prevent them from flickering (take 2).

​https://bugs.webkit.org/show_bug.cgi?id=31439

  • inspector/front-end/inspector.js: (preloadImages):
9:10 AM Changeset in webkit [50946] by pfeldman@chromium.org
  • 3 edits
    2 deletes in trunk

2009-11-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Adam Barth.

Chromium: [REGRESSION] Crash while stopping on a breakpoint.
Rolling back r50890.

​https://bugs.webkit.org/show_bug.cgi?id=31467

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::canAccessPrivate):
9:10 AM Changeset in webkit [50945] by Adam Roben
  • 2 edits in trunk/WebKit/win

Build fix

  • Interfaces/WebKit.idl: Un-sort the #includes again. Apparently they

are order-dependent!

9:05 AM Changeset in webkit [50944] by Adam Roben
  • 2 edits in trunk/WebKit/win

Touch WebKit.idl to fix the Windows build

  • Interfaces/WebKit.idl: Sorted #includes.
8:58 AM Changeset in webkit [50943] by Adam Roben
  • 10 edits in trunk

Finish replacing worldIDs with world objects

The only remaining use of worldIDs was in a method only used by DRT
for the isolated worlds tests.

Fixes <​http://webkit.org/b/31414> Replace worldIDs with world objects

Reviewed by Mark Rowe.

WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

  • WebView/WebFramePrivate.h:

Renamed from
_stringByEvaluatingJavaScriptInIsolatedWorld:WithGobalObject:FromString:.
Now takes a WebScriptWorld instead of a worldID, so we don't need to
maintain a map of worldID -> world anymore.

WebKit/win:

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp:

(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):

  • WebFrame.h:

Renamed from stringByEvaluatingJavaScriptInIsolatedWorld. Now takes an
IWebScriptWorld instead of a worldID, so we don't need to maintain a
map of worldID -> world anymore.

WebKitTools:

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::evaluateScriptInIsolatedWorld):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::evaluateScriptInIsolatedWorld):
Updated for changes to WebFrame. Now holds the map of worldID -> world
at this level instead of making WebKit do it.

8:43 AM Changeset in webkit [50942] by vestbo@webkit.org
  • 3 edits in trunk/WebKitTools

[Qt] Ensure the DRT does not output anything until first test is run

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTree.cpp:
  • DumpRenderTree/qt/DumpRenderTree.h:
8:11 AM Changeset in webkit [50941] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Clear the undo stack in before each new test run.

Reviewed by Tor Arne Vestbø.

Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

7:06 AM Changeset in webkit [50940] by vestbo@webkit.org
  • 6 edits in trunk/WebKit/qt

Update documentation for the Qt API

Reviewed by Simon Hausmann.

  • Api/qgraphicswebview.cpp:
  • Api/qwebelement.cpp:
  • Api/qwebframe.cpp:
  • Api/qwebsettings.cpp:
  • Api/qwebview.cpp:
6:57 AM Changeset in webkit [50939] by krit@webkit.org
  • 4 edits in trunk

2009-11-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Gustavo Noronha.

[CAIRO] shadow support for Canvas and SVG
​https://bugs.webkit.org/show_bug.cgi?id=30960


This is the fix of a regression, caused by the shadow patch
from the bug above. Reinserted the save and restore calls
that were accidently removed by the previous patch.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke):

Skip fast/canvas/canvas-shadow.html we need to enable filters
on cairo to pass this test.

  • platform/gtk/Skipped:
5:49 AM Changeset in webkit [50938] by eric@webkit.org
  • 5 edits in trunk

2009-11-13 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable Page Cache if setMaximumPagesInCache needs it.
This fixes ​https://bugs.webkit.org/show_bug.cgi?id=31266.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::setMaximumPagesInCache):

2009-11-13 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference):
5:21 AM Changeset in webkit [50937] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-11-13 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix initial QWebView focus behavior.

focusController->setFocused(true) was not always called.
​https://bugs.webkit.org/show_bug.cgi?id=31466

  • Api/qwebpage.cpp: (QWebPagePrivate::focusInEvent):
5:12 AM Changeset in webkit [50936] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

Use correct install-path when running qdoc3

Reviewed by Simon Hausmann.

  • docs/docs.pri:
2:45 AM Changeset in webkit [50935] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-13 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Reverting r50908 since it makes inspector tests
time out.

​https://bugs.webkit.org/show_bug.cgi?id=31439

  • inspector/front-end/inspector.js:
2:21 AM Changeset in webkit [50934] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip one new test.

1:51 AM Changeset in webkit [50933] by pfeldman@chromium.org
  • 5 edits
    1 add in trunk/WebCore

2009-11-13 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Enable 'console.profile()' and 'console.profileEnd()'
regardless of JAVASCRIPT_DEBUGGER.

​https://bugs.webkit.org/show_bug.cgi?id=31293

  • WebCore.gypi:
  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profile): (WebCore::JSConsole::profileEnd):
  • bindings/v8/custom/V8ConsoleCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8CustomBinding.h:
  • page/Console.idl:
1:34 AM Changeset in webkit [50932] by levin@chromium.org
  • 2 edits in trunk/WebCore

Chromium build fix.

Reviewed by NOBODY.

  • bindings/v8/ScriptController.h:

(WebCore::ScriptController::evaluateInWorld): Add a dummy

method which isn't called in chromium to make things compile.

12:11 AM Changeset in webkit [50931] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Update committers.py based on svn records
​https://bugs.webkit.org/show_bug.cgi?id=31366

This list was generated using validate-committer-lists from
​https://bugs.webkit.org/show_bug.cgi?id=30970
and makes committers.py current for committers who have
committed in the last 3 years.

  • Scripts/modules/committers.py:
Note: See TracTimeline for information about the timeline view.