Timeline
Nov 15, 2009:
- 10:19 PM Changeset in webkit [51011] by
-
- 3 edits in trunk/LayoutTests
Fixing broken layout test.
Need to implement ARIA role="directory"
https://bugs.webkit.org/show_bug.cgi?id=31516
Lists are not supported on Leopard or Tiger, so the test for this
bug needs to be skipped.
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- 10:02 PM Changeset in webkit [51010] by
-
- 3 edits in trunk/WebKitTools
2009-11-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
svn-apply may not handle git patches created by bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31457
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- 8:44 PM Changeset in webkit [51009] by
-
- 2 edits in trunk/WebKit/chromium
2009-11-15 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Correct an error in the previous commit
- public/WebAccessibilityRole.h: It should be WebAccessibilityRoleDirectory, not WebAccessibilityDirectoryRole.
- 7:48 PM Changeset in webkit [51008] by
-
- 3 edits in trunk/WebKit/chromium
2009-11-15 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Bring WebAccessibilityRole up to sync after
http://trac.webkit.org/changeset/51007.
- public/WebAccessibilityRole.h: Added WebAccessibilityRoleDirectory.
- src/AssertMatchingEnums.cpp: Added a match between DirectoryRole and WebAccessibilityRoleDirectory.
- 6:05 PM Changeset in webkit [51007] by
-
- 10 edits2 adds in trunk
Need to implement ARIA role="directory"
https://bugs.webkit.org/show_bug.cgi?id=31516
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-directory.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::isOrderedList):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::createARIARoleMap):
WebKit/mac:
Fix a spelling error in the comment of a localized (accessibility) string.
- WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXARIAContentGroupText:]):
LayoutTests:
- platform/mac/accessibility/aria-directory-expected.txt: Added.
- platform/mac/accessibility/aria-directory.html: Added.
- 3:34 PM Changeset in webkit [51006] by
-
- 2 edits in trunk/WebCore
2009-11-15 Dave Tapuska <dtapuska@rim.com>
Reviewed by George Staikos.
Compare UChars single unit at a time as opposed to the uint32_t
approach as casting to unaligned addresses may cause a bus failure
on ARMv5 and below. This change replicates the same defines that
exists in AtomicString.cpp
- platform/text/StringHash.h: (WebCore::StringHash::equal):
- 3:32 PM Changeset in webkit [51005] by
-
- 3 edits in trunk/WebKitTools
2009-11-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
bugzilla-tool should post git binary diff
https://bugs.webkit.org/show_bug.cgi?id=31458
Add --binary option to Git.create_patch.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- 3:29 PM Changeset in webkit [51004] by
-
- 2 edits in trunk/WebCore
2009-11-15 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.
- bindings/v8/V8DOMWrapper.cpp:
- 3:28 PM Changeset in webkit [51003] by
-
- 2 edits in trunk/WebCore
2009-11-15 Maxime Simon <Maxime Simon>
Reviewed by Adam Barth.
[Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.
- platform/haiku/FileChooserHaiku.cpp:
- 3:26 PM Changeset in webkit [51002] by
-
- 2 edits in trunk/WebCore
2009-11-15 Maxime Simon <Maxime Simon>
Reviewed by Adam Barth.
[Haiku] Build fix. ColorSpace name had a wrong CamelCase.
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformStrokeColor):
- 3:24 PM Changeset in webkit [51001] by
-
- 4 edits in trunk/WebKitTools
2009-11-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Add bugzilla-tool check-style
https://bugs.webkit.org/show_bug.cgi?id=31515
- Scripts/bugzilla-tool:
- Scripts/modules/bugzilla.py:
- 3:15 PM Changeset in webkit [51000] by
-
- 8 edits in trunk/WebCore
2009-11-15 Daniel Bates <dbates@webkit.org>
No review, rolling out r50999.
http://trac.webkit.org/changeset/50999
Need to fix some issues in the Windows build. Missed some places where
RenderTextControl::isEdited is called.
- bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setUserEdited): (WebCore::RenderTextControl::subtreeHasChanged):
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::isEdited): (WebCore::RenderTextControl::setEdited): (WebCore::RenderTextControl::isUserEdited):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
- 2:55 PM Changeset in webkit [50999] by
-
- 8 edits in trunk/WebCore
2009-11-15 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
These are more descriptive names so as to clear an ambiguity surrounding
their usage. Also, renames associated setters and getters so that they
coincide with the renamed fields.
No functionality was changed. So, no tests were included.
- bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited. (WebCore::RenderTextControl::subtreeHasChanged):
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited. (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited. (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
Nov 14, 2009:
- 12:55 PM Changeset in webkit [50998] by
-
- 11 edits5 adds in trunk
WebCore: Fix for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
Reviewed by Dan Bernstein.
Test: fast/overflow/line-clamp.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
Use the line count value if available. Otherwise, convert the percentage to the line count, as we did before. Also,
if there is anchor as the last child box, still allow adding the ellipsis.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
(WebCore::RenderLayer::scrollRectToVisible): ditto.
- WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
- rendering/style/LineClampValue.h: Added.
(WebCore::LineClampValue::LineClampValue):
(WebCore::LineClampValue::value):
(WebCore::LineClampValue::isPercentage):
(WebCore::LineClampValue::isNone):
(WebCore::LineClampValue::operator==):
(WebCore::LineClampValue::operator!=):
- rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.
- rendering/style/RenderStyle.h: Use LineClampValue.
(WebCore::InheritedFlags::lineClamp):
(WebCore::InheritedFlags::setLineClamp):
(WebCore::InheritedFlags::initialLineClamp):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests: Test for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
Reviewed by Dan Bernstein.
- fast/overflow/line-clamp.html: Added.
- platform/mac/fast/overflow/line-clamp-expected.checksum: Added.
- platform/mac/fast/overflow/line-clamp-expected.png: Added.
- platform/mac/fast/overflow/line-clamp-expected.txt: Added.
- 12:24 PM QtBackLog edited by
- Mention individual commits (diff)
- 9:53 AM Changeset in webkit [50997] by
-
- 8 edits in trunk
2009-11-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/7287487>
Do not use QuickTime version to detect media controller theme
- WebCore.base.exp: Export wkMediaControllerThemeAvailable
- platform/mac/WebCoreSystemInterface.h: Ditto.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
- rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.
2009-11-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/7287487>
Do not use QuickTime version to detect media controller theme
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize wkMediaControllerThemeAvailable.
- 7:21 AM Changeset in webkit [50996] by
-
- 4 edits3 adds in trunk
2009-11-14 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add tests for reading/writing .type property of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=29004
- fast/forms/input-type-change3-expected.txt: Added.
- fast/forms/input-type-change3.html: Added.
- fast/forms/script-tests/input-type-change3.js: Added.
2009-11-14 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
- Recognizes date/datetime/datetime-local/month/time/week types of INPUT element. They have no dedicated UI and no type validation for now.
- Clean up setInputType() and formControlType() of HTMLInputElement. https://bugs.webkit.org/show_bug.cgi?id=29004
Test: fast/forms/input-type-change3.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): (WebCore::HTMLInputElement::patternMismatch): (WebCore::HTMLInputElement::tooLong): (WebCore::createTypeMap): Initializer for a static local variable. (WebCore::HTMLInputElement::setInputType): (WebCore::createFormControlTypes): Initializer for a static local variable. (WebCore::HTMLInputElement::formControlType): (WebCore::HTMLInputElement::saveFormControlState): (WebCore::HTMLInputElement::restoreFormControlState): (WebCore::HTMLInputElement::accessKeyAction): (WebCore::HTMLInputElement::rendererIsNeeded): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::isTextField): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::isRequiredFormControl): (WebCore::HTMLInputElement::dataList):
- html/HTMLInputElement.h: Add new values to InputType enum, and define numberOfTypes.
- 6:08 AM Changeset in webkit [50995] by
-
- 2 edits in trunk/LayoutTests
Skip new test that needs new DRT infrastructure, with bug filled.
