⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 18, 2009:

11:18 PM Changeset in webkit [51177] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix for QtWebKit after r51172.

  • platform/qt/Localizations.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
10:18 PM Changeset in webkit [51176] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-18 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Normalize ' and " in bugzilla-tool
​https://bugs.webkit.org/show_bug.cgi?id=31655

We decided " is better than ' and we should be consistent.

  • Scripts/bugzilla-tool:
10:17 PM Changeset in webkit [51175] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore: Fixed <rdar://problem/7398987> Assertion failure in
RenderLayer::updateClipRects when a plug-in’s enclosing layer is
enclosed by a transformed layer

Reviewed by Simon Fraser.

Tests: fast/layers/clip-rects-transformed-2.html

fast/layers/clip-rects-transformed.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
that is either transformed or composited. During painting and hit
testing, when a transformed or composited layer is hit, it becomes the
new root layer, which ultimately gets passed to calculateRects().
(WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
root layer to calculateRects(), and return the bounding box of the
transformed rectangle.
(WebCore::RenderLayer::selfClipRect): Ditto.

  • rendering/RenderLayer.h:

LayoutTests: Test for <rdar://problem/7398987> Assertion failure in
RenderLayer::updateClipRects when a plug-in’s enclosing layer is
enclosed by a transformed layer

Reviewed by Simon Fraser.

  • fast/layers/clip-rects-transformed-2-expected.txt: Added.
  • fast/layers/clip-rects-transformed-2.html: Added.
  • fast/layers/clip-rects-transformed-expected.txt: Added.
  • fast/layers/clip-rects-transformed.html: Added.
10:03 PM Changeset in webkit [51174] by Laszlo Gombos
  • 36 edits
    6 deletes in trunk

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
​https://bugs.webkit.org/show_bug.cgi?id=29469

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
​https://bugs.webkit.org/show_bug.cgi?id=29469

  • Api/qcookiejar.cpp: Removed.
  • Api/qcookiejar.h: Removed.
  • Api/qgraphicswebview.cpp: (QGraphicsWebView::event):
  • Api/qwebframe.cpp: (QWebFrame::load):
  • Api/qwebframe.h:
  • Api/qwebkitglobal.h:
  • Api/qwebnetworkinterface.cpp: Removed.
  • Api/qwebnetworkinterface.h: Removed.
  • Api/qwebnetworkinterface_p.h: Removed.
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::acceptNavigationRequest): (QWebPage::acceptNavigationRequest): (QWebPage::action): (QWebPage::userAgentForUrl):
  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
  • Api/qwebview.cpp: (QWebView::load): (QWebView::event):
  • Api/qwebview.h:
  • QtLauncher/main.cpp: (MainWindow::print): (MainWindow::setupUI): (main):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::download): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientQt::startDownload): (WebCore::FrameLoaderClientQt::createPlugin):

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
​https://bugs.webkit.org/show_bug.cgi?id=29469

No new tests as there is no change if compiled with
Qt v4.4 or later version.

  • WebCore.pro:
  • dom/XMLTokenizerQt.cpp: (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::doWrite): (WebCore::XMLTokenizer::startDocument): (WebCore::XMLTokenizer::parseDtd):
  • platform/graphics/qt/FontQt.cpp:
  • platform/graphics/qt/FontQt43.cpp: Removed.
  • platform/graphics/qt/ImageQt.cpp:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::setDefersLoading):
  • platform/network/qt/ResourceRequest.h:
  • platform/network/qt/ResourceRequestQt.cpp:
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::clearData):
  • platform/qt/CookieJarQt.cpp: (WebCore::cookieJar): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode): (WebCore::windowsKeyCodeForKeyEvent):
  • platform/text/qt/TextBoundaries.cpp:
  • platform/text/qt/TextBreakIteratorQt.cpp:
  • plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
​https://bugs.webkit.org/show_bug.cgi?id=29469

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/ImageDiff.pro:
9:47 PM Changeset in webkit [51173] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2009-11-18 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

GitTest.test_create_binary_patch fails if /tmp is symlink
​https://bugs.webkit.org/show_bug.cgi?id=31536

  • Scripts/modules/scm_unittest.py:
9:38 PM Changeset in webkit [51172] by tkent@chromium.org
  • 28 edits
    3 adds in trunk

2009-11-18 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

  • fast/dom/domListEnumeration-expected.txt: updated with new property
  • fast/dom/script-tests/domListEnumeration.js: ditto
  • fast/forms/script-tests/validationMessage.js: Added.
  • fast/forms/validationMessage-expected.txt: Added.
  • fast/forms/validationMessage.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2009-11-18 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

Test: fast/forms/validationMessage.html

  • html/HTMLButtonElement.idl: validationMessage attribute
  • html/HTMLFieldSetElement.idl: validationMessage attribute
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.idl: validationMessage attribute
  • html/HTMLSelectElement.idl: validationMessage attribute
  • html/HTMLTextAreaElement.idl: validationMessage attribute
  • html/ValidityState.cpp: new method to retrieve pertinent localized text
  • html/ValidityState.h:
  • page/mac/WebCoreViewFactory.h:
  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp:
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/haiku/LocalizedStringsHaiku.cpp:
  • platform/mac/LocalizedStringsMac.mm:
  • platform/wx/LocalizedStringsWx.cpp:

2009-11-18 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

  • English.lproj/Localizable.strings: new localizable strings

2009-11-18 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

  • src/LocalizedStrings.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

2009-11-18 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory validationMessageValueMissingText]): (-[WebViewFactory validationMessageTypeMismatchText]): (-[WebViewFactory validationMessagePatternMismatchText]): (-[WebViewFactory validationMessageTooLongText]): (-[WebViewFactory validationMessageRangeUnderflowText]): (-[WebViewFactory validationMessageRangeOverflowText]): (-[WebViewFactory validationMessageStepMismatchText]):

2009-11-18 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

  • WebCoreLocalizedStrings.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
9:09 PM Changeset in webkit [51171] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

Fix a typo. Remove the trailing semicolon
from an include directive after r51137.

No new tests as there is no functional change.

  • platform/qt/QWebPageClient.h:
8:52 PM Changeset in webkit [51170] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix for QtWebKit after r51159.

Include float.h for DBL_MANT_DIG. Not sure why this
is not a problem for other ports.

  • html/HTMLInputElement.cpp:
7:15 PM Changeset in webkit [51169] by rolandsteiner@chromium.org
  • 4 edits
    2 adds in trunk

WebCore: Bug 31574 - Crashing bug when removing <ruby> element
(​https://bugs.webkit.org/show_bug.cgi?id=31574)

Reviewed by Darin Adler.

Cause of the bug:
1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
4.) this triggers the special handling of child removal in RenderRubyRun that

causes it to destroy itself

5.) On returning from all this the renderer crashes when accessing a member

or virtual function on this now illegal object.

I therefore added a flag that tracks if the ruby run is being destroyed.
If so, avoid doing the special handling in removeChild that caused this.
It's not the most elegant solution, but the easiest to implement without
touching unrelated code. Also, it's self-documenting.

Test: fast/ruby/ruby-remove.html

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::destroy):
(WebCore::RenderRubyRun::removeChild):

  • rendering/RenderRubyRun.h:

LayoutTests: Bug 31574 - Crashing bug when removing <ruby> element
(​https://bugs.webkit.org/show_bug.cgi?id=31574)

Reviewed by Darin Adler.

Layout test to verify it no longer crashes when the <ruby> element
is being removed.

  • fast/ruby/ruby-remove-expected.txt: Added.
  • fast/ruby/ruby-remove.html: Added.
7:12 PM Changeset in webkit [51168] by tkent@chromium.org
  • 7 edits in trunk/JavaScriptCore

2009-11-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Move UString::from(double) implementation to new
WTF::doubleToStringInJavaScriptFormat(), and expose it because WebCore
code will use it.
​https://bugs.webkit.org/show_bug.cgi?id=31330

  • Introduce new function createRep(const char*, unsigned) and UString::UString(const char*, unsigned) to reduce 2 calls to strlen().
  • Fix a bug that dtoa() doesn't update *rve if the input value is NaN or Infinity.

No new tests because this doesn't change the behavior.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/UString.cpp: (JSC::createRep): (JSC::UString::UString): (JSC::UString::from): Move the code to doubleToStringInJavaScriptFormat().
  • runtime/UString.h:
  • wtf/dtoa.cpp: (WTF::dtoa): Fix a bug about rve. (WTF::append): A helper for doubleToStringInJavaScriptFormat(). (WTF::doubleToStringInJavaScriptFormat): Move the code from UString::from(double).
  • wtf/dtoa.h:
6:53 PM Changeset in webkit [51167] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-11-18 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Adler.

Configuration for Chromium Build Slaves.

​https://bugs.webkit.org/show_bug.cgi?id=31442

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
6:46 PM Changeset in webkit [51166] by eric@webkit.org
  • 4 edits in trunk

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
​https://bugs.webkit.org/show_bug.cgi?id=31643

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
​https://bugs.webkit.org/show_bug.cgi?id=31643

No new tests as there is no functional change.

  • WebCore.pro:
6:38 PM Changeset in webkit [51165] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2009-11-18 Yong Li <​yong.li@torchmobile.com>

Reviewed by Eric Seidel.

Implement TextBoundaries for WINCE port.
​https://bugs.webkit.org/show_bug.cgi?id=27371

  • platform/text/wince/TextBoundariesWince.cpp: Added.
6:30 PM Changeset in webkit [51164] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-11-18 Yong Li <​yong.li@torchmobile.com>

Reviewed by Eric Seidel.

Implement TextBreakIterator for WINCE port.
​https://bugs.webkit.org/show_bug.cgi?id=27371

  • platform/text/wince/TextBreakIteratorWince.cpp: Added.
6:15 PM Changeset in webkit [51163] by tkent@chromium.org
  • 5 edits
    18 adds in trunk

2009-11-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Tests for ValidityState.typeMismatch for the following types of INPUT element:

date, datetime, datetime-local, month, time and week

​https://bugs.webkit.org/show_bug.cgi?id=31342

  • fast/forms/ValidityState-typeMismatch-date-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-date.html: Added.
  • fast/forms/ValidityState-typeMismatch-datetime-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-datetime.html: Added.
  • fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-datetimelocal.html: Added.
  • fast/forms/ValidityState-typeMismatch-month-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-month.html: Added.
  • fast/forms/ValidityState-typeMismatch-time-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-time.html: Added.
  • fast/forms/ValidityState-typeMismatch-week-expected.txt: Added.
  • fast/forms/ValidityState-typeMismatch-week.html: Added.
  • fast/forms/script-tests/ValidityState-typeMismatch-date.js: Added.
  • fast/forms/script-tests/ValidityState-typeMismatch-datetime.js: Added.
  • fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js: Added.
  • fast/forms/script-tests/ValidityState-typeMismatch-month.js: Added.
  • fast/forms/script-tests/ValidityState-typeMismatch-time.js: Added.
  • fast/forms/script-tests/ValidityState-typeMismatch-week.js: Added.

2009-11-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Add support for ValidityState.typeMismatch for the following INPUT types:

date datetime datetime-local month time week

​https://bugs.webkit.org/show_bug.cgi?id=31342

Tests: fast/forms/ValidityState-typeMismatch-date.html

fast/forms/ValidityState-typeMismatch-datetime.html
fast/forms/ValidityState-typeMismatch-datetimelocal.html
fast/forms/ValidityState-typeMismatch-month.html
fast/forms/ValidityState-typeMismatch-time.html
fast/forms/ValidityState-typeMismatch-week.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::formStringToISODateTime): Check the type validity of the specified type and string using the ISODateTime class.
  • html/HTMLInputElement.h:
  • html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): Check the type validity for date, datetime, datetime-local, month, time and week with HTMLInputElemtn::formStringToISODateTime()
6:13 PM Changeset in webkit [51162] by mjs@apple.com
  • 4 edits in trunk/WebCore

2009-11-18 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
​https://bugs.webkit.org/show_bug.cgi?id=31237


Also speeds up Dromaeo DOM Core tests by 1.31x.

  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N2) behavior. The subtree mark bit was no longer effective; instead I changed things so only a node that has no ancestors with wrappers would do marking; there should be only one in the typical case (the root of the detached subtree).
  • dom/Node.cpp: (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
  • dom/Node.h: ditto
6:07 PM Changeset in webkit [51161] by Darin Adler
  • 7 edits in trunk/WebCore

Get rid of the redundant strokeType and fillType data members on
a GraphicsContext as well as the FillOrStrokeType enum. Use
null pointers instead.

Reviewed by Sam Weinig.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setStrokeColor): Null out the pattern
and gradient.
(WebCore::GraphicsContext::setFillColor): Ditto.
(WebCore::GraphicsContext::setStrokePattern): Null out the graident.
(WebCore::GraphicsContext::setFillPattern): Ditto.
(WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
(WebCore::GraphicsContext::setFillGradient): Ditto.

  • platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::setPlatformFill): Use null checks on fillPattern and
fillGraident instead of a switch statement.
(WebCore::setPlatformStroke): Ditto.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
(WebCore::GraphicsContext::applyFillPattern): Ditto.
(WebCore::calculateDrawingMode): Use fillPattern and strokePattern
to see if there is a pattern instead of fillType and strokeType.
(WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
fillPattern, and strokePattern instead of fillType and strokeType.
(WebCore::GraphicsContext::fillPath): Added FIXME about color space that
is used in the pattern and gradient case probably erroneously. Moved
gradient code inside an if statement. Streamlined pattern code and
use an if statement. No switch any more.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto.
(WebCore::GraphicsContext::strokeRect): Ditto.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
fillGraident instead of a switch statement.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto.

  • platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
(WebCore::GraphicsContext::fillRect): Ditto.

6:01 PM Changeset in webkit [51160] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-18 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

workqueue.py results in totally broken commit-queue UI
​https://bugs.webkit.org/show_bug.cgi?id=31645

  • Scripts/bugzilla-tool:
    • Remove unneeded use of PatchCollection.
    • Grab a new copy of the cq'd patches every run of the queue.
5:48 PM Changeset in webkit [51159] by eric@webkit.org
  • 9 edits
    12 adds in trunk

2009-11-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Add tests for ValidityState.stepMismatch.
​https://bugs.webkit.org/show_bug.cgi?id=31331

  • fast/forms/ValidityState-stepMismatch-number-expected.txt: Added.
  • fast/forms/ValidityState-stepMismatch-number.html: Added.
  • fast/forms/ValidityState-stepMismatch-range-expected.txt: Added.
  • fast/forms/ValidityState-stepMismatch-range.html: Added.
  • fast/forms/ValidityState-stepMismatch-unsupported-expected.txt: Added.
  • fast/forms/ValidityState-stepMismatch-unsupported.html: Added.
  • fast/forms/input-step-expected.txt: Added.
  • fast/forms/input-step.html: Added.
  • fast/forms/script-tests/ValidityState-stepMismatch-number.js: Added.
  • fast/forms/script-tests/ValidityState-stepMismatch-range.js: Added.
  • fast/forms/script-tests/ValidityState-stepMismatch-unsupported.js: Added.
  • fast/forms/script-tests/input-step.js: Added.

2009-11-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Support for step attribute and ValidityStae.stepMismatch for
type=number and range. stepMismatch will be false if the
difference between the current value and a multiple of the step
value is very small.

Change the behavior of RenderSlider so that it always has a value
rounded to the step attribute value.

​https://bugs.webkit.org/show_bug.cgi?id=31331

Tests: fast/forms/ValidityState-stepMismatch-number.html

fast/forms/ValidityState-stepMismatch-range.html
fast/forms/ValidityState-stepMismatch-unsupported.html
fast/forms/input-step.html

  • html/HTMLAttributeNames.in: Add "step".
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepMismatch): (WebCore::HTMLInputElement::getStepParameters): (WebCore::HTMLInputElement::getAllowedValueStep):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl: Add "step".
  • html/ValidityState.cpp: (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
  • html/ValidityState.h:
  • rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::clampValue):
5:27 PM Changeset in webkit [51158] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Need to ASSERT(isMainThread()) in ThreadShared methods.
​https://bugs.webkit.org/show_bug.cgi?id=31637

Reviewed by Darin Adler.

Added ASSERT(IsMainThread()) to all following methods:

  • platform/TreeShared.h:

(WebCore::TreeShared::TreeShared):
(WebCore::TreeShared::~TreeShared):
(WebCore::TreeShared::ref):
(WebCore::TreeShared::deref):
(WebCore::TreeShared::setParent):
(WebCore::TreeShared::parent):

5:00 PM Changeset in webkit [51157] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-18 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Eric Seidel.

Add plugin visibility manual test

​https://bugs.webkit.org/show_bug.cgi?id=31542

  • manual-tests/plugins/windowed.html:
  • manual-tests/plugins/windowless.html:
4:52 PM Changeset in webkit [51156] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-11-18 Patrick Mueller <​Patrick_Mueller@us.ibm.com>

Reviewed by Pavel Feldman.

Web Inspector - remember last script displayed in Scripts panel
​https://bugs.webkit.org/show_bug.cgi?id=27552

Manual test added

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.showScript): (WebInspector.ScriptsPanel.prototype.showResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.ScriptsPanel.prototype._goBack): (WebInspector.ScriptsPanel.prototype._goForward):
  • manual-tests/inspector/remember-last-script.html: Added.
4:43 PM Changeset in webkit [51155] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-18 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

Win chromium is slow to draw transparent texts
​https://bugs.webkit.org/show_bug.cgi?id=31258

Create bounded transparency layers instead of just clipping.

No new tests because this is just a performance improvement.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
4:35 PM Changeset in webkit [51154] by eric@webkit.org
  • 8 edits in trunk

2009-11-18 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Update expected result after Qt4.6 upgrade.
​https://bugs.webkit.org/show_bug.cgi?id=31560

Test: LayoutTests/editing/deleting/5408255.html

  • platform/qt/editing/deleting/5408255-expected.txt:

2009-11-18 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Add support for displaying deleteButton.
​https://bugs.webkit.org/show_bug.cgi?id=31560

Test: LayoutTests/editing/deleting/5408255.html

  • WebCore.qrc:
  • platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):

2009-11-18 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Add support for displaying deleteButton.
​https://bugs.webkit.org/show_bug.cgi?id=31560

Test: LayoutTests/editing/deleting/5408255.html

  • Api/qwebsettings.cpp: (graphics):
  • Api/qwebsettings.h:
4:26 PM Changeset in webkit [51153] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-18 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Eric Seidel.

Fix Qt build without JavaScript debugger.

​https://bugs.webkit.org/show_bug.cgi?id=31575

  • page/Console.idl:
4:18 PM Changeset in webkit [51152] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2009-11-18 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

Make 80 patches a formal requirement for reviewership
​https://bugs.webkit.org/show_bug.cgi?id=31313
Per discussion on the webkit-reviewers list:
​http://lists.webkit.org/mailman/private.cgi/webkit-reviewers/2009-November/000795.html

  • coding/commit-review-policy.html:
4:05 PM Changeset in webkit [51151] by dbates@webkit.org
  • 3 edits
    10 adds in trunk

2009-11-18 Daniel Bates <​dbates@webkit.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=24971
And
<rdar://problem/7138265>

Fixes an issue where setting the height of a table row programmatically
(via JavaScript) causes the table to be improperly rendered because the
height of each row in the table is not recalculated with respect to the
CSS height property.

In particular, programmatically setting the height of some table row causes
the rows of that table to be rendered with a height equal to the minimum
height required by the cells in that row, regardless of any specified cell
heights. Instead, when RenderTableSection::recalcCells is called, the height
of each row should be set to the CSS height property just as we do in
RenderTableSection::addChild.

Test: fast/table/row-height-recalc2.html

  • rendering/RenderTableSection.cpp: (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added. (WebCore::RenderTableSection::addChild): Moved code that set row height into method WebCore::setRowHeightToRowStyleHeightIfNotRelative. (WebCore::RenderTableSection::recalcCells): Modified to call WebCore::setRowHeightToRowStyleHeightIfNotRelative.

2009-11-18 Daniel Bates <​dbates@webkit.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=24971
And
<rdar://problem/7138265>

Tests that setting the height of a table row programmatically (via JavaScript)
recalculates the height of the rows in the table.

  • fast/table/row-height-recalc2.html: Added.
  • platform/mac/fast/table/row-height-recalc2-expected.checksum: Added.
  • platform/mac/fast/table/row-height-recalc2-expected.png: Added.
  • platform/mac/fast/table/row-height-recalc2-expected.txt: Added.
  • platform/qt/fast/table/row-height-recalc2-expected.checksum: Added.
  • platform/qt/fast/table/row-height-recalc2-expected.png: Added.
  • platform/qt/fast/table/row-height-recalc2-expected.txt: Added.
  • platform/win/fast/table/row-height-recalc2-expected.checksum: Added.
  • platform/win/fast/table/row-height-recalc2-expected.png: Added.
  • platform/win/fast/table/row-height-recalc2-expected.txt: Added.
3:57 PM Changeset in webkit [51150] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Reduce flakiness in zero-duration-with-non-zero-delay-end.html by
increasing a timeout.

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31646

  • transitions/zero-duration-with-non-zero-delay-end.html:
3:47 PM Changeset in webkit [51149] by zoltan@webkit.org
  • 11 edits in trunk/WebCore

Allow custom memory allocation control for the part of platform directory in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=31473

Reviewed by Darin Adler.

Inherits the following classes from FastAllocBase because these are
instantiated by 'new':

class AnimationList - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
class Color - instantiated at WebCore/rendering/RenderTheme.cpp:48
struct Length - instantiated at WebCore/platform/Length.cpp:103
class PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
class ContextMenuItem - instantiated at WebCore/platform/ContextMenu.cpp:70
class DeprecatedPtrList - instantiated at WebCore/rendering/RenderBlock.cpp:2284

Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:

class GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
class FontCache - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
struct MediaPlayerFactory - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
class DeprecatedPtrListNode - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53

  • platform/ContextMenuItem.h:
  • platform/DeprecatedPtrList.h:
  • platform/DeprecatedPtrListImpl.cpp:
  • platform/Length.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/animation/AnimationList.h:
  • platform/graphics/Color.h:
  • platform/graphics/FontCache.h:
  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/MediaPlayer.cpp:
3:46 PM Changeset in webkit [51148] by eric@webkit.org
  • 10 edits in trunk

2009-11-18 Daniel Bates <​dbates@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31186

Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
These are more descriptive names so as to clear an ambiguity surrounding
their usage. Also, renames associated setters and getters so that they
coincide with the renamed fields.

No functionality was changed. So, no tests were included.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited. (WebCore::RenderTextControl::subtreeHasChanged):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited. (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited. (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):

2009-11-18 Daniel Bates <​dbates@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31186

Changes associated with renaming RenderTextControl::isUserEdited.

  • DOMHTMLClasses.cpp: (DOMHTMLInputElement::isUserEdited): Formerly named isUserEdited. (DOMHTMLTextAreaElement::isUserEdited): Ditto.
3:44 PM Changeset in webkit [51147] by weinig@apple.com
  • 8 edits
    3 deletes in trunk

Make the Mac Geolocation API async.

Reviewed by Anders Carlsson.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Remove WebGeolocation.

WebKit/mac:

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::requestGeolocationPermissionForFrame):
(-[WebGeolocationPolicyListener initWithGeolocation:]):
(-[WebGeolocationPolicyListener allow]):
(-[WebGeolocationPolicyListener deny]):
Add WebGeolocationPolicyListener implementation of the new WebGeolocationPolicyListener
protocol and use if to implement requestGeolocationPermissionForFrame using the new async
API.

  • WebCoreSupport/WebGeolocation.mm: Removed.
  • WebCoreSupport/WebGeolocationInternal.h: Removed.
  • WebCoreSupport/WebGeolocationMock.mm: Remove bogus include.
  • WebCoreSupport/WebGeolocationPrivate.h: Removed.
  • WebView/WebUIDelegatePrivate.h: Remove requestGeolocationPermission and add

WebGeolocationPolicyListener protocol and decidePolicyForGeolocationRequestFromOrigin delegate
method.

WebKitTools:

Update DRT to use the new async Mac Geolocation API.

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):

3:36 PM Changeset in webkit [51146] by eric@webkit.org
  • 3 edits
    1 delete in trunk/WebCore

2009-11-18 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
​https://bugs.webkit.org/show_bug.cgi?id=31499

No new tests, just a build cleanup.

  • WebCore.gypi:
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8CustomBinding.h:
3:29 PM Changeset in webkit [51145] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Add and option to toggle HTML5 datalist support to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=31599

  • Scripts/build-webkit:
3:25 PM Changeset in webkit [51144] by Nate Chapin
  • 4 edits in trunk

2009-11-18 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

Remove Chromium's unnecessary dependency on wtf's tcmalloc files.

​https://bugs.webkit.org/show_bug.cgi?id=31648

3:23 PM Applications using WebKit edited by blythe_yee@apple.com
(diff)
3:18 PM Changeset in webkit [51143] by kevino@webkit.org
  • 15 edits in trunk

Reviewed by Kevin Ollivier.

Enable wx plugin support using the Windows implementation as a base.

​https://bugs.webkit.org/show_bug.cgi?id=31636

3:10 PM Changeset in webkit [51142] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-11-18 Evan Stade <​estade@chromium.org>

Reviewed by Darin Fisher.

Menu button shows wrong content in Chromium
​https://bugs.webkit.org/show_bug.cgi?id=31448

Make context menu button (VK_APPS) show context menu for node that has
keyboard focus. This affects both the content and the positioning.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendContextMenuEvent):
3:02 PM Changeset in webkit [51141] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-11-18 Thiago Macieira <​thiago.macieira@nokia.com>

Reviewed by Gavin Barraclough.

[Qt] Implement symbol hiding for JSC's JIT functions.

These functions are implemented directly in assembly, so they need the
proper directives to enable/disable visibility. On ELF systems, it's
.hidden, whereas on Mach-O systems (Mac) it's .private_extern. On
Windows, it's not necessary since you have to explicitly export. I
also implemented the AIX idiom, though it's unlikely anyone will
implement AIX/POWER JIT.
​https://bugs.webkit.org/show_bug.cgi?id=30864

  • jit/JITStubs.cpp:
2:49 PM Changeset in webkit [51140] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-11-18 Andrei Popescu <​andreip@google.com>

Reviewed by Dimitri Glazkov.

[Android] Add shared timer and sound utilities to platform/android
​https://bugs.webkit.org/show_bug.cgi?id=31584

No new tests required, this is platform specific code.

  • platform/android/SharedTimerAndroid.cpp: Added. (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
  • platform/android/SoundAndroid.cpp: Added. (WebCore::systemBeep):
2:41 PM Changeset in webkit [51139] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-11-18 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Fix profile tree nodes loss after focus / restore actions.

Focusing on a node is currently implemented via nodes reattaching
with some caching involved. It seems that not all code was updated
to handle this scenario correctly.

​https://bugs.webkit.org/show_bug.cgi?id=31553

  • inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._restore): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.insertChild): (WebInspector.DataGridNode.prototype._detach): (WebInspector.DataGridNode.prototype.savePosition): (WebInspector.DataGridNode.prototype.restorePosition):
  • inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridTree.prototype.focus): (WebInspector.TopDownProfileDataGridTree.prototype.restore):
2:37 PM Changeset in webkit [51138] by dbates@webkit.org
  • 2 edits in trunk/WebKitSite

2009-11-18 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31610

Adds property "min-width" to #title so that the width of the title
element on each page is at least 790px. In particular, this makes
the page <​http://webkit.org/security/security-group-members.html>
consistent, in appearance, to the rest of the site.

  • css/main.css:
2:33 PM Changeset in webkit [51137] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-18 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPageClient.h needs in some cases QCursor, but it does not
include it
​https://bugs.webkit.org/show_bug.cgi?id=31527

No new tests as this is just a coding style fix that affects the
build of some not yet submitted patches (i.e. for bug 30173).

  • platform/qt/QWebPageClient.h:
2:25 PM Changeset in webkit [51136] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-18 Nicolas Roard <​nicolas@roard.com>

Reviewed by Dimitri Glazkov.

InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
​https://bugs.webkit.org/show_bug.cgi?id=31504

  • inspector/InspectorTimelineAgent.h:Added the guard.
2:08 PM Changeset in webkit [51135] by snej@chromium.org
  • 2 edits in trunk/WebCore

Build fix to my previous checkin, for Windows Chromium

  • svg/SVGAnimatedProperty.h:

(WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.

2:05 PM Changeset in webkit [51134] by Joseph Pecoraro
  • 5 edits in trunk/WebCore

2009-11-18 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Directly Access <head> Instead of Searching for It
​https://bugs.webkit.org/show_bug.cgi?id=31641

Changed old access of the head element (document.getElementsByTagName)
to just use the document.head accessor.

  • inspector/front-end/FontView.js: (WebInspector.FontView):
  • inspector/front-end/InjectedScript.js: (InjectedScript.addStyleSelector):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
  • inspector/front-end/inspector.js: (windowLoaded):
2:04 PM Changeset in webkit [51133] by weinig@apple.com
  • 3 edits in trunk/WebCore

Fix two Geolocation assertions.

Reviewed by Anders Carlsson.

  • page/Chrome.cpp:

(WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
is not called from JS.

  • page/Geolocation.cpp:

(WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
a RefPtr first.

2:02 PM Changeset in webkit [51132] by ap@apple.com
  • 2 edits in trunk/WebCore

Case sensitive file system build fix.

  • platform/network/Credential.h: It's not WTF, just wtf.
1:54 PM Changeset in webkit [51131] by agolden@apple.com
  • 4 edits in trunk/WebCore

Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
objects and WebCore::Credential objects without losing certificate information.

Reviewed by Alexey Proskuryakov

1:49 PM Changeset in webkit [51130] by darin@chromium.org
  • 5 edits in trunk/WebKit/chromium

2009-11-17 Darin Fisher <​darin@chromium.org>

Reviewed by Dmitry Titov.

Minor cleanup in WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=31616

  • public/WebFormElement.h: Add missing WEBKIT_API prefix.
  • public/WebNode.h: Add missing WEBKIT_API prefix.
  • src/WebFormElement.cpp: (WebKit::WebFormElement::action): Make action getter const.
  • src/WebNode.cpp: (WebKit::WebNode::frame): Utilize WebFrameImpl::fromFrame.
1:31 PM Changeset in webkit [51129] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Update expected results of fixed test.

12:46 PM Changeset in webkit [51128] by oliver@apple.com
  • 4 edits in trunk

Interpreter may do an out of range access when throwing an exception in the profiler.
​https://bugs.webkit.org/show_bug.cgi?id=31635

Reviewed by Alexey Proskuryakov.

Add bounds check.

12:25 PM Changeset in webkit [51127] by dimich@chromium.org
  • 4 edits in trunk/WebCore

Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
​https://bugs.webkit.org/show_bug.cgi?id=31615

Reviewed by Eric Seidel.

  • dom/Document.cpp:

(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::ScriptExecutionContextTaskTimer::fired):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::performTask):
(WebCore::Document::postTask):

  • dom/ScriptExecutionContext.cpp:
  • dom/ScriptExecutionContext.h:
12:09 PM Changeset in webkit [51126] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Disabling WebSocket tests on Tiger back, they still hang.

  • platform/mac-tiger/Skipped:
11:57 AM Changeset in webkit [51125] by snej@chromium.org
  • 9 edits in trunk/WebCore

Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
by causing the right v8-to-WebCore conversion function to be called for every parameter.
This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
To enforce correctness, I added a mode that disables implicit
String-->AtomicString conversions while compiling the generated bindings.
​https://bugs.webkit.org/show_bug.cgi?id=31168

Reviewed by Darin Adler.

  • bindings/scripts/CodeGeneratorV8.pm: Generate usage of V8Parameter class.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Enable NO_IMPLICIT_ATOMICSTRING.
  • bindings/v8/V8Binding.h: Add V8Parameter class.
  • css/WebKitCSSKeyframesRule.h: Make AtomicString conversions explicit.
  • dom/Document.idl: Remove obsolete [HintAtomic] annotation.
  • platform/text/AtomicString.h: Added NO_IMPLICIT_ATOMICSTRING option.
  • svg/SVGAnimatedTemplate.h: Change some return types to String to avoid implicit conversion.
  • svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.
11:49 AM Changeset in webkit [51124] by Darin Adler
  • 3 edits in trunk/WebCore

Move FillOrStrokeType out of public header.

Reviewed by Dan Bernstein.

  • platform/graphics/GraphicsContext.h: Updated copyright date to cover

some years we published Apple changes, sorted forward declarations,
removed FillOrStrokeType enum.

  • platform/graphics/GraphicsContextPrivate.h: Updated copyright date

to cover some years we published Apple changes, sorted includes,
moved FillOrStrokeType enum here.

11:37 AM Changeset in webkit [51123] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

Fix the clobber list of cacheFlush for ARM and Thumb2 on Linux
​https://bugs.webkit.org/show_bug.cgi?id=31631

Patch by Gabor Loki <​loki@inf.u-szeged.hu> on 2009-11-18
Reviewed by Darin Adler.

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

11:23 AM Changeset in webkit [51122] by cmarrin@apple.com
  • 17 edits in trunk

Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
​https://bugs.webkit.org/show_bug.cgi?id=31601

These are used to debug accelerated compositing layers. I removed
the platform specific code from GraphicsLayerCA.mm and added calls
to GraphicsLayerClient to get it from the higher levels. The values
now get cached in RenderLayerCompositing and are queried from there
by RenderLayerBacking (which implements the GraphicsLayerClient interface).

10:26 AM Changeset in webkit [51121] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-11-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Get rid of metrics and properties sidebars'
flickering.

​https://bugs.webkit.org/show_bug.cgi?id=31629

  • inspector/front-end/MetricsSidebarPane.js:
  • inspector/front-end/PropertiesSidebarPane.js:
10:21 AM Changeset in webkit [51120] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Eliminate flakiness in file-URL-with-port-number by removing a setTimeout.
The timeout caused the test to fail about 2% of the time on the Chromium builders.
The timeout exists to catch cases where the iframe does not load, but the test
framework already will handle this (albeit with a longer timeout).

Reviewed by Dmitry Titov.

  • fast/loader/file-URL-with-port-number.html:
10:12 AM Changeset in webkit [51119] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Fixes <​http://webkit.org/b/31606>.
Web Inspector: Enter/Return key should enter edit mode for Editable Fields.

Reviewed by Pavel Feldman.

This implements Enter starting editing mode in an editable DataGrid. If the
DataGrid is editable and the user hits return, startEditing the first child
of the selected node. Also refactored some editing functions to take an
event target instead of the event itself, because the functions only needed
the target. Lastly, added had return in editing mode stop propogation, because
when enter was hit to confirm text, it would propagate back to the datagrid
and try to start editing again.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._ondblclick):
(WebInspector.DataGrid.prototype._startEditing):
(WebInspector.DataGrid.prototype.handleKeyEvent):
(WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
(WebInspector.DataGrid.prototype._mouseDownInDataTable):
(WebInspector.DataGrid.prototype._clickInDataTable):

  • inspector/front-end/inspector.js:

(WebInspector.startEditing.element.handleKeyEvent):
(WebInspector.startEditing):

9:57 AM Changeset in webkit [51118] by benm@google.com
  • 3 edits
    3 adds in trunk

HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
​https://bugs.webkit.org/show_bug.cgi?id=31593

Reviewed by Darin Adler.

WebCore:

Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.

LayoutTests:

  • fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-whitespace.js: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-whitespace-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html: Added.
9:38 AM Changeset in webkit [51117] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-18 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Touch InspectorController so that frontend
JS files are deployed on Windows.

  • inspector/InspectorController.cpp:
9:30 AM Changeset in webkit [51116] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Trying to enable WebSocket tests on Tiger again, now that bug 31603 is fixed.

  • platform/mac-tiger/Skipped:
9:25 AM Changeset in webkit [51115] by pfeldman@chromium.org
  • 3 edits in trunk

2009-11-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: clone timeline records array instead of
copying reference on invalidate all.

​https://bugs.webkit.org/show_bug.cgi?id=31596

  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
8:38 AM Changeset in webkit [51114] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Change the initialization order so that the controllers
will be created before exporting them to the JS DOM window.

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):

8:17 AM QtWebKitAPI edited by Simon Hausmann
(diff)
8:16 AM Changeset in webkit [51113] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Fix a code copy and paste error. m_page should be page.

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::createWindow):

8:15 AM QtWebKitAPI edited by Simon Hausmann
(diff)
8:14 AM QtWebKitAPI edited by Simon Hausmann
(diff)
8:05 AM QtWebKitAPI created by Simon Hausmann
7:49 AM QtWebKitContrib edited by Simon Hausmann
(diff)
7:02 AM Changeset in webkit [51112] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-11-18 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Elements don't drop out of compositing layers when animation ends
​https://bugs.webkit.org/show_bug.cgi?id=31613
<rdar://problem/7402913>

Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
are compositing anyway for other reasons. Doing so can cause those layers
to stay in compositing mode even after animations finish, because needsToBeComposited()
continues to return true.

No new tests because it's not possible to determine which elements are in
compositing layers from DRT output.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
6:27 AM Changeset in webkit [51111] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Make the QWebElement::render() test pass when pixmaps aren't 32 bit.

Patch by Paul Olav Tvete <​paul.tvete@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.

  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::render):

5:22 AM Changeset in webkit [51110] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

[Qt] Fix detection of linux-g++

Patch by Harald Fernengel <​harald.fernengel@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.

Never use "linux-g++*" to check for linux-g++, since this will break embedded
builds which use linux-arm-g++ and friends. Use 'linux*-g++*' to check for any
g++ on linux mkspec.

5:20 AM Changeset in webkit [51109] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Properly localize documentation strings for the tab-key-cycles-through-elements property.

5:20 AM Changeset in webkit [51108] by kov@webkit.org
  • 4 edits in trunk

Ensure that tabKeyCyclesThroughElements is true by default.

5:19 AM Changeset in webkit [51107] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Clarify and simplify the legal section in the overview documentation,
after review with our legal team.

Reviewed by Tor Arne Vestbø.

  • docs/qtwebkit.qdoc:
4:58 AM Changeset in webkit [51106] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Add QtLauncher support for opening links in the default browser

Reviewed by Simon Hausmann.

This can be triggered by either the context menu or by clicking a link
while holding down the Alt key. Opening a link in a new windows is
triggered by holding down Shift.

  • QtLauncher/main.cpp:
4:53 AM Changeset in webkit [51105] by Girish Ramakrishnan
  • 3 edits in trunk/WebCore

[Qt] Mac Plugins: Remove null timer

Reviewed by Tor Arne Vestbø.

A null timer was used to send mouse move events. Instead, we now use
move events to send nullEvent. This brings down CPU usage by 20-30%.

​https://bugs.webkit.org/show_bug.cgi?id=31624

4:48 AM Changeset in webkit [51104] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

[GTK] Failing test media/video-document-types.html
​https://bugs.webkit.org/show_bug.cgi?id=31352

Match what Mac has been doing since r36001: cancel the main load,
and handle failures caused by 'will be handled by plugin' errors.

Covered by test media/video-document-types.html

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::committedLoad):
(WebKit::FrameLoaderClient::shouldFallBack):

2:29 AM Changeset in webkit [51103] by Simon Hausmann
  • 3 edits
    4 adds in trunk

[Qt] WebKit crashes when loading certain SVG images

Patch by Benjamin Poulain <​benjamin.poulain@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.

WebCore:

Check if the familly exist before creating the PlatformData from it.

​https://bugs.webkit.org/show_bug.cgi?id=29443

Test: svg/text/text-font-invalid.html

  • platform/graphics/qt/FontFallbackListQt.cpp:

(WebCore::FontFallbackList::fontDataAt):

LayoutTests:

Added a test for a crash of QtWebkit when loading SVG images.

​https://bugs.webkit.org/show_bug.cgi?id=29443

  • svg/text/resources/text-font-invalid.svg: Added.
  • svg/text/text-font-invalid-expected.txt: Added.
  • svg/text/text-font-invalid.html: Added.

Nov 17, 2009:

10:51 PM Changeset in webkit [51102] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-11-17 Nicolas Weber <​thakis@chromium.org>

Reviewed by Darin Fisher.

Fix crash in Chromium/Mac where dropdowns weren't dismissed correctly
after navigation.
​https://bugs.webkit.org/show_bug.cgi?id=31609

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showExternal): Set parent for external dropdowns, so that |PopupListBox::hidePopup()| can successfully notify its parent's client.
9:19 PM Changeset in webkit [51101] by tkent@chromium.org
  • 4 edits
    3 adds in trunk

2009-11-17 Hayato Ito <​hayato@google.com>

Reviewed by Darin Adler.

Avoid infinite mutual recursion when deeply nested tags are loaded
​https://bugs.webkit.org/show_bug.cgi?id=30651

  • fast/parser/block-nesting-cap-table-expected.txt: Added.
  • fast/parser/block-nesting-cap-table.html: Added.
  • fast/parser/script-tests/block-nesting-cap-table.js: Added.

2009-11-17 Hayato Ito <​hayato@google.com>

Reviewed by Darin Adler.

Avoid infinite mutual recursion when deeply nested tags are loaded
​https://bugs.webkit.org/show_bug.cgi?id=30651

Test: fast/parser/block-nesting-cap-table.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken): (WebCore::tagPriorityOfNode): (WebCore::HTMLParser::limitBlockDepth): (WebCore::HTMLParser::insertNodeAfterLimitBlockDepth): (WebCore::HTMLParser::insertNode):
  • html/HTMLParser.h:
8:18 PM Changeset in webkit [51100] by jhoneycutt@apple.com
  • 2 edits in trunk/JavaScriptCore

Add JSContextRefPrivate.h to list of copied files.

Reviewed by Mark Rowe.

5:12 PM Changeset in webkit [51099] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X

Reviewed by Alexey Proskuryakov.

  • pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.

This prevents symlinks from confusing the descendant check.

5:08 PM Changeset in webkit [51098] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Rubber-stamped by Alexey Proskuryakov.

Final clean-ups for minor coding standard violations.
​https://bugs.webkit.org/show_bug.cgi?id=26102.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:
4:35 PM Changeset in webkit [51097] by dimich@chromium.org
  • 5 edits
    2 adds in trunk

WebCore: In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
​https://bugs.webkit.org/show_bug.cgi?id=31567

Patch by Johnny Ding <​jnd@chromium.org> on 2009-11-17
Reviewed by Darin Adler.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElementData::shouldExecuteAsJavaScript):

LayoutTests: In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
Change the original test to pure js test, and test the situation about script tags which have text or language attribute.
​https://bugs.webkit.org/show_bug.cgi?id=31567

Patch by Johnny Ding <​jnd@chromium.org> on 2009-11-17
Reviewed by Darin Adler.

  • fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution-expected.txt:
  • fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html:
  • fast/dom/HTMLScriptElement/script-tests: Added.
  • fast/dom/HTMLScriptElement/script-tests/script-for-attribute-unexpected-execution.js: Added.

(ScriptForAttributeExecute):

4:31 PM Changeset in webkit [51096] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

<​http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run

Reviewed by Alexey Proskuryakov.

WebKitTools:

If the WebSocket server fails to start have DRT load an error page in place of tests that require the
server to be up rather than having run-webkit-tests abort immediately.

  • Scripts/run-webkit-tests:

LayoutTests:

  • websocket/resources/server-failed-to-start.html: Error page that will be loaded in place of websocket

tests when the server fails to start.

4:24 PM Changeset in webkit [51095] by dimich@chromium.org
  • 2 edits in trunk/WebKit/chromium

Revert r50887, it regressed handling of cmd-left when a text box is focused.
​https://bugs.webkit.org/show_bug.cgi?id=31566

Patch by Nicolas Weber <​thakis@chromium.org> on 2009-11-17
Reviewed by Darin Fisher, Dmitry Titov.

  • src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::keyboardEvent):

4:08 PM CommitQueue edited by thakis@chromium.org
(diff)
3:38 PM Changeset in webkit [51094] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

Implement DOMHTMLInputElement::replaceCharactersInRange().

​https://bugs.webkit.org/show_bug.cgi?id=31492

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::replaceCharactersInRange):
Get the text of the input field. Replace the given range with the
replacement text, and set this new string as the input element's value.
Select from index to the end of the field. This matches the
implementation in the Obj-C bindings.

3:37 PM Changeset in webkit [51093] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

DOMHTMLOptionElement is missing some functionality.

​https://bugs.webkit.org/show_bug.cgi?id=31491

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp:

(DOMHTMLOptionElement::text):
Cast m_element to an HTMLOptionElement, and call its text() function.
(DOMHTMLOptionElement::label):
Ditto, for label().

3:37 PM Changeset in webkit [51092] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

DOMHTMLSelectElement is missing some implementation.

​https://bugs.webkit.org/show_bug.cgi?id=31489

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp:

(DOMHTMLSelectElement::options):
Cast m_element to an HTMLSelectElement. If it has no options, return
E_FAIL. Otherwise, create a DOMHTMLOptionsCollection to wrap the
options, and return it.
(DOMHTMLSelectElement::activateItemAtIndex):
If the index is out of bounds, return E_FAIL. Otherwise, select the
item.

3:37 PM Changeset in webkit [51091] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKit/win

DOMHTMLOptionsCollection is missing some implementation.

​https://bugs.webkit.org/show_bug.cgi?id=31488

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp:

(DOMHTMLOptionsCollection::DOMHTMLOptionsCollection):
Initialize m_collection.
(DOMHTMLOptionsCollection::createInstance):
Create a DOMHTMLOptionsCollection. If we fail to query for
IDOMHTMLOptionsCollection, delete it, and return 0. Otherwise, return
the result.
(DOMHTMLOptionsCollection::length):
(DOMHTMLOptionsCollection::item):
Create a DOMNode for the WebCore Node. If this is 0, return E_FAIL.
(DOMHTMLOptionsCollection::namedItem):
Correct the signature of this function.

  • DOMHTMLClasses.h:

Declare DOMHTMLOptionsCollection::createInstance(). Correct the
signature of namedItem() to match IDOMHTMLOptionsCollection. Add a
member to DOMHTMLOptionsCollection to hold the WebCore object.

3:37 PM Changeset in webkit [51090] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

DOMHTMLInputElement::rectOnScreen() returns the wrong rect

​https://bugs.webkit.org/show_bug.cgi?id=31487

Reviewed by Darin Adler.

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::rectOnScreen):
Return the rect on screen, not the rect in the window.

2:07 PM Changeset in webkit [51089] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Pavel Feldman.

Skip inspector tests that are flaky on Windows Release - this is being tracked by:
​https://bugs.webkit.org/show_bug.cgi?id=31596.

  • platform/win/Skipped:
1:40 PM Changeset in webkit [51088] by jparent@chromium.org
  • 4 edits in trunk/LayoutTests

Eliminate flakiness in char-encoding tests by removing setTimeout,
that was working around an old issue.
​https://bugs.webkit.org/show_bug.cgi?id=31571

Reviewed by Darin Adler.

  • fast/encoding/char-encoding-mac.html:
  • fast/encoding/char-encoding.html:
  • fast/encoding/resources/char-encoding-utils.js:
1:30 PM Changeset in webkit [51087] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed buildbot fix.

Revert part of earlier patch and add comment, as it
was causing timeouts on the buildbot.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::notifyDone):

12:38 PM Changeset in webkit [51086] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-11-17 Martin Robinson <​martin.james.robinson@gmail.com>

Reviewed by Adam Barth.

[GTK] Style cleanup for GOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=31506

Remove forward declaration in GOwnPtr and do some style cleanup.

  • wtf/GOwnPtr.cpp:
  • wtf/GOwnPtr.h: (WTF::GOwnPtr::GOwnPtr): (WTF::GOwnPtr::~GOwnPtr): (WTF::GOwnPtr::get): (WTF::GOwnPtr::release): (WTF::GOwnPtr::outPtr): (WTF::GOwnPtr::set): (WTF::GOwnPtr::clear): (WTF::GOwnPtr::operator*): (WTF::GOwnPtr::operator->): (WTF::GOwnPtr::operator!): (WTF::GOwnPtr::operator UnspecifiedBoolType): (WTF::GOwnPtr::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::getPtr): (WTF::freeOwnedGPtr):
12:11 PM Changeset in webkit [51085] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-11-17 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

commit-queue is failing to set reviewer in ChangeLogs
​https://bugs.webkit.org/show_bug.cgi?id=31592

  • Scripts/bugzilla-tool: Clarify the "applying" log message.
  • Scripts/modules/bugzilla.py:
    • Add a new _validate_committer_and_reviewer function as a temporary solution until we can make a real Attachment object which knows how to fill in its committer/reviewer fields automatically.
12:05 PM Changeset in webkit [51084] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Make the timeout 15 sec as for the other DRT's and make
it print out the same output when a test timeout.

Reviewed by Oliver Hunt.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::waitUntilDone):
(LayoutTestController::notifyDone):
(LayoutTestController::timerEvent):

11:56 AM Changeset in webkit [51083] by yael.aharon@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] QGLLauncher does not support drag&drop of local files
​https://bugs.webkit.org/show_bug.cgi?id=31057

Reviewed by Kenneth Rohde Christiansen.

Enable accepting files in QGraphicsWebView.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::QGraphicsWebView):
(QGraphicsWebView::dragEnterEvent):

11:33 AM Changeset in webkit [51082] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Correct build error in Debug_Cairo target after @49705.

Reviewed by NOBODY - Build Fix.

  • WebKit.vcproj/WebKit.vcproj: Revise JavaScriptCore.lib dependency to have proper "_debug" suffix needed by the Debug_Cairo target.
11:27 AM Web Inspector edited by timothy@apple.com
(diff)
11:26 AM WebInspector created by timothy@apple.com
Copied from Web Inspector
11:11 AM Changeset in webkit [51081] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/inspector/InspectorController.cpp

Touch InspectorController to force the Inspector HTML and JS files to be
updated.

10:57 AM Changeset in webkit [51080] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Not reviewed, follow up to r51072: rename skipped entries

  • platform/qt/Skipped:
10:52 AM Changeset in webkit [51079] by Joseph Pecoraro
  • 2 edits in trunk/WebKitTools

2009-11-17 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Fixed typos in comments.

  • Scripts/modules/committers.py:
10:42 AM Changeset in webkit [51078] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Crashing tests after updating to Qt-4.6.0
​https://bugs.webkit.org/show_bug.cgi?id=31591

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped: Put tests into skiplist temporarily.
10:37 AM Changeset in webkit [51077] by bweinstein@apple.com
  • 4 edits in trunk/WebKit/win

Touch files to try to fix the build.

Reviewed by NOBODY - Build Fix.

  • Interfaces/IWebInspector.idl:
  • Interfaces/WebKit.idl:
  • WebKit.vcproj/Interfaces.vcproj:
9:55 AM Changeset in webkit [51076] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] better test coverage for ErrorPageExtension
​https://bugs.webkit.org/show_bug.cgi?id=31583

Reviewed by Kenneth Christiansen.

Improved the coverage of current ErrorPageExtension tests by
adding autotests involving frameset and iframes.

  • tests/qwebpage/tst_qwebpage.cpp:

(ErrorPage::extension): Make the ErrorPageExtension
to work for all frames, not only the main frame.
(tst_QWebPage::errorPageExtension): Stop using
the 'frameset.html' resouce in this method since
an autotest specific for frameset's is being added.
(tst_QWebPage::errorPageExtensionInIFrames): Added.
(tst_QWebPage::errorPageExtensionInFrameset): Added.

6:14 AM Changeset in webkit [51075] by pfeldman@chromium.org
  • 1 edit
    6 moves
    2 adds in trunk/LayoutTests

2009-11-17 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed, tests fix. Follow up to r51072: move
platform-specific results for fast/inspector into
fast/inspector-support.

  • platform/mac/fast/inspector-support/matchedrules-expected.checksum: Renamed from LayoutTests/platform/mac/fast/inspector/matchedrules-expected.checksum.
  • platform/mac/fast/inspector-support/matchedrules-expected.png: Renamed from LayoutTests/platform/mac/fast/inspector/matchedrules-expected.png.
  • platform/mac/fast/inspector-support/matchedrules-expected.txt: Renamed from LayoutTests/platform/mac/fast/inspector/matchedrules-expected.txt.
  • platform/mac/fast/inspector-support/style-expected.txt: Renamed from LayoutTests/platform/mac/fast/inspector/style-expected.txt.
  • platform/qt/fast/inspector-support/matchedrules-expected.txt: Renamed from LayoutTests/platform/qt/fast/inspector/matchedrules-expected.txt.
  • platform/qt/fast/inspector-support/style-expected.txt: Renamed from LayoutTests/platform/qt/fast/inspector/style-expected.txt.
5:54 AM Changeset in webkit [51074] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Actually skip the inspector console tests while the problem
discussed in ​https://bugs.webkit.org/show_bug.cgi?id=31472 is
fixed.

5:38 AM Changeset in webkit [51073] by pfeldman@chromium.org
  • 5 edits in trunk

2009-11-17 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed, build fix. Follow up to r51072: rename skipped entries
for the tests that were moved. Also skipped console tests on GTK
while investigating and touched Interfaces.vcproj to clobber win bot.


  • platform/gtk/Skipped:
  • platform/qt/Skipped:
5:11 AM Changeset in webkit [51072] by pfeldman@chromium.org
  • 37 edits
    10 moves
    2 adds in trunk

2009-11-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Make DRT show web inspector for tests in inspector/ folder.

  • Updated DRT to show/close inspector for all tests under /inspector
  • Introduced LayoutTestController::setTimelineProfilingEnabled and WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
  • Removed reload on each inspector test
  • Renamed fast/inspector to fast/inspector-support in order not to trigger inspector for those.
  • Reimplemented timeline tests in order to get rid of reload there.
  • Moved tests that don't require harness into the fast group.

​https://bugs.webkit.org/show_bug.cgi?id=31472

WebCore:

  • WebCore.Inspector.exp:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord):

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp: (setTimelineProfilingEnabledCallback): (closeWebInspectorCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldOpenWebInspector): (runTest):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setTimelineProfilingEnabled):
  • DumpRenderTree/mac/DumpRenderTree.mm: (shouldOpenWebInspector): (runTest):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setTimelineProfilingEnabled):
  • DumpRenderTree/win/DumpRenderTree.cpp: (shouldOpenWebInspector): (runTest):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setTimelineProfilingEnabled):

LayoutTests:

  • fast/inspector-support/cssURLQuotes-expected.txt: Renamed from LayoutTests/fast/inspector/cssURLQuotes-expected.txt.
  • fast/inspector-support/cssURLQuotes.html: Renamed from LayoutTests/fast/inspector/cssURLQuotes.html.
  • fast/inspector-support/matchedrules.html: Renamed from LayoutTests/fast/inspector/matchedrules.html.
  • fast/inspector-support/style.html: Renamed from LayoutTests/fast/inspector/style.html.
  • fast/inspector-support/uncaught-dom1-exception-expected.txt: Renamed from LayoutTests/inspector/uncaught-dom1-exception-expected.txt.
  • fast/inspector-support/uncaught-dom1-exception.html: Renamed from LayoutTests/inspector/uncaught-dom1-exception.html.
  • fast/inspector-support/uncaught-dom3-exception-expected.txt: Renamed from LayoutTests/inspector/uncaught-dom3-exception-expected.txt.
  • fast/inspector-support/uncaught-dom3-exception.html: Renamed from LayoutTests/inspector/uncaught-dom3-exception.html.
  • fast/inspector-support/uncaught-dom8-exception-expected.txt: Renamed from LayoutTests/inspector/uncaught-dom8-exception-expected.txt.
  • fast/inspector-support/uncaught-dom8-exception.html: Renamed from LayoutTests/inspector/uncaught-dom8-exception.html.
  • inspector/inspector-test.js: (onload): (evaluateInWebInspector): (notifyDone):
  • inspector/resources/timeline-iframe-data.html: Added.
  • inspector/timeline-layout-expected.txt:
  • inspector/timeline-layout.html:
  • inspector/timeline-mark-timeline.html:
  • inspector/timeline-paint.html:
  • inspector/timeline-parse-html-expected.txt:
  • inspector/timeline-parse-html.html:
  • inspector/timeline-recalculate-styles-expected.txt:
  • inspector/timeline-recalculate-styles.html:
  • inspector/timeline-script-tag-1-expected.txt:
  • inspector/timeline-script-tag-1.html:
  • inspector/timeline-script-tag-2-expected.txt:
  • inspector/timeline-script-tag-2.html:
  • inspector/timeline-script-tag-2.js:
  • inspector/timeline-test.js: (printTimelineRecords): (): (dumpTimelineRecords): (printProps): (frontend_getTimelineResults):

WebKit/mac:

WebKit/win:

  • Interfaces/IWebInspector.idl:
  • WebInspector.cpp: (WebInspector::isTimelineProfilingEnabled): (WebInspector::setTimelineProfilingEnabled):
  • WebInspector.h:

WebKit/gtk:

  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_class_init): (webkit_web_inspector_set_property): (webkit_web_inspector_get_property):
4:40 AM Changeset in webkit [51071] by benm@google.com
  • 1 edit
    4 adds in trunk/WebCore

[Android] Android is missing the implementation of the GeolocationService iface.
​https://bugs.webkit.org/show_bug.cgi?id=31554

Patch by Andrei Popescu <​andreip@google.com> on 2009-11-17
Reviewed by Dimitri Glazkov.

No new tests required as this is platform specific code.

  • platform/android/GeolocationServiceAndroid.cpp: Added.

(WebCore::GeolocationServiceAndroid::create):
(WebCore::GeolocationServiceAndroid::GeolocationServiceAndroid):
(WebCore::GeolocationServiceAndroid::startUpdating):
(WebCore::GeolocationServiceAndroid::stopUpdating):
(WebCore::GeolocationServiceAndroid::suspend):
(WebCore::GeolocationServiceAndroid::resume):
(WebCore::GeolocationServiceAndroid::newPositionAvailable):
(WebCore::GeolocationServiceAndroid::newErrorAvailable):
(WebCore::GeolocationServiceAndroid::timerFired):
(WebCore::GeolocationServiceAndroid::isPositionMovement):
(WebCore::GeolocationServiceAndroid::isPositionMoreAccurate):
(WebCore::GeolocationServiceAndroid::isPositionMoreTimely):

  • platform/android/GeolocationServiceAndroid.h: Added.

(WebCore::GeolocationServiceAndroid::~GeolocationServiceAndroid):
(WebCore::GeolocationServiceAndroid::lastPosition):
(WebCore::GeolocationServiceAndroid::lastError):

  • platform/android/GeolocationServiceBridge.cpp: Added.

(WebCore::):
(WebCore::GeolocationServiceBridge::GeolocationServiceBridge):
(WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
(WebCore::GeolocationServiceBridge::start):
(WebCore::GeolocationServiceBridge::stop):
(WebCore::GeolocationServiceBridge::setEnableGps):
(WebCore::GeolocationServiceBridge::newLocationAvailable):
(WebCore::GeolocationServiceBridge::newErrorAvailable):
(WebCore::GeolocationServiceBridge::toGeoposition):
(WebCore::GeolocationServiceBridge::startJavaImplementation):
(WebCore::GeolocationServiceBridge::stopJavaImplementation):

  • platform/android/GeolocationServiceBridge.h: Added.
1:36 AM Changeset in webkit [51070] by hamaji@chromium.org
  • 7 edits
    1 add in trunk/LayoutTests

2009-11-17 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Eric Seidel.

Fix http tests so that they do not submit a GET form to about:blank.

Original tests expected that submitting an empty form to <about:blank> navigates
the browser to <about:blank?>, not <about:blank>. However, some other browsers
do not act like Safari, and in fact the layout test runner of Chromium was
failing to run these tests.

Prior to this patch, a test that only checks this behavior was added, so now
we can remove the dependency on it from these tests.

Some HTTP tests submit a GET form to about:blank
​https://bugs.webkit.org/show_bug.cgi?id=30423

  • http/tests/navigation/onload-navigation-iframe-2-expected.txt:
  • http/tests/navigation/onload-navigation-iframe-2.html:
  • http/tests/navigation/onload-navigation-iframe-expected.txt:
  • http/tests/navigation/onload-navigation-iframe-timeout-expected.txt:
  • http/tests/navigation/onload-navigation-iframe-timeout.html:
  • http/tests/navigation/onload-navigation-iframe.html:
  • http/tests/navigation/resources/blank.txt: Added.
1:27 AM Changeset in webkit [51069] by hamaji@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-11-17 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Darin Adler.

Add a test to check the behavior of submitting a GET form to <about:blank>.

Currently Safari redirects the browser to <about:blank?>, while some other
browsers do not (including Firefox and Chromium). The objective of this test is
to express the current behavior of Safari and to become ready to remove
unintentional dependency on it from several tests.

Some HTTP tests submit a GET form to about:blank
​https://bugs.webkit.org/show_bug.cgi?id=30423

  • fast/forms/get-forms-to-about-blank-expected.txt: Added.
  • fast/forms/get-forms-to-about-blank.html: Added.
12:41 AM Changeset in webkit [51068] by oliver@apple.com
  • 6 edits in trunk

Incorrect use of JavaScriptCore API in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=31577

Reviewed by Maciej Stachowiak

Return undefined rather than a literal null.

Note: See TracTimeline for information about the timeline view.