Timeline
Nov 19, 2009:
- 11:01 PM Changeset in webkit [51232] by
-
- 2 edits in trunk/WebKitTools
2009-11-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
https://bugs.webkit.org/show_bug.cgi?id=31707
This is to help when we implement build-attachment.
- Scripts/bugzilla-tool:
- 10:43 PM Changeset in webkit [51231] by
-
- 3 edits2 copies in trunk/WebKitTools
2009-11-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Support Qt port in bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31701
Now we support building with Qt!
- Scripts/bugzilla-tool:
- Scripts/modules/webkitport.py: Added.
- Scripts/modules/webkitport_unittest.py: Added.
- Scripts/run-webkit-unittests:
- 10:20 PM Changeset in webkit [51230] by
-
- 3 edits in trunk/WebKitTools
2009-11-19 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Adam Barth.
Remove inserting stderr into patch in bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=29914
Modify SCM python module's run_command function to avoid return of stderr
by default, so stderr won't be inserted into the patches.
Modify the related unit test.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- 10:17 PM Changeset in webkit [51229] by
-
- 2 edits in trunk/WebCore
2009-11-19 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Resync Resources Backend and Frontend
https://bugs.webkit.org/show_bug.cgi?id=31705
- inspector/front-end/Resource.js: resync enum values with backend (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): return false if all else fails, not true in all cases
- 10:03 PM Changeset in webkit [51228] by
-
- 4 edits in trunk
2009-11-19 Steve Block <steveblock@google.com>
Android port lacks configuration in Platform.h and config.h.
https://bugs.webkit.org/show_bug.cgi?id=31671
- wtf/Platform.h: Modified. Added Android-specific configuration.
2009-11-19 Steve Block <steveblock@google.com>
Reviewed by Darin Fisher.
Android port lacks configuration in Platform.h and config.h.
https://bugs.webkit.org/show_bug.cgi?id=31671
Build change only. No new tests possible.
- config.h: Modified. Added Android-specific configuration.
- 9:44 PM Changeset in webkit [51227] by
-
- 3 edits2 adds in trunk
2009-11-20 Roland Steiner <rolandsteiner@chromium.org>
WebCore: Change default stylesheet to reset text indentation for ruby elements by default.
(https://bugs.webkit.org/show_bug.cgi?id=31247)
Reviewed by Darin Adler.
Test: fast/ruby/ruby-text-indent.html
- css/html.css: reset text-indent on <ruby> and <rt> elements
LayoutTests: Test checking that CSS 'text-indent' does not affect ruby rendering by default.
(https://bugs.webkit.org/show_bug.cgi?id=31247)
Reviewed by Darin Adler.
- fast/ruby/ruby-text-indent-expected.txt: Added.
- fast/ruby/ruby-text-indent.html: Added.
- 6:18 PM Changeset in webkit [51226] by
-
- 3 edits in trunk/WebKitTools
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool needs per-command help
https://bugs.webkit.org/show_bug.cgi?id=31697
Added support for "bugzilla-tool help command-name"
and a unit test to make sure it works.
- Scripts/modules/multicommandtool.py:
- Scripts/modules/multicommandtool_unittest.py:
- 6:12 PM Changeset in webkit [51225] by
-
- 2 edits in trunk/WebCore
Fixes <http://webkit.org/b/22754>.
Web Inspector: Keyboard shortcut for Element finder.
Reviewed by Darin Adler.
Use Command + Shift + C as a shortcut for Node Search, to
match the Firebug shortcut to do the same thing.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleKeyEvent):
- 5:09 PM Changeset in webkit [51224] by
-
- 12 edits in trunk/WebKit/chromium
2009-11-19 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Make chromium/webkit/glue/FormFieldValues use the WebKit API
- public/WebElement.h:
- public/WebFormElement.h:
- public/WebInputElement.h: (WebKit::WebInputElement::):
- public/WebNode.h:
- src/AssertMatchingEnums.cpp:
- src/DOMUtilitiesPrivate.cpp: (WebKit::nameOfInputElement):
- src/DOMUtilitiesPrivate.h:
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill): (WebKit::EditorClientImpl::doAutofill):
- src/WebFormElement.cpp: (WebKit::WebFormElement::name): (WebKit::WebFormElement::method): (WebKit::WebFormElement::getNamedElements): (WebKit::WebFormElement::getInputElements):
- src/WebInputElement.cpp: (WebKit::WebInputElement::isEnabledFormControl): (WebKit::WebInputElement::inputType): (WebKit::WebInputElement::formControlType): (WebKit::WebInputElement::value): (WebKit::WebInputElement::dispatchFormControlChangeEvent): (WebKit::WebInputElement::setSelectionRange): (WebKit::WebInputElement::name): (WebKit::WebInputElement::nameForAutofill):
- src/WebNode.cpp: (WebKit::WebNode::frame):
- 4:55 PM Changeset in webkit [51223] by
-
- 3 edits2 adds in trunk/WebKitTools
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move MultiCommandTool and Command into a separate file and add some basic unit tests
https://bugs.webkit.org/show_bug.cgi?id=31695
- Scripts/bugzilla-tool:
- Scripts/modules/multicommandtool.py: Added.
- Scripts/modules/multicommandtool_unittest.py: Added.
- Scripts/run-webkit-unittests:
- 4:53 PM Changeset in webkit [51222] by
-
- 13 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31690
Make SocketStreamHandleCFNet work on Windows
- WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.
- platform/network/ResourceHandle.h: Removed loaderRunLoop().
- platform/network/cf/LoaderRunLoopCF.cpp: Added. (WebCore::emptyPerform): (WebCore::runLoaderThread): (WebCore::loaderRunLoop):
- platform/network/cf/LoaderRunLoopCF.h: Added. Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because it's needed for more than just resource loading.
- platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.
- platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.
- platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to main thread.
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of inoperable main run loop.
(WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::readStreamCallbackMainThread):
(WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
Forward stream events to main thread on Windows.
- 4:47 PM Changeset in webkit [51221] by
-
- 2 edits in trunk/WebCore
2009-11-19 Avi Drissman <avi@chromium.org>
Reviewed by Darin Adler.
Quick style fix.
https://bugs.webkit.org/show_bug.cgi?id=27777
- platform/graphics/cg/PDFDocumentImage.cpp:
- 4:30 PM Changeset in webkit [51220] by
-
- 2 edits1 delete in trunk/LayoutTests/platform/win/fast/table
Update Windows expected pixel results, and remove the RenderTree results, because they are the same as the Mac.
- 4:25 PM Changeset in webkit [51219] by
-
- 3 edits in trunk/WebCore
Build fix. No review needed.
- platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaButton):
- 4:02 PM Changeset in webkit [51218] by
-
- 2 edits in trunk/WebCore
Build fix. No review needed.
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintCheckbox):
(WebCore::RenderThemeChromiumSkia::paintRadio):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
- 3:58 PM Changeset in webkit [51217] by
-
- 3 edits in trunk/WebCore
Build fix. No review needed.
- platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::draw):
- platform/graphics/qt/StillImageQt.h:
- 3:53 PM Changeset in webkit [51216] by
-
- 2 edits in trunk/WebCore
Build fix. No review needed.
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
- 3:50 PM Changeset in webkit [51215] by
-
- 2 edits in trunk/WebCore
Build fix. No review needed.
- plugins/PluginView.cpp:
(WebCore::PluginView::paintMissingPluginIcon):
- 3:46 PM Changeset in webkit [51214] by
-
- 2 edits in trunk/WebCore
Build fix. No review needed.
- platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
- 3:38 PM Changeset in webkit [51213] by
-
- 2 edits in trunk/WebKitTools
2009-11-19 Eric Seidel <eric@webkit.org>
No review, just adding a FIXME.
Split out command parsing and help printing from BugzillaTool
https://bugs.webkit.org/show_bug.cgi?id=31688
- Scripts/bugzilla-tool: Add an extra comment about current design failures.
- 3:36 PM Changeset in webkit [51212] by
-
- 42 edits9 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
color-correction work with untagged images
Reviewed by Darin Adler.
Image's draw(), drawPattern(), and fillWithSolidColor() functions
now take a ColorSpace. A bunch of classes inherit from Image, so
draw() and drawPattern() functions there must also take a
ColorSpace.
- platform/graphics/Image.cpp:
(WebCore::Image::fillWithSolidColor):
(WebCore::Image::drawTiled):
- platform/graphics/Image.h:
- platform/graphics/BitmapImage.h:
- platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::draw):
(WebCore::GeneratedImage::drawPattern):
- platform/graphics/GeneratedImage.h:
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::draw):
- platform/graphics/cg/PDFDocumentImage.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):
- svg/graphics/SVGImage.h:
All of the drawImage() functions and drawTiled() functions of
GraphicsContext now take a ColorSpace.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
This is where the actual work is done.
- platform/graphics/cg/ImageCG.cpp:
(WebCore::imageWithColorSpace): New static function that returns a
copy of the given image in the given ColorSpace *IF* we should use
the given ColorSpace. We will ignore the color space if the image
is tagged and return 0.
(WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to
call imageWithColorSpace().
(WebCore::Image::drawPattern): Same.
Attempt to keep all ports building.
- platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
- platform/graphics/haiku/ImageHaiku.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
- platform/graphics/qt/ImageQt.cpp:
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
- platform/graphics/skia/BitmapImageSingleFrameSkia.h:
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):
- platform/graphics/wx/ImageWx.cpp:
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::drawPattern):
Callers of GraphicsContext's drawImage() and drawTiled() functions
now need to send a ColorSpace.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::apply):
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::apply):
- platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::apply):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintResizer):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
- rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
- svg/graphics/SVGPaintServerPattern.cpp:
(WebCore::SVGPaintServerPattern::setup):
- svg/graphics/SVGResourceFilter.cpp:
(WebCore::SVGResourceFilter::applyFilter):
- svg/graphics/filters/SVGFEMerge.cpp:
(WebCore::FEMerge::apply):
- svg/graphics/filters/SVGFEOffset.cpp:
(WebCore::FEOffset::apply):
- svg/graphics/filters/SVGFETile.cpp:
(WebCore::FETile::apply):
LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=31321 Make
-webkit-color-correction work with untagged images
Reviewed by Darin Adler.
- fast/css/color-correction-on-background-image.html: Added.
- fast/css/color-correction-untagged-images.html: Added.
- fast/css/resources/purple-noprofile.png: Added.
- platform/mac/fast/css/color-correction-on-background-image-expected.checksum: Added.
- platform/mac/fast/css/color-correction-on-background-image-expected.png: Added.
- platform/mac/fast/css/color-correction-on-background-image-expected.txt: Added.
- platform/mac/fast/css/color-correction-untagged-images-expected.checksum: Added.
- platform/mac/fast/css/color-correction-untagged-images-expected.png: Added.
- platform/mac/fast/css/color-correction-untagged-images-expected.txt: Added.
- 3:32 PM Changeset in webkit [51211] by
-
- 2 edits in trunk/JavaScriptCore
isMainThread() on Chromium (Mac and Linux) is so slow it timeouts LayoutTests..
https://bugs.webkit.org/show_bug.cgi?id=31693
Reviewed by David Levin.
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): grab and use the pthread_t of the main thread instead of ThreadIdentifier.
(WTF::isMainThread): Ditto.
- 3:30 PM Changeset in webkit [51210] by
-
- 3 edits in trunk/LayoutTests
2009-11-19 Michelangelo De Simone <Michelangelo De Simone>
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>
Files missed when landing patch.
- platform/qt/Skipped:
- platform/win/Skipped:
- 3:28 PM Changeset in webkit [51209] by
-
- 2 edits in trunk/WebKitTools
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Split out command parsing and help printing from BugzillaTool
https://bugs.webkit.org/show_bug.cgi?id=31688
- Scripts/bugzilla-tool:
- Add new MultiCommandTool class to contain option parsing and help printing logic.
- Rename private methods to use _ pattern.
- MultiCommandTool has two abstract methods should_show_command_help and should_execute_command. -
- 3:21 PM Changeset in webkit [51208] by
-
- 2 edits in trunk/WebKitTools
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Re-factor help printing to use modern python idioms
https://bugs.webkit.org/show_bug.cgi?id=31685
- Scripts/bugzilla-tool:
- 3:12 PM Changeset in webkit [51207] by
-
- 4 edits in trunk/WebCore
2009-11-19 Avi Drissman <avi@chromium.org>
Reviewed by Darin Adler.
Properly create a CGImageRef on non-PLATFORM(MAC).
https://bugs.webkit.org/show_bug.cgi?id=27777
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::sharedBufferGetBytesAtPosition): (WebCore::sharedBufferRelease): (WebCore::ImageSource::setData):
- platform/graphics/cg/ImageSourceCG.h:
- platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged):
- 2:16 PM Changeset in webkit [51206] by
-
- 2 edits in trunk/LayoutTests
Trying to enable WebSocket tests on Tiger again, as the bot seems to behave now.
- platform/mac-tiger/Skipped:
- 2:04 PM Changeset in webkit [51205] by
-
- 2 edits1 add in trunk/WebCore
-webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
https://bugs.webkit.org/show_bug.cgi?id=31656
Reviewed Dave Hyatt
Make sure we're a child of the painting root before drawing overflow features.
- 1:29 PM Changeset in webkit [51204] by
-
- 2 edits in trunk/WebCore
Not reviewed, attempt to fix Chromium build.
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.
- 1:02 PM Changeset in webkit [51203] by
-
- 2 edits in trunk/WebKitTools
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
commit-queue empty queue logs twice
https://bugs.webkit.org/show_bug.cgi?id=31679
- Scripts/bugzilla-tool:
- 12:28 PM Changeset in webkit [51202] by
-
- 2 edits in trunk/WebKitTools
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
bugzilla-tool's reviewer/committer rejection message should be clearer
https://bugs.webkit.org/show_bug.cgi?id=31126
Add more explanatory prose to bugzilla-tool's flag permission rejection message.
- Scripts/modules/bugzilla.py:
- 12:25 PM Changeset in webkit [51201] by
-
- 3 edits2 adds in trunk
2009-11-19 Rahul Kuchhal <kuchhal@chromium.org>
Reviewed by Darin Adler.
Do not assert when a high number is used for roman numerals in lists.
https://bugs.webkit.org/show_bug.cgi?id=31652
- fast/lists/ol-start-roman.html: Added.
- platform/mac/fast/lists/ol-start-roman-expected.txt: Added.
2009-11-19 Rahul Kuchhal <kuchhal@chromium.org>
Reviewed by Darin Adler.
Do not assert when a high number is used for roman numerals in lists.
https://bugs.webkit.org/show_bug.cgi?id=31652
Test: fast/lists/ol-start-roman.html
- rendering/RenderListMarker.cpp: (WebCore::toRoman): Increase the char array size.
- 12:14 PM Changeset in webkit [51200] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Oliver Hunt.
Add translatable strings to cover validationMessage, after
r51172. Already covered by existing test.
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
- 12:12 PM Changeset in webkit [51199] by
-
- 3 edits in trunk/JavaScriptCore
2009-11-19 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Remove HAVE(STRING_H) guard from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=31668
- config.h:
- runtime/UString.cpp:
- 11:59 AM Changeset in webkit [51198] by
-
- 2 edits in trunk/JavaScriptCore
Fixing a bug in MessageQueue::removeIf() that leads to an
assertion failure.
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=31657
- wtf/MessageQueue.h:
(WTF::MessageQueue::removeIf):
- 11:54 AM Changeset in webkit [51197] by
-
- 9 edits in trunk
2009-11-19 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Remove HAVE(FLOAT_H) guard
https://bugs.webkit.org/show_bug.cgi?id=31661
JavaScriptCore has a dependency on float.h, there is
no need to guard float.h.
- runtime/DatePrototype.cpp: Remove include directive for float.h as it is included in MathExtras.h already.
- runtime/Operations.cpp: Ditto.
- runtime/UString.cpp: Ditto.
- wtf/dtoa.cpp: Ditto.
- wtf/MathExtras.h: Remove HAVE(FLOAT_H) guard.
- wtf/Platform.h: Ditto.
2009-11-19 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Remove HAVE(FLOAT_H) guard
https://bugs.webkit.org/show_bug.cgi?id=31661
WebCore has a dependency on float.h, there is
no need to guard float.h.
No new tests as there is no functional change.
- html/HTMLInputElement.cpp: Remove include directive for float.h as it is included in MathExtras.h already.
- 11:41 AM Changeset in webkit [51196] by
-
- 6 edits in trunk
2009-11-19 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Updated timeline paint test to ignore width and height. GTK+ testing
uses a different top level window size than other platforms.
- inspector/timeline-paint-expected.txt:
- inspector/timeline-test.js:
- platform/win/Skipped:
2009-11-19 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Forces a WM_PAINT event on calling layoutTestController.display()
in order to enable the timeline-paint.html test on Windows.
::UpdateWindow() does not force an event becaue the window is
not visible.
- DumpRenderTree/win/DumpRenderTree.cpp: (displayWebView):
- 11:28 AM Changeset in webkit [51195] by
-
- 8 edits2 adds in trunk
2009-11-19 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
WAI-ARIA roles not supported on image map <area>
https://bugs.webkit.org/show_bug.cgi?id=31525
- accessibility/aria-used-on-image-maps-expected.txt: Added.
- accessibility/aria-used-on-image-maps.html: Added.
- platform/gtk/Skipped:
- platform/win/Skipped:
- 11:03 AM Changeset in webkit [51194] by
-
- 2 edits in trunk/WebCore
2009-11-19 Simon Fraser <Simon Fraser>
Reviewed by Pavel Feldman.
Instrumentation should account for painting in compositing layers
https://bugs.webkit.org/show_bug.cgi?id=31674
Add calls to InspectorTimelineAgent for painting into compositing layers,
which is not accounted for in FrameView::paintContents().
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): Avoid fetching the FrameView multiple times.
(WebCore::inspectorTimelineAgent):
(WebCore::RenderLayerBacking::paintContents):
- 10:21 AM Changeset in webkit [51193] by
-
- 2 edits in trunk/WebKitTools
2009-11-19 Michelangelo De Simone <Michelangelo De Simone>
No review needed.
Added myself to committers list.
- Scripts/modules/committers.py:
- 10:16 AM Changeset in webkit [51192] by
-
- 2 edits in trunk/WebKitTools
2009-11-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Bugzilla-tool command classes should match command names
https://bugs.webkit.org/show_bug.cgi?id=31666
I renamed all the commands except CommitMessageForCurrentDiff because
the new name would conflict with an existing class.
- Scripts/bugzilla-tool:
- 10:14 AM Changeset in webkit [51191] by
-
- 49 edits3 adds in trunk
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/7035231>
Support closed caption in <video> element
Test: media/media-captions.html
- WebCore.base.exp:
- accessibility/AccessibilityMediaControls.cpp: (WebCore::AccessibilityMediaControl::controlTypeName):
Define ShowClosedCaptionsButton and HideClosedCaptionsButton.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Add MediaToggleClosedCaptionsButtonPart.
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
Define and match mediaControlsToggleClosedCaptionsButton.
- css/CSSSelector.h: (WebCore::CSSSelector::):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Define and match PseudoMediaControlsToggleClosedCaptions.
- css/CSSValueKeywords.in:
Define and use media-toggle-closed-captions-button.
- css/mediaControls.css:
- css/mediaControlsQuickTime.css:
Add webkit-media-controls-toggle-closed-captions-button.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):
Initialize m_closedCaptionsVisible.
(WebCore::HTMLMediaElement::loadInternal):
Set m_closedCaptionsVisible to false.
(WebCore::HTMLMediaElement::hasClosedCaptions):
(WebCore::HTMLMediaElement::closedCaptionsVisible):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
New, captions internal methods.
(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible):
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible):
(WebCore::HTMLMediaElement::webkitHasClosedCaptions):
New, captions DOM API.
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
Declare methods needed for captions API.
- platform/ThemeTypes.h:
Add MediaToggleClosedCaptionsButtonPart.
- platform/android/LocalizedStringsAndroid.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
Add empty implmentations.
- platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::hasClosedCaptions): (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
New, empty implementations of media engine closed caption functions.
(WebCore::MediaPlayer::hasClosedCaptions):
(WebCore::MediaPlayer::setClosedCaptionsVisible):
New, call media engine closed caption functions.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::hasClosedCaptions): (WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):
Declare new media engine methods.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::hasClosedCaptions): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
New, QTKit implementation of closed caption methods.
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText):
Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement):
Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
New, implement the closed caption toggle button,
- rendering/MediaControlElements.h:
Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
declare MediaControlToggleClosedCaptionsButtonElement.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange): (WebCore::RenderMedia::createToggleClosedCaptionsButton): (WebCore::RenderMedia::createStatusDisplay): (WebCore::RenderMedia::updateControls): (WebCore::RenderMedia::forwardEvent):
- rendering/RenderMedia.h:
Deal with m_toggleClosedCaptionsButton.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint):
Deal with MediaToggleClosedCaptionsButtonPart.
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
Declare paintMediaToggleClosedCaptionsButton.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
New.
(WebCore::RenderThemeMac::shouldRenderMediaControlPart):
Don't render captions toggle button unless we are using the new theme, the
movie has captions, and the movie is in a <video> element since we currently
rely on QTKit to render the captions.
- rendering/style/RenderStyleConstants.h:
Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/7035231>
Support closed caption in <video> element
- media/media-captions-expected.txt: Added.
- media/media-captions.html: Added.
- media/content/counting-captioned.mov: Added.
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/win/Skipped:
Skipped on platforms that don't support closed captions yet.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/7035231>
Support closed caption in <video> element
- English.lproj/Localizable.strings:
Add strings for toggle captions button.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/7035231>
Support closed caption in <video> element
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
Add QTMovieHasClosedCaptions and QTMovieSetShowClosedCaptions.
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaControlElementString:]): (-[WebViewFactory localizedMediaControlElementHelpText:]):
Add accessibility help strings for media controller closed caption button.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/7035231>
Support closed caption in <video> element
- WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText):
Add accessibility help strings for media controller closed caption button.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/7035231>
Support closed caption in <video> element
- WebKitSystemInterface.h:
Add prototypes for WKQTMovieHasClosedCaptions and WKQTMovieSetShowClosedCaptions,
define WKMediaUIPartToggleClosedCaptionsButton.
- 10:10 AM Changeset in webkit [51190] by
-
- 2 edits in trunk/WebCore
wx build fix. Add missing header.
- 9:43 AM Changeset in webkit [51189] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31634
Ignore realm for proxy protection spaces
Only affects WebSocket proxy authentication, cannot be tested in DRT.
- platform/network/ProtectionSpace.cpp: (WebCore::operator==):
- platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash):
- 9:42 AM Changeset in webkit [51188] by
-
- 7 edits in trunk
2009-11-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Gustavo Noronha Silva.
Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.
- platform/gtk/Skipped:
2009-11-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Gustavo Noronha Silva.
Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.
- webkit/webkitwebinspector.cpp: (webkit_web_inspector_show):
- webkit/webkitwebinspector.h:
2009-11-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Gustavo Noronha Silva.
Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector):
- 6:23 AM Changeset in webkit [51187] by
-
- 2 edits in trunk/WebKitTools
Minor refactoring + more documentation.
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::clearHistory):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 6:12 AM Changeset in webkit [51186] by
-
- 2 edits3 adds in trunk/WebKit/qt
2009-11-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add instantiation tests for QWebInspector.
- tests/qwebinspector/qwebinspector.pro: Added.
- tests/qwebinspector/tst_qwebinspector.cpp: Added. (tst_QWebInspector::attachAndDestroy):
- tests/tests.pro:
- 6:04 AM Changeset in webkit [51185] by
-
- 2 edits in trunk/WebKit/qt
2009-11-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix QWebInspector destruction problem.
https://bugs.webkit.org/show_bug.cgi?id=31664
- Api/qwebpage.cpp: (QWebPage::~QWebPage):
- 5:47 AM Changeset in webkit [51184] by
-
- 9 edits in trunk
[Qt] Normalize signal and slot signatures.
Patch by Olivier Goffart <ogoffart@trolltech.com> on 2009-11-19
Reviewed by Simon Hausmann.
WebCore:
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
WebKit/qt:
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::setPage):
- Api/qwebview.cpp:
(QWebView::setPage):
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::setFrame):
- docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp:
(wrapInFunction):
- tests/qwebframe/tst_qwebframe.cpp:
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::modified):
(tst_QWebPage::database):
- 5:46 AM Changeset in webkit [51183] by
-
- 2 edits in trunk/JavaScriptCore
Build fix for 32-bit Sparc machines: these machines are big-endian.
Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2009-11-19
Reviewed by Simon Hausmann.
- wtf/Platform.h:
- 5:03 AM Changeset in webkit [51182] by
-
- 7 edits in trunk/WebCore
2009-11-19 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Store cookie domains in the WebInspector object
The cookie domains have been moved from StoragePanel into WebInspector.
Also, the document URLs are now passed inside the WebInspector.addResource()
payload rather than pushed directly from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=31627
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didFinishLoading):
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addCookieDomain):
- inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.addCookieDomain): (WebInspector.reset):
- 4:32 AM Changeset in webkit [51181] by
-
- 5 edits4 adds15 deletes in trunk/LayoutTests
2009-11-19 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Some tests in fast/css-generated-content can be dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=31663
- fast/css-generated-content/absolute-position-inside-inline-expected.txt: Added.
- fast/css-generated-content/absolute-position-inside-inline.html:
- fast/css-generated-content/hit-test-generated-content-expected.txt: Added.
- fast/css-generated-content/hit-test-generated-content.html:
- fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Added.
- fast/css-generated-content/positioned-background-hit-test-crash.html:
- fast/css-generated-content/spellingToolTip-assert-expected.txt: Added.
- fast/css-generated-content/spellingToolTip-assert.html:
- platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.checksum: Removed.
- platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.png: Removed.
- platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.txt: Removed.
- platform/mac/fast/css-generated-content/hit-test-generated-content-expected.checksum: Removed.
- platform/mac/fast/css-generated-content/hit-test-generated-content-expected.png: Removed.
- platform/mac/fast/css-generated-content/hit-test-generated-content-expected.txt: Removed.
- platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.checksum: Removed.
- platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.png: Removed.
- platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Removed.
- platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.checksum: Removed.
- platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.png: Removed.
- platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.txt: Removed.
- platform/qt/fast/css-generated-content/absolute-position-inside-inline-expected.txt: Removed.
- platform/qt/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Removed.
- platform/qt/fast/css-generated-content/spellingToolTip-assert-expected.txt: Removed.
- 2:41 AM Changeset in webkit [51180] by
-
- 2 edits in trunk/WebKitTools
2009-11-19 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
Ignore websocket tests when --no-http is specified.
https://bugs.webkit.org/show_bug.cgi?id=31662
- Scripts/run-webkit-tests:
- 1:34 AM Changeset in webkit [51179] by
-
- 10 edits in trunk/WebCore
Allow custom memory allocation control for the other part of platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31585
Reviewed by Darin Adler.
Inherits the following classes from FastAllocBase because these are
instantiated by 'new':
class RegularExpression - instantiated at: WebCore/page/Frame.cpp:415
class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
class Path - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
class FontPlatformData - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188
Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:
class Cursors - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
class NetworkStateNotifier - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71
class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119
- platform/graphics/MediaPlayerPrivate.h:
- platform/graphics/Path.h:
- platform/graphics/qt/FontPlatformData.h:
- platform/graphics/transforms/TransformationMatrix.h:
- platform/image-decoders/ImageDecoder.h:
- platform/network/NetworkStateNotifier.h:
- platform/network/ResourceRequestBase.h:
- platform/qt/CursorQt.cpp:
- platform/text/RegularExpression.h:
- 12:15 AM Changeset in webkit [51178] by
-
- 5 edits in trunk/LayoutTests
Update the test fast/overflow/004.html to make it match the test
description and expected results.
https://bugs.webkit.org/show_bug.cgi?id=31455
Patch by Kinuko Yasuda <kinuko@google.com> on 2009-11-19
Reviewed by Dan Bernstein.
- fast/overflow/004.html:
- platform/mac/fast/overflow/004-expected.checksum:
- platform/mac/fast/overflow/004-expected.png:
- platform/mac/fast/overflow/004-expected.txt:
Nov 18, 2009:
- 11:18 PM Changeset in webkit [51177] by
-
- 2 edits in trunk/WebCore
2009-11-18 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
- platform/qt/Localizations.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
- 10:18 PM Changeset in webkit [51176] by
-
- 2 edits in trunk/WebKitTools
2009-11-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Normalize ' and " in bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31655
We decided " is better than ' and we should be consistent.
- Scripts/bugzilla-tool:
- 10:17 PM Changeset in webkit [51175] by
-
- 4 edits4 adds in trunk
WebCore: Fixed <rdar://problem/7398987> Assertion failure in
RenderLayer::updateClipRects when a plug-in’s enclosing layer is
enclosed by a transformed layer
Reviewed by Simon Fraser.
Tests: fast/layers/clip-rects-transformed-2.html
fast/layers/clip-rects-transformed.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
that is either transformed or composited. During painting and hit
testing, when a transformed or composited layer is hit, it becomes the
new root layer, which ultimately gets passed to calculateRects().
(WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
root layer to calculateRects(), and return the bounding box of the
transformed rectangle.
(WebCore::RenderLayer::selfClipRect): Ditto.
- rendering/RenderLayer.h:
LayoutTests: Test for <rdar://problem/7398987> Assertion failure in
RenderLayer::updateClipRects when a plug-in’s enclosing layer is
enclosed by a transformed layer
Reviewed by Simon Fraser.
- fast/layers/clip-rects-transformed-2-expected.txt: Added.
- fast/layers/clip-rects-transformed-2.html: Added.
- fast/layers/clip-rects-transformed-expected.txt: Added.
- fast/layers/clip-rects-transformed.html: Added.
- 10:03 PM Changeset in webkit [51174] by
-
- 36 edits6 deletes in trunk
2009-11-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469
- JavaScriptCore.pro:
- jsc.pro:
- wtf/unicode/qt4/UnicodeQt4.h:
2009-11-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469
- Api/qcookiejar.cpp: Removed.
- Api/qcookiejar.h: Removed.
- Api/qgraphicswebview.cpp: (QGraphicsWebView::event):
- Api/qwebframe.cpp: (QWebFrame::load):
- Api/qwebframe.h:
- Api/qwebkitglobal.h:
- Api/qwebnetworkinterface.cpp: Removed.
- Api/qwebnetworkinterface.h: Removed.
- Api/qwebnetworkinterface_p.h: Removed.
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::acceptNavigationRequest): (QWebPage::acceptNavigationRequest): (QWebPage::action): (QWebPage::userAgentForUrl):
- Api/qwebpage.h:
- Api/qwebpage_p.h:
- Api/qwebview.cpp: (QWebView::load): (QWebView::event):
- Api/qwebview.h:
- QtLauncher/main.cpp: (MainWindow::print): (MainWindow::setupUI): (main):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::download): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientQt::startDownload): (WebCore::FrameLoaderClientQt::createPlugin):
2009-11-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469
No new tests as there is no change if compiled with
Qt v4.4 or later version.
- WebCore.pro:
- dom/XMLTokenizerQt.cpp: (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::doWrite): (WebCore::XMLTokenizer::startDocument): (WebCore::XMLTokenizer::parseDtd):
- platform/graphics/qt/FontQt.cpp:
- platform/graphics/qt/FontQt43.cpp: Removed.
- platform/graphics/qt/ImageQt.cpp:
- platform/network/ResourceHandleInternal.h:
- platform/network/qt/QNetworkReplyHandler.cpp:
- platform/network/qt/QNetworkReplyHandler.h:
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::setDefersLoading):
- platform/network/qt/ResourceRequest.h:
- platform/network/qt/ResourceRequestQt.cpp:
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::clearData):
- platform/qt/CookieJarQt.cpp: (WebCore::cookieJar): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode): (WebCore::windowsKeyCodeForKeyEvent):
- platform/text/qt/TextBoundaries.cpp:
- platform/text/qt/TextBreakIteratorQt.cpp:
- plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
2009-11-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/ImageDiff.pro:
- 9:47 PM Changeset in webkit [51173] by
-
- 2 edits in trunk/WebKitTools
2009-11-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
GitTest.test_create_binary_patch fails if /tmp is symlink
https://bugs.webkit.org/show_bug.cgi?id=31536
- Scripts/modules/scm_unittest.py:
- 9:38 PM Changeset in webkit [51172] by
-
- 28 edits3 adds in trunk
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
- fast/dom/domListEnumeration-expected.txt: updated with new property
- fast/dom/script-tests/domListEnumeration.js: ditto
- fast/forms/script-tests/validationMessage.js: Added.
- fast/forms/validationMessage-expected.txt: Added.
- fast/forms/validationMessage.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
Test: fast/forms/validationMessage.html
- html/HTMLButtonElement.idl: validationMessage attribute
- html/HTMLFieldSetElement.idl: validationMessage attribute
- html/HTMLFormControlElement.cpp:
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.idl: validationMessage attribute
- html/HTMLSelectElement.idl: validationMessage attribute
- html/HTMLTextAreaElement.idl: validationMessage attribute
- html/ValidityState.cpp: new method to retrieve pertinent localized text
- html/ValidityState.h:
- page/mac/WebCoreViewFactory.h:
- platform/LocalizedStrings.h:
- platform/android/LocalizedStringsAndroid.cpp:
- platform/gtk/LocalizedStringsGtk.cpp:
- platform/haiku/LocalizedStringsHaiku.cpp:
- platform/mac/LocalizedStringsMac.mm:
- platform/wx/LocalizedStringsWx.cpp:
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
- English.lproj/Localizable.strings: new localizable strings
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
- src/LocalizedStrings.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory validationMessageValueMissingText]): (-[WebViewFactory validationMessageTypeMismatchText]): (-[WebViewFactory validationMessagePatternMismatchText]): (-[WebViewFactory validationMessageTooLongText]): (-[WebViewFactory validationMessageRangeUnderflowText]): (-[WebViewFactory validationMessageRangeOverflowText]): (-[WebViewFactory validationMessageStepMismatchText]):
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
- WebCoreLocalizedStrings.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
- 9:09 PM Changeset in webkit [51171] by
-
- 2 edits in trunk/WebCore
2009-11-18 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
Fix a typo. Remove the trailing semicolon
from an include directive after r51137.
No new tests as there is no functional change.
- platform/qt/QWebPageClient.h:
- 8:52 PM Changeset in webkit [51170] by
-
- 2 edits in trunk/WebCore
2009-11-18 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
Include float.h for DBL_MANT_DIG. Not sure why this
is not a problem for other ports.
- html/HTMLInputElement.cpp:
- 7:15 PM Changeset in webkit [51169] by
-
- 4 edits2 adds in trunk
WebCore: Bug 31574 - Crashing bug when removing <ruby> element
(https://bugs.webkit.org/show_bug.cgi?id=31574)
Reviewed by Darin Adler.
Cause of the bug:
1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
4.) this triggers the special handling of child removal in RenderRubyRun that
causes it to destroy itself
5.) On returning from all this the renderer crashes when accessing a member
or virtual function on this now illegal object.
I therefore added a flag that tracks if the ruby run is being destroyed.
If so, avoid doing the special handling in removeChild that caused this.
It's not the most elegant solution, but the easiest to implement without
touching unrelated code. Also, it's self-documenting.
Test: fast/ruby/ruby-remove.html
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::destroy):
(WebCore::RenderRubyRun::removeChild):
- rendering/RenderRubyRun.h:
LayoutTests: Bug 31574 - Crashing bug when removing <ruby> element
(https://bugs.webkit.org/show_bug.cgi?id=31574)
Reviewed by Darin Adler.
Layout test to verify it no longer crashes when the <ruby> element
is being removed.
- fast/ruby/ruby-remove-expected.txt: Added.
- fast/ruby/ruby-remove.html: Added.
- 7:12 PM Changeset in webkit [51168] by
-
- 7 edits in trunk/JavaScriptCore
2009-11-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Move UString::from(double) implementation to new
WTF::doubleToStringInJavaScriptFormat(), and expose it because WebCore
code will use it.
https://bugs.webkit.org/show_bug.cgi?id=31330
- Introduce new function createRep(const char*, unsigned) and UString::UString(const char*, unsigned) to reduce 2 calls to strlen().
- Fix a bug that dtoa() doesn't update *rve if the input value is NaN or Infinity.
No new tests because this doesn't change the behavior.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- runtime/UString.cpp: (JSC::createRep): (JSC::UString::UString): (JSC::UString::from): Move the code to doubleToStringInJavaScriptFormat().
- runtime/UString.h:
- wtf/dtoa.cpp: (WTF::dtoa): Fix a bug about rve. (WTF::append): A helper for doubleToStringInJavaScriptFormat(). (WTF::doubleToStringInJavaScriptFormat): Move the code from UString::from(double).
- wtf/dtoa.h:
- 6:53 PM Changeset in webkit [51167] by
-
- 3 edits in trunk/WebKitTools
2009-11-18 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Adler.
Configuration for Chromium Build Slaves.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 6:46 PM Changeset in webkit [51166] by
-
- 4 edits in trunk
2009-11-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=31643
- JavaScriptCore.pro:
2009-11-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=31643
No new tests as there is no functional change.
- WebCore.pro:
- 6:38 PM Changeset in webkit [51165] by
-
- 1 edit1 add in trunk/WebCore
2009-11-18 Yong Li <yong.li@torchmobile.com>
Reviewed by Eric Seidel.
Implement TextBoundaries for WINCE port.
https://bugs.webkit.org/show_bug.cgi?id=27371
- platform/text/wince/TextBoundariesWince.cpp: Added.
- 6:30 PM Changeset in webkit [51164] by
-
- 1 edit2 adds in trunk/WebCore
2009-11-18 Yong Li <yong.li@torchmobile.com>
Reviewed by Eric Seidel.
Implement TextBreakIterator for WINCE port.
https://bugs.webkit.org/show_bug.cgi?id=27371
- platform/text/wince/TextBreakIteratorWince.cpp: Added.
- 6:15 PM Changeset in webkit [51163] by
-
- 5 edits18 adds in trunk
2009-11-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Tests for ValidityState.typeMismatch for the following types of INPUT element:
date, datetime, datetime-local, month, time and week
- fast/forms/ValidityState-typeMismatch-date-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-date.html: Added.
- fast/forms/ValidityState-typeMismatch-datetime-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-datetime.html: Added.
- fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-datetimelocal.html: Added.
- fast/forms/ValidityState-typeMismatch-month-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-month.html: Added.
- fast/forms/ValidityState-typeMismatch-time-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-time.html: Added.
- fast/forms/ValidityState-typeMismatch-week-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-week.html: Added.
- fast/forms/script-tests/ValidityState-typeMismatch-date.js: Added.
- fast/forms/script-tests/ValidityState-typeMismatch-datetime.js: Added.
- fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js: Added.
- fast/forms/script-tests/ValidityState-typeMismatch-month.js: Added.
- fast/forms/script-tests/ValidityState-typeMismatch-time.js: Added.
- fast/forms/script-tests/ValidityState-typeMismatch-week.js: Added.
2009-11-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add support for ValidityState.typeMismatch for the following INPUT types:
date datetime datetime-local month time week
Tests: fast/forms/ValidityState-typeMismatch-date.html
fast/forms/ValidityState-typeMismatch-datetime.html
fast/forms/ValidityState-typeMismatch-datetimelocal.html
fast/forms/ValidityState-typeMismatch-month.html
fast/forms/ValidityState-typeMismatch-time.html
fast/forms/ValidityState-typeMismatch-week.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::formStringToISODateTime): Check the type validity of the specified type and string using the ISODateTime class.
- html/HTMLInputElement.h:
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): Check the type validity for date, datetime, datetime-local, month, time and week with HTMLInputElemtn::formStringToISODateTime()
- 6:13 PM Changeset in webkit [51162] by
-
- 4 edits in trunk/WebCore
2009-11-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
https://bugs.webkit.org/show_bug.cgi?id=31237
Also speeds up Dromaeo DOM Core tests by 1.31x.
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N2) behavior. The subtree mark bit was no longer effective; instead I changed things so only a node that has no ancestors with wrappers would do marking; there should be only one in the typical case (the root of the detached subtree).
- dom/Node.cpp: (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
- dom/Node.h: ditto
- 6:07 PM Changeset in webkit [51161] by
-
- 7 edits in trunk/WebCore
Get rid of the redundant strokeType and fillType data members on
a GraphicsContext as well as the FillOrStrokeType enum. Use
null pointers instead.
Reviewed by Sam Weinig.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setStrokeColor): Null out the pattern
and gradient.
(WebCore::GraphicsContext::setFillColor): Ditto.
(WebCore::GraphicsContext::setStrokePattern): Null out the graident.
(WebCore::GraphicsContext::setFillPattern): Ditto.
(WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
(WebCore::GraphicsContext::setFillGradient): Ditto.
- platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill): Use null checks on fillPattern and
fillGraident instead of a switch statement.
(WebCore::setPlatformStroke): Ditto.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
(WebCore::GraphicsContext::applyFillPattern): Ditto.
(WebCore::calculateDrawingMode): Use fillPattern and strokePattern
to see if there is a pattern instead of fillType and strokeType.
(WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
fillPattern, and strokePattern instead of fillType and strokeType.
(WebCore::GraphicsContext::fillPath): Added FIXME about color space that
is used in the pattern and gradient case probably erroneously. Moved
gradient code inside an if statement. Streamlined pattern code and
use an if statement. No switch any more.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto.
(WebCore::GraphicsContext::strokeRect): Ditto.
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
fillGraident instead of a switch statement.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto.
- platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
(WebCore::GraphicsContext::fillRect): Ditto.
- 6:01 PM Changeset in webkit [51160] by
-
- 2 edits in trunk/WebKitTools
2009-11-18 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
workqueue.py results in totally broken commit-queue UI
https://bugs.webkit.org/show_bug.cgi?id=31645
- Scripts/bugzilla-tool:
- Remove unneeded use of PatchCollection.
- Grab a new copy of the cq'd patches every run of the queue.
- 5:48 PM Changeset in webkit [51159] by
-
- 9 edits12 adds in trunk
2009-11-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add tests for ValidityState.stepMismatch.
https://bugs.webkit.org/show_bug.cgi?id=31331
- fast/forms/ValidityState-stepMismatch-number-expected.txt: Added.
- fast/forms/ValidityState-stepMismatch-number.html: Added.
- fast/forms/ValidityState-stepMismatch-range-expected.txt: Added.
- fast/forms/ValidityState-stepMismatch-range.html: Added.
- fast/forms/ValidityState-stepMismatch-unsupported-expected.txt: Added.
- fast/forms/ValidityState-stepMismatch-unsupported.html: Added.
- fast/forms/input-step-expected.txt: Added.
- fast/forms/input-step.html: Added.
- fast/forms/script-tests/ValidityState-stepMismatch-number.js: Added.
- fast/forms/script-tests/ValidityState-stepMismatch-range.js: Added.
- fast/forms/script-tests/ValidityState-stepMismatch-unsupported.js: Added.
- fast/forms/script-tests/input-step.js: Added.
2009-11-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Support for step attribute and ValidityStae.stepMismatch for
type=number and range. stepMismatch will be false if the
difference between the current value and a multiple of the step
value is very small.
Change the behavior of RenderSlider so that it always has a value
rounded to the step attribute value.
Tests: fast/forms/ValidityState-stepMismatch-number.html
fast/forms/ValidityState-stepMismatch-range.html
fast/forms/ValidityState-stepMismatch-unsupported.html
fast/forms/input-step.html
- html/HTMLAttributeNames.in: Add "step".
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepMismatch): (WebCore::HTMLInputElement::getStepParameters): (WebCore::HTMLInputElement::getAllowedValueStep):
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl: Add "step".
- html/ValidityState.cpp: (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
- html/ValidityState.h:
- rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::clampValue):
- 5:27 PM Changeset in webkit [51158] by
-
- 2 edits in trunk/WebCore
Need to ASSERT(isMainThread()) in ThreadShared methods.
https://bugs.webkit.org/show_bug.cgi?id=31637
Reviewed by Darin Adler.
Added ASSERT(IsMainThread()) to all following methods:
- platform/TreeShared.h:
(WebCore::TreeShared::TreeShared):
(WebCore::TreeShared::~TreeShared):
(WebCore::TreeShared::ref):
(WebCore::TreeShared::deref):
(WebCore::TreeShared::setParent):
(WebCore::TreeShared::parent):
- 5:00 PM Changeset in webkit [51157] by
-
- 3 edits in trunk/WebCore
2009-11-18 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Eric Seidel.
Add plugin visibility manual test
- manual-tests/plugins/windowed.html:
- manual-tests/plugins/windowless.html:
- 4:52 PM Changeset in webkit [51156] by
-
- 2 edits1 add in trunk/WebCore
2009-11-18 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Pavel Feldman.
Web Inspector - remember last script displayed in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=27552
Manual test added
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.showScript): (WebInspector.ScriptsPanel.prototype.showResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.ScriptsPanel.prototype._goBack): (WebInspector.ScriptsPanel.prototype._goForward):
- manual-tests/inspector/remember-last-script.html: Added.
- 4:43 PM Changeset in webkit [51155] by
-
- 2 edits in trunk/WebCore
2009-11-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dimitri Glazkov.
Win chromium is slow to draw transparent texts
https://bugs.webkit.org/show_bug.cgi?id=31258
Create bounded transparency layers instead of just clipping.
No new tests because this is just a performance improvement.
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
- 4:35 PM Changeset in webkit [51154] by
-
- 8 edits in trunk
2009-11-18 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Update expected result after Qt4.6 upgrade.
https://bugs.webkit.org/show_bug.cgi?id=31560
Test: LayoutTests/editing/deleting/5408255.html
- platform/qt/editing/deleting/5408255-expected.txt:
2009-11-18 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Add support for displaying deleteButton.
https://bugs.webkit.org/show_bug.cgi?id=31560
Test: LayoutTests/editing/deleting/5408255.html
- WebCore.qrc:
- platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):
2009-11-18 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Add support for displaying deleteButton.
https://bugs.webkit.org/show_bug.cgi?id=31560
Test: LayoutTests/editing/deleting/5408255.html
- Api/qwebsettings.cpp: (graphics):
- Api/qwebsettings.h:
- 4:26 PM Changeset in webkit [51153] by
-
- 2 edits in trunk/WebCore
2009-11-18 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Eric Seidel.
Fix Qt build without JavaScript debugger.
- page/Console.idl:
- 4:18 PM Changeset in webkit [51152] by
-
- 2 edits in trunk/WebKitSite
2009-11-18 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
Make 80 patches a formal requirement for reviewership
https://bugs.webkit.org/show_bug.cgi?id=31313
Per discussion on the webkit-reviewers list:
http://lists.webkit.org/mailman/private.cgi/webkit-reviewers/2009-November/000795.html
- coding/commit-review-policy.html:
- 4:05 PM Changeset in webkit [51151] by
-
- 3 edits10 adds in trunk
2009-11-18 Daniel Bates <dbates@webkit.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=24971
And
<rdar://problem/7138265>
Fixes an issue where setting the height of a table row programmatically
(via JavaScript) causes the table to be improperly rendered because the
height of each row in the table is not recalculated with respect to the
CSS height property.
In particular, programmatically setting the height of some table row causes
the rows of that table to be rendered with a height equal to the minimum
height required by the cells in that row, regardless of any specified cell
heights. Instead, when RenderTableSection::recalcCells is called, the height
of each row should be set to the CSS height property just as we do in
RenderTableSection::addChild.
Test: fast/table/row-height-recalc2.html
- rendering/RenderTableSection.cpp: (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added. (WebCore::RenderTableSection::addChild): Moved code that set row height into method WebCore::setRowHeightToRowStyleHeightIfNotRelative. (WebCore::RenderTableSection::recalcCells): Modified to call WebCore::setRowHeightToRowStyleHeightIfNotRelative.
2009-11-18 Daniel Bates <dbates@webkit.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=24971
And
<rdar://problem/7138265>
Tests that setting the height of a table row programmatically (via JavaScript)
recalculates the height of the rows in the table.
- fast/table/row-height-recalc2.html: Added.
- platform/mac/fast/table/row-height-recalc2-expected.checksum: Added.
- platform/mac/fast/table/row-height-recalc2-expected.png: Added.
- platform/mac/fast/table/row-height-recalc2-expected.txt: Added.
- platform/qt/fast/table/row-height-recalc2-expected.checksum: Added.
- platform/qt/fast/table/row-height-recalc2-expected.png: Added.
- platform/qt/fast/table/row-height-recalc2-expected.txt: Added.
- platform/win/fast/table/row-height-recalc2-expected.checksum: Added.
- platform/win/fast/table/row-height-recalc2-expected.png: Added.
- platform/win/fast/table/row-height-recalc2-expected.txt: Added.
- 3:57 PM Changeset in webkit [51150] by
-
- 2 edits in trunk/LayoutTests
Reduce flakiness in zero-duration-with-non-zero-delay-end.html by
increasing a timeout.
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=31646
- transitions/zero-duration-with-non-zero-delay-end.html:
- 3:47 PM Changeset in webkit [51149] by
-
- 11 edits in trunk/WebCore
Allow custom memory allocation control for the part of platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31473
Reviewed by Darin Adler.
Inherits the following classes from FastAllocBase because these are
instantiated by 'new':
class AnimationList - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
class Color - instantiated at WebCore/rendering/RenderTheme.cpp:48
struct Length - instantiated at WebCore/platform/Length.cpp:103
class PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
class ContextMenuItem - instantiated at WebCore/platform/ContextMenu.cpp:70
class DeprecatedPtrList - instantiated at WebCore/rendering/RenderBlock.cpp:2284
Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:
class GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
class FontCache - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
struct MediaPlayerFactory - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
class DeprecatedPtrListNode - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53
- platform/ContextMenuItem.h:
- platform/DeprecatedPtrList.h:
- platform/DeprecatedPtrListImpl.cpp:
- platform/Length.h:
- platform/PlatformKeyboardEvent.h:
- platform/animation/AnimationList.h:
- platform/graphics/Color.h:
- platform/graphics/FontCache.h:
- platform/graphics/GraphicsContextPrivate.h:
- platform/graphics/MediaPlayer.cpp:
- 3:46 PM Changeset in webkit [51148] by
-
- 10 edits in trunk
2009-11-18 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
These are more descriptive names so as to clear an ambiguity surrounding
their usage. Also, renames associated setters and getters so that they
coincide with the renamed fields.
No functionality was changed. So, no tests were included.
- bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited. (WebCore::RenderTextControl::subtreeHasChanged):
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited. (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited. (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
2009-11-18 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Changes associated with renaming RenderTextControl::isUserEdited.
- DOMHTMLClasses.cpp: (DOMHTMLInputElement::isUserEdited): Formerly named isUserEdited. (DOMHTMLTextAreaElement::isUserEdited): Ditto.
- 3:44 PM Changeset in webkit [51147] by
-
- 8 edits3 deletes in trunk
Make the Mac Geolocation API async.
Reviewed by Anders Carlsson.
WebKit:
- WebKit.xcodeproj/project.pbxproj: Remove WebGeolocation.
WebKit/mac:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requestGeolocationPermissionForFrame):
(-[WebGeolocationPolicyListener initWithGeolocation:]):
(-[WebGeolocationPolicyListener allow]):
(-[WebGeolocationPolicyListener deny]):
Add WebGeolocationPolicyListener implementation of the new WebGeolocationPolicyListener
protocol and use if to implement requestGeolocationPermissionForFrame using the new async
API.
- WebCoreSupport/WebGeolocation.mm: Removed.
- WebCoreSupport/WebGeolocationInternal.h: Removed.
- WebCoreSupport/WebGeolocationMock.mm: Remove bogus include.
- WebCoreSupport/WebGeolocationPrivate.h: Removed.
- WebView/WebUIDelegatePrivate.h: Remove requestGeolocationPermission and add
WebGeolocationPolicyListener protocol and decidePolicyForGeolocationRequestFromOrigin delegate
method.
WebKitTools:
Update DRT to use the new async Mac Geolocation API.
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
- 3:36 PM Changeset in webkit [51146] by
-
- 3 edits1 delete in trunk/WebCore
2009-11-18 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
https://bugs.webkit.org/show_bug.cgi?id=31499
No new tests, just a build cleanup.
- WebCore.gypi:
- bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
- bindings/v8/custom/V8CustomBinding.h:
- 3:29 PM Changeset in webkit [51145] by
-
- 2 edits in trunk/WebKitTools
2009-11-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Add and option to toggle HTML5 datalist support to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=31599
- Scripts/build-webkit:
- 3:25 PM Changeset in webkit [51144] by
-
- 4 edits in trunk
2009-11-18 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Remove Chromium's unnecessary dependency on wtf's tcmalloc files.
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- 3:23 PM Applications using WebKit edited by
- (diff)
- 3:18 PM Changeset in webkit [51143] by
-
- 15 edits in trunk
Reviewed by Kevin Ollivier.
Enable wx plugin support using the Windows implementation as a base.
https://bugs.webkit.org/show_bug.cgi?id=31636
- 3:10 PM Changeset in webkit [51142] by
-
- 2 edits in trunk/WebKit/chromium
2009-11-18 Evan Stade <estade@chromium.org>
Reviewed by Darin Fisher.
Menu button shows wrong content in Chromium
https://bugs.webkit.org/show_bug.cgi?id=31448
Make context menu button (VK_APPS) show context menu for node that has
keyboard focus. This affects both the content and the positioning.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendContextMenuEvent):
- 3:02 PM Changeset in webkit [51141] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-18 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Gavin Barraclough.
[Qt] Implement symbol hiding for JSC's JIT functions.
These functions are implemented directly in assembly, so they need the
proper directives to enable/disable visibility. On ELF systems, it's
.hidden, whereas on Mach-O systems (Mac) it's .private_extern. On
Windows, it's not necessary since you have to explicitly export. I
also implemented the AIX idiom, though it's unlikely anyone will
implement AIX/POWER JIT.
https://bugs.webkit.org/show_bug.cgi?id=30864
- jit/JITStubs.cpp:
- 2:49 PM Changeset in webkit [51140] by
-
- 1 edit2 adds in trunk/WebCore
2009-11-18 Andrei Popescu <andreip@google.com>
Reviewed by Dimitri Glazkov.
[Android] Add shared timer and sound utilities to platform/android
https://bugs.webkit.org/show_bug.cgi?id=31584
No new tests required, this is platform specific code.
- platform/android/SharedTimerAndroid.cpp: Added. (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
- platform/android/SoundAndroid.cpp: Added. (WebCore::systemBeep):
- 2:41 PM Changeset in webkit [51139] by
-
- 4 edits in trunk/WebCore
2009-11-18 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Fix profile tree nodes loss after focus / restore actions.
Focusing on a node is currently implemented via nodes reattaching
with some caching involved. It seems that not all code was updated
to handle this scenario correctly.
- inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._restore): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.insertChild): (WebInspector.DataGridNode.prototype._detach): (WebInspector.DataGridNode.prototype.savePosition): (WebInspector.DataGridNode.prototype.restorePosition):
- inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridTree.prototype.focus): (WebInspector.TopDownProfileDataGridTree.prototype.restore):
- 2:37 PM Changeset in webkit [51138] by
-
- 2 edits in trunk/WebKitSite
2009-11-18 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Adds property "min-width" to #title so that the width of the title
element on each page is at least 790px. In particular, this makes
the page <http://webkit.org/security/security-group-members.html>
consistent, in appearance, to the rest of the site.
- css/main.css:
- 2:33 PM Changeset in webkit [51137] by
-
- 2 edits in trunk/WebCore
2009-11-18 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebPageClient.h needs in some cases QCursor, but it does not
include it
https://bugs.webkit.org/show_bug.cgi?id=31527
No new tests as this is just a coding style fix that affects the
build of some not yet submitted patches (i.e. for bug 30173).
- platform/qt/QWebPageClient.h:
- 2:25 PM Changeset in webkit [51136] by
-
- 2 edits in trunk/WebCore
2009-11-18 Nicolas Roard <nicolas@roard.com>
Reviewed by Dimitri Glazkov.
InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=31504
- inspector/InspectorTimelineAgent.h:Added the guard.
- 2:08 PM Changeset in webkit [51135] by
-
- 2 edits in trunk/WebCore
Build fix to my previous checkin, for Windows Chromium
- svg/SVGAnimatedProperty.h:
(WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.
- 2:05 PM Changeset in webkit [51134] by
-
- 5 edits in trunk/WebCore
2009-11-18 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Directly Access <head> Instead of Searching for It
https://bugs.webkit.org/show_bug.cgi?id=31641
Changed old access of the head element (document.getElementsByTagName)
to just use the document.head accessor.
- inspector/front-end/FontView.js: (WebInspector.FontView):
- inspector/front-end/InjectedScript.js: (InjectedScript.addStyleSelector):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
- inspector/front-end/inspector.js: (windowLoaded):
- 2:04 PM Changeset in webkit [51133] by
-
- 3 edits in trunk/WebCore
Fix two Geolocation assertions.
Reviewed by Anders Carlsson.
- page/Chrome.cpp:
(WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
is not called from JS.
- page/Geolocation.cpp:
(WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
a RefPtr first.
- 2:02 PM Changeset in webkit [51132] by
-
- 2 edits in trunk/WebCore
Case sensitive file system build fix.
- platform/network/Credential.h: It's not WTF, just wtf.
- 1:54 PM Changeset in webkit [51131] by
-
- 4 edits in trunk/WebCore
Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
objects and WebCore::Credential objects without losing certificate information.
Reviewed by Alexey Proskuryakov
- 1:49 PM Changeset in webkit [51130] by
-
- 5 edits in trunk/WebKit/chromium
2009-11-17 Darin Fisher <darin@chromium.org>
Reviewed by Dmitry Titov.
Minor cleanup in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=31616
- public/WebFormElement.h: Add missing WEBKIT_API prefix.
- public/WebNode.h: Add missing WEBKIT_API prefix.
- src/WebFormElement.cpp: (WebKit::WebFormElement::action): Make action getter const.
- src/WebNode.cpp: (WebKit::WebNode::frame): Utilize WebFrameImpl::fromFrame.
- 1:31 PM Changeset in webkit [51129] by
-
- 2 edits in trunk/LayoutTests
Update expected results of fixed test.
- 12:46 PM Changeset in webkit [51128] by
-
- 4 edits in trunk
Interpreter may do an out of range access when throwing an exception in the profiler.
https://bugs.webkit.org/show_bug.cgi?id=31635
Reviewed by Alexey Proskuryakov.
Add bounds check.
- 12:25 PM Changeset in webkit [51127] by
-
- 4 edits in trunk/WebCore
Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
https://bugs.webkit.org/show_bug.cgi?id=31615
Reviewed by Eric Seidel.
- dom/Document.cpp:
(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::ScriptExecutionContextTaskTimer::fired):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::performTask):
(WebCore::Document::postTask):
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
- 12:09 PM Changeset in webkit [51126] by
-
- 2 edits in trunk/LayoutTests
Disabling WebSocket tests on Tiger back, they still hang.
- platform/mac-tiger/Skipped:
- 11:57 AM Changeset in webkit [51125] by
-
- 9 edits in trunk/WebCore
Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
by causing the right v8-to-WebCore conversion function to be called for every parameter.
This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
To enforce correctness, I added a mode that disables implicit
String-->AtomicString conversions while compiling the generated bindings.
https://bugs.webkit.org/show_bug.cgi?id=31168
Reviewed by Darin Adler.
- bindings/scripts/CodeGeneratorV8.pm: Generate usage of V8Parameter class.
- bindings/v8/DerivedSourcesAllInOne.cpp: Enable NO_IMPLICIT_ATOMICSTRING.
- bindings/v8/V8Binding.h: Add V8Parameter class.
- css/WebKitCSSKeyframesRule.h: Make AtomicString conversions explicit.
- dom/Document.idl: Remove obsolete [HintAtomic] annotation.
- platform/text/AtomicString.h: Added NO_IMPLICIT_ATOMICSTRING option.
- svg/SVGAnimatedTemplate.h: Change some return types to String to avoid implicit conversion.
- svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.
- 11:49 AM Changeset in webkit [51124] by
-
- 3 edits in trunk/WebCore
Move FillOrStrokeType out of public header.
Reviewed by Dan Bernstein.
- platform/graphics/GraphicsContext.h: Updated copyright date to cover
some years we published Apple changes, sorted forward declarations,
removed FillOrStrokeType enum.
- platform/graphics/GraphicsContextPrivate.h: Updated copyright date
to cover some years we published Apple changes, sorted includes,
moved FillOrStrokeType enum here.
- 11:37 AM Changeset in webkit [51123] by
-
- 2 edits in trunk/JavaScriptCore
Fix the clobber list of cacheFlush for ARM and Thumb2 on Linux
https://bugs.webkit.org/show_bug.cgi?id=31631
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-11-18
Reviewed by Darin Adler.
- jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
- 11:23 AM Changeset in webkit [51122] by
-
- 17 edits in trunk
Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
https://bugs.webkit.org/show_bug.cgi?id=31601
These are used to debug accelerated compositing layers. I removed
the platform specific code from GraphicsLayerCA.mm and added calls
to GraphicsLayerClient to get it from the higher levels. The values
now get cached in RenderLayerCompositing and are queried from there
by RenderLayerBacking (which implements the GraphicsLayerClient interface).
- 10:26 AM Changeset in webkit [51121] by
-
- 3 edits in trunk/WebCore
2009-11-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Get rid of metrics and properties sidebars'
flickering.
- inspector/front-end/MetricsSidebarPane.js:
- inspector/front-end/PropertiesSidebarPane.js:
- 10:21 AM Changeset in webkit [51120] by
-
- 2 edits in trunk/LayoutTests
Eliminate flakiness in file-URL-with-port-number by removing a setTimeout.
The timeout caused the test to fail about 2% of the time on the Chromium builders.
The timeout exists to catch cases where the iframe does not load, but the test
framework already will handle this (albeit with a longer timeout).
Reviewed by Dmitry Titov.
- fast/loader/file-URL-with-port-number.html:
- 10:12 AM Changeset in webkit [51119] by
-
- 3 edits in trunk/WebCore
Fixes <http://webkit.org/b/31606>.
Web Inspector: Enter/Return key should enter edit mode for Editable Fields.
Reviewed by Pavel Feldman.
This implements Enter starting editing mode in an editable DataGrid. If the
DataGrid is editable and the user hits return, startEditing the first child
of the selected node. Also refactored some editing functions to take an
event target instead of the event itself, because the functions only needed
the target. Lastly, added had return in editing mode stop propogation, because
when enter was hit to confirm text, it would propagate back to the datagrid
and try to start editing again.
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._ondblclick):
(WebInspector.DataGrid.prototype._startEditing):
(WebInspector.DataGrid.prototype.handleKeyEvent):
(WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
(WebInspector.DataGrid.prototype._mouseDownInDataTable):
(WebInspector.DataGrid.prototype._clickInDataTable):
- inspector/front-end/inspector.js:
(WebInspector.startEditing.element.handleKeyEvent):
(WebInspector.startEditing):
- 9:57 AM Changeset in webkit [51118] by
-
- 3 edits3 adds in trunk
HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
https://bugs.webkit.org/show_bug.cgi?id=31593
Reviewed by Darin Adler.
WebCore:
Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.
LayoutTests:
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-whitespace.js: Added.
- fast/dom/HTMLAnchorElement/set-href-attribute-whitespace-expected.txt: Added.
- fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html: Added.
- 9:38 AM Changeset in webkit [51117] by
-
- 2 edits in trunk/WebCore
2009-11-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Touch InspectorController so that frontend
JS files are deployed on Windows.
- inspector/InspectorController.cpp:
- 9:30 AM Changeset in webkit [51116] by
-
- 2 edits in trunk/LayoutTests
Trying to enable WebSocket tests on Tiger again, now that bug 31603 is fixed.
- platform/mac-tiger/Skipped:
- 9:25 AM Changeset in webkit [51115] by
-
- 3 edits in trunk
2009-11-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: clone timeline records array instead of
copying reference on invalidate all.
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
- 8:38 AM Changeset in webkit [51114] by
-
- 2 edits in trunk/WebKitTools
Change the initialization order so that the controllers
will be created before exporting them to the JS DOM window.
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
- 8:17 AM QtWebKitAPI edited by
- (diff)
- 8:16 AM Changeset in webkit [51113] by
-
- 2 edits in trunk/WebKitTools
Fix a code copy and paste error. m_page should be page.
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::createWindow):
- 8:15 AM QtWebKitAPI edited by
- (diff)
- 8:14 AM QtWebKitAPI edited by
- (diff)
- 8:05 AM QtWebKitAPI created by
- 7:49 AM QtWebKitContrib edited by
- (diff)
- 7:02 AM Changeset in webkit [51112] by
-
- 2 edits in trunk/WebCore
2009-11-18 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Elements don't drop out of compositing layers when animation ends
https://bugs.webkit.org/show_bug.cgi?id=31613
<rdar://problem/7402913>
Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
are compositing anyway for other reasons. Doing so can cause those layers
to stay in compositing mode even after animations finish, because needsToBeComposited()
continues to return true.
No new tests because it's not possible to determine which elements are in
compositing layers from DRT output.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- 6:27 AM Changeset in webkit [51111] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Make the QWebElement::render() test pass when pixmaps aren't 32 bit.
Patch by Paul Olav Tvete <paul.tvete@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.
- tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::render):
- 5:22 AM Changeset in webkit [51110] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Fix detection of linux-g++
Patch by Harald Fernengel <harald.fernengel@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.
Never use "linux-g++*" to check for linux-g++, since this will break embedded
builds which use linux-arm-g++ and friends. Use 'linux*-g++*' to check for any
g++ on linux mkspec.
- JavaScriptCore.pri:
- 5:20 AM Changeset in webkit [51109] by
-
- 2 edits in trunk/WebKit/gtk
Properly localize documentation strings for the tab-key-cycles-through-elements property.
- 5:20 AM Changeset in webkit [51108] by
-
- 4 edits in trunk
Ensure that tabKeyCyclesThroughElements is true by default.
- 5:19 AM Changeset in webkit [51107] by
-
- 2 edits in trunk/WebKit/qt
Clarify and simplify the legal section in the overview documentation,
after review with our legal team.
Reviewed by Tor Arne Vestbø.
- docs/qtwebkit.qdoc:
- 4:58 AM Changeset in webkit [51106] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Add QtLauncher support for opening links in the default browser
Reviewed by Simon Hausmann.
This can be triggered by either the context menu or by clicking a link
while holding down the Alt key. Opening a link in a new windows is
triggered by holding down Shift.
- QtLauncher/main.cpp:
- 4:53 AM Changeset in webkit [51105] by
-
- 3 edits in trunk/WebCore
[Qt] Mac Plugins: Remove null timer
Reviewed by Tor Arne Vestbø.
A null timer was used to send mouse move events. Instead, we now use
move events to send nullEvent. This brings down CPU usage by 20-30%.
- 4:48 AM Changeset in webkit [51104] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
[GTK] Failing test media/video-document-types.html
https://bugs.webkit.org/show_bug.cgi?id=31352
Match what Mac has been doing since r36001: cancel the main load,
and handle failures caused by 'will be handled by plugin' errors.
Covered by test media/video-document-types.html
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::committedLoad):
(WebKit::FrameLoaderClient::shouldFallBack):
- 2:29 AM Changeset in webkit [51103] by
-
- 3 edits4 adds in trunk
[Qt] WebKit crashes when loading certain SVG images
Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.
WebCore:
Check if the familly exist before creating the PlatformData from it.
https://bugs.webkit.org/show_bug.cgi?id=29443
Test: svg/text/text-font-invalid.html
- platform/graphics/qt/FontFallbackListQt.cpp:
(WebCore::FontFallbackList::fontDataAt):
LayoutTests:
Added a test for a crash of QtWebkit when loading SVG images.
https://bugs.webkit.org/show_bug.cgi?id=29443
- svg/text/resources/text-font-invalid.svg: Added.
- svg/text/text-font-invalid-expected.txt: Added.
- svg/text/text-font-invalid.html: Added.
