Context Navigation

I also took this opportunity to make 'help' a real Command.
Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).

Scripts/bugzilla-tool:
- change should_show_command_help to should_show_in_main_help
Scripts/modules/commands/download.py:
- Mark commands as being shown in main help or not.
- show_in_main_help = False is not required (default is false), but it seemed to make the commands more self-documenting.
Scripts/modules/commands/queries.py: ditto
Scripts/modules/commands/queues.py: ditto
Scripts/modules/commands/upload.py: ditto
Scripts/modules/multicommandtool.py:
- Make Command hold a pointer to tool in self.tool. Most Command subclasses do not take advantage of this yet, but it was required for HelpCommand to be able to reach the tool from _help_epilog().
- Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
- Move MultiCommandTool._help_epilog to Command._help_epilog
- Move "help" logic into HelpCommand.execute()
- Change should_show_command_help to should_show_in_main_help and add a default implementation.
Scripts/modules/multicommandtool_unittest.py:
- Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'

4:57 PM Changeset in webkit [51402] by Dimitri Glazkov

6 edits in trunk

WebCore:

2009-11-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

[Chromium] Implement canSetValueAttribute in the API, the clean-up part.
https://bugs.webkit.org/show_bug.cgi?id=31894

accessibility/chromium/AccessibilityObjectWrapper.h: Added RefCounted decl. (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Removed mis-refcountingness.

WebKit/chromium:

2009-11-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

[Chromium] Implement canSetValueAttribute in the API.
https://bugs.webkit.org/show_bug.cgi?id=31894

public/WebAccessibilityObject.h: Added decl.
src/WebAccessibilityCacheImpl.h: Cleaned up mis-include.
src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::canSetValueAttribute): Added impl.

4:51 PM Changeset in webkit [51401] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Audio related layout tests are failing on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=27910

platform/qt/Skipped: fast/js/global-constructors.html added.

4:44 PM Changeset in webkit [51400] by eric@webkit.org

3 edits
3 adds in trunk

2009-11-25 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Off-by-one error in index validation for drawElements and drawArrays
https://bugs.webkit.org/show_bug.cgi?id=31891

Fixed computation of number of elements for bound array objects.

Test: fast/canvas/webgl/index-validation.html

fast/canvas/webgl/index-validation-expected.txt: Added.
fast/canvas/webgl/index-validation.html: Added.
fast/canvas/webgl/script-tests/index-validation.js: Added.

2009-11-25 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Off-by-one error in index validation for drawElements and drawArrays
https://bugs.webkit.org/show_bug.cgi?id=31891

Fixed computation of number of elements for bound array objects.

Test: fast/canvas/webgl/index-validation.html

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::vertexAttribPointer):

4:41 PM Changeset in webkit [51399] by bweinstein@apple.com

2 edits in trunk/WebKitTools

Patch by Mark Rowe.

Reviewed by Dan Bernstein.

The buildbots are failing on Windows because when they were upgraded
to 4.0.4, Apple Application Support was not in their path. Add it to
the path to fix the buildots.

Scripts/webkitdirs.pm:

4:29 PM Changeset in webkit [51398] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Remove a bunch of now passing fast tests from skiplist.
And add a crasher/crashed pair into skiplist.

platform/qt/Skipped:

3:44 PM Changeset in webkit [51397] by dimich@chromium.org

2 edits in trunk/WebCore

Update SharedScript to use eventNames() instead of EventNames()
https://bugs.webkit.org/show_bug.cgi?id=31890

Reviewed by David Levin.

SharedScript/WebKitSharedScript.cpp:

(WebCore::LoadEventTask::performTask):

3:29 PM Changeset in webkit [51396] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Put tests into skiplist because of missing layoutTestController feature.

platform/qt/Skipped:
http/tests/cache/subresource-failover-to-network.html added.
fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html added.

"3D_RENDERING and ACCELERATED_COMPOSITING" block moved to good place.

2:26 PM Changeset in webkit [51395] by Csaba Osztrogonác

2 edits in trunk/WebKitTools

run-webkit-tests doesn't accept directories/files with --skipped=only parameter
https://bugs.webkit.org/show_bug.cgi?id=31799

Reviewed by David Kilzer.

Scripts/run-webkit-tests: Fixed.

1:09 PM Changeset in webkit [51394] by darin@chromium.org

2 edits in trunk/WebKit/chromium

2009-11-25 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Unable to repost form data by hitting reload
https://bugs.webkit.org/show_bug.cgi?id=31882

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadData):

1:08 PM Changeset in webkit [51393] by eric.carlson@apple.com

10 edits in trunk

2009-11-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7409331> Windows: Support closed caption in <video> element

Enable closed captions in QuickTime/Windows media engine.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::hasClosedCaptions): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):

New, all through to m_qtMovie.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

Make all but the destructor private since MediaPlayer call through the media
engine interface.

platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::disableUnsupportedTracks):

Use handy new constants for QuickTime track types.

(QTMovieWin::hasClosedCaptions):
(QTMovieWin::setClosedCaptionsVisible):

New, closed caption support.

platform/graphics/win/QTMovieWin.h:

rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):

Deal with closed caption buttons.

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::shouldRenderMediaControlPart):

New, don't ask the media engine if it has closed captions unless the Safari theme will
be able to render the button.

(WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):

New.

rendering/RenderThemeWin.h:

2009-11-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7409331> Windows: Support closed caption in <video> element

platform/win/Skipped:

Enable the closed caption test.

12:04 PM Changeset in webkit [51392] by eric@webkit.org

5 edits in trunk/WebCore

2009-11-25 Drew Wilson <atwilson@chromium.org>

Reviewed by David Levin.

MessagePorts always look remotely entangled even when closed.
https://bugs.webkit.org/show_bug.cgi?id=31698

Tests: Existing tests suffice, Chromium soak test passes now.

bindings/v8/custom/V8CustomBinding.h: Removed kMessagePortEntangledPortIndex which is no longer used.
bindings/v8/V8GCController.cpp: (WebCore::GCPrologueVisitor::visitDOMWrapper): Simplified GC code to reflect the Chromium MessagePort implementation (locallyEntangledPort() always returns false). (WebCore::GCEpilogueVisitor::visitDOMWrapper): Cleaned up epilogue code to handle the case where the port gets closed in mid-GC (due to the parent context being freed).
dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::close): Now sets the closed flag. (WebCore::MessagePort::disentanglePorts): Updated to use new isCloned() API instead of relying on isEntangled(), which was incorrect.
dom/MessagePort.h: Added a m_closed flag and updated isEntangled() to check it. (WebCore::MessagePort::isEntangled): Now returns false if the port has been closed. (WebCore::MessagePort::isCloned): Added new API to differentiate between cloned and closed ports (closed ports can still be passed to postMessage).

12:02 PM Changeset in webkit [51391] by zoltan@webkit.org

3 edits in trunk/WebKitTools

2009-11-25 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Change run_command to give back stderr by default
https://bugs.webkit.org/show_bug.cgi?id=31734

Change run_command to give back stderr by default.
Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
Change the related unittest call.

Scripts/modules/scm.py:
Scripts/modules/scm_unittest.py:

10:22 AM Changeset in webkit [51390] by kov@webkit.org

2 edits in trunk/LayoutTests

Skip test that needs structure we do not provide yet

10:03 AM Changeset in webkit [51389] by Dimitri Glazkov

4 edits in trunk/WebKit/chromium

2009-11-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

[Chromium] Plumb setNeedsSiteSpecificQuirks throught WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=31878

public/WebSettings.h: Added decl.
src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setNeedsSiteSpecificQuirks): Added impl.
src/WebSettingsImpl.h:

9:12 AM Changeset in webkit [51388] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Fix crash of QtWebKit on any page with Flash when compiled with MinGW.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-11-25
Reviewed by Simon Hausmann.

Fix inline assembly, don't dereference the function pointer twice.

plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::hookedBeginPaint):
(WebCore::PluginView::hookedEndPaint):

9:02 AM Changeset in webkit [51387] by Simon Hausmann

4 edits in trunk

[Qt] Remove the Referer header when redirecting to a non-secure site
https://bugs.webkit.org/show_bug.cgi?id=31785

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-11-22
Reviewed by Adam Barth.

This makes Qt pass two tests introduced in r50226.

WebCore:

platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

LayoutTests:

platform/qt/Skipped:

8:50 AM Changeset in webkit [51386] by benm@google.com

3 edits in trunk/WebCore

The select elements do not reflect the actual choice the user makes.
https://bugs.webkit.org/show_bug.cgi?id=31831

Patch by Andrei Popescu <andreip@google.com> on 2009-11-25
Reviewed by Dimitri Glazkov.

Handle the drawing of the listboxes in Android code.

No new features, just fixing an Android problem. Existing layout tests are sufficient.

platform/android/RenderThemeAndroid.cpp:

(WebCore::theme):
(WebCore::RenderThemeAndroid::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeAndroid::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeAndroid::adjustButtonStyle):
(WebCore::RenderThemeAndroid::paintTextArea):
(WebCore::RenderThemeAndroid::adjustListboxStyle):

platform/android/RenderThemeAndroid.h:

8:15 AM Changeset in webkit [51385] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-25 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Load InspectorResource mime type from CachedResource for 304 responses

For network libraries that do not merge cache data into 304 ResourceResponses,
the mime type for cached resources is unknown.
https://bugs.webkit.org/show_bug.cgi?id=31868

inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::type):

8:06 AM Changeset in webkit [51384] by eric@webkit.org

1 edit
2 adds in trunk/WebCore

2009-11-25 Andrei Popescu <andreip@google.com>

Reviewed by Eric Seidel.

Android is missing implementation of SSL Key generator functions.
https://bugs.webkit.org/show_bug.cgi?id=31825

This change adds the PlatformBridge class to platform/android.
PlarformBridge is used to access the embedding layer for things
such as key generator, cookies, plugins, etc.

No new tests required, this is platform code.

platform/android/PlatformBridge.h: Added.
platform/android/SSLKeyGeneratorAndroid.cpp: Added. (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):

8:05 AM Changeset in webkit [51383] by eric@webkit.org

5 edits in trunk/WebKitTools

2009-11-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Centralize required argument parsing in Command
https://bugs.webkit.org/show_bug.cgi?id=31872

Scripts/modules/commands/download.py: remove custom required arg message.
Scripts/modules/commands/upload.py: ditto.
Scripts/modules/multicommandtool.py:
- Add _parse_required_arguments.
- Pass program name off to OptionParser.
- Add name() for access to tool name.
- Add check_arguments_and_execute and make it return a return code.
- Replace a couple uses of + with %.
Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments

7:59 AM Changeset in webkit [51382] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-25 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GTK] use gst_init_check() instead of gst_init()
https://bugs.webkit.org/show_bug.cgi?id=31864

Use gst_init_check() instead of gst_init() to prevent eventual
unexpected exit of the application.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::do_gst_init): (WebCore::MediaPlayerPrivate::isAvailable):

7:46 AM Changeset in webkit [51381] by eric@webkit.org

3 edits
1 add in trunk/WebKitTools

2009-11-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
https://bugs.webkit.org/show_bug.cgi?id=31870

Scripts/modules/commands/queries_unittest.py: Use the new class.
Scripts/modules/multicommandtool_unittest.py: Ditto.
Scripts/modules/outputcapture.py: Added.

5:01 AM Changeset in webkit [51380] by kov@webkit.org

2 edits in trunk/WebCore

Reviewed by Xan Lopez.

Some tests are crashing from time to time
https://bugs.webkit.org/show_bug.cgi?id=31866

Make sure we do not notify the client of a finished load, if the
load has been cancelled, or the client is gone.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):

3:02 AM Changeset in webkit [51379] by benm@google.com

6 edits in trunk/WebCore

[Android] Upstream Android changes to WebCore/bridge/jni
https://bugs.webkit.org/show_bug.cgi?id=31824

Reviewed by Eric Seidel.

No new tests required as no new functionality.

bridge/jni/jni_class.cpp:

(JavaClass::JavaClass): Add calls to delete allocated references, to avoid potential leaks.

bridge/jni/jni_instance.cpp: Add an Android include path.
bridge/jni/jni_instance.h: Add getter/setter for JObjectWrapper::_instance and make the JavaInstance ctor and member variables protected. Both needed for the Android port, see bug for discussion.

(JSC::Bindings::JObjectWrapper::instance): Added.
(JSC::Bindings::JObjectWrapper::setInstance): Added.

bridge/jni/jni_runtime.cpp:

(JavaMethod::JavaMethod): Delete an allocated reference to avoid a potential leak.

bridge/jni/jni_utility.h:

(JSC::Bindings::callJNIMethodV): Delete an allocated reference to avoid a potential leak.

1:40 AM QtWebKitContrib edited by Simon Hausmann

(diff)

12:25 AM Changeset in webkit [51378] by zoltan@webkit.org

11 edits in trunk/WebCore

Allow custom memory allocation control for classes of the plugins and rendering directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31827

Reviewed by Eric Seidel.

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

class PluginRequest - plugins/PluginView.cpp:521
class PluginMainThreadScheduler - plugins/PluginMainThreadScheduler.cpp:34
class PluginDatabase - plugins/PluginDatabase.cpp:50
struct MimeClassInfo - plugins/PluginInfoStore.cpp:50
struct PluginInfo - plugins/PluginInfoStore.cpp:40
class RenderArena - dom/Document.cpp:1401
class RenderImageScaleData - rendering/RenderImage.cpp:149
class TableLayout - (its child class) rendering/RenderTable.cpp:82
struct ColumnInfo - rendering/RenderBlock.cpp:3590
struct FloatingObject - rendering/RenderBlock.cpp:2300
struct MaxMargin - rendering/RenderBlock.cpp:4794
class RenderMarquee - rendering/RenderLayer.cpp:3277

plugins/PluginData.h:
plugins/PluginDatabase.h:
plugins/PluginMainThreadScheduler.h:
plugins/PluginView.h:
rendering/RenderArena.h:
rendering/RenderBlock.cpp:
rendering/RenderBlock.h:
rendering/RenderImage.cpp:
rendering/RenderMarquee.h:
rendering/TableLayout.h:

Nov 24, 2009:

11:32 PM Changeset in webkit [51377] by bweinstein@apple.com

20 edits
2 copies in trunk

Un-roll out the roll out that was committed in r51376 because it didn't help the Windows bots,
even though it seemed to in my testing. Sorry.

11:04 PM Changeset in webkit [51376] by bweinstein@apple.com

20 edits
2 deletes in trunk

Roll out r51354, r51460, and r51461 to see if removing them will fix
the Windows test bots, which are currently not very happy.

10:04 PM Changeset in webkit [51375] by cmarrin@apple.com

2 edits in trunk/WebKit/win

Another Windows build fix

Got rid of d3d.lib and d3dx9.lib dependency. Not needed until
we turn on ACCELERATED_COMPOSITING

10:01 PM Changeset in webkit [51374] by dimich@chromium.org

8 edits
10 adds in trunk/WebCore

Initial implementation of WebKitSharedScript and SharedScriptContext
https://bugs.webkit.org/show_bug.cgi?id=31569

Reviewed by David Levin.

No new tests since there are no bindings yet (soon to come).

DerivedSources.make: Add WebKitSharedScript and SharedScriptContext to a list of idl files.
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::Document::detach): Notify WebKitSharedScriptRepository that document is detaching.

dom/EventTarget.cpp: Add new casting methods, since the new types are EventTargets.

(WebCore::EventTarget::toWebKitSharedScript):
(WebCore::EventTarget::toSharedScriptContext):

dom/EventTarget.h: Ditto
dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::isSharedScriptContext): New virtual method, since there is a new type of context.

SharedScript/SharedScriptContext.cpp: Added. Similar to WorkerContext, but w/o threading.

(WebCore::SharedScriptContext::SharedScriptContext):
(WebCore::SharedScriptContext::~SharedScriptContext):
(WebCore::SharedScriptContext::clearScript):
(WebCore::SharedScriptContext::virtualURL):
(WebCore::SharedScriptContext::virtualCompleteURL):
(WebCore::SharedScriptContext::reportException):
(WebCore::SharedScriptContext::addMessage):
(WebCore::SharedScriptContext::resourceRetrievedByXMLHttpRequest):
(WebCore::SharedScriptContext::scriptImported):
(WebCore::SharedScriptContext::matches):
(WebCore::SharedScriptContext::addToDocumentsList):
(WebCore::SharedScriptContext::destructionTimerFired):
(WebCore::SharedScriptContext::removeFromDocumentList):
(WebCore::SharedScriptContext::load):
(WebCore::SharedScriptContext::postTask):
(WebCore::SharedScriptContext::eventTargetData):
(WebCore::SharedScriptContext::ensureEventTargetData):
(WebCore::SharedScriptContext::scriptExecutionContext):

SharedScript/SharedScriptContext.h: Added.

(WebCore::SharedScriptContext::create):
(WebCore::SharedScriptContext::isSharedScriptContext):
(WebCore::SharedScriptContext::userAgent):
(WebCore::SharedScriptContext::toSharedScriptContext):
(WebCore::SharedScriptContext::self):
(WebCore::SharedScriptContext::script):
(WebCore::SharedScriptContext::loaded):
(WebCore::SharedScriptContext::name):
(WebCore::SharedScriptContext::refEventTarget):
(WebCore::SharedScriptContext::derefEventTarget):
(WebCore::SharedScriptContext::refScriptExecutionContext):
(WebCore::SharedScriptContext::derefScriptExecutionContext):

SharedScript/SharedScriptContext.idl: Added.

SharedScript/SharedScriptController.h:

Added. Empty implementation of a ScriptController, will come later as part of bindings. Needed to compile.

SharedScript/WebKitSharedScript.cpp: Added. EventTarget-based DOM object.

(WebCore::WebKitSharedScript::WebKitSharedScript):
(WebCore::WebKitSharedScript::~WebKitSharedScript):
(WebCore::WebKitSharedScript::setContext):
(WebCore::LoadEventTask::create): Fires asynchronous 'load' event when underlying SharedScriptContext is initialized.
(WebCore::LoadEventTask::performTask):
(WebCore::LoadEventTask::LoadEventTask):
(WebCore::WebKitSharedScript::scheduleLoadEvent):

SharedScript/WebKitSharedScript.h: Added.

(WebCore::WebKitSharedScript::create):
(WebCore::WebKitSharedScript::scriptExecutionContext):
(WebCore::WebKitSharedScript::toWebKitSharedScript):
(WebCore::WebKitSharedScript::context):
(WebCore::WebKitSharedScript::refEventTarget):
(WebCore::WebKitSharedScript::derefEventTarget):
(WebCore::WebKitSharedScript::eventTargetData):
(WebCore::WebKitSharedScript::ensureEventTargetData):

SharedScript/WebKitSharedScript.idl: Added.

SharedScript/WebKitSharedScriptRepository.cpp: Added. Implements a list of running SharedScriptContexts.

(WebCore::ScriptLoader::ScriptLoader): The helper class to load an initial script of SharedScriptContext.
(WebCore::ScriptLoader::load):
(WebCore::ScriptLoader::notifyFinished):
(WebCore::WebKitSharedScriptRepository::instance): Repository has a static global instance.
(WebCore::WebKitSharedScriptRepository::connect):
(WebCore::WebKitSharedScriptRepository::documentDetached): Called from Document::detach().
(WebCore::WebKitSharedScriptRepository::removeSharedScriptContext): Called from ~SharedScriptContext().
(WebCore::WebKitSharedScriptRepository::connectToSharedScript):
(WebCore::WebKitSharedScriptRepository::getSharedScriptContext):

SharedScript/WebKitSharedScriptRepository.h: Added.

(WebCore::WebKitSharedScriptRepository::WebKitSharedScriptRepository):

9:38 PM Changeset in webkit [51373] by dimich@chromium.org

16 edits in trunk

Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
https://bugs.webkit.org/show_bug.cgi?id=31444

Reviewed by Eric Seidel.

configure.ac:

JavaScriptCore:

Configurations/FeatureDefines.xcconfig:
wtf/Platform.h:

WebCore:

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
WebCore.pro:

WebKit:

chromium/features.gypi:

WebKit/chromium:

features.gypi:

WebKit/mac:

Configurations/FeatureDefines.xcconfig:

WebKitTools:

Scripts/build-webkit:

9:22 PM Changeset in webkit [51372] by cmarrin@apple.com

2 edits in trunk/WebKit/win

Fixed Windows build

Got rid of QuartzCore.lib dependency. Not needed until
we turn on ACCELERATED_COMPOSITING

8:29 PM Changeset in webkit [51371] by cmarrin@apple.com

19 edits
8 adds in trunk

Implement accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=27314

Initial implementation, but disabled in this checkin.
To enable ENABLE_3D_RENDERING and USE_ACCELERATED_COMPOSITING
must be turned on. Also d3d9.lib and d3d9x.lib must be added
to the build.

7:13 PM Changeset in webkit [51370] by cmarrin@apple.com

5 edits
2 adds in trunk

Do error checking of parameter to createShader
https://bugs.webkit.org/show_bug.cgi?id=31808

6:45 PM Changeset in webkit [51369] by eric@webkit.org

3 edits
3 adds in trunk

2009-11-24 Jason Smith <dark.panda@gmail.com>

Reviewed by Alexey Proskuryakov.

RegExp#exec's returned Array-like object behaves differently from
regular Arrays
https://bugs.webkit.org/show_bug.cgi?id=31689

LayoutTests/fast/js/regexp-in-and-foreach-handling.html: Added.
LayoutTests/fast/js/script-tests/regexp-in-and-foreach-handling.js: Added.
LayoutTests/fast/js/regexp-in-and-foreach-handling-expected.txt: Added.

2009-11-24 Jason Smith <dark.panda@gmail.com>

Reviewed by Alexey Proskuryakov.

RegExp#exec's returned Array-like object behaves differently from
regular Arrays
https://bugs.webkit.org/show_bug.cgi?id=31689

JavaScriptCore/runtime/RegExpConstructor.cpp: ensure that undefined values are added to the returned RegExpMatchesArray

6:16 PM Changeset in webkit [51368] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-24 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Ignore line-height CSS property specified to a search field on
Windows and Linux.
https://bugs.webkit.org/show_bug.cgi?id=31820

LayoutTests/fast/forms/control-restrict-line-height.html checks that the
following controls should ignore line-height CSS property.

<select>
<input type=button>
<input type=search>

This change addresses the <input type=search> issue with Chromium/Windows
and Chromium/Linux.

rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustSearchFieldStyle): Implement this to ignore line-height.
rendering/RenderThemeChromiumSkia.h: Declare adjustSearchFieldStyle().

5:22 PM Changeset in webkit [51367] by Simon Fraser

2 edits in trunk/WebCore

2009-11-24 Simon Fraser <Simon Fraser>

No review.

Stylistic fix: indent the member var initialisation.

platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::GraphicsLayerCA):

4:24 PM Changeset in webkit [51366] by Simon Fraser

2 edits in trunk/WebCore

2009-11-24 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.

SVGUseElement::toClipPath can crash
<rdar://problem/7385270>

Null-test m_shadowTreeRootElement again, because the call to buildPendingResource() may not
actually initialize it.

svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):

4:06 PM Changeset in webkit [51365] by snej@chromium.org

2 edits in trunk

Add Chromium's gyp-generated Xcode projects to the .gitignore file.

3:46 PM Changeset in webkit [51364] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2009-11-24 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

Linux Chromium sends too many click events
https://bugs.webkit.org/show_bug.cgi?id=31841

Manually count number of clicks for double/triple click events. This
makes us match Firefox on http://www.quirksmode.org/js/events_mouse.html
Chromium side of this patch is here:
http://codereview.chromium.org/431031/show

src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::mouseEvent):

3:43 PM Changeset in webkit [51363] by barraclough@apple.com

15 edits in trunk/WebCore

Bug 31848 - Remove uses of mainThreadCurrentWorld, and of currentWorld using a globalData.

Reviewed by Geoff Garen.

These methods get the world from the global data rather than from an execstate.
If the current world is always read from an exec state then it can be read
from the global object, and world entry can become automagical, rather than
being explicitly set by an EnterDOMWrapperWorld.

bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJS):

bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

bindings/js/JSDOMBinding.cpp:

(WebCore::currentWorld):
(WebCore::DOMObjectWrapperMapFor):
(WebCore::hasCachedDOMObjectWrapper):
(WebCore::getCachedDOMObjectWrapper):
(WebCore::cacheDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapper):
(WebCore::getCachedDOMNodeWrapper):
(WebCore::cacheDOMNodeWrapper):

bindings/js/JSDOMBinding.h:

(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):
(WebCore::getDOMNodeWrapper):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):

bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::location):
(WebCore::toJS):

bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::toJS):

bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::markChildren):
(WebCore::createWrapper):
(WebCore::toJS):

bindings/js/JSSVGPathSegCustom.cpp:

(WebCore::toJS):

bindings/js/JSStyleSheetCustom.cpp:

(WebCore::toJS):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::dropProtection):

3:19 PM Changeset in webkit [51362] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

queries_unittest.py should test command output
https://bugs.webkit.org/show_bug.cgi?id=31845

Scripts/modules/commands/queries_unittest.py:
- Capture stdout and stderr and compare with expected strings.

2:41 PM Changeset in webkit [51361] by ap@apple.com

2 edits in trunk/WebCore

Windows build fix.

platform/network/cf/SocketStreamHandleCFNet.cpp: Also, don't include the wrong one!

2:34 PM Changeset in webkit [51360] by ap@apple.com

2 edits in trunk/WebCore

Windows build fix.

platform/network/cf/SocketStreamHandleCFNet.cpp: Include the proper WKSI header.

2:32 PM Changeset in webkit [51359] by Simon Fraser

2 edits in trunk/WebCore

2009-11-24 Simon Fraser <Simon Fraser>

Windows build fix.

page/win/FrameCGWin.cpp: (WebCore::imageFromRect): (WebCore::imageFromSelection):

2:21 PM Changeset in webkit [51358] by eric.carlson@apple.com

8 edits in trunk/WebCore

2009-11-24 Eric Carlson <eric.carlson@apple.com>

Not reviewed. Revert r51351 until a new WebKitSupportLibrary is available.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
platform/graphics/win/QTMovieWin.cpp:
platform/graphics/win/QTMovieWin.h:
rendering/RenderMediaControls.cpp:
rendering/RenderThemeWin.cpp:
rendering/RenderThemeWin.h:

2:16 PM Changeset in webkit [51357] by Simon Fraser

2 edits in trunk/WebKitTools

2009-11-24 Simon Fraser <Simon Fraser>

No Review.

Fix spelling error ("depenedencies").

Scripts/build-webkit:

2:05 PM Changeset in webkit [51356] by mrowe@apple.com

2 edits in trunk/WebKitTools

Land the configuration that includes the two debug GTK Linux builders.

BuildSlaveSupport/build.webkit.org-config/config.json:

1:54 PM Changeset in webkit [51355] by Simon Fraser

7 edits in trunk/WebCore

2009-11-24 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Find highlight is drawn incorrectly on pages with compositing layers
<rdar://problem/7413925>

Part 2: Add a new bit to the PaintBehavior flags, PaintBehaviorFlattenCompositingLayers,
and pass that down when painting into an image.

When set, it forces painting of compositing layers to go down a software paint path
when all layers are painted, irrespective of compositing status, and where
3d transforms are flattened to 2d. When doing this, we also need to use temporary
clip rects for layers which are normally composited.

page/FrameView.h: (WebCore::FrameView::paintBehavior):
page/mac/FrameMac.mm: (WebCore::Frame::imageFromRect):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::renderableTransform): (WebCore::expandClipRectForDescendantsAndReflection): (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer):
rendering/RenderLayer.h: (WebCore::RenderLayer::paintsWithTransparency): (WebCore::RenderLayer::paintsWithTransform):
rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds):
rendering/RenderObject.h:

1:50 PM Changeset in webkit [51354] by ap@apple.com

20 edits
2 adds in trunk

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=31844
SocketStreamHandleCFNet should support CONNECT proxy credentials

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/network/CredentialStorage.h:
platform/network/mac/CredentialStorageMac.mm: Added. (WebCore::CredentialStorage::getFromPersistentStorage):
platform/network/cf/CredentialStorageCFNet.cpp: Added. (WebCore::CredentialStorage::getFromPersistentStorage): Add support for fetching credentials from persistent storage (CFNet version is currently a stub).

bindings/js/JSWebSocketCustom.cpp: Removed an unneeded include.

platform/network/cf/SocketStreamHandle.h:
platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::createStreams): (WebCore::getStoredCONNECTProxyCredentials): (WebCore::authenticationSchemeFromAuthenticationMethod): (WebCore::SocketStreamHandle::addCONNECTCredentials): (WebCore::SocketStreamHandle::readStreamCallback): Check if connection attempt was resulted in 407, and try stored credentials if it did.

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:
WebCore.base.exp: Updated WKSI.

1:44 PM Changeset in webkit [51353] by Simon Fraser

10 edits in trunk/WebCore

2009-11-24 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Find highlight is drawn incorrectly on pages with compositing layers
<rdar://problem/7413925>

Part 1: Rename PaintRestriction to PaintBehavior, and make it a bitmask, in
preparation for adding a new flag related to painting into an image.

PaintBehaviorSelectionOnly and PaintBehaviorForceBlackText are now separate flags.

page/FrameView.cpp: (WebCore::FrameView::reset): (WebCore::FrameView::paintContents): (WebCore::FrameView::setPaintBehavior):
page/FrameView.h:
page/mac/FrameMac.mm: (WebCore::Frame::selectionImage):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): (WebCore::RenderLayer::paintLayer):
rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): (WebCore::RenderLayerBacking::paintContents):
rendering/RenderLayerBacking.h:
rendering/RenderObject.h:
rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):

1:41 PM Changeset in webkit [51352] by oliver@apple.com

2 edits in trunk/JavaScriptCore

JSON.stringify performance on undefined is very poor
https://bugs.webkit.org/show_bug.cgi?id=31839

Reviewed by Alexey Proskuryakov.

Switch from a UString to a Vector<UChar> when building
the JSON string, allowing us to safely remove the substr-copy
we otherwise did when unwinding an undefined property.

Also turns out to be a ~5% speedup on stringification.

1:31 PM Changeset in webkit [51351] by eric.carlson@apple.com

8 edits in trunk/WebCore

2009-11-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7409331> Windows: Support closed caption in <video> element

Enable closed captions in QuickTime/Windows media engine.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::hasClosedCaptions): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::hasClosedCaptions): (QTMovieWin::setClosedCaptionsVisible):
platform/graphics/win/QTMovieWin.h:
rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):
rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):
rendering/RenderThemeWin.h:

1:22 PM Changeset in webkit [51350] by darin@chromium.org

6 edits
4 adds in trunk

2009-11-24 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Renderer hang when using www.expedia.com
https://bugs.webkit.org/show_bug.cgi?id=31822

Test: http/tests/cache/subresource-failover-to-network.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Use the originalRequest when inheriting cache policy. This matches SubresourceLoader::create.

2009-11-24 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Renderer hang when using www.expedia.com
https://bugs.webkit.org/show_bug.cgi?id=31822

This test verifies that a synchronous XMLHttpRequest, generated from a
page that is the result of a form submission, loads properly when the
user navigates back to the page.

When navigating back to a page that resulted from a form submission,
the page is loaded with the ReturnCacheDataDontLoad cache policy. It
is important that subresources (including XMLHttpRequest instances) do
not inherit this cache policy.

http/tests/cache/resources/echo-no-store.cgi: Added.
http/tests/cache/resources/subresource-failover-to-network.cgi: Added.
http/tests/cache/subresource-failover-to-network-expected.txt: Added.
http/tests/cache/subresource-failover-to-network.html: Added.

2009-11-24 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Renderer hang when using www.expedia.com
https://bugs.webkit.org/show_bug.cgi?id=31822

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest): Assign ReturnCacheDataDontLoad cache policy at the last moment to match Safari. This way the cache policy does not get stored in DocumentLoader's originalRequest preventing it from being inherited by subresource requests.
src/ResourceHandle.cpp: (WebCore::ResourceHandle::willLoadFromCache): Remove assignment of ReturnCacheDataDontLoad cache policy so that it doesn't end up applying to the DocumentLoader's originalRequest.

12:18 PM Changeset in webkit [51349] by cmarrin@apple.com

2 adds in trunk/WebCore/html/canvas

Didn't add these files to http://trac.webkit.org/changeset/51348

12:04 PM Changeset in webkit [51348] by cmarrin@apple.com

33 edits in trunk

Change get... calls to latest spec
https://bugs.webkit.org/show_bug.cgi?id=30091

Removed old versions of get calls on WebGLRenderingContext and
added new ones per spec returning "any". New code simplifies
GraphicsContext3D and fixes previously unimplemented routines.
Added custom JS and V8 bindings. Added exhaustive test case
exercising all new code paths. Updated preexisting test cases for
new APIs. Fixed preexisting bugs in WebKit's and Chrome's WebGL
implementations.

Ran WebGL layout tests in WebKit (clean) and Chrome (couple of
preexisting known failures) and manual WebGL tests in both
browsers.

11:51 AM Changeset in webkit [51347] by sfalken@apple.com

2 edits in trunk/WebCore

Windows build fix.

WebCore.vcproj/QTMovieWin.vcproj: Add additional search path for QuickTime SDK.

11:50 AM Changeset in webkit [51346] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/31840> bisect-builds broke after r50080

Reviewed by Dan Bernstein.

Scripts/bisect-builds:

(mountAndRunNightly): Switched back to using backticks to run
the hdiutil command since exec() will terminate the existing
script, which is not what we want. Store the output of
File::Spec->devnull() in a variable for use in the hdiutil
detach commands.

11:38 AM Changeset in webkit [51345] by pfeldman@chromium.org

2 edits in trunk/WebKit/chromium

2009-11-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Darin Fisher.

Chromium: Expose method for reporting user stats
to the host. Also includes drive-by default implementation.

https://bugs.webkit.org/show_bug.cgi?id=31830

public/WebKitClient.h:

11:33 AM Changeset in webkit [51344] by dimich@chromium.org

2 edits
1 add
5 deletes in trunk/LayoutTests

Convert fast/table/row-height-recalc2.html to be 'dumpAsText()'
https://bugs.webkit.org/show_bug.cgi?id=31816

Reviewed by Eric Seidel.

fast/table/row-height-recalc2-expected.txt: Added.
fast/table/row-height-recalc2.html:
platform/mac/fast/table/row-height-recalc2-expected.checksum: Removed.
platform/mac/fast/table/row-height-recalc2-expected.png: Removed.
platform/mac/fast/table/row-height-recalc2-expected.txt: Removed.
platform/qt/fast/table/row-height-recalc2-expected.checksum: Removed.
platform/qt/fast/table/row-height-recalc2-expected.png: Removed.
platform/qt/fast/table/row-height-recalc2-expected.txt: Removed.
platform/win/fast/table/row-height-recalc2-expected.checksum: Removed.
platform/win/fast/table/row-height-recalc2-expected.png: Removed.

10:55 AM Changeset in webkit [51343] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-24 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] GStreamer-CRITICAL's (and other warnings) on <video>
https://bugs.webkit.org/show_bug.cgi?id=26354

Implemented MediaPlayerPrivate::isAvailable by checking the
presence of the playbin2 GStreamer element.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::isAvailable):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

10:47 AM Changeset in webkit [51342] by eric@webkit.org

4 edits in trunk

2009-11-24 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

When building up the pango layout from text boxes, only append a
newline char after verifying there are no more boxes on this line.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getPangoLayoutForAtk):

2009-11-24 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

When building up the pango layout from text boxes, only append a
newline char after verifying there are no more boxes on this line.

tests/testatk.c (test_webkit_atk_get_text_at_offset_newlines): (main):

9:53 AM Changeset in webkit [51341] by Joseph Pecoraro

4 edits in trunk/WebCore

2009-11-24 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Keyboard Shortcut to Clear Console Messages
https://bugs.webkit.org/show_bug.cgi?id=31780

All Platforms: Ctrl+L = Clear Console Messages
Mac Only: Cmd+K = Clear Console Messages

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): create shortcuts (WebInspector.ConsoleView.prototype._promptKeyDown): handle shortcuts
inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut.makeKey): convenience conversion of "a-z" character to keyCode
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): style fixes for keyboard shortcuts

9:20 AM Changeset in webkit [51340] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-24 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: touch inspector controller in order to
kick win bot inspector deploy. rs=aroben.

inspector/InspectorController.cpp:

9:15 AM Changeset in webkit [51339] by pfeldman@chromium.org

7 edits in trunk

2009-11-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement expandable compartments on timeline panel.

https://bugs.webkit.org/show_bug.cgi?id=31796

inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelineRecordListRow.prototype.dispose): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelineRecordGraphRow.prototype._onClick): (WebInspector.TimelineRecordGraphRow.prototype.dispose):
inspector/front-end/inspector.css:

8:15 AM Changeset in webkit [51338] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2009-11-24 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[Chromium] Fix DOM storage layout tests
https://bugs.webkit.org/show_bug.cgi?id=31833

The issue is, essentially, that this code assumes that
SecurityOrigin::createString can re-create a SecurityOrigin given
the string produced from SecurityOrigin::toString. This is a bogus
assumption in a number of corner cases (e.g., document.domain,
@sandbox). A recent patch (http://trac.webkit.org/changeset/51294)
make this assumption further invalid in the case of of file:// URLs.

The correct fix is for this code to use WebSecurityOrigin objects
(and not strings) to represent SecurityOrigin objects. However, the
expert on this code is on vacation, and I don't want to do major
surgery here without his involvement. This patch is a temporary fix
to get these tests passing again. We'll do the right fix once
jorlow gets back from vacation.

Tests: Covered by a number of existing DOM storage tests.

src/WebStorageNamespaceImpl.cpp: (WebKit::WebStorageNamespaceImpl::createStorageArea):

2:21 AM Changeset in webkit [51337] by mrowe@apple.com

8 edits in trunk

Fix production builds where the source tree may be read-only.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed