Context Navigation

Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=29966

A test case where a user drags the mouse from an empty inline
element to above texts.

editing/selection/last-empty-inline-expected.txt: Added.
editing/selection/last-empty-inline.html: Added.
platform/win/Skipped:

2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=29966

When an empty inline element is clicked, the root inline box has
no leaf children. Use the renderer of a normal child instead.

This change resolves Windows port's assertion failure in a layout test.
Also, this fixes the behavior when a user drags the mouse from an
empty inline element to above texts.

Test: editing/selection/last-empty-inline.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPointWithInlineChildren):

9:59 PM Changeset in webkit [51428] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-26 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Ignore line-height CSS property specified to push buttons on
Windows and Linux.
https://bugs.webkit.org/show_bug.cgi?id=31712

LayoutTests/fast/forms/control-restrict-line-height.html checks that the
following controls should ignore line-height CSS property.

<select>
<input type=button>
<input type=search>

This change addresses the <input type=button> issue with Chromium/Windows
and Chromium/Linux.

rendering/RenderThemeChromiumSkia.cpp: Implement adjustButtonStyle() to ignore line-height.
rendering/RenderThemeChromiumSkia.h: Declare adjustButtonStyle().

9:53 PM Changeset in webkit [51427] by eric@webkit.org

2 edits
2 adds
4 deletes in trunk/LayoutTests

2009-11-26 Kinuko Yasuda <kinuko@chromium.com>

Reviewed by Eric Seidel.

Rewrite the test fast/parser/comment-in-textarea to use dumpAsText
so that the expected results can be independent of platform differences.
https://bugs.webkit.org/show_bug.cgi?id=31580

fast/parser/comment-in-textarea-expected.txt: Added.
fast/parser/comment-in-textarea.html:
fast/parser/script-tests/comment-in-textarea.js: Added.
platform/mac/fast/parser/comment-in-textarea-expected.checksum: Removed.
platform/mac/fast/parser/comment-in-textarea-expected.png: Removed.
platform/mac/fast/parser/comment-in-textarea-expected.txt: Removed.
platform/win/fast/parser/comment-in-textarea-expected.txt: Removed.

9:46 PM Changeset in webkit [51426] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-26 Kinuko Yasuda <kinuko@chromium.com>

Reviewed by Eric Seidel.

Remove the special charset meta tag in the clipboard so that
copy-and-paste with interchange breaklines/spaces works correctly
within WebKit.

No new tests. Layout tests that involve copy-and-paste with
interchange breaklines (like editing/pasteboard/paste-line-endings-00?)
should pass on Mac/Chromium with this fix.

platform/chromium/ClipboardChromium.cpp:
platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::documentFragment):

9:33 PM Changeset in webkit [51425] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-26 İsmail Dönmez <ismail@namtrac.org>

Reviewed by Eric Seidel.

Compile with QT_NO_WHEELEVENT defined.

platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::applyDelta):

9:20 PM Changeset in webkit [51424] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Incorrect behaviour of jneq_null in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=31901

Reviewed by Gavin Barraclough.

Correct the logic of jneq_null. This is already covered by existing tests.

8:06 PM Changeset in webkit [51423] by Laszlo Gombos

15 edits
2 moves in trunk

2009-11-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Oliver Hunt.

Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793

GNUmakefile.am: Change the path for GOwnPtr.*.
JavaScriptCore.gyp/JavaScriptCore.gyp: Remove GOwnPtr.cpp from the exclude list.
JavaScriptCore.gypi: Change the path for GOwnPtr.*.
wscript: Remove GOwnPtr.cpp from the exclude list.
wtf/GOwnPtr.cpp: Removed.
wtf/GOwnPtr.h: Removed.
wtf/Threading.h: Change the path for GOwnPtr.h.
wtf/gtk/GOwnPtr.cpp: Copied from JavaScriptCore/wtf/GOwnPtr.cpp.
wtf/gtk/GOwnPtr.h: Copied from JavaScriptCore/wtf/GOwnPtr.h.
wtf/unicode/glib/UnicodeGLib.h: Change the path for GOwnPtr.h.

2009-11-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Oliver Hunt.

Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793

webkit/webkitwebview.cpp: Change the path for GOwnPtr.h.

2009-11-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Oliver Hunt.

Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793

No new tests as there is no functional change.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Change the path for GOwnPtr.h.
platform/text/TextEncoding.cpp: Ditto.
platform/text/gtk/TextCodecGtk.cpp: Ditto.

2009-11-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Oliver Hunt.

Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793

GNUmakefile.am: Add JavaScriptCore/wtf/gtk to the include path.

1:22 PM Changeset in webkit [51422] by yurys@chromium.org

10 edits in trunk

2009-11-26 Yury Semikhatsky <yurys@chromium.org>

Not reviewed. Build fix: revert r51421.

inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
inspector/InspectorController.h:
inspector/InspectorResource.cpp: (WebCore::InspectorResource::addLength):
loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):

2009-11-26 Yury Semikhatsky <yurys@chromium.org>

Not reviewed. Build fix: revert r51421.

public/WebDevToolsAgent.h:
public/WebView.h:
src/WebViewImpl.cpp:
src/WebViewImpl.h:

12:59 PM Changeset in webkit [51421] by yurys@chromium.org

10 edits in trunk

2009-11-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

This is a WebCore part of the fix that allows to view plugin
resources loaded by plugins.

https://bugs.webkit.org/show_bug.cgi?id=31832

inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
inspector/InspectorController.h: Remove unused DocumentLoader parameters from inspector methods.
inspector/InspectorResource.cpp: (WebCore::InspectorResource::addLength): Update loading end time when new data are received.
loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFailToLoad): Notify InspectorController about the failure. (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):

2009-11-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

WebCore part of the fix that allows to view plugin
resources loaded by plugins. Methods that for resource
loading notifications are exposed through WebDevToolsAgent
interface to the glue code to allow Chromium's plugin
implementation to notify InspectorController about resource
loading in plugins.

https://bugs.webkit.org/show_bug.cgi?id=31832

public/WebDevToolsAgent.h:
public/WebView.h:
src/WebViewImpl.cpp: (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
src/WebViewImpl.h:

12:27 PM Changeset in webkit [51420] by eric@webkit.org

5 edits
2 adds in trunk

2009-11-26 Daniel Bates <dbates@webkit.org>

Reviewed by Pavel Feldman.

https://bugs.webkit.org/show_bug.cgi?id=21554

Tests that the tooltip text for an image is its dimensions.

inspector/elements-img-tooltip-expected.txt: Added.
inspector/elements-img-tooltip.html: Added.

2009-11-26 Daniel Bates <dbates@webkit.org>

Reviewed by Pavel Feldman.

https://bugs.webkit.org/show_bug.cgi?id=21554

Implements support for hovering over <img> src to display the height and width of that image
in a tooltip. Displays both the displayable and natural dimensions of the image.

Test: inspector/elements-img-tooltip.html

inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode): Added. (WebInspector.ElementsTreeElement.prototype._updateTitle.callback): (WebInspector.ElementsTreeElement.prototype._updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy.getPropertiesAsync): Added.
inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode): Added tooltipText argument. (WebInspector.linkifyURL): Ditto.

10:06 AM Changeset in webkit [51419] by kevino@webkit.org

2 edits in trunk/WebCore

wx build fix after drawPattern API change.

8:50 AM Changeset in webkit [51418] by cmarrin@apple.com

8 adds in trunk/LayoutTests/fast/canvas/webgl

Missed checking in these files from https://bugs.webkit.org/show_bug.cgi?id=30091

8:50 AM Changeset in webkit [51417] by zoltan@webkit.org

2 edits in trunk/WebKitTools

2009-11-26 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Adam Barth.

Remove directory prefixes from linux commands

SCM unittests can cause errors on some systems if we use absolute reference to
the commands, so directory prefixes have been removed.

Scripts/modules/scm_unittest.py:

7:59 AM Changeset in webkit [51416] by eric@webkit.org

7 edits in trunk/WebCore

2009-11-26 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Use an internal field instead of hidden property to speedup lookup
of entered isolated world.

Plus some inlinings.
https://bugs.webkit.org/show_bug.cgi?id=31884

Covered by layout tests + manual running of some benchmarks as
content scripts.

bindings/v8/V8DOMWrapper.cpp:
bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::setDOMWrapper):
bindings/v8/V8HiddenPropertyName.h:
bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::getEntered): (WebCore::V8IsolatedWorld::getGlobalObject):
bindings/v8/custom/V8CustomBinding.h:

7:06 AM Changeset in webkit [51415] by Simon Hausmann

1 edit
3 deletes in trunk/WebKit/qt

Rubber-stamped by Holger Freyther.

Removed unused ICO image plugin handler.

Plugins/ICOHandler.cpp: Removed.
Plugins/ICOHandler.h: Removed.
Plugins/Plugins.pro: Removed.

6:34 AM Changeset in webkit [51414] by eric@webkit.org

2 edits
1 move in trunk/WebCore

2009-11-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Corrects build break on Windows.

Rename platform/text/qt/TextBoundaries.cpp to TextBoundariesQt.cpp since
platform/text/TextBoundaries.cpp was compiled instead when compiling with nmake.

WebCore.pro:
platform/text/qt/TextBoundariesQt.cpp: Renamed from WebCore/platform/text/qt/TextBoundaries.cpp. (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):

5:20 AM Changeset in webkit [51413] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-26 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Do not check if the thread is main or not when accessing DOMDataStore as currently in Chromium WebKit is used in main thread only.
https://bugs.webkit.org/show_bug.cgi?id=31877

Covered by layout tests and buildbots.

bindings/v8/V8DOMMap.cpp: (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap):

5:04 AM Changeset in webkit [51412] by Girish Ramakrishnan

2 edits in trunk/WebCore

[Qt] Mac Plugins : Pass mouse position relative to the fake window

Reviewed by Holger Freyther.

When using off-screen rendering, we need to pass mouse events relative
to the fake window instead of the global position.

https://bugs.webkit.org/show_bug.cgi?id=31794

4:44 AM QtWebKitMirrorGuide edited by zecke@selfish.org

Mention the Math.random() problem with the test content. (diff)

4:33 AM QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org

(diff)

4:31 AM QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org

(diff)

4:26 AM QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org

Fix the marking of completed items. (diff)

4:23 AM QtBackLog edited by zecke@selfish.org

Put the commits and date into the right column (diff)

4:21 AM QtBackLog edited by zecke@selfish.org

Mention the network change, and the issue that QtWebKit is using less … (diff)

4:18 AM QtBackLog edited by zecke@selfish.org

Complete the QtPlugin work (diff)

3:16 AM Changeset in webkit [51411] by zecke@webkit.org

2 edits in trunk/WebCore

[Qt] Use QNetworkReply::rawHeaderPairs

https://bugs.webkit.org/show_bug.cgi?id=31826

The QNetworkReply is internally storing the HTTP headers
as a list of pairs. Currently we have to ask the QNetworkReply
to put all header names into a QStringList. Afterwards we will
iterate over this QStringList and ask the QNetworkReply to
give us the value for this header name. The current Qt implementation
is doing a linear to find the header value.

Use a new API to directly access the list of pairs and push
this into WebCore. This avoids doing some allocations and doing
linear searches from within a loop.

platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

2:34 AM Changeset in webkit [51410] by zecke@webkit.org

11 edits
2 adds in trunk

[Qt] Add automatic test case for plugins that use QWidget

https://bugs.webkit.org/show_bug.cgi?id=31203

Change the RenderTreeAsText to look into the WebCore::Widget
and print the state of the platformWidget. Change the DRT to
use QtUiTools to be able to initiate QProgressBar and such
as a plugin. Add the test case, add the result, update the
other results due the new test.

WebCore:

rendering/RenderTreeAsText.cpp:

(WebCore::operator<<): Add special case for RenderPart

WebKitTools:

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::createPlugin):

DumpRenderTree/qt/DumpRenderTree.h:
DumpRenderTree/qt/DumpRenderTree.pro:

LayoutTest:

platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/plugins/netscape-dom-access-expected.txt: Added
platform/qt/plugins/qt-qwidget-plugin-expected.txt: Added
platform/win/Skipped:
plugins/qt-qwidget-plugin.html: Added.

2:31 AM Changeset in webkit [51409] by zecke@webkit.org

6 edits in trunk

[Qt] Call Widget::setSelfVisible from hide/show

https://bugs.webkit.org/show_bug.cgi?id=31203

Call Widget::setSelfVisible from Widget::show and
Widget::hide and use isParentVisible to decide
if the widget should be shown. This way client
code can rely on isVisible.

Change PluginViewQt::show, PluginViewQt::hide to
call the base class as it is doing the right thing
now. Add an assert verify that platfomWidget and
platformPluginWidget are the same.

manual-tests/qt/qtplugin.html: Modify manual test
platform/qt/WidgetQt.cpp:

(WebCore::Widget::show):
(WebCore::Widget::hide):

[Qt] Do not show the QWidget when the WebCore::Widget is hidden

https://bugs.webkit.org/show_bug.cgi?id=31203

The clipping code was making a QWidget visible even if the
WebCore::Widget was hidden. Fix the bug by calling setVisible
only if the WebCore::Widget Widget::isSelfVisible.

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::QtPluginWidget::show): Override WebCore::Widget::show to call handleVisibility
(WebCore::QtPluginWidget::handleVisibility): New method to call setVisible when we are visible
(FrameLoaderClientQt::createPlugin): Hide the QWidget by default

2:31 AM Changeset in webkit [51408] by zecke@webkit.org

2 edits in trunk/WebCore

Fix compilation of REQUEST_DEBUG debug code

https://bugs.webkit.org/show_bug.cgi?id=31850

In r47907 the single parameter KURL constructor to parse
from a WebCore::String was replaced with a two parameter
constructor. I think in this debug case parsing the urls
again is no problem and I have changed the code to use the
two parameter version.

loader/loader.cpp:

(WebCore::Loader::Host::didFinishLoading):

12:43 AM Changeset in webkit [51407] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-26 Søren Gjesse <sgjesse@chromium.org>

Reviewed by Pavel Feldman.

[V8] Avoid using JavaScript objects as context data
https://bugs.webkit.org/show_bug.cgi?id=31873

Change the context "data" from a JavaScript object holding the two properties type and value to
a string holding type and value separated by a comma.

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::setContextDebugId): (WebCore::V8Proxy::contextDebugId):

Nov 25, 2009:

10:16 PM Changeset in webkit [51406] by eric@webkit.org

10 edits in trunk/WebKitTools

2009-11-25 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Update pywebsocket to 0.4.2

Update pywebsocket to 0.4.2
https://bugs.webkit.org/show_bug.cgi?id=31861

pywebsocket/example/echo_client.py:
pywebsocket/example/echo_wsh.py:
pywebsocket/mod_pywebsocket/init.py:
pywebsocket/mod_pywebsocket/dispatch.py:
pywebsocket/mod_pywebsocket/msgutil.py:
pywebsocket/mod_pywebsocket/standalone.py:
pywebsocket/setup.py:
pywebsocket/test/test_dispatch.py:
pywebsocket/test/test_msgutil.py:

7:02 PM Changeset in webkit [51405] by abarth@webkit.org

4 edits
2 copies in trunk/WebKitTools

2009-11-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add unit test for mark-fixed
https://bugs.webkit.org/show_bug.cgi?id=31896

Scripts/modules/commands/commandtest.py: Added.
Scripts/modules/commands/queries_unittest.py:
Scripts/modules/commands/upload_unittest.py: Added.
Scripts/modules/mock_bugzillatool.py:
Scripts/run-webkit-unittests:

6:25 PM Changeset in webkit [51404] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-11-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool should have a mark-fixed command
https://bugs.webkit.org/show_bug.cgi?id=31853

Pretty simple stuff.

Scripts/modules/commands/upload.py:

6:22 PM Changeset in webkit [51403] by eric@webkit.org

8 edits in trunk/WebKitTools

2009-11-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

'bugzilla-tool help' should only show common commands like how 'git help' does
https://bugs.webkit.org/show_bug.cgi?id=31772

I also took this opportunity to make 'help' a real Command.
Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).

Scripts/bugzilla-tool:
- change should_show_command_help to should_show_in_main_help
Scripts/modules/commands/download.py:
- Mark commands as being shown in main help or not.
- show_in_main_help = False is not required (default is false), but it seemed to make the commands more self-documenting.
Scripts/modules/commands/queries.py: ditto
Scripts/modules/commands/queues.py: ditto
Scripts/modules/commands/upload.py: ditto
Scripts/modules/multicommandtool.py:
- Make Command hold a pointer to tool in self.tool. Most Command subclasses do not take advantage of this yet, but it was required for HelpCommand to be able to reach the tool from _help_epilog().
- Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
- Move MultiCommandTool._help_epilog to Command._help_epilog
- Move "help" logic into HelpCommand.execute()
- Change should_show_command_help to should_show_in_main_help and add a default implementation.
Scripts/modules/multicommandtool_unittest.py:
- Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'

4:57 PM Changeset in webkit [51402] by Dimitri Glazkov

6 edits in trunk

WebCore:

2009-11-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

[Chromium] Implement canSetValueAttribute in the API, the clean-up part.
https://bugs.webkit.org/show_bug.cgi?id=31894

accessibility/chromium/AccessibilityObjectWrapper.h: Added RefCounted decl. (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Removed mis-refcountingness.

WebKit/chromium:

2009-11-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

[Chromium] Implement canSetValueAttribute in the API.
https://bugs.webkit.org/show_bug.cgi?id=31894

public/WebAccessibilityObject.h: Added decl.
src/WebAccessibilityCacheImpl.h: Cleaned up mis-include.
src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::canSetValueAttribute): Added impl.

4:51 PM Changeset in webkit [51401] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Audio related layout tests are failing on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=27910

platform/qt/Skipped: fast/js/global-constructors.html added.

4:44 PM Changeset in webkit [51400] by eric@webkit.org

3 edits
3 adds in trunk

2009-11-25 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Off-by-one error in index validation for drawElements and drawArrays
https://bugs.webkit.org/show_bug.cgi?id=31891

Fixed computation of number of elements for bound array objects.

Test: fast/canvas/webgl/index-validation.html

fast/canvas/webgl/index-validation-expected.txt: Added.
fast/canvas/webgl/index-validation.html: Added.
fast/canvas/webgl/script-tests/index-validation.js: Added.

2009-11-25 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Off-by-one error in index validation for drawElements and drawArrays
https://bugs.webkit.org/show_bug.cgi?id=31891

Fixed computation of number of elements for bound array objects.

Test: fast/canvas/webgl/index-validation.html

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::vertexAttribPointer):

4:41 PM Changeset in webkit [51399] by bweinstein@apple.com

2 edits in trunk/WebKitTools

Patch by Mark Rowe.

Reviewed by Dan Bernstein.

The buildbots are failing on Windows because when they were upgraded
to 4.0.4, Apple Application Support was not in their path. Add it to
the path to fix the buildots.

Scripts/webkitdirs.pm:

4:29 PM Changeset in webkit [51398] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Remove a bunch of now passing fast tests from skiplist.
And add a crasher/crashed pair into skiplist.

platform/qt/Skipped:

3:44 PM Changeset in webkit [51397] by dimich@chromium.org

2 edits in trunk/WebCore

Update SharedScript to use eventNames() instead of EventNames()
https://bugs.webkit.org/show_bug.cgi?id=31890

Reviewed by David Levin.

SharedScript/WebKitSharedScript.cpp:

(WebCore::LoadEventTask::performTask):

3:29 PM Changeset in webkit [51396] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Put tests into skiplist because of missing layoutTestController feature.

platform/qt/Skipped:
http/tests/cache/subresource-failover-to-network.html added.
fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html added.

"3D_RENDERING and ACCELERATED_COMPOSITING" block moved to good place.

2:26 PM Changeset in webkit [51395] by Csaba Osztrogonác

2 edits in trunk/WebKitTools

run-webkit-tests doesn't accept directories/files with --skipped=only parameter
https://bugs.webkit.org/show_bug.cgi?id=31799

Reviewed by David Kilzer.

Scripts/run-webkit-tests: Fixed.

1:09 PM Changeset in webkit [51394] by darin@chromium.org

2 edits in trunk/WebKit/chromium

2009-11-25 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Unable to repost form data by hitting reload
https://bugs.webkit.org/show_bug.cgi?id=31882

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadData):

1:08 PM Changeset in webkit [51393] by eric.carlson@apple.com

10 edits in trunk

2009-11-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7409331> Windows: Support closed caption in <video> element

Enable closed captions in QuickTime/Windows media engine.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::hasClosedCaptions): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):

New, all through to m_qtMovie.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

Make all but the destructor private since MediaPlayer call through the media
engine interface.

platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::disableUnsupportedTracks):

Use handy new constants for QuickTime track types.

(QTMovieWin::hasClosedCaptions):
(QTMovieWin::setClosedCaptionsVisible):

New, closed caption support.

platform/graphics/win/QTMovieWin.h:

rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):

Deal with closed caption buttons.

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::shouldRenderMediaControlPart):

New, don't ask the media engine if it has closed captions unless the Safari theme will
be able to render the button.

(WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):

New.

rendering/RenderThemeWin.h:

2009-11-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7409331> Windows: Support closed caption in <video> element

platform/win/Skipped:

Enable the closed caption test.

12:04 PM Changeset in webkit [51392] by eric@webkit.org

5 edits in trunk/WebCore

2009-11-25 Drew Wilson <atwilson@chromium.org>

Reviewed by David Levin.

MessagePorts always look remotely entangled even when closed.
https://bugs.webkit.org/show_bug.cgi?id=31698

Tests: Existing tests suffice, Chromium soak test passes now.

bindings/v8/custom/V8CustomBinding.h: Removed kMessagePortEntangledPortIndex which is no longer used.
bindings/v8/V8GCController.cpp: (WebCore::GCPrologueVisitor::visitDOMWrapper): Simplified GC code to reflect the Chromium MessagePort implementation (locallyEntangledPort() always returns false). (WebCore::GCEpilogueVisitor::visitDOMWrapper): Cleaned up epilogue code to handle the case where the port gets closed in mid-GC (due to the parent context being freed).
dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::close): Now sets the closed flag. (WebCore::MessagePort::disentanglePorts): Updated to use new isCloned() API instead of relying on isEntangled(), which was incorrect.
dom/MessagePort.h: Added a m_closed flag and updated isEntangled() to check it. (WebCore::MessagePort::isEntangled): Now returns false if the port has been closed. (WebCore::MessagePort::isCloned): Added new API to differentiate between cloned and closed ports (closed ports can still be passed to postMessage).

12:02 PM Changeset in webkit [51391] by zoltan@webkit.org

3 edits in trunk/WebKitTools

2009-11-25 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Change run_command to give back stderr by default
https://bugs.webkit.org/show_bug.cgi?id=31734

Change run_command to give back stderr by default.
Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
Change the related unittest call.

Scripts/modules/scm.py:
Scripts/modules/scm_unittest.py:

10:22 AM Changeset in webkit [51390] by kov@webkit.org

2 edits in trunk/LayoutTests

Skip test that needs structure we do not provide yet

10:03 AM Changeset in webkit [51389] by Dimitri Glazkov

4 edits in trunk/WebKit/chromium

2009-11-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

[Chromium] Plumb setNeedsSiteSpecificQuirks throught WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=31878

public/WebSettings.h: Added decl.
src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setNeedsSiteSpecificQuirks): Added impl.
src/WebSettingsImpl.h:

9:12 AM Changeset in webkit [51388] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Fix crash of QtWebKit on any page with Flash when compiled with MinGW.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-11-25
Reviewed by Simon Hausmann.

Fix inline assembly, don't dereference the function pointer twice.

plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::hookedBeginPaint):
(WebCore::PluginView::hookedEndPaint):

9:02 AM Changeset in webkit [51387] by Simon Hausmann

4 edits in trunk

[Qt] Remove the Referer header when redirecting to a non-secure site
https://bugs.webkit.org/show_bug.cgi?id=31785

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-11-22
Reviewed by Adam Barth.

This makes Qt pass two tests introduced in r50226.

WebCore:

platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

LayoutTests:

platform/qt/Skipped:

8:50 AM Changeset in webkit [51386] by benm@google.com

3 edits in trunk/WebCore

The select elements do not reflect the actual choice the user makes.
https://bugs.webkit.org/show_bug.cgi?id=31831

Patch by Andrei Popescu <andreip@google.com> on 2009-11-25
Reviewed by Dimitri Glazkov.

Handle the drawing of the listboxes in Android code.

No new features, just fixing an Android problem. Existing layout tests are sufficient.

platform/android/RenderThemeAndroid.cpp:

(WebCore::theme):
(WebCore::RenderThemeAndroid::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeAndroid::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeAndroid::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeAndroid::adjustButtonStyle):
(WebCore::RenderThemeAndroid::paintTextArea):
(WebCore::RenderThemeAndroid::adjustListboxStyle):

platform/android/RenderThemeAndroid.h:

8:15 AM Changeset in webkit [51385] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-25 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Load InspectorResource mime type from CachedResource for 304 responses

For network libraries that do not merge cache data into 304 ResourceResponses,
the mime type for cached resources is unknown.
https://bugs.webkit.org/show_bug.cgi?id=31868

inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::type):

8:06 AM Changeset in webkit [51384] by eric@webkit.org

1 edit
2 adds in trunk/WebCore

2009-11-25 Andrei Popescu <andreip@google.com>

Reviewed by Eric Seidel.

Android is missing implementation of SSL Key generator functions.
https://bugs.webkit.org/show_bug.cgi?id=31825

This change adds the PlatformBridge class to platform/android.
PlarformBridge is used to access the embedding layer for things
such as key generator, cookies, plugins, etc.

No new tests required, this is platform code.

platform/android/PlatformBridge.h: Added.
platform/android/SSLKeyGeneratorAndroid.cpp: Added. (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):

8:05 AM Changeset in webkit [51383] by eric@webkit.org

5 edits in trunk/WebKitTools

2009-11-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Centralize required argument parsing in Command
https://bugs.webkit.org/show_bug.cgi?id=31872

Scripts/modules/commands/download.py: remove custom required arg message.
Scripts/modules/commands/upload.py: ditto.
Scripts/modules/multicommandtool.py:
- Add _parse_required_arguments.
- Pass program name off to OptionParser.
- Add name() for access to tool name.
- Add check_arguments_and_execute and make it return a return code.
- Replace a couple uses of + with %.
Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments

7:59 AM Changeset in webkit [51382] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-25 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GTK] use gst_init_check() instead of gst_init()
https://bugs.webkit.org/show_bug.cgi?id=31864

Use gst_init_check() instead of gst_init() to prevent eventual
unexpected exit of the application.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::do_gst_init): (WebCore::MediaPlayerPrivate::isAvailable):

7:46 AM Changeset in webkit [51381] by eric@webkit.org

3 edits
1 add in trunk/WebKitTools

2009-11-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
https://bugs.webkit.org/show_bug.cgi?id=31870

Scripts/modules/commands/queries_unittest.py: Use the new class.
Scripts/modules/multicommandtool_unittest.py: Ditto.
Scripts/modules/outputcapture.py: Added.

5:01 AM Changeset in webkit [51380] by kov@webkit.org

2 edits in trunk/WebCore

Reviewed by Xan Lopez.

Some tests are crashing from time to time
https://bugs.webkit.org/show_bug.cgi?id=31866

Make sure we do not notify the client of a finished load, if the
load has been cancelled, or the client is gone.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):

3:02 AM Changeset in webkit [51379] by benm@google.com

6 edits in trunk/WebCore

[Android] Upstream Android changes to WebCore/bridge/jni
https://bugs.webkit.org/show_bug.cgi?id=31824

Reviewed by Eric Seidel.

No new tests required as no new functionality.

bridge/jni/jni_class.cpp:

(JavaClass::JavaClass): Add calls to delete allocated references, to avoid potential leaks.

bridge/jni/jni_instance.cpp: Add an Android include path.
bridge/jni/jni_instance.h: Add getter/setter for JObjectWrapper::_instance and make the JavaInstance ctor and member variables protected. Both needed for the Android port, see bug for discussion.

(JSC::Bindings::JObjectWrapper::instance): Added.
(JSC::Bindings::JObjectWrapper::setInstance): Added.

bridge/jni/jni_runtime.cpp:

(JavaMethod::JavaMethod): Delete an allocated reference to avoid a potential leak.

bridge/jni/jni_utility.h:

(JSC::Bindings::callJNIMethodV): Delete an allocated reference to avoid a potential leak.

1:40 AM QtWebKitContrib edited by Simon Hausmann

(diff)

12:25 AM Changeset in webkit [51378] by zoltan@webkit.org

11 edits in trunk/WebCore

Allow custom memory allocation control for classes of the plugins and rendering directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31827

Reviewed by Eric Seidel.

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

class PluginRequest - plugins/PluginView.cpp:521
class PluginMainThreadScheduler - plugins/PluginMainThreadScheduler.cpp:34
class PluginDatabase - plugins/PluginDatabase.cpp:50
struct MimeClassInfo - plugins/PluginInfoStore.cpp:50
struct PluginInfo - plugins/PluginInfoStore.cpp:40
class RenderArena - dom/Document.cpp:1401
class RenderImageScaleData - rendering/RenderImage.cpp:149
class TableLayout - (its child class) rendering/RenderTable.cpp:82
struct ColumnInfo - rendering/RenderBlock.cpp:3590
struct FloatingObject - rendering/RenderBlock.cpp:2300
struct MaxMargin - rendering/RenderBlock.cpp:4794
class RenderMarquee - rendering/RenderLayer.cpp:3277

plugins/PluginData.h:
plugins/PluginDatabase.h:
plugins/PluginMainThreadScheduler.h:
plugins/PluginView.h:
rendering/RenderArena.h:
rendering/RenderBlock.cpp:
rendering/RenderBlock.h:
rendering/RenderImage.cpp:
rendering/RenderMarquee.h:
rendering/TableLayout.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed