Timeline
Nov 27, 2009:
- 11:39 PM Changeset in webkit [51456] by
-
- 3 edits in trunk/WebKit/chromium
2009-11-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Add separate method for pause command to WebDevToolsAgent
and WebDevToolsFrontendClient interfaces so that pause command
can be processed on the IO thread.
- public/WebDevToolsAgent.h:
- public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendDebuggerCommandToAgent): (WebKit::WebDevToolsFrontendClient::sendDebuggerPauseScript): (WebKit::WebDevToolsFrontendClient::activateWindow): (WebKit::WebDevToolsFrontendClient::closeWindow): (WebKit::WebDevToolsFrontendClient::dockWindow): (WebKit::WebDevToolsFrontendClient::undockWindow):
- 10:15 PM Changeset in webkit [51455] by
-
- 2 edits in trunk/WebCore
2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed Chromium build fix introduced by r51428.
[Chromium] Ignore line-height CSS property for PushButton
https://bugs.webkit.org/show_bug.cgi?id=31712
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustButtonStyle):
- 9:33 PM Changeset in webkit [51454] by
-
- 2 edits in trunk/WebCore
2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed Chromium test fix by reverting r51413.
[v8] Do not check the thread when accessing DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=31877
- bindings/v8/V8DOMMap.cpp: (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap):
- 4:32 PM Changeset in webkit [51453] by
-
- 2 edits in trunk/WebCore
2009-11-27 Daniel Bates <dbates@webkit.org>
Unreviewed, comment fix.
Corrected misspelling of the word "implemented".
- inspector/front-end/InjectedScriptAccess.js:
- 4:18 PM Changeset in webkit [51452] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed.
Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793
Build fix for chromium after r51423.
Exclude gtk directory from chromium build.
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- 3:46 PM Changeset in webkit [51451] by
-
- 1 edit1 move in trunk/WebKitTools
Rubber stamped by Eric Seidel.
Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
- CommitQueueStatus: Removed.
- CommitQueueStatus/app.yaml: Removed.
- CommitQueueStatus/filters: Removed.
- CommitQueueStatus/filters/init.py: Removed.
- CommitQueueStatus/filters/webkit_extras.py: Removed.
- CommitQueueStatus/index.html: Removed.
- CommitQueueStatus/index.yaml: Removed.
- CommitQueueStatus/queue_status.py: Removed.
- CommitQueueStatus/stylesheets: Removed.
- CommitQueueStatus/stylesheets/main.css: Removed.
- CommitQueueStatus/update_status.html: Removed.
- QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
- 3:39 PM Changeset in webkit [51450] by
-
- 2 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
style-queue should only process each patch once
https://bugs.webkit.org/show_bug.cgi?id=31939
Actually address reviewer comments!
- Scripts/bugzilla-tool:
- 3:36 PM Changeset in webkit [51449] by
-
- 2 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] style-queue fails to apply a bunch of patches for no reason
https://bugs.webkit.org/show_bug.cgi?id=31942
By passing --non-interactive to check-style, we convince check-style
to pass --force to svn-apply, which lets it apply more patches.
- Scripts/modules/commands/queues.py:
- 3:35 PM Changeset in webkit [51448] by
-
- 3 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Support --status-host in style-queue
https://bugs.webkit.org/show_bug.cgi?id=31941
- Scripts/modules/commands/queues.py:
- Scripts/modules/statusbot.py:
- 3:34 PM Changeset in webkit [51447] by
-
- 5 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
style-queue should only process each patch once
https://bugs.webkit.org/show_bug.cgi?id=31939
Before processing a patch, the try-queues now ask the web service
whether they have already processed the patch. This is an initial cut
of this functionality. I expect we're make it richer over time.
- Scripts/bugzilla-tool:
- Scripts/modules/commands/queues.py:
- Scripts/modules/patchcollection.py:
- 3:34 PM Changeset in webkit [51446] by
-
- 2 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PatchStatus does not return status
https://bugs.webkit.org/show_bug.cgi?id=31938
We need to parse attachment_id as an int. Otherwise, we can't find
anything in the datastore.
- CommitQueueStatus/queue_status.py:
- 3:04 PM Changeset in webkit [51445] by
-
- 17 edits in trunk
2009-11-27 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Makes the error messages more descriptive when we refuse to load an object/embed or
refuse to load from the document base URL.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadObject): Changed console message to be more descriptive. (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
2009-11-27 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Rebased results because of new error messages.
- http/tests/security/xssAuditor/base-href-control-char-expected.txt:
- http/tests/security/xssAuditor/base-href-expected.txt:
- http/tests/security/xssAuditor/base-href-null-char-expected.txt:
- http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
- http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/embed-tag-expected.txt:
- http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
- http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/object-src-inject-expected.txt:
- http/tests/security/xssAuditor/object-tag-expected.txt:
- http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
- 10:49 AM Changeset in webkit [51444] by
-
- 2 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make commit-queue status not throw an exception where there is not
status
https://bugs.webkit.org/show_bug.cgi?id=31936
We need to actually fetch the results of the query to see what's in the
datastore.
- CommitQueueStatus/queue_status.py:
- 10:09 AM Changeset in webkit [51443] by
-
- 3 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] unit test ApplyPatches and ApplyAttachment
https://bugs.webkit.org/show_bug.cgi?id=31935
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/download_unittest.py:
- 9:37 AM Changeset in webkit [51442] by
-
- 4 edits1 add in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Unit test download commands
https://bugs.webkit.org/show_bug.cgi?id=31923
Adds download_unittest and fixes a bug found while testing.
- Scripts/modules/commands/commandtest.py:
- Scripts/modules/commands/download.py:
Fixed a bug where we'd throw an error because [].append returns
None.
- Scripts/modules/commands/download_unittest.py: Added.
- Scripts/modules/mock_bugzillatool.py:
- Scripts/run-webkit-unittests:
- 8:21 AM Changeset in webkit [51441] by
-
- 3 edits in trunk/LayoutTests
2009-11-27 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
REGRESSION(51418): fast/canvas/webgl/gl-object-get-calls.html is failing on the Leopard commit bot
https://bugs.webkit.org/show_bug.cgi?id=31919
Temporarily disabled portion of test which is failing on some
machines but not others. Root cause will be investigated under
https://bugs.webkit.org/show_bug.cgi?id=31843 .
- fast/canvas/webgl/gl-object-get-calls-expected.txt:
- fast/canvas/webgl/script-tests/gl-object-get-calls.js:
- 5:07 AM Changeset in webkit [51440] by
-
- 10 edits in trunk
2009-11-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
This is a WebCore part of the fix that allows to view plugin
resources loaded by plugins.
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::addLength):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
2009-11-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
WebCore part of the fix that allows to view plugin
resources loaded by plugins. Methods that for resource
loading notifications are exposed through WebDevToolsAgent
interface to the glue code to allow Chromium's plugin
implementation to notify InspectorController about resource
loading in plugins.
- public/WebDevToolsAgent.h:
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
- src/WebViewImpl.h:
- 3:12 AM Changeset in webkit [51439] by
-
- 18 edits in trunk/WebCore
2009-11-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Instead of generating negative identifiers for cached resources in
InspectorController and extending identifier type from 'unsigned long' to 'long
long' reuse progress tracker from the inspected page to generate those
identifiers. It guarantees that InspectorResources have unique ids since
all of them are generated by that progress tracker.
Added a couple new overloaded methods to Script* objects that accept
long and unsigned long arguments. These types of argumens have already
been passed as long long.
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument):
- bindings/js/ScriptFunctionCall.h:
- bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set):
- bindings/js/ScriptObject.h:
- bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument):
- bindings/v8/ScriptFunctionCall.h:
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set):
- bindings/v8/ScriptObject.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::getTrackedResource): (WebCore::InspectorController::didLoadResourceFromMemoryCache): Use inspected page's ProgressTracker to generate unique identifiers for cached resources in InspectorController.
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildObjectForEventListener):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::updateFocusedNode):
- inspector/InspectorFrontend.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::createCached):
- inspector/InspectorResource.h: Change InspectorResource identifier type from 'long long' to 'unsigned long'. (WebCore::InspectorResource::create): (WebCore::InspectorResource::identifier):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createResourceSendRequestRecord): (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord): (WebCore::TimelineRecordFactory::createResourceFinishRecord):
- 12:45 AM Changeset in webkit [51438] by
-
- 2 edits in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix found while writing unit tests.
- Scripts/modules/commands/download.py:
- 12:04 AM Changeset in webkit [51437] by
-
- 7 edits1 delete in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904
Step 6: Kill the rest.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/queries.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/scm.py:
- Scripts/modules/webkitlandingscripts.py: Removed.
- 12:02 AM Changeset in webkit [51436] by
-
- 5 edits1 add in trunk/WebKitTools
2009-11-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Unit test upload commands
https://bugs.webkit.org/show_bug.cgi?id=31903
Adds unit tests for all but two of the upload commands. The two
remaining ones are more difficult. I'll return to them later. The
goal of these tests is just to run the commands. We can test more
detailed behavior later.
- Scripts/modules/commands/commandtest.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/commands/upload_unittest.py:
- Scripts/modules/mock.py: Added.
- Scripts/modules/mock_bugzillatool.py:
Nov 26, 2009:
- 11:56 PM Changeset in webkit [51435] by
-
- 4 edits1 add in trunk/WebKitTools
2009-11-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904
Step 5: Kill run_and_throw_if_fail.
- Scripts/modules/buildsteps.py:
- Scripts/modules/processutils.py: Added.
- Scripts/modules/webkitlandingscripts.py:
- 11:56 PM Changeset in webkit [51434] by
-
- 4 edits in trunk/WebKitTools
2009-11-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904
Step 4: Kill run_webkit_script.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/webkitlandingscripts.py:
- 11:55 PM Changeset in webkit [51433] by
-
- 4 edits in trunk/WebKitTools
2009-11-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904
Step 3: Kill build_webkit.
- Scripts/modules/buildsteps.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/webkitlandingscripts.py:
- 11:55 PM Changeset in webkit [51432] by
-
- 5 edits in trunk/WebKitTools
2009-11-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904
Step 2: Kill ensure_builders_are_green.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/webkitlandingscripts.py:
- 11:54 PM Changeset in webkit [51431] by
-
- 5 edits1 add in trunk/WebKitTools
2009-11-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904
Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
- Scripts/bugzilla-tool:
- Scripts/modules/buildsteps.py: Added.
- Scripts/modules/commands/download.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/webkitlandingscripts.py:
- 11:51 PM Changeset in webkit [51430] by
-
- 3 edits in trunk/LayoutTests
2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed red bot fix.
Skip tests introduced by the previous change as it seems to be failing.
- platform/qt/Skipped:
- platform/win/Skipped:
- 10:11 PM Changeset in webkit [51429] by
-
- 4 edits2 adds in trunk
2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=29966
A test case where a user drags the mouse from an empty inline
element to above texts.
- editing/selection/last-empty-inline-expected.txt: Added.
- editing/selection/last-empty-inline.html: Added.
- platform/win/Skipped:
2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=29966
When an empty inline element is clicked, the root inline box has
no leaf children. Use the renderer of a normal child instead.
This change resolves Windows port's assertion failure in a layout test.
Also, this fixes the behavior when a user drags the mouse from an
empty inline element to above texts.
Test: editing/selection/last-empty-inline.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPointWithInlineChildren):
- 9:59 PM Changeset in webkit [51428] by
-
- 3 edits in trunk/WebCore
2009-11-26 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Ignore line-height CSS property specified to push buttons on
Windows and Linux.
https://bugs.webkit.org/show_bug.cgi?id=31712
LayoutTests/fast/forms/control-restrict-line-height.html checks that the
following controls should ignore line-height CSS property.
- <select>
- <input type=button>
- <input type=search>
This change addresses the <input type=button> issue with Chromium/Windows
and Chromium/Linux.
- rendering/RenderThemeChromiumSkia.cpp: Implement adjustButtonStyle() to ignore line-height.
- rendering/RenderThemeChromiumSkia.h: Declare adjustButtonStyle().
- 9:53 PM Changeset in webkit [51427] by
-
- 2 edits2 adds4 deletes in trunk/LayoutTests
2009-11-26 Kinuko Yasuda <kinuko@chromium.com>
Reviewed by Eric Seidel.
Rewrite the test fast/parser/comment-in-textarea to use dumpAsText
so that the expected results can be independent of platform differences.
https://bugs.webkit.org/show_bug.cgi?id=31580
- fast/parser/comment-in-textarea-expected.txt: Added.
- fast/parser/comment-in-textarea.html:
- fast/parser/script-tests/comment-in-textarea.js: Added.
- platform/mac/fast/parser/comment-in-textarea-expected.checksum: Removed.
- platform/mac/fast/parser/comment-in-textarea-expected.png: Removed.
- platform/mac/fast/parser/comment-in-textarea-expected.txt: Removed.
- platform/win/fast/parser/comment-in-textarea-expected.txt: Removed.
- 9:46 PM Changeset in webkit [51426] by
-
- 3 edits in trunk/WebCore
2009-11-26 Kinuko Yasuda <kinuko@chromium.com>
Reviewed by Eric Seidel.
Remove the special charset meta tag in the clipboard so that
copy-and-paste with interchange breaklines/spaces works correctly
within WebKit.
No new tests. Layout tests that involve copy-and-paste with
interchange breaklines (like editing/pasteboard/paste-line-endings-00?)
should pass on Mac/Chromium with this fix.
- platform/chromium/ClipboardChromium.cpp:
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::documentFragment):
- 9:33 PM Changeset in webkit [51425] by
-
- 2 edits in trunk/WebCore
2009-11-26 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Eric Seidel.
Compile with QT_NO_WHEELEVENT defined.
- platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::applyDelta):
- 9:20 PM Changeset in webkit [51424] by
-
- 2 edits in trunk/JavaScriptCore
Incorrect behaviour of jneq_null in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=31901
Reviewed by Gavin Barraclough.
Correct the logic of jneq_null. This is already covered by existing tests.
- 8:06 PM Changeset in webkit [51423] by
-
- 15 edits2 moves in trunk
2009-11-26 Laszlo Gombos <Laszlo Gombos>
Reviewed by Oliver Hunt.
Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793
- GNUmakefile.am: Change the path for GOwnPtr.*.
- JavaScriptCore.gyp/JavaScriptCore.gyp: Remove GOwnPtr.cpp from the exclude list.
- JavaScriptCore.gypi: Change the path for GOwnPtr.*.
- wscript: Remove GOwnPtr.cpp from the exclude list.
- wtf/GOwnPtr.cpp: Removed.
- wtf/GOwnPtr.h: Removed.
- wtf/Threading.h: Change the path for GOwnPtr.h.
- wtf/gtk/GOwnPtr.cpp: Copied from JavaScriptCore/wtf/GOwnPtr.cpp.
- wtf/gtk/GOwnPtr.h: Copied from JavaScriptCore/wtf/GOwnPtr.h.
- wtf/unicode/glib/UnicodeGLib.h: Change the path for GOwnPtr.h.
2009-11-26 Laszlo Gombos <Laszlo Gombos>
Reviewed by Oliver Hunt.
Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793
- webkit/webkitwebview.cpp: Change the path for GOwnPtr.h.
2009-11-26 Laszlo Gombos <Laszlo Gombos>
Reviewed by Oliver Hunt.
Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793
No new tests as there is no functional change.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Change the path for GOwnPtr.h.
- platform/text/TextEncoding.cpp: Ditto.
- platform/text/gtk/TextCodecGtk.cpp: Ditto.
2009-11-26 Laszlo Gombos <Laszlo Gombos>
Reviewed by Oliver Hunt.
Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793
- GNUmakefile.am: Add JavaScriptCore/wtf/gtk to the include path.
- 1:22 PM Changeset in webkit [51422] by
-
- 10 edits in trunk
2009-11-26 Yury Semikhatsky <yurys@chromium.org>
Not reviewed. Build fix: revert r51421.
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::addLength):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
2009-11-26 Yury Semikhatsky <yurys@chromium.org>
Not reviewed. Build fix: revert r51421.
- public/WebDevToolsAgent.h:
- public/WebView.h:
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
- 12:59 PM Changeset in webkit [51421] by
-
- 10 edits in trunk
2009-11-26 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
This is a WebCore part of the fix that allows to view plugin
resources loaded by plugins.
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h: Remove unused DocumentLoader parameters from inspector methods.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::addLength): Update loading end time when new data are received.
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFailToLoad): Notify InspectorController about the failure. (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
2009-11-26 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
WebCore part of the fix that allows to view plugin
resources loaded by plugins. Methods that for resource
loading notifications are exposed through WebDevToolsAgent
interface to the glue code to allow Chromium's plugin
implementation to notify InspectorController about resource
loading in plugins.
- public/WebDevToolsAgent.h:
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
- src/WebViewImpl.h:
- 12:27 PM Changeset in webkit [51420] by
-
- 5 edits2 adds in trunk
2009-11-26 Daniel Bates <dbates@webkit.org>
Reviewed by Pavel Feldman.
Tests that the tooltip text for an image is its dimensions.
- inspector/elements-img-tooltip-expected.txt: Added.
- inspector/elements-img-tooltip.html: Added.
2009-11-26 Daniel Bates <dbates@webkit.org>
Reviewed by Pavel Feldman.
Implements support for hovering over <img> src to display the height and width of that image
in a tooltip. Displays both the displayable and natural dimensions of the image.
Test: inspector/elements-img-tooltip.html
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode): Added. (WebInspector.ElementsTreeElement.prototype._updateTitle.callback): (WebInspector.ElementsTreeElement.prototype._updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
- inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy.getPropertiesAsync): Added.
- inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode): Added tooltipText argument. (WebInspector.linkifyURL): Ditto.
- 10:06 AM Changeset in webkit [51419] by
-
- 2 edits in trunk/WebCore
wx build fix after drawPattern API change.
- 8:50 AM Changeset in webkit [51418] by
-
- 8 adds in trunk/LayoutTests/fast/canvas/webgl
Missed checking in these files from https://bugs.webkit.org/show_bug.cgi?id=30091
- 8:50 AM Changeset in webkit [51417] by
-
- 2 edits in trunk/WebKitTools
2009-11-26 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Adam Barth.
Remove directory prefixes from linux commands
SCM unittests can cause errors on some systems if we use absolute reference to
the commands, so directory prefixes have been removed.
- Scripts/modules/scm_unittest.py:
- 7:59 AM Changeset in webkit [51416] by
-
- 7 edits in trunk/WebCore
2009-11-26 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Use an internal field instead of hidden property to speedup lookup
of entered isolated world.
Plus some inlinings.
https://bugs.webkit.org/show_bug.cgi?id=31884
Covered by layout tests + manual running of some benchmarks as
content scripts.
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::setDOMWrapper):
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
- bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::getEntered): (WebCore::V8IsolatedWorld::getGlobalObject):
- bindings/v8/custom/V8CustomBinding.h:
- 7:06 AM Changeset in webkit [51415] by
-
- 1 edit3 deletes in trunk/WebKit/qt
Rubber-stamped by Holger Freyther.
Removed unused ICO image plugin handler.
- Plugins/ICOHandler.cpp: Removed.
- Plugins/ICOHandler.h: Removed.
- Plugins/Plugins.pro: Removed.
- 6:34 AM Changeset in webkit [51414] by
-
- 2 edits1 move in trunk/WebCore
2009-11-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Corrects build break on Windows.
Rename platform/text/qt/TextBoundaries.cpp to TextBoundariesQt.cpp since
platform/text/TextBoundaries.cpp was compiled instead when compiling with nmake.
- WebCore.pro:
- platform/text/qt/TextBoundariesQt.cpp: Renamed from WebCore/platform/text/qt/TextBoundaries.cpp. (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):
- 5:20 AM Changeset in webkit [51413] by
-
- 2 edits in trunk/WebCore
2009-11-26 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Do not check if the thread is main or not when accessing DOMDataStore as currently in Chromium WebKit is used in main thread only.
https://bugs.webkit.org/show_bug.cgi?id=31877
Covered by layout tests and buildbots.
- bindings/v8/V8DOMMap.cpp: (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap):
- 5:04 AM Changeset in webkit [51412] by
-
- 2 edits in trunk/WebCore
[Qt] Mac Plugins : Pass mouse position relative to the fake window
Reviewed by Holger Freyther.
When using off-screen rendering, we need to pass mouse events relative
to the fake window instead of the global position.
- 4:44 AM QtWebKitMirrorGuide edited by
- Mention the Math.random() problem with the test content. (diff)
- 4:33 AM QtWebKitPerformanceToolBackLog: edited by
- (diff)
- 4:31 AM QtWebKitPerformanceToolBackLog: edited by
- (diff)
- 4:26 AM QtWebKitPerformanceToolBackLog: edited by
- Fix the marking of completed items. (diff)
- 4:23 AM QtBackLog edited by
- Put the commits and date into the right column (diff)
- 4:21 AM QtBackLog edited by
- Mention the network change, and the issue that QtWebKit is using less … (diff)
- 4:18 AM QtBackLog edited by
- Complete the QtPlugin work (diff)
- 3:16 AM Changeset in webkit [51411] by
-
- 2 edits in trunk/WebCore
[Qt] Use QNetworkReply::rawHeaderPairs
https://bugs.webkit.org/show_bug.cgi?id=31826
The QNetworkReply is internally storing the HTTP headers
as a list of pairs. Currently we have to ask the QNetworkReply
to put all header names into a QStringList. Afterwards we will
iterate over this QStringList and ask the QNetworkReply to
give us the value for this header name. The current Qt implementation
is doing a linear to find the header value.
Use a new API to directly access the list of pairs and push
this into WebCore. This avoids doing some allocations and doing
linear searches from within a loop.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 2:34 AM Changeset in webkit [51410] by
-
- 11 edits2 adds in trunk
[Qt] Add automatic test case for plugins that use QWidget
https://bugs.webkit.org/show_bug.cgi?id=31203
Change the RenderTreeAsText to look into the WebCore::Widget
and print the state of the platformWidget. Change the DRT to
use QtUiTools to be able to initiate QProgressBar and such
as a plugin. Add the test case, add the result, update the
other results due the new test.
WebCore:
- rendering/RenderTreeAsText.cpp:
(WebCore::operator<<): Add special case for RenderPart
WebKitTools:
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::createPlugin):
- DumpRenderTree/qt/DumpRenderTree.h:
- DumpRenderTree/qt/DumpRenderTree.pro:
LayoutTest:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/plugins/netscape-dom-access-expected.txt: Added
- platform/qt/plugins/qt-qwidget-plugin-expected.txt: Added
- platform/win/Skipped:
- plugins/qt-qwidget-plugin.html: Added.
- 2:31 AM Changeset in webkit [51409] by
-
- 6 edits in trunk
[Qt] Call Widget::setSelfVisible from hide/show
https://bugs.webkit.org/show_bug.cgi?id=31203
Call Widget::setSelfVisible from Widget::show and
Widget::hide and use isParentVisible to decide
if the widget should be shown. This way client
code can rely on isVisible.
Change PluginViewQt::show, PluginViewQt::hide to
call the base class as it is doing the right thing
now. Add an assert verify that platfomWidget and
platformPluginWidget are the same.
- manual-tests/qt/qtplugin.html: Modify manual test
- platform/qt/WidgetQt.cpp:
(WebCore::Widget::show):
(WebCore::Widget::hide):
[Qt] Do not show the QWidget when the WebCore::Widget is hidden
https://bugs.webkit.org/show_bug.cgi?id=31203
The clipping code was making a QWidget visible even if the
WebCore::Widget was hidden. Fix the bug by calling setVisible
only if the WebCore::Widget Widget::isSelfVisible.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::QtPluginWidget::show): Override WebCore::Widget::show to call handleVisibility
(WebCore::QtPluginWidget::handleVisibility): New method to call setVisible when we are visible
(FrameLoaderClientQt::createPlugin): Hide the QWidget by default
- 2:31 AM Changeset in webkit [51408] by
-
- 2 edits in trunk/WebCore
Fix compilation of REQUEST_DEBUG debug code
https://bugs.webkit.org/show_bug.cgi?id=31850
In r47907 the single parameter KURL constructor to parse
from a WebCore::String was replaced with a two parameter
constructor. I think in this debug case parsing the urls
again is no problem and I have changed the code to use the
two parameter version.
- loader/loader.cpp:
(WebCore::Loader::Host::didFinishLoading):
- 12:43 AM Changeset in webkit [51407] by
-
- 3 edits in trunk/WebCore
2009-11-26 Søren Gjesse <sgjesse@chromium.org>
Reviewed by Pavel Feldman.
[V8] Avoid using JavaScript objects as context data
https://bugs.webkit.org/show_bug.cgi?id=31873
Change the context "data" from a JavaScript object holding the two properties type and value to
a string holding type and value separated by a comma.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::setContextDebugId): (WebCore::V8Proxy::contextDebugId):
