Context Navigation

compositing/layers-inside-overflow-scroll.html:
compositing/self-painting-layers.html: Use the 'loadeddata' event, instead of 'load', to know when the video loads.

platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
platform/mac/compositing/repaint/content-into-overflow-expected.png:
platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
platform/mac/compositing/repaint/overflow-into-content-expected.png:
platform/mac/compositing/self-painting-layers-expected.checksum:
platform/mac/compositing/self-painting-layers-expected.png: Update with correct pixel results.

7:26 PM Changeset in webkit [51477] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-11-29 Eric Seidel <eric@webkit.org>

No review, just adding missing svn property.

Set svn:executable property on new scripts.
These were added by commit-queue commits, but the executable
property was lost due to a bug in svn-apply:
https://bugs.webkit.org/show_bug.cgi?id=27204

Scripts/update-webkit-chromium: Added property svn:executable.
Scripts/validate-committer-lists: Added property svn:executable.

7:21 PM Changeset in webkit [51476] by Simon Fraser

10 edits in trunk/WebCore

2009-11-29 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Optimize the hierarchy rebuilding of compositing layers
https://bugs.webkit.org/show_bug.cgi?id=31879

When updating the compositing layer hierarchy, instead of removing all
child layers and then re-adding them one by one, build a vector of child
layers, and set them in one go.

platform/graphics/GraphicsLayer.h:
platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setChildren): New method that takes a Vector of child GraphicsLayers.

platform/graphics/mac/GraphicsLayerCA.h: Override setChildren().
platform/graphics/win/GraphicsLayerCACF.h: Ditto.
platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setChildren): Implement setChildren() to set the bit that notes that sublayers changed.
platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::setChildren): Implement setChildren() to udpate sublayers, with a note that this is not efficient.

rendering/RenderLayerCompositor.h:
rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): When updating compositing layers, use the faster updateLayerTreeGeometry() if we know that no layer hierarchy changes are needed, and, at the root, use the vector returned from rebuildCompositingLayerTree() to attach the root layer. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Changed to collect child layers into Vectors of GraphicsLayers, which can be set as layer children in one go. (WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Split out from rebuildCompositingLayerTree() for simplicity, and called when we just need to update layer geometry, without doing any reparenting.

7:12 PM Changeset in webkit [51475] by eric@webkit.org

1 edit
1 add in trunk/WebKitTools

2009-11-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Need a way to validate that committers.py includes all committers/reviewers
https://bugs.webkit.org/show_bug.cgi?id=30970

Add a script which knows how to compare our public committer/reviewer
lists and show discrepancies between them.

Validates mailing lists vs. committers.py:

committers.py committers missing from webkit-committers@lists
webkit-committers@lists members missing from committers.py
committers.py reviewers missing from webkit-reviewers@lists
webkit-reviewers@lists members missing from committers.py
webkit-reviewers@lists members missing from committers.py reviewer list

Validates committers.py vs. trunk/ SVN history:

committers who have not committed in over a year
SVN committers missing from committers.py
committers.py members who have no record in SVN.

All of these lists still show "false positives" until a few more committers.py updates are made, like:
https://bugs.webkit.org/show_bug.cgi?id=31366

Scripts/validate-committer-lists: Added.

7:10 PM Changeset in webkit [51474] by dbates@webkit.org

2 edits in trunk/WebCore

2009-11-29 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31971

Updated comment to reflect latest XSSAuditor bindings.

No functionality was changed. So, no new tests.

page/XSSAuditor.h:

6:45 PM Changeset in webkit [51473] by dbates@webkit.org

12 edits in trunk/WebCore

2009-11-29 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31969

Removes unnecessary #include files.

No functionality was changed. So, no new tests.

css/CSSComputedStyleDeclaration.cpp: Removed include CachedImage.h, and Pair.h
css/CSSCursorImageValue.cpp: Removed include RenderStyle.h
css/CSSFontFaceSrcValue.cpp: Removed include Node.h
css/CSSFontSelector.cpp: Removed include NodeList.h
css/CSSGradientValue.cpp: Removed include GraphicsContext.h, ImageBuffer.h
css/CSSImageValue.cpp: Removed include RenderStyle.h
css/CSSImportRule.cpp: Removed include MediaList.h
css/CSSMutableStyleDeclaration.cpp: Removed include CSSProperty.h
css/CSSRule.cpp: Removed include CSSStyleSheet.h
css/CSSStyleSelector.cpp: Removed include CSSFontFace.h, CSSFontFaceSource.h, and CSSProperty.h
page/EventSource.h: Removed include EventListener.h

5:32 PM Changeset in webkit [51472] by dbates@webkit.org

4 edits in trunk/WebCore

2009-11-29 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31965

Removed #include KeyframeList.h from CSSStyleSelector.h. Instead,
forward declared it.

As a side effect, we need to #include KeyframeList.h in
RenderLayerBacking.cpp.

No functionality was changed. So, no new tests.

css/CSSStyleSelector.cpp:
css/CSSStyleSelector.h: Removed #include KeyframeList.h
rendering/RenderLayerBacking.cpp: Added #include KeyframeList.h

5:02 PM Changeset in webkit [51471] by eric@webkit.org

3 edits
2 adds in trunk

2009-11-29 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Test using Id as index of node list.
https://bugs.webkit.org/show_bug.cgi?id=31428

fast/dom/Element/id-in-node-list-index01-expected.txt: Added.
fast/dom/Element/id-in-node-list-index01.html: Added.

2009-11-29 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Continue to search for matching node in the case where multiple nodes
have the same id.
https://bugs.webkit.org/show_bug.cgi?id=31428

Test: fast/dom/Element/id-in-node-list-index01.html

dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):

4:50 PM Changeset in webkit [51470] by dbates@webkit.org

3 edits in trunk/WebCore

2009-11-29 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31966

Removed #include RenderStyle.h from file KeyframeAnimation.h. Instead,
forward declared it.

No functionality was changed. So, no new tests.

page/animation/KeyframeAnimation.cpp:
page/animation/KeyframeAnimation.h:

4:06 PM Changeset in webkit [51469] by dbates@webkit.org

1 edit in trunk/WebCore/ChangeLog

2009-11-29 Daniel Bates <dbates@webkit.org>

Unreviewed, fix change log entry date.

For some reason, bugzilla-tool did not update the date in the change
log entry for my last commit (r51468). So, this commit fixes the date
of that entry.

3:55 PM Changeset in webkit [51468] by dbates@webkit.org

2 edits in trunk/WebCore

2009-11-28 Daniel Bates <dbates@webkit.org>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=31964

Removed #include StringImpl, StyleImage. Instead, forward declared them.
Also, we can substitute #include <wtf/PassRefPtr.h> for #include PlatformString.h,
since it seems we only really used it to include PassRefPtr.h.

No functionality was changed. So, no new tests.

rendering/style/ContentData.h:

12:11 PM Changeset in webkit [51467] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-11-29 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Mac build has JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=31828

wtf/Platform.h: Enable JIT for Qt Mac builds

7:57 AM Changeset in webkit [51466] by eric@webkit.org

11 edits in trunk/WebCore

2009-11-29 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for classes of the rendering and storage directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31906

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

class SQLTransactionClient - storage/DatabaseThread.cpp:45
class SQLTransactionCoordinator - storage/DatabaseThread.cpp:46
class OriginUsageRecord - storage/OriginQuotaManager.cpp:66
class DatabaseTracker - storage/DatabaseTracker.cpp:62
class ScrollbarTheme - (its child class) rendering/RenderScrollbarTheme.cpp:35
class RenderSelectionInfoBase - (its child class) rendering/RenderView.cpp:310
class RenderOverflow - rendering/RenderBox.cpp:2846

Inherits the following classes from FastAllocBase because these are instantiated by 'new':

struct FillLayer - css/CSSStyleSelector.cpp:197
struct ShadowData - rendering/style/ShadowData.cpp:35
class CounterContent - css/CSSStyleSelector.cpp:4111

platform/ScrollbarTheme.h:
rendering/RenderOverflow.h:
rendering/RenderSelectionInfo.h:
rendering/style/CounterContent.h:
rendering/style/FillLayer.h:
rendering/style/ShadowData.h:
storage/DatabaseTracker.h:
storage/OriginUsageRecord.h:
storage/SQLTransactionClient.h:
storage/SQLTransactionCoordinator.h:

Nov 28, 2009:

10:36 PM QtWebKitBackportingFixes edited by Laszlo Gombos

(diff)

10:31 PM QtWebKitBackportingFixes edited by Laszlo Gombos

(diff)

5:53 PM Changeset in webkit [51465] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-11-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
https://bugs.webkit.org/show_bug.cgi?id=31950

Now we cache the last status that we get back from QueueStatusServer.
Eventually we'll have to do something more fancy if we want to support
a "try again" button on QueueStatusServer, but we can cross that bridge
when we come to it.

Scripts/modules/patchcollection.py:

5:50 PM Changeset in webkit [51464] by abarth@webkit.org

8 edits in trunk/WebKitTools

2009-11-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

StyleQueue scans ~100 bug pages every 5 minutes
https://bugs.webkit.org/show_bug.cgi?id=31947

Instead of getting the pending-review attachment ids by scanning each
bug (which results in a network request), we should just get them all
from webkit.org/pending-review in one shot.

Scripts/modules/bugzilla.py:
Scripts/modules/bugzilla_unittest.py:
Scripts/modules/commands/queries.py:
Scripts/modules/commands/queries_unittest.py:
Scripts/modules/commands/queues.py:
Scripts/modules/mock_bugzillatool.py:
Scripts/modules/patchcollection.py:

4:20 PM Changeset in webkit [51463] by abarth@webkit.org

3 edits in trunk/WebKitTools

2009-11-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] CC webkit-bot-watchers whenever the bots touch bugs
https://bugs.webkit.org/show_bug.cgi?id=31952

The mailing list is open for anyone to subscribe.

Scripts/modules/bugzilla.py:
Scripts/modules/commands/queues.py:

4:17 PM Changeset in webkit [51462] by abarth@webkit.org

3 edits in trunk/WebKitTools

2009-11-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] style-queue should report style errors to bugzilla
https://bugs.webkit.org/show_bug.cgi?id=31945

Currently, we're just logging the style errors locally. With this
patch we'll actually log the errors to bugzilla. Note: I plan to run
with the "local-only" logging during development.

Scripts/modules/commands/queues.py:
Scripts/modules/scm.py:

1:48 PM Changeset in webkit [51461] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-11-28 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Apply workaround for the limitation of VirtualFree with MEM_RELEASE to all ports running on Windows
https://bugs.webkit.org/show_bug.cgi?id=31943

runtime/MarkStack.h: (JSC::MarkStack::MarkStackArray::shrinkAllocation):

10:27 AM Changeset in webkit [51460] by abarth@webkit.org

4 edits in trunk/WebKitTools

2009-11-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] style-queue shouldn't reject patches from the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31944

Currently the style-queue subprocess gets confused and thinks its the
commit-queue. If the patch has an error, it rejects it from the
commit-queue. Instead, we should have style-queue specific logic.
This patch doesn't add that logic, but it gives us a callback we can
use to add that logic.