⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 30, 2009:

11:37 PM Changeset in webkit [51527] by hamaji@chromium.org
  • 24 edits
    2 adds in trunk

2009-11-30 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Dan Bernstein.

css2.1/t1205-c566-list-stl-00-e-ag.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=23264
css2.1/t1205-c565-list-pos-00-b.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=23263

Ignore whitespaces after list markers.
Rendering of this was already done for the case where inside=false.
This fixes the rendering of inside=true case and calcInlinePrefWidths.

Test: fast/lists/calc-width-with-space.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):

2009-11-30 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Dan Bernstein.

css2.1/t1205-c566-list-stl-00-e-ag.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=23264

  • editing/pasteboard/copy-crash-expected.txt:
  • fast/lists/calc-width-with-space-expected.txt: Added.
  • fast/lists/calc-width-with-space.html: Added.
  • platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.checksum:
  • platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.png:
  • platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.checksum:
  • platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.png:
  • platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.checksum:
  • platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.png:
  • platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum:
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.png:
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.txt:
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum:
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png:
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt:
  • platform/mac/fast/repaint/list-marker-expected.checksum:
  • platform/mac/fast/repaint/list-marker-expected.png:
  • platform/mac/fast/repaint/list-marker-expected.txt:
  • platform/qt/Skipped:
11:25 PM Changeset in webkit [51526] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

check-webkit-style is slightly too verbose
​https://bugs.webkit.org/show_bug.cgi?id=32010

check-webkit-style prints out a bunch of "done" lines that seem redundant,
especially for the style-queue.

  • Scripts/modules/cpp_style.py:
10:41 PM Changeset in webkit [51525] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-30 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Eric Seidel.

[GTK] Moved the functions that are closing the result log of the
tests to the last line of the runTest function, this avoids
reporting crashes in the wrong test if there is a problem when
reseting the state after the test.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest):
7:33 PM Changeset in webkit [51524] by ukai@chromium.org
  • 5 edits in trunk/WebCore

2009-11-30 Fumitoshi Ukai <​ukai@chromium.org>

Unreviewed Chromium build fix introduced by r51212

Fix scriptStateFromNode and ScriptStateFromPage to take DOMWrapperWorld
as the first argument.
Move mainThreadNormalWorld() to ScriptState.{h,cpp}.
Add debuggerWorld() and pluginWorld() in ScriptState.h.

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromNode): (WebCore::scriptStateFromPage): (WebCore::mainThreadNormalWorld):
  • bindings/v8/ScriptState.h: (WebCore::debuggerWorld): (WebCore::pluginWorld):
5:18 PM Changeset in webkit [51523] by weinig@apple.com
  • 5 edits in trunk/WebKitTools

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=31286
fast/js/date-proto-generic-invocation breaks another test

Reviewed by Geoffrey Garen.

Don't cache JSClassRefs, a change to the prototype chain will
last between tests.

  • DumpRenderTree/AccessibilityController.cpp:

(AccessibilityController::getJSClass):

  • DumpRenderTree/GCController.cpp:

(GCController::getJSClass):

  • DumpRenderTree/GCController.h:
  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::getJSClass):

4:44 PM Changeset in webkit [51522] by enrica@apple.com
  • 15 edits
    2 adds in trunk

WebCore: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
​https://bugs.webkit.org/show_bug.cgi?id=31750

Reviewed by Darin Adler.

The goal is to change the way we choose a visible position
after hit detection, by preferring a visually equivalent editable
position if available. By doing this, it is possible to add content
to an editable block that initially contains only non editable elements.

Test: editing/selection/mixed-editability-10.html

  • WebCore.base.exp: Changed to match the new signature of downstream

and upstream in the Position class.

  • dom/Position.cpp:

(WebCore::Position::atEditingBoundary): Added.
(WebCore::Position::upstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::downstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
(WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box
to be used in calculating the caret rectangle.

  • dom/Position.h:

(WebCore::Position::):

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::atEditingBoundary): Added.
(WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.

  • dom/PositionIterator.h:
  • editing/htmlediting.cpp:

(WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
(WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position,
if available.

  • rendering/RenderText.cpp:

(WebCore::RenderText::isAllCollapsibleWhitespace): Added.

  • rendering/RenderText.h:

LayoutTests: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
​https://bugs.webkit.org/show_bug.cgi?id=31750

Reviewed by Darin Adler.

  • editing/selection/5825350-1-expected.txt:
  • editing/selection/5825350-1.html: Modified to use caret rectangle.
  • editing/selection/5825350-2-expected.txt:
  • editing/selection/5825350-2.html: Modified to use caret rectangle.
  • editing/selection/mixed-editability-10-expected.txt: Added.
  • editing/selection/mixed-editability-10.html: Added.
  • platform/mac/editing/deleting/5390681-2-expected.txt: Re-baselined

to account for the new possible caret position.

4:40 PM Changeset in webkit [51521] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-11-30 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Update pywebsocket to 0.4.2.1.
This is to fix a bug that some messages are logged to stderr even when the log file is specified.
​https://bugs.webkit.org/show_bug.cgi?id=31976

  • pywebsocket/mod_pywebsocket/standalone.py:
  • pywebsocket/setup.py:
4:12 PM Changeset in webkit [51520] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix, add header needed for wx build.

4:08 PM Changeset in webkit [51519] by mrowe@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from a machine that cannot run x86_64 binaries

Reviewed by David Kilzer.

The check for whether WTF_USE_PLUGIN_HOST_PROCESS is defined occurs under the native architecture of the build machine.
If that is 32-bit then WTF_USE_PLUGIN_HOST_PROCESS will not be defined. We work around this by forcing the check to
be performed against the x86_64 architecture.

  • DerivedSources.make:
4:07 PM Changeset in webkit [51518] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-11-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Generate pass messages for style-queue
​https://bugs.webkit.org/show_bug.cgi?id=31995

With this change, the style-queue posts "pass" messages to bugs as
well. Also, added more information to the state store w.r.t. passing
and failing.

  • Scripts/modules/commands/queues.py:
  • Scripts/modules/patchcollection.py:
3:55 PM Changeset in webkit [51517] by Beth Dakin
  • 3 edits
    2 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
Safari caused by extreme column-gap and column-width values
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

Prevent desiredColumnCount from being less than 1 since it is used
as a divisor.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::calcColumnWidth):

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
Safari caused by extreme column-gap and column-width values
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

  • fast/multicol/huge-column-gap-crash-expected.txt: Added.
  • fast/multicol/huge-column-gap-crash.html: Added.
3:48 PM Changeset in webkit [51516] by ap@apple.com
  • 4 edits in trunk

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=31659
Connection must be closed in case of Web Socket handshake error

The network connection was closed, but the close event wasn't dispatched.

Tested by websocket/tests/handshake-error.html, which is un-skipped now.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose): Call client didHandle() method. This looks strange in CFNetwork implementation, because it's the client that asked to close the stream, so it shouldn't need the callback. It makes more sense in cross-process implementation, because closing is async there.
3:45 PM UsingGitWithWebKit edited by eric@webkit.org
(diff)
3:20 PM Changeset in webkit [51515] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-11-30 Abhinav Mithal <​abhinav.mithal@nokia.com>

Reviewed by Simon Hausmann.

[Qt][Symbian] Report SymbianOS in user agent string for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=31961

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
2:10 PM Changeset in webkit [51514] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows Build fix. Reviewed by NOBODY.

2:02 PM Changeset in webkit [51513] by mrowe@apple.com
  • 2 edits in trunk/WebKit

Use the correct path to Info.plist to avoid creating an empty file at the top of the WebKit directory.

  • WebKit.xcodeproj/project.pbxproj:
1:48 PM Changeset in webkit [51512] by barraclough@apple.com
  • 36 edits in trunk

Bug 31859 - Make world selection for JSC IsolatedWorlds automagical.

Reviewed by Geoff Garen.

JavaScriptCore:

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Remove the temporary duct tape of willExecute/didExecute virtual hooks on the JSGlobalData::ClientData - these are no longer necessary.

  • API/JSBase.cpp:

(JSEvaluateScript):

  • API/JSObjectRef.cpp:

(JSObjectCallAsFunction):

  • JavaScriptCore.exp:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:

WebCore:

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Remove the last uses of mainThreadCurrentWorld(), so the world is always obtained via
currentWorld(). Switch this to obtain the world from the ExecsState's lexical global
object instead. Remove the call/construct/evaluate 'InWorld' methods, since these
are no longer necessary.

  • WebCore.base.exp:
  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCallbackData.h:

(WebCore::JSCallbackData::JSCallbackData):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::currentWorld):
(WebCore::mainThreadNormalWorld):

  • bindings/js/JSDOMBinding.h:

(WebCore::WebCoreJSClientData::WebCoreJSClientData):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::updateDocument):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::open):

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):

  • bindings/js/JSQuarantinedObjectWrapper.cpp:

(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::executeFunctionInContext):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):

  • bindings/js/ScriptObjectQuarantine.cpp:

(WebCore::getQuarantinedScriptObject):

  • bindings/js/ScriptState.cpp:

(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):

  • bindings/js/ScriptState.h:
  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):

  • bridge/NP_jsobject.cpp:

(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::call):
(JavaJSObject::eval):

  • dom/NodeFilter.h:

(WebCore::NodeFilter::acceptNode):

  • dom/NodeIterator.h:

(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):

  • dom/TreeWalker.h:

(WebCore::TreeWalker::parentNode):
(WebCore::TreeWalker::firstChild):
(WebCore::TreeWalker::lastChild):
(WebCore::TreeWalker::previousSibling):
(WebCore::TreeWalker::nextSibling):
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::didEvaluateForTestInFrontend):

  • inspector/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::evaluate):

WebKit/mac:

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Since WebCore no longer needs to explicitly specify the world on entry to JSC DebuggerCallFrame::evaluate can be called directly.

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame evaluateWebScript:]):

1:43 PM Changeset in webkit [51511] by eric.carlson@apple.com
  • 4 edits
    6 deletes in trunk

2009-11-30 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

All HTML5 media element events should be regular events
​https://bugs.webkit.org/show_bug.cgi?id=30513

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): (WebCore::HTMLMediaElement::noneSupported): (WebCore::HTMLMediaElement::mediaEngineError): (WebCore::HTMLMediaElement::setNetworkState): (WebCore::HTMLMediaElement::userCancelledLoad):

Call scheduleEvent instead of scheduleProgressEvent.

(WebCore::HTMLMediaElement::progressEventTimerFired):

Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement
after scheduling a 'progress' event so the controller will update download
progress indicator.

  • html/HTMLMediaElement.h:

Remove scheduleProgressEvent prototype.

2009-11-30 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

All HTML5 media element events should be regular events
​https://bugs.webkit.org/show_bug.cgi?id=30513


Remove progress event tests.

  • media/progress-event-at-least-one-expected.txt: Removed.
  • media/progress-event-at-least-one.html: Removed.
  • media/progress-event-expected.txt: Removed.
  • media/progress-event-total-expected.txt: Removed.
  • media/progress-event-total.html: Removed.
  • media/progress-event.html: Removed.
1:41 PM Changeset in webkit [51510] by Adam Roben
  • 4 edits in trunk/WebKit/win

Fix double-free of BSTRs passed to WebNavigationData::createInstance

WebFrameLoaderClient::updateGlobalHistory was converting
WebCore::Strings to WebCore::BStrings, then passing them to
WebNavigationData::createInstance. But the latter function takes BSTR
parameters and adopts them into WebCore::BStrings. So the end result
was that two WebCore::BStrings would end up freeing each underlying
BSTR.

The fix is to only convert to WebCore::BString inside
WebNavigationData.

Fixes <​http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
(r49564): Crash in updateGlobalHistory when running Javascript iBench
test

I couldn't find a way to reproduce this in DumpRenderTree.

Reviewed by Steve Falkenburg.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
WebNavigationData::createInstance.

  • WebNavigationData.cpp:

(WebNavigationData::WebNavigationData):
(WebNavigationData::createInstance):

  • WebNavigationData.h:

Changed to take const WebCore::String&s instead of BSTRs and to
convert the Strings to BStrings at this level.

1:38 PM Changeset in webkit [51509] by ap@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

It was me who reviewed the patch, not Eric! Alas, some tools we use cause wrong reviewer information in Bugzilla.

1:35 PM Changeset in webkit [51508] by ap@apple.com
  • 3 edits in trunk/LayoutTests

2009-11-30 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

In testing handshake-error case, web_socket_do_extra_handshake calls a non-existent method
​https://bugs.webkit.org/show_bug.cgi?id=31465

  • platform/mac/Skipped: websocket/tests/handshake-error.html now fails on Mac, added to Skipped list, and filed bug 31659 to investigate.
  • websocket/tests/handshake-error_wsh.py: Call write() on a correct object.
1:27 PM Changeset in webkit [51507] by Joseph Pecoraro
  • 1 delete in trunk/WebKit/Info.plist

Remove file git invisibly added

1:19 PM Changeset in webkit [51506] by Joseph Pecoraro
  • 9 edits
    1 add in trunk

2009-11-30 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Wrong console output for Regexp escape sequence
​https://bugs.webkit.org/show_bug.cgi?id=31538

Updated inspector/console-format.html

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createDividerElement): style issues. (WebInspector.ConsoleView.createFilterElement): style issues. (WebInspector.ConsoleView): added _customFormatters table. (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses. (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues. (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic. (WebInspector.ConsoleView.prototype._formatobject): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._printArray): (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts. (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting. (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting. (WebInspector.ConsoleCommandResult):
  • inspector/front-end/InjectedScript.js: simplified regex formatting.
  • inspector/front-end/inspector.js: (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
  • inspector/front-end/utilities.js: (Element.prototype.hasStyleClass): update inaccurate comment. (String.prototype.trimURL): converted new RegExp to literal for performance benefits.
12:42 PM Changeset in webkit [51505] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-11-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove obsolete PLATFORM(KDE) code
​https://bugs.webkit.org/show_bug.cgi?id=31958

KDE is now using unpatched QtWebKit.

  • parser/Lexer.cpp: Remove obsolete KDE_USE_FINAL guard
  • wtf/Platform.h: Remove PLATFORM(KDE) definition and code section that is guarded with it.
11:55 AM Changeset in webkit [51504] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping test that fails because of broken DND, and some tests
requiring new results.

  • platform/gtk/Skipped:
11:31 AM Changeset in webkit [51503] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.17

Tagging 1.1.17.

11:27 AM Changeset in webkit [51502] by kov@webkit.org
  • 2 edits in trunk

Rubber-stamped by Xan Lopez.

Make sure we distribute and install GObject Introspection files.

  • GNUmakefile.am:
10:59 AM Changeset in webkit [51501] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-30 Erik Arvidsson <​arv@chromium.org>

Reviewed by Adam Barth.

Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=31895

No new tests. This is already covered by:

fast/dom/CSSStyleDeclaration/css-computed-style-item.html
fast/dom/CSSStyleDeclaration/css-style-item.html

  • bindings/v8/V8Collection.h: (WebCore::collectionStringIndexedPropertyGetter): (WebCore::setCollectionStringIndexedGetter):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
10:50 AM Changeset in webkit [51500] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
​https://bugs.webkit.org/show_bug.cgi?id=31986

Reviewed by Adam Roben.

  • WebFrame.cpp:

(WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.

10:36 AM QtBackLog edited by zecke@selfish.org
The first set of network changes landed, mark the item as completed. (diff)
9:54 AM Changeset in webkit [51499] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Simon Fraser.

Check for WEBKIT_TESTFONTS environment variable in
run-webkit-tests, for GTK+, to have a more prominent error
message.

  • Scripts/run-webkit-tests:
9:41 AM Changeset in webkit [51498] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-30 Steve Block <​steveblock@google.com>

Reviewed by Eric Seidel.

Adds include of wtf/StdLibExtras.h for DEFINE_STATIC_LOCAL in V8 ScriptController.
​https://bugs.webkit.org/show_bug.cgi?id=31932

Build fix only, no new tests.

  • bindings/v8/ScriptController.cpp: Modified. Adds include of wtf/StdLibExtras.h.
9:34 AM Changeset in webkit [51497] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-30 Steve Block <​steveblock@google.com>

Reviewed by Eric Seidel.

Adds PassOwnPtr include to ScriptExecutionContext.h.
​https://bugs.webkit.org/show_bug.cgi?id=31929

Build fix only, no new tests.

  • dom/ScriptExecutionContext.h: Modified. Adds PassOwnPtr include.
9:25 AM Changeset in webkit [51496] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2009-11-30 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Complex test of mask with every combination of maskUnits and maskContentUnits
as well as different values for size and position of the mask and it's content.

  • platform/mac/svg/custom/mask-with-all-units-expected.checksum: Added.
  • platform/mac/svg/custom/mask-with-all-units-expected.png: Added.
  • platform/mac/svg/custom/mask-with-all-units-expected.txt: Added.
  • svg/custom/mask-with-all-units.svg: Added.

2009-11-30 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=31980

It turns out, that we did not handle maskUnits="userSpaceOnUse"
correctly. We just need to move the context of the maskImage
if maskContentUnits="objectBoundingBox". The context gets scaled
on this unit combination, so we have to substract the position of
the targetRect. On userSpaceOnUse the position just depends on the
position of the mask element.
I added a test with some senseless and reasonable values for size
and postion of the mask and it's contents. I also used every
combination of maskUnits and maskContentUnits to be sure, that it
is fixed this time.

Test: svg/custom/mask-with-all-units.svg

  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
9:17 AM Changeset in webkit [51495] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-30 Steve Block <​steveblock@google.com>

Reviewed by Eric Seidel.

Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
​https://bugs.webkit.org/show_bug.cgi?id=31928

Build fix only, no new tests.

  • page/DOMWindow.cpp: Modified. Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
9:10 AM Changeset in webkit [51494] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-30 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Dimitri Glazkov.

update-webkit --chromium forces gclient sync

​https://bugs.webkit.org/show_bug.cgi?id=31967

  • Scripts/update-webkit-chromium:
9:03 AM Changeset in webkit [51493] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-30 Steve Block <​steveblock@google.com>

Reviewed by Eric Seidel.

Adds SHARED_WORKERS guards to V8 WorkerContextExecutionProxy.
​https://bugs.webkit.org/show_bug.cgi?id=31926

Build fix only, no new tests.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::convertToV8Object): (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
8:56 AM Changeset in webkit [51492] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-30 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Chrome::contentsSizeChanged() is called when the content size has not changed
​https://bugs.webkit.org/show_bug.cgi?id=31978

Do not trigger contentsSizeChaned() is the new size is the same as the old one.

  • page/FrameView.cpp: (WebCore::FrameView::setContentsSize):
8:49 AM Changeset in webkit [51491] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-11-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix minor waning in QtWebKit
​https://bugs.webkit.org/show_bug.cgi?id=31963

  • tests/qwebpage/tst_qwebpage.cpp: (ErrorPage::extension): Remove info wariable as it is not used.
8:42 AM Changeset in webkit [51490] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-11-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix some compiler warnings seen on QtWebKit/Mac
​https://bugs.webkit.org/show_bug.cgi?id=31962

No new tests as there is no functional change.

  • platform/network/ResourceHandle.h: Make destructor virtual as after r50772 ResourceHandle has virtual functions.
  • plugins/mac/PluginPackageMac.cpp: (WebCore::PluginPackage::fetchInfo): Fix typo WTF is a namespace not a label
  • plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::setNPWindowIfNeeded): Add l to the format specifier
7:36 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:31 AM Changeset in webkit [51489] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

7:30 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:30 AM Changeset in webkit [51488] by mrowe@apple.com
  • 1 copy in tags/Safari-532.5

New tag.

7:13 AM Changeset in webkit [51487] by kov@webkit.org
  • 2 edits in trunk

Build fix. Make sure JSCore-1.0.gir is added to the distributed
tarball.

7:09 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:00 AM QtWebKitJournal edited by Simon Hausmann
(diff)
5:53 AM Changeset in webkit [51486] by xan@webkit.org
  • 9 edits in trunk

2009-11-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump versions for 1.1.17 release.

  • configure.ac:

WebCore:

2009-11-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add new headers to sources list.

  • GNUmakefile.am:

WebKit/gtk:

2009-11-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Prepare for 1.1.17 release.

  • NEWS:
  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
4:08 AM Changeset in webkit [51485] by Girish Ramakrishnan
  • 2 edits in trunk/WebCore

[Qt] Mac Plugins : Get context menu to work in QGraphicsView

Reviewed by Holger Freyther.

Flash expects the value in record.where to be the global position for
displaying the context menu.

​https://bugs.webkit.org/show_bug.cgi?id=31979

3:27 AM Changeset in webkit [51484] by Simon Hausmann
  • 4 edits in trunk

[Qt] Fix compilation with win32-icc

Patch by Jan-Arve Sæther <​jan-arve.saether@nokia.com> on 2009-11-30
Reviewed by Simon Hausmann.

.:

Include os-win32 for stdint.h since MS does not ship that in their PSDK.

  • WebKit.pri:

JavaScriptCore:

The Intel compiler does not support the has_trivial_constructor type
trait. The Intel Compiler can report itself as _MSC_VER >= 1400. The
reason for that is that the Intel Compiler depends on the Microsoft
Platform SDK, and in order to try to be "fully" MS compatible it will
"pretend" to be the same MS compiler as was shipped with the MS PSDK.
(Thus, compiling with win32-icc with VC8 SDK will make the source code
"think" the compiler at hand supports this type trait).

  • wtf/TypeTraits.h:
2:39 AM Changeset in webkit [51483] by steveblock@google.com
  • 2 edits in trunk/WebCore

Adds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController.
​https://bugs.webkit.org/show_bug.cgi?id=31925

Reviewed by Eric Seidel.

This code uses ChromiumBridge and Chromium-specific constant values not
appropriate for other platforms such as Android.

Build fix only, no new tests.

  • bindings/v8/V8GCController.cpp: Modified. Adds PLATFORM(CHROMIUM) around Chromium-specific code.
1:41 AM Changeset in webkit [51482] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Put tests into skiplist because of missing features.

  • platform/qt/Skipped:
  • fast/dom/Window/window-postmessage-clone.html added
  • inspector/elements-img-tooltip.html added.
12:58 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)

Nov 29, 2009:

8:50 PM Changeset in webkit [51481] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Build fix.

Correct draw signature used in ImageCairoWin.cpp.

  • platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

8:15 PM Changeset in webkit [51480] by oliver@apple.com
  • 6 edits in trunk

postMessage should serialize File objects
​https://bugs.webkit.org/show_bug.cgi?id=31955

Reviewed by Sam Weinig.

Update SerializedScriptValue to include support for
File objects in the serialized object graph.

7:54 PM Changeset in webkit [51479] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-29 Eric Seidel <​eric@webkit.org>

Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.

  • Scripts/modules/committers.py:
7:45 PM Changeset in webkit [51478] by Simon Fraser
  • 9 edits in trunk/LayoutTests

2009-11-29 Simon Fraser <Simon Fraser>

Rubber-stamped by Eric Seidel.

Fix up some compositing layout tests.

  • compositing/layers-inside-overflow-scroll.html:
  • compositing/self-painting-layers.html: Use the 'loadeddata' event, instead of 'load', to know when the video loads.
  • platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
  • platform/mac/compositing/repaint/content-into-overflow-expected.png:
  • platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
  • platform/mac/compositing/repaint/overflow-into-content-expected.png:
  • platform/mac/compositing/self-painting-layers-expected.checksum:
  • platform/mac/compositing/self-painting-layers-expected.png: Update with correct pixel results.
7:26 PM Changeset in webkit [51477] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-11-29 Eric Seidel <​eric@webkit.org>

No review, just adding missing svn property.

Set svn:executable property on new scripts.
These were added by commit-queue commits, but the executable
property was lost due to a bug in svn-apply:
​https://bugs.webkit.org/show_bug.cgi?id=27204

  • Scripts/update-webkit-chromium: Added property svn:executable.
  • Scripts/validate-committer-lists: Added property svn:executable.
7:21 PM Changeset in webkit [51476] by Simon Fraser
  • 10 edits in trunk/WebCore

2009-11-29 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Optimize the hierarchy rebuilding of compositing layers
​https://bugs.webkit.org/show_bug.cgi?id=31879

When updating the compositing layer hierarchy, instead of removing all
child layers and then re-adding them one by one, build a vector of child
layers, and set them in one go.

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setChildren): New method that takes a Vector of child GraphicsLayers.
  • platform/graphics/mac/GraphicsLayerCA.h: Override setChildren().
  • platform/graphics/win/GraphicsLayerCACF.h: Ditto.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setChildren): Implement setChildren() to set the bit that notes that sublayers changed.
  • platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::setChildren): Implement setChildren() to udpate sublayers, with a note that this is not efficient.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): When updating compositing layers, use the faster updateLayerTreeGeometry() if we know that no layer hierarchy changes are needed, and, at the root, use the vector returned from rebuildCompositingLayerTree() to attach the root layer. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Changed to collect child layers into Vectors of GraphicsLayers, which can be set as layer children in one go. (WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Split out from rebuildCompositingLayerTree() for simplicity, and called when we just need to update layer geometry, without doing any reparenting.
7:12 PM Changeset in webkit [51475] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-11-29 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Need a way to validate that committers.py includes all committers/reviewers
​https://bugs.webkit.org/show_bug.cgi?id=30970

Add a script which knows how to compare our public committer/reviewer
lists and show discrepancies between them.

Validates mailing lists vs. committers.py:

  • committers.py committers missing from webkit-committers@lists
  • webkit-committers@lists members missing from committers.py
  • committers.py reviewers missing from webkit-reviewers@lists
  • webkit-reviewers@lists members missing from committers.py
  • webkit-reviewers@lists members missing from committers.py reviewer list

Validates committers.py vs. trunk/ SVN history:

  • committers who have not committed in over a year
  • SVN committers missing from committers.py
  • committers.py members who have no record in SVN.

All of these lists still show "false positives" until a few more committers.py updates are made, like:
​https://bugs.webkit.org/show_bug.cgi?id=31366

  • Scripts/validate-committer-lists: Added.
7:10 PM Changeset in webkit [51474] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2009-11-29 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=31971

Updated comment to reflect latest XSSAuditor bindings.

No functionality was changed. So, no new tests.

  • page/XSSAuditor.h:
6:45 PM Changeset in webkit [51473] by dbates@webkit.org
  • 12 edits in trunk/WebCore

2009-11-29 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31969

Removes unnecessary #include files.

No functionality was changed. So, no new tests.

  • css/CSSComputedStyleDeclaration.cpp: Removed include CachedImage.h, and Pair.h
  • css/CSSCursorImageValue.cpp: Removed include RenderStyle.h
  • css/CSSFontFaceSrcValue.cpp: Removed include Node.h
  • css/CSSFontSelector.cpp: Removed include NodeList.h
  • css/CSSGradientValue.cpp: Removed include GraphicsContext.h, ImageBuffer.h
  • css/CSSImageValue.cpp: Removed include RenderStyle.h
  • css/CSSImportRule.cpp: Removed include MediaList.h
  • css/CSSMutableStyleDeclaration.cpp: Removed include CSSProperty.h
  • css/CSSRule.cpp: Removed include CSSStyleSheet.h
  • css/CSSStyleSelector.cpp: Removed include CSSFontFace.h, CSSFontFaceSource.h, and CSSProperty.h
  • page/EventSource.h: Removed include EventListener.h
5:32 PM Changeset in webkit [51472] by dbates@webkit.org
  • 4 edits in trunk/WebCore

2009-11-29 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31965

Removed #include KeyframeList.h from CSSStyleSelector.h. Instead,
forward declared it.

As a side effect, we need to #include KeyframeList.h in
RenderLayerBacking.cpp.

No functionality was changed. So, no new tests.

  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h: Removed #include KeyframeList.h
  • rendering/RenderLayerBacking.cpp: Added #include KeyframeList.h
5:02 PM Changeset in webkit [51471] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-11-29 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Test using Id as index of node list.
​https://bugs.webkit.org/show_bug.cgi?id=31428

  • fast/dom/Element/id-in-node-list-index01-expected.txt: Added.
  • fast/dom/Element/id-in-node-list-index01.html: Added.

2009-11-29 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Continue to search for matching node in the case where multiple nodes
have the same id.
​https://bugs.webkit.org/show_bug.cgi?id=31428

Test: fast/dom/Element/id-in-node-list-index01.html

  • dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
4:50 PM Changeset in webkit [51470] by dbates@webkit.org
  • 3 edits in trunk/WebCore

2009-11-29 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31966

Removed #include RenderStyle.h from file KeyframeAnimation.h. Instead,
forward declared it.

No functionality was changed. So, no new tests.

  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
4:06 PM Changeset in webkit [51469] by dbates@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2009-11-29 Daniel Bates <​dbates@webkit.org>

Unreviewed, fix change log entry date.

For some reason, bugzilla-tool did not update the date in the change
log entry for my last commit (r51468). So, this commit fixes the date
of that entry.

3:55 PM Changeset in webkit [51468] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2009-11-28 Daniel Bates <​dbates@webkit.org>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=31964

Removed #include StringImpl, StyleImage. Instead, forward declared them.
Also, we can substitute #include <wtf/PassRefPtr.h> for #include PlatformString.h,
since it seems we only really used it to include PassRefPtr.h.

No functionality was changed. So, no new tests.

  • rendering/style/ContentData.h:
12:11 PM Changeset in webkit [51467] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-11-29 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Mac build has JIT disabled
​https://bugs.webkit.org/show_bug.cgi?id=31828

  • wtf/Platform.h: Enable JIT for Qt Mac builds
7:57 AM Changeset in webkit [51466] by eric@webkit.org
  • 11 edits in trunk/WebCore

2009-11-29 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for classes of the rendering and storage directory in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=31906

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

class SQLTransactionClient - storage/DatabaseThread.cpp:45
class SQLTransactionCoordinator - storage/DatabaseThread.cpp:46
class OriginUsageRecord - storage/OriginQuotaManager.cpp:66
class DatabaseTracker - storage/DatabaseTracker.cpp:62
class ScrollbarTheme - (its child class) rendering/RenderScrollbarTheme.cpp:35
class RenderSelectionInfoBase - (its child class) rendering/RenderView.cpp:310
class RenderOverflow - rendering/RenderBox.cpp:2846

Inherits the following classes from FastAllocBase because these are instantiated by 'new':

struct FillLayer - css/CSSStyleSelector.cpp:197
struct ShadowData - rendering/style/ShadowData.cpp:35
class CounterContent - css/CSSStyleSelector.cpp:4111

  • platform/ScrollbarTheme.h:
  • rendering/RenderOverflow.h:
  • rendering/RenderSelectionInfo.h:
  • rendering/style/CounterContent.h:
  • rendering/style/FillLayer.h:
  • rendering/style/ShadowData.h:
  • storage/DatabaseTracker.h:
  • storage/OriginUsageRecord.h:
  • storage/SQLTransactionClient.h:
  • storage/SQLTransactionCoordinator.h:
Note: See TracTimeline for information about the timeline view.