Timeline
Dec 1, 2009:
- 10:26 PM Changeset in webkit [51588] by
-
- 2 edits in trunk/WebCore
Incorrect code in WebGLRenderingContext.cpp
https://bugs.webkit.org/show_bug.cgi?id=32046
Reviewed by Eric Seidel.
Fix incorrect code that happened to work. != has higher precendence than &.
The simplest fix is to remove the "!= 0" which violates WebKit style
guidelines anyway.
Also added periods to few comments in the same function.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateIndexArray):
- 9:51 PM Changeset in webkit [51587] by
-
- 4 edits in trunk/WebKitSite
2009-12-01 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Darin Adler.
Added clarifications to the web site regarding coding style and
code cleanup--
Changes include the following:
- Expanded the style guidelines regarding "using" statements.
- Made the style guidelines page validate as HTML.
- Added that legacy WebKit components should not be cleaned up.
- Added that it is more acceptable to update style when already touching code.
- coding/coding-style.html:
- coding/contributing.html:
- projects/cleanup/index.html:
- 9:50 PM Changeset in webkit [51586] by
-
- 5 edits in trunk/LayoutTests
2009-12-01 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Update expectations of css2.1/t1205-c56* for Qt
https://bugs.webkit.org/show_bug.cgi?id=32015
- platform/qt/Skipped:
- platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
- platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
- platform/qt/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
- 9:44 PM Changeset in webkit [51585] by
-
- 2 edits in trunk/WebKitTools
2009-12-01 Yaar Schnitman <yaar@chromium.org>
build-webkit: Remove flex,bison,gperf check for chromium
https://bugs.webkit.org/show_bug.cgi?id=32043
- Scripts/webkitdirs.pm:
- 9:17 PM Changeset in webkit [51584] by
-
- 7 edits3 adds in trunk
2009-12-01 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
pattern and step attributes of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=31708
- fast/forms/input-minmax-expected.txt:
- fast/forms/input-pattern-expected.txt: Added.
- fast/forms/input-pattern.html: Added.
- fast/forms/input-step-expected.txt:
- fast/forms/script-tests/input-minmax.js: Add tests for null/undefined/non-string.
- fast/forms/script-tests/input-pattern.js: Added.
- fast/forms/script-tests/input-step.js: Change the result for null.
2009-12-01 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
pattern and step attributes of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=31708
- html/HTMLInputElement.idl:
- 8:54 PM Changeset in webkit [51583] by
-
- 3 edits in trunk/WebKitTools
Build fixage for Windows/GTK for DumpRenderTree.
WAI-ARIA: implement support for ARIA drag and drop
https://bugs.webkit.org/show_bug.cgi?id=32007
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
- 8:40 PM Changeset in webkit [51582] by
-
- 11 edits2 adds in trunk
WAI-ARIA: implement support for ARIA drag and drop
https://bugs.webkit.org/show_bug.cgi?id=32007
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-drag-drop.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::supportsARIADropping):
(WebCore::AccessibilityObject::supportsARIADragging):
(WebCore::AccessibilityObject::isARIAGrabbed):
(WebCore::AccessibilityObject::setARIAGrabbed):
(WebCore::AccessibilityObject::determineARIADropEffects):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::supportsARIADropping):
(WebCore::AccessibilityRenderObject::supportsARIADragging):
(WebCore::AccessibilityRenderObject::isARIAGrabbed):
(WebCore::AccessibilityRenderObject::setARIAGrabbed):
(WebCore::AccessibilityRenderObject::determineARIADropEffects):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
- html/HTMLAttributeNames.in:
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(getARIADropEffectsCallback):
(getARIAIsGrabbedCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
LayoutTests:
- platform/mac/accessibility/aria-drag-drop-expected.txt: Added.
- platform/mac/accessibility/aria-drag-drop.html: Added.
- 7:49 PM Changeset in webkit [51581] by
-
- 1 edit in trunk/WebCore/bindings/v8/ScriptController.cpp
Typo fix.
- 7:44 PM Changeset in webkit [51580] by
-
- 3 edits in trunk/WebCore
2009-12-01 Adam Barth <abarth@webkit.org>
Unreviewed port of @sandbox to V8.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow):
- 7:28 PM Changeset in webkit [51579] by
-
- 1 edit2 adds in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=21288
Reviewed by Darin Adler.
Add sneaky test that has tabs.
- fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing.html: Added.
- 7:02 PM Changeset in webkit [51578] by
-
- 1 edit in trunk/WebCore/loader/FrameLoaderTypes.h
Change unsigned to int to fix the Windows build.
- 6:40 PM Changeset in webkit [51577] by
-
- 23 edits55 adds in trunk
2009-12-01 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Darin Adler.
Implement HTML5 sandbox attribute for iframes.
http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
https://bugs.webkit.org/show_bug.cgi?id=21288
- fast/frames/resources/non-sandboxed-iframe-navigation.html: Added.
- fast/frames/resources/sandboxed-iframe-attribute-parsing-allowed.html: Added.
- fast/frames/resources/sandboxed-iframe-attribute-parsing-disallowed.html: Added.
- fast/frames/resources/sandboxed-iframe-form-allowed.html: Added.
- fast/frames/resources/sandboxed-iframe-form-disallowed.html: Added.
- fast/frames/resources/sandboxed-iframe-navigated.html: Added.
- fast/frames/resources/sandboxed-iframe-navigation-child.html: Added.
- fast/frames/resources/sandboxed-iframe-navigation-navigated.html: Added.
- fast/frames/resources/sandboxed-iframe-navigation-parent.html: Added.
- fast/frames/resources/sandboxed-iframe-navigation-source.html: Added.
- fast/frames/resources/sandboxed-iframe-navigation-targetlink.html: Added.
- fast/frames/resources/sandboxed-iframe-navigation-windowopen.html: Added.
- fast/frames/resources/sandboxed-iframe-plugins-frame-applet.html: Added.
- fast/frames/resources/sandboxed-iframe-plugins-frame-embed.html: Added.
- fast/frames/resources/sandboxed-iframe-plugins-frame-object.html: Added.
- fast/frames/resources/sandboxed-iframe-script-dynamic.html: Added.
- fast/frames/resources/sandboxed-iframe-storage-allowed.html: Added.
- fast/frames/resources/sandboxed-iframe-storage-disallowed.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing.html: Added.
- fast/frames/sandboxed-iframe-forms-expected.txt: Added.
- fast/frames/sandboxed-iframe-forms.html: Added.
- fast/frames/sandboxed-iframe-navigation-allowed-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-allowed.html: Added.
- fast/frames/sandboxed-iframe-navigation-parent-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-parent.html: Added.
- fast/frames/sandboxed-iframe-navigation-targetlink-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-targetlink.html: Added.
- fast/frames/sandboxed-iframe-navigation-windowopen-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-windowopen.html: Added.
- fast/frames/sandboxed-iframe-plugins-expected.txt: Added.
- fast/frames/sandboxed-iframe-plugins.html: Added.
- fast/frames/sandboxed-iframe-scripting-expected.txt: Added.
- fast/frames/sandboxed-iframe-scripting.html: Added.
- fast/frames/sandboxed-iframe-storage-expected.txt: Added.
- fast/frames/sandboxed-iframe-storage.html: Added.
- http/tests/security/resources/sandboxed-iframe-document-cookie-read-denied.html: Added.
- http/tests/security/resources/sandboxed-iframe-modify-self.html: Added.
- http/tests/security/resources/xss-DENIED-sandboxed-iframe-attacker.html: Added.
- http/tests/security/sandboxed-iframe-document-cookie-expected.txt: Added.
- http/tests/security/sandboxed-iframe-document-cookie.html: Added.
- http/tests/security/sandboxed-iframe-modify-self-expected.txt: Added.
- http/tests/security/sandboxed-iframe-modify-self.html: Added.
- http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt: Added.
- http/tests/security/xss-DENIED-sandboxed-iframe.html: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html: Added.
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-iframe.html: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow.cgi: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-iframe.html: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard-iframe.html: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard.cgi: Added.
- http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied.cgi: Added.
2009-12-01 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Darin Adler.
Implement HTML5 sandbox attribute for iframes.
http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
https://bugs.webkit.org/show_bug.cgi?id=21288
Tests: fast/frames/sandboxed-iframe-attribute-parsing.html
fast/frames/sandboxed-iframe-forms.html
fast/frames/sandboxed-iframe-navigation-allowed.html
fast/frames/sandboxed-iframe-navigation-parent.html
fast/frames/sandboxed-iframe-navigation-targetlink.html
fast/frames/sandboxed-iframe-navigation-windowopen.html
fast/frames/sandboxed-iframe-plugins.html
fast/frames/sandboxed-iframe-scripting.html
fast/frames/sandboxed-iframe-storage.html
http/tests/security/sandboxed-iframe-document-cookie.html
http/tests/security/sandboxed-iframe-modify-self.html
http/tests/security/xss-DENIED-sandboxed-iframe.html
http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html
http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html
http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html
- bindings/js/JSDOMWindowCustom.cpp: sandboxing navigation (WebCore::createWindow):
- bindings/js/ScriptController.cpp: sandboxing scripts (WebCore::ScriptController::isEnabled):
- dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::cookie): raise exception when accessed from sandbox (WebCore::Document::setCookie): raise exception when accessed from sandbox (WebCore::Document::initSecurityContext): updae sandbox status (WebCore::Document::updateSandboxFlags):
- dom/Document.h:
- dom/Document.idl:
- html/HTMLAppletElement.cpp: sandboxing applets (WebCore::HTMLAppletElement::createRenderer): (WebCore::HTMLAppletElement::renderWidgetForJSBindings): (WebCore::HTMLAppletElement::canEmbedJava):
- html/HTMLAppletElement.h:
- html/HTMLAttributeNames.in:
- html/HTMLFrameOwnerElement.cpp: management of sandbox flags as stated in attribute (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
- html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::sandboxFlags):
- html/HTMLIFrameElement.cpp: sandbox attribute parsing (WebCore::parseSandboxAttribute): (WebCore::HTMLIFrameElement::parseMappedAttribute):
- html/HTMLIFrameElement.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies):
- loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::submitForm): sandboxing forms (WebCore::FrameLoader::requestObject): sandboxing plugins (WebCore::FrameLoader::shouldAllowNavigation): sandboxing navigation (WebCore::FrameLoader::updateSandboxFlags): propagation of sandbox flags
- loader/FrameLoader.h: (WebCore::FrameLoader::ownerElementSandboxFlagsChanged): (WebCore::FrameLoader::isSandboxed): (WebCore::FrameLoader::sandboxFlags):
- loader/FrameLoaderTypes.h: (WebCore::):
- page/DOMWindow.cpp: disable storage and databases in sandboxed frames (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage): (WebCore::DOMWindow::openDatabase):
- page/SecurityOrigin.cpp: added sandboxing status (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::toString):
- page/SecurityOrigin.h: (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::isSandboxed): (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage):
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
- 6:04 PM Changeset in webkit [51576] by
-
- 7 edits2 adds in trunk
ARIA: support a way to create a static text object
https://bugs.webkit.org/show_bug.cgi?id=32030
Reviewed by David Kilzer.
WebCore:
Test: accessibility/aria-text-role.html
- accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::isDescendantOfBarrenParent):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::text):
- accessibility/AccessibilityRenderObject.h:
LayoutTests:
- accessibility/aria-text-role-expected.txt: Added.
- accessibility/aria-text-role.html: Added.
- platform/gtk/Skipped:
- platform/win/Skipped:
- 5:56 PM Changeset in webkit [51575] by
-
- 2 edits in trunk/WebKitTools
Not reviewed. GTK DRT try 2.
- 5:51 PM Changeset in webkit [51574] by
-
- 2 edits in trunk/WebKitTools
Not reviewed. Try to fix gtk DRT build.
- 5:48 PM Changeset in webkit [51573] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to rebuild Interfaces and fix the Windows build.
- 5:41 PM Changeset in webkit [51572] by
-
- 3 edits in trunk/WebCore
Inspector crashes when collecting on every allocation
https://bugs.webkit.org/show_bug.cgi?id=32044
Reviewed by Maciej Stachowiak.
The crash is caused by the prototype wrapper object getting collected
when allocating the object that is going to use it as a prototype.
Because the only reference to the prototype wrapper is through the
new object's Structure it does not get marked automatically.
- 5:40 PM Changeset in webkit [51571] by
-
- 2 edits in trunk
Build fix by using DOMNode::node() to go from a DOMNode to a node, and
added svg/animation in the WebCore.vcproj list of headers to be copied
over on build.
- 5:26 PM Changeset in webkit [51570] by
-
- 3 edits in trunk/WebKitTools
check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
https://bugs.webkit.org/show_bug.cgi?id=32033
Reviewed by Eric Seidel.
- Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
instead of startswith.
- Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
- 5:03 PM Changeset in webkit [51569] by
-
- 2 edits in trunk/WebKitTools
Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
- 4:53 PM Changeset in webkit [51568] by
-
- 4 edits in trunk/WebKit
Not reviewed. Try to fix qt/win builds.
- 4:41 PM Changeset in webkit [51567] by
-
- 29 edits8 adds in trunk
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.
Implemented just like the existing pauseAnimation* methods for CSS animations.
- Api/qwebframe.cpp: (qt_drt_pauseSVGAnimation):
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.
Implemented just like the existing pauseAnimation* methods for CSS animations.
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_pause_svg_animation):
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.
Implemented just like the existing pauseAnimation* methods for CSS animations.
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp: (WebFrame::pauseSVGAnimation):
- WebFrame.h:
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.
Implemented just like the existing pauseAnimation* methods for CSS animations.
- WebView/WebFrame.mm: (-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]):
- WebView/WebFramePrivate.h:
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add 'sampleSVGAnimationForElementAtTime' method to the LayoutTestController,
for the use within the new SVG animation test framework (LayoutTests/svg/animations/)
layoutTestController.sampleAnimationAtTime(<svg animation id>, <absolute time>, <svg element id>);
to sample a svg animateMotion/animateColor/animate/set element at certain times.
After the desired SVG animation starts and calling the method above, it's immediately forwarded to
the desired sampling time. After JS returns from the 'sampleSVGAnimationForElementAtTime' method
a callback is fired used to sample the animation value at the target time. It's modelled similar
to the CSS animation/transition testing framework, inspired by
LayoutTests/animations/animation-test-helpers.js.
Though it has been extended to integrate within the fast/js/js-test-* framework, that's used for
the SVG dynamic-updates tests, to simplify test creation, by utilizing script-tests/* only.
Adding a simple testcase testing the DRT methods, it will soon be extended to test animVal/baseVal
interaction, while animating.
Test: svg/animations/animVal-basics.html
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::sampleAnimationAtTime):
- svg/SVGDocumentExtensions.h:
- svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::SMILTimeContainer): (WebCore::SMILTimeContainer::sampleAnimationAtTime): (WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SMILTimeContainer.h:
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add LayoutTests/svg/animations directory, containing a new
framework for SVG animation test with sampling at certain times.
Added one example test, which will be extended soon to cover animVal
support, once basic support has been implemented.
- svg/animations: Added.
- svg/animations/animVal-basics-expected.txt: Added.
- svg/animations/animVal-basics.html: Added.
- svg/animations/resources: Added.
- svg/animations/resources/SVGAnimationTestCase.js: Added. (isCloseEnough): (moveAnimationTimelineAndSample): (startTest): (sampleAnimation): (runAnimationTest):
- svg/animations/script-tests: Added.
- svg/animations/script-tests/TEMPLATE.html: Added.
- svg/animations/script-tests/animVal-basics.js: Added. (sample1): (sample2): (sample3): (executeTest):
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add new 'sampleSVGAnimationForElementAtTime' DRT method,
used by the new SVG animation testing framework, implemented
for qt/gtk/win/mac.
- DumpRenderTree/LayoutTestController.cpp: (sampleSVGAnimationForElementAtTimeCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::sampleSVGAnimationForElementAtTime):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
- 4:05 PM Changeset in webkit [51566] by
-
- 14 edits in trunk
JavaScriptCore: Added variants of find/contains/add that allow a foreign key type to be used.
This will allow AtomicString-keyed maps to be queried by C string without
having to create a temporary AtomicString (see HTTPHeaderMap.)
The code for this is adapted from the equivalent in HashSet.h.
WebCore: Add convenience methods to Element and QualifiedName that take
char* instead of AtomicString, in preparation for removing the
implicit conversion between the two types (30187).
https://bugs.webkit.org/show_bug.cgi?id=31749
Reviewed by Darin Adler.
- 3:59 PM Changeset in webkit [51565] by
-
- 2 edits in trunk/WebCore
More Windows build fix.
- platform/network/cf/CredentialStorageCFNet.cpp: (WebCore::CredentialStorage::getFromPersistentStorage):
- 3:52 PM Changeset in webkit [51564] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- platform/network/cf/CredentialStorageCFNet.cpp: Include RetainPtr.h.
- 3:40 PM Changeset in webkit [51563] by
-
- 2 edits in trunk/LayoutTests
Skip more tests that fail with specific versions of CFNetwork on Windows
Rubber-stamped in advance by Brady Eidson.
- platform/win/Skipped:
- 3:36 PM Changeset in webkit [51562] by
-
- 4 edits in trunk/WebKit/mac
Simplify [WebView userAgentForURL:]. No need to call into helper function.
Reviewed by Mark Rowe.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::userAgent):
- WebView/WebView.mm:
(-[WebView userAgentForURL:]):
- WebView/WebViewInternal.h:
- 3:35 PM Changeset in webkit [51561] by
-
- 6 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32036
Implement CredentialStorage::getFromPersistentStorage for CFNetwork
- 3:34 PM Changeset in webkit [51560] by
-
- 4 edits in trunk/WebKit/chromium
[Chromium] Simplify zoom-related APIs and add a zoom level getter,
part one: Add new APIs. (Old APIs will be removed in a second pass.)
https://bugs.webkit.org/show_bug.cgi?id=31893
Reviewed by Darin Fisher.
- public/WebView.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
- src/WebViewImpl.h:
- 2:12 PM Changeset in webkit [51559] by
-
- 6 edits in trunk
2009-12-01 Daniel Bates <dbates@webkit.org>
Reviewed by Pavel Feldman.
Updated layout test to reflect change to localized string and
rebased the result.
- inspector/elements-img-tooltip-expected.txt:
- inspector/elements-img-tooltip.html:
2009-12-01 Daniel Bates <dbates@webkit.org>
Reviewed by Pavel Feldman.
Added missing localized strings (that I left out of the patch for bug #21554):
%d × %d pixels
%d × %d pixels (Natural: %d × %d pixels)
Also, changed formatting of these stings to conform with existing ones (added
a space on both sides of the multiply sign).
- English.lproj/localizedStrings.js: Added stings.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
- 2:05 PM Changeset in webkit [51558] by
-
- 2 edits in trunk/WebKit/qt
2009-12-01 Daniel Bates <dbates@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Makes QtLauncher default to the http scheme for URLs.
- QtLauncher/main.cpp: (MainWindow::MainWindow): (MainWindow::changeLocation): (main):
- 1:33 PM Changeset in webkit [51557] by
-
- 2 edits in trunk/LayoutTests
Skip a test that fails with some versions of CFNetwork on Windows
Rubber-stamped by Brady Eidson.
- platform/win/Skipped: Skip http/tests/plugins/post-url-file.html.
- 1:32 PM Changeset in webkit [51556] by
-
- 2 edits4 adds in trunk
Fix for bug 32032, empty namespaces should be allowed in @namespace directives in CSS.
Reviewed by Simon Fraser.
Added fast/css/namespaces/namespaces-empty.xml
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addNamespace):
(WebCore::CSSStyleSheet::determineNamespace):
- 1:17 PM Changeset in webkit [51555] by
-
- 2 edits in trunk/JavaScriptCore
Revert 51551 because it broke GTK+.
- 12:59 PM Changeset in webkit [51554] by
-
- 2 edits in trunk/WebKitTools
Remove user content before running each test on Windows
Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
Reviewed by Alexey Proskuryakov.
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting): Remove all user content
before each test, which matches Mac.
- 12:08 PM Changeset in webkit [51553] by
-
- 2 edits in trunk/WebCore
2009-12-01 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Escape key in the Search Field should be more User Friendly
https://bugs.webkit.org/show_bug.cgi?id=32005
- inspector/front-end/inspector.js: (WebInspector.loaded): add mousedown listener on the search field (WebInspector.searchFieldManualFocus): user clicked to focus on the search field (WebInspector.searchKeyDown): handle escape
- 11:08 AM Changeset in webkit [51552] by
-
- 2 edits in trunk/LayoutTests
Enabling WebSocket tests on Windows again - let's see what errors get logged.
- platform/win/Skipped:
- 11:01 AM Changeset in webkit [51551] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-01 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
PLATFORM(CAIRO) should be defined by WIN_CAIRO define
https://bugs.webkit.org/show_bug.cgi?id=22250
- wtf/Platform.h: Remove WTF_PLATFORM_CAIRO as it is already define in config.h
- 10:56 AM Changeset in webkit [51550] by
-
- 2 edits in trunk/WebKitTools
2009-12-01 Yuzo Fujishima <yuzo@google.com>
Reviewed by Alexey Proskuryakov.
Make pywebsocket log errors to a file
https://bugs.webkit.org/show_bug.cgi?id=31604
- Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory (by passing the path to the server via a recently added -l option).
- 10:55 AM Changeset in webkit [51549] by
-
- 2 edits4 adds in trunk
@namespace directives need to use "maybe_space" in the "maybe_ns_prefix" portion of the grammar to match
the spec. Not doing so prevent comments from being used immmediately after the namespace prefix.
Reviewed by David Kilzer.
Added fast/css/namespaces-comments.xml
- css/CSSGrammar.y:
- 10:41 AM Changeset in webkit [51548] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-01 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Darin Fisher.
Only fire start/stop events when main frame is not loading.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage):
- 10:38 AM Changeset in webkit [51547] by
-
- 2 edits in trunk/LayoutTests
Add a timing-out test to the Skipped file on Windows
Rubber-stamped by Ada Chan.
- platform/win/Skipped: Added
fast/dom/Window/window-postmessage-clone.html, which was timing out
due to eventSender.beginDragFiles being unimplemented.
- 10:35 AM Changeset in webkit [51546] by
-
- 2 edits in trunk/WebKitTools
Fix tests that use the TestNetscapePlugin in Debug_Internal builds
Reviewed by Ada Chan.
Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
TestNetscapePlugin fail in Debug_Internal builds
- DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
directory in Debug and Debug_All builds, but not in Debug_Internal
builds.
- 10:01 AM Changeset in webkit [51545] by
-
- 2 edits in trunk/WebKitTools
Re-enable DRT's watchdog timer on Windows
It was accidentally disabled in r50907.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
into an if condition.
- 9:24 AM Changeset in webkit [51544] by
-
- 2 edits in trunk/WebCore
2009-12-01 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Timothy Hatcher.
Reloading WebInspector from context menu is closing it instead of reloading.
https://bugs.webkit.org/show_bug.cgi?id=32004
When reloading WebInspector, don't delete its m_page.
- inspector/InspectorController.cpp: (WebCore::InspectorController::close):
- 9:20 AM Changeset in webkit [51543] by
-
- 2 edits7 adds in trunk/LayoutTests
Add expected Windows failure results for tests that use textInputController
<http://webkit.org/b/32021> covers fixing these tests.
Rubber-stamped by Sam Weinig.
- platform/win/Skipped: Removed tests that use textInputController.
- platform/win/editing/selection/5825350-1-expected.txt: Added.
- platform/win/editing/selection/5825350-2-expected.txt: Added.
- platform/win/editing/selection/mixed-editability-10-expected.txt: Added.
- platform/win/fast/events/ime-composition-events-001-expected.txt: Added.
- platform/win/fast/forms/input-maxlength-ime-completed-expected.txt: Added.
- platform/win/fast/forms/input-maxlength-ime-preedit-expected.txt: Added.
- platform/win/fast/text/international/thai-cursor-position-expected.txt: Added.
- 8:51 AM Changeset in webkit [51542] by
-
- 2 edits in trunk/LayoutTests
[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector().
- platform/qt/Skipped: inspector/timeline-network-resource.html added.
- 8:46 AM Changeset in webkit [51541] by
-
- 3 edits in trunk/WebKitTools
2009-12-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
check-webkit-style complains about #imports with / in them
https://bugs.webkit.org/show_bug.cgi?id=32022
We need to exclude #import directives in addition to #include from the
binary operator whitespace checks.
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 8:46 AM Changeset in webkit [51540] by
-
- 8 edits6 adds in trunk/WebCore
2009-12-01 Steve Block <steveblock@google.com>
Reviewed by Dimitri Glazkov.
Adds V8 bindings for Geolocation.
https://bugs.webkit.org/show_bug.cgi?id=30206
Also adds Geolocation files to Chrome build files.
- WebCore.gyp/WebCore.gyp: Modified. Corrects list of Geolocation IDL files.
- WebCore.gypi: Modified. Adds Geolocation files.
- bindings/v8/DOMObjectsInclude.h: Modified. Adds Geolocation includes.
- bindings/v8/DerivedSourcesAllInOne.cpp: Modified. Adds Geolocation files.
- bindings/v8/V8Index.cpp: Modified. Includes Geolocation generated headers.
- bindings/v8/V8Index.h: Modified. Adds Geolocation types to DOM_OBJECT_TYPES.
- bindings/v8/custom/V8CoordinatesCustom.cpp: Added. Handles optional properties.
- bindings/v8/custom/V8CustomBinding.h: Modified. Declares callbacks and getters.
- bindings/v8/custom/V8CustomPositionCallback.cpp: Added. (WebCore::V8CustomPositionCallback::V8CustomPositionCallback): Added. Constructor. (WebCore::V8CustomPositionCallback::~V8CustomPositionCallback): Added. Destructor. (WebCore::V8CustomPositionCallback::handleEvent): Added. Invokes callback.
- bindings/v8/custom/V8CustomPositionCallback.h: Added. (WebCore::V8CustomPositionCallback::create): Added. Factory method.
- bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Added. (WebCore::V8CustomPositionErrorCallback::V8CustomPositionErrorCallback): Added. Constructor. (WebCore::V8CustomPositionErrorCallback::~V8CustomPositionErrorCallback): Added. Destructor. (WebCore::V8CustomPositionErrorCallback::handleEvent): Added. Invokes callback.
- bindings/v8/custom/V8CustomPositionErrorCallback.h: Added. (WebCore::V8CustomPositionErrorCallback::create): Added. Factory method.
- bindings/v8/custom/V8GeolocationCustom.cpp: Added. (WebCore::throwTypeMismatchException): Added. Throws a type mismatch error. (WebCore::createPositionCallback): Added. Handles type checking for successCallback argument. (WebCore::createPositionErrorCallback): Added. Handles type checking for errorCallback argument. (WebCore::createPositionOptions): Added. Handles type checking for positionOptions argument.
- 8:19 AM Changeset in webkit [51539] by
-
- 2 edits3 adds in trunk/LayoutTests
2009-12-01 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Adds test for Timeline network resource records.
- inspector/timeline-network-resource-expected.txt: Added.
- inspector/timeline-network-resource.html: Added.
- inspector/timeline-network-resource.js: Added.
- inspector/timeline-test.js: (printTimelineRecords):
- 8:17 AM Changeset in webkit [51538] by
-
- 4 edits in trunk/WebCore
2009-12-01 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Provide a way to get ScriptState for the inspected page.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromPage):
- 8:09 AM Changeset in webkit [51537] by
-
- 5 edits in trunk
Changed mallocs to fastMallocs and frees to fastFrees in GraphicsContext3D. Also added error returns
https://bugs.webkit.org/show_bug.cgi?id=30778
- 7:45 AM Changeset in webkit [51536] by
-
- 2 edits in trunk/WebCore
2009-12-01 Mads Ager <ager@chromium.org>
Reviewed by Eric Seidel.
[V8] Don't crash in DOMWindow event getter in OOM situations
https://bugs.webkit.org/show_bug.cgi?id=32017
Add missing null handle checks in DOMWindow event property
accessors. V8Proxy::context(frame) can return a null handle in
OOM situations either if failing to initialize a context or if an
OOM is handled gracefully and javascript is disabled.
No new tests because we don't have a good way to test
out-of-memory bugs.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
- 6:44 AM Changeset in webkit [51535] by
-
- 6 edits in trunk
Updated HTMLCanvasElement to accept "experimental-webgl" as the context name.
https://bugs.webkit.org/show_bug.cgi?id=31672
- 6:22 AM Changeset in webkit [51534] by
-
- 2 edits in trunk/WebCore
2009-12-01 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Not reviewed: chromium build fix, added missing import.
- inspector/InspectorFrontendHost.cpp:
- 3:26 AM Changeset in webkit [51533] by
-
- 2 edits in trunk/LayoutTests
[Qt] Put tests into skiplist because of missing textInputController.selectedRange().
- platform/qt/Skipped:
- editing/selection/mixed-editability-10.html added.
- editing/selection/5825350-1.html added.
- editing/selection/5825350-2.html added.
- 1:45 AM Changeset in webkit [51532] by
-
- 2 edits in trunk/WebCore
2009-12-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: fix windows build via unexcluding generated files from
project.
- WebCore.vcproj/WebCore.vcproj:
- 1:33 AM Changeset in webkit [51531] by
-
- 2 edits in trunk/WebCore
Stop copying IDL files in to the WebCore framework wrapper.
- WebCore.xcodeproj/project.pbxproj:
- 1:28 AM Changeset in webkit [51530] by
-
- 2 edits in trunk/WebCore
Fix the Tiger build by making the Xcode project compatible with Xcode 2.4.
This was probably broken by hand-editing the project file as Xcode itself
knows how to keep project files to a backwards-compatible subset of its format.
- WebCore.xcodeproj/project.pbxproj:
- 12:45 AM Changeset in webkit [51529] by
-
- 2 edits in trunk/WebCore
2009-12-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: windows build fix (bad vcproj in r51528).
- WebCore.vcproj/WebCore.vcproj:
- 12:07 AM Changeset in webkit [51528] by
-
- 49 edits5 copies7 adds2 deletes in trunk/WebCore
2009-11-27 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Reviewed by Timothy Hatcher.
Web Inspector: Split InspectorBackend into three parts: backend,
injected script host and frontend host.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSInspectorBackendCustom.cpp: Removed.
- bindings/js/JSInspectorFrontendHostCustom.cpp: Added. (WebCore::JSInspectorFrontendHost::search): (WebCore::JSInspectorFrontendHost::setting): (WebCore::JSInspectorFrontendHost::setSetting):
- bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
- bindings/js/ScriptObject.h:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
- bindings/v8/ScriptObject.h:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8InspectorBackendCustom.cpp: Removed.
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- inspector/InjectedScriptHost.cpp: Added. (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::~InjectedScriptHost): (WebCore::InjectedScriptHost::copyText): (WebCore::InjectedScriptHost::nodeForId): (WebCore::InjectedScriptHost::wrapObject): (WebCore::InjectedScriptHost::unwrapObject): (WebCore::InjectedScriptHost::pushNodePathToFrontend): (WebCore::InjectedScriptHost::addNodesToSearchResult): (WebCore::InjectedScriptHost::currentCallFrame): (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript): (WebCore::InjectedScriptHost::inspectorDOMAgent): (WebCore::InjectedScriptHost::inspectorFrontend):
- inspector/InjectedScriptHost.h: Added. (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::inspectorController): (WebCore::InjectedScriptHost::disconnectController):
- inspector/InjectedScriptHost.idl: Added.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::InspectorBackend): (WebCore::InspectorBackend::storeLastActivePanel): (WebCore::InspectorBackend::toggleNodeSearch): (WebCore::InspectorBackend::resourceTrackingEnabled): (WebCore::InspectorBackend::debuggerEnabled): (WebCore::InspectorBackend::enableDebugger): (WebCore::InspectorBackend::disableDebugger): (WebCore::InspectorBackend::addBreakpoint): (WebCore::InspectorBackend::updateBreakpoint): (WebCore::InspectorBackend::removeBreakpoint): (WebCore::InspectorBackend::pauseInDebugger): (WebCore::InspectorBackend::resumeDebugger): (WebCore::InspectorBackend::stepOverStatementInDebugger): (WebCore::InspectorBackend::stepIntoStatementInDebugger): (WebCore::InspectorBackend::stepOutOfFunctionInDebugger): (WebCore::InspectorBackend::pauseOnExceptions): (WebCore::InspectorBackend::setPauseOnExceptions): (WebCore::InspectorBackend::profilerEnabled): (WebCore::InspectorBackend::enableProfiler): (WebCore::InspectorBackend::disableProfiler): (WebCore::InspectorBackend::startProfiling): (WebCore::InspectorBackend::stopProfiling): (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile): (WebCore::InspectorBackend::currentCallFrame): (WebCore::InspectorBackend::highlightDOMNode): (WebCore::InspectorBackend::hideDOMNodeHighlight): (WebCore::InspectorBackend::getCookies): (WebCore::InspectorBackend::deleteCookie): (WebCore::InspectorBackend::didEvaluateForTestInFrontend): (WebCore::InspectorBackend::nodeForId):
- inspector/InspectorBackend.h: (WebCore::InspectorBackend::create):
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable):
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorFrontendHost): (WebCore::InspectorController::injectedScriptHost):
- inspector/InspectorFrontendHost.cpp: Added. (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::loaded): (WebCore::InspectorFrontendHost::attach): (WebCore::InspectorFrontendHost::detach): (WebCore::InspectorFrontendHost::closeWindow): (WebCore::InspectorFrontendHost::windowUnloading): (WebCore::InspectorFrontendHost::setAttachedWindowHeight): (WebCore::InspectorFrontendHost::moveWindowBy): (WebCore::InspectorFrontendHost::localizedStringsURL): (WebCore::InspectorFrontendHost::hiddenPanels): (WebCore::InspectorFrontendHost::platform): (WebCore::InspectorFrontendHost::port): (WebCore::InspectorFrontendHost::addResourceSourceToFrame): (WebCore::InspectorFrontendHost::addSourceToFrame):
- inspector/InspectorFrontendHost.h: Added. (WebCore::InspectorFrontendHost::create): (WebCore::InspectorFrontendHost::inspectorController): (WebCore::InspectorFrontendHost::disconnectController):
- inspector/InspectorFrontendHost.idl: Added.
- inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set condition):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.clearMessages):
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype.setAttributeAsync): (WebInspector.DOMAgent.prototype.removeAttributeAsync): (WebInspector.DOMAgent.prototype.setTextNodeValueAsync): (WebInspector.Cookies.getCookiesAsync): (WebInspector.EventListeners.getEventListenersForNodeAsync):
- inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.prototype.getEntries): (WebInspector.DOMStorage.prototype.setItem): (WebInspector.DOMStorage.prototype.removeItem):
- inspector/front-end/Database.js: (WebInspector.Database.prototype.getTableNames):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.handleCopyEvent): (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode): (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode): ():
- inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype):
- inspector/front-end/InjectedScript.js: (InjectedScript._evaluateAndWrap): (InjectedScript.performSearch.addNodesToResults): (InjectedScript.getCallFrames): (InjectedScript._callFrameForId): (InjectedScript._clearConsoleMessages): (InjectedScript._inspectObject): (InjectedScript._copy): (InjectedScript._ensureCommandLineAPIInstalled): (InjectedScript._window): (InjectedScript._nodeForId): (InjectedScript._objectForId): (InjectedScript.pushNodeToFrontend): (InjectedScript.executeSql): (InjectedScript.executeSql.errorCallback): (InjectedScript.executeSql.queryTransaction):
- inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
- inspector/front-end/InspectorBackendStub.js: Added. (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.wrapCallback): (.WebInspector.InspectorBackendStub.prototype.platform): (.WebInspector.InspectorBackendStub.prototype.port): (.WebInspector.InspectorBackendStub.prototype.closeWindow): (.WebInspector.InspectorBackendStub.prototype.attach): (.WebInspector.InspectorBackendStub.prototype.detach): (.WebInspector.InspectorBackendStub.prototype.storeLastActivePanel): (.WebInspector.InspectorBackendStub.prototype.clearMessages): (.WebInspector.InspectorBackendStub.prototype.searchingForNode): (.WebInspector.InspectorBackendStub.prototype.search): (.WebInspector.InspectorBackendStub.prototype.toggleNodeSearch): (.WebInspector.InspectorBackendStub.prototype.setAttachedWindowHeight): (.WebInspector.InspectorBackendStub.prototype.moveByUnrestricted): (.WebInspector.InspectorBackendStub.prototype.addResourceSourceToFrame): (.WebInspector.InspectorBackendStub.prototype.addSourceToFrame): (.WebInspector.InspectorBackendStub.prototype.getResourceDocumentNode): (.WebInspector.InspectorBackendStub.prototype.highlightDOMNode): (.WebInspector.InspectorBackendStub.prototype.hideDOMNodeHighlight): (.WebInspector.InspectorBackendStub.prototype.inspectedWindow): (.WebInspector.InspectorBackendStub.prototype.loaded): (.WebInspector.InspectorBackendStub.prototype.localizedStringsURL): (.WebInspector.InspectorBackendStub.prototype.windowUnloading): (.WebInspector.InspectorBackendStub.prototype.hiddenPanels): (.WebInspector.InspectorBackendStub.prototype.debuggerEnabled): (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.resourceTrackingEnabled): (.WebInspector.InspectorBackendStub.prototype.enableDebugger): (.WebInspector.InspectorBackendStub.prototype.disableDebugger): (.WebInspector.InspectorBackendStub.prototype.addBreakpoint): (.WebInspector.InspectorBackendStub.prototype.removeBreakpoint): (.WebInspector.InspectorBackendStub.prototype.updateBreakpoint): (.WebInspector.InspectorBackendStub.prototype.pauseInDebugger): (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptions): (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptions): (.WebInspector.InspectorBackendStub.prototype.resumeDebugger): (.WebInspector.InspectorBackendStub.prototype.profilerEnabled): (.WebInspector.InspectorBackendStub.prototype.enableProfiler): (.WebInspector.InspectorBackendStub.prototype.disableProfiler): (.WebInspector.InspectorBackendStub.prototype.startProfiling): (.WebInspector.InspectorBackendStub.prototype.stopProfiling): (.WebInspector.InspectorBackendStub.prototype.getProfileHeaders): (.WebInspector.InspectorBackendStub.prototype.getProfile): (.WebInspector.InspectorBackendStub.prototype.takeHeapSnapshot): (.WebInspector.InspectorBackendStub.prototype.databaseTableNames): (.WebInspector.InspectorBackendStub.prototype.stepIntoStatementInDebugger): (.WebInspector.InspectorBackendStub.prototype.stepOutOfFunctionInDebugger): (.WebInspector.InspectorBackendStub.prototype.stepOverStatementInDebugger): (.WebInspector.InspectorBackendStub.prototype.setSetting): (.WebInspector.InspectorBackendStub.prototype.dispatchOnInjectedScript): (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup): (.WebInspector.InspectorBackendStub.prototype.setting):
- inspector/front-end/InspectorControllerStub.js:
- inspector/front-end/InspectorFrontendHostStub.js: Added. (.WebInspector.InspectorFrontendHostStub): (.WebInspector.InspectorFrontendHostStub.prototype.platform): (.WebInspector.InspectorFrontendHostStub.prototype.port): (.WebInspector.InspectorFrontendHostStub.prototype.closeWindow): (.WebInspector.InspectorFrontendHostStub.prototype.attach): (.WebInspector.InspectorFrontendHostStub.prototype.detach): (.WebInspector.InspectorFrontendHostStub.prototype.search): (.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight): (.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy): (.WebInspector.InspectorFrontendHostStub.prototype.addResourceSourceToFrame): (.WebInspector.InspectorFrontendHostStub.prototype.addSourceToFrame): (.WebInspector.InspectorFrontendHostStub.prototype.loaded): (.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL): (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels): (.WebInspector.InspectorFrontendHostStub.prototype.setSetting): (.WebInspector.InspectorFrontendHostStub.prototype.setting):
- inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView): (WebInspector.CPUProfileType.prototype.buttonClicked):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._enableProfiling): (WebInspector.ProfilesPanel.prototype._toggleProfiling):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._toggleLargerResources): (WebInspector.ResourcesPanel.prototype._enableResourceTracking): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): (WebInspector.ScriptsPanel.prototype._togglePause): (WebInspector.ScriptsPanel.prototype._stepOverClicked): (WebInspector.ScriptsPanel.prototype._stepIntoClicked): (WebInspector.ScriptsPanel.prototype._stepOutClicked):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype.performSearch.findSearchMatches): (WebInspector.SourceView.prototype.performSearch):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
- inspector/front-end/TestController.js: (WebInspector.TestController.prototype.notifyDone):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions): (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.pendingDispatches.0.get platform): (WebInspector.get port): (WebInspector.set currentPanel): (WebInspector._createPanels): (WebInspector._loadPreferences): (WebInspector.set attached): (WebInspector._updateHoverHighlight): (WebInspector.loaded): (windowLoaded): (WebInspector.windowUnload): (WebInspector.close): (WebInspector.toolbarDrag): (WebInspector.UIString):
Nov 30, 2009:
- 11:37 PM Changeset in webkit [51527] by
-
- 24 edits2 adds in trunk
2009-11-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
css2.1/t1205-c566-list-stl-00-e-ag.html is failing
https://bugs.webkit.org/show_bug.cgi?id=23264
css2.1/t1205-c565-list-pos-00-b.html is failing
https://bugs.webkit.org/show_bug.cgi?id=23263
Ignore whitespaces after list markers.
Rendering of this was already done for the case where inside=false.
This fixes the rendering of inside=true case and calcInlinePrefWidths.
Test: fast/lists/calc-width-with-space.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
2009-11-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
css2.1/t1205-c566-list-stl-00-e-ag.html is failing
https://bugs.webkit.org/show_bug.cgi?id=23264
- editing/pasteboard/copy-crash-expected.txt:
- fast/lists/calc-width-with-space-expected.txt: Added.
- fast/lists/calc-width-with-space.html: Added.
- platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.checksum:
- platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.png:
- platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.txt:
- platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.checksum:
- platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.png:
- platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt:
- platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.checksum:
- platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.png:
- platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
- platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum:
- platform/mac/fast/block/positioning/complex-percentage-height-expected.png:
- platform/mac/fast/block/positioning/complex-percentage-height-expected.txt:
- platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum:
- platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png:
- platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt:
- platform/mac/fast/repaint/list-marker-expected.checksum:
- platform/mac/fast/repaint/list-marker-expected.png:
- platform/mac/fast/repaint/list-marker-expected.txt:
- platform/qt/Skipped:
- 11:25 PM Changeset in webkit [51526] by
-
- 2 edits in trunk/WebKitTools
2009-11-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
check-webkit-style is slightly too verbose
https://bugs.webkit.org/show_bug.cgi?id=32010
check-webkit-style prints out a bunch of "done" lines that seem redundant,
especially for the style-queue.
- Scripts/modules/cpp_style.py:
- 10:41 PM Changeset in webkit [51525] by
-
- 2 edits in trunk/WebKitTools
2009-11-30 Alejandro G. Castro <alex@igalia.com>
Reviewed by Eric Seidel.
[GTK] Moved the functions that are closing the result log of the
tests to the last line of the runTest function, this avoids
reporting crashes in the wrong test if there is a problem when
reseting the state after the test.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest):
- 7:33 PM Changeset in webkit [51524] by
-
- 5 edits in trunk/WebCore
2009-11-30 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed Chromium build fix introduced by r51212
Fix scriptStateFromNode and ScriptStateFromPage to take DOMWrapperWorld
as the first argument.
Move mainThreadNormalWorld() to ScriptState.{h,cpp}.
Add debuggerWorld() and pluginWorld() in ScriptState.h.
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromNode): (WebCore::scriptStateFromPage): (WebCore::mainThreadNormalWorld):
- bindings/v8/ScriptState.h: (WebCore::debuggerWorld): (WebCore::pluginWorld):
- 5:18 PM Changeset in webkit [51523] by
-
- 5 edits in trunk/WebKitTools
Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
fast/js/date-proto-generic-invocation breaks another test
Reviewed by Geoffrey Garen.
Don't cache JSClassRefs, a change to the prototype chain will
last between tests.
- DumpRenderTree/AccessibilityController.cpp:
(AccessibilityController::getJSClass):
- DumpRenderTree/GCController.cpp:
(GCController::getJSClass):
- DumpRenderTree/GCController.h:
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::getJSClass):
- 4:44 PM Changeset in webkit [51522] by
-
- 15 edits2 adds in trunk
WebCore: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750
Reviewed by Darin Adler.
The goal is to change the way we choose a visible position
after hit detection, by preferring a visually equivalent editable
position if available. By doing this, it is possible to add content
to an editable block that initially contains only non editable elements.
Test: editing/selection/mixed-editability-10.html
- WebCore.base.exp: Changed to match the new signature of downstream
and upstream in the Position class.
- dom/Position.cpp:
(WebCore::Position::atEditingBoundary): Added.
(WebCore::Position::upstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::downstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
(WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box
to be used in calculating the caret rectangle.
- dom/Position.h:
(WebCore::Position::):
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::atEditingBoundary): Added.
(WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
- dom/PositionIterator.h:
- editing/htmlediting.cpp:
(WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
(WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position,
if available.
- rendering/RenderText.cpp:
(WebCore::RenderText::isAllCollapsibleWhitespace): Added.
- rendering/RenderText.h:
LayoutTests: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750
Reviewed by Darin Adler.
- editing/selection/5825350-1-expected.txt:
- editing/selection/5825350-1.html: Modified to use caret rectangle.
- editing/selection/5825350-2-expected.txt:
- editing/selection/5825350-2.html: Modified to use caret rectangle.
- editing/selection/mixed-editability-10-expected.txt: Added.
- editing/selection/mixed-editability-10.html: Added.
- platform/mac/editing/deleting/5390681-2-expected.txt: Re-baselined
to account for the new possible caret position.
- 4:40 PM Changeset in webkit [51521] by
-
- 3 edits in trunk/WebKitTools
2009-11-30 Yuzo Fujishima <yuzo@google.com>
Reviewed by Alexey Proskuryakov.
Update pywebsocket to 0.4.2.1.
This is to fix a bug that some messages are logged to stderr even when the log file is specified.
https://bugs.webkit.org/show_bug.cgi?id=31976
- pywebsocket/mod_pywebsocket/standalone.py:
- pywebsocket/setup.py:
- 4:12 PM Changeset in webkit [51520] by
-
- 2 edits in trunk/WebCore
wx build fix, add header needed for wx build.
- 4:08 PM Changeset in webkit [51519] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from a machine that cannot run x86_64 binaries
Reviewed by David Kilzer.
The check for whether WTF_USE_PLUGIN_HOST_PROCESS is defined occurs under the native architecture of the build machine.
If that is 32-bit then WTF_USE_PLUGIN_HOST_PROCESS will not be defined. We work around this by forcing the check to
be performed against the x86_64 architecture.
- DerivedSources.make:
- 4:07 PM Changeset in webkit [51518] by
-
- 3 edits in trunk/WebKitTools
2009-11-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Generate pass messages for style-queue
https://bugs.webkit.org/show_bug.cgi?id=31995
With this change, the style-queue posts "pass" messages to bugs as
well. Also, added more information to the state store w.r.t. passing
and failing.
- Scripts/modules/commands/queues.py:
- Scripts/modules/patchcollection.py:
- 3:55 PM Changeset in webkit [51517] by
-
- 3 edits2 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
Safari caused by extreme column-gap and column-width values
-and corresponding-
<rdar://problem/7425433>
Reviewed by Oliver Hunt.
Prevent desiredColumnCount from being less than 1 since it is used
as a divisor.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
Safari caused by extreme column-gap and column-width values
-and corresponding-
<rdar://problem/7425433>
Reviewed by Oliver Hunt.
- fast/multicol/huge-column-gap-crash-expected.txt: Added.
- fast/multicol/huge-column-gap-crash.html: Added.
- 3:48 PM Changeset in webkit [51516] by
-
- 4 edits in trunk
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=31659
Connection must be closed in case of Web Socket handshake error
The network connection was closed, but the close event wasn't dispatched.
Tested by websocket/tests/handshake-error.html, which is un-skipped now.
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose): Call client didHandle() method. This looks strange in CFNetwork implementation, because it's the client that asked to close the stream, so it shouldn't need the callback. It makes more sense in cross-process implementation, because closing is async there.
- 3:45 PM UsingGitWithWebKit edited by
- (diff)
- 3:20 PM Changeset in webkit [51515] by
-
- 2 edits in trunk/WebKit/qt
2009-11-30 Abhinav Mithal <abhinav.mithal@nokia.com>
Reviewed by Simon Hausmann.
[Qt][Symbian] Report SymbianOS in user agent string for Symbian
https://bugs.webkit.org/show_bug.cgi?id=31961
- Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
- 2:10 PM Changeset in webkit [51514] by
-
- 2 edits in trunk/JavaScriptCore
Windows Build fix. Reviewed by NOBODY.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 2:02 PM Changeset in webkit [51513] by
-
- 2 edits in trunk/WebKit
Use the correct path to Info.plist to avoid creating an empty file at the top of the WebKit directory.
- WebKit.xcodeproj/project.pbxproj:
- 1:48 PM Changeset in webkit [51512] by
-
- 36 edits in trunk
Bug 31859 - Make world selection for JSC IsolatedWorlds automagical.
Reviewed by Geoff Garen.
WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.
Remove the temporary duct tape of willExecute/didExecute virtual hooks on the JSGlobalData::ClientData - these are no longer necessary.
- API/JSBase.cpp:
(JSEvaluateScript):
- API/JSObjectRef.cpp:
(JSObjectCallAsFunction):
- JavaScriptCore.exp:
- runtime/JSGlobalData.cpp:
- runtime/JSGlobalData.h:
WebCore:
WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.
Remove the last uses of mainThreadCurrentWorld(), so the world is always obtained via
currentWorld(). Switch this to obtain the world from the ExecsState's lexical global
object instead. Remove the call/construct/evaluate 'InWorld' methods, since these
are no longer necessary.
- WebCore.base.exp:
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSDOMBinding.cpp:
(WebCore::currentWorld):
(WebCore::mainThreadNormalWorld):
- bindings/js/JSDOMBinding.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::updateDocument):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
- bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):
- bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
- bindings/js/ScriptObjectQuarantine.cpp:
(WebCore::getQuarantinedScriptObject):
- bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):
- bindings/js/ScriptState.h:
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
- bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
- dom/NodeFilter.h:
(WebCore::NodeFilter::acceptNode):
- dom/NodeIterator.h:
(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
- dom/TreeWalker.h:
(WebCore::TreeWalker::parentNode):
(WebCore::TreeWalker::firstChild):
(WebCore::TreeWalker::lastChild):
(WebCore::TreeWalker::previousSibling):
(WebCore::TreeWalker::nextSibling):
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::didEvaluateForTestInFrontend):
- inspector/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):
WebKit/mac:
WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.
Since WebCore no longer needs to explicitly specify the world on entry to JSC DebuggerCallFrame::evaluate can be called directly.
- WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]):
- 1:43 PM Changeset in webkit [51511] by
-
- 4 edits6 deletes in trunk
2009-11-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
All HTML5 media element events should be regular events
https://bugs.webkit.org/show_bug.cgi?id=30513
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): (WebCore::HTMLMediaElement::noneSupported): (WebCore::HTMLMediaElement::mediaEngineError): (WebCore::HTMLMediaElement::setNetworkState): (WebCore::HTMLMediaElement::userCancelledLoad):
Call scheduleEvent instead of scheduleProgressEvent.
(WebCore::HTMLMediaElement::progressEventTimerFired):
Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement
after scheduling a 'progress' event so the controller will update download
progress indicator.
- html/HTMLMediaElement.h:
Remove scheduleProgressEvent prototype.
2009-11-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
All HTML5 media element events should be regular events
https://bugs.webkit.org/show_bug.cgi?id=30513
Remove progress event tests.
- media/progress-event-at-least-one-expected.txt: Removed.
- media/progress-event-at-least-one.html: Removed.
- media/progress-event-expected.txt: Removed.
- media/progress-event-total-expected.txt: Removed.
- media/progress-event-total.html: Removed.
- media/progress-event.html: Removed.
- 1:41 PM Changeset in webkit [51510] by
-
- 4 edits in trunk/WebKit/win
Fix double-free of BSTRs passed to WebNavigationData::createInstance
WebFrameLoaderClient::updateGlobalHistory was converting
WebCore::Strings to WebCore::BStrings, then passing them to
WebNavigationData::createInstance. But the latter function takes BSTR
parameters and adopts them into WebCore::BStrings. So the end result
was that two WebCore::BStrings would end up freeing each underlying
BSTR.
The fix is to only convert to WebCore::BString inside
WebNavigationData.
Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
(r49564): Crash in updateGlobalHistory when running Javascript iBench
test
I couldn't find a way to reproduce this in DumpRenderTree.
Reviewed by Steve Falkenburg.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
WebNavigationData::createInstance.
- WebNavigationData.cpp:
(WebNavigationData::WebNavigationData):
(WebNavigationData::createInstance):
- WebNavigationData.h:
Changed to take const WebCore::String&s instead of BSTRs and to
convert the Strings to BStrings at this level.
- 1:38 PM Changeset in webkit [51509] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
It was me who reviewed the patch, not Eric! Alas, some tools we use cause wrong reviewer information in Bugzilla.
- 1:35 PM Changeset in webkit [51508] by
-
- 3 edits in trunk/LayoutTests
2009-11-30 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
In testing handshake-error case, web_socket_do_extra_handshake calls a non-existent method
https://bugs.webkit.org/show_bug.cgi?id=31465
- platform/mac/Skipped: websocket/tests/handshake-error.html now fails on Mac, added to Skipped list, and filed bug 31659 to investigate.
- websocket/tests/handshake-error_wsh.py: Call write() on a correct object.
- 1:27 PM Changeset in webkit [51507] by
-
- 1 delete in trunk/WebKit/Info.plist
Remove file git invisibly added
- 1:19 PM Changeset in webkit [51506] by
-
- 9 edits1 add in trunk
2009-11-30 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Wrong console output for Regexp escape sequence
https://bugs.webkit.org/show_bug.cgi?id=31538
Updated inspector/console-format.html
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createDividerElement): style issues. (WebInspector.ConsoleView.createFilterElement): style issues. (WebInspector.ConsoleView): added _customFormatters table. (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses. (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues. (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic. (WebInspector.ConsoleView.prototype._formatobject): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._printArray): (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts. (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting. (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting. (WebInspector.ConsoleCommandResult):
- inspector/front-end/InjectedScript.js: simplified regex formatting.
- inspector/front-end/inspector.js: (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
- inspector/front-end/utilities.js: (Element.prototype.hasStyleClass): update inaccurate comment. (String.prototype.trimURL): converted new RegExp to literal for performance benefits.
- 12:42 PM Changeset in webkit [51505] by
-
- 3 edits in trunk/JavaScriptCore
2009-11-30 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove obsolete PLATFORM(KDE) code
https://bugs.webkit.org/show_bug.cgi?id=31958
KDE is now using unpatched QtWebKit.
- parser/Lexer.cpp: Remove obsolete KDE_USE_FINAL guard
- wtf/Platform.h: Remove PLATFORM(KDE) definition and code section that is guarded with it.
- 11:55 AM Changeset in webkit [51504] by
-
- 2 edits in trunk/LayoutTests
Skipping test that fails because of broken DND, and some tests
requiring new results.
- platform/gtk/Skipped:
- 11:31 AM Changeset in webkit [51503] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.17
Tagging 1.1.17.
- 11:27 AM Changeset in webkit [51502] by
-
- 2 edits in trunk
Rubber-stamped by Xan Lopez.
Make sure we distribute and install GObject Introspection files.
- GNUmakefile.am:
- 10:59 AM Changeset in webkit [51501] by
-
- 3 edits in trunk/WebCore
2009-11-30 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
https://bugs.webkit.org/show_bug.cgi?id=31895
No new tests. This is already covered by:
fast/dom/CSSStyleDeclaration/css-computed-style-item.html
fast/dom/CSSStyleDeclaration/css-style-item.html
- bindings/v8/V8Collection.h: (WebCore::collectionStringIndexedPropertyGetter): (WebCore::setCollectionStringIndexedGetter):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
- 10:50 AM Changeset in webkit [51500] by
-
- 2 edits in trunk/WebKit/win
WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
https://bugs.webkit.org/show_bug.cgi?id=31986
Reviewed by Adam Roben.
- WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.
- 10:36 AM QtBackLog edited by
- The first set of network changes landed, mark the item as completed. (diff)
- 9:54 AM Changeset in webkit [51499] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Simon Fraser.
Check for WEBKIT_TESTFONTS environment variable in
run-webkit-tests, for GTK+, to have a more prominent error
message.
- Scripts/run-webkit-tests:
- 9:41 AM Changeset in webkit [51498] by
-
- 2 edits in trunk/WebCore
2009-11-30 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Adds include of wtf/StdLibExtras.h for DEFINE_STATIC_LOCAL in V8 ScriptController.
https://bugs.webkit.org/show_bug.cgi?id=31932
Build fix only, no new tests.
- bindings/v8/ScriptController.cpp: Modified. Adds include of wtf/StdLibExtras.h.
- 9:34 AM Changeset in webkit [51497] by
-
- 2 edits in trunk/WebCore
2009-11-30 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Adds PassOwnPtr include to ScriptExecutionContext.h.
https://bugs.webkit.org/show_bug.cgi?id=31929
Build fix only, no new tests.
- dom/ScriptExecutionContext.h: Modified. Adds PassOwnPtr include.
- 9:25 AM Changeset in webkit [51496] by
-
- 3 edits4 adds in trunk
2009-11-30 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Complex test of mask with every combination of maskUnits and maskContentUnits
as well as different values for size and position of the mask and it's content.
- platform/mac/svg/custom/mask-with-all-units-expected.checksum: Added.
- platform/mac/svg/custom/mask-with-all-units-expected.png: Added.
- platform/mac/svg/custom/mask-with-all-units-expected.txt: Added.
- svg/custom/mask-with-all-units.svg: Added.
2009-11-30 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=31980
It turns out, that we did not handle maskUnits="userSpaceOnUse"
correctly. We just need to move the context of the maskImage
if maskContentUnits="objectBoundingBox". The context gets scaled
on this unit combination, so we have to substract the position of
the targetRect. On userSpaceOnUse the position just depends on the
position of the mask element.
I added a test with some senseless and reasonable values for size
and postion of the mask and it's contents. I also used every
combination of maskUnits and maskContentUnits to be sure, that it
is fixed this time.
Test: svg/custom/mask-with-all-units.svg
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- 9:17 AM Changeset in webkit [51495] by
-
- 2 edits in trunk/WebCore
2009-11-30 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=31928
Build fix only, no new tests.
- page/DOMWindow.cpp: Modified. Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
- 9:10 AM Changeset in webkit [51494] by
-
- 2 edits in trunk/WebKitTools
2009-11-30 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
update-webkit --chromium forces gclient sync
- Scripts/update-webkit-chromium:
- 9:03 AM Changeset in webkit [51493] by
-
- 2 edits in trunk/WebCore
2009-11-30 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Adds SHARED_WORKERS guards to V8 WorkerContextExecutionProxy.
https://bugs.webkit.org/show_bug.cgi?id=31926
Build fix only, no new tests.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::convertToV8Object): (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
- 8:56 AM Changeset in webkit [51492] by
-
- 2 edits in trunk/WebCore
2009-11-30 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Chrome::contentsSizeChanged() is called when the content size has not changed
https://bugs.webkit.org/show_bug.cgi?id=31978
Do not trigger contentsSizeChaned() is the new size is the same as the old one.
- page/FrameView.cpp: (WebCore::FrameView::setContentsSize):
- 8:49 AM Changeset in webkit [51491] by
-
- 2 edits in trunk/WebKit/qt
2009-11-30 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix minor waning in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=31963
- tests/qwebpage/tst_qwebpage.cpp: (ErrorPage::extension): Remove info wariable as it is not used.
- 8:42 AM Changeset in webkit [51490] by
-
- 4 edits in trunk/WebCore
2009-11-30 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix some compiler warnings seen on QtWebKit/Mac
https://bugs.webkit.org/show_bug.cgi?id=31962
No new tests as there is no functional change.
- platform/network/ResourceHandle.h: Make destructor virtual as after r50772 ResourceHandle has virtual functions.
- plugins/mac/PluginPackageMac.cpp: (WebCore::PluginPackage::fetchInfo): Fix typo WTF is a namespace not a label
- plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::setNPWindowIfNeeded): Add l to the format specifier
- 7:36 AM QtWebKitJournal edited by
- (diff)
- 7:31 AM Changeset in webkit [51489] by
-
- 4 edits in trunk
Versioning.
- 7:30 AM QtWebKitJournal edited by
- (diff)
- 7:30 AM Changeset in webkit [51488] by
-
- 1 copy in tags/Safari-532.5
New tag.
- 7:13 AM Changeset in webkit [51487] by
-
- 2 edits in trunk
Build fix. Make sure JSCore-1.0.gir is added to the distributed
tarball.
- 7:09 AM QtWebKitJournal edited by
- (diff)
- 7:00 AM QtWebKitJournal edited by
- (diff)
- 5:53 AM Changeset in webkit [51486] by
-
- 9 edits in trunk
2009-11-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump versions for 1.1.17 release.
- configure.ac:
WebCore:
2009-11-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Add new headers to sources list.
- GNUmakefile.am:
WebKit/gtk:
2009-11-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Prepare for 1.1.17 release.
- NEWS:
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
- 4:08 AM Changeset in webkit [51485] by
-
- 2 edits in trunk/WebCore
[Qt] Mac Plugins : Get context menu to work in QGraphicsView
Reviewed by Holger Freyther.
Flash expects the value in record.where to be the global position for
displaying the context menu.
- 3:27 AM Changeset in webkit [51484] by
-
- 4 edits in trunk
[Qt] Fix compilation with win32-icc
Patch by Jan-Arve Sæther <jan-arve.saether@nokia.com> on 2009-11-30
Reviewed by Simon Hausmann.
.:
Include os-win32 for stdint.h since MS does not ship that in their PSDK.
- WebKit.pri:
The Intel compiler does not support the has_trivial_constructor type
trait. The Intel Compiler can report itself as _MSC_VER >= 1400. The
reason for that is that the Intel Compiler depends on the Microsoft
Platform SDK, and in order to try to be "fully" MS compatible it will
"pretend" to be the same MS compiler as was shipped with the MS PSDK.
(Thus, compiling with win32-icc with VC8 SDK will make the source code
"think" the compiler at hand supports this type trait).
- wtf/TypeTraits.h:
- 2:39 AM Changeset in webkit [51483] by
-
- 2 edits in trunk/WebCore
Adds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController.
https://bugs.webkit.org/show_bug.cgi?id=31925
Reviewed by Eric Seidel.
This code uses ChromiumBridge and Chromium-specific constant values not
appropriate for other platforms such as Android.
Build fix only, no new tests.
- bindings/v8/V8GCController.cpp: Modified. Adds PLATFORM(CHROMIUM) around Chromium-specific code.
- 1:41 AM Changeset in webkit [51482] by
-
- 2 edits in trunk/LayoutTests
[Qt] Put tests into skiplist because of missing features.
- platform/qt/Skipped:
- fast/dom/Window/window-postmessage-clone.html added
- inspector/elements-img-tooltip.html added.
- 12:58 AM QtWebKitBackportingFixes edited by
- (diff)
