⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 2, 2009:

11:27 PM Changeset in webkit [51626] by eric@webkit.org
  • 4 edits
    2 adds
    8 deletes in trunk/LayoutTests

2009-12-02 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Rewrite two tests with dumpAsText
​https://bugs.webkit.org/show_bug.cgi?id=32014

  • fast/block/positioning/complex-percentage-height-expected.txt: Added.
  • fast/block/positioning/complex-percentage-height.html:
  • fast/lists/item-not-in-list-line-wrapping-expected.txt: Added.
  • fast/lists/item-not-in-list-line-wrapping.html:
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum: Removed.
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.png: Removed.
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.txt: Removed.
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum: Removed.
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png: Removed.
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed.
  • platform/qt/Skipped:
  • platform/qt/fast/block/positioning/complex-percentage-height-expected.txt: Removed.
  • platform/qt/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed.
10:46 PM Changeset in webkit [51625] by oliver@apple.com
  • 1 edit
    2 adds in trunk/JavaScriptCore

Add files missed in prior patch.

Reviewed by Gavin Barraclough.

10:25 PM Changeset in webkit [51624] by oliver@apple.com
  • 9 edits in trunk/JavaScriptCore

Add zombies to JSC
​https://bugs.webkit.org/show_bug.cgi?id=32103

Reviewed by Gavin Barraclough.

Add a compile time flag to make the JSC collector replace "unreachable"
objects with zombie objects. The zombie object is a JSCell subclass that
ASSERTs on any attempt to use the JSCell methods. In addition there are
a number of additional assertions in bottleneck code to catch zombie usage
as quickly as possible.

Grrr. Argh. Brains.

10:14 PM Changeset in webkit [51623] by eric@webkit.org
  • 9 edits
    2 adds in trunk

2009-12-02 Yusuke Sato <​yusukes@chromium.org>

Reviewed by Eric Seidel.

Sanitize web fonts using the OTS library
​https://bugs.webkit.org/show_bug.cgi?id=31106

Add support for OpenType sanitizer (OTS). It parses OpenType files (from @font-face)
and attempts to validate and sanitize them. We hope this reduces the attack surface
of the system font libraries.

  • WebCore.gyp/WebCore.gyp: Added dependency to (chromium_src_dir)/third_party/ots/ library.
  • WebCore.gypi: Added new files below.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/chromium/FontCustomPlatformData.cpp: Validate and transcode a web font. (WebCore::createFontCustomPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.cpp: Ditto. (WebCore::createFontCustomPlatformData):
  • platform/graphics/opentype/OpenTypeSanitizer.cpp: Added. (WebCore::OpenTypeSanitizer::sanitize):
  • platform/graphics/opentype/OpenTypeSanitizer.h: Added. (WebCore::OpenTypeSanitizer::OpenTypeSanitizer):

2009-12-02 Yusuke Sato <​yusukes@chromium.org>

Reviewed by Eric Seidel.

Sanitize web fonts using the OTS library
​https://bugs.webkit.org/show_bug.cgi?id=31106

  • DEPS: Added dependency to the OpenType sanitizer library.
  • features.gypi: Added ENABLE_OPENTYPE_SANITIZER=1.
9:31 PM Changeset in webkit [51622] by eric@webkit.org
  • 5 edits
    1 add in trunk/WebKitTools

2009-12-02 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(51595): commit-queue is throwing exceptions
​https://bugs.webkit.org/show_bug.cgi?id=32083

  • Scripts/modules/commands/queues.py:
    • Don't use default value of [] as it ends up getting shared.
    • Make log_progress accept arrays of ints as well as strings.
    • Return an exit code from execute()
  • Scripts/modules/commands/queues_unittest.py: Added.
    • Test to make sure log_progress will accept ints.
    • Test to make sure run_bugzilla_tool will accept ints.
  • Scripts/modules/workqueue.py:
    • Print the stack trace on unexpected exceptions for easier debugging.
  • Scripts/run-webkit-unittests:
    • Add queues_unittest.
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
  • Scripts/modules/mock_bugzillatool.py:
  • Scripts/modules/workqueue.py:
  • Scripts/run-webkit-unittests:
9:20 PM Changeset in webkit [51621] by oliver@apple.com
  • 5 edits in trunk/WebCore

Web Inspector frontend heap allocates ScriptFunctionCall which is unsafe
​https://bugs.webkit.org/show_bug.cgi?id=32098

Reviewed by Sam Weinig.

Fix is simply to make the ScriptFunctionCall stack allocated as nature intended
Doing this required adding an appendArgument(char*) to ScriptFunctionCall so
that an explicit String cast would not be necessary.

To prevent something like this happening again in future i've added private
operator new implementations to ScriptFunctionCall making this type of mistake
produce errors when compiling.

Test case: Inspector tests now pass with GC on every alloc enabled.

9:10 PM Changeset in webkit [51620] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Fix a mistake in the previous change

Reviewed by Mark Rowe.

  • WebView/WebView.mm:

(+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
Make sure to include the image types’ view and representation classes
even when plug-ins are not allowed.

9:08 PM Changeset in webkit [51619] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-02 David Levin <​levin@chromium.org>

Reviewed by Adam Barth.

check-webkit-style is too noisy about namespace indenting issues.
​https://bugs.webkit.org/show_bug.cgi?id=32096

  • Scripts/modules/cpp_style.py: Added a _FileState object to be able to track file level information. In this case, it simply tracks whether the error has already been given, so that it isn't done again.
  • Scripts/modules/cpp_style_unittest.py: Modified test cases to pass in the _FileState object and fix a test that expected to see the namespace error twice (now it only occurs once). No new tests because existing tests cover the change in functionality.
4:38 PM Changeset in webkit [51618] by kevino@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

Reviewed by Eric Seidel.

[wx] Get DumpRenderTree building after waf switch.

​https://bugs.webkit.org/show_bug.cgi?id=32041

4:22 PM Changeset in webkit [51617] by mitz@apple.com
  • 8 edits in trunk/WebKit/mac

Fixed <rdar://problem/7254127> WebKit can load plug-ins even when
plug-ins are disabled

Reviewed by Anders Carlsson.

Ensure that the shared WebPluginDatabase is not instantiated if no
WebViews are used that have plug-ins enabled.

  • DefaultDelegates/WebDefaultPolicyDelegate.m:

(-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
Call -[WebView _canShowMIMEType:] on the WebView instead of calling the
class method.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::canShowMIMEType): Ditto.
(WebFrameLoaderClient::transitionToCommittedForNewPage): Call
-[WebFrameView _viewClassForMIMEType:] on the WebView instead of calling
the class method.
(WebFrameLoaderClient::objectContentType): Ditto.

  • WebView/WebDataSource.mm:

(+[WebDataSource _representationClassForMIMEType:allowingPlugins:]):
Added the allowPlugins parameter, which is passed through to
+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:].
(-[WebDataSource _makeRepresentation]): Pass an allowPlugins value
based on the WebView’s preferences.

  • WebView/WebFrameView.mm:

(-[WebFrameView _makeDocumentViewForDataSource:]): Call
-[WebFrameView _viewClassForMIMEType:] instead of calling the class
method.
(+[WebFrameView _viewClassForMIMEType:allowingPlugins:]): Added the
allowPlugins parameter, which is passed through to
+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:].
(-[WebFrameView _viewClassForMIMEType:]): Added. Passes an allowPlugins
value based on the WebView’s preferences.

  • WebView/WebFrameViewInternal.h:
  • WebView/WebView.mm:

(+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
Added the allowPlugins parameter. If false, skip the instantiation of
the shared WebPluginDatabase.
(-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Pass an
allowPlugins value based on the WebView’s preferences.
(+[WebView _canShowMIMEType:allowingPlugins:]): Passes allowPlugins to
+_viewClass:andRepresentationClass:forMIMEType:allowingPlugins:.
(+[WebView canShowMIMEType:]): Changed to pass YES to
+_canShowMIMEType:allowingPlugins:.
(-[WebView _canShowMIMEType:]): Added. Passes an allowPlugins value
based on the WebView’s preferences.
(-[WebView _pluginForMIMEType:]): Return nil if plug-ins are disabled.
(-[WebView _pluginForExtension:]): Ditto.
(-[WebView _isMIMETypeRegisteredAsPlugin:]): Return NO if plug-ins are
disabled.

  • WebView/WebViewInternal.h:
3:39 PM Changeset in webkit [51616] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Fixes a crash when scrolling a frame that goes away mid-scroll.

<rdar://problem/7400263>

Reviewed by John Sullivan.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]): Retain self incase the last
reference is released when calling super.

3:25 PM Changeset in webkit [51615] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=32089
Test that WebSocket.readyState is set correctly

  • websocket/tests/script-tests/simple.js: (ws.onopen): (ws.onmessage): (ws.onclose):
  • websocket/tests/simple-expected.txt: Added readyState logging.
3:21 PM Changeset in webkit [51614] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-12-02 Evan Stade <​estade@chromium.org>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=32029
Mousewheel event delta has reversed sign on Linux Chrome.

No new tests (layout tests don't cover event conversion code).
Manual test: ​http://www.switchonthecode.com/tutorials/javascript-tutorial-the-scroll-wheel

  • src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::mouseWheelEvent):
1:36 PM Changeset in webkit [51613] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Make change-values-during-transition less flaky. Transition is 1 sec duration,
translating 100px, starting at 0, so it should be at 50px at 500ms, not 600ms.

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31997

  • transitions/change-values-during-transition.html:

isEqual: Remove unnecessary code - tolerance always passed in and always default value.
getXPosition: Extract into a function, since it is duplicated twice.
check2: Still run second check if the first fails, just give more debugging output.
start: Remove final setTimeout - nothing changes between the end of check2 and here,

so this is just making the test take 100ms longer.

1:24 PM Changeset in webkit [51612] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to fix the Safari build.

1:10 PM Changeset in webkit [51611] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Skip http/tests/cache/subresource-failover-to-network.html because it
is flaky on Windows, fixing it is being tracked by
​https://bugs.webkit.org/show_bug.cgi?id=32038.

  • platform/win/Skipped:
11:47 AM Changeset in webkit [51610] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Put tests into skiplist because of missing layoutTestController.evaluateInWebInspector().

  • platform/qt/Skipped:
  • inspector/elements-panel-selection-on-refresh.html added.
  • inspector/timeline-event-dispatch.html added.
11:34 AM Changeset in webkit [51609] by timothy@apple.com
  • 1 edit in trunk/WebKit/win/DOMHTMLClasses.h

Build fix.

11:27 AM Changeset in webkit [51608] by hyatt@apple.com
  • 7 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=32072, clean up invalid @-rule error handling so that we
pass more CSS test suite stuff. Make the grammar stop enforcing the ordering of @namespace vs.
@variables vs. @import. Just let the parser handle that instead. This simplifies the grammar and
makes error handling deal with more cases correctly.

Reviewed by Darin Adler.

Added fast/css/namespaces/namespaces-invalid-at-rules.xml

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::createCharsetRule):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::addNamespace):
(WebCore::CSSParser::createVariablesRule):

  • css/CSSParser.h:
11:24 AM Changeset in webkit [51607] by timothy@apple.com
  • 2 edits in trunk/WebKit/win

Move setValueForUser to the end of the DOMHTMLInputElement interface
so it is fine for binary compatibility.

Directed by Steve Falkenburg.

  • Interfaces/DOMHTML.idl:
11:21 AM Changeset in webkit [51606] by timothy@apple.com
  • 3 edits in trunk/WebKit/win

Expose setValueForUser for the COM DOMHTMLInputElement.

<rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::setValueForUser):

  • Interfaces/DOMHTML.idl:
11:17 AM Changeset in webkit [51605] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-02 Yusuke Sato <​yusukes@chromium.org>

Reviewed by Dan Bernstein.

Safari/Chromium for Windows fails to load CJK WebFonts
​https://bugs.webkit.org/show_bug.cgi?id=31804

  • platform/graphics/opentype/OpenTypeUtilities.cpp: (WebCore::renameAndActivateFont): Load a remote font even if the font has 2 or more faces.
11:10 AM Changeset in webkit [51604] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-12-02 Eric Z. Ayers <​zundel@google.com>

Reviewed by Pavel Feldman.

Adds a timeline test for EventDispatch records.

​https://bugs.webkit.org/show_bug.cgi?id=31376

  • inspector/timeline-event-dispatch-expected.txt: Added.
  • inspector/timeline-event-dispatch.html: Added.
11:03 AM Changeset in webkit [51603] by eric@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2009-12-02 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Fisher.

Chromium: Need tickmarks in scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=32069

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ScrollbarThemeChromiumMac.h: Added.
  • platform/chromium/ScrollbarThemeChromiumMac.mm: Added.
10:34 AM Changeset in webkit [51602] by timothy@apple.com
  • 10 edits in trunk

WebCore: Expose a function to set the value of an input element on behalf of the user.
This function will dispatch the change event so the page is notified when autofill
happens. Also dispatch a change event when a select element is changed by autofill.

<rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Added the DOMHTMLInputElementPrivate.h header.
  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLSelectElement _activateItemAtIndex:]): Call setSelectedIndexByUser instead so
a change event is fired. This method is called by Safari autofill.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode): Use dispatchFormControlChangeEvent instead
of dispatching the change event directly to be consistent.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLInputElement::setValueForUser): Added. Calls setValue with the sendChangeEvent
(WebCore::HTMLInputElement::setValue): Added the optional sendChangeEvent argument. Mimics setChecked.

  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl: Added setValueForUser for non-JS languages.
  • html/InputElement.h: Added setValueForUser.

WebKit/mac: Migrate DOMHTMLInputElementPrivate.h as a private header.

Reviewed by Darin Adler.

  • MigrateHeaders.make:
10:32 AM Changeset in webkit [51601] by pfeldman@chromium.org
  • 12 edits
    2 adds in trunk

2009-12-02 Pavel Feldman <​pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

Reviewed by Timothy Hatcher.

Web Inspector: DOM tree selection disappears upon page refresh.

​https://bugs.webkit.org/show_bug.cgi?id=31142

Test: inspector/elements-panel-selection-on-refresh.html

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodeByPathToFrontend):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent): (WebCore::InspectorController::resetScriptObjects):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::reset): (WebCore::InspectorDOMAgent::setDocument): (WebCore::InspectorDOMAgent::pushDocumentToFrontend): (WebCore::InspectorDOMAgent::nodeForPath): (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._setDocument):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.setDocument.selectDefaultNode): (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/InjectedScript.js: (InjectedScript.pushNodeByPathToFrontend):
  • inspector/front-end/InjectedScriptAccess.js:
7:33 AM Changeset in webkit [51600] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=32045, make sure escape sequences work with
all the @-rules we support. When escape sequences are present, the lexical scanner
just returns a generic token name: ATKEYWORD. We have to process the escape sequences
and then recheck against the rules we support with the final processed name. If we
find a match, we mutate the token value to the appropriate rule name token, e.g.,
NAMESPACE_SYM.

Reviewed by Dan Bernstein.

Added fast/css/namespaces/namespaces-escapes.xml

  • css/CSSParser.cpp:

(WebCore::CSSParser::lex):
(WebCore::CSSParser::recheckAtKeyword):
(WebCore::CSSParser::text):

  • css/CSSParser.h:
6:52 AM Changeset in webkit [51599] by eric@webkit.org
  • 5 edits in trunk

2009-12-02 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.:w

Allow to skip thread checks when accessing DOMDataStore for processes
which run V8 in single thread mode.
​https://bugs.webkit.org/show_bug.cgi?id=31877

Should be covered by buildbots.

  • bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::enableFasterDOMStoreAccess): (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap):
  • bindings/v8/V8DOMMap.h:

2009-12-02 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

Allow to skip thread checks when accessing DOMDataStore for processes
which run V8 in single thread mode.
​https://bugs.webkit.org/show_bug.cgi?id=31877

  • src/WebScriptController.cpp: (WebKit::WebScriptController::enableV8SingleThreadMode):
5:12 AM Changeset in webkit [51598] by yurys@chromium.org
  • 15 edits
    4 deletes in trunk/WebCore

2009-12-02 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Code clean up: remove ScriptObjectQuarantine.* as a whole.

​https://bugs.webkit.org/show_bug.cgi?id=32060

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/ScriptObjectQuarantine.cpp: Removed.
  • bindings/js/ScriptObjectQuarantine.h: Removed.
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::quarantineValue):
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptObjectQuarantine.cpp: Removed.
  • bindings/v8/ScriptObjectQuarantine.h: Removed.
  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::quarantineValue):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/InspectorController.cpp:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorFrontend.cpp:
4:55 AM Changeset in webkit [51597] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] r51577 made fast/frames/sandboxed-iframe-plugins.html crash.

  • platform/qt/Skipped:
  • fast/frames/sandboxed-iframe-navigation-windowopen.html added. (crasher)
2:51 AM Changeset in webkit [51596] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] build-attachment shouldn't check whether the builders are red
​https://bugs.webkit.org/show_bug.cgi?id=32062

build-attachment doesn't touch the remote repository, so there isn't a
need to hold off when the builders are red.

  • Scripts/modules/commands/download.py:
  • Scripts/modules/landingsequence.py:
2:44 AM Changeset in webkit [51595] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-02 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(51590): style-queue and build-queue think their empty when they are not
​https://bugs.webkit.org/show_bug.cgi?id=32061

  • Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
  • Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
2:18 AM Changeset in webkit [51594] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed. Skip new tests.

  • platform/qt/Skipped:
  • svg/custom/mask-with-all-units.svg added.
  • fast/css/namespaces/namespaces-comments.xml added.
  • fast/css/namespaces/namespaces-empty.xml added.
1:59 AM Writing Layout Tests for DumpRenderTree edited by skylined@chromium.org
Document setCanOpenWindows (based on an example I found, not actual … (diff)
1:43 AM Changeset in webkit [51593] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-02 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

build-queue is throwing exceptions and complaining about
lack of --no-update on build-attachment. Make it stop.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
1:15 AM Changeset in webkit [51592] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-02 Adam Barth <​abarth@webkit.org>

Unreviewed "build" fix. Forgot to declare my variables. :(

  • QueueStatusServer/queue_status.py:
1:11 AM Changeset in webkit [51591] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2009-12-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Implement status bubble view
​https://bugs.webkit.org/show_bug.cgi?id=32057

The status bubble is a compact representation of the queue status for a
given patch. This will eventually help us reduce the comment spam from
the queues.

  • QueueStatusServer/index.html: Added HTML5 doctype for sanity.
  • QueueStatusServer/queue_status.py:
  • QueueStatusServer/status_bubble.html: Added.
1:04 AM Changeset in webkit [51590] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2009-12-02 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

trim commands/*.py includes now that commands are unit tested
​https://bugs.webkit.org/show_bug.cgi?id=32056

In the course of ensuring that the unit tests still
passed after this change, I had to actually make them
pass in the first place.

  • Scripts/modules/bugzilla.py:
    • Fix _parse_attachment_ids_request_query to return ints instead of strings.
  • Scripts/modules/commands/download.py: Remove unneeded imports.
  • Scripts/modules/commands/queries.py: Ditto.
  • Scripts/modules/commands/queues.py: Ditto.
  • Scripts/modules/commands/upload.py: Ditto.
  • Scripts/modules/scm_unittest.py:
    • Fix to expect the \n after the path since echo adds an \n.
12:19 AM Changeset in webkit [51589] by ukai@chromium.org
  • 4 edits
    17 adds in trunk

2009-12-02 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket handshake check query component of URL
​https://bugs.webkit.org/show_bug.cgi?id=31617

  • websocket/tests/echo-location_wsh.py: Added.
  • websocket/tests/no-query_wsh.py: Added.
  • websocket/tests/script-tests/url-with-credential.js: Added.
  • websocket/tests/script-tests/url-with-empty-query.js: Added.
  • websocket/tests/script-tests/url-with-fragment.js: Added.
  • websocket/tests/script-tests/url-with-query-for-no-query.js: Added.
  • websocket/tests/script-tests/url-with-query.js: Added.
  • websocket/tests/url-with-credential-expected.txt: Added.
  • websocket/tests/url-with-credential.html: Added.
  • websocket/tests/url-with-empty-query-expected.txt: Added.
  • websocket/tests/url-with-empty-query.html: Added.
  • websocket/tests/url-with-fragment-expected.txt: Added.
  • websocket/tests/url-with-fragment.html: Added.
  • websocket/tests/url-with-query-expected.txt: Added.
  • websocket/tests/url-with-query-for-no-query-expected.txt: Added.
  • websocket/tests/url-with-query-for-no-query.html: Added.
  • websocket/tests/url-with-query.html: Added.

2009-12-02 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket handshake check query component of URL
​https://bugs.webkit.org/show_bug.cgi?id=31617

Tests: websocket/tests/url-with-credential.html

websocket/tests/url-with-empty-query.html
websocket/tests/url-with-fragment.html
websocket/tests/url-with-query-for-no-query.html
websocket/tests/url-with-query.html

  • platform/KURLGoogle.cpp: (WebCore::KURL::query): returns a null if query is not specified and returns an empty if query is specified but empty.
  • websockets/WebSocketHandshake.cpp: (WebCore::resourceName): added. add query component to path if specified. (WebCore::WebSocketHandshake::clientLocation): (WebCore::WebSocketHandshake::clientHandshakeMessage):

Dec 1, 2009:

10:26 PM Changeset in webkit [51588] by levin@chromium.org
  • 2 edits in trunk/WebCore

Incorrect code in WebGLRenderingContext.cpp
​https://bugs.webkit.org/show_bug.cgi?id=32046

Reviewed by Eric Seidel.

Fix incorrect code that happened to work. != has higher precendence than &.
The simplest fix is to remove the "!= 0" which violates WebKit style
guidelines anyway.

Also added periods to few comments in the same function.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateIndexArray):

9:51 PM Changeset in webkit [51587] by eric@webkit.org
  • 4 edits in trunk/WebKitSite

2009-12-01 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Darin Adler.

Added clarifications to the web site regarding coding style and
code cleanup--

​https://bugs.webkit.org/show_bug.cgi?id=31618

Changes include the following:

  • Expanded the style guidelines regarding "using" statements.
  • Made the style guidelines page validate as HTML.
  • Added that legacy WebKit components should not be cleaned up.
  • Added that it is more acceptable to update style when already touching code.
  • coding/coding-style.html:
  • coding/contributing.html:
  • projects/cleanup/index.html:
9:50 PM Changeset in webkit [51586] by hamaji@chromium.org
  • 5 edits in trunk/LayoutTests

2009-12-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Update expectations of css2.1/t1205-c56* for Qt
​https://bugs.webkit.org/show_bug.cgi?id=32015

  • platform/qt/Skipped:
  • platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
9:44 PM Changeset in webkit [51585] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-01 Yaar Schnitman <​yaar@chromium.org>

build-webkit: Remove flex,bison,gperf check for chromium
​https://bugs.webkit.org/show_bug.cgi?id=32043

  • Scripts/webkitdirs.pm:
9:17 PM Changeset in webkit [51584] by eric@webkit.org
  • 7 edits
    3 adds in trunk

2009-12-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
pattern and step attributes of HTMLInputElement.
​https://bugs.webkit.org/show_bug.cgi?id=31708

  • fast/forms/input-minmax-expected.txt:
  • fast/forms/input-pattern-expected.txt: Added.
  • fast/forms/input-pattern.html: Added.
  • fast/forms/input-step-expected.txt:
  • fast/forms/script-tests/input-minmax.js: Add tests for null/undefined/non-string.
  • fast/forms/script-tests/input-pattern.js: Added.
  • fast/forms/script-tests/input-step.js: Change the result for null.

2009-12-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
pattern and step attributes of HTMLInputElement.
​https://bugs.webkit.org/show_bug.cgi?id=31708

  • html/HTMLInputElement.idl:
8:54 PM Changeset in webkit [51583] by Chris Fleizach
  • 3 edits in trunk/WebKitTools

Build fixage for Windows/GTK for DumpRenderTree.

WAI-ARIA: implement support for ARIA drag and drop
​https://bugs.webkit.org/show_bug.cgi?id=32007

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):

8:40 PM Changeset in webkit [51582] by Chris Fleizach
  • 11 edits
    2 adds in trunk

WAI-ARIA: implement support for ARIA drag and drop
​https://bugs.webkit.org/show_bug.cgi?id=32007

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/aria-drag-drop.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::supportsARIADropping):
(WebCore::AccessibilityObject::supportsARIADragging):
(WebCore::AccessibilityObject::isARIAGrabbed):
(WebCore::AccessibilityObject::setARIAGrabbed):
(WebCore::AccessibilityObject::determineARIADropEffects):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::supportsARIADropping):
(WebCore::AccessibilityRenderObject::supportsARIADragging):
(WebCore::AccessibilityRenderObject::isARIAGrabbed):
(WebCore::AccessibilityRenderObject::setARIAGrabbed):
(WebCore::AccessibilityRenderObject::determineARIADropEffects):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

  • html/HTMLAttributeNames.in:

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getARIADropEffectsCallback):
(getARIAIsGrabbedCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):

LayoutTests:

  • platform/mac/accessibility/aria-drag-drop-expected.txt: Added.
  • platform/mac/accessibility/aria-drag-drop.html: Added.
7:49 PM Changeset in webkit [51581] by abarth@webkit.org
  • 1 edit in trunk/WebCore/bindings/v8/ScriptController.cpp

Typo fix.

7:44 PM Changeset in webkit [51580] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-12-01 Adam Barth <​abarth@webkit.org>

​https://bugs.webkit.org/show_bug.cgi?id=21288

Unreviewed port of @sandbox to V8.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow):
7:28 PM Changeset in webkit [51579] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=21288

Reviewed by Darin Adler.

Add sneaky test that has tabs.

  • fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
  • fast/frames/sandboxed-iframe-attribute-parsing.html: Added.
7:02 PM Changeset in webkit [51578] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/loader/FrameLoaderTypes.h

Change unsigned to int to fix the Windows build.

6:40 PM Changeset in webkit [51577] by abarth@webkit.org
  • 23 edits
    55 adds in trunk

2009-12-01 Patrik Persson <​patrik.j.persson@ericsson.com>

Reviewed by Darin Adler.

Implement HTML5 sandbox attribute for iframes.
​http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
​https://bugs.webkit.org/show_bug.cgi?id=21288

  • fast/frames/resources/non-sandboxed-iframe-navigation.html: Added.
  • fast/frames/resources/sandboxed-iframe-attribute-parsing-allowed.html: Added.
  • fast/frames/resources/sandboxed-iframe-attribute-parsing-disallowed.html: Added.
  • fast/frames/resources/sandboxed-iframe-form-allowed.html: Added.
  • fast/frames/resources/sandboxed-iframe-form-disallowed.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigated.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigation-child.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigation-navigated.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigation-parent.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigation-source.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigation-targetlink.html: Added.
  • fast/frames/resources/sandboxed-iframe-navigation-windowopen.html: Added.
  • fast/frames/resources/sandboxed-iframe-plugins-frame-applet.html: Added.
  • fast/frames/resources/sandboxed-iframe-plugins-frame-embed.html: Added.
  • fast/frames/resources/sandboxed-iframe-plugins-frame-object.html: Added.
  • fast/frames/resources/sandboxed-iframe-script-dynamic.html: Added.
  • fast/frames/resources/sandboxed-iframe-storage-allowed.html: Added.
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html: Added.
  • fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
  • fast/frames/sandboxed-iframe-attribute-parsing.html: Added.
  • fast/frames/sandboxed-iframe-forms-expected.txt: Added.
  • fast/frames/sandboxed-iframe-forms.html: Added.
  • fast/frames/sandboxed-iframe-navigation-allowed-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-allowed.html: Added.
  • fast/frames/sandboxed-iframe-navigation-parent-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-parent.html: Added.
  • fast/frames/sandboxed-iframe-navigation-targetlink-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-targetlink.html: Added.
  • fast/frames/sandboxed-iframe-navigation-windowopen-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-windowopen.html: Added.
  • fast/frames/sandboxed-iframe-plugins-expected.txt: Added.
  • fast/frames/sandboxed-iframe-plugins.html: Added.
  • fast/frames/sandboxed-iframe-scripting-expected.txt: Added.
  • fast/frames/sandboxed-iframe-scripting.html: Added.
  • fast/frames/sandboxed-iframe-storage-expected.txt: Added.
  • fast/frames/sandboxed-iframe-storage.html: Added.
  • http/tests/security/resources/sandboxed-iframe-document-cookie-read-denied.html: Added.
  • http/tests/security/resources/sandboxed-iframe-modify-self.html: Added.
  • http/tests/security/resources/xss-DENIED-sandboxed-iframe-attacker.html: Added.
  • http/tests/security/sandboxed-iframe-document-cookie-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-document-cookie.html: Added.
  • http/tests/security/sandboxed-iframe-modify-self-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-modify-self.html: Added.
  • http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt: Added.
  • http/tests/security/xss-DENIED-sandboxed-iframe.html: Added.
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html: Added.
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html: Added.
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-iframe.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow.cgi: Added.
  • http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-iframe.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard-iframe.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard.cgi: Added.
  • http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied.cgi: Added.

2009-12-01 Patrik Persson <​patrik.j.persson@ericsson.com>

Reviewed by Darin Adler.

Implement HTML5 sandbox attribute for iframes.
​http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
​https://bugs.webkit.org/show_bug.cgi?id=21288

Tests: fast/frames/sandboxed-iframe-attribute-parsing.html

fast/frames/sandboxed-iframe-forms.html
fast/frames/sandboxed-iframe-navigation-allowed.html
fast/frames/sandboxed-iframe-navigation-parent.html
fast/frames/sandboxed-iframe-navigation-targetlink.html
fast/frames/sandboxed-iframe-navigation-windowopen.html
fast/frames/sandboxed-iframe-plugins.html
fast/frames/sandboxed-iframe-scripting.html
fast/frames/sandboxed-iframe-storage.html
http/tests/security/sandboxed-iframe-document-cookie.html
http/tests/security/sandboxed-iframe-modify-self.html
http/tests/security/xss-DENIED-sandboxed-iframe.html
http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html
http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html
http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html

  • bindings/js/JSDOMWindowCustom.cpp: sandboxing navigation (WebCore::createWindow):
  • bindings/js/ScriptController.cpp: sandboxing scripts (WebCore::ScriptController::isEnabled):
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::cookie): raise exception when accessed from sandbox (WebCore::Document::setCookie): raise exception when accessed from sandbox (WebCore::Document::initSecurityContext): updae sandbox status (WebCore::Document::updateSandboxFlags):
  • dom/Document.h:
  • dom/Document.idl:
  • html/HTMLAppletElement.cpp: sandboxing applets (WebCore::HTMLAppletElement::createRenderer): (WebCore::HTMLAppletElement::renderWidgetForJSBindings): (WebCore::HTMLAppletElement::canEmbedJava):
  • html/HTMLAppletElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLFrameOwnerElement.cpp: management of sandbox flags as stated in attribute (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
  • html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::sandboxFlags):
  • html/HTMLIFrameElement.cpp: sandbox attribute parsing (WebCore::parseSandboxAttribute): (WebCore::HTMLIFrameElement::parseMappedAttribute):
  • html/HTMLIFrameElement.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies):
  • loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::submitForm): sandboxing forms (WebCore::FrameLoader::requestObject): sandboxing plugins (WebCore::FrameLoader::shouldAllowNavigation): sandboxing navigation (WebCore::FrameLoader::updateSandboxFlags): propagation of sandbox flags
  • loader/FrameLoader.h: (WebCore::FrameLoader::ownerElementSandboxFlagsChanged): (WebCore::FrameLoader::isSandboxed): (WebCore::FrameLoader::sandboxFlags):
  • loader/FrameLoaderTypes.h: (WebCore::):
  • page/DOMWindow.cpp: disable storage and databases in sandboxed frames (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage): (WebCore::DOMWindow::openDatabase):
  • page/SecurityOrigin.cpp: added sandboxing status (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::toString):
  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::isSandboxed): (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
6:04 PM Changeset in webkit [51576] by Chris Fleizach
  • 7 edits
    2 adds in trunk

ARIA: support a way to create a static text object
​https://bugs.webkit.org/show_bug.cgi?id=32030

Reviewed by David Kilzer.

WebCore:

Test: accessibility/aria-text-role.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::isDescendantOfBarrenParent):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::text):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • accessibility/aria-text-role-expected.txt: Added.
  • accessibility/aria-text-role.html: Added.
  • platform/gtk/Skipped:
  • platform/win/Skipped:
5:56 PM Changeset in webkit [51575] by Nikolas Zimmermann
  • 2 edits in trunk/WebKitTools

Not reviewed. GTK DRT try 2.

5:51 PM Changeset in webkit [51574] by Nikolas Zimmermann
  • 2 edits in trunk/WebKitTools

Not reviewed. Try to fix gtk DRT build.

5:48 PM Changeset in webkit [51573] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to rebuild Interfaces and fix the Windows build.

5:41 PM Changeset in webkit [51572] by oliver@apple.com
  • 3 edits in trunk/WebCore

Inspector crashes when collecting on every allocation
​https://bugs.webkit.org/show_bug.cgi?id=32044

Reviewed by Maciej Stachowiak.

The crash is caused by the prototype wrapper object getting collected
when allocating the object that is going to use it as a prototype.
Because the only reference to the prototype wrapper is through the
new object's Structure it does not get marked automatically.

5:40 PM Changeset in webkit [51571] by bweinstein@apple.com
  • 2 edits in trunk

Build fix by using DOMNode::node() to go from a DOMNode to a node, and
added svg/animation in the WebCore.vcproj list of headers to be copied
over on build.

5:26 PM Changeset in webkit [51570] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
​https://bugs.webkit.org/show_bug.cgi?id=32033

Reviewed by Eric Seidel.

  • Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find

instead of startswith.

  • Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
5:03 PM Changeset in webkit [51569] by Nikolas Zimmermann
  • 2 edits in trunk/WebKitTools

Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.

4:53 PM Changeset in webkit [51568] by Nikolas Zimmermann
  • 4 edits in trunk/WebKit

Not reviewed. Try to fix qt/win builds.

4:41 PM Changeset in webkit [51567] by Nikolas Zimmermann
  • 29 edits
    8 adds in trunk

2009-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
​https://bugs.webkit.org/show_bug.cgi?id=31897

Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.

Implemented just like the existing pauseAnimation* methods for CSS animations.

  • Api/qwebframe.cpp: (qt_drt_pauseSVGAnimation):

2009-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
​https://bugs.webkit.org/show_bug.cgi?id=31897

Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.

Implemented just like the existing pauseAnimation* methods for CSS animations.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_pause_svg_animation):

2009-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
​https://bugs.webkit.org/show_bug.cgi?id=31897

Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.

Implemented just like the existing pauseAnimation* methods for CSS animations.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp: (WebFrame::pauseSVGAnimation):
  • WebFrame.h:

2009-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
​https://bugs.webkit.org/show_bug.cgi?id=31897

Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.

Implemented just like the existing pauseAnimation* methods for CSS animations.

  • WebView/WebFrame.mm: (-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]):
  • WebView/WebFramePrivate.h:

2009-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
​https://bugs.webkit.org/show_bug.cgi?id=31897

Add 'sampleSVGAnimationForElementAtTime' method to the LayoutTestController,
for the use within the new SVG animation test framework (LayoutTests/svg/animations/)

layoutTestController.sampleAnimationAtTime(<svg animation id>, <absolute time>, <svg element id>);
to sample a svg animateMotion/animateColor/animate/set element at certain times.

After the desired SVG animation starts and calling the method above, it's immediately forwarded to
the desired sampling time. After JS returns from the 'sampleSVGAnimationForElementAtTime' method
a callback is fired used to sample the animation value at the target time. It's modelled similar
to the CSS animation/transition testing framework, inspired by
LayoutTests/animations/animation-test-helpers.js.

Though it has been extended to integrate within the fast/js/js-test-* framework, that's used for
the SVG dynamic-updates tests, to simplify test creation, by utilizing script-tests/* only.

Adding a simple testcase testing the DRT methods, it will soon be extended to test animVal/baseVal
interaction, while animating.

Test: svg/animations/animVal-basics.html

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::sampleAnimationAtTime):
  • svg/SVGDocumentExtensions.h:
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::SMILTimeContainer): (WebCore::SMILTimeContainer::sampleAnimationAtTime): (WebCore::SMILTimeContainer::updateAnimations):
  • svg/animation/SMILTimeContainer.h:

2009-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
​https://bugs.webkit.org/show_bug.cgi?id=31897

Add LayoutTests/svg/animations directory, containing a new
framework for SVG animation test with sampling at certain times.

Added one example test, which will be extended soon to cover animVal
support, once basic support has been implemented.

  • svg/animations: Added.
  • svg/animations/animVal-basics-expected.txt: Added.
  • svg/animations/animVal-basics.html: Added.
  • svg/animations/resources: Added.
  • svg/animations/resources/SVGAnimationTestCase.js: Added. (isCloseEnough): (moveAnimationTimelineAndSample): (startTest): (sampleAnimation): (runAnimationTest):
  • svg/animations/script-tests: Added.
  • svg/animations/script-tests/TEMPLATE.html: Added.
  • svg/animations/script-tests/animVal-basics.js: Added. (sample1): (sample2): (sample3): (executeTest):

2009-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Simon Fraser.

Add SVG animation test framework with 'snapshot' functionality
​https://bugs.webkit.org/show_bug.cgi?id=31897

Add new 'sampleSVGAnimationForElementAtTime' DRT method,
used by the new SVG animation testing framework, implemented
for qt/gtk/win/mac.

  • DumpRenderTree/LayoutTestController.cpp: (sampleSVGAnimationForElementAtTimeCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::sampleSVGAnimationForElementAtTime):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::sampleSVGAnimationForElementAtTime):
4:05 PM Changeset in webkit [51566] by snej@chromium.org
  • 14 edits in trunk

JavaScriptCore: Added variants of find/contains/add that allow a foreign key type to be used.
This will allow AtomicString-keyed maps to be queried by C string without
having to create a temporary AtomicString (see HTTPHeaderMap.)
The code for this is adapted from the equivalent in HashSet.h.

WebCore: Add convenience methods to Element and QualifiedName that take
char* instead of AtomicString, in preparation for removing the
implicit conversion between the two types (30187).
​https://bugs.webkit.org/show_bug.cgi?id=31749

Reviewed by Darin Adler.

3:59 PM Changeset in webkit [51565] by ap@apple.com
  • 2 edits in trunk/WebCore

More Windows build fix.

  • platform/network/cf/CredentialStorageCFNet.cpp: (WebCore::CredentialStorage::getFromPersistentStorage):
3:52 PM Changeset in webkit [51564] by ap@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • platform/network/cf/CredentialStorageCFNet.cpp: Include RetainPtr.h.
3:40 PM Changeset in webkit [51563] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip more tests that fail with specific versions of CFNetwork on Windows

Rubber-stamped in advance by Brady Eidson.

  • platform/win/Skipped:
3:36 PM Changeset in webkit [51562] by weinig@apple.com
  • 4 edits in trunk/WebKit/mac

Simplify [WebView userAgentForURL:]. No need to call into helper function.

Reviewed by Mark Rowe.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::userAgent):

  • WebView/WebView.mm:

(-[WebView userAgentForURL:]):

  • WebView/WebViewInternal.h:
3:35 PM Changeset in webkit [51561] by ap@apple.com
  • 6 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32036
Implement CredentialStorage::getFromPersistentStorage for CFNetwork

3:34 PM Changeset in webkit [51560] by pkasting@chromium.org
  • 4 edits in trunk/WebKit/chromium

[Chromium] Simplify zoom-related APIs and add a zoom level getter,
part one: Add new APIs. (Old APIs will be removed in a second pass.)
​https://bugs.webkit.org/show_bug.cgi?id=31893

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):

  • src/WebViewImpl.h:
2:12 PM Changeset in webkit [51559] by eric@webkit.org
  • 6 edits in trunk

2009-12-01 Daniel Bates <​dbates@webkit.org>

Reviewed by Pavel Feldman.

​https://bugs.webkit.org/show_bug.cgi?id=32001

Updated layout test to reflect change to localized string and
rebased the result.

  • inspector/elements-img-tooltip-expected.txt:
  • inspector/elements-img-tooltip.html:

2009-12-01 Daniel Bates <​dbates@webkit.org>

Reviewed by Pavel Feldman.

​https://bugs.webkit.org/show_bug.cgi?id=32001

Added missing localized strings (that I left out of the patch for bug #21554):
%d × %d pixels
%d × %d pixels (Natural: %d × %d pixels)

Also, changed formatting of these stings to conform with existing ones (added
a space on both sides of the multiply sign).

  • English.lproj/localizedStrings.js: Added stings.
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
2:05 PM Changeset in webkit [51558] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-01 Daniel Bates <​dbates@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

​https://bugs.webkit.org/show_bug.cgi?id=31898

Makes QtLauncher default to the http scheme for URLs.

  • QtLauncher/main.cpp: (MainWindow::MainWindow): (MainWindow::changeLocation): (main):
1:33 PM Changeset in webkit [51557] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a test that fails with some versions of CFNetwork on Windows

Rubber-stamped by Brady Eidson.

  • platform/win/Skipped: Skip http/tests/plugins/post-url-file.html.
1:32 PM Changeset in webkit [51556] by hyatt@apple.com
  • 2 edits
    4 adds in trunk

Fix for bug 32032, empty namespaces should be allowed in @namespace directives in CSS.

Reviewed by Simon Fraser.

Added fast/css/namespaces/namespaces-empty.xml

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::addNamespace):
(WebCore::CSSStyleSheet::determineNamespace):

1:17 PM Changeset in webkit [51555] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

Revert 51551 because it broke GTK+.

12:59 PM Changeset in webkit [51554] by Adam Roben
  • 2 edits in trunk/WebKitTools

Remove user content before running each test on Windows

Fixes <​http://webkit.org/b/31479> Make websocket tests work on Windows

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting): Remove all user content
before each test, which matches Mac.

12:08 PM Changeset in webkit [51553] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2009-12-01 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Escape key in the Search Field should be more User Friendly
​https://bugs.webkit.org/show_bug.cgi?id=32005

  • inspector/front-end/inspector.js: (WebInspector.loaded): add mousedown listener on the search field (WebInspector.searchFieldManualFocus): user clicked to focus on the search field (WebInspector.searchKeyDown): handle escape
11:08 AM Changeset in webkit [51552] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Enabling WebSocket tests on Windows again - let's see what errors get logged.

  • platform/win/Skipped:
11:01 AM Changeset in webkit [51551] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-12-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

PLATFORM(CAIRO) should be defined by WIN_CAIRO define
​https://bugs.webkit.org/show_bug.cgi?id=22250

  • wtf/Platform.h: Remove WTF_PLATFORM_CAIRO as it is already define in config.h
10:56 AM Changeset in webkit [51550] by ap@apple.com
  • 2 edits in trunk/WebKitTools

2009-12-01 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Make pywebsocket log errors to a file
​https://bugs.webkit.org/show_bug.cgi?id=31604

  • Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory (by passing the path to the server via a recently added -l option).
10:55 AM Changeset in webkit [51549] by hyatt@apple.com
  • 2 edits
    4 adds in trunk

@namespace directives need to use "maybe_space" in the "maybe_ns_prefix" portion of the grammar to match
the spec. Not doing so prevent comments from being used immmediately after the namespace prefix.

Reviewed by David Kilzer.

Added fast/css/namespaces-comments.xml

  • css/CSSGrammar.y:
10:41 AM Changeset in webkit [51548] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-12-01 Xiyuan Xia <​xiyuan@chromium.org>

Reviewed by Darin Fisher.

Only fire start/stop events when main frame is not loading.

​https://bugs.webkit.org/show_bug.cgi?id=31838

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage):
10:38 AM Changeset in webkit [51547] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add a timing-out test to the Skipped file on Windows

Rubber-stamped by Ada Chan.

  • platform/win/Skipped: Added

fast/dom/Window/window-postmessage-clone.html, which was timing out
due to eventSender.beginDragFiles being unimplemented.

10:35 AM Changeset in webkit [51546] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix tests that use the TestNetscapePlugin in Debug_Internal builds

Reviewed by Ada Chan.

Fixes <​http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
TestNetscapePlugin fail in Debug_Internal builds

  • DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin

directory in Debug and Debug_All builds, but not in Debug_Internal
builds.

10:01 AM Changeset in webkit [51545] by Adam Roben
  • 2 edits in trunk/WebKitTools

Re-enable DRT's watchdog timer on Windows

It was accidentally disabled in r50907.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
into an if condition.

9:24 AM Changeset in webkit [51544] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-01 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Timothy Hatcher.

Reloading WebInspector from context menu is closing it instead of reloading.
​https://bugs.webkit.org/show_bug.cgi?id=32004

When reloading WebInspector, don't delete its m_page.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::close):
9:20 AM Changeset in webkit [51543] by Adam Roben
  • 2 edits
    7 adds in trunk/LayoutTests

Add expected Windows failure results for tests that use textInputController

<​http://webkit.org/b/32021> covers fixing these tests.

Rubber-stamped by Sam Weinig.

  • platform/win/Skipped: Removed tests that use textInputController.
  • platform/win/editing/selection/5825350-1-expected.txt: Added.
  • platform/win/editing/selection/5825350-2-expected.txt: Added.
  • platform/win/editing/selection/mixed-editability-10-expected.txt: Added.
  • platform/win/fast/events/ime-composition-events-001-expected.txt: Added.
  • platform/win/fast/forms/input-maxlength-ime-completed-expected.txt: Added.
  • platform/win/fast/forms/input-maxlength-ime-preedit-expected.txt: Added.
  • platform/win/fast/text/international/thai-cursor-position-expected.txt: Added.
8:51 AM Changeset in webkit [51542] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector().

  • platform/qt/Skipped: inspector/timeline-network-resource.html added.
8:46 AM Changeset in webkit [51541] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

check-webkit-style complains about #imports with / in them
​https://bugs.webkit.org/show_bug.cgi?id=32022

We need to exclude #import directives in addition to #include from the
binary operator whitespace checks.

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
8:46 AM Changeset in webkit [51540] by eric@webkit.org
  • 8 edits
    6 adds in trunk/WebCore

2009-12-01 Steve Block <​steveblock@google.com>

Reviewed by Dimitri Glazkov.

Adds V8 bindings for Geolocation.
​https://bugs.webkit.org/show_bug.cgi?id=30206

Also adds Geolocation files to Chrome build files.

  • WebCore.gyp/WebCore.gyp: Modified. Corrects list of Geolocation IDL files.
  • WebCore.gypi: Modified. Adds Geolocation files.
  • bindings/v8/DOMObjectsInclude.h: Modified. Adds Geolocation includes.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Modified. Adds Geolocation files.
  • bindings/v8/V8Index.cpp: Modified. Includes Geolocation generated headers.
  • bindings/v8/V8Index.h: Modified. Adds Geolocation types to DOM_OBJECT_TYPES.
  • bindings/v8/custom/V8CoordinatesCustom.cpp: Added. Handles optional properties.
  • bindings/v8/custom/V8CustomBinding.h: Modified. Declares callbacks and getters.
  • bindings/v8/custom/V8CustomPositionCallback.cpp: Added. (WebCore::V8CustomPositionCallback::V8CustomPositionCallback): Added. Constructor. (WebCore::V8CustomPositionCallback::~V8CustomPositionCallback): Added. Destructor. (WebCore::V8CustomPositionCallback::handleEvent): Added. Invokes callback.
  • bindings/v8/custom/V8CustomPositionCallback.h: Added. (WebCore::V8CustomPositionCallback::create): Added. Factory method.
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Added. (WebCore::V8CustomPositionErrorCallback::V8CustomPositionErrorCallback): Added. Constructor. (WebCore::V8CustomPositionErrorCallback::~V8CustomPositionErrorCallback): Added. Destructor. (WebCore::V8CustomPositionErrorCallback::handleEvent): Added. Invokes callback.
  • bindings/v8/custom/V8CustomPositionErrorCallback.h: Added. (WebCore::V8CustomPositionErrorCallback::create): Added. Factory method.
  • bindings/v8/custom/V8GeolocationCustom.cpp: Added. (WebCore::throwTypeMismatchException): Added. Throws a type mismatch error. (WebCore::createPositionCallback): Added. Handles type checking for successCallback argument. (WebCore::createPositionErrorCallback): Added. Handles type checking for errorCallback argument. (WebCore::createPositionOptions): Added. Handles type checking for positionOptions argument.
8:19 AM Changeset in webkit [51539] by eric@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2009-12-01 Eric Z. Ayers <​zundel@google.com>

Reviewed by Pavel Feldman.

Adds test for Timeline network resource records.

​https://bugs.webkit.org/show_bug.cgi?id=31378

  • inspector/timeline-network-resource-expected.txt: Added.
  • inspector/timeline-network-resource.html: Added.
  • inspector/timeline-network-resource.js: Added.
  • inspector/timeline-test.js: (printTimelineRecords):
8:17 AM Changeset in webkit [51538] by yurys@chromium.org
  • 4 edits in trunk/WebCore

2009-12-01 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Adam Barth.

Provide a way to get ScriptState for the inspected page.

​https://bugs.webkit.org/show_bug.cgi?id=32020

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromPage):
8:09 AM Changeset in webkit [51537] by cmarrin@apple.com
  • 5 edits in trunk

Changed mallocs to fastMallocs and frees to fastFrees in GraphicsContext3D. Also added error returns
​https://bugs.webkit.org/show_bug.cgi?id=30778

7:45 AM Changeset in webkit [51536] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-01 Mads Ager <​ager@chromium.org>

Reviewed by Eric Seidel.

[V8] Don't crash in DOMWindow event getter in OOM situations
​https://bugs.webkit.org/show_bug.cgi?id=32017

Add missing null handle checks in DOMWindow event property
accessors. V8Proxy::context(frame) can return a null handle in
OOM situations either if failing to initialize a context or if an
OOM is handled gracefully and javascript is disabled.

No new tests because we don't have a good way to test
out-of-memory bugs.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
6:44 AM Changeset in webkit [51535] by cmarrin@apple.com
  • 6 edits in trunk

Updated HTMLCanvasElement to accept "experimental-webgl" as the context name.
​https://bugs.webkit.org/show_bug.cgi?id=31672

6:22 AM Changeset in webkit [51534] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-12-01 Pavel Feldman <​pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

Not reviewed: chromium build fix, added missing import.

  • inspector/InspectorFrontendHost.cpp:
3:26 AM Changeset in webkit [51533] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Put tests into skiplist because of missing textInputController.selectedRange().

  • platform/qt/Skipped:
  • editing/selection/mixed-editability-10.html added.
  • editing/selection/5825350-1.html added.
  • editing/selection/5825350-2.html added.
1:45 AM Changeset in webkit [51532] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-12-01 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: fix windows build via unexcluding generated files from
project.

  • WebCore.vcproj/WebCore.vcproj:
1:33 AM Changeset in webkit [51531] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Stop copying IDL files in to the WebCore framework wrapper.

  • WebCore.xcodeproj/project.pbxproj:
1:28 AM Changeset in webkit [51530] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the Tiger build by making the Xcode project compatible with Xcode 2.4.

This was probably broken by hand-editing the project file as Xcode itself
knows how to keep project files to a backwards-compatible subset of its format.

  • WebCore.xcodeproj/project.pbxproj:
12:45 AM Changeset in webkit [51529] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-12-01 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: windows build fix (bad vcproj in r51528).

  • WebCore.vcproj/WebCore.vcproj:
12:07 AM Changeset in webkit [51528] by pfeldman@chromium.org
  • 49 edits
    5 copies
    7 adds
    2 deletes in trunk/WebCore

2009-11-27 Pavel Feldman <​pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

Reviewed by Timothy Hatcher.

Web Inspector: Split InspectorBackend into three parts: backend,
injected script host and frontend host.


​https://bugs.webkit.org/show_bug.cgi?id=31888

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSInspectorBackendCustom.cpp: Removed.
  • bindings/js/JSInspectorFrontendHostCustom.cpp: Added. (WebCore::JSInspectorFrontendHost::search): (WebCore::JSInspectorFrontendHost::setting): (WebCore::JSInspectorFrontendHost::setSetting):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/ScriptObject.h:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/v8/ScriptObject.h:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: Removed.
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • inspector/InjectedScriptHost.cpp: Added. (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::~InjectedScriptHost): (WebCore::InjectedScriptHost::copyText): (WebCore::InjectedScriptHost::nodeForId): (WebCore::InjectedScriptHost::wrapObject): (WebCore::InjectedScriptHost::unwrapObject): (WebCore::InjectedScriptHost::pushNodePathToFrontend): (WebCore::InjectedScriptHost::addNodesToSearchResult): (WebCore::InjectedScriptHost::currentCallFrame): (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript): (WebCore::InjectedScriptHost::inspectorDOMAgent): (WebCore::InjectedScriptHost::inspectorFrontend):
  • inspector/InjectedScriptHost.h: Added. (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::inspectorController): (WebCore::InjectedScriptHost::disconnectController):
  • inspector/InjectedScriptHost.idl: Added.
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::InspectorBackend): (WebCore::InspectorBackend::storeLastActivePanel): (WebCore::InspectorBackend::toggleNodeSearch): (WebCore::InspectorBackend::resourceTrackingEnabled): (WebCore::InspectorBackend::debuggerEnabled): (WebCore::InspectorBackend::enableDebugger): (WebCore::InspectorBackend::disableDebugger): (WebCore::InspectorBackend::addBreakpoint): (WebCore::InspectorBackend::updateBreakpoint): (WebCore::InspectorBackend::removeBreakpoint): (WebCore::InspectorBackend::pauseInDebugger): (WebCore::InspectorBackend::resumeDebugger): (WebCore::InspectorBackend::stepOverStatementInDebugger): (WebCore::InspectorBackend::stepIntoStatementInDebugger): (WebCore::InspectorBackend::stepOutOfFunctionInDebugger): (WebCore::InspectorBackend::pauseOnExceptions): (WebCore::InspectorBackend::setPauseOnExceptions): (WebCore::InspectorBackend::profilerEnabled): (WebCore::InspectorBackend::enableProfiler): (WebCore::InspectorBackend::disableProfiler): (WebCore::InspectorBackend::startProfiling): (WebCore::InspectorBackend::stopProfiling): (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile): (WebCore::InspectorBackend::currentCallFrame): (WebCore::InspectorBackend::highlightDOMNode): (WebCore::InspectorBackend::hideDOMNodeHighlight): (WebCore::InspectorBackend::getCookies): (WebCore::InspectorBackend::deleteCookie): (WebCore::InspectorBackend::didEvaluateForTestInFrontend): (WebCore::InspectorBackend::nodeForId):
  • inspector/InspectorBackend.h: (WebCore::InspectorBackend::create):
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable):
  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorFrontendHost): (WebCore::InspectorController::injectedScriptHost):
  • inspector/InspectorFrontendHost.cpp: Added. (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::loaded): (WebCore::InspectorFrontendHost::attach): (WebCore::InspectorFrontendHost::detach): (WebCore::InspectorFrontendHost::closeWindow): (WebCore::InspectorFrontendHost::windowUnloading): (WebCore::InspectorFrontendHost::setAttachedWindowHeight): (WebCore::InspectorFrontendHost::moveWindowBy): (WebCore::InspectorFrontendHost::localizedStringsURL): (WebCore::InspectorFrontendHost::hiddenPanels): (WebCore::InspectorFrontendHost::platform): (WebCore::InspectorFrontendHost::port): (WebCore::InspectorFrontendHost::addResourceSourceToFrame): (WebCore::InspectorFrontendHost::addSourceToFrame):
  • inspector/InspectorFrontendHost.h: Added. (WebCore::InspectorFrontendHost::create): (WebCore::InspectorFrontendHost::inspectorController): (WebCore::InspectorFrontendHost::disconnectController):
  • inspector/InspectorFrontendHost.idl: Added.
  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set condition):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype.setAttributeAsync): (WebInspector.DOMAgent.prototype.removeAttributeAsync): (WebInspector.DOMAgent.prototype.setTextNodeValueAsync): (WebInspector.Cookies.getCookiesAsync): (WebInspector.EventListeners.getEventListenersForNodeAsync):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.prototype.getEntries): (WebInspector.DOMStorage.prototype.setItem): (WebInspector.DOMStorage.prototype.removeItem):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.getTableNames):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.handleCopyEvent): (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode): (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode): ():
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype):
  • inspector/front-end/InjectedScript.js: (InjectedScript._evaluateAndWrap): (InjectedScript.performSearch.addNodesToResults): (InjectedScript.getCallFrames): (InjectedScript._callFrameForId): (InjectedScript._clearConsoleMessages): (InjectedScript._inspectObject): (InjectedScript._copy): (InjectedScript._ensureCommandLineAPIInstalled): (InjectedScript._window): (InjectedScript._nodeForId): (InjectedScript._objectForId): (InjectedScript.pushNodeToFrontend): (InjectedScript.executeSql): (InjectedScript.executeSql.errorCallback): (InjectedScript.executeSql.queryTransaction):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/InspectorBackendStub.js: Added. (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.wrapCallback): (.WebInspector.InspectorBackendStub.prototype.platform): (.WebInspector.InspectorBackendStub.prototype.port): (.WebInspector.InspectorBackendStub.prototype.closeWindow): (.WebInspector.InspectorBackendStub.prototype.attach): (.WebInspector.InspectorBackendStub.prototype.detach): (.WebInspector.InspectorBackendStub.prototype.storeLastActivePanel): (.WebInspector.InspectorBackendStub.prototype.clearMessages): (.WebInspector.InspectorBackendStub.prototype.searchingForNode): (.WebInspector.InspectorBackendStub.prototype.search): (.WebInspector.InspectorBackendStub.prototype.toggleNodeSearch): (.WebInspector.InspectorBackendStub.prototype.setAttachedWindowHeight): (.WebInspector.InspectorBackendStub.prototype.moveByUnrestricted): (.WebInspector.InspectorBackendStub.prototype.addResourceSourceToFrame): (.WebInspector.InspectorBackendStub.prototype.addSourceToFrame): (.WebInspector.InspectorBackendStub.prototype.getResourceDocumentNode): (.WebInspector.InspectorBackendStub.prototype.highlightDOMNode): (.WebInspector.InspectorBackendStub.prototype.hideDOMNodeHighlight): (.WebInspector.InspectorBackendStub.prototype.inspectedWindow): (.WebInspector.InspectorBackendStub.prototype.loaded): (.WebInspector.InspectorBackendStub.prototype.localizedStringsURL): (.WebInspector.InspectorBackendStub.prototype.windowUnloading): (.WebInspector.InspectorBackendStub.prototype.hiddenPanels): (.WebInspector.InspectorBackendStub.prototype.debuggerEnabled): (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.resourceTrackingEnabled): (.WebInspector.InspectorBackendStub.prototype.enableDebugger): (.WebInspector.InspectorBackendStub.prototype.disableDebugger): (.WebInspector.InspectorBackendStub.prototype.addBreakpoint): (.WebInspector.InspectorBackendStub.prototype.removeBreakpoint): (.WebInspector.InspectorBackendStub.prototype.updateBreakpoint): (.WebInspector.InspectorBackendStub.prototype.pauseInDebugger): (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptions): (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptions): (.WebInspector.InspectorBackendStub.prototype.resumeDebugger): (.WebInspector.InspectorBackendStub.prototype.profilerEnabled): (.WebInspector.InspectorBackendStub.prototype.enableProfiler): (.WebInspector.InspectorBackendStub.prototype.disableProfiler): (.WebInspector.InspectorBackendStub.prototype.startProfiling): (.WebInspector.InspectorBackendStub.prototype.stopProfiling): (.WebInspector.InspectorBackendStub.prototype.getProfileHeaders): (.WebInspector.InspectorBackendStub.prototype.getProfile): (.WebInspector.InspectorBackendStub.prototype.takeHeapSnapshot): (.WebInspector.InspectorBackendStub.prototype.databaseTableNames): (.WebInspector.InspectorBackendStub.prototype.stepIntoStatementInDebugger): (.WebInspector.InspectorBackendStub.prototype.stepOutOfFunctionInDebugger): (.WebInspector.InspectorBackendStub.prototype.stepOverStatementInDebugger): (.WebInspector.InspectorBackendStub.prototype.setSetting): (.WebInspector.InspectorBackendStub.prototype.dispatchOnInjectedScript): (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup): (.WebInspector.InspectorBackendStub.prototype.setting):
  • inspector/front-end/InspectorControllerStub.js:
  • inspector/front-end/InspectorFrontendHostStub.js: Added. (.WebInspector.InspectorFrontendHostStub): (.WebInspector.InspectorFrontendHostStub.prototype.platform): (.WebInspector.InspectorFrontendHostStub.prototype.port): (.WebInspector.InspectorFrontendHostStub.prototype.closeWindow): (.WebInspector.InspectorFrontendHostStub.prototype.attach): (.WebInspector.InspectorFrontendHostStub.prototype.detach): (.WebInspector.InspectorFrontendHostStub.prototype.search): (.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight): (.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy): (.WebInspector.InspectorFrontendHostStub.prototype.addResourceSourceToFrame): (.WebInspector.InspectorFrontendHostStub.prototype.addSourceToFrame): (.WebInspector.InspectorFrontendHostStub.prototype.loaded): (.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL): (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels): (.WebInspector.InspectorFrontendHostStub.prototype.setSetting): (.WebInspector.InspectorFrontendHostStub.prototype.setting):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView): (WebInspector.CPUProfileType.prototype.buttonClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._enableProfiling): (WebInspector.ProfilesPanel.prototype._toggleProfiling):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._toggleLargerResources): (WebInspector.ResourcesPanel.prototype._enableResourceTracking): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): (WebInspector.ScriptsPanel.prototype._togglePause): (WebInspector.ScriptsPanel.prototype._stepOverClicked): (WebInspector.ScriptsPanel.prototype._stepIntoClicked): (WebInspector.ScriptsPanel.prototype._stepOutClicked):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype.performSearch.findSearchMatches): (WebInspector.SourceView.prototype.performSearch):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
  • inspector/front-end/TestController.js: (WebInspector.TestController.prototype.notifyDone):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions): (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.pendingDispatches.0.get platform): (WebInspector.get port): (WebInspector.set currentPanel): (WebInspector._createPanels): (WebInspector._loadPreferences): (WebInspector.set attached): (WebInspector._updateHoverHighlight): (WebInspector.loaded): (windowLoaded): (WebInspector.windowUnload): (WebInspector.close): (WebInspector.toolbarDrag): (WebInspector.UIString):
Note: See TracTimeline for information about the timeline view.