⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 3, 2009:

11:50 PM Changeset in webkit [51684] by Chris Fleizach
  • 7 edits
    4 adds in trunk

WAI-ARIA: aria-activedescendant doesn't work as intended
​https://bugs.webkit.org/show_bug.cgi?id=32100

Reviewed by Beth Dakin.

WebCore:

Fixes a number of issues regarding the "tree" role and aria-activedescendant.

  1. The indexes were being reported incorrectly by treeitems.
  2. aria-activedescendant changes were not being sent to the containing item.
  3. The tree's selected rows need to consult aria-activedescendant.
  4. Since a tree changes what it returns as its children (it returns its rows) the mac-specific array indexing methods need to correctly handle the tree case.

Tests: platform/mac/accessibility/aria-tree-activedescendant.html

platform/mac/accessibility/aria-tree-index-of-items.html

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
(WebCore::AccessibilityRenderObject::activeDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

  • platform/mac/accessibility/aria-tree-activedescendant-expected.txt: Added.
  • platform/mac/accessibility/aria-tree-activedescendant.html: Added.
  • platform/mac/accessibility/aria-tree-index-of-items-expected.txt: Added.
  • platform/mac/accessibility/aria-tree-index-of-items.html: Added.
11:48 PM Changeset in webkit [51683] by zoltan@webkit.org
  • 5 edits in trunk/WebCore

2009-12-03 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for the xml directory in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=

Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

struct XMLHttpRequestStaticData - xml/XMLHttpRequest.cpp:134

Inherits the following classes from FastAllocBase because these are instantiated by 'new':

class NodeTest - xml/XPathGrammar.y:258
class NodeSet - xml/XPathValue.cpp:52
struct EvaluationContext - xml/XPathExpressionNode.cpp:40

  • xml/XMLHttpRequest.cpp:
  • xml/XPathExpressionNode.h:
  • xml/XPathNodeSet.h:
  • xml/XPathStep.h:
11:42 PM Changeset in webkit [51682] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2009-12-03 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

check-webkit-style should check for camelCase variable names
​https://bugs.webkit.org/show_bug.cgi?id=32051

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
10:40 PM Changeset in webkit [51681] by atwilson@chromium.org
  • 4 edits
    1 add in trunk/WebCore

New History changes do not compile for Chromium/V8
​https://bugs.webkit.org/show_bug.cgi?id=32148

Reviewed by Adam Barth.

Existing tests suffice (just trying to get code to compile).

  • WebCore.gypi:

Added V8HistoryCustom.cpp and other missing files.

  • bindings/v8/custom/V8CustomBinding.h:

Added custom handlers for History.pushState()/replaceState().

  • bindings/v8/custom/V8HistoryCustom.cpp: Added.

Added custom handlers for History.pushState()/replaceState().

  • history/BackForwardListChromium.cpp:

(WebCore::BackForwardList::pushStateItem):
Stubbed out this routine for now - will implement in the future.

10:19 PM Changeset in webkit [51680] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-12-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

OwnPtr<XBLBindingManager> Document::m_bindingManager;
​https://bugs.webkit.org/show_bug.cgi?id=32147

The document actually owns the bindingManager. That's what the code
should say.

  • dom/Document.cpp: (WebCore::Document::~Document):
  • dom/Document.h: (WebCore::Document::bindingManager):
9:55 PM Changeset in webkit [51679] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-12-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

OwnPtr<Tokenizer> Document::m_tokenizer;
​https://bugs.webkit.org/show_bug.cgi?id=32145

The document actually owns the tokenizer. That's what the code should say.

  • dom/Document.cpp: (WebCore::Document::removedLastRef): (WebCore::Document::~Document): (WebCore::Document::cancelParsing): (WebCore::Document::implicitOpen): (WebCore::Document::implicitClose):
  • dom/Document.h: (WebCore::Document::tokenizer):
9:54 PM Changeset in webkit [51678] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-12-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

OwnPtr<RenderArena> Document::m_renderArena;
​https://bugs.webkit.org/show_bug.cgi?id=32146

The document owns the renderArena. That's what the code should say.

  • dom/Document.cpp: (WebCore::Document::Document): Also, removed a redundant initialization of the tokenizer that I missed in my previous patch. (WebCore::Document::~Document): (WebCore::Document::attach): (WebCore::Document::detach):
  • dom/Document.h: (WebCore::Document::renderArena):
9:54 PM Changeset in webkit [51677] by atwilson@chromium.org
  • 5 edits in trunk

Revert r51633

This reverts commit 4c9cc0b9a12d38654b9c687ffc1671c7307b397a.

9:33 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
9:28 PM Changeset in webkit [51676] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2009-12-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

The code should say that Document owns DocLoader
​https://bugs.webkit.org/show_bug.cgi?id=32143

It's the truth.

  • dom/Document.cpp: (WebCore::Document::~Document):
  • dom/Document.h: (WebCore::Document::docLoader):
6:53 PM Changeset in webkit [51675] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Try and fix the Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a symbol that should be exported.
6:35 PM Changeset in webkit [51674] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Try and fix the Mac build.

6:28 PM Changeset in webkit [51673] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

Fixing layout test bustage on platforms.

AX: VO just says "term" on many web sites
​https://bugs.webkit.org/show_bug.cgi?id=32139

  • platform/mac-leopard/accessibility/lists-expected.txt:
  • platform/mac/accessibility/radio-button-group-members-expected.txt:
6:17 PM Changeset in webkit [51672] by oliver@apple.com
  • 6 edits in trunk/JavaScriptCore

REGRESSION(4.0.3-48777): Crash in JSC::ExecState::propertyNames() (Debug-only?)
​https://bugs.webkit.org/show_bug.cgi?id=32133

Reviewed by Gavin Barraclough.

Work around odd GCC-ism and correct the scopechain for use by
calls made while a cachedcall is active on the callstack.

6:15 PM Changeset in webkit [51671] by barraclough@apple.com
  • 9 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=32136
Add a rope representation to JSString. Presently JSString always holds its data in UString form.
Instead, allow the result of a string concatenation to be represented in a tree form - with a
variable sized, reference-counted rope node retaining a set of UString::Reps (or other rope nopes).

Reviewed by Oliver "Brraaaaiiiinnnnnzzzzzzzz" Hunt.

Strings must still currently be resolved down to a flat UString representation before being used,
but by holding the string in a rope representation during construction we can avoid copying data
until we know the final size of the string.

~2% progression on SunSpider (~25% on date-format-xparb, ~20% on string-validate-input).

  • Update exports.
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • Make use of new JSString::length() method to avoid prematurely resolving ropes.
  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • Switch the string length trampoline to read the length directly from JSString::m_length, rather than from the JSString's UString::Rep's 'len' property.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Modify op_add such that addition of two strings, where either or both strings are already in rope representation, produces a rope as a result.
  • runtime/JSString.cpp:

(JSC::JSString::Rope::~Rope):
(JSC::copyChars):
(JSC::JSString::resolveRope):
(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toBoolean):
(JSC::JSString::toNumber):
(JSC::JSString::toString):
(JSC::JSString::toThisString):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::JSString::Rope::Fiber::Fiber):
(JSC::JSString::Rope::Fiber::destroy):
(JSC::JSString::Rope::Fiber::isRope):
(JSC::JSString::Rope::Fiber::rope):
(JSC::JSString::Rope::Fiber::string):
(JSC::JSString::Rope::create):
(JSC::JSString::Rope::initializeFiber):
(JSC::JSString::Rope::ropeLength):
(JSC::JSString::Rope::stringLength):
(JSC::JSString::Rope::fibers):
(JSC::JSString::Rope::Rope):
(JSC::JSString::Rope::operator new):
(JSC::JSString::JSString):
(JSC::JSString::value):
(JSC::JSString::length):
(JSC::JSString::isRope):
(JSC::JSString::rope):
(JSC::JSString::string):
(JSC::JSString::canGetIndex):
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSubstring):
(JSC::JSString::getStringPropertySlot):

  • Add rope form.
  • runtime/Operations.h:

(JSC::jsAdd):
(JSC::concatenateStrings):

  • Update string concatenation, and addition of ropes, to produce ropes.
  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertyNames):

  • Make use of new JSString::length() method to avoid prematurely resolving ropes.
6:06 PM Changeset in webkit [51670] by Chris Fleizach
  • 13 edits
    2 adds in trunk

AX: VO just says "term" on many web sites
​https://bugs.webkit.org/show_bug.cgi?id=32139

Reviewed by Eric Seidel.

WebCore:

Test: platform/mac/accessibility/definition-list-term.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityDescription):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper subrole]):
(-[AccessibilityObjectWrapper roleDescription]):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getRoleDescriptionCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::roleDescription):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::roleDescription):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::roleDescription):

LayoutTests:

  • platform/mac/accessibility/aria-grouping-roles-expected.txt:
  • platform/mac/accessibility/aria-grouping-roles.html:
  • platform/mac/accessibility/definition-list-term-expected.txt: Added.
  • platform/mac/accessibility/definition-list-term.html: Added.
  • platform/mac/accessibility/lists-expected.txt:
5:00 PM Changeset in webkit [51669] by Chris Fleizach
  • 16 edits
    2 adds in trunk

Implement WAI-ARIA scrollbar role and related property aria-orientation
​https://bugs.webkit.org/show_bug.cgi?id=32126

Reviewed by Beth Dakin.

WebCore:

Test: accessibility/aria-scrollbar-role.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isScrollbar):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::valueForRange):
(WebCore::AccessibilityRenderObject::orientation):
(WebCore::AccessibilityRenderObject::canHaveChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/HTMLAttributeNames.in:

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getOrientationCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::orientation):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::orientation):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::orientation):

LayoutTests:

  • accessibility/aria-scrollbar-role-expected.txt: Added.
  • accessibility/aria-scrollbar-role.html: Added.
  • platform/gtk/Skipped:
  • platform/win/Skipped:
4:16 PM Changeset in webkit [51668] by mitz@apple.com
  • 4 edits
    4 adds in trunk

Fixed <rdar://problem/7401617> Selection painting issue in hardware-
accelerated layers
which is another part of ​https://bugs.webkit.org/show_bug.cgi?id=23628
Fix selection painting to do container-relative repaints

Reviewed by Darin Adler.

Test: fast/repaint/block-selection-gap-in-composited-layer.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint): Compute and paint
gap rects in the coordinate space of the repaint container.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): Added a
FIXME.

  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Map block selection gap rects from
the repaint container’s coordinate space to the view’s coordinate space
before adding them to the cached selection bounds.
(WebCore::RenderView::clearSelection): Changed to use
repaintRectangleInViewAndCompositedLayers() so that the selection rect
is invalidated in composited layers as well.

4:07 PM Changeset in webkit [51667] by ap@apple.com
  • 4 edits in trunk/LayoutTests

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32132
websocket/tests/simple.html fails on Windows

  • websocket/tests/script-tests/simple.js:
  • websocket/tests/simple-expected.txt: Make the test weaker - readyState could already grow by the time a posted event gets dispatched.
  • platform/win/Skipped: Un-skip the test.
3:37 PM Changeset in webkit [51666] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Make shorthand-transitions.html less flaky.
The test currently allows for timing related differences by using a tolerance, but the tolerance
is inconsistent in the test, even for values read at the same time (some values are allowed a 100ms
difference, others are only allowed 50ms). This change makes all values have a 100ms tolerance.
(open question: is 100ms enough? I've looked through a bunch of logs of failures and it seems to be,
so this should definitely help reduce but this may not entirely eliminate flakiness).

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32134

  • transitions/shorthand-transitions.html:
3:24 PM Changeset in webkit [51665] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-12-03 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32135

[Qt] Add expected files for new tests we pass.
Compared to the Mac expected png files.

  • platform/qt/fast/css/namespaces/namespaces-escapes-expected.txt: Added.
  • platform/qt/fast/css/namespaces/namespaces-invalid-at-expected.txt: Added.
2:17 PM Changeset in webkit [51664] by eric.carlson@apple.com
  • 2 edits in trunk/WebKitTools

2009-12-03 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben.

Minor correction to r51663.

  • DumpRenderTree/win/DumpRenderTree.cpp: (addQTDirToPATH):

GetEnvironmentVariable -> GetEnvironmentVariableW.

2:10 PM Changeset in webkit [51663] by eric.carlson@apple.com
  • 2 edits in trunk/WebKitTools

2009-12-03 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben.

~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
​https://bugs.webkit.org/show_bug.cgi?id=30256

Add the QuickTime dll directory to the PATH environment variable so
inialization can succeed.

  • DumpRenderTree/win/DumpRenderTree.cpp: (addQTDirToPATH): (initialize):
2:08 PM Changeset in webkit [51662] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-03 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::maybeDump):
2:01 PM Changeset in webkit [51661] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2009-12-03 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

Update pywebsocket to 0.4.3
This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
Stack trace is logged now in INFO level.
​https://bugs.webkit.org/show_bug.cgi?id=32097

  • pywebsocket/mod_pywebsocket/dispatch.py:
  • pywebsocket/mod_pywebsocket/msgutil.py:
  • pywebsocket/mod_pywebsocket/standalone.py:
  • pywebsocket/mod_pywebsocket/util.py:
  • pywebsocket/setup.py:
  • pywebsocket/test/test_dispatch.py:
  • pywebsocket/test/test_util.py:
1:54 PM Changeset in webkit [51660] by eric@webkit.org
  • 9 edits
    1 add in trunk

2009-12-03 Jonathan Dixon <​joth@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 32066 - Add enable geolocation flag to WebCore::Settings for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=32066

Adds geolocationEnabled in Settings for runtime control of geolocaiton features. This defaults to ON
as it is intended as a development and testing aid, not a user control. To completely remove geolocation
from a given port, the compile time ENABLE_GEOLOCATION should still be used.
Adding placeholder GeolocationServiceChromium implementation, as this is required to allows
ENABLE_GEOLOCATION to be defined (in turn required for testing), even though this patch does not
make that the default just yet.

  • WebCore.gypi:
  • page/Settings.cpp: (WebCore::Settings::Settings): Add new m_geolocationEnabled flag default value (WebCore::Settings::setGeolocationEnabled): Setter for m_geolocationEnabled flag
  • page/Settings.h: (WebCore::Settings::geolocationEnabled): Add m_geolocationEnabled flag
  • platform/chromium/GeolocationServiceChromium.cpp: Added. (WebCore::GeolocationServiceChromium::GeolocationServiceChromium): Place holder GeolocationServiceChromium) (WebCore::createGeolocationService): factory function, only required when ENABLED(GEOLOCATION) is true

2009-12-03 Jonathan Dixon <​joth@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 32066 - Add enable geolocation flag to WebCore::Settings for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=32066

Add the plumbing to map WebSettings through to WebCore::Settings

  • features.gypi:
  • public/WebSettings.h: Add setGeolocationEnabled API to interface
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setGeolocationEnabled): Calls through to WebCore::Settings::setGeolocationEnabled
  • src/WebSettingsImpl.h: Add setGeolocationEnabled interface function
1:43 PM Changeset in webkit [51659] by enrica@apple.com
  • 2 edits in trunk/WebCore

SpinTracer: 349 spins in Mail at WebCore::Editor::advanceToNextMisspelling(bool)
<rdar://problem/7198592>
​https://bugs.webkit.org/show_bug.cgi?id=32129

Reviewed by John Sullivan.

Fixed the way the next paragraph is calculated.
I've added a repro case in Safari and attached it to the Bugzilla bug.

  • editing/Editor.cpp:

(WebCore::findFirstMisspellingOrBadGrammarInRange): Changed the way we move to the
next paragraph in the loop.

1:37 PM Changeset in webkit [51658] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-03 İsmail Dönmez <​ismail@namtrac.org>

Reviewed by Eric Seidel.

Fix compilation when SVG is disabled.

  • Api/qwebframe.cpp: (qt_drt_pauseSVGAnimation):
1:27 PM Changeset in webkit [51657] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Alexey Proskuryakov.

Skip failing WebSocket test on Windows.

  • platform/win/Skipped:
1:25 PM Changeset in webkit [51656] by weinig@apple.com
  • 4 edits in trunk/WebKitTools

Fix JSClassRef leak.

Reviewed by Gavin Barraclough.

  • DumpRenderTree/AccessibilityController.cpp:

(AccessibilityController::makeWindowObject):

  • DumpRenderTree/GCController.cpp:

(GCController::makeWindowObject):

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::makeWindowObject):

1:19 PM Changeset in webkit [51655] by beidson@apple.com
  • 3 edits in trunk/LayoutTests

Rubberstamped by Oliver Hunt.

Fix layout tests by removing the full outputting of the Date object and just outputting the milliseconds since the epoch.

  • fast/loader/stateobjects/pushstate-object-types-expected.txt:
  • fast/loader/stateobjects/pushstate-object-types.html:
1:06 PM Changeset in webkit [51654] by ap@apple.com
  • 1 edit
    1 copy
    2 adds in trunk/LayoutTests

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32130
Add a test for sending non-trivial amount of data over WebSocket

  • websocket/tests/echo_wsh.py: Copied from WebKitTools/pywebsocket/example/echo_wsh.py.
  • websocket/tests/simple-stress-expected.txt: Added.
  • websocket/tests/simple-stress.html: Added.
12:59 PM Changeset in webkit [51653] by beidson@apple.com
  • 7 edits in trunk/LayoutTests

Rubberstamped by Sam Weinig.

Fix my absolute URL snafu by outputting only the last path component for these URLs,
which is all that is relevant.

  • fast/loader/stateobjects/document-destroyed-navigate-back-expected.txt:
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll-expected.txt:
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
  • fast/loader/stateobjects/document-destroyed-navigate-back.html:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-expected.txt:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
12:38 PM Changeset in webkit [51652] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix

11:51 AM Changeset in webkit [51651] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix

11:39 AM Changeset in webkit [51650] by beidson@apple.com
  • 2 edits in trunk/WebCore

No wonder editing WebCore.exp repeatedly while I worked on this patch never seemed to stick.

Long live our auto-generated overlords that I didn't know about...

  • WebCore.base.exp:
11:34 AM Changeset in webkit [51649] by oliver@apple.com
  • 6 edits in trunk

REGRESSION (r51627): 3 SVG tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=32117

Reviewed by Dan Bernstein.

Null checking Items in the SVGList is insufficient as items may
be floats, etc so add SVGListTraits::isNull and add appropriate
specializations.

Test: svg/dom/svglist-exception-on-out-bounds-error.html

11:32 AM Changeset in webkit [51648] by beidson@apple.com
  • 2 edits in trunk/WebCore

No review - release build fix.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::documentDetached):

11:27 AM Changeset in webkit [51647] by beidson@apple.com
  • 2 edits in trunk/WebCore

No review - release build fix.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::pushState):

11:25 AM Changeset in webkit [51646] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force Interfaces rebuild and fix Windows build.

11:18 AM Changeset in webkit [51645] by enrica@apple.com
  • 12 edits
    2 adds in trunk

WebCore: Multiple Undos removes the last posted comment and/or the ones before it.
<rdar://problem/6557066>
​https://bugs.webkit.org/show_bug.cgi?id=32079

Reviewed by Adele Peterson.

The fix consists in preventing Undos and Redos to be applied to elements that
are no longer editable. We do not attempt to remove the commands from the queue.
It is a relatively simple fix that comes with a little extra overhead for the apply
and unapply methods where we are now performing the editability check.

Test: editing/undo/undo-indent-noneditable.html

  • editing/AppendNodeCommand.cpp:

(WebCore::AppendNodeCommand::doApply):
(WebCore::AppendNodeCommand::doUnapply):

  • editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):

  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

  • editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

  • editing/JoinTextNodesCommand.cpp:

(WebCore::JoinTextNodesCommand::doApply):
(WebCore::JoinTextNodesCommand::doUnapply):

  • editing/MergeIdenticalElementsCommand.cpp:

(WebCore::MergeIdenticalElementsCommand::doApply):
(WebCore::MergeIdenticalElementsCommand::doUnapply):

  • editing/RemoveNodeCommand.cpp:

(WebCore::RemoveNodeCommand::doApply):
(WebCore::RemoveNodeCommand::doUnapply):

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::executeApply):
(WebCore::SplitElementCommand::doUnapply):

  • editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doApply):
(WebCore::SplitTextNodeCommand::doUnapply):

  • editing/WrapContentsInDummySpanCommand.cpp:

(WebCore::WrapContentsInDummySpanCommand::doUnapply):
(WebCore::WrapContentsInDummySpanCommand::doReapply):

LayoutTests: Multiple Undos removes the last posted comment and/or the ones before it.
<rdar://problem/6557066>
​https://bugs.webkit.org/show_bug.cgi?id=32079

Reviewed by Adele Peterson.

Added test to verify that undo has no effect when an element is
no longer editable.

  • editing/undo/undo-indent-noneditable-expected.txt: Added.
  • editing/undo/undo-indent-noneditable.html: Added.
11:04 AM Changeset in webkit [51644] by beidson@apple.com
  • 67 edits
    29 adds in trunk

<rdar://problem/7214236> and ​http://webkit.org/b/32052 - Implement HTML5 state object history API

Reviewed by Sam Weinig.

WebCore:

Tests: fast/loader/stateobjects/document-destroyed-navigate-back.html

fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html
fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html
fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html
fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html
fast/loader/stateobjects/pushstate-object-types.html
fast/loader/stateobjects/pushstate-then-replacestate.html
fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html
fast/loader/stateobjects/replacestate-then-pushstate.html
http/tests/loading/state-object-security-exception.html

Derived sources and project file changes:

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am
  • WebCore.pro
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Add the new PopStateEvent:

  • dom/PopStateEvent.cpp: Added.

(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::initPopStateEvent):

  • dom/PopStateEvent.h: Added.

(WebCore::PopStateEvent::create):
(WebCore::PopStateEvent::isPopStateEvent):
(WebCore::PopStateEvent::state):

  • dom/PopStateEvent.idl: Added.
  • bindings/js/JSPopStateEventCustom.cpp: Added.

(WebCore::JSPopStateEvent::initPopStateEvent):
(WebCore::JSPopStateEvent::state):

  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • dom/Event.cpp:

(WebCore::Event::isPopStateEvent):

  • dom/Event.h:
  • dom/EventNames.h:

Add the "onpopstate" attribute:

  • html/HTMLAttributeNames.in:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::parseMappedAttribute):

  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::parseMappedAttribute):

  • html/HTMLFrameSetElement.h:
  • html/HTMLFrameSetElement.idl:
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

Add pushState and replaceState management to the loader and history machinery:

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateForSameDocumentNavigation): Augmented from "scrollToAnchor()", combining

both the same-document fragment scroll case with the new same-document state object activation case.

(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):

  • loader/HistoryController.h:
  • history/BackForwardList.cpp:

(WebCore::BackForwardList::addItem): Use insertItemAfterCurrent.
(WebCore::BackForwardList::insertItemAfterCurrent): Optionally insert the item without clearing the forward

list, as pushStateItem might've selectively cleared only certain items, with the bulk of the forward list
meant to remain.

(WebCore::BackForwardList::pushStateItem): Clear the forward list *only* for the state item's document, then

insert the new item.

(WebCore::BackForwardList::removeItem):

  • history/BackForwardList.h:
  • page/History.cpp:

(WebCore::History::urlForState):
(WebCore::History::stateObjectAdded):

  • page/History.h:
  • page/History.idl:

Let HistoryItems and Documents associate with each other, as well as letting HistoryItems contain state objects:

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::setStateObject):
(WebCore::HistoryItem::setDocument):
(WebCore::HistoryItem::documentDetached):

  • history/HistoryItem.h:

(WebCore::HistoryItem::stateObject):
(WebCore::HistoryItem::document):

  • dom/Document.cpp:

(WebCore::Document::detach): Notify all back/forward history items owned by this Document that it

is going away.

(WebCore::Document::registerHistoryItem): Manage the list of back/forward history items this document owns.
(WebCore::Document::unregisterHistoryItem): Ditto.

  • dom/Document.h:

Add the ability for Documents, DocumentLoaders, and FrameLoaderClients to be notified when a Documents
URL changes as the result of pushState(), replaceState(), or a popstate navigation:

  • dom/Document.cpp:

(WebCore::Document::implicitClose): If there's a pending state object, dispatch the popstate event.
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::statePopped): If loading is complete, dispatch the popstate event. Otherwise, set

the pending state object.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::replaceRequestURLForSameDocumentNavigation):

  • loader/DocumentLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDidChangeStateObjectForPageForFrame):

Change handling of "loading a HistoryItem" to distinguish between new-Document navigations and same-Document
navigations, combining the old concept of anchor scrolls with the new concept of state object navigations:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::navigateWithinDocument):
(WebCore::FrameLoader::navigateToDifferentDocument):
(WebCore::FrameLoader::loadItem):

  • loader/FrameLoader.h:
  • page/Page.cpp:

(WebCore::Page::goToItem): Changed to allow state object activations to pass through without the load stopping.

WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidPushStateWithinPage):
(WebKit::FrameLoaderClientImpl::dispatchDidReplaceStateWithinPage):
(WebKit::FrameLoaderClientImpl::dispatchDidPopStateWithinPage):

  • src/FrameLoaderClientImpl.h:

WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidPushStateWithinPage):
(WebKit::FrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebKit::FrameLoaderClient::dispatchDidPopStateWithinPage):

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebFrameLoaderClient::dispatchDidPopStateWithinPage):

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebFrameLoadDelegatePrivate.h:
  • WebView/WebView.mm:

(-[WebView _cacheFrameLoadDelegateImplementations]):

WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidPushStateWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidReplaceStateWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidPopStateWithinPage):

  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

  • Interfaces/IWebFrameLoadDelegatePrivate2.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebFrameLoaderClient::dispatchDidPopStateWithinPage):

  • WebCoreSupport/WebFrameLoaderClient.h:

WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::dispatchDidPushStateWithinPage):
(WebCore::FrameLoaderClientWx::dispatchDidReplaceStateWithinPage):
(WebCore::FrameLoaderClientWx::dispatchDidPopStateWithinPage):

  • WebKitSupport/FrameLoaderClientWx.h:

WebKitTools:

Keep DRT-win building...

  • DumpRenderTree/win/FrameLoadDelegate.h:

(FrameLoadDelegate::didPushStateWithinPageForFrame):
(FrameLoadDelegate::didReplaceStateWithinPageForFrame):
(FrameLoadDelegate::didPopStateWithinPageForFrame):

LayoutTests:

Update expected results of old tests:

  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/security/cross-frame-access-enumeration-expected.txt:

New tests:

  • fast/loader/stateobjects: Added.
  • fast/loader/stateobjects/document-destroyed-navigate-back-expected.txt: Added.
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll-expected.txt: Added.
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html: Added.
  • fast/loader/stateobjects/document-destroyed-navigate-back.html: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-addeventlistener-expected.txt: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-body-attribute-expected.txt: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute-expected.txt: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-window-attribute-expected.txt: Added.
  • fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html: Added.
  • fast/loader/stateobjects/pushstate-object-types-expected.txt: Added.
  • fast/loader/stateobjects/pushstate-object-types.html: Added.
  • fast/loader/stateobjects/pushstate-then-replacestate-expected.txt: Added.
  • fast/loader/stateobjects/pushstate-then-replacestate.html: Added.
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-expected.txt: Added.
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html: Added.
  • fast/loader/stateobjects/replacestate-then-pushstate-expected.txt: Added.
  • fast/loader/stateobjects/replacestate-then-pushstate.html: Added.
  • fast/loader/stateobjects/resources: Added.
  • fast/loader/stateobjects/resources/navigate-back.html: Added.
  • http/tests/loading/state-object-security-exception-expected.txt: Added.
  • http/tests/loading/state-object-security-exception.html: Added.
10:53 AM Changeset in webkit [51643] by kov@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Xan Lopez.

Platform-specific result for test. GIO identifies the file as
application/javascript, as opposed to other platforms identifying
it as application/x-javascript.

  • platform/gtk/inspector/timeline-network-resource-expected.txt: Added.
10:04 AM Changeset in webkit [51642] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-12-03 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium build fix.
r51621 changed JS bindings only, broke v8's.

  • bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument):
  • bindings/v8/ScriptFunctionCall.h:
9:16 AM Changeset in webkit [51641] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

Re-baseline required after r51522.

  • platform/gtk/editing/deleting/5390681-2-expected.txt:
9:09 AM Changeset in webkit [51640] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping new tests, and tests that require new DRT functionality.

9:06 AM Changeset in webkit [51639] by zoltan@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed build fix.

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2009-12-03
[Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.

  • DumpRenderTree/qt/DumpRenderTree.cpp:
8:57 AM Changeset in webkit [51638] by Dimitri Glazkov
  • 6 edits in trunk/WebCore

2009-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

[V8] Attributes and NamedNodeMaps aren't tracked correctly and may be prematurely garbage-collected.
​https://bugs.webkit.org/show_bug.cgi?id=32094

Covered by existing test: LayoutTests/fast/dom/Attr/access-after-element-destruction.html

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8GCController.cpp: (WebCore::ObjectGrouperVisitor::visitDOMWrapper):
  • bindings/v8/custom/V8CustomBinding.h:
8:43 AM Changeset in webkit [51637] by pfeldman@chromium.org
  • 4 edits in trunk

2009-12-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Chromium: Add support for settings containing ":"

​https://bugs.webkit.org/show_bug.cgi?id=32118

  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::loadSettings):
6:25 AM Changeset in webkit [51636] by kenneth@webkit.org
  • 4 edits in trunk/WebCore

repaint events from outside the viewport aren't received
​https://bugs.webkit.org/show_bug.cgi?id=32081

Reviewed by Simon Fraser.

When using a tiled backing store for painting, you need to receive
event from outside the viewport. Setting the viewport to the size
of the contents is not an option if you want to make use of WebCore's
infrastructure for drawing scrollbars etc.

A new property, paintsEntireContents, has been introduced for the
above use-case. It is settable, as tiling will be optional for Qt,
and for the not yet upstreamed EFL port, there will be two different
views, where only one of them are tiled.

No change in behavior, so no new tests added.

  • page/FrameView.cpp:

(WebCore::FrameView::repaintContentRectangle):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::setPaintsEntireContents):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:

(WebCore::ScrollView::paintsEntireContents):

6:24 AM Changeset in webkit [51635] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip layoutTestController.notifyDone() related tests which got revealed in r51634
until there is a fix for the issue.
​https://bugs.webkit.org/show_bug.cgi?id=31626

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2009-12-03
Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped:
6:20 AM Moving to Git edited by maruel@chromium.org
Add Gerrit2 link and the fact that cygwin is already a requirement on … (diff)
6:06 AM Changeset in webkit [51634] by Csaba Osztrogonác
  • 5 edits in trunk

WebKitTools: [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
Prevent DRT from showing the main view if these childs get deleted.
This fixes ​https://bugs.webkit.org/show_bug.cgi?id=31591.

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2009-12-03
Reviewed by Kenneth Rohde Christiansen.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::~DumpRenderTree):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::closeRemainingWindows):
(WebCore::DumpRenderTree::createWindow):
(WebCore::DumpRenderTree::windowCount):

  • DumpRenderTree/qt/DumpRenderTree.h:

LayoutTests: [Qt] Re-enable previously skipped tests.
​https://bugs.webkit.org/show_bug.cgi?id=31591

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2009-12-03
Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped:
5:52 AM Changeset in webkit [51633] by jeremy@chromium.org
  • 5 edits in trunk

Reviewed by Eric Seidel.

Switch Chrome/Mac to use Core Text APIs rather than ATSUI APIs.
​https://bugs.webkit.org/show_bug.cgi?id=31802

No test since this is already covered by existing pixel tests.

  • platform/graphics/SimpleFontData.h: Change #ifdef to define getNSFont() on Chrome/Mac .
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: Provide forward declarations

of Core Text functions that are public on 10.6 but SPI on 10.5.

5:15 AM Changeset in webkit [51632] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector().

  • platform/qt/Skipped:
  • inspector/settings-set-get.html added.
4:46 AM Changeset in webkit [51631] by pfeldman@chromium.org
  • 35 edits
    2 adds in trunk

2009-12-03 Pavel Feldman <​pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

Reviewed by Timothy Hatcher.

Web Inspector: Simplify the settings support in inspector controller.

​https://bugs.webkit.org/show_bug.cgi?id=32076

Test: inspector/settings-set-get.html

  • WebCore.Inspector.exp:
  • bindings/js/JSInspectorFrontendHostCustom.cpp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setting): (WebCore::InspectorController::setSetting): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::attachWindow): (WebCore::InspectorController::setAttachedWindowHeight): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::showWindow): (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setting): (WebCore::InspectorFrontendHost::setSetting):
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • loader/EmptyClients.h: (WebCore::EmptyInspectorClient::populateSetting): (WebCore::EmptyInspectorClient::storeSetting):

WebKit/chromium

  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::hiddenPanels): (WebKit::InspectorClientImpl::populateSetting): (WebKit::InspectorClientImpl::storeSetting): (WebKit::InspectorClientImpl::loadSettings): (WebKit::InspectorClientImpl::saveSettings):
  • src/InspectorClientImpl.h:

WebKit/cf

  • WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::populateSetting): (WebInspectorClient::storeSetting):

WebKit/gtk

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting):
  • WebCoreSupport/InspectorClientGtk.h:

WebKit/haiku

  • WebCoreSupport/InspectorClientHaiku.cpp: (WebCore::InspectorClientHaiku::populateSetting): (WebCore::InspectorClientHaiku::storeSetting):
  • WebCoreSupport/InspectorClientHaiku.h:

WebKit/mac

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):

WebKit/qt

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): (WebCore::InspectorClientQt::storeSetting): (WebCore::variantToSetting): (WebCore::settingToVariant):
  • WebCoreSupport/InspectorClientQt.h:

WebKit/win

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::attachWindow): (WebInspectorClient::detachWindow): (WebInspectorClient::showWindowWithoutNotifications):
  • WebCoreSupport/WebInspectorClient.h:

WebKit/wx

  • WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::populateSetting): (WebCore::InspectorClientWx::storeSetting):
  • WebKitSupport/InspectorClientWx.h:
4:31 AM Changeset in webkit [51630] by benm@google.com
  • 6 edits in trunk

[Android] notifyHistoryItemChanged() should pass a pointer to the HistoryItem that changed.
​https://bugs.webkit.org/show_bug.cgi?id=31915

Reviewed by Brady Eidson.

WebCore:

No change in functionality so no new tests required.

  • history/HistoryItem.cpp:

(WebCore::defaultNotifyHistoryItemChanged): Update this function to pass the HistoryItem that is being changed.
(WebCore::HistoryItem::setAlternateTitle): Update call to notifyHistoryItemChanged to include the new parameter.
(WebCore::HistoryItem::setURLString): ditto.
(WebCore::HistoryItem::setOriginalURLString): ditto.
(WebCore::HistoryItem::setReferrer): ditto.
(WebCore::HistoryItem::setTitle): ditto.
(WebCore::HistoryItem::setTarget): ditto.
(WebCore::HistoryItem::setDocumentState): On Android, add a call to notifyHistoryItemChanged. See bug for a discussion of why this is needed.
(WebCore::HistoryItem::clearDocumentState): ditto.
(WebCore::HistoryItem::setIsTargetItem): ditto.
(WebCore::HistoryItem::addChildItem): ditto.
(WebCore::HistoryItem::setFormInfoFromRequest): ditto.

  • history/HistoryItem.h: Update signature of notifyHistoryItemChanged.

WebKit/mac:

  • History/WebHistoryItem.mm:

(WKNotifyHistoryItemChanged): Update WKNotifyHistoryItemChanged() to add the new HistoryItem parameter added in the WebCore portion of this patch.

  • History/WebHistoryItemInternal.h: ditto.
4:18 AM Changeset in webkit [51629] by benm@google.com
  • 25 edits in trunk

[Android] The FrameLoaderClient is unaware of BackForwardList changes.
​https://bugs.webkit.org/show_bug.cgi?id=31914

Reviewed by Brady Eidson.

WebCore:

This change adds three new methods on the FrameLoaderClient interface to receive notifications when the BackForwardList changes.

No new tests required. Functionality on all platforms upstream remains the same. Android is the first platform to make use of these callbacks.

  • history/BackForwardList.cpp:

(WebCore::BackForwardList::addItem): Execute the callback.
(WebCore::BackForwardList::goBack): ditto.
(WebCore::BackForwardList::goForward): ditto.
(WebCore::BackForwardList::goToItem): ditto.
(WebCore::BackForwardList::setCapacity): dito.

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation for the callback that does nothing.
(WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::EmptyFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.

  • loader/FrameLoaderClient.h:

WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebKit::FrameLoaderClientImpl::dispatchDidRemoveBackForwardItem): ditto.
(WebKit::FrameLoaderClientImpl::dispatchDidChangeBackForwardIndex): dito.

  • src/FrameLoaderClientImpl.h:

WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebKit::FrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebKit::FrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebCore::FrameLoaderClientHaiku::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::FrameLoaderClientHaiku::dispatchDidChangeBackForwardIndex): ditto.

  • WebCoreSupport/FrameLoaderClientHaiku.h:

WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.

WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebCore::FrameLoaderClientQt::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::FrameLoaderClientQt::dispatchDidChangeBackForwardIndex): ditto.

  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.

  • WebCoreSupport/WebFrameLoaderClient.h:

WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebCore::FrameLoaderClientWx::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::FrameLoaderClientWx::dispatchDidChangeBackForwardIndex): ditto.

  • WebKitSupport/FrameLoaderClientWx.h:
3:52 AM Changeset in webkit [51628] by benm@google.com
  • 2 edits
    3 adds in trunk/WebCore

[Android] Upstream WebCore/history/android: Require some platform specific state attached to HistoryItem.
​https://bugs.webkit.org/show_bug.cgi?id=31913

Reviewed by Brady Eidson.

Android stores information such as the zoom scale factor and bridge back to the Java counterpart with HistoryItem.

No new tests required as this is Android specific code.

  • history/HistoryItem.h: Add Android specific member data to HistoryItem.
  • history/android: Added.
  • history/android/AndroidWebHistoryBridge.h: Added.
  • history/android/HistoryItemAndroid.cpp: Added, provides implementation for Android specific member functions in HistoryItem.

(WebCore::HistoryItem::bridge): Added.
(WebCore::HistoryItem::setBridge): Added.

1:22 AM Changeset in webkit [51627] by oliver@apple.com
  • 8 edits
    2 adds in trunk

NULL ptr in SVGPathSegList::getPathSegAtLength()
​https://bugs.webkit.org/show_bug.cgi?id=30313

Reviewed by Maciej Stachowiak.

Add exception checks to SVGPathSegList's implementation to catch (and propagate) exceptions.
Add null checks to SVGList's content manipulation functions to prevent
null values from entering the list in the first place.

Test: svg/dom/svgpath-out-of-bounds-getPathSeg.html

Dec 2, 2009:

11:27 PM Changeset in webkit [51626] by eric@webkit.org
  • 4 edits
    2 adds
    8 deletes in trunk/LayoutTests

2009-12-02 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Rewrite two tests with dumpAsText
​https://bugs.webkit.org/show_bug.cgi?id=32014

  • fast/block/positioning/complex-percentage-height-expected.txt: Added.
  • fast/block/positioning/complex-percentage-height.html:
  • fast/lists/item-not-in-list-line-wrapping-expected.txt: Added.
  • fast/lists/item-not-in-list-line-wrapping.html:
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum: Removed.
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.png: Removed.
  • platform/mac/fast/block/positioning/complex-percentage-height-expected.txt: Removed.
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum: Removed.
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png: Removed.
  • platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed.
  • platform/qt/Skipped:
  • platform/qt/fast/block/positioning/complex-percentage-height-expected.txt: Removed.
  • platform/qt/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed.
10:46 PM Changeset in webkit [51625] by oliver@apple.com
  • 1 edit
    2 adds in trunk/JavaScriptCore

Add files missed in prior patch.

Reviewed by Gavin Barraclough.

10:25 PM Changeset in webkit [51624] by oliver@apple.com
  • 9 edits in trunk/JavaScriptCore

Add zombies to JSC
​https://bugs.webkit.org/show_bug.cgi?id=32103

Reviewed by Gavin Barraclough.

Add a compile time flag to make the JSC collector replace "unreachable"
objects with zombie objects. The zombie object is a JSCell subclass that
ASSERTs on any attempt to use the JSCell methods. In addition there are
a number of additional assertions in bottleneck code to catch zombie usage
as quickly as possible.

Grrr. Argh. Brains.

10:14 PM Changeset in webkit [51623] by eric@webkit.org
  • 9 edits
    2 adds in trunk

2009-12-02 Yusuke Sato <​yusukes@chromium.org>

Reviewed by Eric Seidel.

Sanitize web fonts using the OTS library
​https://bugs.webkit.org/show_bug.cgi?id=31106

Add support for OpenType sanitizer (OTS). It parses OpenType files (from @font-face)
and attempts to validate and sanitize them. We hope this reduces the attack surface
of the system font libraries.

  • WebCore.gyp/WebCore.gyp: Added dependency to (chromium_src_dir)/third_party/ots/ library.
  • WebCore.gypi: Added new files below.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/chromium/FontCustomPlatformData.cpp: Validate and transcode a web font. (WebCore::createFontCustomPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.cpp: Ditto. (WebCore::createFontCustomPlatformData):
  • platform/graphics/opentype/OpenTypeSanitizer.cpp: Added. (WebCore::OpenTypeSanitizer::sanitize):
  • platform/graphics/opentype/OpenTypeSanitizer.h: Added. (WebCore::OpenTypeSanitizer::OpenTypeSanitizer):

2009-12-02 Yusuke Sato <​yusukes@chromium.org>

Reviewed by Eric Seidel.

Sanitize web fonts using the OTS library
​https://bugs.webkit.org/show_bug.cgi?id=31106

  • DEPS: Added dependency to the OpenType sanitizer library.
  • features.gypi: Added ENABLE_OPENTYPE_SANITIZER=1.
9:31 PM Changeset in webkit [51622] by eric@webkit.org
  • 5 edits
    1 add in trunk/WebKitTools

2009-12-02 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(51595): commit-queue is throwing exceptions
​https://bugs.webkit.org/show_bug.cgi?id=32083

  • Scripts/modules/commands/queues.py:
    • Don't use default value of [] as it ends up getting shared.
    • Make log_progress accept arrays of ints as well as strings.
    • Return an exit code from execute()
  • Scripts/modules/commands/queues_unittest.py: Added.
    • Test to make sure log_progress will accept ints.
    • Test to make sure run_bugzilla_tool will accept ints.
  • Scripts/modules/workqueue.py:
    • Print the stack trace on unexpected exceptions for easier debugging.
  • Scripts/run-webkit-unittests:
    • Add queues_unittest.
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
  • Scripts/modules/mock_bugzillatool.py:
  • Scripts/modules/workqueue.py:
  • Scripts/run-webkit-unittests:
9:20 PM Changeset in webkit [51621] by oliver@apple.com
  • 5 edits in trunk/WebCore

Web Inspector frontend heap allocates ScriptFunctionCall which is unsafe
​https://bugs.webkit.org/show_bug.cgi?id=32098

Reviewed by Sam Weinig.

Fix is simply to make the ScriptFunctionCall stack allocated as nature intended
Doing this required adding an appendArgument(char*) to ScriptFunctionCall so
that an explicit String cast would not be necessary.

To prevent something like this happening again in future i've added private
operator new implementations to ScriptFunctionCall making this type of mistake
produce errors when compiling.

Test case: Inspector tests now pass with GC on every alloc enabled.

9:10 PM Changeset in webkit [51620] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Fix a mistake in the previous change

Reviewed by Mark Rowe.

  • WebView/WebView.mm:

(+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
Make sure to include the image types’ view and representation classes
even when plug-ins are not allowed.

9:08 PM Changeset in webkit [51619] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-02 David Levin <​levin@chromium.org>

Reviewed by Adam Barth.

check-webkit-style is too noisy about namespace indenting issues.
​https://bugs.webkit.org/show_bug.cgi?id=32096

  • Scripts/modules/cpp_style.py: Added a _FileState object to be able to track file level information. In this case, it simply tracks whether the error has already been given, so that it isn't done again.
  • Scripts/modules/cpp_style_unittest.py: Modified test cases to pass in the _FileState object and fix a test that expected to see the namespace error twice (now it only occurs once). No new tests because existing tests cover the change in functionality.
4:38 PM Changeset in webkit [51618] by kevino@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

Reviewed by Eric Seidel.

[wx] Get DumpRenderTree building after waf switch.

​https://bugs.webkit.org/show_bug.cgi?id=32041

4:22 PM Changeset in webkit [51617] by mitz@apple.com
  • 8 edits in trunk/WebKit/mac

Fixed <rdar://problem/7254127> WebKit can load plug-ins even when
plug-ins are disabled

Reviewed by Anders Carlsson.

Ensure that the shared WebPluginDatabase is not instantiated if no
WebViews are used that have plug-ins enabled.

  • DefaultDelegates/WebDefaultPolicyDelegate.m:

(-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
Call -[WebView _canShowMIMEType:] on the WebView instead of calling the
class method.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::canShowMIMEType): Ditto.
(WebFrameLoaderClient::transitionToCommittedForNewPage): Call
-[WebFrameView _viewClassForMIMEType:] on the WebView instead of calling
the class method.
(WebFrameLoaderClient::objectContentType): Ditto.

  • WebView/WebDataSource.mm:

(+[WebDataSource _representationClassForMIMEType:allowingPlugins:]):
Added the allowPlugins parameter, which is passed through to
+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:].
(-[WebDataSource _makeRepresentation]): Pass an allowPlugins value
based on the WebView’s preferences.

  • WebView/WebFrameView.mm:

(-[WebFrameView _makeDocumentViewForDataSource:]): Call
-[WebFrameView _viewClassForMIMEType:] instead of calling the class
method.
(+[WebFrameView _viewClassForMIMEType:allowingPlugins:]): Added the
allowPlugins parameter, which is passed through to
+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:].
(-[WebFrameView _viewClassForMIMEType:]): Added. Passes an allowPlugins
value based on the WebView’s preferences.

  • WebView/WebFrameViewInternal.h:
  • WebView/WebView.mm:

(+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
Added the allowPlugins parameter. If false, skip the instantiation of
the shared WebPluginDatabase.
(-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Pass an
allowPlugins value based on the WebView’s preferences.
(+[WebView _canShowMIMEType:allowingPlugins:]): Passes allowPlugins to
+_viewClass:andRepresentationClass:forMIMEType:allowingPlugins:.
(+[WebView canShowMIMEType:]): Changed to pass YES to
+_canShowMIMEType:allowingPlugins:.
(-[WebView _canShowMIMEType:]): Added. Passes an allowPlugins value
based on the WebView’s preferences.
(-[WebView _pluginForMIMEType:]): Return nil if plug-ins are disabled.
(-[WebView _pluginForExtension:]): Ditto.
(-[WebView _isMIMETypeRegisteredAsPlugin:]): Return NO if plug-ins are
disabled.

  • WebView/WebViewInternal.h:
3:39 PM Changeset in webkit [51616] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Fixes a crash when scrolling a frame that goes away mid-scroll.

<rdar://problem/7400263>

Reviewed by John Sullivan.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]): Retain self incase the last
reference is released when calling super.

3:25 PM Changeset in webkit [51615] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=32089
Test that WebSocket.readyState is set correctly

  • websocket/tests/script-tests/simple.js: (ws.onopen): (ws.onmessage): (ws.onclose):
  • websocket/tests/simple-expected.txt: Added readyState logging.
3:21 PM Changeset in webkit [51614] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-12-02 Evan Stade <​estade@chromium.org>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=32029
Mousewheel event delta has reversed sign on Linux Chrome.

No new tests (layout tests don't cover event conversion code).
Manual test: ​http://www.switchonthecode.com/tutorials/javascript-tutorial-the-scroll-wheel

  • src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::mouseWheelEvent):
1:36 PM Changeset in webkit [51613] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Make change-values-during-transition less flaky. Transition is 1 sec duration,
translating 100px, starting at 0, so it should be at 50px at 500ms, not 600ms.

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31997

  • transitions/change-values-during-transition.html:

isEqual: Remove unnecessary code - tolerance always passed in and always default value.
getXPosition: Extract into a function, since it is duplicated twice.
check2: Still run second check if the first fails, just give more debugging output.
start: Remove final setTimeout - nothing changes between the end of check2 and here,

so this is just making the test take 100ms longer.

1:24 PM Changeset in webkit [51612] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to fix the Safari build.

1:10 PM Changeset in webkit [51611] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Skip http/tests/cache/subresource-failover-to-network.html because it
is flaky on Windows, fixing it is being tracked by
​https://bugs.webkit.org/show_bug.cgi?id=32038.

  • platform/win/Skipped:
11:47 AM Changeset in webkit [51610] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Put tests into skiplist because of missing layoutTestController.evaluateInWebInspector().

  • platform/qt/Skipped:
  • inspector/elements-panel-selection-on-refresh.html added.
  • inspector/timeline-event-dispatch.html added.
11:34 AM Changeset in webkit [51609] by timothy@apple.com
  • 1 edit in trunk/WebKit/win/DOMHTMLClasses.h

Build fix.

11:27 AM Changeset in webkit [51608] by hyatt@apple.com
  • 7 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=32072, clean up invalid @-rule error handling so that we
pass more CSS test suite stuff. Make the grammar stop enforcing the ordering of @namespace vs.
@variables vs. @import. Just let the parser handle that instead. This simplifies the grammar and
makes error handling deal with more cases correctly.

Reviewed by Darin Adler.

Added fast/css/namespaces/namespaces-invalid-at-rules.xml

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::createCharsetRule):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::addNamespace):
(WebCore::CSSParser::createVariablesRule):

  • css/CSSParser.h:
11:24 AM Changeset in webkit [51607] by timothy@apple.com
  • 2 edits in trunk/WebKit/win

Move setValueForUser to the end of the DOMHTMLInputElement interface
so it is fine for binary compatibility.

Directed by Steve Falkenburg.

  • Interfaces/DOMHTML.idl:
11:21 AM Changeset in webkit [51606] by timothy@apple.com
  • 3 edits in trunk/WebKit/win

Expose setValueForUser for the COM DOMHTMLInputElement.

<rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::setValueForUser):

  • Interfaces/DOMHTML.idl:
11:17 AM Changeset in webkit [51605] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-02 Yusuke Sato <​yusukes@chromium.org>

Reviewed by Dan Bernstein.

Safari/Chromium for Windows fails to load CJK WebFonts
​https://bugs.webkit.org/show_bug.cgi?id=31804

  • platform/graphics/opentype/OpenTypeUtilities.cpp: (WebCore::renameAndActivateFont): Load a remote font even if the font has 2 or more faces.
11:10 AM Changeset in webkit [51604] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-12-02 Eric Z. Ayers <​zundel@google.com>

Reviewed by Pavel Feldman.

Adds a timeline test for EventDispatch records.

​https://bugs.webkit.org/show_bug.cgi?id=31376

  • inspector/timeline-event-dispatch-expected.txt: Added.
  • inspector/timeline-event-dispatch.html: Added.
11:03 AM Changeset in webkit [51603] by eric@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2009-12-02 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Fisher.

Chromium: Need tickmarks in scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=32069

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ScrollbarThemeChromiumMac.h: Added.
  • platform/chromium/ScrollbarThemeChromiumMac.mm: Added.
10:34 AM Changeset in webkit [51602] by timothy@apple.com
  • 10 edits in trunk

WebCore: Expose a function to set the value of an input element on behalf of the user.
This function will dispatch the change event so the page is notified when autofill
happens. Also dispatch a change event when a select element is changed by autofill.

<rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Added the DOMHTMLInputElementPrivate.h header.
  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLSelectElement _activateItemAtIndex:]): Call setSelectedIndexByUser instead so
a change event is fired. This method is called by Safari autofill.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode): Use dispatchFormControlChangeEvent instead
of dispatching the change event directly to be consistent.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLInputElement::setValueForUser): Added. Calls setValue with the sendChangeEvent
(WebCore::HTMLInputElement::setValue): Added the optional sendChangeEvent argument. Mimics setChecked.

  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl: Added setValueForUser for non-JS languages.
  • html/InputElement.h: Added setValueForUser.

WebKit/mac: Migrate DOMHTMLInputElementPrivate.h as a private header.

Reviewed by Darin Adler.

  • MigrateHeaders.make:
10:32 AM Changeset in webkit [51601] by pfeldman@chromium.org
  • 12 edits
    2 adds in trunk

2009-12-02 Pavel Feldman <​pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

Reviewed by Timothy Hatcher.

Web Inspector: DOM tree selection disappears upon page refresh.

​https://bugs.webkit.org/show_bug.cgi?id=31142

Test: inspector/elements-panel-selection-on-refresh.html

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodeByPathToFrontend):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent): (WebCore::InspectorController::resetScriptObjects):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::reset): (WebCore::InspectorDOMAgent::setDocument): (WebCore::InspectorDOMAgent::pushDocumentToFrontend): (WebCore::InspectorDOMAgent::nodeForPath): (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._setDocument):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.setDocument.selectDefaultNode): (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/InjectedScript.js: (InjectedScript.pushNodeByPathToFrontend):
  • inspector/front-end/InjectedScriptAccess.js:
7:33 AM Changeset in webkit [51600] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=32045, make sure escape sequences work with
all the @-rules we support. When escape sequences are present, the lexical scanner
just returns a generic token name: ATKEYWORD. We have to process the escape sequences
and then recheck against the rules we support with the final processed name. If we
find a match, we mutate the token value to the appropriate rule name token, e.g.,
NAMESPACE_SYM.

Reviewed by Dan Bernstein.

Added fast/css/namespaces/namespaces-escapes.xml

  • css/CSSParser.cpp:

(WebCore::CSSParser::lex):
(WebCore::CSSParser::recheckAtKeyword):
(WebCore::CSSParser::text):

  • css/CSSParser.h:
6:52 AM Changeset in webkit [51599] by eric@webkit.org
  • 5 edits in trunk

2009-12-02 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.:w

Allow to skip thread checks when accessing DOMDataStore for processes
which run V8 in single thread mode.
​https://bugs.webkit.org/show_bug.cgi?id=31877

Should be covered by buildbots.

  • bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::enableFasterDOMStoreAccess): (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap):
  • bindings/v8/V8DOMMap.h:

2009-12-02 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

Allow to skip thread checks when accessing DOMDataStore for processes
which run V8 in single thread mode.
​https://bugs.webkit.org/show_bug.cgi?id=31877

  • src/WebScriptController.cpp: (WebKit::WebScriptController::enableV8SingleThreadMode):
5:12 AM Changeset in webkit [51598] by yurys@chromium.org
  • 15 edits
    4 deletes in trunk/WebCore

2009-12-02 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Code clean up: remove ScriptObjectQuarantine.* as a whole.

​https://bugs.webkit.org/show_bug.cgi?id=32060

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/ScriptObjectQuarantine.cpp: Removed.
  • bindings/js/ScriptObjectQuarantine.h: Removed.
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::quarantineValue):
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptObjectQuarantine.cpp: Removed.
  • bindings/v8/ScriptObjectQuarantine.h: Removed.
  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::quarantineValue):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/InspectorController.cpp:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorFrontend.cpp:
4:55 AM Changeset in webkit [51597] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] r51577 made fast/frames/sandboxed-iframe-plugins.html crash.

  • platform/qt/Skipped:
  • fast/frames/sandboxed-iframe-navigation-windowopen.html added. (crasher)
2:51 AM Changeset in webkit [51596] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] build-attachment shouldn't check whether the builders are red
​https://bugs.webkit.org/show_bug.cgi?id=32062

build-attachment doesn't touch the remote repository, so there isn't a
need to hold off when the builders are red.

  • Scripts/modules/commands/download.py:
  • Scripts/modules/landingsequence.py:
2:44 AM Changeset in webkit [51595] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-02 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(51590): style-queue and build-queue think their empty when they are not
​https://bugs.webkit.org/show_bug.cgi?id=32061

  • Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
  • Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
2:18 AM Changeset in webkit [51594] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed. Skip new tests.

  • platform/qt/Skipped:
  • svg/custom/mask-with-all-units.svg added.
  • fast/css/namespaces/namespaces-comments.xml added.
  • fast/css/namespaces/namespaces-empty.xml added.
1:59 AM Writing Layout Tests for DumpRenderTree edited by skylined@chromium.org
Document setCanOpenWindows (based on an example I found, not actual … (diff)
1:43 AM Changeset in webkit [51593] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-02 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

build-queue is throwing exceptions and complaining about
lack of --no-update on build-attachment. Make it stop.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
1:15 AM Changeset in webkit [51592] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-02 Adam Barth <​abarth@webkit.org>

Unreviewed "build" fix. Forgot to declare my variables. :(

  • QueueStatusServer/queue_status.py:
1:11 AM Changeset in webkit [51591] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2009-12-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Implement status bubble view
​https://bugs.webkit.org/show_bug.cgi?id=32057

The status bubble is a compact representation of the queue status for a
given patch. This will eventually help us reduce the comment spam from
the queues.

  • QueueStatusServer/index.html: Added HTML5 doctype for sanity.
  • QueueStatusServer/queue_status.py:
  • QueueStatusServer/status_bubble.html: Added.
1:04 AM Changeset in webkit [51590] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2009-12-02 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

trim commands/*.py includes now that commands are unit tested
​https://bugs.webkit.org/show_bug.cgi?id=32056

In the course of ensuring that the unit tests still
passed after this change, I had to actually make them
pass in the first place.

  • Scripts/modules/bugzilla.py:
    • Fix _parse_attachment_ids_request_query to return ints instead of strings.
  • Scripts/modules/commands/download.py: Remove unneeded imports.
  • Scripts/modules/commands/queries.py: Ditto.
  • Scripts/modules/commands/queues.py: Ditto.
  • Scripts/modules/commands/upload.py: Ditto.
  • Scripts/modules/scm_unittest.py:
    • Fix to expect the \n after the path since echo adds an \n.
12:19 AM Changeset in webkit [51589] by ukai@chromium.org
  • 4 edits
    17 adds in trunk

2009-12-02 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket handshake check query component of URL
​https://bugs.webkit.org/show_bug.cgi?id=31617

  • websocket/tests/echo-location_wsh.py: Added.
  • websocket/tests/no-query_wsh.py: Added.
  • websocket/tests/script-tests/url-with-credential.js: Added.
  • websocket/tests/script-tests/url-with-empty-query.js: Added.
  • websocket/tests/script-tests/url-with-fragment.js: Added.
  • websocket/tests/script-tests/url-with-query-for-no-query.js: Added.
  • websocket/tests/script-tests/url-with-query.js: Added.
  • websocket/tests/url-with-credential-expected.txt: Added.
  • websocket/tests/url-with-credential.html: Added.
  • websocket/tests/url-with-empty-query-expected.txt: Added.
  • websocket/tests/url-with-empty-query.html: Added.
  • websocket/tests/url-with-fragment-expected.txt: Added.
  • websocket/tests/url-with-fragment.html: Added.
  • websocket/tests/url-with-query-expected.txt: Added.
  • websocket/tests/url-with-query-for-no-query-expected.txt: Added.
  • websocket/tests/url-with-query-for-no-query.html: Added.
  • websocket/tests/url-with-query.html: Added.

2009-12-02 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket handshake check query component of URL
​https://bugs.webkit.org/show_bug.cgi?id=31617

Tests: websocket/tests/url-with-credential.html

websocket/tests/url-with-empty-query.html
websocket/tests/url-with-fragment.html
websocket/tests/url-with-query-for-no-query.html
websocket/tests/url-with-query.html

  • platform/KURLGoogle.cpp: (WebCore::KURL::query): returns a null if query is not specified and returns an empty if query is specified but empty.
  • websockets/WebSocketHandshake.cpp: (WebCore::resourceName): added. add query component to path if specified. (WebCore::WebSocketHandshake::clientLocation): (WebCore::WebSocketHandshake::clientHandshakeMessage):
Note: See TracTimeline for information about the timeline view.