⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 7, 2009:

10:00 PM Changeset in webkit [51836] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix to make QtBuildBot green.
Skip failing tests caused by r51828 (Turn on (SVG) Filters for Qt.)
​https://bugs.webkit.org/show_bug.cgi?id=32224
​http://build.webkit.org/results/Qt%20Linux%20Release/r51828%20(4620)/results.html

  • platform/qt/Skipped:
9:58 PM Changeset in webkit [51835] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2009-12-07 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

[check-webkit-style] S_OK is a fine identifier
​https://bugs.webkit.org/show_bug.cgi?id=32225

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
9:48 PM Changeset in webkit [51834] by hamaji@chromium.org
  • 5 edits in trunk/LayoutTests

2009-12-07 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

editing/selection/last-empty-inline is failing in Windows
​https://bugs.webkit.org/show_bug.cgi?id=31985

  • editing/selection/last-empty-inline-expected.txt:
  • editing/selection/last-empty-inline.html:
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:29 PM Changeset in webkit [51833] by hamaji@chromium.org
  • 3 edits in trunk/WebCore

2009-12-07 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Add a function to show render tree for debugging
​https://bugs.webkit.org/show_bug.cgi?id=31288

No new tests because this just adds a function for debugging.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::showRenderObject): (WebCore::RenderObject::showRenderTreeAndMark): (showRenderTree):
  • rendering/RenderObject.h:
8:55 PM Changeset in webkit [51832] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-12-07 Zhe Su <​suzhe@chromium.org>

Reviewed by Darin Fisher.

[Chromium] accesskey is not supported on Chromium Mac.
​https://bugs.webkit.org/show_bug.cgi?id=32213

This change fixes (partially) the accesskey issue by decoupling the
code for handling accesskeys and system keys. Because on Mac,
the modifiers of accesskeys are ctrl+alt, which are not marked as
system keys.
In order to fully fix this issue, some changes in Chromium code is
also required.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::charEvent):
8:33 PM Changeset in webkit [51831] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-07 Victor Wang <​victorw@chromium.org>

Reviewed by Dimitri Glazkov.

Implement NamedPropertyEnumerator and IndexedPropertyEnumerator for
V8 NPObject. This should make the object enumerable and fix the
enumeration issue in layout test plugins/netscape-enumerate.html.

Also fix some existing style issues per webkit style guidelines.

​https://bugs.webkit.org/show_bug.cgi?id=32254

Test: plugins/netscape-enumerate.html

  • bindings/v8/V8NPObject.cpp: (npObjectInvokeImpl): (npObjectInvokeDefaultHandler): (npObjectGetProperty): (npObjectPropertyEnumerator): (npObjectNamedPropertyEnumerator): (npObjectIndexedPropertyEnumerator): (createV8ObjectForNPObject):
8:19 PM Changeset in webkit [51830] by ukai@chromium.org
  • 5 edits
    3 deletes in trunk

2009-12-07 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fragments now make WebSocket URL parsing fail.
​https://bugs.webkit.org/show_bug.cgi?id=32144

  • websocket/tests/script-tests/url-parsing.js:
  • websocket/tests/script-tests/url-with-fragment.js: Removed.
  • websocket/tests/url-parsing-expected.txt:
  • websocket/tests/url-with-fragment-expected.txt: Removed.
  • websocket/tests/url-with-fragment.html: Removed.

2009-12-07 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fragments now make WebSocket URL parsing fail.
​https://bugs.webkit.org/show_bug.cgi?id=32144

  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
8:03 PM Changeset in webkit [51829] by ukai@chromium.org
  • 5 edits in trunk

2009-12-07 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Darin Adler.

Fix wrong length parsing in WebSocket.
​https://bugs.webkit.org/show_bug.cgi?id=32203

These two tests assumed wrong length encoding in frame: it parsed
length from bytes with 8th bit on. But spec says length is encoded
as a series of 7-bit bytes stored in octests with the 8th bit on
*but the last byte*.
These tests encodes a frame that has 129 length, so it must be
\x81\0x01 instead of \x81\0x81.

  • websocket/tests/frame-length-longer-than-buffer_wsh.py:
  • websocket/tests/frame-length-skip_wsh.py:

2009-12-07 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Darin Adler.

Fix wrong length parsing in WebSocket.
​https://bugs.webkit.org/show_bug.cgi?id=32203

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
7:44 PM Changeset in webkit [51828] by Nikolas Zimmermann
  • 6 edits in trunk

2009-12-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Rubber-stamped by Maciej Stachowiak.

Turn on (SVG) Filters for Qt.
​https://bugs.webkit.org/show_bug.cgi?id=32224

6:54 PM Changeset in webkit [51827] by eric@webkit.org
  • 8 edits in trunk

2009-12-07 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

Chromium: theme scrollbars to match GTK theme.
Add functions to RenderThemeChromiumLinux to change the scrollbar
color.

Since the change is to the Chromium WebKit API layer, testing will
be in Chromium's test shell.
​http://bugs.webkit.org/show_bug.cgi?id=32048

Patch from Markus Gutschke <​markus@chromium.org>.

  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::saturateAndBrighten): (WebCore::outlineColor): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::setScrollbarColors):
  • rendering/RenderThemeChromiumLinux.h: (WebCore::RenderThemeChromiumLinux::thumbInactiveColor): (WebCore::RenderThemeChromiumLinux::thumbActiveColor): (WebCore::RenderThemeChromiumLinux::trackColor):

2009-12-07 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

Chromium: theme scrollbars to match GTK theme.
Add API to set the colors.

Since the change is to the Chromium WebKit API layer, testing will
be in Chromium's test shell.
​http://bugs.webkit.org/show_bug.cgi?id=32048

Patch from Markus Gutschke <​markus@chromium.org>.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setScrollbarColors):
  • src/WebViewImpl.h:
6:50 PM Changeset in webkit [51826] by hamaji@chromium.org
  • 2 edits in trunk/BugsSite

2009-12-07 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Kilzer.

Bugzilla should show images in git patches
​https://bugs.webkit.org/show_bug.cgi?id=31395

Attempt to go r51748 again using --directory option of git-apply.

  • PrettyPatch/PrettyPatch.rb:
6:44 PM Changeset in webkit [51825] by kov@webkit.org
  • 10 edits in trunk

WebCore

Reviewed by Xan Lopez.

[GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that
​https://bugs.webkit.org/show_bug.cgi?id=32247

Allow creating a ResourceResponse from a SoupMessage.

Covered by API test.

  • platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):

WebKit/gtk

Reviewed by Xan Lopez.

[GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that
​https://bugs.webkit.org/show_bug.cgi?id=32247

Provide a way for applications to respect Content-Disposition, by
fetching the WebKitNetworkResponse from the frame during
mime-type-policy-decision-requested.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Download content when Content-Disposition is attachment.
  • tests/testmimehandling.c: (server_callback): (mime_type_policy_decision_requested_cb):
  • tests/testwebframe.c: (test_webkit_web_frame_response): (main):
  • webkit/webkitprivate.cpp: (WebKit::core):
  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_network_response):
  • webkit/webkitwebframe.h:
6:40 PM Changeset in webkit [51824] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-07 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Make run-webkit-websocketserver log to stderr rather than to a file.
​https://bugs.webkit.org/show_bug.cgi?id=32234

  • Scripts/run-webkit-websocketserver:
6:29 PM Changeset in webkit [51823] by Nikolas Zimmermann
  • 3 edits
    3 deletes in trunk

2009-12-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Reverting problematic patch, causing errors.

Revert r51789 (Avoid zero division during SVGPaintServerPattern::setup()). Crashes on all Windows slaves.
Reopen bug ​https://bugs.webkit.org/show_bug.cgi?id=29912.

  • svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
6:26 PM Changeset in webkit [51822] by tkent@chromium.org
  • 6 edits
    9 adds in trunk

2009-12-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Add tests for HTMLInputElement::stepUp() and stepDown().
​https://bugs.webkit.org/show_bug.cgi?id=27451

  • fast/forms/input-step-number-expected.txt: Added.
  • fast/forms/input-step-number.html: Added.
  • fast/forms/input-step-range-expected.txt: Added.
  • fast/forms/input-step-range.html: Added.
  • fast/forms/input-step-unsupported-expected.txt: Added.
  • fast/forms/input-step-unsupported.html: Added.
  • fast/forms/script-tests/input-step-number.js: Added.
  • fast/forms/script-tests/input-step-range.js: Added.
  • fast/forms/script-tests/input-step-unsupported.js: Added.

2009-12-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Add support for HTMLInputElement::stepUp() and stepDown() for
type=number and type=range.
​https://bugs.webkit.org/show_bug.cgi?id=27451

Our implementation of stepUp() and stepDown() rounds the resultant
value to conform to the step value.
Change the number-string conversion method for RenderSlider to be
consistent with type=number.

Tests: fast/forms/input-step-number.html

fast/forms/input-step-range.html
fast/forms/input-step-unsupported.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): Unify the code for NUMBER and RANGE. (WebCore::HTMLInputElement::rangeOverflow): Unify the code for NUMBER and RANGE. (WebCore::HTMLInputElement::minimum): Renamed from rangeMinimum(), and support for NUMBER. (WebCore::HTMLInputElement::maximum): Renamed from rangeMaximum(), and support for NUMBER. (WebCore::HTMLInputElement::stepBase): (WebCore::HTMLInputElement::stepMismatch): Use stepBase(). (WebCore::HTMLInputElement::applyStepForNumberOrRange): (WebCore::HTMLInputElement::stepUp): (WebCore::HTMLInputElement::stepDown): (WebCore::HTMLInputElement::formStringFromDouble):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::stepUp): (WebCore::HTMLInputElement::stepDown):
  • html/HTMLInputElement.idl: Add stepUp() and stepDown().
  • rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): Sync with rangeMinimum()/rangeMaximum() renaming. (WebCore::RenderSlider::updateFromElement): Use formStringFromDouble(). (WebCore::RenderSlider::setValueForPosition): Use formStringFromDouble().
6:21 PM Changeset in webkit [51821] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed: Chromium build fix try 2 (dumb error).

  • bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::getString):

5:55 PM Changeset in webkit [51820] by ajwong@chromium.org
  • 3 edits in trunk/WebCore

Not reviewed: Chromium build fix.

Fix Chromium build break caused by an added dependency from

ScriptControllerBase to JSDOMWindowShell, and an API change in
ScriptValue.

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::getString):

5:31 PM Changeset in webkit [51819] by enrica@apple.com
  • 3 edits
    2 adds in trunk

WebCore: REGRESSION(4.0.4-42a12): Indent does not work for twice modified with background text in gmail.
<rdar://problem/7442387>
​https://bugs.webkit.org/show_bug.cgi?id=32233

Reviewed by Darin Adler.

Fixes problem in re-creating the correct hierarchy under the new block.
Added extensive testing to cover all the cases.

Test: editing/execCommand/indent-with-style2.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

LayoutTests: REGRESSION(4.0.4-42a12): Indent does not work for twice modified with background text in gmail.
<rdar://problem/7442387>
​https://bugs.webkit.org/show_bug.cgi?id=32233

Reviewed by Darin Adler.

  • editing/execCommand/indent-with-style2-expected.txt: Added.
  • editing/execCommand/indent-with-style2.html: Added.
5:22 PM Changeset in webkit [51818] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2009-12-07 Finnur Thorarinsson <​finnur.webkit@gmail.com>

Reviewed by Darin Fisher.

A patch for Chromium to restrict the scope of the Gmail focus fix,
where we set the Selection to 0,0 for content-editable fields and
also make sure we set the selection end-state for find to select the
text found (when not focusing a link we found).
WebKit bug: ​https://bugs.webkit.org/show_bug.cgi?id=32248

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setFocus):
5:15 PM Changeset in webkit [51817] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

Not reviewed. Add some missing files that depend on SVG Filters support, only mac supports it for now.
Still one more crash affecting the win slaves, unrelated to the filters patch though.

5:03 PM Changeset in webkit [51816] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Windows build fix for checkouts with a space in the path

  • win/tools/scripts/auto-version.sh: Quote the output file's directory

before passing it to mkdir.

4:59 PM Changeset in webkit [51815] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed. Skip a timeouter flakey test.

  • platform/qt/Skipped: fast/frames/sandboxed-iframe-plugins.html added.
4:51 PM Changeset in webkit [51814] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

Not reviewed. Skip yet another test, what a journey...

4:50 PM Changeset in webkit [51813] by dimich@chromium.org
  • 15 edits in trunk

Remove ENABLE_SHARED_SCRIPT flags
​https://bugs.webkit.org/show_bug.cgi?id=32245
This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.

Rubber-stamped by Darin Adler.

  • configure.ac:

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pro:

WebKit/chromium:

  • features.gypi:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKitTools:

  • Scripts/build-webkit:
4:40 PM Changeset in webkit [51812] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

Not reviewed. Adjust one layout test to the results of the Leopard Intel slave.

4:37 PM Changeset in webkit [51811] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

Not reviewed. Turn Qt slave green again, after landing filters.

4:10 PM Changeset in webkit [51810] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2009-12-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Force JS binding regeneration, eventually fixing the broken tests on the bots.

  • bindings/scripts/CodeGeneratorJS.pm:
4:04 PM Changeset in webkit [51809] by mitz@apple.com
  • 5 edits in trunk/LayoutTests

Corrected expected results

  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum:
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.checksum:
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.png:
4:02 PM Changeset in webkit [51808] by mitz@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Rubber-stamped by Simon Fraser.

Re-enabled this test now that <rdar://problem/7450481> is fixed.

  • fast/repaint/block-selection-gap-in-composited-layer.html: Copied from LayoutTests/fast/repaint/block-selection-gap-in-composited-layer.html.disabled.
  • fast/repaint/block-selection-gap-in-composited-layer.html.disabled: Removed.
4:00 PM Changeset in webkit [51807] by bweinstein@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Add new exported symbols to finally fix the build.

3:53 PM Changeset in webkit [51806] by barraclough@apple.com
  • 2 edits in trunk/WebKit/win
  • WebView.cpp:

(WebView::stringByEvaluatingJavaScriptFromString):

Reviewed by NOBODY (Windows build fix part III).

3:47 PM Changeset in webkit [51805] by barraclough@apple.com
  • 2 edits in trunk/WebKit/win
  • WebView.cpp:

(WebView::stringByEvaluatingJavaScriptFromString):

Reviewed by NOBODY (Windows build fix part II).

3:30 PM Changeset in webkit [51804] by Simon Fraser
  • 11 edits in trunk

2009-12-07 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

<rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests

The counter that WebView used to keep track of the number of enclosed WebHTMLViews using
accelerated compositing was hard to manage, and maintained incorrectly in a number of cases.
This caused one compositing test make DumpRenderTree think that all subsequent tests
were compositing too.

Replace this counter with notifications, which are only fired if a client (DRT) requests them. The
notification informs the client that a WebHTMLView entered compositing mode (or an already-
compositing WebHTML was added); it does not say when a view becomes uncomposited, or all
compositing subviews were removed, since this is tricky to get right.

Change -[WebView _isUsingAcceleratedCompositing] to manually walk the frames, and
return YES if any document view is composited.

  • WebKit.exp:
  • WebView/WebHTMLView.mm: (-[WebHTMLView close]): (-[WebHTMLView viewDidMoveToSuperview]): (-[WebHTMLView attachRootLayer:]): (-[WebHTMLView detachRootLayer]):
  • WebView/WebView.mm: (+[WebView automaticallyNotifiesObserversForKey:]): (-[WebView _postsAcceleratedCompositingNotifications]): (-[WebView _setPostsAcceleratedCompositingNotifications:]): (-[WebView _isUsingAcceleratedCompositing]):
  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
3:26 PM Changeset in webkit [51803] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (Windows build fixage part I).

3:15 PM Changeset in webkit [51802] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2009-12-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Try to fix mac builds by touching svgtags.in - I only tried from-scratch builds.

  • svg/svgtags.in:
3:14 PM Changeset in webkit [51801] by barraclough@apple.com
  • 42 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=32184
Handle out-of-memory conditions with JSC Ropes with a JS exception, rather than crashing.
Switch from using fastMalloc to tryFastMalloc, pass an ExecState to record the exception on.

Reviewed by Oliver Hunt.

JavaScriptCore:

  • API/JSCallbackObjectFunctions.h:

(JSC::::toString):

  • API/JSValueRef.cpp:

(JSValueIsStrictEqual):

(JSC::BytecodeGenerator::emitEqualityOp):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::calculatedFunctionName):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):
(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::addParentForConsoleStart):

  • profiler/Profiler.cpp:

(JSC::Profiler::willExecute):
(JSC::Profiler::didExecute):
(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):

  • profiler/Profiler.h:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::name):
(JSC::InternalFunction::displayName):
(JSC::InternalFunction::calculatedDisplayName):

  • runtime/InternalFunction.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getString):

  • runtime/JSCell.h:

(JSC::JSValue::getString):

  • runtime/JSONObject.cpp:

(JSC::gap):
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::appendStringifiedValue):

  • runtime/JSObject.cpp:

(JSC::JSObject::putDirectFunction):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::get):

  • runtime/JSString.cpp:

(JSC::JSString::Rope::~Rope):
(JSC::JSString::resolveRope):
(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toNumber):
(JSC::JSString::toString):
(JSC::JSString::toThisString):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::JSString::Rope::createOrNull):
(JSC::JSString::Rope::operator new):
(JSC::JSString::value):
(JSC::JSString::tryGetValue):
(JSC::JSString::getIndex):
(JSC::JSString::getStringPropertySlot):
(JSC::JSValue::toString):

  • runtime/JSValue.h:
  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

  • runtime/Operations.cpp:

(JSC::JSValue::strictEqualSlowCase):

  • runtime/Operations.h:

(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline):
(JSC::JSValue::strictEqual):
(JSC::jsLess):
(JSC::jsLessEq):
(JSC::jsAdd):
(JSC::concatenateStrings):

  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::equalTo):

  • runtime/PropertyDescriptor.h:
  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):

WebCore:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toHTMLCanvasStyle):
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::setShadow):

  • bindings/js/ScriptCallStack.cpp:

(WebCore::ScriptCallStack::ScriptCallStack):
(WebCore::ScriptCallStack::initialize):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::getString):

  • bindings/js/ScriptValue.h:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializingTreeWalker::convertIfTerminal):

  • bindings/objc/WebScriptObject.mm:

(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):

  • page/Console.cpp:

(WebCore::Console::addMessage):

WebKit/mac:

  • WebView/WebView.mm:

(aeDescFromJSValue):

3:03 PM Changeset in webkit [51800] by Nikolas Zimmermann
  • 249 edits
    2 adds in trunk

2009-12-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Holger Hans Peter Freyther.

Turn on (SVG) Filters support, by default.
​https://bugs.webkit.org/show_bug.cgi?id=32224

Only enable filters on mac for now, skipped all affected tests on the other platforms.
Will enable them one after another, to minimize breakage.

  • Configurations/FeatureDefines.xcconfig: Enable FILTERS build flag.
2:50 PM Changeset in webkit [51799] by eric@webkit.org
  • 5 edits in trunk

2009-12-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Some changes to ValidityState-typeMismatch-url.html.
​https://bugs.webkit.org/show_bug.cgi?id=29913

  • Add more test cases Username, IPv6 address, mailto:, file:, tel:, fragment, and IDN.
  • Handle difference between KURL and KURLGoogle
  • fast/forms/ValidityState-typeMismatch-url-expected.txt:
  • fast/forms/script-tests/ValidityState-typeMismatch-url.js:

2009-12-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that KURL rejects a host name which has an IPv4 address
inside an IPv6 form like [::127.0.0.1].
​https://bugs.webkit.org/show_bug.cgi?id=29913

  • platform/KURL.cpp: (WebCore::characterClassTable): Add IPv6Char to '.'.
2:43 PM Changeset in webkit [51798] by darin@chromium.org
  • 5 edits in trunk/LayoutTests

2009-12-07 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

http/tests/cache/subresource-failover-to-network.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=32038

Rewrite test to avoid dumpResourceLoadCallbacks, which do not
interleave predictably with the output of dumpFrameLoadCallbacks.
Other things besides resource loading can delay onload.

The newly written test uses a cookie to determine if the test has
passed.

Unskip this test for platform/win.

  • http/tests/cache/resources/subresource-failover-to-network.cgi:
  • http/tests/cache/subresource-failover-to-network-expected.txt:
  • http/tests/cache/subresource-failover-to-network.html:
  • platform/win/Skipped:
2:35 PM Changeset in webkit [51797] by ap@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32244
Test sending and receiving small WebSocket messages of different lengths

  • websocket/tests/frame-lengths-expected.txt: Added.
  • websocket/tests/frame-lengths.html: Added.
2:27 PM Changeset in webkit [51796] by beidson@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7443417> - Closing a window opened with "New windows open with: Same Page" results in crash in ::~HistoryItem

Reviewed by Sam Weinig.

The HistoryItem copy constructor has one very specific use case - to support the feature of a WebView copying another WebView's
BackForwardList. That constructor wasn't initializing its m_document pointer, leading to this crash in the destructor.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::~HistoryItem): Change the setDocument(0) to an ASSERT that the document is already 0. A HistoryItem cannot

outlive its Document and Documents will always clear the back-pointer in their ::detach() method.

(WebCore::HistoryItem::HistoryItem): Missed the m_document initializer in the copy constructor. Also remove an invalid assertion

about the original items m_cachedPage object (which is irrelevant to the copy).

1:54 PM Changeset in webkit [51795] by dimich@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Not reviewed - fix typo in ChangeLog.

1:52 PM Changeset in webkit [51794] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-07 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Fisher.

Chromium buildbots are not red when they fail
​https://bugs.webkit.org/show_bug.cgi?id=32235

  • Scripts/build-webkit:
1:51 PM Changeset in webkit [51793] by dimich@chromium.org
  • 8 edits
    9 deletes in trunk/WebCore

Remove partial SharedScript implementation.
​https://bugs.webkit.org/show_bug.cgi?id=32237
The patch was obtained by running "git revert" command and then un-reverting WebCore/ChangeLog.

Reviewed by Daring Adler.

  • DerivedSources.make:
  • SharedScript/SharedScriptContext.cpp: Removed.
  • SharedScript/SharedScriptContext.h: Removed.
  • SharedScript/SharedScriptContext.idl: Removed.
  • SharedScript/SharedScriptController.h: Removed.
  • SharedScript/WebKitSharedScript.cpp: Removed.
  • SharedScript/WebKitSharedScript.h: Removed.
  • SharedScript/WebKitSharedScript.idl: Removed.
  • SharedScript/WebKitSharedScriptRepository.cpp: Removed.
  • SharedScript/WebKitSharedScriptRepository.h: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::detach):

  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • dom/ScriptExecutionContext.h:
1:25 PM Changeset in webkit [51792] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-07 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Fisher.

Typo in chromium linux builder
​https://bugs.webkit.org/show_bug.cgi?id=32238

  • Scripts/webkitdirs.pm:
1:06 PM Changeset in webkit [51791] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add two tests generating new results to gtks collection of tests doing so.

  • platform/gtk/Skipped:
1:05 PM Changeset in webkit [51790] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=32226
Random crashes in WebSocket tests on Leopard Debug builbot

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::close): Make sure the object still exists when setting m_state.
12:32 PM Changeset in webkit [51789] by krit@webkit.org
  • 3 edits
    3 adds in trunk

2009-12-07 Shiki Okasaka <​shiki@google.com>

Reviewed by Dirk Schulze.

Avoid zero division during SVGPaintServerPattern::setup()
​https://bugs.webkit.org/show_bug.cgi?id=29912

Fix zero division bugs in SVGPaintServerPattern::setup() that occurred
if the tile of a pattern was bigger than the pattern and the pattern
size was < 0.5, and if the attribute overflow was set to visible.

Test: svg/custom/small-pattern.html

  • svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):

2009-12-07 Dirk Schulze <​krit@webkit.org>

Reviewed by Adam Barth.

If the tile of a pattern is bigger than the pattern and the
pattern size is < 0.5, the SVGPaintServer produced a division
by zero. This also only happens, if the attribute overflow is
set to visible.
This is a test with a pattern size of 0.1 and a tile size of 1.

  • svg/custom/script-tests/small-pattern.js: Added.
  • svg/custom/small-pattern-expected.txt: Added.
  • svg/custom/small-pattern.html: Added.
12:17 PM Changeset in webkit [51788] by eric@webkit.org
  • 6 edits in trunk

2009-12-07 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Fisher.

fixes to build-webkit --chromium
​https://bugs.webkit.org/show_bug.cgi?id=32179

  • DEPS:
  • WebKit.gyp:
  • gyp_webkit:

2009-12-07 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Fisher.

fixes to build-webkit --chromium
​https://bugs.webkit.org/show_bug.cgi?id=32179

  • Scripts/webkitdirs.pm:
11:46 AM Changeset in webkit [51787] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-07 Eric Seidel <​eric@webkit.org>

No review, just adding two recently approved committers.

  • Scripts/modules/committers.py:
11:36 AM Changeset in webkit [51786] by ap@apple.com
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-websocketserver: Added property svn:executable.
11:36 AM Changeset in webkit [51785] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-12-07 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

[v8] WebCore::WebGLArrayBufferInternal::byteLengthAttrGetter NULL pointer
​https://bugs.webkit.org/show_bug.cgi?id=31889

Fixed bug in handling of zero-argument constructor call.

Test: fast/canvas/webgl/bug-31889.html

  • fast/canvas/webgl/bug-31889-expected.txt: Added.
  • fast/canvas/webgl/bug-31889.html: Added.

2009-12-07 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

[v8] WebCore::WebGLArrayBufferInternal::byteLengthAttrGetter NULL pointer
​https://bugs.webkit.org/show_bug.cgi?id=31889

Fixed bug in handling of zero-argument constructor call.

Test: fast/canvas/webgl/bug-31889.html

  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
11:26 AM Changeset in webkit [51784] by kov@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. Landing files I forgot to add to my working copy before
committing r51734.

11:22 AM Changeset in webkit [51783] by eric@webkit.org
  • 4 edits in trunk

2009-12-07 Gyuyoung Kim <​gyuyoung@gmail.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32024
[GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER

Fix build errors when javascript-debugger is disabled on GTK

  • GNUmakefile.am:

2009-12-07 Gyuyoung Kim <​gyuyoung@gmail.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32024
[GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER

Fix build errors when javascript-debugger is disabled on GTK

  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_set_property): (webkit_web_inspector_get_property):
11:09 AM Changeset in webkit [51782] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Don't skip websocket/tests/url-with-credential.html, it's one of earlier tests that is
to blame.

  • platform/mac/Skipped:
11:06 AM Changeset in webkit [51781] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Steve Falkenburg.

Add one more fast/js test to the Skipped list - also due to:
​https://bugs.webkit.org/show_bug.cgi?id=32228.

  • platform/win/Skipped:
10:51 AM Changeset in webkit [51780] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2009-12-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Cleaning up Skipped files in order to make more bots green, as I plan to land changes, that affect all bots (svg filters support).

Remove non-existant animations/3d directory in qt&win Skipped lists.
Skip one more test on windows (see bug #32228, already in radar, just guessing - not yet sure if it's a random crash issue though)
Skip 19 (!) tests on the Qt slave, failing since a longer time. Qt developers: Please investigate.

  • platform/qt/Skipped: Also remove some duplicates I spotted.
  • platform/win/Skipped:
10:34 AM Changeset in webkit [51779] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-12-07 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Add run-webkit-websocketserver

​https://bugs.webkit.org/show_bug.cgi?id=31390

  • Scripts/run-webkit-websocketserver: Added.
10:23 AM Changeset in webkit [51778] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Disable two flaky SnowLeopard tests, filed bug and notified author.

Tests "plugins/document-open.html" and "plugins/mouse-events.html" are flaky on SnowLeopard
​https://bugs.webkit.org/show_bug.cgi?id=32229

  • platform/mac-snowleopard/Skipped:
10:23 AM Changeset in webkit [51777] by sfalken@apple.com
  • 4 edits in tags/Safari-532.5.1

Merge r51773.

10:22 AM Changeset in webkit [51776] by mitz@apple.com
  • 7 edits
    8 adds in trunk

WebCore: Fixed <rdar://problem/7437820> Weird selection artifacts

Reviewed by Darin Adler.

Tests: fast/repaint/block-selection-gap-stale-cache-2.html

fast/repaint/block-selection-gap-stale-cache.html

Instead of caching the block selection gaps’ bounds in the RenderView at setSelection()
time, cache them in each RenderLayer at paint time. This prevents the cache from getting
stale due to layout changes and overflow scrolling.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint): Account for overflow scroll.
(WebCore::RenderBlock::paintSelection): Update the enclosing layer’s selection gaps bounds.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::addBlockSelectionGapsBounds): Added. Updates the selection gaps
bounds to include the given rect.
(WebCore::RenderLayer::clearBlockSelectionGapsBounds): Added. Recursively clears the cached
selection gaps bounds.
(WebCore::RenderLayer::repaintBlockSelectionGaps): Added. Recursively invalidates the
selection gaps bounds.

  • rendering/RenderLayer.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Clear the layer-level selection gaps bounds instead
of the view-level cache.
(WebCore::RenderView::clearSelection): Changed to call repaintBlockSelectionGaps().

  • rendering/RenderView.h:

LayoutTests: Tests for <rdar://problem/7437820> Weird selection artifacts

Reviewed by Darin Adler.

  • fast/repaint/block-selection-gap-stale-cache-2.html: Added.
  • fast/repaint/block-selection-gap-stale-cache.html: Added.
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum: Added.
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png: Added.
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.txt: Added.
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.checksum: Added.
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.png: Added.
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.txt: Added.
10:09 AM Changeset in webkit [51775] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

REGRESSION: fast/js/excessive-comma-usage.html and fast/js/math-transforms.html fail on win
​https://bugs.webkit.org/show_bug.cgi?id=32228

Adding above two tests to the Skipped list on win, attempting to turn the win slave green again.

  • platform/win/Skipped:
10:06 AM Changeset in webkit [51774] by sfalken@apple.com
  • 1 copy in tags/Safari-532.5.1

New tag.

10:03 AM Changeset in webkit [51773] by sfalken@apple.com
  • 4 edits in trunk

Build fix. Be flexible about which version of ICU is used on Windows.

JavaScriptCore:

  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Add optional xcopy commands to copy ICU 4.2.

WebKitTools:

  • DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
9:43 AM Changeset in webkit [51772] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Remove non-existant files in gtk/Skipped list, and exclude a printing test, without results. Should turn the gtk slave green again.

  • platform/gtk/Skipped:
9:21 AM Changeset in webkit [51771] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Attempt to get all mac build slaves to green again. Disable crashing test, and notify the author of it to fix it.

New test "websocket/tests/url-with-credential.html" crashes in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=32226

  • platform/mac/Skipped:
9:10 AM Changeset in webkit [51770] by Nikolas Zimmermann
  • 1 edit
    1 add in trunk/LayoutTests

Not reviewed. Add missing layout test result.

9:07 AM Changeset in webkit [51769] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-12-07 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha.

Fixed whitelist comment and removed useless (tags, sdp) mimetypes
from it. Also, GStreamer doesn't handle directly SMIL.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
7:38 AM Changeset in webkit [51768] by eric@webkit.org
  • 4 edits in trunk

2009-12-07 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Eliminate the segfaults which occur when accessing the text interface now
implemented by text controls.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getPangoLayoutForAtk):

2009-12-07 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Eliminate the segfaults which occur when accessing the text interface now
implemented by text controls.

  • tests/testatk.c (test_webkit_atk_get_text_at_offset_textarea): (test_webkit_atk_get_text_at_offset_text_input): (main):
7:31 AM Changeset in webkit [51767] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-07 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve the autotests of QtWebkit
​https://bugs.webkit.org/show_bug.cgi?id=32216

Remove the calls to qWait() of the autotest of QWebView

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::reusePage):
7:02 AM Changeset in webkit [51766] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2009-12-07 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Add declarations for DevTools message dispatching on IO thread
(see ​http://codereview.chromium.org/460018)

​https://bugs.webkit.org/show_bug.cgi?id=32217

  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
6:52 AM Changeset in webkit [51765] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-12-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

op_loop_if_less JIT codegen is broken for 64-bit
​https://bugs.webkit.org/show_bug.cgi?id=32221

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_false): Fix codegen in this version - test was backwards.
6:35 AM Changeset in webkit [51764] by kov@webkit.org
  • 5 edits
    6 adds in trunk

Reviewed by Xan Lopez.

Build the new API test.

[GTK] REGRESSION: webkit thinks it can render PDFs
​https://bugs.webkit.org/show_bug.cgi?id=32183

  • GNUmakefile.am:

WebCore

Reviewed by Xan Lopez.

Turn the MediaPlayer supported types blacklist into a whitelist

[GTK] REGRESSION: webkit thinks it can render PDFs
​https://bugs.webkit.org/show_bug.cgi?id=32183

Covered by API test.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

WebKit/gtk

Reviewed by Xan Lopez.

New test to make sure we do not regress this feature anymore. All
test files were created by me.

[GTK] REGRESSION: webkit thinks it can render PDFs
​https://bugs.webkit.org/show_bug.cgi?id=32183

  • tests/resources/test.html: Added.
  • tests/resources/test.ogg: Added.
  • tests/resources/test.pdf: Added.
  • tests/resources/test.txt: Added.
  • tests/testmimehandling.c: Added. (server_callback): (idle_quit_loop_cb): (mime_type_policy_decision_requested_cb): (test_mime_type): (test_mime_pdf): (test_mime_html): (test_mime_text): (test_mime_ogg): (main):
6:34 AM Changeset in webkit [51763] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-07 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve the autotests of QtWebkit
​https://bugs.webkit.org/show_bug.cgi?id=32216

Refactor tst_qwebframe to remove qWait() and use
the function waitForSignal() from util.h

  • tests/qwebframe/tst_qwebframe.cpp:
6:27 AM Changeset in webkit [51762] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-12-07 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25524
[Gtk] Expose the title attribute to assistive technologies

  • platform/gtk/accessibility/title-and-alt.html: Added.
  • platform/gtk/accessibility/title-and-alt-expected.txt: Added.

2009-12-07 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25524
[Gtk] Expose the title attribute to assistive technologies

Expose 'alt' attribute from images as accessible name.
Expose the 'title' core HTML attribute as accessible description.
This is a modified version of the original fix submitted by Mario Sanchez Prada,
adjusted so that it doesn't impact other platforms.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_get_description):
6:13 AM Changeset in webkit [51761] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-12-07 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve the autotests of QtWebkit
​https://bugs.webkit.org/show_bug.cgi?id=32216

Refactor the test of QGraphicsWebView:
-make waitForSignal() available to all the tests.
-remove QTest::qWait()

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::crashOnViewlessWebPages):
  • tests/util.h: (waitForSignal):
5:50 AM Changeset in webkit [51760] by oliver@apple.com
  • 5 edits in trunk

Object.create fails if properties on the descriptor are getters
​https://bugs.webkit.org/show_bug.cgi?id=32219

Reviewed by Maciej Stachowiak.

Correctly initialise the PropertySlots with the descriptor object.

5:44 AM Changeset in webkit [51759] by Girish Ramakrishnan
  • 2 edits in trunk/WebKit/qt

[Qt] Plugins: Force windowless mode when there is no native window handle

Reviewed by Simon Hausmann.

Inject wmode=opaque while instantiating the plugin for the case when the
webpage is not backed by a native window handle.

​https://bugs.webkit.org/show_bug.cgi?id=32059

5:29 AM Changeset in webkit [51758] by vestbo@webkit.org
  • 4 edits in trunk/WebCore

[Qt] Fix support for generic font families

Reviewed by Simon Hausmann.

By not propagating the resolved font family in FontCacheQt and
only concidering the font description we ended up passing the
generic font families to Qt directly. Since most systems don't
have a mapping for these font families we ended up using the
default font in most cases.

  • platform/graphics/qt/FontCacheQt.cpp:
  • platform/graphics/qt/FontPlatformData.h:
  • platform/graphics/qt/FontPlatformDataQt.cpp:
5:06 AM Changeset in webkit [51757] by oliver@apple.com
  • 9 edits
    1 add in trunk

Object.getOwnPropertyDescriptor() allows cross-frame access
​https://bugs.webkit.org/show_bug.cgi?id=32119

Reviewed by Maciej Stachowiak.

Make all implementations of getOwnPropertyDescriptor that have
cross domain restrictions simply fail immediately on cross domain
access, rather than trying to mimic the behaviour of normal
property access.

Test: http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html

4:36 AM Changeset in webkit [51756] by steveblock@google.com
  • 9 edits
    3 adds in trunk/WebCore

Moves JSC-specific functions from jni_utility and moves them to new jsc/jni_utility_private files.
​https://bugs.webkit.org/show_bug.cgi?id=32157

Reviewed by Adam Barth.

Build fix only, no new tests.

  • WebCore.xcodeproj/project.pbxproj: Modified. Add jni_utility_private.[cpp|h].
  • bridge/jni/jni_instance.cpp: Modified. Include jni_utility_private.h for JSC.
  • bridge/jni/jni_jsobject.mm: Modified. Include jni_utility_private.h for JSC.
  • bridge/jni/jni_objc.mm: Modified. Include jni_utility_private.h for JSC.
  • bridge/jni/jni_runtime.cpp: Modified. Include jni_utility_private.h for JSC.
  • bridge/jni/jni_utility.cpp: Modified. Removed convertValueToJValue and convertArrayInstanceToJavaArray.
  • bridge/jni/jni_utility.h: Modified. Removed convertValueToJValue and dispatchJNICall.
  • bridge/jni/jsc: Added.
  • bridge/jni/jsc/jni_utility_private.cpp: Added.

(JSC::Bindings::convertArrayInstanceToJavaArray):
(JSC::Bindings::convertValueToJValue):

  • bridge/jni/jsc/jni_utility_private.h: Added. Header for convertValueToJValue and dispatchJNICall.
  • platform/android/TemporaryLinkStubs.cpp: Modified. Include jni_utility_private.h for JSC.
4:04 AM Changeset in webkit [51755] by krit@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-07 Dirk Schulze <​krit@webkit.org>

Not reviewed, adding myself to the reviewers list.

  • Scripts/modules/committers.py:
12:51 AM QtWebKitMediaElementSupport edited by vestbo@webkit.org
(diff)
12:50 AM QtWebKitMediaElementSupport edited by vestbo@webkit.org
(diff)
12:46 AM QtWebKitMediaElementSupport created by vestbo@webkit.org
12:46 AM QtWebKit edited by vestbo@webkit.org
(diff)

Dec 6, 2009:

11:53 PM Changeset in webkit [51754] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add an API for uploading results files to StatusBot
​https://bugs.webkit.org/show_bug.cgi?id=32210

Add Content-Type: plain/text which was forgotten
from the previous commit when I landed with land-patches
instead of land-diff.

  • QueueStatusServer/queue_status.py:
11:45 PM Changeset in webkit [51753] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add an API for uploading results files to StatusBot
​https://bugs.webkit.org/show_bug.cgi?id=32210

  • Scripts/modules/statusbot.py:
11:42 PM Changeset in webkit [51752] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Status Server needs a way to handle uploaded results
​https://bugs.webkit.org/show_bug.cgi?id=32209

  • QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
  • QueueStatusServer/update_status.html: Add file upload.
11:06 PM Changeset in webkit [51751] by hamaji@chromium.org
  • 2 edits in trunk/BugsSite

2009-12-06 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. Revert r51748.

Bugzilla should show images in git patches
​https://bugs.webkit.org/show_bug.cgi?id=31395

  • PrettyPatch/PrettyPatch.rb:
10:42 PM Changeset in webkit [51750] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] BuildAttachment should not check the builders
​https://bugs.webkit.org/show_bug.cgi?id=32207

This is code that got copied here by accident when the class was created.

  • Scripts/modules/commands/download.py:
10:42 PM Changeset in webkit [51749] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Make LandingSequence.update aware of ports
​https://bugs.webkit.org/show_bug.cgi?id=32208

This is required to make build work on the Chromium port because
Chromium has a custom update-webkit.

  • Scripts/modules/landingsequence.py:
10:42 PM Changeset in webkit [51748] by hamaji@chromium.org
  • 2 edits in trunk/BugsSite

2009-12-06 Shinichiro Hamaji <​shinichiro.hamaji@gmail.com>

Reviewed by David Kilzer.

Bugzilla should show images in git patches
​https://bugs.webkit.org/show_bug.cgi?id=31395

Show images in git patches using git-apply.

  • PrettyPatch/PrettyPatch.rb:
9:20 PM Changeset in webkit [51747] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2009-12-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add early warning system commands to bugzilla-tool.

  • Scripts/bugzilla-tool:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/webkitport.py:
9:11 PM Changeset in webkit [51746] by abarth@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2009-12-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
​https://bugs.webkit.org/show_bug.cgi?id=32205

  • Scripts/modules/commands/early_warning_system.py: Added.
  • Scripts/modules/commands/queues.py:
7:27 PM Changeset in webkit [51745] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

REGRESSION (r51728): update-webkit fails when the current directory is
not inside a Subversion working copy
​https://bugs.webkit.org/show_bug.cgi?id=32204

Reviewed by Adele Peterson.

  • Scripts/update-webkit: Invoke isSVN() in the correct working

directory.

6:45 PM Changeset in webkit [51744] by eric@webkit.org
  • 5 edits in trunk/LayoutTests

2009-12-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Improve portability and readability of table-percent-height* tests.
​https://bugs.webkit.org/show_bug.cgi?id=31858

The purpose of these tests is to confirm that an element with
height:N% inside a table cell has non-zero height. We don't need
to check concrete pixel sizes of form controls.

This updates the tests so that they check heights are non-zero and
75% heights are same as corresponding 100% heights or actually 75%.

  • fast/replaced/table-percent-height-expected.txt:
  • fast/replaced/table-percent-height-text-controls-expected.txt:
  • fast/replaced/table-percent-height-text-controls.html:
  • fast/replaced/table-percent-height.html:
6:19 PM Changeset in webkit [51743] by ukai@chromium.org
  • 6 edits
    8 adds in trunk/LayoutTests

2009-12-06 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Add tests for cross-origin WebSocket usage
​https://bugs.webkit.org/show_bug.cgi?id=32055

  • websocket/tests/cross-origin-expected.txt: Added.
  • websocket/tests/cross-origin.html: Added.
  • websocket/tests/fixed-origin_wsh.py: Added.
  • websocket/tests/handshake-fail-by-cross-origin-expected.txt: Added.
  • websocket/tests/handshake-fail-by-cross-origin.html: Added.
  • websocket/tests/origin-test_wsh.py: Added.
  • websocket/tests/script-tests/cross-origin.js: Added.
  • websocket/tests/script-tests/frame-length-longer-than-buffer.js:
  • websocket/tests/script-tests/frame-length-skip.js:
  • websocket/tests/script-tests/handshake-error.js:
  • websocket/tests/script-tests/handshake-fail-by-cross-origin.js: Added.
  • websocket/tests/script-tests/simple.js:
  • websocket/tests/simple-expected.txt:
5:09 PM Changeset in webkit [51742] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Rename AbstractTryQueue to AbstractReviewQueue
​https://bugs.webkit.org/show_bug.cgi?id=32202

  • Scripts/modules/commands/queues.py:
9:40 AM Changeset in webkit [51741] by eric@webkit.org
  • 3 edits in trunk/WebKit/haiku

2009-12-06 Maxime Simon <Maxime Simon>

Reviewed by Adam Barth.

Build fix. Add in FrameLoaderClientHaiku the declaration of three functions introduced in r51644.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::dispatchDidPushStateWithinPage): (WebCore::FrameLoaderClientHaiku::dispatchDidReplaceStateWithinPage): (WebCore::FrameLoaderClientHaiku::dispatchDidPopStateWithinPage):
  • WebCoreSupport/FrameLoaderClientHaiku.h:
3:37 AM Changeset in webkit [51740] by oliver@apple.com
  • 2 edits in trunk/WebCore

texImage2D pixel junk for transparency
​https://bugs.webkit.org/show_bug.cgi?id=32188

Reviewed by Maciej Stachowiak

Use kCGBlendModeCopy when drawing an image to the intermediate context
used to create a GL texture.

No test as we don't currently have any mechanism to retrieve pixel data
from the webgl context.

2:30 AM Changeset in webkit [51739] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.

Actually tested 64-bit *and* 32-bit build this time.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_loop_if_false):

2:09 AM Changeset in webkit [51738] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.

Really really fix 64-bit build for prior patch (actually tested this time).

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_loop_if_false):
(JSC::JIT::emitSlow_op_loop_if_false):

1:57 AM Changeset in webkit [51737] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.

Really fix 64-bit build for prior patch.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_jless):

1:51 AM Changeset in webkit [51736] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.

Fix 64-bit build for prior patch.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_loop_if_less):

1:42 AM Changeset in webkit [51735] by mjs@apple.com
  • 17 edits in trunk

2009-12-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

conway benchmark spends half it's time in op_less (jump fusion fails)
​https://bugs.webkit.org/show_bug.cgi?id=32190

<1% speedup on SunSpider and V8
2x speedup on "conway" benchmark


Two optimizations:

1) Improve codegen for logical operators &&,
and ! in a condition context


When generating code for combinations of &&,
and !, in a

condition context (i.e. in an if statement or loop condition), we
used to produce a value, and then separately jump based on its
truthiness. Now we pass the false and true targets in, and let the
logical operators generate jumps directly. This helps in four
ways:

a) Individual clauses of a short-circuit logical operator can now
jump directly to the then or else clause of an if statement (or to
the top or exit of a loop) instead of jumping to a jump.


b) It used to be that jump fusion with the condition of the first
clause of a logical operator was inhibited, because the register
was ref'd to be used later, in the actual condition jump; this no
longer happens since a jump straight to the final target is
generated directly.

c) It used to be that jump fusion with the condition of the second
clause of a logical operator was inhibited, because there was a
jump target right after the second clause and before the actual
condition jump. But now it's no longer necessary for the first
clause to jump there so jump fusion is not blocked.

d) We avoid generating excess mov statements in some cases.


As a concrete example this source:


if (!((x < q && y < q)
(t < q && z < q))) {

...

}


Used to generate this bytecode:


[ 34] less r1, r-15, r-19
[ 38] jfalse r1, 7(->45)
[ 41] less r1, r-16, r-19
[ 45] jtrue r1, 14(->59)
[ 48] less r1, r-17, r-19
[ 52] jfalse r1, 7(->59)
[ 55] less r1, r-18, r-19
[ 59] jtrue r1, 17(->76)


And now generates this bytecode (also taking advantage of the second optimization below):


[ 34] jnless r-15, r-19, 8(->42)
[ 38] jless r-16, r-19, 26(->64)
[ 42] jnless r-17, r-19, 8(->50)
[ 46] jless r-18, r-19, 18(->64)


Note the jump fusion and the fact that there's less jump
indirection - three of the four jumps go straight to the target
clause instead of indirecting through another jump.


2) Implement jless opcode to take advantage of the above, since we'll now often generate
a less followed by a jtrue where fusion is not forbidden.


  • parser/Nodes.h: (JSC::ExpressionNode::hasConditionContextCodegen): Helper function to determine whether a node supports special conditional codegen. Return false as this is the default. (JSC::ExpressionNode::emitBytecodeInConditionContext): Assert not reached - only really defined for nodes that do have conditional codegen. (JSC::UnaryOpNode::expr): Add const version. (JSC::LogicalNotNode::hasConditionContextCodegen): Returne true only if subexpression supports it. (JSC::LogicalOpNode::hasConditionContextCodegen): Return true.
  • parser/Nodes.cpp: (JSC::LogicalNotNode::emitBytecodeInConditionContext): Implemented - just swap the true and false targets for the child node. (JSC::LogicalOpNode::emitBytecodeInConditionContext): Implemented - handle jumps directly, improving codegen quality. Also handles further nested conditional codegen. (JSC::ConditionalNode::emitBytecode): Use condition context codegen when available. (JSC::IfNode::emitBytecode): ditto (JSC::IfElseNode::emitBytecode): ditto (JSC::DoWhileNode::emitBytecode): ditto (JSC::WhileNode::emitBytecode): ditto (JSC::ForNode::emitBytecode): ditto
  • bytecode/Opcode.h:
  • Added loop_if_false opcode - needed now that falsey jumps can be backwards.
  • Added jless opcode to take advantage of new fusion opportunities.
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): Handle above.
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpIfTrue): Add peephole for less + jtrue ==> jless. (JSC::BytecodeGenerator::emitJumpIfFalse): Add handling of backwrds falsey jumps.
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitNodeInConditionContext): Wrapper to handle tracking of overly deep expressions etc.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Implement the two new opcodes (loop_if_false, jless).
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): Implement JIT support for the two new opcodes. (JSC::JIT::privateCompileSlowCases): ditto
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): ditto (JSC::JIT::emitBinaryDoubleOp): ditto
  • jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_loop_if_less): ditto (JSC::JIT::emit_op_loop_if_false): ditto (JSC::JIT::emitSlow_op_loop_if_false): ditto
  • jit/JITStubs.cpp:
  • jit/JITStubs.h: (JSC::):

2009-12-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

conway benchmark spends half it's time in op_less (jump fusion fails)
​https://bugs.webkit.org/show_bug.cgi?id=32190

  • fast/js/codegen-loops-logical-nodes-expected.txt:
  • fast/js/script-tests/codegen-loops-logical-nodes.js: Update to test some newly sensitive cases of codegen that were not already covered.
Note: See TracTimeline for information about the timeline view.