Context Navigation

Change forward declaration of WebContextMenuData from class to
struct to match its definition. The bug was introduced by
http://trac.webkit.org/changeset/51874

src/ContextMenuClientImpl.h:

10:07 PM Changeset in webkit [51936] by Beth Dakin

5 edits
8 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32346 SVG property
-webkit-shadow should apply shadow on the result after compositing
-and corresponding-
<rdar://problem/7389404>

Reviewed by Oliver Hunt.

Set a transparency layer when setting a shadow to apply the shadow
to the composite.

rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):
(WebCore::SVGRenderBase::finishRenderSVGContent):

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=32346 SVG
property -webkit-shadow should apply shadow on the result after
compositing
-and corresponding-
<rdar://problem/7389404>

Reviewed by Oliver Hunt.

New tests:

platform/mac/svg/css/composite-shadow-example-expected.checksum: Added.
platform/mac/svg/css/composite-shadow-example-expected.png: Added.
platform/mac/svg/css/composite-shadow-example-expected.txt: Added.
platform/mac/svg/css/composite-shadow-with-opacity-expected.checksum: Added.
platform/mac/svg/css/composite-shadow-with-opacity-expected.png: Added.
platform/mac/svg/css/composite-shadow-with-opacity-expected.txt: Added.
svg/css/composite-shadow-example.html: Added.
svg/css/composite-shadow-with-opacity.html: Added.

New and improved results:

platform/mac/svg/css/group-with-shadow-expected.checksum:
platform/mac/svg/css/group-with-shadow-expected.png:

7:32 PM Changeset in webkit [51935] by ap@apple.com

5 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32332
WebSocket events should be dispatched synchronously

Updated websocket/tests/simple to test for the new behavior.

When Web Sockets API says that events should be queued for async dispatch, it means something
different. We should keep this in mind when dealing with other HTML5-related specs.

The model for HTML5 is that code running in response to network events (e.g. WebSocket or
XMLHttpRequest algorithms) runs in a separate thread of execution, and thus needs to post
async events as its only way to communicate with client code. As long as network events are
queued themselves (as they are in WebKit), there is no need to queue JS events for async
dispatch.

websockets/WebSocket.cpp: (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didClose):

7:30 PM Changeset in webkit [51934] by ap@apple.com

3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=32355
Assertion failure when opening a WebSocket connection

I couldn't make a reliable test for this. Once the test from bug 32299 is landed, it
will provide partial coverage, as I was frequently seeing the assertion failure with it.

platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): It's not an error if zero if returned from platformSend() - it just means that nothing could be pushed down to the network layer, and all data was queued for later.
platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::readStreamCallback): This will no longer happen with SocketStream, but a client can potentially destroy the handle from any callback, so we need to check that this didn't happen. (WebCore::SocketStreamHandle::writeStreamCallback): Ditto.

5:44 PM Changeset in webkit [51933] by barraclough@apple.com

6 edits in trunk

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=32228
Make destruction of ropes non-recursive to prevent stack exhaustion.
Also, pass a UString& into initializeFiber rather than a Ustring::Rep*,
since the Rep is not being ref counted this could result in usage of a
Rep with refcount zero (where the Rep comes from a temporary UString
returned from a function).

Reviewed by Oliver Hunt.

runtime/JSString.cpp:

(JSC::JSString::Rope::destructNonRecursive):
(JSC::JSString::Rope::~Rope):

runtime/JSString.h:

(JSC::JSString::Rope::initializeFiber):

runtime/Operations.h:

(JSC::concatenateStrings):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=32228
Reenabling tests.

Reviewed by Oliver Hunt.

platform/win/Skipped:

4:58 PM Changeset in webkit [51932] by eric@webkit.org

5 edits in trunk

2009-12-09 Marwan Al Jubeh <marwan.aljubeh@gmail.com>

Reviewed by Adam Roben.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
in Windows as part of running update_webkit.

building/build.html:
- removed the reference to forgetting to set environment variables as a common source of errors on Windows. This is because this patch would make it unnecessary for the user to set these variables manually.

2009-12-09 Marwan Al Jubeh <marwan.aljubeh@gmail.com>

Reviewed by Adam Roben.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
in Windows as part of running update_webkit.

Scripts/update-webkit:
- Run setupAppleWinEnv() on Apple's Windows port.
Scripts/webkitdirs.pm:
- Added functions that return the source directory, libraries directory and default build directory on Windows.
- Added isWindowsNT() which tests if the current Windows version is from the Windows NT family.
- Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir and Cygwin to their desired values.

4:23 PM Changeset in webkit [51931] by weinig@apple.com

3 edits in trunk/WebCore

Roll out 51919 and 51920. They were incorrect and unnecessary right now.

platform/mac/WebCoreObjCExtras.mm:

(WebCoreObjCScheduleDeallocateOnMainThread):

platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::NetworkStateNotifier):

3:32 PM Changeset in webkit [51930] by eric@webkit.org

2 edits in trunk/WebCore

2009-12-09 Steve Block <steveblock@google.com>

Reviewed by Darin Fisher.

Adds wtf/StdLibExtras.h include for DEFINE_STATIC_LOCAL in V8 ScriptState.
https://bugs.webkit.org/show_bug.cgi?id=32330

Build fix only, no new tests.

bindings/v8/ScriptState.cpp: Modified. Adds wtf/StdLibExtras.h include.

3:08 PM Changeset in webkit [51929] by eric@webkit.org

2 edits in trunk/WebKitSite

2009-12-09 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Darin Adler.

Added the "using std::foo" rule to the coding style guidelines.

https://bugs.webkit.org/show_bug.cgi?id=32301

Added to the coding style guidelines the "using std::foo" rule
checked by the check-webkit-style script. Also clarified the
"using" statement guidelines that apply to implementation files.

coding/coding-style.html:

3:01 PM Changeset in webkit [51928] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-12-09 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31930

Update to r51457. ASSERTs changed to COMPILE_ASSERTs.
The speedup is 25%.

runtime/JSGlobalData.cpp: (JSC::VPtrSet::VPtrSet):

2:54 PM Changeset in webkit [51927] by eric@webkit.org

3 edits in trunk/WebCore

2009-12-09 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Adds ENABLE(INSPECTOR) guards around script binding methods that use types
defined only when INSPECTOR is enabled.
https://bugs.webkit.org/show_bug.cgi?id=32328

Build fix only, no new tests.

bindings/js/ScriptValue.cpp: Modified. Added ENABLE(INSPECTOR) guard to ScriptValue::quarantineValue.
bindings/v8/ScriptObject.cpp: Modified. Added ENABLE(INSPECTOR) guard to some overloads of ScriptGlobalObject::set.

2:47 PM Changeset in webkit [51926] by eric@webkit.org

10 edits
2 adds in trunk

2009-12-09 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds Android Makefiles for building with V8.
https://bugs.webkit.org/show_bug.cgi?id=32278

Android.mk: Modified. Includes Makefiles for V8.

2009-12-09 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Updates Android Makefiles with latest additions.
https://bugs.webkit.org/show_bug.cgi?id=32278

Android.mk: Modified.
Android.v8.wtf.mk: Modified.

2009-12-09 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds Android Makefiles for building with V8.
Also updates existing Android Makefiles with latest additions.
https://bugs.webkit.org/show_bug.cgi?id=32278

Build fix only, no new tests.

Android.derived.jscbindings.mk: Modified.
Android.derived.mk: Modified.
Android.derived.v8bindings.mk: Added.
Android.jscbindings.mk: Modified.
Android.mk: Modified.
Android.v8bindings.mk: Added.

2:35 PM Changeset in webkit [51925] by steveblock@google.com

2 edits in trunk/WebCore

Bug 32338 - [Chromium] Fix Chromium builder by including missing GeolocationServiceChromium
https://bugs.webkit.org/show_bug.cgi?id=32338

Patch by Jonathan Dixon <joth@chromium.org> on 2009-12-09
Reviewed by Dimitri Glazkov.

Fix build break: re-include file dropped out by merge in http://trac.webkit.org/changeset/51681/trunk/WebCore/WebCore.gypi

WebCore.gypi: Add missing GeolocationServiceChromium.cpp

2:32 PM Changeset in webkit [51924] by eric@webkit.org

2 edits in trunk/WebCore

2009-12-09 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Brady Eidson.

Fixed a typo in http://trac.webkit.org/changeset/51644 that broke
the QWebPage autotest.

No new test required.

loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateToDifferentDocument):

2:25 PM Changeset in webkit [51923] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-12-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

exception thrown when running apply-patches
https://bugs.webkit.org/show_bug.cgi?id=32344

The update step now takes a port option. Once we finish the Steps
refactoring, we won't have to worry about this kind of bug again.

Scripts/modules/commands/download.py:

2:18 PM Changeset in webkit [51922] by eric@webkit.org

2 edits in trunk/WebCore

2009-12-09 Robert Hogan <robert@roberthogan.net>

Reviewed by Eric Seidel.

Exclude JSSVG*.cpp generated files from --minimal and --no-svg builds.

https://bugs.webkit.org/show_bug.cgi?id=32286

WebCore.pro:

2:11 PM Changeset in webkit [51921] by eric@webkit.org

2 edits in trunk/WebCore

2009-12-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

Ogg mimetypes are incorrect
https://bugs.webkit.org/show_bug.cgi?id=27113

The ogg extension is handled by audio/ogg instead of
application/ogg. See
http://wiki.xiph.org/MIME_Types_and_File_Extensions

platform/MIMETypeRegistry.cpp: (WebCore::TypeExtensionPair::):

1:57 PM Changeset in webkit [51920] by weinig@apple.com

2 edits in trunk/WebCore

Use the current run loop instead of the main runloop for the NetworkStateNotifier.

Reviewed by Anders Carlsson.

platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::NetworkStateNotifier):

1:55 PM Changeset in webkit [51919] by weinig@apple.com

2 edits in trunk/WebCore

Use isMainThread() helper instead of pthread_main_np() != 0.

Reviewed by Anders Carlsson.

platform/mac/WebCoreObjCExtras.mm:

(WebCoreObjCScheduleDeallocateOnMainThread):

1:37 PM Changeset in webkit [51918] by kov@webkit.org

2 edits in trunk/LayoutTests

Skip a failing test that needs DRT support to override standard
preferences.

platform/gtk/Skipped:

1:36 PM Changeset in webkit [51917] by darin@chromium.org

5 edits in trunk/WebKit/chromium

2009-12-09 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32324
[Chromium] Suppress WebFrameClient callbacks from a detached frame.

This change means that we no longer need the ClientHandle class.
FrameLoaderClient::detachedFromParent3() is called on each frame
in the frame tree from within frameDetached().

Test: http/tests/loading/gmail-assert-on-load.html

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::create): (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::createChildFrame):
src/WebFrameImpl.h: (WebKit::WebFrameImpl::client): (WebKit::WebFrameImpl::dropClient):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::close):

1:31 PM Changeset in webkit [51916] by weinig@apple.com

11 edits in trunk/WebCore

Add some #ifdefs to allow us to experiment with a single NSView mac WebKit.

Reviewed by Anders Carlsson.

page/Chrome.h:
page/EventHandler.h:
page/mac/ChromeMac.mm:
page/mac/DragControllerMac.mm:

(WebCore::DragController::dragOperation):

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::eventLoopHandleMouseDragged):
(WebCore::EventHandler::eventActivatedView):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::createDraggingClipboard):
(WebCore::isKeyboardOptionTab):
(WebCore::EventHandler::invertSenseOfTabsToLinks):
(WebCore::EventHandler::tabsToAllControls):
(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
(WebCore::EventHandler::accessKeyModifiers):

platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

platform/Widget.cpp:
platform/Widget.h:
platform/mac/ScrollViewMac.mm:
platform/mac/WidgetMac.mm:

(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::show):
(WebCore::Widget::hide):
(WebCore::Widget::setCursor):
(WebCore::Widget::paint):
(WebCore::Widget::setFocus):
(WebCore::Widget::setIsSelected):
(WebCore::Widget::frameRect):
(WebCore::Widget::setFrameRect):

12:36 PM Changeset in webkit [51915] by eric@webkit.org

4 edits in trunk/WebCore

2009-12-09 Michael Nordman <Michael Nordman>

Reviewed by Dimitri Glazkov.

Chromium build fix.

No new tests.

bindings/v8/DOMData.cpp
bindings/v8/V8DOMWrapper.cpp
bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):

12:31 PM Changeset in webkit [51914] by weinig@apple.com

2 edits in trunk/JavaScriptCore

Fix a bug found while trying to compile JavaScriptCore with clang++.

Reviewed by Gavin Barraclough.

yarr/RegexPattern.h:

(JSC::Yarr::PatternTerm::PatternTerm): Don't self assign here. Use false instead.

12:26 PM Changeset in webkit [51913] by bfulgham@webkit.org

2 edits in trunk/WebKit/win

Revert incorrect commit-box update r51911.
It mistakenly set the selectAll implementation in the
deslectAll method.

WebFrame.cpp:

(WebFrame::deselectAll):

12:14 PM Changeset in webkit [51912] by eric@webkit.org

2 edits in trunk/WebCore

2009-12-09 Søren Gjesse <sgjesse@chromium.org>

Reviewed by Pavel Feldman.

[V8] Isolated world reuse failure
https://bugs.webkit.org/show_bug.cgi?id=32306

Fixed bug introduced in r51407: (http://trac.webkit.org/changeset/51407) which caused layout test
LayoutTests/http/tests/security/isolatedWorld/world-reuse.html to fail.

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::contextDebugId):

12:06 PM Changeset in webkit [51911] by eric@webkit.org

2 edits in trunk/WebKit/win

2009-12-09 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Darin Adler.

Provide an implementation for 'selectAll'
https://bugs.webkit.org/show_bug.cgi?id=32296

WebFrame.cpp: (WebFrame::selectAll): Implement "SelectAll" command.

11:59 AM Changeset in webkit [51910] by eric@webkit.org

2 edits in trunk/WebCore

2009-12-09 Patrick Scott <phanna@email.unc.edu>

Fix the build with ENABLE_ORIENTATION_EVENTS
https://bugs.webkit.org/show_bug.cgi?id=32321

page/Frame.cpp: (WebCore::Frame::sendOrientationChangeEvent):

11:52 AM Changeset in webkit [51909] by eric@webkit.org

2 edits in trunk/WebCore

2009-12-09 Avi Drissman <avi@chromium.org>

Reviewed by Darin Fisher.

Chromium tickmarks in scrollbar now UX approved.
https://bugs.webkit.org/show_bug.cgi?id=32069

platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint):

11:00 AM Changeset in webkit [51908] by andersca@apple.com

2 edits in trunk/JavaScriptCore

Attempt to fix the Windows build.

Reviewed by Sam Weinig.

wtf/FastMalloc.h:

10:53 AM Changeset in webkit [51907] by bfulgham@webkit.org

2 edits in trunk/WebKit/win

Provide an implementation for 'selectAll'
https://bugs.webkit.org/show_bug.cgi?id=32296

Reviewed by Darin Adler.

WebFrame.cpp:

(WebFrame::selectAll): Implement "SelectAll" command.

10:44 AM Changeset in webkit [51906] by cmarrin@apple.com

9 edits in trunk

Delay load DLLs for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=31856

Add logic to turn off accelerated compositing if d3d9 or QuartzCore
DLLs are not present.

10:40 AM Changeset in webkit [51905] by andersca@apple.com

4 edits in trunk/JavaScriptCore

Fix some things found while trying to compile JavaScriptCore with clang++.

Reviewed by Sam Weinig.

wtf/FastMalloc.h:

Add correct exception specifications for the allocation/deallocation operators.

wtf/Vector.h:
wtf/VectorTraits.h:

Fix a bunch of struct/class mismatches.

10:22 AM Changeset in webkit [51904] by darin@chromium.org

2 edits in trunk/WebKit/chromium

2009-12-08 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Include clickCount when doing MouseEvent -> WebMouseEvent conversion
in Chromium API.

https://bugs.webkit.org/show_bug.cgi?id=32289

src/WebInputEventConversion.cpp: (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):

10:11 AM Changeset in webkit [51903] by abarth@webkit.org

4 edits in trunk/WebKitTools

2009-12-09 Adam Barth <abarth@webkit.org>

Unreviewed. Fix ScriptError includes. I don't understand why these
didn't throw during unit testing...

Scripts/modules/commands/download.py:
Scripts/modules/logging_unittest.py:
Scripts/modules/workqueue.py:

9:43 AM Changeset in webkit [51902] by Nate Chapin

13 edits
2 moves in trunk/WebCore

2009-12-09 Nate Chapin <Nate Chapin>

Reviewed by Darin Adler.

Rename dom/ClassNames to SpaceSplitString and update build files.

https://bugs.webkit.org/show_bug.cgi?id=32250

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules):
dom/ClassNames.cpp: Removed.
dom/ClassNames.h: Removed.
dom/ClassNodeList.h:
dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::classNames):
dom/SpaceSplitString.cpp: Copied from WebCore/dom/ClassNames.cpp. (WebCore::SpaceSplitStringData::createVector): (WebCore::SpaceSplitStringData::containsAll):
dom/SpaceSplitString.h: Copied from WebCore/dom/ClassNames.h. (WebCore::SpaceSplitStringData::SpaceSplitStringData): (WebCore::SpaceSplitString::SpaceSplitString): (WebCore::SpaceSplitString::set): (WebCore::SpaceSplitString::containsAll):
dom/StyledElement.h: (WebCore::StyledElement::classNames):
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setRel):

9:28 AM Changeset in webkit [51901] by senorblanco@chromium.org

8 edits in trunk/WebCore

Enable SVG filters in Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=32323

Reviewed by Darin Fisher.

Covered by SVG filter layout tests.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/DerivedSourcesAllInOne.cpp:
bindings/v8/V8DOMWrapper.cpp:
bindings/v8/V8Index.cpp:
bindings/v8/V8Index.h:

8:59 AM QtWebKit/CodeCamp200912 edited by zecke@selfish.org

mention the performance talks (diff)

8:50 AM bbandix_drt_tools.pdf attached to QtWebKit/CodeCamp200912 by abecsi@inf.u-szeged.hu

7:26 AM Changeset in webkit [51900] by yurys@chromium.org

2 edits in trunk/WebKit/chromium

2009-12-09 Yury Semikhatsky <yurys@chromium.org>

Unreviewed, build fix.

Add return statement to default implementation of hostIdentifier method
introduced in http://trac.webkit.org/changeset/51897

public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::hostIdentifier):

7:05 AM Changeset in webkit [51899] by yurys@chromium.org

3 edits in trunk/WebKit/chromium

2009-12-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Add declaration of static methods that allow to dispatch
DevTools messages on the IO thread and accept WebDevToolsMessageData
argument.

https://bugs.webkit.org/show_bug.cgi?id=32314

public/WebDevToolsAgent.h:
public/WebDevToolsAgentClient.h:

6:49 AM WkMem.pdf attached to QtWebKit/CodeCamp200912 by zherczeg@inf.u-szeged.hu

Meamory measurement using freya (valgrind)

5:27 AM Changeset in webkit [51898] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Skip a failing test introduced in r51877.

platform/qt/Skipped: fast/loader/input-element-page-cache-crash.html added.

5:19 AM Changeset in webkit [51897] by yurys@chromium.org

6 edits
1 copy in trunk/WebKit/chromium

2009-12-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce a class for devtools message data

https://bugs.webkit.org/show_bug.cgi?id=32314

WebKit.gyp:
public/WebDevToolsAgent.h:
public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::sendMessageToFrontend): (WebKit::WebDevToolsAgentClient::forceRepaint): (WebKit::WebDevToolsAgentClient::hostIdentifier): (WebKit::WebDevToolsAgentClient::runtimeFeatureStateChanged):
public/WebDevToolsFrontend.h:
public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendMessageToAgent):
public/WebDevToolsMessageData.h: Added.

5:15 AM ARM-JIT.pdf attached to QtWebKit/CodeCamp200912 by zherczeg@inf.u-szeged.hu

ARM-JIT in nutshell

5:04 AM Changeset in webkit [51896] by Nikolas Zimmermann

2 edits in trunk/LayoutTests

2009-12-09 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix typo in the Skipped list s/.htm/.html/ in the last test I added.

platform/mac-snowleopard/Skipped:

3:34 AM QtWebKit/CodeCamp200912 edited by vestbo@webkit.org

(diff)

2:09 AM QtWebKit/CodeCamp200912 edited by akiss@inf.u-szeged.hu

(diff)

2:05 AM akiss-uszintro.pdf attached to QtWebKit/CodeCamp200912 by akiss@inf.u-szeged.hu

Intro to #u-szeged

1:54 AM WebKit Team edited by xan@webkit.org

(diff)

1:39 AM Changeset in webkit [51895] by abarth@webkit.org

4 edits
1 delete in trunk/WebKitTools

2009-12-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Remove unused PatchCollection class
https://bugs.webkit.org/show_bug.cgi?id=32312

It's dead code.

Scripts/modules/patchcollection.py:
Scripts/modules/patchcollection_unittest.py: Removed.

1:29 AM Changeset in webkit [51894] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-12-09 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix. CheckStyle needs a --no-upate option.

Scripts/modules/commands/download.py:

1:24 AM Changeset in webkit [51893] by abarth@webkit.org

4 edits
1 add in trunk/WebKitTools

2009-12-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Convert Build to use Sequence
https://bugs.webkit.org/show_bug.cgi?id=32310

So much prettier.

Scripts/modules/buildsteps.py:
Scripts/modules/commands/download.py:
Scripts/modules/landingsequence.py:
Scripts/modules/stepsequence.py: Added.

1:17 AM Changeset in webkit [51892] by oliver@apple.com

3 edits in trunk/WebCore

Build fix

12:26 AM Changeset in webkit [51891] by abarth@webkit.org

1 edit
1 add in trunk/WebKitTools

2009-12-09 Adam Barth <abarth@webkit.org>

Add missing file.

Scripts/modules/executive.py: Added.

12:24 AM Changeset in webkit [51890] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-12-09 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix.

Scripts/modules/landingsequence.py:

12:20 AM Changeset in webkit [51889] by abarth@webkit.org

12 edits
1 delete in trunk/WebKitTools

2009-12-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Implement abstract Steps
https://bugs.webkit.org/show_bug.cgi?id=32212

This is a fairly disruptive change that refactors how we build
commands. Instead of using a landing sequence, we can now assemble a
sequence of steps directly. We still use the landing sequence in the
interim, but this will be removed soon.

Scripts/bugzilla-tool:
Scripts/modules/buildsteps.py:
Scripts/modules/commands/download.py:
Scripts/modules/commands/early_warning_system.py:
Scripts/modules/commands/queues.py:
Scripts/modules/commands/queues_unittest.py:
Scripts/modules/landingsequence.py:
Scripts/modules/mock_bugzillatool.py:
Scripts/modules/processutils.py: Removed.
Scripts/modules/scm.py:
Scripts/modules/scm_unittest.py:
Scripts/modules/webkitport.py:

Dec 8, 2009:

11:51 PM Changeset in webkit [51888] by eric@webkit.org

11 edits in trunk/WebKitTools

2009-12-08 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

run_command and ScriptError should move into processutils.py
https://bugs.webkit.org/show_bug.cgi?id=32305

Turns out there are a zillion callers to run_command.

Scripts/modules/commands/download.py:
Scripts/modules/commands/early_warning_system.py:
Scripts/modules/commands/queues.py:
Scripts/modules/landingsequence.py:
Scripts/modules/logging_unittest.py:
Scripts/modules/processutils.py:
Scripts/modules/scm.py:
Scripts/modules/scm_unittest.py:
Scripts/modules/workqueue.py:
Scripts/modules/workqueue_unittest.py:

7:43 PM Changeset in webkit [51887] by mjs@apple.com

1 edit in trunk/JavaScriptCore/ChangeLog

Remove stray conflict marker.

7:39 PM Changeset in webkit [51886] by ukai@chromium.org

7 edits
3 adds in trunk

2009-12-08 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Darin Adler.

WebSocket allow space (U+0020) in sub protocol name.
https://bugs.webkit.org/show_bug.cgi?id=32266

Skipped sub-protocol-with-space.html for now until new pywebsocket is
landed.

websocket/tests/bad-sub-protocol-expected.txt:
websocket/tests/script-tests/bad-sub-protocol.js:
websocket/tests/script-tests/sub-protocol-with-space.js: Added.
websocket/tests/sub-protocol-with-space-expected.txt: Added.
websocket/tests/sub-protocol-with-space.html: Added.

2009-12-08 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Darin Adler.

WebSocket allow space (U+0020) in sub protocol name.
https://bugs.webkit.org/show_bug.cgi?id=32266

Test: websocket/tests/sub-protocol-with-space.html

websockets/WebSocket.cpp: (WebCore::isValidProtocolString):

7:20 PM Changeset in webkit [51885] by ukai@chromium.org

1 edit
3 adds in trunk/LayoutTests

2009-12-08 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Darin Adler.

Add tests that WebSocket-Protocol: is ignored if protocol was not specified.
https://bugs.webkit.org/show_bug.cgi?id=32267

websocket/tests/script-tests/websocket-protocol-ignored.js: Added.
websocket/tests/websocket-protocol-ignored-expected.txt: Added.
websocket/tests/websocket-protocol-ignored.html: Added.

6:38 PM Changeset in webkit [51884] by eric@webkit.org

14 edits
7 adds in trunk

2009-12-08 Peterson Trethewey <petersont@google.com>

Reviewed by Oliver Hunt.

Implement WebGLUniformLocation and change API to use it.
https://bugs.webkit.org/show_bug.cgi?id=31173

fast/canvas/webgl/resources/structUniformShader.vert: Added.
fast/canvas/webgl/script-tests/uniform-location.js: Added.
fast/canvas/webgl/uniform-location-expected.txt: Added.
fast/canvas/webgl/uniform-location.html: Added.

2009-12-08 Peterson Trethewey <petersont@google.com>

Reviewed by Oliver Hunt.

Implement WebGLUniformLocation and change API to use it.
https://bugs.webkit.org/show_bug.cgi?id=31173

Test: fast/canvas/webgl/uniform-location.html

DerivedSources.make:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::getProgramParameter): (WebCore::JSWebGLRenderingContext::getUniform): (WebCore::functionForUniform): (WebCore::dataFunctionf): (WebCore::dataFunctioni): (WebCore::dataFunctionMatrix):
bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/DerivedSourcesAllInOne.cpp:
bindings/v8/V8Index.cpp:
bindings/v8/V8Index.h:
bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toWebGLUniformLocation): (WebCore::): (WebCore::CALLBACK_FUNC_DECL): (WebCore::isFunctionToCallForAttribute): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv):
html/canvas/WebGLRenderingContext.h:
html/canvas/WebGLRenderingContext.idl:
html/canvas/WebGLUniformLocation.cpp: Added. (WebCore::WebGLUniformLocation::create): (WebCore::WebGLUniformLocation::WebGLUniformLocation):
html/canvas/WebGLUniformLocation.h: Added. (WebCore::WebGLUniformLocation::~WebGLUniformLocation): (WebCore::WebGLUniformLocation::program): (WebCore::WebGLUniformLocation::location):
html/canvas/WebGLUniformLocation.idl: Added.

5:43 PM Changeset in webkit [51883] by agl@chromium.org

3 edits
2 adds in trunk

2009-12-08 Adam Langley <agl@google.com>

Reviewed by Darin Adler.

Fix assertion failure in WebCore::RenderBlock::startDelayUpdateScrollInfo

startDelayUpdateScrollInfo calls a function that can end up calling
startDelayUpdateScrollInfo again. However, it's static state is
inconsistent when this happens leading to an assertion failure (or
probably a memory leak if assertions are off).

Thanks to Robert Swiecki for the test case.

https://bugs.webkit.org/show_bug.cgi?id=32172
http://code.google.com/p/chromium/issues/detail?id=28880

Test: fast/css/recursive-delay-update-scroll.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::finishDelayUpdateScrollInfo):

2009-12-08 Adam Langley <agl@google.com>

Reviewed by Darin Adler.

Fix assertion failure in WebCore::RenderBlock::startDelayUpdateScrollInfo

startDelayUpdateScrollInfo calls a function that can end up calling
startDelayUpdateScrollInfo again. However, it's static state is
inconsistent when this happens leading to an assertion failure (or
probably a memory leak if assertions are off).

Thanks to Robert Swiecki for the test case.

https://bugs.webkit.org/show_bug.cgi?id=32172
http://code.google.com/p/chromium/issues/detail?id=28880

fast/css/recursive-delay-update-scroll.html: Added.
fast/css/recursive-delay-update-scroll-expected.txt: Added.

5:29 PM Changeset in webkit [51882] by mjs@apple.com

9 edits
1 copy in trunk/JavaScriptCore

move code generation portions of Nodes.cpp to bytecompiler directory
https://bugs.webkit.org/show_bug.cgi?id=32284

Reviewed by Darin Adler.

bytecompiler/NodesCodegen.cpp: Copied from parser/Nodes.cpp. Removed parts that

are not about codegen.

parser/Nodes.cpp: Removed everything that is about codegen.

Update build systems:

Android.mk:
GNUmakefile.am:
JavaScriptCore.gypi:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:

4:59 PM Changeset in webkit [51881] by sfalken@apple.com

2 edits in trunk/WebCore

WebCore source level debugging on Windows not reliable in some cases
https://bugs.webkit.org/show_bug.cgi?id=32297

Reviewed by Adam Roben.

Customized pdb file name/location for WebCore static library.

WebCore.vcproj/WebCoreCommon.vsprops: Add ProgramDataBaseFileName.

4:52 PM Changeset in webkit [51880] by kevino@webkit.org

14 edits
1 add in trunk

Reviewed by Kevin Ollivier.

[wx] Mac plugins support.

https://bugs.webkit.org/show_bug.cgi?id=32236

4:40 PM Changeset in webkit [51879] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-12-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/7295070> WebKit video fullscreen keeps playing after closing the window

Fix a leak of the QTMovieView when exiting fullscreen video, and remove the
old workaround.

WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): Set the movie view as the contentView directly. (-[WebVideoFullscreenController setMediaElement:WebCore::]): Cast the contentView to a movie view. (-[WebVideoFullscreenController windowDidExitFullscreen]): Remove the old workaround.

4:14 PM Changeset in webkit [51878] by Nikolas Zimmermann

2 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skip another failing media test, that I already mentioned in the bug report.

platform/mac-snowleopard/Skipped:

4:08 PM Changeset in webkit [51877] by beidson@apple.com

3 edits
2 adds in trunk

Navigating to a cached page can result in accessing a destroyed HTMLInputElement.
<rdar://problem/6856662> and https://webkit.org/b/32293

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/input-element-page-cache-crash.html

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute): Make sure to unregister for the activation

callback after the new m_autocomplete setting has been stored so the unregistration actually
takes place.

LayoutTests:

fast/loader/input-element-page-cache-crash-expected.txt: Added.
fast/loader/input-element-page-cache-crash.html: Added.

3:54 PM Changeset in webkit [51876] by levin@chromium.org

3 edits in trunk/WebKitTools

[check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {
https://bugs.webkit.org/show_bug.cgi?id=32193

Reviewed by Adam Barth.

Scripts/modules/cpp_style.py: For the function { rule, if there is space at the beginning of line, ignore lines which then have a macro.
Scripts/modules/cpp_style_unittest.py: Add tests to verify the new behavior.

3:27 PM Changeset in webkit [51875] by dimich@chromium.org

14 edits
5 deletes in trunk

Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
It may have caused massive increase of reported leaks on the bots.
https://bugs.webkit.org/show_bug.cgi?id=31639

Rubber-stamped by David Levin.

JavaScriptCore:

GNUmakefile.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/Structure.cpp:

(JSC::Structure::Structure):

wtf/RefCounted.h:

(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::hasOneRef):
(WTF::RefCountedBase::refCount):
(WTF::RefCountedBase::derefBase):

wtf/ThreadVerifier.h: Removed.

JavaScriptGlue:

ForwardingHeaders/wtf/ThreadVerifier.h: Removed.

WebCore:

ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
loader/icon/IconRecord.cpp:

(WebCore::IconRecord::IconRecord):

platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer):

platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl):

WebKit/mac:

ForwardingHeaders/wtf/ThreadVerifier.h: Removed.

WebKitTools:

DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed.

2:45 PM WebInspector edited by timothy@apple.com

(diff)

2:43 PM Changeset in webkit [51874] by pfeldman@chromium.org

14 edits
1 copy in trunk

2009-12-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Darin Fisher.

Chromium: support custom WebCore context menu items in Chromium port.

https://bugs.webkit.org/show_bug.cgi?id=32277

WebCore:

platform/ContextMenu.h:
platform/ContextMenuItem.h: (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
platform/chromium/ContextMenuChromium.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemWithAction): (WebCore::ContextMenu::itemAtIndex): (WebCore::ContextMenu::platformDescription):
platform/chromium/ContextMenuItemChromium.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::checked): (WebCore::ContextMenuItem::enabled): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled):

WebKit/chromium:

public/WebContextMenuData.h:
public/WebPopupMenuInfo.h: (WebKit::WebPopupMenuInfo::Item::):
public/WebView.h:
src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::executeCustomContextMenuAction):
src/WebViewImpl.h:

2:42 PM Changeset in webkit [51873] by Nikolas Zimmermann

3 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skip fast/repaint/block-selection-gap-in-table-cell.html (generates new result) to turn Qt/Gtk builds green again.

platform/gtk/Skipped:
platform/qt/Skipped:

1:58 PM Changeset in webkit [51872] by agl@chromium.org

2 edits in trunk/WebCore

2009-12-08 Adam Langley <agl@google.com>

Reviewed by Dimitri Glazkov.

Chromium Linux: set default scrollbar colours.

This is so that layout tests have sane defaults for the scrollbar
colours, even if the API user doesn't set any.

This is a fix due to r51827.

https://bugs.webkit.org/show_bug.cgi?id=32287

This is very well covered by existing layout tests.

rendering/RenderThemeChromiumLinux.cpp:

1:35 PM Changeset in webkit [51871] by kov@webkit.org

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Make WebKit build correctly on FreeBSD, IA64, and Alpha.
Based on work by Petr Salinger <Petr.Salinger@seznam.cz>,
and Colin Watson <cjwatson@ubuntu.com>.

wtf/Platform.h:

1:14 PM Changeset in webkit [51870] by Beth Dakin

2 edits in trunk/WebCore

Fix for <rdar://problem/7397808> Crash occurs at
RenderObject::containingBlock() as I type in the Google Search
field (during page load)

Reviewed by Sam Weinig.

editing/Editor.cpp:

(WebCore::Editor::insideVisibleArea): ownerRenderer() needs to be
null checked.

12:25 PM Changeset in webkit [51869] by dimich@chromium.org

14 edits
5 adds in trunk

Add asserts to RefCounted to make sure ref/deref happens on the right thread.
https://bugs.webkit.org/show_bug.cgi?id=31639

Reviewed by Darin Adler.

JavaScriptCore:

runtime/Structure.cpp:

(JSC::Structure::Structure): Disable thread verification on this class since it uses addressOfCount().

wtf/RefCounted.h:

(WTF::RefCountedBase::ref): Add ASSERT.
(WTF::RefCountedBase::hasOneRef): Ditto.
(WTF::RefCountedBase::refCount): Ditto.
(WTF::RefCountedBase::derefBase): Ditto.
(WTF::RefCountedBase::disableThreadVerification): delegate to ThreadVerifier method.

wtf/ThreadVerifier.h: Added.

(WTF::ThreadVerifier::ThreadVerifier): New Debug-only class to verify that ref/deref of RefCounted is done on the same thread.
(WTF::ThreadVerifier::activate): Activates checks. Called when ref count becomes above 2.
(WTF::ThreadVerifier::deactivate): Deactivates checks. Called when ref count drops below 2.
(WTF::ThreadVerifier::disableThreadVerification): used on objects that should not be checked (StringImpl etc)
(WTF::ThreadVerifier::verifyThread):

GNUmakefile.am: Add ThreadVerifier.h to the build file.
JavaScriptCore.gypi: Ditto.
JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
JavaScriptCore.xcodeproj/project.pbxproj: Ditto.

JavaScriptGlue:

ForwardingHeaders/wtf/ThreadVerifier.h: Added.

WebCore:

loader/icon/IconRecord.cpp:

(WebCore::IconRecord::IconRecord): Disable thread verification for this class because of its cross-thread use in IconDatabase.

platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer): Ditto.

platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl): Disable thread verification for this class, add FIXME to enforce proper usage via crossThreadString.

ForwardingHeaders/wtf/ThreadVerifier.h: Added.

WebKit/mac:

ForwardingHeaders/wtf/ThreadVerifier.h: Added.

WebKitTools:

DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added.

11:16 AM Changeset in webkit [51868] by ajwong@chromium.org

2 edits in trunk/WebKit/chromium

Not reviewed: Chromium build fix.

r51859 changed the case for some of the ResourceRequest::TargetType
enums.

src/FrameLoaderClientImpl.cpp:

(WebKit::determineTargetTypeFromLoader):

10:59 AM Changeset in webkit [51867] by Adam Roben

2 edits in trunk/WebKit/win

Windows build fix

Interfaces/WebKit.idl: Touched this to force Interfaces.vcproj to rebuild.

10:55 AM Changeset in webkit [51866] by levin@chromium.org

3 edits in trunk/WebKitTools

[check-webkit-style] False positive for camel case of JSC op codes
https://bugs.webkit.org/show_bug.cgi?id=32192

Reviewed by Adam Barth.

Scripts/modules/cpp_style.py: Added an exception for the JSC op code functions and const_iterator as well since I noticed a false positive there when testing the fix.
Scripts/modules/cpp_style_unittest.py: Added tests for these changes.

10:44 AM Changeset in webkit [51865] by abarth@webkit.org

7 edits
2 adds in trunk

2009-12-08 John Gregg <johnnyg@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31886

Test for accessing the notificationCenter of a window after it's closed.

fast/notifications/notification-after-close-expected.txt: Added.
fast/notifications/notification-after-close.html: Added.

2009-12-08 John Gregg <johnnyg@google.com>

Reviewed by Adam Barth.

Inform the NotificationCenter when its window goes away in the same
manner as other DOMWindow fields, and prevent invalid operations on
it after that happens.

As part of this, change the V8 bindings for notifications to call
through the NotificationCenter rather than doing those operations
itself.

https://bugs.webkit.org/show_bug.cgi?id=31886

Test: fast/notifications/notification-after-close.html

bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
notifications/Notification.cpp: (WebCore::Notification::Notification):
notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission): (WebCore::NotificationCenter::requestPermission):
notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification): (WebCore::NotificationCenter::disconnectFrame):
page/DOMWindow.cpp: (WebCore::DOMWindow::clear):

10:44 AM CommitQueue edited by abarth@webkit.org

(diff)

9:37 AM Changeset in webkit [51864] by mitz@apple.com

4 edits
4 adds in trunk

WebCore: Fixed block selection gap repainting in table cells

Reviewed by John Sullivan.

Test: fast/repaint/block-selection-gap-in-table-cell.html

This recently-introduced regression exposed the fact that
RenderTableCell did not override offsetFromContainer() to adjust for
the fact that table cells’ coordinates are relative to the table
section, not the table row. With this fixed, RenderTableCell no longer
needs to override mapLocalToContainer() and mapAbsoluteToLocalPoint(),
since the base class implementations of those use offsetFromContainer().

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::offsetFromContainer):

rendering/RenderTableCell.h:

LayoutTests: Added a test of block selection gap repainting in table cells

Reviewed by John Sullivan.

fast/repaint/block-selection-gap-in-table-cell.html: Added.
platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.checksum: Added.
platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.png: Added.
platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Added.

9:35 AM Changeset in webkit [51863] by Nikolas Zimmermann

2 edits in trunk/WebCore

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Sane way to force a rebuild on all win slaves, according to Adam Roben.

WebCorePrefix.h:

9:32 AM Changeset in webkit [51862] by mitz@apple.com

1 edit in trunk/WebCore/ChangeLog

Correct Bugzilla link

9:31 AM Changeset in webkit [51861] by mitz@apple.com

2 edits in trunk/WebCore

Build fix

loader/loader.cpp:

(WebCore::cachedResourceTypeToTargetType):

9:08 AM Changeset in webkit [51860] by Nikolas Zimmermann

2 edits in trunk/WebCore

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Touch svgtags.in to eventually fix the win debug build.

svg/svgtags.in:

9:04 AM Changeset in webkit [51859] by eric@webkit.org

4 edits in trunk/WebCore

2009-12-08 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=32152
Update the ResourceRequest::RequestType. This previously
was specific to Chromium. Moved into ResourceRequestBase, enabling
more specificity about the type (which is otherwise only known to the
loader), and also making this information available to all platforms.
Any platform with a network layer which can utilize this information
may want to use it for prioritization.

Note to Chromium glue: TargetIsSubResource renamed to TargetIsSubresource.

loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::CachedResourceTypeToTargetType): (WebCore::Loader::Host::servePendingRequests):
platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::): (WebCore::ResourceRequestBase::targetType): (WebCore::ResourceRequestBase::setTargetType): (WebCore::ResourceRequestBase::ResourceRequestBase):
platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):

8:55 AM Changeset in webkit [51858] by eric@webkit.org

4 edits
7 adds in trunk

2009-12-08 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

[Android] Adds Makefiles for Android port.
https://bugs.webkit.org/show_bug.cgi?id=31325

Android.mk: Added.

2009-12-08 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

[Android] Adds Makefiles for Android port.
https://bugs.webkit.org/show_bug.cgi?id=31325

Android.mk: Added.
Android.v8.wtf.mk: Added.

2009-12-08 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

[Android] Adds Makefiles for Android port.
https://bugs.webkit.org/show_bug.cgi?id=31325

Build system change only. No tests possible.

Android.derived.jscbindings.mk: Added.
Android.derived.mk: Added.
Android.jscbindings.mk: Added.
Android.mk: Added.
WebCorePrefix.h: Modified. Sets up some flags and adds a header required for building on Android.

8:55 AM Changeset in webkit [51857] by sullivan@apple.com

2 edits in trunk/WebKit/win

Split two-clause assertions into two separate assertions.

Reviewed by Dan Bernstein

DOMHTMLClasses.cpp:

(DOMHTMLInputElement::isTextField):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::rectOnScreen):
Added the two assertions here that all other functions in this group shared.
(DOMHTMLInputElement::selectedRange):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::setAutofilled):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::isAutofilled):
Split a two-clause assertion into two separate assertions.

8:36 AM Changeset in webkit [51856] by christian@webkit.org

4 edits in trunk

2009-12-08 Christian Dywan <christian@twotoasts.de>

Reviewed by Xan Lopez.

configure.ac: Require only libSoup 2.27.91 but check for 2.29.3 and define HAVE_LIBSOUP_2_29_3 in that case.

8:28 AM Changeset in webkit [51855] by Nikolas Zimmermann

10 edits in trunk

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Maciej Stachowiak.

Turn on (SVG) Filters for Win.
https://bugs.webkit.org/show_bug.cgi?id=32224

8:17 AM Changeset in webkit [51854] by christian@webkit.org

2 edits in trunk/WebKit/gtk

2009-12-08 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

Point out the meaning of "Content-Disposition" when implementing the
mime-type-policy-decision-requested signal.

webkit/webkitwebview.cpp: (webkit_web_view_class_init):

7:58 AM Changeset in webkit [51853] by kov@webkit.org

2 edits in trunk

Rubber-stamped by Xan Lopez.

Late post-release version bump.

configure.ac:

7:33 AM Changeset in webkit [51852] by eric@webkit.org

5 edits in trunk/LayoutTests

2009-12-08 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

These test results should not have platform-dependent pixel values.
https://bugs.webkit.org/show_bug.cgi?id=32265

Change is75PercentOf() so that it doesn't show pixel values when
the check is passed.

fast/replaced/table-percent-height-expected.txt:
fast/replaced/table-percent-height-text-controls-expected.txt:
fast/replaced/table-percent-height-text-controls.html:
fast/replaced/table-percent-height.html:

7:20 AM Changeset in webkit [51851] by eric@webkit.org

3 edits
2 adds in trunk

2009-12-08 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

CSS Counter Nesting still does not work according to the spec.
https://bugs.webkit.org/show_bug.cgi?id=31723

fast/css/counters/nesting-expected.txt: Added.
fast/css/counters/nesting.html: Added. This test tests compliance with the CSS2.1 counter scoping and nesting rules.

2009-12-08 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

CSS Counter Nesting still does not work according to the spec.
https://bugs.webkit.org/show_bug.cgi?id=31723

Test: fast/css/counters/nesting.html

rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Replaced the faulty counter insertion algorithm with one that works.

7:08 AM Changeset in webkit [51850] by sullivan@apple.com

7 edits in trunk

Add isAutofilled getter to match existing setter.

Reviewed by Ada Chan.

WebCore:

bindings/objc/DOMHTML.mm:

(-[DOMHTMLInputElement _isAutofilled]):
Implemented new cover function.

bindings/objc/DOMPrivate.h:

Declared new cover function.

WebKit/win:

DOMHTMLClasses.cpp:

(DOMHTMLInputElement::isAutofilled):
Implemented new cover function.

DOMHTMLClasses.h:

Declared new cover function.

Interfaces/DOMPrivate.idl:

Declared new interface.

7:02 AM Changeset in webkit [51849] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector().

platform/qt/Skipped: inspector/cookie-resource-match.html added.

6:58 AM Changeset in webkit [51848] by eric@webkit.org

4 edits
1 add in trunk

2009-12-08 Dominik Röttsches <dominik.roettsches@access-company.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] Create a TextBreakIterator implementation based on GLib (without ICU)
https://bugs.webkit.org/show_bug.cgi?id=31469

Removing hybrid configuration for --with-unicode-backend=glib
ICU not required anymore.

autotools/webkit.m4:

2009-12-08 Dominik Röttsches <dominik.roettsches@access-company.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] Create a TextBreakIterator implementation based on GLib (without ICU)
https://bugs.webkit.org/show_bug.cgi?id=31469

Added a TextBreakIterator implementation based on GLib and pango,
which allows compiling WebCore without ICU.

GNUmakefile.am:
platform/text/gtk/TextBreakIteratorGtk.cpp: Added. (WebCore::): (WebCore::setUpIterator): (WebCore::characterBreakIterator): (WebCore::cursorMovementIterator): (WebCore::wordBreakIterator): (WebCore::lineBreakIterator): (WebCore::sentenceBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakLast): (WebCore::textBreakNext): (WebCore::textBreakPrevious): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent): (WebCore::isTextBreak):

6:35 AM Changeset in webkit [51847] by Nikolas Zimmermann

2 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update Gtk's custom prototype-inheritance-2-expected.txt, after enabling filters
(As gtk builds with geolocation, unlike the other platforms, it needs its own results)

This turns the Gtk slave to green again.

platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

6:09 AM QtWebKit/CodeCamp200912 edited by tapani.mikola@nokia.com

(diff)

6:02 AM QtWebKit edited by tapani.mikola@nokia.com

(diff)

5:56 AM QtWebKit/CodeCamp200912 created by tapani.mikola@nokia.com

5:21 AM Changeset in webkit [51846] by eric@webkit.org

11 edits
2 adds in trunk

2009-12-08 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Change the way cookies are retrieved in the WebInspector frontend.

Moved the cookie filtering from the native code into the frontend so that
all cookies can be retrieved regardless of the associated domain
(required for certain audits to run.)
https://bugs.webkit.org/show_bug.cgi?id=32160

inspector/cookie-resource-match-expected.txt: Added.
inspector/cookie-resource-match.html: Added.

2009-12-08 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Change the way cookies are retrieved in the WebInspector frontend.

Moved the cookie filtering from the native code into the frontend so that
all cookies can be retrieved regardless of the associated domain
(required for certain audits to run.)
https://bugs.webkit.org/show_bug.cgi?id=32160

Test: inspector/cookie-resource-match.html

inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getCookies):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies):
inspector/InspectorController.h:
inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype.update.callback): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._cookiesForDomain):
inspector/front-end/DOMAgent.js: (WebInspector.Cookies.getCookiesAsync): (WebInspector.Cookies.cookieMatchesResourceURL): (WebInspector.Cookies.cookieDomainMatchesResourceDomain):
inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.get documentURL): (WebInspector.Resource.prototype.set documentURL):
inspector/front-end/inspector.js: (WebInspector.addResource):

4:55 AM Changeset in webkit [51845] by Nikolas Zimmermann

2 edits in trunk/WebCore

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Touch svgtags.in, in order to force SVGNames.* regeneration. Praying for gtk bot to be fixed :-)

svg/svgtags.in:

4:30 AM Changeset in webkit [51844] by Nikolas Zimmermann

2 edits in trunk/WebCore

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Trying to force a rebuild on the Gtk slave. If that doesn't work, someone must force a rebuild from scratch.

bindings/scripts/CodeGeneratorJS.pm:

3:51 AM Changeset in webkit [51843] by Nikolas Zimmermann

6 edits in trunk

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Maciej Stachowiak.

Turn on (SVG) Filters for Gtk.
https://bugs.webkit.org/show_bug.cgi?id=32224

3:21 AM Changeset in webkit [51842] by Nikolas Zimmermann

2 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skip some tests that fail for a longer period on the SnowLeopard bot. Filed two bugs, notifying the authors.

platform/mac-snowleopard/Skipped:

2:58 AM Changeset in webkit [51841] by Nikolas Zimmermann

4 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Oops forgot to update three results -> Qt slave green again.

platform/qt/svg/filters/feGaussianBlur-expected.txt:
platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
platform/qt/svg/filters/feOffset-expected.txt:

2:47 AM Changeset in webkit [51840] by Nikolas Zimmermann

11 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Now that the Qt slave has been rebuilt, reenable all tests that failed
because of the build problems (Qt slave didn't rebuild all files with ENABLE_FILTERS set).

Update some Qt specfic filter test results.

platform/qt/Skipped:
platform/qt/svg/filters/feComposite-expected.txt:
platform/qt/svg/filters/feMerge-expected.txt:
platform/qt/svg/filters/feTile-expected.txt:
platform/qt/svg/filters/shadow-on-filter-expected.txt:
platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
platform/qt/svg/filters/sourceAlpha-expected.txt:
platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
platform/qt/svg/filters/subRegion-one-effect-expected.txt:
platform/qt/svg/filters/subRegion-two-effects-expected.txt:

2:19 AM Changeset in webkit [51839] by pfeldman@chromium.org

22 edits
2 copies in trunk/WebCore

2009-12-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: provide custom context menu in the front-end window.

https://bugs.webkit.org/show_bug.cgi?id=32200

English.lproj/localizedStrings.js:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::contextMenuItemSelected): (WebCore::InspectorFrontend::contextMenuCleared):
inspector/InspectorFrontend.h:
inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::showContextMenu): (WebCore::InspectorFrontendHost::contextMenuItemSelected): (WebCore::InspectorFrontendHost::contextMenuCleared):
inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::MenuSelectionHandler::create): (WebCore::InspectorFrontendHost::MenuSelectionHandler::~MenuSelectionHandler): (WebCore::InspectorFrontendHost::MenuSelectionHandler::disconnect): (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuItemSelected): (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuCleared): (WebCore::InspectorFrontendHost::MenuSelectionHandler::MenuSelectionHandler):
inspector/InspectorFrontendHost.idl:
inspector/front-end/ContextMenu.js: Added.
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:
inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentContextMenu):
page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::clearContextMenu): (WebCore::ContextMenuController::handleContextMenuEvent): (WebCore::ContextMenuController::showContextMenu): (WebCore::ContextMenuController::createContextMenu): (WebCore::ContextMenuController::contextMenuItemSelected):
page/ContextMenuController.h:
page/ContextMenuSelectionHandler.h: Added. (WebCore::ContextMenuSelectionHandler::ContextMenuSelectionHandler): (WebCore::ContextMenuSelectionHandler::~ContextMenuSelectionHandler):
platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
platform/ContextMenuItem.h:

2:04 AM Changeset in webkit [51838] by Csaba Osztrogonác

2 edits in trunk/WebCore

Rubber-stamped by Kenneth Rohde Christiansen.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-08
[Qt] Build fix of duplicated platform/graphics/filters/FEGaussianBlur.cpp in WebCore.pro after enabled svg filters.

No new tests needed.

WebCore.pro:

12:32 AM Changeset in webkit [51837] by ukai@chromium.org

1 edit
10 adds in trunk/LayoutTests

2009-12-08 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Darin Adler.

Add tests that WebSocket protocol argument works.
https://bugs.webkit.org/show_bug.cgi?id=3178

websocket/tests/bad-sub-protocol-expected.txt: Added.
websocket/tests/bad-sub-protocol.html: Added.
websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt: Added.
websocket/tests/handshake-fail-by-sub-protocol-mismatch.html: Added.
websocket/tests/protocol-test_wsh.py: Added.
websocket/tests/script-tests/bad-sub-protocol.js: Added.
websocket/tests/script-tests/handshake-fail-by-sub-protocol-mismatch.js: Added.
websocket/tests/script-tests/sub-protocol.js: Added.
websocket/tests/sub-protocol-expected.txt: Added.
websocket/tests/sub-protocol.html: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed