Timeline
Dec 10, 2009:
- 11:54 PM QtWebKit/CodeCamp200912 edited by
- Start documenting day 3 (diff)
- 11:51 PM QtWebKit/CodeCamp200912 edited by
- (diff)
- 7:42 PM Changeset in webkit [51978] by
-
- 5 edits in trunk/JavaScriptCore
2009-12-10 Adam Barth <abarth@webkit.org>
No review, rolling out r51975.
http://trac.webkit.org/changeset/51975
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- runtime/JSString.h: (JSC::JSString::JSString): (JSC::JSString::appendStringInConstruct):
- runtime/Operations.cpp: (JSC::jsAddSlowCase):
- runtime/Operations.h: (JSC::jsString): (JSC::jsAdd):
- 7:12 PM Changeset in webkit [51977] by
-
- 3 edits3 adds in trunk
2009-12-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Mixed content shouldn't trigger for plug-ins without URLs
https://bugs.webkit.org/show_bug.cgi?id=32384
- http/tests/security/mixedContent/empty-url-plugin-in-frame-expected.txt: Added.
- http/tests/security/mixedContent/empty-url-plugin-in-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-empty-url-plugin.html: Added.
2009-12-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Mixed content shouldn't trigger for plug-ins without URLs
https://bugs.webkit.org/show_bug.cgi?id=32384
These plug-ins cannot be controlled by active network attackers, so
there's no reason to trigger a mixed content warning.
Test: http/tests/security/mixedContent/empty-url-plugin-in-frame.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent):
- 6:22 PM Changeset in webkit [51976] by
-
- 5 edits in trunk
Incorrect caching of prototype lookup with dictionary base
https://bugs.webkit.org/show_bug.cgi?id=32402
Reviewed by Gavin Barraclough
Make sure we don't add cached prototype lookup to the proto_list
lookup chain if the top level object is a dictionary.
- 6:07 PM Changeset in webkit [51975] by
-
- 5 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32400
Switch remaining cases of string addition to use ropes.
Reviewed by Oliver Hunt.
~1% progression on Sunspidey.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSString.h:
(JSC::JSString::JSString):
(JSC::JSString::appendStringInConstruct):
- runtime/Operations.cpp:
(JSC::jsAddSlowCase):
- runtime/Operations.h:
(JSC::jsString):
(JSC::jsAdd):
- 4:58 PM Changeset in webkit [51974] by
-
- 2 edits in trunk/WebKit/chromium
Unreviewed, build fix for chromium.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest):
- 4:41 PM Changeset in webkit [51973] by
-
- 3 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32140
REGRESSION(r50072): Mailman administrative functionality is broken
Test: http/tests/misc/percent-sign-in-form-field-name.html
- platform/network/FormDataBuilder.cpp: (WebCore::appendQuotedString): Don't encode percent sign, we never had a good reason to do that.
- 4:20 PM Changeset in webkit [51972] by
-
- 3 edits in trunk/WebKitTools
2009-12-10 Eric Seidel <eric@webkit.org>
No review, just updating unit tests to match recent checkins.
- Scripts/modules/mock_bugzillatool.py:
- Add missing red_core_builders_names method causing exception.
- Scripts/modules/workqueue_unittest.py:
- processutils is dead, use executive.py instead.
- 4:06 PM Changeset in webkit [51971] by
-
- 17 edits in trunk
2009-12-10 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
Remove JSObject::getPropertyAttributes() and all usage of it.
https://bugs.webkit.org/show_bug.cgi?id=31933
getOwnPropertyDescriptor() should be used instead.
- JavaScriptCore.exp:
- JavaScriptCore.order:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::getOwnPropertyDescriptor):
- debugger/DebuggerActivation.h:
- runtime/JSObject.cpp: (JSC::JSObject::propertyIsEnumerable):
- runtime/JSObject.h:
- runtime/JSVariableObject.cpp:
- runtime/JSVariableObject.h:
2009-12-10 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
Remove getPropertyAttributes() from JavaScript bindings.
https://bugs.webkit.org/show_bug.cgi?id=31933
The functionality is provided by getOwnPropertyDescriptor().
- WebCore.order:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSDOMWindowShell.h:
- bindings/scripts/CodeGeneratorJS.pm:
- page/DOMWindow.idl:
- 3:55 PM Changeset in webkit [51970] by
-
- 23 edits3 adds in trunk
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Changed WebGLRenderingContext to synthesize GL errors rather than
raising JavaScript exceptions. Removed internal getError() calls
after each graphics call. The GraphicsContext3D maintains the
synthetic exceptions because only it has complete information
about certain conditions requiring them to be raised.
Based on idea from Ilmari Heikkinen, added create3DDebugContext()
to webgl-test.js and changed the WebGL layout tests expecting
error conditions to use it. Updated expected.txt files, which now
implicitly test the OpenGL error as it is part of the exception's
message.
Added new targeted test covering aspects of synthetic errors as
well as regression tests for bugs uncovered during its development.
Test: fast/canvas/webgl/error-reporting.html
- fast/canvas/webgl/drawArraysOutOfBounds-expected.txt:
- fast/canvas/webgl/drawArraysOutOfBounds.html:
- fast/canvas/webgl/drawElementssOutOfBounds-expected.txt:
- fast/canvas/webgl/drawElementssOutOfBounds.html:
- fast/canvas/webgl/error-reporting-expected.txt: Added.
- fast/canvas/webgl/error-reporting.html: Added.
- fast/canvas/webgl/getActiveTest-expected.txt:
- fast/canvas/webgl/incorrect-context-object-behaviour-expected.txt:
- fast/canvas/webgl/invalidPassedParams-expected.txt:
- fast/canvas/webgl/invalidPassedParams.html:
- fast/canvas/webgl/null-object-behaviour-expected.txt:
- fast/canvas/webgl/resources/webgl-test.js: (create3DDebugContext.wrap.getError): (create3DDebugContext):
- fast/canvas/webgl/script-tests/error-reporting.js: Added.
- fast/canvas/webgl/script-tests/getActiveTest.js:
- fast/canvas/webgl/script-tests/incorrect-context-object-behaviour.js:
- fast/canvas/webgl/script-tests/null-object-behaviour.js:
- fast/canvas/webgl/script-tests/uniform-location.js:
- fast/canvas/webgl/uniform-location-expected.txt:
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Changed WebGLRenderingContext to synthesize GL errors rather than
raising JavaScript exceptions. Removed internal getError() calls
after each graphics call. The GraphicsContext3D maintains the
synthetic exceptions because only it has complete information
about certain conditions requiring them to be raised.
Based on idea from Ilmari Heikkinen, added create3DDebugContext()
to webgl-test.js and changed the WebGL layout tests expecting
error conditions to use it. Updated expected.txt files, which now
implicitly test the OpenGL error as it is part of the exception's
message.
Added new targeted test covering aspects of synthetic errors as
well as regression tests for bugs uncovered during its development.
Test: fast/canvas/webgl/error-reporting.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::sizeInBytes): (WebCore::WebGLRenderingContext::activeTexture): (WebCore::WebGLRenderingContext::attachShader): (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::bindFramebuffer): (WebCore::WebGLRenderingContext::bindRenderbuffer): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::createShader): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::disableVertexAttribArray): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enableVertexAttribArray): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getBufferParameter): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getRenderbufferParameter): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getTexParameter): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::useProgram): (WebCore::WebGLRenderingContext::validateProgram): (WebCore::WebGLRenderingContext::vertexAttribPointer):
- html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::cleanupAfterGraphicsCall):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::synthesizeGLError):
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Changed WebGLRenderingContext to synthesize GL errors rather than
raising JavaScript exceptions. Removed internal getError() calls
after each graphics call. The GraphicsContext3D maintains the
synthetic exceptions because only it has complete information
about certain conditions requiring them to be raised.
Based on idea from Ilmari Heikkinen, added create3DDebugContext()
to webgl-test.js and changed the WebGL layout tests expecting
error conditions to use it. Updated expected.txt files, which now
implicitly test the OpenGL error as it is part of the exception's
message.
Added new targeted test covering aspects of synthetic errors as
well as regression tests for bugs uncovered during its development.
Test: fast/canvas/webgl/error-reporting.html
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::getError): (WebCore::GraphicsContext3DInternal::synthesizeGLError): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::synthesizeGLError):
- 3:47 PM Changeset in webkit [51969] by
-
- 4 edits in trunk/WebKitTools
2009-12-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move run_command onto Executive to make code which uses run_command testable
https://bugs.webkit.org/show_bug.cgi?id=32396
- Scripts/modules/executive.py:
- Move run_command and error handlers onto Executive.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- 3:40 PM Changeset in webkit [51968] by
-
- 2 edits in trunk/WebCore
2009-12-10 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Fix for assert on Chrome/skia with SVG Filters enabled.
https://bugs.webkit.org/show_bug.cgi?id=32394
Covered by LayoutTests/svg/W3C-SVG-1.1/filters-tile-01-b.svg and others.
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
- 3:33 PM Changeset in webkit [51967] by
-
- 3 edits in trunk/WebKit/chromium
2009-12-10 Mike Belshe <mike@belshe.com>
Reviewed by Darin Fisher.
Fix FrameLoader to use the new ResourceTypes properly.
- public/WebURLRequest.h: (WebKit::WebURLRequest::):
- src/FrameLoaderClientImpl.cpp: (WebKit::setTargetTypeFromLoader): (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest):
- 3:28 PM Changeset in webkit [51966] by
-
- 1 edit5 adds in trunk/LayoutTests
Layout test for video element on HTTP
https://bugs.webkit.org/show_bug.cgi?id=32333
Reviewed by Eric Carlson.
Added a new layout test that tests video element on HTTP protocol.
This test load the same video file twice. The first load will cache
the video file if caching is supported. The second load ensure
the cache works correctly.
- http/tests/media/resources/test.mp4: Copied from LayoutTests/media/content/test.mp4.
- http/tests/media/resources/test.ogv: Copied from LayoutTests/media/content/test.ogv.
The above two files are copied from LayoutTests/media/content because the HTTP
server is rooted at LayoutTests/http/tests. And we don't want to serve these
files with cgi because that will ruin the HTTP headers.
- http/tests/media/video-load-twice-expected.txt: Added.
- http/tests/media/video-load-twice.html: Added.
- 2:59 PM Changeset in webkit [51965] by
-
- 7 edits2 adds in trunk
REGRESSION(4.0.4-42a12): With 2 highlighted lines of text in gmail/hotmail selecting Bold selects other 2 edit buttons automatically.
<rdar://problem/7442065>
https://bugs.webkit.org/show_bug.cgi?id=32285
Reviewed by Darin Adler.
WebCore:
When examining the styles of the nodes after the first in a range selection, we take into
cosideration differences in style of txt nodes only.
Test: editing/execCommand/queryCommandState-02.html
- editing/Editor.cpp:
(WebCore::Editor::selectionHasStyle):
LayoutTests:
- editing/execCommand/queryCommandState-02-expected.txt: Added.
- editing/execCommand/queryCommandState-02.html: Added.
- editing/execCommand/script-tests/toggle-compound-styles.js: Fixed typo in text.
- platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
- platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
- platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
- 2:13 PM Changeset in webkit [51964] by
-
- 7 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32367
Add support for short Ropes (up to 3 entries) inline within JSString.
(rather than externally allocating an object to hold the rope).
Switch jsAdd of (JSString* + JSString*) to now make use of Ropes.
Reviewed by Oliver Hunt & Mark Rowe.
~1% progression on Sunspidey.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::toBoolean):
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::JSString::Rope::Fiber::deref):
(JSC::JSString::Rope::Fiber::ref):
(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):
(JSC::JSString::JSString):
(JSC::JSString::~JSString):
(JSC::JSString::value):
(JSC::JSString::tryGetValue):
(JSC::JSString::length):
(JSC::JSString::canGetIndex):
(JSC::JSString::appendStringInConstruct):
(JSC::JSString::appendValueInConstructAndIncrementLength):
(JSC::JSString::isRope):
(JSC::JSString::string):
(JSC::JSString::ropeLength):
(JSC::JSString::getStringPropertySlot):
- runtime/Operations.h:
(JSC::jsString):
(JSC::jsAdd):
(JSC::resolveBase):
- 2:10 PM Changeset in webkit [51963] by
-
- 2 edits in trunk/LayoutTests
2009-12-10 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, fixing layout test mishap.
Add a newline to the layout test.
- http/tests/security/isolatedWorld/events-expected.txt: Added a newline at the end of the file.
- 2:06 PM Changeset in webkit [51962] by
-
- 5 edits3 adds in trunk
Crash in XMLTokenizer::popCurrentNode if window.close() is called during parsing
https://bugs.webkit.org/show_bug.cgi?id=31576
Reviewed by Alexey Proskuryakov.
Add a RefCounted wrapper object around xmlParserCtxtPtr so we can
maintain it's lifetime more effectively.
Test: fast/parser/xhtml-close-while-parsing.xhtml
- 1:59 PM BuildingQtOnOSX edited by
- Require qt4-mac-dev (v4.6) instead of qt4-mac (v4.5.3). See … (diff)
- 1:54 PM Changeset in webkit [51961] by
-
- 4 edits in trunk/WebCore
2009-12-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: debugger shortcuts don't work when
Search field or Console drawer has focus.
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.documentKeyUp): (WebInspector.searchKeyDown):
- 1:42 PM Changeset in webkit [51960] by
-
- 17 edits2 copies2 adds in trunk
WebCore:
2009-12-10 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Events created in isolated worlds may fire in main world.
https://bugs.webkit.org/show_bug.cgi?id=32386
Test: http/tests/security/isolatedWorld/events.html
- WebCore.gypi: Added WorldContextHandle.
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Added WorldContextHandle params.
- bindings/v8/SharedPersistent.h: Fixed a few style/include issues.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): Added WorldContextHandle params. (WebCore::V8AbstractEventListener::handleEvent): Adjusted context retrieval to use WorldContextHandle. (WebCore::V8AbstractEventListener::invokeEventHandler): Ditto.
- bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::worldContext): Added WorldContextHandle params.
- bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper): Ditto.
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): Ditto. (WebCore::V8LazyEventListener::prepareListenerObject): Adjusted context retrieval to use WorldContextHandle.
- bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create): Added WorldContextHandle params.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::context): Refactored to use mainWorldContext(); (WebCore::V8Proxy::mainWorldContext): Added. (WebCore::toV8Context): Changed to use WorldContextHandle.
- bindings/v8/V8Proxy.h: Added mainWorldContext decl.
- bindings/v8/V8Utilities.cpp: (WebCore::reportException): Added an extra check to avoid crashes during frame teardown.
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): Added WorldContextHandle params.
- bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create): Added WorldContextHandle params.
- bindings/v8/WorldContextHandle.cpp: Added.
- bindings/v8/WorldContextHandle.h: Added.
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener): Added WorldContextHandle params.
- bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create): Added WorldContextHandle params.
LayoutTests:
2009-12-10 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Events created in isolated worlds may fire in main world.
https://bugs.webkit.org/show_bug.cgi?id=32386
This test is relevant to both JSC and V8 isolated world implementation,
ensuring that events are fired in the right worlds.
- http/tests/security/isolatedWorld/events.html: Added.
- http/tests/security/isolatedWorld/events-expected.txt: Added.
- 1:17 PM Changeset in webkit [51959] by
-
- 6 edits in trunk/WebKitTools
2009-12-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool needs a command to list patches needing cq+
https://bugs.webkit.org/show_bug.cgi?id=32351
- Scripts/modules/bugzilla.py:
- Parse attacher_email from attachment xml.
- Scripts/modules/bugzilla_unittest.py:
- Test new attacher_email parsing.
- Scripts/modules/commands/queries.py:
- Add PatchesToCommitQueue
- Scripts/modules/commands/queries_unittest.py:
- Tests for PatchesToCommitQueue
- Scripts/modules/mock_bugzillatool.py:
- Add necessary mock methods for running PatchesToCommitQueue
- 1:04 PM Changeset in webkit [51958] by
-
- 4 edits in trunk/WebKit/mac
Mac build fix. Unreviewed.
Re-adds code that was mistakenly removed from my last patch.
- WebCoreSupport/WebPluginHalterClient.mm:
Add necessary #import.
- WebView/WebDelegateImplementationCaching.h:
Declare a new overload of CallUIDelegateReturningBoolean.
- WebView/WebDelegateImplementationCaching.mm:
(CallDelegateReturningBoolean):
Add a new overload with different arguments.
(CallUIDelegateReturningBoolean):
Ditto.
- 12:24 PM Changeset in webkit [51957] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
Add a missing null-check, that is causing some crash reports.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad):
- 11:57 AM Changeset in webkit [51956] by
-
- 2 edits in trunk/WebKitTools
2009-12-10 Adam Barth <abarth@webkit.org>
Unreviewed. Turns out every StepSequence command needs a --quiet
option.
- Scripts/modules/stepsequence.py:
- 11:51 AM Changeset in webkit [51955] by
-
- 4 edits in trunk/JavaScriptCore
Fix three more things found by compiling with clang++.
Reviewed by Geoffrey Garen.
- runtime/Structure.h:
(JSC::StructureTransitionTable::reifySingleTransition):
Add the 'std' qualifier to the call to make_pair.
- wtf/DateMath.cpp:
(WTF::initializeDates):
Incrementing a bool is deprecated according to the C++ specification.
- wtf/PtrAndFlags.h:
(WTF::PtrAndFlags::PtrAndFlags):
Name lookup should not be done in dependent bases, so explicitly qualify the call to set.
- 11:33 AM Changeset in webkit [51954] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to try and fix the Windows build.
- 11:23 AM Changeset in webkit [51953] by
-
- 16 edits in trunk
Pass more information about a plug-in to the PluginHalterDelegate
Reviewed by Adam Roben.
WebCore:
- loader/EmptyClients.h:
Remove this unused class.
- page/HaltablePlugin.h:
Add new functions to return the plug-in's name and whether it is
windowed.
- page/PluginHalter.cpp:
(WebCore::PluginHalter::timerFired):
Pass new arguments to the client.
- page/PluginHalterClient.h:
Add new parameters.
- plugins/PluginView.cpp:
(WebCore::PluginView::pluginName):
Return the name from the PluginPackage.
- plugins/PluginView.h:
(WebCore::PluginView::isWindowed):
WebKit/mac:
- Plugins/WebBaseNetscapePluginView.mm:
(WebHaltablePlugin::isWindowed):
Return false - the Mac doesn't really have windowed plug-ins.
(WebHaltablePlugin::pluginName):
Return the name from the plug-in package.
- WebCoreSupport/WebPluginHalterClient.h:
Update for new parameters.
- WebCoreSupport/WebPluginHalterClient.mm:
(WebPluginHalterClient::shouldHaltPlugin):
Ditto; pass them when making the delegate call.
- WebView/WebUIDelegatePrivate.h:
Update for new parameters.
WebKit/win:
- Interfaces/IWebPluginHalterDelegate.idl:
Add new parameters.
- WebCoreSupport/WebPluginHalterClient.cpp:
(WebPluginHalterClient::shouldHaltPlugin):
Update for new parameters. Pass them when making the delegate call.
- WebCoreSupport/WebPluginHalterClient.h:
Update for new parameters.
- 10:58 AM Changeset in webkit [51952] by
-
- 3 edits in trunk/WebCore
Fixes <http://webkit.org/b/31738>.
Web Inspector: Console Scope Bar should be on top of console when Console is a Panel.
Reviewed by Pavel Feldman.
When the console is set to be shown as a full panel, move the scope bar to the top
where it looks best. When it is only shown as a drawer, move it to the bottom, where
it originally was. This takes up less space as a drawer, and makes it more discoverable
and usable when it is the full panel.
- inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.show): Move filter bar to top.
(WebInspector.ConsolePanel.prototype.hide): Move filter bar back to bottom.
- inspector/front-end/inspector.css:
- 9:54 AM Changeset in webkit [51951] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-12-10 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Adam Barth.
Test case to verify that sandboxing 'about:blank' does not make
the containing frame sandboxed.
- fast/frames/resources/sandboxed-iframe-about-blank.html: Added.
- fast/frames/sandboxed-iframe-about-blank-expected.txt: Added.
- fast/frames/sandboxed-iframe-about-blank.html: Added.
- 9:13 AM Changeset in webkit [51950] by
-
- 2 edits in trunk/WebCore
Fix for alpha blending in SVG Filters on Chromium/skia.
https://bugs.webkit.org/show_bug.cgi?id=32378
Reviewed by Dirk Schulze.
Covered by LayoutTests/svg/filters/feGaussianBlur.svg and others.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::platformTransformColorSpace):
- 8:44 AM Changeset in webkit [51949] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-10 Ilya Tikhonovsky <loislo@google.com>
Reviewed by Pavel Feldman.
Chromium: Expose devtools agent API for inspector layout tests.
- public/WebDevToolsAgent.h: (WebKit::WebDevToolsAgent::setTimelineProfilingEnabled): (WebKit::WebDevToolsAgent::evaluateInWebInspector):
- 6:29 AM Changeset in webkit [51948] by
-
- 8 edits2 adds in trunk
Reviewed by Xan Lopez.
[GTK] Should provide an API to control the IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=32334
First step towards a full IconDatabase API. This provides
notification for pages with favicons, and lets clients handle
them.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::registerForIconNotification): (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
- tests/resources/blank.ico: Added.
- tests/testwebview.c: Added. (server_callback): (idle_quit_loop_cb): (icon_uri_changed_cb): (icon_loaded_cb): (test_webkit_web_view_icon_uri): (main):
- webkit/webkitprivate.cpp: (closeIconDatabaseOnExit): (webkit_init):
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_get_property): (webkit_web_view_finalize): (webkit_web_view_class_init): (webkit_web_view_get_icon_uri):
- webkit/webkitwebview.h:
- 5:55 AM Changeset in webkit [51947] by
-
- 4 edits in trunk
2009-12-10 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
DumpRenderTree has been patched so that the timeline-paint.html
unit test now runs under GTK+.
- platform/gtk/Skipped:
2009-12-10 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Implements displayWebView() to force an invalidation and repaint.
This fixes a problem running the timeline-paint.html unit test.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (displayWebView):
- 4:53 AM Changeset in webkit [51946] by
-
- 10 edits in trunk/WebCore
2009-12-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add context menu actions for DOM tree.
- English.lproj/localizedStrings.js:
- inspector/front-end/ContextMenu.js: (WebInspector.ContextMenu): (WebInspector.ContextMenu.prototype.show): (WebInspector.ContextMenu.prototype.appendItem): (WebInspector.ContextMenu.prototype.appendSeparator): (WebInspector.ContextMenu.prototype._itemSelected): (WebInspector.contextMenuItemSelected): (WebInspector.contextMenuCleared):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmouseout): (WebInspector.ElementsTreeOutline.prototype.populateContextMenu): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu): (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu): (WebInspector.ElementsTreeElement.prototype._startEditing): (WebInspector.ElementsTreeElement.prototype._addNewAttribute):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._toggleURLdecoding):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/inspector.js: (WebInspector.contextMenuEventFired):
- inspector/front-end/treeoutline.js: (TreeElement.treeElementDoubleClicked):
- 4:05 AM Changeset in webkit [51945] by
-
- 20 edits in trunk/WebCore
2009-12-09 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Oliver Hunt.
Filters contain some leaks in untested code
https://bugs.webkit.org/show_bug.cgi?id=32325
Fix obvious leak in SVGFE*Lighting classes. Implement the create() idiom for
all classes in svg/graphics, that were missing it. The lighting filters aren't
implemented so far, but the associated FilterEffect objects are build, which created
these leaks.
This removes the SVG related failures in the leaks bot.
- 4:04 AM Changeset in webkit [51944] by
-
- 3 edits in trunk/LayoutTests
2009-12-10 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skip two tests on gtk/qt that generate new results.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 2:13 AM QtBackLog edited by
- (diff)
- 2:13 AM QtBackLog edited by
- (diff)
- 1:21 AM Changeset in webkit [51943] by
-
- 3 edits2 adds in trunk
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
[Chromium] SporeViewer demo doesn't work in Chromium
https://bugs.webkit.org/show_bug.cgi?id=32364
Test: fast/canvas/webgl/bug-32364.html
- fast/canvas/webgl/bug-32364-expected.txt: Added.
- fast/canvas/webgl/bug-32364.html: Added.
2009-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
[Chromium] SporeViewer demo doesn't work in Chromium
https://bugs.webkit.org/show_bug.cgi?id=32364
Test: fast/canvas/webgl/bug-32364.html
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi):
- 12:33 AM Changeset in webkit [51942] by
-
- 2 edits in trunk/WebKitTools
2009-12-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Convert more commands to StepSequences
https://bugs.webkit.org/show_bug.cgi?id=32362
We should eventually convert all the commands, but I'm starting with
the easy ones.
- Scripts/modules/commands/download.py:
- 12:21 AM Changeset in webkit [51941] by
-
- 2 edits in trunk/WebKitTools
2009-12-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
[GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing
https://bugs.webkit.org/show_bug.cgi?id=31103
Give focus to the webviews when we create them, since some tests expect this.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (main):
- 12:18 AM Changeset in webkit [51940] by
-
- 2 edits in trunk/WebKitTools
2009-12-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool "builders are red" error should tell you which builders
https://bugs.webkit.org/show_bug.cgi?id=32211
- Scripts/modules/buildsteps.py:
Dec 9, 2009:
- 11:47 PM Changeset in webkit [51939] by
-
- 4 edits3 adds in trunk
2009-12-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Google reader gets stuck in the "Loading..." state and does not complete
https://bugs.webkit.org/show_bug.cgi?id=32256
<rdar://problem/7456388>
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_jless): Fix some backward branches.
2009-12-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Test for: Google reader gets stuck in the "Loading..." state and does not complete
https://bugs.webkit.org/show_bug.cgi?id=32256
- fast/js/codegen-jless-expected.txt: Added.
- fast/js/codegen-jless.html: Added.
- fast/js/script-tests/codegen-jless.js: Added.
- 11:29 PM Changeset in webkit [51938] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed. Skip a timeouter flakey test.
- platform/qt/Skipped: fast/frames/sandboxed-iframe-scripting.html added.
- 11:22 PM Changeset in webkit [51937] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-09 Yury Semikhatsky <yurys@chromium.org>
Unreviewed, build fix.
Change forward declaration of WebContextMenuData from class to
struct to match its definition. The bug was introduced by
http://trac.webkit.org/changeset/51874
- src/ContextMenuClientImpl.h:
- 10:07 PM Changeset in webkit [51936] by
-
- 5 edits8 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32346 SVG property
-webkit-shadow should apply shadow on the result after compositing
-and corresponding-
<rdar://problem/7389404>
Reviewed by Oliver Hunt.
Set a transparency layer when setting a shadow to apply the shadow
to the composite.
- rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
(WebCore::SVGRenderBase::finishRenderSVGContent):
LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=32346 SVG
property -webkit-shadow should apply shadow on the result after
compositing
-and corresponding-
<rdar://problem/7389404>
Reviewed by Oliver Hunt.
New tests:
- platform/mac/svg/css/composite-shadow-example-expected.checksum: Added.
- platform/mac/svg/css/composite-shadow-example-expected.png: Added.
- platform/mac/svg/css/composite-shadow-example-expected.txt: Added.
- platform/mac/svg/css/composite-shadow-with-opacity-expected.checksum: Added.
- platform/mac/svg/css/composite-shadow-with-opacity-expected.png: Added.
- platform/mac/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- svg/css/composite-shadow-example.html: Added.
- svg/css/composite-shadow-with-opacity.html: Added.
New and improved results:
- platform/mac/svg/css/group-with-shadow-expected.checksum:
- platform/mac/svg/css/group-with-shadow-expected.png:
- 7:32 PM Changeset in webkit [51935] by
-
- 5 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32332
WebSocket events should be dispatched synchronously
Updated websocket/tests/simple to test for the new behavior.
When Web Sockets API says that events should be queued for async dispatch, it means something
different. We should keep this in mind when dealing with other HTML5-related specs.
The model for HTML5 is that code running in response to network events (e.g. WebSocket or
XMLHttpRequest algorithms) runs in a separate thread of execution, and thus needs to post
async events as its only way to communicate with client code. As long as network events are
queued themselves (as they are in WebKit), there is no need to queue JS events for async
dispatch.
- websockets/WebSocket.cpp: (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didClose):
- 7:30 PM Changeset in webkit [51934] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=32355
Assertion failure when opening a WebSocket connection
I couldn't make a reliable test for this. Once the test from bug 32299 is landed, it
will provide partial coverage, as I was frequently seeing the assertion failure with it.
- platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): It's not an error if zero if returned from platformSend() - it just means that nothing could be pushed down to the network layer, and all data was queued for later.
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::readStreamCallback): This will no longer happen with SocketStream, but a client can potentially destroy the handle from any callback, so we need to check that this didn't happen. (WebCore::SocketStreamHandle::writeStreamCallback): Ditto.
- 5:44 PM Changeset in webkit [51933] by
-
- 6 edits in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=32228
Make destruction of ropes non-recursive to prevent stack exhaustion.
Also, pass a UString& into initializeFiber rather than a Ustring::Rep*,
since the Rep is not being ref counted this could result in usage of a
Rep with refcount zero (where the Rep comes from a temporary UString
returned from a function).
Reviewed by Oliver Hunt.
- runtime/JSString.cpp:
(JSC::JSString::Rope::destructNonRecursive):
(JSC::JSString::Rope::~Rope):
- runtime/JSString.h:
(JSC::JSString::Rope::initializeFiber):
- runtime/Operations.h:
(JSC::concatenateStrings):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=32228
Reenabling tests.
Reviewed by Oliver Hunt.
- platform/win/Skipped:
- 4:58 PM Changeset in webkit [51932] by
-
- 5 edits in trunk
2009-12-09 Marwan Al Jubeh <marwan.aljubeh@gmail.com>
Reviewed by Adam Roben.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
in Windows as part of running update_webkit.
- building/build.html:
- removed the reference to forgetting to set environment variables as a common source of errors on Windows. This is because this patch would make it unnecessary for the user to set these variables manually.
2009-12-09 Marwan Al Jubeh <marwan.aljubeh@gmail.com>
Reviewed by Adam Roben.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
in Windows as part of running update_webkit.
- Scripts/update-webkit:
- Run setupAppleWinEnv() on Apple's Windows port.
- Scripts/webkitdirs.pm:
- Added functions that return the source directory, libraries directory and default build directory on Windows.
- Added isWindowsNT() which tests if the current Windows version is from the Windows NT family.
- Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir and Cygwin to their desired values.
- 4:23 PM Changeset in webkit [51931] by
-
- 3 edits in trunk/WebCore
Roll out 51919 and 51920. They were incorrect and unnecessary right now.
- platform/mac/WebCoreObjCExtras.mm:
(WebCoreObjCScheduleDeallocateOnMainThread):
- platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
- 3:32 PM Changeset in webkit [51930] by
-
- 2 edits in trunk/WebCore
2009-12-09 Steve Block <steveblock@google.com>
Reviewed by Darin Fisher.
Adds wtf/StdLibExtras.h include for DEFINE_STATIC_LOCAL in V8 ScriptState.
https://bugs.webkit.org/show_bug.cgi?id=32330
Build fix only, no new tests.
- bindings/v8/ScriptState.cpp: Modified. Adds wtf/StdLibExtras.h include.
- 3:08 PM Changeset in webkit [51929] by
-
- 2 edits in trunk/WebKitSite
2009-12-09 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Darin Adler.
Added the "using std::foo" rule to the coding style guidelines.
Added to the coding style guidelines the "using std::foo" rule
checked by the check-webkit-style script. Also clarified the
"using" statement guidelines that apply to implementation files.
- coding/coding-style.html:
- 3:01 PM Changeset in webkit [51928] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-09 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Update to r51457. ASSERTs changed to COMPILE_ASSERTs.
The speedup is 25%.
- runtime/JSGlobalData.cpp: (JSC::VPtrSet::VPtrSet):
- 2:54 PM Changeset in webkit [51927] by
-
- 3 edits in trunk/WebCore
2009-12-09 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Adds ENABLE(INSPECTOR) guards around script binding methods that use types
defined only when INSPECTOR is enabled.
https://bugs.webkit.org/show_bug.cgi?id=32328
Build fix only, no new tests.
- bindings/js/ScriptValue.cpp: Modified. Added ENABLE(INSPECTOR) guard to ScriptValue::quarantineValue.
- bindings/v8/ScriptObject.cpp: Modified. Added ENABLE(INSPECTOR) guard to some overloads of ScriptGlobalObject::set.
- 2:47 PM Changeset in webkit [51926] by
-
- 10 edits2 adds in trunk
2009-12-09 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds Android Makefiles for building with V8.
https://bugs.webkit.org/show_bug.cgi?id=32278
- Android.mk: Modified. Includes Makefiles for V8.
2009-12-09 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Updates Android Makefiles with latest additions.
https://bugs.webkit.org/show_bug.cgi?id=32278
- Android.mk: Modified.
- Android.v8.wtf.mk: Modified.
2009-12-09 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds Android Makefiles for building with V8.
Also updates existing Android Makefiles with latest additions.
https://bugs.webkit.org/show_bug.cgi?id=32278
Build fix only, no new tests.
- Android.derived.jscbindings.mk: Modified.
- Android.derived.mk: Modified.
- Android.derived.v8bindings.mk: Added.
- Android.jscbindings.mk: Modified.
- Android.mk: Modified.
- Android.v8bindings.mk: Added.
- 2:35 PM Changeset in webkit [51925] by
-
- 2 edits in trunk/WebCore
Bug 32338 - [Chromium] Fix Chromium builder by including missing GeolocationServiceChromium
https://bugs.webkit.org/show_bug.cgi?id=32338
Patch by Jonathan Dixon <joth@chromium.org> on 2009-12-09
Reviewed by Dimitri Glazkov.
Fix build break: re-include file dropped out by merge in http://trac.webkit.org/changeset/51681/trunk/WebCore/WebCore.gypi
- WebCore.gypi: Add missing GeolocationServiceChromium.cpp
- 2:32 PM Changeset in webkit [51924] by
-
- 2 edits in trunk/WebCore
2009-12-09 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Brady Eidson.
Fixed a typo in http://trac.webkit.org/changeset/51644 that broke
the QWebPage autotest.
No new test required.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateToDifferentDocument):
- 2:25 PM Changeset in webkit [51923] by
-
- 2 edits in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
exception thrown when running apply-patches
https://bugs.webkit.org/show_bug.cgi?id=32344
The update step now takes a port option. Once we finish the Steps
refactoring, we won't have to worry about this kind of bug again.
- Scripts/modules/commands/download.py:
- 2:18 PM Changeset in webkit [51922] by
-
- 2 edits in trunk/WebCore
2009-12-09 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Exclude JSSVG*.cpp generated files from --minimal and --no-svg builds.
- WebCore.pro:
- 2:11 PM Changeset in webkit [51921] by
-
- 2 edits in trunk/WebCore
2009-12-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
Ogg mimetypes are incorrect
https://bugs.webkit.org/show_bug.cgi?id=27113
The ogg extension is handled by audio/ogg instead of
application/ogg. See
http://wiki.xiph.org/MIME_Types_and_File_Extensions
- platform/MIMETypeRegistry.cpp: (WebCore::TypeExtensionPair::):
- 1:57 PM Changeset in webkit [51920] by
-
- 2 edits in trunk/WebCore
Use the current run loop instead of the main runloop for the NetworkStateNotifier.
Reviewed by Anders Carlsson.
- platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
- 1:55 PM Changeset in webkit [51919] by
-
- 2 edits in trunk/WebCore
Use isMainThread() helper instead of pthread_main_np() != 0.
Reviewed by Anders Carlsson.
- platform/mac/WebCoreObjCExtras.mm:
(WebCoreObjCScheduleDeallocateOnMainThread):
- 1:37 PM Changeset in webkit [51918] by
-
- 2 edits in trunk/LayoutTests
Skip a failing test that needs DRT support to override standard
preferences.
- platform/gtk/Skipped:
- 1:36 PM Changeset in webkit [51917] by
-
- 5 edits in trunk/WebKit/chromium
2009-12-09 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=32324
[Chromium] Suppress WebFrameClient callbacks from a detached frame.
This change means that we no longer need the ClientHandle class.
FrameLoaderClient::detachedFromParent3() is called on each frame
in the frame tree from within frameDetached().
Test: http/tests/loading/gmail-assert-on-load.html
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::create): (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::createChildFrame):
- src/WebFrameImpl.h: (WebKit::WebFrameImpl::client): (WebKit::WebFrameImpl::dropClient):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::close):
- 1:31 PM Changeset in webkit [51916] by
-
- 11 edits in trunk/WebCore
Add some #ifdefs to allow us to experiment with a single NSView mac WebKit.
Reviewed by Anders Carlsson.
- page/Chrome.h:
- page/EventHandler.h:
- page/mac/ChromeMac.mm:
- page/mac/DragControllerMac.mm:
(WebCore::DragController::dragOperation):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::eventLoopHandleMouseDragged):
(WebCore::EventHandler::eventActivatedView):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::createDraggingClipboard):
(WebCore::isKeyboardOptionTab):
(WebCore::EventHandler::invertSenseOfTabsToLinks):
(WebCore::EventHandler::tabsToAllControls):
(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
(WebCore::EventHandler::accessKeyModifiers):
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/Widget.cpp:
- platform/Widget.h:
- platform/mac/ScrollViewMac.mm:
- platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::show):
(WebCore::Widget::hide):
(WebCore::Widget::setCursor):
(WebCore::Widget::paint):
(WebCore::Widget::setFocus):
(WebCore::Widget::setIsSelected):
(WebCore::Widget::frameRect):
(WebCore::Widget::setFrameRect):
- 12:36 PM Changeset in webkit [51915] by
-
- 4 edits in trunk/WebCore
2009-12-09 Michael Nordman <Michael Nordman>
Reviewed by Dimitri Glazkov.
Chromium build fix.
No new tests.
- bindings/v8/DOMData.cpp
- bindings/v8/V8DOMWrapper.cpp
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
- 12:31 PM Changeset in webkit [51914] by
-
- 2 edits in trunk/JavaScriptCore
Fix a bug found while trying to compile JavaScriptCore with clang++.
Reviewed by Gavin Barraclough.
- yarr/RegexPattern.h:
(JSC::Yarr::PatternTerm::PatternTerm): Don't self assign here. Use false instead.
- 12:26 PM Changeset in webkit [51913] by
-
- 2 edits in trunk/WebKit/win
Revert incorrect commit-box update r51911.
It mistakenly set the selectAll implementation in the
deslectAll method.
- WebFrame.cpp:
(WebFrame::deselectAll):
- 12:14 PM Changeset in webkit [51912] by
-
- 2 edits in trunk/WebCore
2009-12-09 Søren Gjesse <sgjesse@chromium.org>
Reviewed by Pavel Feldman.
[V8] Isolated world reuse failure
https://bugs.webkit.org/show_bug.cgi?id=32306
Fixed bug introduced in r51407: (http://trac.webkit.org/changeset/51407) which caused layout test
LayoutTests/http/tests/security/isolatedWorld/world-reuse.html to fail.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::contextDebugId):
- 12:06 PM Changeset in webkit [51911] by
-
- 2 edits in trunk/WebKit/win
2009-12-09 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Darin Adler.
Provide an implementation for 'selectAll'
https://bugs.webkit.org/show_bug.cgi?id=32296
- WebFrame.cpp: (WebFrame::selectAll): Implement "SelectAll" command.
- 11:59 AM Changeset in webkit [51910] by
-
- 2 edits in trunk/WebCore
2009-12-09 Patrick Scott <phanna@email.unc.edu>
Fix the build with ENABLE_ORIENTATION_EVENTS
https://bugs.webkit.org/show_bug.cgi?id=32321
- page/Frame.cpp: (WebCore::Frame::sendOrientationChangeEvent):
- 11:52 AM Changeset in webkit [51909] by
-
- 2 edits in trunk/WebCore
2009-12-09 Avi Drissman <avi@chromium.org>
Reviewed by Darin Fisher.
Chromium tickmarks in scrollbar now UX approved.
https://bugs.webkit.org/show_bug.cgi?id=32069
- platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint):
- 11:00 AM Changeset in webkit [51908] by
-
- 2 edits in trunk/JavaScriptCore
Attempt to fix the Windows build.
Reviewed by Sam Weinig.
- wtf/FastMalloc.h:
- 10:53 AM Changeset in webkit [51907] by
-
- 2 edits in trunk/WebKit/win
Provide an implementation for 'selectAll'
https://bugs.webkit.org/show_bug.cgi?id=32296
Reviewed by Darin Adler.
- WebFrame.cpp:
(WebFrame::selectAll): Implement "SelectAll" command.
- 10:44 AM Changeset in webkit [51906] by
-
- 9 edits in trunk
Delay load DLLs for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=31856
Add logic to turn off accelerated compositing if d3d9 or QuartzCore
DLLs are not present.
- 10:40 AM Changeset in webkit [51905] by
-
- 4 edits in trunk/JavaScriptCore
Fix some things found while trying to compile JavaScriptCore with clang++.
Reviewed by Sam Weinig.
- wtf/FastMalloc.h:
Add correct exception specifications for the allocation/deallocation operators.
- wtf/Vector.h:
- wtf/VectorTraits.h:
Fix a bunch of struct/class mismatches.
- 10:22 AM Changeset in webkit [51904] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-08 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Include clickCount when doing MouseEvent -> WebMouseEvent conversion
in Chromium API.
- src/WebInputEventConversion.cpp: (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
- 10:11 AM Changeset in webkit [51903] by
-
- 4 edits in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Unreviewed. Fix ScriptError includes. I don't understand why these
didn't throw during unit testing...
- Scripts/modules/commands/download.py:
- Scripts/modules/logging_unittest.py:
- Scripts/modules/workqueue.py:
- 9:43 AM Changeset in webkit [51902] by
-
- 13 edits2 moves in trunk/WebCore
2009-12-09 Nate Chapin <Nate Chapin>
Reviewed by Darin Adler.
Rename dom/ClassNames to SpaceSplitString and update build files.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules):
- dom/ClassNames.cpp: Removed.
- dom/ClassNames.h: Removed.
- dom/ClassNodeList.h:
- dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::classNames):
- dom/SpaceSplitString.cpp: Copied from WebCore/dom/ClassNames.cpp. (WebCore::SpaceSplitStringData::createVector): (WebCore::SpaceSplitStringData::containsAll):
- dom/SpaceSplitString.h: Copied from WebCore/dom/ClassNames.h. (WebCore::SpaceSplitStringData::SpaceSplitStringData): (WebCore::SpaceSplitString::SpaceSplitString): (WebCore::SpaceSplitString::set): (WebCore::SpaceSplitString::containsAll):
- dom/StyledElement.h: (WebCore::StyledElement::classNames):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setRel):
- 9:28 AM Changeset in webkit [51901] by
-
- 8 edits in trunk/WebCore
Enable SVG filters in Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=32323
Reviewed by Darin Fisher.
Covered by SVG filter layout tests.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 8:59 AM QtWebKit/CodeCamp200912 edited by
- mention the performance talks (diff)
- 7:26 AM Changeset in webkit [51900] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-09 Yury Semikhatsky <yurys@chromium.org>
Unreviewed, build fix.
Add return statement to default implementation of hostIdentifier method
introduced in http://trac.webkit.org/changeset/51897
- public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::hostIdentifier):
- 7:05 AM Changeset in webkit [51899] by
-
- 3 edits in trunk/WebKit/chromium
2009-12-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Add declaration of static methods that allow to dispatch
DevTools messages on the IO thread and accept WebDevToolsMessageData
argument.
- public/WebDevToolsAgent.h:
- public/WebDevToolsAgentClient.h:
- 5:27 AM Changeset in webkit [51898] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip a failing test introduced in r51877.
- platform/qt/Skipped: fast/loader/input-element-page-cache-crash.html added.
- 5:19 AM Changeset in webkit [51897] by
-
- 6 edits1 copy in trunk/WebKit/chromium
2009-12-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce a class for devtools message data
- WebKit.gyp:
- public/WebDevToolsAgent.h:
- public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::sendMessageToFrontend): (WebKit::WebDevToolsAgentClient::forceRepaint): (WebKit::WebDevToolsAgentClient::hostIdentifier): (WebKit::WebDevToolsAgentClient::runtimeFeatureStateChanged):
- public/WebDevToolsFrontend.h:
- public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendMessageToAgent):
- public/WebDevToolsMessageData.h: Added.
- 5:04 AM Changeset in webkit [51896] by
-
- 2 edits in trunk/LayoutTests
2009-12-09 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix typo in the Skipped list s/.htm/.html/ in the last test I added.
- platform/mac-snowleopard/Skipped:
- 3:34 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 2:09 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 1:54 AM WebKit Team edited by
- (diff)
- 1:39 AM Changeset in webkit [51895] by
-
- 4 edits1 delete in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Remove unused PatchCollection class
https://bugs.webkit.org/show_bug.cgi?id=32312
It's dead code.
- Scripts/modules/patchcollection.py:
- Scripts/modules/patchcollection_unittest.py: Removed.
- 1:29 AM Changeset in webkit [51894] by
-
- 2 edits in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. CheckStyle needs a --no-upate option.
- Scripts/modules/commands/download.py:
- 1:24 AM Changeset in webkit [51893] by
-
- 4 edits1 add in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Convert Build to use Sequence
https://bugs.webkit.org/show_bug.cgi?id=32310
So much prettier.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/stepsequence.py: Added.
- 1:17 AM Changeset in webkit [51892] by
-
- 3 edits in trunk/WebCore
Build fix
- 12:26 AM Changeset in webkit [51891] by
-
- 1 edit1 add in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Add missing file.
- Scripts/modules/executive.py: Added.
- 12:24 AM Changeset in webkit [51890] by
-
- 2 edits in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix.
- Scripts/modules/landingsequence.py:
- 12:20 AM Changeset in webkit [51889] by
-
- 12 edits1 delete in trunk/WebKitTools
2009-12-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Implement abstract Steps
https://bugs.webkit.org/show_bug.cgi?id=32212
This is a fairly disruptive change that refactors how we build
commands. Instead of using a landing sequence, we can now assemble a
sequence of steps directly. We still use the landing sequence in the
interim, but this will be removed soon.
- Scripts/bugzilla-tool:
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/commands/queues_unittest.py:
- Scripts/modules/landingsequence.py:
- Scripts/modules/mock_bugzillatool.py:
- Scripts/modules/processutils.py: Removed.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py:
- Scripts/modules/webkitport.py:
