⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 14, 2009:

11:31 PM Changeset in webkit [52140] by Chris Fleizach
  • 12 edits
    2 adds in trunk

WAI-ARIA: implement treegrid
​https://bugs.webkit.org/show_bug.cgi?id=31299

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/aria-treegrid.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityARIAGrid.h:

(WebCore::AccessibilityARIAGrid::supportsSelectedRows):

  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):

  • accessibility/AccessibilityARIAGridRow.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isARIATreeGridRow):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityTable.h:

(WebCore::AccessibilityTable::supportsSelectedRows):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

LayoutTests:

  • platform/mac/accessibility/aria-treegrid-expected.txt: Added.
  • platform/mac/accessibility/aria-treegrid.html: Added.
10:44 PM Changeset in webkit [52139] by mjs@apple.com
  • 6 edits in trunk/SunSpider

2009-12-14 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

Some Browser-hosted SunSpider files are not valid HTML5
​https://bugs.webkit.org/show_bug.cgi?id=32536


Made various fixes to validate as HTML5 with no warnings (mainly removing bogus
close tags and adding a meta charset declaration).

  • hosted/sunspider.html:
  • hosted/versions.html:
  • resources/TEMPLATE.html:
  • resources/driver-TEMPLATE.html:
  • resources/results-TEMPLATE.html:
10:25 PM Changeset in webkit [52138] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-14 Adam Barth <​abarth@webkit.org>

Unreviewed. Fix failing unittest.

  • Scripts/modules/bugzilla_unittest.py:
10:24 PM Changeset in webkit [52137] by mjs@apple.com
  • 4 edits in trunk/SunSpider

2009-12-14 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric Seidel.

Make sunspider-0.9.1 the default content set (both command-line and hosted)
​https://bugs.webkit.org/show_bug.cgi?id=32537

  • hosted/sunspider.html: Change default suite link.
  • sunspider: Change default suite.
  • sunspider-compare-results: Likewise.
10:16 PM Changeset in webkit [52136] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Kill _create_step_sequence
​https://bugs.webkit.org/show_bug.cgi?id=32539

It's cleaner to represent not having these sequences as an empty
sequence instead of None.

  • Scripts/modules/commands/download.py:
  • Scripts/modules/stepsequence.py:
10:00 PM Changeset in webkit [52135] by eric@webkit.org
  • 3 edits
    2 adds in trunk/WebKitTools

2009-12-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move Credential handling out into a separate module
​https://bugs.webkit.org/show_bug.cgi?id=32531

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/credentials.py: Added.
  • Scripts/modules/credentials_unittest.py: Added.
  • Scripts/run-webkit-unittests:
9:53 PM Changeset in webkit [52134] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-14 Adam Barth <​abarth@webkit.org>

Unreviewed. Address reviewer comments from an earlier patch. I didn't
do this earlier because I was worried about conflicts in dependent
patches.

  • Scripts/modules/commands/download.py:
9:38 PM Changeset in webkit [52133] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Make download commands declarative
​https://bugs.webkit.org/show_bug.cgi?id=32469

This patch "properly" factors most of the download commands. These
commands are now largely declarative, which is the final step of this
grand refactoring.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
9:38 PM Changeset in webkit [52132] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Add AbstractPatchSequencingCommand to remove redundant code
​https://bugs.webkit.org/show_bug.cgi?id=32468

Redundant code is bad. This patch moves us towards more declarative
commands.

  • Scripts/modules/commands/download.py:
9:32 PM Changeset in webkit [52131] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2009-12-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Kill WebKitApplyingScripts
​https://bugs.webkit.org/show_bug.cgi?id=32467

Ah! I've been wanting to do this for a long time. This patch brings
the applying commands into the patch processing fold.

  • Scripts/bugzilla-tool:
  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/download_unittest.py:
  • Scripts/modules/mock_bugzillatool.py:
9:31 PM Changeset in webkit [52130] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2009-12-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Convert rollout to StepSequence
​https://bugs.webkit.org/show_bug.cgi?id=32406

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/download_unittest.py:
  • Scripts/modules/mock_bugzillatool.py:
9:21 PM Changeset in webkit [52129] by abarth@webkit.org
  • 5 edits
    1 delete in trunk/WebKitTools

2009-12-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Kill LandingSequence
​https://bugs.webkit.org/show_bug.cgi?id=32464

Removes LandingSequence in favor of StepSequence. This required
changing the Step API slightly to carry a general notion of state
instead of carrying patches specifically.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/landingsequence.py: Removed.
  • Scripts/modules/stepsequence.py:
7:27 PM Changeset in webkit [52128] by mjs@apple.com
  • 4 edits
    1 delete in trunk/SunSpider

2009-12-14 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

in-browser SunSpider suffers excessive penalty under power management
​https://bugs.webkit.org/show_bug.cgi?id=32505


I have made a few changes to address this:


1) Change how browser-hosted SunSpider loads tests - preload the content and write it in with
document.write to reduce triggering of progress UI.
2) Reduce time between tests to 10ms from 500ms, so that power management doesn't keep the CPU
stepped all the way down the whole time.
3) Run the test cycle an extra time for warmup before the runs that count.

  • hosted/sunspider-record-result.js: Removed.
  • make-hosted:
  • resources/TEMPLATE.html:
  • resources/driver-TEMPLATE.html:
7:05 PM Changeset in webkit [52127] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/7460655> REGRESSION (r47255): Content shifted down at software.opensuse.org
​https://bugs.webkit.org/show_bug.cgi?id=32382

Reviewed by Darin Adler.

WebCore:

Test: fast/block/float/in-margin.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::getClearDelta): Floats that do not intrude into the line (because
they are in the margin) do not need to be cleared.

LayoutTests:

  • fast/block/float/in-margin.html: Added.
  • platform/mac/fast/block/float/in-margin-expected.checksum: Added.
  • platform/mac/fast/block/float/in-margin-expected.png: Added.
  • platform/mac/fast/block/float/in-margin-expected.txt: Added.
5:14 PM Changeset in webkit [52126] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Pressing backspace inside a table cell erases all empty rows below it.
<rdar://problem/5565461>
​https://bugs.webkit.org/show_bug.cgi?id=32526

Reviewed by John Sullivan.

WebCore:

No deletion is performed when the caret selection is on an empty table cell.

Test: editing/deleting/delete-empty-table.html

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteKeyPressed): Added check for empty table cells in
case of caret selection.

LayoutTests:

  • editing/deleting/delete-empty-table-expected.txt: Added.
  • editing/deleting/delete-empty-table.html: Added.
4:19 PM Changeset in webkit [52125] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Brady Eidson.

Add two http iFrame dynamic form tests to the Windows Skipped
list.

  • platform/win/Skipped:
2:45 PM Changeset in webkit [52124] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-12-14 Evan Stade <​estade@chromium.org>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=32347
Chromium: Context menu launched by menu key has funky behavior

Make the context menu's position depend on the selection only when an
editable field has focus. Also, don't send multiple context menu events
for a single keypress.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::sendContextMenuEvent):
2:38 PM Changeset in webkit [52123] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-12-14 Andrei Popescu <​andreip@google.com>

Reviewed by Darin Adler.

[Android] Android needs ResourceHandle implementation
​https://bugs.webkit.org/show_bug.cgi?id=32515

Adds implementation of ResourceHandle on Android.

No new tests needed, this is platform-specific code, so existing
tests are sufficient.

  • platform/network/android/ResourceHandleAndroid.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::willLoadFromCache): (WebCore::ResourceHandle::loadsBlocked): (WebCore::SyncLoader::SyncLoader): (WebCore::SyncLoader::~SyncLoader): (WebCore::SyncLoader::didReceiveResponse): (WebCore::SyncLoader::didReceiveData): (WebCore::SyncLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously):
  • platform/network/android/ResourceLoaderAndroid.h: Added. (WebCore::ResourceLoaderAndroid::~ResourceLoaderAndroid): (WebCore::ResourceLoaderAndroid::ResourceLoaderAndroid):
2:30 PM Changeset in webkit [52122] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-14 Marco Martin <​notmart@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

In the Scrollbar painting of the Qt theme integration,
intersects any previous clip rects with the one needed to paint the scrollbar.
This fixes the painting in QGraphicsview, when the parent of the widget that
paints the QWebPage has the QGraphicsItem::ItemClipsChildrenToShape set and
a piece of the scrollbar should be cipped away
​https://bugs.webkit.org/show_bug.cgi?id=30366

No new tests.

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint):
2:23 PM Changeset in webkit [52121] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Provide working printing support for WinCairo port.

Reviewed by Adam Roben.

  • WebFrame.cpp:

(WebFrame::spoolPage): Conditionalize initialization of

PlatformGraphicsContext handling for CG vs. Cairo.

(scaleFactor): Add helper function.
(hdcFromContext): Add helper function.
(WebFrame::drawHeader): Correct Cairo variation.
(WebFrame::drawFooter): Correct Cairo variation.
(WebFrame::spoolPages): Correct Cairo variation.

2:17 PM Changeset in webkit [52120] by Dimitri Glazkov
  • 4 edits in trunk/WebCore

2009-12-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

[V8] Generate bindings for trivial indexers.
​https://bugs.webkit.org/show_bug.cgi?id=32455

Covered by existing tests.

  • bindings/scripts/CodeGeneratorV8.pm:

Added detecting indexers and generating code for them.

  • bindings/v8/V8Collection.h: Removed code that's now generated.
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Ditto.
2:16 PM Changeset in webkit [52119] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-12-14 Kinuko Yasuda <​kinuko@chromium.com>

Reviewed by Darin Fisher.

Make changing-frame-hierarchy-in-onload.html less flaky and
platform-independent.
​https://bugs.webkit.org/show_bug.cgi?id=32319

  • http/tests/navigation/changing-frame-hierarchy-in-onload.html:
2:09 PM Changeset in webkit [52118] by eric@webkit.org
  • 6 edits in trunk

2009-12-14 Robert Hogan <​robert@roberthogan.net>

Reviewed by Eric Seidel.

[Qt] Fix ​https://bugs.webkit.org/show_bug.cgi?id=32437

Amend the behaviour of DRT::notifyDone to dump only when
the page has finished loading.

This fix permits removal of the following tests from the Qt skipped list:
fast/forms/textarea-linewrap-dynamic.html
fast/forms/textarea-setvalue-submit.html
fast/forms/textarea-hard-linewrap-empty.html
fast/forms/submit-to-url-fragment.html
http/tests/misc/percent-sign-in-form-field-name.html
http/tests/security/escape-form-data-field-names.html

However it also requires the following two to be added to the skipped list:

http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
svg/custom/use-instanceRoot-as-event-target.xhtml

It appears the behaviour of notifyDone was masking problems with these two
tests.

  • platform/qt/Skipped:

2009-12-14 Robert Hogan <​robert@roberthogan.net>

Reviewed by Eric Seidel.

[Qt] Fix ​https://bugs.webkit.org/show_bug.cgi?id=32437

Amend the behaviour of DRT::notifyDone to dump only when
the page has finished loading.

This fix permits removal of the following tests from the Qt skipped list:
fast/forms/textarea-linewrap-dynamic.html
fast/forms/textarea-setvalue-submit.html
fast/forms/textarea-hard-linewrap-empty.html
fast/forms/submit-to-url-fragment.html
http/tests/misc/percent-sign-in-form-field-name.html
http/tests/security/escape-form-data-field-names.html

However it also requires the following two to be added to the skipped list:

http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
svg/custom/use-instanceRoot-as-event-target.xhtml

It appears the behaviour of notifyDone was masking problems with these two
tests.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::notifyDone): (LayoutTestController::provisionalLoad):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::resetLoadFinished):
1:57 PM Changeset in webkit [52117] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2009-12-14 Robert Hogan <​robert@roberthogan.net>

Reviewed by Eric Seidel.

Bug 32519 - mouseEvent fires mutiple times in
LayoutTests/svg/custom/use-instanceRoot-as-event-target.xhtml

Add test to Qt skipped list (was passing due to bug in DRT, see
​https://bugs.webkit.org/show_bug.cgi?id=32437). Updated detail on bug
in gtk and win skipped lists.

​https://bugs.webkit.org/show_bug.cgi?id=32519

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
1:47 PM Changeset in webkit [52116] by ap@apple.com
  • 7 edits
    2 adds in trunk

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=31660
REGRESSION (r49394): Image load event fires before the document fragment is attached.

Test: fast/images/image-load-event-in-fragment.html

We cannot fire load events immediately after parsing a fragment - an element inserted via
innerHTML or equivalent should be reachable via getElementById() by the time its load event
fires.

  • dom/Document.cpp: (WebCore::Document::implicitClose): Call dispatchPendingBeforeLoadEvents() and dispatchPendingLoadEvents() individually. I'm not sure why these calls are here, just preserving existing behavior.
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write): Load events for elements that have just been parsed cannot be dispatched yet, we should give the elements a chance to be inserted into a document first. There is no compatibility baggage for beforeload, so it seems OK to dispatch it right away.
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::dispatchPendingBeforeLoadEvents): (WebCore::ImageLoader::dispatchPendingLoadEvents):
  • loader/ImageLoader.h: Separated dispatchPendingEvents() into individual functions for each event kind.
1:27 PM Changeset in webkit [52115] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-12-14 Jakob Petsovits <​jpetsovits@rim.com>

Reviewed by Simon Fraser.

Add FloatQuad::isRectilinear() to check whether it can be represented as FloatRect.
​https://bugs.webkit.org/show_bug.cgi?id=30442

This enables optimizations for distinguishing between
arbitrary FloatQuads and rectilinear ones.

  • platform/graphics/FloatQuad.cpp: (WebCore::FloatQuad::isRectilinear):
  • platform/graphics/FloatQuad.h:
1:08 PM Changeset in webkit [52114] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Add two XSS tests that intermittently time out to the Windows
Skipped list.

  • platform/win/Skipped:
12:57 PM Changeset in webkit [52113] by eric@webkit.org
  • 13 edits in trunk

2009-12-14 Simon Hausmann <Simon Hausmann>

Reviewed by Holger Freyther.

[Qt] Extend basic touch event test with a simple keyboard modifier test.

​https://bugs.webkit.org/show_bug.cgi?id=32482

  • fast/events/basic-touch-events-expected.txt:
  • fast/events/script-tests/basic-touch-events.js: (singleTouchSequence):

2009-12-14 Simon Hausmann <Simon Hausmann>

Reviewed by Holger Freyther.

[Qt] Add support for keyboard modifiers to TouchEvent

​https://bugs.webkit.org/show_bug.cgi?id=32482

Similar to other ui events with keyboard state, get the alt, shift,
meta and ctrl modifiers straight from the platform event.

  • dom/TouchEvent.cpp: (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::initTouchEvent):
  • dom/TouchEvent.h: (WebCore::TouchEvent::create):
  • dom/TouchEvent.idl:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
  • platform/PlatformTouchEvent.h: (WebCore::PlatformTouchEvent::PlatformTouchEvent): (WebCore::PlatformTouchEvent::shiftKey): (WebCore::PlatformTouchEvent::ctrlKey): (WebCore::PlatformTouchEvent::altKey): (WebCore::PlatformTouchEvent::metaKey):
  • platform/qt/PlatformTouchEventQt.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):

2009-12-14 Simon Hausmann <Simon Hausmann>

Reviewed by Holger Freyther.

[Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events

​https://bugs.webkit.org/show_bug.cgi?id=32482

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::setTouchModifier): (EventSender::clearTouchPoints): (EventSender::sendTouchEvent):
  • DumpRenderTree/qt/EventSenderQt.h:
12:49 PM Changeset in webkit [52112] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-14 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] crash when clicking "Sign out" in GMail
​https://bugs.webkit.org/show_bug.cgi?id=32300

When the ResourceLoader cancels the handle we have to make sure not to access
the resource handle afterwards again.
This complete r29515

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
12:42 PM Changeset in webkit [52111] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-14 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve the autotests of QtWebkit
​https://bugs.webkit.org/show_bug.cgi?id=32216

Refactor tst_qwebelement to remove the qWait()

  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::style):
12:35 PM Changeset in webkit [52110] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

Fix the QWebPage inputMethods() autotest after r51758
to compare the Qt::ImFont property's family against an explicitly
previously configured family.

​https://bugs.webkit.org/show_bug.cgi?id=32491

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
12:28 PM Changeset in webkit [52109] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-12-14 Robert Hogan <​robert@roberthogan.net>

Reviewed by Eric Seidel.

access-control-basic-denied-preflight-cache.html fails manual testing.

LayoutTests/http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
fails manual testing. It passes the automatic layout tests in Qt due to a bug with
notifyDone (see ​https://bugs.webkit.org/show_bug.cgi?id=32437).

Performing the test manually in QtLauncher shows that an exception is received.

Add access-control-basic-denied-preflight-cache.html to the Qt skipped list.

​https://bugs.webkit.org/show_bug.cgi?id=32521

  • platform/qt/Skipped:
12:21 PM Changeset in webkit [52108] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-12-14 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Implement InjectedScript.evaluateOnSelf() that evaluates functions in the InjectedScript context.
​https://bugs.webkit.org/show_bug.cgi?id=32517

  • inspector/front-end/InjectedScript.js: (InjectedScript.evaluateOnSelf):
  • inspector/front-end/InjectedScriptAccess.js:
12:13 PM Changeset in webkit [52107] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-12-14 Nayan Kumar K <​nayankk@gmail.com>

Reviewed by Darin Adler.

Fix for compilation errors in WML enabled builds.

​https://bugs.webkit.org/show_bug.cgi?id=32481

  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::setValueForUser):
  • wml/WMLInputElement.h:
12:06 PM Changeset in webkit [52106] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2009-12-14 Eric Carlson <​eric.carlson@apple.com>

Not reviewed, build fix.

Add missing newline at end of test result.

  • platform/mac-tiger/media/video-no-audio-expected.txt:
12:01 PM Changeset in webkit [52105] by benm@google.com
  • 1 edit
    3 adds in trunk/WebCore

[Android] Android needs ResourceError, ResourceResponse and
ResourceRequest implementation.
​https://bugs.webkit.org/show_bug.cgi?id=32522

Patch by Andrei Popescu <​andreip@google.com> on 2009-12-14
Reviewed by Darin Adler.

Add implementation of ResourceError, ResourceResponse and ResourceRequest.
No new tests needed, the existing tests should be sufficient.

  • platform/network/android/ResourceError.h: Added.

(WebCore::ResourceError::ResourceError):

  • platform/network/android/ResourceRequest.h: Added.

(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::setUserGesture):
(WebCore::ResourceRequest::getUserGesture):

  • platform/network/android/ResourceResponse.h: Added.

(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::doUpdateResourceResponse):

11:38 AM Changeset in webkit [52104] by weinig@apple.com
  • 3 edits in trunk/WebCore

Fix the build.

  • page/Geolocation.cpp:
  • page/Geolocation.h:
11:26 AM Changeset in webkit [52103] by weinig@apple.com
  • 24 edits
    5 adds in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=32499
Add client based Geolocation provider

Reviewed by Dan Bernstein.

Add first cut of a client based Geolocation provider. This is guarded by
ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a
GeolocationControllerClient interface that no-one currently implements,
but will in a subsequent patch.

WebCore:

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • page/Geolocation.cpp:

(WebCore::createGeopositionFromGeolocationPosition):
(WebCore::createPositionErrorFromGeolocationError):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::fatalErrorOccurred):
(WebCore::Geolocation::requestTimedOut):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::handleError):
(WebCore::Geolocation::positionChanged):
(WebCore::Geolocation::makeSuccessCallbacks):
(WebCore::Geolocation::errorOccurred):
(WebCore::Geolocation::geolocationServicePositionChanged):
(WebCore::Geolocation::geolocationServiceErrorOccurred):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):

  • page/Geolocation.h:
  • page/GeolocationController.cpp: Added.

(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::~GeolocationController):
(WebCore::GeolocationController::addObserver):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::errorOccurred):
(WebCore::GeolocationController::lastPosition):

  • page/GeolocationController.h: Added.
  • page/GeolocationControllerClient.h: Added.

(WebCore::GeolocationControllerClient::~GeolocationControllerClient):

  • page/GeolocationError.h: Added.

(WebCore::GeolocationError::):
(WebCore::GeolocationError::create):
(WebCore::GeolocationError::code):
(WebCore::GeolocationError::message):

  • page/GeolocationPosition.h: Added.

(WebCore::GeolocationPosition::create):
(WebCore::GeolocationPosition::timestamp):
(WebCore::GeolocationPosition::latitude):
(WebCore::GeolocationPosition::longitude):
(WebCore::GeolocationPosition::accuracy):
(WebCore::GeolocationPosition::altitude):
(WebCore::GeolocationPosition::altitudeAccuracy):
(WebCore::GeolocationPosition::heading):
(WebCore::GeolocationPosition::speed):
(WebCore::GeolocationPosition::canProvideAltitude):
(WebCore::GeolocationPosition::canProvideAltitudeAccuracy):
(WebCore::GeolocationPosition::canProvideHeading):
(WebCore::GeolocationPosition::canProvideSpeed):
(WebCore::GeolocationPosition::GeolocationPosition):

  • page/Geoposition.h:

(WebCore::Geoposition::create):

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(WebCore::Page::geolocationController):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

WebKit/win:

  • WebView.cpp:

(WebView::initWithFrame):

11:10 AM QtWebKit/CodeCamp200912 edited by carol.szabo@nokia.com
(diff)
10:45 AM Changeset in webkit [52102] by agl@chromium.org
  • 3 edits
    3 adds in trunk

2009-12-14 Adam Langley <​agl@google.com>

Reviewed by Darin Adler.

Test that an image's size is valid before reading it.

Previously, an image that failed to load (m_failed == true) would
trigger an assertion failure when WebKit tried to get its size.

​https://bugs.webkit.org/show_bug.cgi?id=32176
​http://code.google.com/p/chromium/issues/detail?id=28566

Test: fast/images/size-failure.html

  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::createFrameAtIndex):
10:40 AM Changeset in webkit [52101] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=32524
REGRESSION(52084): fast/dom/prototypes.html failing two CSS tests

Reviewed by Simon Fraser.

  • wtf/StdLibExtras.h:

(WTF::bitCount): The original patch put the parentheses in the wrong
place, completely changing the calculation and making it almost always
wrong. Moved the parentheses around the '+' operation, like the original
compiler warning suggested.

10:04 AM Changeset in webkit [52100] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7458272> REGRESSION (r50470) Reproducible ASSERT in
RenderWidget::setWidgetGeometry()

Reviewed by Darin Adler.

WebCore:

Test: fast/forms/defer-updateFromElement.html

  • html/HTMLFormControlElement.cpp:

(WebCore::updateFromElementCallback): Added this post-attach callback
that invokes updateFromElement().
(WebCore::HTMLFormControlElement::recalcStyle): Instead of calling
updateFromElement(), enqueue a post-attach (in this case, post-style
recalc) callback to do it. updateFromElement() can cause the selection
to change, and in turn trigger synchronous layout, so it must not be
called during style recalc.

LayoutTests:

  • fast/forms/defer-updateFromElement-expected.txt: Added.
  • fast/forms/defer-updateFromElement.html: Added.
10:01 AM Changeset in webkit [52099] by pfeldman@chromium.org
  • 18 edits in trunk/WebCore

2009-12-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [regression] inspector deletes nodes when editing css.

Now all the treeoutlines are focusable, sections and their titles
are also focusable. Change contains couple of drive-by fixes such as
canceling of the attribute edit nuking attr info and maintaining proper
selection while deleting nodes.

​https://bugs.webkit.org/show_bug.cgi?id=32460

  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.handleShortcut):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._promptKeyDown):
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype._keyDown):
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView): (WebInspector.DatabaseQueryView.prototype._promptKeyDown):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.get defaultFocusedElement): (WebInspector.ElementsPanel.prototype.handleShortcut):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype._keyDown): (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): (WebInspector.ElementsTreeElement.prototype._editingCancelled):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.get defaultFocusedElement):
  • inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement): (WebInspector.ScriptsPanel.prototype.handleShortcut):
  • inspector/front-end/SidebarPane.js: (WebInspector.SidebarPane): (WebInspector.SidebarPane.prototype.toggleExpanded): (WebInspector.SidebarPane.prototype._onTitleKeyDown):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.documentCanCopy): (WebInspector.documentCopy): (WebInspector._searchFieldManualFocus): (WebInspector._searchKeyDown): (WebInspector.startEditing.cleanUpAfterEditing): (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
  • inspector/front-end/treeoutline.js: (TreeOutline): (TreeOutline._removeChildAtIndex): (TreeOutline.prototype._treeKeyDown): (TreeElement.prototype.deselect):
  • inspector/front-end/utilities.js: ():
9:46 AM Changeset in webkit [52098] by Adam Roben
  • 2 edits in trunk/WebKit/win

Change IWebFramePrivate's vtable to be compatible with Safari 4.0.4

Reviewed by Steve Falkenburg.

Fixes <​http://webkit.org/b/32433> REGRESSION (r51567): Right click on
a link element crashes WebKit nightly

  • Interfaces/IWebFramePrivate.idl: Moved pauseSVGAnimation to the end

of the interface so the vtable that Safari 4.0.4 sees is unchanged.

9:43 AM Changeset in webkit [52097] by eric.carlson@apple.com
  • 1 edit
    11 adds in trunk/LayoutTests

2009-12-14 Eric Carlson <​eric.carlson@apple.com>

Not reviewed, build fix.

Update Tiger media test results after r52094.

  • platform/mac-tiger/accessibility: Added.
  • platform/mac-tiger/accessibility/media-element-expected.txt: Added.
  • platform/mac-tiger/media/audio-controls-rendering-expected.txt: Added.
  • platform/mac-tiger/media/controls-after-reload-expected.txt: Added.
  • platform/mac-tiger/media/controls-drag-timebar-expected.txt: Added.
  • platform/mac-tiger/media/controls-strict-expected.txt: Added.
  • platform/mac-tiger/media/controls-styling-expected.txt: Added.
  • platform/mac-tiger/media/video-controls-rendering-expected.txt: Added.
  • platform/mac-tiger/media/video-display-toggle-expected.txt: Added.
  • platform/mac-tiger/media/video-no-audio-expected.txt: Added.
  • platform/mac-tiger/media/video-zoom-controls-expected.txt: Added.
9:20 AM Changeset in webkit [52096] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-12-14 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Guard all of JSC's wrapper cache-related members on Document.

  • dom/Document.cpp: (WebCore::Document::createWrapperCache): Widened the guards to the whole method.
  • dom/Document.h: Added JSC guards to wrapper cache-related members.
8:25 AM Changeset in webkit [52095] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: there's an infinite loop going on for some webpages - facebook.com
​https://bugs.webkit.org/show_bug.cgi?id=32501

Reviewed by Adele Peterson.

WebCore:

The problem is that parentObjectUnignored() cannot be called
while in accessibilityIsIgnored, because it leads to
recursiveness. Specifically, there were checks to determine
if an object was within a ARIA tree. That check should
1) be moved to all platforms, and 2) not call parentObjectUnignored().

Test: accessibility/hang-in-isignored.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isAllowedChildOfTree):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

LayoutTests:

  • accessibility/hang-in-isignored-expected.txt: Added.
  • accessibility/hang-in-isignored.html: Added.
8:16 AM Changeset in webkit [52094] by eric.carlson@apple.com
  • 18 edits
    9 adds in trunk

2009-12-14 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows

Use MediaControllerThemeQuickTime on Leopard.

  • rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):

2009-12-14 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows

Regenerate layout and pixel test results for the new UI.

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/accessibility/media-element-expected.txt:
  • platform/mac-leopard/media/audio-controls-rendering-expected.checksum:
  • platform/mac-leopard/media/audio-controls-rendering-expected.txt:
  • platform/mac-leopard/media/controls-after-reload-expected.checksum: Added.
  • platform/mac-leopard/media/controls-after-reload-expected.png: Added.
  • platform/mac-leopard/media/controls-after-reload-expected.txt:
  • platform/mac-leopard/media/controls-drag-timebar-expected.txt:
  • platform/mac-leopard/media/controls-strict-expected.checksum: Added.
  • platform/mac-leopard/media/controls-strict-expected.png: Added.
  • platform/mac-leopard/media/controls-strict-expected.txt:
  • platform/mac-leopard/media/controls-strict-mode-expected.txt: Added.
  • platform/mac-leopard/media/controls-styling-expected.checksum: Added.
  • platform/mac-leopard/media/controls-styling-expected.png: Added.
  • platform/mac-leopard/media/controls-styling-expected.txt:
  • platform/mac-leopard/media/video-controls-rendering-expected.checksum:
  • platform/mac-leopard/media/video-controls-rendering-expected.txt:
  • platform/mac-leopard/media/video-display-toggle-expected.checksum:
  • platform/mac-leopard/media/video-display-toggle-expected.txt:
  • platform/mac-leopard/media/video-no-audio-expected.checksum: Added.
  • platform/mac-leopard/media/video-no-audio-expected.png: Added.
  • platform/mac-leopard/media/video-no-audio-expected.txt:
  • platform/mac-leopard/media/video-zoom-controls-expected.checksum:
  • platform/mac-leopard/media/video-zoom-controls-expected.txt:
7:44 AM Changeset in webkit [52093] by Adam Roben
  • 2 edits in trunk/WebKit/win

Build fix

  • WebKit.vcproj/WebKit.vcproj: Added $(DXSDK_DIR)\Lib\x86 to the

libpath for all non-Cairo configurations (it was missing from most of
them).

7:38 AM Changeset in webkit [52092] by Adam Roben
  • 2 edits
    1 add in trunk/WebCore

Move QuartzCore-related build settings into a vsprops file

Fixes <​http://webkit.org/b/32518>

Reviewed by Dan Bernstein.

  • WebCore.vcproj/WebCore.vcproj: Let VS reformat the files list, added

WebCoreQuartzCore.vsprops to the non-Cairo configurations, moved all
other QuartzCore-related build settings from here...

  • WebCore.vcproj/WebCoreQuartzCore.vsprops: ...to here.
7:21 AM Changeset in webkit [52091] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-12-14 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antti Koivisto.

handling scripts can block UI
​https://bugs.webkit.org/show_bug.cgi?id=27612

Break execution of external scrips to smaller chunks.
No new tests since no new functionality was introduced.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished): (WebCore::HTMLTokenizer::executeExternalScriptsIfReady): (WebCore::HTMLTokenizer::executeExternalScriptsTimerFired): (WebCore::HTMLTokenizer::continueExecutingExternalScripts):
  • html/HTMLTokenizer.h:
6:13 AM Changeset in webkit [52090] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

Unreviewed trivial buildfix.

Patch by Gabor Loki <​loki@inf.u-szeged.hu> on 2009-12-14
Fix crosses initialization of usedPrimaryBlocks for JSValue32

  • runtime/Collector.cpp:

(JSC::Heap::markConservatively):

3:09 AM Changeset in webkit [52089] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Connect QNetworkReply via direct connections.

​https://bugs.webkit.org/show_bug.cgi?id=32113

In the past we have switched from auto connections to queued
connections to get some more stability. The problem with the
Queued connections is latency. Even when running simple loading
tests the time it takes to runs highly varies and by using
direct connections these tests produce a stable result.

We will have to look out for crashes coming from within the
QNetworkAccessManager due this patch and address them then.

3:03 AM Changeset in webkit [52088] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2009-12-14 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Gustavo Noronha Silva.

media/video-played-collapse.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=31434

  • platform/gtk/Skipped: Give this test another chance, we believe the bug above has been fixed in a previous commit.
2:51 AM Changeset in webkit [52087] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

New setting to allow applications to completely supress the
default context menu that is generated by WebKit. This allows them
to still pass the vent to the default handler without needing to
use ugly hacks such as handling populate-popup, and removing all
the items from the default context menu.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event):
2:48 AM Changeset in webkit [52086] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[Qt] QtWebKit should use QImageReader::setQuality(49)

​https://bugs.webkit.org/show_bug.cgi?id=30740

Using QImageReader::setQuality(49) will influence the JPEG
decoder of Qt to use the JDCT_IFAST routines for decompressing. This
is showing a 5% improvement in a reduction that decodes all images
used during the page loading test. The libjpeg documentation mentions
that the IFAST routine is not as accurate as other routines but in
our tests we couldn't see a difference.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):

2:01 AM Changeset in webkit [52085] by Philippe Normand
  • 3 edits in trunk/WebCore

emit volumeChanged and durationChanged upon notification from GStreamer.

1:56 AM Changeset in webkit [52084] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

GCC 4.3.x warning fixed. Suggested parantheses added.
warning: ../../../JavaScriptCore/wtf/StdLibExtras.h:77: warning: suggest parentheses around + or - in operand of &

Reviewed by Simon Hausmann.

  • wtf/StdLibExtras.h:

(WTF::bitCount):

12:39 AM Changeset in webkit [52083] by adele@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

RS by Maciej Stachowiak.

Adding platform specific results for these test as part of reverting changes from ​http://trac.webkit.org/changeset/49585 to fix:
<rdar://problem/7382815> REGRESSION (4.0.4-TOT): Home photo slider is too narrow at ​http://www.ziprealty.com/
​https://bugs.webkit.org/show_bug.cgi?id=32078

  • platform/win/fast/css/large-number-round-trip-expected.txt: Added.
  • platform/win/fast/css/opacity-float-expected.txt: Added.
12:13 AM Changeset in webkit [52082] by ggaren@apple.com
  • 33 edits
    2 adds in trunk

JavaScriptCore: Changed GC from mark-sweep to mark-allocate.

Reviewed by Sam Weinig.

Added WeakGCMap to keep WebCore blissfully ignorant about objects that
have become garbage but haven't run their destructors yet.

1% SunSpider speedup.
7.6% v8 speedup (37% splay speedup).
17% speedup on bench-alloc-nonretained.js.
18% speedup on bench-alloc-retained.js.

  • API/JSBase.cpp:

(JSGarbageCollect):

files.

  • debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions): Updated to use the Collector
iterator abstraction.

  • jsc.cpp:

(functionGC): Updated for rename.

  • runtime/Collector.cpp: Slightly reduced the number of allocations per

collection, so that small workloads only allocate on collector block,
rather than two.

(JSC::Heap::Heap): Updated to use the new allocateBlock function.

(JSC::Heap::destroy): Updated to use the new freeBlocks function.

(JSC::Heap::allocateBlock): New function to initialize a block when
allocating it.

(JSC::Heap::freeBlock): Consolidated the responsibility for running
destructors into this function.

(JSC::Heap::freeBlocks): Updated to use freeBlock.

(JSC::Heap::recordExtraCost): Sweep the heap in this reporting function,
so that allocation, which is more common, doesn't have to check extraCost.

(JSC::Heap::heapAllocate): Run destructors right before recycling a
garbage cell. This has better cache utilization than a separate sweep phase.

(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks): New set of functions for managing the size of
the heap, now that the heap doesn't maintain any information about its
size.

(JSC::isPointerAligned):
(JSC::isHalfCellAligned):
(JSC::isPossibleCell):
(JSC::isCellAligned):
(JSC::Heap::markConservatively): Cleaned up this code a bit.

(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells): Some helper functions for examining the the mark
bitmap.

(JSC::Heap::sweep): Simplified this function by using a DeadObjectIterator.

(JSC::Heap::markRoots): Reordered some operations for clarity.

(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics): Rewrote these functions to calculate an object
count on demand, since the heap doesn't maintain this information by
itself.

(JSC::Heap::reset): New function for resetting the heap once we've
exhausted heap space.

(JSC::Heap::collectAllGarbage): This function matches the old collect()
behavior, but it's now an uncommon function used only by API.

  • runtime/Collector.h:

(JSC::CollectorBitmap::count):
(JSC::CollectorBitmap::isEmpty): Added some helper functions for managing
the collector mark bitmap.

(JSC::Heap::reportExtraMemoryCost): Changed reporting from cell equivalents
to bytes, so it's easier to understand.

  • runtime/CollectorHeapIterator.h:

(JSC::CollectorHeapIterator::CollectorHeapIterator):
(JSC::CollectorHeapIterator::operator!=):
(JSC::CollectorHeapIterator::operator*):
(JSC::CollectorHeapIterator::advance):
(JSC::::LiveObjectIterator):
(JSC::::operator):
(JSC::::DeadObjectIterator):
(JSC::::ObjectIterator): New iterators for encapsulating details about
heap layout, and what's live and dead on the heap.

  • runtime/JSArray.cpp:

(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength): Delay reporting extra cost until
we're fully constructed, so the heap mark phase won't visit us in an
invalid state.

  • runtime/JSCell.h:

(JSC::JSCell::):
(JSC::JSCell::createDummyStructure):
(JSC::JSCell::JSCell):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h: Added a dummy cell to simplify allocation logic.
  • runtime/JSString.h:

(JSC::jsSubstring): Don't report extra cost for substrings, since they
share a buffer that's already reported extra cost.

  • runtime/Tracing.d:
  • runtime/Tracing.h: Changed these dtrace hooks not to report object

counts, since they're no longer cheap to compute.

  • runtime/UString.h: Updated for renames.
  • runtime/WeakGCMap.h: Added.

(JSC::WeakGCMap::isEmpty):
(JSC::WeakGCMap::uncheckedGet):
(JSC::WeakGCMap::uncheckedBegin):
(JSC::WeakGCMap::uncheckedEnd):
(JSC::::get):
(JSC::::take):
(JSC::::set):
(JSC::::uncheckedRemove): Mentioned above.

  • wtf/StdLibExtras.h:

(WTF::bitCount): Added a bit population count function, so the heap can
count live objects to fulfill statistics questions.

JavaScriptGlue: Changed GC from mark-sweep to mark-allocate.

Reviewed by Sam Weinig.

  • JavaScriptGlue.cpp:

(JSCollect): Updated for rename. Fixed a bug where JSGlue would not check
to avoid nested GC calls.

WebCore: Changed GC from mark-sweep to mark-allocate.

Reviewed by Sam Weinig.

  • ForwardingHeaders/runtime/WeakGCMap.h: Added.
  • bindings/js/GCController.cpp:

(WebCore::collect):
(WebCore::GCController::gcTimerFired):
(WebCore::GCController::garbageCollectNow): Updated for rename.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::removeWrappers):
(WebCore::hasCachedDOMObjectWrapperUnchecked):
(WebCore::hasCachedDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapperUnchecked):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):

  • bindings/js/JSDOMBinding.h: Changed DOM wrapper maps to be WeakGCMaps.

Don't ASSERT that an item must be in the WeakGCMap when its destructor
runs, since it might have been overwritten in the map first.

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::toJS): Changed Document from a DOM object wrapper to a DOM node
wrapper, to simplify some code.

  • bindings/js/JSInspectedObjectWrapper.cpp:

(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
(WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper):

  • bindings/js/JSInspectorCallbackWrapper.cpp: Use a WeakGCMap for these

wrappers.

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::markChildren): Updated for WeakGCMap and Document using
a DOM node wrapper instead of a DOM object wrapper.

  • bindings/js/JSSVGPODTypeWrapper.h:

(WebCore::JSSVGDynamicPODTypeWrapperCache::wrapperMap):
(WebCore::JSSVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
(WebCore::JSSVGDynamicPODTypeWrapperCache::forgetWrapper):
(WebCore::::~JSSVGDynamicPODTypeWrapper): Shined a small beam of sanity light
on this code. Use hashtable-based lookup in JSSVGPODTypeWrapper.h instead
of linear lookup through iteration, since that's what hashtables were
invented for. Make JSSVGPODTypeWrapper.h responsible for reomving itself
from the table, instead of its JS wrapper, to decouple these objects from
GC, and because these objects are refCounted, not solely owned by their
JS wrappers.

  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.h: Adopted changes above.

Dec 13, 2009:

11:01 PM Changeset in webkit [52081] by adele@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

RS by Maciej Stachowiak.

Readding platform specific results for this test as part of reverting changes from ​http://trac.webkit.org/changeset/49585 to fix:
<rdar://problem/7382815> REGRESSION (4.0.4-TOT): Home photo slider is too narrow at ​http://www.ziprealty.com/
​https://bugs.webkit.org/show_bug.cgi?id=32078

  • platform/mac/fast/css/opacity-float-expected.txt: Added.
9:01 PM Changeset in webkit [52080] by abarth@webkit.org
  • 13 edits
    6 adds in trunk

2009-12-13 Charles Reis <​creis@chromium.org>

Reviewed by Adam Barth.

Refactor some security code out of V8 bindings
​https://bugs.webkit.org/show_bug.cgi?id=32326

No new tests. There should be no functionality changes in this patch,
since it is only refactoring code.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/BindingSecurity.h: Added. (WebCore::BindingSecurity::BindingSecurity): (WebCore::::canAccessWindow): (WebCore::::canAccessFrame): (WebCore::::checkNodeSecurity):
  • bindings/BindingSecurityBase.cpp: Added. (WebCore::BindingSecurityBase::getDOMWindow): (WebCore::BindingSecurityBase::getFrame): (WebCore::BindingSecurityBase::canAccessWindow):
  • bindings/BindingSecurityBase.h: Added.
  • bindings/GenericBinding.h: Added. (WebCore::):
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::isSafeScript):
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8BindingState.cpp: Added. (WebCore::::Only): (WebCore::::getActiveWindow): (WebCore::::immediatelyReportUnsafeAccessTo):
  • bindings/v8/V8BindingState.h: Added. (WebCore::):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::reportUnsafeAccessTo): (WebCore::reportUnsafeJavaScriptAccess):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::):
  • bindings/v8/custom/V8CustomBinding.cpp: (WebCore::allowSettingFrameSrcToJavascriptUrl): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::V8Custom::ClearTimeoutImpl): (WebCore::NAMED_ACCESS_CHECK): (WebCore::INDEXED_ACCESS_CHECK):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK):

2009-12-13 Charles Reis <​creis@chromium.org>

Reviewed by Adam Barth.

Refactor some security code out of V8 bindings
​https://bugs.webkit.org/show_bug.cgi?id=32326

  • src/WebBindings.cpp: (WebKit::getDragDataImpl):
7:10 PM Changeset in webkit [52079] by zecke@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Implement initializeMaximumHTTPConnectionCountPerHost.

Qt allows to have three connections per host on Symbian, for
every other platform the limit is set to six connections per
host but the default implementation will only schedule four
connections per host.
In a manual test we seem to get the best loading speed by
going with Qt's limit and schedule two more jobs to allow Qt
to prepare them.

  • platform/network/ResourceRequestBase.cpp:
  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::initializeMaximumHTTPConnectionCountPerHost):

6:38 PM Changeset in webkit [52078] by mjs@apple.com
  • 3 edits in trunk

2009-12-13 Eric Seidel <​eric@webkit.org>

Reviewed by Gavin Barraclough.

string-base64 test does not compute a valid base64 string
​http://bugs.webkit.org/show_bug.cgi?id=16806

  • tests/string-base64.js: change str[i] to str.charCodeAt(i)

2009-12-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Gavin Barraclough.

SunSpider/tests/string-base64.js does not compute a valid base64 encoded string
​https://bugs.webkit.org/show_bug.cgi?id=16806

Based on a patch by Eric Seidel.


Fix the base64 computation to actually compute correct results. The impact on runtime of
the test is pretty small, but noticeable for some browsers. But at least it's not
doing a wrong and meaningless computation any more.


  • tests/sunspider-0.9.1/string-base64.js: (): (base64ToString):
6:26 PM Changeset in webkit [52077] by mjs@apple.com
  • 2 edits in trunk/WebKitTools

Fix minor problem in sunspider-compare-results which left it broken.

Reviewed by Gavin Barraclaugh.

  • Scripts/sunspider-compare-results: Declare $parseonly
5:32 PM Changeset in webkit [52076] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • runtime/JSGlobalObjectFunctions.cpp:

Reviewed by NOBODY (speculative Windows build fix).

4:27 PM Changeset in webkit [52075] by barraclough@apple.com
  • 12 edits
    1 add in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=32496
Switch remaining cases of string construction to use StringBuilder.
Builds strings using a vector rather than using string append / addition.

Reviewed by Sam Weinig.

(JSC::FunctionExecutable::paramString):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::stringify):
(JSC::Stringifier::indent):

  • runtime/JSString.h:
  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lexString):

  • runtime/NumberPrototype.cpp:

(JSC::integerPartNoExp):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):

  • runtime/Operations.h:

(JSC::jsString):

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferences):
(JSC::stringProtoFuncConcat):

4:14 PM Changeset in webkit [52074] by mitz@apple.com
  • 2 edits in trunk/WebKitSite

Add a style guideline concerning floating point literals
​https://bugs.webkit.org/show_bug.cgi?id=32497

Reviewed by Sam Weinig.

  • coding/coding-style.html:
4:12 PM Changeset in webkit [52073] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7341364> Crash at HTMLParser::popOneBlockCommon() after
handling misnested residual style tags

Reviewed by Simon Fraser.

WebCore:

Test: fast/parser/residual-style-close-ref-clone.html

  • html/HTMLParser.cpp:

(WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Gave the
block stack a strong reference to the cloned residual style element.

LayoutTests:

  • fast/parser/residual-style-close-ref-clone-expected.txt: Added.
  • fast/parser/residual-style-close-ref-clone.html: Added.
3:53 PM Changeset in webkit [52072] by mjs@apple.com
  • 2 edits in trunk/SunSpider

Fixing commit error...

I accidentally committed my last patch in a form that broke Web-hosted SunSpider. Fixing.

  • resources/driver-TEMPLATE.html:
3:00 PM Changeset in webkit [52071] by adele@apple.com
  • 9 edits in trunk

Reverting changes from ​http://trac.webkit.org/changeset/49585 to fix:
<rdar://problem/7382815> REGRESSION (4.0.4-TOT): Home photo slider is too narrow at ​http://www.ziprealty.com/
​https://bugs.webkit.org/show_bug.cgi?id=32078

Reviewed by Sam Weinig.

WebCore:

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):

LayoutTests:

  • fast/css/large-number-round-trip-expected.txt:
  • fast/css/large-number-round-trip.html: Updated to run in Firefox.
  • fast/css/opacity-float-expected.txt:
  • fast/css/opacity-float.html:
  • transforms/2d/compound-2d-transforms-expected.txt:
  • transforms/2d/compound-2d-transforms.html:
2:48 PM Changeset in webkit [52070] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

Also give the right click event to the frame's event handler, if
there WebCore decides to not generate the default context
menu. This fixes some pages that handle right-button clicks for
things other than context menu creation.

  • webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event):
2:34 PM Changeset in webkit [52069] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-13 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Simon Hausmann.

Add a test in Qt for ​https://bugs.webkit.org/show_bug.cgi?id=29005
​https://bugs.webkit.org/show_bug.cgi?id=29008

  • tests/qwebframe/tst_qwebframe.cpp:
12:31 PM Changeset in webkit [52068] by mjs@apple.com
  • 3 edits
    1 add in trunk/SunSpider

2009-12-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

Use JSON.parse instead of eval for Web-hosted SunSpider results processing
​https://bugs.webkit.org/show_bug.cgi?id=32490

  • hosted/json2.js: Added. Incorporated from json.org
  • resources/driver-TEMPLATE.html: Fix an HTML validation bug I noticed.
  • resources/results-TEMPLATE.html: Use JSON.parse instead of eval to process results.
5:33 AM Changeset in webkit [52067] by jeremy@chromium.org
  • 8 edits in trunk

Reviewed by Eric Seidel.

Add code to allow toggling ATSUI/Core Text rendering at runtime in ComplexTextController.
​https://bugs.webkit.org/show_bug.cgi?id=31802

The goal here is to allow for a zero runtime hit for ports that decide to select
the API at compile time.
When both USE(ATSUI) and USE(CORE_TEXT) are true, the API is toggled
at runtime. Core Text is used for OS Versions >= 10.6.

No test since this is already covered by existing pixel tests.

  • platform/graphics/SimpleFontData.h: Change #ifdef to define getNSFont() on Chrome/Mac .
  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::shouldUseATSUIAPI): Cache decision about which API to use.
(WebCore::ComplexTextController::ComplexTextRun::indexAt):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Stub function to call through
to ATSUI/Core text variants.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): The actual work for object construction
is delegate to createTextRunFromFontDataATSUI/createTextRunFromFontDataCoreText.

  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Small style fix.
(WebCore::ComplexTextController::ComplexTextRun::createTextRunFromFontDataATSUI):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::ComplexTextRun::createTextRunFromFontDataCoreText):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

4:11 AM reni_regexp.pdf attached to QtWebKit/CodeCamp200912 by reni@inf.u-szeged.hu
3:32 AM Changeset in webkit [52066] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-12-13 Christian Dywan <​christian@twotoasts.de>

Reviewed by Holger Freyther.

​http://bugs.webkit.org/show_bug.cgi?id=31014
[Gtk] Build fails with gtk+-2.10 (no tested with older releases)

Guard GTK+ 2.12 specific tooltip code with #ifdef.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
1:31 AM Changeset in webkit [52065] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-13 Simon Hausmann <Simon Hausmann>

Reviewed by Holger Freyther.

[Qt] Re-enable QWebView::renderHints property for Qt for Symbian

​https://bugs.webkit.org/show_bug.cgi?id=28273

The bug in Qt's moc that triggered a linking error when declaring this
property has been fixed and we can remove the workaround.

  • Api/qwebview.h:
12:44 AM Changeset in webkit [52064] by eric.carlson@apple.com
  • 17 edits in trunk

2009-12-13 Eric Carlson <​eric.carlson@apple.com>

No review, rolling out r52059 until I can generate new Tiger
test results.

  • rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):

2009-12-13 Eric Carlson <​eric.carlson@apple.com>

No review, rolling out r52059 until I can generate new Tiger test
results.

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/media/controls-after-reload-expected.txt:
  • platform/mac-leopard/media/controls-drag-timebar-expected.txt:
  • platform/mac-leopard/media/controls-strict-expected.txt:
  • platform/mac-leopard/media/controls-styling-expected.txt:
  • platform/mac-leopard/media/video-controls-rendering-expected.checksum:
  • platform/mac-leopard/media/video-controls-rendering-expected.txt:
  • platform/mac-leopard/media/video-display-toggle-expected.checksum:
  • platform/mac-leopard/media/video-display-toggle-expected.txt:
  • platform/mac-leopard/media/video-no-audio-expected.txt:
  • platform/mac-leopard/media/video-zoom-controls-expected.checksum:
  • platform/mac-leopard/media/video-zoom-controls-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/video-zoom-expected.checksum:
Note: See TracTimeline for information about the timeline view.