Timeline
Dec 15, 2009:
- 11:54 PM Changeset in webkit [52189] by
-
- 4 edits in trunk/WebKitTools
2009-12-15 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by David Levin.
Code clean-up in check-webkit-style as described below.
The only functional changes are minor improvements to the
script's help output.
- Scripts/check-webkit-style:
- Added the module docstring from cpp_style.py.
- Improved wording of the --help output and added some of the default values as substitution strings.
- Called cpp_style.exit_with_usage instead of sys.stderr.write in main function.
- Made changes caused by changes to cpp_style.py.
- Scripts/modules/cpp_style.py:
- Removed module docstring, as well as redundant _USAGE string and main() function obsoleted by check-webkit-style.
- Moved specification of default script values from within a function definition to global variables.
- Moved the default webkit filter rules to be near the other global variables.
- Renamed "FILTER" global variables to "FILTER_RULES" to establish unambiguous terminology.
- Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES.
- Changed _STYLE_CATEGORIES from a string to a list.
- Added default webkit filter rules to --filter= output.
- Renamed "print_" methods to "exit_with_" since they exist and added a temporary display_help parameter.
- Added a temporary display_help parameter to parse_arguments.
- Scripts/modules/cpp_style_unittest.py:
- Made changes caused by changes to cpp_style.py.
- Lower-cased ErrorCollector's ERROR_CATEGORIES instance variables since they are not global.
- 11:21 PM Changeset in webkit [52188] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix for the style-queue.
Typo: _updates_status -> _update_status
We need to improve our testing infrastructure for the queues.
- Scripts/modules/commands/queues.py:
- 11:05 PM Changeset in webkit [52187] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix for the style-queue. I suspect this is a recent
regression from Eric's change below.
- Scripts/modules/commands/queues.py:
- 7:12 PM Changeset in webkit [52186] by
-
- 5 edits in trunk/SunSpider
2009-12-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adele Peterson.
Make SunSpider version more prominent in the title
https://bugs.webkit.org/show_bug.cgi?id=32574
- hosted/sunspider.html:
- hosted/versions.html:
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html:
- 6:26 PM Changeset in webkit [52185] by
-
- 3 edits in trunk/SunSpider
2009-12-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Make SunSpider refuse to compare results across content versions
https://bugs.webkit.org/show_bug.cgi?id=32573
The results URL now includes a version indicator, and compare mode
will refuse to compare between versions.
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html:
- 6:02 PM Changeset in webkit [52184] by
-
- 4 edits2 adds in trunk
Fix crash when encountering illegal HTML within a continuation inside <ruby>.
(https://bugs.webkit.org/show_bug.cgi?id=32316)
Reviewed by Adam Barth.
Avoid having the anonymous blocks utilized in the ruby renderers being
re-used as continuation blocks.
Avoid having ruby runs collected as "leftover blocks".
Test: fast/ruby/ruby-illegal.html
WebCore:
- rendering/RenderRuby.h:
(WebCore::RenderRubyAsInline::removeLeftoverAnonymousBlock): mustn't be called
(WebCore::RenderRubyAsInline::isRuby): made private
(WebCore::RenderRubyAsInline::renderName): made private
(WebCore::RenderRubyAsInline::createsAnonymousWrapper): return true
(WebCore::RenderRubyAsBlock::removeLeftoverAnonymousBlock): mustn't be called
(WebCore::RenderRubyAsBlock::isRuby): made private
(WebCore::RenderRubyAsBlock::renderName): made private
(WebCore::RenderRubyAsBlock::createsAnonymousWrapper): return true
- rendering/RenderRubyRun.h:
(WebCore::RenderRubyRun::removeLeftoverAnonymousBlock): avoid
(WebCore::RenderRubyRun::isRubyRun): made private
(WebCore::RenderRubyRun::renderName): made private
(WebCore::RenderRubyRun::createsAnonymousWrapper): return true
LayoutTests:
- fast/ruby/ruby-illegal-expected.txt: Added.
- fast/ruby/ruby-illegal.html: Added.
- 4:51 PM Changeset in webkit [52183] by
-
- 2 edits in trunk/WebKitTools
2009-12-15 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
update-webkit-chromium to auto-install gclient
- Scripts/update-webkit-chromium:
- 4:04 PM Changeset in webkit [52182] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32498
<rdar://problem/7471495>
REGRESSION(r51978-r52039): AJAX "Mark This Forum Read" function no longer
works
Reviewed by Sam "r=me" Weinig.
Fixed a tyop.
- runtime/Operations.h:
(JSC::jsAdd): Use the '&&' operator, not the ',' operator.
- 3:53 PM Changeset in webkit [52181] by
-
- 1 edit in trunk/WebKit/win/WebKit.vcproj/WebKit.vcproj
Add delay load of QuartzCore.dll and QuartzCoreInterface.dll to fix Windows build
- 3:47 PM Changeset in webkit [52180] by
-
- 4 edits in trunk/WebKitTools
2009-12-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot
https://bugs.webkit.org/show_bug.cgi?id=32546
You can see an example of this working in:
https://bugs.webkit.org/show_bug.cgi?id=32585#c3
- QueueStatusServer/queue_status.py:
- Output the id of the newly created status.
- Scripts/modules/commands/queues.py:
- Tweak the commit-queue logging to include a full status link.
- Scripts/modules/statusbot.py:
- update_status should return the newly created status id.
- 3:44 PM Changeset in webkit [52179] by
-
- 2 edits in trunk/JavaScriptCore
Try to fix the windows build: don't export this inlined function.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:33 PM Changeset in webkit [52178] by
-
- 4 edits in trunk/JavaScriptCore
Inlined JSCell's operator new.
Reviewed by Beth Dakin.
3.7% speedup on bench-allocate-nonretained.js.
- JavaScriptCore.exp:
- runtime/JSCell.cpp:
- runtime/JSCell.h:
(JSC::JSCell::operator new):
- 3:02 PM BuildingQtOnWindows edited by
- Replaced outdated Trolltech website link to Qt download with Nokia link (diff)
- 3:02 PM Changeset in webkit [52177] by
-
- 14 edits in trunk/WebCore
2009-12-15 Nate Chapin <Nate Chapin>
Reviewed by Darin Adler.
Rename skipCanLoadCheck to skipSecurityCheck in a bunch of places in WebCore/loader.
- loader/Cache.cpp: (WebCore::Cache::requestUserCSSStyleSheet):
- loader/CachedImage.cpp: (WebCore::CachedImage::load):
- loader/CachedResource.cpp: (WebCore::CachedResource::load):
- loader/CachedResource.h: (WebCore::CachedResource::load):
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): (WebCore::DocumentThreadableLoader::preflightSuccess): (WebCore::DocumentThreadableLoader::loadRequest):
- loader/DocumentThreadableLoader.h:
- loader/FrameLoaderTypes.h: (WebCore::):
- loader/Request.cpp: (WebCore::Request::Request):
- loader/Request.h: (WebCore::Request::shouldDoSecurityCheck):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- loader/SubresourceLoader.h:
- loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests):
- loader/loader.h:
- 2:40 PM Changeset in webkit [52176] by
-
- 7 edits in trunk/JavaScriptCore
Removed the number heap, replacing it with a one-item free list for
numbers, taking advantage of the fact that two number cells fit inside
the space for one regular cell, and number cells don't require destruction.
Reviewed by Oliver Hunt.
SunSpider says 1.6% faster in JSVALUE32 mode (the only mode that
heap-allocates numbers).
SunSpider says 1.1% faster in JSVALUE32_64 mode. v8 says 0.8% faster
in JSVALUE32_64 mode. 10% speedup on bench-alloc-nonretained.js. 6%
speedup on bench-alloc-retained.js.
There's a lot of formulaic change in this patch, but not much substance.
- JavaScriptCore.exp:
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- runtime/Collector.cpp:
(JSC::Heap::Heap):
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlockPtr):
(JSC::Heap::freeBlocks):
(JSC::Heap::recordExtraCost):
(JSC::Heap::allocate):
(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks):
(JSC::Heap::markConservatively):
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells):
(JSC::Heap::sweep):
(JSC::Heap::markRoots):
(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics):
(JSC::Heap::isBusy):
(JSC::Heap::reset):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::primaryHeapBegin):
(JSC::Heap::primaryHeapEnd):
- runtime/Collector.h:
(JSC::): Removed all code pertaining to the number heap, and changed all
heap template functions and classes to non-template functions and classes.
(JSC::Heap::allocateNumber): A new optimization to replace the number
heap: allocate half-sized number cells in pairs, returning the first
cell and caching the second cell for the next allocation.
- runtime/CollectorHeapIterator.h:
(JSC::LiveObjectIterator::LiveObjectIterator):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::DeadObjectIterator):
(JSC::DeadObjectIterator::operator++):
(JSC::ObjectIterator::ObjectIterator):
(JSC::ObjectIterator::operator++):
- runtime/JSCell.h:
(JSC::JSCell::isNumber): Removed all code pertaining to the number heap,
and changed all heap template functions and classes to non-template functions
and classes.
- 2:18 PM Changeset in webkit [52175] by
-
- 1 edit in trunk/WebKitSite/blog-files/webgl/resources/utils3d.js
updated WebGL demos to latest spec
- 2:12 PM Changeset in webkit [52174] by
-
- 4 edits2 adds in trunk
<rdar://problem/7470452> Safari/Chromium crashes on complicated @font-face rule
https://bugs.webkit.org/show_bug.cgi?id=32257
Reviewed by Darin Adler.
WebCore:
Test: fast/css/font-face-unused-source-loaded.html
The loading of a font resource caused a CSSFontFace that had the resource in one of its
sources, but wasn’t using it (due to using an earlier source) to invalidate its
CSSSegmentedFontFaces. This caused FontData for the active source (the one that did not just
finish loading) to be deleted, but that went unnoticed by Font::operator==(), since the
corresponding FontFallbackLists were not in the loading state. The fix is for CSSFontFace to
ignore loads from unused sources.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontLoaded): Bail out if the loaded source is not the active source.
(WebCore::CSSFontFace::getFontData): Set m_activeSource to the source that supplied the
FontData.
- css/CSSFontFace.h:
(WebCore::CSSFontFace::CSSFontFace): Initialize m_activeSource.
LayoutTests:
- fast/css/font-face-unused-source-loaded-expected.txt: Added.
- fast/css/font-face-unused-source-loaded.html: Added.
- 2:12 PM Changeset in webkit [52173] by
-
- 1 delete in trunk/WebCore/manual-tests/webgl
Getting rid of out of date WebGL tests
- 2:07 PM Changeset in webkit [52172] by
-
- 4 edits in trunk/WebCore
2009-12-15 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Cannot load flash files from a local file.
https://bugs.webkit.org/show_bug.cgi?id=32572
When loading the main resource and its mime type is application/octet-stream,
use the file extenstion to check if it is a supported plugin.
No new tests were added since any existing swf file can be used as a manual test.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
- loader/MainResourceLoader.h:
- plugins/PluginDatabase.h:
- 1:55 PM Changeset in webkit [52171] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WeakGCMap class
https://bugs.webkit.org/show_bug.cgi?id=32547
Inherits WeakGCMap from FastAllocBase because it is instantiated by
'new' at: WebCore/dom/Document.cpp:512.
- runtime/WeakGCMap.h:
- 1:52 PM Changeset in webkit [52170] by
-
- 5 edits4 deletes in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=18498>.
REGRESSION: Tips are not shown for resources anymore.
Reviewed by Timothy Hatcher.
As discussed in the bug, Tips are not coming back, and the feature
will be moved to the audits panel. This patch is to remove the Tips
code and the resources that it needed.
- WebCore.gypi: Removed tips files.
- inspector/front-end/Images/tipBalloon.png: Removed.
- inspector/front-end/Images/tipBalloonBottom.png: Removed.
- inspector/front-end/Images/tipIcon.png: Removed.
- inspector/front-end/Images/tipIconPressed.png: Removed.
- inspector/front-end/Resource.js: Removed tips code.
(WebInspector.Resource.prototype.set finished):
- inspector/front-end/WebKit.qrc: Removed tips files.
- inspector/front-end/inspector.css: Removes tips style rules.
- 1:44 PM Changeset in webkit [52169] by
-
- 4 edits in trunk/WebCore
2009-12-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Display request headers for main resource
having redirects.
- inspector/InspectorController.cpp: (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest):
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::appendRedirect): (WebCore::InspectorResource::createCached): (WebCore::InspectorResource::updateRequest):
- inspector/InspectorResource.h: (WebCore::InspectorResource::create):
- 1:35 PM Changeset in webkit [52168] by
-
- 2 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=32578>.
Web Inspector: No Need for ?="" now that we have context menus.
Reviewed by Timothy Hatcher.
Remove the toggleNewAttributeButton function and callers to it, as
we don't need this behavior anymore, now that we have context menus.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.set hovered):
(WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):
(WebInspector.ElementsTreeElement.prototype._startEditing):
- 12:15 PM Changeset in webkit [52167] by
-
- 1 edit in trunk/WebKit/gtk/ChangeLog
Fixed typos
- 11:55 AM Changeset in webkit [52166] by
-
- 4 edits in trunk/WebCore
2009-12-15 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
[V8] Generate trivial named property getters.
https://bugs.webkit.org/show_bug.cgi?id=32562
Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm: Added GenerateImplementationNamedPropertyGetter.
- bindings/v8/V8Collection.h: (WebCore::getNamedPropertyOfCollection): Fixed a booboo by using AtomicString like we're supposed to.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed code that's now generated.
- 11:51 AM Changeset in webkit [52165] by
-
- 3 edits in trunk/WebCore
Part of <http://webkit.org/b/32568>.
New Web Inspector: The Context Menu should be used in more places.
Reviewed by Timothy Hatcher.
Add support for context menu entries for editing and deleting elements
in the datagrid. This gives support to deleting cookies, and editing and
deleting session storage and local storage.
- English.lproj/localizedStrings.js: Added "Edit" and "Add New" entries (delete was already there)
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid): Added context menu listener.
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
- 11:08 AM Changeset in webkit [52164] by
-
- 10 edits in trunk
2009-12-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Don't allow default framebuffer to be mutated
https://bugs.webkit.org/show_bug.cgi?id=32391
- fast/canvas/webgl/error-reporting-expected.txt:
- fast/canvas/webgl/null-object-behaviour-expected.txt:
- fast/canvas/webgl/script-tests/error-reporting.js:
- fast/canvas/webgl/script-tests/null-object-behaviour.js:
2009-12-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Don't allow default framebuffer to be mutated
https://bugs.webkit.org/show_bug.cgi?id=32391
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D):
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::bindFramebuffer):
2009-12-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Don't allow default framebuffer to be mutated
https://bugs.webkit.org/show_bug.cgi?id=32391
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::bindFramebuffer): (WebCore::GraphicsContext3D::bindFramebuffer):
- 10:50 AM Changeset in webkit [52163] by
-
- 2 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for FontPlatformDataCacheKey class
https://bugs.webkit.org/show_bug.cgi?id=32552
Inherits the following struct from FastAllocBase because it is instantiated by 'new':
struct name - instantiated at: WebCore/'location'
struct FontPlatformDataCacheKey - platform/graphics/FontCache.cpp:118
- platform/graphics/FontCache.cpp:
- 10:43 AM Changeset in webkit [52162] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for dtoa's P5Node struct
https://bugs.webkit.org/show_bug.cgi?id=32544
Inherits P5Node struct from Noncopyable because it is instantiated by
'new' at wtf/dtoa.cpp:588 and don't need to be copyable.
- wtf/dtoa.cpp:
- 10:14 AM Changeset in webkit [52161] by
-
- 3 edits in trunk/WebKit/chromium
2009-12-15 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Add TreeGridRole to catch up with
http://trac.webkit.org/changeset/52159.
- public/WebAccessibilityRole.h: (WebKit::): Added WebAccessibilityRoleTreeGrid.
- src/AssertMatchingEnums.cpp: Added matching compile assert.
- 10:13 AM Changeset in webkit [52160] by
-
- 7 edits in trunk
Bug 31090 - [Chromium] Add DownloadURL format to Chromium clipboard.
https://bugs.webkit.org/show_bug.cgi?id=31090
Reviewed by Dmitry Titov.
The proposal to whatwg can be found here:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022118.html
WebCore:
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ChromiumDataObject.h:
- platform/chromium/ClipboardChromium.cpp:
(WebCore::):
(WebCore::clipboardTypeFromMIMEType):
(WebCore::ClipboardChromium::setData):
WebKit/chromium:
- public/WebDragData.h:
- src/WebDragData.cpp:
(WebKit::WebDragData::downloadURL):
(WebKit::WebDragData::setDownloadURL):
- 10:13 AM BuildBot edited by
- (diff)
- 10:07 AM Changeset in webkit [52159] by
-
- 13 edits2 adds in trunk
WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-treegrid.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityARIAGrid.h:
(WebCore::AccessibilityARIAGrid::supportsSelectedRows):
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
- accessibility/AccessibilityObject.h:
(WebCore::):
(WebCore::AccessibilityObject::isARIATreeGridRow):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.h:
(WebCore::AccessibilityTable::supportsSelectedRows):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
LayoutTests:
- platform/mac-leopard/Skipped:
- platform/mac/accessibility/aria-treegrid-expected.txt: Added.
- platform/mac/accessibility/aria-treegrid.html: Added.
- 9:09 AM Changeset in webkit [52158] by
-
- 2 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for EmptyEditorClient and EmptyInspectorClient
https://bugs.webkit.org/show_bug.cgi?id=32557
Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class EmptyEditorClient - svg/graphics/SVGImage.cpp:230
class EmptyInspectorClient - svg/graphics/SVGImage.cpp:241
- loader/EmptyClients.h:
- 9:02 AM Changeset in webkit [52157] by
-
- 3 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore/inspector directory's classes
https://bugs.webkit.org/show_bug.cgi?id=32556
Inherits the following class from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class InspectorFrontend - inspector/InspectorController.cpp:538
class InspectorTimelineAgent - inspector/InspectorController.cpp:1097
- inspector/InspectorFrontend.h:
- inspector/InspectorTimelineAgent.h:
- 8:54 AM Changeset in webkit [52156] by
-
- 3 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore/platform/network directory's classes
https://bugs.webkit.org/show_bug.cgi?id=32553
Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
struct CrossThreadResourceResponseData - platform/network/ResourceResponseBase.cpp:109
Inherits the following classes from FastAllocBase because these are
instantiated by 'new':
class ResourceResponseBase - (its child class) platform/network/ResourceResponseBase.cpp:90
class ResourceRequestBase - (its child class) loader/DocumentThreadableLoader.cpp:88
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.h:
- 8:44 AM Changeset in webkit [52155] by
-
- 3 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for AnimationControllerPrivate and FillLayerPropertyWrapperGetter
https://bugs.webkit.org/show_bug.cgi?id=32549
Inherits AnimationControllerPrivate and FillLayerPropertyWrapperGetter
classes from Noncopyable because these are instantiated by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
AnimationControllerPrivate - page/animation/AnimationController.cpp:439
FillLayerPropertyWrapperGetter - (its child class) page/animation/AnimationBase.cpp:464
- page/animation/AnimationBase.cpp:
- page/animation/AnimationControllerPrivate.h:
- 8:36 AM Changeset in webkit [52154] by
-
- 7 edits in trunk/WebCore
2009-12-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not lose HTTP redirect information, display it
in the Resources Panel.
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::appendRedirect): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::releaseScriptObject): (WebCore::InspectorResource::type):
- inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::Changes::setAll):
- inspector/front-end/inspector.js: (WebInspector._addResource): (WebInspector.updateResource):
- 8:17 AM Changeset in webkit [52153] by
-
- 2 edits in trunk/WebCore
[Qt] Followup for direct signals and slots connections in QNetworkReplyHandler
https://bugs.webkit.org/show_bug.cgi?id=32113
For Qt versions prior to 4.6.1 we will need to use QueuedConnection
for the signal and slot connection to avoid running into a bug in.
Add a comment that we want to remove one signal to forward
queued items when moving our minimum requirements.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
- 8:17 AM Changeset in webkit [52152] by
-
- 4 edits1 add in trunk
[Qt] Fix JavaScript prompt behavior for empty/null strings.
https://bugs.webkit.org/show_bug.cgi?id=30914
The patch is based on the work done by Gupta Manish.
In the default implementation of the JavaScript prompt
we are using a QInputDialog to get the text and this has
one quirk with regard to not entering any text.
In other WebKit ports and in Firefox an empty string is
returned but in the Qt case it is a null string.
Change the API documentation in QWebPage to mention we want to
have a non null string but do the fixup in the ChromeClientQt
to support existing code.
WebKit/qt:
- Api/qwebpage.cpp:
(QWebPage::javaScriptPrompt): Change API documentation
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::runJavaScriptPrompt): Fixup null QString
WebCore:
- manual-tests/qt/java-script-prompt.html: Added.
- 8:13 AM Changeset in webkit [52151] by
-
- 5 edits in trunk/WebCore
2009-12-15 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Moving list populate methods from PopupMenuQt to QWebPopup.
In preparation to future implementation of a delegation API for the combobox.
- platform/PopupMenu.h:
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide):
- platform/qt/QWebPopup.cpp: (WebCore::QWebPopup::show): (WebCore::QWebPopup::populate):
- platform/qt/QWebPopup.h: (WebCore::QWebPopup::hide):
- 6:18 AM Changeset in webkit [52150] by
-
- 5 edits5 moves in trunk/WebKitTools
[Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-15
Reviewed by Tor Arne Vestbø.
- DumpRenderTree/qt/DumpRenderTree.cpp: Removed.
- DumpRenderTree/qt/DumpRenderTree.h: Removed.
- DumpRenderTree/qt/DumpRenderTree.pro: Updated.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp.
- DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h.
- DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp.
(GCController::GCController):
- DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/WorkQueueItem.h: Removed.
- DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes.
- DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h.
- DumpRenderTree/qt/jsobjects.cpp: Removed.
- DumpRenderTree/qt/jsobjects.h: Removed.
- DumpRenderTree/qt/main.cpp: Updated includes.
- 4:20 AM QtWebKit/CodeCamp200912Teams edited by
- (diff)
- 4:14 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 4:08 AM QtWebKit/CodeCamp200912Teams edited by
- (diff)
- 3:29 AM Changeset in webkit [52149] by
-
- 6 edits1 copy in trunk/WebCore
2009-12-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Extract WebInspector.Section from WebInspector.PropertiesSection.
https://bugs.webkit.org/show_bug.cgi?id=32523
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
- inspector/front-end/Section.js: Added. (WebInspector.Section): (WebInspector.Section.prototype.get title): (WebInspector.Section.prototype.set title): (WebInspector.Section.prototype.get subtitle): (WebInspector.Section.prototype.set subtitle): (WebInspector.Section.prototype.get expanded): (WebInspector.Section.prototype.set expanded): (WebInspector.Section.prototype.get populated): (WebInspector.Section.prototype.set populated): (WebInspector.Section.prototype.expand): (WebInspector.Section.prototype.collapse): (WebInspector.Section.prototype.toggleExpanded):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 3:12 AM Changeset in webkit [52148] by
-
- 3 edits1 delete in trunk/WebKitTools
2009-12-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
We have two mark-fixed commands
https://bugs.webkit.org/show_bug.cgi?id=32073
- Scripts/mark-bug-fixed: Removed.
- Scripts/modules/commands/upload.py:
- Scripts/modules/commands/upload_unittest.py:
- 2:39 AM Changeset in webkit [52147] by
-
- 4 edits in trunk/WebKitTools
2009-12-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected
https://bugs.webkit.org/show_bug.cgi?id=28286
- QueueStatusServer/index.html:
- Show [results] links if a results log was uploaded.
- QueueStatusServer/queue_status.py:
- Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str().
- Scripts/modules/commands/queues.py:
- Post to the status bot when a patch fails and include the failure log as a results file.
- 2:32 AM QtWebKit/CodeCamp200912Teams created by
- 2:18 AM Changeset in webkit [52146] by
-
- 12 edits2 deletes in trunk
2009-12-15 Eric Seidel <eric@webkit.org>
No review, rolling out r52140.
http://trac.webkit.org/changeset/52140
https://bugs.webkit.org/show_bug.cgi?id=31299
The commit broke the Leopard bots and unfortunately
Chris wasn't around to fix them, so I'm rolling the change
out after 3 hours so that the bots can roll green again. :)
- platform/mac/accessibility/aria-treegrid-expected.txt: Removed.
- platform/mac/accessibility/aria-treegrid.html: Removed.
2009-12-15 Eric Seidel <eric@webkit.org>
No review, rolling out r52140.
http://trac.webkit.org/changeset/52140
https://bugs.webkit.org/show_bug.cgi?id=31299
The commit broke the Leopard bots and unfortunately
Chris wasn't around to fix them, so I'm rolling the change
out after 3 hours so that the bots can roll green again. :)
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityARIAGrid.h:
- accessibility/AccessibilityARIAGridRow.cpp:
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityObject.cpp: (WebCore::createARIARoleMap):
- accessibility/AccessibilityObject.h: (WebCore::):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isMultiSelect): (WebCore::AccessibilityRenderObject::setIsExpanded): (WebCore::AccessibilityRenderObject::setSelectedRows): (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows): (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren): (WebCore::AccessibilityRenderObject::selectedChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.h:
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
- 2:07 AM Changeset in webkit [52145] by
-
- 8 edits in trunk/WebKitTools
2009-12-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queue sub-commands need --status-host so they can report status
https://bugs.webkit.org/show_bug.cgi?id=32313
Make --status-bot a global option and make
run_bugzilla_tool pass --status-bot to sub-commands.
- Scripts/bugzilla-tool:
- Rename _status to status_bot and make it non-lazy.
- Scripts/modules/commands/queues.py:
- Move status updates out of WorkQueue and into individual queues.
- Scripts/modules/commands/queues_unittest.py:
- Test that --status-host is passed to bugzilla-tool when run as subcommand.
- Scripts/modules/mock_bugzillatool.py:
- Add a MockStatusBot
- Scripts/modules/workqueue.py:
- Remove status_host and work_work_logs_directory callbacks.
- Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches!
- Scripts/modules/workqueue_unittest.py:
- Update unit tests to reflect new callbacks.
- 1:29 AM Changeset in webkit [52144] by
-
- 3 edits in trunk/WebKit/qt
[Qt] Do not disable the inspector on show and hide
https://bugs.webkit.org/show_bug.cgi?id=31851
On Qt/X11 with some window managers the window will be
hidden when switching windows. In this case all the results
are gone when coming back to the window.
Attempt to use the CloseEvent to figure out if the window
was closed and withdrawn as this is more friendly to the
user of the inspector client.
- Api/qwebinspector.cpp:
(QWebInspector::hideEvent):
(QWebInspector::closeEvent):
- Api/qwebinspector.h:
- 1:29 AM Changeset in webkit [52143] by
-
- 2 edits in trunk/WebCore
[Qt] Remove dead code from FontPlatformDataQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=32540
In r51758 the code that used familyNames was removed
and we should remove the creation of the familyNames
as well.
- platform/graphics/qt/FontPlatformDataQt.cpp:
- 12:57 AM Changeset in webkit [52142] by
-
- 2 edits in trunk/WebKitTools
2009-12-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
scm_unittest.py is too slow
https://bugs.webkit.org/show_bug.cgi?id=31818
Now we don't run the SCM unit tests unless we get the --all flag on the
command line. Eric and I were commenting out this test because it was
too painful to run.
- Scripts/run-webkit-unittests:
- 12:17 AM Changeset in webkit [52141] by
-
- 10 edits in trunk
Reviewed by Adam Roben.
WebCore:
WebCore part of <rdar://problem/7173515> Use LOGFONT support in Core
Graphics when available
When using a version of Core Graphics with LOGFONT support, this fixes
<rdar://problem/5764844> First-time launch is painfully slow due to font
plist creation
and <rdar://problem/6576281> 12px synthetic-italics Tahoma text is less
readable in Safari than in Firefox/IE due to poorly-spaced letters
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): No longer call drawGDIGlyphs for stroked text.
- platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): Added a synthesizeItalic parameter. When set to true, if italics are desired but the best match lacks italics, creates and returns a synthetic italics font. (WebCore::FontCache::createFontPlatformData): Ask to synthesize italics if needed.
- platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): Updated an assertion, and changed to create the CGFont from the LOGFONT. (WebCore::createFontCustomPlatformData): Changed cgFont to be a RetainPtr. Do not create a CGFont from the font data if it can be created from the LOGFONT in fontPlatformData().
- platform/graphics/win/FontDatabase.cpp: (WebCore::populateFontDatabase): Avoid font database work if fonts are not going to be looked up by name.
- platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::platformDataInit): Create the CGFont from a LOGFONT based on the HFONT.
WebKitLibraries:
WebKitSystemInterface part of <rdar://problem/7173515> Use LOGFONT support in
Core Graphics when available
- win/include/WebKitSystemInterface/WebKitSystemInterface.h: Declared
wkCanCreateCGFontWithLOGFONT().
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
Dec 14, 2009:
- 11:31 PM Changeset in webkit [52140] by
-
- 12 edits2 adds in trunk
WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-treegrid.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityARIAGrid.h:
(WebCore::AccessibilityARIAGrid::supportsSelectedRows):
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isARIATreeGridRow):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.h:
(WebCore::AccessibilityTable::supportsSelectedRows):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
LayoutTests:
- platform/mac/accessibility/aria-treegrid-expected.txt: Added.
- platform/mac/accessibility/aria-treegrid.html: Added.
- 10:44 PM Changeset in webkit [52139] by
-
- 6 edits in trunk/SunSpider
2009-12-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Some Browser-hosted SunSpider files are not valid HTML5
https://bugs.webkit.org/show_bug.cgi?id=32536
Made various fixes to validate as HTML5 with no warnings (mainly removing bogus
close tags and adding a meta charset declaration).
- hosted/sunspider.html:
- hosted/versions.html:
- resources/TEMPLATE.html:
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html:
- 10:25 PM Changeset in webkit [52138] by
-
- 2 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Unreviewed. Fix failing unittest.
- Scripts/modules/bugzilla_unittest.py:
- 10:24 PM Changeset in webkit [52137] by
-
- 4 edits in trunk/SunSpider
2009-12-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Eric Seidel.
Make sunspider-0.9.1 the default content set (both command-line and hosted)
https://bugs.webkit.org/show_bug.cgi?id=32537
- hosted/sunspider.html: Change default suite link.
- sunspider: Change default suite.
- sunspider-compare-results: Likewise.
- 10:16 PM Changeset in webkit [52136] by
-
- 3 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Kill _create_step_sequence
https://bugs.webkit.org/show_bug.cgi?id=32539
It's cleaner to represent not having these sequences as an empty
sequence instead of None.
- Scripts/modules/commands/download.py:
- Scripts/modules/stepsequence.py:
- 10:00 PM Changeset in webkit [52135] by
-
- 3 edits2 adds in trunk/WebKitTools
2009-12-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move Credential handling out into a separate module
https://bugs.webkit.org/show_bug.cgi?id=32531
- Scripts/modules/bugzilla.py:
- Scripts/modules/credentials.py: Added.
- Scripts/modules/credentials_unittest.py: Added.
- Scripts/run-webkit-unittests:
- 9:53 PM Changeset in webkit [52134] by
-
- 2 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Unreviewed. Address reviewer comments from an earlier patch. I didn't
do this earlier because I was worried about conflicts in dependent
patches.
- Scripts/modules/commands/download.py:
- 9:38 PM Changeset in webkit [52133] by
-
- 3 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Make download commands declarative
https://bugs.webkit.org/show_bug.cgi?id=32469
This patch "properly" factors most of the download commands. These
commands are now largely declarative, which is the final step of this
grand refactoring.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- 9:38 PM Changeset in webkit [52132] by
-
- 2 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Add AbstractPatchSequencingCommand to remove redundant code
https://bugs.webkit.org/show_bug.cgi?id=32468
Redundant code is bad. This patch moves us towards more declarative
commands.
- Scripts/modules/commands/download.py:
- 9:32 PM Changeset in webkit [52131] by
-
- 5 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitApplyingScripts
https://bugs.webkit.org/show_bug.cgi?id=32467
Ah! I've been wanting to do this for a long time. This patch brings
the applying commands into the patch processing fold.
- Scripts/bugzilla-tool:
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/download_unittest.py:
- Scripts/modules/mock_bugzillatool.py:
- 9:31 PM Changeset in webkit [52130] by
-
- 5 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Convert rollout to StepSequence
https://bugs.webkit.org/show_bug.cgi?id=32406
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/download_unittest.py:
- Scripts/modules/mock_bugzillatool.py:
- 9:21 PM Changeset in webkit [52129] by
-
- 5 edits1 delete in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=32464
Removes LandingSequence in favor of StepSequence. This required
changing the Step API slightly to carry a general notion of state
instead of carrying patches specifically.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/landingsequence.py: Removed.
- Scripts/modules/stepsequence.py:
- 7:27 PM Changeset in webkit [52128] by
-
- 4 edits1 delete in trunk/SunSpider
2009-12-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
in-browser SunSpider suffers excessive penalty under power management
https://bugs.webkit.org/show_bug.cgi?id=32505
I have made a few changes to address this:
1) Change how browser-hosted SunSpider loads tests - preload the content and write it in with
document.write to reduce triggering of progress UI.
2) Reduce time between tests to 10ms from 500ms, so that power management doesn't keep the CPU
stepped all the way down the whole time.
3) Run the test cycle an extra time for warmup before the runs that count.
- hosted/sunspider-record-result.js: Removed.
- make-hosted:
- resources/TEMPLATE.html:
- resources/driver-TEMPLATE.html:
- 7:05 PM Changeset in webkit [52127] by
-
- 3 edits4 adds in trunk
<rdar://problem/7460655> REGRESSION (r47255): Content shifted down at software.opensuse.org
https://bugs.webkit.org/show_bug.cgi?id=32382
Reviewed by Darin Adler.
WebCore:
Test: fast/block/float/in-margin.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getClearDelta): Floats that do not intrude into the line (because
they are in the margin) do not need to be cleared.
LayoutTests:
- fast/block/float/in-margin.html: Added.
- platform/mac/fast/block/float/in-margin-expected.checksum: Added.
- platform/mac/fast/block/float/in-margin-expected.png: Added.
- platform/mac/fast/block/float/in-margin-expected.txt: Added.
- 5:14 PM Changeset in webkit [52126] by
-
- 3 edits2 adds in trunk
Pressing backspace inside a table cell erases all empty rows below it.
<rdar://problem/5565461>
https://bugs.webkit.org/show_bug.cgi?id=32526
Reviewed by John Sullivan.
WebCore:
No deletion is performed when the caret selection is on an empty table cell.
Test: editing/deleting/delete-empty-table.html
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Added check for empty table cells in
case of caret selection.
LayoutTests:
- editing/deleting/delete-empty-table-expected.txt: Added.
- editing/deleting/delete-empty-table.html: Added.
- 4:19 PM Changeset in webkit [52125] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Brady Eidson.
Add two http iFrame dynamic form tests to the Windows Skipped
list.
- platform/win/Skipped:
- 2:45 PM Changeset in webkit [52124] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-14 Evan Stade <estade@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=32347
Chromium: Context menu launched by menu key has funky behavior
Make the context menu's position depend on the selection only when an
editable field has focus. Also, don't send multiple context menu events
for a single keypress.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::sendContextMenuEvent):
- 2:38 PM Changeset in webkit [52123] by
-
- 1 edit2 adds in trunk/WebCore
2009-12-14 Andrei Popescu <andreip@google.com>
Reviewed by Darin Adler.
[Android] Android needs ResourceHandle implementation
https://bugs.webkit.org/show_bug.cgi?id=32515
Adds implementation of ResourceHandle on Android.
No new tests needed, this is platform-specific code, so existing
tests are sufficient.
- platform/network/android/ResourceHandleAndroid.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::willLoadFromCache): (WebCore::ResourceHandle::loadsBlocked): (WebCore::SyncLoader::SyncLoader): (WebCore::SyncLoader::~SyncLoader): (WebCore::SyncLoader::didReceiveResponse): (WebCore::SyncLoader::didReceiveData): (WebCore::SyncLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/android/ResourceLoaderAndroid.h: Added. (WebCore::ResourceLoaderAndroid::~ResourceLoaderAndroid): (WebCore::ResourceLoaderAndroid::ResourceLoaderAndroid):
- 2:30 PM Changeset in webkit [52122] by
-
- 2 edits in trunk/WebCore
2009-12-14 Marco Martin <notmart@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
In the Scrollbar painting of the Qt theme integration,
intersects any previous clip rects with the one needed to paint the scrollbar.
This fixes the painting in QGraphicsview, when the parent of the widget that
paints the QWebPage has the QGraphicsItem::ItemClipsChildrenToShape set and
a piece of the scrollbar should be cipped away
https://bugs.webkit.org/show_bug.cgi?id=30366
No new tests.
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint):
- 2:23 PM Changeset in webkit [52121] by
-
- 2 edits in trunk/WebKit/win
Provide working printing support for WinCairo port.
Reviewed by Adam Roben.
- WebFrame.cpp:
(WebFrame::spoolPage): Conditionalize initialization of
PlatformGraphicsContext handling for CG vs. Cairo.
(scaleFactor): Add helper function.
(hdcFromContext): Add helper function.
(WebFrame::drawHeader): Correct Cairo variation.
(WebFrame::drawFooter): Correct Cairo variation.
(WebFrame::spoolPages): Correct Cairo variation.
- 2:17 PM Changeset in webkit [52120] by
-
- 4 edits in trunk/WebCore
2009-12-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
[V8] Generate bindings for trivial indexers.
https://bugs.webkit.org/show_bug.cgi?id=32455
Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm:
Added detecting indexers and generating code for them.
- bindings/v8/V8Collection.h: Removed code that's now generated.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Ditto.
- 2:16 PM Changeset in webkit [52119] by
-
- 2 edits in trunk/LayoutTests
2009-12-14 Kinuko Yasuda <kinuko@chromium.com>
Reviewed by Darin Fisher.
Make changing-frame-hierarchy-in-onload.html less flaky and
platform-independent.
https://bugs.webkit.org/show_bug.cgi?id=32319
- http/tests/navigation/changing-frame-hierarchy-in-onload.html:
- 2:09 PM Changeset in webkit [52118] by
-
- 6 edits in trunk
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Amend the behaviour of DRT::notifyDone to dump only when
the page has finished loading.
This fix permits removal of the following tests from the Qt skipped list:
fast/forms/textarea-linewrap-dynamic.html
fast/forms/textarea-setvalue-submit.html
fast/forms/textarea-hard-linewrap-empty.html
fast/forms/submit-to-url-fragment.html
http/tests/misc/percent-sign-in-form-field-name.html
http/tests/security/escape-form-data-field-names.html
However it also requires the following two to be added to the skipped list:
http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
svg/custom/use-instanceRoot-as-event-target.xhtml
It appears the behaviour of notifyDone was masking problems with these two
tests.
- platform/qt/Skipped:
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Amend the behaviour of DRT::notifyDone to dump only when
the page has finished loading.
This fix permits removal of the following tests from the Qt skipped list:
fast/forms/textarea-linewrap-dynamic.html
fast/forms/textarea-setvalue-submit.html
fast/forms/textarea-hard-linewrap-empty.html
fast/forms/submit-to-url-fragment.html
http/tests/misc/percent-sign-in-form-field-name.html
http/tests/security/escape-form-data-field-names.html
However it also requires the following two to be added to the skipped list:
http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
svg/custom/use-instanceRoot-as-event-target.xhtml
It appears the behaviour of notifyDone was masking problems with these two
tests.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::notifyDone): (LayoutTestController::provisionalLoad):
- DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::resetLoadFinished):
- 1:57 PM Changeset in webkit [52117] by
-
- 4 edits in trunk/LayoutTests
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Bug 32519 - mouseEvent fires mutiple times in
LayoutTests/svg/custom/use-instanceRoot-as-event-target.xhtml
Add test to Qt skipped list (was passing due to bug in DRT, see
https://bugs.webkit.org/show_bug.cgi?id=32437). Updated detail on bug
in gtk and win skipped lists.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 1:47 PM Changeset in webkit [52116] by
-
- 7 edits2 adds in trunk
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=31660
REGRESSION (r49394): Image load event fires before the document fragment is attached.
Test: fast/images/image-load-event-in-fragment.html
We cannot fire load events immediately after parsing a fragment - an element inserted via
innerHTML or equivalent should be reachable via getElementById() by the time its load event
fires.
- dom/Document.cpp: (WebCore::Document::implicitClose): Call dispatchPendingBeforeLoadEvents() and dispatchPendingLoadEvents() individually. I'm not sure why these calls are here, just preserving existing behavior.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write): Load events for elements that have just been parsed cannot be dispatched yet, we should give the elements a chance to be inserted into a document first. There is no compatibility baggage for beforeload, so it seems OK to dispatch it right away.
- loader/ImageLoader.cpp: (WebCore::ImageLoader::dispatchPendingBeforeLoadEvents): (WebCore::ImageLoader::dispatchPendingLoadEvents):
- loader/ImageLoader.h: Separated dispatchPendingEvents() into individual functions for each event kind.
- 1:27 PM Changeset in webkit [52115] by
-
- 3 edits in trunk/WebCore
2009-12-14 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Simon Fraser.
Add FloatQuad::isRectilinear() to check whether it can be represented as FloatRect.
https://bugs.webkit.org/show_bug.cgi?id=30442
This enables optimizations for distinguishing between
arbitrary FloatQuads and rectilinear ones.
- platform/graphics/FloatQuad.cpp: (WebCore::FloatQuad::isRectilinear):
- platform/graphics/FloatQuad.h:
- 1:08 PM Changeset in webkit [52114] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Add two XSS tests that intermittently time out to the Windows
Skipped list.
- platform/win/Skipped:
- 12:57 PM Changeset in webkit [52113] by
-
- 13 edits in trunk
2009-12-14 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
[Qt] Extend basic touch event test with a simple keyboard modifier test.
- fast/events/basic-touch-events-expected.txt:
- fast/events/script-tests/basic-touch-events.js: (singleTouchSequence):
2009-12-14 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
[Qt] Add support for keyboard modifiers to TouchEvent
Similar to other ui events with keyboard state, get the alt, shift,
meta and ctrl modifiers straight from the platform event.
- dom/TouchEvent.cpp: (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::initTouchEvent):
- dom/TouchEvent.h: (WebCore::TouchEvent::create):
- dom/TouchEvent.idl:
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
- platform/PlatformTouchEvent.h: (WebCore::PlatformTouchEvent::PlatformTouchEvent): (WebCore::PlatformTouchEvent::shiftKey): (WebCore::PlatformTouchEvent::ctrlKey): (WebCore::PlatformTouchEvent::altKey): (WebCore::PlatformTouchEvent::metaKey):
- platform/qt/PlatformTouchEventQt.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):
2009-12-14 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
[Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::setTouchModifier): (EventSender::clearTouchPoints): (EventSender::sendTouchEvent):
- DumpRenderTree/qt/EventSenderQt.h:
- 12:49 PM Changeset in webkit [52112] by
-
- 2 edits in trunk/WebCore
2009-12-14 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] crash when clicking "Sign out" in GMail
https://bugs.webkit.org/show_bug.cgi?id=32300
When the ResourceLoader cancels the handle we have to make sure not to access
the resource handle afterwards again.
This complete r29515
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 12:42 PM Changeset in webkit [52111] by
-
- 2 edits in trunk/WebKit/qt
2009-12-14 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216
Refactor tst_qwebelement to remove the qWait()
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::style):
- 12:35 PM Changeset in webkit [52110] by
-
- 2 edits in trunk/WebKit/qt
2009-12-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
Fix the QWebPage inputMethods() autotest after r51758
to compare the Qt::ImFont property's family against an explicitly
previously configured family.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
- 12:28 PM Changeset in webkit [52109] by
-
- 2 edits in trunk/LayoutTests
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
access-control-basic-denied-preflight-cache.html fails manual testing.
LayoutTests/http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
fails manual testing. It passes the automatic layout tests in Qt due to a bug with
notifyDone (see https://bugs.webkit.org/show_bug.cgi?id=32437).
Performing the test manually in QtLauncher shows that an exception is received.
Add access-control-basic-denied-preflight-cache.html to the Qt skipped list.
- platform/qt/Skipped:
- 12:21 PM Changeset in webkit [52108] by
-
- 3 edits in trunk/WebCore
2009-12-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Implement InjectedScript.evaluateOnSelf() that evaluates functions in the InjectedScript context.
https://bugs.webkit.org/show_bug.cgi?id=32517
- inspector/front-end/InjectedScript.js: (InjectedScript.evaluateOnSelf):
- inspector/front-end/InjectedScriptAccess.js:
- 12:13 PM Changeset in webkit [52107] by
-
- 3 edits in trunk/WebCore
2009-12-14 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Darin Adler.
Fix for compilation errors in WML enabled builds.
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::setValueForUser):
- wml/WMLInputElement.h:
- 12:06 PM Changeset in webkit [52106] by
-
- 2 edits in trunk/LayoutTests
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Not reviewed, build fix.
Add missing newline at end of test result.
- platform/mac-tiger/media/video-no-audio-expected.txt:
- 12:01 PM Changeset in webkit [52105] by
-
- 1 edit3 adds in trunk/WebCore
[Android] Android needs ResourceError, ResourceResponse and
ResourceRequest implementation.
https://bugs.webkit.org/show_bug.cgi?id=32522
Patch by Andrei Popescu <andreip@google.com> on 2009-12-14
Reviewed by Darin Adler.
Add implementation of ResourceError, ResourceResponse and ResourceRequest.
No new tests needed, the existing tests should be sufficient.
- platform/network/android/ResourceError.h: Added.
(WebCore::ResourceError::ResourceError):
- platform/network/android/ResourceRequest.h: Added.
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::setUserGesture):
(WebCore::ResourceRequest::getUserGesture):
- platform/network/android/ResourceResponse.h: Added.
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::doUpdateResourceResponse):
- 11:38 AM Changeset in webkit [52104] by
-
- 3 edits in trunk/WebCore
Fix the build.
- page/Geolocation.cpp:
- page/Geolocation.h:
- 11:26 AM Changeset in webkit [52103] by
-
- 24 edits5 adds in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=32499
Add client based Geolocation provider
Reviewed by Dan Bernstein.
Add first cut of a client based Geolocation provider. This is guarded by
ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a
GeolocationControllerClient interface that no-one currently implements,
but will in a subsequent patch.
WebCore:
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- page/Geolocation.cpp:
(WebCore::createGeopositionFromGeolocationPosition):
(WebCore::createPositionErrorFromGeolocationError):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::fatalErrorOccurred):
(WebCore::Geolocation::requestTimedOut):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::handleError):
(WebCore::Geolocation::positionChanged):
(WebCore::Geolocation::makeSuccessCallbacks):
(WebCore::Geolocation::errorOccurred):
(WebCore::Geolocation::geolocationServicePositionChanged):
(WebCore::Geolocation::geolocationServiceErrorOccurred):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
- page/Geolocation.h:
- page/GeolocationController.cpp: Added.
(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::~GeolocationController):
(WebCore::GeolocationController::addObserver):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::errorOccurred):
(WebCore::GeolocationController::lastPosition):
- page/GeolocationController.h: Added.
- page/GeolocationControllerClient.h: Added.
(WebCore::GeolocationControllerClient::~GeolocationControllerClient):
- page/GeolocationError.h: Added.
(WebCore::GeolocationError::):
(WebCore::GeolocationError::create):
(WebCore::GeolocationError::code):
(WebCore::GeolocationError::message):
- page/GeolocationPosition.h: Added.
(WebCore::GeolocationPosition::create):
(WebCore::GeolocationPosition::timestamp):
(WebCore::GeolocationPosition::latitude):
(WebCore::GeolocationPosition::longitude):
(WebCore::GeolocationPosition::accuracy):
(WebCore::GeolocationPosition::altitude):
(WebCore::GeolocationPosition::altitudeAccuracy):
(WebCore::GeolocationPosition::heading):
(WebCore::GeolocationPosition::speed):
(WebCore::GeolocationPosition::canProvideAltitude):
(WebCore::GeolocationPosition::canProvideAltitudeAccuracy):
(WebCore::GeolocationPosition::canProvideHeading):
(WebCore::GeolocationPosition::canProvideSpeed):
(WebCore::GeolocationPosition::GeolocationPosition):
- page/Geoposition.h:
(WebCore::Geoposition::create):
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(WebCore::Page::geolocationController):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
WebKit/gtk:
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
WebKit/win:
- WebView.cpp:
(WebView::initWithFrame):
- 11:10 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 10:45 AM Changeset in webkit [52102] by
-
- 3 edits3 adds in trunk
2009-12-14 Adam Langley <agl@google.com>
Reviewed by Darin Adler.
Test that an image's size is valid before reading it.
Previously, an image that failed to load (m_failed == true) would
trigger an assertion failure when WebKit tried to get its size.
https://bugs.webkit.org/show_bug.cgi?id=32176
http://code.google.com/p/chromium/issues/detail?id=28566
Test: fast/images/size-failure.html
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::createFrameAtIndex):
- 10:40 AM Changeset in webkit [52101] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32524
REGRESSION(52084): fast/dom/prototypes.html failing two CSS tests
Reviewed by Simon Fraser.
- wtf/StdLibExtras.h:
(WTF::bitCount): The original patch put the parentheses in the wrong
place, completely changing the calculation and making it almost always
wrong. Moved the parentheses around the '+' operation, like the original
compiler warning suggested.
- 10:04 AM Changeset in webkit [52100] by
-
- 3 edits2 adds in trunk
<rdar://problem/7458272> REGRESSION (r50470) Reproducible ASSERT in
RenderWidget::setWidgetGeometry()
Reviewed by Darin Adler.
WebCore:
Test: fast/forms/defer-updateFromElement.html
- html/HTMLFormControlElement.cpp:
(WebCore::updateFromElementCallback): Added this post-attach callback
that invokes updateFromElement().
(WebCore::HTMLFormControlElement::recalcStyle): Instead of calling
updateFromElement(), enqueue a post-attach (in this case, post-style
recalc) callback to do it. updateFromElement() can cause the selection
to change, and in turn trigger synchronous layout, so it must not be
called during style recalc.
LayoutTests:
- fast/forms/defer-updateFromElement-expected.txt: Added.
- fast/forms/defer-updateFromElement.html: Added.
- 10:01 AM Changeset in webkit [52099] by
-
- 18 edits in trunk/WebCore
2009-12-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: [regression] inspector deletes nodes when editing css.
Now all the treeoutlines are focusable, sections and their titles
are also focusable. Change contains couple of drive-by fixes such as
canceling of the attribute edit nuking attr info and maintaining proper
selection while deleting nodes.
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.handleShortcut):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._promptKeyDown):
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype._keyDown):
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView): (WebInspector.DatabaseQueryView.prototype._promptKeyDown):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.get defaultFocusedElement): (WebInspector.ElementsPanel.prototype.handleShortcut):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype._keyDown): (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): (WebInspector.ElementsTreeElement.prototype._editingCancelled):
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.get defaultFocusedElement):
- inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement): (WebInspector.ScriptsPanel.prototype.handleShortcut):
- inspector/front-end/SidebarPane.js: (WebInspector.SidebarPane): (WebInspector.SidebarPane.prototype.toggleExpanded): (WebInspector.SidebarPane.prototype._onTitleKeyDown):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.documentCanCopy): (WebInspector.documentCopy): (WebInspector._searchFieldManualFocus): (WebInspector._searchKeyDown): (WebInspector.startEditing.cleanUpAfterEditing): (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
- inspector/front-end/treeoutline.js: (TreeOutline): (TreeOutline._removeChildAtIndex): (TreeOutline.prototype._treeKeyDown): (TreeElement.prototype.deselect):
- inspector/front-end/utilities.js: ():
- 9:46 AM Changeset in webkit [52098] by
-
- 2 edits in trunk/WebKit/win
Change IWebFramePrivate's vtable to be compatible with Safari 4.0.4
Reviewed by Steve Falkenburg.
Fixes <http://webkit.org/b/32433> REGRESSION (r51567): Right click on
a link element crashes WebKit nightly
- Interfaces/IWebFramePrivate.idl: Moved pauseSVGAnimation to the end
of the interface so the vtable that Safari 4.0.4 sees is unchanged.
- 9:43 AM Changeset in webkit [52097] by
-
- 1 edit11 adds in trunk/LayoutTests
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Not reviewed, build fix.
Update Tiger media test results after r52094.
- platform/mac-tiger/accessibility: Added.
- platform/mac-tiger/accessibility/media-element-expected.txt: Added.
- platform/mac-tiger/media/audio-controls-rendering-expected.txt: Added.
- platform/mac-tiger/media/controls-after-reload-expected.txt: Added.
- platform/mac-tiger/media/controls-drag-timebar-expected.txt: Added.
- platform/mac-tiger/media/controls-strict-expected.txt: Added.
- platform/mac-tiger/media/controls-styling-expected.txt: Added.
- platform/mac-tiger/media/video-controls-rendering-expected.txt: Added.
- platform/mac-tiger/media/video-display-toggle-expected.txt: Added.
- platform/mac-tiger/media/video-no-audio-expected.txt: Added.
- platform/mac-tiger/media/video-zoom-controls-expected.txt: Added.
- 9:20 AM Changeset in webkit [52096] by
-
- 3 edits in trunk/WebCore
2009-12-14 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Guard all of JSC's wrapper cache-related members on Document.
- dom/Document.cpp: (WebCore::Document::createWrapperCache): Widened the guards to the whole method.
- dom/Document.h: Added JSC guards to wrapper cache-related members.
- 8:25 AM Changeset in webkit [52095] by
-
- 5 edits2 adds in trunk
AX: there's an infinite loop going on for some webpages - facebook.com
https://bugs.webkit.org/show_bug.cgi?id=32501
Reviewed by Adele Peterson.
WebCore:
The problem is that parentObjectUnignored() cannot be called
while in accessibilityIsIgnored, because it leads to
recursiveness. Specifically, there were checks to determine
if an object was within a ARIA tree. That check should
1) be moved to all platforms, and 2) not call parentObjectUnignored().
Test: accessibility/hang-in-isignored.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isAllowedChildOfTree):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
LayoutTests:
- accessibility/hang-in-isignored-expected.txt: Added.
- accessibility/hang-in-isignored.html: Added.
- 8:16 AM Changeset in webkit [52094] by
-
- 18 edits9 adds in trunk
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
Use MediaControllerThemeQuickTime on Leopard.
- rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
Regenerate layout and pixel test results for the new UI.
- platform/mac-leopard/Skipped:
- platform/mac-leopard/accessibility/media-element-expected.txt:
- platform/mac-leopard/media/audio-controls-rendering-expected.checksum:
- platform/mac-leopard/media/audio-controls-rendering-expected.txt:
- platform/mac-leopard/media/controls-after-reload-expected.checksum: Added.
- platform/mac-leopard/media/controls-after-reload-expected.png: Added.
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- platform/mac-leopard/media/controls-drag-timebar-expected.txt:
- platform/mac-leopard/media/controls-strict-expected.checksum: Added.
- platform/mac-leopard/media/controls-strict-expected.png: Added.
- platform/mac-leopard/media/controls-strict-expected.txt:
- platform/mac-leopard/media/controls-strict-mode-expected.txt: Added.
- platform/mac-leopard/media/controls-styling-expected.checksum: Added.
- platform/mac-leopard/media/controls-styling-expected.png: Added.
- platform/mac-leopard/media/controls-styling-expected.txt:
- platform/mac-leopard/media/video-controls-rendering-expected.checksum:
- platform/mac-leopard/media/video-controls-rendering-expected.txt:
- platform/mac-leopard/media/video-display-toggle-expected.checksum:
- platform/mac-leopard/media/video-display-toggle-expected.txt:
- platform/mac-leopard/media/video-no-audio-expected.checksum: Added.
- platform/mac-leopard/media/video-no-audio-expected.png: Added.
- platform/mac-leopard/media/video-no-audio-expected.txt:
- platform/mac-leopard/media/video-zoom-controls-expected.checksum:
- platform/mac-leopard/media/video-zoom-controls-expected.txt:
- 7:44 AM Changeset in webkit [52093] by
-
- 2 edits in trunk/WebKit/win
Build fix
- WebKit.vcproj/WebKit.vcproj: Added $(DXSDK_DIR)\Lib\x86 to the
libpath for all non-Cairo configurations (it was missing from most of
them).
- 7:38 AM Changeset in webkit [52092] by
-
- 2 edits1 add in trunk/WebCore
Move QuartzCore-related build settings into a vsprops file
Fixes <http://webkit.org/b/32518>
Reviewed by Dan Bernstein.
- WebCore.vcproj/WebCore.vcproj: Let VS reformat the files list, added
WebCoreQuartzCore.vsprops to the non-Cairo configurations, moved all
other QuartzCore-related build settings from here...
- WebCore.vcproj/WebCoreQuartzCore.vsprops: ...to here.
- 7:21 AM Changeset in webkit [52091] by
-
- 3 edits in trunk/WebCore
2009-12-14 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antti Koivisto.
handling scripts can block UI
https://bugs.webkit.org/show_bug.cgi?id=27612
Break execution of external scrips to smaller chunks.
No new tests since no new functionality was introduced.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished): (WebCore::HTMLTokenizer::executeExternalScriptsIfReady): (WebCore::HTMLTokenizer::executeExternalScriptsTimerFired): (WebCore::HTMLTokenizer::continueExecutingExternalScripts):
- html/HTMLTokenizer.h:
- 6:13 AM Changeset in webkit [52090] by
-
- 2 edits in trunk/JavaScriptCore
Unreviewed trivial buildfix.
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-12-14
Fix crosses initialization of usedPrimaryBlocks for JSValue32
- runtime/Collector.cpp:
(JSC::Heap::markConservatively):
- 3:09 AM Changeset in webkit [52089] by
-
- 2 edits in trunk/WebCore
[Qt] Connect QNetworkReply via direct connections.
https://bugs.webkit.org/show_bug.cgi?id=32113
In the past we have switched from auto connections to queued
connections to get some more stability. The problem with the
Queued connections is latency. Even when running simple loading
tests the time it takes to runs highly varies and by using
direct connections these tests produce a stable result.
We will have to look out for crashes coming from within the
QNetworkAccessManager due this patch and address them then.
- 3:03 AM Changeset in webkit [52088] by
-
- 2 edits in trunk/LayoutTests
2009-12-14 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Gustavo Noronha Silva.
media/video-played-collapse.html is failing
https://bugs.webkit.org/show_bug.cgi?id=31434
- platform/gtk/Skipped: Give this test another chance, we believe the bug above has been fixed in a previous commit.
- 2:51 AM Changeset in webkit [52087] by
-
- 3 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
New setting to allow applications to completely supress the
default context menu that is generated by WebKit. This allows them
to still pass the vent to the default handler without needing to
use ugly hacks such as handling populate-popup, and removing all
the items from the default context menu.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event):
- 2:48 AM Changeset in webkit [52086] by
-
- 2 edits in trunk/WebCore
[Qt] QtWebKit should use QImageReader::setQuality(49)
https://bugs.webkit.org/show_bug.cgi?id=30740
Using QImageReader::setQuality(49) will influence the JPEG
decoder of Qt to use the JDCT_IFAST routines for decompressing. This
is showing a 5% improvement in a reduction that decodes all images
used during the page loading test. The libjpeg documentation mentions
that the IFAST routine is not as accurate as other routines but in
our tests we couldn't see a difference.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
- 2:01 AM Changeset in webkit [52085] by
-
- 3 edits in trunk/WebCore
emit volumeChanged and durationChanged upon notification from GStreamer.
- 1:56 AM Changeset in webkit [52084] by
-
- 2 edits in trunk/JavaScriptCore
GCC 4.3.x warning fixed. Suggested parantheses added.
warning: ../../../JavaScriptCore/wtf/StdLibExtras.h:77: warning: suggest parentheses around + or - in operand of &
Reviewed by Simon Hausmann.
- wtf/StdLibExtras.h:
(WTF::bitCount):
- 12:39 AM Changeset in webkit [52083] by
-
- 1 edit2 adds in trunk/LayoutTests
RS by Maciej Stachowiak.
Adding platform specific results for these test as part of reverting changes from http://trac.webkit.org/changeset/49585 to fix:
<rdar://problem/7382815> REGRESSION (4.0.4-TOT): Home photo slider is too narrow at http://www.ziprealty.com/
https://bugs.webkit.org/show_bug.cgi?id=32078
- platform/win/fast/css/large-number-round-trip-expected.txt: Added.
- platform/win/fast/css/opacity-float-expected.txt: Added.
- 12:13 AM Changeset in webkit [52082] by
-
- 33 edits2 adds in trunk
JavaScriptCore: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
Added WeakGCMap to keep WebCore blissfully ignorant about objects that
have become garbage but haven't run their destructors yet.
1% SunSpider speedup.
7.6% v8 speedup (37% splay speedup).
17% speedup on bench-alloc-nonretained.js.
18% speedup on bench-alloc-retained.js.
- API/JSBase.cpp:
(JSGarbageCollect):
- API/JSContextRef.cpp:
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj: Updated for renames and new
files.
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Updated to use the Collector
iterator abstraction.
- jsc.cpp:
(functionGC): Updated for rename.
- runtime/Collector.cpp: Slightly reduced the number of allocations per
collection, so that small workloads only allocate on collector block,
rather than two.
(JSC::Heap::Heap): Updated to use the new allocateBlock function.
(JSC::Heap::destroy): Updated to use the new freeBlocks function.
(JSC::Heap::allocateBlock): New function to initialize a block when
allocating it.
(JSC::Heap::freeBlock): Consolidated the responsibility for running
destructors into this function.
(JSC::Heap::freeBlocks): Updated to use freeBlock.
(JSC::Heap::recordExtraCost): Sweep the heap in this reporting function,
so that allocation, which is more common, doesn't have to check extraCost.
(JSC::Heap::heapAllocate): Run destructors right before recycling a
garbage cell. This has better cache utilization than a separate sweep phase.
(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks): New set of functions for managing the size of
the heap, now that the heap doesn't maintain any information about its
size.
(JSC::isPointerAligned):
(JSC::isHalfCellAligned):
(JSC::isPossibleCell):
(JSC::isCellAligned):
(JSC::Heap::markConservatively): Cleaned up this code a bit.
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells): Some helper functions for examining the the mark
bitmap.
(JSC::Heap::sweep): Simplified this function by using a DeadObjectIterator.
(JSC::Heap::markRoots): Reordered some operations for clarity.
(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics): Rewrote these functions to calculate an object
count on demand, since the heap doesn't maintain this information by
itself.
(JSC::Heap::reset): New function for resetting the heap once we've
exhausted heap space.
(JSC::Heap::collectAllGarbage): This function matches the old collect()
behavior, but it's now an uncommon function used only by API.
- runtime/Collector.h:
(JSC::CollectorBitmap::count):
(JSC::CollectorBitmap::isEmpty): Added some helper functions for managing
the collector mark bitmap.
(JSC::Heap::reportExtraMemoryCost): Changed reporting from cell equivalents
to bytes, so it's easier to understand.
- runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::CollectorHeapIterator):
(JSC::CollectorHeapIterator::operator!=):
(JSC::CollectorHeapIterator::operator*):
(JSC::CollectorHeapIterator::advance):
(JSC::::LiveObjectIterator):
(JSC::::operator):
(JSC::::DeadObjectIterator):
(JSC::::ObjectIterator): New iterators for encapsulating details about
heap layout, and what's live and dead on the heap.
- runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength): Delay reporting extra cost until
we're fully constructed, so the heap mark phase won't visit us in an
invalid state.
- runtime/JSCell.h:
(JSC::JSCell::):
(JSC::JSCell::createDummyStructure):
(JSC::JSCell::JSCell):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h: Added a dummy cell to simplify allocation logic.
- runtime/JSString.h:
(JSC::jsSubstring): Don't report extra cost for substrings, since they
share a buffer that's already reported extra cost.
- runtime/Tracing.d:
- runtime/Tracing.h: Changed these dtrace hooks not to report object
counts, since they're no longer cheap to compute.
- runtime/UString.h: Updated for renames.
- runtime/WeakGCMap.h: Added.
(JSC::WeakGCMap::isEmpty):
(JSC::WeakGCMap::uncheckedGet):
(JSC::WeakGCMap::uncheckedBegin):
(JSC::WeakGCMap::uncheckedEnd):
(JSC::::get):
(JSC::::take):
(JSC::::set):
(JSC::::uncheckedRemove): Mentioned above.
- wtf/StdLibExtras.h:
(WTF::bitCount): Added a bit population count function, so the heap can
count live objects to fulfill statistics questions.
JavaScriptGlue: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
- JavaScriptGlue.cpp:
(JSCollect): Updated for rename. Fixed a bug where JSGlue would not check
to avoid nested GC calls.
WebCore: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
- ForwardingHeaders/runtime/WeakGCMap.h: Added.
- bindings/js/GCController.cpp:
(WebCore::collect):
(WebCore::GCController::gcTimerFired):
(WebCore::GCController::garbageCollectNow): Updated for rename.
- bindings/js/JSDOMBinding.cpp:
(WebCore::removeWrappers):
(WebCore::hasCachedDOMObjectWrapperUnchecked):
(WebCore::hasCachedDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapperUnchecked):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):
- bindings/js/JSDOMBinding.h: Changed DOM wrapper maps to be WeakGCMaps.
Don't ASSERT that an item must be in the WeakGCMap when its destructor
runs, since it might have been overwritten in the map first.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS): Changed Document from a DOM object wrapper to a DOM node
wrapper, to simplify some code.
- bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
(WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper):
- bindings/js/JSInspectorCallbackWrapper.cpp: Use a WeakGCMap for these
wrappers.
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren): Updated for WeakGCMap and Document using
a DOM node wrapper instead of a DOM object wrapper.
- bindings/js/JSSVGPODTypeWrapper.h:
(WebCore::JSSVGDynamicPODTypeWrapperCache::wrapperMap):
(WebCore::JSSVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
(WebCore::JSSVGDynamicPODTypeWrapperCache::forgetWrapper):
(WebCore::::~JSSVGDynamicPODTypeWrapper): Shined a small beam of sanity light
on this code. Use hashtable-based lookup in JSSVGPODTypeWrapper.h instead
of linear lookup through iteration, since that's what hashtables were
invented for. Make JSSVGPODTypeWrapper.h responsible for reomving itself
from the table, instead of its JS wrapper, to decouple these objects from
GC, and because these objects are refCounted, not solely owned by their
JS wrappers.
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.h: Adopted changes above.
