Context Navigation

(PrintWebUIDelegate::PrintWebUIDelegate):
(PrintWebUIDelegate::createWebViewWithRequest):
(PrintWebUIDelegate::webViewShow):
(PrintWebUIDelegate::webViewClose):
(PrintWebUIDelegate::webViewFocus):
(PrintWebUIDelegate::webViewUnfocus):
(PrintWebUIDelegate::webViewFirstResponder):
(PrintWebUIDelegate::makeFirstResponder):
(PrintWebUIDelegate::setStatusText):
(PrintWebUIDelegate::webViewStatusText):
(PrintWebUIDelegate::webViewAreToolbarsVisible):
(PrintWebUIDelegate::setToolbarsVisible):
(PrintWebUIDelegate::webViewIsStatusBarVisible):
(PrintWebUIDelegate::setStatusBarVisible):
(PrintWebUIDelegate::webViewIsResizable):
(PrintWebUIDelegate::setResizable):
(PrintWebUIDelegate::setFrame):
(PrintWebUIDelegate::webViewFrame):
(PrintWebUIDelegate::setContentRect):
(PrintWebUIDelegate::webViewContentRect):
(PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage):
(PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage):
(PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt):
(PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage):
(PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener):
(PrintWebUIDelegate::mouseDidMoveOverElement):
(PrintWebUIDelegate::contextMenuItemsForElement):
(PrintWebUIDelegate::validateUserInterfaceItem):
(PrintWebUIDelegate::shouldPerformAction):
(PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo):
(PrintWebUIDelegate::willPerformDragDestinationAction):
(PrintWebUIDelegate::dragSourceActionMaskForPoint):
(PrintWebUIDelegate::willPerformDragSourceAction):
(PrintWebUIDelegate::contextMenuItemSelected):
(PrintWebUIDelegate::hasCustomMenuImplementation):
(PrintWebUIDelegate::trackCustomPopupMenu):
(PrintWebUIDelegate::measureCustomMenuItem):
(PrintWebUIDelegate::drawCustomMenuItem):
(PrintWebUIDelegate::addCustomMenuDrawingData):
(PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
(PrintWebUIDelegate::canTakeFocus):
(PrintWebUIDelegate::takeFocus):
(PrintWebUIDelegate::registerUndoWithTarget):
(PrintWebUIDelegate::removeAllActionsWithTarget):
(PrintWebUIDelegate::setActionTitle):
(PrintWebUIDelegate::undo):
(PrintWebUIDelegate::redo):
(PrintWebUIDelegate::canUndo):
(PrintWebUIDelegate::canRedo):
(PrintWebUIDelegate::printFrame):
(PrintWebUIDelegate::ftpDirectoryTemplatePath):
(PrintWebUIDelegate::webViewHeaderHeight):
(PrintWebUIDelegate::webViewFooterHeight):
(PrintWebUIDelegate::drawHeaderInRect):
(PrintWebUIDelegate::drawFooterInRect):
(PrintWebUIDelegate::canRunModal):
(PrintWebUIDelegate::createModalDialog):
(PrintWebUIDelegate::runModal):
(PrintWebUIDelegate::isMenuBarVisible):
(PrintWebUIDelegate::setMenuBarVisible):
(PrintWebUIDelegate::runDatabaseSizeLimitPrompt):
(PrintWebUIDelegate::paintCustomScrollbar):
(PrintWebUIDelegate::paintCustomScrollCorner):

WinLauncher/WinLauncher.cpp: Add new UI delegate for print support.

(WinLauncherWebHost::updateAddressBar): check-webkit-style fixes.
(WinLauncherWebHost::QueryInterface): check-webkit-style fixes.
(WinLauncherWebHost::AddRef): check-webkit-style fixes.
(WinLauncherWebHost::Release): check-webkit-style fixes.
(resizeSubViews): check-webkit-style fixes.
(_tWinMain): check-webkit-style fixes.
(MyRegisterClass): check-webkit-style fixes.
(InitInstance): check-webkit-style fixes.
(AbortProc): New print support function.
(getPrinterDC): New print support function.
(initDocStruct): New print support function.
(PrintView): New printing implementation.
(WndProc): Add support for printing.
(MyEditProc): check-webkit-style fixes.
(About): check-webkit-style fixes.
(loadURL): check-webkit-style fixes.

WinLauncher/WinLauncher.h:

(WinLauncherWebHost::WinLauncherWebHost):
(WinLauncherWebHost::didStartProvisionalLoadForFrame):
(WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
(WinLauncherWebHost::didFailProvisionalLoadWithError):
(WinLauncherWebHost::didCommitLoadForFrame):
(WinLauncherWebHost::didReceiveTitle):
(WinLauncherWebHost::didReceiveIcon):
(WinLauncherWebHost::didFinishLoadForFrame):
(WinLauncherWebHost::didFailLoadWithError):
(WinLauncherWebHost::didChangeLocationWithinPageForFrame):
(WinLauncherWebHost::willPerformClientRedirectToURL):
(WinLauncherWebHost::didCancelClientRedirectForFrame):
(WinLauncherWebHost::willCloseFrame):
(WinLauncherWebHost::windowScriptObjectAvailable):

WinLauncher/WinLauncher.rc: Add menu entry for printing.
WinLauncher/WinLauncher.vcproj: Add new files.
WinLauncher/resource.h: Add menu entry for printing.

7:30 PM Changeset in webkit [52399] by ukai@chromium.org

6 edits in trunk

2009-12-19 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Invalid url should raise SYNTAX_ERR exception.
https://bugs.wbekit.org/show_bug.cgi?id=32700

websocket/tests/bad-sub-protocol-expected.txt: add CONSOLE MESSAGEs
websocket/tests/script-tests/url-parsing.js: add invalid url tests. Also changed url from ws://127.0.0.1/ to ws://127.0.0.1:8880/websocket/tests/simple to make it sure no errors on console message for these tests by not receiving unexpected response from 127.0.0.1:80.
websocket/tests/url-parsing-expected.txt:

2009-12-19 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700

Check url is valid in WebSocket::connect.
Also log the detailed reason of websocket failures to console.

websockets/WebSocket.cpp: (WebCore::WebSocket::connect):

6:40 PM Changeset in webkit [52398] by abarth@webkit.org

3 edits in trunk/WebKitTools

2009-12-19 Adam Barth <abarth@webkit.org>

Unreviewed. Tweak the CSS to make the dashboard prettier.

QueueStatusServer/stylesheets/dashboard.css:
QueueStatusServer/templates/dashboard.html:

6:32 PM Changeset in webkit [52397] by mitz@apple.com

2 edits in trunk/WebCore

REGRESSION: Up/down arrow keys do not step numeric CSS property values
https://bugs.webkit.org/show_bug.cgi?id=32776

Reviewed by Darin Adler.

inspector/front-end/inspector.js:

(WebInspector.documentKeyDown): Call the focused element’s
handleKeyEvent method.

5:37 PM Changeset in webkit [52396] by abarth@webkit.org

8 edits
3 moves
6 adds in trunk/WebKitTools

2009-12-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

QueueStatusServer needs a human readable dashboard
https://bugs.webkit.org/show_bug.cgi?id=32769

Here is a first cut at the dashboard. There's a lot left to do.

QueueStatusServer/filters/webkit_extras.py:
QueueStatusServer/handlers/dashboard.py: Added.
QueueStatusServer/handlers/patchstatus.py:
QueueStatusServer/handlers/recentstatus.py:
QueueStatusServer/handlers/showresults.py:
QueueStatusServer/handlers/statusbubble.py:
QueueStatusServer/handlers/updatestatus.py:
QueueStatusServer/main.py:
QueueStatusServer/model/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py.
QueueStatusServer/stylesheets/dashboard.css: Added.
QueueStatusServer/templates/dashboard.html: Added.
QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html.
QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html.

5:30 PM BuildingOnWindows edited by dbates@webkit.org

Add notice of change made in changeset 51399 that requires Safari … (diff)

1:58 PM Changeset in webkit [52395] by eric@webkit.org

5 edits in trunk/WebCore

2009-12-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738

This patch makes SVG Masking faster. At the moment we create a new ImageBuffer
and copy the complete pixel array. That is rather inefficient. This patch
uses the mask image directly.
It also bounds the direct pixel manipultation to the viewable area to minimize
the calculation of the mask.

No change in functionality. So no new test.

svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
svg/SVGMaskElement.h:
svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
svg/graphics/SVGResourceMasker.h:

1:35 PM Changeset in webkit [52394] by eric@webkit.org

3 edits
4 adds in trunk

2009-12-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010

Tests the right order of filter and clipper/masker aplied to a SVG
object.

platform/mac/svg/filters/filter-clip-expected.checksum: Added.
platform/mac/svg/filters/filter-clip-expected.png: Added.
platform/mac/svg/filters/filter-clip-expected.txt: Added.
svg/filters/filter-clip.svg: Added.

2009-12-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010

The right ordering for applying effects on objects in SVG is filters,
clipper/masker and opacity. This patch fixes the order of filter and
clipper/masker. Opacity and marker need another test.
This change is according to the SVG Specification:
http://www.w3.org/TR/SVG11/render.html#Elements

Test: svg/filters/filter-clip.svg

rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):

12:53 PM Changeset in webkit [52393] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-12-19 Daniel Bates <dbates@webkit.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=32462

Added --inspector-frontend flag to build-webkit to copy any changes
to the inspector front-end files to the built WebCore framework. This
will make inspector development more consistent with the rest of
WebKit development.

Scripts/build-webkit:
Scripts/webkitdirs.pm:

10:55 AM Changeset in webkit [52392] by eric@webkit.org

2 edits in trunk/WebCore

2009-12-19 Evan Martin <evan@chromium.org>

Reviewed by Gustavo Noronha Silva.

Revert my attempt at making --disable-geolocation work; it is
more complicated than I anticipated. (It passed on the build bots
because they build with --enable-geolocation.)

GNUmakefile.am:

10:52 AM Changeset in webkit [52391] by otte@webkit.org

2 adds in trunk/LayoutTests/platform/gtk/svg/css

add forgotten file

10:45 AM Changeset in webkit [52390] by otte@webkit.org

1 edit in trunk/LayoutTests/ChangeLog

Rebaselined test after revision 52335.

10:37 AM Changeset in webkit [52389] by eric@webkit.org

4 edits
2 adds in trunk

2009-12-19 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Tests for https://bugs.webkit.org/show_bug.cgi?id=28153
can't middle-button paste within a single window

LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste-expected.txt: Added
LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste.html: Adeed

2009-12-19 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Fixed the problem when pasting in the same window with the
middle-button, now we store a reference to the range instead of
requesting it every time, and we do not release it until the
clipboard is requested.
https://bugs.webkit.org/show_bug.cgi?id=28153

WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:
WebKit/gtk/WebCoreSupport/EditorClientGtk.h:

10:30 AM Changeset in webkit [52388] by eric@webkit.org

3 edits
3 adds in trunk

2009-12-19 MORITA Hajime <morrita@gmail.com>

Reviewed by Darin Adler.

WebCore::Range::surroundContents NULL pointer crash.

https://bugs.webkit.org/show_bug.cgi?id=31684

fast/dom/Range/31684-expected.txt: Added.
fast/dom/Range/31684.html: Added.
fast/dom/Range/script-tests/31684.js: Added.

2009-12-19 MORITA Hajime <morrita@gmail.com>

Reviewed by Darin Adler.

WebCore::Range::surroundContents NULL pointer crash.

https://bugs.webkit.org/show_bug.cgi?id=31684

Test: fast/dom/Range/31684.html

dom/Range.cpp: (WebCore::Range::surroundContents): throw exception when parentOfNewParent->parentNode() is NULL.

10:24 AM Changeset in webkit [52387] by kov@webkit.org

2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

Protect download objects when reporting errors, to make sure the
download stays alive between the status change notification, and
the error signal emission.

webkit/webkitdownload.cpp:

(webkit_download_error):

10:08 AM Changeset in webkit [52386] by christian@webkit.org

2 edits in trunk/WebCore

2009-12-19 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

Don't use an icon for all spelling guess menu items.

platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):

9:23 AM Changeset in webkit [52385] by abarth@webkit.org

3 edits in trunk/WebKitTools

2009-12-19 Adam Barth <abarth@webkit.org>

Unreviewed fixes for me being terrible at python.

Scripts/modules/bugzilla.py:
Scripts/run-webkit-unittests:

8:24 AM Changeset in webkit [52384] by kov@webkit.org

2 edits in trunk/WebCore

2009-12-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Missing \.

GNUmakefile.am:

7:16 AM Changeset in webkit [52383] by eric@webkit.org

2 edits in trunk

2009-12-19 Evan Martin <evan@chromium.org>

Reviewed by Gustavo Noronha Silva.

Add a couple of WebKitGtk files to .gitignore.

.gitignore:

3:52 AM Changeset in webkit [52382] by eric@webkit.org

2 edits in trunk/WebCore

2009-12-19 Evan Martin <evan@chromium.org>

Reviewed by Gustavo Noronha Silva.

Make --disable-geolocation and --disable-svg work, by conditionally
building the relevant files.

GNUmakefile.am:

Dec 18, 2009:

11:14 PM Changeset in webkit [52381] by abarth@webkit.org

2 edits
9 adds
1 delete in trunk/WebKitTools

2009-12-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Split QueueStatus server into modules
https://bugs.webkit.org/show_bug.cgi?id=32768

One monolithic file is no good.

QueueStatusServer/app.yaml:
QueueStatusServer/handlers/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
QueueStatusServer/handlers/patchstatus.py: Added.
QueueStatusServer/handlers/recentstatus.py: Added.
QueueStatusServer/handlers/showresults.py: Added.
QueueStatusServer/handlers/statusbubble.py: Added.
QueueStatusServer/handlers/updatestatus.py: Added.
QueueStatusServer/main.py: Added.
QueueStatusServer/model.py: Added.
QueueStatusServer/queue_status.py: Removed.

11:12 PM Changeset in webkit [52380] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2009-12-18 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

[Chromium] Eliminate redundant data copy in GraphicsContext3D readback
https://bugs.webkit.org/show_bug.cgi?id=32763

Eliminated useless creation of a CGBitmapContext and from there a
CGImage. Now create CGImage directly from data. Also changed
readPixels parameters and CGImage alpha info to try to avoid byte
swapping, and disabled interpolation when drawing the GL content.
Some test cases run twice as fast with these changes, though more
work is needed to achieve desired performance.

No test case; performance optimization only. Ran WebGL demos from
Khronos site to verify changes.

src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::beginPaint):

10:40 PM Changeset in webkit [52379] by eric@webkit.org

2 edits in trunk/WebCore

2009-12-18 Peter Kasting <pkasting@google.com>

Reviewed by Simon Fraser.

Add a comment about some confusing code that otherwise would look like
it might be a bug.
https://bugs.webkit.org/show_bug.cgi?id=32534

rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):

10:33 PM Changeset in webkit [52378] by abarth@webkit.org

3 edits
2 moves in trunk/WebKitTools

2009-12-18 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

Renamed WorkQueue to QueueEngine. WorkQueue is not a queue.

Scripts/modules/commands/queues.py:
Scripts/modules/queueengine.py: Added.
Scripts/modules/queueengine_unittest.py: Added.
Scripts/modules/stepsequence.py:
Scripts/modules/workqueue.py: Removed.
Scripts/modules/workqueue_unittest.py: Removed.

10:05 PM Changeset in webkit [52377] by abarth@webkit.org

4 edits in trunk/WebKitTools

2009-12-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add watches for EWS
https://bugs.webkit.org/show_bug.cgi?id=32767

dglazkov wanted to be added.

Scripts/modules/bugzilla.py:
Scripts/modules/commands/early_warning_system.py:
Scripts/modules/commands/queues.py:

10:02 PM Changeset in webkit [52376] by mitz@apple.com

2 edits in trunk/WebKit

Updated localizable strings after r52368

English.lproj/Localizable.strings:

9:14 PM Changeset in webkit [52375] by Nikolas Zimmermann

2 edits in trunk/WebCore

2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Messed up the XCode file, trying to fix.

WebCore.xcodeproj/project.pbxproj:

8:44 PM Changeset in webkit [52374] by Nikolas Zimmermann

2 edits in trunk/WebCore

2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed, fix typos in WebCore.xcodeproj.

WebCore.xcodeproj/project.pbxproj:

8:34 PM Changeset in webkit [52373] by Nikolas Zimmermann

26 edits in trunk/WebCore

2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

SVGAngle / SVGPreserveAspectRatio should be POD types
https://bugs.webkit.org/show_bug.cgi?id=32758

Convert SVGAngle / SVGPreserveAspectRatio to be non-refcounted types, just
like it has been done for SVGMatrix / SVGLength before.

This patch prepares removing the special DOMObjectWithSVGContext hack.
No change in functionality, thus no new tests.

6:34 PM Changeset in webkit [52372] by dumi@chromium.org

2 edits in trunk/WebCore

Chromium build fix, no review.

storage/chromium/DatabaseTrackerChromium.cpp:

6:04 PM Changeset in webkit [52371] by bfulgham@webkit.org

2 edits in trunk/WebCore

Build fix, no review.

platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::createFontPlatformData): Correct my typo

on the CG build.

6:03 PM Changeset in webkit [52370] by dumi@chromium.org

2 edits in trunk/WebCore

Make DatabaseTrackerChromium::removeOpenDatabase() send and IPC on
the main thread when a database is being closed.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32627

storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::removeOpenDatabaseOnMainThread):
(WebCore::DatabaseTracker::removeOpenDatabase):

5:59 PM Changeset in webkit [52369] by bfulgham@webkit.org

3 edits in trunk/WebCore

Build fix, no review.

page/win/FrameCairoWin.cpp: Add missing include.
platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::createFontPlatformData): Conditionalize

Safari-only call.

5:56 PM Changeset in webkit [52368] by weinig@apple.com

8 edits
5 adds in trunk/WebKit

Add Mac WebKit side of the client based geolocation provider.

Reviewed by Dan Bernstein.

WebKit:

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Misc/WebKitErrors.m:

(registerErrors): Add Geolocation errors.

Misc/WebKitErrorsPrivate.h:
WebCoreSupport/WebGeolocationControllerClient.h: Added.

(WebGeolocationControllerClient::webView):

WebCoreSupport/WebGeolocationControllerClient.mm: Added.

(WebGeolocationControllerClient::WebGeolocationControllerClient):
(WebGeolocationControllerClient::startUpdating):
(WebGeolocationControllerClient::stopUpdating):
(WebGeolocationControllerClient::lastPosition):
Add implementation of the WebGeolocationControllerClient.

WebView/WebGeolocationPosition.h: Added.
WebView/WebGeolocationPosition.mm: Added.

(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(core):
(-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):

WebView/WebGeolocationPositionInternal.h: Added.

Add an Objective-C wrapper for GeolocationPosition.

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Set the GeolocationControllerClient.
(-[WebView _setGeolocationProvider:]): Set the GeolocationProvider
(-[WebView _geolocationProvider]): Return the GeolocationProvider.
(-[WebView _geolocationDidChangePosition:]): Notify WebCore that the position changed.
(-[WebView _geolocationDidFailWithError:]): Notify WebCore that an error occured.

WebView/WebViewData.h:
WebView/WebViewPrivate.h:

5:27 PM Changeset in webkit [52367] by dumi@chromium.org

2 edits in trunk/WebCore

Move some code related to database closing from the destructor to
the close() method. This would allow us to do things such as post
tasks to other threads when a database closes, which cannot be
done now, because we cannot increment the ref count to a database
object when we're in its destructor.

Reviewed by Dmitry Titov.

https://bugs.webkit.org/show_bug.cgi?id=32626

storage/Database.cpp:

(WebCore::Database::~Database):
(WebCore::Database::close):

4:47 PM Changeset in webkit [52366] by eric@webkit.org

3 edits in trunk/WebKit/chromium

2009-12-18 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Chromium build fix
https://bugs.webkit.org/show_bug.cgi?id=32756

public/WebAccessibilityRole.h: (WebKit::):
src/AssertMatchingEnums.cpp:

4:40 PM Changeset in webkit [52365] by mrowe@apple.com

2 edits in tags/Safari-532.7.1/WebKit/mac

Merge r52344.

4:40 PM Changeset in webkit [52364] by mrowe@apple.com

2 edits in tags/Safari-532.7.1/WebKit/mac

Merge r52342.

4:40 PM Changeset in webkit [52363] by mrowe@apple.com

4 edits in tags/Safari-532.7.1/WebKit/mac

Merge r52338.

4:40 PM Changeset in webkit [52362] by mrowe@apple.com

7 edits in tags/Safari-532.7.1/WebKit

Merge r52336.

4:40 PM Changeset in webkit [52361] by mrowe@apple.com

4 edits in tags/Safari-532.7.1/WebCore

Merge r52331.

4:40 PM Changeset in webkit [52360] by mrowe@apple.com

2 edits in tags/Safari-532.7.1/WebCore

Merge r52330.

4:40 PM Changeset in webkit [52359] by mrowe@apple.com

10 edits in tags/Safari-532.7.1

Merge r52325.

4:39 PM Changeset in webkit [52358] by mrowe@apple.com

4 edits in tags/Safari-532.7.1

Merge r52298.

4:39 PM Changeset in webkit [52357] by mrowe@apple.com

4 edits in tags/Safari-532.7.1

Versioning.

4:33 PM Changeset in webkit [52356] by eric@webkit.org

2 edits in trunk/WebKit/mac

2009-12-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(52325) Chromium build broken due to link failure
https://bugs.webkit.org/show_bug.cgi?id=32753

WebCoreSupport/WebSystemInterface.m:
- Chromium Mac builds use this file, but do not enable Pre-compiled Header (PCH) files so that Chromium build bots can take advantage of the faster distcc 3. Eventually all mac builds will likely use distcc, but for now we'll add Platform.h here and document its usage so it's not removed by accident.

4:29 PM Changeset in webkit [52355] by eric@webkit.org

10 edits in trunk/JavaScriptCore

2009-12-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Move some build decisions from Qt build system into source files
https://bugs.webkit.org/show_bug.cgi?id=31956

JavaScriptCore.pri: Compile files unconditionally
jit/ExecutableAllocatorPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
jit/ExecutableAllocatorWin.cpp: Guard with PLATFORM(WIN_OS)
runtime/MarkStackPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
runtime/MarkStackSymbian.cpp: Guard with PLATFORM(SYMBIAN)
runtime/MarkStackWin.cpp: Guard with PLATFORM(WIN_OS)
wtf/Platform.h: Guard ENABLE_JSC_MULTIPLE_THREADS with ENABLE_SINGLE_THREADED for the Qt port
wtf/ThreadingNone.cpp: Guard with ENABLE(SINGLE_THREADED)
wtf/qt/ThreadingQt.cpp: Guard with !ENABLE(SINGLE_THREADED)

4:22 PM Changeset in webkit [52354] by Simon Fraser

3 edits
2 adds in trunk

2009-12-18 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Crash when accessing webkitTransition property after setting webkitTransitionProperty with invalid value.
https://bugs.webkit.org/show_bug.cgi?id=31559

Fix an array bounds error when accessing the CSS value for a shorthand property that takes
a comma-separated list, after the list for one of the component properties has been set to a different length.

Test: fast/css/shorthand-mismatched-list-crash.html

css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):

4:09 PM Changeset in webkit [52353] by mrowe@apple.com

1 copy in tags/Safari-532.7.1

New tag.

4:05 PM Changeset in webkit [52352] by jhoneycutt@apple.com

4 edits
2 adds in trunk

REGRESSION(r52233): MSAA: Accessibility role of lists is wrong

https://bugs.webkit.org/show_bug.cgi?id=32736

Reviewed by Adam Roben.

WebCore:

Test: platform/win/accessibility/list-role.html

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::roleValueForMSAA):
Return roleValue(), rather than m_role, as subclasses may override it.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::roleValueForMSAA):
Fallback to roleValue(), rather than m_role, as it may be overriden.

LayoutTests:

platform/win/accessibility/list-role-expected.txt: Added.
platform/win/accessibility/list-role.html: Added.

Verify that lists return the "list" role.

4:05 PM Changeset in webkit [52351] by jhoneycutt@apple.com

6 edits
2 adds in trunk

MSAA: Accessibility role of list items is wrong

https://bugs.webkit.org/show_bug.cgi?id=32688

Reviewed by Adam Roben.

WebCore:

Test: platform/win/accessibility/list-item-role.html

accessibility/AccessibilityObject.h:

(WebCore::):
Add a ListItemRole to the enum.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::msaaRoleForRenderer):
Return the role for the RenderObject, or UnknownRole if unknown.
(WebCore::AccessibilityRenderObject::roleValueForMSAA):
Call msaaRoleForRenderer() to get the role. If it is UnknownRole, fall
back to m_role.

WebKit/win:

AccessibleBase.cpp:

(MSAARole):
Make the WebCore list item role map to the MSAA list item role.

LayoutTests:

platform/win/accessibility/list-item-role-expected.txt: Added.
platform/win/accessibility/list-item-role.html: Added.

Verify that the list item role is "list item".

4:05 PM Changeset in webkit [52350] by jhoneycutt@apple.com

3 edits
2 adds in trunk

MSAA: Accessibility role of list markers is wrong

https://bugs.webkit.org/show_bug.cgi?id=32687

Reviewed by Adam Roben.

WebKit/win:

AccessibleBase.cpp:

(MSAARole):
Make the WebCore list marker role map to the MSAA static text role.

LayoutTests:

platform/win/accessibility/list-marker-role-expected.txt: Added.
platform/win/accessibility/list-marker-role.html: Added.

Verify that the list marker role is "text".

4:00 PM Changeset in webkit [52349] by Simon Fraser

2 edits in trunk/WebCore

2009-12-18 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe.

Remove WebCore.ClientBasedGeolocation.exp from Sources, and remove two IDL files from Resources.

WebCore.xcodeproj/project.pbxproj:

3:57 PM Changeset in webkit [52348] by bweinstein@apple.com

1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Build fix part II, this time it's personal.x

3:46 PM Changeset in webkit [52347] by bweinstein@apple.com

1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

First step at a Windows build fix, get it to link JavaScriptCore. Might fail later.

2:59 PM Changeset in webkit [52346] by barraclough@apple.com

13 edits in trunk/JavaScriptCore

Add createNonCopying method to UString to make replace constructor passed bool,
to make behaviour more explicit. Add createFromUTF8 to UString (wrapping method
on UString::Rep), since other cases of transliteration (e.g. from ascii) are
performed in UString constructors. Add/use setHash & size() accessors on Rep,
rather than accessing _hash/len directly.

Reviewed by Sam Weinig.

API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass):

API/OpaqueJSString.cpp:

(OpaqueJSString::ustring):

JavaScriptCore.exp:
runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

runtime/Identifier.cpp:

(JSC::Identifier::equal):
(JSC::CStringTranslator::translate):
(JSC::UCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):

runtime/JSString.cpp:

(JSC::JSString::resolveRope):

runtime/JSString.h:

(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):

runtime/StringBuilder.h:

(JSC::StringBuilder::release):

runtime/StringConstructor.cpp:

(JSC::stringFromCharCodeSlowCase):

runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):

runtime/UString.cpp:

(JSC::UString::UString):
(JSC::UString::createNonCopying):
(JSC::UString::createFromUTF8):

runtime/UString.h:

(JSC::UString::Rep::setHash):
(JSC::UString::~UString):
(JSC::makeString):

2:51 PM Changeset in webkit [52345] by weinig@apple.com

6 edits
1 add in trunk/WebCore

Fix mac Geolocation build.

DerivedSources.make:
WebCore.ClientBasedGeolocation.exp: Added.
WebCore.xcodeproj/project.pbxproj:
page/Geolocation.h:
page/GeolocationError.h:

(WebCore::GeolocationError::GeolocationError):

page/GeolocationPosition.h:

2:44 PM Changeset in webkit [52344] by weinig@apple.com

2 edits in trunk/WebKit/mac

Fix preference key name.

Reviewed by Anders Carlsson.

WebView/WebPreferenceKeysPrivate.h:

2:18 PM Changeset in webkit [52343] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Changed Register constructors to assignment operators, to streamline
moving values into registers. (In theory, there's no difference between
the two, since the constructor should just inline away, but there seems
to be a big difference in the addled mind of the GCC optimizer.)

Reviewed by Cameron Zwarich and Gavin Barraclough.

In the interpreter, this is a 3.5% SunSpider speedup and a 1K-2K
reduction in stack usage per privateExecute stack frame.

interpreter/CallFrame.h:

(JSC::ExecState::setCalleeArguments):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setScopeChain):
(JSC::ExecState::init):
(JSC::ExecState::setArgumentCount):
(JSC::ExecState::setCallee):
(JSC::ExecState::setCodeBlock): Added a little bit of casting so these
functions could use the new Register assignment operators.

interpreter/Register.h:

(JSC::Register::withInt):
(JSC::Register::Register):
(JSC::Register::operator=): Swapped in assignment operators for constructors.

2:05 PM Changeset in webkit [52342] by andersca@apple.com

2 edits in trunk/WebKit/mac

Pass preference to plug-in host.

Reviewed by Sam Weinig.

Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost):

1:57 PM Changeset in webkit [52341] by bweinstein@apple.com

5 edits
6 adds in trunk

Fixes <http://webkit.org/b/32613>.
REGRESSION (r52008): Middle-clicking on a linked image starts a pan scroll,
but should follow the link instead.

Reviewed by Adam Roben.

WebCore:

The node itself isn't the only possible node that can be a link (that was the
original check), any of its ancestors could be links as well, we need to climb
up the tree to see. Created a new function (enclosingAnchorNode), that finds a
node's enclosing anchor element (if it exists), that we can share between RenderLayer
and Node, and also added tests that test pan scrolling behavior in image maps.

Tests: platform/win/fast/events/panScroll-image-no-scroll.html

platform/win/fast/events/panScroll-imageMap-href-no-scroll.html
platform/win/fast/events/panScroll-imageMap-noHref-scroll.html

dom/Node.cpp:

(WebCore::Node::enclosingAnchorNode):
(WebCore::Node::defaultEventHandler):

dom/Node.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

LayoutTests:

Added tests that test pan scrolling behavior when you middle click on images with
links, and if you click on parts on image maps that are links, and that aren't.

platform/win/fast/events/panScroll-image-no-scroll-expected.txt: Added.
platform/win/fast/events/panScroll-image-no-scroll.html: Added.
platform/win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Added.
platform/win/fast/events/panScroll-imageMap-href-no-scroll.html: Added.
platform/win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Added.
platform/win/fast/events/panScroll-imageMap-noHref-scroll.html: Added.

1:55 PM Changeset in webkit [52340] by ariya@webkit.org

2 edits in trunk/WebKit/qt

2009-12-18 Ariya Hidayat <ariya.hidayat@gmail.com>

Build fix, not reviewed.

QtLauncher/main.cpp: (MainWindow::setTouchMocking): Leave setTouchMocking as an empty function for Qt < 4.6 so that moc still creates a slot for that. Otherwise, it would have generated a linker error.

1:45 PM Changeset in webkit [52339] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-12-18 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

move bugzilla.py off of urllib2
https://bugs.webkit.org/show_bug.cgi?id=32729

Scripts/modules/bugzilla.py: use mechanize for all url fetching.

1:43 PM Changeset in webkit [52338] by andersca@apple.com

4 edits in trunk/WebKit/mac

Add WKPCRunSyncOpenPanel implementation.

Reviewed by Sam Weinig.

Plugins/Hosted/NetscapePluginHostProxy.mm:

(WKPCRunSyncOpenPanel):

Plugins/Hosted/WebKitPluginClient.defs:
Plugins/Hosted/WebKitPluginHost.defs:

1:18 PM Changeset in webkit [52337] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-12-18 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=32713
[Qt] make wtf/Assertions.h compile in winscw compiler.

Add string arg before ellipsis to help winscw compiler resolve variadic
macro definitions in wtf/Assertions.h.

wtf/Assertions.h:

1:17 PM Changeset in webkit [52336] by andersca@apple.com

7 edits in trunk/WebKit

Add a useProxiedOpenPanel WebPreference and tunnel it through to the plug-in host.

Reviewed by Sam Weinig.

Plugins/Hosted/NetscapePluginHostManager.h:
Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::hostForPackage):
(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::instantiatePlugin):

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences usesProxiedOpenPanel]):
(-[WebPreferences setUsesProxiedOpenPanel:]):

WebView/WebPreferencesPrivate.h:

12:50 PM Changeset in webkit [52335] by otte@webkit.org

4 edits in trunk

[GTK] RemoveDashboard support. It's useless.

configure.ac:

12:46 PM Changeset in webkit [52334] by ggaren@apple.com

5 edits
1 add in trunk/JavaScriptCore

Fixed intermittent failure seen on Windows buildbot, and in other JSC
API clients.

Reviewed by Adam Roben.

Added a WeakGCPtr class and changed OpaqueJSClass::cachedPrototype to
use it, to avoid vending a stale object as a prototype.

API/JSClassRef.cpp:

(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::prototype):

API/JSClassRef.h: Use WeakGCPtr.

JavaScriptCore.xcodeproj/project.pbxproj:
runtime/WeakGCPtr.h: Added.

(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::get):
(JSC::WeakGCPtr::clear):
(JSC::WeakGCPtr::operator*):
(JSC::WeakGCPtr::operator->):
(JSC::WeakGCPtr::operator!):
(JSC::WeakGCPtr::operator bool):
(JSC::WeakGCPtr::operator UnspecifiedBoolType):
(JSC::WeakGCPtr::assign):
(JSC::::operator):
(JSC::operator==):
(JSC::operator!=):
(JSC::static_pointer_cast):
(JSC::const_pointer_cast):
(JSC::getPtr): Added WeakGCPtr to the project.

12:45 PM Changeset in webkit [52333] by bweinstein@apple.com

1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Add a needed export to fix the Windows build.

12:42 PM Changeset in webkit [52332] by christian@webkit.org

2 edits in trunk/WebCore

2009-12-18 Christian Dywan <christian@twotoasts.de>

Reviewed by Xan Lopez.

[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546

Omit SearchWeb from the context menu in the GTK+ port.

platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

12:41 PM Changeset in webkit [52331] by weinig@apple.com

4 edits in trunk/WebCore

Add export the new symbol in WebCoreSystemInterface.

Reviewed by Anders Carlsson.

WebCore.base.exp:
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

12:26 PM Changeset in webkit [52330] by weinig@apple.com

2 edits in trunk/WebCore

Forward declare NSMutableArray when not compiling for Objective-C.

Reviewed by Anders Carlsson.

platform/mac/WebCoreSystemInterface.h:

12:02 PM Changeset in webkit [52329] by barraclough@apple.com

7 edits
1 add in trunk

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=32720

Reviewed by Sam Weinig.

JavaScriptCore.exp:
- Remove exports for UString::append
JavaScriptCore.xcodeproj/project.pbxproj:
- Make StringBuilder a private header (was project).

WebCore: https://bugs.webkit.org/show_bug.cgi?id=32720
Replace UString addition/append with use of JSC::StringBuilder.

Reviewed by Sam Weinig.

ForwardingHeaders/runtime/StringBuilder.h: Added.
bindings/js/ScriptString.h:

(WebCore::ScriptString::operator+=):

bridge/jni/jni_runtime.cpp:

(appendClassName):
(JavaMethod::signature):

inspector/InspectorController.cpp:

(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::addStartProfilingMessageToConsole):
(WebCore::InspectorController::getCurrentUserInitiatedProfileName):

11:55 AM Changeset in webkit [52328] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha Silva.

[GTK] GRefPtr does not take a reference when assigned a raw pointer
https://bugs.webkit.org/show_bug.cgi?id=32709

Ensure that when assigning a raw pointer to a GRefPtr, the reference
count is incremented. Also remove the GRefPtr conversion overload as
GRefPtr types have necessarily incompatible reference counting.

wtf/gtk/GRefPtr.h: (WTF::GRefPtr::operator=):

11:43 AM Changeset in webkit [52327] by eric@webkit.org

3 edits
2 adds in trunk

2009-12-18 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Index validation for drawElements examines too many indices
https://bugs.webkit.org/show_bug.cgi?id=32692

fast/canvas/webgl/bug-32692-expected.txt: Added.
fast/canvas/webgl/bug-32692.html: Added.

2009-12-18 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Index validation for drawElements examines too many indices
https://bugs.webkit.org/show_bug.cgi?id=32692

Test: fast/canvas/webgl/bug-32692.html

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):

11:36 AM Changeset in webkit [52326] by kov@webkit.org

5 edits in trunk

2009-12-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Disable page cache for tests.

DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (copyWebSettingKey): (LayoutTestController::overridePreference):

11:22 AM Changeset in webkit [52325] by weinig@apple.com

10 edits in trunk

WebCore: Update WebKitSystemInterface for <rdar://problem/7237059>.

Reviewed by Anders Carlsson.

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

WebKit/mac: Update WebKitSystemInterface for <rdar://problem/7237059>.

Reviewed by Anders Carlsson.

WebCoreSupport/WebSystemInterface.m:

(InitWebCoreSystemInterface):

WebKitLibraries: Update WebKitSystemInterface for <rdar://problem/7237059>.

Reviewed by Anders Carlsson.

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

11:16 AM Changeset in webkit [52324] by bweinstein@apple.com

1 edit
2 adds in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Add expected failing results for fast/dom/Element/id-in-deleteutton.html.
The progress of fixing the failure is being tracked by:
<https://bugs.webkit.org/show_bug.cgi?id=32727>.

platform/win/fast/dom/Element: Added.
platform/win/fast/dom/Element/id-in-deletebutton-expected.txt: Added.

10:48 AM Changeset in webkit [52323] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-12-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix gtk-doc of webkit_web_resource_new.

webkit/webkitwebresource.cpp:

10:35 AM Changeset in webkit [52322] by Adam Roben

2 edits in trunk/WebCore

GTK build fix

plugins/gtk/PluginViewGtk.cpp: Added #include.

10:00 AM Changeset in webkit [52321] by Adam Roben

8 edits in trunk

Build fixes

WebCore: Chromium build fix

platform/chromium/PopupMenuChromium.cpp: Added #include.

WebKit/chromium: Chromium build fix

src/ChromiumBridge.cpp:
src/WebPluginContainerImpl.cpp:
src/WebViewImpl.cpp:

Added #includes.

WebKit/qt: Qt build fix

Api/qwebpage.cpp: Added #include.

9:54 AM Changeset in webkit [52320] by Adam Roben

2 edits in trunk/WebCore

Chromium build fix

html/HTMLLinkElement.cpp: Added #include.

9:52 AM Changeset in webkit [52319] by Adam Roben

6 edits in trunk

Qt build fix

WebCore:

platform/qt/RenderThemeQt.cpp:
plugins/qt/PluginDataQt.cpp:
plugins/qt/PluginViewQt.cpp:

Added #includes.

WebKit/qt:

Api/qwebpage.cpp:

Added #includes.

9:47 AM Changeset in webkit [52318] by ukai@chromium.org

3 edits in trunk/WebKitTools

2009-12-18 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

Check one space before end of line comments.
https://bugs.webkit.org/show_bug.cgi?id=32597

Fix to check one space before end of line comments in whitespace and build/header_guard.
Also fix build/header_guard to use WebKit header guard defines.

Scripts/modules/cpp_style.py:
Scripts/modules/cpp_style_unittest.py:

9:47 AM Changeset in webkit [52317] by Adam Roben

2 edits in trunk/WebCore

V8 build fix

bindings/v8/custom/V8DOMWindowCustom.cpp: Added #include.

9:45 AM Changeset in webkit [52316] by Adam Roben

2 edits in trunk/WebKit/gtk

GTK build fix

webkit/webkitprivate.cpp: Added #include.

9:42 AM Changeset in webkit [52315] by Adam Roben

2 edits in trunk/WebCore

GTK (and others?) build fix

platform/text/StringImpl.h: Added #include.

9:38 AM Changeset in webkit [52314] by Adam Roben

68 edits in trunk

Reduce #includes in a few high-use headers

Removed unnecessary #includes in these headers:

Frame.h
FrameWin.h
Node.h
Page.h
StringImpl.h

The rest of the patch is all adding #includes to source files that now
require them.

Fixes <http://webkit.org/b/32718>.

Rubber-stamped by Anders Carlsson.

WebCore:

dom/Node.h:
page/Frame.h:
page/Page.h:
page/win/FrameWin.h:
platform/text/StringImpl.h:

Removed unnecessary #includes.

accessibility/win/AXObjectCacheWin.cpp:
bindings/js/JSDOMWindowBase.cpp:
bindings/js/JSDOMWindowCustom.cpp:
dom/Document.cpp:
dom/InputElement.cpp:
dom/Node.cpp:
dom/SelectElement.cpp:
editing/EditorCommand.cpp:
html/HTMLFormControlElement.cpp:
html/HTMLFormElement.cpp:
html/HTMLMediaElement.cpp:
html/HTMLParser.cpp:
html/HTMLTextAreaElement.cpp:
html/HTMLVideoElement.cpp:
inspector/InspectorController.cpp:
loader/FrameLoader.cpp:
loader/HistoryController.cpp:
loader/appcache/ApplicationCacheGroup.cpp:
page/Console.cpp:
page/EventHandler.cpp:
page/Frame.cpp:
page/FrameView.cpp:
page/Navigator.cpp:
page/PageGroup.cpp:
page/Settings.cpp:
page/mac/EventHandlerMac.mm:
platform/KURL.h:
platform/ScrollbarThemeComposite.cpp:
platform/cf/BinaryPropertyList.cpp:
platform/graphics/mac/GraphicsLayerCA.h:
platform/graphics/win/WKCACFLayerRenderer.cpp:
platform/mac/PopupMenuMac.mm:
platform/mac/WidgetMac.mm:
platform/network/cf/DNSCFNet.cpp:
platform/text/StringImpl.cpp:
platform/win/FileSystemWin.cpp:
platform/win/PlatformScreenWin.cpp:
platform/win/PopupMenuWin.cpp:
platform/win/WidgetWin.cpp:
plugins/PluginView.cpp:
plugins/win/PluginViewWin.cpp:
rendering/InlineTextBox.cpp:
rendering/RenderBox.cpp:
rendering/RenderFileUploadControl.cpp:
rendering/RenderInline.cpp:
rendering/RenderLayerCompositor.cpp:
rendering/RenderObject.cpp:
rendering/RootInlineBox.cpp:
storage/DatabaseTracker.cpp:
storage/DatabaseTracker.h:
storage/SQLTransactionClient.cpp:
svg/graphics/SVGImage.cpp:

Added now-needed #includes.

WebKit/mac:

Add #includes needed after WebCore clean-up

WebView/WebFrame.mm:
WebView/WebFrameView.mm:
WebView/WebView.mm:

WebKit/win:

Add #includes needed after WebCore clean-up

WebCoreSupport/WebContextMenuClient.cpp:
WebDataSource.cpp:
WebHTMLRepresentation.cpp:
WebView.cpp:
WebView.h:

9:06 AM Changeset in webkit [52313] by Simon Hausmann

6 edits in trunk

[Qt] Clean up the qmake build system to distinguish between trunk builds and package builds

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=32716

WebKit.pri: Use standalone_package instead of QTDIR_build

JavaScriptCore:

pcre/pcre.pri: Use standalone_package instead of QTDIR_build

WebCore:

Introduce standalone_package as config that is set when QTDIR_build is set or when
the directory for the generated files is present.

Renamed uses of QTDIR_build that apply to generic package builds to use standalone_package.
Others remain as they are specific to building inside Qt.

WebCore.pro:

8:56 AM QtWebKitPerformanceWork edited by dbates@webkit.org

Minor spelling correction (diff)

8:40 AM Changeset in webkit [52312] by eric@webkit.org

36 edits
20 adds in trunk

2009-12-18 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Darin Adler.

New test cases for isId support.
https://bugs.webkit.org/show_bug.cgi?id=5578

dom/xhtml/level3/core/attrisid04-expected.txt:
dom/xhtml/level3/core/attrisid04.js: (setUpPage):
dom/xhtml/level3/core/attrisid05-expected.txt:
dom/xhtml/level3/core/attrisid05.js: (setUpPage):
fast/dom/Element/attrisid-extra01-expected.txt: Added.
fast/dom/Element/attrisid-extra01.html: Added.
fast/dom/Element/id-in-applet-expected.txt: Added.
fast/dom/Element/id-in-applet.html: Added.
fast/dom/Element/id-in-deletebutton-expected.txt: Added.
fast/dom/Element/id-in-deletebutton.html: Added.
fast/dom/Element/id-in-formcollection-expected.txt: Added.
fast/dom/Element/id-in-formcollection.html: Added.
fast/dom/Element/id-in-frame-expected.txt: Added.
fast/dom/Element/id-in-frame.html: Added.
fast/dom/Element/id-in-frameset-expected.txt: Added.
fast/dom/Element/id-in-frameset.html: Added.
fast/dom/Element/id-in-getelement01-expected.txt: Added.
fast/dom/Element/id-in-getelement01.html: Added.
fast/dom/Element/id-in-insert-hr-expected.txt: Added.
fast/dom/Element/id-in-insert-hr.html: Added.
fast/dom/Element/id-in-map-expected.txt: Added.
fast/dom/Element/id-in-map.html: Added.
fast/dom/Element/id-in-param-expected.txt: Added.
fast/dom/Element/id-in-param.html: Added.

2009-12-18 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Darin Adler.

Implemented isId as specified by DOM Level 3. See detailed description below.
https://bugs.webkit.org/show_bug.cgi?id=5578

Added isId property and implementation:
Tests: dom/xhtml/level3/core/attrisid01-07.xhtml

fast/dom/Element/attrisid-extra01.html

dom/Attr.cpp: (WebCore::Attr::isId):
dom/Attr.h:
dom/Attr.idl:

Replaced instances of HTMLNames::idAttr with Element::idAttributeName()
for the reason that id attribute name could be customized to a different
string other than "id". A test case is associated to each code change.

dom/Document.cpp: (WebCore::Document::getElementById): Test: fast/dom/Element/id-in-getelement01.html
dom/Element.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::Element::setAttribute): (WebCore::Element::setAttributeMap): (WebCore::Element::insertedIntoDocument): (WebCore::Element::removedFromDocument): (WebCore::Element::formatForDebugger): (WebCore::Element::rareIDAttributeName):
dom/Element.h: Added function idAttributeName(). (WebCore::Element::idAttributeName):
dom/ElementRareData.h: Added member variable to store customized id name in ElementRareData. (WebCore::ElementRareData::ElementRareData):
dom/NamedAttrMap.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::NamedNodeMap::setNamedItem): (WebCore::NamedNodeMap::removeNamedItem): (WebCore::NamedNodeMap::setAttributes):
dom/Node.cpp: Removed ASSERT as it may not hold any more. (WebCore::Node::querySelector):
dom/SelectorNodeList.cpp: Removed ASSERT as it may not hold any more. (WebCore::createSelectorNodeList):
dom/StyledElement.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::StyledElement::parseMappedAttribute):
editing/DeleteButtonController.cpp: Test: fast/dom/Element/id-in-deletebutton.html (WebCore::DeleteButtonController::createDeletionUI):
editing/EditorCommand.cpp: Test: fast/dom/Element/id-in-insert-hr.html (WebCore::executeInsertHorizontalRule):
html/HTMLAppletElement.cpp: Test: fast/dom/Element/id-in-applet.html (WebCore::HTMLAppletElement::parseMappedAttribute): (WebCore::HTMLAppletElement::createRenderer):
html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): Test: fast/forms/select-namedItem.html (WebCore::HTMLCollection::updateNameCache): Test: fast/dom/collection-namedItem-via-item.html
html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::ensureColumn): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom.html (WebCore::HTMLDataGridColElement::parseMappedAttribute): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html
html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
html/HTMLFormCollection.cpp: Test: fast/dom/Element/id-in-formcollection.html (WebCore::HTMLFormCollection::getNamedFormItem): (WebCore::HTMLFormCollection::nextNamedItem): (WebCore::HTMLFormCollection::updateNameCache):
html/HTMLFrameElementBase.cpp: Test: fast/dom/Element/id-in-frame.html (WebCore::HTMLFrameElementBase::parseMappedAttribute): (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
html/HTMLImageElement.cpp: Test: fast/dom/Element/id-in-deletebutton.html (WebCore::HTMLImageElement::parseMappedAttribute):
html/HTMLMapElement.cpp: Test: fast/dom/Element/id-in-map.html (WebCore::HTMLMapElement::parseMappedAttribute):
html/HTMLNameCollection.cpp: Test: fast/dom/Element/id-in-frameset.html (WebCore::HTMLNameCollection::itemAfter):
html/HTMLObjectElement.cpp: Test: fast/dom/HTMLDocument/object-by-name-or-id.html (WebCore::HTMLObjectElement::parseMappedAttribute):
html/HTMLParamElement.cpp: Test: fast/dom/Element/id-in-param.html (WebCore::HTMLParamElement::parseMappedAttribute):
loader/CachedFont.cpp: Test: svg/custom/acid3-test-77.html (WebCore::CachedFont::getSVGFontById):
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Debug-only code
rendering/SVGRenderTreeAsText.cpp: Test: svg/text/text-gradient-positioning.svg (WebCore::writeRenderResources):
svg/SVGElement.cpp: Test: svg/custom/acid3-test-77.html (WebCore::SVGElement::insertedIntoDocument):
svg/SVGStyledElement.cpp: Test: svg/custom/js-update-image-and-display.svg (WebCore::SVGStyledElement::isKnownAttribute):
wml/WMLElement.cpp: (WebCore::WMLElement::parseMappedAttribute):

7:04 AM Changeset in webkit [52311] by eric@webkit.org

6 edits
2 adds in trunk/WebKit/qt

2009-12-18 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add new API to QWebFrame to scrollRecursively starting with any css overflow
then checking current frame and then ancestors
https://bugs.webkit.org/show_bug.cgi?id=32668

Api/qwebframe.cpp: (QWebFramePrivate::scrollOverflow): (QWebFrame::scrollRecursively):
Api/qwebframe.h:
Api/qwebframe_p.h:
tests/qwebframe/qwebframe.qrc:
tests/qwebframe/testiframe.html: Added.
tests/qwebframe/testiframe2.html: Added.
tests/qwebframe/tst_qwebframe.cpp:

6:03 AM Changeset in webkit [52310] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Fix the build on Symbian.

Reviewed by Tor Arne Vestbø.

Use QFont::lastRestortFamily() instead of QFont::lastRestortFont(),
which is a missing symbol in Qt 4.6.0 on Symbian.

Functionally they should be equivalent, according to the source.

platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

6:01 AM Changeset in webkit [52309] by Philippe Normand

2 edits in trunk/WebCore

2009-12-18 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] segfault during controls initialization if not GTK theme is present.
https://bugs.webkit.org/show_bug.cgi?id=32705

Create empty images for the controls if no GTK theme is set.

platform/graphics/gtk/ImageGtk.cpp: (WebCore::getThemeIconFileName): (WebCore::loadImageFromFile):

5:38 AM Changeset in webkit [52308] by kov@webkit.org

3 edits in trunk/WebCore

Revert r52305, since it breaks many http tests. We will try a better
solution for Soup.

5:32 AM Changeset in webkit [52307] by Simon Hausmann

2 edits in trunk/WebKit/qt

[Qt] Fix infinite recursion in touch mocking.

Reviewed by Tor Arne Vestbø.

Don't send the fake touch events to the view, as that'll trigger the
event filter again.

QtLauncher/main.cpp:

(MainWindow::sendTouchEvent):

4:00 AM Changeset in webkit [52306] by eric@webkit.org

3 edits in trunk/WebKit/gtk

2009-12-18 Kalle Vahlman <kalle.vahlman@movial.com> and Alejandro G. Castro <alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Add enable-page-cache property to WebSettings for disabling the Page Cache

webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
webkit/webkitwebview.cpp:

2:51 AM Changeset in webkit [52305] by otte@webkit.org

3 edits in trunk/WebCore

Remove the fragment identifier from url before passing it to libsoup.

In newer releases libsoup emits a warning when it gets handed a
fragment.

2:37 AM Changeset in webkit [52304] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Compile warning from line 29 of GRefPtr.cpp
https://bugs.webkit.org/show_bug.cgi?id=32703

Fix memory leak and compiler warning in GRefPtr GHashTable template
specialization.

wtf/gtk/GRefPtr.cpp: (WTF::refGPtr):

1:50 AM Changeset in webkit [52303] by eric@webkit.org

3 edits
2 adds in trunk

2009-12-18 Alejandro G. Castro <alex@igalia.com>

Reviewed by Darin Adler.

REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
at the beginning.
https://bugs.webkit.org/show_bug.cgi?id=31920

Added test showing the problem described in the bug.

editing/selection/wrapped-line-caret-3.html:
editing/selection/wrapped-line-caret-3-expected.txt:

2009-12-18 Alejandro G. Castro <alex@igalia.com>

Reviewed by Darin Adler.

REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
at the beginning.
https://bugs.webkit.org/show_bug.cgi?id=31920

Moving up from a position after the end of the previous lines
should use UPSTREAM affinity to render the caret in the previous
line.

Context Navigation

Timeline

Dec 19, 2009:

Dec 18, 2009:

Download in other formats: