Context Navigation

If null or undefined is set to a JavaScript property, C++ setter function receives NaN.
If a getter C++ function returns NaN or infinity, a JavaScript property returns null.

Test: fast/forms/input-valueasdate.html

bindings/js/JSDOMBinding.cpp: (WebCore::jsDateOrNull): Implement the above. (WebCore::valueToDate): ditto.
bindings/js/JSDOMBinding.h: Declare them.
bindings/scripts/CodeGeneratorJS.pm: Produce jsDateOrNull() or valueToDate() for Date type.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Temporal implementation. (WebCore::HTMLInputElement::setValueAsDate): ditto.
html/HTMLInputElement.h:
html/HTMLInputElement.idl: Declare valueAsDate.

10:16 PM Changeset in webkit [52433] by eric@webkit.org

2 edits in trunk/WebKitSite

2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Darin Adler.

Removed outdated contact information from bug life cycle page.

https://bugs.webkit.org/show_bug.cgi?id=32494

quality/lifecycle.html:

8:57 PM Changeset in webkit [52432] by eric@webkit.org

11 edits in trunk/WebCore

2009-12-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Introduce the followings:

::-webkit-inner-spin-button pseudo CSS selector
::-webkit-outer-spin-button pseudo CSS selector
new appearance type: inner-spin-button
new appearance type: outer-spin-button

They're going to be used for <input type=number> UI.
https://bugs.webkit.org/show_bug.cgi?id=31821

Inner-spin-button will be used for Windows, and outer-spin-button
will be used for Mac. A spin-button will represent a pair of an
increasing button part and a decreasing button part. SpinUpState,
which is defined in ThemeTypes.h, will be used to distinguish
these two parts.

The outer-spin-button implementation will use NSStepperCell.
NSStepperCell represents the pair of the parts and we can't draw them
independently. So a spin-button also represents the pair of the parts.

This change has no tests. The following changes with tests will cover.

css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
css/CSSSelector.h: (WebCore::CSSSelector::):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
css/CSSValueKeywords.in:
css/html.css:
platform/ThemeTypes.h: (WebCore::ControlState): Add SpinUpState. (WebCore::ControlPart): Add InnerSpinButtonPart and OuterSpinButtonPart.
rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::adjustInnerSpinButtonStyle): Add an empty implementation. (WebCore::RenderTheme::adjustOuterSpinButtonStyle): Add an empty implementation.
rendering/RenderTheme.h: (WebCore::RenderTheme::paintInnerSpinButton): Add an empty implementation. (WebCore::RenderTheme::paintOuterSpinButton): Add an empty implementation.
rendering/style/RenderStyleConstants.h: (WebCore::PseudoId): Add INNER_SPIN_BUTTON and OUTER_SPIN_BUTTON.

7:17 PM Changeset in webkit [52431] by eric@webkit.org

4 edits in trunk/WebCore

2009-12-20 Nayan Kumar K <nayankk@gmail.com>

Reviewed by Darin Adler.

Fix for compilation errors in WML module, due to the changeset #52314.
https://bugs.webkit.org/show_bug.cgi?id=32786

No new tests, this is compilation error fix.

wml/WMLDocument.cpp:
wml/WMLPageState.cpp:
wml/WMLPageState.h:

6:57 PM Changeset in webkit [52430] by abarth@webkit.org

8 edits
1 copy
1 add in trunk/WebKitTools

2009-12-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Optimize status updates for new dashboard
https://bugs.webkit.org/show_bug.cgi?id=32797

This patch makes the queues slightly more chatty with the web service.
Also, this patch introduces some testing for the queues!

Scripts/modules/commands/early_warning_system.py:
Scripts/modules/commands/early_warning_system_unittest.py: Added.
Scripts/modules/commands/queues.py:
Scripts/modules/commands/queues_unittest.py:
Scripts/modules/commands/queuestest.py: Added.
Scripts/modules/mock_bugzillatool.py:
Scripts/modules/patchcollection.py:
Scripts/modules/queueengine.py:
Scripts/run-webkit-unittests:

6:42 PM Changeset in webkit [52429] by eric@webkit.org

3 edits
2 adds
1 delete in trunk/WebKitTools

2009-12-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Prepare QueueStatusServer for new status messages
https://bugs.webkit.org/show_bug.cgi?id=32805

QueueStatusServer/handlers/recentstatus.py:
QueueStatusServer/index.html: Removed.
QueueStatusServer/model/attachment.py:
QueueStatusServer/model/queues.py: Added.
QueueStatusServer/templates/recentstatus.html: Added.

3:51 PM Changeset in webkit [52428] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-12-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Unset the adjustments in our FrameView when detaching from
parent. Fixes some crashers when transitioning to a new page from
a scrolled page.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::detachedFromParent2):

2:00 PM QtWebKitAPI edited by Simon Hausmann

(diff)

12:50 PM Changeset in webkit [52427] by mitz@apple.com

2 edits in trunk/WebCore

<rdar://problem/7487689> REGRESSION (r52203): Inspector console uses
Monaco on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=32775

Reviewed by Mark Rowe.

inspector/front-end/inspector.css: Use the default monospace family

and size.

12:07 PM Changeset in webkit [52426] by kov@webkit.org

2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

Remove emission of signal that does not exist.

WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::webViewDestroyed):

11:31 AM Changeset in webkit [52425] by kov@webkit.org

3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

Provides a new API to copy WebKitWebHistoryItem objects.

webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_copy):

webkit/webkitwebhistoryitem.h:

10:46 AM Changeset in webkit [52424] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-12-20 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Disable the page cache by default since:

It was previously off by default.
There are still some issues when enabling it.

webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):

10:22 AM Changeset in webkit [52423] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-12-20 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adam Barth.

[check-webkit-style] static_cast is not misnamed!
https://bugs.webkit.org/show_bug.cgi?id=32796

Scripts/modules/cpp_style.py:
Scripts/modules/cpp_style_unittest.py:

10:07 AM Changeset in webkit [52422] by kov@webkit.org

3 edits in trunk/WebKit/gtk

2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Make sure we get the URI that is being loaded when updating
WebKitWebFrame's knowledge of it. This was causing problems now
that page cache is enabled.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
tests/testloading.c: (load_goback_status_changed_cb): (load_wentback_status_changed_cb): (test_loading_goback): (main):

9:39 AM Changeset in webkit [52421] by eric@webkit.org

9 edits in trunk/WebCore

2009-12-20 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] Remove more GTK+ and GLib headers from WebCore
https://bugs.webkit.org/show_bug.cgi?id=32795

Remove most GTK+ and GLib includes from WebCore headers.

platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
platform/gtk/PasteboardHelper.h:
platform/gtk/RenderThemeGtk.cpp:
platform/gtk/RenderThemeGtk.h:
platform/gtk/ScrollbarGtk.cpp:
platform/gtk/ScrollbarThemeGtk.h:
platform/gtk/gtk2drawing.c:
platform/gtk/gtkdrawing.h:

9:06 AM Changeset in webkit [52420] by kevino@webkit.org

8 edits in trunk

[wx] build fixes after recent changes.

8:26 AM Changeset in webkit [52419] by eric@webkit.org

5 edits in trunk

2009-12-20 Alejandro G. Castro <alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
https://bugs.webkit.org/show_bug.cgi?id=32788

Avoid using fixed values when moving mouse.

platform/gtk/editing/pasteboard/middle-button-paste-expected.txt:
platform/gtk/editing/pasteboard/middle-button-paste.html:

2009-12-20 Alejandro G. Castro <alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
https://bugs.webkit.org/show_bug.cgi?id=32788

Do not increase the click count if we are using a different button.

DumpRenderTree/gtk/EventSender.cpp:

7:53 AM Changeset in webkit [52418] by eric@webkit.org

4 edits in trunk/WebKit/gtk

2009-12-20 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Cache control APIs
https://bugs.webkit.org/show_bug.cgi?id=24001

Original patch by Bobby Powers <bobby@laptop.org>

Added new API to specify cache models for GTK port.

webkit/webkitprivate.cpp: (webkit_init): set a default cache model.
webkit/webkitwebview.cpp:
webkit/webkitwebview.h: (webkit_set_cache_model): Added function. (webkit_get_cache_model): Added function.

7:45 AM Changeset in webkit [52417] by kov@webkit.org

2 edits in trunk/WebCore

Reviewed by Xan Lopez.

Hopefully fix the assertion we are hitting by not forcing updating
the state of scrollbars when setting the adjustments. This was
leading to a premature layout.

fast/dom/open-and-close-by-DOM.html
fast/dom/Window/closure-access-after-navigation-window.html
fast/harness/use-page-cache.html

platform/gtk/ScrollViewGtk.cpp:

(WebCore::ScrollView::setGtkAdjustments):

4:58 AM Changeset in webkit [52416] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-12-20 Xan Lopez <xlopez@igalia.com>

Revert the previous patch, it introduces some failures in the
bots.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

4:41 AM Changeset in webkit [52415] by pfeldman@chromium.org

7 edits in trunk/WebCore

2009-12-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Darin Adler.

Web Inspector: Constrain the number of messages the inspector shows.

https://bugs.webkit.org/show_bug.cgi?id=20919

English.lproj/localizedStrings.js:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::populateScriptObjects):
inspector/InspectorController.h:
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount):
inspector/InspectorFrontend.h:
inspector/front-end/inspector.js: (WebInspector.updateConsoleMessageExpiredCount):

4:27 AM Changeset in webkit [52414] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-12-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] crash when loading new page
https://bugs.webkit.org/show_bug.cgi?id=32752

Wait until the document is attached to adjust our alignments,
since we need to make sure the FrameView in the document content
render object matches the newly created FrameView for the new
page, otherwise we'll try to relayout the wrong view.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

4:18 AM Changeset in webkit [52413] by eric@webkit.org

3 edits in trunk/LayoutTests

2009-12-20 Alejandro G. Castro <alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

platform/gtk/editing/pasteboard/middle-button-paste-expected.txt:
platform/gtk/editing/pasteboard/middle-button-paste.html:

4:02 AM Changeset in webkit [52412] by kov@webkit.org

2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

Create a new WebKitDataSource object when attaching to a frame, if
one does not exist. This may happen when we are fetching data from
the page cache.

WebCoreSupport/DocumentLoaderGtk.cpp:

(WebKit::DocumentLoader::attachToFrame):
(WebKit::DocumentLoader::unrefDataSource):

2:46 AM Changeset in webkit [52411] by kov@webkit.org

2 edits in trunk/WebKit/gtk

Rubber-stamped by Xan Lopez.

Make sure the text encoding machinery is initialized from the main
frame, before opening the icon database.

webkit/webkitprivate.cpp:

(webkit_init):

2:27 AM Changeset in webkit [52410] by eric@webkit.org

1 edit
5 adds in trunk/LayoutTests

2009-12-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Adler.

Upstreaming two plugin tests from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32750

plugins/get-file-url-expected.txt: Added.
plugins/get-file-url.html: Added.
plugins/get-url-with-iframe-target-expected.txt: Added.
plugins/get-url-with-iframe-target.html: Added.
plugins/resources/get-file-url-subframe.html: Added.

2:18 AM Changeset in webkit [52409] by eric@webkit.org

1 edit
3 adds in trunk/LayoutTests

2009-12-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Adler.

Upstream a test from chromium.org that verifies that calling
document.clear() from an external script doesn't crash the browser.
https://bugs.webkit.org/show_bug.cgi?id=32743

fast/dom/document-clear-expected.txt: Added.
fast/dom/document-clear.html: Added.
fast/dom/resources/document-clear.js: Added.

2:10 AM Changeset in webkit [52408] by eric@webkit.org

1 edit
2 adds in trunk/LayoutTests

2009-12-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32735

Upstream a test from chromium.org - ensure that creating a
new Image is actually creating an HTML image element, regardless
of the doctype.

svg/custom/new-image-is-html-element-expected.txt: Added.
svg/custom/new-image-is-html-element.svg: Added.

2:01 AM Changeset in webkit [52407] by eric@webkit.org

1 edit
4 adds in trunk/LayoutTests

2009-12-20 Dirk Pranke <dpranke@fila-macpro.mtv.corp.google.com>

Reviewed by Darin Adler.

upstream test from chromium.org - this tests simulating italic
on glyphs that don't have an italic version.

https://bugs.webkit.org/show_bug.cgi?id=32693

fast/text/fake-italic.html: Added.
platform/mac/fast/text/fake-italic-expected.checksum: Added.
platform/mac/fast/text/fake-italic-expected.png: Added.
platform/mac/fast/text/fake-italic-expected.txt: Added.

1:52 AM Changeset in webkit [52406] by eric@webkit.org

3 edits
2 copies in trunk/WebCore

2009-12-20 Andrei Popescu <andreip@google.com>

Reviewed by Adam Barth.

[Android] Android needs implementation of setCookies, cookies and cookiesEnabled functions.
https://bugs.webkit.org/show_bug.cgi?id=32559

Add implementation of the cookie functions.
Fix a crash caused by dereferencing a 0 MainResourceLoader pointer
in ResourceHandle::start().

No new tests, this is platform code.

platform/android/PlatformBridge.h:
platform/network/android/AuthenticationChallenge.h: Added.
platform/network/android/CookieJarAndroid.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
platform/network/android/ResourceHandleAndroid.cpp: (WebCore::ResourceHandle::start):

1:47 AM Changeset in webkit [52405] by abarth@webkit.org

7 edits
1 copy
1 add in trunk/WebKitTools

2009-12-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[QueueStatusServer] Add a per-patch details page
https://bugs.webkit.org/show_bug.cgi?id=32784

This is a first cut at a per-patch details page. I'm sure we'll have
to iterate.

QueueStatusServer/filters/webkit_extras.py:
QueueStatusServer/handlers/patch.py: Added.
QueueStatusServer/index.yaml:
QueueStatusServer/main.py:
QueueStatusServer/model/attachment.py:
QueueStatusServer/stylesheets/dashboard.css:
QueueStatusServer/templates/dashboard.html:
QueueStatusServer/templates/patch.html: Added.

12:27 AM Changeset in webkit [52404] by abarth@webkit.org

4 edits
1 add in trunk/WebKitTools

2009-12-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Use memcache to make dashboard to fast
https://bugs.webkit.org/show_bug.cgi?id=32780

QueueStatusServer/app.yaml:
QueueStatusServer/handlers/dashboard.py:
QueueStatusServer/handlers/updatestatus.py:
QueueStatusServer/model/attachment.py: Added.

Dec 19, 2009:

11:48 PM Changeset in webkit [52403] by eric@webkit.org

5 edits in trunk/WebCore

2009-12-19 Eric Seidel <eric@webkit.org>

No review, rolling out r52395.
http://trac.webkit.org/changeset/52395

svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
svg/SVGMaskElement.h:
svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
svg/graphics/SVGResourceMasker.h:

11:36 PM Changeset in webkit [52402] by abarth@webkit.org

6 edits in trunk

2009-12-19 Adam Barth <abarth@webkit.org>

No review, rolling out r52399.
http://trac.webkit.org/changeset/52399

websocket/tests/bad-sub-protocol-expected.txt:
websocket/tests/script-tests/url-parsing.js:
websocket/tests/url-parsing-expected.txt:

2009-12-19 Adam Barth <abarth@webkit.org>

No review, rolling out r52399.
http://trac.webkit.org/changeset/52399

websockets/WebSocket.cpp: (WebCore::WebSocket::connect):

11:22 PM Changeset in webkit [52401] by abarth@webkit.org

3 edits
2 adds in trunk

2009-12-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a test for window.open and JavaScript URLs.

http/tests/security/xss-DENIED-window-open-javascript-url-expected.txt: Added.
http/tests/security/xss-DENIED-window-open-javascript-url.html: Added.

2009-12-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Added a missing "not".

Test: http/tests/security/xss-DENIED-window-open-javascript-url.html

bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow):

10:55 PM Changeset in webkit [52400] by bfulgham@webkit.org

6 edits
2 adds in trunk/WebKitTools

Provide an example implementation for printing under Windows.
http://bugs.webkit.org/show_bug.cgi?id=32504.`

Reviewed by Adam Roben.

WinLauncher/PrintWebUIDelegate.cpp: Added.

(PrintWebUIDelegate::QueryInterface):
(PrintWebUIDelegate::AddRef):
(PrintWebUIDelegate::Release):
(PrintWebUIDelegate::webViewPrintingMarginRect):

WinLauncher/PrintWebUIDelegate.h: Added.

(PrintWebUIDelegate::PrintWebUIDelegate):
(PrintWebUIDelegate::createWebViewWithRequest):
(PrintWebUIDelegate::webViewShow):
(PrintWebUIDelegate::webViewClose):
(PrintWebUIDelegate::webViewFocus):
(PrintWebUIDelegate::webViewUnfocus):
(PrintWebUIDelegate::webViewFirstResponder):
(PrintWebUIDelegate::makeFirstResponder):
(PrintWebUIDelegate::setStatusText):
(PrintWebUIDelegate::webViewStatusText):
(PrintWebUIDelegate::webViewAreToolbarsVisible):
(PrintWebUIDelegate::setToolbarsVisible):
(PrintWebUIDelegate::webViewIsStatusBarVisible):
(PrintWebUIDelegate::setStatusBarVisible):
(PrintWebUIDelegate::webViewIsResizable):
(PrintWebUIDelegate::setResizable):
(PrintWebUIDelegate::setFrame):
(PrintWebUIDelegate::webViewFrame):
(PrintWebUIDelegate::setContentRect):
(PrintWebUIDelegate::webViewContentRect):
(PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage):
(PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage):
(PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt):
(PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage):
(PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener):
(PrintWebUIDelegate::mouseDidMoveOverElement):
(PrintWebUIDelegate::contextMenuItemsForElement):
(PrintWebUIDelegate::validateUserInterfaceItem):
(PrintWebUIDelegate::shouldPerformAction):
(PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo):
(PrintWebUIDelegate::willPerformDragDestinationAction):
(PrintWebUIDelegate::dragSourceActionMaskForPoint):
(PrintWebUIDelegate::willPerformDragSourceAction):
(PrintWebUIDelegate::contextMenuItemSelected):
(PrintWebUIDelegate::hasCustomMenuImplementation):
(PrintWebUIDelegate::trackCustomPopupMenu):
(PrintWebUIDelegate::measureCustomMenuItem):
(PrintWebUIDelegate::drawCustomMenuItem):
(PrintWebUIDelegate::addCustomMenuDrawingData):
(PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
(PrintWebUIDelegate::canTakeFocus):
(PrintWebUIDelegate::takeFocus):
(PrintWebUIDelegate::registerUndoWithTarget):
(PrintWebUIDelegate::removeAllActionsWithTarget):
(PrintWebUIDelegate::setActionTitle):
(PrintWebUIDelegate::undo):
(PrintWebUIDelegate::redo):
(PrintWebUIDelegate::canUndo):
(PrintWebUIDelegate::canRedo):
(PrintWebUIDelegate::printFrame):
(PrintWebUIDelegate::ftpDirectoryTemplatePath):
(PrintWebUIDelegate::webViewHeaderHeight):
(PrintWebUIDelegate::webViewFooterHeight):
(PrintWebUIDelegate::drawHeaderInRect):
(PrintWebUIDelegate::drawFooterInRect):
(PrintWebUIDelegate::canRunModal):
(PrintWebUIDelegate::createModalDialog):
(PrintWebUIDelegate::runModal):
(PrintWebUIDelegate::isMenuBarVisible):
(PrintWebUIDelegate::setMenuBarVisible):
(PrintWebUIDelegate::runDatabaseSizeLimitPrompt):
(PrintWebUIDelegate::paintCustomScrollbar):
(PrintWebUIDelegate::paintCustomScrollCorner):

WinLauncher/WinLauncher.cpp: Add new UI delegate for print support.

(WinLauncherWebHost::updateAddressBar): check-webkit-style fixes.
(WinLauncherWebHost::QueryInterface): check-webkit-style fixes.
(WinLauncherWebHost::AddRef): check-webkit-style fixes.
(WinLauncherWebHost::Release): check-webkit-style fixes.
(resizeSubViews): check-webkit-style fixes.
(_tWinMain): check-webkit-style fixes.
(MyRegisterClass): check-webkit-style fixes.
(InitInstance): check-webkit-style fixes.
(AbortProc): New print support function.
(getPrinterDC): New print support function.
(initDocStruct): New print support function.
(PrintView): New printing implementation.
(WndProc): Add support for printing.
(MyEditProc): check-webkit-style fixes.
(About): check-webkit-style fixes.
(loadURL): check-webkit-style fixes.

WinLauncher/WinLauncher.h:

(WinLauncherWebHost::WinLauncherWebHost):
(WinLauncherWebHost::didStartProvisionalLoadForFrame):
(WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
(WinLauncherWebHost::didFailProvisionalLoadWithError):
(WinLauncherWebHost::didCommitLoadForFrame):
(WinLauncherWebHost::didReceiveTitle):
(WinLauncherWebHost::didReceiveIcon):
(WinLauncherWebHost::didFinishLoadForFrame):
(WinLauncherWebHost::didFailLoadWithError):
(WinLauncherWebHost::didChangeLocationWithinPageForFrame):
(WinLauncherWebHost::willPerformClientRedirectToURL):
(WinLauncherWebHost::didCancelClientRedirectForFrame):
(WinLauncherWebHost::willCloseFrame):
(WinLauncherWebHost::windowScriptObjectAvailable):

WinLauncher/WinLauncher.rc: Add menu entry for printing.
WinLauncher/WinLauncher.vcproj: Add new files.
WinLauncher/resource.h: Add menu entry for printing.

7:30 PM Changeset in webkit [52399] by ukai@chromium.org

6 edits in trunk

2009-12-19 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Invalid url should raise SYNTAX_ERR exception.
https://bugs.wbekit.org/show_bug.cgi?id=32700

websocket/tests/bad-sub-protocol-expected.txt: add CONSOLE MESSAGEs
websocket/tests/script-tests/url-parsing.js: add invalid url tests. Also changed url from ws://127.0.0.1/ to ws://127.0.0.1:8880/websocket/tests/simple to make it sure no errors on console message for these tests by not receiving unexpected response from 127.0.0.1:80.
websocket/tests/url-parsing-expected.txt:

2009-12-19 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700

Check url is valid in WebSocket::connect.
Also log the detailed reason of websocket failures to console.

websockets/WebSocket.cpp: (WebCore::WebSocket::connect):

6:40 PM Changeset in webkit [52398] by abarth@webkit.org

3 edits in trunk/WebKitTools

2009-12-19 Adam Barth <abarth@webkit.org>

Unreviewed. Tweak the CSS to make the dashboard prettier.

QueueStatusServer/stylesheets/dashboard.css:
QueueStatusServer/templates/dashboard.html:

6:32 PM Changeset in webkit [52397] by mitz@apple.com

2 edits in trunk/WebCore

REGRESSION: Up/down arrow keys do not step numeric CSS property values
https://bugs.webkit.org/show_bug.cgi?id=32776

Reviewed by Darin Adler.

inspector/front-end/inspector.js:

(WebInspector.documentKeyDown): Call the focused element’s
handleKeyEvent method.

5:37 PM Changeset in webkit [52396] by abarth@webkit.org

8 edits
3 moves
6 adds in trunk/WebKitTools

2009-12-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

QueueStatusServer needs a human readable dashboard
https://bugs.webkit.org/show_bug.cgi?id=32769

Here is a first cut at the dashboard. There's a lot left to do.

QueueStatusServer/filters/webkit_extras.py:
QueueStatusServer/handlers/dashboard.py: Added.
QueueStatusServer/handlers/patchstatus.py:
QueueStatusServer/handlers/recentstatus.py:
QueueStatusServer/handlers/showresults.py:
QueueStatusServer/handlers/statusbubble.py:
QueueStatusServer/handlers/updatestatus.py:
QueueStatusServer/main.py:
QueueStatusServer/model/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py.
QueueStatusServer/stylesheets/dashboard.css: Added.
QueueStatusServer/templates/dashboard.html: Added.
QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html.
QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html.

5:30 PM BuildingOnWindows edited by dbates@webkit.org

Add notice of change made in changeset 51399 that requires Safari … (diff)

1:58 PM Changeset in webkit [52395] by eric@webkit.org

5 edits in trunk/WebCore

2009-12-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738

This patch makes SVG Masking faster. At the moment we create a new ImageBuffer
and copy the complete pixel array. That is rather inefficient. This patch
uses the mask image directly.
It also bounds the direct pixel manipultation to the viewable area to minimize
the calculation of the mask.

No change in functionality. So no new test.

svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
svg/SVGMaskElement.h:
svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
svg/graphics/SVGResourceMasker.h:

1:35 PM Changeset in webkit [52394] by eric@webkit.org

3 edits
4 adds in trunk

2009-12-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010

Tests the right order of filter and clipper/masker aplied to a SVG
object.

platform/mac/svg/filters/filter-clip-expected.checksum: Added.
platform/mac/svg/filters/filter-clip-expected.png: Added.
platform/mac/svg/filters/filter-clip-expected.txt: Added.
svg/filters/filter-clip.svg: Added.

2009-12-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010

The right ordering for applying effects on objects in SVG is filters,
clipper/masker and opacity. This patch fixes the order of filter and
clipper/masker. Opacity and marker need another test.
This change is according to the SVG Specification:
http://www.w3.org/TR/SVG11/render.html#Elements

Test: svg/filters/filter-clip.svg

rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):

12:53 PM Changeset in webkit [52393] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-12-19 Daniel Bates <dbates@webkit.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=32462

Added --inspector-frontend flag to build-webkit to copy any changes
to the inspector front-end files to the built WebCore framework. This
will make inspector development more consistent with the rest of
WebKit development.

Scripts/build-webkit:
Scripts/webkitdirs.pm:

10:55 AM Changeset in webkit [52392] by eric@webkit.org

2 edits in trunk/WebCore

2009-12-19 Evan Martin <evan@chromium.org>

Reviewed by Gustavo Noronha Silva.

Revert my attempt at making --disable-geolocation work; it is
more complicated than I anticipated. (It passed on the build bots
because they build with --enable-geolocation.)

GNUmakefile.am:

10:52 AM Changeset in webkit [52391] by otte@webkit.org

2 adds in trunk/LayoutTests/platform/gtk/svg/css

add forgotten file

10:45 AM Changeset in webkit [52390] by otte@webkit.org

1 edit in trunk/LayoutTests/ChangeLog

Rebaselined test after revision 52335.

10:37 AM Changeset in webkit [52389] by eric@webkit.org

4 edits
2 adds in trunk

2009-12-19 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Tests for https://bugs.webkit.org/show_bug.cgi?id=28153
can't middle-button paste within a single window

LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste-expected.txt: Added
LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste.html: Adeed

2009-12-19 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Fixed the problem when pasting in the same window with the
middle-button, now we store a reference to the range instead of
requesting it every time, and we do not release it until the
clipboard is requested.
https://bugs.webkit.org/show_bug.cgi?id=28153

WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:
WebKit/gtk/WebCoreSupport/EditorClientGtk.h:

10:30 AM Changeset in webkit [52388] by eric@webkit.org

3 edits
3 adds in trunk

2009-12-19 MORITA Hajime <morrita@gmail.com>

Reviewed by Darin Adler.

WebCore::Range::surroundContents NULL pointer crash.

https://bugs.webkit.org/show_bug.cgi?id=31684

fast/dom/Range/31684-expected.txt: Added.
fast/dom/Range/31684.html: Added.
fast/dom/Range/script-tests/31684.js: Added.

2009-12-19 MORITA Hajime <morrita@gmail.com>

Reviewed by Darin Adler.

WebCore::Range::surroundContents NULL pointer crash.

https://bugs.webkit.org/show_bug.cgi?id=31684

Test: fast/dom/Range/31684.html

dom/Range.cpp: (WebCore::Range::surroundContents): throw exception when parentOfNewParent->parentNode() is NULL.

10:24 AM Changeset in webkit [52387] by kov@webkit.org

2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

Protect download objects when reporting errors, to make sure the
download stays alive between the status change notification, and
the error signal emission.