⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 21, 2009:

11:46 PM Changeset in webkit [52485] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip layoutTestController.notifyDone() related test until fix.
​https://bugs.webkit.org/show_bug.cgi?id=31626

  • platform/qt/Skipped: http/tests/misc/set-window-opener-to-null.html added.
11:04 PM Changeset in webkit [52484] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-12-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Upstream chrome/fast/events/iframe-onload-remove-self-no-crash.html .
​https://bugs.webkit.org/show_bug.cgi?id=32742 .

  • fast/frames/iframe-onload-remove-self-no-crash-expected.txt: Added.
  • fast/frames/iframe-onload-remove-self-no-crash.html: Added.
  • fast/frames/resources/iframe-onload-remove-self-no-crash-child.html: Added.
  • fast/frames/resources/iframe-onload-remove-self-no-crash.js: Added. (onWindowLoad):
10:57 PM Changeset in webkit [52483] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-12-21 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

Use ASSERT instead of assert in image-decoders
​https://bugs.webkit.org/show_bug.cgi?id=32852

Other decoders use WTF's ASSERT macro.
Follow this convention.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable):
10:54 PM Changeset in webkit [52482] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Prospective GTK build fix: Add UStringImpl.cpp/h to the build.

  • GNUmakefile.am:
10:53 PM Changeset in webkit [52481] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Fix the Qt build, add UStringImpl.cpp to the build.

10:46 PM Changeset in webkit [52480] by abarth@webkit.org
  • 7 edits
    1 copy in trunk/WebKitTools

2009-12-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Automate the process of calling prepare-ChangeLog
​https://bugs.webkit.org/show_bug.cgi?id=32816

This patch automates the process of creating a bug and patch and
uploading it to bugzilla. The first cut just calls
prepare-ChangeLog.

This patch required some refactoring of upload.py to the Step
model, but that's worth doing anyway.

  • Scripts/bugzilla-tool:
  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/upload.py:
  • Scripts/modules/commands/upload_unittest.py:
  • Scripts/modules/mock_bugzillatool.py:
9:44 PM Changeset in webkit [52479] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-21 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

Use vsnprintf instead of vasprintf for RVCT.
​https://bugs.webkit.org/show_bug.cgi?id=32851

RVCT does not support vasprint, so use vsnprintf instead.

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
8:47 PM Changeset in webkit [52478] by ukai@chromium.org
  • 6 edits in trunk

2009-12-21 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Invalid url should raise SYNTAX_ERR exception.
​https://bugs.webkit.org/show_bug.cgi?id=32700

  • websocket/tests/bad-sub-protocol-expected.txt: add CONSOLE MESSAGEs
  • websocket/tests/script-tests/url-parsing.js: add invalid url tests. Also changed url from ws://127.0.0.1/ to ws://127.0.0.1:8880/websocket/tests/simple to make it sure no errors on console message for these tests by not receiving unexpected response from 127.0.0.1:80
  • websocket/tests/url-parsing-expected.txt:

2009-12-21 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Invalid url should raise SYNTAX_ERR exception.
​https://bugs.webkit.org/show_bug.cgi?id=32700

Check url is valid in WebSocket::connect.
Also log the detailed reason of websocket failures to console.

  • websockets/WebSocket.cpp: (WebCore::encodeProtocolString): (WebCore::WebSocket::connect):
8:31 PM Changeset in webkit [52477] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-12-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

Upstream a test from chromium.org.
​https://bugs.webkit.org/show_bug.cgi?id=32761

  • http/tests/misc/resources/content-iframe.html: Added.
  • http/tests/misc/set-window-opener-to-null-expected.txt: Added.
  • http/tests/misc/set-window-opener-to-null.html: Added.
7:36 PM Changeset in webkit [52476] by bweinstein@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Build fix for Windows Debug, if this breaks Release I will roll it out.

7:01 PM Changeset in webkit [52475] by bweinstein@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Should be final part of the Windows build fix.

7:00 PM Changeset in webkit [52474] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Don't allocate a WebGeolocationControllerClient unless that compile-time setting is enabled.

Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

6:49 PM Changeset in webkit [52473] by mrowe@apple.com
  • 4 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.

Reviewed by Samuel Weinig.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
6:41 PM Changeset in webkit [52472] by bweinstein@apple.com
  • 3 edits in trunk

Hopefully closer to a build fix. JavaScriptCore will build now.

6:25 PM Changeset in webkit [52471] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows Build fix part 5.

6:04 PM Changeset in webkit [52470] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix breakage of world introduced in build fix to r52463.

Reviewed by NOBODY (build fix).

  • runtime/UStringImpl.h:
6:03 PM Changeset in webkit [52469] by andersca@apple.com
  • 2 edits in trunk/WebCore

Make sure that we check for the right thread.

Reviewed by Sam Weinig.

  • platform/mac/WebCoreObjCExtras.mm:

(WebCoreObjCScheduleDeallocateOnMainThread):

5:35 PM QtWebKitPerformanceWork edited by dbates@webkit.org
Change formatting to outline mode (diff)
5:31 PM QtWebKitPerformanceWork edited by dbates@webkit.org
Add section Common Windows Errors and describe port 80 already in use error (diff)
5:28 PM Changeset in webkit [52468] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

unreviewed windows build fix #4

5:21 PM Changeset in webkit [52467] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

unreviewed windows build fix #3

5:08 PM Changeset in webkit [52466] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

unreviewed windows build fix #2

4:57 PM Changeset in webkit [52465] by enrica@apple.com
  • 5 edits in trunk

WebCore: REGRESSION(4.0.4-ToT): Indent deletes non highlighted text in gmail.
<rdar://problem/7489326>
​https://bugs.webkit.org/show_bug.cgi?id=32843

Reviewed by Maciej Stachowiak.

The fix for 7442387 did not handle the case where the end of paragraph
is not a descendant of the computed outer block.
Updated editing/execCommand/indent-with-style2.html to cover this case too.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

LayoutTests: REGRESSION(4.0.4-ToT): Indent deletes non highlighted text in gmail.
<rdar://problem/7489326>
​https://bugs.webkit.org/show_bug.cgi?id=32843

Reviewed by Maciej Stachowiak.

The fix for 7442387 did not handle the case where the end of paragraph
is not a descendant of the computed outer block.
Updated editing/execCommand/indent-with-style2.html to cover this case too.

  • editing/execCommand/indent-with-style2-expected.txt:
  • editing/execCommand/indent-with-style2.html:
4:53 PM Changeset in webkit [52464] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/runtime/UStringImpl.h

unreviewed windows build fix #1

4:47 PM QtWebKitPerformanceWork edited by dbates@webkit.org
Rewrote the sentence that starts "When starting the 'http_server'...", … (diff)
4:41 PM QtWebKitPerformanceWork edited by dbates@webkit.org
Added section Prerequisites to mention (diff)
4:38 PM Changeset in webkit [52463] by barraclough@apple.com
  • 10 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=32831
Replace UString::Rep implementation, following introduction of ropes to JSC.

Reviewed by Darin Adler.

JavaScriptCore:

  • Remove redundant overcapacity mechanisms.
  • Reduce memory cost of Rep's.
  • Add an inline storage mechanism akin to that in WebCore's StringImpl.

~1% Sunspider progression.

(JSC::JSString::resolveRope):

  • runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage):

  • runtime/UString.cpp:

(JSC::initializeUString):
(JSC::createRep):
(JSC::UString::createFromUTF8):
(JSC::UString::createUninitialized):
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
(JSC::UString::ascii):
(JSC::UString::operator=):
(JSC::UString::toStrictUInt32):
(JSC::equal):

  • runtime/UString.h:

(JSC::UString::isEmpty):
(JSC::UString::cost):
(JSC::makeString):

  • runtime/UStringImpl.cpp: Added.

(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::destroy):
(JSC::UStringImpl::computeHash):

  • runtime/UStringImpl.h: Added.

(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UntypedPtrAndBitfield::asPtr):
(JSC::UntypedPtrAndBitfield::operator&=):
(JSC::UntypedPtrAndBitfield::operator|=):
(JSC::UntypedPtrAndBitfield::operator&):
(JSC::UStringImpl::create):
(JSC::UStringImpl::createCopying):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::data):
(JSC::UStringImpl::size):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::hash):
(JSC::UStringImpl::computedHash):
(JSC::UStringImpl::setHash):
(JSC::UStringImpl::identifierTable):
(JSC::UStringImpl::setIdentifierTable):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::allocChars):
(JSC::UStringImpl::copyChars):
(JSC::UStringImpl::computeHash):
(JSC::UStringImpl::null):
(JSC::UStringImpl::empty):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::operator new):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):

JavaScriptGlue:

  • ForwardingHeaders/wtf/PossiblyNull.h: Added.
    • add forwarding header.

WebCore:

  • ForwardingHeaders/runtime/UStringImpl.h: Added.
    • add forwarding header.
  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::ustring):

  • order of arguments to UString::Rep constructor for shared strings changed.
3:50 PM Changeset in webkit [52462] by eric@webkit.org
  • 1 edit
    16 adds in trunk/LayoutTests

2009-12-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

Upstream a bunch of platform-specific Chromium plugin tests.
​https://bugs.webkit.org/show_bug.cgi?id=32751

  • platform/chromium/plugins/call-as-function-expected.txt: Added.
  • platform/chromium/plugins/call-as-function.html: Added.
  • platform/chromium/plugins/get-url-with-iframe-target-no-crash-expected.txt: Added.
  • platform/chromium/plugins/get-url-with-iframe-target-no-crash.html: Added.
  • platform/chromium/plugins/multiple-plugins-expected.txt: Added.
  • platform/chromium/plugins/multiple-plugins.html: Added.
  • platform/chromium/plugins/nested-plugin-objects-expected.txt: Added.
  • platform/chromium/plugins/nested-plugin-objects.html: Added.
  • platform/chromium/plugins/refcount-leaks-expected.txt: Added.
  • platform/chromium/plugins/refcount-leaks.html: Added.
  • platform/chromium/plugins/return-npobject-expected.txt: Added.
  • platform/chromium/plugins/return-npobject.html: Added.
  • platform/chromium/plugins/script-object-invoke-expected.txt: Added.
  • platform/chromium/plugins/script-object-invoke.html: Added.
3:42 PM Changeset in webkit [52461] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-12-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Darin Adler.

Upstream a test to ensure we handle variations on "javascript:" URL
correctly.

​https://bugs.webkit.org/show_bug.cgi?id=32740

  • fast/dom/xss-DENIED-javascript-variations-expected.txt: Added.
  • fast/dom/xss-DENIED-javascript-variations.html: Added.
3:39 PM Changeset in webkit [52460] by mrowe@apple.com
  • 5 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.

Reviewed by Samuel Weinig.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
3:15 PM Changeset in webkit [52459] by Nate Chapin
  • 66 edits
    1 add in trunk/WebCore

2009-12-18 Nate Chapin <Nate Chapin>

Reviewed by Adam barth.

Generate V8 bindings non-constructor callback declarations
in CodeGeneratorV8.pm instead of manually declaring them in
V8CustomBinding.h.

​https://bugs.webkit.org/show_bug.cgi?id=32638

3:00 PM Changeset in webkit [52458] by Nate Chapin
  • 1 edit
    5 deletes in trunk/LayoutTests

2009-12-21 Nate Chapin <Nate Chapin>

Unreviewed, build fix.

Cleared instead of deleted some layout test files, making them fail. Delete them for real.

  • http/tests/navigation/image-load-in-beforeunload-handler-expected.txt: Removed.
  • http/tests/navigation/image-load-in-beforeunload-handler.html: Removed.
  • http/tests/navigation/image-load-in-unload-handler-expected.txt: Removed.
  • http/tests/navigation/image-load-in-unload-handler.html: Removed.
  • http/tests/navigation/resources/wait-then-notify-done.html: Removed.
2:52 PM Changeset in webkit [52457] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Did a rename, so checking in the

version of the script I used.

2:39 PM Changeset in webkit [52456] by Nate Chapin
  • 15 edits in trunk

2009-12-21 Nate Chapin <Nate Chapin>

Rubber-stamped by Darin Adler.

Revert r52446 due to crashiness.

​https://bugs.webkit.org/show_bug.cgi?id=32839

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::pageHidden):
  • loader/FrameLoader.h: (WebCore::FrameLoader::suppressOpenerInNewFrame):
  • loader/Request.cpp: (WebCore::Request::Request): (WebCore::Request::~Request):
  • loader/Request.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h:
  • loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::cancelPendingRequests): (WebCore::Loader::Host::cancelRequests):
2:12 PM Changeset in webkit [52455] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update status-bubble to show all the queues
​https://bugs.webkit.org/show_bug.cgi?id=32838

Also, move statusbubble over to use memcache.

  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/templates/statusbubble.html:
1:26 PM Changeset in webkit [52454] by pkasting@chromium.org
  • 5 edits in trunk/WebCore

Add support for V8 Date binding.
​https://bugs.webkit.org/show_bug.cgi?id=32699

Patch by Kent Tamura <​tkent@chromium.org> on 2009-12-19
Reviewed by Adam Barth.

This implements the same behavior as the recent change of
CodeGeneratorJS.pm and JSDOMBinding.cpp.

  • bindings/scripts/CodeGeneratorV8.pm: Produce toWebCoreDate() or v8DateOrNull() for Date type.
  • bindings/v8/V8Binding.cpp:

(WebCore::toWebCoreDate):

Converts a JavaScript object to a double representing Date.

(WebCore::v8DateOrNull):

Converts a double representing Date to a JavaScript Date object or null.

  • bindings/v8/V8Binding.h: Declare toWebCoreDate() and v8DateOrNull().
  • html/HTMLInputElement.idl: Delete V8_BINGIN exclusion for valueAsDate.
12:19 PM Changeset in webkit [52453] by eric@webkit.org
  • 3 edits
    1 copy
    1 add in trunk/WebKitTools

2009-12-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Delete the boring "Empty queue" status messages in QueueStatusServer
​https://bugs.webkit.org/show_bug.cgi?id=32818

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/cron.yaml:
  • QueueStatusServer/handlers/gc.py:
  • QueueStatusServer/main.py:
12:18 PM Changeset in webkit [52452] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Doc: Minor fixes to language.

Patch by David Boddie <​dboddie@trolltech.com> on 2009-12-21
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:
12:15 PM Changeset in webkit [52451] by Darin Adler
  • 5 edits in trunk/WebCore

Renamed m_sel to m_selection. Used do-webcore-rename.

Reviewed by Mark Rowe.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::setSelection):
(WebCore::SelectionController::nodeWillBeRemoved):
(WebCore::SelectionController::willBeModified):
(WebCore::SelectionController::directionOfEnclosingBlock):
(WebCore::SelectionController::modifyExtendingRight):
(WebCore::SelectionController::modifyExtendingForward):
(WebCore::SelectionController::modifyMovingRight):
(WebCore::SelectionController::modifyMovingForward):
(WebCore::SelectionController::modifyExtendingLeft):
(WebCore::SelectionController::modifyExtendingBackward):
(WebCore::SelectionController::modifyMovingLeft):
(WebCore::SelectionController::modifyMovingBackward):
(WebCore::SelectionController::modify):
(WebCore::SelectionController::expandUsingGranularity):
(WebCore::SelectionController::xPosForVerticalArrowNavigation):
(WebCore::SelectionController::setBase):
(WebCore::SelectionController::setExtent):
(WebCore::SelectionController::layout):
(WebCore::SelectionController::caretRenderer):
(WebCore::SelectionController::invalidateCaretRect):
(WebCore::SelectionController::paintCaret):
(WebCore::SelectionController::debugRenderer):
(WebCore::SelectionController::contains):
(WebCore::SelectionController::selectAll):
(WebCore::SelectionController::formatForDebugger):
(WebCore::SelectionController::showTreeForThis):

  • editing/SelectionController.h:
  • editing/gtk/SelectionControllerGtk.cpp:

(WebCore::SelectionController::notifyAccessibilityForSelectionChange):

  • editing/mac/SelectionControllerMac.mm:

(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
Let the script do its thing. Made sure no tests broke.

12:11 PM Changeset in webkit [52450] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-12-21 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Darin Adler.

Inconsistent use of counterName and identifier in CSS counter code and loss of information about the counter type.
​https://bugs.webkit.org/show_bug.cgi?id=31814

No new tests because there are no functional changes in this patch.

  • rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode): (WebCore::CounterNode::computeCountInParent): (WebCore::showTreeAndMark):
  • rendering/RenderCounter.cpp: (WebCore::planCounter): (WebCore::findPlaceForCounter): (WebCore::makeCounterNode): (WebCore::RenderCounter::originalText): Changed to use identifier instead of counterName and actsAsReset or hasResetType, as appropriate instead of isReset.
  • rendering/CounterNode.h: (WebCore::CounterNode::actsAsReset): (WebCore::CounterNode::hasResetType):
12:00 PM Changeset in webkit [52449] by krit@webkit.org
  • 8 edits in trunk

2009-12-21 Dirk Schulze <​krit@webkit.org>

Reviewed by Darin Adler and Nikolas Zimmermann.

Speed-up SVG Masking
​https://bugs.webkit.org/show_bug.cgi?id=32738

This patch makes SVG Masking faster. The luminance calculaton of the ImageBuffer,
that is created by pixel manipulation, got optimized. The ImageBuffer and it's
luminance is created once now, not on every call of applyMask.
The size of the intermediate ImageBuffer depends on the visible area now and is
clipped by the mask rect.


The patch doesn't change functionality so no new tests needed.
The new ImageBuffer handling in Mask causes two updates of test results. The pixel
tests and LayoutTests pass, but the checksum doesn't match.

  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):

2009-12-21 Dirk Schulze <​krit@webkit.org>

Reviewed by Darin Adler and Nikolas Zimmermann.

Speed-up SVG Masking
​https://bugs.webkit.org/show_bug.cgi?id=32738

Update pixel test results for two SVG masking operations. They don't fail
and there is no noticable difference between the old and new results. But
Masking uses smaller ImageBuffers now and that changed the checksum.

  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
10:58 AM Changeset in webkit [52448] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2009-12-21 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Test that dragging an SVG as <img> doesn't crash the browser.
Note that this only works in debug mode as it's a failing assert.

​https://bugs.webkit.org/show_bug.cgi?id=32511

  • fast/images/drag-svg-as-image.html: Added.
  • platform/qt/Skipped: fast/images/drag-svg-as-image.html added.

2009-12-21 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Fix assertion failure when dragging an SVG image.
​https://bugs.webkit.org/show_bug.cgi?id=32511

Test: fast/images/drag-svg-as-image.html

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::filenameExtension): Return "svg"
  • svg/graphics/SVGImage.h:
9:58 AM Changeset in webkit [52447] by Philippe Normand
  • 2 edits in trunk/WebCore

Reviewed by Xan Lopez.

[GTK] G_OBJECT() cast is not necessary for signals connection and properties access
​https://bugs.webkit.org/show_bug.cgi?id=32661

Removed useless calls to the G_OBJECT() macro and replaced NULL
occurences with a SENTINEL macro.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::hasAudio): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
9:51 AM UsingGitWithWebKit edited by Adam Roben
Explain why one might want to "track the Subversion repository" (diff)
8:55 AM Changeset in webkit [52446] by Nate Chapin
  • 10 edits
    5 adds in trunk

2009-12-21 Nate Chapin <Nate Chapin>

Reviewed by Darin Adler.

If an image load is started during an unload or beforeunload event, run it
asynchronously (and allow it to outlive its page) so navigation can continue
while the load completes.

​https://bugs.webkit.org/show_bug.cgi?id=30457

Tests: http/tests/navigation/image-load-in-beforeunload-handler.html

http/tests/navigation/image-load-in-unload-handler.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/FrameLoader.cpp: Rename m_unloadEventBeingDispatched to m_isDispatchingUnloadEvent. (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Set m_isDispatchingBeforeUnloadEvent. (WebCore::FrameLoader::pageHidden):
  • loader/FrameLoader.h: (WebCore::FrameLoader::isDispatchingUnloadFamilyEvent): Added.
  • loader/Request.cpp: (WebCore::Request::Request): Add OutlivePagePolicy to constructor parameters
  • loader/Request.h: (WebCore::): Add OutlivePagePolicy enum. (WebCore::Request::shouldOutlivePage): Added. (WebCore::Request::frame): Added.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Change one of the security checks to an outlive page check.
  • loader/SubresourceLoader.h:
  • loader/loader.cpp: (WebCore::Loader::load): Add OutlivePagePolicy to Request constructor call,

ensure requests that should outlive page are done asynchronously.

(WebCore::Loader::cancelRequests): Remove ending ASSERT since it will now be hard to predict how

many requests might possibly outlive a cancel in every case.

(WebCore::Loader::Host::servePendingRequests): Use the correct frame in the case of a request outliving its page.
(WebCore::Loader::Host::cancelPendingRequests): Ensure we don't cancel request that should outlive their page.
(WebCore::Loader::Host::cancelRequests): Ensure we don't cancel request that should outlive their page.

8:34 AM Changeset in webkit [52445] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Xan Lopez.

  • platform/gtk/Skipped: Unskip test fixed by patch from Bug 24001.
7:06 AM Changeset in webkit [52444] by vestbo@webkit.org
  • 18 edits
    13 copies
    10 moves
    9 adds
    7 deletes in trunk/WebKit/qt

[Qt] Clean up the WebKit layer unit-tests

Reviewed by Simon Hausmann.

  • Use tests.pri for common options
  • Standardize file naming
  • Move all resources to 'resources' subdir
  • Standardize how TESTS_SOURCE_DIR is used
  • Get rid of UID3 for symbian (autogenerated)
  • Don't build app bundles on Mac OS X
  • tests/benchmarks/loading/loading.pro: Added.
  • tests/benchmarks/loading/tst_loading.pro: Removed.
  • tests/benchmarks/painting/painting.pro: Added.
  • tests/benchmarks/painting/tst_painting.pro: Removed.
  • tests/qgraphicswebview/qgraphicswebview.pro:
  • tests/qwebelement/qwebelement.pro:
  • tests/qwebelement/qwebelement.qrc: Removed.
  • tests/qwebelement/resources/image.png: Renamed from WebKit/qt/tests/qwebelement/image.png.
  • tests/qwebelement/resources/style.css: Renamed from WebKit/qt/tests/qwebelement/style.css.
  • tests/qwebelement/resources/style2.css: Renamed from WebKit/qt/tests/qwebelement/style2.css.
  • tests/qwebelement/tst_qwebelement.qrc: Added.
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebframe/qwebframe.qrc: Removed.
  • tests/qwebframe/resources/image.png: Renamed from WebKit/qt/tests/qwebframe/image.png.
  • tests/qwebframe/resources/style.css: Renamed from WebKit/qt/tests/qwebframe/style.css.
  • tests/qwebframe/resources/test1.html: Renamed from WebKit/qt/tests/qwebframe/test1.html.
  • tests/qwebframe/resources/test2.html: Renamed from WebKit/qt/tests/qwebframe/test2.html.
  • tests/qwebframe/resources/testiframe.html: Renamed from WebKit/qt/tests/qwebframe/testiframe.html.
  • tests/qwebframe/resources/testiframe2.html: Renamed from WebKit/qt/tests/qwebframe/testiframe2.html.
  • tests/qwebframe/tst_qwebframe.cpp:
  • tests/qwebframe/tst_qwebframe.qrc: Added.
  • tests/qwebhistory/qwebhistory.pro:
  • tests/qwebhistory/resources/page1.html: Renamed from WebKit/qt/tests/qwebhistory/data/page1.html.
  • tests/qwebhistory/resources/page2.html: Renamed from WebKit/qt/tests/qwebhistory/data/page2.html.
  • tests/qwebhistory/resources/page3.html: Renamed from WebKit/qt/tests/qwebhistory/data/page3.html.
  • tests/qwebhistory/resources/page4.html: Renamed from WebKit/qt/tests/qwebhistory/data/page4.html.
  • tests/qwebhistory/resources/page5.html: Renamed from WebKit/qt/tests/qwebhistory/data/page5.html.
  • tests/qwebhistory/resources/page6.html: Renamed from WebKit/qt/tests/qwebhistory/data/page6.html.
  • tests/qwebhistory/tst_qwebhistory.cpp:

(tst_QWebHistory::):

  • tests/qwebhistory/tst_qwebhistory.qrc:
  • tests/qwebhistoryinterface/qwebhistoryinterface.pro:
  • tests/qwebinspector/qwebinspector.pro:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebpage/resources/frame_a.html: Renamed from WebKit/qt/tests/qwebpage/frametest/frame_a.html.
  • tests/qwebpage/resources/iframe.html: Renamed from WebKit/qt/tests/qwebpage/frametest/iframe.html.
  • tests/qwebpage/resources/iframe2.html: Renamed from WebKit/qt/tests/qwebpage/frametest/iframe2.html.
  • tests/qwebpage/resources/iframe3.html: Renamed from WebKit/qt/tests/qwebpage/frametest/iframe3.html.
  • tests/qwebpage/resources/index.html: Renamed from WebKit/qt/tests/qwebpage/frametest/index.html.
  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::backActionUpdate):
(tst_QWebPage::frameAt):
(tst_QWebPage::errorPageExtensionInFrameset):
(tst_QWebPage::screenshot):

  • tests/qwebpage/tst_qwebpage.qrc:
  • tests/qwebplugindatabase/qwebplugindatabase.pro:
  • tests/qwebview/qwebview.pro:
  • tests/qwebview/resources/frame_a.html: Renamed from WebKit/qt/tests/qwebview/data/frame_a.html.
  • tests/qwebview/resources/index.html: Renamed from WebKit/qt/tests/qwebview/data/index.html.
  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::reusePage):
(tst_QWebView::crashTests):

  • tests/qwebview/tst_qwebview.qrc:
  • tests/resources/image2.png: Renamed from WebKit/qt/tests/qwebframe/resources/image2.png.
  • tests/tests.pri: Added.
  • tests/tests.pro:
6:44 AM Changeset in webkit [52443] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix non-ACCELERATED_COMPOSITING builds

  • WebPreferences.cpp:

(WebPreferences::acceleratedCompositingEnabled): Guard use of
WKCACFLayerRenderer with USE(ACCELERATED_COMPOSITING).

6:36 AM Changeset in webkit [52442] by Adam Roben
  • 7 edits in trunk/WebKit/win

Add IWebPreferencesPrivate::[set]AcceleratedCompositingEnabled

Fixes <​http://webkit.org/b/32745>.

Reviewed by Ada Chan.

  • Interfaces/IWebPreferencesPrivate.idl: Added

[set]AcceleratedCompositingEnabled.

  • Interfaces/WebKit.idl: Touched to force a build.
  • WebPreferenceKeysPrivate.h: Added

WebKitAcceleratedCompositingEnabledPreferenceKey.

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Make accelerated
compositing be on by default.
(WebPreferences::setAcceleratedCompositingEnabled): Store the new
value.
(WebPreferences::acceleratedCompositingEnabled): If accelerated
compositing isn't available, return false. Otherwise, return the value
stored in preferences.

  • WebPreferences.h: Added [set]AcceleratedCompositingAvailable.
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Just pass the value from
WebPreferences on down.

6:36 AM Changeset in webkit [52441] by Adam Roben
  • 2 edits in trunk/WebCore

Fix Windows build warnings

  • WebCore.vcproj/WebCore.vcproj: Exclude SVG files from the build that

are compiled via SVGAllInOne.cpp.

3:10 AM Changeset in webkit [52440] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-12-20 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Can’t copy outer html of selected node.
Also adds "Copy as HTML" context menu item.

​https://bugs.webkit.org/show_bug.cgi?id=32802

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  • inspector/front-end/inspector.js: (WebInspector.documentCanCopy):
3:00 AM Changeset in webkit [52439] by pfeldman@chromium.org
  • 6 edits
    3 adds in trunk/WebCore

2009-12-20 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Eric Seidel.

Web Inspector: extract syntax highlighters into separate files.

​https://bugs.webkit.org/show_bug.cgi?id=32803

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CSSSourceSyntaxHighlighter.js: Added. (WebInspector.CSSSourceSyntaxHighlighter):
  • inspector/front-end/JavaScriptSourceSyntaxHighlighter.js: Added. (WebInspector.JavaScriptSourceSyntaxHighlighter): (WebInspector.JavaScriptSourceSyntaxHighlighter.):
  • inspector/front-end/SourceFrame.js:
  • inspector/front-end/SourceSyntaxHighlighter.js: Added. (WebInspector.SourceSyntaxHighlighter): (WebInspector.SourceSyntaxHighlighter.prototype.createSpan): (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk): (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): (WebInspector.SourceSyntaxHighlighter.prototype.process): (WebInspector.SourceSyntaxHighlighter.prototype.lex): (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken): (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
1:48 AM Changeset in webkit [52438] by jchaffraix@webkit.org
  • 3 edits in trunk/WebCore

defersLoading is disabled in current libcURL.
​https://bugs.webkit.org/show_bug.cgi?id=32707

Patch by Julien Chaffraix <​jchaffraix@pleyo.com> on 2009-12-18
Reviewed by Darin Adler.

Basically this change reverts r49577 that was totally wrong.
According to curlver.h, LIBCURL_VERSION_NUM is a
"6-digit (24 bits) hexadecimal number".

The check should be against 0x071200 (7.18) as it was originally the case.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle): Use the right check.

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::setDefersLoading): Ditto. Also removed a print
to use a LOG_ERROR instead.

1:07 AM Changeset in webkit [52437] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-12-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Exception on queue status server
​https://bugs.webkit.org/show_bug.cgi?id=32812

Turns out we need to pass the id to the filter.

  • QueueStatusServer/filters/webkit_extras.py:
  • QueueStatusServer/templates/patch.html:
  • QueueStatusServer/templates/recentstatus.html:

Dec 20, 2009:

11:29 PM Changeset in webkit [52436] by hamaji@chromium.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-12-20 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Created "style" folder for code supporting check-webkit-style.

  • Scripts/modules/style: Added.
11:24 PM Changeset in webkit [52435] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: error when running commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=32806

Fix typo and add test!

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/bugzilla_unittest.py:
10:20 PM Changeset in webkit [52434] by tkent@chromium.org
  • 8 edits
    3 adds in trunk

2009-12-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

A test for Date binding.
​https://bugs.webkit.org/show_bug.cgi?id=32698

  • fast/forms/input-valueasdate-expected.txt: Added.
  • fast/forms/input-valueasdate.html: Added.
  • fast/forms/script-tests/input-valueasdate.js: Added.

2009-12-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Add support for JavaScriptCore Date binding.
​https://bugs.webkit.org/show_bug.cgi?id=32698

This is needed for HTMLInputElement::valueAsDate and
HTMLTimeElement::valueAsDate.

A Date instance is mapped to a double value in C++.

  • If null or undefined is set to a JavaScript property, C++ setter function receives NaN.
  • If a getter C++ function returns NaN or infinity, a JavaScript property returns null.

Test: fast/forms/input-valueasdate.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::jsDateOrNull): Implement the above. (WebCore::valueToDate): ditto.
  • bindings/js/JSDOMBinding.h: Declare them.
  • bindings/scripts/CodeGeneratorJS.pm: Produce jsDateOrNull() or valueToDate() for Date type.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Temporal implementation. (WebCore::HTMLInputElement::setValueAsDate): ditto.
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl: Declare valueAsDate.
10:16 PM Changeset in webkit [52433] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2009-12-20 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Darin Adler.

Removed outdated contact information from bug life cycle page.

​https://bugs.webkit.org/show_bug.cgi?id=32494

  • quality/lifecycle.html:
8:57 PM Changeset in webkit [52432] by eric@webkit.org
  • 11 edits in trunk/WebCore

2009-12-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Introduce the followings:

  • ::-webkit-inner-spin-button pseudo CSS selector
  • ::-webkit-outer-spin-button pseudo CSS selector
  • new appearance type: inner-spin-button
  • new appearance type: outer-spin-button

They're going to be used for <input type=number> UI.
​https://bugs.webkit.org/show_bug.cgi?id=31821

Inner-spin-button will be used for Windows, and outer-spin-button
will be used for Mac. A spin-button will represent a pair of an
increasing button part and a decreasing button part. SpinUpState,
which is defined in ThemeTypes.h, will be used to distinguish
these two parts.

The outer-spin-button implementation will use NSStepperCell.
NSStepperCell represents the pair of the parts and we can't draw them
independently. So a spin-button also represents the pair of the parts.

This change has no tests. The following changes with tests will cover.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • css/CSSValueKeywords.in:
  • css/html.css:
  • platform/ThemeTypes.h: (WebCore::ControlState): Add SpinUpState. (WebCore::ControlPart): Add InnerSpinButtonPart and OuterSpinButtonPart.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::adjustInnerSpinButtonStyle): Add an empty implementation. (WebCore::RenderTheme::adjustOuterSpinButtonStyle): Add an empty implementation.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintInnerSpinButton): Add an empty implementation. (WebCore::RenderTheme::paintOuterSpinButton): Add an empty implementation.
  • rendering/style/RenderStyleConstants.h: (WebCore::PseudoId): Add INNER_SPIN_BUTTON and OUTER_SPIN_BUTTON.
7:17 PM Changeset in webkit [52431] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-12-20 Nayan Kumar K <​nayankk@gmail.com>

Reviewed by Darin Adler.

Fix for compilation errors in WML module, due to the changeset #52314.
​https://bugs.webkit.org/show_bug.cgi?id=32786

No new tests, this is compilation error fix.

  • wml/WMLDocument.cpp:
  • wml/WMLPageState.cpp:
  • wml/WMLPageState.h:
6:57 PM Changeset in webkit [52430] by abarth@webkit.org
  • 8 edits
    1 copy
    1 add in trunk/WebKitTools

2009-12-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Optimize status updates for new dashboard
​https://bugs.webkit.org/show_bug.cgi?id=32797

This patch makes the queues slightly more chatty with the web service.
Also, this patch introduces some testing for the queues!

  • Scripts/modules/commands/early_warning_system.py:
  • Scripts/modules/commands/early_warning_system_unittest.py: Added.
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/queues_unittest.py:
  • Scripts/modules/commands/queuestest.py: Added.
  • Scripts/modules/mock_bugzillatool.py:
  • Scripts/modules/patchcollection.py:
  • Scripts/modules/queueengine.py:
  • Scripts/run-webkit-unittests:
6:42 PM Changeset in webkit [52429] by eric@webkit.org
  • 3 edits
    2 adds
    1 delete in trunk/WebKitTools

2009-12-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Prepare QueueStatusServer for new status messages
​https://bugs.webkit.org/show_bug.cgi?id=32805

  • QueueStatusServer/handlers/recentstatus.py:
  • QueueStatusServer/index.html: Removed.
  • QueueStatusServer/model/attachment.py:
  • QueueStatusServer/model/queues.py: Added.
  • QueueStatusServer/templates/recentstatus.html: Added.
3:51 PM Changeset in webkit [52428] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-12-20 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Unset the adjustments in our FrameView when detaching from
parent. Fixes some crashers when transitioning to a new page from
a scrolled page.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::detachedFromParent2):
2:00 PM QtWebKitAPI edited by Simon Hausmann
(diff)
12:50 PM Changeset in webkit [52427] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7487689> REGRESSION (r52203): Inspector console uses
Monaco on Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=32775

Reviewed by Mark Rowe.

  • inspector/front-end/inspector.css: Use the default monospace family

and size.

12:07 PM Changeset in webkit [52426] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

Remove emission of signal that does not exist.

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::webViewDestroyed):

11:31 AM Changeset in webkit [52425] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

Provides a new API to copy WebKitWebHistoryItem objects.

  • webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_copy):

  • webkit/webkitwebhistoryitem.h:
10:46 AM Changeset in webkit [52424] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-12-20 Xan Lopez <​xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Disable the page cache by default since:

  • It was previously off by default.
  • There are still some issues when enabling it.
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
10:22 AM Changeset in webkit [52423] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-20 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Adam Barth.

[check-webkit-style] static_cast is not misnamed!
​https://bugs.webkit.org/show_bug.cgi?id=32796

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
10:07 AM Changeset in webkit [52422] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-12-20 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Make sure we get the URI that is being loaded when updating
WebKitWebFrame's knowledge of it. This was causing problems now
that page cache is enabled.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
  • tests/testloading.c: (load_goback_status_changed_cb): (load_wentback_status_changed_cb): (test_loading_goback): (main):
9:39 AM Changeset in webkit [52421] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-12-20 Martin Robinson <​martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] Remove more GTK+ and GLib headers from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=32795

Remove most GTK+ and GLib includes from WebCore headers.

  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/gtk/PasteboardHelper.h:
  • platform/gtk/RenderThemeGtk.cpp:
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/ScrollbarGtk.cpp:
  • platform/gtk/ScrollbarThemeGtk.h:
  • platform/gtk/gtk2drawing.c:
  • platform/gtk/gtkdrawing.h:
9:06 AM Changeset in webkit [52420] by kevino@webkit.org
  • 8 edits in trunk

[wx] build fixes after recent changes.

8:26 AM Changeset in webkit [52419] by eric@webkit.org
  • 5 edits in trunk

2009-12-20 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
​https://bugs.webkit.org/show_bug.cgi?id=32788

Avoid using fixed values when moving mouse.

  • platform/gtk/editing/pasteboard/middle-button-paste-expected.txt:
  • platform/gtk/editing/pasteboard/middle-button-paste.html:

2009-12-20 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
​https://bugs.webkit.org/show_bug.cgi?id=32788

Do not increase the click count if we are using a different button.

  • DumpRenderTree/gtk/EventSender.cpp:
7:53 AM Changeset in webkit [52418] by eric@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-12-20 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Cache control APIs
​https://bugs.webkit.org/show_bug.cgi?id=24001

Original patch by Bobby Powers <​bobby@laptop.org>

Added new API to specify cache models for GTK port.

  • webkit/webkitprivate.cpp: (webkit_init): set a default cache model.
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h: (webkit_set_cache_model): Added function. (webkit_get_cache_model): Added function.
7:45 AM Changeset in webkit [52417] by kov@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Xan Lopez.

Hopefully fix the assertion we are hitting by not forcing updating
the state of scrollbars when setting the adjustments. This was
leading to a premature layout.

fast/dom/open-and-close-by-DOM.html
fast/dom/Window/closure-access-after-navigation-window.html
fast/harness/use-page-cache.html

  • platform/gtk/ScrollViewGtk.cpp:

(WebCore::ScrollView::setGtkAdjustments):

4:58 AM Changeset in webkit [52416] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-12-20 Xan Lopez <​xlopez@igalia.com>

Revert the previous patch, it introduces some failures in the
bots.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
4:41 AM Changeset in webkit [52415] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2009-12-20 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Darin Adler.

Web Inspector: Constrain the number of messages the inspector shows.

​https://bugs.webkit.org/show_bug.cgi?id=20919

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/inspector.js: (WebInspector.updateConsoleMessageExpiredCount):
4:27 AM Changeset in webkit [52414] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-12-20 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] crash when loading new page
​https://bugs.webkit.org/show_bug.cgi?id=32752

Wait until the document is attached to adjust our alignments,
since we need to make sure the FrameView in the document content
render object matches the newly created FrameView for the new
page, otherwise we'll try to relayout the wrong view.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
4:18 AM Changeset in webkit [52413] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2009-12-20 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

  • platform/gtk/editing/pasteboard/middle-button-paste-expected.txt:
  • platform/gtk/editing/pasteboard/middle-button-paste.html:
4:02 AM Changeset in webkit [52412] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

Create a new WebKitDataSource object when attaching to a frame, if
one does not exist. This may happen when we are fetching data from
the page cache.

  • WebCoreSupport/DocumentLoaderGtk.cpp:

(WebKit::DocumentLoader::attachToFrame):
(WebKit::DocumentLoader::unrefDataSource):

2:46 AM Changeset in webkit [52411] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Rubber-stamped by Xan Lopez.

Make sure the text encoding machinery is initialized from the main
frame, before opening the icon database.

  • webkit/webkitprivate.cpp:

(webkit_init):

2:27 AM Changeset in webkit [52410] by eric@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

2009-12-20 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Darin Adler.

Upstreaming two plugin tests from chromium.org.
​https://bugs.webkit.org/show_bug.cgi?id=32750

  • plugins/get-file-url-expected.txt: Added.
  • plugins/get-file-url.html: Added.
  • plugins/get-url-with-iframe-target-expected.txt: Added.
  • plugins/get-url-with-iframe-target.html: Added.
  • plugins/resources/get-file-url-subframe.html: Added.
2:18 AM Changeset in webkit [52409] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-12-20 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Darin Adler.

Upstream a test from chromium.org that verifies that calling
document.clear() from an external script doesn't crash the browser.
​https://bugs.webkit.org/show_bug.cgi?id=32743

  • fast/dom/document-clear-expected.txt: Added.
  • fast/dom/document-clear.html: Added.
  • fast/dom/resources/document-clear.js: Added.
2:10 AM Changeset in webkit [52408] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-12-20 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32735

Upstream a test from chromium.org - ensure that creating a
new Image is actually creating an HTML image element, regardless
of the doctype.

  • svg/custom/new-image-is-html-element-expected.txt: Added.
  • svg/custom/new-image-is-html-element.svg: Added.
2:01 AM Changeset in webkit [52407] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-12-20 Dirk Pranke <​dpranke@fila-macpro.mtv.corp.google.com>

Reviewed by Darin Adler.

upstream test from chromium.org - this tests simulating italic
on glyphs that don't have an italic version.

​https://bugs.webkit.org/show_bug.cgi?id=32693

  • fast/text/fake-italic.html: Added.
  • platform/mac/fast/text/fake-italic-expected.checksum: Added.
  • platform/mac/fast/text/fake-italic-expected.png: Added.
  • platform/mac/fast/text/fake-italic-expected.txt: Added.
1:52 AM Changeset in webkit [52406] by eric@webkit.org
  • 3 edits
    2 copies in trunk/WebCore

2009-12-20 Andrei Popescu <​andreip@google.com>

Reviewed by Adam Barth.

[Android] Android needs implementation of setCookies, cookies and cookiesEnabled functions.
​https://bugs.webkit.org/show_bug.cgi?id=32559

Add implementation of the cookie functions.
Fix a crash caused by dereferencing a 0 MainResourceLoader pointer
in ResourceHandle::start().

No new tests, this is platform code.

  • platform/android/PlatformBridge.h:
  • platform/network/android/AuthenticationChallenge.h: Added.
  • platform/network/android/CookieJarAndroid.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
  • platform/network/android/ResourceHandleAndroid.cpp: (WebCore::ResourceHandle::start):
1:47 AM Changeset in webkit [52405] by abarth@webkit.org
  • 7 edits
    1 copy
    1 add in trunk/WebKitTools

2009-12-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[QueueStatusServer] Add a per-patch details page
​https://bugs.webkit.org/show_bug.cgi?id=32784

This is a first cut at a per-patch details page. I'm sure we'll have
to iterate.

  • QueueStatusServer/filters/webkit_extras.py:
  • QueueStatusServer/handlers/patch.py: Added.
  • QueueStatusServer/index.yaml:
  • QueueStatusServer/main.py:
  • QueueStatusServer/model/attachment.py:
  • QueueStatusServer/stylesheets/dashboard.css:
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/patch.html: Added.
12:27 AM Changeset in webkit [52404] by abarth@webkit.org
  • 4 edits
    1 add in trunk/WebKitTools

2009-12-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Use memcache to make dashboard to fast
​https://bugs.webkit.org/show_bug.cgi?id=32780

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/handlers/dashboard.py:
  • QueueStatusServer/handlers/updatestatus.py:
  • QueueStatusServer/model/attachment.py: Added.
Note: See TracTimeline for information about the timeline view.