Timeline
Dec 25, 2009:
- 9:26 PM Changeset in webkit [52564] by
-
- 7 edits5 adds in trunk
2009-12-25 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Implement HTML5 section element.
https://bugs.webkit.org/show_bug.cgi?id=32936
<section> should behave the same as <nav>.
Test: fast/html/section-element.html
- css/html.css: Add section as a block element.
- editing/htmlediting.cpp: (WebCore::validBlockTag): Add sectionTag.
- html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for sectionTag. (WebCore::blockTagList): Add sectionTag.
- html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add sectionTag.
- html/HTMLTagNames.in: Add section.
2009-12-25 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Implement HTML5 section element.
https://bugs.webkit.org/show_bug.cgi?id=32936
The new test file tests:
- <p> closing,
- Residual style, and
- FormatBlock.
- fast/html/script-tests/TEMPLATE.html: Added.
- fast/html/script-tests/section-element.js: Added.
- fast/html/section-element-expected.txt: Added.
- fast/html/section-element.html: Added.
- 8:34 PM Changeset in webkit [52563] by
-
- 2 edits in trunk/WebKit
- StringsNotToBeLocalized.txt: Updated for recent changes.
- 3:58 PM Changeset in webkit [52562] by
-
- 2 edits in trunk/WebKitTools
2009-12-25 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Fixes an issue where checkFrameworks always dies with an error under Windows
since the clause "unless (-x $path)" is always satisfied because files under
Windows do not have an explict executable bit.
- Scripts/webkitdirs.pm:
- 3:32 PM Changeset in webkit [52561] by
-
- 3 edits in trunk/WebCore
2009-12-25 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Cleans up XSSAuditor.
Currently, we pass various parameters through to XSSAuditor::findInRequest
that are used to determine how to decode the HTTP input parameters so that
we can perform a match against the script source. Instead, we have defined
a structure XSSAuditor::FindTask that can hold all of these parameters.
No functionality was changed. So, no new tests.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): Modified to use struct XSSAuditor::FindTask. (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Ditto. (WebCore::XSSAuditor::canCreateInlineEventListener): Ditto. (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Ditto. (WebCore::XSSAuditor::canLoadObject): Ditto. (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. (WebCore::XSSAuditor::findInRequest): Ditto.
- page/XSSAuditor.h: (WebCore::XSSAuditor::FindTask::FindTask): Added.
- 3:11 PM Changeset in webkit [52560] by
-
- 5 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] svg/custom/global-constructors.html skipped
temporarily (until fix) because of missing variables.
Platform dependent expected files updated after r52559.
https://bugs.webkit.org/show_bug.cgi?id=32941
- platform/qt/Skipped: svg/custom/global-constructors.html added until fix.
- platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
- platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
- platform/qt/fast/js/global-constructors-expected.txt: updated.
- 3:08 PM BuildingGtk edited by
- (diff)
- 1:03 PM Changeset in webkit [52559] by
-
- 11 edits3 adds in trunk
2009-12-25 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
DOMWindow is missing lots of SVG* constructor objects
https://bugs.webkit.org/show_bug.cgi?id=20430
Expose all implemented SVG 1.1 constructors.
Test: svg/custom/global-constructors.js
- bindings/v8/V8Index.cpp: Add missing includes for SVGFontFaceElement & SVGMissingGlyphElement
- bindings/v8/V8Index.h: Add misisng SVGFontFaceElement & SVGMissingGlyphElement declarations.
- page/DOMWindow.idl: Add a bunch of new SVG object ctors.
- svg/SVGAnimatedPathData.idl: Add OmitConstructor flag, as this is a SVG MI class, which is not exposable at the moment.
- svg/SVGAnimatedPoints.idl: Ditto.
- 6:58 AM Changeset in webkit [52558] by
-
- 7 edits4 adds in trunk/WebCore
2009-12-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
AuditsPanel for Web Inspector (hidden, no preset audits).
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/AuditLauncherView.js: Added. (WebInspector.AuditLauncherView.categorySortFunction): (WebInspector.AuditLauncherView): (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState): (WebInspector.AuditLauncherView.prototype._setAuditRunning): (WebInspector.AuditLauncherView.prototype._launchButtonClicked.profilingFinishedCallback): (WebInspector.AuditLauncherView.prototype._launchButtonClicked): (WebInspector.AuditLauncherView.prototype._selectAllClicked): (WebInspector.AuditLauncherView.prototype._categoryClicked): (WebInspector.AuditLauncherView.prototype._createCategoryElement): (WebInspector.AuditLauncherView.prototype._createLauncherUI): (WebInspector.AuditLauncherView.prototype._updateButton): (WebInspector.AuditLauncherView.prototype.resize):
- inspector/front-end/AuditResultView.js: Added. (WebInspector.AuditResultView.entrySortFunction): (WebInspector.AuditResultView): (WebInspector.AuditCategoryResultPane): (WebInspector.AuditRuleResultPane): (WebInspector.AuditRuleResultPane.prototype._decorateRuleResult): (WebInspector.AuditRuleResultChildSection): (WebInspector.AuditRuleResultChildSection.prototype.set title): (WebInspector.AuditRuleResultChildSection.prototype.expand):
- inspector/front-end/AuditsPanel.js: Added. (WebInspector.AuditsPanel): (WebInspector.AuditsPanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.AuditsPanel.prototype.get statusBarItems): (WebInspector.AuditsPanel.prototype.get mainResourceLoadTime): (WebInspector.AuditsPanel.prototype.set mainResourceLoadTime): (WebInspector.AuditsPanel.prototype.get mainResourceDOMContentTime): (WebInspector.AuditsPanel.prototype.set mainResourceDOMContentTime): (WebInspector.AuditsPanel.prototype.get categoriesById): (WebInspector.AuditsPanel.prototype.get visibleView): (WebInspector.AuditsPanel.prototype._constructCategories): (WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback): (WebInspector.AuditsPanel.prototype._executeAudit): (WebInspector.AuditsPanel.prototype._auditFinishedCallback): (WebInspector.AuditsPanel.prototype.initiateAudit.initiateAuditCallback): (WebInspector.AuditsPanel.prototype.initiateAudit): (WebInspector.AuditsPanel.prototype._reloadResources): (WebInspector.AuditsPanel.prototype._didMainResourceLoad): (WebInspector.AuditsPanel.prototype.showResults): (WebInspector.AuditsPanel.prototype.showLauncherView): (WebInspector.AuditsPanel.prototype.showView): (WebInspector.AuditsPanel.prototype.show): (WebInspector.AuditsPanel.prototype.attach): (WebInspector.AuditsPanel.prototype.resize): (WebInspector.AuditsPanel.prototype.updateMainViewWidth): (WebInspector.AuditsPanel.prototype._updateLauncherViewControls): (WebInspector.AuditsPanel.prototype._clearButtonClicked): (WebInspector.AuditsPanel.prototype._closeVisibleView): (WebInspector.AuditCategory): (WebInspector.AuditCategory.prototype.get id): (WebInspector.AuditCategory.prototype.get displayName): (WebInspector.AuditCategory.prototype.get ruleCount): (WebInspector.AuditCategory.prototype.addRule): (WebInspector.AuditCategory.prototype.runRules): (WebInspector.AuditRule): (WebInspector.AuditRule.prototype.get id): (WebInspector.AuditRule.prototype.get displayName): (WebInspector.AuditRule.prototype.run): (WebInspector.AuditRule.prototype.doRun): (WebInspector.AuditRule.prototype.getValue): (WebInspector.AuditCategoryResult): (WebInspector.AuditCategoryResult.prototype.addEntry): (WebInspector.AuditRuleResult): (WebInspector.AuditRuleResult.prototype.appendChild): (WebInspector.AuditRuleResult.prototype.set type): (WebInspector.AuditRuleResult.prototype.get type): (WebInspector.AuditsSidebarTreeElement): (WebInspector.AuditsSidebarTreeElement.prototype.onattach): (WebInspector.AuditsSidebarTreeElement.prototype.onselect): (WebInspector.AuditsSidebarTreeElement.prototype.get selectable): (WebInspector.AuditsSidebarTreeElement.prototype.refresh): (WebInspector.AuditResultSidebarTreeElement): (WebInspector.AuditResultSidebarTreeElement.prototype.onselect): (WebInspector.AuditResultSidebarTreeElement.prototype.get selectable):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/audits.css: Added.
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.updateResource):
- 6:37 AM Changeset in webkit [52557] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
LayoutTests/inspector/settings-set-get.html removed
by r52547, it should be removed from skiplist.
- platform/qt/Skipped: inspector/settings-set-get.html removed.
- 6:24 AM Changeset in webkit [52556] by
-
- 15 edits in trunk/WebCore
2009-12-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement Edit Inner HTML action.
- English.lproj/localizedStrings.js:
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::pushNodePathToFrontend):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::pushNodePathToFrontendCallback):
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodePathToFrontend):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorDOMAgent.h:
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.show): (WebInspector.ElementsPanel.prototype._updateModifiedNodesSoon): (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.commit): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML): ():
- inspector/front-end/InjectedScript.js: (InjectedScript.getNodePropertyValue): (InjectedScript.setOuterHTML): (InjectedScript.performSearch.addNodesToResults): (InjectedScript._inspectObject): (InjectedScript._copy): (InjectedScript.pushNodeToFrontend):
- inspector/front-end/InjectedScriptAccess.js:
- inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels): (.WebInspector.InspectorFrontendHostStub.prototype.windowUnloading):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
Dec 24, 2009:
- 11:23 PM BuildingGtk edited by
- Added notice about required libsoup >= 2.28.2 due to change-set 52208 (diff)
- 10:07 PM Changeset in webkit [52555] by
-
- 2 edits in trunk/WebCore
Web Inspector: Console should force long URLs to wrap
https://bugs.webkit.org/show_bug.cgi?id=32927
Reviewed by Timothy Hatcher.
- inspector/front-end/inspector.css: Added "word-wrap: break-word;" to
the #console-messages rule.
- 7:25 PM Changeset in webkit [52554] by
-
- 2 edits in trunk/WebCore
2009-12-24 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed Chromium test fix by reverting r52536.
Do not a new Database pointer to any structure until its version has been verified
https://bugs.webkit.org/show_bug.cgi?id=32913
- storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
- 5:15 PM Changeset in webkit [52553] by
-
- 2 edits in trunk/LayoutTests
2009-12-24 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Remove LayoutTests/storage/change-version.html from Qt Skipped list
LayoutTests/storage/change-version.html now passes.
Probably related to the fix in https://bugs.webkit.org/show_bug.cgi?id=32437.
- platform/qt/Skipped:
- 11:41 AM Changeset in webkit [52552] by
-
- 2 edits in trunk/WebKit/qt
Reviewed by Gustavo Noronha.
Doc : QGraphicsWebView::zoomFactor was introduced in 4.6.
- 9:34 AM Changeset in webkit [52551] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-24 Laszlo Gombos <Laszlo Gombos>
Unreviewed; revert of r52550.
The change regressed the following LayoutTests for QtWebKit.
fast/workers/worker-call.html -> crashed
fast/workers/worker-close.html -> crashed
- wtf/qt/ThreadingQt.cpp: (WTF::waitForThreadCompletion): (WTF::detachThread):
- 9:03 AM Changeset in webkit [52550] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-24 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix memory leak by deleting instance of ThreadPrivate
in function waitForThreadCompletion(), synchronously, or in
detachThread(), asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=32614
- wtf/qt/ThreadingQt.cpp: (WTF::waitForThreadCompletion): (WTF::detachThread):
- 6:12 AM Changeset in webkit [52549] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-24
[Qt] Skip failing test until a solution for layoutTestController.notifyDone() is found.
https://bugs.webkit.org/show_bug.cgi?id=31626
- platform/qt/Skipped: inspector/console-clear.html skipped
- 5:46 AM Changeset in webkit [52548] by
-
- 7 edits7 adds in trunk
Fix for WebKit bug 29968 - Selecting text with text-overflow ellipsis
should not show cut off text
https://bugs.webkit.org/show_bug.cgi?id=29968
Reviewed by Dan Bernstein.
Also fixes the issue on both Mac OS X and Windows where the highlight
would extend only partway into the ellipsis based on the size of the
characters being truncated.
Test: editing/selection/select-text-overflow-ellipsis.html
WebCore:
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): When the ellipsis have been selected, paints them with the color for selected text. (WebCore::EllipsisBox::selectionRect): Returns the selection rect for the ellipsis text. (WebCore::EllipsisBox::paintSelection): Paints the selection highlight around the ellipsis text.
- rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox): Default the selection state of the EllipsisBox to SelectionNone. (WebCore::EllipsisBox::setSelectionState): Allow the selection state to be explicitly set by the InlineTextBox that it is associated with, since the selection state depends on the position of the selection within the truncated text. (WebCore::EllipsisBox::selectionState): Return the cached selection state.
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): If the text is truncated and the selection extends into the truncation where there are ellipsis, set the selection state on the EllipsisBox. (WebCore::paintTextWithShadows): Allow for an upper bound to be specified on the maximum length of the text to be painted. (WebCore::InlineTextBox::paint): Make sure the text that is drawn gets appropriately truncated. This was not an issue before on Mac OS X because it wasn't necessary to draw the selected text separately (the selected text had the same color as the non-selected text). (WebCore::InlineTextBox::paintSelection): If the text is being truncated, let whatever is being painted in the space after the truncated text paint its own highlight.
- rendering/InlineTextBox.h: (WebCore::InlineTextBox::truncation): Allow RenderText to access the truncation status.
- rendering/RenderText.cpp: (WebCore::RenderText::selectionRectForRepaint): Make sure that any ellipsis box that falls within the selection also gets repainted.
Places the expected results under the mac and win platforms separately
because they are pixel test results and also the size of the
RenderBlocks are showing up as slightly different between mac and win.
LayoutTests:
- editing/selection/select-text-overflow-ellipsis.html: Added.
- platform/mac/editing/selection/select-text-overflow-ellipsis-expected.checksum: Added.
- platform/mac/editing/selection/select-text-overflow-ellipsis-expected.png: Added.
- platform/mac/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
- platform/win/editing/selection/select-text-overflow-ellipsis-expected.checksum: Added.
- platform/win/editing/selection/select-text-overflow-ellipsis-expected.png: Added.
- platform/win/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
- 4:33 AM Changeset in webkit [52547] by
-
- 24 edits1 add2 deletes in trunk
2009-12-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add Settings.js class that would manage
frontend settings.
This change:
- Splits preferences and settings
- Pushes settings to the frontend on load
- Stores settings on each change
- Stores showInheritedStyles as setting.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::saveFrontendSettings):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::populateFrontendSettings):
- inspector/InspectorFrontend.h:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype._settingsLoaded): (WebInspector.EventListenersSidebarPane.prototype): ():
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.saveFrontendSettings): (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
- inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub): (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createStatusbarButtons): (WebInspector.ResourcesPanel.prototype._settingsLoaded): (WebInspector.ResourcesPanel.prototype._toggleLargerResources): (WebInspector.ResourcesPanel.prototype._setLargerResources):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
- inspector/front-end/Settings.js: Added. (WebInspector.populateFrontendSettings): (WebInspector.Settings): (WebInspector.Settings.prototype._load): (WebInspector.Settings.prototype._installSetting): (WebInspector.Settings.prototype._get): (WebInspector.Settings.prototype._set):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._settingsLoaded): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._changeSetting): (WebInspector.StylesSidebarPane.prototype._changeColorFormat): (WebInspector.StylePropertiesSection.showInheritedToggleFunction): (WebInspector.StylePropertiesSection):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded): (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions): (WebInspector.WatchExpressionsSection): (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded):
- 3:12 AM Changeset in webkit [52546] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-24 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: follow up to r52545, adding missing tests.
- inspector/console-clear-expected.txt: Added.
- inspector/console-clear.html: Added.
- 3:05 AM Changeset in webkit [52545] by
-
- 15 edits in trunk
2009-12-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: [REGRESSION] console's clear command does not work.
Test: inspector/console-clear.html
WebCore:
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::clearConsoleMessages):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp:
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorController.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype.requestClearConsoleMessages): (WebInspector.ConsoleView.prototype.clearConsoleMessages): (WebInspector.ConsoleView.prototype._clearButtonClicked):
- inspector/front-end/InjectedScript.js: (InjectedScript.clearConsoleMessages): (InjectedScript._ensureCommandLineAPIInstalled):
- inspector/front-end/InjectedScriptAccess.js:
- inspector/front-end/inspector.js: (WebInspector.clearConsoleMessages): (WebInspector.reset):
LayoutTests:
- inspector/console-clear-expected.txt: Added.
- inspector/console-clear.html: Added.
- inspector/console-tests.js: (dumpConsoleMessages.callback): (dumpConsoleMessages):
- 2:38 AM Changeset in webkit [52544] by
-
- 10 edits in trunk
2009-12-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Console dumps strings in escaped form.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatIndividualValue):
- inspector/console-format-expected.txt:
