⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 26, 2009:

11:36 PM Changeset in webkit [52569] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-26 Eric Seidel <eric@webkit.org>

No review, rolling out r52554.
http://trac.webkit.org/changeset/52554

https://bugs.webkit.org/show_bug.cgi?id=32955
The original change was covered under
https://bugs.webkit.org/show_bug.cgi?id=32913

r52554 was itself a rollout of r52536.
However it caused two layout tests to fail on Leopard:
storage/open-database-while-transaction-in-progress.html
svg/W3C-SVG-1.1/filters-conv-01-f.svg (no clue why?)

So I'm rolling out the rollout in an attempt to get the bots green.
r52554 did not explain why it was rolled out, so I do not know
what might fail for Chromium after this change. I warned the folks
in #chromium that it was coming.

  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
10:50 PM Changeset in webkit [52568] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Make the qt build go fast
https://bugs.webkit.org/show_bug.cgi?id=32951

Make use of multiple cores, if available.

  • Scripts/modules/webkitport.py:
7:35 PM QtBackLog edited by zecke@selfish.org
(diff)
5:28 PM Changeset in webkit [52567] by mitz@apple.com
  • 2 edits in trunk

Added Radar URLs

5:27 PM Changeset in webkit [52566] by mitz@apple.com
  • 3 edits
    4 adds in trunk

REGRESSION (r47255): Extra Large Amount of Empty Space
https://bugs.webkit.org/show_bug.cgi?id=32690

Reviewed by Sam Weinig.

WebCore:

Test: fast/block/float/clear-to-fit.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::getClearDelta): Only clear floats as needed to
fit the child on the line.

LayoutTests:

  • fast/block/float/clear-to-fit-expected.checksum: Added.
  • fast/block/float/clear-to-fit-expected.png: Added.
  • fast/block/float/clear-to-fit-expected.txt: Added.
  • fast/block/float/clear-to-fit.html: Added.
1:40 AM Changeset in webkit [52565] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] Skipping some flakey tests.
https://bugs.webkit.org/show_bug.cgi?id=32946

  • platform/qt/Skipped:
    • http/tests/cookies/simple-cookies-expired.html added.
    • storage/database-lock-after-reload.html added.
    • storage/empty-statement.html added.
    • storage/execute-sql-args.html added.
    • storage/hash-change-with-xhr.html added.

Dec 25, 2009:

9:26 PM Changeset in webkit [52564] by tkent@chromium.org
  • 7 edits
    5 adds in trunk

2009-12-25 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Implement HTML5 section element.
https://bugs.webkit.org/show_bug.cgi?id=32936

<section> should behave the same as <nav>.

Test: fast/html/section-element.html

  • css/html.css: Add section as a block element.
  • editing/htmlediting.cpp: (WebCore::validBlockTag): Add sectionTag.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for sectionTag. (WebCore::blockTagList): Add sectionTag.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add sectionTag.
  • html/HTMLTagNames.in: Add section.

2009-12-25 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Implement HTML5 section element.
https://bugs.webkit.org/show_bug.cgi?id=32936

The new test file tests:

  • <p> closing,
  • Residual style, and
  • FormatBlock.
  • fast/html/script-tests/TEMPLATE.html: Added.
  • fast/html/script-tests/section-element.js: Added.
  • fast/html/section-element-expected.txt: Added.
  • fast/html/section-element.html: Added.
8:34 PM Changeset in webkit [52563] by Darin Adler
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Updated for recent changes.
3:58 PM Changeset in webkit [52562] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-25 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32682

Fixes an issue where checkFrameworks always dies with an error under Windows
since the clause "unless (-x $path)" is always satisfied because files under
Windows do not have an explict executable bit.

  • Scripts/webkitdirs.pm:
3:32 PM Changeset in webkit [52561] by dbates@webkit.org
  • 3 edits in trunk/WebCore

2009-12-25 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=32938

Cleans up XSSAuditor.

Currently, we pass various parameters through to XSSAuditor::findInRequest
that are used to determine how to decode the HTTP input parameters so that
we can perform a match against the script source. Instead, we have defined
a structure XSSAuditor::FindTask that can hold all of these parameters.

No functionality was changed. So, no new tests.

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): Modified to use struct XSSAuditor::FindTask. (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Ditto. (WebCore::XSSAuditor::canCreateInlineEventListener): Ditto. (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Ditto. (WebCore::XSSAuditor::canLoadObject): Ditto. (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. (WebCore::XSSAuditor::findInRequest): Ditto.
  • page/XSSAuditor.h: (WebCore::XSSAuditor::FindTask::FindTask): Added.
3:11 PM Changeset in webkit [52560] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] svg/custom/global-constructors.html skipped
temporarily (until fix) because of missing variables.
Platform dependent expected files updated after r52559.

https://bugs.webkit.org/show_bug.cgi?id=32941

  • platform/qt/Skipped: svg/custom/global-constructors.html added until fix.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
  • platform/qt/fast/js/global-constructors-expected.txt: updated.
3:08 PM BuildingGtk edited by jgeboski@gmail.com
(diff)
1:03 PM Changeset in webkit [52559] by Nikolas Zimmermann
  • 11 edits
    3 adds in trunk

2009-12-25 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

DOMWindow is missing lots of SVG* constructor objects
https://bugs.webkit.org/show_bug.cgi?id=20430

Expose all implemented SVG 1.1 constructors.

Test: svg/custom/global-constructors.js

  • bindings/v8/V8Index.cpp: Add missing includes for SVGFontFaceElement & SVGMissingGlyphElement
  • bindings/v8/V8Index.h: Add misisng SVGFontFaceElement & SVGMissingGlyphElement declarations.
  • page/DOMWindow.idl: Add a bunch of new SVG object ctors.
  • svg/SVGAnimatedPathData.idl: Add OmitConstructor flag, as this is a SVG MI class, which is not exposable at the moment.
  • svg/SVGAnimatedPoints.idl: Ditto.
6:58 AM Changeset in webkit [52558] by pfeldman@chromium.org
  • 7 edits
    4 adds in trunk/WebCore

2009-12-25 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

AuditsPanel for Web Inspector (hidden, no preset audits).

https://bugs.webkit.org/show_bug.cgi?id=31665

6:37 AM Changeset in webkit [52557] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

LayoutTests/inspector/settings-set-get.html removed
by r52547, it should be removed from skiplist.

  • platform/qt/Skipped: inspector/settings-set-get.html removed.
6:24 AM Changeset in webkit [52556] by pfeldman@chromium.org
  • 15 edits in trunk/WebCore

2009-12-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement Edit Inner HTML action.

https://bugs.webkit.org/show_bug.cgi?id=32924

  • English.lproj/localizedStrings.js:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::pushNodePathToFrontend):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::pushNodePathToFrontendCallback):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodePathToFrontend):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.show): (WebInspector.ElementsPanel.prototype._updateModifiedNodesSoon): (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.commit): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML): ():
  • inspector/front-end/InjectedScript.js: (InjectedScript.getNodePropertyValue): (InjectedScript.setOuterHTML): (InjectedScript.performSearch.addNodesToResults): (InjectedScript._inspectObject): (InjectedScript._copy): (InjectedScript.pushNodeToFrontend):
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels): (.WebInspector.InspectorFrontendHostStub.prototype.windowUnloading):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
Note: See TracTimeline for information about the timeline view.