Context Navigation

bindings/scripts/CodeGeneratorV8.pm: Added GenerateImplementationMasqueradeAsUndefined.
bindings/v8/DerivedSourcesAllInOne.cpp: Touched to keep IB-based builds happy.
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed hand-configuring.

3:08 PM Changeset in webkit [52673] by eric@webkit.org

15 edits in trunk

2009-12-30 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by Dimitri Glazkov.

Autocomplete in Chromium now offers suggestions within the input element as a user
a) types text that produces some autocomplete suggestions, and
b) scrolls through suggested values in the menu
The suggested value is rendered but not exposed through JS unti the
user makes the final selection.

No new tests since this new functionality (autocomplete suggestions)
is intentionally hidden from everything else than renderer.

src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::initialize): (WebKit::AutocompletePopupMenuClient::setInitialAutocompleteValue): (WebKit::AutocompletePopupMenuClient::selectionChanged): (WebKit::AutocompletePopupMenuClient::popupDidHide): (WebKit::AutocompletePopupMenuClient::setTextFromItem): (WebKit::AutocompletePopupMenuClient::resetLastFieldValue):
src/AutocompletePopupMenuClient.h:

2009-12-30 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by Dimitri Glazkov.

Added ability for PopupMenuClient to signal when
a) selection changed, and
b) weather suggested value should be accepted when popup menu closes

No new tests since this new functionality (autocomplete suggestions)
is intentionally hidden from everything else than renderer.

platform/PopupMenuClient.h:
platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::hidePopup): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::clearSelection): (WebCore::PopupListBox::hidePopup):
platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::menuUnmapped):
platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
platform/qt/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::hidePopup):
platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::hide):
platform/wx/PopupMenuWx.cpp: (WebCore::PopupMenu::OnMenuItemSelected):
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::popupDidHide):
rendering/RenderMenuList.h: (WebCore::RenderMenuList::selectionChanged):
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::popupDidHide):
rendering/RenderTextControlSingleLine.h: (WebCore::RenderTextControlSingleLine::selectionChanged):

1:59 PM Changeset in webkit [52672] by Nate Chapin

25 edits
1 delete in trunk/WebCore

2009-12-30 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Auto-generate V8 bindings header declarations for
property accessor getter/setters, and remove a couple of
unnecessarily custom bindings that weren't properly declared
custom anyway.

Android.v8bindings.mk: Remove V8NavigatorCustom.cpp.
WebCore.gypi: Remove V8NavigatorCustom.cpp.
bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/V8DOMWrapper.cpp:
bindings/v8/custom/V8AttrCustom.cpp:
bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
bindings/v8/custom/V8ClipboardCustom.cpp:
bindings/v8/custom/V8CoordinatesCustom.cpp:
bindings/v8/custom/V8CustomBinding.cpp:
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8DOMWindowCustom.cpp:
bindings/v8/custom/V8DocumentCustom.cpp:
bindings/v8/custom/V8DocumentLocationCustom.cpp:
bindings/v8/custom/V8EventCustom.cpp:
bindings/v8/custom/V8HTMLDocumentCustom.cpp:
bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
bindings/v8/custom/V8HTMLInputElementCustom.cpp:
bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
bindings/v8/custom/V8LocationCustom.cpp:
bindings/v8/custom/V8MessageEventCustom.cpp:
bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
bindings/v8/custom/V8SVGLengthCustom.cpp:
bindings/v8/custom/V8WorkerContextCustom.cpp:
bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

1:24 PM Changeset in webkit [52671] by eric@webkit.org

4 edits
1 move in trunk/LayoutTests

2009-12-30 Dirk Schulze <krit@webkit.org>

Reviewed by Anders Carlsson.

svg/custom/use-on-symbol-inside-pattern.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=17393

Reenable the test. It isn't failing anymore.

platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.checksum:
platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png:
platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
svg/custom/use-on-symbol-inside-pattern.svg: Copied from LayoutTests/svg/custom/use-on-symbol-inside-pattern.svg-disabled.
svg/custom/use-on-symbol-inside-pattern.svg-disabled: Removed.

12:05 PM Changeset in webkit [52670] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-12-30 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Touch DerivedSourcesAllInOne to avoid clobbering IB-based builds.

bindings/v8/DerivedSourcesAllInOne.cpp: Added a line-break.

11:28 AM Changeset in webkit [52669] by Dimitri Glazkov

4 edits
1 delete in trunk/WebCore

2009-12-30 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

[V8] Generate configuring of call-as-function callbacks.
https://bugs.webkit.org/show_bug.cgi?id=33061

Refactoring, covered by existing tests.

bindings/scripts/CodeGeneratorV8.pm: Added GenerateHeaderCustomCall and

GenerateImplementationCustomCall.

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed all hand-configuring of call-as-function

callbacks.

bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::V8HTMLAppletElement::callAsFunctionCallback): Added. (WebCore::V8HTMLEmbedElement::callAsFunctionCallback): Added. (WebCore::V8HTMLObjectElement::callAsFunctionCallback): Added.
bindings/v8/custom/V8HTMLPlugInElementCustom.h: Removed.

11:26 AM Changeset in webkit [52668] by kevino@webkit.org

8 edits
3 adds in trunk

Reviewed by Kevin Ollivier.

Introduce wxWebSettings API interface for editing wxWebView / page settings.

https://bugs.webkit.org/show_bug.cgi?id=32956

10:37 AM Changeset in webkit [52667] by eric@webkit.org

16 edits
2 moves in trunk/WebKitTools

2009-12-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

logging.py should be renamed to webkit_logging.py and eventually die
https://bugs.webkit.org/show_bug.cgi?id=33058

Change all imports of "logging" to webkit_logging,
except the ones which came from Google's cpp_lint.py and diff_parser.py
which clearly are assuming python's logging.py.

Scripts/modules/bugzilla.py:
Scripts/modules/buildbot.py:
Scripts/modules/buildsteps.py:
Scripts/modules/commands/download.py:
Scripts/modules/commands/queries.py:
Scripts/modules/commands/queues.py:
Scripts/modules/commands/upload.py:
Scripts/modules/credentials.py:
Scripts/modules/executive.py:
Scripts/modules/multicommandtool.py:
Scripts/modules/queueengine.py:
Scripts/modules/scm.py:
Scripts/modules/statusbot.py:
Scripts/modules/stepsequence.py:
Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.

10:22 AM Changeset in webkit [52666] by abarth@webkit.org

7 edits
2 adds in trunk/WebCore

2009-12-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[v8] Move world-specific state out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=33034

This is the first step towards unifying the V8 implementation of
isolated worlds with the JSC implementation. We need an object to
encapulate all the world-specific bindings state. Previoulsy, we used
V8Proxy for this purpose (along with a million other things), but
there's a one-to-one mapping between V8Proxy objects and Frame objects.

This patch takes the world-specific state and moves it to a new object,
affectionately called V8DOMWindowShell. This object is the moral
equivalent of JSDOMWindowShell but with more data members because life
is more complicated in V8-land.

This patch is almost entirely code motion. Future patches will clean
up this class as we use it to represent window shells in isolated
worlds as well as the main world.

WebCore.gypi:
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::updateDocument):
bindings/v8/V8DOMWindowShell.cpp: Added. (WebCore::handleFatalErrorInV8): (WebCore::reportFatalErrorInV8): (WebCore::reportUnsafeJavaScriptAccess): (WebCore::V8DOMWindowShell::create): (WebCore::V8DOMWindowShell::V8DOMWindowShell): (WebCore::V8DOMWindowShell::isContextInitialized): (WebCore::V8DOMWindowShell::disposeContextHandles): (WebCore::V8DOMWindowShell::destroyGlobal): (WebCore::V8DOMWindowShell::clearForClose): (WebCore::V8DOMWindowShell::clearForNavigation): (WebCore::V8DOMWindowShell::initContextIfNeeded): (WebCore::V8DOMWindowShell::createNewContext): (WebCore::V8DOMWindowShell::installDOMWindow): (WebCore::V8DOMWindowShell::updateDocumentWrapper): (WebCore::V8DOMWindowShell::clearDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::V8DOMWindowShell::clearDocumentWrapperCache): (WebCore::V8DOMWindowShell::setSecurityToken): (WebCore::V8DOMWindowShell::updateDocument): (WebCore::V8DOMWindowShell::updateSecurityOrigin): (WebCore::V8DOMWindowShell::getHiddenObjectPrototype): (WebCore::V8DOMWindowShell::installHiddenObjectPrototype): (WebCore::V8DOMWindowShell::createWrapperFromCacheSlowCase):
bindings/v8/V8DOMWindowShell.h: Added. (WebCore::V8DOMWindowShell::context): (WebCore::V8DOMWindowShell::createWrapperFromCache):
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructorForContext): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::~V8Proxy): (WebCore::V8Proxy::handleOutOfMemory): (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::setContextDebugId):
bindings/v8/V8Proxy.h: (WebCore::V8Proxy::windowShell): (WebCore::V8Proxy::extensions):

9:50 AM Changeset in webkit [52665] by eric@webkit.org

6 edits in trunk

2009-12-30 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVGResourceClipper needs to invalidate content
https://bugs.webkit.org/show_bug.cgi?id=33054

Added invalidate() to SVGResourceClipper to reset clipData
and drawing area after attribute changes.

This fixes two LayoutTests.

svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::invalidate):
svg/graphics/SVGResourceClipper.h:

2009-12-30 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVGResourceClipper needs to invalidate content
https://bugs.webkit.org/show_bug.cgi?id=33054

Drawing area should change after attribute changes in clipPath or
it's childs.

platform/mac/svg/custom/clip-path-child-changes-expected.txt:
platform/mac/svg/custom/clip-path-units-changes-expected.txt:

9:42 AM Changeset in webkit [52664] by eric@webkit.org

3 edits in trunk/WebCore

2009-12-30 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] RenderThemeQt::applyTheme is a misnomer and is suboptimally coded.

https://bugs.webkit.org/show_bug.cgi?id=33035

This patch:

renames RenderThemeQt::applyTheme to initializeCommonQStyleOptions,
extracts the palette initialization code to a separate function in order to provide for readable pointer checking and moves this code up in the function to allow for future changes to the palette brushes needed for bug 30173,
optimizes some of the code in the function for readability, speed and size.
fixes some minor style issues

No new tests because code behavior is not changed.

platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton): (WebCore::initPaletteFromPageClientIfExists): (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
platform/qt/RenderThemeQt.h:

8:49 AM Changeset in webkit [52663] by Dimitri Glazkov

6 edits in trunk/WebCore

2009-12-30 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

[V8] Generate configuring of all indexers.
https://bugs.webkit.org/show_bug.cgi?id=33031

Refactorig, covered by existing tests.

bindings/scripts/CodeGeneratorV8.pm: Added generation of indexers for

special cases.

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed custom tempalte configuration of

indexers.

bindings/v8/custom/V8CustomBinding.h: Added decls for Applet, Embed, and Object

elements (these will be generated, too -- later.)

bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::npObjectIndexedGetter): Moved common code to a separate method. (WebCore::npObjectIndexedSetter): Ditto. (WebCore::INDEXED_PROPERTY_GETTER): Added custom handlers for Applet, Embed, and Object all calling the common method. (WebCore::INDEXED_PROPERTY_SETTER): Ditto.

8:43 AM Changeset in webkit [52662] by eric@webkit.org

8 edits in trunk

2009-12-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] It should be possible to disable inspector
https://bugs.webkit.org/show_bug.cgi?id=32724

This change fixes the build break. Some QtWebKit interfaces
will not be fully functional (most notable QWebInspector) if
INSPECTOR is disabled.

Api/qwebinspector.cpp: (QWebInspector::showEvent): (QWebInspector::closeEvent):
Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPagePrivate::getOrCreateInspector): (QWebPagePrivate::inspectorController): (QWebPage::triggerAction): (QWebPage::updatePositionDependentActions):
WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow):

2009-12-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] It should be possible to disable inspector
https://bugs.webkit.org/show_bug.cgi?id=32724

This makes the r48430 available for other ports as well.
No new tests, as there is no new functionality.

inspector/InjectedScriptHost.idl: Guard the interface with INSPECTOR guard.

inspector/InspectorBackend.idl: Ditto.

inspector/InspectorFrontendHost.idl: Ditto.

8:13 AM Changeset in webkit [52661] by Dimitri Glazkov

6 edits in trunk/WebCore

2009-12-30 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

[V8] Generate configuring of all named property getters/setters/enumerators.
https://bugs.webkit.org/show_bug.cgi?id=32996

Refactoring, covered by existing tests.

bindings/scripts/CodeGeneratorV8.pm: Added generation of named property handlers

for special cases (See bug for more info).

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed custom template configuration of named

property handlers.

bindings/v8/custom/V8CustomBinding.h: Added decls for Applet, Embed, and Object

elements (these will be generated, too -- later.)

bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::npObjectNamedGetter): Moved common code to a separate method. (WebCore::npObjectNamedSetter): Ditto. (WebCore::NAMED_PROPERTY_GETTER): Added custom handlers for Applet, Embed, and Object all calling the common method. (WebCore::NAMED_PROPERTY_SETTER): Ditto.

6:58 AM Changeset in webkit [52660] by eric@webkit.org

4 edits in trunk

2009-12-30 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Fix PluginView::handlePostReadFile().
https://bugs.webkit.org/show_bug.cgi?id=33052

The function should actually rewrite the given file to the buffer.

This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
now along with other passing http/plugins tests.

plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::handlePostReadFile):

2009-12-30 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Fix PluginView::handlePostReadFile().
https://bugs.webkit.org/show_bug.cgi?id=33052

The function should actually rewrite the given file to the buffer.

This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
now along with other passing http/plugins tests.

platform/qt/Skipped:

6:30 AM Changeset in webkit [52659] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-12-30 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] layoutTestController.pathToLocalResource() should return a path, not an URL
https://bugs.webkit.org/show_bug.cgi?id=33051

Moreover, its primary function is to normalize the path in regard of platform
specific directory separators. Therefore, it can simply make use of the
QDir::toNativeSeparators function.

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::pathToLocalResource):

6:16 AM Changeset in webkit [52658] by ddkilzer@apple.com

3 edits in trunk/WebKitTools

Fix executable bits for r52646

Scripts/VCSUtils_unittest.pl: Added property svn:executable.
Scripts/test-webkit-perl: Ditto.

6:12 AM Changeset in webkit [52657] by zecke@webkit.org

3 edits in trunk/WebCore

[Qt] Revert "Implement ImageDecoderQt::clearFrameBufferCache()" from r52516.

https://bugs.webkit.org/show_bug.cgi?id=32121

The implementation appears to either run into an ASSERT
or leak memory at runtime as the m_buffer, m_reader may
already exist. The bug was reopened and we do have a plan now.

platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::clearFrameBufferCache):

platform/graphics/qt/ImageDecoderQt.h:

5:09 AM Changeset in webkit [52656] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-12-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Skipping isolatedWorld test - we still do not support that.

platform/gtk/Skipped:

4:58 AM Changeset in webkit [52655] by Simon Hausmann

3 edits
5 adds in trunk

WebCore: [Qt] Add support for Symbian def files

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-12-30
Reviewed by Simon Hausmann.

WebCore.pro:

WebKit/qt: Upstream Symbian def files from Qt 4.6.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-12-30
Reviewed by Simon Hausmann.

These files define the ABI of QtWebKit on Symbian.

symbian/bwins/QtWebKitu.def: Added.
symbian/eabi/QtWebKitu.def: Added.

4:40 AM Changeset in webkit [52654] by Simon Hausmann

2 edits in trunk/WebCore

Unreviewed Qt/Symbian build fix.

Don't build network state notifier support when building inside of Qt.
Otherwise the Qt build depends on an external module that itself depends
on Qt again.

WebCore.pro:

4:34 AM Changeset in webkit [52653] by yurys@chromium.org

7 edits in trunk/WebCore

2009-12-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Use current isolated world's context for ScriptCallStack.

https://bugs.webkit.org/show_bug.cgi?id=33016

bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState): (WebCore::ScriptController::currentScriptState): (WebCore::ScriptController::clearWindowShell):
bindings/v8/ScriptController.h:
bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::scriptState):
bindings/v8/V8IsolatedWorld.h:

2:46 AM Changeset in webkit [52652] by Csaba Osztrogonác

1 edit
1 copy
4 adds in trunk/LayoutTests

Rubber-stamped by Holger Hans Peter Freyther.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-30
[Qt] Add expected files for the following new passing tests.

platform/qt/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
platform/qt/fast/block/float/in-margin-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/in-margin-expected.txt.
platform/qt/fast/text/fake-italic-expected.txt: Added.
platform/qt/svg/custom/empty-mask-expected.txt: Added.
platform/qt/svg/filters/filter-source-position-expected.txt: Added.

2:20 AM Changeset in webkit [52651] by Csaba Osztrogonác

12 edits in trunk/LayoutTests

[Qt] Expected files updated after r52647.

Reviewed by Dirk Schulze.

platform/qt/svg/css/clippath-with-shadow-expected.txt:
platform/qt/svg/filters/feGaussianBlur-expected.txt:
platform/qt/svg/filters/feMerge-expected.txt:
platform/qt/svg/filters/feOffset-expected.txt:
platform/qt/svg/filters/feTile-expected.txt:
platform/qt/svg/filters/shadow-on-filter-expected.txt:
platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
platform/qt/svg/filters/sourceAlpha-expected.txt:
platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
platform/qt/svg/filters/subRegion-one-effect-expected.txt:
platform/qt/svg/filters/subRegion-two-effects-expected.txt:

1:20 AM Changeset in webkit [52650] by Csaba Osztrogonác

4 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] DataGrid support turned off by r52648. Expected files updated.

platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
platform/qt/fast/js/global-constructors-expected.txt: updated.

12:56 AM Changeset in webkit [52649] by krit@webkit.org

2 edits in trunk/LayoutTests

2009-12-30 Dirk Schulze <krit@webkit.org>

Unreviewed test result fix.

Detailed boundingBoxes in SVG Renderer
https://bugs.webkit.org/show_bug.cgi?id=32815

Forgot to update this test.

platform/mac/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:

12:52 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

12:47 AM Changeset in webkit [52648] by Simon Hausmann

2 edits in trunk/WebCore

Turn off DataGrid support by default.

Patch by Laszlo Gombos <Laszlo Gombos> on 2009-12-30
Reviewed by Simon Hausmann.

No new tests, as there is no new functionality.

WebCore.pro:

12:10 AM Changeset in webkit [52647] by krit@webkit.org

82 edits in trunk

2009-12-29 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Detailed boundingBoxes in SVG Renderer
https://bugs.webkit.org/show_bug.cgi?id=32815

Add new bounding boxes for strokes, filters, masker and clipper in SVG.
These new bounding boxes help to fix repaintRectInLocalCoordinates.
We calculate the smallest repaint rect considering the new bounding boxes
now, filters get the correct paint area, masker clip the mask image size
to the visible area of the target.

Tests: Many tests need an update. The changes in repaintRectInLocalCoordinates

affect the LayoutTests.

rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::strokeBoundingBox):
rendering/RenderObject.cpp: (WebCore::RenderObject::toSVGRenderBase):
rendering/RenderObject.h:
rendering/RenderPath.cpp: (WebCore::RenderPath::strokeBoundingBox): (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::setPath):
rendering/RenderPath.h: (WebCore::RenderPath::markerBoundingBox):
rendering/RenderSVGBlock.h: (WebCore::RenderSVGBlock::toSVGRenderBase):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::strokeBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
rendering/RenderSVGContainer.h:
rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::toSVGRenderBase): (WebCore::RenderSVGImage::strokeBoundingBox):
rendering/RenderSVGInline.h: (WebCore::RenderSVGInline::objectBoundingBox): (WebCore::RenderSVGInline::repaintRectInLocalCoordinates):
rendering/RenderSVGModelObject.h: (WebCore::RenderSVGModelObject::toSVGRenderBase):
rendering/RenderSVGRoot.h: (WebCore::RenderSVGRoot::strokeBoundingBox):
rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
rendering/RenderSVGText.h: (WebCore::RenderSVGText::toSVGRenderBase):
rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::~SVGRenderBase): (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer):
rendering/SVGRenderSupport.h: (WebCore::SVGRenderBase::toSVGRenderBase): (WebCore::SVGRenderBase::strokeBoundingBox): (WebCore::SVGRenderBase::markerBoundingBox):
rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::toSVGRenderBase): (WebCore::SVGRootInlineBox::objectBoundingBox): (WebCore::SVGRootInlineBox::repaintRectInLocalCoordinates):
svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterBoundingBox):
svg/SVGFilterElement.h:
svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::maskBoundingBox): (WebCore::SVGMaskElement::drawMaskerContent):
svg/SVGMaskElement.h:
svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::clipperBoundingBox):
svg/graphics/SVGResourceClipper.h:
svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::filterBoundingBox): (WebCore::shouldProcessFilter): (WebCore::SVGResourceFilter::prepareFilter):
svg/graphics/SVGResourceFilter.h:
svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::maskerBoundingBox): (WebCore::SVGResourceMasker::applyMask):
svg/graphics/SVGResourceMasker.h:

2009-12-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmmermann.

Detailed boundingBoxes in SVG Renderer
https://bugs.webkit.org/show_bug.cgi?id=32815

Mainly Filter and Masker tests need new test results.
repaintRectInLocalCoordinates changed to calculate the smallest
repaint area considering the bounding bo of masker, filter and
clipper as well as the stroke and marker boundaries.

platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
platform/mac/svg/batik/filters/feTile-expected.txt:
platform/mac/svg/batik/filters/filterRegions-expected.txt:
platform/mac/svg/batik/masking/maskRegions-expected.txt:
platform/mac/svg/batik/text/textEffect-expected.txt:
platform/mac/svg/batik/text/textEffect3-expected.txt:
platform/mac/svg/css/clippath-with-shadow-expected.txt:
platform/mac/svg/custom/clip-path-display-none-child-expected.txt:
platform/mac/svg/custom/clip-path-href-changes-expected.txt:
platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
platform/mac/svg/custom/clip-path-with-transform-expected.txt:
platform/mac/svg/custom/empty-merge-expected.txt:
platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
platform/mac/svg/custom/focus-ring-expected.checksum:
platform/mac/svg/custom/focus-ring-expected.png:
platform/mac/svg/custom/focus-ring-expected.txt:
platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
platform/mac/svg/custom/js-late-clipPath-creation-expected.txt:
platform/mac/svg/custom/mask-excessive-malloc-expected.checksum:
platform/mac/svg/custom/mask-excessive-malloc-expected.png:
platform/mac/svg/custom/mask-with-all-units-expected.txt:
platform/mac/svg/custom/non-opaque-filters-expected.txt:
platform/mac/svg/custom/recursive-clippath-expected.txt:
platform/mac/svg/custom/text-clip-expected.txt:
platform/mac/svg/custom/visibility-override-clip-expected.txt:
platform/mac/svg/filters/big-sized-filter-2-expected.txt:
platform/mac/svg/filters/big-sized-filter-expected.txt:
platform/mac/svg/filters/feDisplacementMap-expected.txt:
platform/mac/svg/filters/feMerge-expected.txt:
platform/mac/svg/filters/feOffset-expected.txt:
platform/mac/svg/filters/feTile-expected.txt:
platform/mac/svg/filters/filter-source-position-expected.txt:
platform/mac/svg/filters/filterRes-expected.txt:
platform/mac/svg/filters/shadow-on-filter-expected.txt:
platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
platform/mac/svg/filters/subRegion-one-effect-expected.txt:
platform/mac/svg/filters/subRegion-two-effects-expected.txt:
svg/custom/use-clipped-transform-expected.txt:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed