⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 3, 2010:

11:40 PM Changeset in webkit [52706] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-01-03 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric Seidel.

Update wtf/Platform.h to document the new system for porting macros.
​https://bugs.webkit.org/show_bug.cgi?id=33130

  • wtf/Platform.h:
11:15 PM Changeset in webkit [52705] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-03 Adam Barth <​abarth@webkit.org>

Unreviewed "build" fix. Need to import ScriptError.

  • Scripts/webkitpy/buildsteps.py:
11:08 PM Porting Macros plan edited by mjs@apple.com
(diff)
11:08 PM Changeset in webkit [52704] by abarth@webkit.org
  • 7 edits in trunk/WebKitTools

2010-01-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Make it easier to run submit-patch when previous run cancelled
​https://bugs.webkit.org/show_bug.cgi?id=33070

This patch renames create-review to submit-patch (as requested by
Maciej).

This patch makes it easier to run submit-patch after the user has
already cancelled a previous run of submit-patch by detecting when we
already have ChangeLogs and reading the bug number from them (and not
attempting to recreate them). Aside from performance and the extra
edit step, this command should not subsume post-dif.

Also, added a --email command line argument so that the output of
prepare-ChangeLog makes sense when it can't find the user's email
address.

  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/buildsteps.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/user.py:
11:04 PM Changeset in webkit [52703] by eric@webkit.org
  • 38 edits
    2 moves in trunk/WebKitTools

2010-01-03 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Rename Scripts/modules to Scripts/webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=33128

Just search-replace and svn mv commands.

  • Scripts/bugzilla-tool:
  • Scripts/check-webkit-style:
  • Scripts/modules: Removed.
  • Scripts/modules/BeautifulSoup.py: Removed.
  • Scripts/modules/init.py: Removed.
  • Scripts/modules/bugzilla.py: Removed.
  • Scripts/modules/bugzilla_unittest.py: Removed.
  • Scripts/modules/buildbot.py: Removed.
  • Scripts/modules/buildbot_unittest.py: Removed.
  • Scripts/modules/buildsteps.py: Removed.
  • Scripts/modules/buildsteps_unittest.py: Removed.
  • Scripts/modules/changelogs.py: Removed.
  • Scripts/modules/changelogs_unittest.py: Removed.
  • Scripts/modules/commands: Removed.
  • Scripts/modules/commands/init.py: Removed.
  • Scripts/modules/commands/commandtest.py: Removed.
  • Scripts/modules/commands/download.py: Removed.
  • Scripts/modules/commands/download_unittest.py: Removed.
  • Scripts/modules/commands/early_warning_system.py: Removed.
  • Scripts/modules/commands/early_warning_system_unittest.py: Removed.
  • Scripts/modules/commands/queries.py: Removed.
  • Scripts/modules/commands/queries_unittest.py: Removed.
  • Scripts/modules/commands/queues.py: Removed.
  • Scripts/modules/commands/queues_unittest.py: Removed.
  • Scripts/modules/commands/queuestest.py: Removed.
  • Scripts/modules/commands/upload.py: Removed.
  • Scripts/modules/commands/upload_unittest.py: Removed.
  • Scripts/modules/comments.py: Removed.
  • Scripts/modules/committers.py: Removed.
  • Scripts/modules/committers_unittest.py: Removed.
  • Scripts/modules/cpp_style.py: Removed.
  • Scripts/modules/cpp_style_unittest.py: Removed.
  • Scripts/modules/credentials.py: Removed.
  • Scripts/modules/credentials_unittest.py: Removed.
  • Scripts/modules/diff_parser.py: Removed.
  • Scripts/modules/diff_parser_unittest.py: Removed.
  • Scripts/modules/executive.py: Removed.
  • Scripts/modules/executive_unittest.py: Removed.
  • Scripts/modules/grammar.py: Removed.
  • Scripts/modules/mock.py: Removed.
  • Scripts/modules/mock_bugzillatool.py: Removed.
  • Scripts/modules/multicommandtool.py: Removed.
  • Scripts/modules/multicommandtool_unittest.py: Removed.
  • Scripts/modules/outputcapture.py: Removed.
  • Scripts/modules/patchcollection.py: Removed.
  • Scripts/modules/queueengine.py: Removed.
  • Scripts/modules/queueengine_unittest.py: Removed.
  • Scripts/modules/scm.py: Removed.
  • Scripts/modules/scm_unittest.py: Removed.
  • Scripts/modules/statusbot.py: Removed.
  • Scripts/modules/stepsequence.py: Removed.
  • Scripts/modules/style: Removed.
  • Scripts/modules/style.py: Removed.
  • Scripts/modules/style_unittest.py: Removed.
  • Scripts/modules/text_style.py: Removed.
  • Scripts/modules/text_style_unittest.py: Removed.
  • Scripts/modules/user.py: Removed.
  • Scripts/modules/webkit_logging.py: Removed.
  • Scripts/modules/webkit_logging_unittest.py: Removed.
  • Scripts/modules/webkit_mechanize.py: Removed.
  • Scripts/modules/webkitport.py: Removed.
  • Scripts/modules/webkitport_unittest.py: Removed.
  • Scripts/test-webkit-python: Removed.
  • Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
  • Scripts/validate-committer-lists:
  • Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/bugzilla_unittest.py:
  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/buildbot_unittest.py:
  • Scripts/webkitpy/buildsteps.py:
  • Scripts/webkitpy/buildsteps_unittest.py:
  • Scripts/webkitpy/commands/commandtest.py:
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/download_unittest.py:
  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/early_warning_system_unittest.py:
  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commands/queries_unittest.py:
  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/commands/queuestest.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/comments.py:
  • Scripts/webkitpy/credentials.py:
  • Scripts/webkitpy/credentials_unittest.py:
  • Scripts/webkitpy/executive.py:
  • Scripts/webkitpy/executive_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/multicommandtool.py:
  • Scripts/webkitpy/multicommandtool_unittest.py:
  • Scripts/webkitpy/queueengine.py:
  • Scripts/webkitpy/queueengine_unittest.py:
  • Scripts/webkitpy/scm.py:
  • Scripts/webkitpy/scm_unittest.py:
  • Scripts/webkitpy/statusbot.py:
  • Scripts/webkitpy/stepsequence.py:
  • Scripts/webkitpy/webkit_logging_unittest.py:
  • Scripts/webkitpy/webkitport_unittest.py:
10:58 PM Porting Macros plan edited by mjs@apple.com
(diff)
10:54 PM Porting Macros plan edited by mjs@apple.com
(diff)
10:50 PM Porting Macros plan created by mjs@apple.com
10:49 PM WikiStart edited by mjs@apple.com
(diff)
10:31 PM Changeset in webkit [52702] by eric@webkit.org
  • 3 edits
    1 move
    1 add in trunk/WebKitTools

2010-01-03 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Added script to test both Perl and Python, and renamed
run-webkit-unittests to test-webkit-python.

​https://bugs.webkit.org/show_bug.cgi?id=33045

  • Scripts/VCSUtils_unittest.pl:
    • Tweaked so it can be run from outside Scripts directory.
  • Scripts/run-webkit-unittests: Removed.
    • Renamed to test-webkit-python.
  • Scripts/test-webkit-perl:
    • Tweaked so it can be run from outside Scripts directory.
  • Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.
  • Scripts/test-webkit-scripts: Added.
    • Runs both test-webkit-perl and test-webkit-python.
7:12 PM Changeset in webkit [52701] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-01-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue/bugzilla-tool should build both Debug and Release
​https://bugs.webkit.org/show_bug.cgi?id=28450

Add a --build-style command that lets the master process tell the child
process to build both debug and release. Eventually we want to teach
the test step to understand this option too, but that's a patch for
another day.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/webkitport.py:
  • Scripts/modules/webkitport_unittest.py:
6:40 PM Changeset in webkit [52700] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-01-03 Kenneth Russell <​kbr@google.com>

Reviewed by Maciej Stachowiak.

Index validation code must always copy client data
​https://bugs.webkit.org/show_bug.cgi?id=32748

Client data must always be copied during bufferData and
bufferSubData calls, because otherwise the data the GL uses to
draw may differ from that checked by the index validation code.

  • fast/canvas/webgl/index-validation-copies-indices-expected.txt: Added.
  • fast/canvas/webgl/index-validation-copies-indices.html: Added.

2010-01-03 Kenneth Russell <​kbr@google.com>

Reviewed by Maciej Stachowiak.

Index validation code must always copy client data
​https://bugs.webkit.org/show_bug.cgi?id=32748

Client data must always be copied during bufferData and
bufferSubData calls, because otherwise the data the GL uses to
draw may differ from that checked by the index validation code.

Test: fast/canvas/webgl/index-validation-copies-indices.html

  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::WebGLBuffer): (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData):
  • html/canvas/WebGLBuffer.h:
6:32 PM Changeset in webkit [52699] by eric@webkit.org
  • 6 edits in trunk

2010-01-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Implement CookieJarChromium::cookiesEnabled
​https://bugs.webkit.org/show_bug.cgi?id=33123

Call out to ChromiumBridge to find out if cookies are enabled.

  • platform/chromium/ChromiumBridge.h:
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::cookiesEnabled):

2010-01-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Implement CookieJarChromium::cookiesEnabled
​https://bugs.webkit.org/show_bug.cgi?id=33123

Call out to the webKitClient() to see if cookies are enabled. Also
remove some straggling references to policyURL!

  • public/WebKitClient.h: (WebKit::WebKitClient::setCookies): (WebKit::WebKitClient::cookies): (WebKit::WebKitClient::rawCookies): (WebKit::WebKitClient::cookiesEnabled):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cookiesEnabled):
6:24 PM Changeset in webkit [52698] by eric@webkit.org
  • 11 edits in trunk

2010-01-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove evaluateInNewContext (it's useless)
​https://bugs.webkit.org/show_bug.cgi?id=33068

This function has no clients and makes life complicated. Isolated
worlds won out over NewContext and there's not really any going back
now.

No new tests because this is all minus lines.

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertWindowToV8Object):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:

2010-01-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove evaluateInNewContext (it's useless)
​https://bugs.webkit.org/show_bug.cgi?id=33068

This function has no clients and makes life complicated. Isolated
worlds won out over NewContext and there's not really any going back
now.

  • public/WebFrame.h:
  • src/FrameLoaderClientImpl.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
6:17 PM Changeset in webkit [52697] by eric@webkit.org
  • 4 edits in trunk

2010-01-03 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] EventSender: add support for Enter key events
​https://bugs.webkit.org/show_bug.cgi?id=33064

Unskip 5 tests that are fixed now.

  • platform/qt/Skipped:

2010-01-03 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] EventSender: add support for Enter key events
​https://bugs.webkit.org/show_bug.cgi?id=33064

Unskip 5 tests that are fixed now.

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):
6:10 PM Changeset in webkit [52696] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Add test for previous typo fix
​https://bugs.webkit.org/show_bug.cgi?id=33083

A trivial test for a trivial fix, as requested by Eric.

  • Scripts/modules/bugzilla_unittest.py:
6:03 PM Changeset in webkit [52695] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-01-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement mac-ews
​https://bugs.webkit.org/show_bug.cgi?id=33072

The mac-ews is slightly different than the other early warning systems
because we can't run Mac OS X inside a VM. For that reason, we only
process patches that were uploaded by committers. This isn't as much
coverage as the other EWS bots, but it's better than nothing.

  • Scripts/modules/commands/early_warning_system.py:
  • Scripts/modules/commands/early_warning_system_unittest.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/queuestest.py:
  • Scripts/modules/mock_bugzillatool.py:
5:55 PM Changeset in webkit [52694] by eric@webkit.org
  • 1 edit
    12 moves
    3 adds in trunk/LayoutTests

2010-01-03 Mario Bensi <​mbensi@pleyo.com>

Reviewed by Simon Fraser.

create 3d directory and move tests dependent of 3D Rendering in this
directory.

​https://bugs.webkit.org/show_bug.cgi?id=33081

  • animations/3d: Added.
  • animations/3d/change-transform-in-end-event.html: Copied from LayoutTests/animations/change-transform-in-end-event.html.
  • animations/3d/state-at-end-event-transform.html: Copied from LayoutTests/animations/state-at-end-event-transform.html.
  • animations/3d/transform-origin-vs-functions-expected.txt: Copied from LayoutTests/animations/transform-origin-vs-functions-expected.txt.
  • animations/3d/transform-origin-vs-functions.html: Copied from LayoutTests/animations/transform-origin-vs-functions.html.
  • animations/change-transform-in-end-event.html: Removed.
  • animations/state-at-end-event-transform.html: Removed.
  • animations/transform-origin-vs-functions-expected.txt: Removed.
  • animations/transform-origin-vs-functions.html: Removed.
1:48 PM Changeset in webkit [52693] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip test that fails on and off on the release bot.

1:25 PM Changeset in webkit [52692] by ddkilzer@apple.com
  • 6 edits in trunk/WebKitTools

Refactored svn-apply and svn-unapply to use a common "patch"
command method, and added unit tests for this new method.

Patch by Chris Jerdonek <​chris.jerdonek@gmail.com> on 2010-01-03
Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=33098

  • Scripts/VCSUtils.pm:
    • Added generateRunPatchCommand().
    • Added runPatchCommand().
    • Added exitStatus() from webkitdirs.pm to address FIXME.
  • Scripts/VCSUtils_unittest.pl:
    • Added 10 unit tests for generateRunPatchCommand().
    • Added 4 unit tests for runPatchCommand().
    • Added callSilently() method.
  • Scripts/svn-apply:
    • Refactored applyPatch().
    • Removed $pathScriptWasRunFrom global variable.
    • Addressed issue where "--force" option was getting added twice.
  • Scripts/svn-unapply:
    • Refactored applyPatch().
    • Removed $pathScriptWasRunFrom global variable.
    • Added support for --force option.
    • Enhanced to return meaningful exit status.
  • Scripts/webkitdirs.pm:
    • Moved exitStatus() implementation to VCSUtils.pm.
11:39 AM Changeset in webkit [52691] by weinig@apple.com
  • 4 edits in trunk/WebCore

Rubber-stamped by Dan Bernstein.

Remove out of date commented out attributes in IDLs. We have implemented onpopstate.

  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.idl:
  • page/DOMWindow.idl:
11:36 AM Changeset in webkit [52690] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2009-12-31 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable all HTML5 persistent features for QGVLauncher
​https://bugs.webkit.org/show_bug.cgi?id=33086

  • QGVLauncher/main.cpp: Call enablePersistentStorage() (main):
9:45 AM Changeset in webkit [52689] by krit@webkit.org
  • 5 edits in trunk/WebCore

2010-01-03 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Mark more filter effect as alphaImage if possible
​https://bugs.webkit.org/show_bug.cgi?id=33111

Mark more effects as alphaImage if the previous effect is a
alphaImage. This can reduce the calculation on the next effect
like feGaussianBlur.


Test: This changes don't affect any LayoutTests and can't be tested

somehow, since the changes are 'invisible'.

  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):

Jan 2, 2010:

11:57 AM Changeset in webkit [52688] by dbates@webkit.org
  • 5 edits
    3 deletes in trunk/LayoutTests

2010-01-02 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33109

Cleans up the XSSAuditor test directory by removing unnecessary test scripts.

The patch for bug #33107 added notifyDone() functionality to the script
echo-intertag.pl. So, we can substitute this script for scripts echo-intertag-and-notify.php,
echo-intertag-post-and-notify.pl, and echo-intertag-post.pl.

  • http/tests/security/xssAuditor/link-opens-new-window.html: Modified to call script echo-intertag.pl.
  • http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Removed.
  • http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Removed.
  • http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Removed.
  • http/tests/security/xssAuditor/script-tag-post-control-char.html: Modified to call script echo-intertag.pl.
  • http/tests/security/xssAuditor/script-tag-post-null-char.html: Modified to call script echo-intertag.pl.
  • http/tests/security/xssAuditor/script-tag-post.html: Modified to call script echo-intertag.pl.
11:54 AM Changeset in webkit [52687] by dbates@webkit.org
  • 4 edits in trunk/LayoutTests

2010-01-02 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33107

Removes the use of window.setTimeout from the XSSAuditor tests:
get-from-iframe.html and post-from-iframe.html by having the
script echo-intertag.pl (called by these tests) call
layoutTestController.notifyDone().

  • http/tests/security/xssAuditor/get-from-iframe.html: Removes call of window.setTimeout.
  • http/tests/security/xssAuditor/post-from-iframe.html: Ditto.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl: If the query argument notifyDone is found, then the script will generate a JavaScript script to call layoutTestController.notifyDone().
Note: See TracTimeline for information about the timeline view.