⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 6, 2010:

11:07 PM Changeset in webkit [52903] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-01-06 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Return an invalid Qt::ImMicroFocus if queried while the view needs to layout.

​https://bugs.webkit.org/show_bug.cgi?id=33204

  • Api/qwebpage.cpp: (QWebPage::inputMethodQuery):
10:12 PM Changeset in webkit [52902] by tkent@chromium.org
  • 7 edits in trunk

2010-01-06 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Eric Seidel.

Remove fast/events/keydown-numpad-key.html from the Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=33250

  • platform/qt/Skipped:

2010-01-06 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Eric Seidel.

Make windowsKeyCodeForKeyEvent() return correct key code for
numeric-pad arrow keys.
​https://bugs.webkit.org/show_bug.cgi?id=33250

Test: fast/events/keydown-numpad-keys.html

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):

2010-01-06 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Eric Seidel.

[Qt] Support the 3rd argument of EventSender.keyDown that
has been recently added to report keyLocation
(see also: ​https://bugs.webkit.org/show_bug.cgi?id=28247).
​https://bugs.webkit.org/show_bug.cgi?id=33250

Test: fast/events/keydown-numpad-keys.html

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):
  • DumpRenderTree/qt/EventSenderQt.h:
10:00 PM Changeset in webkit [52901] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add long_help for all common commands.
​https://bugs.webkit.org/show_bug.cgi?id=33261

For now these long_helps are pretty basic.
These were all written to just explain the steps
that each command runs. This style long_help could
be made easier by using:
​https://bugs.webkit.org/show_bug.cgi?id=33257

  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/queries.py:
9:30 PM Changeset in webkit [52900] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-18 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Dirk Schulze.

Improve DOM performance in large SVG files.
Check the dirty area before painting a path, which prevents unnecessary
clipping and changes to the GraphicsContext.
​https://bugs.webkit.org/show_bug.cgi?id=30055

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
8:45 PM Changeset in webkit [52899] by tkent@chromium.org
  • 3 edits in trunk/WebCore

2010-01-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Use a static HashMap for HTMLElement::tagPriority().
​https://bugs.webkit.org/show_bug.cgi?id=33269

The prior code compares AtomicStringImpl pointers 18 times at
worst. This change avoids it.

No new tests because this is just a refactoring.

  • html/HTMLElement.cpp: (WebCore::Empty1IntHashTraits): A HashTraits to return 1 as the empty value. (WebCore::initializeTagPriorityMap): Initialization of a static HashMap. (WebCore::HTMLElement::tagPriority): Use the static HashMap created by initializeTagPriorityMap().
  • html/HTMLElement.h: (WebCore::HTMLElement::HTMLElement): Add an assertion about non-null localName().
8:06 PM Changeset in webkit [52898] by eric@webkit.org
  • 5 edits in trunk

2010-01-06 Mike Belshe <​mike@belshe.com>

Add a flag to the ResourceResponse for tracking if a request was
fetched via SPDY. This is plumbed through so that we can inform
a webpage via JavaScript if it was fecthed via the experimental
SPDY protocol.

​https://bugs.webkit.org/show_bug.cgi?id=33186

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::wasFetchedViaSpdy): (WebCore::ResourceResponse::setWasFetchedViaSpdy):

2010-01-06 Mike Belshe <​mike@belshe.com>

Add a flag to the ResourceResponse for tracking if a request was
fetched via SPDY. This is plumbed through so that we can inform
a webpage via JavaScript if it was fecthed via the experimental
SPDY protocol.

​https://bugs.webkit.org/show_bug.cgi?id=33186

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasFetchedViaSpdy): (WebKit::WebURLResponse::setWasFetchedViaSpdy):
8:01 PM Changeset in webkit [52897] by tonikitoo@webkit.org
  • 5 edits in trunk

[Qt] Add page zooming support to Qt DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=32898

Patch by Kim Grönholm <​kim.gronholm@nomovok.com>,

Diego Gonzalez <​diego.gonzalez@openbossa.org> and
Afonso Costa <​afonso.costa@openbossa.org> on 2010-01-06

Reviewed by Kenneth Christiansen.

WebKitTools:

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::zoomPageIn):
(EventSender::zoomPageOut):

  • DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

  • platform/qt/Skipped:
7:37 PM Changeset in webkit [52896] by eric@webkit.org
  • 5 edits in trunk

2010-01-06 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Adam Treat.

[Qt] RenderTheme: Missing support for native sliders

​https://bugs.webkit.org/show_bug.cgi?id=33122

Implement painting of native slider controls in RenderTheme
and unskip a couple of layout tests that are passing after
this change.

  • platform/qt/Skipped:

2010-01-06 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Adam Treat.

[Qt] RenderTheme: Missing support for native sliders

​https://bugs.webkit.org/show_bug.cgi?id=33122

Implement painting of native slider controls in RenderTheme
and unskip a couple of layout tests that are passing after
this change.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintSliderTrack): (WebCore::RenderThemeQt::adjustSliderTrackStyle): (WebCore::RenderThemeQt::paintSliderThumb): (WebCore::RenderThemeQt::adjustSliderThumbStyle): (WebCore::RenderThemeQt::supportsFocus): (WebCore::RenderThemeQt::adjustSliderThumbSize):
  • platform/qt/RenderThemeQt.h:
7:23 PM Changeset in webkit [52895] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-06 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Darin Adler.

Adjust incorrect comments after r40534.

  • bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext):
6:57 PM Changeset in webkit [52894] by ukai@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for chromium.
Add "bool V8WorkerContext::WebSocketEnabled()"

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::WebSocketEnabled):

6:45 PM Changeset in webkit [52893] by ukai@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed build fix.
remove wrong assertion

  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):

6:33 PM Changeset in webkit [52892] by ukai@chromium.org
  • 20 edits
    2 copies
    9 adds in trunk

2010-01-06 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by David Levin

Add WebSocket feature in Worker
​https://bugs.webkit.org/show_bug.cgi?id=32214

  • websocket/tests/workers/resources/simple_wsh.py: Copied from LayoutTests/websocket/tests/simple_wsh.py.
  • websocket/tests/workers/resources/worker-simple.js: Added.
  • websocket/tests/workers/worker-simple-expected.txt: Added.
  • websocket/tests/workers/worker-simple.html: Added.

2010-01-06 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by David Levin.

Add WebSocket feature in Worker
​https://bugs.webkit.org/show_bug.cgi?id=32214

Introduce ThreadableWebSocketChannel interface and add
WorkerThreadableWebSocketChannel for Worker.
WorkerThreadableWebSocketChannel uses WebSocketChannel in the
main thread, which is managed by Peer and communicated via Bridge.

Test: websocket/tests/workers/worker-simple.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebSocketConstructor.h:
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::webSocket):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
  • bindings/v8/custom/V8WebSocketCustom.cpp: (WebCore::V8Custom::v8WebSocketConstructorCallback):
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • platform/CrossThreadCopier.cpp: (WebCore::::copy):
  • platform/CrossThreadCopier.h: (WebCore::):
  • websockets/ThreadableWebSocketChannel.cpp: Added.
  • websockets/ThreadableWebSocketChannel.h: Added.
  • websockets/ThreadableWebSocketChannelClientWrapper.h: Added.
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect): (WebCore::WebSocket::didReceiveMessage):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.h: (WebCore::WebSocketChannel::refThreadableWebSocketChannel): (WebCore::WebSocketChannel::derefThreadableWebSocketChannel):
  • websockets/WebSocketChannelClient.h:
  • websockets/WebSocketHandshake.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp: Added.
  • websockets/WorkerThreadableWebSocketChannel.h: Added.
  • workers/WorkerContext.idl:
6:20 PM Changeset in webkit [52891] by eric@webkit.org
  • 7 edits in trunk

2010-01-06 Adam Bergkvist <​adam.bergkvist@ericsson.com>

Reviewed by Darin Adler.

Modified EventSource event-stream parser to support a single CR as line ending.
Updated test accordingly.
​https://bugs.webkit.org/show_bug.cgi?id=33207

  • http/tests/eventsource/eventsource-parse-event-stream-expected.txt:
  • http/tests/eventsource/eventsource-parse-event-stream.html:
  • http/tests/eventsource/resources/event-stream.php:

2010-01-06 Adam Bergkvist <​adam.bergkvist@ericsson.com>

Reviewed by Darin Adler.

Modified EventSource event-stream parser to support a single CR as line ending.
​https://bugs.webkit.org/show_bug.cgi?id=33207

  • page/EventSource.cpp: (WebCore::EventSource::EventSource): (WebCore::EventSource::parseEventStream):
  • page/EventSource.h:
6:05 PM Changeset in webkit [52890] by eric@webkit.org
  • 5 edits in trunk

2010-01-06 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getInterfaceMaskFromObject): (getPangoLayoutForAtk): (webkit_accessible_text_get_text):
  • accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):

2010-01-06 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text

  • tests/testatk.c (test_webkit_atk_get_text_at_offset): (test_webkit_atk_get_text_at_offset_forms): (test_webkit_atk_get_text_at_offset_newlines):
6:04 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
5:41 PM Changeset in webkit [52889] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/7488126> With text-rendering: optimizelegibility, sometimes lines run too long
​https://bugs.webkit.org/show_bug.cgi?id=32794

Reviewed by Sam Weinig.

WebCore:

Test: platform/mac/fast/text/line-breaking-with-kerning.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak): When kerning is enabled, include
the trailing space when measuring a word, then subtract its width. This
accounts for kerning between the last glyph of the word and the following space.

LayoutTests:

  • platform/mac/fast/text/line-breaking-with-kerning-expected.checksum: Added.
  • platform/mac/fast/text/line-breaking-with-kerning-expected.png: Added.
  • platform/mac/fast/text/line-breaking-with-kerning-expected.txt: Added.
  • platform/mac/fast/text/line-breaking-with-kerning.html: Added.
5:33 PM Changeset in webkit [52888] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-06 Eric Seidel <​eric@webkit.org>

No review.

REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
​https://bugs.webkit.org/show_bug.cgi?id=33256

I am unable to reproduce this failure locally, so this fix is only speculative.
Skip the test we believe is causing the log message which bleeds into fast/workers/shared-worker-constructor.html

  • platform/mac/Skipped:
5:29 PM Changeset in webkit [52887] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Simon Fraser.

Third step of:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView getVariable:value:]): Add case for WKNVSupportsCompositingCoreAnimationPluginsBool.
5:14 PM Changeset in webkit [52886] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-06 Eric Seidel <​eric@webkit.org>

No review, just adding Mike Belshe's new bugzilla email at his request.

  • Scripts/webkitpy/committers.py:
5:01 PM Changeset in webkit [52885] by kdecker@apple.com
  • 9 edits in trunk

Reviewed by Simon Fraser

Second step of:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

  • Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginLayer]): Added.
  • Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginLayer]): Added. Reviewed by Simon Fraser.

Second step of:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

  • Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginLayer]): Added.
  • Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginLayer]): Added.
4:50 PM Changeset in webkit [52884] by abarth@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix screwed up ChangeLog about screwing up... Sigh.

4:48 PM Changeset in webkit [52883] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-06 Eric Seidel <​eric@webkit.org>

No review.

REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
​https://bugs.webkit.org/show_bug.cgi?id=33256

I am unable to reproduce this failure locally, so this fix is only speculative.
Skip the test we believe is causing the log message which bleeds into fast/workers/shared-worker-constructor.html

  • platform/mac/Skipped:
4:47 PM Changeset in webkit [52882] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2010-01-06 Adam Barth <​abarth@webkit.org>

No review, rolling out r52877.
​http://trac.webkit.org/changeset/52877
​https://bugs.webkit.org/show_bug.cgi?id=33243

I screwedd up landing this patch and only partially applied the patch I
was trying to land.

  • bindings/ScriptControllerBase.cpp:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorld):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::mainWorldWindowShell): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::clearForClose): (WebCore::ScriptController::destroyWindowShell): (WebCore::ScriptController::updateDocument):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::proxy): (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell): (WebCore::ScriptController::evaluateInWorld):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::create): (WebCore::V8DOMWindowShell::V8DOMWindowShell): (WebCore::V8DOMWindowShell::initContextIfNeeded):
4:30 PM Changeset in webkit [52881] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-01-06 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Carlson.

media/video-seeking.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=33273

Removed setTimeouts from this test. It kind of looks
like they were intentional, but I don't see how they add
anything to this test (other than race conditions).

  • media/video-seeking-expected.txt:
  • media/video-seeking.html:
4:26 PM Changeset in webkit [52880] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-06 Eric Seidel <​eric@webkit.org>

Unreviewed. Rolling back in a change I should not have rolled out.

The original commit ​http://trac.webkit.org/changeset/52862
was rolled out again in ​http://trac.webkit.org/changeset/52871
but I now believe that rollout to be in error.
My sincerest apologies for the churn.

Fix the bug in previous commit: we shouldn't finish
decoding if "sizeOnly" is true.
​https://bugs.webkit.org/show_bug.cgi?id=33258

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode):
4:24 PM Changeset in webkit [52879] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-01-06 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

fast/css/transition-color-unspecified.html and fast/dom/HTMLObjectElement/object-as-frame.html are flaky
​https://bugs.webkit.org/show_bug.cgi?id=33270

These both rely on setTimeouts where they should be using events.

  • fast/css/transition-color-unspecified.html:
  • fast/dom/HTMLObjectElement/object-as-frame.html:
4:21 PM Changeset in webkit [52878] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-06 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

platform/chromium/fast/dom/interval.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=33274

We're seeing the debug bots take >100000 microseconds to stop
and Interval.

  • platform/chromium/fast/dom/interval.html:
4:16 PM Changeset in webkit [52877] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2010-01-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[v8] Let ScriptController have more than one windowShell
​https://bugs.webkit.org/show_bug.cgi?id=33243

This patch lets ScriptController have more than one windowShell. We're
currently only using one of them (for the main world), but this patch
lets us use other ones for isolated worlds soon.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScriptInWorld):
  • bindings/js/ScriptController.cpp:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::createWorld): (WebCore::ScriptController::initScript): (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::mainWorldWindowShell): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::clearForClose): (WebCore::ScriptController::destroyWindowShell): (WebCore::ScriptController::updateDocument):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell): (WebCore::ScriptController::globalObject): (WebCore::ScriptController::proxy):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::create): (WebCore::V8DOMWindowShell::V8DOMWindowShell): (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
3:56 PM Changeset in webkit [52876] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-06 Eric Seidel <​eric@webkit.org>

Unreviewed. Rolling out r52869 and r52853 due to bot
and local run-webkit-test failures

REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
​https://bugs.webkit.org/show_bug.cgi?id=33256

The original bug was ​https://bugs.webkit.org/show_bug.cgi?id=33153

  • Scripts/run-webkit-tests:
3:20 PM Changeset in webkit [52875] by mrowe@apple.com
  • 5 edits in trunk

Fix the Mac build.

  • WebCore.base.exp: Export symbols WebKit would like to use.
  • plugins/PluginWidget.h:

(WebCore::PluginWidget::PluginWidget): Redeclare a constructor.

3:09 PM Changeset in webkit [52874] by weinig@apple.com
  • 2 edits in trunk/WebKit/mac

Attempt to fix non-Snow Leopard Mac build.

  • WebCoreSupport/WebFrameLoaderClient.mm:
2:25 PM Changeset in webkit [52873] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-06 Eric Seidel <​eric@webkit.org>

Unreviewed "build" fix. Just adding missing include.

bugzilla-tool rollout --complete-rollout should make a nicer bug comment
​https://bugs.webkit.org/show_bug.cgi?id=29212

  • Scripts/webkitpy/steps/completerollout.py:
2:23 PM Changeset in webkit [52872] by kdecker@apple.com
  • 5 edits
    2 adds in trunk

Reviewed by Eric Carlson.


First step toward:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism


Small refactoring moving the PluginWidget class from WebKit to WebCore.

  • WebCore.xcodeproj/project.pbxproj: Added new source files and a "mac" group; exposes PluginWidget.h as a "Private" role
  • platform/Widget.h: Added isPluginWidget(). (WebCore::Widget::isPluginWidget):
  • plugins/PluginWidget.h: Added. (WebCore::PluginWidget::isPluginWidget): Added as an interim solution until Mac plug-ins inheirt from PluginView.
  • plugins/mac/PluginWidgetMac.mm: Added. (WebCore::PluginWidget::invalidateRect): Added. Extracted from the old WebKit/FrameLoaderClientMac version of PluginWidget

Reviewed by Eric Carlson.

First step toward:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism


Small refactoring moving the PluginWidget class from WebKit to WebCore.

  • WebCoreSupport/WebFrameLoaderClient.mm: Use the WebCore version of PluginWidget.
2:20 PM Changeset in webkit [52871] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-06 Eric Seidel <​eric@webkit.org>

No review, rolling out r52862.
​http://trac.webkit.org/changeset/52862
​https://bugs.webkit.org/show_bug.cgi?id=33258

Caused svg/W3C-SVG-1.1/linking-a-01-b.svg to crash on the
Leopard Release builder.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode):
2:14 PM Changeset in webkit [52870] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool rollout --complete-rollout should make a nicer bug comment
​https://bugs.webkit.org/show_bug.cgi?id=29212

  • Scripts/webkitpy/bugzilla.py:
    • Make reopen_bug robust against the bug already being open.
  • Scripts/webkitpy/commands/download.py:
    • Remove dead code from Rollout.
  • Scripts/webkitpy/steps/completerollout.py:
    • Improve the rollout comment.
2:12 PM Changeset in webkit [52869] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-06 Andras Becsi <​abecsi@inf.u-szeged.hu>

Reviewed by Darin Adler.

Set isHttpdOpen to 0 if pidfile does not exist for some reason.
Speculative fix for ​https://bugs.webkit.org/show_bug.cgi?id=33256.

  • Scripts/run-webkit-tests:
2:04 PM Changeset in webkit [52868] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-01-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Revert the part of my last commit touching Base.xcconfig, was not meant to be commited.

  • Configurations/Base.xcconfig:
2:02 PM WebKit Team edited by treat@kde.org
(diff)
1:37 PM Changeset in webkit [52867] by Nate Chapin
  • 12 edits
    1 delete in trunk/WebCore

2010-01-05 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Generate header declarations for V8 binding security checks
and delete V8CustomBinding.cpp

  • Android.v8bindings.mk: Removed V8CustomBinding.cpp.
  • WebCore.gypi: Removed V8CustomBinding.cpp.
  • bindings/scripts/CodeGeneratorV8.pm: Generate security check declarations.
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::getTargetFrame): Moved from V8CustomBinding.cpp. (WebCore::reportUnsafeJavaScriptAccess): (WebCore::V8DOMWindowShell::createNewContext): (WebCore::V8DOMWindowShell::setLocation): Moved from V8CustomBinding.cpp.
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::downcastSVGPathSeg): Moved from V8CustomBinding.cpp. (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::getTemplate):
  • bindings/v8/custom/V8CustomBinding.cpp: Removed.
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::locationAccessorSetter): (WebCore::V8DOMWindow::namedSecurityCheck): (WebCore::V8DOMWindow::indexedSecurityCheck):
  • bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::V8Document::locationAccessorSetter):
  • bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::indexedSecurityCheck): (WebCore::V8History::namedSecurityCheck):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::indexedSecurityCheck): (WebCore::V8Location::namedSecurityCheck):
1:26 PM Changeset in webkit [52866] by Nikolas Zimmermann
  • 42 edits
    15 adds in trunk

2010-01-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Marker code is buggy: referencePoint translation is off
​https://bugs.webkit.org/show_bug.cgi?id=33012

Rewrite marker code, as it had many issues:

  • Correct refX/refY handling (covered by new marker-referencePoint.svg test)
  • Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
  • Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
  • Fix SVGResource assuming that there is only one resource per resource type per element. Markers can have three different resources of the same type (three markers, start/mid/end markers)

Filed bug 33115 (PathElementAddQuadCurveToPoint not handled for <marker>), which was just a TODO in the code before.

Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
Test: svg/custom/marker-referencePoint.svg

svg/custom/marker-opacity.svg
svg/custom/marker-strokeWidth-changes.svg

  • Android.mk: Add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to build.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/FrameView.cpp: Notify RenderSVGRoot children about viewport size changes, just like it's handled for <body> in HTML. (WebCore::FrameView::layout): This is important, as marker bounding boxes may depend on the current viewport size through relative coordinates used in <svg>.
  • rendering/RenderPath.cpp: (WebCore::RenderPath::markerBoundingBox): Calculates and caches marker boundaries in the layout() phase. (WebCore::RenderPath::repaintRectInLocalCoordinates): Use the cached marker bounding box during paint() time. (WebCore::RenderPath::setPath): Clear marker boundaries upon path changes. (WebCore::RenderPath::paint): Use SVGMarkerLayoutInfo::drawMarkers() instead of the local drawMarkersIfNeeded() function, which is gone now. (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Utilized by markerBoundingBox() to request SVGResourceMarker objects and calculate their boundaries.
  • rendering/RenderPath.h: Store SVGMarkerLayoutInfo objects, and rename m_markerBounds to m_cachedLocalMarkerBBox for consistency. (WebCore::RenderPath::path): Inline this accessor.
  • rendering/RenderSVGContainer.h: Make paint() public (to be used from SVGResourceMarker), all other methods protected (to be used from RenderSVGViewportContainer).
  • rendering/RenderSVGViewportContainer.cpp: Remove useless paint() override, as the comment in the code indicated. (WebCore::RenderSVGViewportContainer::markerBoundaries): Maps the marker contents repaintRectInLocalCoordinates() into the final coordinate system (see code). (WebCore::RenderSVGViewportContainer::markerContentTransformation): Add marker-specific helper method, allowing to make viewportTransform() private again.
  • rendering/RenderSVGViewportContainer.h: Marking viewportTransform() private, it's never meant to be used outside this renderer.
  • rendering/SVGMarkerData.h: Added. Refactored from existing RenderPath code, preserving original copyrights. (WebCore::SVGMarkerData::): Helper struct for SVGMarkerLayoutInfo. (WebCore::SVGMarkerData::origin): Holds the final computed destination of a marker. (WebCore::SVGMarkerData::marker): Holds a pointer to the associated SVGResourceMarker object, which we're aiming to layout. (WebCore::SVGMarkerData::currentAngle): Calculates the current angle for a certain marker type (start/mid/end) based upon the computed inslope/outslope values. (WebCore::SVGMarkerData::updateTypeAndMarker): Helper method. (WebCore::SVGMarkerData::updateOutslope): Ditto. (WebCore::SVGMarkerData::updateMarkerDataForPathElement): Does the actual inslope/outslope calculation. (WebCore::SVGMarkerData::updateInslope): Helper method.
  • rendering/SVGMarkerLayoutInfo.cpp: Added. New approach to build marker layout info, this time correct during layout() time instead of paint() time. (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo): (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo): (WebCore::processStartAndMidMarkers): Static helper method used to visit each path element in order to calculate inslopes/outslopes (-> orientation angles) (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): Build list of MarkerLayout objects, used to query boundaries, and to paint markers during drawMarkers(). (WebCore::SVGMarkerLayoutInfo::drawMarkers): Cheap method walking existing MarkerLayout vector, drawing the individual RenderSVGViewportContainer of the markers. (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker): Helper method.
  • rendering/SVGMarkerLayoutInfo.h: Added. (WebCore::MarkerLayout::MarkerLayout): Helper struct storing a pair of SVGResourceMarker* and a TranformationMatrix. (WebCore::SVGMarkerLayoutInfo::markerData): Public helper methods returning references to private member variables, used from processStartAndMidMarkers. (WebCore::SVGMarkerLayoutInfo::midMarker): Ditto. (WebCore::SVGMarkerLayoutInfo::elementIndex): Ditto.
  • svg/SVGMarkerElement.cpp: Adopt to name change: setRef() -> setReferencePoint(). setMarker() -> setRenderer() (WebCore::SVGMarkerElement::~SVGMarkerElement): Remove obsolete detach() hack, fixed by SVGUseElement changes. (WebCore::SVGMarkerElement::canvasResource): Add ASSERT(renderer()) to clarify that canvasResource() is only meant to used after renderer creation.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::~SVGSVGElement): Remove obsolete detach() hack, fixed by SVGUseElement changes.
  • svg/SVGUseElement.cpp: Rework buildPendingResource() to remove SVGSVGElement/SVGMarkerElement detach() hacks (called manually from destructors), see below. (WebCore::SVGUseElement::buildPendingResource): Always detach() the shadow tree root element, before destructing it - this caused the regression with this patch before.
  • svg/graphics/SVGResource.cpp: Instead of maintaining a global hashmap between SVGStyledElements and an array of possible SVGResources, use a HashSet of SVGResources

and directly scan the already existing list of clients for a certain SVGResource. This wrong approach has been introduced over two years
ago, making the assumption that there's only one resource type per element. Though markers can provide three resources of the same type
per element (all SVGResourceMarker objects, but in different rules: start/mid/end marker). That information is only available while painting.

(WebCore::resourceSet): Add global static HashSet<SVGResource*>.
(WebCore::SVGResource::SVGResource): Add us to the resourceSet.
(WebCore::SVGResource::~SVGResource): Remove us from resourceSet.
(WebCore::SVGResource::removeClient): Traverse all SVGResource clients and remove the passed SVGStyledElement from the client list (invoked by SVGStyledElement destructor).
(WebCore::SVGResource::addClient): Remove the offending part of the old approach, making the wrong assumption regarding resource types.

  • svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::markerTransformation): Create TransformationMatrix in the local marker content (RenderSVGViewportContainer) coordinate system, to position a marker. (WebCore::SVGResourceMarker::draw): Simplify marker drawing a lot: used the passing TransformationMatrix (cached in SVGMarkerLayoutInfo) to draw the marker content renderer. (WebCore::SVGResourceMarker::externalRepresentation): Adopt to refX/refY -> referencePoint changes.
  • svg/graphics/SVGResourceMarker.h: Store a FloatPoint m_referecePoint instead of two refX/refY float values. (WebCore::SVGResourceMarker::setRenderer): Renamed from setMarker(). (WebCore::SVGResourceMarker::setReferencePoint): Renamed from setRef(). (WebCore::SVGResourceMarker::referencePoint): New accessor replacing refX() / refY().
1:10 PM Changeset in webkit [52865] by krit@webkit.org
  • 26 edits in trunk

2010-01-06 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage support
​https://bugs.webkit.org/show_bug.cgi?id=31905

This implements the SVG Filter effect feImage with support of fragment urls.
It also includes a bug fix for feComposite. feComposite didn't cover values
bigger than 255 correctly on composite oeprator arithmetic.

Tests: There are already many feImage tests in trunk. They just needed updated

pixel test results.
The feComposite bug is covered by svg/W3C-SVG-1.1/filters-composite-02-b.svg
and depends on feImage.

  • platform/graphics/filters/FEComposite.cpp: (WebCore::arithmetic):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGImage.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource): (WebCore::SVGFEImageElement::parseMappedAttribute): (WebCore::SVGFEImageElement::notifyFinished): (WebCore::SVGFEImageElement::build):
  • svg/SVGFEImageElement.h:
  • svg/SVGFEImageElement.idl:
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::transformRect):
  • svg/SVGPreserveAspectRatio.h:
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::FEImage): (WebCore::FEImage::create): (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h:

2010-01-06 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage support
​https://bugs.webkit.org/show_bug.cgi?id=31905

The implementation of feImage requires pixel test result updates of the already
available tests.

There is also an update for svg/filters/feComposite.svg, since the patch also
fixed a bug in feComposite.

  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.checksum:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.png:
  • platform/mac/svg/filters/feComposite-expected.checksum:
  • platform/mac/svg/filters/feComposite-expected.png:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.checksum:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:

2010-01-06 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage support
​https://bugs.webkit.org/show_bug.cgi?id=31905

Update SVG status page. We support feDisplacementMap and feImage now.

  • projects/svg/status.xml:
12:26 PM Changeset in webkit [52864] by Darin Adler
  • 1 edit
    1 add in trunk/LayoutTests

Added file James Robinson provided to go with his fix for
​https://bugs.webkit.org/show_bug.cgi?id=32295

  • platform/mac/fast/repaint/block-no-inflow-children-expected.png: Added.
12:24 PM Changeset in webkit [52863] by Darin Adler
  • 5 edits in trunk/LayoutTests

Some script tests have wrappers that don't match their templates
​https://bugs.webkit.org/show_bug.cgi?id=33239

Reviewed by Eric Seidel.

  • fast/dom/StyleSheet/get-stylesheet-byname.html: Updated to use

a standard test wrapper instead of a custom one.

  • fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js:

Changed test to not depend on a non-standard wrapper.

  • fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Updated

results since I changed the test around.

  • platform/mac/editing/selection/script-tests/TEMPLATE.html: Fix

incorrect path in template that broke the test when we called
make-script-test-wrappers.

12:15 PM Changeset in webkit [52862] by yong.li@torchmobile.com
  • 2 edits in trunk/WebCore

2010-01-06 Yong Li <​yoli@rim.com>

Reviewed by Darin Adler.

Fix the bug in previous commit: we shouldn't finish
decoding if "sizeOnly" is true.
​https://bugs.webkit.org/show_bug.cgi?id=33258

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode):
11:59 AM Changeset in webkit [52861] by bweinstein@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Should be last part of Windows Build fix.

11:58 AM Changeset in webkit [52860] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-01-06 Eric Seidel <​eric@webkit.org>

No review, rolling out r52855.
​http://trac.webkit.org/changeset/52855
​https://bugs.webkit.org/show_bug.cgi?id=33222

Caused 6 layout tests to fail on Mac

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/ResourceLoader.cpp:
  • loader/ResourceLoader.h:
11:51 AM Changeset in webkit [52859] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

QT build fix.

  • runtime/Identifier.cpp:

(JSC::createIdentifierTableSpecific):

11:45 AM Changeset in webkit [52858] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix part I.

11:38 AM Changeset in webkit [52857] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

  • runtime/Identifier.cpp:

(JSC::createIdentifierTableSpecificCallback):

11:38 AM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
11:33 AM Changeset in webkit [52856] by barraclough@apple.com
  • 20 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=33236
Remove m_identifierTable pointer from UString

Reviewed by Sam Weinig.

JavaScriptCore:

Currently every string holds a pointer so that during destruction,
if a string has been used as an identifier, it can remove itself
from the table. By instead accessing the identifierTable via a
thread specific tracking the table associated with the current
globaldata, we can save the memory cost of this pointer.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

  • change the API shims to track the identifierTable of the current JSGlobalData.
  • API/JSContextRef.cpp:

(JSContextGroupCreate):

  • update creation of JSGlobalData for API usage to use new create method.
  • fix shim instanciation bug in JSGlobalContextCreateInGroup.

(JSC::checkSyntax):
(JSC::evaluate):

  • add asserts to check the identifierTable is being tracked correctly.
  • runtime/Identifier.cpp:

(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::Identifier::remove):
(JSC::Identifier::checkSameIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):
(JSC::createDefaultDataSpecific):

  • Use currentIdentifierTable() instead of UStringImpl::m_identifierTable.
  • Define methods to access the thread specific identifier tables.
  • runtime/Identifier.h:

(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):

  • Declare methods to access the thread specific identifier tables.
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::createNonDefault):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):

  • creation of JSGlobalData objects, other than for API usage, associate themselves with the current thread.
  • runtime/JSGlobalData.h:
  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::destroy):

  • destroy() method should be using isIdentifier().
  • runtime/UStringImpl.h:

(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):

  • replace m_identifierTable with a single m_isIdentifier bit.
  • wtf/StringHashFunctions.h:

(WTF::stringHash):

  • change string hash result from 32-bit to 31-bit, to free a bit in UStringImpl for m_isIdentifier.

JavaScriptGlue:

Add API shims similar to those used in the JSC API to track the current identifierTable.

  • JSBase.cpp:

(JSBase::Release):

  • JSUtils.cpp:

(JSObjectKJSValue):
(KJSValueToCFTypeInternal):
(unprotectGlobalObject):
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

  • JSUtils.h:
  • JSValueWrapper.cpp:

(JSValueWrapper::JSObjectCopyPropertyNames):
(JSValueWrapper::JSObjectCopyProperty):
(JSValueWrapper::JSObjectSetProperty):
(JSValueWrapper::JSObjectCallFunction):
(JSValueWrapper::JSObjectCopyCFValue):

  • JavaScriptGlue.cpp:

(JSRunCreate):
(JSRunEvaluate):
(JSRunCheckSyntax):
(JSCollect):

  • JavaScriptGlue.xcodeproj/project.pbxproj:
  • UserObjectImp.cpp:

(UserObjectImp::callAsFunction):

10:25 AM Changeset in webkit [52855] by yong.li@torchmobile.com
  • 5 edits in trunk/WebCore

2010-01-06 Yong Li <​yoli@rim.com>

Reviewed by Darin Adler.

Let ReourceLoader deliver segmented data
when loading resource from a SharedBuffer object.
​https://bugs.webkit.org/show_bug.cgi?id=33222

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveData):
  • loader/ResourceLoader.h:
3:14 AM Changeset in webkit [52854] by Simon Hausmann
  • 2 edits in trunk/WebCore

Unreviewed trivial Qt build fix.

Prefix the phonon includes with phonon/ to avoid conflicts with the S60
audio routing API ( ​http://wiki.forum.nokia.com/index.php/Audio_Routing_API ).

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
2:02 AM Changeset in webkit [52853] by loki@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-06 Andras Becsi <​abecsi@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
and remove the httpd's pidfile directory if httpd terminated.

  • Scripts/run-webkit-tests:
12:24 AM Changeset in webkit [52852] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-01-06 Darin Fisher <​darin@chromium.org>

Fix release build bustage.

  • src/WebKit.cpp: Need to include Logging.h

Jan 5, 2010:

11:56 PM Changeset in webkit [52851] by darin@chromium.org
  • 7 edits
    2 adds in trunk/WebKit/chromium

2010-01-05 Darin Fisher <​darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Expose more APIs to eliminate WebCore usage in Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=33249

  • WebKit.gyp:
  • public/WebFrame.h:
  • public/WebGlyphCache.h: Added.
  • public/WebKit.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrame::instanceCount): (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl):
  • src/WebFrameImpl.h:
  • src/WebGlyphCache.cpp: Added. (WebKit::WebGlyphCache::pageCount):
  • src/WebKit.cpp: (WebKit::enableLogChannel):
11:31 PM Changeset in webkit [52850] by darin@chromium.org
  • 2 edits in trunk/WebCore

2010-01-05 Darin Fisher <​darin@chromium.org>

Reviewed by Adam Barth.

Moving v8::HandleScope up above declaration of v8::Local to fix a
Chromium startup crash.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setContextDebugId):
10:37 PM Changeset in webkit [52849] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-01-05 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by David Levin.

Refactored check-webkit-style's argument parser to not rely
on global state, and improved its error handling and unit
test coverage.

​https://bugs.webkit.org/show_bug.cgi?id=32966

  • Scripts/check-webkit-style:
    • Adjusted to use new argument parser.
  • Scripts/webkitpy/cpp_style.py:
    • Changed _CppStyleState to accept an array of filter rules instead of a comma-delimited string.
    • Eliminated cpp_style._DEFAULT_FILTER_RULES.
    • Eliminated cpp_style._USAGE.
  • Scripts/webkitpy/cpp_style_unittest.py:
    • Updated test_filter() and test_default_filter().
  • Scripts/webkitpy/style.py:
    • Converted style._USAGE to create_usage().
    • Corrected usage instructions by removing 0 as a valid --verbose flag value.
    • Removed use_webkit_styles().
    • Added ProcessorOptions class.
    • Added ArgumentDefaults class.
    • Added ArgumentPrinter class.
    • Removed parse_arguments and added ArgumentParser class.
    • Moved exit_with_usage() and exit_with_categories() into ArgumentParser.
    • Refactored parse_arguments() as ArgumentParser.parse().
    • Improved parser error handling.
  • Scripts/webkitpy/style_unittest.py:
    • Added DefaultArgumentsTest class.
    • Addressed FIXME to check style.WEBKIT_FILTER_RULES against style.STYLE_CATEGORIES.
    • Added ArgumentPrinterTest class.
    • Added ArgumentParserTest class and rewrote parser unit tests.
9:11 PM Changeset in webkit [52848] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Re-enable plug-in halting on Mac after r51953

Reviewed by Mark Rowe.

  • WebCoreSupport/WebPluginHalterClient.mm:

(WebPluginHalterClient::enabled): Test for the correct selector.

7:09 PM Changeset in webkit [52847] by abarth@webkit.org
  • 12 edits in trunk

2010-01-05 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[v8] Move V8DOMWindowShell to ScriptController
​https://bugs.webkit.org/show_bug.cgi?id=33232

This patch moves V8DOMWindow shell to ScriptController, where the
window shells live in JSC land. The next step will be to allow for
more than one window shell per script controller.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::mainWorldWindowShell): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::clearForClose): (WebCore::ScriptController::destroyWindowShell): (WebCore::ScriptController::updateDocument):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::~V8DOMWindowShell):
  • bindings/v8/V8DOMWindowShell.h: (WebCore::V8DOMWindowShell::localHandleForContext):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
  • bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::V8IsolatedContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::~V8Proxy): (WebCore::V8Proxy::handleOutOfMemory): (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::currentContext): (WebCore::V8Proxy::setContextDebugId):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::adjustedContext):

2010-01-05 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[v8] Move V8DOMWindowShell to ScriptController
​https://bugs.webkit.org/show_bug.cgi?id=33232

Update FrameLoaderClientImpl.cpp to call clearForClose on
ScriptController instead of on V8Proxy.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
6:57 PM Changeset in webkit [52846] by eric@webkit.org
  • 8 edits
    6 adds in trunk

2010-01-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Implement HTML5 <header> and <footer> elements.
​https://bugs.webkit.org/show_bug.cgi?id=32943

These test:

  • <p> closing,
  • No nesting restriction,
  • Residual style, and
  • FormatBlock.
  • fast/html/footer-element-expected.txt: Added.
  • fast/html/footer-element.html: Added.
  • fast/html/header-element-expected.txt: Added.
  • fast/html/header-element.html: Added.
  • fast/html/script-tests/footer-element.js: Added.
  • fast/html/script-tests/header-element.js: Added.

2010-01-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Implement HTML5 <header> and <footer> elements.
​https://bugs.webkit.org/show_bug.cgi?id=32943

<header> and <footer> should behave the same as <nav>, <section>,
<article>, and <aside>. The HTML parser doesn't need to restrict
the nesting of header/footer elements.

Tests: fast/html/footer-element.html

fast/html/header-element.html

  • css/html.css: Add header/footer as block elements.
  • editing/htmlediting.cpp: (WebCore::validBlockTag): Add headerTag and footerTag.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for headerTag and footerTag. (WebCore::blockTagList): Add headerTag and footerTag.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Rename isHeaderTag() to isHeadingTag() (WebCore::HTMLParser::getNode): Add headerTag and footerTag. (WebCore::HTMLParser::isHeadingTag): Renamed from isHeaderTag().
  • html/HTMLParser.h:
    • Rename isHeaderTag() to isHeadingTag()
    • Remove non-existing popNestedHeaderTag().
  • html/HTMLTagNames.in: Add header and footer.
6:46 PM Changeset in webkit [52845] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-01-05 Rachel Petterson <​rlp@google.com>

Reviewed by Adam Barth.

Matches the texImage2D and texSubImage2D functions to their
declarations. Elminates uncessary versions of those functions.
​https://bugs.webkit.org/show_bug.cgi?id=31562
Also bug: ​https://bugs.webkit.org/show_bug.cgi?id=31493

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
6:07 PM Changeset in webkit [52844] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-05 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

CDATA sections are merged into Text nodes when normalize() is used
​https://bugs.webkit.org/show_bug.cgi?id=33191

  • fast/dom/Node/normalize-with-cdata-expected.txt: Added.
  • fast/dom/Node/normalize-with-cdata.html: Added.
  • fast/dom/Node/script-tests/normalize-with-cdata.js: Added.
6:06 PM Changeset in webkit [52843] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-05 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

CDATA sections are merged into Text nodes when normalize() is used
​https://bugs.webkit.org/show_bug.cgi?id=33191

  • fast/dom/Node/normalize-with-cdata-expected.txt: Added.
  • fast/dom/Node/normalize-with-cdata.html: Added.
  • fast/dom/Node/script-tests/normalize-with-cdata.js: Added.
6:05 PM Changeset in webkit [52842] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-01-05 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

CDATA sections are merged into Text nodes when normalize() is used
​https://bugs.webkit.org/show_bug.cgi?id=33191

  • fast/dom/Node/normalize-with-cdata-expected.txt: Added.
  • fast/dom/Node/normalize-with-cdata.html: Added.
  • fast/dom/Node/script-tests/normalize-with-cdata.js: Added.
6:03 PM Changeset in webkit [52841] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-01-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

animations/animation-drt-api-multiple-keyframes.html and animations/animation-drt-api.html are flaky
​https://bugs.webkit.org/show_bug.cgi?id=33244

Both these tests have a race condition. They start looking
for the animation start after the node is already rendered.
Instead, set the animation just before looking for the animation
start.

  • animations/animation-drt-api-multiple-keyframes.html:
  • animations/animation-drt-api.html:
5:35 PM Changeset in webkit [52840] by Darin Adler
  • 3 edits
    3 adds in trunk

CDATA sections are merged into Text nodes when normalize() is used
​https://bugs.webkit.org/show_bug.cgi?id=33191

Reviewed by Dan Bernstein.

WebCore:

Test: fast/dom/Node/normalize-with-cdata.html

  • dom/Node.cpp:

(WebCore::Node::normalize): Use nodeType instead of isTextNode.

LayoutTests:

  • fast/dom/Node/normalize-with-cdata-expected.txt: Added.
  • fast/dom/Node/normalize-with-cdata.html: Added.
  • fast/dom/Node/script-tests/normalize-with-cdata.js: Added.
5:13 PM Changeset in webkit [52839] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-01-05 James Robinson <​jamesr@google.com>

Reviewed by Eric Seidel.

Typing in Google Wave repaints the whole screen
​https://bugs.webkit.org/show_bug.cgi?id=32295

Add a repaint test to make sure that when mutations happen in a grandchild of a block element that has no in-flow children
the entire block element is not unnecessarily repainted.
The bug only shows up when running pixel tests.

  • fast/repaint/block-no-inflow-children.html: Added.
  • platform/mac/fast/repaint/block-no-inflow-children-expected.checksum: Added.
  • platform/mac/fast/repaint/block-no-inflow-children-expected.png: Added.
  • platform/mac/fast/repaint/block-no-inflow-children-expected.txt: Added.

2010-01-05 James Robinson <​jamesr@google.com>

Reviewed by Eric Seidel.

Typing in Google Wave repaints the whole screen
​https://bugs.webkit.org/show_bug.cgi?id=32295

Marks a RenderBlock without block children for layout and painting when it has no line boxes only if it has inline immediate children.
The existing logic uses the existence of line boxes as a dirty flag to indicate that line boxes need to be regenerated. This heuristic
fails when the RenderBlock does not have any in-flow children at all, causing the RenderBlock to get unnecessarily marked for layout and
painting. This is particularly bad for common scrollbar manipulation tricks like putting one positioned div inside another - this
structure caused the entire outer div's bounds to get scheduled for a paint whenever there was any mutation of any descendant.

Test: LayoutTests/fast/repaint/block-no-inline-children.html (only shows up in pixel tests)

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
4:07 PM Changeset in webkit [52838] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-01-05 James Robinson <​jamesr@chromium.org>

Reviewed by David Hyatt.

Cleans up line box clearing when a RenderBlock loses its last child.
​https://bugs.webkit.org/show_bug.cgi?id=33228

The 'fullLayout' flag in RenderBlock::layoutInlineChildren() is pretty vague, hopefully this will be easier for the next person to figure out.

No new tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
3:57 PM Changeset in webkit [52837] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

LayoutTests/animations/change-keyframes.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=33233

The timing calculation was just off. It was starting the
second animation at 600ms and then checking to be half-way
done with the 1 second animation at 1000ms. Instead, just
modify the animation to run a bit earlier.

  • animations/change-keyframes.html:
3:53 PM Changeset in webkit [52836] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-05 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Provide the "documentURL" property for documents and frame owner elements

This is necessary to determine owner document URLs for nodes (all nodes have
the top-level document set as ownerDocument).
​https://bugs.webkit.org/show_bug.cgi?id=33025

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
3:51 PM Changeset in webkit [52835] by cmarrin@apple.com
  • 3 edits in trunk/LayoutTests

Fixed a bug in testcase. Passing an empty array to texImage2D
now must be done with 'null' not '0'.

  • fast/canvas/webgl/script-tests/texImageTest.js:
  • fast/canvas/webgl/texImageTest-expected.txt:
3:42 PM Changeset in webkit [52834] by cmarrin@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

New test for texImage2d and texSubImage2d cases
New test for texImage2d using ImageData which tests rendering.
​https://bugs.webkit.org/show_bug.cgi?id=31562
Also bug: ​https://bugs.webkit.org/show_bug.cgi?id=31493

3:22 PM Changeset in webkit [52833] by pkasting@chromium.org
  • 5 edits in trunk/WebCore

Public GIF decoder should stop decoding when allocation fails
​https://bugs.webkit.org/show_bug.cgi?id=33231

Reviewed by Adam Barth.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::haveDecodedRow):

  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::output_row):
(GIFImageReader::do_lzw):
(GIFImageReader::read):

  • platform/image-decoders/gif/GIFImageReader.h:
3:13 PM Changeset in webkit [52832] by Adam Roben
  • 1 edit in trunk/WebKit/win/ChangeLog

Add missing Radar numbers

3:08 PM Changeset in webkit [52831] by yong.li@torchmobile.com
  • 4 edits in trunk/WebCore

2010-01-05 Yong Li <​yoli@rim.com>

Reviewed by Darin Adler.

Make PNG image decoder work with segmented SharedBuffer
​https://bugs.webkit.org/show_bug.cgi?id=33213

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create):
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::isAllDataReceived): (WebCore::ImageDecoder::setData):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::currentBufferSize): (WebCore::PNGImageReader::setComplete): (WebCore::PNGImageReader::decode): (WebCore::PNGImageDecoder::decode): (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::pngComplete):
3:07 PM Changeset in webkit [52830] by Adam Roben
  • 2 edits in trunk/WebKit/win

Make IWebView::close and destroying a WebView's HWND optional for WebKit clients

WebView will now take care of these operations itself when its last
reference is released, if they haven't already been done.

IWebView::close now also destroys the WebView's HWND. All WebKit
clients were already performing these operations in succession anyway,
or were attempting to by calling IWebView::close then destroying the
WebView's host window (which actually resulted in the WebView's HWND
leaking, and the crash in the below bug).

Fixes <​http://webkit.org/b/32827> Crash when calling IWebView::close,
then releasing the WebView, without calling DestroyWindow

Fixes a few WebViewDestruction tests, too.

Reviewed by Steve Falkenburg.

  • WebView.cpp:

(WebView::~WebView): Don't try to destroy m_viewWindow here. That
should already have happened. Assert that this is the case.
(WebView::close): If m_viewWindow isn't already being destroyed,
destroy it now. Moved the call to revokeDragDrop() here from our
WM_DESTROY handler because it needs to be done before m_viewWindow is
nulled out.
(WebView::WebViewWndProc): Removed call to revokeDragDrop() that
close() now performs.
(WebView::Release): If our last reference is being released, call
close() so that clients don't have to. (It's harmless to call close()
multiple times.) We do this here instead of in the destructor because
close() can cause AddRef() and Release() to be called, and calling
those from within the destructor leads to double-destruction.
(WebView::setHostWindow): Removed an unnecessary (and now harmful)
null-check.
(WebView::revokeDragDrop): Changed an assertion into a run-time check,
since this will now sometimes be called when m_viewWindow hasn't been
created yet. Changed the IsWindow call to a null-check because we
never hold onto a destroyed m_viewWindow.
(WebView::windowAncestryDidChange): If we don't have a view window,
stop tracking changes to our parent's active state.

3:07 PM Changeset in webkit [52829] by Adam Roben
  • 4 edits in trunk

Make it safe to call IWebView::close when IWebView::initWithFrame hasn't been called

Part of <​http://webkit.org/b/32827> Crash when calling
IWebView::close, then releasing the WebView, without calling
DestroyWindow

Reviewed by Steve Falkenburg.

WebKit/win:

  • WebView.cpp:

(WebView::close): Null-check m_page and m_preferences before using
them. They will be null if initWithFrame was never called.

WebKitTools:

Test that it's safe to call IWebView::close when IWebView::initWithFrame
hasn't been called

  • WebKitAPITest/tests/WebViewDestruction.cpp:

(WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
without ever calling IWebView::initWithFrame and tests that we don't
crash or leak.

3:07 PM Changeset in webkit [52828] by Adam Roben
  • 3 edits in trunk/WebKit/win

Add assertions to catch double-destruction of WebViews earlier

I basically copied the m_deletionHasBegun logic from WTF::RefCounted.

Fixes <​http://webkit.org/b/33219>.

Reviewed by Darin Adler.

  • WebView.cpp:

(WebView::WebView): Initialize m_deletionHasBegun
(WebView::AddRef): Assert that deletion hasn't already begun.
(WebView::Release): Assert that deletion hasn't already begun, then
record when deletion *does* begin.

  • WebView.h: Added m_deletionHasBegun.
3:06 PM Changeset in webkit [52827] by Adam Roben
  • 2 edits in trunk/WebKit/win

Remove dead code in WebViewWndProc

Fixes <​http://webkit.org/b/33218>.

Reviewed by Darin Adler.

  • WebView.cpp:

(WebView::WebViewWndProc): Removed a redundant isBeingDestroyed check.
We bail out much earlier in this function if isBeingDestroyed is true.

3:06 PM Changeset in webkit [52826] by Adam Roben
  • 2 edits in trunk/WebKitTools

Add more WebViewDestruction tests

Fixes <​http://webkit.org/b/33216>.

Reviewed by Eric Seidel.

  • WebKitAPITest/tests/WebViewDestruction.cpp:

(WebKitAPITest::NoInitWithFrame):
(WebKitAPITest::CloseThenDestroyViewWindow):
(WebKitAPITest::DestroyViewWindowThenClose):
(WebKitAPITest::DestroyHostWindow):
(WebKitAPITest::DestroyHostWindowThenClose):
(WebKitAPITest::CloseThenDestroyHostWindow):
Added these tests that exercise tearing down a WebView in various
ways, all of which we eventually want to have work. Some of them
currently crash or leak.

2:45 PM Changeset in webkit [52825] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-05 Robert Hogan <​robert@roberthogan.net>

Reviewed by Eric Seidel.

[Qt] fix DRT link failures on --no-svg builds when only making changes to DRT

If you're working from a --minimal or --no-svg build and make changes to the
DRT, then recompile, the build will fail.

This is because the current behavior at build time is to assume that the
previous Qt build supported SVG and consequently delete libQtWebKit.so.
Unfortunately, just deleting libQtWebKit.so will not cause the library to
re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
results in a link failure on the DRT.

Since re-linking libQtWebKit can take up to ten minutes and should be avoided
in cases where not actually required, remove the assumption that
the previous Qt build supported SVG, and amend the symbol detection to look for
a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.

​https://bugs.webkit.org/show_bug.cgi?id=32992

  • Scripts/webkitdirs.pm:
2:30 PM Changeset in webkit [52824] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-12-25 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

Buildfix for WinCE + style fixes.
​https://bugs.webkit.org/show_bug.cgi?id=32939

  • jsc.cpp: (functionPrint): (functionQuit): (parseArguments): (fillBufferWithContentsOfFile):
1:18 PM Changeset in webkit [52823] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-05 Adam Barth <​abarth@webkit.org>

Rubber stamped by Dimitri Glazkov.

Fix namespace indent for ScriptController.

  • bindings/v8/ScriptController.h: (WebCore::ScriptController::proxy): (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell): (WebCore::ScriptController::xssAuditor): (WebCore::ScriptController::setProcessingTimerCallback): (WebCore::ScriptController::setPaused): (WebCore::ScriptController::isPaused): (WebCore::ScriptController::sourceURL): (WebCore::ScriptController::evaluateInWorld):
12:48 PM Changeset in webkit [52822] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-05 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

WinCE buildfix after r52791 (renamed PLATFORM(WINCE) to OS(WINCE)).
​https://bugs.webkit.org/show_bug.cgi?id=33205

  • jit/ExecutableAllocator.h:
12:40 PM Changeset in webkit [52821] by cmarrin@apple.com
  • 8 edits in trunk/WebCore

Implement most cases of texImage2D and texSubImage2D
​https://bugs.webkit.org/show_bug.cgi?id=31562

12:37 PM Changeset in webkit [52820] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Part of <​https://bugs.webkit.org/show_bug.cgi?id=32568>.
Web Inspector: Context Menus should be used in more places.

Reviewed by Tim Hatcher.

Add context menus to handle the interaction with breakpoints in the Source Frame. Currently
we use left click to add/disable/remove breakpoints, and left click to edit (for conditional
breakpoints), but this is hard to discover and behaves differently than Xcode.

Change the behavior to be more like Xcode, left click adds a breakpoint if there isn't one, and
removes it if there is one.

On the context menu, if there is no breakpoint there, we have Add Breakpoint, and Add Conditional
Breakpoint. If there is a breakpoint there, we add entries for Edit Breakpoint (edit
the condition), Remove Breakpoint, and Enable/Disable Breakpoint (based on the current state).

  • English.lproj/localizedStrings.js: Added localized context menu entries.
  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._documentContextMenu.addAndEditBreakpoint):
(WebInspector.SourceFrame.prototype._documentContextMenu): Added context menu entries and handlers.
(WebInspector.SourceFrame.prototype._documentMouseDown): Changed left click behavior (Add -> Remove).

12:34 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
12:33 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
12:32 PM Changeset in webkit [52819] by Chris Fleizach
  • 9 edits
    2 adds in trunk

AX: need a way to get the progress of a webpage load
​https://bugs.webkit.org/show_bug.cgi?id=33221

Reviewed by Eric Seidel.

WebCore:

Test: platform/mac/accessibility/estimated-progress.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::estimatedLoadingProgress):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::estimatedLoadingProgress):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • platform/mac/accessibility/document-attributes-expected.txt:
  • platform/mac/accessibility/estimated-progress-expected.txt: Added.
  • platform/mac/accessibility/estimated-progress.html: Added.
  • platform/mac/accessibility/frame-with-title-expected.txt:
  • platform/mac/accessibility/frame-with-title.html:
12:17 PM Changeset in webkit [52818] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping three new tests.

11:51 AM Changeset in webkit [52817] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-05 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by David Kilzer.

Switched to generating list of Perl unit test files dynamically,
instead of explicitly.

​https://bugs.webkit.org/show_bug.cgi?id=33200

  • Scripts/test-webkitperl:
11:44 AM Changeset in webkit [52816] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-05 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Reimplement EventSender::leapForward
​https://bugs.webkit.org/show_bug.cgi?id=33114

Follow Windows implementation of leapForward. When leapForward is called,
messages are queued and posted after the timeout. A new event loop is created to
handle those messages and the additional messages that are created as a result.

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::EventSender): (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo): (EventSender::leapForward): (EventSender::sendOrQueueEvent): (EventSender::replaySavedEvents): (EventSender::eventFilter):
  • DumpRenderTree/qt/EventSenderQt.h:
11:36 AM Changeset in webkit [52815] by eric@webkit.org
  • 6 edits in trunk

2010-01-05 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Drag & drop layout tests fail even when run manually
​https://bugs.webkit.org/show_bug.cgi?id=33055

No new tests. Fix 3 layout tests when run manually.
fast/events/drag-and-drop.html
fast/events/drag-and-drop-dataTransfer-types-nocrash.html
fast/events/drag-and-drop-fire-drag-dragover.html
Running these tests in DRT will be fixed in 31332.

  • page/qt/DragControllerQt.cpp: (WebCore::DragController::cleanupAfterSystemDrag): Cleanup the drag operation if it failed to complete, Otherwise, new drag operations will not be possible.

2010-01-05 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Drag & drop layout tests fail even when run manually
​https://bugs.webkit.org/show_bug.cgi?id=33055

No new tests. Fix 3 layout tests when run manually.
fast/events/drag-and-drop.html
fast/events/drag-and-drop-dataTransfer-types-nocrash.html
fast/events/drag-and-drop-fire-drag-dragover.html
Running these tests in DRT will be fixed in 31332.

  • Api/qwebpage.cpp: (dropActionToDragOp): (dragOpToDropAction): (QWebPagePrivate::dragEnterEvent): (QWebPagePrivate::dragMoveEvent): (QWebPagePrivate::dropEvent): Accept drag events even if they are not over a drop target. This is to ensure that drag events will continue to be delivered.
  • Api/qwebpage_p.h:
  • WebCoreSupport/DragClientQt.cpp: (WebCore::dragOperationToDropActions): (WebCore::dropActionToDragOperation): (WebCore::DragClientQt::startDrag): Send dragEnd event.
11:28 AM Changeset in webkit [52814] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-05 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Fix obscure queue crash in queueengine
​https://bugs.webkit.org/show_bug.cgi?id=33196

Sometimes we get an exception that can't be stringified. For example:

AttributeError: 'ParseError' object has no attribute 'msg'

In these cases, the whole queue dies because we're in the global
exception handler. Instead of dieing here, we should just print a less
informative message to the console. We're already printing the whole
backtrace anyway, so there's not much point to stringifying the
exception anyway.

  • Scripts/webkitpy/queueengine.py:
11:08 AM Changeset in webkit [52813] by kov@webkit.org
  • 4 edits in trunk

Reviewed by Xan Lopez.

Based on idea and original patch by Evan Martin.

Remove libWebCore intermediate library, to improve link time.

[GTK] Build time must be reduced
​https://bugs.webkit.org/show_bug.cgi?id=32921

11:06 AM Changeset in webkit [52812] by abarth@webkit.org
  • 8 edits in trunk/WebCore

2010-01-05 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Move allowSetting{Frame}SrcToJavascriptUrl from V8Custom to BindingSecurity and
remove the v8-specific pieces.

​https://bugs.webkit.org/show_bug.cgi?id=33182

  • bindings/BindingSecurity.h: (WebCore::::allowSettingFrameSrcToJavascriptUrl): Moved from V8CustomBinding.cpp. (WebCore::::allowSettingSrcToJavascriptURL): Moved from V8CustomBinding.cpp.
  • bindings/v8/custom/V8AttrCustom.cpp: (WebCore::V8Attr::valueAccessorSetter):
  • bindings/v8/custom/V8CustomBinding.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeCallback): (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNSCallback): (WebCore::V8Element::setAttributeNodeNSCallback):
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp: (WebCore::V8HTMLFrameElement::srcAccessorSetter): (WebCore::V8HTMLFrameElement::locationAccessorSetter):
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: (WebCore::V8HTMLIFrameElement::srcAccessorSetter):
11:04 AM Changeset in webkit [52811] by abarth@webkit.org
  • 11 edits
    4 copies
    1 move
    1 add
    1 delete in trunk/WebCore

2010-01-05 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Separate DOMWrapperWorld from V8IsolatedWorld
​https://bugs.webkit.org/show_bug.cgi?id=33087

This change separate DOMWrapperWorld and IsolatedWorld from
V8IsolatedWorld. I've also renamed V8IsolatedWorld to
V8IsolatedContext in preparation for having more than one context in a
single isolated world.

This patch moves us closer to two goals:
1) Matching the structure of the JSC implementation of isolated worlds.
2) Letting scripts running in isolated contexts see into other iframes

(which requires having more than one context in an isolated world.)

  • WebCore.gypi:
  • bindings/v8/DOMWrapperWorld.cpp: Added. (WebCore::DOMWrapperWorld::DOMWrapperWorld): (WebCore::mainThreadNormalWorld):
  • bindings/v8/DOMWrapperWorld.h: Added. (WebCore::DOMWrapperWorld::create):
  • bindings/v8/IsolatedWorld.cpp: Added. (WebCore::IsolatedWorld::IsolatedWorld): (WebCore::IsolatedWorld::~IsolatedWorld):
  • bindings/v8/IsolatedWorld.h: Added. (WebCore::IsolatedWorld::create): (WebCore::IsolatedWorld::count): (WebCore::IsolatedWorld::domDataStore):
  • bindings/v8/MainThreadDOMData.cpp: (WebCore::MainThreadDOMData::getMainThreadStore):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::currentScriptState):
  • bindings/v8/ScriptState.cpp:
  • bindings/v8/ScriptState.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8IsolatedContext.cpp: Copied from WebCore/bindings/v8/V8IsolatedWorld.cpp. (WebCore::V8IsolatedContext::contextWeakReferenceCallback): (WebCore::V8IsolatedContext::V8IsolatedContext): (WebCore::V8IsolatedContext::destroy): (WebCore::V8IsolatedContext::~V8IsolatedContext): (WebCore::V8IsolatedContext::scriptState):
  • bindings/v8/V8IsolatedContext.h: Copied from WebCore/bindings/v8/V8IsolatedWorld.h. (WebCore::V8IsolatedContext::getEntered): (WebCore::V8IsolatedContext::world):
  • bindings/v8/V8IsolatedWorld.cpp: Removed.
  • bindings/v8/V8IsolatedWorld.h: Removed.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::context):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::WorldContextHandle):
11:03 AM Changeset in webkit [52810] by abarth@webkit.org
  • 5 edits
    1 copy
    6 moves
    3 adds in trunk/WebCore

2010-01-05 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Move createWindow into generic bindings so it can be shared with JSC
​https://bugs.webkit.org/show_bug.cgi?id=33201

This patch moves createWindow from V8-specific code into the generic
bindings so that is can be re-used by the JavaScriptCore bindings. I
haven't actually moved the JSC bindings over to using this yet.

Also, I organized the generic bindings a bit more as it's becoming
clearer how things are going to shape up. There are still some
question marks, but hopefully the answers will become clear as we
progress.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/generic/BindingDOMWindow.h: Added. (WebCore::::createWindow):
  • bindings/generic/BindingSecurity.h: Renamed from WebCore/bindings/BindingSecurity.h. (WebCore::BindingSecurity::BindingSecurity): (WebCore::::canAccessWindow): (WebCore::::canAccessFrame): (WebCore::::checkNodeSecurity):
  • bindings/generic/BindingSecurityBase.cpp: Renamed from WebCore/bindings/BindingSecurityBase.cpp. (WebCore::BindingSecurityBase::getDOMWindow): (WebCore::BindingSecurityBase::getFrame): (WebCore::BindingSecurityBase::canAccess):
  • bindings/generic/BindingSecurityBase.h: Renamed from WebCore/bindings/BindingSecurityBase.h.
  • bindings/generic/GenericBinding.h: Renamed from WebCore/bindings/GenericBinding.h. (WebCore::):
  • bindings/v8/V8Binding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::showModalDialogCallback): (WebCore::V8DOMWindow::openCallback):
  • bindings/v8/specialization/V8BindingDOMWindow.h: Added. (WebCore::V8BindingDOMWindow::storeDialogArgs):
  • bindings/v8/specialization/V8BindingState.cpp: Renamed from WebCore/bindings/v8/V8BindingState.cpp. (WebCore::::Only): (WebCore::::getActiveWindow): (WebCore::::immediatelyReportUnsafeAccessTo):
  • bindings/v8/specialization/V8BindingState.h: Renamed from WebCore/bindings/v8/V8BindingState.h. (WebCore::):
11:00 AM Changeset in webkit [52809] by eric@webkit.org
  • 9 edits
    2 adds in trunk

2010-01-05 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32571

Added a test to make sure that ARIA checkboxes correctly handle the aria-checked attribute.

  • accessibility/aria-checkbox-checked-expected.txt: Added.
  • accessibility/aria-checkbox-checked.html: Added.

2010-01-05 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32571

For an object with an aria role of "checkbox" or "radiobutton",
Use the "aria-checked" attribute to determine if it's checked.

Test: accessibility/aria-checkbox-checked.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isChecked):

2010-01-05 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32571

For an object with an aria role of "checkbox" or "radiobutton",
use the "aria-checked" attribute to determine if it's checked.
These changes add an isChecked() method to AccessibilityUIElement
so that we can check for this property from a layout test.

  • DumpRenderTree/AccessibilityUIElement.cpp: (getIsCheckedCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isChecked):
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isChecked):
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isChecked):
10:43 AM Changeset in webkit [52808] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

Having a comment for the #endif for a header guard is not required WebKit style.
​https://bugs.webkit.org/show_bug.cgi?id=33214

Reviewed by Darin Adler.

  • Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit early when it has all the needed information to continue.
  • Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests.
10:40 AM Changeset in webkit [52807] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.18

Tagging 1.1.18.

10:36 AM Changeset in webkit [52806] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-05 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Added compiler error for unsupported platforms.
​https://bugs.webkit.org/show_bug.cgi?id=33112

  • jit/JITStubs.cpp:
10:14 AM Changeset in webkit [52805] by Adam Roben
  • 2 edits in trunk/WebKitTools

Share more code in the WebViewDestruction tests

Part of <​http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

  • WebKitAPITest/tests/WebViewDestruction.cpp:

(WebKitAPITest::createAndInitializeWebView): Renamed from
createWebView. Now initializes the HostWindow and returns the
WebView's HWND via an out-parameter.
(WebKitAPITest::finishWebViewDestructionTest): Added. Code came from
the CloseWithoutDestroyWindow test.
(WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from
CloseWithoutDestroyWindow and changed to use the new functions.
(WebKitAPITest::MainFrameAfterClose): Changed to use the new
functions.
(WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from
NoCloseOrDestroyWindow and changed to use the new functions.

10:14 AM Changeset in webkit [52804] by Adam Roben
  • 2 edits in trunk/WebKitTools

Don't show HostWindows by default

This was making WebKitAPITest very flashy as windows appeared and
disappeared.

Part of <​http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

  • WebKitAPITest/HostWindow.cpp:

(WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style
from the window.

10:14 AM Changeset in webkit [52803] by Adam Roben
  • 2 edits in trunk/WebKitTools

Don't hang in WebKitAPITest if no messages have been posted

Part of <​http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

  • WebKitAPITest/tests/WebViewDestruction.cpp:

(WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
to avoid hanging if no messages have been posted.

10:14 AM Changeset in webkit [52802] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix WebKitCreateInstance helper

Part of <​http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

  • WebKitAPITest/tests/WebViewDestruction.cpp:

(WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
through, instead of taking its address.

9:54 AM Changeset in webkit [52801] by yong.li@torchmobile.com
  • 3 edits in trunk/WebCore

2010-01-05 Yong Li <​yoli@rim.com>

Reviewed by Adam Roben.

Fix build warnings blindly
​https://bugs.webkit.org/show_bug.cgi?id=33178

  • platform/SharedBuffer.cpp:
  • platform/SharedBuffer.h: (WebCore::SharedBuffer::append):
9:45 AM Changeset in webkit [52800] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::append):

8:24 AM Changeset in webkit [52799] by yong.li@torchmobile.com
  • 4 edits in trunk/WebCore

2010-01-05 Yong Li <​yong.li@torchmobile.com>

Reviewed by Darin Adler.

Fix an obvious bug and build errors in previous commit (r52795)
​https://bugs.webkit.org/show_bug.cgi?id=33178

  • platform/SharedBuffer.h: (WebCore::SharedBuffer::isEmpty):
  • platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::maybeTransferPlatformData):
8:09 AM Changeset in webkit [52798] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-01-05 Gustavo Noronha Silva <Gustavo Noronha Silva>

Updated docs for 1.1.18 release.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
7:53 AM Changeset in webkit [52797] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

Follow r52729 in ARMAssembler.
​https://bugs.webkit.org/show_bug.cgi?id=33208

Reviewed by Maciej Stachowiak.

Use WTF_ARM_ARCH_AT_LEAST instead of ARM_ARCH_VERSION

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::encodeComplexImm): Move tmp declaration to ARMv7

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::):
(JSC::ARMAssembler::bkpt):

7:53 AM Changeset in webkit [52796] by xan@webkit.org
  • 4 edits in trunk

2010-01-05 Xan Lopez <​xlopez@igalia.com>

Bump for 1.1.18 release.

  • configure.ac:

WebKit/gtk:

2010-01-05 Xan Lopez <​xlopez@igalia.com>

Update for 1.1.18 release.

  • NEWS:
7:14 AM Changeset in webkit [52795] by yong.li@torchmobile.com
  • 7 edits in trunk/WebCore

2010-01-04 Yong Li <​yoli@rim.com>

Reviewed by Darin Adler.

Let SharedBuffer use a group of memory segments internally.
It will merge the segments into a flat consecutive buffer only when
necessary.
​https://bugs.webkit.org/show_bug.cgi?id=33178

  • platform/SharedBuffer.cpp: (WebCore::allocateSegment): (WebCore::freeSegment): (WebCore::SharedBuffer::SharedBuffer): (WebCore::SharedBuffer::~SharedBuffer): (WebCore::SharedBuffer::adoptVector): (WebCore::SharedBuffer::size): (WebCore::SharedBuffer::data): (WebCore::SharedBuffer::append): (WebCore::SharedBuffer::clear): (WebCore::SharedBuffer::copy): (WebCore::SharedBuffer::buffer): (WebCore::SharedBuffer::getSomeData):
  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::maybeTransferPlatformData):
  • platform/haiku/SharedBufferHaiku.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/qt/SharedBufferQt.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
6:22 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:00 AM Changeset in webkit [52794] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Unreviewed build fix for Gtk+

Don't use comments in Platform.h, at least some of them seem to make the version of GCC
used on the Gtk buildbot unhappy.

  • wtf/Platform.h:
2:28 AM Changeset in webkit [52793] by Simon Hausmann
  • 2 edits in trunk/WebCore

Unreviewed trivial Symbian build fix

  • plugins/symbian/PluginViewSymbian.cpp: Add missing HostWindow.h inclusion
1:45 AM Changeset in webkit [52792] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix broken export macros in package builds.

Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=33202

Always define QT_MAKEDLL unless we're doing a static
build or we're building inside of Qt. When building
inside of Qt the correct define is pulled from qbase.pri.

  • WebCore.pro:
12:58 AM Changeset in webkit [52791] by mjs@apple.com
  • 147 edits in trunk

2010-01-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Fisher.

Reorganize, document and rename OS() platform macros.
​https://bugs.webkit.org/show_bug.cgi?id=33198

  • wtf/Platform.h: Rename, reorganize and document OS() macros.

Adapt to name changes. Also fixed a few incorrect OS checks.

  • API/JSContextRef.cpp:
  • assembler/MacroAssemblerARM.cpp: (JSC::isVFPPresent):
  • assembler/MacroAssemblerX86Common.h:
  • bytecode/SamplingTool.cpp:
  • config.h:
  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::~RegisterFile):
  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::grow):
  • jit/ExecutableAllocator.h:
  • jit/ExecutableAllocatorFixedVMPool.cpp:
  • jit/ExecutableAllocatorPosix.cpp:
  • jit/ExecutableAllocatorSymbian.cpp:
  • jit/ExecutableAllocatorWin.cpp:
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITStubs.cpp:
  • jsc.cpp: (main):
  • parser/Grammar.y:
  • profiler/ProfileNode.cpp: (JSC::getCount):
  • runtime/Collector.cpp: (JSC::Heap::Heap): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr): (JSC::currentThreadStackBase): (JSC::getCurrentPlatformThread): (JSC::suspendThread): (JSC::resumeThread): (JSC::getPlatformThreadRegisters): (JSC::otherThreadStackPointer):
  • runtime/Collector.h:
  • runtime/DateConstructor.cpp:
  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
  • runtime/InitializeThreading.cpp: (JSC::initializeThreading):
  • runtime/MarkStack.h: (JSC::MarkStack::MarkStackArray::shrinkAllocation):
  • runtime/MarkStackPosix.cpp:
  • runtime/MarkStackSymbian.cpp:
  • runtime/MarkStackWin.cpp:
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncLastIndexOf):
  • runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
  • runtime/UString.cpp: (JSC::UString::from):
  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/CurrentTime.cpp: (WTF::lowResUTCTime):
  • wtf/CurrentTime.h: (WTF::getLocalTime):
  • wtf/DateMath.cpp:
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_ThreadCache::InitModule): (WTF::TCMallocStats::):
  • wtf/FastMalloc.h:
  • wtf/MathExtras.h:
  • wtf/RandomNumber.cpp: (WTF::randomNumber):
  • wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
  • wtf/StringExtras.h:
  • wtf/TCSpinLock.h: (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
  • wtf/TCSystemAlloc.cpp:
  • wtf/ThreadSpecific.h: (WTF::::destroy):
  • wtf/Threading.h:
  • wtf/ThreadingPthreads.cpp: (WTF::initializeThreading): (WTF::isMainThread):
  • wtf/ThreadingWin.cpp: (WTF::wtfThreadEntryPoint): (WTF::createThreadInternal):
  • wtf/VMTags.h:
  • wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault):
  • wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform):

2010-01-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Fisher.

Reorganize, document and rename OS() platform macros.
​https://bugs.webkit.org/show_bug.cgi?id=33198

Adapt to name changes.

  • src/ChromiumBridge.cpp:
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::isSelectTrailingWhitespaceEnabled): (WebKit::): (WebKit::EditorClientImpl::handleEditingKeyboardEvent):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::makeContextCurrent):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionAsText): (WebKit::WebFrameImpl::printPage):
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::mouseContextMenu): (WebKit::WebViewImpl::mouseUp): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::sendContextMenuEvent): (WebKit::WebViewImpl::setScrollbarColors): (WebKit::WebViewImpl::navigationPolicyFromMouseEvent):

2010-01-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Fisher.

Reorganize, document and rename OS() platform macros.
​https://bugs.webkit.org/show_bug.cgi?id=33198

Adapt to name changes.

  • webkit/webkitwebsettings.cpp: (webkit_get_user_agent):

2010-01-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Fisher.

Reorganize, document and rename OS() platform macros.
​https://bugs.webkit.org/show_bug.cgi?id=33198

Adapt to name changes. Also fixed a few incorrect OS checks.

  • accessibility/AccessibilityObject.h:
  • config.h:
  • dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::platform):
  • loader/CachedFont.cpp:
  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryParser.cpp:
  • page/EventHandler.cpp:
  • page/Frame.cpp: (WebCore::Frame::setUseSecureKeyboardEntry):
  • page/NavigatorBase.cpp: (WebCore::NavigatorBase::platform):
  • page/Page.h:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:
  • page/chromium/DragControllerChromium.cpp: (WebCore::DragController::isCopyKeyDown):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::accessKeyModifiers):
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/FileSystem.h:
  • platform/KeyboardCodes.h:
  • platform/PurgeableBuffer.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
  • platform/chromium/ClipboardUtilitiesChromium.cpp:
  • platform/chromium/ClipboardUtilitiesChromium.h:
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::documentFragment):
  • platform/chromium/PlatformKeyboardEventChromium.cpp: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout): (WebCore::PopupMenu::show):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName):
  • platform/graphics/FontCache.h:
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
  • platform/graphics/Gradient.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/Path.h:
  • platform/graphics/Pattern.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cg/ColorCG.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/chromium/FontCustomPlatformData.h:
  • platform/graphics/chromium/FontPlatformData.h:
  • platform/graphics/opentype/OpenTypeUtilities.cpp:
  • platform/graphics/opentype/OpenTypeUtilities.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getWindowsContext):
  • platform/graphics/qt/ImageQt.cpp:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipToImageBuffer):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::save): (PlatformContextSkia::restore):
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFiles): (WebCore::Icon::paint):
  • platform/graphics/wx/GraphicsContextWx.cpp:
  • platform/gtk/FileSystemGtk.cpp: (WebCore::filenameToString): (WebCore::filenameFromString): (WebCore::filenameForDisplay):
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  • platform/network/curl/ResourceHandleManager.cpp:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
  • platform/text/String.cpp: (WebCore::String::format): (WebCore::String::number):
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
  • platform/text/TextStream.cpp:
  • platform/text/TextStream.h:
  • platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::decode):
  • platform/win/PlatformMouseEventWin.cpp: (WebCore::messageToEventType): (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/win/PlatformScreenWin.cpp: (WebCore::deviceInfoForWidget): (WebCore::screenIsMonochrome):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): (WebCore::PopupMenu::paint): (WebCore::PopupMenu::registerClass): (WebCore::PopupMenu::PopupMenuWndProc): (WebCore::PopupMenu::wndProc):
  • platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime):
  • platform/wx/FileSystemWx.cpp: (WebCore::unloadModule):
  • plugins/PluginDatabase.cpp:
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::compareFileVersion):
  • plugins/PluginPackage.h:
  • plugins/PluginView.cpp: (WebCore::PluginView::setFrameRect): (WebCore::PluginView::stop): (WebCore::PluginView::PluginView):
  • plugins/PluginView.h:
  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addWindowsMediaPlayerPluginDirectory): (WebCore::addMacromediaPluginDirectories):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
  • plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView): (WebCore::PluginView::wndProc): (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paintIntoTransformedContext): (WebCore::PluginView::paintWindowedPluginIntoContext): (WebCore::PluginView::paint): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::platformStart):

2010-01-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Fisher.

Reorganize, document and rename OS() platform macros.
​https://bugs.webkit.org/show_bug.cgi?id=33198

Adapt to name changes.


  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/config.h:
12:55 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:47 AM Changeset in webkit [52790] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-05 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Minor improvements to test-webkit-scripts, as suggested
by an earlier review.

​https://bugs.webkit.org/show_bug.cgi?id=33125

  • Scripts/test-webkit-scripts:
    • Used OptionParser class instead of getopt.getopt().
    • Created main() method for main block.
    • Enclosed functions in a class.
12:07 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:06 AM Changeset in webkit [52789] by Chris Fleizach
  • 2 edits in trunk/WebKitTools

No review. Fix DRT breakage on Tiger/Leopard.

Add ARIA "Live Region" support
​https://bugs.webkit.org/show_bug.cgi?id=33117

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
12:00 AM Changeset in webkit [52788] by darin@chromium.org
  • 8 edits in trunk/WebKit/chromium

2010-01-04 Darin Fisher <​darin@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Expose more DOM methods to support LayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=33185

  • public/WebDocument.h: Adds documentElement method.
  • public/WebElement.h: Adds innerText method.
  • public/WebFrame.h: Adds renderTreeAsText and counterValueForElementById methods, and fixes a few whitespace issues.
  • src/WebDocument.cpp: (WebKit::WebDocument::documentElement):
  • src/WebElement.cpp: (WebKit::WebElement::innerText):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearName): (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::counterValueForElementById):
  • src/WebFrameImpl.h:
Note: See TracTimeline for information about the timeline view.