⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 9, 2010:

7:12 PM Changeset in webkit [53048] by dbates@webkit.org
  • 9 edits in trunk

2010-01-09 Daniel Bates <​dbates@webkit.org>

No review, rolling out r53044.
​http://trac.webkit.org/changeset/53044
​https://bugs.webkit.org/show_bug.cgi?id=33419


We need to look into this some more because the Qt
bot is failing the XSSAuditor tests. See bug #33419
for more details.

  • Api/qwebsettings.cpp:
  • Api/qwebsettings.h:

2010-01-09 Daniel Bates <​dbates@webkit.org>

No review, rolling out r53044.
​http://trac.webkit.org/changeset/53044
​https://bugs.webkit.org/show_bug.cgi?id=33419


We need to look into this some more because the Qt
bot is failing the XSSAuditor tests. See bug #33419
for more details.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

2010-01-09 Daniel Bates <​dbates@webkit.org>

No review, rolling out r53044.
​http://trac.webkit.org/changeset/53044
​https://bugs.webkit.org/show_bug.cgi?id=33419


We need to look into this some more because the Qt
bot is failing the XSSAuditor tests. See bug #33419
for more details.

  • platform/qt/Skipped:
6:52 PM Changeset in webkit [53047] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-09 Daniel Bates <​dbates@webkit.org>

No review, rolling out r53045.
​http://trac.webkit.org/changeset/53045
​https://bugs.webkit.org/show_bug.cgi?id=33440

This fix did not resolve the issue. That is, more XSSAuditor tests are
failing on the Qt bot. So, we're going ultimately going to rollout the
change committed in change set 53044 <​http://trac.webkit.org/changeset/53044>,
but we need to first rollout the attempted fix committed in change
set 53045.

  • platform/qt/Skipped:
6:36 PM Changeset in webkit [53046] by abarth@webkit.org
  • 28 edits in trunk

2010-01-09 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

ScriptController::isEnabled needs to be renamed
​https://bugs.webkit.org/show_bug.cgi?id=32063

Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts to reflect what the method actually
means. This is a trivial change, but it involved touching a lot of
call sites.

  • WebCore.PluginHostProcess.exp:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::canExecuteScripts): (WebCore::ScriptController::executeScript):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::bindingRootObject): (WebCore::ScriptController::windowScriptNPObject): (WebCore::ScriptController::jsObjectForPluginElement): (WebCore::ScriptController::executeScriptInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::windowScriptObject):
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/js/ScriptState.cpp: (WebCore::scriptStateFromNode):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::windowScriptNPObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieve):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::evaluateScript):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::controls):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken):
  • inspector/InspectorController.cpp: (WebCore::canPassNodeToJavaScript):
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::isProcessingUserGesture): (WebCore::FrameLoader::open): (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds): (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):

2010-01-09 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

ScriptController::isEnabled needs to be renamed
​https://bugs.webkit.org/show_bug.cgi?id=32063

Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::bindToWindowObject):

2010-01-09 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

ScriptController::isEnabled needs to be renamed
​https://bugs.webkit.org/show_bug.cgi?id=32063

Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):

2010-01-09 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

ScriptController::isEnabled needs to be renamed
​https://bugs.webkit.org/show_bug.cgi?id=32063

Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts.

  • WebFrame.cpp: (wxWebFrame::RunScript):
6:00 PM Changeset in webkit [53045] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-09 Daniel Bates <​dbates@webkit.org>

Rubber-stamped by Adam Barth.

Adds failing XSSAuditor tests to the Qt Skipped file
while we come up with a fix for them. See bug #33440
for more details.

  • platform/qt/Skipped:
4:40 PM Changeset in webkit [53044] by dbates@webkit.org
  • 9 edits in trunk

2010-01-09 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33419

Adds support for the XSSAuditor to the Qt DRT.

  • Api/qwebsettings.cpp: Updated comment to reflect added key XSSAuditorEnabled.
  • Api/qwebsettings.h: Adds settings key XSSAuditorEnabled.

2010-01-09 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33419

Removes the XSSAuditor tests from the Qt Skipped file since
we now can run these tests.

  • platform/qt/Skipped:

2010-01-09 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33419

Adds support for the XSSAuditor to the Qt DRT.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
4:20 PM Changeset in webkit [53043] by abarth@webkit.org
  • 3 edits
    1 copy
    1 add in trunk/WebKitTools

2010-01-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Retry writes to QueueStatusServer when we get 500 errors
​https://bugs.webkit.org/show_bug.cgi?id=33412

This prevents the queues from failing to mark a patch as "pass" or
"fail" when AppEngine throws 500 errors.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/networktransaction.py: Added.
  • Scripts/webkitpy/networktransaction_unittest.py: Added.
  • Scripts/webkitpy/statusserver.py:
  • Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
  • Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
  • Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
4:18 PM Changeset in webkit [53042] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-09 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

Inspector font for errors is ugly on non-OSX platforms
​https://bugs.webkit.org/show_bug.cgi?id=33340

  • css/view-source.css: Add a fallback to sans-serif on a CSS selector that previously only listed Lucida Grande.
4:01 PM Changeset in webkit [53041] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers

Reviewed by Eric Seidel.

  • QueueStatusServer/templates/statusbubble.html: Added

-moz-border-radius and -webkit-border-radius to provide rounded
borders in older Firefox and Safari browsers.

2:50 PM Changeset in webkit [53040] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-09 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by David Kilzer.

Modified VCSUtils::gitdiff2svndiff() to accept strings that
end in vertical white space.

​https://bugs.webkit.org/show_bug.cgi?id=33415

  • Scripts/VCSUtils.pm:
  • Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
10:45 AM Changeset in webkit [53039] by mitz@apple.com
  • 5 edits
    4 adds in trunk

<rdar://problem/7525778> Font fallback kills SVG kerning
​https://bugs.webkit.org/show_bug.cgi?id=33400

Reviewed by Nikolas Zimmermann.

WebCore:

Test: platform/mac/fast/text/sticky-typesetting-features.html

Cache font attributes separately for different typesetting features.

  • platform/graphics/SimpleFontData.h: Replaced single-element caches

with maps.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::disableLigatures): Added an ATSUStyle parameter.
(WebCore::initializeATSUStyle): Look up the ATSUStyle in the map and
initialize if necessary. Return the ATSUStyle.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
Use the ATSUStyle returned from initializeATSUStyle().

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformDestroy): Destroy the ATSUStyles in the
map.
(WebCore::SimpleFontData::getCFStringAttributes): Look up the attributes
dictionary in the map and initialize if necessary.

LayoutTests:

  • platform/mac/fast/text/sticky-typesetting-features-expected.checksum: Added.
  • platform/mac/fast/text/sticky-typesetting-features-expected.png: Added.
  • platform/mac/fast/text/sticky-typesetting-features-expected.txt: Added.
  • platform/mac/fast/text/sticky-typesetting-features.html: Added.

Jan 8, 2010:

11:49 PM Changeset in webkit [53038] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-08 Adam Barth <​abarth@webkit.org>

Unreviewed. Fix namespace indent for SecurityOrigin.h.

  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::domainWasSetInDOM): (WebCore::SecurityOrigin::protocol): (WebCore::SecurityOrigin::host): (WebCore::SecurityOrigin::domain): (WebCore::SecurityOrigin::port): (WebCore::SecurityOrigin::canLoadLocalResources): (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::isSandboxed): (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage): (WebCore::SecurityOrigin::):
11:40 PM Changeset in webkit [53037] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-01-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dmitry Titov.

bindings/v8/DOMData is missing a virtual destructor
​https://bugs.webkit.org/show_bug.cgi?id=33390

DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes
but it does not have a virtual destructor. While this isn't currently causing
any leaks, since there are no instances of ChildThreadDOMData or
MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC
compiler generates the following compilation error:

"/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual
functions and accessible non-virtual destructor"

We therefore need to add a virtual destructor to DOMData.

  • bindings/v8/DOMData.cpp: (WebCore::DOMData::~DOMData):
  • bindings/v8/DOMData.h:
11:09 PM Changeset in webkit [53036] by dbates@webkit.org
  • 7 edits in trunk

2010-01-08 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33417

Cleans up style errors exposed by the patch for bug #33198.
Moreover, fixes all "Weird number of spaces at line-start. Are you using a 4-space indent?"
errors reported by check-webkit-style.

No functionality was changed. So, no new tests.

  • wtf/Platform.h:

2010-01-08 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33417

Cleans up style errors exposed by the patch for bug #33198.

No functionality was changed. So, no new tests.

  • src/GraphicsContext3D.cpp:

2010-01-08 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33417

Cleans up style errors exposed by the patch for bug #33198.

No functionality was changed. So, no new tests.

  • platform/graphics/SimpleFontData.h:
  • plugins/PluginPackage.cpp:
8:48 PM Changeset in webkit [53035] by Simon Fraser
  • 1 edit
    1 delete in trunk/LayoutTests

2010-01-08 Simon Fraser <Simon Fraser>

No review.

Remove layout test that was committed by mistake.

  • compositing/webgl/webgl-blending.html: Removed.
8:07 PM Changeset in webkit [53034] by Simon Fraser
  • 4 edits
    26 adds in trunk

2010-01-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

WebGL canvas paints background color twice
​https://bugs.webkit.org/show_bug.cgi?id=33361

Clean up some logic around "directly composited" content: some images, video, and WebGL.

We previously set the GraphicsLayer background color to the CSS background color
in some cases where the box has no other decorations. However, the content
layer's bounds do not correspond with the background box in many cases,
and we could end up both painting the background color, and setting it on the layer.

Simplify this logic to never use layer background colors, and thus skip allocating
backing store only when the element has no visible box decorations.

Tests: compositing/images/direct-image-background-color.html

compositing/reflections/simple-composited-reflections.html
compositing/video/video-background-color.html
compositing/webgl/webgl-background-color.html
compositing/webgl/webgl-blending.html

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::is3DCanvas): Utility to determine if a RenderObject is a canvas with WebGL (WebCore::RenderLayerBacking::RenderLayerBacking): Remove m_hasDirectlyCompositedContent. (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): canUseDirectCompositing() is renamed to isDirectlyCompositedImage() and only applies to images now. No longer set layer background color. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Just use hasPaintedContent() as the argument to setDrawsContent(). (WebCore::hasBoxDecorationsOrBackground): Renamed. (WebCore::RenderLayerBacking::hasNonCompositingContent): (WebCore::hasBoxDecorationsOrBackgroundImage): Renamed from hasBoxDecorations(). (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Moved test for hasOverflowControls() into hasNonCompositingContent() and removed the FIXME comment. (WebCore::RenderLayerBacking::containsPaintedContent): New method that decides if the layer (and its non-composited children) has any content that must be painted into backing store. (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Renamed from canUseDirectCompositing() and reduced to only apply to images. (WebCore::RenderLayerBacking::rendererContentChanged): 3D canvas no longer falls under the canUseDirectCompositing() scope.
6:16 PM Changeset in webkit [53033] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

<​http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button

Reviewed by Adam Barth.

This button was broken during a previous Bugzilla upgrade after
changes were made to the names of objects exposed on templates.

  • template/en/custom/attachment/reviewform.html.tmpl: Changed

attachid to attachment.id and ispatch to attachment.ispatch.
Also tweaked the format to use 4 table columns instead of 5.

5:57 PM Changeset in webkit [53032] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Eric Seidel.

Don't store RegExp flags string representation
​https://bugs.webkit.org/show_bug.cgi?id=33321

It's unused; the string representation is reconstructed from flags.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h:
5:46 PM Changeset in webkit [53031] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

5:45 PM Changeset in webkit [53030] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.22

New tag.

5:39 PM Changeset in webkit [53029] by mrowe@apple.com
  • 8 edits in branches/safari-4-branch

Merge r52141.

5:39 PM Changeset in webkit [53028] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

5:25 PM Changeset in webkit [53027] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-08 Steve Block <​steveblock@google.com>

Reviewed by Darin Adler.

Use member initialization syntax instead of assignment for member variables of Document used
for determining minimum layout delay.
​https://bugs.webkit.org/show_bug.cgi?id=33316

No new tests, style change only.

  • dom/Document.cpp: Modified. (WebCore::Document::Document): Modified. Use initializer list for m_startTime, m_overMinimumLayoutThreshold and m_extraLayoutDelay.
5:02 PM Changeset in webkit [53026] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-01-08 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Passing array that is too large to set method of WebGLArrays does not throw an exception
​https://bugs.webkit.org/show_bug.cgi?id=33352

Added needed range checks to JSC and V8 custom bindings. Expanded
preexisting test suite for WebGLArrays and updated its expected
results. Tested in WebKit and Chromium.

  • fast/canvas/webgl/array-set-out-of-bounds-expected.txt: Added.
  • fast/canvas/webgl/array-set-out-of-bounds.html: Added.
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2010-01-08 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Passing array that is too large to set method of WebGLArrays does not throw an exception
​https://bugs.webkit.org/show_bug.cgi?id=33352

Added needed range checks to JSC and V8 custom bindings. Expanded
preexisting test suite for WebGLArrays and updated its expected
results. Tested in WebKit and Chromium.

Test: fast/canvas/webgl/array-set-out-of-bounds.html

  • bindings/js/JSWebGLArrayHelper.h: (WebCore::setWebGLArrayFromArray):
  • bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::setWebGLArrayFromArray):
5:02 PM Changeset in webkit [53025] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Memory use grows grows possibly unbounded in this JavaScript Array test case
​https://bugs.webkit.org/show_bug.cgi?id=31675

This fixes one observed bug in this test case, which is that
arrays don't report extra cost for the sparse value maps.

SunSpider reports a small speedup.

  • runtime/JSArray.cpp: (JSC::JSArray::putSlowCase): Report extra memory cost for the sparse value map.
  • runtime/JSArray.h:
4:46 PM Changeset in webkit [53024] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Eric Seidel <​eric@webkit.org>

Reviewed by Alexey Proskuryakov.

http/tests/xmlhttprequest/logout.html failed on Tiger Bot
​https://bugs.webkit.org/show_bug.cgi?id=31412

  • platform/mac-tiger/Skipped: After talking with Alexey, we're just gonna skip the failing test on Tiger.
4:30 PM Changeset in webkit [53023] by ap@apple.com
  • 3 edits
    6 adds in trunk

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=32962
HTML tags are wrongfully parsed when setting innerHTML of a SCRIPT element

Also fixed the same for STYLE elements.

Tests: fast/dom/css-innerHTML.html

fast/dom/script-innerHTML-x.xhtml
fast/dom/script-innerHTML.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML): Don't parse JS or CSS as HTML, matching Firefox.
4:20 PM Changeset in webkit [53022] by bfulgham@webkit.org
  • 3 edits in trunk/WebKit/win

Build fix, no review.

Protect video control logic inside ENABLE(VIDEO).

  • WebView.cpp:

(WebView::enterFullscreenForNode):
(WebView::exitFullscreen):

  • WebView.h:
4:05 PM Changeset in webkit [53021] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Replacing all RANDOMBLOB calls with ZEROBLOB calls in preparation
for denying RANDOMBLOB calls in HTML5 DB transactions.

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=33396

  • storage/open-database-while-transaction-in-progress.html:
3:59 PM Changeset in webkit [53020] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Included UNCONFIRMED bugs by default in advanced search query

Rubber-stamped by Alexey Proskuryakov.

  • data/params: Prepended 'bug_status=UNCONFIRMED&' to

'defaultquery' parameter.

3:53 PM Changeset in webkit [53019] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=33279
fast/websockets/websocket-event-target.html causes any test after it to fail

  • fast/websockets/script-tests/websocket-event-target.js: The test uses an HTTP server URL to create a WebSocket, so an error may be logged to console when detected (this is timing dependent).
  • platform/mac/Skipped: Removed the test from Skipped list.
3:52 PM Changeset in webkit [53018] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-08 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

run-javascriptcore-tests needs a --quiet flag
​https://bugs.webkit.org/show_bug.cgi?id=33399

Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.

  • Scripts/webkitpy/steps/runtests.py:
3:35 PM Changeset in webkit [53017] by Beth Dakin
  • 9 edits
    8 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
with -webkit-shadow on svg shapes
-and-
<rdar://problem/7389149>

Reviewed by Oliver Hunt.

Inflate the repaintRect for the shadow using its extent.

  • rendering/RenderForeignObject.cpp:

(WebCore::RenderForeignObject::computeRectForRepaint):

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::computeRectForRepaint):

  • rendering/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::computeRectForRepaint):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::computeRectForRepaint):

  • rendering/SVGRenderSupport.cpp:

(WebCore::getSVGShadowExtent):
(WebCore::SVGRenderBase::inflateForShadow):

  • rendering/SVGRenderSupport.h:

LayoutTests: Tests for ​https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
with -webkit-shadow on svg shapes
-and-
<rdar://problem/7389149>

Reviewed by Oliver Hunt.

  • fast/repaint/moving-shadow-on-container.html: Added.
  • fast/repaint/moving-shadow-on-path.html: Added.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum: Added.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.png: Added.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum: Added.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.png: Added.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt: Added.
3:27 PM Changeset in webkit [53016] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

FIX: Make patch status appear on reviewform.html.tmpl

  • template/en/custom/attachment/reviewform.html.tmpl: Check

attachment.ispatch (not just ispatch) when deciding whether
to display patch status. Also update layout a bit.

3:22 PM Changeset in webkit [53015] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2010-01-08
Reviewed by Alexey Proskuryakov.

To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
the time when Apache and WebSocketServer is locked by tests.
Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
we need to run http and websocket tests after all other tests.
If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
we need to preserve the given order.

  • Scripts/run-webkit-tests:
3:22 PM Changeset in webkit [53014] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Update data/params parameters

  • data/params: Updated 'timezone' to turn off DST. Updated

'usebugaliases' and 'usevotes' to turn them off.

3:01 PM Changeset in webkit [53013] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Don't post style-queue pass messages to bugs
​https://bugs.webkit.org/show_bug.cgi?id=33404

These messages aren't needed any more now that we have the status
bubble reporting pass events passively.

  • Scripts/webkitpy/commands/queues.py:
2:51 PM Changeset in webkit [53012] by ap@apple.com
  • 4 edits in trunk/LayoutTests

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32294
http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg

Changed the test to not have any funky characters. Filed bug 33400 to track the underlying
problem with kerning.

  • http/tests/uri/escaped-entity-expected.txt:
  • http/tests/uri/escaped-entity.html:
  • platform/mac/Skipped:
2:45 PM Changeset in webkit [53011] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Optimize the number of CPUs used for building Qt and Gtk
​https://bugs.webkit.org/show_bug.cgi?id=33394

Instead of hardcoding the number 8, we should read the number of CPUs
from the environment.

  • Scripts/webkitpy/executive.py:
  • Scripts/webkitpy/webkitport.py:
  • Scripts/webkitpy/webkitport_unittest.py:
2:31 PM Changeset in webkit [53010] by Dimitri Glazkov
  • 15 edits in trunk/LayoutTests

2010-01-08 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

New baselines to reflect the smaller repaint areas caused by r52839
​https://bugs.webkit.org/show_bug.cgi?id=33271

  • platform/mac/fast/repaint/background-misaligned-expected.checksum:
  • platform/mac/fast/repaint/background-misaligned-expected.png:
  • platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.checksum:
  • platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum:
  • platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
  • platform/mac/fast/repaint/float-new-in-block-expected.checksum:
  • platform/mac/fast/repaint/float-new-in-block-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/mac/fast/repaint/selected-replaced-expected.checksum:
  • platform/mac/fast/repaint/selected-replaced-expected.png:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.checksum:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.png:
2:29 PM Changeset in webkit [53009] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-01-08 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

WebGLArray subclasses do the wrong conversion in indexSetter
​https://bugs.webkit.org/show_bug.cgi?id=33350

  • fast/canvas/webgl/array-setters-expected.txt: Added.
  • fast/canvas/webgl/array-setters.html: Added.
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2010-01-08 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

WebGLArray subclasses do the wrong conversion in indexSetter
​https://bugs.webkit.org/show_bug.cgi?id=33350

Test: fast/canvas/webgl/array-setters.html

  • bindings/js/JSWebGLFloatArrayCustom.cpp: (WebCore::JSWebGLFloatArray::indexSetter):
  • bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: (WebCore::JSWebGLUnsignedIntArray::indexSetter):
2:05 PM Changeset in webkit [53008] by yong.li@torchmobile.com
  • 2 edits in trunk/JavaScriptCore

2010-01-08 Yong Li <​yoli@rim.com>

Reviewed by Darin Adler.

Remove unnecessary #include from FastMalloc.cpp
​https://bugs.webkit.org/show_bug.cgi?id=33393

  • wtf/FastMalloc.cpp:
2:05 PM Changeset in webkit [53007] by eric@webkit.org
  • 4 edits in trunk/BugsSite

2010-01-08 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Show patch status in bugs.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=33368

This patch adds an iframe to the show_bug page and the edit attachment
page that displays whether the attachment passed the various bots.

  • template/en/custom/attachment/edit.html.tmpl:
  • template/en/custom/attachment/list.html.tmpl:
  • template/en/custom/attachment/reviewform.html.tmpl:
1:49 PM Changeset in webkit [53006] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

transitions/cancel-transition.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=33398

There's a race between the check() call and the final
setTimeout. Just remove the final setTimeout and put
its contents in the check call itself.

  • transitions/cancel-transition.html:
1:48 PM Changeset in webkit [53005] by eric@webkit.org
  • 8 edits
    2 moves in trunk

2010-01-08 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Delegation client
​https://bugs.webkit.org/show_bug.cgi?id=32826

Factory related code removed from QtAbstractWebPopup. Popups are now created
by ChromeClientQt.
Popup content information struct added to class QtAbstractWebPopup.
PopupMenuClient is now hidden from higher layers.
QtAbstractWebPopup now receives content information and font as parameters
of method populate.
QtFallbackWebPopup moved to WebKit/qt/WebCoreSupport.

  • WebCore.pro:
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::getItems): (WebCore::PopupMenu::show):
  • platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::popupDidHide): (WebCore::QtAbstractWebPopup::valueChanged):
  • platform/qt/QtAbstractWebPopup.h: (WebCore::QtAbstractWebPopup::Item::):
  • platform/qt/QtFallbackWebPopup.cpp: Removed.
  • platform/qt/QtFallbackWebPopup.h: Removed.

2010-01-08 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Delegation client
​https://bugs.webkit.org/show_bug.cgi?id=32826

Added method createPopup to ChromeClientQt used to create popups.
QtFallbackWebPopup moved from WebCore/platform/qt to
WebKit/qt/WebCoreSupport.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createPopup):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/QtFallbackWebPopup.cpp: Added. (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate): (WebCore::QtFallbackWebPopup::showPopup): (WebCore::QtFallbackWebPopup::hidePopup): (WebCore::QtFallbackWebPopup::activeChanged): (WebCore::QtFallbackWebPopup::setParent):
  • WebCoreSupport/QtFallbackWebPopup.h: Added. (WebCore::QtFallbackWebPopup::hide):
1:31 PM Changeset in webkit [53004] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-08 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Skip invalid blocks in CSS property declarations.
​https://bugs.webkit.org/show_bug.cgi?id=31231
​https://bugs.webkit.org/show_bug.cgi?id=26619

This patch makes the CSS parser skip property declarations containing invalid blocks.

  • fast/css/parsing-error-recovery-expected.txt: Added.
  • fast/css/parsing-error-recovery.html: Added.

2010-01-08 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Skip invalid blocks in CSS property declarations.
​https://bugs.webkit.org/show_bug.cgi?id=31231
​https://bugs.webkit.org/show_bug.cgi?id=26619

This patch makes the CSS parser skip property declarations containing invalid blocks.

Test: fast/css/parsing-error-recovery.html

  • css/CSSGrammar.y:
1:11 PM Changeset in webkit [53003] by cmarrin@apple.com
  • 8 edits in trunk/LayoutTests

Fixed media test failures caused by ​http://trac.webkit.org/changeset/52998.
The media controller on Windows now has a full-screen button, which changes
the layout and therefore the test results. I regenerated them for
Windows.

1:07 PM Changeset in webkit [53002] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

The Windows Release bots were having trouble with the xmlhttprequest tests, so
they were skipped (r50280). They all currently pass on my machine, so unskipping them now.

  • platform/win/Skipped:
12:49 PM Changeset in webkit [53001] by darin@chromium.org
  • 3 edits
    3 adds in trunk/WebKit/chromium

2010-01-08 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Upstream webkit unit tests from the chromium repository
​https://bugs.webkit.org/show_bug.cgi?id=33351

This adds one such test (for KURL) and sets up the test framework.

Switch WebKit to build a static library on all platforms. Add a
webkit_unit_tests executable target that runs the unit tests and also
ensures that we don't have any missing symbols (a function that WebKit
as a shared library used to serve).

Changes chromium_src_dir to ../../WebKit/chromium to match how
WebCore.gyp defines that variable.

  • WebKit.gyp:
  • public/WebKitClient.h: (WebKit::WebKitClient::getPluginList): Remove bogus trailing semi-colon. (WebKit::WebKitClient::decrementStatsCounter): Remove bogus trailing semi-colon. (WebKit::WebKitClient::incrementStatsCounter): Remove bogus trailing semi-colon. (WebKit::WebKitClient::traceEventBegin): Remove bogus trailing semi-colon. (WebKit::WebKitClient::traceEventEnd): Remove bogus trailing semi-colon. (WebKit::WebKitClient::histogramCounts): Remove bogus trailing semi-colon.
  • tests: Added.
  • tests/KURLTest.cpp: Added.
  • tests/WebKitTest.h: Added.
12:31 PM Changeset in webkit [53000] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: CSS content not returned correctly in AX
​https://bugs.webkit.org/show_bug.cgi?id=33308

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/css-content-attribute.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

LayoutTests:

  • platform/mac/accessibility/css-content-attribute-expected.txt: Added.
  • platform/mac/accessibility/css-content-attribute.html: Added.
11:58 AM Changeset in webkit [52999] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-06 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

transitions/shorthand-border-transitions.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=33276

Yet another transitions test that doesn't give consistent
wiggle room. Make all the wiggle rooms account for >=200ms
instead of some that were only giving 100ms wiggle room.

  • transitions/shorthand-border-transitions.html:
11:23 AM Changeset in webkit [52998] by cmarrin@apple.com
  • 17 edits
    2 adds in trunk

Implement full-screen video for Windows
​https://bugs.webkit.org/show_bug.cgi?id=31318

10:55 AM Changeset in webkit [52997] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Unreviewed correction.

Accidentally left unnecessary modification to hdcFromContext
in when landing r52995.

  • WebFrame.cpp:

(hdcFromContext): Back out unneeded modification.

10:54 AM Changeset in webkit [52996] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-08 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Adam Barth.

Fix a regression that removed a call to
FrameLoaderClient::didDestroyScriptContextForFrame.
​https://bugs.webkit.org/show_bug.cgi?id=33347

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::disposeContextHandles):
10:16 AM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
9:30 AM Changeset in webkit [52995] by bfulgham@webkit.org
  • 5 edits in trunk

WebCore: WebKit plugins are not rendered during printing.
​https://bugs.webkit.org/show_bug.cgi?id=33022.

Reviewed by Adam Roben.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintWindowedPluginIntoContext): Tell

cairo printing surface to flush so that blank regions do
not write over the plugin's paint operations.

  • rendering/RenderLayer.cpp: Build fix.

(WebCore::RenderLayer::beginTransparencyLayers): Correct

method signature missing for ColorSpace.

WebKit/win: Use correct cairo surface data type for handling print operations.
​https://bugs.webkit.org/show_bug.cgi?id=33022.

Reviewed by Adam Roben.

  • WebFrame.cpp:

(scaleFactor): Handle 'scale = 0' case.
(WebFrame::spoolPage): Use scaleFactor helper function. Account for

margin size in region passed to header/footer routines.

(WebFrame::spoolPages): Properly clean up Cairo surface.

9:24 AM Changeset in webkit [52994] by Chris Fleizach
  • 7 edits in trunk

REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
​https://bugs.webkit.org/show_bug.cgi?id=33300

Reviewed by Eric Seidel.

WebCore:

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:withContext:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):

LayoutTests:

  • platform/mac/Skipped:
6:27 AM Changeset in webkit [52993] by Csaba Osztrogonác
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed trivail fix. Missing bugzilla link added to ChangeLog.(r52976)

6:22 AM Changeset in webkit [52992] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

r52976 revealed this failure by re-ordering tests.

I do not have a Snow Leopard build to test with, so skipping this
and filed bug ​https://bugs.webkit.org/show_bug.cgi?id=33372

  • platform/mac-snowleopard/Skipped: platform/mac/editing/input/devanagari-ligature.html skipped.
5:26 AM Changeset in webkit [52991] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in this skiplist by this commit.

  • platform/win/Skipped:
5:08 AM Changeset in webkit [52990] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

r52976 revealed this failure by re-ordering tests.
r52980 corrected the expected results file, but Windows still fails,
presumably due to another test still affecting this one.

Reviewed by Eric Seidel.

I do not have a windows build to test with, so skipping this
and filed bug ​https://bugs.webkit.org/show_bug.cgi?id=33374

  • platform/win/Skipped: svg/W3C-SVG-1.1/filters-conv-01-f.svg skipped.
4:59 AM Changeset in webkit [52989] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-08 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Hausmann.

commit-queue should run run-javascriptcore-tests
​https://bugs.webkit.org/show_bug.cgi?id=33376

I also made it run the python and perl unit tests.

  • Scripts/webkitpy/steps/runtests.py:
  • Scripts/webkitpy/webkitport.py:
4:46 AM Changeset in webkit [52988] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Threading problems with some of the tests
​https://bugs.webkit.org/show_bug.cgi?id=30814

We are going to skip all the storage tests until we find the issue
with the threading system in the gtk port.

  • platform/gtk/Skipped:
4:09 AM Changeset in webkit [52987] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Eric Seidel <​eric@webkit.org>

No review, rolling out r52983.
​http://trac.webkit.org/changeset/52983
​https://bugs.webkit.org/show_bug.cgi?id=33321

Broke 59 JavaScriptCore tests. I don't think Kent knew about
run-javascriptcore-tests. Sadly neither does the commit-bot,
yet.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h: (JSC::RegExp::flags):
3:54 AM Changeset in webkit [52986] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-01-08 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

[GTK] loading test should use SoupServer instead of actual sites
​https://bugs.webkit.org/show_bug.cgi?id=33353

Make all the loading tests use SoupServer, instead of fetching
stuff from the Internet.

  • tests/testloading.c: (server_callback): (get_uri_for_path): (test_loading_status): (test_loading_error): (test_loading_cancelled): (load_wentback_status_changed_cb): (load_error_test): (test_loading_goback): (main):
3:50 AM Changeset in webkit [52985] by pfeldman@chromium.org
  • 6 edits
    2 adds
    1 delete in trunk/WebCore

2010-01-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Regex-based syntax highlighting is slow.

​https://bugs.webkit.org/show_bug.cgi?id=33330

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/JavaScriptHighlighterScheme.js: Removed.
  • inspector/front-end/JavaScriptTokenizer.js: Added. (WebInspector.JavaScriptTokenizer): (WebInspector.JavaScriptTokenizer.prototype.set line): (WebInspector.JavaScriptTokenizer.prototype.getCondition): (WebInspector.JavaScriptTokenizer.prototype.setCondition): (WebInspector.JavaScriptTokenizer.prototype._charAt): (WebInspector.JavaScriptTokenizer.prototype.nextToken):
  • inspector/front-end/JavaScriptTokenizer.re2js: Added.
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
3:44 AM Changeset in webkit [52984] by eric@webkit.org
  • 8 edits in trunk

2010-01-08 Eric Seidel <​eric@webkit.org>

No review, rolling out r52981.
​http://trac.webkit.org/changeset/52981
​https://bugs.webkit.org/show_bug.cgi?id=33319

Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

2010-01-08 Eric Seidel <​eric@webkit.org>

No review, rolling out r52981.
​http://trac.webkit.org/changeset/52981
​https://bugs.webkit.org/show_bug.cgi?id=33319

Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/regexp-compile-expected.txt:
  • fast/js/script-tests/regexp-compile.js:
  • fast/regex/non-pattern-characters-expected.txt:
3:32 AM Changeset in webkit [52983] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Darin Adler.

Don't store RegExp flags string representation
​https://bugs.webkit.org/show_bug.cgi?id=33321

It's unused; the string representation is reconstructed from flags.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h:
3:23 AM Changeset in webkit [52982] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Eric Seidel <​eric@webkit.org>

Reviewed by Tor Arne Vestbø.

media/unsupported-tracks.html is failing on Snow Leopard Release bot
​https://bugs.webkit.org/show_bug.cgi?id=32339

  • platform/mac-snowleopard/Skipped: Add this to join a bunch of other skipped media tests which time out.
3:17 AM Changeset in webkit [52981] by eric@webkit.org
  • 8 edits in trunk

2010-01-08 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
​https://bugs.webkit.org/show_bug.cgi?id=33319

"" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.

  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

2010-01-08 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
​https://bugs.webkit.org/show_bug.cgi?id=33319

Add new test cases and adapt existing ones.

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/script-tests/regexp-compile.js:
  • fast/regex/non-pattern-characters-expected.txt:
2:22 AM Changeset in webkit [52980] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-08 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Hausmann.

http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg
​https://bugs.webkit.org/show_bug.cgi?id=32294

  • platform/mac/Skipped: Add http/tests/uri/escaped-entity.html to Skipped list since it affects later tests.
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Check in correct results.
2:12 AM Changeset in webkit [52979] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Fisher.

REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
​https://bugs.webkit.org/show_bug.cgi?id=33300

Skipping platform/mac/accessibility/aria-liveregions-notifications.html
to make the bots green until Chris Fleizach can fix the AX Notification system
to correctly unregister logging callbacks.

  • platform/mac/Skipped:
12:51 AM Changeset in webkit [52978] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

RVCT compiler with "-Otime -O3" optimization tries to optimize out
inline new'ed pointers that are passed as arguments.
Proposed patch assigns new'ed pointer explicitly outside function call.

Patch by Norbert Leser <​norbert.leser@nokia.com> on 2010-01-08
Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=33084

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

12:01 AM Changeset in webkit [52977] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

Remove an unnecessary cacheFlush from ARM_TRADITIONAL JIT
​https://bugs.webkit.org/show_bug.cgi?id=33203

Reviewed by Gavin Barraclough.

  • assembler/ARMAssembler.cpp: Remove obsolete linkBranch function.

(JSC::ARMAssembler::executableCopy): Inline a clean linkBranch code.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::getLdrImmAddress): Use inline function.
(JSC::ARMAssembler::getLdrImmAddressOnPool): Ditto.
(JSC::ARMAssembler::patchPointerInternal): Remove an unnecessary cacheFlush.
(JSC::ARMAssembler::linkJump): Use patchPointerInternal instead of linkBranch.
(JSC::ARMAssembler::linkCall): Ditto.
(JSC::ARMAssembler::relinkCall): Ditto.

Note: See TracTimeline for information about the timeline view.