⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 23, 2010:

11:44 PM Changeset in webkit [53774] by oliver@apple.com
  • 6 edits in trunk

2010-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Implement support for FileList cloning in postMessage
​https://bugs.webkit.org/show_bug.cgi?id=34048

Add test for passing a FileList through postMessage, and
correct testing already present to test what it was meant
to be.

  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone.html:

2010-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Implement support for FileList cloning in postMessage
​https://bugs.webkit.org/show_bug.cgi?id=34048

Support passing FileList through postMessage APIs. Basically
mechanical task in line with other terminals in the object
graph.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedFileList::create): (WebCore::SerializedFileList::length): (WebCore::SerializedFileList::item): (WebCore::SerializedFileList::SerializedFileList): (WebCore::SerializedScriptValueData::SerializedScriptValueData): (WebCore::SharedSerializedData::asFileList): (WebCore::SerializingTreeWalker::convertIfTerminal): (WebCore::DeserializingTreeWalker::convertIfTerminal): (WebCore::TeardownTreeWalker::convertIfTerminal):

Rearrange these functions to not use 'default:' handling
so that the compiler will actually tell us when we're
not handling cases.

  • bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValueData::): (WebCore::SerializedScriptValueData::asFileList):
5:50 PM Changeset in webkit [53773] by mitz@apple.com
  • 3 edits
    1 delete in trunk

<rdar://problem/7569820> svg/custom/text-zoom.xhtml fails on Windows
​https://bugs.webkit.org/show_bug.cgi?id=34006

Reviewed by Maciej Stachowiak.

WebKit/win:

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Added WebKitZoomsTextOnlyPreferenceKey
with a default value of true.

LayoutTests:

  • platform/win/svg/custom/text-zoom-expected.txt: Removed.
1:53 PM Changeset in webkit [53772] by kenneth@webkit.org
  • 3 edits in trunk/WebKitTools

[Qt] Unreviewed build fix

  • QtLauncher/QtLauncher.pro:
  • QtLauncher/webinspector.h:
1:40 PM Changeset in webkit [53771] by kenneth@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

Rubberstamped by Simon Hausmann.

[Qt] Move the WebInspector class to it's own header file.

  • QtLauncher/main.cpp:
  • QtLauncher/webinspector.h: Added.

(WebInspector::WebInspector):
(WebInspector::showEvent):
(WebInspector::hideEvent):

8:54 AM Changeset in webkit [53770] by eric@webkit.org
  • 6 edits in trunk

2010-01-23 Robert Hogan <​robert@roberthogan.net>

Reviewed by Kenneth Rohde Christiansen.

Qt DRT: respect window.close() and window.closed()

Qt DRT needs to maintain a correct count of open windows
for windowCount(). It also needs to delete windows that
have been closed by window.close().

This fixes the following tests:

plugins/destroy-during-npp-new.html
fast/dom/Document/early-document-access.html
fast/dom/Window/window-early-properties.html
fast/events/open-window-from-another-frame.html
fast/events/popup-blocking-click-in-iframe.html

​https://bugs.webkit.org/show_bug.cgi?id=32953

  • platform/qt/Skipped:

2010-01-23 Robert Hogan <​robert@roberthogan.net>

Reviewed by Kenneth Rohde Christiansen.

Qt DRT: respect window.close() and window.closed()

Qt DRT needs to maintain a correct count of open windows
for windowCount(). It also needs to delete windows that
have been closed by window.close().

This fixes the following tests:

plugins/destroy-during-npp-new.html
fast/dom/Document/early-document-access.html
fast/dom/Window/window-early-properties.html
fast/events/open-window-from-another-frame.html
fast/events/popup-blocking-click-in-iframe.html

​https://bugs.webkit.org/show_bug.cgi?id=32953

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::createWindow): (WebCore::DumpRenderTree::windowCloseRequested):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::maybeDump):
8:37 AM Changeset in webkit [53769] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-01-23 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix positioning of ComboBox popup in QGraphicsWebView.

Wrap the popup in a QGraphicsProxyWidget, so that the popup
transforms with the item.

​https://bugs.webkit.org/show_bug.cgi?id=33887

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup): (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show):
  • WebCoreSupport/QtFallbackWebPopup.h:
8:08 AM Changeset in webkit [53768] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-01-22 Simon Fraser <Simon Fraser>

Reviewed by Eric Carlson.

Race condition in video setup can force videos into software mode
​https://bugs.webkit.org/show_bug.cgi?id=34034

We used to call setUpVideoRendering() unconditionally from
acceleratedRenderingStateChanged(); this could happen before the movie had any
data, and thus force the movie into software rendering mode.

Fix by returning early from setUpVideoRendering() if isReadyForRendering() returns false,
which also allows us to remove some other checks for being ready to render.

Timing dependent, hard to make a test for.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToMedia): Optimize to do an early return if passing in the same layer that is already being used.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setUpVideoRendering): Return without doing anything if not ready to render. (WebCore::MediaPlayerPrivate::updateStates): No need to call isReadyForRendering() any more, since setUpVideoRendering() does that. (WebCore::MediaPlayerPrivate::setVisible): No need to check the ready state; this is equivalent to the check inside of setUpVideoRendering().
3:43 AM Changeset in webkit [53767] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-23 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Add new inspector test added in r53766 to skipi
list on qt platform.

  • platform/qt/Skipped:
2:13 AM Changeset in webkit [53766] by yurys@chromium.org
  • 44 edits
    2 adds in trunk

2010-01-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Inject inspector script directly into the inspected context. All the
communication between the script and the frontend is serialized into
JSON strings. It allows to get rid of object quarantines in Web Inspector.

​https://bugs.webkit.org/show_bug.cgi?id=32554

Test: inspector/console-log-before-inspector-open.html

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::databaseForId): (WebCore::JSInjectedScriptHost::currentCallFrame): (WebCore::JSInjectedScriptHost::nodeForId): (WebCore::JSInjectedScriptHost::pushNodePathToFrontend): (WebCore::JSInjectedScriptHost::selectDatabase): (WebCore::JSInjectedScriptHost::selectDOMStorage):
  • bindings/js/ScriptCallStack.h: (WebCore::ScriptCallStack::globalState):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptObject.h: (WebCore::ScriptObject::scriptState):
  • bindings/js/ScriptValue.cpp:
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::globalState):
  • bindings/v8/ScriptObject.h: (WebCore::ScriptObject::scriptState):
  • bindings/v8/ScriptValue.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::setInjectedScriptSource): (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::releaseWrapperObjectGroup):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::pausedScript):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages): (WebInspector.ConsoleView.prototype.doEvalInWindow):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parseRule):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged.InjectedScriptAccess.get addInspectedNode): (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.setDocument): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
  • inspector/front-end/EventListenersSidebarPane.js: ():
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess): (InjectedScriptAccess.getDefault): (get InjectedScriptAccess): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane): (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback):
  • inspector/front-end/ObjectPropertiesSection.js:
  • inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.pausedScript): (WebInspector.addConsoleMessage): (WebInspector.log.logMessage): (WebInspector.log):

2010-01-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Inject inspector script directly into the inspected context. All the
communication between the script and the frontend is serialized into
JSON strings. It allows to get rid of object quarantines in Web Inspector.

Test that web inspector doesn't crash when opening if there are messages in
the console. Refactor test case due to InjectedScriptAccess changes.

​https://bugs.webkit.org/show_bug.cgi?id=32554

  • inspector/console-log-before-inspector-open-expected.txt: Added.
  • inspector/console-log-before-inspector-open.html: Added.
  • inspector/styles-iframe.html:
1:51 AM Changeset in webkit [53765] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Added a user default for specifying a fallback frameworks path in case
the bundle does not contain frameworks for the current Mac OS X version.

Reviewed by Mark Rowe.

  • WebKitLauncher/main.m:

(fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
keyed by the FallbackSystemVersions user default and returns it.
(main): If a frameworks directory for the current system version is not found,
try the fallback.

Jan 22, 2010:

11:11 PM Changeset in webkit [53764] by eric@webkit.org
  • 16 edits
    4 copies
    1 add in trunk

2010-01-22 Alex Milowski <​alex@milowski.com>

Reviewed by David Hyatt.

Updated tests due to stylesheet changes.

  • platform/mac/mathml/presentation/sub-expected.checksum:
  • platform/mac/mathml/presentation/sub-expected.png:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.checksum:
  • platform/mac/mathml/presentation/sup-expected.png:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:

2010-01-22 Alex Milowski <​alex@milowski.com>

Reviewed by David Hyatt.

Added support for RenderMathMLBlock base object and isRenderMathMLBlock()
method on RenderObject.

Added support for text elements and updated tag and attribute names

Also, updated the stylesheet added files to the project

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • css/mathml.css:
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/MathMLTextElement.cpp: Added. (WebCore::MathMLTextElement::MathMLTextElement): (WebCore::MathMLTextElement::create): (WebCore::MathMLTextElement::createRenderer):
  • mathml/MathMLTextElement.h: Added.
  • mathml/RenderMathMLBlock.cpp: Added. (WebCore::RenderMathMLBlock::RenderMathMLBlock): (WebCore::RenderMathMLBlock::styleDidChange): (WebCore::RenderMathMLBlock::isChildAllowed): (WebCore::RenderMathMLBlock::makeBlockStyle): (WebCore::RenderMathMLBlock::nonOperatorHeight): (WebCore::RenderMathMLBlock::stretchToHeight):
  • mathml/RenderMathMLBlock.h: Added. (WebCore::RenderMathMLBlock::isRenderMathMLBlock): (WebCore::RenderMathMLBlock::isRenderMathMLOperator): (WebCore::RenderMathMLBlock::isRenderMathMLRow): (WebCore::RenderMathMLBlock::isRenderMathMLMath): (WebCore::RenderMathMLBlock::hasBase): (WebCore::toRenderMathMLBlock):
  • mathml/mathattrs.in: Added.
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderMathMLBlock):
10:51 PM Changeset in webkit [53763] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-22 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Make run-webkit-tests work under Cygwin for the Qt port

setPathForRunningWebKitApp() is implemented for the Qt port
by using qmake to query for the location of the Qt libraries.

This requires the original environment (%ENV) to be untouched,
so launchWithCurrentEnv() was refactored to launchWithEnv(),
and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
instead. This has the added benefit of getting rid of the temp
variables used for storing the current env.

openDumpTool() is also refactored a bit into platform-spesific,
port-spesific, and generic environment variables.

Checks for undef was added a few places to fix Perl concat
warnings when run-webkit-tests is aborted.

​https://bugs.webkit.org/show_bug.cgi?id=33895

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
10:35 PM Changeset in webkit [53762] by eric@webkit.org
  • 6 edits in trunk/LayoutTests

2010-01-22 Garret Kelly <​gdk@chromium.org>

Reviewed by David Levin.

Fixing svg/custom/stroke-width-click.svg to not cause the double-click
handler to fire on certain platforms (chromium, for one). Chromium,
Leopard, and GTK all agree on the calculated extents of the shape, so I'm
disabling this test on mac-tiger and re-enabling it on mac-leopard and
updating the expected file to reflect the current state of the test.
​https://bugs.webkit.org/show_bug.cgi?id=33865

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • svg/custom/stroke-width-click-expected.txt:
  • svg/custom/stroke-width-click.svg:
10:19 PM Changeset in webkit [53761] by eric@webkit.org
  • 11 edits
    4 adds in trunk

2010-01-22 James Robinson <​jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

Adds tests for the 'selected' attribute of <option>s
​https://bugs.webkit.org/show_bug.cgi?id=32641

HTMLOptionElement_selected2 checks that the selected attribute is up to date immediately after the <select>
parsed. HTMLOptionElement_selected3 does the same, but checks immediately prior to the </select>.

Also changes the expectation for add-remove-option-modification-event to reflect that we now pass.

  • fast/forms/HTMLOptionElement_selected-expected.txt:
  • fast/forms/HTMLOptionElement_selected.html:
  • fast/forms/HTMLOptionElement_selected2-expected.txt: Added.
  • fast/forms/HTMLOptionElement_selected2.html: Added.
  • fast/forms/HTMLOptionElement_selected3-expected.txt: Added.
  • fast/forms/HTMLOptionElement_selected3.html: Added.
  • fast/forms/add-remove-option-modification-event-expected.txt:

2010-01-22 James Robinson <​jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

Ensures that the 'selected' attribute of an <option> is correct
​https://bugs.webkit.org/show_bug.cgi?id=32641

Adds a check in OptionElement::selected() that checks if list items need to be recalculated and does so if needed,
so the attribute is up to date more often. Also gets rid of most of the recalcStyle() side effects.

Our behavior now matches Firefox 3.5 and IE8 after the </select> is parsed.

Tests: fast/forms/HTMLOptionElement_selected2.html

fast/forms/HTMLOptionElement_selected3.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::setOptionsChangedOnRenderer): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::restoreFormControlState): (WebCore::SelectElement::reset): (WebCore::SelectElement::typeAheadFind):
  • dom/SelectElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::selected): (WebCore::HTMLOptionElement::insertedIntoTree):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
  • html/HTMLSelectElement.h:
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::recalcStyle):
9:43 PM Changeset in webkit [53760] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-22 Chris Rogers <​crogers@google.com>

Reviewed by Eric Seidel.

Need to handle WebGLUnsignedByteArray as method argument for V8 binding
​https://bugs.webkit.org/show_bug.cgi?id=33929

V8 code generator does not have associated tests

  • bindings/scripts/CodeGeneratorV8.pm:
9:27 PM Changeset in webkit [53759] by eric@webkit.org
  • 7 edits in trunk

2010-01-22 Elliot Glaysher <​erg@chromium.org>

Reviewed by David Levin.

Chromium: theme selection colors to match gtk theme
Add functions to RenderThemeChromiumLinux to change the selection color
according to the current GTK+ theme.

Since the change is to the Chromium WebKit API layer, testing is done
in Chromium's test shell (see Chromium side of this patch:
​http://codereview.chromium.org/554004)

​https://bugs.webkit.org/show_bug.cgi?id=33921

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumLinux::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumLinux::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumLinux::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumLinux::setSelectionColors):
  • rendering/RenderThemeChromiumLinux.h: Adds static members.

2010-01-22 Elliot Glaysher <​erg@chromium.org>

Reviewed by David Levin.

Chromium: theme selection colors to match gtk theme
Add functions to RenderThemeChromiumLinux to change the selection color
according to the current GTK+ theme.

Since the change is to the Chromium WebKit API layer, testing is done
in Chromium's test shell (see Chromium side of this patch:
​http://codereview.chromium.org/554004)

​https://bugs.webkit.org/show_bug.cgi?id=33921

  • public/WebView.h: Adds interface to change the selection colors
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setSelectionColors): Implements new interface.
  • src/WebViewImpl.h:
9:11 PM Changeset in webkit [53758] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-22 Steve VanDeBogart <​vandebo@chromium.org>

Reviewed by David Levin.

A new test to check that middle clicking on the primary scroll bars
does not trigger a paste event.
​https://bugs.webkit.org/show_bug.cgi?id=33062

  • scrollbars/scrollbar-middleclick-nopaste-expected.txt: Added.
  • scrollbars/scrollbar-middleclick-nopaste.html: Added.

2010-01-22 Steve VanDeBogart <​vandebo@chromium.org>

Reviewed by David Levin.

Middle clicking the main scroll bars should not trigger a paste event
in Linux chromium.
​https://bugs.webkit.org/show_bug.cgi?id=33062

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseUp):
9:09 PM UsingGitWithWebKit edited by Chris Jerdonek
Added note about "commit-log-editor" and dcommit. (diff)
8:59 PM UsingGitWithWebKit edited by Chris Jerdonek
Added note about squashing commits, if necessary, before dcommit. (diff)
8:42 PM Changeset in webkit [53757] by kevino@webkit.org
  • 17 edits in trunk

Reviewed by Kevin Ollivier.

[wx] Remove the Bakefile build system, which is no longer being used.

​https://bugs.webkit.org/show_bug.cgi?id=34022

8:33 PM Changeset in webkit [53756] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Build fix after r53718.

8:18 PM Changeset in webkit [53755] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Update platform-specific test results following r53722

8:06 PM Changeset in webkit [53754] by kov@webkit.org
  • 3 edits
    2 adds in trunk

LayoutTests

2010-01-22 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Simon Fraser.

Checking in platform-specific results for test that is failing
because of an additional single pixel in size - the test passes,
when testing manually.

  • platform/gtk/svg/custom/text-zoom-expected.txt: Added.

WebKitTools

2010-01-22 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Simon Fraser.

Reset zoom level to 1.0 when resetting view state. This is causing
many tests to fail after svg/custom/text-zoom.xhtml changes the
zoom level.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
8:00 PM Changeset in webkit [53753] by sfalken@apple.com
  • 3 edits in trunk/LayoutTests

Roll out r53752 to fix bots.

7:46 PM Changeset in webkit [53752] by sfalken@apple.com
  • 3 edits in trunk/LayoutTests

Rubber-stamped by Cameron Zwarich.

Re-enable Geolocation tests on Mac.

  • platform/mac/Skipped:
  • platform/win/Skipped:
7:06 PM Changeset in webkit [53751] by sfalken@apple.com
  • 1 edit in trunk/WebCore/platform/GeolocationService.cpp

Mac build fix.

6:53 PM Changeset in webkit [53750] by sfalken@apple.com
  • 1 edit in trunk/WebCore/platform/mac/GeolocationServiceMac.mm

Build fix. Don't include CoreLocation-based Geolocation if CLIENT_BASED_GEOLOCATION is set.

6:34 PM Changeset in webkit [53749] by sfalken@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Build fix. Touch exp file to force it to rebuild via DerivedSources.make.

6:18 PM WikiStart edited by Chris Jerdonek
Alphabetized Documentation pages to find them more easily (diff)
6:16 PM Changeset in webkit [53748] by pkasting@chromium.org
  • 1 edit
    1 delete in trunk/WebCore

Remove unnecessary copy of zlib.
​https://bugs.webkit.org/show_bug.cgi?id=34028

Reviewed by Darin Adler.

  • platform/image-decoders/zlib: Removed.
  • platform/image-decoders/zlib/adler32.c: Removed.
  • platform/image-decoders/zlib/compress.c: Removed.
  • platform/image-decoders/zlib/crc32.c: Removed.
  • platform/image-decoders/zlib/crc32.h: Removed.
  • platform/image-decoders/zlib/deflate.c: Removed.
  • platform/image-decoders/zlib/deflate.h: Removed.
  • platform/image-decoders/zlib/gzio.c: Removed.
  • platform/image-decoders/zlib/infback.c: Removed.
  • platform/image-decoders/zlib/inffast.c: Removed.
  • platform/image-decoders/zlib/inffast.h: Removed.
  • platform/image-decoders/zlib/inffixed.h: Removed.
  • platform/image-decoders/zlib/inflate.c: Removed.
  • platform/image-decoders/zlib/inflate.h: Removed.
  • platform/image-decoders/zlib/inftrees.c: Removed.
  • platform/image-decoders/zlib/inftrees.h: Removed.
  • platform/image-decoders/zlib/mozzconf.h: Removed.
  • platform/image-decoders/zlib/trees.c: Removed.
  • platform/image-decoders/zlib/trees.h: Removed.
  • platform/image-decoders/zlib/uncompr.c: Removed.
  • platform/image-decoders/zlib/zconf.h: Removed.
  • platform/image-decoders/zlib/zlib.h: Removed.
  • platform/image-decoders/zlib/zutil.c: Removed.
  • platform/image-decoders/zlib/zutil.h: Removed.
6:07 PM Changeset in webkit [53747] by ajwong@chromium.org
  • 4 edits in trunk/WebKit/chromium

Not reviewed. backout.

Backout r53705. Causes ui_tests to timeout, and browser_tests to fail with
TestConnectToBadPort and WindowOpenInvalidExtension.

5:58 PM Changeset in webkit [53746] by sfalken@apple.com
  • 12 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=34025
Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.

Reviewed by Darin Adler.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

WebKitTools:

  • Scripts/build-webkit:
5:52 PM Changeset in webkit [53745] by Simon Fraser
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-01-22 Simon Fraser <Simon Fraser>

No review.

Commit missing test result.

  • fast/dom/Window/webkitConvertPointUpdateLayout-expected.txt: Added.
5:51 PM Changeset in webkit [53744] by dimich@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Fix tests, unreviewed. Adding expectations file missing from r53739

  • fast/dom/Window/webkitConvertPointUpdateLayout-expected.txt: Added.
5:33 PM Changeset in webkit [53743] by sfalken@apple.com
  • 2 edits in trunk/LayoutTests

Build fix. Add missing comma.

  • fast/dom/Window/window-properties.html:
5:17 PM Changeset in webkit [53742] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-01-22 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

REGRESSION (r53110): Find My iPhone message dialog is offset from original position once it gets focus
​https://bugs.webkit.org/show_bug.cgi?id=33821

Fix an issue with the geometry of fixed position, composited layers inside other
composited layers. If we called convertToLayerCoords() on a fixed layer with an ancestor
layer which is not the root, then we assumed that the fixed layer had a positioning root.
However, this is not always the case, since the fixed layer may have a compositing ancestor
which is not a fixed container.

Test: compositing/geometry/fixed-in-composited.html

  • rendering/RenderLayer.cpp: (WebCore::isFixedPositionedContainer): Utility function to test whether a layer acts as a fixed position container.

(WebCore::RenderLayer::convertToLayerCoords): When called on a fixed position layer
for an ancestor layer that is not the root, compute the correct offsets by looking for
the fixed position container, and computing offsets relative to that. If the ancestorLayer
is the fixed position container, fall through to the existing code that is shared
with absolutely positioned layers.

5:14 PM Changeset in webkit [53741] by sfalken@apple.com
  • 3 edits in trunk/LayoutTests

Skip fast/dom/Window/window-properties-geolocation.html
until ​https://bugs.webkit.org/show_bug.cgi?id=34025 is landed.

  • platform/mac/Skipped:
  • platform/win/Skipped:
5:07 PM Changeset in webkit [53740] by sfalken@apple.com
  • 7 edits
    1 copy
    1 add
    1 delete in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=34024
Layout tests don't easily allow Geolocation to be on in only a subset of platforms

Reviewed by Darin Adler.

  • fast/dom/Window/window-properties-geolocation-expected.txt: Added.
  • fast/dom/Window/window-properties-geolocation.html: Copied from fast/dom/Window/window-properties.html.

Moved Geolocation property testing here.

  • fast/dom/Window/window-properties.html: Exclude Geolocation from testing. Moved to window-properties-geolocation.html.
  • fast/dom/navigator-detached-no-crash.html: Exclude Geolocation from output.
  • fast/dom/script-tests/prototype-inheritance-2.js: Exclude Geolocation.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Removed Geolocation properties from expected results.
  • platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Removed. Gtk results now match baseline.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Removed Geolocation properties from expected results.
  • platform/qt/Skipped: Skip Geolocation tests. Not yet available in Qt.
4:46 PM Changeset in webkit [53739] by Simon Fraser
  • 3 edits
    1 add in trunk

2010-01-22 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

webkitConvertPointFromNodeToPage doesn't take into account most recent transform style
​https://bugs.webkit.org/show_bug.cgi?id=34023

Be sure to call updateLayoutIgnorePendingStylesheets() before doing point mapping,
to apply any style changes since the last layout.

Test: fast/dom/Window/webkitConvertPointUpdateLayout.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitConvertPointFromNodeToPage): Call updateLayoutIgnorePendingStylesheets(). (WebCore::DOMWindow::webkitConvertPointFromPageToNode): Ditto.
4:46 PM Changeset in webkit [53738] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, fixes one issue with window-property-descriptors test.

  • fast/dom/Window/script-tests/window-property-descriptors.js: Don't dump the property that only appears in debug build, it will fail tests in debug.
4:43 PM Changeset in webkit [53737] by mjs@apple.com
  • 4 edits in trunk/WebCore

2010-01-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Roben.

Use stale cache data when going back and forward but not using WebCore’s page cache
​https://bugs.webkit.org/show_bug.cgi?id=33993
<rdar://problem/7383392>

No tests since this is a performance change.

  • loader/CachePolicy.h: (WebCore::): Add CachePolicyAllowStale.
  • loader/DocLoader.cpp: (WebCore::DocLoader::checkForReload): Never reload in the case of CachePolicyAllowStale.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::subresourceCachePolicy): Return CachePolicyAllowStale if the main resource is being loaded to allow stale data. (WebCore::FrameLoader::addExtraFieldsToRequest): Use ReturnCacheDataElseLoad on back/forward loads - needed when going back of forward to a page with frames.
4:31 PM Changeset in webkit [53736] by knorton@google.com
  • 2 edits in trunk/WebCore

2010-01-22 Kelly Norton <​knorton@google.com>

Reviewed by Pavel Feldman.

Web Inspector: JavaScript Error in DOMAgent.js:375 (_attributesUpdated)
​https://bugs.webkit.org/show_bug.cgi?id=33915

Errors were caused by the fact that Element::attributes calls Element::setAttribute to
synchronized the styleAttr. The fix is to simply check the synchronizing style attribute
flag.

  • dom/Element.cpp: (WebCore::Element::setAttribute): Checked for case where styleAttr is being synchronized.
4:27 PM Changeset in webkit [53735] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-22 Adam Barth <​abarth@webkit.org>

Unreviewed. Arg. Someone renamed limit to output_limit on me.

  • Scripts/webkitpy/commands/queues.py:
4:21 PM Changeset in webkit [53734] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-22 Adam Barth <​abarth@webkit.org>

Rubber stamped by Eric Seidel.

Make init.py and buildbot.py pass pep8 style checker.

  • Scripts/webkitpy/init.py:
  • Scripts/webkitpy/buildbot.py:
4:12 PM Changeset in webkit [53733] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-21 Joe Mason <​jmason@rim.com>

Reviewed by Adam Barth.

webkit-patch should retry on invalid password
​https://bugs.webkit.org/show_bug.cgi?id=33955

Ask for bugs.webkit.org authentication in a loop.

  • Scripts/webkitpy/bugzilla.py:
4:10 PM Changeset in webkit [53732] by jianli@chromium.org
  • 5 edits in trunk/LayoutTests

No review. Updated Qt layout tests due to r53722.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
4:06 PM Changeset in webkit [53731] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-22 Adam Barth <​abarth@webkit.org>

Unreviewed. Don't call seek on a NoneType.

  • Scripts/webkitpy/statusserver.py:
3:58 PM Changeset in webkit [53730] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-22 Petri Latvala <​petri.latvala@nomovok.com>

Reviewed by David Levin.

check-webkit-style breaks on files with unknown types
​https://bugs.webkit.org/show_bug.cgi?id=34001

For files with type FileType.NONE, dispatch_processor returns None.

  • Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
3:58 PM Changeset in webkit [53729] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make bugzilla.py and webkitport.py conform to pep8
​https://bugs.webkit.org/show_bug.cgi?id=34015

This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
style as enforced by pep8.py. I wasn't able to get rid of all the
errors because I'm not sure how to wrap some lines properly. Also,
there are a few deprication errors that I couldn't resolve easily.
However, this is a massive improvement in compliance.

  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/webkitport.py:
3:57 PM Changeset in webkit [53728] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-22 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Limit length of EWS results to 5MB
​https://bugs.webkit.org/show_bug.cgi?id=34016

Hopefully this will fix the bug where the results link doesn't appear.
Our current theory is that the results blob is too big and the server
is rejecting the request with a 500 error. That causes us to re-try
the post, but when we re-try the StringIO buffer has its seek pointer
at the end.

  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/statusserver.py:
3:54 PM Changeset in webkit [53727] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

No review. Build fix.
Updated the newly added test to count the change from r53722.

  • fast/dom/Window/window-property-descriptors-expected.txt:
3:50 PM Changeset in webkit [53726] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Platform dependent expected files added for tests introduced in r53656,
because these tests pass. Compared to png files.

Reviewed by Nikolas Zimmermann.

  • platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt: Added.
3:49 PM Changeset in webkit [53725] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-01-22 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Update r53711 for GraphicsLayer method rename.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::createLayerForMovie): Rename from change setContentsToVideo.
3:41 PM Changeset in webkit [53724] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, test fix.

Update a layout test for change in page scroll size.
​https://bugs.webkit.org/show_bug.cgi?id=32595

  • fast/events/scrollbar-double-click-expected.txt:
3:36 PM Changeset in webkit [53723] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

2010-01-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix comment in the a SVG <use> testcase, it should say "green rectangles" instead of "blue rectangles", as noticed by Csaba Osztrogonac.

  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.checksum:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml:
3:03 PM Changeset in webkit [53722] by jianli@chromium.org
  • 7 edits in trunk

WebCore: Add BlobConstructor to DOMWindow.
​https://bugs.webkit.org/show_bug.cgi?id=33982

Reviewed by Darin Adler.

  • page/DOMWindow.idl:

LayoutTests: Updated the affected tests due to adding BlobConstructor to DOMWindow.
​https://bugs.webkit.org/show_bug.cgi?id=33982

Reviewed by Darin Adler.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
3:03 PM Changeset in webkit [53721] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

[WebFrame loadRequest:] does not null check the WebCore::Frame
<rdar://problem/7416286> and ​https://bugs.webkit.org/show_bug.cgi?id=34021

Reviewed by Adele Peterson.

  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]): Null check the WebCore::Frame as it can disappear

out of underneath a WebFrame.

2:59 PM Changeset in webkit [53720] by jianli@chromium.org
  • 3 edits in trunk/LayoutTests

Add test for new attributes introduced in File and Blob interfaces.
​https://bugs.webkit.org/show_bug.cgi?id=33980

Reviewed by Darin Adler.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js:
2:18 PM Changeset in webkit [53719] by bweinstein@apple.com
  • 2 edits
    1 add in trunk/WebCore

Rubber-stamped by Adam Roben.

Commit files that were supposed to be part of r53696, but weren't
landed.

  • English.lproj/localizedStrings.js:
  • manual-tests/debugger-caught-uncaught-exceptions.html: Added.
2:17 PM Changeset in webkit [53718] by pkasting@chromium.org
  • 8 edits in trunk

When scrolling by page, hold back 1/8th of the visible size instead of
40 px.
​https://bugs.webkit.org/show_bug.cgi?id=32595

Reviewed by David Hyatt.

WebCore:

  • editing/EditorCommand.cpp:

(WebCore::verticalScrollDistance):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

  • platform/Scrollbar.h:
  • platform/wx/ScrollViewWx.cpp:

(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):

WebKit/mac:

  • WebView/WebFrameView.mm:

(-[WebFrameView _verticalPageScrollDistance]):
(-[WebFrameView initWithFrame:]):
(-[WebFrameView _horizontalPageScrollDistance]):

2:13 PM Changeset in webkit [53717] by dimich@chromium.org
  • 2 edits in trunk/JavaScriptCore

Not reviewed, attempted Snow Leopard build fix.

  • wtf/ThreadingPthreads.cpp: Add a forward declaration of a function which is not 'static'.
2:05 PM Changeset in webkit [53716] by pkasting@chromium.org
  • 18 edits in trunk

Not reviewed, backout.

Back out r52673, which caused several regressions.
​https://bugs.webkit.org/show_bug.cgi?id=32533

WebCore:

  • platform/PopupMenuClient.h:
  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupContainer::hidePopup):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::hidePopup):

  • platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenu::menuUnmapped):

  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenu::show):

  • platform/qt/QtAbstractWebPopup.cpp:

(WebCore::QtAbstractWebPopup::popupDidHide):

  • platform/qt/QtAbstractWebPopup.h:
  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::hide):

  • platform/wx/PopupMenuWx.cpp:

(WebCore::PopupMenu::OnMenuItemSelected):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::popupDidHide):

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::popupDidHide):

  • rendering/RenderTextControlSingleLine.h:

WebKit/chromium:

  • src/AutocompletePopupMenuClient.cpp:

(WebKit::AutocompletePopupMenuClient::initialize):
(WebKit::AutocompletePopupMenuClient::popupDidHide):
(WebKit::AutocompletePopupMenuClient::setTextFromItem):

  • src/AutocompletePopupMenuClient.h:

WebKit/qt:

  • WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopupCombo::hidePopup):

2:04 PM Changeset in webkit [53715] by Chris Jerdonek
  • 4 edits
    1 add in trunk/WebKitTools

33791: Proposed patch 1 (amended with preferred license)

2:00 PM Changeset in webkit [53714] by dimich@chromium.org
  • 16 edits
    2 adds in trunk

Fix the leak of ThreadIdentifiers in threadMap across threads.
​https://bugs.webkit.org/show_bug.cgi?id=32689

Reviewed by Maciej Stachowiak.

JavaScriptCore:

Test is added to DumpRenderTree.mm.

  • Android.mk: Added file ThreadIdentifierDataPthreads.(h|cpp) to build.
  • Android.v8.wtf.mk: Ditto.
  • GNUmakefile.am: Ditto.
  • JavaScriptCore.gyp/JavaScriptCore.gyp: Ditto.
  • JavaScriptCore.gypi: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • wtf/ThreadIdentifierDataPthreads.cpp: Added. Contains custom implementation of thread-specific data that uses custom destructor.

(WTF::ThreadIdentifierData::~ThreadIdentifierData): Removes the ThreadIdentifier from the threadMap.
(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::destruct): Custom thread-specific destructor. Resets the value for the key again to cause second invoke.
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce): Need to use pthread_once since initialization may come on any thread(s).

  • wtf/ThreadIdentifierDataPthreads.h: Added.

(WTF::ThreadIdentifierData::ThreadIdentifierData):

  • wtf/Threading.cpp:

(WTF::threadEntryPoint): Move initializeCurrentThreadInternal to after the lock to make

sure it is invoked when ThreadIdentifier is already established.

  • wtf/Threading.h: Rename setThreadNameInternal -> initializeCurrentThreadInternal since it does more then only set the name now.
  • wtf/ThreadingNone.cpp:

(WTF::initializeCurrentThreadInternal): Ditto.

  • wtf/ThreadingWin.cpp:

(WTF::initializeCurrentThreadInternal): Ditto.
(WTF::initializeThreading): Ditto.

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeCurrentThreadInternal): Ditto.

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeCurrentThreadInternal): Ditto.

  • wtf/ThreadingPthreads.cpp:

(WTF::establishIdentifierForPthreadHandle):
(WTF::clearPthreadHandleForIdentifier): Make it not 'static' so the ~ThreadIdentifierData() in another file can call it.
(WTF::initializeCurrentThreadInternal): Set the thread-specific data. The ThreadIdentifier is already established by creating thread.
(WTF::waitForThreadCompletion): Remove call to clearPthreadHandleForIdentifier(threadID) since it is now done in ~ThreadIdentifierData().
(WTF::detachThread): Ditto.
(WTF::currentThread): Use the thread-specific data to get the ThreadIdentifier. It's many times faster then Mutex-protected iteration through the map.

Also, set the thread-specific data if called first time on the thread.

WebKitTools:

Add a new test to verify the ThreadIdentifiers are not reused across threads.
The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
waiting for the previous thread to terminate before starting the next.
The treads use WTF::currentThread() in their thread function. Without a fix, this
causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
The test practically does not affect the DRT run time because the threads end immediately.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(runThread): Test thread function.
(testThreadIdentifierMap):
(dumpRenderTree):

1:52 PM Changeset in webkit [53713] by mitz@apple.com
  • 6 edits in trunk/WebCore

Rubber-stamped by Darin Adler.

Revert r53693 because it broke scrolling of pages with fixed elements on
Mac OS X.

  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):

  • platform/ScrollView.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::destroy):

12:59 PM Changeset in webkit [53712] by ap@apple.com
  • 9 edits
    3 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=34008
Assertion failure in KURL::setProtocol when running DOM Fuzzer

Test: fast/dom/Window/invalid-protocol.html

  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setProtocol): Raise an exception if KURL::setProtocol fails.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setProtocol): Move argument tweaking logic into KURL. This way, the ':' trick applies to both JSLocation and HTMLAnchorElement, matching IE (but not Firefox). IE behavior is more permissive, and even more logical in my opinion.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): Assert that setting protocol succeeded.
  • platform/KURL.cpp: (WebCore::KURL::setProtocol): Remove everything past ':', if present. Return false if the protocol to set is not valid. (WebCore::isValidProtocol): Made this work correctly for empty strings.
  • platform/KURL.h: isValidProtocol() is now static in KURL.cpp, it's only used in setProtocol().
  • platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): Always return true. This should hopefully prevent Chromium build breakage, alhough tests will likely fail. (WebCore::isValidProtocol): Removed, as this isn't used at the moment.
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::httpURLForAuthenticationAndCookies): Assert that setting protocol succeeded.
12:40 PM Changeset in webkit [53711] by eric.carlson@apple.com
  • 5 edits in trunk/WebCore

2010-01-22 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben.

<rdar://problem/7373568>
​https://bugs.webkit.org/show_bug.cgi?id=34007
Implement hardware acceleration of video compositing on Windows

Internally we still have QuickTime render to a bitmap, but frames are then composited
with the page using an accelerated renderer.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_newFrameAvailable. (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): Call tearDownVideoRendering. (WebCore::MediaPlayerPrivate::cancelLoad): Call tearDownVideoRendering. (WebCore::MediaPlayerPrivate::updateStates): Call setUpVideoRendering once the movie

is ready to draw.

(WebCore::MediaPlayerPrivate::isReadyForRendering): New, utility function returns true

only when movie is ready to render.

(WebCore::MediaPlayerPrivate::setSize): Remember the size as we need it when rendering

in accelerated mode.

(WebCore::MediaPlayerPrivate::setVisible): Call setUpVideoRendering when made visible.
(WebCore::MediaPlayerPrivate::paint): Do nothing when rendering to a layer. Move frame

rate drawing code to paintCompleted.

(WebCore::MediaPlayerPrivate::paintCompleted): New, clear m_newFrameAvailable and, when

built with DRAW_FRAME_RATE, draw framerate.

(WebCore::MediaPlayerPrivate::movieNewImageAvailable): Set m_newFrameAvailable, trigger

repaint differently when drawing to a layer.

(WebCore::MediaPlayerPrivate::currentRenderingMode): New, return the current rendering mode.
(WebCore::MediaPlayerPrivate::preferredRenderingMode): New, return preferred rendering mode

(render to a layer whenever possible).

(WebCore::MediaPlayerPrivate::setUpVideoRendering): New, tear down current rendering mode

and set up new mode when necessary.

(WebCore::MediaPlayerPrivate::tearDownVideoRendering): New, noop unless rendering to a layer.
(WebCore::MediaPlayerPrivate::hasSetUpVideoRendering): New.
(WebCore::MediaPlayerPrivate::paintContents): New, callback from compositing layer when it

is time to draw the current frame.

(WebCore::MediaPlayerPrivate::createLayerForMovie): New, allocate a layer for the movie.
(WebCore::MediaPlayerPrivate::destroyLayerForMovie): New, delete movie layer.
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): New, return true unless the

movie is not ready to render.

(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): New, deal with change in

accelerated rendering state.

(WebCore::MediaPlayerPrivate::notifySyncRequired): New, callback from compositing layer

when it wants to schedule a redraw.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: (WebCore::MediaPlayerPrivate::notifyAnimationStarted): (WebCore::MediaPlayerPrivate::showDebugBorders): (WebCore::MediaPlayerPrivate::showRepaintCounter):
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::getCurrentFrameInfo):

New, return information about the offscreen render buffer.

(QTMovieWin::initializeQuickTime):

  • platform/graphics/win/QTMovieWin.h:
12:33 PM Changeset in webkit [53710] by jorlow@chromium.org
  • 12 edits in trunk

2010-01-21 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

The Chromium WebKit API needs to expose storage event related data
​https://bugs.webkit.org/show_bug.cgi?id=33985

setItem and removeItem on WebStorageArea need to expose what the previous
value was for the key being modified. Clear needs to return whether it
actually cleared anything.

  • public/WebStorageArea.h: (WebKit::WebStorageArea::setItem): (WebKit::WebStorageArea::removeItem): (WebKit::WebStorageArea::clear):
  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::StorageAreaProxy): (WebCore::StorageAreaProxy::setItem): (WebCore::StorageAreaProxy::removeItem): (WebCore::StorageAreaProxy::clear): (WebCore::StorageAreaProxy::storageEvent):
  • src/StorageAreaProxy.h:
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespaceProxy::StorageNamespaceProxy): (WebCore::StorageNamespaceProxy::copy): (WebCore::StorageNamespaceProxy::storageArea):
  • src/StorageNamespaceProxy.h:
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem): (WebKit::WebStorageAreaImpl::removeItem): (WebKit::WebStorageAreaImpl::clear):
  • src/WebStorageAreaImpl.h:

2010-01-21 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

The Chromium WebKit API needs to expose storage event related data
​https://bugs.webkit.org/show_bug.cgi?id=33985

This change is not visible to layoutTests/web pages.

  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::setItem): return the old value (WebCore::StorageAreaImpl::removeItem): return the old value (WebCore::StorageAreaImpl::clear): return whether there was anything to clear
  • storage/StorageAreaImpl.h:
12:06 PM Changeset in webkit [53709] by adele@apple.com
  • 3 edits
    2 adds in trunk

An element that doesn't validate and an invalid element shouldn't share style
​https://bugs.webkit.org/show_bug.cgi?id=34010

Reviewed by Dan Bernstein.

Test: fast/css/pseudo-invalid-novalidate-001.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Separate the check for willValidate from the check for isValidFormControlElement.
  • html/HTMLFormControlElement.h: The validity method doesn't need to be virtual.
11:49 AM Changeset in webkit [53708] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Crash in fast/dom/Window/window-properties if Geolocation enabled
​https://bugs.webkit.org/show_bug.cgi?id=34013

Reviewed by Dan Bernstein.

Add null check to fix Geolocation crash in fast/dom/Window/window-properties.

  • page/Geolocation.cpp:

(WebCore::createGeoposition):

11:13 AM Changeset in webkit [53707] by enrica@apple.com
  • 3 edits in trunk/LayoutTests

Fix for the failing test on qt buildbot.
This tests had been added as part of the patch for ​https://bugs.webkit.org/show_bug.cgi?id=33970

Reviewed by Adele Peterson.

  • editing/pasteboard/paste-noscript-svg-expected.txt:
  • editing/resources/svgcontent.xhtml:
11:09 AM Changeset in webkit [53706] by eric@webkit.org
  • 2 edits
    5 adds in trunk

2010-01-22 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Darin Adler.

Object.getOwnPropertyDescriptor(window) returns descriptors for properties in the prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=33948

Even though prototype properties are proxied by JSDOMWindow::getOwnPropertySlot(),
that proxying should not be performed by JSDOMWindow::getOwnPropertyDescriptor().

This makes getOwnPropertyDescriptor() consistent with getOwnPropertyNames().

Test: fast/dom/Window/window-property-descriptors.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
10:44 AM Changeset in webkit [53705] by darin@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-01-21 Darin Fisher <​darin@chromium.org>

Reviewed by David Levin.

[Chromium] spurious WebViewClient::didStopLoading if changing
location.hash while a subframe is still loading

​https://bugs.webkit.org/show_bug.cgi?id=33884

This is a refinement of ​http://trac.webkit.org/changeset/51548

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClientImpl::postProgressStartedNotification): (WebKit::FrameLoaderClientImpl::postProgressFinishedNotification):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::didStartLoading): (WebKit::WebViewImpl::didStopLoading):
  • src/WebViewImpl.h:
10:31 AM Changeset in webkit [53704] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Check in expected failure results for text-zoom.xhtml on Windows

Fixing this test is covered by <​http://webkit.org/b/34006>.

Rubber-stamped by Dan Bernstein.

  • platform/win/svg/custom/text-zoom-expected.txt: Added.
9:01 AM Changeset in webkit [53703] by Girish Ramakrishnan
  • 6 edits in trunk

[Qt] Save the QWebPageClient instead of the ownerWidget in QtAbstractWebPopup

Reviewed by Simon Hausmann.

The QWebPageClient is required for the QtFallbackWebPopup. QtFallbackWebPopup will
need it to create a QGraphicsProxyWidget (in a future commit) for the
QGraphicsWebView's web popup.

8:11 AM Changeset in webkit [53702] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/misc/slow-loading-mask.html timed out.
​https://bugs.webkit.org/show_bug.cgi?id=34004

  • platform/qt/Skipped: http/tests/misc/slow-loading-mask.html skipped.
6:28 AM Changeset in webkit [53701] by hamaji@chromium.org
  • 1 edit
    10 moves
    3 adds
    24 deletes in trunk/LayoutTests

2010-01-22 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

incorrect results for css2.1 layout tests that use setTimeout in body onload event
​https://bugs.webkit.org/show_bug.cgi?id=17557

  • css2.1/README.txt: Added.
  • css2.1/t1204-increment-00-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-increment-00-c-o.html.
  • css2.1/t1204-increment-01-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-increment-01-c-o.html.
  • css2.1/t1204-increment-02-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-increment-02-c-o.html.
  • css2.1/t1204-reset-00-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-reset-00-c-o.html.
  • css2.1/t1204-reset-01-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-reset-01-c-o.html.
  • css2.1/t1204-reset-02-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-reset-02-c-o.html.
  • fast/css/counters/counter-increment-000-expected.txt: Renamed from LayoutTests/fast/css/counters/t1204-increment-00-c-o-expected.txt.
  • fast/css/counters/counter-increment-000.html: Renamed from LayoutTests/fast/css/counters/t1204-increment-00-c-o.html.
  • fast/css/counters/counter-increment-001-expected.txt: Renamed from LayoutTests/fast/css/counters/t1204-increment-01-c-o-expected.txt.
  • fast/css/counters/counter-increment-001.html: Renamed from LayoutTests/fast/css/counters/t1204-increment-01-c-o.html.
  • fast/css/counters/counter-reset-001-expected.txt: Added.
  • fast/css/counters/counter-reset-001.html: Added.
  • platform/mac/css2.1/t1204-increment-00-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-increment-00-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-increment-00-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-increment-01-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-increment-01-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-increment-01-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-increment-02-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-increment-02-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-increment-02-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-reset-00-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-reset-00-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-reset-00-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-reset-01-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-reset-01-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-reset-01-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-reset-02-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-reset-02-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-reset-02-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-increment-00-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-increment-01-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-increment-02-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-reset-00-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-reset-01-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-reset-02-c-o-expected.txt: Removed.
6:13 AM Changeset in webkit [53700] by hamaji@chromium.org
  • 2 edits in trunk/BugsSite

2010-01-22 Janusz Lewandowski <​lew21@xtreeme.org>

Reviewed by Maciej Stachowiak.

run-webkit-tests fails on Ruby 1.9
​https://bugs.webkit.org/show_bug.cgi?id=33554
inject does not work with strings any more, so BugsSite/PrettyPatch/PrettyPatch.rb prints lots of errors.

  • PrettyPatch/PrettyPatch.rb:
5:42 AM Changeset in webkit [53699] by Simon Hausmann
  • 2 edits in trunk/WebCore

Unreviewed Qt "build" fix.

  • WebCore.pro: Fix warning about missing header file that isn't present anymore.
5:34 AM Changeset in webkit [53698] by Girish Ramakrishnan
  • 2 edits in trunk/WebKit/qt

QState::polished() was renamed to QState::propertiesAssigned() when
Qt 4.6.0 was released.

Reviewed by Kenneth Rohde Christiansen.

4:56 AM Changeset in webkit [53697] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip test introduced in r53684 because of missing eventSender.textZoomIn()

  • platform/qt/Skipped: svg/custom/text-zoom.xhtml skipped.
4:52 AM Changeset in webkit [53696] by yurys@chromium.org
  • 10 edits in trunk/WebCore

2010-01-22 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Web Inspector: Caught exceptions still pause the debugger.
<​https://bugs.webkit.org/show_bug.cgi?id=28622>.

Turn the pauseOnExceptions variable from a bool to an int, because we now have
3 states, in an enum: DontPauseOnExceptions, PauseOnAllExceptions, and
PauseOnUncaughtExceptions. The status button for pausing on exceptions is now
a tri-state button, which cycles from Don't pause (no background) to Pause on All
(blue background) to Pause on Uncaught (purple background).

Also added the ability for a status button to have more than 2 states, and added
style rules for a CSS three state button.

Added a manual test, manual-tests/debugger-caught-uncaught-exceptions.html, that
generates caught and uncaught exceptions.

  • English.lproj/localizedStrings.js: Added updated Action / Click to Action text.
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::pauseOnExceptions): Changed from a bool to an int. (WebCore::InspectorBackend::setPauseOnExceptions): Ditto.
  • inspector/InspectorBackend.h: Ditto.
  • inspector/InspectorBackend.idl: Ditto.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::JavaScriptDebugServer): Changed from bool to PauseOnExceptionsState. (WebCore::JavaScriptDebugServer::setPauseOnExceptions): Ditto. (WebCore::JavaScriptDebugServer::exception): Updated logic to see if we are breaking

on uncaught exceptions, and check if we have a handler.

  • inspector/JavaScriptDebugServer.h: (WebCore::JavaScriptDebugServer::): Changed from bool to PauseOnExceptionsState. (WebCore::JavaScriptDebugServer::pauseOnExceptions): Ditto.
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptionsState): Changed from returning false to returning 0 (stub function).
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): Updated to new text/new cycling of variables. (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): Updated to new text/new cycling of variables.
  • inspector/front-end/StatusBarButton.js: (WebInspector.StatusBarButton): Added the option for a different number of states. (WebInspector.StatusBarButton.prototype.set toggled): Added rules to toggle on/off with multiple states.
  • inspector/front-end/inspector.css: Added rules for toggled-1 and toggled-2.
  • manual-tests/debugger-caught-uncaught-exceptions.html: Added.
4:30 AM Changeset in webkit [53695] by eric@webkit.org
  • 4 edits
    2 adds in trunk/WebCore

2010-01-22 Ben Murdoch <​benm@google.com>

Reviewed by Eric Seidel.

[Android] Android platform specific PlatformTouchEvent and PlatformTouchPoint implementations are not upstream.
​https://bugs.webkit.org/show_bug.cgi?id=33719

Add the Android specific files and update the Android makefile.

No new tests as this is all Android-specific code.

  • Android.mk: Add Touch event related files to the makefile.
  • platform/PlatformTouchEvent.h: Add Android constructor.
  • platform/PlatformTouchPoint.h: Ditto.
  • platform/android/PlatformTouchEventAndroid.cpp: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent): Android implementation.
  • platform/android/PlatformTouchPointAndroid.cpp: Added. (WebCore::PlatformTouchPoint::PlatformTouchPoint): Android implementation.
4:23 AM QtWebKitBackportingFixes edited by Girish Ramakrishnan
(diff)
4:04 AM Changeset in webkit [53694] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

[Qt] css1_forward_compatible_parsing.html moved from css2.1 to fast/css by r53664.

  • platform/qt/Skipped: path fixed.
4:01 AM Changeset in webkit [53693] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-01-22 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Do not render the full frame when there is some elements with fixed positioning
​https://bugs.webkit.org/show_bug.cgi?id=33150

The RenderObjects with fixed position register to the view
to be taken into account while scrolling.
The scrolling code update specifically those elements after blitting the pixels.

  • page/FrameView.cpp: (WebCore::FrameView::registerFixedPositionedObject): (WebCore::FrameView::unregisterFixedPositionedObject): (WebCore::FrameView::scrollContentsFastPath):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
  • platform/ScrollView.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::destroy):
3:57 AM Changeset in webkit [53692] by ukai@chromium.org
  • 1 edit
    2 copies
    1 move
    6 adds
    2 deletes in trunk/LayoutTests

2010-01-22 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Maciej Stachowiak.

Split websocket/tests/bad-sub-protocol.html
​https://bugs.webkit.org/show_bug.cgi?id=33646

  • websocket/tests/bad-sub-protocol-control-chars-expected.txt: Added.
  • websocket/tests/bad-sub-protocol-control-chars.html: Added.
  • websocket/tests/bad-sub-protocol-empty-expected.txt: Added.
  • websocket/tests/bad-sub-protocol-empty.html: Added.
  • websocket/tests/bad-sub-protocol-expected.txt: Removed.
  • websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Added.
  • websocket/tests/bad-sub-protocol-non-ascii.html: Added.
  • websocket/tests/bad-sub-protocol.html: Removed.
  • websocket/tests/script-tests/bad-sub-protocol-control-chars.js: Added.
  • websocket/tests/script-tests/bad-sub-protocol-empty.js: Added.
  • websocket/tests/script-tests/bad-sub-protocol-non-ascii.js: Added.
  • websocket/tests/script-tests/bad-sub-protocol.js: Removed.
2:48 AM Changeset in webkit [53691] by eric@webkit.org
  • 4 edits
    2 adds
    3 deletes in trunk

2010-01-22 Kent Tamura <​tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Improve portability of listbox-deselect-scroll.html
​https://bugs.webkit.org/show_bug.cgi?id=33989

  • Convert the test to dumpAsTest
  • Use eventSender.mouseDown(0, addSelectionKey)
  • Avoid hard-coded line-heights.
  • fast/forms/listbox-deselect-scroll-expected.txt: Added.
  • fast/forms/listbox-deselect-scroll.html:
  • fast/forms/script-tests/listbox-deselect-scroll.js: Added.
  • platform/mac/fast/forms/listbox-deselect-scroll-expected.checksum: Removed.
  • platform/mac/fast/forms/listbox-deselect-scroll-expected.png: Removed.
  • platform/mac/fast/forms/listbox-deselect-scroll-expected.txt: Removed.

2010-01-22 Kent Tamura <​tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Fix a bug that mouseDown:withModifiers: is never called.
​https://bugs.webkit.org/show_bug.cgi?id=33989

  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]):
2:26 AM Changeset in webkit [53690] by eric@webkit.org
  • 6 edits
    2 adds in trunk/WebCore

2010-01-22 Anton Muhin <​antonm@chromium.org>

Reviewed by Eric Seidel.

Adding ScriptWrappable into WebCore.
This allows to associate custom information when Node
gets wrapped into JavaScript wrapper.

[v8, dom] Add a pointer field to C++ Node class
​https://bugs.webkit.org/show_bug.cgi?id=32430

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptWrappable.h: Added. (WebCore::ScriptWrappable::ScriptWrappable):
  • bindings/v8/ScriptWrappable.h: Added. (WebCore::ScriptWrappable::ScriptWrappable): (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper):
  • dom/Node.h:
1:42 AM Changeset in webkit [53689] by yurys@chromium.org
  • 2 edits in trunk/WebCore

emikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Add stub implementation of dispatchOnInjectedScript method so that
Chromium source can compile against it and the main fix for the bug
28622 can be landed without breaking Chromium build.

​https://bugs.webkit.org/show_bug.cgi?id=28622

  • inspector/InspectorBackend.h: (WebCore::InspectorBackend::dispatchOnInjectedScript):
1:19 AM Changeset in webkit [53688] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-22 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Dmitry Titov.

ENABLE(DATABASE) guard is missing in ScriptExecutionContext::~ScriptExecutionContext
​https://bugs.webkit.org/show_bug.cgi?id=33990

Add missing ENABLE(DATABASE) guard.

  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
1:17 AM Changeset in webkit [53687] by kenneth@webkit.org
  • 3 edits
    2 adds in trunk/WebKitTools

[Qt] Separate out the WebPage class into it's own
cpp/header files. Also, removed the assumption that
the view is a QWebView, in preparation of a merger
of the two Qt WebKit launchers.

Rubberstamped by Antti Koivisto.

  • QtLauncher/QtLauncher.pro:
  • QtLauncher/main.cpp:

(WebView::mousePressEvent):

  • QtLauncher/webpage.cpp: Added.

(WebPage::supportsExtension):
(WebPage::extension):
(WebPage::acceptNavigationRequest):
(WebPage::openUrlInDefaultBrowser):

  • QtLauncher/webpage.h: Added.

(WebPage::WebPage):

12:42 AM Changeset in webkit [53686] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-01-22 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=33590

  • bindings/scripts/generate-bindings.pl:
12:42 AM Changeset in webkit [53685] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-01-22 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=33590

Rename FEATURE_DEFINES_JAVASCRIPT to FEATURE_DEFINES and remove
the hardcoded LANGUAGE_JAVASCRIPT=1, in preparation for its use by
the GObject DOM bindings.

  • GNUmakefile.am:
12:20 AM Changeset in webkit [53684] by mitz@apple.com
  • 4 edits
    4 adds in trunk

<rdar://problem/7568696> Zoom applied to embedded SVG incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=33988

Reviewed by Darin Adler.

WebCore:

Test: svg/custom/text-zoom.xhtml

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement): Initialize m_scale.
(WebCore::SVGSVGElement::currentScale): If this is the document element,
return the frame’s zoom factor. Otherwise, return m_scale.
(WebCore::SVGSVGElement::setCurrentScale): If this is the document element,
set the frame’s zoom factor. Otherwise, set m_scale and mark for layout.

  • svg/SVGSVGElement.h: Added m_scale member.

LayoutTests:

  • svg/custom/text-zoom-expected.checksum: Added.
  • svg/custom/text-zoom-expected.png: Added.
  • svg/custom/text-zoom-expected.txt: Added.
  • svg/custom/text-zoom.xhtml: Added.
Note: See TracTimeline for information about the timeline view.