⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 31, 2010:

11:29 PM Applications using WebKit edited by wevah@derailer.org
Paparazzi! is a Universal Binary. Also dropped the "www." from its URL. (diff)
11:05 PM Changeset in webkit [54126] by Chris Jerdonek
  • 5 edits
    2 adds in trunk/WebKitTools

2010-01-31 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Moved style error handler code to their own classes, and
related refactoring. Increased unit test code coverage of
style error handling.

​https://bugs.webkit.org/show_bug.cgi?id=34379

  • Scripts/check-webkit-style:
    • Minor change: added error_count variable.
  • Scripts/webkitpy/style/checker.py:
    • Renamed ProcessorOptions.should_report_error() to is_reportable().
    • In the StyleChecker class--
      • Removed _default_style_error_handler().
      • Added _increment_error_count().
      • Refactored to use DefaultStyleErrorHandler and PatchStyleErrorHandler constructors.
  • Scripts/webkitpy/style/checker_unittest.py:
    • In the StyleStyleCheckerTest class--
      • Removed write_sample_error().
      • Removed test_default_style_error_handler().
  • Scripts/webkitpy/style/error_handlers.py: Added.
    • Added DefaultStyleErrorHandler class.
    • Added PatchStyleErrorHandler class.
  • Scripts/webkitpy/style/error_handlers_unittest.py: Added.
    • Added unit tests for DefaultStyleErrorHandler and PatchStyleErrorHandler.
  • Scripts/webkitpy/style/unittests.py:
    • Added error_handlers unit tests.
10:21 PM Changeset in webkit [54125] by tkent@chromium.org
  • 31 edits
    2 deletes in trunk/WebCore

2010-01-31 Kent Tamura <​tkent@chromium.org>

Unreviewed. Revert r54112 and r54124 because of Windows build error.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/cairo/TransformationMatrixCairo.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/cg/TransformationMatrixCG.cpp:
  • platform/graphics/haiku/GraphicsContextHaiku.cpp:
  • platform/graphics/haiku/PathHaiku.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/PathQt.cpp:
  • platform/graphics/qt/TransformationMatrixQt.cpp:
  • platform/graphics/skia/GraphicsContextSkia.cpp:
  • platform/graphics/skia/PathSkia.cpp:
  • platform/graphics/skia/TransformationMatrixSkia.cpp:
  • platform/graphics/transforms/AffineTransform.cpp: Removed.
  • platform/graphics/transforms/AffineTransform.h: Removed.
  • platform/graphics/wince/GraphicsContextWince.cpp:
  • platform/graphics/wx/GraphicsContextWx.cpp:
  • platform/graphics/wx/PathWx.cpp:
  • platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::TransformationMatrix::operator wxGraphicsMatrix):
9:04 PM Changeset in webkit [54124] by tkent@chromium.org
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Unreviewd. Windows build fix.

8:23 PM Changeset in webkit [54123] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-31 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Buildfix for WinCE + style fixes (TLS_OUT_OF_INDEXES is not defined).
​https://bugs.webkit.org/show_bug.cgi?id=34380

  • wtf/ThreadSpecific.h:
6:37 PM Changeset in webkit [54122] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-31 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Limit the scope of packing alignment to avoid MSVC C4103 warning.
​https://bugs.webkit.org/show_bug.cgi?id=34390

Use pack(push, 16) and pack(pop) to limit the scope of packing
alignment change.

  • bindings/js/JSSVGPODTypeWrapper.h:
6:33 PM Changeset in webkit [54121] by tkent@chromium.org
  • 5 edits in trunk

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

[Windows] Fix a bug of round() with huge integral numbers
​https://bugs.webkit.org/show_bug.cgi?id=34297

Fix a bug that round() for huge integral numbers returns incorrect
results. For example, round(8639999913600001) returns
8639999913600002 without this change though the double type can
represent 8639999913600001 precisely.

Math.round() of JavaScript has a similar problem. But this change
doesn't fix it because Math.round() doesn't use round() of
MathExtra.h.

  • wtf/MathExtras.h: (round): Avoid to do "num + 0.5" or "num - 0.5". (roundf): Fixed similarly. (llround): Calls round(). (llroundf): Calls roundf(). (lround): Calls round(). (lroundf): Calls roundf().

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

[Win] Fix a bug of round() with huge integral numbers
​https://bugs.webkit.org/show_bug.cgi?id=34297

Add a test case to call round(8639999913600001).

  • fast/forms/input-valueasnumber-datetime-expected.txt:
  • fast/forms/script-tests/input-valueasnumber-datetime.js:
5:56 PM Changeset in webkit [54120] by tkent@chromium.org
  • 7 edits in trunk

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix valueAsNumber calculation for type=month.
​https://bugs.webkit.org/show_bug.cgi?id=34304

valueAsNumber calculation for type=month which was checked in as
r53893 was the number of milliseconds since UNIX epoch, and it was
wrong. The correct way is the number months since UNIX epoch.

  • fast/forms/input-valueasnumber-month-expected.txt:
  • fast/forms/script-tests/input-valueasnumber-month.js:

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix valueAsNumber calculation for type=month.
​https://bugs.webkit.org/show_bug.cgi?id=34304

valueAsNumber calculation for type=month which was checked in as
r53893 was the number of milliseconds since UNIX epoch, and it was
wrong. The correct way is the number months since UNIX epoch.

  • html/DateComponents.cpp: (WebCore::DateComponents::setMonthsSinceEpoch): (WebCore::DateComponents::monthsSinceEpoch):
  • html/DateComponents.h: Declare setMonthsSinceEpoch() and monthsSinceEpoch().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseToDouble): Switch to monthsSinceEpoch() for type=MONTH. (WebCore::HTMLInputElement::valueAsDate): Add code with millisecondsSinceEpoch() for MONTH because parseToDouble() changed its behavior. (WebCore::HTMLInputElement::setValueAsNumber): Use setMonthsSinceEpoch() for MONTH.
5:43 PM Changeset in webkit [54119] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Fix a bug that a selected word is not recognized as a
spell-check source.
​https://bugs.webkit.org/show_bug.cgi?id=33660

  • src/ContextMenuClientImpl.cpp: (WebKit::isASingleWord): Use wordBreakIterator(), and correctly check the return value of textBreakNext().
5:42 PM Changeset in webkit [54118] by mitz@apple.com
  • 2 edits in trunk/WebCore

Web Inspector: REGRESSION: Numbers in bubbles are vertically off-center
​https://bugs.webkit.org/show_bug.cgi?id=34398

Reviewed by Timothy Hatcher.

  • inspector/front-end/inspector.css: Specify line-height: normal for

".console-message .bubble" and ".sidebar-tree-item .status .bubble".

4:54 PM Changeset in webkit [54117] by ojan@chromium.org
  • 6 edits in trunk

2010-01-28 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

Implement CSSOM Range.getClientRects for collapsed selections
​https://bugs.webkit.org/show_bug.cgi?id=34239

Adds two cases to getClientRects test.

  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/Range/getClientRects.html:

2010-01-28 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

Implement CSSOM Range.getClientRects for collapsed selections
​https://bugs.webkit.org/show_bug.cgi?id=34239

When getting the quads for a range on a text node, allow returning
zero width quads. This leaves the case of collapsed selections inside
elements still not fixed, but no worse.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteQuadsForRange):
3:59 PM Changeset in webkit [54116] by mrowe@apple.com
  • 4 edits in trunk/WebCore

Roll r54095 out again without making a mess of the ChangeLog.

3:59 PM Changeset in webkit [54115] by mrowe@apple.com
  • 4 edits in trunk/WebCore

Revert r54114 since it made a mess of the ChangeLog.

3:43 PM Changeset in webkit [54114] by eric.carlson@apple.com
  • 4 edits in trunk/WebCore

2010-01-31 Eric Carlson <​eric.carlson@apple.com>

Revert r54095 because it caused many media tests to fail.

  • platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::setContentsToVideo): (WebCore::GraphicsLayerCACF::updateContentsVideo):
  • platform/graphics/win/GraphicsLayerCACF.h: (WebCore::GraphicsLayerCACF::):
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::task): (QTMovieWinPrivate::setSize):
3:01 PM Changeset in webkit [54113] by oliver@apple.com
  • 8 edits in trunk

2010-01-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Simon Fraser.

Animated scaling of background-image is too slow
​https://bugs.webkit.org/show_bug.cgi?id=33808

Update checksum.

  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:

2010-01-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Simon Fraser.

Animated scaling of background-image is too slow
​https://bugs.webkit.org/show_bug.cgi?id=33808

Implement a version of the RenderImage animated scaling optimisation
for background images. Due to the possibility of arbitrary transforms
being applied to containing elements we explicitly check the current
CTM of the context for scaling or rotation.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer): (WebCore::RenderBoxModelScaleData::size): (WebCore::RenderBoxModelScaleData::setSize): (WebCore::RenderBoxModelScaleData::lastPaintTime): (WebCore::RenderBoxModelScaleData::setLastPaintTime): (WebCore::RenderBoxModelScaleData::useLowQualityScale): (WebCore::RenderBoxModelScaleData::transform): (WebCore::RenderBoxModelScaleData::setTransform): (WebCore::RenderBoxModelScaleData::setUseLowQualityScale): (WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed): (WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::highQualityRepaintTimerFired): (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
1:04 PM Changeset in webkit [54112] by krit@webkit.org
  • 31 edits
    2 adds in trunk/WebCore

2010-01-31 Dirk Schulze <​krit@webkit.org>

Reviewed by Simon Fraser.

Add back an AffineTransform class for use by SVG
​https://bugs.webkit.org/show_bug.cgi?id=33750

These are the first steps on reimplementing AffineTransform. Unlike
the old affine code, this one is platform independent like TransformationMatrix.
AffineTransform has the benefit, that it stores just 6 doubles instead of
16 in TransformationMatrix. The calculations of transformations are not that
complex and can improve the memory usage and speed of SVG.
AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
least for the moment).
HTML Canvas is the first that makes use of the new AffineTransform. Next patches
will introduce the affine code to SVG.

No new tests. The new AffineTransformation code is tested by fast/canvas.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
  • platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
  • platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform):
  • platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix):
  • platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend):
  • platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform):
  • platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix):
9:55 AM Changeset in webkit [54111] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-31 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] Breakpoint source line is not displayed
in the breakpoint manager.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addBreakpointToSource):
8:36 AM Changeset in webkit [54110] by pfeldman@chromium.org
  • 11 edits
    1 add in trunk/WebCore

2010-01-31 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce NativeTextViewer.

This change handles rendering highlighted text, using browser's
selection/drag/drop/click logic. Breakpoint decorations and
program counter is working.

Todo: line numbers are painted 'under' the text when scrolling
horizontally, search is not yet implemented.

​https://bugs.webkit.org/show_bug.cgi?id=34391

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DivBasedTextViewer.js: Added. (WebInspector.DivBasedTextViewer): (WebInspector.DivBasedTextViewer.prototype._textChanged): (WebInspector.DivBasedTextViewer.prototype._createLineDivs): (WebInspector.DivBasedTextViewer.prototype._updatePreferredSize): (WebInspector.DivBasedTextViewer.prototype._scroll): (WebInspector.DivBasedTextViewer.prototype._registerMouseListeners): (WebInspector.DivBasedTextViewer.prototype._registerKeyboardListeners): (WebInspector.DivBasedTextViewer.prototype._registerClipboardListeners): (WebInspector.DivBasedTextViewer.prototype._paintSelection): (WebInspector.DivBasedTextViewer.prototype._positionDivDecoration): (WebInspector.DivBasedTextViewer.prototype._mouseDown): (WebInspector.DivBasedTextViewer.prototype._contextMenu): (WebInspector.DivBasedTextViewer.prototype._caretForMouseEvent): (WebInspector.DivBasedTextViewer.prototype._paintLine): (WebInspector.DivBasedTextViewer.prototype._createSpan):
  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype._createEditorIfNeeded): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype.resize):
  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype._registerMouseListeners): (WebInspector.TextEditor.prototype._registerKeyboardListeners): (WebInspector.TextEditor.prototype._registerClipboardListeners): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype.revalidateDecorationsAndPaint): (WebInspector.TextEditor.prototype._updatePreferredSize): (WebInspector.TextEditor.prototype.resize): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._paintLine): (WebInspector.TextEditor.prototype._contextMenu): (WebInspector.TextEditor.prototype._caretForMouseEvent): (WebInspector.TextEditor.prototype._changeFont):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/textEditor.css:
7:42 AM Changeset in webkit [54109] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-31 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

[Qt] Enable FAST_MOBILE_SCROLLING on Qt embedded platforms
​https://bugs.webkit.org/show_bug.cgi?id=34168

Enable FAST_MOBILE_SCROLLING for Qt on Maemo 5, Linux embedded
and Symbian

  • WebCore.pro:

Jan 30, 2010:

11:38 PM Changeset in webkit [54108] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-01-31 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Make ScriptState destructor protected since all non-empty
ScriptStates are managed by GC. Remove obsolete constructor.

​https://bugs.webkit.org/show_bug.cgi?id=34266

  • bindings/v8/ScriptState.cpp:
  • bindings/v8/ScriptState.h:
10:01 PM Changeset in webkit [54107] by Simon Fraser
  • 5 edits in trunk/WebCore

2010-01-30 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Use CGGradient on Leopard and later, since it's faster than CGShading
​https://bugs.webkit.org/show_bug.cgi?id=34384

Use CGGradient on Leopard and later, rather than CGShading, for
performance.

  • platform/graphics/Gradient.h:
  • platform/graphics/Gradient.cpp: (WebCore::Gradient::sortStopsIfNecessary): Utility method to sort stops. Did not call this from getColor() to avoid overhead of a function call.
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformDestroy): Use CGGradientRelease() post-Tiger. (WebCore::Gradient::platformGradient): Create and return a CGGradientRef post-Tiger. (WebCore::Gradient::fill): Call new paint() method. (WebCore::Gradient::paint): New convenence method that avoids testing isRadial() in a bunch of other places.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): Call the gradient's paint() method. (WebCore::GraphicsContext::strokePath): Ditto (WebCore::GraphicsContext::fillRect): Ditto (WebCore::GraphicsContext::strokeRect): Ditto
7:21 PM Changeset in webkit [54106] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-01-30 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

Do color animations on premultiplied colors
​https://bugs.webkit.org/show_bug.cgi?id=34383

Convert colors to premultiplied alpha before interpolating them,
then convert the result back to non-premultiplied. This gives better
results when animating from transparent colors.

Test: transitions/color-transition-premultiplied.html

  • page/animation/AnimationBase.cpp: (WebCore::blendFunc):
4:37 PM Changeset in webkit [54105] by kevino@webkit.org
  • 5 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add a way to get the parse mode to wxWebKit API.

​https://bugs.webkit.org/show_bug.cgi?id=34341

1:42 PM Changeset in webkit [54104] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-01-30 Gustavo Noronha Silva <Gustavo Noronha Silva>

Build fixes needed for make distcheck.

  • GNUmakefile.am:
Note: See TracTimeline for information about the timeline view.