⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 1, 2010:

11:56 PM Changeset in webkit [54210] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-02-01 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for IconDatabaseClient class
​https://bugs.webkit.org/show_bug.cgi?id=33252

Inherits the following struct from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'
class IconDatabaseClient - loader/icon/IconDatabase.cpp:89

  • loader/icon/IconDatabaseClient.h:
11:51 PM Changeset in webkit [54209] by bweinstein@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Check in new expected results for a test that has been failing on Windows
since it was originally landed. This appears to be a font issue, but commenting
on bug <​https://bugs.webkit.org/show_bug.cgi?id=34234> to make sure.

  • platform/win/fast/text/international/hebrew-vowels-expected.txt: Added.
11:46 PM Changeset in webkit [54208] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-02-01 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port MIMETypeRegistry
​https://bugs.webkit.org/show_bug.cgi?id=34220

Port MIMETypeRegistry with an extension map as other ports do.

  • platform/brew: Added.
  • platform/brew/MIMETypeRegistryBrew.cpp: Added. (WebCore::): (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
10:53 PM Changeset in webkit [54207] by dimich@chromium.org
  • 6 edits
    7 deletes in trunk

Revert r54194 that fails new test on Qt and Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=34382

10:41 PM Changeset in webkit [54206] by Chris Jerdonek
  • 6 edits
    2 adds in trunk/WebKitTools

Addressed FIXME in check-webkit-style so that the carriage-return
check will work for patches.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=34260

Also added support for limiting the number of errors reported
per category, per file.

  • Scripts/webkitpy/style/checker.py:
    • Added new "whitespace/carriage_return" category from common.py.
    • Added MAX_REPORTS_PER_CATEGORY dictionary.
    • Added max_reports_per_category attribute to ProcessorOptions class.
    • Refactored StyleChecker._process_file().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated ProcessorOptionsTest tests.
    • Added test to check MAX_REPORTS_PER_CATEGORY.
  • Scripts/webkitpy/style/error_handlers.py:
    • Added support for suppressing the display of errors after reaching a per-category maximum (from max_reports_per_category).
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Added test for suppressing error display.
  • Scripts/webkitpy/style/processors/common.py: Added.
    • Moved carriage-return check to new file.
  • Scripts/webkitpy/style/processors/common_unittest.py: Added.
    • Added unit tests for carriage-return check.
  • Scripts/webkitpy/style/unittests.py:
    • Added reference to common_unittest.py.
10:28 PM Changeset in webkit [54205] by hamaji@chromium.org
  • 19 edits
    8 adds in trunk

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=33840

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • printing/page-break-always-expected.txt: Added.
  • printing/page-break-always.html: Added.
  • printing/pageNumerForElementById-expected.txt: Added.
  • printing/pageNumerForElementById.html: Added.
  • printing/script-tests/TEMPLATE.html: Added.
  • printing/script-tests/page-break-always.js: Added. (createParagraph):
  • printing/script-tests/pageNumerForElementById.js: Added. (createParagraph):

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=33840

Test: printing/page-break-always.html

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/PrintContext.cpp: (WebCore::PrintContext::pageRect): Added a getter function. (WebCore::PrintContext::computePageRects): Move its logic into computePageRectsWithPageSize. (WebCore::PrintContext::computePageRectsWithPageSize): Factored out from computePageRects for pageNumberForElement. (WebCore::enclosingBoxModelObject): Added for pageNumberForElement. (WebCore::PrintContext::pageNumberForElement): Added for testing.
  • page/PrintContext.h:

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=33840

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame pageNumberForElement:element:pageWidth:]):

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=33840

  • DumpRenderTree/LayoutTestController.cpp: (pageNumberForElementByIdCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageNumberForElementById):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageNumberForElementById):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageNumberForElementById):
10:19 PM Changeset in webkit [54204] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2010-02-01 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add conversions between IntSize and AEESize
​https://bugs.webkit.org/show_bug.cgi?id=34197

Make it easy to convert between IntSize and AEESize.

  • platform/graphics/IntSize.h:
  • platform/graphics/brew/IntSizeBrew.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator AEESize):
9:36 PM Changeset in webkit [54203] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-02-01 Stephen White <​senorblanco@chromium.org>

Reviewed by Eric Seidel.

Fix for Pattern transformations in Chromium/Skia. This required
reworking Pattern a bit to be more like the Gradient implementation.
In particular, it now holds an m_pattern reference to the
platform-specific implementation, and passes along changes to the
m_patternSpaceTransformation, in the same way that Gradient does for
m_gradientSpaceTransformation. This is necessary since Skia creates the
platform-specific pattern (SkShader) once, rather than recreating it
on each draw.
For platforms other than Skia, m_pattern is unused, they will
continue to use the static createPlatformPattern(), and the new
notification functions are stubbed out. Other platforms can switch to
the new implementation if they so choose.

​https://bugs.webkit.org/show_bug.cgi?id=24534

Covered by svg/custom/pattern-y-offset.svg,
svg/custom/pattern-cycle-detection.svg, and many more.

  • platform/graphics/Pattern.cpp: (WebCore::Pattern::Pattern): Initializer for m_pattern. (WebCore::Pattern::~Pattern): call platformDestroy(). (WebCore::Pattern::setPatternSpaceTransform): Pass along the transform via setPlatformPatternSpaceTransform(). (WebCore::Pattern::platformDestroy): (WebCore::Pattern::setPlatformPatternSpaceTransform): Stub implementations for non-skia platforms.
  • platform/graphics/Pattern.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokePattern): Call platformPattern() instead of static version. Since Pattern now owns its SkShader, no need to unref here.
  • platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::platformDestroy): Unref the SkShader on destroy. (WebCore::Pattern::platformPattern): Create the platform pattern (SkShader) once, and cache it. (WebCore::Pattern::setPlatformPatternSpaceTransform): Set the shader's local matrix from the m_patternSpaceTransformation.
9:13 PM Changeset in webkit [54202] by dbates@webkit.org
  • 8 edits
    22 adds in trunk

2010-02-01 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=27312

Implements support for full page blocking via the X-XSS-Protection header.

Tests: http/tests/security/xssAuditor/full-block-base-href.html

http/tests/security/xssAuditor/full-block-get-from-iframe.html
http/tests/security/xssAuditor/full-block-iframe-javascript-url.html
http/tests/security/xssAuditor/full-block-iframe-no-inherit.php
http/tests/security/xssAuditor/full-block-javascript-link.html
http/tests/security/xssAuditor/full-block-link-onclick.html
http/tests/security/xssAuditor/full-block-object-tag.html
http/tests/security/xssAuditor/full-block-post-from-iframe.html
http/tests/security/xssAuditor/full-block-script-tag-with-source.html
http/tests/security/xssAuditor/full-block-script-tag.html
http/tests/security/xssAuditor/malformed-xss-protection-header.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::shouldFullPageBlockForXSSProtectionHeader): Added. (WebCore::XSSAuditor::findInRequest): Modified to call method XSSAuditor::shouldFullPageBlockForXSSProtectionHeader.
  • page/XSSAuditor.h: Defined method shouldFullPageBlockForXSSProtectionHeader and fixed misspelled words in large comment block.

2010-02-01 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=27312

Tests that the header "X-XSS-Protection: full-block" leads to a full page block
when an XSS attack is detected.

  • http/tests/security/xssAuditor/full-block-base-href-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-base-href.html: Added.
  • http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-get-from-iframe.html: Added.
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url.html: Added.
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit.php: Added.
  • http/tests/security/xssAuditor/full-block-javascript-link-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-javascript-link.html: Added.
  • http/tests/security/xssAuditor/full-block-link-onclick-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-link-onclick.html: Added.
  • http/tests/security/xssAuditor/full-block-object-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-object-tag.html: Added.
  • http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-post-from-iframe.html: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-with-source.html: Added.
  • http/tests/security/xssAuditor/full-block-script-tag.html: Added.
  • http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt: Added.
  • http/tests/security/xssAuditor/malformed-xss-protection-header.html: Added.
  • http/tests/security/xssAuditor/resources/echo-head-base-href.pl: Modified to optionally enable full page blocking.
  • http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Ditto.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl: Ditto.
  • http/tests/security/xssAuditor/resources/utilities.js: (checkIfFrameLocationMatchesURLAndCallDone): Added. (sendRequestFromIFrame): Modified to optionally call callback function when done.
9:10 PM Changeset in webkit [54201] by hamaji@chromium.org
  • 3 edits in trunk/LayoutTests

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Dmitry Titov.

Convert textarea-rows-cols.html to dumpAsText()
​https://bugs.webkit.org/show_bug.cgi?id=34074

Remove checks for the size of scrollbar as scrollbar doesn't
appear on Windows.

  • fast/forms/script-tests/textarea-rows-cols.js:
  • fast/forms/textarea-rows-cols-expected.txt:
9:01 PM Changeset in webkit [54200] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-02-01 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port SharedTimer with IShell_SetTimerEx.
​https://bugs.webkit.org/show_bug.cgi?id=33599

As fireTime passed in setSharedTimerFireTime is the absolute time,
we must calcalute the interval by subtracting currentTime() from
fireTime and pass the result to ISHELL_SetTimerEx.

  • platform/brew/SharedTimerBrew.cpp: Added. (WebCore::invokeCallback): (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
8:56 PM Changeset in webkit [54199] by tkent@chromium.org
  • 3 edits
    3 adds in trunk

2010-02-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Date.UTC() should apply TimeClip operation.
​https://bugs.webkit.org/show_bug.cgi?id=34461

ECMAScript 5 15.9.4.3:

9 Return TimeClip(MakeDate(MakeDay(yr, m, dt), MakeTime(h, min, s, milli))).

  • runtime/DateConstructor.cpp: (JSC::dateUTC): Calls WTF::timeClip().

2010-02-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Date.UTC() should apply TimeClip operation.
​https://bugs.webkit.org/show_bug.cgi?id=34461

Add tests for corner cases of Date.UTC().

  • fast/js/date-utc-timeclip-expected.txt: Added.
  • fast/js/date-utc-timeclip.html: Added.
  • fast/js/script-tests/date-utc-timeclip.js: Added.
8:48 PM Changeset in webkit [54198] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2010-02-01 Kent Tamura <​tkent@chromium.org>

Unreviewed. Add two more test cases which I forgot to add in r54197.
​https://bugs.webkit.org/show_bug.cgi?id=34462

  • fast/js/math-expected.txt:
  • fast/js/script-tests/math.js:
8:42 PM Changeset in webkit [54197] by tkent@chromium.org
  • 5 edits in trunk

2010-02-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that Math.round() retunrs incorrect results for huge integers
​https://bugs.webkit.org/show_bug.cgi?id=34462

  • runtime/MathObject.cpp: (JSC::mathProtoFuncRound): Avoid "arg + 0.5".

2010-02-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that Math.round() retunrs incorrect results for huge integers
​https://bugs.webkit.org/show_bug.cgi?id=34462

  • fast/js/math-expected.txt:
  • fast/js/script-tests/math.js: Add test cases for Math.round() for huge numbers.
8:13 PM Changeset in webkit [54196] by hamaji@chromium.org
  • 4 edits in trunk/WebCore

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

[Chromium] Unreviewed attempt to fix the chromium build.

Corresponding change: ​http://trac.webkit.org/changeset/54182

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/ScriptController.h:
7:19 PM Changeset in webkit [54195] by hamaji@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed attempt to fix the broken build.

This was introduced in ​http://trac.webkit.org/changeset/54182

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::performMediaPlayerAction):
7:14 PM Changeset in webkit [54194] by dimich@chromium.org
  • 6 edits
    8 adds in trunk

When a live iframe element is moved between pages, it still depends on the old page.
​https://bugs.webkit.org/show_bug.cgi?id=34382

Reviewed by David Levin.

WebCore:

Test: fast/frames/iframe-reparenting-new-page.html

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::setName):
Move the code setting the frame name into a separate function.

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::updateLiveFrame):
Update frame tree, reset page in the contentFrame and re-set the name.

(WebCore::HTMLFrameElementBase::insertedIntoDocument):

  • html/HTMLFrameElementBase.h:
  • page/Frame.cpp:

(WebCore::Frame::setPage):

  • page/Frame.h: Add setPage method. It is only currently used when iframe is

moved between pages (so the ASSERT(m_ownerElement).

LayoutTests:

  • fast/frames/iframe-reparenting-new-page-expected.txt: Added.
  • fast/frames/iframe-reparenting-new-page.html: Added.
  • fast/frames/resources/iframe-reparenting-new-page-1.html: Added.
  • fast/frames/resources/iframe-reparenting-new-page-2.html: Added.
  • fast/frames/resources/iframe-reparenting-new-page-iframe.html: Added.
7:06 PM Changeset in webkit [54193] by beidson@apple.com
  • 6 edits in trunk

WebCore: Add common IRC ports to port blocking.
<rdar://problem/7593895> and ​https://bugs.webkit.org/show_bug.cgi?id=34451

Reviewed by Tim Hatcher.

  • platform/KURL.cpp:

(WebCore::portAllowed):

LayoutTests: Add common IRC ports to port blocking.
<rdar://problem/7593895> and ​https://bugs.webkit.org/show_bug.cgi?id=34451

  • platform/mac-tiger/security/block-test-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • security/block-test.html:

Reviewed by Tim Hatcher.

6:45 PM Changeset in webkit [54192] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed fix for an invalid function call.

check-webkit-style: Remove filename parameter from all functions where no longer used
​https://bugs.webkit.org/show_bug.cgi?id=34249

  • Scripts/webkitpy/style/checker.py:
6:43 PM Changeset in webkit [54191] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-01-27 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Eric Seidel.

Add support for addUserScript to chromium port.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::addUserScript): (WebKit::WebViewImpl::removeAllUserContent):
  • src/WebViewImpl.h:
6:42 PM Changeset in webkit [54190] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-01-29 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

[V8] Add compile time guards for IndexedDB custom functions
​https://bugs.webkit.org/show_bug.cgi?id=34368

  • bindings/v8/custom/V8IDBRequestCustom.cpp:
  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
6:07 PM QtWebKitGraphics edited by noam.rosenthal@nokia.com
(diff)
6:06 PM cssAnimTestSuite.html attached to QtWebKitGraphics by noam.rosenthal@nokia.com
Comprehensive test suite for CSS animations
6:04 PM CssAnimationTestSuite edited by noam.rosenthal@nokia.com
(diff)
6:02 PM cssAnimTestSuite.html attached to CssAnimationTestSuite by noam.rosenthal@nokia.com
6:01 PM CssAnimationTestSuite created by noam.rosenthal@nokia.com
5:48 PM Changeset in webkit [54189] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/LayoutTests

Merge r53116.

5:48 PM Changeset in webkit [54188] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/LayoutTests

Merge r53115.

5:48 PM Changeset in webkit [54187] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r53114.

5:48 PM Changeset in webkit [54186] by mrowe@apple.com
  • 1 edit
    2 adds in branches/safari-4-branch/LayoutTests

Merge r53096.

5:47 PM Changeset in webkit [54185] by mrowe@apple.com
  • 1 edit
    1 add in branches/safari-4-branch/LayoutTests

Merge r53093.

5:47 PM Changeset in webkit [54184] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-4-branch

Merge r53078.

5:33 PM Changeset in webkit [54183] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-01 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port WTF's currentTime
​https://bugs.webkit.org/show_bug.cgi?id=33567

Combine GETUTCSECONDS and GETTIMEMS to calculate the number
of milliseconds since 1970/01/01 00:00:00 UTC.

  • wtf/CurrentTime.cpp: (WTF::currentTime):
5:20 PM Changeset in webkit [54182] by barraclough@apple.com
  • 25 edits
    3 adds in trunk

Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds

WebCore:

Reviewed by Sam Weinig + Oliver Hunt.

Change HTMLMediaElement methods that require checking whether the event is a user gesture to
be passed a boolean. This may be passed from the JSC bindings (where we have an exec state),
or read from the event. Add a Flag to the IDL to mark this information is required.

  • WebCore.Video.exp:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::processingUserGesture):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::domWindowAllowPopUp):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::processingUserGesture):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::anyPageIsProcessingUserGesture):

  • bindings/js/ScriptController.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Event.cpp:

(WebCore::Event::isUserEvent):

  • dom/Event.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removedFromDocument):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::documentDidBecomeActive):
(WebCore::HTMLMediaElement::webkitEnterFullScreen):

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::isProcessingUserGesture):

  • loader/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::allowPopUp):

  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlSeekButtonElement::defaultEventHandler):

WebKit/mac:

Reviewed by Sam Weinig + Oliver Hunt.

Pass processeing user gensture flag to media play/pause methods.

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController setPlaying:]):

WebKit/win:

Reviewed by Sam Weinig + Oliver Hunt.

Pass processeing user gensture flag to media play/pause methods.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::play):
(FullscreenVideoController::pause):

LayoutTests:

Reviewed by Sam Weinig.

  • http/tests/security/isolatedWorld/resources/userGestureEvents-second-window.html: Added.
  • http/tests/security/isolatedWorld/userGestureEvents-expected.txt: Added.
  • http/tests/security/isolatedWorld/userGestureEvents.html: Added.
5:17 PM Changeset in webkit [54181] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-4-branch

Merge r51976 and the parts of r50704 that it depended on.

5:16 PM Changeset in webkit [54180] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-01 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Use the fallback style on Maemo 5

​https://bugs.webkit.org/show_bug.cgi?id=34376

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::fallbackStyle): (WebCore::RenderThemeQt::qStyle): (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
  • platform/qt/RenderThemeQt.h:
5:00 PM Changeset in webkit [54179] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-01 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Nate Chapin.

[V8] Making V8 generated classes' GetTemplate() function public
​https://bugs.webkit.org/show_bug.cgi?id=34026

  • bindings/scripts/CodeGeneratorV8.pm: Generated code need not depend on V8CustomBinding.h, made GetTemplate() signature public.
4:56 PM Changeset in webkit [54178] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse()

Reviewed by Anders Carlsson.

The crash was caused by having two streams with a streamID of 1.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now
correctly increments m_currentURLRequestID to account for the manual stream.
(WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream,
null it out instead of trying to remove it from the map. Added an assertion.
(WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion.

4:42 PM Changeset in webkit [54177] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r51704.

4:39 PM Changeset in webkit [54176] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-01 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

[Qt] WinCE buildfix after r52729 and fix for Q_BIG_ENDIAN typo.
​https://bugs.webkit.org/show_bug.cgi?id=34378

  • wtf/Platform.h:
4:35 PM Changeset in webkit [54175] by steveblock@google.com
  • 3 edits
    2 adds in trunk/WebCore

Adds V8-specific JNI bridge classes
​https://bugs.webkit.org/show_bug.cgi?id=34166

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JNIBridgeJSC.

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Added JNIBridge.cpp and JNIBridgeV8.cpp
  • bridge/Bridge.h: Modified. Added missing include for Noncopyable.h
  • bridge/jni/v8/JNIBridgeV8.cpp: Added.

(JavaField::JavaField):

  • bridge/jni/v8/JNIBridgeV8.h: Added.

(JSC::Bindings::JavaField::name):
(JSC::Bindings::JavaField::type):
(JSC::Bindings::JavaField::getJNIType):

4:34 PM Changeset in webkit [54174] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-4-branch

Merge r51962.

4:34 PM Changeset in webkit [54173] by mrowe@apple.com
  • 6 edits
    4 adds in branches/safari-4-branch

Merge r50110.

4:34 PM Changeset in webkit [54172] by mrowe@apple.com
  • 5 edits in branches/safari-4-branch/WebCore

Merge r50017.

4:25 PM Changeset in webkit [54171] by steveblock@google.com
  • 2 edits
    2 adds in trunk/WebCore

Adds V8-specific JNI utility functions.
​https://bugs.webkit.org/show_bug.cgi?id=33901

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JNIUtilityPrivate.

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Add JNIUtilityPrivate.cpp
  • bridge/jni/v8/JNIUtilityPrivate.cpp: Added.

(JSC::Bindings::convertNPVariantToJValue):
(JSC::Bindings::convertJValueToNPVariant):

  • bridge/jni/v8/JNIUtilityPrivate.h: Added.
4:23 PM Changeset in webkit [54170] by mrowe@apple.com
  • 12 edits
    12 adds in branches/safari-4-branch

Merge r52784.

4:15 PM Changeset in webkit [54169] by steveblock@google.com
  • 2 edits
    2 adds in trunk/WebCore

Adds V8 version of JavaClass
​https://bugs.webkit.org/show_bug.cgi?id=33898

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JavaClassJSC

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Added JavaClassV8.cpp
  • bridge/jni/v8/JavaClassV8.cpp: Added.

(JavaClass::JavaClass):
(JavaClass::~JavaClass):
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):

  • bridge/jni/v8/JavaClassV8.h: Added.
4:09 PM Changeset in webkit [54168] by mrowe@apple.com
  • 12 edits
    2 adds in branches/safari-4-branch

Merge r51645.

4:09 PM Changeset in webkit [54167] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-4-branch

Merge r50310.

4:08 PM Changeset in webkit [54166] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

REGRESSION: editing/selection/doubleclick-beside-cr-span.html times out on Windows
​https://bugs.webkit.org/show_bug.cgi?id=34069

Make the sleep time shorter as this test timed out on Windows bot.

  • editing/selection/doubleclick-beside-cr-span.html:
4:03 PM Changeset in webkit [54165] by steveblock@google.com
  • 3 edits
    2 adds in trunk/WebCore

Adds V8 version of JavaInstance
​https://bugs.webkit.org/show_bug.cgi?id=33951

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JavaInstanceJSC.
Also fixes a typo in a comment in JavaInstanceJSC.cpp.

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Added JavaInstanceV8.cpp
  • bridge/jni/jsc/JavaInstanceJSC.cpp: Modified.

(JavaInstance::invokeMethod): Modified. Fixed comment

  • bridge/jni/v8/JavaInstanceV8.cpp: Added.

(JavaInstance::JavaInstance):
(JavaInstance::~JavaInstance):
(JavaInstance::getClass):
(JavaInstance::invokeMethod):
(JObjectWrapper::JObjectWrapper):
(JObjectWrapper::~JObjectWrapper):

  • bridge/jni/v8/JavaInstanceV8.h: Added.

(JSC::Bindings::JObjectWrapper::instance):
(JSC::Bindings::JObjectWrapper::setInstance):
(JSC::Bindings::JObjectWrapper::ref):
(JSC::Bindings::JObjectWrapper::deref):
(JSC::Bindings::JavaInstance::javaInstance):
(JSC::Bindings::JavaInstance::begin):
(JSC::Bindings::JavaInstance::end):
(JSC::Bindings::JavaInstance::virtualBegin):
(JSC::Bindings::JavaInstance::virtualEnd):

3:43 PM Changeset in webkit [54164] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r47726.

3:38 PM Changeset in webkit [54163] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r51659.

3:32 PM Changeset in webkit [54162] by dumi@chromium.org
  • 5 edits in trunk/WebCore

Making sure that all in-progress transactions are rolled back on
the database thread before they're destroyed. Otherwise,
SQLiteTransaction's destructor will try to do a rollback and that
would cause an assertion failure, if the object is not destroyed
on the DB thread.

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=34152

  • platform/sql/SQLiteTransaction.cpp:

(WebCore::SQLiteTransaction::stop):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):

  • storage/SQLTransaction.h:
  • storage/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::shutdown):

3:32 PM Changeset in webkit [54161] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r53813.

3:32 PM Changeset in webkit [54160] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-4-branch

Merge r53812.

3:26 PM Changeset in webkit [54159] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-4-branch

Merge r50466.

3:25 PM Changeset in webkit [54158] by mrowe@apple.com
  • 10 edits
    4 adds in branches/safari-4-branch

Merge r50470.

3:25 PM Changeset in webkit [54157] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebCore

Merge r50435.

3:23 PM Changeset in webkit [54156] by weinig@apple.com
  • 3 edits in trunk/WebCore

Fix EXPERIMENTAL_SINGLE_VIEW_MODE build.

Reviewed by Beth Dakin.

  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::currentNSEvent):
(WebCore::EventHandler::currentKeyboardEvent):
(WebCore::EventHandler::mouseDown):
(WebCore::EventHandler::mouseDragged):
(WebCore::EventHandler::mouseUp):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):

3:19 PM Changeset in webkit [54155] by eric@webkit.org
  • 5 edits in trunk

2010-02-01 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT Provide global flag ability
​https://bugs.webkit.org/show_bug.cgi?id=34418

Add the globalFlag property to the Qt LayoutTestController to allow
cross-domain indications.

  • platform/qt/Skipped:

2010-02-01 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT Provide global flag ability
​https://bugs.webkit.org/show_bug.cgi?id=34418

Add the globalFlag property to the Qt LayoutTestController to allow
cross-domain indications.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::globalFlag): (LayoutTestController::setGlobalFlag):
3:11 PM Changeset in webkit [54154] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r50083.

2:39 PM Changeset in webkit [54153] by Nate Chapin
  • 1 edit
    13 adds in trunk/WebCore

2010-02-01 Nate Chapin <Nate Chapin>

Unreviewed, Chromium build fix.

Failed to properly add new files for ​http://trac.webkit.org/changeset/54150.

  • bindings/v8/custom/V8BarInfoCustom.cpp: Added.
  • bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8CSSValueCustom.cpp: Added.
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
  • bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
  • bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
  • bindings/v8/custom/V8SVGElementCustom.cpp: Added.
  • bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
  • bindings/v8/custom/V8ScreenCustom.cpp: Added.
  • bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
2:29 PM Changeset in webkit [54152] by mpcomplete@chromium.org
  • 7 edits in trunk

Add support for addUserScript to chromium port.

2:20 PM Changeset in webkit [54151] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2010-02-01 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=34448
<rdar://problem/7598130>

RenderVideo::intrinsicSizeChanged infinite recursion

  • rendering/RenderImage.h: (WebCore::RenderImage::intrinsicSizeChanged): Make protected instead of private so it can

be called by RenderVideo.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::intrinsicSizeChanged): Call RenderMedia::intrinsicSizeChanged, not

RenderVideo::intrinsicSizeChanged.

(WebCore::RenderVideo::imageChanged): Call RenderMedia::imageChanged instead of

RenderImage::imageChanged.

2:12 PM Changeset in webkit [54150] by Nate Chapin
  • 33 edits in trunk/WebCore

2010-02-01 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Generate toV8() converter for most WebCore->V8 conversions,
and defined custom converters in their respective V8<class>Custom.cpp.

Old converters in V8DOMWrapper will be deleted in a later patch.

​https://bugs.webkit.org/show_bug.cgi?id=32563

  • Android.v8bindings.mk:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8BarInfoCustom.cpp: Added.
  • bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8CSSValueCustom.cpp: Added.
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8ConsoleCustom.cpp:
  • bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NavigatorCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
  • bindings/v8/custom/V8SVGElementCustom.cpp: Added.
  • bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
  • bindings/v8/custom/V8ScreenCustom.cpp: Added.
  • bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8TreeWalkerCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
  • dom/make_names.pl: Add options to generate wrapper factory for V8 bindings.
2:06 PM Changeset in webkit [54149] by bweinstein@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

Check in (failing) expected results for fast/dom/Window/window-postmessage-clone-frames.
This fails because of <rdar://problem/5230396> eventSender.beginDragWithFiles is unimplemented.

  • platform/win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
2:03 PM WebKit Team edited by hamaji@chromium.org
minor fix for quotations (diff)
2:02 PM Changeset in webkit [54148] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-01 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: lazy-load textual resources to avoid UI hangup
​https://bugs.webkit.org/show_bug.cgi?id=34332

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.contentTabSelected):
1:53 PM Changeset in webkit [54147] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-02-01 Eric Carlson <​eric.carlson@apple.com>

No review, build fix.

​https://bugs.webkit.org/show_bug.cgi?id=34447
http/tests/media/video-referer.html fails on Windows

  • platform/win/Skipped:
1:35 PM Changeset in webkit [54146] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed trivial fix.
Platform dependent expected file updated after r54143.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
1:21 PM Changeset in webkit [54145] by beidson@apple.com
  • 11 edits
    2 adds in trunk

Crash in Safari opening new tabs to "same page"
<rdar://problem/7593857> and ​https://bugs.webkit.org/show_bug.cgi?id=34444

Reviewed by Adele Peterson.

WebCore:

Test: fast/loader/crash-copying-backforwardlist.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadItem): Null check currentItem().

  • page/Page.cpp:

(WebCore::Page::goToItem): Ditto.

WebKitTools:

Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(setNewWindowsCopyBackForwardListCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::newWindowsCopyBackForwardList):
(LayoutTestController::setNewWindowsCopyBackForwardList):

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:createWebViewWithRequest:]):

LayoutTests:

  • fast/loader/crash-copying-backforwardlist-expected.txt: Added.
  • fast/loader/crash-copying-backforwardlist.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
1:09 PM Changeset in webkit [54144] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Remove unused file that doesn't seem to belong to the port.

​https://bugs.webkit.org/show_bug.cgi?id=34445

12:48 PM Changeset in webkit [54143] by eric.carlson@apple.com
  • 12 edits in trunk

2010-02-01 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

Fullscreen API should be on HTMLVideoElement
​https://bugs.webkit.org/show_bug.cgi?id=34438


Move fullscreen DOM APIs from HTMLMediaElement to HTMLVideoElement.

  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::paint): Removed outdated FIXME. (WebCore::HTMLVideoElement::paintCurrentFrameInContext): Ditto. (WebCore::HTMLVideoElement::webkitEnterFullScreen): Moved from HTMLMediaElement. (WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto. (WebCore::HTMLVideoElement::webkitSupportsFullscreen): Ditto. (WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.idl:

2010-02-01 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

Fullscreen API should be on HTMLVideoElement
​https://bugs.webkit.org/show_bug.cgi?id=34438

Update fullscreen tests now that <audio> doesn't have fullscreen API.

  • fast/dom/Window/window-properties-expected.txt:
  • media/media-fullscreen-inline-expected.txt:
  • media/media-fullscreen-not-in-document-expected.txt:
  • media/media-fullscreen.js: (buttonClickHandler): (canplaythrough):
12:05 PM Changeset in webkit [54142] by carol.szabo@nokia.com
  • 2 edits in trunk/WebKitTools

2010-02-01 Carol Szabo <​carol.szabo@nokia.com>

Unreviewed.

Add myself to list of committers.

  • Scripts/webkitpy/committers.py:
12:04 PM Changeset in webkit [54141] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-02-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Structure not accounting for anonymous slots when computing property storage size
​https://bugs.webkit.org/show_bug.cgi?id=34441

Previously any Structure with anonymous storage would have a property map, so we
were only including anonymous slot size if there was a property map. Given this
is no longer the case we should always include the anonymous slot count in the
property storage size.

  • runtime/Structure.h: (JSC::Structure::propertyStorageSize):
10:59 AM Changeset in webkit [54140] by Nate Chapin
  • 2 edits in trunk/WebKitTools

2010-02-01 Nate Chapin <Nate Chapin>

Rubber-stamped by David Levin.

Add myself to reviewer list.

  • Scripts/webkitpy/committers.py:
10:44 AM Changeset in webkit [54139] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2010-02-01 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Syntax highlighting in source view of
Resources pane stops half-way.

There were two problems here: (1) styles for html highlighter were not
added into the css file (they used to be injected manually in the
SourceFrame before). (2) 'Tag' needed to be lexer's state, not parser's.
Otherwise unbalanced quotes in the text nodes were matching too match
into the string tokens.

​https://bugs.webkit.org/show_bug.cgi?id=34359

  • inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer.prototype._createLineDivs): (WebInspector.NativeTextViewer.prototype._lineHeight): (WebInspector.NativeTextViewer.prototype.initFontMetrics):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createEditorIfNeeded):
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor.prototype.initFontMetrics): (WebInspector.TextEditor.prototype._registerShortcuts):
  • inspector/front-end/inspectorSyntaxHighlight.css:
10:40 AM WebKit Team edited by Nate Chapin
(diff)
10:35 AM Changeset in webkit [54138] by benm@google.com
  • 6 edits
    3 deletes in trunk

ScriptCallFrame's do not get line numbers/source id's if the caller is unkown.
​https://bugs.webkit.org/show_bug.cgi?id=34335

Reviewed by Darin Adler.

WebCore:

  • bindings/js/ScriptCallStack.cpp:

(WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still availble so pass it to the ScriptCallFrame being constructed.

LayoutTests:

Update layout tests that did not have source and line number information for their console messages, as this information is now available to the ScriptCallFrame and thus can be passed to the inspector, for example.

  • fast/js/console-non-string-values-expected.txt: Add console line number/source.
  • userscripts/script-not-run-for-fragments-expected.txt: ditto.
  • userscripts/script-run-at-start-expected.txt: ditto.
  • platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Removed as platform workarounds no longer necessary.
  • platform/mac/inspector/console-log-before-inspector-open-expected.txt: ditto.
  • platform/win/inspector/console-log-before-inspector-open-expected.txt: ditto.
10:07 AM Changeset in webkit [54137] by krit@webkit.org
  • 32 edits
    2 adds in trunk/WebCore

2010-02-01 Dirk Schulze <​krit@webkit.org>

Reviewed by Simon Fraser.

Add back an AffineTransform class for use by SVG
​https://bugs.webkit.org/show_bug.cgi?id=33750

These are the first steps on reimplementing AffineTransform. Unlike
the old affine code, this one is platform independent like TransformationMatrix.
AffineTransform has the benefit, that it stores just 6 doubles instead of
16 in TransformationMatrix. The calculations of transformations are not that
complex and can improve the memory usage and speed of SVG.
AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
least for the moment).
HTML Canvas is the first that makes use of the new AffineTransform. Next patches
will introduce the affine code to SVG.

No new tests. The new AffineTransformation code is tested by fast/canvas.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
  • platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
  • platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform):
  • platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix):
  • platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend): (WebCore::AffineTransform::toTransformationMatrix):
  • platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix):
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform):
  • platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix):
8:22 AM Changeset in webkit [54136] by Philippe Normand
  • 12 edits in trunk

2010-01-29 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] set playbin mute property depending on volume value
​https://bugs.webkit.org/show_bug.cgi?id=31586

New API in MediaPlayer for mute control. 3 new methods are
introduced:

  • bool supportsMuting() const;
  • bool muted() const;
  • void setMuted(bool);

Platform MediaPlayer implementations can support it easily if the
underlying sound daemon/API supports muting (eg. not only setting
volume to 0) like PulseAudio for instance on Linux. At the moment
the only player supporting this new API is the
MediaPlayerPrivateGStreamer.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): (WebCore::HTMLMediaElement::mediaPlayerMuteChanged):
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::supportsMuting): (WebCore::NullMediaPlayerPrivate::setMuted): (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::muted): (WebCore::MediaPlayer::supportsMuting): (WebCore::MediaPlayer::setMuted): (WebCore::MediaPlayer::volumeChanged): (WebCore::MediaPlayer::muteChanged):
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerMuteChanged):
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsMuting): (WebCore::MediaPlayerPrivateInterface::setMuted):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::notifyMuteIdleCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedCallback): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::supportsMuting): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::muteChangedCallback): (WebCore::MediaPlayerPrivate::muteChanged): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

2010-01-29 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] set playbin mute property depending on volume value
​https://bugs.webkit.org/show_bug.cgi?id=31586

New API in MediaPlayer for mute control

  • public/WebMediaPlayerClient.h:
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::volumeChanged): (WebKit::WebMediaPlayerClientImpl::muteChanged):
  • src/WebMediaPlayerClientImpl.h:
7:30 AM Changeset in webkit [54135] by Csaba Osztrogonác
  • 1 edit
    1 copy in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Platform dependent expected file added for test introduced in r53868,
because this test passes. Compared to png file and Mac expected file.

  • platform/qt/fast/lists/anonymous-items-expected.txt: Added.
7:03 AM Changeset in webkit [54134] by Simon Hausmann
  • 3 edits in trunk/WebCore

[Qt] Build without SSL support is broken

Patch by Henry Haverinen <Henry Haverinen> on 2010-02-01
Reviewed by Simon Hausmann.

Added missing #ifdefs for OpenSSL support and one null-pointer
check for the socket.

​https://bugs.webkit.org/show_bug.cgi?id=34416

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp:

(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::send):

6:05 AM Changeset in webkit [54133] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2010-02-01 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Fix rest of the NativeTextViewer (line numbers,
conditional breakpoints, selection).

5:58 AM QtWebKitBackportingFixes edited by andreas.kling@nokia.com
(diff)
5:54 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:11 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
4:43 AM QtWebKitBackportingFixes edited by kenneth@webkit.org
(diff)
2:50 AM Changeset in webkit [54132] by steveblock@google.com
  • 2 edits
    2 adds in trunk/WebCore

Adds implementation of JavaString for V8.
​https://bugs.webkit.org/show_bug.cgi?id=33953

Reviewed by Ariya Hidayat.

No new tests, build fix only.

  • bridge/jni/JNIBridge.h: Modified. Include JavaStringV8.h for V8
  • bridge/jni/v8: Added.
  • bridge/jni/v8/JavaStringV8.h: Added.

(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::UTF8String):
(JSC::Bindings::JavaStringImpl::uchars):
(JSC::Bindings::JavaStringImpl::length):

2:05 AM Changeset in webkit [54131] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-02-01 Oliver Hunt <​oliver@apple.com>

Windows build fix, update exports file (again)

1:56 AM Changeset in webkit [54130] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-02-01 Oliver Hunt <​oliver@apple.com>

Windows build fix, update exports file

1:43 AM Changeset in webkit [54129] by oliver@apple.com
  • 5 edits
    2 adds in trunk

2010-01-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

JSC is failing to propagate anonymous slot count on some transitions
​https://bugs.webkit.org/show_bug.cgi?id=34321

Remove secondary Structure constructor, and make Structure store a copy
of the number of anonymous slots directly so saving an immediate allocation
of a property map for all structures with anonymous storage, which also
avoids the leaked property map on new property transition in the original
version of this patch.

We need to propagate the the anonymous slot count otherwise we can end up
with a structure recording incorrect information about the available and
needed space for property storage, or alternatively incorrectly reusing
some slots.

  • JavaScriptCore.exp:
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::copyPropertyTable): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::insertIntoPropertyMapHashTable): (JSC::Structure::createPropertyMapHashTable):
  • runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::hasAnonymousSlots): (JSC::Structure::anonymousSlotCount):

2010-02-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

JSC is failing to propagate anonymous slot count on some transitions
​https://bugs.webkit.org/show_bug.cgi?id=34321

Add test case for modifying DOM objects with anonymous storage.

  • fast/dom/Window/anonymous-slot-with-changes-expected.txt: Added.
  • fast/dom/Window/anonymous-slot-with-changes.html: Added.
1:27 AM Changeset in webkit [54128] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-01 Alex Milowski <​alex@milowski.com>

Reviewed by Darin Adler.

Added compile time debug support for mathml layout (block boundary & baseline)

  • mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::stretchToHeight): (WebCore::RenderMathMLBlock::paint):
  • mathml/RenderMathMLBlock.h:
12:50 AM Changeset in webkit [54127] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-02-01 Philippe Normand <​pnormand@igalia.com>

Rubber stamped by Xan Lopez.

Fixed compilation warning about unsigned vs signed comparison.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint):

Jan 31, 2010:

11:29 PM Applications using WebKit edited by wevah@derailer.org
Paparazzi! is a Universal Binary. Also dropped the "www." from its URL. (diff)
11:05 PM Changeset in webkit [54126] by Chris Jerdonek
  • 5 edits
    2 adds in trunk/WebKitTools

2010-01-31 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Moved style error handler code to their own classes, and
related refactoring. Increased unit test code coverage of
style error handling.

​https://bugs.webkit.org/show_bug.cgi?id=34379

  • Scripts/check-webkit-style:
    • Minor change: added error_count variable.
  • Scripts/webkitpy/style/checker.py:
    • Renamed ProcessorOptions.should_report_error() to is_reportable().
    • In the StyleChecker class--
      • Removed _default_style_error_handler().
      • Added _increment_error_count().
      • Refactored to use DefaultStyleErrorHandler and PatchStyleErrorHandler constructors.
  • Scripts/webkitpy/style/checker_unittest.py:
    • In the StyleStyleCheckerTest class--
      • Removed write_sample_error().
      • Removed test_default_style_error_handler().
  • Scripts/webkitpy/style/error_handlers.py: Added.
    • Added DefaultStyleErrorHandler class.
    • Added PatchStyleErrorHandler class.
  • Scripts/webkitpy/style/error_handlers_unittest.py: Added.
    • Added unit tests for DefaultStyleErrorHandler and PatchStyleErrorHandler.
  • Scripts/webkitpy/style/unittests.py:
    • Added error_handlers unit tests.
10:21 PM Changeset in webkit [54125] by tkent@chromium.org
  • 31 edits
    2 deletes in trunk/WebCore

2010-01-31 Kent Tamura <​tkent@chromium.org>

Unreviewed. Revert r54112 and r54124 because of Windows build error.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/cairo/TransformationMatrixCairo.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/cg/TransformationMatrixCG.cpp:
  • platform/graphics/haiku/GraphicsContextHaiku.cpp:
  • platform/graphics/haiku/PathHaiku.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/PathQt.cpp:
  • platform/graphics/qt/TransformationMatrixQt.cpp:
  • platform/graphics/skia/GraphicsContextSkia.cpp:
  • platform/graphics/skia/PathSkia.cpp:
  • platform/graphics/skia/TransformationMatrixSkia.cpp:
  • platform/graphics/transforms/AffineTransform.cpp: Removed.
  • platform/graphics/transforms/AffineTransform.h: Removed.
  • platform/graphics/wince/GraphicsContextWince.cpp:
  • platform/graphics/wx/GraphicsContextWx.cpp:
  • platform/graphics/wx/PathWx.cpp:
  • platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::TransformationMatrix::operator wxGraphicsMatrix):
9:04 PM Changeset in webkit [54124] by tkent@chromium.org
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Unreviewd. Windows build fix.

8:23 PM Changeset in webkit [54123] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-31 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Buildfix for WinCE + style fixes (TLS_OUT_OF_INDEXES is not defined).
​https://bugs.webkit.org/show_bug.cgi?id=34380

  • wtf/ThreadSpecific.h:
6:37 PM Changeset in webkit [54122] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-31 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Limit the scope of packing alignment to avoid MSVC C4103 warning.
​https://bugs.webkit.org/show_bug.cgi?id=34390

Use pack(push, 16) and pack(pop) to limit the scope of packing
alignment change.

  • bindings/js/JSSVGPODTypeWrapper.h:
6:33 PM Changeset in webkit [54121] by tkent@chromium.org
  • 5 edits in trunk

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

[Windows] Fix a bug of round() with huge integral numbers
​https://bugs.webkit.org/show_bug.cgi?id=34297

Fix a bug that round() for huge integral numbers returns incorrect
results. For example, round(8639999913600001) returns
8639999913600002 without this change though the double type can
represent 8639999913600001 precisely.

Math.round() of JavaScript has a similar problem. But this change
doesn't fix it because Math.round() doesn't use round() of
MathExtra.h.

  • wtf/MathExtras.h: (round): Avoid to do "num + 0.5" or "num - 0.5". (roundf): Fixed similarly. (llround): Calls round(). (llroundf): Calls roundf(). (lround): Calls round(). (lroundf): Calls roundf().

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

[Win] Fix a bug of round() with huge integral numbers
​https://bugs.webkit.org/show_bug.cgi?id=34297

Add a test case to call round(8639999913600001).

  • fast/forms/input-valueasnumber-datetime-expected.txt:
  • fast/forms/script-tests/input-valueasnumber-datetime.js:
5:56 PM Changeset in webkit [54120] by tkent@chromium.org
  • 7 edits in trunk

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix valueAsNumber calculation for type=month.
​https://bugs.webkit.org/show_bug.cgi?id=34304

valueAsNumber calculation for type=month which was checked in as
r53893 was the number of milliseconds since UNIX epoch, and it was
wrong. The correct way is the number months since UNIX epoch.

  • fast/forms/input-valueasnumber-month-expected.txt:
  • fast/forms/script-tests/input-valueasnumber-month.js:

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix valueAsNumber calculation for type=month.
​https://bugs.webkit.org/show_bug.cgi?id=34304

valueAsNumber calculation for type=month which was checked in as
r53893 was the number of milliseconds since UNIX epoch, and it was
wrong. The correct way is the number months since UNIX epoch.

  • html/DateComponents.cpp: (WebCore::DateComponents::setMonthsSinceEpoch): (WebCore::DateComponents::monthsSinceEpoch):
  • html/DateComponents.h: Declare setMonthsSinceEpoch() and monthsSinceEpoch().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseToDouble): Switch to monthsSinceEpoch() for type=MONTH. (WebCore::HTMLInputElement::valueAsDate): Add code with millisecondsSinceEpoch() for MONTH because parseToDouble() changed its behavior. (WebCore::HTMLInputElement::setValueAsNumber): Use setMonthsSinceEpoch() for MONTH.
5:43 PM Changeset in webkit [54119] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Fix a bug that a selected word is not recognized as a
spell-check source.
​https://bugs.webkit.org/show_bug.cgi?id=33660

  • src/ContextMenuClientImpl.cpp: (WebKit::isASingleWord): Use wordBreakIterator(), and correctly check the return value of textBreakNext().
5:42 PM Changeset in webkit [54118] by mitz@apple.com
  • 2 edits in trunk/WebCore

Web Inspector: REGRESSION: Numbers in bubbles are vertically off-center
​https://bugs.webkit.org/show_bug.cgi?id=34398

Reviewed by Timothy Hatcher.

  • inspector/front-end/inspector.css: Specify line-height: normal for

".console-message .bubble" and ".sidebar-tree-item .status .bubble".

4:54 PM Changeset in webkit [54117] by ojan@chromium.org
  • 6 edits in trunk

2010-01-28 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

Implement CSSOM Range.getClientRects for collapsed selections
​https://bugs.webkit.org/show_bug.cgi?id=34239

Adds two cases to getClientRects test.

  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/Range/getClientRects.html:

2010-01-28 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

Implement CSSOM Range.getClientRects for collapsed selections
​https://bugs.webkit.org/show_bug.cgi?id=34239

When getting the quads for a range on a text node, allow returning
zero width quads. This leaves the case of collapsed selections inside
elements still not fixed, but no worse.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteQuadsForRange):
3:59 PM Changeset in webkit [54116] by mrowe@apple.com
  • 4 edits in trunk/WebCore

Roll r54095 out again without making a mess of the ChangeLog.

3:59 PM Changeset in webkit [54115] by mrowe@apple.com
  • 4 edits in trunk/WebCore

Revert r54114 since it made a mess of the ChangeLog.

3:43 PM Changeset in webkit [54114] by eric.carlson@apple.com
  • 4 edits in trunk/WebCore

2010-01-31 Eric Carlson <​eric.carlson@apple.com>

Revert r54095 because it caused many media tests to fail.

  • platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::setContentsToVideo): (WebCore::GraphicsLayerCACF::updateContentsVideo):
  • platform/graphics/win/GraphicsLayerCACF.h: (WebCore::GraphicsLayerCACF::):
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::task): (QTMovieWinPrivate::setSize):
3:01 PM Changeset in webkit [54113] by oliver@apple.com
  • 8 edits in trunk

2010-01-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Simon Fraser.

Animated scaling of background-image is too slow
​https://bugs.webkit.org/show_bug.cgi?id=33808

Update checksum.

  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:

2010-01-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Simon Fraser.

Animated scaling of background-image is too slow
​https://bugs.webkit.org/show_bug.cgi?id=33808

Implement a version of the RenderImage animated scaling optimisation
for background images. Due to the possibility of arbitrary transforms
being applied to containing elements we explicitly check the current
CTM of the context for scaling or rotation.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer): (WebCore::RenderBoxModelScaleData::size): (WebCore::RenderBoxModelScaleData::setSize): (WebCore::RenderBoxModelScaleData::lastPaintTime): (WebCore::RenderBoxModelScaleData::setLastPaintTime): (WebCore::RenderBoxModelScaleData::useLowQualityScale): (WebCore::RenderBoxModelScaleData::transform): (WebCore::RenderBoxModelScaleData::setTransform): (WebCore::RenderBoxModelScaleData::setUseLowQualityScale): (WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed): (WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::highQualityRepaintTimerFired): (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
1:04 PM Changeset in webkit [54112] by krit@webkit.org
  • 31 edits
    2 adds in trunk/WebCore

2010-01-31 Dirk Schulze <​krit@webkit.org>

Reviewed by Simon Fraser.

Add back an AffineTransform class for use by SVG
​https://bugs.webkit.org/show_bug.cgi?id=33750

These are the first steps on reimplementing AffineTransform. Unlike
the old affine code, this one is platform independent like TransformationMatrix.
AffineTransform has the benefit, that it stores just 6 doubles instead of
16 in TransformationMatrix. The calculations of transformations are not that
complex and can improve the memory usage and speed of SVG.
AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
least for the moment).
HTML Canvas is the first that makes use of the new AffineTransform. Next patches
will introduce the affine code to SVG.

No new tests. The new AffineTransformation code is tested by fast/canvas.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
  • platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
  • platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform):
  • platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix):
  • platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend):
  • platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform):
  • platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix):
9:55 AM Changeset in webkit [54111] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-31 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] Breakpoint source line is not displayed
in the breakpoint manager.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addBreakpointToSource):
8:36 AM Changeset in webkit [54110] by pfeldman@chromium.org
  • 11 edits
    1 add in trunk/WebCore

2010-01-31 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce NativeTextViewer.

This change handles rendering highlighted text, using browser's
selection/drag/drop/click logic. Breakpoint decorations and
program counter is working.

Todo: line numbers are painted 'under' the text when scrolling
horizontally, search is not yet implemented.

​https://bugs.webkit.org/show_bug.cgi?id=34391

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DivBasedTextViewer.js: Added. (WebInspector.DivBasedTextViewer): (WebInspector.DivBasedTextViewer.prototype._textChanged): (WebInspector.DivBasedTextViewer.prototype._createLineDivs): (WebInspector.DivBasedTextViewer.prototype._updatePreferredSize): (WebInspector.DivBasedTextViewer.prototype._scroll): (WebInspector.DivBasedTextViewer.prototype._registerMouseListeners): (WebInspector.DivBasedTextViewer.prototype._registerKeyboardListeners): (WebInspector.DivBasedTextViewer.prototype._registerClipboardListeners): (WebInspector.DivBasedTextViewer.prototype._paintSelection): (WebInspector.DivBasedTextViewer.prototype._positionDivDecoration): (WebInspector.DivBasedTextViewer.prototype._mouseDown): (WebInspector.DivBasedTextViewer.prototype._contextMenu): (WebInspector.DivBasedTextViewer.prototype._caretForMouseEvent): (WebInspector.DivBasedTextViewer.prototype._paintLine): (WebInspector.DivBasedTextViewer.prototype._createSpan):
  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype._createEditorIfNeeded): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype.resize):
  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype._registerMouseListeners): (WebInspector.TextEditor.prototype._registerKeyboardListeners): (WebInspector.TextEditor.prototype._registerClipboardListeners): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype.revalidateDecorationsAndPaint): (WebInspector.TextEditor.prototype._updatePreferredSize): (WebInspector.TextEditor.prototype.resize): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._paintLine): (WebInspector.TextEditor.prototype._contextMenu): (WebInspector.TextEditor.prototype._caretForMouseEvent): (WebInspector.TextEditor.prototype._changeFont):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/textEditor.css:
7:42 AM Changeset in webkit [54109] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-31 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

[Qt] Enable FAST_MOBILE_SCROLLING on Qt embedded platforms
​https://bugs.webkit.org/show_bug.cgi?id=34168

Enable FAST_MOBILE_SCROLLING for Qt on Maemo 5, Linux embedded
and Symbian

  • WebCore.pro:
Note: See TracTimeline for information about the timeline view.