⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 3, 2010:

11:54 PM Changeset in webkit [54328] by dpranke@chromium.org
  • 23 edits in trunk/WebKitTools

2010-02-03 Dirk Pranke <​dpranke@chromium.org>

Rubber-stamped by Eric Seidel.

Change "the Chromium name" to "the name of Google Inc." in the licenses

​https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/path_utils.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
11:51 PM Changeset in webkit [54327] by dpranke@chromium.org
  • 12 edits
    11 moves
    1 add in trunk/WebKitTools

2010-02-03 Dirk Pranke <​dpranke@chromium.org>

Rubber-stamped by Eric Siedel.

Rename files as part of refactoring the layout_tests package. All
the platform_utils* module, the path_utils.py module, and
the http server and web socket server modules are moved into a new
port/ package.

​https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/init.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
  • Scripts/webkitpy/layout_tests/port/http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server.py.
  • Scripts/webkitpy/layout_tests/port/http_server_base.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
  • Scripts/webkitpy/layout_tests/port/httpd2.pem: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
  • Scripts/webkitpy/layout_tests/port/lighttpd.conf: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
  • Scripts/webkitpy/layout_tests/port/path_utils.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
11:48 PM Changeset in webkit [54326] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-02-03 Nicholas Young <​nicholas.young@nokia.com>

Reviewed by Eric Carlson.

Defer formatting of times displayed on media controls to the current theme.
​https://bugs.webkit.org/show_bug.cgi?id=34405

No new tests needed. Refactoring Only.

  • rendering/MediaControlElements.cpp: Removed formatTime() (WebCore::MediaControlTimeDisplayElement::setCurrentValue): No longer sets inner text
  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateTimeDisplay): Asks the theme to format the time display elements
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::formatMediaControlsTime): new virtual method (WebCore::RenderTheme::formatMediaControlsCurrentTime): new virtual method (WebCore::RenderTheme::formatMediaControlsRemainingTime): new virtual method
  • rendering/RenderTheme.h:
11:30 PM Changeset in webkit [54325] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix.

websocket/tests/close-on-unload.html and
close-on-navigate-new-location.html will fail on mac tiger,
because python on the platform doesn't support set(), which is
used in websocket handler for these tests.

  • platform/mac-tiger/Skipped: skip websocket/tests/close-on-unload.html and websocket/tests/close-on-navigate-new-location.html
11:26 PM Changeset in webkit [54324] by ukai@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-02-03 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

navigating a frame to new location closes websocket in the frame
​https://bugs.webkit.org/show_bug.cgi?id=34557

  • websocket/tests/close-on-navigate-new-location-expected.txt: Added.
  • websocket/tests/close-on-navigate-new-location.html: Added.
9:52 PM Changeset in webkit [54323] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Windows Debug_All build fix.

  • platform/graphics/win/WKCACFLayer.cpp:
7:57 PM Changeset in webkit [54322] by mrowe@apple.com
  • 1 delete in trunk/LayoutTests/websocket/tests/resources/close-on-unload-iframe.html~

Remove an unnecessary backup file.

7:28 PM Changeset in webkit [54321] by beidson@apple.com
  • 3 edits
    9 adds in trunk

REGRESSION (r51644): WebCore/manual-tests/linkjump-1.html fails
<rdar://problem/7595694> and ​https://bugs.webkit.org/show_bug.cgi?id=34550

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: fast/loader/document-with-fragment-url-1.html

fast/loader/document-with-fragment-url-2.html
fast/loader/document-with-fragment-url-3.html
fast/loader/document-with-fragment-url-4.html

  • platform/KURL.cpp:

(WebCore::KURL::init): When resolving new URL from an empty reference relative to an absolute URL,

any fragment identifier from the absolute URL should be removed from the resulting resolution.

LayoutTests:

  • fast/loader/document-with-fragment-url-1-expected.txt: Added.
  • fast/loader/document-with-fragment-url-1.html: Added.
  • fast/loader/document-with-fragment-url-2-expected.txt: Added.
  • fast/loader/document-with-fragment-url-2.html: Added.
  • fast/loader/document-with-fragment-url-3-expected.txt: Added.
  • fast/loader/document-with-fragment-url-3.html: Added.
  • fast/loader/document-with-fragment-url-4-expected.txt: Added.
  • fast/loader/document-with-fragment-url-4.html: Added.
  • fast/loader/resources/document-with-fragment-url-test.html: Added.
6:49 PM Changeset in webkit [54320] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-03 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Define WTF_PLATFORM_BREWMP_SIMULATOR when AEE_SIMULATOR is defined
​https://bugs.webkit.org/show_bug.cgi?id=34514

PLATFORM(BREWMP_SIMULATOR) guard is needed to make distinction between BREWMP
and BREWMP simulator.

  • wtf/Platform.h:
6:24 PM Changeset in webkit [54319] by ukai@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-02-03 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket should close the connection when unloading the document
​https://bugs.webkit.org/show_bug.cgi?id=33248

  • websocket/tests/close-on-unload-expected.txt: Added.
  • websocket/tests/close-on-unload.html: Added.
  • websocket/tests/close-on-unload_wsh.py: Added.
  • websocket/tests/resources/close-on-unload-iframe.html: Added.
6:23 PM Changeset in webkit [54318] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-02-03 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port TextBreakIteratorInternalICU
​https://bugs.webkit.org/show_bug.cgi?id=34515

Port TextBreakIteratorInternalICU.

  • platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Added. (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
5:52 PM Changeset in webkit [54317] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Fix for <rdar://problem/7594212>
​https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at ​http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319

Reviewed by Simon Fraser.

Test: fast/css/counters/counter-before-selector-crash.html

  • rendering/RenderCounter.cpp: (WebCore::updateCounters): nil check.

LayoutTests: Test for: <rdar://problem/7594212>
​https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at ​http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319

Reviewed by Simon Fraser.

  • fast/css/counters/counter-before-selector-crash-expected.txt: Added.
  • fast/css/counters/counter-before-selector-crash.html: Added.
5:32 PM Changeset in webkit [54316] by adele@apple.com
  • 2 edits in trunk/WebCore

Initialize the variable in the last checkin to false. I didn't realize DRT relies on this being false.
So ports that want visited link tracking need to set that flag.

Reviewed by Brady Eidson.

  • page/PageGroup.cpp:
5:09 PM Changeset in webkit [54315] by mrowe@apple.com
  • 4 edits
    1 add in branches/safari-4-branch/WebCore

Merge r54311.

5:07 PM Changeset in webkit [54314] by Csaba Osztrogonác
  • 4 edits
    1 add in trunk/WebKitTools

Rubber-stamped by Eric Seidel.

Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
​https://bugs.webkit.org/show_bug.cgi?id=34399

  • Scripts/run-iexploder-tests:
  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
  • Scripts/webkitperl/httpd.pm: Added.
4:50 PM Changeset in webkit [54313] by adele@apple.com
  • 2 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=34547
static shouldTrackVisitedLinks is not initialized

Reviewed by Brady Eidson.

For ports that don't call into WebKit to initialize this,
we should initialize to true so they get the visited link behavior by default.

  • page/PageGroup.cpp:
4:32 PM Changeset in webkit [54312] by Csaba Osztrogonác
  • 4 edits
    1 delete in trunk/WebKitTools

Rubber-stamped by Eric Seidel.

Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots

  • Scripts/run-iexploder-tests:
  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
  • Scripts/webkitperl/httpd.pm: Removed.
4:26 PM Changeset in webkit [54311] by mitz@apple.com
  • 4 edits
    1 add in trunk/WebCore

<rdar://problem/7577604> Drag and Drop: background elements are bleeding through
​https://bugs.webkit.org/show_bug.cgi?id=34546

Reviewed by Simon Fraser.

  • manual-tests/drag-image-table-part-decorations.html: Added.
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t
paint within the current painting root.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.
(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

4:19 PM Changeset in webkit [54310] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch/WebKitTools

Build fix.

3:47 PM Changeset in webkit [54309] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add wxWebKitWindowFeatures and have createWindow send a notification for
clients to handle.

​https://bugs.webkit.org/show_bug.cgi?id=34542

3:31 PM Changeset in webkit [54308] by mrowe@apple.com
  • 8 edits in branches/safari-4-branch

Merge r54083.

3:31 PM Changeset in webkit [54307] by Csaba Osztrogonác
  • 4 edits in trunk

Rubber-stamped by Ariya Hidayat.

Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
​https://bugs.webkit.org/show_bug.cgi?id=34399

WebKitTools:

  • DumpRenderTree/win/EventSender.cpp:

(buildModifierFlags):
(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):

LayoutTests:

  • platform/win/Skipped:
3:06 PM Changeset in webkit [54306] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-02-03 Nate Chapin <Nate Chapin>

Unreviewed, Chromium mac build fix.

[V8] Remove unused V8Proxy* variable from generated wrapping code.

  • bindings/scripts/CodeGeneratorV8.pm:
2:33 PM Changeset in webkit [54305] by Nate Chapin
  • 47 edits in trunk/WebCore

2010-02-03 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.


​https://bugs.webkit.org/show_bug.cgi?id=32563

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptObject.cpp:
  • bindings/v8/V8AbstractEventListener.cpp:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8NodeFilterCondition.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/WorkerContextExecutionProxy.h
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8CustomPositionCallback.cpp:
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8DocumentLocationCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8MessageEventCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NodeIteratorCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8SVGMatrixCustom.cpp:
  • bindings/v8/custom/V8StyleSheetListCustom.cpp:
  • bindings/v8/custom/V8TreeWalkerCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
2:32 PM Changeset in webkit [54304] by eric@webkit.org
  • 25 edits in trunk/WebKitTools

2010-02-03 Eric Seidel <​eric@webkit.org>

No review, just fixing copyrights.

Concerns were expressed about "The Chromium Authors" being
a valid legal entity for copyright assignment in the WebKit repository,
so this change removes all "The Chromium Authors".

I looked at the svn logs in src.chromium.org and failed to find any
non-google contributions to these files, so they are all now
marked as copyright "Google Inc" as all Google contributers assign
copyright to "Google Inc" as part of their employment agreement.

  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/run-chromium-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/layout_package/http_server.py:
  • Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2:26 PM Changeset in webkit [54303] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r48879.

2:26 PM Changeset in webkit [54302] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Merge r48374.

2:26 PM Changeset in webkit [54301] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48364.

2:26 PM Changeset in webkit [54300] by mrowe@apple.com
  • 31 edits
    1 copy
    15 adds in branches/safari-4-branch

Merge r48363.

2:23 PM Changeset in webkit [54299] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix drawing buttons in viewless WebKit.

Reviewed by Anders Carlsson.

  • platform/mac/ThemeMac.mm:

(WebCore::paintButton): If there is no view, make sure to flip the
context so that the button is drawn correctly.

2:00 PM Changeset in webkit [54298] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
​https://bugs.webkit.org/show_bug.cgi?id=34425

Reviewed by Kenneth Rohde Christiansen.

Reverting r54279, it was a misunderstanding.

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp:
1:44 PM Changeset in webkit [54297] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] QtLauncher, refactor argument handling in preparation of merge
with QGVLauncher

Reviewed by Ariya Hidayat.

  • QtLauncher/main.cpp:

(LauncherApplication::urls):
(LauncherApplication::isRobotized):
(LauncherApplication::applyDefaultSettings):
(LauncherApplication::LauncherApplication):
(LauncherApplication::formatKeys):
(LauncherApplication::enumToKeys):
(fail):
(LauncherApplication::handleUserOptions):
(main):

1:43 PM Changeset in webkit [54296] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-03 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Remove COMPILE_ASSERT conflict with the underlying PLATFORM
​https://bugs.webkit.org/show_bug.cgi?id=34190

COMPILE_ASSERT conflicts with the underlying PLATFORM because it is defined
both in WTF's Assertions.h and BREWMP's AEEClassIDs.h. Include AEEClassIDs.h
in Assertions.h and undef COMPILE_ASSERT to avoid redefining COMPILE_ASSERT.

  • wtf/Assertions.h:
1:19 PM Changeset in webkit [54295] by Csaba Osztrogonác
  • 4 edits in trunk

Rubber-stamped by Ariya Hidayat.

Rolling out r53889, because it might caused flakeyness on the Windows Test bots
​https://bugs.webkit.org/show_bug.cgi?id=34399

WebKitTools:

  • DumpRenderTree/win/EventSender.cpp:

(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):

LayoutTests:

  • platform/win/Skipped:
1:17 PM Changeset in webkit [54294] by eric@webkit.org
  • 1 edit
    2 adds in trunk/JavaScriptCore

2010-02-03 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Implement OwnPtrBrew to make sure BREW instances are freed.
​https://bugs.webkit.org/show_bug.cgi?id=34518

Add OwnPtrBrew to release IFile, IFileMgr and IBitmap instances.

  • wtf/brew/OwnPtrBrew.cpp: Added. (WTF::IFileMgr): (WTF::IFile): (WTF::IBitmap): (WTF::freeOwnedPtrBrew):
  • wtf/brew/OwnPtrBrew.h: Added. (WTF::OwnPtrBrew::OwnPtrBrew): (WTF::OwnPtrBrew::~OwnPtrBrew): (WTF::OwnPtrBrew::get): (WTF::OwnPtrBrew::release): (WTF::OwnPtrBrew::outPtr): (WTF::OwnPtrBrew::set): (WTF::OwnPtrBrew::clear): (WTF::OwnPtrBrew::operator*): (WTF::OwnPtrBrew::operator->): (WTF::OwnPtrBrew::operator!): (WTF::OwnPtrBrew::operator UnspecifiedBoolType): (WTF::OwnPtrBrew::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::getPtr):
12:58 PM Changeset in webkit [54293] by bweinstein@apple.com
  • 3 edits in trunk/WebKit/win

Scroll does not work with IBM Thinkpad.
<​https://bugs.webkit.org/show_bug.cgi?id=14227>
<rdar://7142545>

Reviewed by Steve Falkenburg.

When initializing the WebView, add two scrollbar Windows inside of
our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events.
(similar to what Firefox did in: <​https://bugzilla.mozilla.org/show_bug.cgi?id=507222>.

Only do this if the user has installed some kind of Trackpoint driver, using an algorithm
like <​https://bugzilla.mozilla.org/show_bug.cgi?id=514927>.

Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll
the WebView.

  • WebView.cpp:

(WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down

by lines or pages.

(WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right

by lines or pages.

(WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL.
(WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create

vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages.

(WebView::shouldInitializeTrackPointHack): Check if there is a registry key for

the some kind of IBM Trackpoint driver.

  • WebView.h:
12:14 PM Changeset in webkit [54292] by eric@webkit.org
  • 5 edits in trunk

2010-02-03 Drew Wilson <​atwilson@chromium.org>

Reviewed by Alexey Proskuryakov.

SharedWorkerScriptLoader should not be an ActiveDOMObject
​https://bugs.webkit.org/show_bug.cgi?id=34513

Test: Existing tests suffice (fixes test downstream in Chrome).

  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed to no longer derive from ActiveDOMObject (handles its own refcounting). (WebCore::SharedWorkerScriptLoader::load): Now increments own refcount when a load is pending. (WebCore::SharedWorkerScriptLoader::notifyFinished): Changed to decrement refcount when load is complete.
  • workers/WorkerScriptLoaderClient.h: Documentation change about reliability of notifyFinished() when used from worker context.

2010-02-03 Drew Wilson <​atwilson@chromium.org>

Reviewed by Alexey Proskuryakov.

SharedWorkerScriptLoader should not be an ActiveDOMObject
​https://bugs.webkit.org/show_bug.cgi?id=34513

  • src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed SharedWorkerScriptLoader to manage its own lifecycle without using ActiveDOMObject. (WebCore::SharedWorkerScriptLoader::parentContext): (WebCore::pendingLoaders): Now we manually track pending loads so we can shut them down when the parent context shuts down. (WebCore::SharedWorkerScriptLoader::contextDetached): Shuts down/frees any pending worker loads. (WebCore::SharedWorkerScriptLoader::~SharedWorkerScriptLoader): Marks the SharedWorker object as not having pending activity if there was a load active (handles case where load was pending when parent document exits). (WebCore::SharedWorkerScriptLoader::load): (WebCore::SharedWorkerRepository::documentDetached): Now calls SharedWorkerScriptLoader::contextDetached() to shutdown any pending worker loads.
11:57 AM Changeset in webkit [54291] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Inspector renders blank scripts on reloading the webpage.

​https://bugs.webkit.org/show_bug.cgi?id=34537

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
11:41 AM Changeset in webkit [54290] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-03 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Export WTF::fastStrDup symbol
​https://bugs.webkit.org/show_bug.cgi?id=34526

11:39 AM Changeset in webkit [54289] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

[Qt] Fix pixel tests support.
​https://bugs.webkit.org/show_bug.cgi?id=27813

Reviewed by Ariya Hidayat.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):

  • Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.

(WebCore::DumpRenderTree::dump): Fixed and renamed variables.

11:02 AM Changeset in webkit [54288] by mitz@apple.com
  • 2 edits in trunk/WebKitLibraries

Fixed a bug where WKSetNSURLConnectionDefersCallbacks(true) did not defer callbacks during modal dialogs.

Reviewed by Anders Carlsson.

  • libWebKitSystemInterfaceLeopard.a:
10:52 AM Changeset in webkit [54287] by kevino@webkit.org
  • 4 edits in trunk

Reviewed by Kevin Ollivier.

[wx] Enable JIT compilation for wx.

​https://bugs.webkit.org/show_bug.cgi?id=34536

10:26 AM Changeset in webkit [54286] by yurys@chromium.org
  • 13 edits
    2 deletes in trunk/WebCore

2010-02-03 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Revert r54285 which failed to compile on Linux GTK.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScript.cpp: Removed.
  • inspector/InjectedScript.h: Removed.
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
10:11 AM Changeset in webkit [54285] by yurys@chromium.org
  • 14 edits
    2 adds in trunk/WebCore

2010-02-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Provide strongly typed C++ interface for inspector's injected script.

​https://bugs.webkit.org/show_bug.cgi?id=33616

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScript.cpp: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapAndStringify): (WebCore::InjectedScript::releaseWrapperObjectGroup):
  • inspector/InjectedScript.h: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::~InjectedScript): (WebCore::InjectedScript::hasNoValue):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
10:02 AM Changeset in webkit [54284] by abecsi@webkit.org
  • 4 edits in trunk

Unreviewed build fix.

[Qt] Roll-out r54281 because it broke the build on the Qt Release bot.

9:48 AM Changeset in webkit [54283] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-02-03 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Timothy Hatcher.

[Chromium] Return a consistent set of platforms from WebDevToolsFrontendImpl
​https://bugs.webkit.org/show_bug.cgi?id=34523

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::jsPlatform):
8:09 AM Changeset in webkit [54282] by levin@chromium.org
  • 2 edits in trunk/WebCore

2010-02-02 Bryan Yeung <​bryeung@google.com>

Reviewed by Darin Adler.

Avoid using an invalidated KURL object in baseURI.

​https://bugs.webkit.org/show_bug.cgi?id=34492

This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg

This is a re-application of this patch since it was mistakenly identified as
the cause of a big chromium test regression and rolled out in r54264.

  • dom/Element.cpp: (WebCore::Element::baseURI):
8:01 AM Changeset in webkit [54281] by eric@webkit.org
  • 4 edits in trunk

2010-02-03 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
recaching, remove QTimer::singleShot and QPixmap::scaled, more
accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.

​https://bugs.webkit.org/show_bug.cgi?id=34062

This is tested by ​https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs (WebCore::OpacityAnimationQt::updateState): style change

2010-02-03 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
of QTimer::singleShot, and moved syncLayers() from paint() to update()
​https://bugs.webkit.org/show_bug.cgi?id=34062

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update): Moved the sync operation to update (QGraphicsWebView::paint): Moved the sync operation to update
7:37 AM Changeset in webkit [54280] by levin@chromium.org
  • 5 edits
    2 adds in trunk

WebCore: [Chromium] Make setCaretBlinkInterval static.
​https://bugs.webkit.org/show_bug.cgi?id=31704

Patch by Joel Stanley <​joel@jms.id.au> on 2010-02-02
Reviewed by David Levin.

This is so it can be called from the newly exposed Chromium API setter
method.

  • rendering/RenderThemeChromiumLinux.cpp:
  • rendering/RenderThemeChromiumLinux.h:

WebKit/chromium: [Chromium] Add API method for setting caret blink frequency.
​https://bugs.webkit.org/show_bug.cgi?id=31704

Patch by Joel Stanley <​joel@jms.id.au> on 2010-02-02
Reviewed by David Levin.

This enables the RenderThemeChromiumLinux::setCaretBlinkInterval method
to be called Chromium's API. The API is linux-only as it is currently
the only port to implement RenderTheme::setCaretBlinkInterval.

  • WebKit.gyp: Add WebRenderTheme.{h,cpp}
  • public/linux/WebRenderTheme.h: Added.
  • src/linux/WebRenderTheme.cpp: Added.

(WebKit::setCaretBlinkInterval): Exposed API

5:42 AM Changeset in webkit [54279] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
​https://bugs.webkit.org/show_bug.cgi?id=34425

Reviewed by Kenneth Rohde Christiansen.

Buffer the sent data in SocketStreamHandlePrivate instead of relying on
the network layer to do it. This is more robust and more consistent with how
Qt's HTTP stack works.
Close the socket in SocketStreamHandlePrivate::close() regardless of its state.

No new tests, since no new functionality is introduced.

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp:
5:02 AM Changeset in webkit [54278] by hamaji@chromium.org
  • 45 edits in trunk/WebCore

2010-02-03 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed revert of r54259 as it seems to break chromium's unit tests.
The tests pass with r54257 but fail with r54260.
As r54258 and r54260 don't touch code, I'm reverting this change.

[V8] Generate toV8 conversion helpers, a la JSC bindings.
​https://bugs.webkit.org/show_bug.cgi?id=32563

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent):
  • bindings/v8/V8Collection.h: (WebCore::getV8Object): (WebCore::toNativeCollection): (WebCore::getNamedPropertyOfCollection): (WebCore::collectionNamedPropertyGetter): (WebCore::getIndexedPropertyOfCollection): (WebCore::collectionIndexedPropertyGetter): (WebCore::nodeCollectionIndexedPropertyEnumerator): (WebCore::collectionIndexedPropertyEnumerator): (WebCore::collectionStringOrNullIndexedPropertyGetter): (WebCore::collectionStringIndexedPropertyGetter): (WebCore::setCollectionIndexedGetter): (WebCore::setCollectionNamedGetter): (WebCore::setCollectionStringOrNullIndexedGetter): (WebCore::setCollectionStringIndexedGetter):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::downcastSVGPathSeg): (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toV8Object): (WebCore::V8CanvasRenderingContext2D::createPatternCallback):
  • bindings/v8/custom/V8CustomPositionCallback.cpp: (WebCore::V8CustomPositionCallback::handleEvent):
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp: (WebCore::V8CustomPositionErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp: (WebCore::V8CustomSQLStatementCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: (WebCore::V8CustomSQLTransactionCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openCallback): (WebCore::V8DOMWindow::indexedPropertyGetter): (WebCore::V8DOMWindow::namedPropertyGetter):
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::evaluateCallback): (WebCore::V8Document::getCSSCanvasContextCallback): (WebCore::V8Document::implementationAccessorGetter):
  • bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::V8Document::locationAccessorGetter):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNodeNSCallback):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::V8Event::dataTransferAccessorGetter): (WebCore::V8Event::clipboardDataAccessorGetter):
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLAllCollection::callAsFunctionCallback):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::V8Custom::v8HTMLAudioElementConstructorCallback):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLCollection::callAsFunctionCallback):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorGetter):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::V8HTMLFormElement::indexedPropertyGetter): (WebCore::V8HTMLFormElement::namedPropertyGetter):
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: (WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::V8Custom::v8HTMLImageElementConstructorCallback):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::V8HTMLSelectElement::namedPropertyGetter): (WebCore::V8HTMLSelectElement::indexedPropertyGetter):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScript): (WebCore::V8InjectedScriptHost::nodeForIdCallback): (WebCore::V8InjectedScriptHost::databaseForIdCallback):
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::portsAccessorGetter):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::indexedPropertyGetter): (WebCore::V8NamedNodeMap::namedPropertyGetter):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::V8NodeList::namedPropertyGetter): (WebCore::V8NodeList::callAsFunctionCallback):
  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback):
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::V8SVGMatrix::multiplyCallback): (WebCore::V8SVGMatrix::inverseCallback): (WebCore::V8SVGMatrix::rotateFromVectorCallback):
  • bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::V8StyleSheetList::namedPropertyGetter):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8Object):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::V8XSLTProcessor::transformToFragmentCallback): (WebCore::V8XSLTProcessor::transformToDocumentCallback):
2:54 AM Changeset in webkit [54277] by eric@webkit.org
  • 13 edits
    2 copies
    1 move
    3 adds in trunk/WebCore

2010-02-03 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Start unforking debugger and profiler code.

Remove custom implementation of Console.
Add 'ScriptProfiler' and 'ScriptProfile' types.
Start migration to engine-neutral types in InspectorController.

​https://bugs.webkit.org/show_bug.cgi?id=34481

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSConsoleCustom.cpp:
  • bindings/js/ScriptProfile.h: Added.
  • bindings/js/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
  • bindings/js/ScriptProfiler.h: Added.
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptProfile.h: Added. (WebCore::ScriptProfile::create): (WebCore::ScriptProfile::~ScriptProfile): (WebCore::ScriptProfile::title): (WebCore::ScriptProfile::uid): (WebCore::ScriptProfile::ScriptProfile):
  • bindings/v8/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
  • bindings/v8/ScriptProfiler.h: Added.
  • bindings/v8/custom/V8ConsoleCustom.cpp: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::endGroup): (WebCore::InspectorController::show): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole): (WebCore::InspectorController::createProfileHeader): (WebCore::InspectorController::getCurrentUserInitiatedProfileName): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::specialPanelForJSName):
  • inspector/InspectorController.h: (WebCore::InspectorController::searchingForNodeInPage):
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
  • page/Console.h: (WebCore::): (WebCore::Console::create): (WebCore::Console::profiles):
  • page/Console.idl:
2:13 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
1:50 AM Changeset in webkit [54276] by mnaganov@chromium.org
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/committers.py

Add myself to commiters.py

12:11 AM Changeset in webkit [54275] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Barth.

http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
​https://bugs.webkit.org/show_bug.cgi?id=33349

  • platform/win/Skipped: http/tests/security/xss-DENIED-window-open-javascript-url.html skipped.

Feb 2, 2010:

10:56 PM Changeset in webkit [54274] by tkent@chromium.org
  • 11 edits in trunk

2010-02-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that changes for some constraint attributes doesn't
update validation CSS selectors.
​https://bugs.webkit.org/show_bug.cgi?id=31716

Add tests for maxLength changes and step changes.

  • fast/forms/input-live-pseudo-selectors-expected.txt:
  • fast/forms/resources/input-live-pseudo-selectors.js:
  • fast/forms/resources/textarea-live-pseudo-selectors.js:
  • fast/forms/textarea-live-pseudo-selectors-expected.txt:

2010-02-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that changes for some constraint attributes doesn't
update validation CSS selectors.
​https://bugs.webkit.org/show_bug.cgi?id=31716

  • Rename HTMLFormControlElement::updateValidity() to setNeedsValidityCheck()
  • Introduce HTMLFormControlElement::setNeedsWillValidate()
  • Introduce HTMLFormControlElement::m_hasName to make willValidate() work in parseMappedAttribute().
  • We need to call setNeedsValidityCheck() when HTMLInputElement::step or HTMLTextAreaElement::maxLength is changed.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::insertedIntoTree): (WebCore::HTMLFormControlElement::removedFromTree): (WebCore::HTMLFormControlElement::formDestroyed): (WebCore::HTMLFormControlElement::willValidate): Avoids function calls. (WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): (WebCore::HTMLFormControlElement::setNeedsValidityCheck):
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::disabled): Move the code from .cpp.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute): (WebCore::HTMLTextAreaElement::setValue):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
9:57 PM Changeset in webkit [54273] by rolandsteiner@chromium.org
  • 3 edits
    4 adds in trunk

Bug 34198 - Ruby text should not inherit line-height
(​https://bugs.webkit.org/show_bug.cgi?id=34198)

Reviewed by Adele Peterson.

Resetting line-height to 'normal' in the default UA style sheet.
Adding layout-test to check for this.

WebCore:

Test: fast/ruby/ruby-line-height.html

  • css/html.css:

LayoutTests:

  • fast/ruby/script-tests: Added.
  • fast/ruby/script-tests/ruby-line-height.js: Added.
  • fast/ruby/ruby-line-height-expected.txt: Added.
  • fast/ruby/ruby-line-height.html: Added.
9:22 PM Changeset in webkit [54272] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-02-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
​https://bugs.webkit.org/show_bug.cgi?id=34483

Add tests for datetime, datetime-local, month, time and week, and
merge existing tests into one test file.

  • fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-date.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-number.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-range.html: Removed.
  • fast/forms/ValidityState-rangeOverflow.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-date.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow.html: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added.

2010-02-02 James Robinson <​jamesr@chromium.org>

Reviewed by Dmitry Titov.

Add a null check for image, which might be NULL if tileSize is empty
​https://bugs.webkit.org/show_bug.cgi?id=34510

Test: fast/gradients/crash-on-1px-border.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
8:21 PM Changeset in webkit [54271] by tkent@chromium.org
  • 3 edits
    2 moves
    4 adds
    16 deletes in trunk

2010-02-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
​https://bugs.webkit.org/show_bug.cgi?id=34483

Add tests for datetime, datetime-local, month, time and week, and
merge existing tests into one test file.

  • fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-date.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-number.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-range.html: Removed.
  • fast/forms/ValidityState-rangeOverflow.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-date.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow.html: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added.

2010-02-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
​https://bugs.webkit.org/show_bug.cgi?id=34483

Tests: fast/forms/ValidityState-rangeOverflow.html

fast/forms/ValidityState-rangeUnderflow.html

  • html/HTMLInputElement.cpp: Defines the hard limits for the types as double values. (WebCore::HTMLInputElement::rangeUnderflow): Supports the types. (WebCore::HTMLInputElement::rangeOverflow): Supports the types. (WebCore::HTMLInputElement::minimum): Supports the types. (WebCore::HTMLInputElement::maximum): Supports the types.
8:20 PM Changeset in webkit [54270] by hamaji@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-02-02 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Implement WebFrameImpl::pageNumberForElementById
​https://bugs.webkit.org/show_bug.cgi?id=34471

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageNumberForElementById):
  • src/WebFrameImpl.h:
8:00 PM Changeset in webkit [54269] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after introduction of pageNumberForElementById.

7:42 PM Changeset in webkit [54268] by mrowe@apple.com
  • 5 edits in trunk/WebKit/mac

Roll out r54252.

The method it deleted is in fact used, and its deletion resulted in plug-ins that use accelerated compositing not being drawn.

5:36 PM Changeset in webkit [54267] by ukai@chromium.org
  • 5 edits
    2 adds in trunk

2010-02-02 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket wrapper can be collected even if events are pending
​https://bugs.webkit.org/show_bug.cgi?id=34014

  • websocket/tests/websocket-pending-activity-expected.txt: Added.
  • websocket/tests/websocket-pending-activity.html: Added.

2010-02-02 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket set pending activity to avoid unexpected GC.
​https://bugs.webkit.org/show_bug.cgi?id=34014

Test: websocket/tests/websocket-pending-activity.html

  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect): set pending activity until it receives didClose. (WebCore::WebSocket::contextDestroyed): check socket is already closed. (WebCore::WebSocket::stop): close the connection and unset pending activity when it stops. (WebCore::WebSocket::didClose): unset pending activity.
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData): protect this while it processes received data.
5:21 PM Changeset in webkit [54266] by kov@webkit.org
  • 3 edits
    2 deletes in trunk/WebCore

2010-02-02 Gustavo Noronha Silva <Gustavo Noronha Silva>

No review, rolling out r54261.
​http://trac.webkit.org/changeset/54261
​https://bugs.webkit.org/show_bug.cgi?id=34435

Causes crashes on release builds

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
  • platform/gtk/GOwnPtrGtk.cpp: Removed.
  • platform/gtk/GOwnPtrGtk.h: Removed.
5:13 PM Changeset in webkit [54265] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-02-02 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Crash in CollectorBitmap::get at nbcolympics.com
​https://bugs.webkit.org/show_bug.cgi?id=34504

This was caused by the use of m_offset to determine the offset of
a new property into the property storage. This patch corrects
the effected cases by incorporating the anonymous slot count. It
also removes the duplicate copy of anonymous slot count from the
property table as keeping this up to date merely increased the
chance of a mismatch. Finally I've added a large number of
assertions in an attempt to prevent such a bug from happening
again.

With the new assertions in place the existing anonymous slot tests
all fail without the m_offset fixes.

  • runtime/PropertyMapHashTable.h:
  • runtime/Structure.cpp: (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::removePropertyTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::removePropertyWithoutTransition): (JSC::Structure::copyPropertyTable): (JSC::Structure::get): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::insertIntoPropertyMapHashTable): (JSC::Structure::createPropertyMapHashTable): (JSC::Structure::rehashPropertyMapHashTable): (JSC::Structure::checkConsistency):
5:12 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
4:54 PM Changeset in webkit [54264] by levin@chromium.org
  • 2 edits in trunk/WebCore

2010-02-02 David Levin <​levin@chromium.org>

No review, rolling out r54245.
​http://trac.webkit.org/changeset/54245
​https://bugs.webkit.org/show_bug.cgi?id=34492

This patch seems to have broken thousands of chromium tests on
Windows (and since it was for chromium, I'm rolling it out).

  • dom/Element.cpp: (WebCore::Element::baseURI):
4:25 PM Changeset in webkit [54263] by sfalken@apple.com
  • 8 edits
    1 add in trunk

2010-02-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

Copyright year updating for Windows version resources should be automatic
​https://bugs.webkit.org/show_bug.cgi?id=34503

2010-02-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

Copyright year updating for Windows version resources should be automatic
​https://bugs.webkit.org/show_bug.cgi?id=34503

  • win/tools/scripts/auto-version.sh:

2010-02-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

Copyright year updating for Windows version resources should be automatic
​https://bugs.webkit.org/show_bug.cgi?id=34503

  • WebKit.vcproj/WebKit.rc:

2010-02-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

Copyright year updating for Windows version resources should be automatic
​https://bugs.webkit.org/show_bug.cgi?id=34503

  • WebCore.vcproj/QTMovieWin.rc:
4:05 PM Changeset in webkit [54262] by Dimitri Glazkov
  • 4 edits in trunk/WebCore

2010-02-02 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r54257.
​http://trac.webkit.org/changeset/54257
​https://bugs.webkit.org/show_bug.cgi?id=34491

[Chromium] broke thousands of Win tests and a few of Linux tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::beginTransparencyLayer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::applyAntiAliasedClipPaths):
  • platform/graphics/skia/PlatformContextSkia.h:
4:03 PM Changeset in webkit [54261] by eric@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2010-02-02 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] libsoup critical warning in media player http cookies injection code
​https://bugs.webkit.org/show_bug.cgi?id=34435

Fixed the critical warning and refactored the
User-Agent/Referer/cookies injection code, in that order. Previous
order (cookies first) was wrong because if cookies injection could
not be done neither the User-Agent not Referer were injected. Also
started a non-JSC-specific, gtk-specific GOwnPtr module.

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
  • platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::SoupURI): (WTF::GstElement):
  • platform/gtk/GOwnPtrGtk.h: Added.
3:37 PM Changeset in webkit [54260] by kov@webkit.org
  • 5 edits in trunk

2010-02-02 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

Bump version, and adjust library versioning for 1.1.20.

  • configure.ac:

WebKit/gtk

2010-02-02 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

Changes in 1.1.20, and documentation control files update.

  • NEWS:
  • docs/webkitgtk-docs.sgml:
3:23 PM Changeset in webkit [54259] by Nate Chapin
  • 45 edits in trunk/WebCore

2010-02-02 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.


​https://bugs.webkit.org/show_bug.cgi?id=32563

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptObject.cpp:
  • bindings/v8/V8AbstractEventListener.cpp:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8NodeFilterCondition.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8CustomPositionCallback.cpp:
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8DocumentLocationCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8MessageEventCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NodeIteratorCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8SVGMatrixCustom.cpp:
  • bindings/v8/custom/V8StyleSheetListCustom.cpp:
  • bindings/v8/custom/V8TreeWalkerCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
3:16 PM Changeset in webkit [54258] by snej@chromium.org
  • 2 edits in trunk/WebKitSite

Clarified coding guidelines on wiki to allow indentation of _nested_ namespaces.
Reviewed by David Levin.
​https://bugs.webkit.org/show_bug.cgi?id=32137

3:06 PM Changeset in webkit [54257] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-02-02 Garret Kelly <​gdk@chromium.org>

Reviewed by David Levin.

When using the Skia graphics context, the beginTransparencyLayer call
currently creates a new layer, but does not keep the current
compositing mode for use when merging the created layer back onto the
rest of the context. This patch fixes that.
​https://bugs.webkit.org/show_bug.cgi?id=34491

fast/backgrounds/svg-as-mask.html is affected by this change in Chromium,
but not fixed. This is the first of a series of patches to fix it.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::beginTransparencyLayer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::beginTransparencyLayer):
  • platform/graphics/skia/PlatformContextSkia.h:
2:50 PM Changeset in webkit [54256] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-02 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument
​https://bugs.webkit.org/show_bug.cgi?id=34409

Platform guards for localtime_r are not needed because we already have
WTF::getLocalTime which does the same thing.

  • loader/FTPDirectoryDocument.cpp: (WebCore::processFileDateString):
  • loader/FTPDirectoryParser.cpp: (WebCore::gmtimeQt):
2:34 PM Changeset in webkit [54255] by eric@webkit.org
  • 1 edit
    2 adds in trunk/JavaScriptCore

2010-02-02 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add dummy main thread functions
​https://bugs.webkit.org/show_bug.cgi?id=33569

Add dummy initializeMainThreadPlatform and
scheduleDispatchFunctionsOnMainThread.

  • wtf/brew/MainThreadBrew.cpp: Added. (WTF::initializeMainThreadPlatform): (WTF::scheduleDispatchFunctionsOnMainThread):
2:29 PM Changeset in webkit [54254] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-02 Eric Seidel <​eric@webkit.org>

Reviewed by Gustavo Noronha Silva.

http/tests/incremental/split-hex-entities.pl timed out on Gtk Linux 32-bit Debug Bot
​https://bugs.webkit.org/show_bug.cgi?id=33445

  • platform/gtk/Skipped: Skip this test to keep the bots green until someone with Gtk knowledge can examine why it intermittently times out.
2:18 PM Changeset in webkit [54253] by eric@webkit.org
  • 4 edits
    1 copy
    3 moves
    1 add in trunk/LayoutTests

2010-02-02 Hayato Ito <​hayato@chromium.org>

Reviewed by Darin Adler.

Move misplaced JS files to the proper location.

​https://bugs.webkit.org/show_bug.cgi?id=34256

  • fast/events/script-tests/basic-touch-events.js: Removed.
  • fast/events/script-tests/create-touch-event.js: Removed.
  • fast/events/script-tests/send-oncancel-event.js: Removed.
  • fast/events/touch/basic-touch-events.html:
  • fast/events/touch/create-touch-event.html:
  • fast/events/touch/script-tests: Added.
  • fast/events/touch/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/events/script-tests/TEMPLATE.html.
  • fast/events/touch/script-tests/basic-touch-events.js: Copied from LayoutTests/fast/events/script-tests/basic-touch-events.js.
  • fast/events/touch/script-tests/create-touch-event.js: Copied from LayoutTests/fast/events/script-tests/create-touch-event.js.
  • fast/events/touch/script-tests/send-oncancel-event.js: Copied from LayoutTests/fast/events/script-tests/send-oncancel-event.js.
  • fast/events/touch/send-oncancel-event.html:
2:00 PM Changeset in webkit [54252] by ap@apple.com
  • 5 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=34502
Unused method pluginLayer in Netscape plug-in views

  • Plugins/Hosted/WebHostedNetscapePluginView.h:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: Removed the method.
1:23 PM Changeset in webkit [54251] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-4-branch

Merge r54242.

1:09 PM Changeset in webkit [54250] by Adam Roben
  • 2 edits in trunk/WebCore

Copy WebCore's bindings generation scripts to the PrivateHeaders directory on Mac

This will allow other projects to use these scripts.

Fixes <​http://webkit.org/b/34498>.

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj: Added the bindings generation

scripst to the Copy Headers phase, and marked them as Private.

12:55 PM Changeset in webkit [54249] by Adam Roben
  • 3 edits in trunk/WebCore

Copy WebCore's bindings generation scripts to a more sensible location

Part of Bug 34496: Clean up WebCore's IDL/script copying
<​https://bugs.webkit.org/show_bug.cgi?id=34496>

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/WebCore.make:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

Instead of copying to obj/WebKit/DOMInterfaces, copy to obj/WebCore/scripts.

12:54 PM Changeset in webkit [54248] by Adam Roben
  • 2 edits
    2 moves in trunk/WebCore

Rename the scripts used to copy WebCore's bindings generation scripts

Part of Bug 34496: Clean up WebCore's IDL/script copying
<​https://bugs.webkit.org/show_bug.cgi?id=34496>

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/MigrateScripts: Renamed from WebCore/WebCore.vcproj/MigrateIDLAndScripts.
  • WebCore.vcproj/migrate-scripts.sh: Renamed from WebCore/WebCore.vcproj/migrate-idls.sh.
  • WebCore.vcproj/WebCoreGenerated.vcproj: Updated for renames.
12:54 PM Changeset in webkit [54247] by Adam Roben
  • 2 edits in trunk/WebCore

Stop copying IDL files into $(WebKitOutputDir)

No one uses these anymore (as of r52921).

Part of Bug 34496: Clean up WebCore's IDL/script copying
<​https://bugs.webkit.org/show_bug.cgi?id=34496>

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/MigrateIDLAndScripts: Don't copy the IDL files

anymore. Keep copying the scripts, though, since other projects
(outside of the WebKit repository) do use those.

12:54 PM Changeset in webkit [54246] by Adam Roben
  • 2 edits in trunk/WebKit/win

Stop copying WebCore's IDL files from SRCROOT to OBJROOT

WebKit doesn't use these anymore (as of r52921).

Part of Bug 34496: Clean up WebCore's IDL/script copying
<​https://bugs.webkit.org/show_bug.cgi?id=34496>

Reviewed by Steve Falkenburg.

  • WebKit.vcproj/WebKit.make:
12:04 PM Changeset in webkit [54245] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-02 Bryan Yeung <bryeung@bryeung-chrome.(none)>

Reviewed by Darin Adler.

Avoid using an invalidated KURL object in baseURI.

​https://bugs.webkit.org/show_bug.cgi?id=34492

This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg

  • dom/Element.cpp: (WebCore::Element::baseURI):
11:47 AM Changeset in webkit [54244] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-02 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Add using WTF::getLocalTime to CurrentTime.h
​https://bugs.webkit.org/show_bug.cgi?id=34493

  • wtf/CurrentTime.h:
10:16 AM Changeset in webkit [54243] by chang.shu@nokia.com
  • 2 edits in trunk/WebKitTools

Add myself to list of committers.

10:00 AM Changeset in webkit [54242] by ap@apple.com
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=34076
<rdar://problem/7594601> Crash in mangleme in WebCore::Element::getAttribute

Test: fast/forms/misplaced-img-form-registration.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerImgElement): Assert that the same image isn't added to vector again. (WebCore::HTMLFormElement::removeImgElement): Similarly, assert that we're removing something that's actually registered.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): If parser fails to insert the image element, then there will be no removed from tree notification either, need to unregister right away.
9:19 AM Changeset in webkit [54241] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Do not use a proxy widget for the QComboBox on Maemo 5, as it
is not working properly and it is not needed at all, as the
comboboxes comes up in their full width on the screen and
do not depend on view.

Reviewed by Ariya Hidayat.

  • WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopup::show):

9:08 AM Changeset in webkit [54240] by apavlov@chromium.org
  • 5 edits in trunk/WebCore

2010-02-02 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Eliminate some of the platform flavor-specific stylesheet selectors

Extract OS version into WebInspector.platformFlavor
​https://bugs.webkit.org/show_bug.cgi?id=34469

  • inspector/front-end/InspectorBackendStub.js:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.platform):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.pendingDispatches.0.URLRegExp.i.get platform): (WebInspector.get platformFlavor): (WebInspector._detectPlatformFlavor): (WebInspector.loaded): (WebInspector.toolbarDragStart): (WebInspector.isMac):
8:35 AM Changeset in webkit [54239] by Martin Robinson
  • 2 edits in trunk/WebKitLibraries

2010-02-02 Martin Robinson <Martin Robinson>

Unreviewed build fix.

The WinCairo build requires this script to be executable.

  • win/tools/scripts/feature-defines.sh: Added property svn:executable.
7:48 AM Changeset in webkit [54238] by Adam Roben
  • 2 edits in trunk/LayoutTests

Stop skipping some tests that were failing due to buggy versions of CFNetwork

Rubber-stamped by Eric Carlson.

  • platform/win/Skipped:
7:45 AM Changeset in webkit [54237] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2010-02-02 Steve Block <​steveblock@google.com>

Reviewed by Ariya Hidayat.

Adds utility functions for converting between JavaInstance and NPAPI types
​https://bugs.webkit.org/show_bug.cgi?id=34468

This is required by Android for injecting objects into V8 JavaScript.

No new tests, added utility functions only.

  • Android.v8bindings.mk: Modified. Added JavaNPObjectV8.cpp
  • bridge/jni/v8/JavaNPObjectV8.cpp: Added. (JSC::Bindings::AllocJavaNPObject): (JSC::Bindings::FreeJavaNPObject): (JSC::Bindings::): (JSC::Bindings::JavaInstanceToNPObject): (JSC::Bindings::ExtractJavaInstance): (JSC::Bindings::JavaNPObjectHasMethod): (JSC::Bindings::JavaNPObjectInvoke): (JSC::Bindings::JavaNPObjectHasProperty): (JSC::Bindings::JavaNPObjectGetProperty):
  • bridge/jni/v8/JavaNPObjectV8.h: Added.
7:42 AM QtWebKitJSCapp edited by siddharth.mathur@nokia.com
(diff)
7:35 AM QtWebKitJSCapp created by siddharth.mathur@nokia.com
7:35 AM Changeset in webkit [54236] by jberlin@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-02-02 Jessie Berlin <​jberlin@webkit.org>

Rubber Stamped by Holger Freyther.

[Qt] Fix style issue identified in bug:
​https://bugs.webkit.org/show_bug.cgi?id=34329

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::InspectorClientWebPage): Fix indentation.
7:31 AM QtWebKit edited by siddharth.mathur@nokia.com
added new page for jsc.exe (diff)
7:29 AM Changeset in webkit [54235] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-02 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Symbian plugins include a wrong header file for QPixmap
​https://bugs.webkit.org/show_bug.cgi?id=34475

  • plugins/symbian/PluginViewSymbian.cpp:
7:28 AM Changeset in webkit [54234] by Chris Jerdonek
  • 4 edits
    2 adds in trunk/WebKitTools

2010-02-02 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Moved filter-related check-webkit-style code into a separate
filter module.

​https://bugs.webkit.org/show_bug.cgi?id=34408

This is preparatory refactoring for Bug 33684, which will allow
file and folder-specific filter rules.

  • Scripts/webkitpy/style/checker.py:
    • Removed CategoryFilter class (moved to filter.py).
  • Scripts/webkitpy/style/checker_unittest.py:
    • Removed CategoryFilter unit tests (moved to filter_unittest.py).
  • Scripts/webkitpy/style/filter.py: Added.
    • Added CategoryFilter class (moved from checker.py).
  • Scripts/webkitpy/style/filter_unittest.py: Added.
    • Added CategoryFilter unit tests (moved from checker_unittest.py).
  • Scripts/webkitpy/style/unittests.py:
    • Added reference to filter_unittest.py.
7:25 AM Changeset in webkit [54233] by jberlin@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-02-01 Jessie Berlin <​jberlin@webkit.org>

Reviewed by Holger Freyther.

[Qt] Enable inspecting the Web Inspector in QtLauncher

​https://bugs.webkit.org/show_bug.cgi?id=34329

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::InspectorClientWebPage): Allow the DeveloperExtrasEnabled setting to default to true for the page containing the Web Inspector.
6:22 AM Changeset in webkit [54232] by yurys@chromium.org
  • 2 edits
    18 adds in trunk/WebKit/chromium

2010-02-02 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Upstream DevTools code.

​https://bugs.webkit.org/show_bug.cgi?id=34326

  • WebKit.gyp:
  • src/APUAgentDelegate.h: Added.
  • src/BoundObject.cpp: Added. (WebKit::BoundObject::BoundObject): (WebKit::BoundObject::~BoundObject): (WebKit::BoundObject::addProtoFunction): (WebKit::BoundObject::build):
  • src/BoundObject.h: Added.
  • src/DebuggerAgent.h: Added.
  • src/DebuggerAgentImpl.cpp: Added. (WebKit::DebuggerAgentImpl::DebuggerAgentImpl): (WebKit::DebuggerAgentImpl::~DebuggerAgentImpl): (WebKit::DebuggerAgentImpl::getContextId): (WebKit::DebuggerAgentImpl::debuggerOutput): (WebKit::DebuggerAgentImpl::createUtilityContext): (WebKit::DebuggerAgentImpl::executeUtilityFunction): (WebKit::DebuggerAgentImpl::executeVoidJavaScript): (WebKit::DebuggerAgentImpl::page):
  • src/DebuggerAgentImpl.h: Added. (WebKit::DebuggerAgentImpl::setAutoContinueOnException): (WebKit::DebuggerAgentImpl::autoContinueOnException): (WebKit::DebuggerAgentImpl::webdevtoolsAgent): (WebKit::DebuggerAgentImpl::webView):
  • src/DebuggerAgentManager.cpp: Added. (WebKit::DebuggerAgentManager::debugHostDispatchHandler): (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::onV8DebugMessage): (WebKit::DebuggerAgentManager::pauseScript): (WebKit::DebuggerAgentManager::executeDebuggerCommand): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler): (WebKit::DebuggerAgentManager::setHostId): (WebKit::DebuggerAgentManager::onWebViewClosed): (WebKit::DebuggerAgentManager::onNavigate): (WebKit::DebuggerAgentManager::sendCommandToV8): (WebKit::DebuggerAgentManager::sendContinueCommandToV8): (WebKit::DebuggerAgentManager::findAgentForCurrentV8Context): (WebKit::DebuggerAgentManager::debuggerAgentForHostId):
  • src/DebuggerAgentManager.h: Added. (WebKit::DebuggerAgentManager::UtilityContextScope::UtilityContextScope): (WebKit::DebuggerAgentManager::UtilityContextScope::~UtilityContextScope):
  • src/DevToolsRPC.h: Added. (WebKit::): (WebKit::DevToolsRPC::Delegate::Delegate): (WebKit::DevToolsRPC::Delegate::~Delegate): (WebKit::DevToolsRPC::DevToolsRPC): (WebKit::DevToolsRPC::~DevToolsRPC): (WebKit::DevToolsRPC::sendRpcMessage):
  • src/DevToolsRPCJS.h: Added.
  • src/ProfilerAgent.h: Added.
  • src/ProfilerAgentImpl.cpp: Added. (WebKit::ProfilerAgentImpl::getActiveProfilerModules): (WebKit::ProfilerAgentImpl::getLogLines):
  • src/ProfilerAgentImpl.h: Added. (WebKit::ProfilerAgentImpl::ProfilerAgentImpl): (WebKit::ProfilerAgentImpl::~ProfilerAgentImpl):
  • src/ToolsAgent.h: Added.
  • src/WebDevToolsAgentImpl.cpp: Added. (WebKit::): (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::disposeUtilityContext): (WebKit::WebDevToolsAgentImpl::unhideResourcesPanelIfNecessary): (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::didNavigate): (WebKit::WebDevToolsAgentImpl::didCommitProvisionalLoad): (WebKit::WebDevToolsAgentImpl::didClearWindowObject): (WebKit::WebDevToolsAgentImpl::forceRepaint): (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController): (WebKit::WebDevToolsAgentImpl::dispatchOnInjectedScript): (WebKit::WebDevToolsAgentImpl::executeVoidJavaScript): (WebKit::WebDevToolsAgentImpl::dispatchMessageFromFrontend): (WebKit::WebDevToolsAgentImpl::inspectElementAt): (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled): (WebKit::WebDevToolsAgentImpl::sendRpcMessage): (WebKit::WebDevToolsAgentImpl::compileUtilityScripts): (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost): (WebKit::WebDevToolsAgentImpl::createInspectorBackendV8Wrapper): (WebKit::WebDevToolsAgentImpl::resetInspectorFrontendProxy): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled): (WebKit::WebDevToolsAgentImpl::jsDispatchOnClient): (WebKit::WebDevToolsAgentImpl::jsDispatchToApu): (WebKit::WebDevToolsAgentImpl::jsEvaluateOnSelf): (WebKit::WebDevToolsAgentImpl::jsOnRuntimeFeatureStateChanged): (WebKit::WebDevToolsAgentImpl::inspectorController): (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest): (WebKit::WebDevToolsAgentImpl::willSendRequest): (WebKit::WebDevToolsAgentImpl::didReceiveData): (WebKit::WebDevToolsAgentImpl::didReceiveResponse): (WebKit::WebDevToolsAgentImpl::didFinishLoading): (WebKit::WebDevToolsAgentImpl::didFailLoading): (WebKit::WebDevToolsAgentImpl::evaluateInWebInspector): (WebKit::WebDevToolsAgentImpl::setTimelineProfilingEnabled): (WebKit::WebDevToolsAgent::create): (WebKit::WebDevToolsAgent::executeDebuggerCommand): (WebKit::WebDevToolsAgent::debuggerPauseScript): (WebKit::WebDevToolsAgent::setMessageLoopDispatchHandler): (WebKit::WebDevToolsAgent::dispatchMessageFromFrontendOnIOThread):
  • src/WebDevToolsAgentImpl.h: Added. (WebKit::WebDevToolsAgentImpl::hostId):
  • src/WebDevToolsFrontendImpl.cpp: Added. (WebKit::ToV8String): (WebKit::WebDevToolsFrontend::create): (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::dispatchMessageFromAgent): (WebKit::WebDevToolsFrontendImpl::executeScript): (WebKit::WebDevToolsFrontendImpl::dispatchOnWebInspector): (WebKit::WebDevToolsFrontendImpl::sendRpcMessage): (WebKit::WebDevToolsFrontendImpl::contextMenuItemSelected): (WebKit::WebDevToolsFrontendImpl::contextMenuCleared): (WebKit::WebDevToolsFrontendImpl::jsLoaded): (WebKit::WebDevToolsFrontendImpl::jsPlatform): (WebKit::WebDevToolsFrontendImpl::jsPort): (WebKit::WebDevToolsFrontendImpl::jsCopyText): (WebKit::WebDevToolsFrontendImpl::jsActivateWindow): (WebKit::WebDevToolsFrontendImpl::jsCloseWindow): (WebKit::WebDevToolsFrontendImpl::jsDockWindow): (WebKit::WebDevToolsFrontendImpl::jsUndockWindow): (WebKit::WebDevToolsFrontendImpl::jsLocalizedStringsURL): (WebKit::WebDevToolsFrontendImpl::jsHiddenPanels): (WebKit::WebDevToolsFrontendImpl::jsDebuggerCommand): (WebKit::WebDevToolsFrontendImpl::jsSetting): (WebKit::WebDevToolsFrontendImpl::jsSetSetting): (WebKit::WebDevToolsFrontendImpl::jsDebuggerPauseScript): (WebKit::WebDevToolsFrontendImpl::jsWindowUnloading): (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
  • src/WebDevToolsFrontendImpl.h: Added. (WebKit::WebDevToolsFrontendImpl::MenuProvider::create): (WebKit::WebDevToolsFrontendImpl::MenuProvider::~MenuProvider): (WebKit::WebDevToolsFrontendImpl::MenuProvider::disconnect): (WebKit::WebDevToolsFrontendImpl::MenuProvider::populateContextMenu): (WebKit::WebDevToolsFrontendImpl::MenuProvider::contextMenuItemSelected): (WebKit::WebDevToolsFrontendImpl::MenuProvider::contextMenuCleared): (WebKit::WebDevToolsFrontendImpl::MenuProvider::MenuProvider):
6:20 AM Nightly Builds edited by Adam Roben
(diff)
5:59 AM Changeset in webkit [54231] by pfeldman@chromium.org
  • 11 edits in trunk/WebCore

2010-02-02 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: URLs are not syntax-higlighted as links in source view.

This change enables linkifier in the NativeTextViewer. It adds
"linkify" and "a_node" parse states into the highlighter in order
to detect links and distinguish between resource and external ones.
Contains drive-by fix for the webkit-html-* styles and moves them to the
common location.

​https://bugs.webkit.org/show_bug.cgi?id=34364

  • inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer): (WebInspector.NativeTextViewer.prototype._createSpan): (WebInspector.NativeTextViewer.prototype._createLink): (WebInspector.NativeTextViewer.prototype._rewriteHref):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype._createEditorIfNeeded):
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._stringToken): (WebInspector.SourceHTMLTokenizer.prototype._attrValueTokenType): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspectorSyntaxHighlight.css:
5:32 AM Changeset in webkit [54230] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-02-02 Martin Robinson <​martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha Silva.

[GTK] When selection changes selections in other WebView are not collapsed
​https://bugs.webkit.org/show_bug.cgi?id=34043

Collapse the selection of a WebView even when the new selection owner is
a new WebView.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::clearClipboardContentsCallback): Only clear the DataObject we are setting is not the same as the one referenced in this callback. Use the same behavior for collapsing the selection. (WebKit::PasteboardHelperGtk::writeClipboardContents): Instead of recording a boolean record the actual data used while writing to the clipboard.
5:16 AM Changeset in webkit [54229] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-02 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Install libraries and headers in package builds
​https://bugs.webkit.org/show_bug.cgi?id=34325

Add the QtWebKit libraries to the installable items, except on
Symbian where the libraries are always linked in their final
destination.

Also include the headers generated by syncqt in the installation.

  • WebCore.pro:
4:59 AM Changeset in webkit [54228] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-02-02 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Display HTML tags verbatim in JS alert/confirm/prompt boxes

​https://bugs.webkit.org/show_bug.cgi?id=34429

  • Api/qwebpage.cpp: (QWebPage::javaScriptAlert): (QWebPage::javaScriptConfirm): (QWebPage::javaScriptPrompt):
4:43 AM Changeset in webkit [54227] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-02 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Dmitry Titov.

[V8] Raising an exception while setting timeout/interval from a detached frame
​https://bugs.webkit.org/show_bug.cgi?id=34453
This fixes the issue/failing test mentioned in Chromium bug:
​http://code.google.com/p/chromium/issues/detail?id=32671

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
4:27 AM Changeset in webkit [54226] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-02-02 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port Screen
​https://bugs.webkit.org/show_bug.cgi?id=34299

Get the screen size and depth from the main display bitmap.

  • platform/brew/ScreenBrew.cpp: Added. (WebCore::getDisplayInfo): (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
4:10 AM Changeset in webkit [54225] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-02-02 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port LocalizedStrings
​https://bugs.webkit.org/show_bug.cgi?id=34257

Port LocalizedStrings to BREWMP.

  • platform/brew/LocalizedStringsBrew.cpp: Added. (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::unknownFileSizeText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::imageTitle): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::AXButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXMenuListPopupActionVerb): (WebCore::AXMenuListActionVerb): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText): (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
3:56 AM Changeset in webkit [54224] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/frames/set-unloaded-frame-location.html timed out on Qt Linux Release Build Bot
​https://bugs.webkit.org/show_bug.cgi?id=33303

fast/frames/sandboxed-iframe-navigation-windowopen.html made fast/frames/set-unloaded-frame-location.html
time out, but now it works correctly, so we can unskip the test.

  • platform/qt/Skipped: fast/frames/sandboxed-iframe-navigation-windowopen.html unskipped.
3:54 AM Changeset in webkit [54223] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-02-02 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port systemBeep
​https://bugs.webkit.org/show_bug.cgi?id=33601

Implement systemBeep with IShell_Beep.

  • platform/brew/SoundBrew.cpp: Added. (WebCore::systemBeep):
3:38 AM Changeset in webkit [54222] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-02-02 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable a way to measure FPS in QGVLauncher
run QGVLauncher with --show-fps to see ongoing fps measurements
This is not meant as accurate FPS, but rather as a way to find
improvements/regressions
​https://bugs.webkit.org/show_bug.cgi?id=34450

  • QGVLauncher/main.cpp: (MainView::MainView): initialize FPS values (MainView::paintEvent): count a painted frame here (MainView::printFps): we print the fps with qDebug every 5 seconds.
3:07 AM Changeset in webkit [54221] by hamaji@chromium.org
  • 5 edits in trunk/WebCore

2010-02-02 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

[Win] Utilize PrintContext to share the printing code with other ports
​https://bugs.webkit.org/show_bug.cgi?id=34312

No new tests as this is just a small refactoring.

2:54 AM Changeset in webkit [54220] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-02 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add HAVE_XXX definitions
​https://bugs.webkit.org/show_bug.cgi?id=34414

Add HAVE_ERRNO_H=1

  • wtf/Platform.h:
2:32 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
2:27 AM Changeset in webkit [54219] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-02-02 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add conversions between IntPoint and AEEPoint
​https://bugs.webkit.org/show_bug.cgi?id=34194

Make it easy to convert between IntPoint and AEEPoint.

  • platform/graphics/IntPoint.h:
  • platform/graphics/brew/IntPointBrew.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator AEEPoint):
1:58 AM Changeset in webkit [54218] by steveblock@google.com
  • 2 edits in trunk/WebCore

Adds virtual destructors for AbstractWeakReferenceMap and AbstractWeakReferenceMap::Visitor
​https://bugs.webkit.org/show_bug.cgi?id=34434

Reviewed by Adam Barth.

No new tests, build fix only.

  • bindings/v8/V8DOMMap.h: Modified.

(WebCore::AbstractWeakReferenceMap::~AbstractWeakReferenceMap): Added.
(WebCore::AbstractWeakReferenceMap::Visitor::~Visitor): Added.

1:53 AM WebKit Team edited by alex
Committer since last week (diff)
1:46 AM Changeset in webkit [54217] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-02 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Don't define HAVE_TM_GMTOFF, HAVE_TM_ZONE and HAVE_TIMEGM
​https://bugs.webkit.org/show_bug.cgi?id=34388

BREWMP does not have these features.

  • wtf/Platform.h:
1:18 AM Changeset in webkit [54216] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-02 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Define WTF_PLATFORM_BREWMP=1 when BUILDING_BREWMP is defined
​https://bugs.webkit.org/show_bug.cgi?id=34386

Define WTF_PLATFORM_BREWMP=1 so that PLATFORM(BREWMP) guard can be used.

  • wtf/Platform.h:
12:52 AM Changeset in webkit [54215] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-02-02 Avi Drissman <​avi@chromium.org>

Reviewed by Eric Seidel.

Sync up Chromium Mac render theme to Mac render theme
​https://bugs.webkit.org/show_bug.cgi?id=34340

Covered by existing layout tests.

  • platform/chromium/ThemeChromiumMac.mm: (WebCore::updateStates): (WebCore::checkbox): (WebCore::paintCheckbox): (WebCore::radio): (WebCore::paintRadio): (WebCore::listButtonSizes): (WebCore::setupButtonCell): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeChromiumMac::controlSize): (WebCore::ThemeChromiumMac::minimumControlSize): (WebCore::ThemeChromiumMac::controlBorder): (WebCore::ThemeChromiumMac::paint):
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]): (WebCore::convertNSColorToColor): (WebCore::RenderThemeChromiumMac::systemColor): (WebCore::RenderThemeChromiumMac::isControlStyled): (WebCore::RenderThemeChromiumMac::adjustRepaintRect): (WebCore::RenderThemeChromiumMac::convertToPaintingRect): (WebCore::RenderThemeChromiumMac::paintCapsLockIndicator): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::RenderThemeChromiumMac::paintMenuListButton): (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): (WebCore::RenderThemeChromiumMac::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumMac::paintSliderTrack): (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintSearchField): (WebCore::RenderThemeChromiumMac::setSearchFieldSize): (WebCore::RenderThemeChromiumMac::adjustSearchFieldStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::RenderThemeChromiumMac::popupButton): (WebCore::RenderThemeChromiumMac::sliderThumbHorizontal): (WebCore::RenderThemeChromiumMac::sliderThumbVertical):
12:52 AM Changeset in webkit [54214] by jorlow@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-02-01 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add WebSecurityOrigin::createFromString factory
​https://bugs.webkit.org/show_bug.cgi?id=34460

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::createFromString):
12:35 AM Changeset in webkit [54213] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-02-02 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port Logging
​https://bugs.webkit.org/show_bug.cgi?id=34300

Log calls to notImplemented() by default.

  • platform/brew/LoggingBrew.cpp: Added. (WebCore::InitializeLoggingChannelsIfNecessary):
12:25 AM Changeset in webkit [54212] by tkent@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-02-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Should not select a word on right-click.
​https://bugs.webkit.org/show_bug.cgi?id=33364

For non-Mac platforms, do not select a word around the caret when
a context menu is opening. This behavior is not common in non-Mac
platforms, and it prevents pasting with a context menu.

In order that the spell checker works without the selection, we
introduce WebFrame::selectWordAroundCaret(). We can replace a word
around the caret with selectWordAroundCaret() + replaceSelection().

  • public/WebFrame.h: Add pure selectWordAroundCaret() declaration.
  • src/ContextMenuClientImpl.cpp: (WebKit::selectMisspelledWord): Move word-selection code to WebFrameImpl::selectWordAroundPosition(), and clear the selection on non-Mac.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundPosition): (WebKit::WebFrameImpl::selectWordAroundCaret):
  • src/WebFrameImpl.h: Add selectWordAroundCaret() declaration.
12:19 AM Changeset in webkit [54211] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-02-02 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port FileChooser
​https://bugs.webkit.org/show_bug.cgi?id=34261

Port FileChooser to BREWMP.

  • platform/brew/FileChooserBrew.cpp: Added. (WebCore::FileChooser::basenameForWidth):
Note: See TracTimeline for information about the timeline view.