⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 4, 2010:

11:45 PM Changeset in webkit [54412] by vestbo@webkit.org
  • 2 edits in trunk

[Qt] Make 'make -f Makefile.DerivedSources qmake' work

Reviewed by Lars Knoll.

Previously this target ended up generating a file named
Makefile.DerivedSources.DerivedSources, and so on.

  • DerivedSources.pro:
11:34 PM Changeset in webkit [54411] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Rubber-stamped by Dan Bernstein.

Fix the ability to #include <WebKit/DOMFile.h>.

  • MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it.
11:18 PM Changeset in webkit [54410] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebKit/chromium

2010-02-04 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Fisher.

Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin
​https://bugs.webkit.org/show_bug.cgi?id=34509

Resubmit: The previous commit (r54333) was rolled back.

  • WebKit.gyp:
  • tests/TransparencyWinTest.cpp: Added. (WebCore::RECTToFloatRect): (WebCore::drawNativeRect): (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::operator<<): (WebCore::TEST):
  • tests/UniscribeHelperTest.cpp: Added. (WebCore::UniscribeTest::UniscribeTest): (WebCore::UniscribeTest::MakeFont): (WebCore::UniscribeTest::SetUp): (WebCore::UniscribeTest::TearDown): (TEST_F):
10:22 PM Changeset in webkit [54409] by mrowe@apple.com
  • 10 edits
    1 move in tags/Safari-533.0.1

Merge r54405.

10:22 PM Changeset in webkit [54408] by mrowe@apple.com
  • 4 edits in tags/Safari-533.0.1

Versioning.

10:20 PM Changeset in webkit [54407] by mrowe@apple.com
  • 1 copy in tags/Safari-533.0.1

New tag.

10:15 PM Changeset in webkit [54406] by ukai@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2010-02-04 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

should not crash when document opened websocket is unloaded
​https://bugs.webkit.org/show_bug.cgi?id=34562

  • websocket/tests/close-on-unload-and-force-gc-expected.txt: Added.
  • websocket/tests/close-on-unload-and-force-gc.html: Added.
  • websocket/tests/close-on-unload-reference-in-parent-expected.txt: Added.
  • websocket/tests/close-on-unload-reference-in-parent.html: Added.
  • websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html: Added.
10:13 PM Changeset in webkit [54405] by mrowe@apple.com
  • 10 edits
    1 move in trunk

Build fix. Remove a symbol corresponding to an inline function from the linker export
file to prevent a weak external failure.

Reviewed by Timothy Hatcher.

JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj: Accommodate rename of script.

JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj: Accommodate rename of script.

WebCore:

  • WebCore.base.exp: Remove symbol.
  • WebCore.xcodeproj/project.pbxproj: Accommodate rename of script.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Accommodate rename of script.

WebKitTools:

  • Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.

Teach the script how to detect weak external symbols so that these errors can be caught immediately
in the future.

9:59 PM Changeset in webkit [54404] by ukai@chromium.org
  • 3 edits in trunk/LayoutTests

2010-02-04 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Shinichiro Hamaji.

websocket/tests/close-on-unload.html failed on Mac Tiger
​https://bugs.webkit.org/show_bug.cgi?id=34563

  • platform/mac-tiger/Skipped: remove websocket/tests/close-on-unload*.html
  • websocket/tests/close-on-unload_wsh.py: use dict instead of set.
9:33 PM Changeset in webkit [54403] by dbates@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-04 Daniel Bates <​dbates@webkit.org>

[Qt] Unreviewed, build fix for Qt bot.

  • runtime/JSStringBuilder.h: Changed #include <X.h> notation #include "X.h".
7:53 PM Changeset in webkit [54402] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix: export a header.

7:47 PM Changeset in webkit [54401] by ggaren@apple.com
  • 1 edit
    1 add in trunk/WebCore

Build fix: Added a forwarding header.

  • ForwardingHeaders/runtime/WeakGCPtr.h: Added.
7:39 PM Changeset in webkit [54400] by ggaren@apple.com
  • 21 edits
    2 adds in trunk

WebCore: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
​https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>

Reviewed by Alexey Proskuryakov and Darin Adler.

There were two bugs here:

  1. A stale wrapper would invalidate a node's event listeners, even if

the node had a fresh wrapper keeping it alive.

The fix for this is for an event listener to keep a WeakGCPtr back-pointer
to the wrapper it expects to mark it. The wrapper destructor checks this
back-pointer, and only invalidates the event listener in the case of a match.

  1. Conversely, a stale wrapper would not invalidate a node's event

listeners soon enough, if its destructor didn't have a chance to run
before an event fired on the node. (This can only happen in cases where
we've made some other error and failed to mark a wrapper that was circuitously
observable in the DOM. But we know we have edge case bugs like this, and
we don't want them to be crashes.)

The fix for this is to check the wrapper back-pointer before firing the
event listener. As long as the the wrapper back-pointer is not null,
it's safe to fire the listener.

  • ForwardingHeaders/runtime/WeakGCPtr.h: Added. Appease build gods.
  • bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

  • bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::markChildren):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::initializeJSFunction):
(WebCore::JSEventListener::invalidateJSFunction):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::create):
(WebCore::JSEventListener::isolatedWorld):
(WebCore::JSEventListener::wrapper):
(WebCore::JSEventListener::setWrapper):
(WebCore::JSEventListener::jsFunction):
(WebCore::createJSAttributeEventListener): Implemented the back-pointer
described above. Refactored the jsFunction() accessor to return 0 if
the wrapper back-pointer is 0.

  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSLazyEventListener.h:

(WebCore::JSLazyEventListener::create):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::markChildren):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::markChildren):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::markChildren):
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::markChildren):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.

  • bindings/js/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.
(WebCore::getEventListenerHandlerBody): Updated for the fact that jsFunction()
is no longer a virtual accessor on the EventHandler base class.

  • bindings/scripts/CodeGeneratorJS.pm: Updated for the fact that jsFunction()

is no longer a virtual accessor on the EventHandler base class. Added a "JS"
to invalidateEventListeners and markEventListeners to clarify that these
actions are for JS event listeners only. Added a wrapper parameter to
invalidateEventListeners for the back-pointer check explained above.

  • dom/EventListener.h:

(WebCore::EventListener::invalidateJSFunction): ditto

  • dom/EventTarget.h:

(WebCore::EventTarget::markJSEventListeners):
(WebCore::EventTarget::invalidateJSEventListeners): ditto

LayoutTests: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
​https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>

Reviewed by Alexey Proskuryakov and Darin Adler.

  • fast/events/bogus-event-listener-invalidation-expected.txt: Added.
  • fast/events/bogus-event-listener-invalidation.html: Added.
7:06 PM Changeset in webkit [54399] by mrowe@apple.com
  • 4 edits in tags/Safari-533

Versioning.

7:05 PM Changeset in webkit [54398] by mrowe@apple.com
  • 1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION

Versioning.

7:03 PM Changeset in webkit [54397] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

6:56 PM Changeset in webkit [54396] by mrowe@apple.com
  • 1 copy in tags/Safari-533

Create tag Safari-533

6:38 PM Changeset in webkit [54395] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-02-04 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=25002
When inserting a new paragraph, avoid nesting empty divs. When
pasting near the end of a paragraph, this prevents each paste
command for getting nested one level deeper.

Three paste tests have been rebaselined since this causes the pasted
content to be outside the last div instead of inside. E.g.,
<div>foo<div>bar</div>[pasted content]</div> is now
<div>foo<div>bar</div></div><div>[pasted content]</div>

The new test verifies this behavior.

  • editing/inserting/paragraph-outside-nested-divs-expected.txt: Added.
  • editing/inserting/paragraph-outside-nested-divs.html: Added.
  • platform/mac/editing/pasteboard/paste-text-012-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-013-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-017-expected.txt:

2010-02-04 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=25002
When inserting a new paragraph, avoid nesting empty divs. When
pasting near the end of a paragraph, this prevents each paste
command for getting nested one level deeper.

Test: editing/inserting/paragraph-outside-nested-divs.html

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::highestVisuallyEquivalentDiv): (WebCore::InsertParagraphSeparatorCommand::doApply):
6:31 PM Changeset in webkit [54394] by barraclough@apple.com
  • 15 edits
    1 add in trunk/JavaScriptCore

Add a JSStringBuilder class (similar-to, and derived-from StringBuilder) to
construct JSStrings, throwing a JS exception should we run out of memory whilst
allocating storage for the string.

Reviewed by Oliver Hunt.

Similarly, add jsMakeNontrivialString methods to use in cases where previously
we were calling makeString & passing the result to jsNontrivialString. Again,
these new methods throw if we hit an out of memory condition.

Move throwOutOfMemoryError into ExceptionHelpers, to make it more widely available.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):

  • runtime/DateConstructor.cpp:

(JSC::callDate):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToGMTString):

  • runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

  • runtime/ExceptionHelpers.cpp:

(JSC::throwOutOfMemoryError):

  • runtime/ExceptionHelpers.h:
  • runtime/JSStringBuilder.h: Added.

(JSC::JSStringBuilder::releaseJSString):
(JSC::jsMakeNontrivialString):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToPrecision):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • runtime/Operations.cpp:
  • runtime/Operations.h:
  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

  • runtime/StringBuilder.h:

(JSC::StringBuilder::append):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):

6:09 PM Changeset in webkit [54393] by dumi@chromium.org
  • 9 edits in trunk

WebCore: 1. Fix a bug in SQLiteTransaction: do not assume that COMMIT always
succeeds.

  1. Jump straight to the transaction error callback when a

statement fails in a way that makes sqlite automatically rollback
the transaction.

  1. Fix the code that handles the "quota reached" failure, as it is

one of the failures that lead to an automatic transaction
rollback.

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=34280

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::isAutoCommitOn):

  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteTransaction.cpp:

(WebCore::SQLiteTransaction::begin):
(WebCore::SQLiteTransaction::commit):
(WebCore::SQLiteTransaction::rollback):
(WebCore::SQLiteTransaction::transactionWasRolledBackBySqlite):

  • platform/sql/SQLiteTransaction.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):

LayoutTests: 1. Enhance quota-tracking.html: if sqlite automatically rolls back
a transaction because of a statement failure, make sure the rest
of the statements in the transaction are not executed.

  1. Fix the expectations for quota-tracking.html. Sqlite cannot

recover from reaching a DB's max size.

Reviewed by Eric Seidel.

  • storage/quota-tracking-expected.txt:
  • storage/quota-tracking.html:
5:50 PM Changeset in webkit [54392] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed, rollback.

Rollback r54387, it doesn't fix builds and Chromium doesn't want this behavior.

  • platform/chromium/ScrollbarThemeChromiumMac.h:
5:41 PM Changeset in webkit [54391] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • wtf/MathExtras.h:
5:35 PM Changeset in webkit [54390] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

5:33 PM Changeset in webkit [54389] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.22.6

New tag.

5:01 PM Changeset in webkit [54388] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2010-02-04 Darin Adler <Darin Adler>

Reviewed by David Levin.

Make MathExtras.h compatible with <cmath>
​https://bugs.webkit.org/show_bug.cgi?id=34618

  • wtf/MathExtras.h: Include <cmath> instead of <math.h>. Use "using" as we do elsewhere in WTF for the four functions from <cmath> we want to use without the prefix. Later we could consider making the std explicit at call sites instead.
4:52 PM Changeset in webkit [54387] by senorblanco@chromium.org
  • 2 edits in trunk/WebCore

2010-02-04 Stephen White <​senorblanco@chromium.org>

Unreviewed, build fix.

Fix for Chromium/Mac after palindromic scrollbar change (54345).

Covered by many layout tests.

  • platform/chromium/ScrollbarThemeChromiumMac.h: (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
4:35 PM Changeset in webkit [54386] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-04 Clemmitt Sigler <​cmsigler@gmail.com>

Reviewed by David Levin.

WebKitGTK doesn't build GtkLauncher when --enable-mathml is specified.
Updated WebCore/GNUmakefile.am to include needed files in build.

​https://bugs.webkit.org/show_bug.cgi?id=34387

No new tests.

  • GNUmakefile.am:
4:29 PM Changeset in webkit [54385] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

4:23 PM Changeset in webkit [54384] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.22.5

New tag.

4:19 PM Changeset in webkit [54383] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-02-04 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

Misc coding style fixes in Haiku port code.
​https://bugs.webkit.org/show_bug.cgi?id=34527

No tests needed.

  • platform/haiku/ContextMenuItemHaiku.cpp: Trailing white space, NULL -> 0
  • platform/haiku/DragImageHaiku.cpp: Trailing white space.
  • platform/haiku/FileChooserHaiku.cpp: Sorted headers.
  • platform/haiku/LocalizedStringsHaiku.cpp: Needed to include NotImplemented.h
4:11 PM Changeset in webkit [54382] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebKit/win

Merge r54376.

3:50 PM Changeset in webkit [54381] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix for r54379.

  • platform/qt/Skipped:
3:43 PM Changeset in webkit [54380] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-02-04 Drew Wilson <​atwilson@chromium.org>

Reviewed by David Levin.

WorkerContext.close() does not work in the chromium port
​https://bugs.webkit.org/show_bug.cgi?id=34551

Test: Adding new downstream test.

  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::workerContextClosedTask): Now shuts down the worker thread when WorkerContext::close() is invoked.
3:36 PM Changeset in webkit [54379] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

editing/pasteboard/drop-inputtext-acquires-style.html
introduced in r54368 skipped because of missing DnD support.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
3:33 PM Changeset in webkit [54378] by christian@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-02-04 Christian Dywan <​christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

[GTK] Add and cleanup return values of signals in view and frame
​https://bugs.webkit.org/show_bug.cgi?id=33484

Add missing and cleanup return values of web frame and web view signals.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
  • webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
3:30 PM Changeset in webkit [54377] by enrica@apple.com
  • 2 edits in trunk/WebCore

Fixed crash on QT introduced with the fix for
​https://bugs.webkit.org/show_bug.cgi?id=34609

Reviewed by Csaba Osztrogonac.

The test has been added with the original patch.

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::writePlainText): Added missing allocation of m_writeData.

3:29 PM Changeset in webkit [54376] by alice.liu@apple.com
  • 2 edits in trunk/WebKit/win

​https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error
codes for most elements that arent listbox or menupopup related"
<rdar://problem/7436861>

Reviewed by Jon Honeycutt.

  • AccessibleBase.cpp:

(AccessibleBase::accSelect):

  • Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that aren't beneath listboxes or menupopups. This was too restrictive since any element can be selectable.
  • Correct the misinterpretation of MSDN's stipulation of situations involving adding, removing, and extending selection on single-select elements
2:51 PM Changeset in webkit [54375] by christian@webkit.org
  • 7 edits in trunk

2010-02-04 Christian Dywan <​christian@twotasts.de>

Reviewed by Xan Lopez.

Require either libsoup 2.28.2 or 2.29.90.

  • configure.ac:

2010-02-04 Christian Dywan <​christian@twotoasts.de>

Reviewed by Xan Lopez.

Conditionalize third party cookie policy for libsoup 2.29.90.

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies):
  • platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): (WebCore::startHttp):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
2:50 PM Changeset in webkit [54374] by christian@webkit.org
  • 2 edits in trunk/WebCore

2010-02-04 Christian Dywan <​christian@twotoasts.de>

Rubber-stamped by Gustavo Noronha Silva.

Add ENABLE(VIDEO) guards around freeOwnedGPtr<GstElement> implementation.

  • platform/gtk/GOwnPtrGtk.cpp:
2:35 PM Changeset in webkit [54373] by ap@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Correct a mistake in ChangeLog entry.

2:12 PM Changeset in webkit [54372] by ap@apple.com
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

Assertion failure in CheckedRadioButtons::removeButton when using jQuery 1.4.1
​https://bugs.webkit.org/show_bug.cgi?id=34520

Test: fast/dom/HTMLInputElement/cloned-input-checked-state.html

  • dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren): Copy non-attribute properties before attributes. Otherwise, copying "checked" property would make the cloned node checked, unchecking original (they share a name, and are thus in the same radio group). We do want the original to be unchecked, but we also want to know its original state in HTMLInputElement::copyNonAttributeProperties().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties): Use setChecked instead of plain assignment to prevent m_checked getting out of sync with checkedRadioButtons. Also, copy field related to default checked state, so that m_checked won't be overridden when copying attributes.
2:12 PM Changeset in webkit [54371] by kevino@webkit.org
  • 3 edits in trunk/WebCore

[wx] Build fix after addition of Clipboard::writePlainText method.

2:10 PM Changeset in webkit [54370] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Properly handle margin settings when printing Plugins in WinCairo.
​https://bugs.webkit.org/show_bug.cgi?id=34613

Reviewed by Adam Roben.

  • WebFrame.cpp:

(WebFrame::spoolPage): Adjust the GraphicsContext passed to the

paintContents method so that the World Transform is properly
positioned to account for margin settings at the time that
PluginViewWin.cpp processes the drawing operations.

2:07 PM Changeset in webkit [54369] by mrowe@apple.com
  • 2 edits in trunk/WebKitLibraries

Update auto-version.sh to better handle major version numbers with fewer than three digits,
and the case when WEBKITLIBRARIESDIR is not set.

Reviewed by Steve Falkenburg.

  • win/tools/scripts/auto-version.sh:
1:50 PM Changeset in webkit [54368] by enrica@apple.com
  • 23 edits
    2 adds in trunk

REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info.
<rdar://problem/7595685>
​https://bugs.webkit.org/show_bug.cgi?id=34609

Reviewed by Oliver Hunt.

WebCore:

Test: editing/pasteboard/drop-inputtext-acquires-style.html

The dragging code did not distinguish the case of dragging the content of an input control
as a special case. The markup placed in the pasteboard included the style information.
I've modified the Clipboard class interface adding a new method writePlainText to match the
behavior of the copy and cut commands and modified the drag code to detect the special case.
I've modified all the platform specific implementations of the Clipboard class.

  • dom/Clipboard.h: Added writePlainText pure virtual function.
  • editing/Editor.cpp:

(WebCore::Editor::cut): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
(WebCore::Editor::copy): Renamed nodeIsTextFormControl to isNodeInTextFormControl.

  • editing/htmlediting.cpp:

(WebCore::isNodeInTextFormControl): Added, after removing the implementation with the old name
in Editor.cpp

  • editing/htmlediting.h:
  • page/DragController.cpp:

(WebCore::DragController::startDrag):

  • platform/Pasteboard.h:
  • platform/android/ClipboardAndroid.cpp:

(WebCore::ClipboardAndroid::writePlainText): Added.

  • platform/android/ClipboardAndroid.h:
  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::writePlainText): Added.

  • platform/chromium/ClipboardChromium.h:
  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::writePlainText): Added.

  • platform/gtk/ClipboardGtk.h:
  • platform/haiku/ClipboardHaiku.cpp:

(WebCore::ClipboardHaiku::writePlainText): Added.

  • platform/haiku/ClipboardHaiku.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writePlainText): Added.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writePlainText): Added helper function.

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::writePlainText): Added.

  • platform/qt/ClipboardQt.h:
  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::writePlainText): Added.

  • platform/win/ClipboardWin.h:

LayoutTests:

  • editing/pasteboard/drop-inputtext-acquires-style-expected.txt: Added.
  • editing/pasteboard/drop-inputtext-acquires-style.html: Added.
1:45 PM Changeset in webkit [54367] by sullivan@apple.com
  • 3 edits
    1 move in trunk/WebKit

​https://bugs.webkit.org/show_bug.cgi?id=34611
WebLocalizedString() could use an assertion that it is being called on the main thread

Reviewed by Tim Hatcher.

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Updated for renamed file (WebLocalizableStrings.m -> WebLocalizableStrings.mm)

WebKit/mac:

  • Misc/WebLocalizableStrings.m: Removed.
  • Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.

Renamed to use .mm extension so it can include a C++ header.
(WebLocalizedString):
Added an assertion that this is being called on the main thread.

1:19 PM Changeset in webkit [54366] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-04 Steve Block <​steveblock@google.com>

Reviewed by Nate Chapin.

Fix bug in V8 convertNPVariantToJValue when converting float and double types
​https://bugs.webkit.org/show_bug.cgi?id=34593

No new tests, build fix only.

  • bridge/jni/v8/JNIUtilityPrivate.cpp: Modified. (JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum.
1:11 PM Changeset in webkit [54365] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.20

Tagging 1.1.20.

12:16 PM Changeset in webkit [54364] by darin@chromium.org
  • 7 edits in trunk

2010-02-04 Chris Guillory <​chris.guillory@google.com>

Reviewed by Darin Fisher.

[Chromium] Notify ChromeClientChromium of AccessibilityObject state
change notifications.


​https://bugs.webkit.org/show_bug.cgi?id=34464

  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::toChromeClientChromium): (WebCore::AXObjectCache::postPlatformNotification):
  • page/chromium/ChromeClientChromium.h:
12:10 PM Changeset in webkit [54363] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-02-04 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Darin Fisher.

Update comments to better document the possible values of the
writing direction menu state variables.

  • public/WebContextMenuData.h:
12:09 PM Changeset in webkit [54362] by loki@webkit.org
  • 5 edits in trunk/JavaScriptCore

Use an easily appendable structure for trampolines instead of pointer parameters.
​https://bugs.webkit.org/show_bug.cgi?id=34424

Patch by Tamas Szirbucz <​szirbucz@inf.u-szeged.hu> on 2010-02-04
Reviewed by Gavin Barraclough.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

  • jit/JIT.h:

(JSC::JIT::compileCTIMachineTrampolines):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITStubs.cpp:

(JSC::JITThunks::JITThunks):

  • jit/JITStubs.h:

(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITThunks::ctiVirtualCallLink):
(JSC::JITThunks::ctiVirtualCall):
(JSC::JITThunks::ctiNativeCallThunk):

12:05 PM Changeset in webkit [54361] by senorblanco@chromium.org
  • 6 edits in trunk/WebCore

2010-02-04 Stephen White <​senorblanco@chromium.org>

Unreviewed, build fix for Chromium.

Revert r54341 ("[v8] Remove clear method from DOM object maps"),
since it causes the worker tests to fail on Chromium.

  • bindings/v8/DOMData.h: (WebCore::DOMData::removeObjectsFromWrapperMap):
  • bindings/v8/DOMDataStore.h: (WebCore::ChunkedTable::clear): (WebCore::ChunkedTable::clearEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
  • bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThreadHelper): (WebCore::removeAllDOMObjectsInCurrentThread):
  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::clear):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
11:39 AM Changeset in webkit [54360] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Build fix after changes in r54345.

11:29 AM Changeset in webkit [54359] by eric@webkit.org
  • 5 edits in trunk

2010-02-04 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crashes when an invalid hostname is pre-fetched
​https://bugs.webkit.org/show_bug.cgi?id=34602

  • http/tests/misc/dns-prefetch-control-expected.txt:
  • http/tests/misc/dns-prefetch-control.html: Add broken hostname test case.

2010-02-04 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crashes when an invalid hostname is pre-fetched
​https://bugs.webkit.org/show_bug.cgi?id=34602

  • platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS): NULL-check the SoupURI that is created from the hostname; that will happen for invalid hostnames.
11:10 AM Changeset in webkit [54358] by bweinstein@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Rubber-stamped by Dan Bernstein.

Add Windows expected results to the new scrollbar test because Windows was trying
to compare to platform/mac first instead of cross-platform.

  • platform/win/fast/events/scrollbar-double-click-expected.txt: Added.
10:52 AM Changeset in webkit [54357] by kenneth@webkit.org
  • 4 edits in trunk/WebKitTools

Rubberstamped by Oliver Hunt.

[Qt] QtLauncher cleanup.

Refactor option handling out in utility functions and make the
arguments more Qt compatible.

  • QtLauncher/main.cpp:

(requiresGraphicsView):
(LauncherApplication::handleUserOptions):

  • QtLauncher/utils.cpp:

(takeOptionValue):
(formatKeys):
(enumToKeys):
(appQuit):

  • QtLauncher/utils.h:
10:42 AM Changeset in webkit [54356] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Properly handle margin settings in WinCairo.
​https://bugs.webkit.org/show_bug.cgi?id=34545

Reviewed by Adam Roben.

  • WebFrame.cpp:

(scaleFactor): Require the margin information as an input

parameter, and use them when computing the scaling factor.

(WebFrame::drawHeader): Pass margin size to scaleFactor.
(WebFrame::drawFooter): Pass margin size to scaleFactor.
(WebFrame::spoolPage):

  1. Pass margin size to scaleFactor.
  2. Recognize that the return value of printerMarginRect is already in device units, and therefore scale it so that the Cairo drawing is correct.
  3. Remove scaling call for margins in GDI code, as it is already in scaled units.
10:35 AM Changeset in webkit [54355] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-04 José Millán Soto <​jmillan@igalia.com>

Reviewed by Xan Lopez.

[Gtk] webkitgtk crashed when Orca open
​https://bugs.webkit.org/show_bug.cgi?id=34463

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textForObject): Checking if render objects are texts before calling toRenderText
10:21 AM Changeset in webkit [54354] by sfalken@apple.com
  • 2 edits in tags/Safari-532.8.1/WebKitLibraries

Merge r54348.

10:18 AM Changeset in webkit [54353] by sfalken@apple.com
  • 4 edits in tags/Safari-532.8.1

Versioning.

10:09 AM Changeset in webkit [54352] by xan@webkit.org
  • 6 edits in trunk

2010-02-04 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump minimum libsoup requirement to 2.29.90

  • configure.ac:

WebCore:

2010-02-04 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Set first party URI in all SoupMessages. This allows libsoup to
implement a "no third party cookies" policy in case it wants
to. Also start a non-JSC-specific, gtk-specific GOwnPtr module and
use it for SoupURI.

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): (WebCore::startHttp):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
10:06 AM Changeset in webkit [54351] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-02-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: group cookies by domains, not frame's domains.

​https://bugs.webkit.org/show_bug.cgi?id=34599

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._cookiesForDomain):
  • inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addCookieDomain):
10:03 AM Changeset in webkit [54350] by sfalken@apple.com
  • 1 copy in tags/Safari-532.8.1

New tag.

10:01 AM Changeset in webkit [54349] by Nate Chapin
  • 61 edits in trunk

2010-02-04 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Delete V8CustomBinding.h and all references to V8Custom

​https://bugs.webkit.org/show_bug.cgi?id=32638

  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8AttrCustom.cpp:
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8ClipboardCustom.cpp:
  • bindings/v8/custom/V8CoordinatesCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h: Removed.
  • bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
  • bindings/v8/custom/V8DatabaseCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventSourceConstructor.cpp:
  • bindings/v8/custom/V8EventSourceCustom.cpp:
  • bindings/v8/custom/V8GeolocationCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback): (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback): (WebCore::V8HTMLImageElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback): (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8NodeFilterCustom.cpp:
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionCustom.cpp:
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
  • bindings/v8/custom/V8SVGLengthCustom.cpp:
  • bindings/v8/custom/V8SharedWorkerCustom.cpp:
  • bindings/v8/custom/V8StorageCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayCustom.h:
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebKitPointConstructor.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • bindings/v8/custom/V8WorkerCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
9:56 AM Changeset in webkit [54348] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Windows build fix for projects not defining WebKitLibrariesDir.

9:43 AM Changeset in webkit [54347] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2010-02-04 Ariya Hidayat <​ariya.hidayat@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Unnecessary QBrush construction for doing a solid fill
​https://bugs.webkit.org/show_bug.cgi?id=34559

Use the similar trick like r37421, i.e. use the special brush for
solid color to avoid creating QBrush again and again.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformFillColor):
9:41 AM Changeset in webkit [54346] by mitz@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
​https://bugs.webkit.org/show_bug.cgi?id=34371

Reviewed by Simon Fraser.

  • platform/mac/fast/events/scrollbar-double-click-expected.txt: Added.
9:35 AM Changeset in webkit [54345] by mitz@apple.com
  • 18 edits in trunk

REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
​https://bugs.webkit.org/show_bug.cgi?id=34371

Reviewed by Simon Fraser.

WebCore:

Allow ScrollbarTheme to cap the overlap between pages, and set a cap of
40 in ScrollbarThemeMac.

  • WebCore.base.exp: Export Scrollbar::maxOverlapBetweenPages().
  • editing/EditorCommand.cpp:

(WebCore::verticalScrollDistance): Use Scrollbar methods instead of
constants, and cap the scroll distance if needed.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::wheelEvent): Ditto.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::maxOverlapBetweenPages): Added. Returns the
value from the native scrollbar theme.

  • platform/Scrollbar.h: Replaced scroll amount constants with static methods.

(WebCore::Scrollbar::pixelsPerLineStep): Replaces cScrollbarPixelsPerLineStep.
(WebCore::Scrollbar::minFractionToStepWhenPaging): Replaces cFractionToStepWhenPaging.

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::maxOverlapBetweenPages): A base implementation
that returns the largest int.

  • platform/gtk/WheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.

  • platform/haiku/PlatformWheelEventHaiku.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.

  • platform/mac/ScrollbarThemeMac.h:

(WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): An override
that returns 40.

  • platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use
Scrollbar::pixelsPerLineStep() instead of cScrollbarPixelsPerLineStep.

  • platform/wx/MouseWheelEventWx.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.

  • platform/wx/ScrollViewWx.cpp:

(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): Use Scrollbar
methods instead of constants, and cap the scroll distance if needed.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout): Ditto.

WebKit/mac:

  • WebView/WebFrameView.mm:

(-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
constants, and cap the scroll distance.
(-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
cScrollbarPixelsPerLineStep.
(-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
constants, and cap the scroll distance.

WebKit/wx:

  • WebView.cpp:

(wxWebView::OnKeyEvents): Use Scrollbar method instead of constant.

8:56 AM Changeset in webkit [54344] by eric@webkit.org
  • 4 edits in trunk

2010-02-04 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
recaching, remove QTimer::singleShot and QPixmap::scaled, more
accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.

​https://bugs.webkit.org/show_bug.cgi?id=34062

This is tested by ​https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs (WebCore::OpacityAnimationQt::updateState): style change

2010-02-04 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
of QTimer::singleShot, and moved syncLayers() from paint() to update()
​https://bugs.webkit.org/show_bug.cgi?id=34062

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update): Moved the sync operation to update (QGraphicsWebView::paint): Moved the sync operation to update
8:39 AM Changeset in webkit [54343] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-02-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Cookies for resources are not shown in storage panel.

​https://bugs.webkit.org/show_bug.cgi?id=34594

  • inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies):
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::cachedResource):
  • inspector/InspectorResource.h: (WebCore::InspectorResource::requestURL):
6:52 AM Changeset in webkit [54342] by abecsi@webkit.org
  • 3 edits in trunk/WebKitTools

2010-02-04 Andras Becsi <​abecsi@inf.u-szeged.hu>

Reviewed by Tor Arne Vestbø.

Implement a locking and scheduling mechanism for http testing sessions to be able
to run multiple instances of run-webkit-tests parallel on the same machine.
If a test session wants to run http tests and this feature is enabled, the pending
sessions create lockfiles with sequential lock numbers. These locks are used to schedule
the running test sessions in first come first served order. An exclusive lock ensures
that the lock numbers are sequential to avoid deadlocks and starvation.
Because the buildbot master specifies the flags used by slaves we need an environment
variable too to be able to use the feature per-slave.
Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
flag enables this feature, otherwise this patch has no effect on the testing whatsoever.

​https://bugs.webkit.org/show_bug.cgi?id=33153

4:57 AM Changeset in webkit [54341] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-02-04 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Remove clear method from DOM object maps
​https://bugs.webkit.org/show_bug.cgi?id=34530

No new tests. Should be covered by existent testing infrastructure.

  • bindings/v8/DOMData.h:
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMMap.h:
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
3:15 AM Changeset in webkit [54340] by eric@webkit.org
  • 3 edits
    2 adds in trunk/JavaScriptCore

2010-02-04 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Increase test coverage for the QScriptValue.

​https://bugs.webkit.org/show_bug.cgi?id=34533

  • qt/tests/qscriptvalue/qscriptvalue.pro:
  • qt/tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::tst_QScriptValue): (tst_QScriptValue::~tst_QScriptValue): (tst_QScriptValue::dataHelper): (tst_QScriptValue::newRow): (tst_QScriptValue::testHelper): (tst_QScriptValue::ctor):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h: Added.
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Added. (tst_QScriptValue::initScriptValues): (tst_QScriptValue::isValid_initData): (tst_QScriptValue::isValid_makeData): (tst_QScriptValue::isValid_test): (tst_QScriptValue::isBool_initData): (tst_QScriptValue::isBool_makeData): (tst_QScriptValue::isBool_test): (tst_QScriptValue::isBoolean_initData): (tst_QScriptValue::isBoolean_makeData): (tst_QScriptValue::isBoolean_test): (tst_QScriptValue::isFunction_initData): (tst_QScriptValue::isFunction_makeData): (tst_QScriptValue::isFunction_test): (tst_QScriptValue::isNull_initData): (tst_QScriptValue::isNull_makeData): (tst_QScriptValue::isNull_test): (tst_QScriptValue::isString_initData): (tst_QScriptValue::isString_makeData): (tst_QScriptValue::isString_test): (tst_QScriptValue::isUndefined_initData): (tst_QScriptValue::isUndefined_makeData): (tst_QScriptValue::isUndefined_test): (tst_QScriptValue::isObject_initData): (tst_QScriptValue::isObject_makeData): (tst_QScriptValue::isObject_test):
2:55 AM Changeset in webkit [54339] by vestbo@webkit.org
  • 3 edits in trunk/WebKitTools

Make run-webkit-tests work under Cygwin for the Qt port

Reviewed by Simon Hausmann.

setPathForRunningWebKitApp() is implemented for the Qt port
by using qmake to query for the location of the Qt libraries.

This requires the original environment (%ENV) to be untouched,
so launchWithCurrentEnv() was refactored to launchWithEnv(),
and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
instead. This has the added benefit of getting rid of the temp
variables used for storing the current env.

openDumpTool() is also refactored a bit into platform-spesific,
port-spesific, and generic environment variables.

Checks for undef was added a few places to fix Perl concat
warnings when run-webkit-tests is aborted.

​https://bugs.webkit.org/show_bug.cgi?id=33895

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
2:50 AM Changeset in webkit [54338] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot
​https://bugs.webkit.org/show_bug.cgi?id=34281

  • platform/qt/Skipped: fast/workers/shared-worker-frame-lifecycle.html skipped until fix.
2:50 AM Changeset in webkit [54337] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[Gtk] Check if the renderer() exists in textForObject.

This is fixing a crash in the textForObject method. It can
happen when inspecting AtkObjects in the accerciser, then
navigating to a new page and still inspecting the old tree.

In this case the AccessibilityObjectWrapperAtk was still
valid but the included renderer() was returning 0. Add a
check for the accObject->renderer() before trying to use
the result.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(textForObject):

2:20 AM Changeset in webkit [54336] by yuzo@google.com
  • 2 edits in trunk/WebKitTools

2010-02-04 Yuzo Fujishima <​yuzo@google.com>

Unreviewed.

Add Yuzo to the committers list.

  • Scripts/webkitpy/committers.py:
2:06 AM Changeset in webkit [54335] by yurys@chromium.org
  • 2 edits
    2 deletes in trunk/WebKit/chromium

2010-02-04 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Revert 54333 which broke Chromium build.

  • WebKit.gyp:
  • tests/TransparencyWinTest.cpp: Removed.
  • tests/UniscribeHelperTest.cpp: Removed.
1:38 AM Changeset in webkit [54334] by yurys@chromium.org
  • 15 edits
    2 adds in trunk/WebCore

2010-02-04 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Provide strongly typed C++ interface for inspector's injected script.

​https://bugs.webkit.org/show_bug.cgi?id=33616

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScript.cpp: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapAndStringifyForConsole): (WebCore::InjectedScript::releaseWrapperObjectGroup):
  • inspector/InjectedScript.h: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::~InjectedScript): (WebCore::InjectedScript::hasNoValue):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
1:16 AM Changeset in webkit [54333] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebKit/chromium

2010-02-04 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Fisher.

Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin.
​https://bugs.webkit.org/show_bug.cgi?id=34509

  • WebKit.gyp:
  • tests/TransparencyWinTest.cpp: Added. (WebCore::RECTToFloatRect): (WebCore::drawNativeRect): (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::operator<<): (WebCore::TEST):
  • tests/UniscribeHelperTest.cpp: Added. (WebCore::UniscribeTest::UniscribeTest): (WebCore::UniscribeTest::MakeFont): (WebCore::UniscribeTest::SetUp): (WebCore::UniscribeTest::TearDown): (WebCore::TEST_F):
1:11 AM Changeset in webkit [54332] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-02-04 Philippe Normand <​pnormand@igalia.com>

Rubber stamped by Xan Lopez.

Missing include, build fix after landing of patch from the bug 34435.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
12:41 AM Changeset in webkit [54331] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-02-04 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by David Levin.

[Chromium] WebKit side of "Writing direction" context menu on OS X.
​https://bugs.webkit.org/show_bug.cgi?id=34524

  • public/WebContextMenuData.h: (WebKit::WebContextMenuData::):
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
12:32 AM Changeset in webkit [54330] by Philippe Normand
  • 3 edits
    2 adds in trunk/WebCore

2010-02-02 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] libsoup critical warning in media player http cookies injection code
​https://bugs.webkit.org/show_bug.cgi?id=34435

Fixed the critical warning and refactored the
User-Agent/Referer/cookies injection code, in that order. Previous
order (cookies first) was wrong because if cookies injection could
not be done neither the User-Agent nor Referer were injected. Also
started a non-JSC-specific, gtk-specific GOwnPtr module.

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
  • platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::SoupURI): (WTF::GstElement):
  • platform/gtk/GOwnPtrGtk.h: Added.
12:25 AM Changeset in webkit [54329] by eric@webkit.org
  • 20 edits in trunk/WebCore

2010-02-04 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Put JSC-specific debugger & profiler code under "USE(JSC)" defines.
The plan is to enable "JAVASCRIPT_DEBUGGER" in Chromium and then
make this code engine-agnostic.

​https://bugs.webkit.org/show_bug.cgi?id=34531

  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::close): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/JavaScriptCallFrame.cpp:
  • inspector/JavaScriptCallFrame.h:
  • inspector/JavaScriptDebugListener.h:
  • inspector/JavaScriptDebugServer.cpp:
  • inspector/JavaScriptDebugServer.h:
  • inspector/JavaScriptProfile.cpp:
  • inspector/JavaScriptProfile.h:
  • inspector/JavaScriptProfileNode.cpp:
  • inspector/JavaScriptProfileNode.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
  • page/Page.cpp: (WebCore::Page::Page):

Feb 3, 2010:

11:54 PM Changeset in webkit [54328] by dpranke@chromium.org
  • 23 edits in trunk/WebKitTools

2010-02-03 Dirk Pranke <​dpranke@chromium.org>

Rubber-stamped by Eric Seidel.

Change "the Chromium name" to "the name of Google Inc." in the licenses

​https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/path_utils.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
11:51 PM Changeset in webkit [54327] by dpranke@chromium.org
  • 12 edits
    11 moves
    1 add in trunk/WebKitTools

2010-02-03 Dirk Pranke <​dpranke@chromium.org>

Rubber-stamped by Eric Siedel.

Rename files as part of refactoring the layout_tests package. All
the platform_utils* module, the path_utils.py module, and
the http server and web socket server modules are moved into a new
port/ package.

​https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/init.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
  • Scripts/webkitpy/layout_tests/port/http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server.py.
  • Scripts/webkitpy/layout_tests/port/http_server_base.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
  • Scripts/webkitpy/layout_tests/port/httpd2.pem: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
  • Scripts/webkitpy/layout_tests/port/lighttpd.conf: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
  • Scripts/webkitpy/layout_tests/port/path_utils.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
11:48 PM Changeset in webkit [54326] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-02-03 Nicholas Young <​nicholas.young@nokia.com>

Reviewed by Eric Carlson.

Defer formatting of times displayed on media controls to the current theme.
​https://bugs.webkit.org/show_bug.cgi?id=34405

No new tests needed. Refactoring Only.

  • rendering/MediaControlElements.cpp: Removed formatTime() (WebCore::MediaControlTimeDisplayElement::setCurrentValue): No longer sets inner text
  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateTimeDisplay): Asks the theme to format the time display elements
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::formatMediaControlsTime): new virtual method (WebCore::RenderTheme::formatMediaControlsCurrentTime): new virtual method (WebCore::RenderTheme::formatMediaControlsRemainingTime): new virtual method
  • rendering/RenderTheme.h:
11:30 PM Changeset in webkit [54325] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix.

websocket/tests/close-on-unload.html and
close-on-navigate-new-location.html will fail on mac tiger,
because python on the platform doesn't support set(), which is
used in websocket handler for these tests.

  • platform/mac-tiger/Skipped: skip websocket/tests/close-on-unload.html and websocket/tests/close-on-navigate-new-location.html
11:26 PM Changeset in webkit [54324] by ukai@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-02-03 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

navigating a frame to new location closes websocket in the frame
​https://bugs.webkit.org/show_bug.cgi?id=34557

  • websocket/tests/close-on-navigate-new-location-expected.txt: Added.
  • websocket/tests/close-on-navigate-new-location.html: Added.
9:52 PM Changeset in webkit [54323] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Windows Debug_All build fix.

  • platform/graphics/win/WKCACFLayer.cpp:
7:57 PM Changeset in webkit [54322] by mrowe@apple.com
  • 1 delete in trunk/LayoutTests/websocket/tests/resources/close-on-unload-iframe.html~

Remove an unnecessary backup file.

7:28 PM Changeset in webkit [54321] by beidson@apple.com
  • 3 edits
    9 adds in trunk

REGRESSION (r51644): WebCore/manual-tests/linkjump-1.html fails
<rdar://problem/7595694> and ​https://bugs.webkit.org/show_bug.cgi?id=34550

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: fast/loader/document-with-fragment-url-1.html

fast/loader/document-with-fragment-url-2.html
fast/loader/document-with-fragment-url-3.html
fast/loader/document-with-fragment-url-4.html

  • platform/KURL.cpp:

(WebCore::KURL::init): When resolving new URL from an empty reference relative to an absolute URL,

any fragment identifier from the absolute URL should be removed from the resulting resolution.

LayoutTests:

  • fast/loader/document-with-fragment-url-1-expected.txt: Added.
  • fast/loader/document-with-fragment-url-1.html: Added.
  • fast/loader/document-with-fragment-url-2-expected.txt: Added.
  • fast/loader/document-with-fragment-url-2.html: Added.
  • fast/loader/document-with-fragment-url-3-expected.txt: Added.
  • fast/loader/document-with-fragment-url-3.html: Added.
  • fast/loader/document-with-fragment-url-4-expected.txt: Added.
  • fast/loader/document-with-fragment-url-4.html: Added.
  • fast/loader/resources/document-with-fragment-url-test.html: Added.
6:49 PM Changeset in webkit [54320] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-03 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Define WTF_PLATFORM_BREWMP_SIMULATOR when AEE_SIMULATOR is defined
​https://bugs.webkit.org/show_bug.cgi?id=34514

PLATFORM(BREWMP_SIMULATOR) guard is needed to make distinction between BREWMP
and BREWMP simulator.

  • wtf/Platform.h:
6:24 PM Changeset in webkit [54319] by ukai@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-02-03 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket should close the connection when unloading the document
​https://bugs.webkit.org/show_bug.cgi?id=33248

  • websocket/tests/close-on-unload-expected.txt: Added.
  • websocket/tests/close-on-unload.html: Added.
  • websocket/tests/close-on-unload_wsh.py: Added.
  • websocket/tests/resources/close-on-unload-iframe.html: Added.
6:23 PM Changeset in webkit [54318] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-02-03 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port TextBreakIteratorInternalICU
​https://bugs.webkit.org/show_bug.cgi?id=34515

Port TextBreakIteratorInternalICU.

  • platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Added. (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
5:52 PM Changeset in webkit [54317] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Fix for <rdar://problem/7594212>
​https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at ​http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319

Reviewed by Simon Fraser.

Test: fast/css/counters/counter-before-selector-crash.html

  • rendering/RenderCounter.cpp: (WebCore::updateCounters): nil check.

LayoutTests: Test for: <rdar://problem/7594212>
​https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at ​http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319

Reviewed by Simon Fraser.

  • fast/css/counters/counter-before-selector-crash-expected.txt: Added.
  • fast/css/counters/counter-before-selector-crash.html: Added.
5:32 PM Changeset in webkit [54316] by adele@apple.com
  • 2 edits in trunk/WebCore

Initialize the variable in the last checkin to false. I didn't realize DRT relies on this being false.
So ports that want visited link tracking need to set that flag.

Reviewed by Brady Eidson.

  • page/PageGroup.cpp:
5:09 PM Changeset in webkit [54315] by mrowe@apple.com
  • 4 edits
    1 add in branches/safari-4-branch/WebCore

Merge r54311.

5:07 PM Changeset in webkit [54314] by Csaba Osztrogonác
  • 4 edits
    1 add in trunk/WebKitTools

Rubber-stamped by Eric Seidel.

Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
​https://bugs.webkit.org/show_bug.cgi?id=34399

  • Scripts/run-iexploder-tests:
  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
  • Scripts/webkitperl/httpd.pm: Added.
4:50 PM Changeset in webkit [54313] by adele@apple.com
  • 2 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=34547
static shouldTrackVisitedLinks is not initialized

Reviewed by Brady Eidson.

For ports that don't call into WebKit to initialize this,
we should initialize to true so they get the visited link behavior by default.

  • page/PageGroup.cpp:
4:32 PM Changeset in webkit [54312] by Csaba Osztrogonác
  • 4 edits
    1 delete in trunk/WebKitTools

Rubber-stamped by Eric Seidel.

Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots

  • Scripts/run-iexploder-tests:
  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
  • Scripts/webkitperl/httpd.pm: Removed.
4:26 PM Changeset in webkit [54311] by mitz@apple.com
  • 4 edits
    1 add in trunk/WebCore

<rdar://problem/7577604> Drag and Drop: background elements are bleeding through
​https://bugs.webkit.org/show_bug.cgi?id=34546

Reviewed by Simon Fraser.

  • manual-tests/drag-image-table-part-decorations.html: Added.
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t
paint within the current painting root.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.
(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

4:19 PM Changeset in webkit [54310] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch/WebKitTools

Build fix.

3:47 PM Changeset in webkit [54309] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add wxWebKitWindowFeatures and have createWindow send a notification for
clients to handle.

​https://bugs.webkit.org/show_bug.cgi?id=34542

3:31 PM Changeset in webkit [54308] by mrowe@apple.com
  • 8 edits in branches/safari-4-branch

Merge r54083.

3:31 PM Changeset in webkit [54307] by Csaba Osztrogonác
  • 4 edits in trunk

Rubber-stamped by Ariya Hidayat.

Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
​https://bugs.webkit.org/show_bug.cgi?id=34399

WebKitTools:

  • DumpRenderTree/win/EventSender.cpp:

(buildModifierFlags):
(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):

LayoutTests:

  • platform/win/Skipped:
3:06 PM Changeset in webkit [54306] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-02-03 Nate Chapin <Nate Chapin>

Unreviewed, Chromium mac build fix.

[V8] Remove unused V8Proxy* variable from generated wrapping code.

  • bindings/scripts/CodeGeneratorV8.pm:
2:33 PM Changeset in webkit [54305] by Nate Chapin
  • 47 edits in trunk/WebCore

2010-02-03 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.


​https://bugs.webkit.org/show_bug.cgi?id=32563

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptObject.cpp:
  • bindings/v8/V8AbstractEventListener.cpp:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8NodeFilterCondition.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/WorkerContextExecutionProxy.h
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8CustomPositionCallback.cpp:
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8DocumentLocationCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8MessageEventCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NodeIteratorCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8SVGMatrixCustom.cpp:
  • bindings/v8/custom/V8StyleSheetListCustom.cpp:
  • bindings/v8/custom/V8TreeWalkerCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
2:32 PM Changeset in webkit [54304] by eric@webkit.org
  • 25 edits in trunk/WebKitTools

2010-02-03 Eric Seidel <​eric@webkit.org>

No review, just fixing copyrights.

Concerns were expressed about "The Chromium Authors" being
a valid legal entity for copyright assignment in the WebKit repository,
so this change removes all "The Chromium Authors".

I looked at the svn logs in src.chromium.org and failed to find any
non-google contributions to these files, so they are all now
marked as copyright "Google Inc" as all Google contributers assign
copyright to "Google Inc" as part of their employment agreement.

  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/run-chromium-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/layout_package/http_server.py:
  • Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2:26 PM Changeset in webkit [54303] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r48879.

2:26 PM Changeset in webkit [54302] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Merge r48374.

2:26 PM Changeset in webkit [54301] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48364.

2:26 PM Changeset in webkit [54300] by mrowe@apple.com
  • 31 edits
    1 copy
    15 adds in branches/safari-4-branch

Merge r48363.

2:23 PM Changeset in webkit [54299] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix drawing buttons in viewless WebKit.

Reviewed by Anders Carlsson.

  • platform/mac/ThemeMac.mm:

(WebCore::paintButton): If there is no view, make sure to flip the
context so that the button is drawn correctly.

2:00 PM Changeset in webkit [54298] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
​https://bugs.webkit.org/show_bug.cgi?id=34425

Reviewed by Kenneth Rohde Christiansen.

Reverting r54279, it was a misunderstanding.

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp:
1:44 PM Changeset in webkit [54297] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] QtLauncher, refactor argument handling in preparation of merge
with QGVLauncher

Reviewed by Ariya Hidayat.

  • QtLauncher/main.cpp:

(LauncherApplication::urls):
(LauncherApplication::isRobotized):
(LauncherApplication::applyDefaultSettings):
(LauncherApplication::LauncherApplication):
(LauncherApplication::formatKeys):
(LauncherApplication::enumToKeys):
(fail):
(LauncherApplication::handleUserOptions):
(main):

1:43 PM Changeset in webkit [54296] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-03 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Remove COMPILE_ASSERT conflict with the underlying PLATFORM
​https://bugs.webkit.org/show_bug.cgi?id=34190

COMPILE_ASSERT conflicts with the underlying PLATFORM because it is defined
both in WTF's Assertions.h and BREWMP's AEEClassIDs.h. Include AEEClassIDs.h
in Assertions.h and undef COMPILE_ASSERT to avoid redefining COMPILE_ASSERT.

  • wtf/Assertions.h:
1:19 PM Changeset in webkit [54295] by Csaba Osztrogonác
  • 4 edits in trunk

Rubber-stamped by Ariya Hidayat.

Rolling out r53889, because it might caused flakeyness on the Windows Test bots
​https://bugs.webkit.org/show_bug.cgi?id=34399

WebKitTools:

  • DumpRenderTree/win/EventSender.cpp:

(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):

LayoutTests:

  • platform/win/Skipped:
1:17 PM Changeset in webkit [54294] by eric@webkit.org
  • 1 edit
    2 adds in trunk/JavaScriptCore

2010-02-03 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Implement OwnPtrBrew to make sure BREW instances are freed.
​https://bugs.webkit.org/show_bug.cgi?id=34518

Add OwnPtrBrew to release IFile, IFileMgr and IBitmap instances.

  • wtf/brew/OwnPtrBrew.cpp: Added. (WTF::IFileMgr): (WTF::IFile): (WTF::IBitmap): (WTF::freeOwnedPtrBrew):
  • wtf/brew/OwnPtrBrew.h: Added. (WTF::OwnPtrBrew::OwnPtrBrew): (WTF::OwnPtrBrew::~OwnPtrBrew): (WTF::OwnPtrBrew::get): (WTF::OwnPtrBrew::release): (WTF::OwnPtrBrew::outPtr): (WTF::OwnPtrBrew::set): (WTF::OwnPtrBrew::clear): (WTF::OwnPtrBrew::operator*): (WTF::OwnPtrBrew::operator->): (WTF::OwnPtrBrew::operator!): (WTF::OwnPtrBrew::operator UnspecifiedBoolType): (WTF::OwnPtrBrew::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::getPtr):
12:58 PM Changeset in webkit [54293] by bweinstein@apple.com
  • 3 edits in trunk/WebKit/win

Scroll does not work with IBM Thinkpad.
<​https://bugs.webkit.org/show_bug.cgi?id=14227>
<rdar://7142545>

Reviewed by Steve Falkenburg.

When initializing the WebView, add two scrollbar Windows inside of
our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events.
(similar to what Firefox did in: <​https://bugzilla.mozilla.org/show_bug.cgi?id=507222>.

Only do this if the user has installed some kind of Trackpoint driver, using an algorithm
like <​https://bugzilla.mozilla.org/show_bug.cgi?id=514927>.

Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll
the WebView.

  • WebView.cpp:

(WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down

by lines or pages.

(WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right

by lines or pages.

(WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL.
(WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create

vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages.

(WebView::shouldInitializeTrackPointHack): Check if there is a registry key for

the some kind of IBM Trackpoint driver.

  • WebView.h:
12:14 PM Changeset in webkit [54292] by eric@webkit.org
  • 5 edits in trunk

2010-02-03 Drew Wilson <​atwilson@chromium.org>

Reviewed by Alexey Proskuryakov.

SharedWorkerScriptLoader should not be an ActiveDOMObject
​https://bugs.webkit.org/show_bug.cgi?id=34513

Test: Existing tests suffice (fixes test downstream in Chrome).

  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed to no longer derive from ActiveDOMObject (handles its own refcounting). (WebCore::SharedWorkerScriptLoader::load): Now increments own refcount when a load is pending. (WebCore::SharedWorkerScriptLoader::notifyFinished): Changed to decrement refcount when load is complete.
  • workers/WorkerScriptLoaderClient.h: Documentation change about reliability of notifyFinished() when used from worker context.

2010-02-03 Drew Wilson <​atwilson@chromium.org>

Reviewed by Alexey Proskuryakov.

SharedWorkerScriptLoader should not be an ActiveDOMObject
​https://bugs.webkit.org/show_bug.cgi?id=34513

  • src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed SharedWorkerScriptLoader to manage its own lifecycle without using ActiveDOMObject. (WebCore::SharedWorkerScriptLoader::parentContext): (WebCore::pendingLoaders): Now we manually track pending loads so we can shut them down when the parent context shuts down. (WebCore::SharedWorkerScriptLoader::contextDetached): Shuts down/frees any pending worker loads. (WebCore::SharedWorkerScriptLoader::~SharedWorkerScriptLoader): Marks the SharedWorker object as not having pending activity if there was a load active (handles case where load was pending when parent document exits). (WebCore::SharedWorkerScriptLoader::load): (WebCore::SharedWorkerRepository::documentDetached): Now calls SharedWorkerScriptLoader::contextDetached() to shutdown any pending worker loads.
11:57 AM Changeset in webkit [54291] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Inspector renders blank scripts on reloading the webpage.

​https://bugs.webkit.org/show_bug.cgi?id=34537

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
11:41 AM Changeset in webkit [54290] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-03 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Export WTF::fastStrDup symbol
​https://bugs.webkit.org/show_bug.cgi?id=34526

11:39 AM Changeset in webkit [54289] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

[Qt] Fix pixel tests support.
​https://bugs.webkit.org/show_bug.cgi?id=27813

Reviewed by Ariya Hidayat.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):

  • Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.

(WebCore::DumpRenderTree::dump): Fixed and renamed variables.

11:02 AM Changeset in webkit [54288] by mitz@apple.com
  • 2 edits in trunk/WebKitLibraries

Fixed a bug where WKSetNSURLConnectionDefersCallbacks(true) did not defer callbacks during modal dialogs.

Reviewed by Anders Carlsson.

  • libWebKitSystemInterfaceLeopard.a:
10:52 AM Changeset in webkit [54287] by kevino@webkit.org
  • 4 edits in trunk

Reviewed by Kevin Ollivier.

[wx] Enable JIT compilation for wx.

​https://bugs.webkit.org/show_bug.cgi?id=34536

10:26 AM Changeset in webkit [54286] by yurys@chromium.org
  • 13 edits
    2 deletes in trunk/WebCore

2010-02-03 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Revert r54285 which failed to compile on Linux GTK.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScript.cpp: Removed.
  • inspector/InjectedScript.h: Removed.
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
10:11 AM Changeset in webkit [54285] by yurys@chromium.org
  • 14 edits
    2 adds in trunk/WebCore

2010-02-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Provide strongly typed C++ interface for inspector's injected script.

​https://bugs.webkit.org/show_bug.cgi?id=33616

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScript.cpp: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapAndStringify): (WebCore::InjectedScript::releaseWrapperObjectGroup):
  • inspector/InjectedScript.h: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::~InjectedScript): (WebCore::InjectedScript::hasNoValue):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
10:02 AM Changeset in webkit [54284] by abecsi@webkit.org
  • 4 edits in trunk

Unreviewed build fix.

[Qt] Roll-out r54281 because it broke the build on the Qt Release bot.

9:48 AM Changeset in webkit [54283] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-02-03 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Timothy Hatcher.

[Chromium] Return a consistent set of platforms from WebDevToolsFrontendImpl
​https://bugs.webkit.org/show_bug.cgi?id=34523

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::jsPlatform):
8:09 AM Changeset in webkit [54282] by levin@chromium.org
  • 2 edits in trunk/WebCore

2010-02-02 Bryan Yeung <​bryeung@google.com>

Reviewed by Darin Adler.

Avoid using an invalidated KURL object in baseURI.

​https://bugs.webkit.org/show_bug.cgi?id=34492

This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg

This is a re-application of this patch since it was mistakenly identified as
the cause of a big chromium test regression and rolled out in r54264.

  • dom/Element.cpp: (WebCore::Element::baseURI):
8:01 AM Changeset in webkit [54281] by eric@webkit.org
  • 4 edits in trunk

2010-02-03 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
recaching, remove QTimer::singleShot and QPixmap::scaled, more
accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.

​https://bugs.webkit.org/show_bug.cgi?id=34062

This is tested by ​https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs (WebCore::OpacityAnimationQt::updateState): style change

2010-02-03 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
of QTimer::singleShot, and moved syncLayers() from paint() to update()
​https://bugs.webkit.org/show_bug.cgi?id=34062

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update): Moved the sync operation to update (QGraphicsWebView::paint): Moved the sync operation to update
7:37 AM Changeset in webkit [54280] by levin@chromium.org
  • 5 edits
    2 adds in trunk

WebCore: [Chromium] Make setCaretBlinkInterval static.
​https://bugs.webkit.org/show_bug.cgi?id=31704

Patch by Joel Stanley <​joel@jms.id.au> on 2010-02-02
Reviewed by David Levin.

This is so it can be called from the newly exposed Chromium API setter
method.

  • rendering/RenderThemeChromiumLinux.cpp:
  • rendering/RenderThemeChromiumLinux.h:

WebKit/chromium: [Chromium] Add API method for setting caret blink frequency.
​https://bugs.webkit.org/show_bug.cgi?id=31704

Patch by Joel Stanley <​joel@jms.id.au> on 2010-02-02
Reviewed by David Levin.

This enables the RenderThemeChromiumLinux::setCaretBlinkInterval method
to be called Chromium's API. The API is linux-only as it is currently
the only port to implement RenderTheme::setCaretBlinkInterval.

  • WebKit.gyp: Add WebRenderTheme.{h,cpp}
  • public/linux/WebRenderTheme.h: Added.
  • src/linux/WebRenderTheme.cpp: Added.

(WebKit::setCaretBlinkInterval): Exposed API

5:42 AM Changeset in webkit [54279] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
​https://bugs.webkit.org/show_bug.cgi?id=34425

Reviewed by Kenneth Rohde Christiansen.

Buffer the sent data in SocketStreamHandlePrivate instead of relying on
the network layer to do it. This is more robust and more consistent with how
Qt's HTTP stack works.
Close the socket in SocketStreamHandlePrivate::close() regardless of its state.

No new tests, since no new functionality is introduced.

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp:
5:02 AM Changeset in webkit [54278] by hamaji@chromium.org
  • 45 edits in trunk/WebCore

2010-02-03 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed revert of r54259 as it seems to break chromium's unit tests.
The tests pass with r54257 but fail with r54260.
As r54258 and r54260 don't touch code, I'm reverting this change.

[V8] Generate toV8 conversion helpers, a la JSC bindings.
​https://bugs.webkit.org/show_bug.cgi?id=32563

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent):
  • bindings/v8/V8Collection.h: (WebCore::getV8Object): (WebCore::toNativeCollection): (WebCore::getNamedPropertyOfCollection): (WebCore::collectionNamedPropertyGetter): (WebCore::getIndexedPropertyOfCollection): (WebCore::collectionIndexedPropertyGetter): (WebCore::nodeCollectionIndexedPropertyEnumerator): (WebCore::collectionIndexedPropertyEnumerator): (WebCore::collectionStringOrNullIndexedPropertyGetter): (WebCore::collectionStringIndexedPropertyGetter): (WebCore::setCollectionIndexedGetter): (WebCore::setCollectionNamedGetter): (WebCore::setCollectionStringOrNullIndexedGetter): (WebCore::setCollectionStringIndexedGetter):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::downcastSVGPathSeg): (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toV8Object): (WebCore::V8CanvasRenderingContext2D::createPatternCallback):
  • bindings/v8/custom/V8CustomPositionCallback.cpp: (WebCore::V8CustomPositionCallback::handleEvent):
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp: (WebCore::V8CustomPositionErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp: (WebCore::V8CustomSQLStatementCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: (WebCore::V8CustomSQLTransactionCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openCallback): (WebCore::V8DOMWindow::indexedPropertyGetter): (WebCore::V8DOMWindow::namedPropertyGetter):
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::evaluateCallback): (WebCore::V8Document::getCSSCanvasContextCallback): (WebCore::V8Document::implementationAccessorGetter):
  • bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::V8Document::locationAccessorGetter):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNodeNSCallback):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::V8Event::dataTransferAccessorGetter): (WebCore::V8Event::clipboardDataAccessorGetter):
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLAllCollection::callAsFunctionCallback):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::V8Custom::v8HTMLAudioElementConstructorCallback):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLCollection::callAsFunctionCallback):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorGetter):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::V8HTMLFormElement::indexedPropertyGetter): (WebCore::V8HTMLFormElement::namedPropertyGetter):
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: (WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::V8Custom::v8HTMLImageElementConstructorCallback):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::V8HTMLSelectElement::namedPropertyGetter): (WebCore::V8HTMLSelectElement::indexedPropertyGetter):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScript): (WebCore::V8InjectedScriptHost::nodeForIdCallback): (WebCore::V8InjectedScriptHost::databaseForIdCallback):
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::portsAccessorGetter):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::indexedPropertyGetter): (WebCore::V8NamedNodeMap::namedPropertyGetter):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::V8NodeList::namedPropertyGetter): (WebCore::V8NodeList::callAsFunctionCallback):
  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback):
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::V8SVGMatrix::multiplyCallback): (WebCore::V8SVGMatrix::inverseCallback): (WebCore::V8SVGMatrix::rotateFromVectorCallback):
  • bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::V8StyleSheetList::namedPropertyGetter):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8Object):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::V8XSLTProcessor::transformToFragmentCallback): (WebCore::V8XSLTProcessor::transformToDocumentCallback):
2:54 AM Changeset in webkit [54277] by eric@webkit.org
  • 13 edits
    2 copies
    1 move
    3 adds in trunk/WebCore

2010-02-03 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Start unforking debugger and profiler code.

Remove custom implementation of Console.
Add 'ScriptProfiler' and 'ScriptProfile' types.
Start migration to engine-neutral types in InspectorController.

​https://bugs.webkit.org/show_bug.cgi?id=34481

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSConsoleCustom.cpp:
  • bindings/js/ScriptProfile.h: Added.
  • bindings/js/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
  • bindings/js/ScriptProfiler.h: Added.
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptProfile.h: Added. (WebCore::ScriptProfile::create): (WebCore::ScriptProfile::~ScriptProfile): (WebCore::ScriptProfile::title): (WebCore::ScriptProfile::uid): (WebCore::ScriptProfile::ScriptProfile):
  • bindings/v8/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
  • bindings/v8/ScriptProfiler.h: Added.
  • bindings/v8/custom/V8ConsoleCustom.cpp: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::endGroup): (WebCore::InspectorController::show): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole): (WebCore::InspectorController::createProfileHeader): (WebCore::InspectorController::getCurrentUserInitiatedProfileName): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::specialPanelForJSName):
  • inspector/InspectorController.h: (WebCore::InspectorController::searchingForNodeInPage):
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
  • page/Console.h: (WebCore::): (WebCore::Console::create): (WebCore::Console::profiles):
  • page/Console.idl:
2:13 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
1:50 AM Changeset in webkit [54276] by mnaganov@chromium.org
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/committers.py

Add myself to commiters.py

12:11 AM Changeset in webkit [54275] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Barth.

http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
​https://bugs.webkit.org/show_bug.cgi?id=33349

  • platform/win/Skipped: http/tests/security/xss-DENIED-window-open-javascript-url.html skipped.
Note: See TracTimeline for information about the timeline view.