⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 6, 2010:

12:18 PM Changeset in webkit [54466] by Dimitri Glazkov
  • 7 edits in trunk

2010-02-06 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r54364.
​http://trac.webkit.org/changeset/54364
​https://bugs.webkit.org/show_bug.cgi?id=34464

Introduced asserts in layout tests, needs more testing
locally.

  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
  • page/chromium/ChromeClientChromium.h:

2010-02-06 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r54364.
​http://trac.webkit.org/changeset/54364
​https://bugs.webkit.org/show_bug.cgi?id=34464

Introduced asserts in layout tests, needs more testing
locally.

  • public/WebViewClient.h:
  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:
11:02 AM Changeset in webkit [54465] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2010-02-06 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Using inlines and function-level statics don't mix, according to gcc.
​https://bugs.webkit.org/show_bug.cgi?id=34663

De-inline deviceRGBColorSpaceRef to avoid gcc-bug landmines.

It appears that the initialization check, generated by gcc doesn't account
for a possibility that the function may be inlined, resulting in lazy
initialization failure for more than one inlined instance of the function.

No behavior change, so no new tests.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::deviceRGBColorSpaceRef):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
12:55 AM Changeset in webkit [54464] by barraclough@apple.com
  • 15 edits in trunk/JavaScriptCore

Change UStringImpl::create to CRASH if the string cannot be allocated,
rather than returning a null string (which will behave like a zero-length
string if used).

Reviewed by Geoff Garen.

Also move createRep function from UString to become new overloaded
UStringImpl::create methods. In doing so, bring their behaviour closer to
being in line with WebCore::StringImpl, in removing the behaviour that they
can be used to produce null UStrings (ASSERT the char* provided is non-null).
This behaviour of converting null C-strings to null UStrings is inefficient
(cmompared to just using UString::null()), incompatible with WebCore::StringImpl's
behaviour, and may generate unexpected behaviour, since in many cases a null
UString can be used like an empty string.

With these changes UStringImpl need not have a concept of null impls, we can
start transitioning this to become an implementation detail of UString, that
internally it chooses to use a null-object rather than an actually zero impl
pointer.

(JSC::Debugger::recompileAllJSFunctions):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::calculatedFunctionName):

  • parser/Parser.cpp:

(JSC::Parser::parse):

  • profiler/Profile.cpp:

(JSC::Profile::Profile):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::stopProfiling):

  • runtime/Error.cpp:

(JSC::Error::create):
(JSC::throwError):

  • runtime/ExceptionHelpers.cpp:

(JSC::createError):

  • runtime/Identifier.cpp:

(JSC::Identifier::add):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

  • runtime/UString.cpp:

(JSC::initializeUString):
(JSC::UString::UString):
(JSC::UString::operator=):

  • runtime/UString.h:

(JSC::UString::isNull):
(JSC::UString::null):
(JSC::UString::rep):
(JSC::UString::UString):

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:

Feb 5, 2010:

10:32 PM Changeset in webkit [54463] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=34670
TestNetscapePlugin should work with Firefox

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if browser doesn't tell what it supports.
10:17 PM Changeset in webkit [54462] by mjs@apple.com
  • 10 edits in branches/safari-532-branch

JavaScriptCore: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • Configurations/FeatureDefines.xcconfig:

WebCore: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • win/tools/vsprops/FeatureDefines.vsprops:

WebKitTools: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • Scripts/build-webkit:
9:37 PM Changeset in webkit [54461] by hamaji@chromium.org
  • 7 edits in trunk

2010-02-05 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Gustavo Noronha Silva.

[Gtk] Implement layoutTestController.pageNumberForElementById
​https://bugs.webkit.org/show_bug.cgi?id=34572

  • platform/gtk/Skipped:

2010-02-05 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Gustavo Noronha Silva.

[Gtk] Implement layoutTestController.pageNumberForElementById
​https://bugs.webkit.org/show_bug.cgi?id=34572

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_page_number_for_element_by_id):

2010-02-05 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Gustavo Noronha Silva.

[Gtk] Implement layoutTestController.pageNumberForElementById
​https://bugs.webkit.org/show_bug.cgi?id=34572

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageNumberForElementById):
8:25 PM Changeset in webkit [54460] by ggaren@apple.com
  • 3 edits in trunk/WebCore

Added an ASSERT to catch an implausible but theoretically possible leak.

Reviewed by Dan Bernstein.

In theory, if malloc allocated a UChar buffer directly after a StringImpl,
the StringImpl might incorrecly assume that the UChar buffer was inline,
and fail to delete it.

This ASSERT is somewhat academic, since we don't use the same allocator
in debug builds, but oh well.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::createUninitialized):

  • platform/text/StringImpl.h: Separated the inline buffer StringImpl

constructor from the out-of-line buffer StringImpl constructor. Made
the former ASSERT that its buffer was indeed inline, and the latter ASSERT
that its buffer was indeed not inline.

6:50 PM Changeset in webkit [54459] by ggaren@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

Removed these special Windows expected results because they represented
incorrect behavior, fixed by a recent patch of mine.

Reviewed by Beth Dakin.

  • platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Removed.
6:44 PM Changeset in webkit [54458] by eric@webkit.org
  • 6 edits in trunk/WebKit/chromium

2010-02-05 James Hawkins <​jhawkins@chromium.org>

Reviewed by David Levin.

[Chromium] Rename autocomplete* to suggestions* to prepare for the
refactoring of AutocompletePopupMenuClient.

​https://bugs.webkit.org/show_bug.cgi?id=34664

  • public/WebView.h:
  • src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::popupDidHide):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::doAutofill):
  • src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutofillSuggestions): (WebKit::WebViewImpl::hideAutofillPopup): (WebKit::WebViewImpl::hideSuggestionsPopup): (WebKit::WebViewImpl::refreshSuggestionsPopup):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::suggestionsPopupDidHide):
6:28 PM Changeset in webkit [54457] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-05 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Define SYSTEM_MALLOC 1
​https://bugs.webkit.org/show_bug.cgi?id=34640

Make BREWMP use system malloc because FastMalloc is not ported.

  • wtf/Platform.h:
5:30 PM Changeset in webkit [54456] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

2010-02-05 Eric Carlson <​eric.carlson@apple.com>

Unreviewed revert of r54454, until I can generate new results

  • media/video-loop-expected.txt:
  • media/video-loop.html:
5:10 PM Changeset in webkit [54455] by cmarrin@apple.com
  • 4 edits in trunk/WebCore

Fixed changed virtual function in GraphicsLayerCACF and call order issues
​https://bugs.webkit.org/show_bug.cgi?id=34348


The correct virtual function in GraphicsLayerCACF is now being
called. We also fixed an issue in QTMovieWin where the size
of the movie was not being set correctly because the call order
was changed.


I also changed the order of a couple of calls in QTMovieWin to account
for changed calling order from the logic above.

4:49 PM Changeset in webkit [54454] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

2010-02-05 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=33671
[GTK] media/video-loop.html fails intermittently on Gtk Bots

Rewrite test to make it less timing dependent.

  • media/video-loop-expected.txt:
  • media/video-loop.html:
4:41 PM Changeset in webkit [54453] by mrowe@apple.com
  • 1 move in branches/old/WWDC-2009-branch

Move aside another old branch.

4:41 PM Changeset in webkit [54452] by dpranke@chromium.org
  • 2 edits
    3 adds in trunk/WebKitTools

2010-02-03 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Add a simple test implementation and the WebKit Mac implementation
for the layout_tests/port package. Also add a simple test driver of
that interface.

​https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/webkitpy/layout_tests/driver_test.py: Added.
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/mac.py: Added.
  • Scripts/webkitpy/layout_tests/port/test.py: Added.
4:40 PM Changeset in webkit [54451] by mrowe@apple.com
  • 5 moves in branches/old

Move aside some old branches.

4:29 PM Changeset in webkit [54450] by mrowe@apple.com
  • 1 copy in branches/safari-532-branch

New branch.

4:01 PM Changeset in webkit [54449] by dpranke@chromium.org
  • 22 edits
    2 adds
    1 delete in trunk/WebKitTools

2010-02-03 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Siedel.

Refactor the port package into an object-oriented style and merge
path_utils into it. We add a 'base' and a 'chromium' object to the
port package; this will allow us to easily add new ports (like
WebKit Mac).

​https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/run-chromium-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/base.py: Added.
  • Scripts/webkitpy/layout_tests/port/chromium.py: Added.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3:11 PM Changeset in webkit [54448] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-02-05 James Hawkins <​jhawkins@chromium.org>

Reviewed by David Levin.

[Chromium] Remove an unused forward declaration in WebKitClient.h.

​https://bugs.webkit.org/show_bug.cgi?id=34622

  • public/WebKitClient.h:
2:53 PM Changeset in webkit [54447] by kdecker@apple.com
  • 5 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=34661
<rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
  • Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView. (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
2:40 PM Changeset in webkit [54446] by enrica@apple.com
  • 2 edits
    2 adds in trunk/WebCore

Horizontal scrollbar works in reverse at milliondollarcu.be
<rdar://problem/7556121>
​https://bugs.webkit.org/show_bug.cgi?id=33848

Reviewed by Simon Fraser.

Added a manual test.

  • manual-tests/win: Added.
  • manual-tests/win/horizontal-scroll-composited.html: Added.
  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):

2:24 PM Changeset in webkit [54445] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
​https://bugs.webkit.org/show_bug.cgi?id=34662

  • platform/qt/Skipped: fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix.
2:04 PM Changeset in webkit [54444] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

Update expected results after r54441 to make buildbot happy.

  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated.
1:58 PM Changeset in webkit [54443] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-02-05 James Hawkins <​jhawkins@chromium.org>

Reviewed by Darin Fisher.

Implement WebInputElement::isActivatedSubmit().

​https://bugs.webkit.org/show_bug.cgi?id=34623

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::isActivatedSubmit):
1:37 PM Changeset in webkit [54442] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-02-05 Ryan Leavengood <​leavengood@gmail.com>

Reviewed by David Levin.

Implementation of GlyphPage::fill() for Haiku port.
​https://bugs.webkit.org/show_bug.cgi?id=34527

Covered by existing tests.

  • platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp
1:21 PM Changeset in webkit [54441] by kenneth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed, missed in earlier commit.

Add expected frame flattening results for Qt.

  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
12:47 PM Changeset in webkit [54440] by kenneth@webkit.org
  • 18 edits
    6 adds in trunk

Implement flattening of framesets
​https://bugs.webkit.org/show_bug.cgi?id=32717

Reviewed by Dave Hyatt.

WebCore:

The following patch, builds ontop of Antti Koivisto's frameset
flattening code from the iPhone source, which itself is based on
the old Nokia Series 60 source.

Layout tests have been added to test the functionality and the original
code which has then been fixed to make these pass, as well as support
frameset grids.

Tests: fast/frames/flattening/frameset-flattening-advanced.html

fast/frames/flattening/frameset-flattening-grid.html
fast/frames/flattening/frameset-flattening-simple.html
fast/frames/flattening/frameset-flattening-subframe-resize.html
fast/frames/flattening/frameset-flattening-subframesets.html

  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setFrameSetFlatteningEnabled):

  • page/Settings.h:

(WebCore::Settings::frameSetFlatteningEnabled):

  • rendering/RenderFrame.cpp:

(WebCore::RenderFrame::layoutWithFlattening):

  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::flattenFrameSet):
(WebCore::RenderFrameSet::userResize):

  • rendering/RenderFrameSet.h:

WebKit/qt:

Privately export the setFrameSetFlatteningEnabled setting for
use with the Qt DRT.

  • Api/qwebpage.cpp:

(qt_drt_setFrameSetFlatteningEnabled):
(QWebPagePrivate::core):

  • Api/qwebpage_p.h:

WebKitTools:

Add support for testing frame flattening with the Qt DRT

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setFrameSetFlatteningEnabled):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Frameset flattening layout test, plus expected result for Qt.

  • fast/frames/flattening/frameset-flattening-advanced.html: Added.
  • fast/frames/flattening/frameset-flattening-grid.html: Added.
  • fast/frames/flattening/frameset-flattening-simple.html: Added.
  • fast/frames/flattening/frameset-flattening-subframe-resize.html: Added.
  • fast/frames/flattening/frameset-flattening-subframesets.html: Added.
  • fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
12:44 PM Changeset in webkit [54439] by Chris Jerdonek
  • 9 edits in trunk/WebKitTools

Provided a way in check-webkit-style to specify filter rules
on a per file or folder basis, via a configuration variable.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=33684

  • Scripts/webkitpy/style/checker.py:
    • Added _PATH_RULES_SPECIFIER configuration variable.
    • In ProcessorOptions class--
      • Changed the CategoryFilter attribute to FilterConfiguration.
      • Added path parameter to is_reportable().
    • Renamed ArgumentDefaults filter_rules attribute to base_filter_rules.
    • Updated ArgumentPrinter class.
    • Added filter rule validation to ArgumentParser (instead of in CategoryFilter constructor).
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated unit tests as necessary.
    • Added unit tests for PATH_RULES_SPECIFIER.
  • Scripts/webkitpy/style/error_handlers.py:
    • Updated DefaultStyleErrorHandler to use file path when calling is_reportable().
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Updated unit tests as necessary.
  • Scripts/webkitpy/style/filter.py:
    • Marked CategoryFilter internal with an underscore.
    • Removed argument validation from CategoryFilter.
    • Added FilterConfiguration class.
  • Scripts/webkitpy/style/filter_unittest.py:
    • Updated CategoryFilterTest class.
    • Added FilterConfigurationTest unit tests.
  • Scripts/webkitpy/style/processors/cpp.py:
    • Removed _is_test_filename() code.
    • Removed hard-coded path checks from check_include_line().
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
    • Removed three unit tests related to exempted files.
11:50 AM Changeset in webkit [54438] by Simon Fraser
  • 7 edits
    2 adds in trunk

2010-02-05 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Changing display type of parent of input on focus causes input field to not receive key events
​https://bugs.webkit.org/show_bug.cgi?id=34620
<rdar://problem/7584572>

When layout affects a text input, the RenderTextControl gets destroyed and
recreated, which in turn makes a new innerTextElement. However, if the text field was
focused, the VisibleSelection is left pointing to the old innerTextElement, so text
input no longer works.

The fix is to call updateFocusAppearanceSoon() when attaching the input element,
which will update the selection if necessary.

Test: fast/forms/restore-selection-after-layout.html

  • dom/Document.h: Add a paramter to updateFocusAppearanceSoon() and a member variable, m_updateFocusAppearanceRestoresSelection, to store its value until the timer fires.
  • dom/Document.cpp: (WebCore::Document::Document): Initialize m_updateFocusAppearanceRestoresSelection (WebCore::Document::updateFocusAppearanceSoon): New restorePreviousSelection parameter. (WebCore::Document::updateFocusAppearanceTimerFired): Pass m_updateFocusAppearanceRestoresSelection down.
  • dom/Element.cpp: (WebCore::Element::attach): Call updateFocusAppearanceSoon() with false.
  • dom/Element.h: The updateFocusAppearanceSoonAfterAttach() was undefined.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach): Call document()->updateFocusAppearanceSoon() with true.
11:46 AM Changeset in webkit [54437] by kenneth@webkit.org
  • 3 edits in trunk/WebKitTools

[Qt] Apply the command line options as settings to the graphics system.

Reviewed by Ariya Hidayat.

  • QtLauncher/main.cpp:

(LauncherWindow::LauncherWindow):
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):

  • QtLauncher/webview.h:

(WebViewGraphicsBased::setItemCacheMode):

11:30 AM Changeset in webkit [54436] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2010-02-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: simplify cookies view, introduce DataGrid::autoSizeColumns.

​https://bugs.webkit.org/show_bug.cgi?id=34646

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.show): (WebInspector.CookieItemsView.prototype._update): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): (WebInspector.CookieItemsView.prototype._createDataGrid): (WebInspector.CookieItemsView.prototype._populateDataGrid.expiresCompare): (WebInspector.CookieItemsView.prototype._populateDataGrid): (WebInspector.CookieItemsView.prototype._createSimpleDataGrid): (WebInspector.CookieItemsView.prototype._populateSimpleDataGrid): (WebInspector.CookieItemsView.prototype._deleteCookieCallback): (WebInspector.CookieItemsView.prototype._refreshButtonClicked):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries): (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.autoSizeColumns):
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult):
11:22 AM Changeset in webkit [54435] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-02-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: group cookies by frame, show total
cookies size, allow sorting cookie table.

​https://bugs.webkit.org/show_bug.cgi?id=34617

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::deleteCookie):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._cookiesForDomain): (WebInspector.CookieItemsView.prototype.dataGridForCookies): (WebInspector.CookieItemsView.prototype._createNodes): (WebInspector.CookieItemsView.prototype._sortData.localeCompare): (WebInspector.CookieItemsView.prototype._sortData.numberCompare): (WebInspector.CookieItemsView.prototype._sortData.expiresCompare): (WebInspector.CookieItemsView.prototype._sortData):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect): (WebInspector.CookieSidebarTreeElement.prototype.get subtitle): (WebInspector.CookieSidebarTreeElement.prototype.set subtitle):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
11:08 AM Changeset in webkit [54434] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-05 Maxime Simone <Maxime Simon>

Reviewed by David Levin.

More robust conversion from BString to String for Haiku port.
​https://bugs.webkit.org/show_bug.cgi?id=34527

Covered by existing tests.

  • platform/text/haiku/StringHaiku.cpp: Fixed include order, Improved coversion from BString.
10:44 AM Changeset in webkit [54433] by mrowe@apple.com
  • 2 edits in tags/Safari-533.0.2/WebCore

Merge r54430.

10:43 AM Changeset in webkit [54432] by mrowe@apple.com
  • 4 edits in tags/Safari-533.0.2

Versioning.

10:41 AM Changeset in webkit [54431] by mrowe@apple.com
  • 1 copy in tags/Safari-533.0.2

New tag.

10:35 AM Changeset in webkit [54430] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

Reviewed by Adam Roben.

  • WebCore.vcproj/WebCore.make:
10:08 AM Changeset in webkit [54429] by Csaba Osztrogonác
  • 32 edits in trunk

Rubber-stamped by Kenneth Rohde Christiansen.
Reviewed by Dirk Schulze.

[Qt] Modifying SVG path dumping to equal to other ports
​https://bugs.webkit.org/show_bug.cgi?id=33784

WebCore:

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::debugString): Path dumping style is aproached to Mac.

LayoutTests:

Expected files updated.

  • platform/qt/svg/css/arrow-with-shadow-expected.txt:
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/qt/svg/css/clippath-with-shadow-expected.txt:
  • platform/qt/svg/css/mask-with-shadow-expected.txt:
  • platform/qt/svg/css/path-with-shadow-expected.txt:
  • platform/qt/svg/css/stars-with-shadow-expected.txt:
  • platform/qt/svg/custom/empty-mask-expected.txt:
  • platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/qt/svg/custom/marker-opacity-expected.txt:
  • platform/qt/svg/custom/marker-referencePoint-expected.txt:
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
  • platform/qt/svg/custom/mask-with-default-value-expected.txt:
  • platform/qt/svg/custom/relative-sized-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/qt/svg/custom/transformedMaskFails-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
9:46 AM Changeset in webkit [54428] by ggaren@apple.com
  • 8 edits in trunk

2010-02-05 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Alexey Proskuryakov.

Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
​https://bugs.webkit.org/show_bug.cgi?id=34569

With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.


However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.

If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.

  • wtf/FastMalloc.cpp: (WTF::fastMalloc): (WTF::fastCalloc):

2010-02-05 Sebastian Dröge <​sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=34317

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::doGstInit):
  • platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gtk/WebKitWebSourceGStreamer.h: Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure. This makes sure that referer, cookies, authentication information and all kinds of other context are passed to GStreamer for websites like Vimeo or YouTube.
9:24 AM Changeset in webkit [54427] by kov@webkit.org
  • 5 edits
    2 adds in trunk

2010-02-05 Sebastian Dröge <​sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=34317

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::doGstInit):
  • platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gtk/WebKitWebSourceGStreamer.h: Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure. This makes sure that referer, cookies, authentication information and all kinds of other context are passed to GStreamer for websites like Vimeo or YouTube.
8:41 AM Changeset in webkit [54426] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Fix build on Windows

Reviewed by Kenneth Rohde Christiansen.

DerivedSources for our API headers failed on Windows,
due to Windows not accepting ; as a command separator,
not needing quotes for echo, and needing < and > escaped.

We now detect Windows and set these quote markers and
escape markers accordingly, as well as use && for separating
individual commands.

  • Api/DerivedSources.pro:
8:28 AM Changeset in webkit [54425] by Nate Chapin
  • 17 edits in trunk

2010-02-05 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Clean up code for getting a v8::FunctionTemplate.


​https://bugs.webkit.org/show_bug.cgi?id=34606

  • bindings/scripts/CodeGeneratorV8.pm: Making GetTemplate() public
  • bindings/v8/V8Binding.cpp: (WebCore::configureTemplate):
  • bindings/v8/V8DOMWrapper.cpp: Remove getTemplate(), use V8ClassIndex::getTemplate() instead. (WebCore::V8DOMWrapper::getConstructor): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::lookupDOMWrapper):
  • bindings/v8/V8Index.cpp: Remove duplicate caching of FunctionTemplates. (WebCore::V8ClassIndex::getTemplate):
  • bindings/v8/V8Index.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::toV8):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback): (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.h:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback): (WebCore::V8HTMLImageElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLImageElementConstructor.h:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback): (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScriptHostV8Wrapper):
8:01 AM Changeset in webkit [54424] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Tor Arne Vestbø.

[Qt] fast/css/dashboard-regions-attr-crash.html skipped,
because ENABLE_DASHBOARD_SUPPORT=0 is the default option.

  • platform/qt/Skipped:
7:09 AM Changeset in webkit [54423] by eric@webkit.org
  • 1 edit
    1 add in trunk

2010-02-05 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Add .gitattributes file to tell git about files with Windows linefeeds
​https://bugs.webkit.org/show_bug.cgi?id=34645

On Windows git defaults to "true" for core.autocrlf, meaning all text
files in the working directory are converted from CRLF to LF on checkin
time. Some files present in the repository have been checked in with
CRLF linefeeds and git should not try to convert them. The added
.gitattributes file tells git to not do any CRLF conversion.

  • .gitattributes: Added.
6:10 AM Changeset in webkit [54422] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Build break in QtWebkit on Symbian
​https://bugs.webkit.org/show_bug.cgi?id=34597

Patch by Siddharth Mathur <​siddharth.mathur@nokia.com> on 2010-02-05
Reviewed by Ariya Hidayat.

  • plugins/PluginView.h:
6:08 AM Changeset in webkit [54421] by yurys@chromium.org
  • 30 edits in trunk

2010-02-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

  • Use SerializedScriptValue for passing data between injected script and inspector frontend.
  • Remove custom JSON implementation from the instpector utility script.
  • Make sure that only objects created in the same ScriptState can be values of ScriptObject/Array properties and arguments to ScriptFunctionCall. We don't want ScriptObjects to leak between contexts.
  • Use ScriptState of the 'this' object in ScriptFunctionCall instead of passing it as additional parameter.

​https://bugs.webkit.org/show_bug.cgi?id=33592

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::reportDidDispatchOnInjectedScript):
  • bindings/js/ScriptArray.cpp: (WebCore::ScriptArray::set):
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptFunctionCall::appendArgument):
  • bindings/js/ScriptFunctionCall.h:
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set):
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::serialize): (WebCore::ScriptValue::deserialize):
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptArray.cpp: (WebCore::ScriptArray::set):
  • bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptFunctionCall::appendArgument):
  • bindings/v8/ScriptFunctionCall.h:
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set):
  • bindings/v8/ScriptState.h:
  • bindings/v8/ScriptValue.cpp: (WebCore::ScriptValue::serialize): (WebCore::deserialize):
  • bindings/v8/ScriptValue.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::reportDidDispatchOnInjectedScriptCallback):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapForConsole): (WebCore::InjectedScript::releaseWrapperObjectGroup):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::didPause): (WebCore::InspectorController::didEvaluateForTestInFrontend):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::newScriptArray): (WebCore::InspectorFrontend::newScriptObject): (WebCore::InspectorFrontend::populateFrontendSettings): (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount): (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::didGetResourceContent): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::addRecordToTimeline): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::setDocument): (WebCore::InspectorFrontend::setDetachedRoot): (WebCore::InspectorFrontend::setChildNodes): (WebCore::InspectorFrontend::childNodeCountUpdated): (WebCore::InspectorFrontend::childNodeInserted): (WebCore::InspectorFrontend::childNodeRemoved): (WebCore::InspectorFrontend::attributesUpdated): (WebCore::InspectorFrontend::didRemoveNode): (WebCore::InspectorFrontend::didGetChildNodes): (WebCore::InspectorFrontend::didApplyDomChange): (WebCore::InspectorFrontend::didGetEventListenersForNode): (WebCore::InspectorFrontend::didGetCookies): (WebCore::InspectorFrontend::didDispatchOnInjectedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::didGetDatabaseTableNames): (WebCore::InspectorFrontend::addDOMStorage): (WebCore::InspectorFrontend::selectDOMStorage): (WebCore::InspectorFrontend::didGetDOMStorageEntries): (WebCore::InspectorFrontend::didSetDOMStorageItem): (WebCore::InspectorFrontend::didRemoveDOMStorageItem): (WebCore::InspectorFrontend::updateDOMStorage): (WebCore::InspectorFrontend::addNodesToSearchResult): (WebCore::InspectorFrontend::contextMenuItemSelected): (WebCore::InspectorFrontend::evaluateForTestInFrontend): (WebCore::InspectorFrontend::callSimpleFunction):
  • inspector/InspectorFrontend.h: (WebCore::InspectorFrontend::scriptState):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName.myCallback): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.addConsoleMessage):

2010-02-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Remove unused inmport of ScriptFunctionCall.h

​https://bugs.webkit.org/show_bug.cgi?id=33592

  • Api/qwebelement.cpp:
6:00 AM WebKit Team edited by krit@webkit.org
(diff)
5:23 AM Changeset in webkit [54420] by vestbo@webkit.org
  • 7 edits
    1 add
    1 delete in trunk

[Qt] Generate convenience headers (QWebView, etc) using qmake

Reviewed by Simon Hausmann.

In Qt this is done using syncqt, but we use a pro-file instead
that generates makefile-rules for each of the extra headers.

These extra headers are installed alongside the normal headers.

WebCore:

  • WebCore.pro: Use headers.pri based on DerivedSources instead

of the one previously checked in in the source tree.

WebKit/qt:

  • Api/DerivedSources.pro: Added. List of headers + pro file magic
  • Api/headers.pri: Removed, list of headers is now in the above file

WebKitTools:

  • Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
4:27 AM Changeset in webkit [54419] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
​https://bugs.webkit.org/show_bug.cgi?id=34569

Patch by Kwang Yul Seo <​skyul@company100.net> on 2010-02-05
Reviewed by Alexey Proskuryakov.

With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.

However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.

If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.

  • wtf/FastMalloc.cpp:

(WTF::fastMalloc):
(WTF::fastCalloc):

4:20 AM Changeset in webkit [54418] by abecsi@webkit.org
  • 2 edits in trunk/WebKitTools

2010-02-05 Andras Becsi <​abecsi@webkit.org>

Unreviewed typo fix.

Fix wrong whitespace alignment introduced in r54342.

4:05 AM Changeset in webkit [54417] by eric@webkit.org
  • 6 edits in trunk

2010-02-05 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Enable JAVASCRIPT_DEBUGGER in chromium port.

​https://bugs.webkit.org/show_bug.cgi?id=34638

  • page/Console.cpp:
  • page/Console.h:
  • page/Console.idl:

2010-02-05 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Enable JAVASCRIPT_DEBUGGER in chromium port.

​https://bugs.webkit.org/show_bug.cgi?id=34638

  • features.gypi:
3:45 AM Changeset in webkit [54416] by kenneth@webkit.org
  • 4 edits in trunk/WebKitTools

Rubberstamped by Oliver Hunt.

[Qt] Make it possible to choose whether the launcher should
use the traditional QWidget based QWebView or the newer
QGraphics based QGraphicsWebView on a QGraphicsView.

  • QtLauncher/main.cpp:

(LauncherWindow::LauncherWindow):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::print):
(LauncherWindow::screenshot):
(LauncherWindow::setEditable):
(LauncherWindow::setupUI):
(main):

  • QtLauncher/webview.cpp:

(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::resizeEvent):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::contextMenuEvent):

  • QtLauncher/webview.h:

(WebViewTraditional::WebViewTraditional):
(GraphicsWebView::GraphicsWebView):
(WebViewGraphicsBased::setPage):

2:50 AM Changeset in webkit [54415] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Tab width for javascript source is 8, should be 4

​https://bugs.webkit.org/show_bug.cgi?id=31248

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame):
  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype.set replaceTabsWithSpaces): (WebInspector.TextEditorModel.prototype._innerSetText): (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded):
1:37 AM Changeset in webkit [54414] by ukai@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-02-05 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

send() should return false, after frame that opened a WebSokcet is detached
​https://bugs.webkit.org/show_bug.cgi?id=34630

  • websocket/tests/send-after-close-on-unload-expected.txt: Added.
  • websocket/tests/send-after-close-on-unload.html: Added.
1:23 AM Changeset in webkit [54413] by tony@chromium.org
  • 6 edits
    2 adds in trunk

2010-02-05 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24872
Add a test to make sure copying from a list and pasting into a list
keeps the list at the same indention level rather than nesting.

  • editing/pasteboard/paste-list-002-expected.txt: Added.
  • editing/pasteboard/paste-list-002.html: Added.

2010-02-05 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24872
When pasting a list into another list should not indent another level.
If the cursor is at the beginning of the line, it should insert the
list items before the current list item. If the cursor is at the end
of the line, it should insert the list items after the current list item.

This matches Firefox and IE and makes the common activity of reordering a list
work as expected.

This also adds a small helper method (isListItem) to htmlediting.h.

Test: editing/pasteboard/paste-list-002.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::insertAsListItems):
  • editing/ReplaceSelectionCommand.h:
  • editing/htmlediting.cpp: (WebCore::isListItem): (WebCore::appendedSublist):
  • editing/htmlediting.h:
Note: See TracTimeline for information about the timeline view.