Timeline
Feb 7, 2010:
- 4:42 PM Changeset in webkit [54475] by
-
- 5 edits in trunk/LayoutTests
2010-02-07 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Fix 2 pixel test baselines that are incorrect but passing
the fuzzy image diff.
editing/deleting/5390681.html should show a cursor, but doesn't.
In r42549, whitespace collapsing was changed but
editing/pasteboard/5387578.html's result wasn't updated to
reflect the collapsed whitespace.
https://bugs.webkit.org/show_bug.cgi?id=34632
- platform/mac/editing/deleting/5390681-2-expected.checksum:
- platform/mac/editing/deleting/5390681-2-expected.png:
- platform/mac/editing/pasteboard/5387578-expected.checksum:
- platform/mac/editing/pasteboard/5387578-expected.png:
- 2:26 PM Changeset in webkit [54474] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-07 Daniel Bates <dbates@webkit.org>
Unreviewed, fix Tiger layout test failure.
Adds expected layout test results for Tiger build.
- platform/mac-tiger/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- 1:43 PM Changeset in webkit [54473] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-02-07 Daniel Bates <dbates@webkit.org>
Unreviewed, fix layout test bots.
Adds expected layout test results for Leopard, Windows, and Qt ports.
- platform/mac-leopard/fast/lists: Added.
- platform/mac-leopard/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- platform/win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- 1:08 PM Changeset in webkit [54472] by
-
- 9 edits2 adds in trunk
2010-02-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Implements all of the numeric CSS3 list-style-types as per
section 4.3 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#numeric>.
Test: fast/lists/w3-css3-list-styles-numeric.html
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- inspector/front-end/SourceCSSTokenizer.re2js:
- platform/text/CharacterNames.h: Added constant hyphenMinus.
- rendering/RenderListMarker.cpp: (WebCore::): Defined enum SequenceType. (WebCore::toAlphabeticOrNumeric): Added. (WebCore::toAlphabetic): Modified to call WebCore::toAlphabeticOrNumeric. (WebCore::toNumeric): Added. (WebCore::listMarkerSuffix): (WebCore::listMarkerText): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/style/RenderStyle.h: (WebCore::):
- rendering/style/RenderStyleConstants.h: Added numeric list style types and fixed indent level for the enum values. (WebCore::):
2010-02-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Tests that all of the numeric CSS3 list-style-types are supported.
- fast/lists/w3-css3-list-styles-numeric.html: Added.
- platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- 12:47 PM Changeset in webkit [54471] by
-
- 2 edits in trunk/WebCore
2010-02-07 Ismail Donmez <ismail@namtrac.org>
Reviewed by Darin Adler.
Include wtf/StringExtras.h for strdup definition, which
is needed for WinCE.
- bridge/IdentifierRep.h:
- 4:52 AM Changeset in webkit [54470] by
-
- 6 edits in trunk
2010-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fragment-held Elements Not Shown in Inspector.
- inspector/console-dirxml-expected.txt:
- inspector/console-dirxml.html:
2010-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fragment-held Elements Not Shown in Inspector.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
- 4:35 AM Changeset in webkit [54469] by
-
- 7 edits in trunk
2010-02-07 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
[chromium] Change chromium interface to handle DownloadURL format.
https://bugs.webkit.org/show_bug.cgi?id=34655
- platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clear): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ChromiumDataObject.h:
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::setData):
2010-02-07 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
[chromium] Change chromium interface to handle DownloadURL format.
https://bugs.webkit.org/show_bug.cgi?id=34655
- public/WebDragData.h:
- src/WebDragData.cpp: (WebKit::WebDragData::downloadMetadata): (WebKit::WebDragData::setDownloadMetadata):
- 3:42 AM Changeset in webkit [54468] by
-
- 2 edits2 adds in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662
Missing file added from the original bug: https://bugs.webkit.org/show_bug.cgi?id=32717
- fast/frames/flattening/resources: Added.
- fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
- platform/qt/Skipped: frameset-flattening-subframe-resize.html unskipped.
- 3:28 AM Changeset in webkit [54467] by
-
- 211 moves in tags/old
Move aside some old tags.
Feb 6, 2010:
- 12:18 PM Changeset in webkit [54466] by
-
- 7 edits in trunk
2010-02-06 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r54364.
http://trac.webkit.org/changeset/54364
https://bugs.webkit.org/show_bug.cgi?id=34464
Introduced asserts in layout tests, needs more testing
locally.
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
- page/chromium/ChromeClientChromium.h:
2010-02-06 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r54364.
http://trac.webkit.org/changeset/54364
https://bugs.webkit.org/show_bug.cgi?id=34464
Introduced asserts in layout tests, needs more testing
locally.
- public/WebViewClient.h:
- src/ChromeClientImpl.cpp:
- src/ChromeClientImpl.h:
- 11:02 AM Changeset in webkit [54465] by
-
- 3 edits in trunk/WebCore
2010-02-06 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
Using inlines and function-level statics don't mix, according to gcc.
https://bugs.webkit.org/show_bug.cgi?id=34663
De-inline deviceRGBColorSpaceRef to avoid gcc-bug landmines.
It appears that the initialization check, generated by gcc doesn't account
for a possibility that the function may be inlined, resulting in lazy
initialization failure for more than one inlined instance of the function.
No behavior change, so no new tests.
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::deviceRGBColorSpaceRef):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
- 12:55 AM Changeset in webkit [54464] by
-
- 15 edits in trunk/JavaScriptCore
Change UStringImpl::create to CRASH if the string cannot be allocated,
rather than returning a null string (which will behave like a zero-length
string if used).
Reviewed by Geoff Garen.
Also move createRep function from UString to become new overloaded
UStringImpl::create methods. In doing so, bring their behaviour closer to
being in line with WebCore::StringImpl, in removing the behaviour that they
can be used to produce null UStrings (ASSERT the char* provided is non-null).
This behaviour of converting null C-strings to null UStrings is inefficient
(cmompared to just using UString::null()), incompatible with WebCore::StringImpl's
behaviour, and may generate unexpected behaviour, since in many cases a null
UString can be used like an empty string.
With these changes UStringImpl need not have a concept of null impls, we can
start transitioning this to become an implementation detail of UString, that
internally it chooses to use a null-object rather than an actually zero impl
pointer.
- JavaScriptCore.exp:
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
- parser/Parser.cpp:
(JSC::Parser::parse):
- profiler/Profile.cpp:
(JSC::Profile::Profile):
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::stopProfiling):
- runtime/Error.cpp:
(JSC::Error::create):
(JSC::throwError):
- runtime/ExceptionHelpers.cpp:
(JSC::createError):
- runtime/Identifier.cpp:
(JSC::Identifier::add):
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/UString.cpp:
(JSC::initializeUString):
(JSC::UString::UString):
(JSC::UString::operator=):
- runtime/UString.h:
(JSC::UString::isNull):
(JSC::UString::null):
(JSC::UString::rep):
(JSC::UString::UString):
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
- runtime/UStringImpl.h:
