Context Navigation

Rename underscored identifiers in WebCore/css/CSSParser.cpp.
https://bugs.webkit.org/show_bug.cgi?id=34877
Also fix whitespace erros that surface due to the above fix.

This doesn't change the code logic. Hence no new tests are required.

css/CSSParser.cpp: (WebCore::CSSParser::parseValue):

9:14 PM Changeset in webkit [54702] by Joseph Pecoraro

2 edits in trunk/WebCore

2010-02-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Focusing a resource in the inspector should default to content not header
https://bugs.webkit.org/show_bug.cgi?id=34861

inspector/front-end/Settings.js: (WebInspector.Settings.prototype._load): changed initial default to content tab

9:01 PM Changeset in webkit [54701] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2010-02-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt and Darin Adler.

The rest of the fix for
https://bugs.webkit.org/show_bug.cgi?id=34864 | <rdar://problem/7594198>
Many objects left uncollected after visiting mail.google.com and closing
window

Don't unconditionally hang onto small strings. Instead, hang onto all
small strings as long as any small string is still referenced.

SunSpider reports no change.

runtime/Collector.cpp: (JSC::Heap::markRoots): Mark the small strings cache last, so it can check if anything else has kept any strings alive.

runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren): Only keep our strings alive if some other reference to at least one of them exists, too.

8:59 PM Changeset in webkit [54700] by Joseph Pecoraro

2 edits in trunk/WebCore

2010-02-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Editing Styles Cannot Tab Backwards from a New Style Item
https://bugs.webkit.org/show_bug.cgi?id=34872

inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.update): triggers afterUpdate (WebInspector.StylePropertiesSection.prototype.afterUpdate): factored out _afterUpdate handling

7:51 PM Changeset in webkit [54699] by Nikolas Zimmermann

2 edits in trunk/WebCore

2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

Add roundedIntSize() convenience method converting FloatSize to IntSize, just like roundedIntPoint() converting FloatPoint to IntPoint.

platform/graphics/FloatSize.h: (WebCore::roundedIntSize):

7:13 PM Changeset in webkit [54698] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-02-11 Eric Seidel <eric@webkit.org>

No review, build fix only.

webkitdirs.pm has a crazy amount of duplicated feature detection code
https://bugs.webkit.org/show_bug.cgi?id=34869

Scripts/build-webkit: Fix typo which broke bots.

7:04 PM Changeset in webkit [54697] by eric@webkit.org

5 edits
1 add
4 deletes in trunk

2010-02-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkitdirs.pm has a crazy amount of duplicated feature detection code
https://bugs.webkit.org/show_bug.cgi?id=34869

In editing run-webkit-tests I found these tests were
skipped on all platforms. Removing them since no one is running them.
If we ever need them we can dig them out of SVN history.

fast/wcss/marquee-dir.xhtml: Removed.
fast/wcss/marquee-loop.xhtml: Removed.
fast/wcss/marquee-speed.xhtml: Removed.
fast/wcss/marquee-style.xhtml: Removed.

2010-02-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkitdirs.pm has a crazy amount of duplicated feature detection code
https://bugs.webkit.org/show_bug.cgi?id=34869

Scripts/build-webkit: Use the new hotness.
Scripts/run-webkit-tests: ditto
Scripts/webkitdirs.pm: Remove a bunch of bad duplicate code.
Scripts/webkitperl/features.pm: Added.
- Simplified the 10 methods in webkitdirs.pm into 2 exported methods in this new file.

6:51 PM Changeset in webkit [54696] by ggaren@apple.com

4 edits in trunk/JavaScriptCore

2010-02-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

Some progress toward fixing
https://bugs.webkit.org/show_bug.cgi?id=34864 | <rdar://problem/7594198>
Many objects left uncollected after visiting mail.google.com and closing
window

SunSpider reports no change.

Keep weak references, rather than protected references, to cached for-in
property name enumerators.

One problem with protected references is that a chain like

[ gc object 1 ] => [ non-gc object ] => [ gc object 2 ]

takes two GC passes to break, since the first pass collects [ gc object 1 ],
releasing [ non-gc object ] and unprotecting [ gc object 2 ], and only
then can a second pass collect [ gc object 2 ].

Another problem with protected references is that they can keep a bunch
of strings alive long after they're useful. In SunSpider and a few popular
websites, the size-speed tradeoff seems to favor weak references.

runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): Moved this constructor into the .cpp file, since it's not used elsewhere.

(JSC::JSPropertyNameIterator::~JSPropertyNameIterator): Added a destructor
to support our weak reference.

runtime/JSPropertyNameIterator.h: (JSC::Structure::setEnumerationCache): (JSC::Structure::clearEnumerationCache): (JSC::Structure::enumerationCache): Added a function for clearing a Structure's enumeration cache, used by our new destructor. Also fixed indentation to match the rest of the file.

runtime/Structure.h: Changed from protected pointer to weak pointer.

6:37 PM Changeset in webkit [54695] by tkent@chromium.org

9 edits in trunk

2010-02-11 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix two issues on maxLength.
https://bugs.webkit.org/show_bug.cgi?id=34783

Add grapheme test cases
Improve test result readability

fast/forms/ValidityState-tooLong-input-expected.txt:
fast/forms/ValidityState-tooLong-textarea-expected.txt:
fast/forms/script-tests/ValidityState-tooLong-input.js:
fast/forms/script-tests/ValidityState-tooLong-textarea.js:

2010-02-11 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix two issues on maxLength.
https://bugs.webkit.org/show_bug.cgi?id=34783

ValidityState.tooLong behavior was inconsistent with UIs of <input> and <textarea>. tooLong checked Unicode code point length though the UIs checks grapheme cluster length.

Setting HTMLTextAreaElement::value didn't update the dirty flag.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::tooLong): Use numGraphemeClusters() instead of length().
html/HTMLTextAreaElement.cpp: Rename setValue() to setNonDirtyValue(), and introduce setValue() which calls setNonDirtyValue() and sets the dirty flag. (WebCore::HTMLTextAreaElement::childrenChanged): (WebCore::HTMLTextAreaElement::reset): (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::setNonDirtyValue): (WebCore::HTMLTextAreaElement::setDefaultValue): (WebCore::HTMLTextAreaElement::tooLong): Use numGraphemeClusters() instead of length().
html/HTMLTextAreaElement.h:

6:12 PM Changeset in webkit [54694] by ukai@chromium.org

10 edits
3 adds in trunk

2010-02-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket bufferedAmount should not be 0 when send after close.
https://bugs.webkit.org/show_bug.cgi?id=34633

websocket/tests/bufferedAmount-after-close-expected.txt: Added.
websocket/tests/bufferedAmount-after-close.html: Added.
websocket/tests/script-tests/bufferedAmount-after-close.js: Added.

2010-02-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket bufferedAmount should not be 0 when send after close.
https://bugs.webkit.org/show_bug.cgi?id=34633

Test: websocket/tests/bufferedAmount-after-close.html

websockets/ThreadableWebSocketChannelClientWrapper.h: (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
websockets/WebSocket.cpp: (WebCore::WebSocket::WebSocket): (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didClose):
websockets/WebSocket.h:
websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::didClose):
websockets/WebSocketChannel.h:
websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didClose):
websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
websockets/WorkerThreadableWebSocketChannel.h:

5:59 PM Changeset in webkit [54693] by dbates@webkit.org

7 edits
1 add in trunk/WebKitTools

2010-02-11 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=34830

Makes method User.prompt static and adds the parameter repeat
to prompt the user up to repeat times.

Scripts/test-webkitpy:
Scripts/webkitpy/bugzilla.py: Substituted method User.prompt for method raw_input.
Scripts/webkitpy/commands/upload.py: Ditto
Scripts/webkitpy/credentials.py: Ditto
Scripts/mock_bugzillatool.py: Updated prototype of MockUser.prompt to match User.prompt.
Scripts/webkitpy/user.py: Made method prompt static and added parameter repeat.
Scripts/webkitpy/user_unittest.py: Added.

5:48 PM Changeset in webkit [54692] by ukai@chromium.org

3 edits
6 adds in trunk

2010-02-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket in Worker failed to close
https://bugs.webkit.org/show_bug.cgi?id=34785

websocket/tests/workers/close-in-shared-worker-expected.txt: Added.
websocket/tests/workers/close-in-shared-worker.html: Added.
websocket/tests/workers/close-in-worker-expected.txt: Added.
websocket/tests/workers/close-in-worker.html: Added.
websocket/tests/workers/resources/close-in-worker.js: Added.
websocket/tests/workers/resources/echo_wsh.py: Copied from LayoutTests/websocket/tests/echo_wsh.py.

2010-02-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket in Worker failed to close
https://bugs.webkit.org/show_bug.cgi?id=34785

Tests: websocket/tests/workers/close-in-shared-worker.html

websocket/tests/workers/close-in-worker.html

websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::close):

5:39 PM Changeset in webkit [54691] by eric@webkit.org

1 edit
37 deletes in trunk/WebKitTools

2010-02-10 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Allow underscored identifiers in CSSParser.cpp

Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*.
WebCore/css/CSSParser.cpp needs to handle some such identifiers.
We should relax the style rule for the file to allow underscored identifiers.

https://bugs.webkit.org/show_bug.cgi?id=34787

Scripts/webkitpy/style/checker.py:

5:29 PM Changeset in webkit [54690] by yuzo@google.com

2 edits in trunk/WebKitTools

2010-02-10 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Allow underscored identifiers in CSSParser.cpp

Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*.
WebCore/css/CSSParser.cpp needs to handle some such identifiers.
We should relax the style rule for the file to allow underscored identifiers.

https://bugs.webkit.org/show_bug.cgi?id=34787

Scripts/webkitpy/style/checker.py:

5:01 PM Changeset in webkit [54689] by Nikolas Zimmermann

1 edit
2 moves in trunk/LayoutTests

2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Oops, move mac-lepard results for mask-invalidation.svg into the correct folder.

platform/mac-leopard/mask-invalidation-expected.checksum: Removed.
platform/mac-leopard/mask-invalidation-expected.png: Removed.
platform/mac-leopard/svg/custom/mask-invalidation-expected.checksum: Copied from platform/mac-leopard/mask-invalidation-expected.checksum.
platform/mac-leopard/svg/custom/mask-invalidation-expected.png: Copied from platform/mac-leopard/mask-invalidation-expected.png.

4:57 PM Changeset in webkit [54688] by eric@webkit.org

5 edits
1 copy in trunk/WebKitTools

2010-02-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Need a command to clear r+ on obsolete patches in the pending-commit queue.
https://bugs.webkit.org/show_bug.cgi?id=34863

Unfortunately our http://webkit.org/pending-commit bugzilla query is not
smart enough to ignore obsolete patches, so bugs show up there which are
still open, but do not have patches ready for landing on them.
This new command "clean-pending-commit" will remove r+ from obsolete patches
in the pending-commit list.

Scripts/test-webkitpy: Add grammar_unittest
Scripts/webkitpy/commands/upload.py: Add clean-pending-commit and make assign-to-committer ignore cq+'d patches.
Scripts/webkitpy/grammar.py: Add join_with_separators
Scripts/webkitpy/grammar_unittest.py: Added.

4:48 PM Changeset in webkit [54687] by Nikolas Zimmermann

1 edit
2 adds in trunk/LayoutTests

2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Add special mac-leopard pixel test results for svg/mask-invalidation.svg - has marginal 0.01% diff to snow leopard baseline.

platform/mac-leopard/mask-invalidation-expected.checksum: Added.
platform/mac-leopard/mask-invalidation-expected.png: Added.

4:38 PM Changeset in webkit [54686] by bweinstein@apple.com

2 edits in trunk/WebKitLibraries

Rubber-stamped by Eric Seidel.

Turn back on SVG Filters on Windows, as they were accidentally disabled and cause
test breakage.

win/tools/vsprops/FeatureDefines.vsprops:

4:36 PM Changeset in webkit [54685] by eric@webkit.org

1 edit
1 add in trunk/WebCore

2010-02-11 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add dummy Cursor
https://bugs.webkit.org/show_bug.cgi?id=34672

platform/brew/CursorBrew.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::dummyCursor): (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::moveCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):

4:20 PM Changeset in webkit [54684] by eric@webkit.org

1 edit
1 add in trunk/JavaScriptCore

2010-02-11 Chris Rogers <crogers@google.com>

Reviewed by David Levin.

audio engine: add Complex number class
https://bugs.webkit.org/show_bug.cgi?id=34538

wtf/Complex.h: Added. (WebCore::complexFromMagnitudePhase):

3:38 PM Changeset in webkit [54683] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-02-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

run-chromium-webkit-tests fails random pixel tests on Mac
https://bugs.webkit.org/show_bug.cgi?id=34862

This is due to the fact that the Mac port has an
invalid path to the image diff tool. Currently it points
to image_diff even though ImageDiff would be correct. We
can't change it to the right path yet without causing the
script to hang. ImageDiff expects to be long-running and
be passed image data over stdin. image_diff (chromium's fork)
expects to be passed command line arguments.
This fix works around the random failures by disabling pixel
tests on mac and logging if the user was trying to run with pixel
tests enabled.

Scripts/webkitpy/layout_tests/port/mac.py:

3:23 PM Changeset in webkit [54682] by bweinstein@apple.com

2 edits in trunk

Touch prefix files to force a rebuild, also so anyone who updates will get a working build

3:15 PM Changeset in webkit [54681] by bweinstein@apple.com

2 edits in trunk

Add a missing semicolon to FeatureDefines.vsprops, so both ENABLE_RUBY and ENABLE_SHARED_WORKERS are parsed

2:26 PM Changeset in webkit [54680] by Nate Chapin

4 edits in trunk/WebCore

2010-02-11 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Add back in a fast path for v8 object wrapping
when it's not possible we're in a WorkerContext (the fast
path is important for performance).

https://bugs.webkit.org/show_bug.cgi?id=34805

bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8ObjectInWorkerContext): (WebCore::V8DOMWrapper::instantiateV8Object):
bindings/v8/V8DOMWrapper.h:

2:23 PM Changeset in webkit [54679] by bweinstein@apple.com

1 edit in trunk/WebCore/bindings/js/JSDOMWindowCustom.cpp

Touch JSDOMWindowCustom.cpp to get it to build.

2:20 PM Changeset in webkit [54678] by kov@webkit.org

1 edit
2 deletes in trunk/LayoutTests

2010-02-11 Gustavo Noronha Silva <Gustavo Noronha Silva>

Remove platform-specific expected results that only existed
because we diverged from other ports regarding enabling
GeoLocation (Apple ports now enable it).

platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Removed.

2:12 PM Changeset in webkit [54677] by kov@webkit.org

3 edits in trunk/LayoutTests

2010-02-11 Gustavo Noronha Silva <Gustavo Noronha Silva>

Rebaseline test after 54646, and skip tests that need results
generated.

platform/gtk/Skipped:
platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:

2:12 PM Changeset in webkit [54676] by bweinstein@apple.com

1 edit in trunk/WebCore/page/DOMWindow.idl

Touch DOMWindow.idl to force a rebuild of some of the DOM bindings

1:53 PM Changeset in webkit [54675] by bweinstein@apple.com

1 edit in trunk/WebKit/win/WebKitPrefix.h

Touch WebKitPrefix.h to force a WebKit rebuild

1:44 PM Changeset in webkit [54674] by bweinstein@apple.com

1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

That wasn't a fix, rolling it out

1:34 PM Changeset in webkit [54673] by bweinstein@apple.com

1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Hopefully final build fix for Windows (I really mean it this time)

1:28 PM Changeset in webkit [54672] by ggaren@apple.com

8 edits in trunk

JavaScriptCore: Added an SPI for asking about all the different live objects on the heap.
Useful for memory debugging.

Reviewed by Oliver Hunt.

JavaScriptCore.exp: Export the new SPI.

runtime/Collector.cpp:

(JSC::typeName): Use a little capitalization. Don't crash in the case of
a non-object cell, since it might just be an uninitialized cell.

(JSC::Heap::objectTypeCounts): The new SPI.

runtime/Collector.h:
runtime/CollectorHeapIterator.h:

(JSC::CollectorHeapIterator::advance):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::operator++):
(JSC::ObjectIterator::operator++): Made 2 tweaks to these iterators:
(1) Skip the last cell in the block, since it's a dummy sentinel, and
we don't want it to confuse the object count; (2) Fixed a logic error
in LiveObjectIterator that could cause it to iterate dead objects if
m_block were equal to m_heap.nextBlock and m_cell were less than
m_heap.nextCell. No test for this since I can't think of a way that this
could make WebKit behave badly.

WebKit/mac: Exported some new JavaScript heap introspection.

Reviewed by Oliver Hunt.

Misc/WebCoreStatistics.h:
Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics javaScriptObjectTypeCounts]): Just like
javaScriptProtectedObjectTypeCounts, except this function enumerates all
live objects, not just protected objects.

1:20 PM Changeset in webkit [54671] by bweinstein@apple.com

2 edits in trunk

Turn off 3D_CANVAS and touch WebCorePrefix.h to force a rebuild.

1:04 PM Changeset in webkit [54670] by bweinstein@apple.com

1 edit in trunk/WebKit/win/WebView.cpp

Build fix for Windows

12:59 PM Changeset in webkit [54669] by Nikolas Zimmermann

2 edits in trunk/WebKitTools

2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Roben.
Try to fix build breakage from r54665.

Scripts/check-for-global-initializers:

12:53 PM Changeset in webkit [54668] by Nikolas Zimmermann

8 edits in trunk/WebCore

2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Small cleanups in SVG render tree code.
Centralize calls to inflateShadow(), in SVGRenderSupport::computeRectForRepaint,
instead of spreading them around the subclasses. All classes should inherit
protected from SVGRenderBase, made it consistent.

Doesn't affect layout tests.

rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::computeRectForRepaint):
rendering/RenderSVGImage.h:
rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::computeRectForRepaint):
rendering/RenderSVGRoot.h:
rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::computeRectForRepaint): (WebCore::RenderSVGText::layout):
rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::computeRectForRepaint):
rendering/SVGRootInlineBox.h:

12:44 PM Changeset in webkit [54667] by mnaganov@chromium.org

2 edits in trunk/WebKit/chromium

2010-02-11 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Ignore subsequent requests of the same profiler log
chunks. This eliminates emission of several instances for the same
heap snapshot.

https://bugs.webkit.org/show_bug.cgi?id=34833

src/js/ProfilerAgent.js: (devtools.ProfilerAgent): (devtools.ProfilerAgent.prototype.initializeProfiling): (devtools.ProfilerAgent.prototype._getNextLogLines): (devtools.ProfilerAgent.prototype.startProfiling): (devtools.ProfilerAgent.prototype._didGetActiveProfilerModules): (devtools.ProfilerAgent.prototype._didGetLogLines):

12:40 PM Changeset in webkit [54666] by xan@webkit.org

2 edits in trunk

2010-02-11 Xan Lopez <xlopez@igalia.com>

Try to fix GTK+ build.

configure.ac:

12:05 PM Changeset in webkit [54665] by hyatt@apple.com

8 edits
3 adds in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=34857
Move InlineIterator and BidiRun into new files so subclasses can access them.

Reviewed by Dan Bernstein.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
rendering/BidiRun.cpp: Added.

(WebCore::BidiRun::destroy):
(WebCore::throw):
(WebCore::BidiRun::operator delete):

rendering/BidiRun.h: Added.

(WebCore::BidiRun::BidiRun):
(WebCore::BidiRun::next):

rendering/InlineIterator.h: Added.

(WebCore::InlineIterator::InlineIterator):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::bidiNext):
(WebCore::bidiFirst):
(WebCore::InlineIterator::increment):
(WebCore::InlineIterator::atEnd):
(WebCore::InlineIterator::current):
(WebCore::InlineIterator::direction):
(WebCore::InlineBidiResolver::increment):
(WebCore::InlineBidiResolver::appendRun):

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::appendRunsForObject):
(WebCore::RenderBlock::requiresLineBox):

12:03 PM Changeset in webkit [54664] by bweinstein@apple.com

1 edit in trunk/WebCore/platform/graphics/GraphicsContext3D.h

Add a PLATFORM(WIN) check for NO_ERROR, attempted build fix

12:01 PM Changeset in webkit [54663] by bweinstein@apple.com

7 edits in trunk/WebCore

Revert accidental commit

11:55 AM Changeset in webkit [54662] by bweinstein@apple.com

7 edits in trunk/WebCore

Attempt to fix the Windows build

11:43 AM Changeset in webkit [54661] by bweinstein@apple.com

1 edit in trunk/WebCore/WebCorePrefix.h

Touch WebCorePrefix.h to force a rebuild.

11:00 AM Changeset in webkit [54660] by tonikitoo@webkit.org

2 edits in trunk

2010-02-11 Antonio Gomes <tonikitoo@webkit.org>

Adjust gstreamer-plugins-base minimum version check (from 0.10 to 0.10.23).

Reviewed by Xan Lopez.

configure.ac:

10:55 AM Changeset in webkit [54659] by yurys@chromium.org

32 edits
1 move
5 adds in trunk/LayoutTests

2010-02-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that Web Inspector can inspect styles of elements in iframe from a domain
different from main frame domain.

inspector-tests.js moved to LayoutTests/http/tests/inspector because it can
be referenced by relative path from LayoutTests/inspector but not vice versa
(html files served from LayoutTests/http/tests cannot refer it because WebKit
tests httpd doesn't serve content not under LayoutTests/http).

https://bugs.webkit.org/show_bug.cgi?id=31587

http/tests/inspector/inspect-iframe-from-different-domain-expected.txt: Added.
http/tests/inspector/inspect-iframe-from-different-domain.html: Added.
http/tests/inspector/inspector-test.js: Renamed from LayoutTests/inspector/inspector-test.js. (onload): (evaluateInWebInspector): (notifyDone): (output): (didEvaluateForTestInFrontend):
http/tests/inspector/resources/iframe-from-different-domain-data.html: Added.
inspector/console-clear.html:
inspector/console-dir.html:
inspector/console-dirxml.html:
inspector/console-format-collections-expected.txt:
inspector/console-format-collections.html:
inspector/console-format.html:
inspector/console-log-before-inspector-open.html:
inspector/console-tests.html:
inspector/cookie-resource-match.html:
inspector/elements-img-tooltip.html:
inspector/elements-panel-rewrite-href-expected.txt:
inspector/elements-panel-rewrite-href.html:
inspector/elements-panel-selection-on-refresh.html:
inspector/elements-panel-structure.html:
inspector/evaluate-in-frontend.html:
inspector/inspected-objects-not-overriden.html:
inspector/styles-iframe.html:
inspector/syntax-highlight-css.html:
inspector/syntax-highlight-javascript.html:
inspector/timeline-enum-stability.html:
inspector/timeline-event-dispatch.html:
inspector/timeline-layout.html:
inspector/timeline-mark-timeline.html:
inspector/timeline-network-resource.html:
inspector/timeline-paint.html:
inspector/timeline-parse-html.html:
inspector/timeline-recalculate-styles.html:
inspector/timeline-script-tag-1.html:
inspector/timeline-script-tag-2.html:
inspector/timeline-trivial.html:
platform/qt/Skipped:

10:27 AM Changeset in webkit [54658] by steveblock@google.com

2 edits in trunk/WebCore

Fixes CodeGeneratorV8.pm to include the header for the indexer type when using setCollectionIndexedGetter()
https://bugs.webkit.org/show_bug.cgi?id=34836

setCollectionIndexedGetter() uses getIndexedPropertyOfCollection(),
which in turn uses toV8() with the indexer type, which is declared in
the header for the indexer type.

9:16 AM Changeset in webkit [54657] by pfeldman@chromium.org

11 edits
2 adds
3 deletes in trunk/WebCore

2010-02-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: split source code into chunks in order to improve text
viewer performance on large files.

https://bugs.webkit.org/show_bug.cgi?id=34816

This change brings back SourceFrame's canvas+style magic, restores line
wrapping and makes things a lot like they used to be.
It removes TextEditor for now and renames NativeTextViewer into TextViewer.
TextViewer is no longer derived from TextEditor.
This TextViewer is still based on TextEditorModel, no iframes are involved.

Instead of creating div per line, TextViewer splits source code into 50 line
chunks. Upon scroll event, visible chunks are sharded into lines and individual
lines are highlighted. Whenever highlighted region gets outside of the visible
area, highlight spans are thrown away and region is replaced with the original
plain text chunk.

Complex stuff:

Whenever there is a need to manipulate individual lines (add message bubble / set breakpoint / reveal / etc.), individual chunks for such lines are created.
There is also an implicit machinery that is maintaining selection when it goes beyond the visible area.
Search occurrences are implemented as artificial spans interweaving highlighting markup.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/NativeTextViewer.js: Removed.
inspector/front-end/ScriptView.js: (WebInspector.ScriptView):
inspector/front-end/Settings.js:
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.set visible): (WebInspector.SourceFrame.prototype.set executionLine): (WebInspector.SourceFrame.prototype.revealLine): (WebInspector.SourceFrame.prototype.addBreakpoint): (WebInspector.SourceFrame.prototype.removeBreakpoint): (WebInspector.SourceFrame.prototype.addMessage): (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype.highlightLine): (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype.markAndRevealRange): (WebInspector.SourceFrame.prototype.clearMarkedRange): (WebInspector.SourceFrame.prototype._breakpointChanged): (WebInspector.SourceFrame.prototype._updateExecutionLine): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype._addExistingBreakpointsToSource): (WebInspector.SourceFrame.prototype._addBreakpointToSource): (WebInspector.SourceFrame.prototype._removeBreakpointFromSource): (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._editBreakpointCondition.committed): (WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed): (WebInspector.SourceFrame.prototype._editBreakpointCondition): (WebInspector.SourceFrame.prototype._showBreakpointConditionPopup): (WebInspector.SourceFrame.prototype._createConditionElement): (WebInspector.SourceFrame.prototype._keyDown): (WebInspector.SourceFrame.prototype.resize): (WebInspector.SourceFrame.prototype._drawProgramCounterInContext): (WebInspector.SourceFrame.prototype._drawProgramCounterImageIfNeeded): (WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded.drawBreakpoint): (WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded):
inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype._removeBreakpoint): (WebInspector.SourceView.prototype.searchCanceled): (WebInspector.SourceView.prototype._jumpToSearchResult):
inspector/front-end/TextEditor.js: Removed.
inspector/front-end/TextViewer.js: Added. (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.set mimeType): (WebInspector.TextViewer.prototype.get textModel): (WebInspector.TextViewer.prototype.revealLine): (WebInspector.TextViewer.prototype.addDecoration): (WebInspector.TextViewer.prototype.removeDecoration): (WebInspector.TextViewer.prototype.markAndRevealRange): (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextViewer.prototype._textChanged): (WebInspector.TextViewer.prototype._createChunkRow): (WebInspector.TextViewer.prototype._makeLineAChunk): (WebInspector.TextViewer.prototype._indexChunks): (WebInspector.TextViewer.prototype._highlightChanged): (WebInspector.TextViewer.prototype._scroll): (WebInspector.TextViewer.prototype.setCoalescingUpdate): (WebInspector.TextViewer.prototype._repaintAll): (WebInspector.TextViewer.prototype._chunkForOffset): (WebInspector.TextViewer.prototype._chunkNumberForLine): (WebInspector.TextViewer.prototype._chunkStartLine): (WebInspector.TextViewer.prototype._restoreChunks): (WebInspector.TextViewer.prototype._repaint): (WebInspector.TextViewer.prototype._getSelection): (WebInspector.TextViewer.prototype._restoreSelection): (WebInspector.TextViewer.prototype._selectionToPosition): (WebInspector.TextViewer.prototype._createLineRow): (WebInspector.TextViewer.prototype._paintLine): (WebInspector.TextViewer.prototype._createSpan): (WebInspector.TextViewer.prototype._createLink): (WebInspector.TextViewer.prototype._rewriteHref): (WebInspector.TextViewer.prototype._markRange): (WebInspector.TextViewer.prototype._decimalDigits): (WebInspector.TextViewer.prototype.resize):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.css:
inspector/front-end/inspector.html:
inspector/front-end/textEditor.css: Removed.
inspector/front-end/textViewer.css: Added.
inspector/front-end/utilities.js: (Node.prototype.traverseNextTextNode): (Node.prototype.rangeBoundaryForOffset):

8:18 AM Changeset in webkit [54656] by Csaba Osztrogonác

2 edits in trunk/WebCore

[Qt] ENABLE_RUBY flag was restored by r54649, but default value wasn't added for Qt port.
https://bugs.webkit.org/show_bug.cgi?id=34698

Reviewed by Tor Arne Vestbø.

WebCore.pri: Add ENABLE_RUBY=1 as default setting.

8:03 AM Changeset in webkit [54655] by steveblock@google.com

2 edits in trunk/JavaScriptCore

Guard cmath using declarations in MathExtras.h on Android
https://bugs.webkit.org/show_bug.cgi?id=34840

7:44 AM Changeset in webkit [54654] by Simon Hausmann

2 edits in trunk/WebKitTools

Make it possible to toggle accelerated compositing from the menu
at run-time.

Reviewed by Tor Arne Vestbø.

QtLauncher/main.cpp:

(LauncherWindow::toggleAcceleratedCompositing):
(LauncherWindow::setupUI):

7:37 AM QtWebKitTableOfFeatures46 edited by Henry Haverinen

(diff)

7:33 AM QtWebKitTableOfFeatures46 edited by Henry Haverinen

(diff)

5:29 AM Changeset in webkit [54653] by steveblock@google.com

2 edits in trunk/WebCore

2010-02-11 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Updates Android V8 Makefile to generate Notifications and WebSockets headers required by V8DOMWrapper.cpp
https://bugs.webkit.org/show_bug.cgi?id=34815

No new tests, build fix only.

Android.derived.v8bindings.mk:

5:27 AM Changeset in webkit [54652] by steveblock@google.com

2 edits in trunk/WebCore

2010-02-11 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Updates Android V8 Makefile to generate XPath header required by V8Proxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=34814

No new tests, build fix only.

Android.derived.v8bindings.mk:

3:40 AM Changeset in webkit [54651] by steveblock@google.com

2 edits in trunk/WebCore

Update Android V8 Makefile to generate Inspector headers required by V8 ScriptObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=34806

3:27 AM Changeset in webkit [54650] by steveblock@google.com

5 edits in trunk/WebCore

Guards SVG code in V8 bindings with ENABLE(SVG)
https://bugs.webkit.org/show_bug.cgi?id=34812

Also updates Android V8 Makefile to generate required SVG headers.

No new tests, build fix only.

2:55 AM Changeset in webkit [54649] by mjs@apple.com

25 edits in trunk