Context Navigation

submitForm wasn't respecting shouldAllowNavigation. Instead of calling
the wrapper function, we need to call shouldAllowNavigation because we
need to handle the "frame not found" case differently than the
"navigation denied" case.

Test: http/tests/security/sandboxed-iframe-form-top.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):

9:47 PM Changeset in webkit [54763] by eric@webkit.org

4 edits in trunk/WebKit/chromium

2010-02-14 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add support for the showDebugBorders setting to Chromium.

https://bugs.webkit.org/show_bug.cgi?id=34906

public/WebSettings.h: Add declaration for setShowDebugBorders
src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setShowDebugBorders): Add method implementation
src/WebSettingsImpl.h: Added declaration for setShowDebugBorders

9:31 PM Changeset in webkit [54762] by eric@webkit.org

2 edits in trunk/WebKit/gtk

2010-02-14 Diego Escalante Urrelo <descalante@igalia.com>

Reviewed by Gustavo Noronha Silva.

[gtk] WebKitDownload's currentSize property is guint, should be guint64
https://bugs.webkit.org/show_bug.cgi?id=34829

Actually use a guint64 for current-size property in WebKitDownload, we
were using a guint which is likely the cause for wrong sizes for files
over 4 Gb.

webkit/webkitdownload.cpp:

9:14 PM Changeset in webkit [54761] by eric@webkit.org

3 edits in trunk/LayoutTests

2010-02-14 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Adam Barth.

[Qt] The original test case failed on Qt because its real output
"A B C DE F" did not match the expected "A B C D E F". The input
field between D and E failed to generate the space in the dumped
text as it normally would if it was broken into a new line.
This DRT issue can be addressed in a seperate bug if necessary
but shrinking the size of font so as to fit all fields into one
line is an immediate fix to pass the test case.
https://bugs.webkit.org/show_bug.cgi?id=33093

fast/html/text-field-input-types.html:
platform/qt/Skipped:

8:58 PM Changeset in webkit [54760] by eric@webkit.org

10 edits in trunk/WebKitTools

2010-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Update rebaseline-chromium-webkit-tests to work with the new code
structure (port objects instead of path_utils and platform_utils).

Added a path_to_test_expectations_file() to the Port interface.

Fixed a bug in the chromium_* platform implementations where the
'target' option was assumed to be set.

Scripts/rebaseline-chromium-webkit-tests:
Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/chromium_linux.py:
Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

8:42 PM Changeset in webkit [54759] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-02-14 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

webkit-build-directory misuses terms
https://bugs.webkit.org/show_bug.cgi?id=34822

Scripts/webkit-build-directory:
- Add --top-level and --configuration options and make using one of them required.
Scripts/webkitpy/layout_tests/port/mac.py:
- Use --top-level instead of --base.

8:08 PM Changeset in webkit [54758] by tkent@chromium.org

5 edits in trunk/WebCore

2010-02-14 Kent Tamura <tkent@chromium.org>

No review. Touch RenderRuny*.cpp to fix Chromium/Windows build bot.

rendering/RenderRuby.cpp: Add a comment for #endf.
rendering/RenderRubyBase.cpp: Add a comment for #endf.
rendering/RenderRubyRun.cpp: Add a comment for #endf.
rendering/RenderRubyText.cpp: Add a comment for #endf.

8:22 AM Changeset in webkit [54757] by Laszlo Gombos

4 edits in trunk

2010-02-14 Chang Shu <Chang.Shu@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable appcache feature.
https://bugs.webkit.org/show_bug.cgi?id=34713

Re-land r54543 without the change in DumpRenderTree/qt/main.cpp.
Persistent storage for AppCache is already initialized in
DumpRenderTreeQt.cpp.

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage):

2010-02-14 Chang Shu <Chang.Shu@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable http/tests/appcache but skip the failed cases.
https://bugs.webkit.org/show_bug.cgi?id=34713

platform/qt/Skipped:

1:17 AM Changeset in webkit [54756] by pfeldman@chromium.org

3 edits in trunk/WebCore

2010-02-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: cache created row, span and text elements
in TextView to improve scroller performance on debug build.

https://bugs.webkit.org/show_bug.cgi?id=34921

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible):
inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.freeCachedElements): (WebInspector.TextViewer.prototype._buildChunks): (WebInspector.TextViewer.prototype._makeLineAChunk): (WebInspector.TextViewer.prototype._paintLine): (WebInspector.TextViewer.prototype._releaseLines): (WebInspector.TextViewer.prototype._appendSpan): (WebInspector.TextViewer.prototype._appendTextNode): (WebInspector.TextChunk): (WebInspector.TextChunk.prototype.set expanded): (WebInspector.TextChunk.prototype._lineNumberText): (WebInspector.TextChunk.prototype._createRow):

Feb 13, 2010:

10:22 PM UsingGitWithWebKit edited by Chris Jerdonek

Added tip on how to determine the path to git. (diff)

9:13 PM WikiStart edited by Chris Jerdonek

Made "Debugging WebKit with XCode" link directly to webkit.org. (diff)

1:44 PM ImprovingLifeOnWindows edited by jberlin@webkit.org

Setting WebKitOutputDir and WebKitLibrariesDir landed in r51932 (diff)

1:41 PM BuildingOnWindows edited by jberlin@webkit.org

Adding information about not being able to find SafariTheme.dll … (diff)

1:06 PM Changeset in webkit [54755] by bweinstein@apple.com

1 edit in trunk/WebCore/html/HTMLInputElement.cpp

Build fix for Windows, initialize success to false.

11:52 AM Changeset in webkit [54754] by tkent@chromium.org

5 edits in trunk/WebCore

2010-02-13 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Refactor parsing/serialization functions in HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=34852

Rename formStringToDouble() to parseToDoubleForNumberType()
Rename formStringToDateComponents() to parseToDateComponents()
Rename formStringFromDouble() to serializeForNumberType()
Add serializeForDateTimeTypes() The code is moved from setValueAsDate() and setDateValue().
Add serialize()

parseToDouble() is the top-level function to parse a
type-dependent string and return a double
value. parseToDoubleForNumber() and parseToDateComponents()
functions are helper functions for it. serialize() is the
top-level function to serialize a double value to a type-dependent
string, and serializeForNumberType() and
serializeForDateTimeTypes() are helper functions for it.

No tests because of no functional changes.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepMismatch): (WebCore::HTMLInputElement::getAllowedValueStep): (WebCore::HTMLInputElement::parseToDouble): (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::setValueAsDate): (WebCore::HTMLInputElement::setValueAsNumber): (WebCore::HTMLInputElement::serializeForDateTimeTypes): (WebCore::HTMLInputElement::serialize): (WebCore::HTMLInputElement::serializeForNumberType): (WebCore::HTMLInputElement::parseToDoubleForNumberType): (WebCore::HTMLInputElement::parseToDateComponents):
html/HTMLInputElement.h:
html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
rendering/RenderSlider.cpp: (WebCore::SliderRange::valueFromElement): (WebCore::RenderSlider::updateFromElement): (WebCore::RenderSlider::setValueForPosition):

7:39 AM Changeset in webkit [54753] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Skip new test that fails. See https://webkit.org/b/34918.

platform/qt/Skipped: fast/text/glyph-reordering.html skipped.

6:04 AM Changeset in webkit [54752] by kov@webkit.org

2 edits in trunk/LayoutTests

2010-02-13 Gustavo Noronha Silva <Gustavo Noronha Silva>

Skip new test that fails. See https://webkit.org/b/34918.

platform/gtk/Skipped:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed