⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 19, 2010:

7:06 PM Changeset in webkit [55043] by mjs@apple.com
  • 17 edits in trunk

2010-02-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

  • Configurations/FeatureDefines.xcconfig:

2010-02-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

  • win/tools/vsprops/FeatureDefines.vsprops:

2010-02-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

  • features.gypi:

2010-02-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

  • Configurations/FeatureDefines.xcconfig:

2010-02-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

I made ENABLE(SANDBOX) only control the sandbox attribute itself;
I did not ifdef the infrastructure to make sandboxing
switchable. This is because the likely concerns about sandboxing
are not stability of the infrastructure code, but rather the fact
that the security model exposed to authors is still evolving.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::parseMappedAttribute):

2010-02-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

  • configure.ac:

2010-02-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

  • Scripts/build-webkit: Handle new flag.
6:08 PM Changeset in webkit [55042] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-02-19 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Shinichiro Hamaji.

[style-queue] should not complain about identifier names with underscores under WebKit/efl/ewk/
​https://bugs.webkit.org/show_bug.cgi?id=35091

White list unix_hacker_style names in WebKit/efl/ewk because these
are used in the EFL API.

  • Scripts/webkitpy/style/checker.py:
    • Filter out readability/naming on WebKit/efl/ewk.
5:23 PM Changeset in webkit [55041] by ap@apple.com
  • 7 edits in trunk

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=35132
<rdar://problem/7664353> Mouse cursor sometimes flickers over Flash content (35132)

WebCore:

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Don't set mouse pointer when above a plug-in or applet to prevent flicker.

WebKit:

  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::mouseMoved): Send adjustCursor events on every mouse move. This matches Firefox, and is actually required for plug-ins to manipulate cursor wihout resorting to techniques such as fast firing timers.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): Some plug-ins handle mouse cursor internally, but those that don't just need to get an arrow cursor (matching Firefox). This means that e.g. a plugin inside <A> won't get a finger mouse pointer.
  • Plugins/WebHostedNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): (-[WebNetscapePluginView handleMouseExited:]): Implement this behavior here, too. Also, out of process code didn't reset mouse pointer on mouse exit, which it needed to do.
  • WebView/WebHTMLView.mm: (needsCursorRectsSupportAtPoint): (setCursor): (resetCursorRects): Make sure that the same workaround we have for Web content also applies to Netscape plug-ins, as AppKit would reset the mouse pointer to arrow if given a chance. (+[WebHTMLViewPrivate initialize]): Renamed setCursorIMP on Leopard and higher to prevent confusion - the method we override is completely different. (-[WebHTMLView hitTest:]): Added a FIXME about a likely bug.
4:51 PM Changeset in webkit [55040] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-19 Eric Seidel <​eric@webkit.org>

Reviewed by Dimitri Glazkov.

fast/forms/search-event-delay.html failed on Snow Leopard Debug Bot
​https://bugs.webkit.org/show_bug.cgi?id=33543

  • platform/mac-snowleopard/Skipped:
    • This test prints times and expects 0.1s precision even on Debug bots. That can't work. Skipping the test to make the bots green until this can be made non-flakey or until we have a layout test system which allows "failure" expectations.
4:45 PM Changeset in webkit [55039] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

Fix regression in calculating an animated image's start time.
​https://bugs.webkit.org/show_bug.cgi?id=35115

Reviewed by Adam Barth.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::startAnimation):

4:44 PM Changeset in webkit [55038] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-19 Eric Seidel <​eric@webkit.org>

Reviewed by Dimitri Glazkov.

editing/pasteboard/4641033.html timed out on Tiger Bot
​https://bugs.webkit.org/show_bug.cgi?id=33310

  • platform/mac-tiger/Skipped:
4:41 PM Changeset in webkit [55037] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-02-19 James Hawkins <​jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Call WebViewClient::didAcceptAutoFillSuggestion when the
user selects a suggestion from the AutoFill suggestions popup.

​https://bugs.webkit.org/show_bug.cgi?id=35174

  • public/WebViewClient.h: (WebKit::WebViewClient::didAcceptAutoFillSuggestion):
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::valueChanged):
  • src/AutoFillPopupMenuClient.h:
3:44 PM Changeset in webkit [55036] by ap@apple.com
  • 13 edits in trunk/WebCore

Reviewed by Geoffrey Garen.

​https://bugs.webkit.org/show_bug.cgi?id=35178
LiveConnect code uses hand-rolled fprintf logging

Changed to use LOG, LOG_ERROR and ASSERT.

  • platform/Logging.cpp: (WebCore::getChannelFromName):
  • platform/Logging.h:
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
  • platform/win/LoggingWin.cpp: (WebCore::InitializeLoggingChannelsIfNecessary): TextConversion channel was (almost) unused, renamed to LiveConnect.
  • platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerEncodingNames): The only use of this channel was in platform specific code, commandeered it for cross-platform needs.
  • bridge/jni/JNIBridge.cpp:
  • bridge/jni/JNIUtility.cpp: (JSC::Bindings::getJavaVM): (JSC::Bindings::getJNIEnv): (JSC::Bindings::getJNIField):
  • bridge/jni/JNIUtility.h: (JSC::Bindings::callJNIMethodV): (JSC::Bindings::callJNIStaticMethod):
  • bridge/jni/jni_jsobject.mm: (completedJavaScriptAccess): (dispatchToJavaScriptThread): (performJavaScriptAccess): (JavaJSObject::invoke): (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember): (JavaJSObject::getSlot): (JavaJSObject::setSlot): (JavaJSObject::toString): (JavaJSObject::createNative):
  • bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance):
  • bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper): (JObjectWrapper::~JObjectWrapper):
3:36 PM Changeset in webkit [55035] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

JSString::getIndex() calls value() to resolve the string value (is a rope)
to a UString, then passes the result to jsSingleCharacterSubstring without
checking for an exception. In case of out-of-memory the returned UString
is null(), which may result in an out-of-buounds substring being created.
This is bad.

Reviewed by Oliver Hunt.

Simple fix is to be able to get an index from a rope without resolving to
UString. This may be a useful optimization in some test cases.

The same bug exists in some other methods is JSString, these can be fixed
by changing them to call getIndex().

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSingleCharacterString):
(JSC::JSString::getStringPropertySlot):

  • runtime/UStringImpl.cpp:

(JSC::singleCharacterSubstring):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::singleCharacterSubstring):

3:07 PM Changeset in webkit [55034] by eric@webkit.org
  • 5 edits
    1 move in trunk/WebKitTools

2010-02-19 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Split out "prepare-rollout" from "rollout" and make --complete-rollout default
​https://bugs.webkit.org/show_bug.cgi?id=33745

  • Scripts/webkitpy/commands/download.py:
    • Add a new AbstractRolloutPrepCommand to share code between PrepareRollout and Rollout
    • Add PrepareRollout
  • Scripts/webkitpy/commands/download_unittest.py: Test PrepareRollout, remove CompleteRollout tests.
  • Scripts/webkitpy/steps/init.py: include ReopenBugAfterRollout step.
  • Scripts/webkitpy/steps/completerollout.py: Removed.
  • Scripts/webkitpy/steps/options.py: remove complete_rollout
  • Scripts/webkitpy/steps/reopenbugafterrollout.py: Added.
3:06 PM Changeset in webkit [55033] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-02-19 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

RenderSVGResourceMasker causes an Assert on Wind builds during DRT
​https://bugs.webkit.org/show_bug.cgi?id=35182

We remove the Assert for now and return earlier, if the HashMap of the Masker
does not contain the RenderObject. The RenderObject is an identifiert to get
a already calculated mask.
A race condition during parsing can cause the invalidation call, before the mask
got calculated (only during DRT on Win build bots).
The real bug will be fixed with: ​https://bugs.webkit.org/show_bug.cgi?id=35181

  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClient):
2:50 PM Changeset in webkit [55032] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-02-19 James Hawkins <​jhawkins@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Use the m_suggestionsPopupClient pointer to refer to the
popup client, as the Autocomplete popup might not be the current
popup.

​https://bugs.webkit.org/show_bug.cgi?id=35172

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::refreshSuggestionsPopup):
2:34 PM Changeset in webkit [55031] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-02-19 James Hawkins <​jhawkins@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to
onAutocompleteSuggestionAccepted to better match the purpose of the
function.

​https://bugs.webkit.org/show_bug.cgi?id=35171

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted):
  • src/EditorClientImpl.h:
  • src/SuggestionsPopupMenuClient.cpp: (WebKit::SuggestionsPopupMenuClient::valueChanged):
2:10 PM Changeset in webkit [55030] by Simon Fraser
  • 5 edits in trunk/WebKit/mac

2010-02-19 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article

Followup to avoid capturing compositing layers twice in snapshots. Add private
methods to WebView to specify whether drawing the WebView into an image will
include flattened compositing layers (the default behavior) or not.

  • WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]): Consult the WebView flag to see if we want flattening.
  • WebView/WebViewPrivate.h: New methods.
  • WebView/WebView.mm: Ditto. (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]):
  • WebView/WebViewData.h: New member variable.
1:44 PM Changeset in webkit [55029] by pkasting@chromium.org
  • 11 edits in trunk

WebCore: Make Pasteboard::writeImage() safe against NULL cachedImages, and clean
up some code.
​https://bugs.webkit.org/show_bug.cgi?id=35136

Reviewed by Darin Fisher.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateRenderer): Shorten some code.

  • page/DragController.cpp:

(WebCore::getImage): Shorten some code.

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage): NULL-check cachedImage().

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeImage): NULL-check cachedImage().

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeImage): NULL-check cachedImage().

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeImage): NULL-check cachedImage().

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeImage): NULL-check cachedImage().

WebKit/chromium: Add an isImageBlocked bool to the WebContextMenuData struct.
​https://bugs.webkit.org/show_bug.cgi?id=35136

Reviewed by Darin Fisher.

This lets us properly enable/disable the "Copy Image" context menu entry
(and, in the future, maybe add a "Load Image" function).

  • public/WebContextMenuData.h:
  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

1:30 PM Changeset in webkit [55028] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Rubberstamped by Noam Rosenthal, who wrote the original code.

Make mouse wheel scrolling work when using the GraphicsLayer.

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):

1:08 PM Changeset in webkit [55027] by oliver@apple.com
  • 7 edits
    1 add in trunk/JavaScriptCore

2010-02-19 Oliver Hunt <​oliver@apple.com>

RS = Gavin Barraclough.

Split the 32/64 version of JITPropertyAccess into a separate file.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp: Added. (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::emit_op_get_by_pname): (JSC::JIT::emitSlow_op_get_by_pname):
12:30 PM Changeset in webkit [55026] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json

2010-02-19 William Siegrist <​wsiegrist@apple.com>

Add GTK Linux 64-bit Release bot. Rename GTK Linux Release to GTK Linux 32-bit Release.

11:47 AM Changeset in webkit [55025] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-02-19 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Need a final integration between QtLauncher and QGVLauncher
​https://bugs.webkit.org/show_bug.cgi?id=35161

Add animated flip support to QtLauncher when running on QGraphicsView mode.

  • QtLauncher/main.cpp: (LauncherWindow::initializeView): (LauncherWindow::setupUI):
  • QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::animatedFlip): (WebViewGraphicsBased::animatedYFlip):
  • QtLauncher/webview.h: (WebViewGraphicsBased::setYRotation): (WebViewGraphicsBased::yRotation):
11:30 AM Changeset in webkit [55024] by eric@webkit.org
  • 2 edits
    1 move in trunk/JavaScriptCore

2010-02-19 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Laszlo Gombos.

Added additional parameter to create_rvct_stubs
for setting the regularexpression prefix.
Renamed it because it now works for other platforms too.
​https://bugs.webkit.org/show_bug.cgi?id=34951

  • DerivedSources.pro:
  • create_jit_stubs: Copied from JavaScriptCore/create_rvct_stubs.
  • create_rvct_stubs: Removed.
11:22 AM Changeset in webkit [55023] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-02-19 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Fix Worker crash regression in r54972

​https://bugs.webkit.org/show_bug.cgi?id=35166

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): Properly unwrap global objects when inside a WorkerContext.
11:09 AM Changeset in webkit [55022] by steveblock@google.com
  • 3 edits in trunk/WebCore

Not reviewed. Reverts r55020 which causes crashes in Chromium LayoutTests

10:59 AM Changeset in webkit [55021] by ap@apple.com
  • 5 edits in trunk

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=35165
plugins/set-status.html fails on Windows bot

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::status):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView status:]): Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as empty ones to chrome.
9:13 AM Changeset in webkit [55020] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-19 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

Sets default values of V8 runtime enabler flags to match behavior with JSC
​https://bugs.webkit.org/show_bug.cgi?id=35095

No new tests, modifies a Chromium feature only.

  • bindings/generic/RuntimeEnabledFeatures.cpp: Modified. Sets appcache and geolocation flag defaults to 'on'
  • storage/Database.cpp: Modified. Sets database flag default to 'on'.
9:13 AM Changeset in webkit [55019] by abecsi@webkit.org
  • 5 edits
    20 adds in trunk

[Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
for passing new tests and unskip the passing ones from the Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=35159

Reviewed by Kenneth Rohde Christiansen.

WebKitTools:

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::textZoomIn):
(EventSender::textZoomOut):

  • DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

  • platform/qt/Skipped: unskip passing tests
  • platform/qt/svg/custom/text-zoom-expected.txt: Added.
  • platform/qt/svg/zoom: Added.
  • platform/qt/svg/zoom/page: Added.
  • platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/qt/svg/zoom/text: Added.
  • platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
8:57 AM Changeset in webkit [55018] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-02-19 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Fixes GeolocationServiceBridgeImpl::stopUpdating (it can be called multiple times).

  • src/GeolocationServiceBridgeChromium.cpp: (WebKit::GeolocationServiceBridgeImpl::stopUpdating):
8:50 AM Changeset in webkit [55017] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-02-19 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Gustavo Noronha Silva.

[GTK] fast/forms/restore-selection-after-layout.html fails on 32bits Debug build
​https://bugs.webkit.org/show_bug.cgi?id=35158

  • platform/gtk/Skipped: Skip failing test
7:16 AM Changeset in webkit [55016] by eric@webkit.org
  • 9 edits
    2 adds in trunk

2010-02-19 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Elements panel: Correctly show empty elements' ending tags
for XML and HTML documents.
​https://bugs.webkit.org/show_bug.cgi?id=26315

  • inspector/console-dirxml-expected.txt:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-expected.txt:
  • inspector/elements-panel-limited-children-expected.txt:
  • inspector/elements-panel-structure-expected.txt: Re-baselined due to closing tags and ellipses between opening and closing tags
  • inspector/elements-panel-xhtml-structure-expected.txt: Added.
  • inspector/elements-panel-xhtml-structure.xhtml: Added.

2010-02-19 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Elements panel: Correctly show empty elements' ending tags
for XML and HTML documents.
​https://bugs.webkit.org/show_bug.cgi?id=26315

Test: inspector/elements-panel-xhtml-structure.xhtml

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode): (WebInspector.ElementsTreeOutline.prototype.get isXMLMimeType): (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired): (WebInspector.ElementsTreeElement.prototype.onexpand): (WebInspector.ElementsTreeElement.prototype.oncollapse): (WebInspector.ElementsTreeElement.prototype.updateTitle.callback): (WebInspector.ElementsTreeElement.prototype.updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
6:52 AM Changeset in webkit [55015] by abecsi@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed Changelog typo fix.

r5993 should be r54993.

6:45 AM Changeset in webkit [55014] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] plugins/set-status.html introduced in r5993 fails skipping it until fix.
​https://bugs.webkit.org/show_bug.cgi?id=35144

  • platform/qt/Skipped:
6:34 AM Changeset in webkit [55013] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-02-19 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Clean-up the handling of HTML5 persistent data for LayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=35004

DumpRenderTreeQt.cpp calls QWebSettings::enablePersistentStorage which sets up
and enables all HTML5 persistent data. All the other calls for setting the
persistent path or enabling the persistent feature are redundant.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): No need to enable AppCache again.
  • DumpRenderTree/qt/main.cpp: (main): No need to setup and enable HTML5 LocalStorage again.
5:13 AM Changeset in webkit [55012] by eric@webkit.org
  • 5 edits in trunk

2010-02-19 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Send the context menu event from contextClick() of EventSender
and do not show context menu in DRT.

LayoutTests:

fast/events/contextmenu-scrolled-page-with-frame.html

[Qt] DRT: Send context menu event from EventSender
​https://bugs.webkit.org/show_bug.cgi?id=35131

  • platform/qt/Skipped:

2010-02-19 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Send the context menu event from contextClick() of EventSender
and do not show context menu in DRT.

LayoutTests:

fast/events/contextmenu-scrolled-page-with-frame.html

[Qt] DRT: Send context menu event from EventSender
​https://bugs.webkit.org/show_bug.cgi?id=35131

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick):
5:01 AM Changeset in webkit [55011] by pfeldman@chromium.org
  • 5 edits in trunk

2010-02-19 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium build fix: reverting r54997 and r54998.
This is a two-sided change that should be coordinated.

  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::protocolAccessorSetter):
  • platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): (WebCore::KURL::isHierarchical):
4:41 AM Changeset in webkit [55010] by Csaba Osztrogonác
  • 2 edits
    2 copies in trunk/LayoutTests

[Qt] editing tests fails after r54980
​https://bugs.webkit.org/show_bug.cgi?id=35145

Reviewed by Kenneth Rohde Christiansen.

After r54980 two tests fail, skip them until fix.
Another two tests pass, they have same results as Win port.

  • platform/qt/Skipped:
    • editing/selection/extend-selection.html skipped.
    • editing/selection/extend-after-mouse-selection.html skipped.
  • platform/qt/editing/selection/click-in-margins-inside-editable-div-expected.txt: Copied from LayoutTests/platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt.
  • platform/qt/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Copied from LayoutTests/platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt.
4:40 AM Changeset in webkit [55009] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-02-19 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium tests fix: update devtools code to match new
web inspector object proxy format.

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.formatCallFrame_): (devtools.DebuggerAgent.formatObjectProxy_):
4:06 AM Changeset in webkit [55008] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-02-19 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

[GTK] plugins/set-status.html fails
​https://bugs.webkit.org/show_bug.cgi?id=35144

  • platform/gtk/Skipped: Skip failing test.
1:18 AM Changeset in webkit [55007] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2010-02-19 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

Adding a GTK layout test result for a new test
added in r54980.

  • platform/gtk/editing/selection/extend-after-mouse-selection-expected.txt: Added.
1:18 AM Changeset in webkit [55006] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2010-02-19 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

Adding a GTK layout test result for a new test
added in r54982.

  • platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
12:30 AM Changeset in webkit [55005] by Philippe Normand
  • 2 edits
    1 add in trunk/WebCore

2010-02-17 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Seidel.

[GTK] RTP/RTSP streams playback support
​https://bugs.webkit.org/show_bug.cgi?id=33662

Added live pipelines support in updateStates().

  • manual-tests/video-rtsp.html: Added.
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::updateStates):

Feb 18, 2010:

11:49 PM Changeset in webkit [55004] by mjs@apple.com
  • 10 edits in branches/safari-532-branch

mark-radar-fixed
<rdar://problem/7540469> Disable ruby support for the branch

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

WebKitTools:

  • Scripts/build-webkit:
11:32 PM Changeset in webkit [55003] by Csaba Osztrogonác
  • 6 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] Update platform specific expected files after r54991.

  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: updated.
  • platform/qt/svg/css/mask-with-shadow-expected.txt: updated.
  • platform/qt/svg/custom/empty-mask-expected.txt: updated.
  • platform/qt/svg/custom/mask-with-default-value-expected.txt: updated.
  • platform/qt/svg/custom/transformedMaskFails-expected.txt: updated.
10:23 PM Changeset in webkit [55002] by oliver@apple.com
  • 9 edits in trunk/JavaScriptCore

2010-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Improve interpreter getter performance
​https://bugs.webkit.org/show_bug.cgi?id=35138

Improve the performance of getter dispatch by making it possible
for the interpreter to cache the GetterSetter object lookup.

To do this we simply need to make PropertySlot aware of getters
as a potentially cacheable property, and record the base and this
objects for a getter access. This allows us to use more-or-less
identical code to that used by the normal get_by_id caching, with
the dispatch being the only actual difference.

I'm holding off of implementing this in the JIT until I do some
cleanup to try and making coding in the JIT not be as horrible
as it is currently.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • runtime/JSObject.cpp: (JSC::JSObject::fillGetterPropertySlot):
  • runtime/PropertySlot.cpp: (JSC::PropertySlot::functionGetter):
  • runtime/PropertySlot.h: (JSC::PropertySlot::isGetter): (JSC::PropertySlot::isCacheable): (JSC::PropertySlot::isCacheableValue): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setGetterSlot): (JSC::PropertySlot::setCacheableGetterSlot): (JSC::PropertySlot::clearOffset): (JSC::PropertySlot::thisValue):
9:17 PM Changeset in webkit [55001] by eric@webkit.org
  • 5 edits
    2 adds in trunk/WebKitTools

2010-02-18 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Moved parsing-related code to a separate file. Also increased
the unit test coverage in some affected areas.

​https://bugs.webkit.org/show_bug.cgi?id=34675

This revision contains no new functionality.

  • Scripts/check-webkit-style:
    • Adjusted to call check_webkit_style_parser().
  • Scripts/webkitpy/style/checker.py:
    • Added check_webkit_style_parser() to pass checker.py configuration settings to optparser.py.
    • Moved _create_usage() and the CommandOptionValues, DefaultCommandOptionValues, ArgumentPrinter, and ArgumentParser classes to optparser.py.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Moved the ProcessorOptionsTest, ArgumentPrinterTest, and ArgumentParserTest classes to optparser.py.
    • Added the CheckWebKitStyleFunctionTest class to check the check_webkit_style_configuration() and check_webkit_style_parser() code paths.
  • Scripts/webkitpy/style/optparser.py: Added.
    • From checker.py, added _create_usage() and the CommandOptionValues, DefaultCommandOptionValues, ArgumentPrinter, and ArgumentParser classes.
    • In the ArgumentParser constructor--
      • Added all_categories as a required parameter.
      • Removed the default value from the default_options parameter.
  • Scripts/webkitpy/style/optparser_unittest.py: Added.
    • From checker_unittest.py, added the ProcessorOptionsTest, ArgumentPrinterTest, and ArgumentParserTest classes.
    • Added the CreateUsageTest class to test _create_usage().
  • Scripts/webkitpy/style/unittests.py:
    • Added optparser_unittest import.
9:14 PM Changeset in webkit [55000] by mjs@apple.com
  • 2 edits in branches/safari-532-branch/WebKitLibraries
  • Add change I missed in the last commit.


  • win/tools/vsprops/FeatureDefines.vsprops:
9:00 PM Changeset in webkit [54999] by eric@webkit.org
  • 14 edits
    3 adds in trunk

2010-02-18 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Adler.

Normalize custom ctors for Image, Option, Audio
​https://bugs.webkit.org/show_bug.cgi?id=34782

  • fast/js/custom-constructors-expected.txt: Added.
  • fast/js/custom-constructors.html: Added.
  • fast/js/script-tests/custom-constructors.js: Added.

2010-02-18 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Adler.

Normalize custom ctors for Image, Option, Audio
​https://bugs.webkit.org/show_bug.cgi?id=34782

Test: fast/js/custom-constructors.html

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): (WebCore::constructAudio):
  • bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback):
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback):
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback):
  • html/HTMLAudioElement.cpp: (WebCore::HTMLAudioElement::HTMLAudioElement): (WebCore::HTMLAudioElement::createForJSConstructor):
  • html/HTMLAudioElement.h:
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::createForJSConstructor): (WebCore::HTMLImageElement::mapToEntry): (WebCore::HTMLImageElement::createRenderer): (WebCore::HTMLImageElement::attach): (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height): (WebCore::HTMLImageElement::naturalHeight):
  • html/HTMLImageElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::HTMLOptionElement): (WebCore::HTMLOptionElement::createForJSConstructor): (WebCore::HTMLOptionElement::ownerSelectElement): (WebCore::HTMLOptionElement::nonRendererRenderStyle): (WebCore::HTMLOptionElement::disabled): (WebCore::HTMLOptionElement::insertedIntoTree):
  • html/HTMLOptionElement.h:
8:29 PM Changeset in webkit [54998] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-02-12 Kent Tamura <​tkent@chromium.org>

Unreviewed. Fix Chromium build.

  • DEPS: Bump Google URL revision to 123.
6:06 PM Changeset in webkit [54997] by brettw@chromium.org
  • 3 edits in trunk/WebCore

2010-02-12 Brett Wilson <​brettw@chromium.org>

Reviewed by Adam Barth.

Update the Google-URL version of KURL and the V8 bindings to the new
behavior of KURL.IsStandard.

​https://bugs.webkit.org/show_bug.cgi?id=34859

This is covered by fast/dom/Window/invalid-protocol.html

  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::protocolAccessorSetter):
  • platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): (WebCore::KURL::isHierarchical):
5:21 PM Changeset in webkit [54996] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=35134
<rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testSetStatus): (pluginInvoke): Added a setStatus() method.
4:47 PM Changeset in webkit [54995] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-02-18 Simon Fraser <Simon Fraser>

No Review.

Remove a couple of extraneous spaces that got added to the project file
by hand-ending.

  • WebCore.xcodeproj/project.pbxproj:
4:44 PM Changeset in webkit [54994] by Simon Fraser
  • 8 edits in trunk

2010-02-18 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article

Add logic to determine when painting via the software rendering path will give an equivalent
result to the accelerated compositing presentation. This tests for the presence of 3D transforms
via the existing RenderLayerCompositor::has3DContent() method.

  • WebCore.base.exp: Export FrameView's isSoftwareRenderable(), paintBehavior() and setPaintBehavior().
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::isSoftwareRenderable): New method. (WebCore::FrameView::paintBehavior): Make this non-inline so that we can reliably export it.
4:37 PM Changeset in webkit [54993] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=35134
<rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)

Test: plugins/set-status.html

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::status): (WebKit::NetscapePluginInstanceProxy::loadURL): Added null checks for CFStringCreateWithCString arguments.
4:19 PM Changeset in webkit [54992] by mitz@apple.com
  • 5 edits
    2 adds in trunk

<rdar://problem/7658811> Multiple style recalcs due to getComputedStyle() on “display: none;” element
when there are pending style sheets

Reviewed by John Sullivan.

WebCore:

Test: fast/css/getComputedStyle/pending-stylesheet.html

When querying a property of a computed style declaration for a non-rendered element,
CSSStyleSelector::styleForElement() was called, and if there were pending style sheet, it
would behave as if the lack of renderer is due to FOUC suppression, and set a flag on
the document causing it to recalculate style. On the next computed style property access,
style would be recalculated for the document, but then the flag would get set again if the
element did not have a renderer.

  • dom/Document.cpp:

(WebCore::Document::styleForElementIgnoringPendingStylesheets): Added. Temporarily sets
m_ignorePendingStylesheets around the call to CSSStyleSelector::styleForElement().

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::computedStyle): Use Document::styleForElementIgnoringPendingStylesheets().

LayoutTests:

  • fast/css/getComputedStyle/pending-stylesheet-expected.txt: Added.
  • fast/css/getComputedStyle/pending-stylesheet.html: Added.
3:12 PM Changeset in webkit [54991] by krit@webkit.org
  • 52 edits
    3 adds
    2 deletes in trunk

2010-02-18 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Move SVGResources to Renderers, starting with Masker
​https://bugs.webkit.org/show_bug.cgi?id=35020

We have rendering specific code in WebCore/svg/graphics. The goal is to move
this code into suitable Renderers. This helps us to clean up the code and makes
maintenance easier. It also makes it possible to remove rendering specific code
from SVG*Elements into this renderers. So the Renderer contains everything that
is needed to use the resource.
RenderSVGResource will be the base class for all new resource render classes like
RenderSVGResourceMasker, RenderSVGResourceClipper and the other resources.

This patch starts moving SVGResourceMasker to RenderSVGResourceMasker.
Another benefit is the much more useful result in DRT on using masker.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::toRenderSVGResource): Conversion to RenderSVGResource base class.
  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGResource): Check if renderer is a resource.
  • rendering/RenderPath.cpp:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::destroy): Renderer gets destroyed, unregister it from it's resources.
  • rendering/RenderSVGImage.h: Some code clean up according to the webkit style. (WebCore::RenderSVGImage::toSVGRenderBase): (WebCore::RenderSVGImage::renderName): (WebCore::RenderSVGImage::isSVGImage): (WebCore::RenderSVGImage::localToParentTransform): (WebCore::RenderSVGImage::strokeBoundingBox): (WebCore::RenderSVGImage::requiresLayer): (WebCore::RenderSVGImage::localTransform):
  • rendering/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::objectBoundingBox): Needed for SVGRenderTreeAsText
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::destroy): Renderer gets destroyed, unregister it from it's resources.
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGResource.h: Added. (WebCore::): Base class for all Resource renderers like masker, clipper and others. (WebCore::RenderSVGResource::RenderSVGResource): (WebCore::RenderSVGResource::cast): (WebCore::RenderSVGResource::toRenderSVGResource): (WebCore::RenderSVGResource::isSVGResource): (WebCore::RenderSVGResource::drawsContents): (WebCore::getRenderSVGResourceById):
  • rendering/RenderSVGResourceMasker.cpp: Added. (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker): (WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker): (WebCore::RenderSVGResourceMasker::invalidateClients): Status of masker changed, remove all clients. (WebCore::RenderSVGResourceMasker::invalidateClient): Status of an object changed, remove pending client. (WebCore::RenderSVGResourceMasker::applyResource): Apply masker to object. (WebCore::RenderSVGResourceMasker::resourceBoundingBox): boundingBox of the resource, depending on the object. (WebCore::RenderSVGResourceMasker::createMaskImage): Creates the mask image, the context gets clipped with.
  • rendering/RenderSVGResourceMasker.h: Added. (WebCore::MaskerData::MaskerData): (WebCore::RenderSVGResourceMasker::renderName): (WebCore::RenderSVGResourceMasker::maskUnits): Unit of mask for DRT. (WebCore::RenderSVGResourceMasker::maskContentUnits): Unit of childs from mask for DRT. (WebCore::RenderSVGResourceMasker::resourceType):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::destroy): Renderer gets destroyed, unregister it from it's resources.
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::destroy): dito.
  • rendering/RenderSVGText.h:
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer): (WebCore::SVGRenderBase::deregisterFromResources): Unregister object from all it's resources after status changed.
  • rendering/SVGRenderSupport.h: (WebCore::SVGRenderBase::toSVGRenderBase): (WebCore::SVGRenderBase::strokeBoundingBox): (WebCore::SVGRenderBase::markerBoundingBox):
  • rendering/SVGRenderTreeAsText.cpp: Update TreeAsText to dump maskers correctly. (WebCore::operator<<): (WebCore::writeSVGResource): (WebCore::writeSVGContainer): (WebCore::writeSVGText): (WebCore::writeSVGInlineText): (WebCore::writeSVGImage): (WebCore::write): (WebCore::writeResourcesToObject):
  • rendering/SVGRenderTreeAsText.h:
  • svg/SVGMaskElement.cpp: Update Masker to use the new renderer. (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): (WebCore::SVGMaskElement::maskBoundingBox): (WebCore::SVGMaskElement::createRenderer):
  • svg/SVGMaskElement.h:
  • svg/SVGStyledElement.cpp: We need to tell the renderer to unregister object, after the status changed. (WebCore::SVGStyledElement::invalidateResources): (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
  • svg/SVGUnitTypes.h: Conversion of integer to SVGUnitType. (WebCore::toUnitType):
  • svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isMarker):
  • svg/graphics/SVGResourceMasker.cpp: Removed.
  • svg/graphics/SVGResourceMasker.h: Removed.

2010-02-18 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Move SVGResources to Renderers, starting with Masker
​https://bugs.webkit.org/show_bug.cgi?id=35020

With the move from SVGResourceMasker to RenderSVGResourceMasker, I changed
the way DRT dumps resources. DRT is now able to dump multi-access
of resources.
Also the size of a Mask resource (depending of the object) and the access of
the resource (togeter with the resource name) is pointed out as an insertion
under the object.

  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/mac/svg/css/mask-with-shadow-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
  • platform/mac/svg/custom/js-late-mask-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-mask-creation-expected.txt:
  • platform/mac/svg/custom/mask-changes-expected.txt:
  • platform/mac/svg/custom/mask-child-changes-expected.txt:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
  • platform/mac/svg/custom/mask-inside-defs-expected.txt:
  • platform/mac/svg/custom/mask-invalidation-expected.txt:
  • platform/mac/svg/custom/mask-on-multiple-objects-expected.txt:
  • platform/mac/svg/custom/mask-with-all-units-expected.txt:
  • platform/mac/svg/custom/mask-with-default-value-expected.txt:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/mac/svg/custom/visibility-override-mask-expected.txt:
  • platform/mac/svg/filters/filter-clip-expected.txt:
  • svg/custom/transformedMaskFails-expected.txt:
2:51 PM Changeset in webkit [54990] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Allow creating/dropping virtual tables when the module is FTS2.

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=34867

  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::createVTable):
(WebCore::DatabaseAuthorizer::dropVTable):

2:40 PM Changeset in webkit [54989] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed, Chromium build fix.

r54963 had a typo in the WebCore.gypi change.
​https://bugs.webkit.org/show_bug.cgi?id=35003

  • WebCore.gypi:
2:15 PM Changeset in webkit [54988] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed a portion of:
<rdar://problem/7165917> | ​https://bugs.webkit.org/show_bug.cgi?id=28676
Safari 4 does not release memory back to the operating system fast enough (28676)

Reviewed by Oliver Hunt.

This patch fixes a surprisingly common edge case in which the page heap
would have only one free span, but that span would be larger than the
minimum free size, so we would decide not to free it, even though it
could be as large as 100MB or more!

SunSpider reports no change on Mac or Windows.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::scavenge): Call shouldContinueScavenging() instead
of doing the math ourselves. Don't keep a local value for pagesDecommitted
because that lets free_committed_pages_ be wrong temporarily. Instead,
update free_committed_pages_ as we go. ASSERT that we aren't releasing
a span that has already been released, because we think this is impossible.
Finally, don't be afraid to release all free memory in the page heap when
scavenging. We only scavenge after 5 seconds of the application's working
set not growing, and we keep both thread caches and a central cache on
top of the page heap, so the extra free pages in the page heap were just
overkill.

2:08 PM Changeset in webkit [54987] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-18 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Simon Fraser.

Changing forward declaration of TimingFunction in GraphicsLayer.h from
class to struct to match its actual definition in TimingFunction.h

​https://bugs.webkit.org/show_bug.cgi?id=35069

  • platform/graphics/GraphicsLayer.h:

Change forward declaration from: class TimingFunction to:
struct TimingFunction

1:50 PM Changeset in webkit [54986] by eric@webkit.org
  • 4 edits in trunk

2010-02-18 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Minor improvement to hybrid QPixmap
​https://bugs.webkit.org/show_bug.cgi?id=34507
Instead of having toHTMLImageElement which creates a new element,
assignToHTMLImageElement would set an existing HTML <img/> element to
contain the native QPixmap/QImge.
Also made some style fixes.

Additions to existing tests: see WebKit/qt/tests

  • bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapWidthField::valueFromInstance): style (JSC::Bindings::QtPixmapHeightField::valueFromInstance): style (JSC::Bindings::QtPixmapAssignToElementMethod::name): assignTo (JSC::Bindings::QtPixmapAssignToElementMethod::invoke): new function (JSC::Bindings::QtPixmapAssignToElementMethod::numParameters): 1 (JSC::Bindings::QtPixmapToDataUrlMethod::invoke): style (JSC::Bindings::QtPixmapToStringMethod::invoke): style (JSC::Bindings::QtPixmapInstance::invokeMethod): style (JSC::Bindings::QtPixmapClass::methodsNamed): new func, removed old (JSC::Bindings::QtPixmapInstance::getPropertyNames): ditto (JSC::Bindings::QtPixmapInstance::defaultValue): style (JSC::Bindings::QtPixmapInstance::valueOf): style (JSC::Bindings::QtPixmapInstance::toPixmap): style (JSC::Bindings::QtPixmapInstance::variantFromObject): style

2010-02-18 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Minor improvement to hybrid QPixmap
​https://bugs.webkit.org/show_bug.cgi?id=34507

  • tests/hybridPixmap/test.html: use assignToHTMLImageElement on an existing element instead of toHTMLImageElement which creates a new one
1:15 PM Changeset in webkit [54985] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-18 Gustavo Noronha Silva <Gustavo Noronha Silva>

[Qt][GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
​https://bugs.webkit.org/show_bug.cgi?id=35086

Skip both new tests that fail. It may be a DRT problem, and the
file path that is reported in the error message also seems to
require tweaking.

  • platform/gtk/Skipped:
1:07 PM Changeset in webkit [54984] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed, bustage fix.

An extraneous line in r54839 broke GIF animation.

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::read):

1:03 PM Changeset in webkit [54983] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-18 Gustavo Noronha Silva <Gustavo Noronha Silva>

[GTK] Fails fast/multicol/client-rects.html
​https://bugs.webkit.org/show_bug.cgi?id=35127

Skip test that fails in GTK+ - trying to get bot green again.

  • platform/gtk/Skipped:
12:55 PM Changeset in webkit [54982] by mitz@apple.com
  • 3 edits
    1 copy
    3 adds in trunk

<rdar://problem/7650652> REGRESSION: Selection painting issue in bug review textbox
​https://bugs.webkit.org/show_bug.cgi?id=34946

Reviewed by Simon Fraser.

WebCore:

Test: fast/repaint/selection-gap-overflow-scroll-2.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintSelection): localToContainerQuad() adjusts for
overflow scroll, but RenderLayer::addBlockSelectionGapsBounds() takes
non-scrolled coordinates, so account for that.

LayoutTests:

  • fast/repaint/selection-gap-overflow-scroll-2.html: Copied from LayoutTests/fast/repaint/selection-gap-overflow-scroll.html.
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum: Added.
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
12:52 PM Changeset in webkit [54981] by dumi@chromium.org
  • 10 edits in trunk

WebCore: Change the V8 and JSC SQLStatementErrorCallback to interpret
'undefined' return values as 'true', as required by the spec.

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=35048

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallbackHelper):
(WebCore::invokeCallback):
(WebCore::invokeCallbackTreatUndefinedAsTrue):

  • bindings/v8/custom/V8CustomVoidCallback.h:

LayoutTests: 'undefined' return values from statement error callbacks are not
treated as 'true'. Fix the tests that did not use this
assumption.

Reviewed by NOBODY Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=35048

  • storage/database-lock-after-reload.html:
  • storage/private-browsing-readonly.html:
  • storage/statement-error-callback.html:
  • storage/statement-error-callback-expected.txt:
11:38 AM Changeset in webkit [54980] by ojan@chromium.org
  • 12 edits
    4 adds in trunk

2010-02-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

keyboard selection sometimes moves the wrong end of the selection for Win/Linux
​https://bugs.webkit.org/show_bug.cgi?id=35066

The changes to js-test-selection-shared.js are just to make the selection editing tests
easier to debug in the future.

The mac results for extend-after-mouse-selection.html contain a "FAIL" line. This is
a case where WebKit doesn't match TextEdit.

  • editing/editing.js: (execMoveSelectionForwardByLineBoundaryCommand): (moveSelectionForwardByLineBoundaryCommand): (execExtendSelectionForwardByLineBoundaryCommand): (extendSelectionForwardByLineBoundaryCommand): (execExtendSelectionBackwardByLineBoundaryCommand): (extendSelectionBackwardByLineBoundaryCommand): (execMoveSelectionBackwardByLineBoundaryCommand): (moveSelectionBackwardByLineBoundaryCommand):
  • editing/selection/extend-after-mouse-selection.html: Added.
  • editing/selection/move-begin-end-expected.txt:
  • editing/selection/move-begin-end.html:
  • editing/selection/resources/js-test-selection-shared.js: (objectAsString): (assertSelectionAt):
  • platform/mac/editing/selection/click-in-margins-inside-editable-div-expected.txt:
  • platform/mac/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
  • platform/mac/editing/selection/extend-after-mouse-selection-expected.txt: Added.
  • platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt:
  • platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
  • platform/win/editing/selection/extend-after-mouse-selection-expected.txt: Added.
  • platform/win/editing/selection/extend-selection-expected.txt: Added.

2010-02-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

keyboard selection sometimes moves the wrong end of the selection for Win/Linux
​https://bugs.webkit.org/show_bug.cgi?id=35066

On Windows/Linux keyboard based selections should always move the same
end of the seleciton. On Mac, lineboundary and documentboundary changes
move different ends of the selection depending on which direction your
extending.

Test: editing/selection/extend-after-mouse-selection.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::positionForPlatform): (WebCore::SelectionController::startForPlatform): (WebCore::SelectionController::endForPlatform): (WebCore::SelectionController::modifyExtendingRight): (WebCore::SelectionController::modifyExtendingForward): (WebCore::SelectionController::modifyMovingForward): (WebCore::SelectionController::modifyExtendingBackward): (WebCore::SelectionController::modifyMovingBackward):
  • editing/SelectionController.h:
11:36 AM Changeset in webkit [54979] by timothy@apple.com
  • 3 edits in trunk/WebCore

Add "with" to the list of keywords to syntax highlight.

​http://webkit.org/b/35123

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer): Add "width" to _keywords.

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:

(WebInspector.SourceJavaScriptTokenizer): Ditto.

11:35 AM Changeset in webkit [54978] by pkasting@chromium.org
  • 7 edits in trunk/WebCore

Rework PNG-in-ICO decoding to copy the decoded framebuffer into the ICO
decoder, making the logic less crazy and more like the other decoders.
​https://bugs.webkit.org/show_bug.cgi?id=28751

Reviewed by Adam Barth.

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::RGBA32Buffer::operator=):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::RGBA32Buffer::RGBA32Buffer):

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::frameBufferAtIndex):
(WebCore::ICOImageDecoder::decodeAtIndex):

  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/qt/RGBA32BufferQt.cpp:

(WebCore::RGBA32Buffer::operator=):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::RGBA32Buffer::operator=):

11:19 AM CommitQueue edited by eric@webkit.org
(diff)
11:19 AM CommitQueue edited by eric@webkit.org
(diff)
11:14 AM CommitQueue edited by eric@webkit.org
(diff)
11:13 AM CommitQueue edited by eric@webkit.org
(diff)
11:11 AM CommitQueue edited by eric@webkit.org
(diff)
11:10 AM CommitQueue edited by eric@webkit.org
(diff)
11:08 AM Changeset in webkit [54977] by Nate Chapin
  • 3 edits in trunk/LayoutTests

2010-02-18 Nate Chapin <Nate Chapin>

Unreviewed, build fix.

Provide good expected results for fast/dom/Window/window-event-override-no-crash.html.

11:05 AM Changeset in webkit [54976] by sfalken@apple.com
  • 1 edit in trunk/WebKitLibraries/win/lib/WebKitSystemInterface_debug.lib

Windows build fix.

10:59 AM Changeset in webkit [54975] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-18 Gustavo Noronha Silva <Gustavo Noronha Silva>

[GTK][Qt] Fails glyph reordering test fast/text/glyph-reordering.html
​https://bugs.webkit.org/show_bug.cgi?id=34918

Unskipping that now passes, after r54912.

  • platform/gtk/Skipped:
10:53 AM Changeset in webkit [54974] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-02-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: multiple popovers on screen at the same time.

​https://bugs.webkit.org/show_bug.cgi?id=35105

  • inspector/front-end/Popover.js: (WebInspector.Popover.prototype.show): (WebInspector.Popover.prototype.hide):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup):
10:45 AM Changeset in webkit [54973] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-02-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Expand Object.proto properly.

​https://bugs.webkit.org/show_bug.cgi?id=35113

  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
  • inspector/front-end/inspector.js: (WebInspector.log.logMessage): (WebInspector.log):
10:40 AM Changeset in webkit [54972] by Nate Chapin
  • 4 edits in trunk/WebCore

2010-02-18 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

[V8] Merge the DOMWindow and WorkerContext object wrapping code paths,
and use a faster method of disambiguating between the types of contexts.

​https://bugs.webkit.org/show_bug.cgi?id=35009

  • bindings/scripts/CodeGeneratorV8.pm: Remove logic determining whether we need to

handle the WorkerContext case.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::globalObjectPrototypeIsDOMWindow): (WebCore::V8DOMWrapper::instantiateV8Object): Merge instantiateV8Object paths.
  • bindings/v8/V8DOMWrapper.h:
10:25 AM Changeset in webkit [54971] by xan@webkit.org
  • 3 edits in trunk/WebCore

2010-02-18 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove some duplication between PluginView and Widget methods, and
move the setSelfVisible calls to the parent class.

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::show): (WebCore::Widget::hide):
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide):
9:51 AM Changeset in webkit [54970] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-02-18 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

<rdar://problem/7655195> Switch Leopard back to using CGShading to avoid CGGradient leaks

Define USE_CG_SHADING on for Tiger and Leopard, and use it to toggle the methods
used for Core Graphics gradient drawing.

  • platform/graphics/Gradient.h:
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformDestroy): (WebCore::Gradient::paint):
9:36 AM Changeset in webkit [54969] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-02-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: on-hover evaluation renders nodes and arrays as strings.

​https://bugs.webkit.org/show_bug.cgi?id=35103

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
9:32 AM Changeset in webkit [54968] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-02-18 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Don't truncate long lines when evaluating expressions on a breakpoint.

​https://bugs.webkit.org/show_bug.cgi?id=35102

  • src/js/DebuggerAgent.js:
9:31 AM Changeset in webkit [54967] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-02-18 A S Alam <​amanpreet.alam@gmail.com>

Punjabi translation.

  • pa.po: Added.
9:13 AM Changeset in webkit [54966] by beidson@apple.com
  • 13 edits
    2 adds in trunk

Particularly constructed WebFrames can try to access a null HistoryItem
<rdar://problem/7638892> and ​https://bugs.webkit.org/show_bug.cgi?id=35063

Reviewed by Sam Weinig.

WebCore:

Test: fast/loader/api-test-new-window-data-load-base-url.html

  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateBackForwardListForFragmentScroll): We have a known case where a fragment scroll

might take place with a null m_currentItem. updateBackForwardListClippedAtTarget() will either move m_currentItem
to m_previousItem then create a new m_currentItem... or it will do nothing. So we either have both an m_currentItem
and m_previousItem, or we have neither. In the case where we have no m_previousItem, return early.

WebKitTools:

Add the specific ability to test this API pattern.

For now only on Mac, perhaps on the main Windows port later, probably not relevant for other ports.

  • DumpRenderTree/LayoutTestController.cpp:

(apiTestNewWindowDataLoadBaseURLCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(-[APITestDelegate initWithCompletionCondition:]):
(-[APITestDelegate webView:didFailLoadWithError:forFrame:]):
(-[APITestDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
(-[APITestDelegate webView:didFinishLoadForFrame:]):
(LayoutTestController::apiTestNewWindowDataLoadBaseURL): Create a WebView, do a loadData: in its

mainFrame, and synchronously wait for main load completion.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::apiTestNewWindowDataLoadBaseURL):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::apiTestNewWindowDataLoadBaseURL):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::apiTestNewWindowDataLoadBaseURL):

LayoutTests:

  • fast/loader/api-test-new-window-data-load-base-url-expected.txt: Added.
  • fast/loader/api-test-new-window-data-load-base-url.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:08 AM Changeset in webkit [54965] by Nate Chapin
  • 1 edit
    2 adds in trunk/LayoutTests

2010-02-18 Nate Chapin <Nate Chapin>

Reviewed by Eric Seidel.

Actually submitting test for ​https://bugs.webkit.org/show_bug.cgi?id=34899 this time.

  • fast/dom/Window/window-event-override-no-crash-expected.txt: Added.
  • fast/dom/Window/window-event-override-no-crash.html: Added.
9:04 AM Changeset in webkit [54964] by Nate Chapin
  • 5 edits in trunk

2010-02-18 Nate Chapin <Nate Chapin>

Reviewed by Eric Seidel.

[V8] Correctly handle the case where the event field on the
global object is a v8::Object, but not a DOM wrapper.

​https://bugs.webkit.org/show_bug.cgi?id=34899

Test: fast/dom/Window/window-event-override-no-crash.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::isValidDOMObject): (WebCore::V8DOMWrapper::isWrapperOfType):
  • bindings/v8/V8DOMWrapper.h:
8:56 AM Changeset in webkit [54963] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-02-18 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed, Qt build fix.

  • inspector/front-end/WebKit.qrc:
8:12 AM Changeset in webkit [54962] by pfeldman@chromium.org
  • 11 edits
    13 adds
    1 delete in trunk/WebCore

2010-02-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement evaluate-on-hover for scripts panel.

​https://bugs.webkit.org/show_bug.cgi?id=35003


  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Images/gearButtonGlyph.png: Added.
  • inspector/front-end/Images/popoverArrows.png: Added.
  • inspector/front-end/Images/popoverBackground.png: Added.
  • inspector/front-end/Images/thumbActiveHoriz.png: Added.
  • inspector/front-end/Images/thumbActiveVert.png: Added.
  • inspector/front-end/Images/thumbHoriz.png: Added.
  • inspector/front-end/Images/thumbHoverHoriz.png: Added.
  • inspector/front-end/Images/thumbHoverVert.png: Added.
  • inspector/front-end/Images/thumbVert.png: Added.
  • inspector/front-end/Images/trackHoriz.png: Added.
  • inspector/front-end/Images/trackVert.png: Added.
  • inspector/front-end/Popup.js: (WebInspector.Popup): (WebInspector.Popup.prototype.show): (WebInspector.Popup.prototype.hide): (WebInspector.Popup.prototype._positionElement):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype._scroll): (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._mouseUp): (WebInspector.SourceFrame.prototype._mouseMove): (WebInspector.SourceFrame.prototype._mouseOut): (WebInspector.SourceFrame.prototype._resetHoverTimer): (WebInspector.SourceFrame.prototype._hidePopup): (WebInspector.SourceFrame.prototype._mouseHover): (WebInspector.SourceFrame.prototype._showPopup.showTextPopup): (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup.evaluateCallback): (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.HoverPropertiesSection): (WebInspector.HoverPropertiesSection.prototype.update):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._paintLine):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspectorSyntaxHighlight.css:
  • inspector/front-end/popover.css: Added.
8:03 AM Changeset in webkit [54961] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Skip the following tests because of missing eventSender.textZoomIn():

svg/zoom/text/absolute-sized-document-no-scrollbars.svg
svg/zoom/text/absolute-sized-document-scrollbars.svg
svg/zoom/text/relative-sized-document-scrollbars.svg
svg/zoom/text/zoom-foreignObject.svg
svg/zoom/text/zoom-hixie-mixed-008.xml
svg/zoom/text/zoom-hixie-mixed-009.xml
svg/zoom/text/zoom-hixie-rendering-model-004.xhtml
svg/zoom/text/zoom-svg-float-border-padding.xml

  • platform/qt/Skipped:
7:55 AM UsingGitWithWebKit edited by vestbo@webkit.org
(diff)
7:54 AM UsingGitWithWebKit edited by vestbo@webkit.org
(diff)
7:51 AM Changeset in webkit [54960] by vestbo@webkit.org
  • 4 edits in trunk

Teach resolve-ChangeLogs to act as a merge-driver for Git

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=28721

To enable automatic merging of ChangeLog files, use the following command:

git config merge.changelog.driver "resolve-ChangeLogs --merge-driver %O %A %B"

The driver always works in "downstream" merge mode, meaning
it will always put the user's changelog entries on top.

  • Scripts/resolve-ChangeLogs:
  • .gitattributes: Add instruction to use merge-driver for ChangeLogs
6:27 AM Changeset in webkit [54959] by eric@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-02-18 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] WebKitDownload documentation is incomplete
​https://bugs.webkit.org/show_bug.cgi?id=35018

Concretely the error signal was undocumented. Also two relevant enums
were not included.

  • docs/webkitgtk-sections.txt:
  • docs/webkitgtk.types:
  • webkit/webkitdownload.cpp: (webkit_download_class_init):
6:22 AM Changeset in webkit [54958] by benm@google.com
  • 2 edits in trunk/WebCore

2010-02-18 Ben Murdoch <​benm@google.com>

Reviewed by Jeremy Orlow.

[v8] Complete upstreaming of V8 Touch Event bindings
​https://bugs.webkit.org/show_bug.cgi?id=35094

No new tests required.

  • bindings/v8/V8Index.cpp: Add generated touch event headers.
6:12 AM Changeset in webkit [54957] by steveblock@google.com
  • 3 edits in trunk/WebCore

2010-02-18 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Updates Android V8 build to use DerivedSourcesAllInOne.cpp
​https://bugs.webkit.org/show_bug.cgi?id=35083

No new tests, build fix only.

  • Android.derived.v8bindings.mk:
  • Android.v8bindings.mk:
5:32 AM Changeset in webkit [54956] by kov@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2009-12-05 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Eric Seidel.

Enable running of GTK+ API tests.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-gtk-tests: Added.
5:27 AM Changeset in webkit [54955] by kov@webkit.org
  • 4 edits in trunk

2010-02-18 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

fast/frames/iframe-reparenting.html crashing on GTK Debug bots
​https://bugs.webkit.org/show_bug.cgi?id=35081

Check that the client is alive after every call to it, since any
of them could cause the load to be cancelled, and the client to go
away.

This is much better than protecting a specific subclass of
ResourceHandleClient (ResourceLoader), which makes us fail when
any other client is used.

Test: fast/frames/iframe-reparenting.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
4:00 AM Changeset in webkit [54954] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
​https://bugs.webkit.org/show_bug.cgi?id=35086

fast/xmlhttprequest/xmlhttprequest-no-file-access.html cause
this fail indirectly, but both of them pass in separated DRT.

  • platform/qt/Skipped: fast/xmlhttprequest/xmlhttprequest-no-file-access.html

skipped until fix to make buildbot happy.

3:46 AM Changeset in webkit [54953] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2010-02-18 Philippe Normand <​pnormand@igalia.com>

Not reviewed, adding a GTK layout test result for a new test
added in r54926.

  • platform/gtk/fast/css/first-letter-first-line-hover-expected.txt: Added.
3:37 AM Changeset in webkit [54952] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-02-18 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

plugins/iframe-shims.html crashing on GTK Debug bots
​https://bugs.webkit.org/show_bug.cgi?id=35085

  • platform/gtk/Skipped: Skip crashing tests.
2:29 AM Changeset in webkit [54951] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-02-18 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

fast/frames/iframe-reparenting.html crashing on GTK Debug bots
​https://bugs.webkit.org/show_bug.cgi?id=35081

  • platform/gtk/Skipped: Skip crashing test.
2:21 AM Changeset in webkit [54950] by benm@google.com
  • 9 edits in trunk/WebCore

[v8] [Android] V8 bindings for touch events are missing.
​https://bugs.webkit.org/show_bug.cgi?id=33795

Reviewed by Nate Chapin.

No new tests as this just enables touch events in V8. Existing touch tests suffice.

  • WebCore.gypi: Add Touch idl files.
  • bindings/scripts/CodeGeneratorV8.pm: Add TouchList to typeCanFailConversion map.
  • bindings/v8/DOMObjectsInclude.h: Add touch headers.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Add touch generated bindings.
  • bindings/v8/V8Index.h: Add touch DOM object types.
  • bindings/v8/custom/V8EventCustom.cpp: Add conversion of event to touch event.
  • Android.derived.jscbindings.mk: Add the touch derived sources to the makefile.
  • Android.derived.v8bindings.mk: Add the touch derived sources to the makefile.
2:07 AM Changeset in webkit [54949] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-02-18 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

fast/css/font-face-opentype.html crashing on GTK bots
​https://bugs.webkit.org/show_bug.cgi?id=35080

  • platform/gtk/Skipped: Skip crashing test.
1:27 AM Changeset in webkit [54948] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-02-18 Jay Campan <​jcampan@google.com>

Reviewed by Adam Barth.

Exposing the title in WebDocument.

​https://bugs.webkit.org/show_bug.cgi?id=35058

  • public/WebDocument.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::title):
1:17 AM Changeset in webkit [54947] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-02-18 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Adam Barth.

debug-safari doesn't pass --debug option to gdb-safari on MacOSX
​https://bugs.webkit.org/show_bug.cgi?id=34411

  • Scripts/webkitdirs.pm:
1:10 AM Changeset in webkit [54946] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-18 William Chan <​willchan@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=35071
Disable loader limiting of requests per host for the chromium port.

No tests because we're only changing a constant.

  • platform/network/chromium/ResourceRequest.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
12:54 AM Changeset in webkit [54945] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-02-18 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
​https://bugs.webkit.org/show_bug.cgi?id=35053

  • Scripts/webkitpy/layout_tests/port/base.py: Add script_path() function for finding scripts.
  • Scripts/webkitpy/layout_tests/port/chromium.py: Remove unused argument.
  • Scripts/webkitpy/layout_tests/port/mac.py:
    • Make sure that calling webkit-build-directory works even if Scripts/ is not in the user's path.
    • Call build-dumprendertree (and make sure it succeeds) before running the tests.
12:38 AM Changeset in webkit [54944] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-02-18 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Add the promised test for the unique ​file:// origins support.
See ​https://bugs.webkit.org/show_bug.cgi?id=34778 for more details.

  • fast/xmlhttprequest/xmlhttprequest-no-file-access.html: Added.
  • fast/xmlhttprequest/resources/xmlhttprequest-no-file-access-real.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt: Added.
12:36 AM Changeset in webkit [54943] by sfalken@apple.com
  • 9 edits in trunk

WebKit on Windows needs a mechanism to listen for WM_SETTINGCHANGED messages
​https://bugs.webkit.org/show_bug.cgi?id=35076

Reviewed by Dan Bernstein.

WebKit/win:

  • WebKit.vcproj/WebKit.def: Added WebKitSystemParameterChanged.
  • WebKit.vcproj/WebKit_debug.def: Added WebKitSystemParameterChanged.
  • WebKitGraphics.cpp:

(WebKitSystemParameterChanged): Call through to wkSystemFontSmoothingChanged for font smoothing changes.

  • WebKitGraphics.h: Added WebKitSystemParameterChanged.

WebKitLibraries:

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib: Updated to add wkSystemFontSmoothingChanged.
  • win/lib/WebKitSystemInterface_debug.lib: Updated to add wkSystemFontSmoothingChanged.
12:17 AM Changeset in webkit [54942] by hamaji@chromium.org
  • 6 edits in trunk/WebKitTools

2010-02-16 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Refactored check-webkit-style's ProcessorOptions class into two
classes. This revision contains no new functionality.

​https://bugs.webkit.org/show_bug.cgi?id=34674

Divided the ProcessorOptions class into a CommandOptionValues
class (the result of parsing the command-line options) and
a StyleCheckerConfiguration class (which configures the main
StyleChecker).

  • Scripts/check-webkit-style:
    • Updated main() to convert the parsed command option values to a StyleCheckConfiguration instance prior to constructing a StyleChecker.
  • Scripts/webkitpy/style/checker.py:
    • Added check_webkit_style_configuration() to convert a CommandOptionValues instance into a StyleCheckerConfiguration instance.
    • Renamed the ProcessorOptions class to CommandOptionValues.
    • In the CommandOptionValues class--
      • Replaced the filter_configuration attribute with the simpler filter_rules attribute.
      • Removed the max_reports_per_error attribute.
      • Moved the is_reportable() method to the new StyleCheckerConfiguration class.
    • Removed the base_filter_rules attribute from the DefaultCommandOptionValues class.
    • In the ArgumentParser class--
      • Added base_filter_rules to the constructor.
      • Changed the parse() method to return a CommandOptionValues instance instead of a ProcessorOptions instance.
    • Created a StyleCheckerConfiguration class.
      • Added the data attributes max_reports_per_category, stderr_write, and verbosity.
      • Added is_reportable() (moved from the ProcessorOptions class) and write_style_error() (moved from the DefaultStyleErrorHandler class).
    • In the StyleChecker class--
      • Replaced the ProcessorOptions options attribute with the StyleCheckerConfiguration _configuration attribute.
      • Removed the _stderr_write attribute.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the existing unit test classes as necessary.
    • Added a StyleCheckerConfigurationTest class.
  • Scripts/webkitpy/style/error_handlers.py:
    • Updated the DefaultStyleErrorHandler class to accept a StyleCheckerConfiguration instance instead of a ProcessorOptions instance and an stderr_write method.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Updated the unit test classes as necessary.
  • Scripts/webkitpy/style/filter.py:
    • Addressed the FIXME in the FilterConfiguration class to change the user_rules attribute to _user_rules (since it is now accessed only internally).
  • Scripts/webkitpy/style/filter_unittest.py:
    • Updated to reflect the change from user_rules to _user_rules.
12:17 AM Changeset in webkit [54941] by tony@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-02-18 Tony Chang <​tony@chromium.org>

Not reviewed, adding a QT layout test result for a new test
added in r54932.

  • platform/qt/editing/pasteboard/page-zoom-expected.txt: Copied from LayoutTests/platform/gtk/editing/pasteboard/page-zoom-expected.txt.
12:06 AM Changeset in webkit [54940] by xan@webkit.org
  • 8 edits in trunk/WebCore

2010-02-18 Xan Lopez <​xlopez@igalia.com>

Reviewed by Eric Seidel.

[Linux] Webkit incompatible with Java plugins
​https://bugs.webkit.org/show_bug.cgi?id=24912

The NP Version supported by WebKit is at the moment hardcoded in
PluginPackage.cpp (to 24), but not all backends actually implement
the methods needed to claim this. Introduce a new method to be
implemented by each backend where the maximum supported version
can be specified, and set the GTK+ port NPVersion to 19. This
fixes an instantaneous crasher in the Sun Java NPAPI plugin.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::initializeBrowserFuncs):
  • plugins/PluginPackage.h:
  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::NPVersion):
  • plugins/mac/PluginPackageMac.cpp: (WebCore::PluginPackage::NPVersion):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::NPVersion):
  • plugins/symbian/PluginPackageSymbian.cpp: (WebCore::PluginPackage::NPVersion):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::NPVersion):
12:04 AM Changeset in webkit [54939] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] editing/pasteboard/page-zoom.html fails
​https://bugs.webkit.org/show_bug.cgi?id=35077

  • platform/qt/Skipped: editing/pasteboard/page-zoom.html skipped until fix.
Note: See TracTimeline for information about the timeline view.